{"action":"closed","number":1422,"pull_request":{"url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1422","id":169126157,"html_url":"https://github.com/MycroftAI/mycroft-core/pull/1422","diff_url":"https://github.com/MycroftAI/mycroft-core/pull/1422.diff","patch_url":"https://github.com/MycroftAI/mycroft-core/pull/1422.patch","issue_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1422","number":1422,"state":"closed","locked":false,"title":"Make keywords per skill to fix overlapping keyword names","user":{"login":"forslund","id":804543,"avatar_url":"https://avatars0.githubusercontent.com/u/804543?v=4","gravatar_id":"","url":"https://api.github.com/users/forslund","html_url":"https://github.com/forslund","followers_url":"https://api.github.com/users/forslund/followers","following_url":"https://api.github.com/users/forslund/following{/other_user}","gists_url":"https://api.github.com/users/forslund/gists{/gist_id}","starred_url":"https://api.github.com/users/forslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forslund/subscriptions","organizations_url":"https://api.github.com/users/forslund/orgs","repos_url":"https://api.github.com/users/forslund/repos","events_url":"https://api.github.com/users/forslund/events{/privacy}","received_events_url":"https://api.github.com/users/forslund/received_events","type":"User","site_admin":false},"body":"## Description\r\nConvert keyword names to unique names by prepending the keyword with a\r\nletter string derived from the unique skill id.\r\n\r\nThis commit modifies required keywords, optional keywords, one_of\r\nkeywords and regex matches.\r\n\r\nThis also munges the context keyword when that is sent to match the\r\nintent correctly.\r\n\r\n## How to test\r\nThings to test location regex overlaps, \"what is the time for london\" should work but \"what's the weather for london should fail.\r\n\r\nContext internal to skills should still work, for example the wikipedia skill \"Tell me about donald duck\" followed by \"tell me more\"\r\n\r\n## Contributor license agreement signed?\r\nCLA [Yes]","created_at":"2018-02-14T14:36:21Z","updated_at":"2018-02-15T08:57:03Z","closed_at":"2018-02-15T08:57:03Z","merged_at":"2018-02-15T08:57:03Z","merge_commit_sha":"ed6ab224c91911a90e237e4dbd9f9954cecfb080","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":664720248,"url":"https://api.github.com/repos/MycroftAI/mycroft-core/labels/CLA:%20Yes","name":"CLA: Yes","color":"0e8a16","default":false},{"id":572162072,"url":"https://api.github.com/repos/MycroftAI/mycroft-core/labels/tagged%20for%20review%20and%20potential%20merge","name":"tagged for review and potential merge","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1422/commits","review_comments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1422/comments","review_comment_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1422/comments","statuses_url":"https://api.github.com/repos/MycroftAI/mycroft-core/statuses/23302b60d91c5bbdb284934cb9354967f4f2a11e","head":{"label":"forslund:feature/munge-keywords","ref":"feature/munge-keywords","sha":"23302b60d91c5bbdb284934cb9354967f4f2a11e","user":{"login":"forslund","id":804543,"avatar_url":"https://avatars0.githubusercontent.com/u/804543?v=4","gravatar_id":"","url":"https://api.github.com/users/forslund","html_url":"https://github.com/forslund","followers_url":"https://api.github.com/users/forslund/followers","following_url":"https://api.github.com/users/forslund/following{/other_user}","gists_url":"https://api.github.com/users/forslund/gists{/gist_id}","starred_url":"https://api.github.com/users/forslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forslund/subscriptions","organizations_url":"https://api.github.com/users/forslund/orgs","repos_url":"https://api.github.com/users/forslund/repos","events_url":"https://api.github.com/users/forslund/events{/privacy}","received_events_url":"https://api.github.com/users/forslund/received_events","type":"User","site_admin":false},"repo":{"id":59365230,"name":"mycroft-core","full_name":"forslund/mycroft-core","owner":{"login":"forslund","id":804543,"avatar_url":"https://avatars0.githubusercontent.com/u/804543?v=4","gravatar_id":"","url":"https://api.github.com/users/forslund","html_url":"https://github.com/forslund","followers_url":"https://api.github.com/users/forslund/followers","following_url":"https://api.github.com/users/forslund/following{/other_user}","gists_url":"https://api.github.com/users/forslund/gists{/gist_id}","starred_url":"https://api.github.com/users/forslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forslund/subscriptions","organizations_url":"https://api.github.com/users/forslund/orgs","repos_url":"https://api.github.com/users/forslund/repos","events_url":"https://api.github.com/users/forslund/events{/privacy}","received_events_url":"https://api.github.com/users/forslund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/forslund/mycroft-core","description":"Mycroft Core, the Mycroft Artificial Intelligence platform.","fork":true,"url":"https://api.github.com/repos/forslund/mycroft-core","forks_url":"https://api.github.com/repos/forslund/mycroft-core/forks","keys_url":"https://api.github.com/repos/forslund/mycroft-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forslund/mycroft-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forslund/mycroft-core/teams","hooks_url":"https://api.github.com/repos/forslund/mycroft-core/hooks","issue_events_url":"https://api.github.com/repos/forslund/mycroft-core/issues/events{/number}","events_url":"https://api.github.com/repos/forslund/mycroft-core/events","assignees_url":"https://api.github.com/repos/forslund/mycroft-core/assignees{/user}","branches_url":"https://api.github.com/repos/forslund/mycroft-core/branches{/branch}","tags_url":"https://api.github.com/repos/forslund/mycroft-core/tags","blobs_url":"https://api.github.com/repos/forslund/mycroft-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forslund/mycroft-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forslund/mycroft-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/forslund/mycroft-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forslund/mycroft-core/statuses/{sha}","languages_url":"https://api.github.com/repos/forslund/mycroft-core/languages","stargazers_url":"https://api.github.com/repos/forslund/mycroft-core/stargazers","contributors_url":"https://api.github.com/repos/forslund/mycroft-core/contributors","subscribers_url":"https://api.github.com/repos/forslund/mycroft-core/subscribers","subscription_url":"https://api.github.com/repos/forslund/mycroft-core/subscription","commits_url":"https://api.github.com/repos/forslund/mycroft-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/forslund/mycroft-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/forslund/mycroft-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/forslund/mycroft-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/forslund/mycroft-core/contents/{+path}","compare_url":"https://api.github.com/repos/forslund/mycroft-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forslund/mycroft-core/merges","archive_url":"https://api.github.com/repos/forslund/mycroft-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forslund/mycroft-core/downloads","issues_url":"https://api.github.com/repos/forslund/mycroft-core/issues{/number}","pulls_url":"https://api.github.com/repos/forslund/mycroft-core/pulls{/number}","milestones_url":"https://api.github.com/repos/forslund/mycroft-core/milestones{/number}","notifications_url":"https://api.github.com/repos/forslund/mycroft-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forslund/mycroft-core/labels{/name}","releases_url":"https://api.github.com/repos/forslund/mycroft-core/releases{/id}","deployments_url":"https://api.github.com/repos/forslund/mycroft-core/deployments","created_at":"2016-05-21T14:51:13Z","updated_at":"2016-05-21T14:51:14Z","pushed_at":"2018-02-15T08:40:15Z","git_url":"git://github.com/forslund/mycroft-core.git","ssh_url":"git@github.com:forslund/mycroft-core.git","clone_url":"https://github.com/forslund/mycroft-core.git","svn_url":"https://github.com/forslund/mycroft-core","homepage":"https://mycroft.ai","size":78281,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"MycroftAI:dev","ref":"dev","sha":"5327b35f31516875f907385ccdd62b477009b4e5","user":{"login":"MycroftAI","id":14171097,"avatar_url":"https://avatars0.githubusercontent.com/u/14171097?v=4","gravatar_id":"","url":"https://api.github.com/users/MycroftAI","html_url":"https://github.com/MycroftAI","followers_url":"https://api.github.com/users/MycroftAI/followers","following_url":"https://api.github.com/users/MycroftAI/following{/other_user}","gists_url":"https://api.github.com/users/MycroftAI/gists{/gist_id}","starred_url":"https://api.github.com/users/MycroftAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MycroftAI/subscriptions","organizations_url":"https://api.github.com/users/MycroftAI/orgs","repos_url":"https://api.github.com/users/MycroftAI/repos","events_url":"https://api.github.com/users/MycroftAI/events{/privacy}","received_events_url":"https://api.github.com/users/MycroftAI/received_events","type":"Organization","site_admin":false},"repo":{"id":59299524,"name":"mycroft-core","full_name":"MycroftAI/mycroft-core","owner":{"login":"MycroftAI","id":14171097,"avatar_url":"https://avatars0.githubusercontent.com/u/14171097?v=4","gravatar_id":"","url":"https://api.github.com/users/MycroftAI","html_url":"https://github.com/MycroftAI","followers_url":"https://api.github.com/users/MycroftAI/followers","following_url":"https://api.github.com/users/MycroftAI/following{/other_user}","gists_url":"https://api.github.com/users/MycroftAI/gists{/gist_id}","starred_url":"https://api.github.com/users/MycroftAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MycroftAI/subscriptions","organizations_url":"https://api.github.com/users/MycroftAI/orgs","repos_url":"https://api.github.com/users/MycroftAI/repos","events_url":"https://api.github.com/users/MycroftAI/events{/privacy}","received_events_url":"https://api.github.com/users/MycroftAI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MycroftAI/mycroft-core","description":"Mycroft Core, the Mycroft Artificial Intelligence platform.","fork":false,"url":"https://api.github.com/repos/MycroftAI/mycroft-core","forks_url":"https://api.github.com/repos/MycroftAI/mycroft-core/forks","keys_url":"https://api.github.com/repos/MycroftAI/mycroft-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MycroftAI/mycroft-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MycroftAI/mycroft-core/teams","hooks_url":"https://api.github.com/repos/MycroftAI/mycroft-core/hooks","issue_events_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/events{/number}","events_url":"https://api.github.com/repos/MycroftAI/mycroft-core/events","assignees_url":"https://api.github.com/repos/MycroftAI/mycroft-core/assignees{/user}","branches_url":"https://api.github.com/repos/MycroftAI/mycroft-core/branches{/branch}","tags_url":"https://api.github.com/repos/MycroftAI/mycroft-core/tags","blobs_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MycroftAI/mycroft-core/statuses/{sha}","languages_url":"https://api.github.com/repos/MycroftAI/mycroft-core/languages","stargazers_url":"https://api.github.com/repos/MycroftAI/mycroft-core/stargazers","contributors_url":"https://api.github.com/repos/MycroftAI/mycroft-core/contributors","subscribers_url":"https://api.github.com/repos/MycroftAI/mycroft-core/subscribers","subscription_url":"https://api.github.com/repos/MycroftAI/mycroft-core/subscription","commits_url":"https://api.github.com/repos/MycroftAI/mycroft-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MycroftAI/mycroft-core/contents/{+path}","compare_url":"https://api.github.com/repos/MycroftAI/mycroft-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MycroftAI/mycroft-core/merges","archive_url":"https://api.github.com/repos/MycroftAI/mycroft-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MycroftAI/mycroft-core/downloads","issues_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues{/number}","pulls_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls{/number}","milestones_url":"https://api.github.com/repos/MycroftAI/mycroft-core/milestones{/number}","notifications_url":"https://api.github.com/repos/MycroftAI/mycroft-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MycroftAI/mycroft-core/labels{/name}","releases_url":"https://api.github.com/repos/MycroftAI/mycroft-core/releases{/id}","deployments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/deployments","created_at":"2016-05-20T14:11:07Z","updated_at":"2018-02-15T04:04:13Z","pushed_at":"2018-02-15T08:57:03Z","git_url":"git://github.com/MycroftAI/mycroft-core.git","ssh_url":"git@github.com:MycroftAI/mycroft-core.git","clone_url":"https://github.com/MycroftAI/mycroft-core.git","svn_url":"https://github.com/MycroftAI/mycroft-core","homepage":"https://mycroft.ai","size":94254,"stargazers_count":2013,"watchers_count":2013,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":494,"mirror_url":null,"archived":false,"open_issues_count":172,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":494,"open_issues":172,"watchers":2013,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1422"},"html":{"href":"https://github.com/MycroftAI/mycroft-core/pull/1422"},"issue":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1422"},"comments":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1422/comments"},"review_comments":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1422/comments"},"review_comment":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1422/commits"},"statuses":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/statuses/23302b60d91c5bbdb284934cb9354967f4f2a11e"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"forslund","id":804543,"avatar_url":"https://avatars0.githubusercontent.com/u/804543?v=4","gravatar_id":"","url":"https://api.github.com/users/forslund","html_url":"https://github.com/forslund","followers_url":"https://api.github.com/users/forslund/followers","following_url":"https://api.github.com/users/forslund/following{/other_user}","gists_url":"https://api.github.com/users/forslund/gists{/gist_id}","starred_url":"https://api.github.com/users/forslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forslund/subscriptions","organizations_url":"https://api.github.com/users/forslund/orgs","repos_url":"https://api.github.com/users/forslund/repos","events_url":"https://api.github.com/users/forslund/events{/privacy}","received_events_url":"https://api.github.com/users/forslund/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":4,"additions":215,"deletions":87,"changed_files":3}}
{"actor":{"display_login":"forslund"}}