{"action":"created","comment":{"url":"https://api.github.com/repos/yonadev/yona-server/pulls/comments/213436050","pull_request_review_id":150272309,"id":213436050,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzQzNjA1MA==","diff_hunk":"@@ -48,7 +44,12 @@\n @Service\n public class DeviceService\n {\n-\tprivate static final String ANDROID_MIN_APP_VERSION = \"1.0.0\";\n+\t// When updating the minimum version, be sure to update the version code and the version.\n+\t// Minimal technical version codes, used to verify the minimum\n+\tprivate static final int ANDROID_MIN_APP_VERSION_CODE = 5;","path":"core/src/main/java/nu/yona/server/device/service/DeviceService.java","position":25,"original_position":25,"commit_id":"83e35e603bec048a38a7977929d2562c536fb0f1","original_commit_id":"83e35e603bec048a38a7977929d2562c536fb0f1","user":{"login":"Bert-R","id":7149792,"node_id":"MDQ6VXNlcjcxNDk3OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/7149792?v=4","gravatar_id":"","url":"https://api.github.com/users/Bert-R","html_url":"https://github.com/Bert-R","followers_url":"https://api.github.com/users/Bert-R/followers","following_url":"https://api.github.com/users/Bert-R/following{/other_user}","gists_url":"https://api.github.com/users/Bert-R/gists{/gist_id}","starred_url":"https://api.github.com/users/Bert-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bert-R/subscriptions","organizations_url":"https://api.github.com/users/Bert-R/orgs","repos_url":"https://api.github.com/users/Bert-R/repos","events_url":"https://api.github.com/users/Bert-R/events{/privacy}","received_events_url":"https://api.github.com/users/Bert-R/received_events","type":"User","site_admin":false},"body":"Yes. The current released version is 39, so we can be confident that nobody uses 5 or earlier. In case someone is, then it would be right to given an error.\r\n\r\nHowever... even version code 39 does not send the open app event. That's only recently added to the Android app, as part of 1.1.","created_at":"2018-08-28T19:04:28Z","updated_at":"2018-08-28T19:04:28Z","html_url":"https://github.com/yonadev/yona-server/pull/491#discussion_r213436050","pull_request_url":"https://api.github.com/repos/yonadev/yona-server/pulls/491","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/yonadev/yona-server/pulls/comments/213436050"},"html":{"href":"https://github.com/yonadev/yona-server/pull/491#discussion_r213436050"},"pull_request":{"href":"https://api.github.com/repos/yonadev/yona-server/pulls/491"}},"in_reply_to_id":213430099},"pull_request":{"url":"https://api.github.com/repos/yonadev/yona-server/pulls/491","id":207766883,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzY2ODgz","html_url":"https://github.com/yonadev/yona-server/pull/491","diff_url":"https://github.com/yonadev/yona-server/pull/491.diff","patch_url":"https://github.com/yonadev/yona-server/pull/491.patch","issue_url":"https://api.github.com/repos/yonadev/yona-server/issues/491","number":491,"state":"closed","locked":false,"title":"YD-584 Add app version code","user":{"login":"Bert-R","id":7149792,"node_id":"MDQ6VXNlcjcxNDk3OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/7149792?v=4","gravatar_id":"","url":"https://api.github.com/users/Bert-R","html_url":"https://github.com/Bert-R","followers_url":"https://api.github.com/users/Bert-R/followers","following_url":"https://api.github.com/users/Bert-R/following{/other_user}","gists_url":"https://api.github.com/users/Bert-R/gists{/gist_id}","starred_url":"https://api.github.com/users/Bert-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bert-R/subscriptions","organizations_url":"https://api.github.com/users/Bert-R/orgs","repos_url":"https://api.github.com/users/Bert-R/repos","events_url":"https://api.github.com/users/Bert-R/events{/privacy}","received_events_url":"https://api.github.com/users/Bert-R/received_events","type":"User","site_admin":false},"body":"This coexists with the app version. The app version is a free-text string that is user readable, the app version code is an integer that is incremented for each and every new build of the app, across releases.\r\n\r\nThe legacy test for the open app event in DeviceTest.groovy has been updated to also create the user in the legacy way.","created_at":"2018-08-11T09:31:37Z","updated_at":"2018-08-28T19:04:28Z","closed_at":"2018-08-11T10:50:45Z","merged_at":"2018-08-11T10:50:45Z","merge_commit_sha":"478607b450cd3d77523c4a0957d1880e2b22c25f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yonadev/yona-server/pulls/491/commits","review_comments_url":"https://api.github.com/repos/yonadev/yona-server/pulls/491/comments","review_comment_url":"https://api.github.com/repos/yonadev/yona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yonadev/yona-server/issues/491/comments","statuses_url":"https://api.github.com/repos/yonadev/yona-server/statuses/83e35e603bec048a38a7977929d2562c536fb0f1","head":{"label":"yonadev:yd-584-add-version-code","ref":"yd-584-add-version-code","sha":"83e35e603bec048a38a7977929d2562c536fb0f1","user":{"login":"yonadev","id":14901571,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTAxNTcx","avatar_url":"https://avatars2.githubusercontent.com/u/14901571?v=4","gravatar_id":"","url":"https://api.github.com/users/yonadev","html_url":"https://github.com/yonadev","followers_url":"https://api.github.com/users/yonadev/followers","following_url":"https://api.github.com/users/yonadev/following{/other_user}","gists_url":"https://api.github.com/users/yonadev/gists{/gist_id}","starred_url":"https://api.github.com/users/yonadev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonadev/subscriptions","organizations_url":"https://api.github.com/users/yonadev/orgs","repos_url":"https://api.github.com/users/yonadev/repos","events_url":"https://api.github.com/users/yonadev/events{/privacy}","received_events_url":"https://api.github.com/users/yonadev/received_events","type":"Organization","site_admin":false},"repo":{"id":43589108,"node_id":"MDEwOlJlcG9zaXRvcnk0MzU4OTEwOA==","name":"yona-server","full_name":"yonadev/yona-server","owner":{"login":"yonadev","id":14901571,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTAxNTcx","avatar_url":"https://avatars2.githubusercontent.com/u/14901571?v=4","gravatar_id":"","url":"https://api.github.com/users/yonadev","html_url":"https://github.com/yonadev","followers_url":"https://api.github.com/users/yonadev/followers","following_url":"https://api.github.com/users/yonadev/following{/other_user}","gists_url":"https://api.github.com/users/yonadev/gists{/gist_id}","starred_url":"https://api.github.com/users/yonadev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonadev/subscriptions","organizations_url":"https://api.github.com/users/yonadev/orgs","repos_url":"https://api.github.com/users/yonadev/repos","events_url":"https://api.github.com/users/yonadev/events{/privacy}","received_events_url":"https://api.github.com/users/yonadev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yonadev/yona-server","description":"Yona Server","fork":false,"url":"https://api.github.com/repos/yonadev/yona-server","forks_url":"https://api.github.com/repos/yonadev/yona-server/forks","keys_url":"https://api.github.com/repos/yonadev/yona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yonadev/yona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yonadev/yona-server/teams","hooks_url":"https://api.github.com/repos/yonadev/yona-server/hooks","issue_events_url":"https://api.github.com/repos/yonadev/yona-server/issues/events{/number}","events_url":"https://api.github.com/repos/yonadev/yona-server/events","assignees_url":"https://api.github.com/repos/yonadev/yona-server/assignees{/user}","branches_url":"https://api.github.com/repos/yonadev/yona-server/branches{/branch}","tags_url":"https://api.github.com/repos/yonadev/yona-server/tags","blobs_url":"https://api.github.com/repos/yonadev/yona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yonadev/yona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yonadev/yona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/yonadev/yona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yonadev/yona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/yonadev/yona-server/languages","stargazers_url":"https://api.github.com/repos/yonadev/yona-server/stargazers","contributors_url":"https://api.github.com/repos/yonadev/yona-server/contributors","subscribers_url":"https://api.github.com/repos/yonadev/yona-server/subscribers","subscription_url":"https://api.github.com/repos/yonadev/yona-server/subscription","commits_url":"https://api.github.com/repos/yonadev/yona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/yonadev/yona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/yonadev/yona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/yonadev/yona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/yonadev/yona-server/contents/{+path}","compare_url":"https://api.github.com/repos/yonadev/yona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yonadev/yona-server/merges","archive_url":"https://api.github.com/repos/yonadev/yona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yonadev/yona-server/downloads","issues_url":"https://api.github.com/repos/yonadev/yona-server/issues{/number}","pulls_url":"https://api.github.com/repos/yonadev/yona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/yonadev/yona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/yonadev/yona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yonadev/yona-server/labels{/name}","releases_url":"https://api.github.com/repos/yonadev/yona-server/releases{/id}","deployments_url":"https://api.github.com/repos/yonadev/yona-server/deployments","created_at":"2015-10-03T05:33:54Z","updated_at":"2018-08-11T10:50:47Z","pushed_at":"2018-08-28T18:54:00Z","git_url":"git://github.com/yonadev/yona-server.git","ssh_url":"git@github.com:yonadev/yona-server.git","clone_url":"https://github.com/yonadev/yona-server.git","svn_url":"https://github.com/yonadev/yona-server","homepage":null,"size":6584,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":9,"open_issues":1,"watchers":7,"default_branch":"master"}},"base":{"label":"yonadev:master","ref":"master","sha":"a35f648e9879587971237333fa7a4b0e8eacab9b","user":{"login":"yonadev","id":14901571,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTAxNTcx","avatar_url":"https://avatars2.githubusercontent.com/u/14901571?v=4","gravatar_id":"","url":"https://api.github.com/users/yonadev","html_url":"https://github.com/yonadev","followers_url":"https://api.github.com/users/yonadev/followers","following_url":"https://api.github.com/users/yonadev/following{/other_user}","gists_url":"https://api.github.com/users/yonadev/gists{/gist_id}","starred_url":"https://api.github.com/users/yonadev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonadev/subscriptions","organizations_url":"https://api.github.com/users/yonadev/orgs","repos_url":"https://api.github.com/users/yonadev/repos","events_url":"https://api.github.com/users/yonadev/events{/privacy}","received_events_url":"https://api.github.com/users/yonadev/received_events","type":"Organization","site_admin":false},"repo":{"id":43589108,"node_id":"MDEwOlJlcG9zaXRvcnk0MzU4OTEwOA==","name":"yona-server","full_name":"yonadev/yona-server","owner":{"login":"yonadev","id":14901571,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTAxNTcx","avatar_url":"https://avatars2.githubusercontent.com/u/14901571?v=4","gravatar_id":"","url":"https://api.github.com/users/yonadev","html_url":"https://github.com/yonadev","followers_url":"https://api.github.com/users/yonadev/followers","following_url":"https://api.github.com/users/yonadev/following{/other_user}","gists_url":"https://api.github.com/users/yonadev/gists{/gist_id}","starred_url":"https://api.github.com/users/yonadev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonadev/subscriptions","organizations_url":"https://api.github.com/users/yonadev/orgs","repos_url":"https://api.github.com/users/yonadev/repos","events_url":"https://api.github.com/users/yonadev/events{/privacy}","received_events_url":"https://api.github.com/users/yonadev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yonadev/yona-server","description":"Yona Server","fork":false,"url":"https://api.github.com/repos/yonadev/yona-server","forks_url":"https://api.github.com/repos/yonadev/yona-server/forks","keys_url":"https://api.github.com/repos/yonadev/yona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yonadev/yona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yonadev/yona-server/teams","hooks_url":"https://api.github.com/repos/yonadev/yona-server/hooks","issue_events_url":"https://api.github.com/repos/yonadev/yona-server/issues/events{/number}","events_url":"https://api.github.com/repos/yonadev/yona-server/events","assignees_url":"https://api.github.com/repos/yonadev/yona-server/assignees{/user}","branches_url":"https://api.github.com/repos/yonadev/yona-server/branches{/branch}","tags_url":"https://api.github.com/repos/yonadev/yona-server/tags","blobs_url":"https://api.github.com/repos/yonadev/yona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yonadev/yona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yonadev/yona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/yonadev/yona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yonadev/yona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/yonadev/yona-server/languages","stargazers_url":"https://api.github.com/repos/yonadev/yona-server/stargazers","contributors_url":"https://api.github.com/repos/yonadev/yona-server/contributors","subscribers_url":"https://api.github.com/repos/yonadev/yona-server/subscribers","subscription_url":"https://api.github.com/repos/yonadev/yona-server/subscription","commits_url":"https://api.github.com/repos/yonadev/yona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/yonadev/yona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/yonadev/yona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/yonadev/yona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/yonadev/yona-server/contents/{+path}","compare_url":"https://api.github.com/repos/yonadev/yona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yonadev/yona-server/merges","archive_url":"https://api.github.com/repos/yonadev/yona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yonadev/yona-server/downloads","issues_url":"https://api.github.com/repos/yonadev/yona-server/issues{/number}","pulls_url":"https://api.github.com/repos/yonadev/yona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/yonadev/yona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/yonadev/yona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yonadev/yona-server/labels{/name}","releases_url":"https://api.github.com/repos/yonadev/yona-server/releases{/id}","deployments_url":"https://api.github.com/repos/yonadev/yona-server/deployments","created_at":"2015-10-03T05:33:54Z","updated_at":"2018-08-11T10:50:47Z","pushed_at":"2018-08-28T18:54:00Z","git_url":"git://github.com/yonadev/yona-server.git","ssh_url":"git@github.com:yonadev/yona-server.git","clone_url":"https://github.com/yonadev/yona-server.git","svn_url":"https://github.com/yonadev/yona-server","homepage":null,"size":6584,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":9,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yonadev/yona-server/pulls/491"},"html":{"href":"https://github.com/yonadev/yona-server/pull/491"},"issue":{"href":"https://api.github.com/repos/yonadev/yona-server/issues/491"},"comments":{"href":"https://api.github.com/repos/yonadev/yona-server/issues/491/comments"},"review_comments":{"href":"https://api.github.com/repos/yonadev/yona-server/pulls/491/comments"},"review_comment":{"href":"https://api.github.com/repos/yonadev/yona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yonadev/yona-server/pulls/491/commits"},"statuses":{"href":"https://api.github.com/repos/yonadev/yona-server/statuses/83e35e603bec048a38a7977929d2562c536fb0f1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Bert-R"}}