{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node-gyp/issues/1333","repository_url":"https://api.github.com/repos/nodejs/node-gyp","labels_url":"https://api.github.com/repos/nodejs/node-gyp/issues/1333/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node-gyp/issues/1333/comments","events_url":"https://api.github.com/repos/nodejs/node-gyp/issues/1333/events","html_url":"https://github.com/nodejs/node-gyp/pull/1333","id":273686467,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUyNDI2NTI2","number":1333,"title":"except e: --> except Exception:","user":{"login":"cclauss","id":3709715,"node_id":"MDQ6VXNlcjM3MDk3MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-14T06:57:40Z","updated_at":"2018-10-14T18:34:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node-gyp/pulls/1333","html_url":"https://github.com/nodejs/node-gyp/pull/1333","diff_url":"https://github.com/nodejs/node-gyp/pull/1333.diff","patch_url":"https://github.com/nodejs/node-gyp/pull/1333.patch"},"body":"In the current code __e__ is both undefined and unused so this code will raise an NameError exception which masks the original exception.\r\n\r\nAn alternative solution would be: __except Exception as e:__ but that still creates an unused variable.\r\n\r\n<!--\r\nThank you for your pull request. Please review the below requirements.\r\n\r\nContributor guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `npm install && npm test` passes\r\n- [ ] tests are included <!-- Bug fixes and new features should include tests -->\r\n- [ ] documentation is changed or added\r\n- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change -->\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node-gyp/issues/comments/429650466","html_url":"https://github.com/nodejs/node-gyp/pull/1333#issuecomment-429650466","issue_url":"https://api.github.com/repos/nodejs/node-gyp/issues/1333","id":429650466,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTY1MDQ2Ng==","user":{"login":"cclauss","id":3709715,"node_id":"MDQ6VXNlcjM3MDk3MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"created_at":"2018-10-14T18:34:20Z","updated_at":"2018-10-14T18:34:20Z","author_association":"CONTRIBUTOR","body":"@refack Your review please.\r\n\r\n[flake8](http://flake8.pycqa.org) testing of https://github.com/nodejs/node-gyp on Python 2.7.14\r\n\r\n$ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__\r\n```\r\n./gyp/pylib/gyp/mac_tool.py:129:12: F821 undefined name 'e'\r\n    except e:\r\n           ^\r\n./gyp/pylib/gyp/xcode_emulation.py:846:9: F821 undefined name 'cflags'\r\n        cflags.append('-F' + platform_root + '/Developer/Library/Frameworks/')\r\n        ^\r\n./gyp/pylib/gyp/generator/make.py:1642:50: F821 undefined name 'target'\r\n      print(\"WARNING: no output for\", self.type, target)\r\n                                                 ^\r\n3     F821 undefined name 'target'\r\n3\r\n```"}}
{"actor":{"display_login":"cclauss"}}