{"action":"created","issue":{"url":"https://api.github.com/repos/ZJONSSON/node-unzipper/issues/74","repository_url":"https://api.github.com/repos/ZJONSSON/node-unzipper","labels_url":"https://api.github.com/repos/ZJONSSON/node-unzipper/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/ZJONSSON/node-unzipper/issues/74/comments","events_url":"https://api.github.com/repos/ZJONSSON/node-unzipper/issues/74/events","html_url":"https://github.com/ZJONSSON/node-unzipper/pull/74","id":353698513,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjc3OTEw","number":74,"title":"Failing tests for uncaught FILE_ENDED error","user":{"login":"rhodgkins","id":1810588,"node_id":"MDQ6VXNlcjE4MTA1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/1810588?v=4","gravatar_id":"","url":"https://api.github.com/users/rhodgkins","html_url":"https://github.com/rhodgkins","followers_url":"https://api.github.com/users/rhodgkins/followers","following_url":"https://api.github.com/users/rhodgkins/following{/other_user}","gists_url":"https://api.github.com/users/rhodgkins/gists{/gist_id}","starred_url":"https://api.github.com/users/rhodgkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhodgkins/subscriptions","organizations_url":"https://api.github.com/users/rhodgkins/orgs","repos_url":"https://api.github.com/users/rhodgkins/repos","events_url":"https://api.github.com/users/rhodgkins/events{/privacy}","received_events_url":"https://api.github.com/users/rhodgkins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-24T08:51:03Z","updated_at":"2018-12-18T09:11:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ZJONSSON/node-unzipper/pulls/74","html_url":"https://github.com/ZJONSSON/node-unzipper/pull/74","diff_url":"https://github.com/ZJONSSON/node-unzipper/pull/74.diff","patch_url":"https://github.com/ZJONSSON/node-unzipper/pull/74.patch"},"body":"After moving over to the Open API (getting ready for #57) I found that I was getting uncaught errors when trying to parse a file that wasn't a zip. \r\n\r\nI've added test cases in a separate file for parse, extract and open (open is the failing one).\r\n\r\n(Possibly related to #48)"},"comment":{"url":"https://api.github.com/repos/ZJONSSON/node-unzipper/issues/comments/448149300","html_url":"https://github.com/ZJONSSON/node-unzipper/pull/74#issuecomment-448149300","issue_url":"https://api.github.com/repos/ZJONSSON/node-unzipper/issues/74","id":448149300,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODE0OTMwMA==","user":{"login":"alubbe","id":2028065,"node_id":"MDQ6VXNlcjIwMjgwNjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2028065?v=4","gravatar_id":"","url":"https://api.github.com/users/alubbe","html_url":"https://github.com/alubbe","followers_url":"https://api.github.com/users/alubbe/followers","following_url":"https://api.github.com/users/alubbe/following{/other_user}","gists_url":"https://api.github.com/users/alubbe/gists{/gist_id}","starred_url":"https://api.github.com/users/alubbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alubbe/subscriptions","organizations_url":"https://api.github.com/users/alubbe/orgs","repos_url":"https://api.github.com/users/alubbe/repos","events_url":"https://api.github.com/users/alubbe/events{/privacy}","received_events_url":"https://api.github.com/users/alubbe/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T09:11:13Z","updated_at":"2018-12-18T09:11:13Z","author_association":"NONE","body":"We have a case that involves unzipping files from users - where it's not unlikely that we get files that are corrupted or not an archive at all. @ZJONSSON should these 3 tests be green or is the current error handling behaviour correct?"}}
{"actor":{"display_login":"alubbe"}}