{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/mesonbuild/nlohmann_json/pulls/2","id":231389891,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzg5ODkx","html_url":"https://github.com/mesonbuild/nlohmann_json/pull/2","diff_url":"https://github.com/mesonbuild/nlohmann_json/pull/2.diff","patch_url":"https://github.com/mesonbuild/nlohmann_json/pull/2.patch","issue_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/issues/2","number":2,"state":"closed","locked":false,"title":"Create wrap files for nlohmann_json-3.4.0","user":{"login":"mpoquet","id":3502831,"node_id":"MDQ6VXNlcjM1MDI4MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3502831?v=4","gravatar_id":"","url":"https://api.github.com/users/mpoquet","html_url":"https://github.com/mpoquet","followers_url":"https://api.github.com/users/mpoquet/followers","following_url":"https://api.github.com/users/mpoquet/following{/other_user}","gists_url":"https://api.github.com/users/mpoquet/gists{/gist_id}","starred_url":"https://api.github.com/users/mpoquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpoquet/subscriptions","organizations_url":"https://api.github.com/users/mpoquet/orgs","repos_url":"https://api.github.com/users/mpoquet/repos","events_url":"https://api.github.com/users/mpoquet/events{/privacy}","received_events_url":"https://api.github.com/users/mpoquet/received_events","type":"User","site_admin":false},"body":"In a few words, this PR does the following.\r\n- Update the wrap to the [latest release] of nlohmann_json.\r\n- Use the released [include.zip] instead of [sources.zip], which drastically reduces the size of the downloaded content (110 MB -> 135 kB).\r\n\r\nI am very new to Meson and its wrap system, please do not hesitate to tell if the PR can be improved.\r\nI ran simple tests on the following wrap file and it seemed to work.\r\n\r\n```\r\n[wrap-file]\r\ndirectory = nlohmann_json-3.4.0\r\nlead_directory_missing = true\r\n\r\nsource_url = https://github.com/nlohmann/json/releases/download/v3.4.0/include.zip\r\nsource_filename = nlohmann-json-3.4.0.zip\r\nsource_hash = bfec46fc0cee01c509cf064d2254517e7fa80d1e7647fea37cf81d97c5682bdc\r\n\r\npatch_url = https://github.com/mpoquet/nlohmann_json/archive/3.4.0.zip\r\npatch_filename = nlohmann-json-3.4.0-wrap.zip\r\npatch_hash = dbb3afe9a93e890dafc3432954b33a368c947b15005c52533b566f3b049cb92b\r\n\r\n```\r\n\r\nPS: I tried to avoid Meson code duplication by proposing nlohmann to release a lightweight version of the sources but he was not interested (to simplify his release process, and to keep packaging issues out of the main repo).\r\n\r\n[latest release]: https://github.com/nlohmann/json/releases/tag/v3.4.0\r\n[include.zip]: https://github.com/nlohmann/json/releases/download/v3.4.0/include.zip\r\n[sources.zip]: https://github.com/nlohmann/json/archive/v3.4.0.zip","created_at":"2018-11-16T01:36:25Z","updated_at":"2018-11-16T14:51:43Z","closed_at":"2018-11-16T14:51:43Z","merged_at":null,"merge_commit_sha":"cd722e0fa27a5863cf30985da7930ac3fc20b1a2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/pulls/2/commits","review_comments_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/pulls/2/comments","review_comment_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/issues/2/comments","statuses_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/statuses/a344dd144433e2f5ce1d4edfc2a115ea1cb0ff9d","head":{"label":"mpoquet:3.4.0","ref":"3.4.0","sha":"a344dd144433e2f5ce1d4edfc2a115ea1cb0ff9d","user":{"login":"mpoquet","id":3502831,"node_id":"MDQ6VXNlcjM1MDI4MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3502831?v=4","gravatar_id":"","url":"https://api.github.com/users/mpoquet","html_url":"https://github.com/mpoquet","followers_url":"https://api.github.com/users/mpoquet/followers","following_url":"https://api.github.com/users/mpoquet/following{/other_user}","gists_url":"https://api.github.com/users/mpoquet/gists{/gist_id}","starred_url":"https://api.github.com/users/mpoquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpoquet/subscriptions","organizations_url":"https://api.github.com/users/mpoquet/orgs","repos_url":"https://api.github.com/users/mpoquet/repos","events_url":"https://api.github.com/users/mpoquet/events{/privacy}","received_events_url":"https://api.github.com/users/mpoquet/received_events","type":"User","site_admin":false},"repo":{"id":157791057,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3OTEwNTc=","name":"nlohmann_json","full_name":"mpoquet/nlohmann_json","private":false,"owner":{"login":"mpoquet","id":3502831,"node_id":"MDQ6VXNlcjM1MDI4MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3502831?v=4","gravatar_id":"","url":"https://api.github.com/users/mpoquet","html_url":"https://github.com/mpoquet","followers_url":"https://api.github.com/users/mpoquet/followers","following_url":"https://api.github.com/users/mpoquet/following{/other_user}","gists_url":"https://api.github.com/users/mpoquet/gists{/gist_id}","starred_url":"https://api.github.com/users/mpoquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpoquet/subscriptions","organizations_url":"https://api.github.com/users/mpoquet/orgs","repos_url":"https://api.github.com/users/mpoquet/repos","events_url":"https://api.github.com/users/mpoquet/events{/privacy}","received_events_url":"https://api.github.com/users/mpoquet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mpoquet/nlohmann_json","description":"Meson build definitions for nlohmann_json","fork":true,"url":"https://api.github.com/repos/mpoquet/nlohmann_json","forks_url":"https://api.github.com/repos/mpoquet/nlohmann_json/forks","keys_url":"https://api.github.com/repos/mpoquet/nlohmann_json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpoquet/nlohmann_json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpoquet/nlohmann_json/teams","hooks_url":"https://api.github.com/repos/mpoquet/nlohmann_json/hooks","issue_events_url":"https://api.github.com/repos/mpoquet/nlohmann_json/issues/events{/number}","events_url":"https://api.github.com/repos/mpoquet/nlohmann_json/events","assignees_url":"https://api.github.com/repos/mpoquet/nlohmann_json/assignees{/user}","branches_url":"https://api.github.com/repos/mpoquet/nlohmann_json/branches{/branch}","tags_url":"https://api.github.com/repos/mpoquet/nlohmann_json/tags","blobs_url":"https://api.github.com/repos/mpoquet/nlohmann_json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpoquet/nlohmann_json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpoquet/nlohmann_json/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpoquet/nlohmann_json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpoquet/nlohmann_json/statuses/{sha}","languages_url":"https://api.github.com/repos/mpoquet/nlohmann_json/languages","stargazers_url":"https://api.github.com/repos/mpoquet/nlohmann_json/stargazers","contributors_url":"https://api.github.com/repos/mpoquet/nlohmann_json/contributors","subscribers_url":"https://api.github.com/repos/mpoquet/nlohmann_json/subscribers","subscription_url":"https://api.github.com/repos/mpoquet/nlohmann_json/subscription","commits_url":"https://api.github.com/repos/mpoquet/nlohmann_json/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpoquet/nlohmann_json/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpoquet/nlohmann_json/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpoquet/nlohmann_json/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpoquet/nlohmann_json/contents/{+path}","compare_url":"https://api.github.com/repos/mpoquet/nlohmann_json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpoquet/nlohmann_json/merges","archive_url":"https://api.github.com/repos/mpoquet/nlohmann_json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpoquet/nlohmann_json/downloads","issues_url":"https://api.github.com/repos/mpoquet/nlohmann_json/issues{/number}","pulls_url":"https://api.github.com/repos/mpoquet/nlohmann_json/pulls{/number}","milestones_url":"https://api.github.com/repos/mpoquet/nlohmann_json/milestones{/number}","notifications_url":"https://api.github.com/repos/mpoquet/nlohmann_json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpoquet/nlohmann_json/labels{/name}","releases_url":"https://api.github.com/repos/mpoquet/nlohmann_json/releases{/id}","deployments_url":"https://api.github.com/repos/mpoquet/nlohmann_json/deployments","created_at":"2018-11-16T00:41:10Z","updated_at":"2018-11-16T00:56:03Z","pushed_at":"2018-11-16T01:29:23Z","git_url":"git://github.com/mpoquet/nlohmann_json.git","ssh_url":"git@github.com:mpoquet/nlohmann_json.git","clone_url":"https://github.com/mpoquet/nlohmann_json.git","svn_url":"https://github.com/mpoquet/nlohmann_json","homepage":"https://github.com/nlohmann/json","size":2,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mesonbuild:master","ref":"master","sha":"23cc826eb26b01ae1887caa9c380a2f61105e7f7","user":{"login":"mesonbuild","id":12551236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxMjM2","avatar_url":"https://avatars0.githubusercontent.com/u/12551236?v=4","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":152225186,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIyMjUxODY=","name":"nlohmann_json","full_name":"mesonbuild/nlohmann_json","private":false,"owner":{"login":"mesonbuild","id":12551236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxMjM2","avatar_url":"https://avatars0.githubusercontent.com/u/12551236?v=4","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesonbuild/nlohmann_json","description":"Meson build definitions for nlohmann_json","fork":false,"url":"https://api.github.com/repos/mesonbuild/nlohmann_json","forks_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/forks","keys_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/teams","hooks_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/hooks","issue_events_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/issues/events{/number}","events_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/events","assignees_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/assignees{/user}","branches_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/branches{/branch}","tags_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/tags","blobs_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/statuses/{sha}","languages_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/languages","stargazers_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/stargazers","contributors_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/contributors","subscribers_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/subscribers","subscription_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/subscription","commits_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/contents/{+path}","compare_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/merges","archive_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/downloads","issues_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/issues{/number}","pulls_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/pulls{/number}","milestones_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/milestones{/number}","notifications_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/labels{/name}","releases_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/releases{/id}","deployments_url":"https://api.github.com/repos/mesonbuild/nlohmann_json/deployments","created_at":"2018-10-09T09:34:08Z","updated_at":"2018-10-09T09:34:18Z","pushed_at":"2018-11-16T14:51:23Z","git_url":"git://github.com/mesonbuild/nlohmann_json.git","ssh_url":"git@github.com:mesonbuild/nlohmann_json.git","clone_url":"https://github.com/mesonbuild/nlohmann_json.git","svn_url":"https://github.com/mesonbuild/nlohmann_json","homepage":"https://github.com/nlohmann/json","size":1,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/nlohmann_json/pulls/2"},"html":{"href":"https://github.com/mesonbuild/nlohmann_json/pull/2"},"issue":{"href":"https://api.github.com/repos/mesonbuild/nlohmann_json/issues/2"},"comments":{"href":"https://api.github.com/repos/mesonbuild/nlohmann_json/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/mesonbuild/nlohmann_json/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/mesonbuild/nlohmann_json/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesonbuild/nlohmann_json/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/mesonbuild/nlohmann_json/statuses/a344dd144433e2f5ce1d4edfc2a115ea1cb0ff9d"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":20,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"sarum9in"}}