{"action":"created","comment":{"url":"https://api.github.com/repos/exonum/exonum/pulls/comments/173655017","pull_request_review_id":102882292,"id":173655017,"diff_hunk":"@@ -22,8 +22,6 @@ rust:\n   - 1.23.0\n \n matrix:\n-  allow_failures:\n-  - env: FEATURE=non-fatal-checks","path":".travis.yml","position":5,"original_position":5,"commit_id":"a093f9c79928a3a81486ae0f7a9cba0dba419da3","original_commit_id":"a093f9c79928a3a81486ae0f7a9cba0dba419da3","user":{"login":"DarkEld3r","id":2997902,"avatar_url":"https://avatars1.githubusercontent.com/u/2997902?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkEld3r","html_url":"https://github.com/DarkEld3r","followers_url":"https://api.github.com/users/DarkEld3r/followers","following_url":"https://api.github.com/users/DarkEld3r/following{/other_user}","gists_url":"https://api.github.com/users/DarkEld3r/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkEld3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkEld3r/subscriptions","organizations_url":"https://api.github.com/users/DarkEld3r/orgs","repos_url":"https://api.github.com/users/DarkEld3r/repos","events_url":"https://api.github.com/users/DarkEld3r/events{/privacy}","received_events_url":"https://api.github.com/users/DarkEld3r/received_events","type":"User","site_admin":false},"body":"Should the whole `matrix` section be removed along with `fast_finish`?","created_at":"2018-03-11T13:39:50Z","updated_at":"2018-03-11T13:42:51Z","html_url":"https://github.com/exonum/exonum/pull/545#discussion_r173655017","pull_request_url":"https://api.github.com/repos/exonum/exonum/pulls/545","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum/pulls/comments/173655017"},"html":{"href":"https://github.com/exonum/exonum/pull/545#discussion_r173655017"},"pull_request":{"href":"https://api.github.com/repos/exonum/exonum/pulls/545"}}},"pull_request":{"url":"https://api.github.com/repos/exonum/exonum/pulls/545","id":173455087,"html_url":"https://github.com/exonum/exonum/pull/545","diff_url":"https://github.com/exonum/exonum/pull/545.diff","patch_url":"https://github.com/exonum/exonum/pull/545.patch","issue_url":"https://api.github.com/repos/exonum/exonum/issues/545","number":545,"state":"open","locked":false,"title":"travis: Remove non-fatal-checks, move cargo-deadlinks to 'lints' job [ECR-822]","user":{"login":"ozkriff","id":662976,"avatar_url":"https://avatars0.githubusercontent.com/u/662976?v=4","gravatar_id":"","url":"https://api.github.com/users/ozkriff","html_url":"https://github.com/ozkriff","followers_url":"https://api.github.com/users/ozkriff/followers","following_url":"https://api.github.com/users/ozkriff/following{/other_user}","gists_url":"https://api.github.com/users/ozkriff/gists{/gist_id}","starred_url":"https://api.github.com/users/ozkriff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ozkriff/subscriptions","organizations_url":"https://api.github.com/users/ozkriff/orgs","repos_url":"https://api.github.com/users/ozkriff/repos","events_url":"https://api.github.com/users/ozkriff/events{/privacy}","received_events_url":"https://api.github.com/users/ozkriff/received_events","type":"User","site_admin":false},"body":"There's no point in having `cargo-deadlinks` as a non-fatal check - everyone just ignores it.\r\n\r\nThis PR fixes some of the warnings.\r\nThough, there're some bugs in `rustdoc`, so a few more hacks were added to suppress them for now.\r\n\r\n```\r\nhttps://docs.rs/exonum-configuration/0.6.0/exonum_configuration/struct.MaybeVote.html\r\n\r\nLinked file at path /home/ozkriff/bitfury/exonum/target/std/string/struct.String.html does not exist!\r\nLinked file at path /home/ozkriff/bitfury/exonum/target/std/primitive.usize.html does not exist!\r\nLinked file at path /home/ozkriff/bitfury/exonum/target/doc/exonum_configuration/enum.Option.html does not exist!\r\n```","created_at":"2018-03-07T13:42:34Z","updated_at":"2018-03-11T13:42:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"698607911a1601271e8f92bf45950307899d4ed9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SerhiiOryshych","id":30264635,"avatar_url":"https://avatars1.githubusercontent.com/u/30264635?v=4","gravatar_id":"","url":"https://api.github.com/users/SerhiiOryshych","html_url":"https://github.com/SerhiiOryshych","followers_url":"https://api.github.com/users/SerhiiOryshych/followers","following_url":"https://api.github.com/users/SerhiiOryshych/following{/other_user}","gists_url":"https://api.github.com/users/SerhiiOryshych/gists{/gist_id}","starred_url":"https://api.github.com/users/SerhiiOryshych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerhiiOryshych/subscriptions","organizations_url":"https://api.github.com/users/SerhiiOryshych/orgs","repos_url":"https://api.github.com/users/SerhiiOryshych/repos","events_url":"https://api.github.com/users/SerhiiOryshych/events{/privacy}","received_events_url":"https://api.github.com/users/SerhiiOryshych/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exonum/exonum/pulls/545/commits","review_comments_url":"https://api.github.com/repos/exonum/exonum/pulls/545/comments","review_comment_url":"https://api.github.com/repos/exonum/exonum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exonum/exonum/issues/545/comments","statuses_url":"https://api.github.com/repos/exonum/exonum/statuses/a093f9c79928a3a81486ae0f7a9cba0dba419da3","head":{"label":"ozkriff:ecr822_fatal_deadlinks","ref":"ecr822_fatal_deadlinks","sha":"a093f9c79928a3a81486ae0f7a9cba0dba419da3","user":{"login":"ozkriff","id":662976,"avatar_url":"https://avatars0.githubusercontent.com/u/662976?v=4","gravatar_id":"","url":"https://api.github.com/users/ozkriff","html_url":"https://github.com/ozkriff","followers_url":"https://api.github.com/users/ozkriff/followers","following_url":"https://api.github.com/users/ozkriff/following{/other_user}","gists_url":"https://api.github.com/users/ozkriff/gists{/gist_id}","starred_url":"https://api.github.com/users/ozkriff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ozkriff/subscriptions","organizations_url":"https://api.github.com/users/ozkriff/orgs","repos_url":"https://api.github.com/users/ozkriff/repos","events_url":"https://api.github.com/users/ozkriff/events{/privacy}","received_events_url":"https://api.github.com/users/ozkriff/received_events","type":"User","site_admin":false},"repo":{"id":113465882,"name":"exonum","full_name":"ozkriff/exonum","owner":{"login":"ozkriff","id":662976,"avatar_url":"https://avatars0.githubusercontent.com/u/662976?v=4","gravatar_id":"","url":"https://api.github.com/users/ozkriff","html_url":"https://github.com/ozkriff","followers_url":"https://api.github.com/users/ozkriff/followers","following_url":"https://api.github.com/users/ozkriff/following{/other_user}","gists_url":"https://api.github.com/users/ozkriff/gists{/gist_id}","starred_url":"https://api.github.com/users/ozkriff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ozkriff/subscriptions","organizations_url":"https://api.github.com/users/ozkriff/orgs","repos_url":"https://api.github.com/users/ozkriff/repos","events_url":"https://api.github.com/users/ozkriff/events{/privacy}","received_events_url":"https://api.github.com/users/ozkriff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ozkriff/exonum","description":"Exonum core repository","fork":true,"url":"https://api.github.com/repos/ozkriff/exonum","forks_url":"https://api.github.com/repos/ozkriff/exonum/forks","keys_url":"https://api.github.com/repos/ozkriff/exonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ozkriff/exonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ozkriff/exonum/teams","hooks_url":"https://api.github.com/repos/ozkriff/exonum/hooks","issue_events_url":"https://api.github.com/repos/ozkriff/exonum/issues/events{/number}","events_url":"https://api.github.com/repos/ozkriff/exonum/events","assignees_url":"https://api.github.com/repos/ozkriff/exonum/assignees{/user}","branches_url":"https://api.github.com/repos/ozkriff/exonum/branches{/branch}","tags_url":"https://api.github.com/repos/ozkriff/exonum/tags","blobs_url":"https://api.github.com/repos/ozkriff/exonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ozkriff/exonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ozkriff/exonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ozkriff/exonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ozkriff/exonum/statuses/{sha}","languages_url":"https://api.github.com/repos/ozkriff/exonum/languages","stargazers_url":"https://api.github.com/repos/ozkriff/exonum/stargazers","contributors_url":"https://api.github.com/repos/ozkriff/exonum/contributors","subscribers_url":"https://api.github.com/repos/ozkriff/exonum/subscribers","subscription_url":"https://api.github.com/repos/ozkriff/exonum/subscription","commits_url":"https://api.github.com/repos/ozkriff/exonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ozkriff/exonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ozkriff/exonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ozkriff/exonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ozkriff/exonum/contents/{+path}","compare_url":"https://api.github.com/repos/ozkriff/exonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ozkriff/exonum/merges","archive_url":"https://api.github.com/repos/ozkriff/exonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ozkriff/exonum/downloads","issues_url":"https://api.github.com/repos/ozkriff/exonum/issues{/number}","pulls_url":"https://api.github.com/repos/ozkriff/exonum/pulls{/number}","milestones_url":"https://api.github.com/repos/ozkriff/exonum/milestones{/number}","notifications_url":"https://api.github.com/repos/ozkriff/exonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ozkriff/exonum/labels{/name}","releases_url":"https://api.github.com/repos/ozkriff/exonum/releases{/id}","deployments_url":"https://api.github.com/repos/ozkriff/exonum/deployments","created_at":"2017-12-07T15:14:49Z","updated_at":"2017-12-07T15:14:51Z","pushed_at":"2018-03-09T08:55:15Z","git_url":"git://github.com/ozkriff/exonum.git","ssh_url":"git@github.com:ozkriff/exonum.git","clone_url":"https://github.com/ozkriff/exonum.git","svn_url":"https://github.com/ozkriff/exonum","homepage":"http://exonum.com","size":5124,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exonum:master","ref":"master","sha":"68d122c0d9897d024873eb899e7b331e63625e60","user":{"login":"exonum","id":23138442,"avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"repo":{"id":80729805,"name":"exonum","full_name":"exonum/exonum","owner":{"login":"exonum","id":23138442,"avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exonum/exonum","description":"Exonum core repository","fork":false,"url":"https://api.github.com/repos/exonum/exonum","forks_url":"https://api.github.com/repos/exonum/exonum/forks","keys_url":"https://api.github.com/repos/exonum/exonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exonum/exonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exonum/exonum/teams","hooks_url":"https://api.github.com/repos/exonum/exonum/hooks","issue_events_url":"https://api.github.com/repos/exonum/exonum/issues/events{/number}","events_url":"https://api.github.com/repos/exonum/exonum/events","assignees_url":"https://api.github.com/repos/exonum/exonum/assignees{/user}","branches_url":"https://api.github.com/repos/exonum/exonum/branches{/branch}","tags_url":"https://api.github.com/repos/exonum/exonum/tags","blobs_url":"https://api.github.com/repos/exonum/exonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exonum/exonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exonum/exonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/exonum/exonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exonum/exonum/statuses/{sha}","languages_url":"https://api.github.com/repos/exonum/exonum/languages","stargazers_url":"https://api.github.com/repos/exonum/exonum/stargazers","contributors_url":"https://api.github.com/repos/exonum/exonum/contributors","subscribers_url":"https://api.github.com/repos/exonum/exonum/subscribers","subscription_url":"https://api.github.com/repos/exonum/exonum/subscription","commits_url":"https://api.github.com/repos/exonum/exonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/exonum/exonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/exonum/exonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/exonum/exonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/exonum/exonum/contents/{+path}","compare_url":"https://api.github.com/repos/exonum/exonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exonum/exonum/merges","archive_url":"https://api.github.com/repos/exonum/exonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exonum/exonum/downloads","issues_url":"https://api.github.com/repos/exonum/exonum/issues{/number}","pulls_url":"https://api.github.com/repos/exonum/exonum/pulls{/number}","milestones_url":"https://api.github.com/repos/exonum/exonum/milestones{/number}","notifications_url":"https://api.github.com/repos/exonum/exonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exonum/exonum/labels{/name}","releases_url":"https://api.github.com/repos/exonum/exonum/releases{/id}","deployments_url":"https://api.github.com/repos/exonum/exonum/deployments","created_at":"2017-02-02T13:56:57Z","updated_at":"2018-03-10T17:03:50Z","pushed_at":"2018-03-11T13:42:02Z","git_url":"git://github.com/exonum/exonum.git","ssh_url":"git@github.com:exonum/exonum.git","clone_url":"https://github.com/exonum/exonum.git","svn_url":"https://github.com/exonum/exonum","homepage":"http://exonum.com","size":5125,"stargazers_count":498,"watchers_count":498,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":68,"open_issues":52,"watchers":498,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum/pulls/545"},"html":{"href":"https://github.com/exonum/exonum/pull/545"},"issue":{"href":"https://api.github.com/repos/exonum/exonum/issues/545"},"comments":{"href":"https://api.github.com/repos/exonum/exonum/issues/545/comments"},"review_comments":{"href":"https://api.github.com/repos/exonum/exonum/pulls/545/comments"},"review_comment":{"href":"https://api.github.com/repos/exonum/exonum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exonum/exonum/pulls/545/commits"},"statuses":{"href":"https://api.github.com/repos/exonum/exonum/statuses/a093f9c79928a3a81486ae0f7a9cba0dba419da3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DarkEld3r"}}