{"action":"closed","number":2399,"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/2399","id":201441423,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDQxNDIz","html_url":"https://github.com/ray-project/ray/pull/2399","diff_url":"https://github.com/ray-project/ray/pull/2399.diff","patch_url":"https://github.com/ray-project/ray/pull/2399.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/2399","number":2399,"state":"closed","locked":false,"title":"[rllib] Count actual sample batch size instead of configured batch size in A3C.","user":{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your contribution!\r\n\r\nPlease review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request.\r\n-->\r\n\r\n## What do these changes do?\r\n\r\nThis fixes a metrics accounting bug where the sample count is not reported correctly. \r\n```\r\n./train.py --run=A3C --env=CartPole-v0 --config='{\"sample_batch_size\": 20, \"sample_async\": false}'\r\n```\r\n## Related issue number\r\n\r\n<!-- Are there any issues opened that will be resolved by merging this change? -->\r\n","created_at":"2018-07-14T07:57:39Z","updated_at":"2018-07-18T06:59:53Z","closed_at":"2018-07-18T06:59:53Z","merged_at":"2018-07-18T06:59:53Z","merge_commit_sha":"f31a6ca96510deb77117826437434da80e6df1f4","assignee":{"login":"richardliaw","id":4529381,"node_id":"MDQ6VXNlcjQ1MjkzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4529381?v=4","gravatar_id":"","url":"https://api.github.com/users/richardliaw","html_url":"https://github.com/richardliaw","followers_url":"https://api.github.com/users/richardliaw/followers","following_url":"https://api.github.com/users/richardliaw/following{/other_user}","gists_url":"https://api.github.com/users/richardliaw/gists{/gist_id}","starred_url":"https://api.github.com/users/richardliaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardliaw/subscriptions","organizations_url":"https://api.github.com/users/richardliaw/orgs","repos_url":"https://api.github.com/users/richardliaw/repos","events_url":"https://api.github.com/users/richardliaw/events{/privacy}","received_events_url":"https://api.github.com/users/richardliaw/received_events","type":"User","site_admin":false},"assignees":[{"login":"richardliaw","id":4529381,"node_id":"MDQ6VXNlcjQ1MjkzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4529381?v=4","gravatar_id":"","url":"https://api.github.com/users/richardliaw","html_url":"https://github.com/richardliaw","followers_url":"https://api.github.com/users/richardliaw/followers","following_url":"https://api.github.com/users/richardliaw/following{/other_user}","gists_url":"https://api.github.com/users/richardliaw/gists{/gist_id}","starred_url":"https://api.github.com/users/richardliaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardliaw/subscriptions","organizations_url":"https://api.github.com/users/richardliaw/orgs","repos_url":"https://api.github.com/users/richardliaw/repos","events_url":"https://api.github.com/users/richardliaw/events{/privacy}","received_events_url":"https://api.github.com/users/richardliaw/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/2399/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/2399/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/2399/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/e81ea95f0d165676b989d4a613fbafad727a900a","head":{"label":"ericl:fix-metrics-for-real","ref":"fix-metrics-for-real","sha":"e81ea95f0d165676b989d4a613fbafad727a900a","user":{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"repo":{"id":91077004,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA3NzAwNA==","name":"ray","full_name":"ericl/ray","owner":{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericl/ray","description":"An experimental distributed execution engine","fork":true,"url":"https://api.github.com/repos/ericl/ray","forks_url":"https://api.github.com/repos/ericl/ray/forks","keys_url":"https://api.github.com/repos/ericl/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericl/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericl/ray/teams","hooks_url":"https://api.github.com/repos/ericl/ray/hooks","issue_events_url":"https://api.github.com/repos/ericl/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ericl/ray/events","assignees_url":"https://api.github.com/repos/ericl/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ericl/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ericl/ray/tags","blobs_url":"https://api.github.com/repos/ericl/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericl/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericl/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericl/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericl/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ericl/ray/languages","stargazers_url":"https://api.github.com/repos/ericl/ray/stargazers","contributors_url":"https://api.github.com/repos/ericl/ray/contributors","subscribers_url":"https://api.github.com/repos/ericl/ray/subscribers","subscription_url":"https://api.github.com/repos/ericl/ray/subscription","commits_url":"https://api.github.com/repos/ericl/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericl/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericl/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericl/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericl/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ericl/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericl/ray/merges","archive_url":"https://api.github.com/repos/ericl/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericl/ray/downloads","issues_url":"https://api.github.com/repos/ericl/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ericl/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ericl/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ericl/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericl/ray/labels{/name}","releases_url":"https://api.github.com/repos/ericl/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ericl/ray/deployments","created_at":"2017-05-12T09:51:04Z","updated_at":"2017-05-12T09:51:06Z","pushed_at":"2018-07-17T18:41:11Z","git_url":"git://github.com/ericl/ray.git","ssh_url":"git@github.com:ericl/ray.git","clone_url":"https://github.com/ericl/ray.git","svn_url":"https://github.com/ericl/ray","homepage":"","size":16761,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"e3badb9b0938b500effc1feb09c8ef3109afa8d8","user":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzMjM0OQ==","name":"ray","full_name":"ray-project/ray","owner":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray","description":"A high-performance distributed execution engine","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2018-07-18T05:50:42Z","pushed_at":"2018-07-18T06:59:53Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"","size":13069,"stargazers_count":3715,"watchers_count":3715,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":494,"mirror_url":null,"archived":false,"open_issues_count":344,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":494,"open_issues":344,"watchers":3715,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2399"},"html":{"href":"https://github.com/ray-project/ray/pull/2399"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/2399"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/2399/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2399/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2399/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/e81ea95f0d165676b989d4a613fbafad727a900a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":9,"deletions":10,"changed_files":3}}
{"actor":{"display_login":"ericl"}}