{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/208","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/208/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/208/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/208/events","html_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/208","id":325095030,"number":208,"title":"Remove Terraform-specific hack.","user":{"login":"ndmckinley","id":605324,"avatar_url":"https://avatars2.githubusercontent.com/u/605324?v=4","gravatar_id":"","url":"https://api.github.com/users/ndmckinley","html_url":"https://github.com/ndmckinley","followers_url":"https://api.github.com/users/ndmckinley/followers","following_url":"https://api.github.com/users/ndmckinley/following{/other_user}","gists_url":"https://api.github.com/users/ndmckinley/gists{/gist_id}","starred_url":"https://api.github.com/users/ndmckinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndmckinley/subscriptions","organizations_url":"https://api.github.com/users/ndmckinley/orgs","repos_url":"https://api.github.com/users/ndmckinley/repos","events_url":"https://api.github.com/users/ndmckinley/events{/privacy}","received_events_url":"https://api.github.com/users/ndmckinley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-21T23:46:24Z","updated_at":"2018-05-22T00:05:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/208","html_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/208","diff_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/208.diff","patch_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/208.patch"},"body":"<!-- A summary of the changes in this commit goes here -->\r\nRemoves a terraform-specific hack to add a slightly-less-hacky provider-agnostic way of solving the same problem.\r\n\r\nMore specifically, adds `name` as a field in the generic Provider::Config, and uses that instead of the normal `product_ns` if present.  I tested it with Chef and with Terraform, works fine with both.\r\n\r\nI tried to explain how limited this solution is in a comment - I don't think it's very clear right now and would appreciate wording suggestions.\r\n\r\nI tested this with chef and terraform - there are no changes to the terraform repo as a result of this change, and Chef seemed to work fine with no name override.\r\n\r\nThis fixes #195.\r\n\r\n<!--\r\nChanges per downstream repository.  For each repository that you\r\nexpect to have changed, find the [tag] and write your commit\r\nmessage beneath it.  More-specific tags replace less-specific tags.\r\nFor example, if you provide a message under [all], a message under\r\n[puppet], and a message under [puppet-dns], the Terraform repository\r\nwill have the resulting commit made using the [all] message, the\r\nPuppet Compute repository will have its commit made using [puppet],\r\nand the Puppet DNS repository will have its commit made using\r\n[puppet-dns].  You can delete unused tags, but you don't need to.\r\n\r\nThe structure of the PR body is important to our CI system!\r\nThe comments can be deleted, but if you want to make the downstream\r\ncommits sensible, you'll need to leave the dashed line separating\r\nthis PR's changes from the commit messages for downstream commits.\r\n-->\r\n\r\n-----------------------------------------------------------------\r\n# [all]\r\nNo changes expected.\r\n## [terraform]\r\n## [puppet]\r\n### [puppet-dns]\r\n### [puppet-sql]\r\n### [puppet-compute]\r\n## [chef]\r\n"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/comments/390821788","html_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/208#issuecomment-390821788","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/208","id":390821788,"user":{"login":"modular-magician","id":36310445,"avatar_url":"https://avatars2.githubusercontent.com/u/36310445?v=4","gravatar_id":"","url":"https://api.github.com/users/modular-magician","html_url":"https://github.com/modular-magician","followers_url":"https://api.github.com/users/modular-magician/followers","following_url":"https://api.github.com/users/modular-magician/following{/other_user}","gists_url":"https://api.github.com/users/modular-magician/gists{/gist_id}","starred_url":"https://api.github.com/users/modular-magician/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modular-magician/subscriptions","organizations_url":"https://api.github.com/users/modular-magician/orgs","repos_url":"https://api.github.com/users/modular-magician/repos","events_url":"https://api.github.com/users/modular-magician/events{/privacy}","received_events_url":"https://api.github.com/users/modular-magician/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T00:05:47Z","updated_at":"2018-05-22T00:05:47Z","author_association":"COLLABORATOR","body":"I am a robot that works on MagicModules PRs!\nI checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.\n\nOnce this PR is approved, you can feel free to merge it without taking any further steps.\n"}}
{"actor":{"display_login":"modular-magician"}}