{"action":"created","issue":{"url":"https://api.github.com/repos/LLNL/lbann/issues/276","repository_url":"https://api.github.com/repos/LLNL/lbann","labels_url":"https://api.github.com/repos/LLNL/lbann/issues/276/labels{/name}","comments_url":"https://api.github.com/repos/LLNL/lbann/issues/276/comments","events_url":"https://api.github.com/repos/LLNL/lbann/issues/276/events","html_url":"https://github.com/LLNL/lbann/pull/276","id":311770413,"number":276,"title":"Evaluation layers","user":{"login":"timmoon10","id":4406448,"avatar_url":"https://avatars0.githubusercontent.com/u/4406448?v=4","gravatar_id":"","url":"https://api.github.com/users/timmoon10","html_url":"https://github.com/timmoon10","followers_url":"https://api.github.com/users/timmoon10/followers","following_url":"https://api.github.com/users/timmoon10/following{/other_user}","gists_url":"https://api.github.com/users/timmoon10/gists{/gist_id}","starred_url":"https://api.github.com/users/timmoon10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timmoon10/subscriptions","organizations_url":"https://api.github.com/users/timmoon10/orgs","repos_url":"https://api.github.com/users/timmoon10/repos","events_url":"https://api.github.com/users/timmoon10/events{/privacy}","received_events_url":"https://api.github.com/users/timmoon10/received_events","type":"User","site_admin":false},"labels":[{"id":374636004,"url":"https://api.github.com/repos/LLNL/lbann/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":808127779,"url":"https://api.github.com/repos/LLNL/lbann/labels/review%20requested","name":"review requested","color":"a053e0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-05T21:10:16Z","updated_at":"2018-04-10T20:26:29Z","closed_at":"2018-04-10T20:20:57Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/LLNL/lbann/pulls/276","html_url":"https://github.com/LLNL/lbann/pull/276","diff_url":"https://github.com/LLNL/lbann/pull/276.diff","patch_url":"https://github.com/LLNL/lbann/pull/276.patch"},"body":"This pull request makes progress on #193. Major changes:\r\n- Implemented `evaluation_layer`, which computes an average value across a mini-batch.\r\n- Implemented `layer_term`, which is an objective function term that interfaces with an evaluation layer.\r\n- Reproduced the KL divergence term in the MNIST VAE model. This involved implementing `reduction_layer` and `power_layer`.\r\n\r\nThis MNIST VAE model passes a gradient check when the MSE loss function is used. The JAG VAE model achieves similar results as the existing version."},"comment":{"url":"https://api.github.com/repos/LLNL/lbann/issues/comments/380235373","html_url":"https://github.com/LLNL/lbann/pull/276#issuecomment-380235373","issue_url":"https://api.github.com/repos/LLNL/lbann/issues/276","id":380235373,"user":{"login":"bvanessen","id":6210171,"avatar_url":"https://avatars2.githubusercontent.com/u/6210171?v=4","gravatar_id":"","url":"https://api.github.com/users/bvanessen","html_url":"https://github.com/bvanessen","followers_url":"https://api.github.com/users/bvanessen/followers","following_url":"https://api.github.com/users/bvanessen/following{/other_user}","gists_url":"https://api.github.com/users/bvanessen/gists{/gist_id}","starred_url":"https://api.github.com/users/bvanessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvanessen/subscriptions","organizations_url":"https://api.github.com/users/bvanessen/orgs","repos_url":"https://api.github.com/users/bvanessen/repos","events_url":"https://api.github.com/users/bvanessen/events{/privacy}","received_events_url":"https://api.github.com/users/bvanessen/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T20:26:29Z","updated_at":"2018-04-10T20:26:29Z","author_association":"COLLABORATOR","body":"When you say this layer centric design, what is the alternative that you want a comparison too?\r\n\r\nBrian C. Van Essen\r\nvanessen1@llnl.gov\r\n(w) 925-422-9300\r\n(c) 925-290-5470\r\n\r\n\r\n\r\n\r\n\r\n> On Apr 10, 2018, at 6:10 AM, Sam Ade Jacobs <notifications@github.com> wrote:\r\n> \r\n> @samadejacobs commented on this pull request.\r\n> \r\n> I can approve based on the @timmoon10 comments that this refactor achieves similar results as current implementation of JAG-VAE-FCN. Since this refactor closely match Doersch Caffe implementaion, it would be nice (and more appropriate) to compare our result to his. Lastly, a general \"design philosophy\" question in broader context of LBANN is: what are the general limitation of this Caffeish (layer-centric) approach?\r\n> \r\n> —\r\n> You are receiving this because you are subscribed to this thread.\r\n> Reply to this email directly, view it on GitHub, or mute the thread.\r\n> \r\n\r\n"}}
{"actor":{"display_login":"bvanessen"}}