{"action":"created","issue":{"url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues/136","repository_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules","labels_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues/136/comments","events_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues/136/events","html_url":"https://github.com/kubevirt/ansible-kubevirt-modules/pull/136","id":381104146,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMTQ5MDM3","number":136,"title":"Add a dedicated module for managing Services","user":{"login":"mmazur","id":62953,"node_id":"MDQ6VXNlcjYyOTUz","avatar_url":"https://avatars1.githubusercontent.com/u/62953?v=4","gravatar_id":"","url":"https://api.github.com/users/mmazur","html_url":"https://github.com/mmazur","followers_url":"https://api.github.com/users/mmazur/followers","following_url":"https://api.github.com/users/mmazur/following{/other_user}","gists_url":"https://api.github.com/users/mmazur/gists{/gist_id}","starred_url":"https://api.github.com/users/mmazur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmazur/subscriptions","organizations_url":"https://api.github.com/users/mmazur/orgs","repos_url":"https://api.github.com/users/mmazur/repos","events_url":"https://api.github.com/users/mmazur/events{/privacy}","received_events_url":"https://api.github.com/users/mmazur/received_events","type":"User","site_admin":false},"labels":[{"id":1119139851,"node_id":"MDU6TGFiZWwxMTE5MTM5ODUx","url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/labels/reviews/2","name":"reviews/2","color":"f1f77b","default":false},{"id":1080282993,"node_id":"MDU6TGFiZWwxMDgwMjgyOTkz","url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-15T10:49:20Z","updated_at":"2018-11-19T14:09:25Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/136","html_url":"https://github.com/kubevirt/ansible-kubevirt-modules/pull/136","diff_url":"https://github.com/kubevirt/ansible-kubevirt-modules/pull/136.diff","patch_url":"https://github.com/kubevirt/ansible-kubevirt-modules/pull/136.patch"},"body":"Let's make sure we're on the same page wrt to config parameters early. @machacekondra @pkliczewski \r\n\r\nThe idea behind `spec` is:\r\n1. One can completely ignore the module's parameters and provide the whole Service spec inline.\r\n2. Any parameter not covered directly by the module for whatever reason can always be provided this way."},"comment":{"url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues/comments/439904647","html_url":"https://github.com/kubevirt/ansible-kubevirt-modules/pull/136#issuecomment-439904647","issue_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues/136","id":439904647,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTkwNDY0Nw==","user":{"login":"mmazur","id":62953,"node_id":"MDQ6VXNlcjYyOTUz","avatar_url":"https://avatars1.githubusercontent.com/u/62953?v=4","gravatar_id":"","url":"https://api.github.com/users/mmazur","html_url":"https://github.com/mmazur","followers_url":"https://api.github.com/users/mmazur/followers","following_url":"https://api.github.com/users/mmazur/following{/other_user}","gists_url":"https://api.github.com/users/mmazur/gists{/gist_id}","starred_url":"https://api.github.com/users/mmazur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmazur/subscriptions","organizations_url":"https://api.github.com/users/mmazur/orgs","repos_url":"https://api.github.com/users/mmazur/repos","events_url":"https://api.github.com/users/mmazur/events{/privacy}","received_events_url":"https://api.github.com/users/mmazur/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T14:09:25Z","updated_at":"2018-11-19T14:09:25Z","author_association":"COLLABORATOR","body":"Ok, I've addressed the points of discussions we've had. This is the most simple version of this that we can have that gets us the functionality we need. Please merge. I'll put the unit tests in a separate PR and continue any further work on this with upstream."}}
{"actor":{"display_login":"mmazur"}}