{"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls/comments/194769218","pull_request_review_id":127905733,"id":194769218,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDc2OTIxOA==","diff_hunk":"@@ -181,6 +181,33 @@ func TestPublishingEndpointsAreHiddenForWeb(t *testing.T) {\n \t\t\t})\n \t\t})\n \n+\t\t// POST request to /instances/{instance_id}/dimensions\n+\t\tConvey(\"When a POST request to create a dimension option resource for an instance in web\", func() {\n+\t\t\tConvey(\"Then response returns a status not found (404)\", func() {\n+\n+\t\t\t\tlog.Debug(\"POST request on Dimension Option resource for an instance\", log.Data{\"endpoint\": \"/instances/{instance_id}/dimensions\", \"method\": \"POST\"})\n+\n+\t\t\t\tdatasetAPI.POST(\"/instances/{instance_id}/dimensions\", instanceID).\n+\t\t\t\t\tWithHeader(florenceTokenName, florenceToken).\n+\t\t\t\t\tWithBytes([]byte(validPOSTAgeDimensionJSON)).\n+\t\t\t\t\tExpect().Status(http.StatusNotFound).\n+\t\t\t\t\tBody().Contains(\"\")","path":"web/datasetAPI/hidden_endpoints_test.go","position":14,"original_position":14,"commit_id":"77cb85f9da6b222433f154282ef1f364ba4be1b8","original_commit_id":"77cb85f9da6b222433f154282ef1f364ba4be1b8","user":{"login":"gedge","id":151578,"node_id":"MDQ6VXNlcjE1MTU3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/151578?v=4","gravatar_id":"","url":"https://api.github.com/users/gedge","html_url":"https://github.com/gedge","followers_url":"https://api.github.com/users/gedge/followers","following_url":"https://api.github.com/users/gedge/following{/other_user}","gists_url":"https://api.github.com/users/gedge/gists{/gist_id}","starred_url":"https://api.github.com/users/gedge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gedge/subscriptions","organizations_url":"https://api.github.com/users/gedge/orgs","repos_url":"https://api.github.com/users/gedge/repos","events_url":"https://api.github.com/users/gedge/events{/privacy}","received_events_url":"https://api.github.com/users/gedge/received_events","type":"User","site_admin":false},"body":"shouldn't this be `Empty()` or similar? or not there (is it actually checking anything?)","created_at":"2018-06-12T14:51:09Z","updated_at":"2018-06-12T14:52:17Z","html_url":"https://github.com/ONSdigital/dp-api-tests/pull/84#discussion_r194769218","pull_request_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls/84","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls/comments/194769218"},"html":{"href":"https://github.com/ONSdigital/dp-api-tests/pull/84#discussion_r194769218"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls/84","id":194225801,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MjI1ODAx","html_url":"https://github.com/ONSdigital/dp-api-tests/pull/84","diff_url":"https://github.com/ONSdigital/dp-api-tests/pull/84.diff","patch_url":"https://github.com/ONSdigital/dp-api-tests/pull/84.patch","issue_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/issues/84","number":84,"state":"open","locked":false,"title":"Add tests for PUT and POST dimension endpoints on dataset API","user":{"login":"nshumoogum","id":7114615,"node_id":"MDQ6VXNlcjcxMTQ2MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/7114615?v=4","gravatar_id":"","url":"https://api.github.com/users/nshumoogum","html_url":"https://github.com/nshumoogum","followers_url":"https://api.github.com/users/nshumoogum/followers","following_url":"https://api.github.com/users/nshumoogum/following{/other_user}","gists_url":"https://api.github.com/users/nshumoogum/gists{/gist_id}","starred_url":"https://api.github.com/users/nshumoogum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nshumoogum/subscriptions","organizations_url":"https://api.github.com/users/nshumoogum/orgs","repos_url":"https://api.github.com/users/nshumoogum/repos","events_url":"https://api.github.com/users/nshumoogum/events{/privacy}","received_events_url":"https://api.github.com/users/nshumoogum/received_events","type":"User","site_admin":false},"body":"### What\r\n\r\nAdd tests for PUT and POST dimension endpoints on dataset API\r\n\r\n### How to review\r\n\r\nCheck all tests against dataset API pass (publishing and web) and check logic and coverage.\r\nTo run the tests you will need to be running the dataset API on `feature/return-correct-error-message` branch.\r\n\r\n### Who can review\r\n\r\nAnyone","created_at":"2018-06-12T09:54:37Z","updated_at":"2018-06-12T14:52:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66a7d3cebd2219149d51a4d39b0d02ba6bca3941","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls/84/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls/84/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/issues/84/comments","statuses_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/statuses/77cb85f9da6b222433f154282ef1f364ba4be1b8","head":{"label":"ONSdigital:feature/extend-dataset-api-tests","ref":"feature/extend-dataset-api-tests","sha":"77cb85f9da6b222433f154282ef1f364ba4be1b8","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":102735561,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3MzU1NjE=","name":"dp-api-tests","full_name":"ONSdigital/dp-api-tests","owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/dp-api-tests","description":"Automated API acceptance tests ","fork":false,"url":"https://api.github.com/repos/ONSdigital/dp-api-tests","forks_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/forks","keys_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/teams","hooks_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/events","assignees_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/tags","blobs_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/subscription","commits_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/merges","archive_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/downloads","issues_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/deployments","created_at":"2017-09-07T12:40:49Z","updated_at":"2018-06-12T10:04:23Z","pushed_at":"2018-06-12T12:07:04Z","git_url":"git://github.com/ONSdigital/dp-api-tests.git","ssh_url":"git@github.com:ONSdigital/dp-api-tests.git","clone_url":"https://github.com/ONSdigital/dp-api-tests.git","svn_url":"https://github.com/ONSdigital/dp-api-tests","homepage":null,"size":2443,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"cmd-develop"}},"base":{"label":"ONSdigital:cmd-develop","ref":"cmd-develop","sha":"32a8a1930c51768c06c31e4d38c6e7a8b18204c9","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":102735561,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3MzU1NjE=","name":"dp-api-tests","full_name":"ONSdigital/dp-api-tests","owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/dp-api-tests","description":"Automated API acceptance tests ","fork":false,"url":"https://api.github.com/repos/ONSdigital/dp-api-tests","forks_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/forks","keys_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/teams","hooks_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/events","assignees_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/tags","blobs_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/subscription","commits_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/merges","archive_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/downloads","issues_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/dp-api-tests/deployments","created_at":"2017-09-07T12:40:49Z","updated_at":"2018-06-12T10:04:23Z","pushed_at":"2018-06-12T12:07:04Z","git_url":"git://github.com/ONSdigital/dp-api-tests.git","ssh_url":"git@github.com:ONSdigital/dp-api-tests.git","clone_url":"https://github.com/ONSdigital/dp-api-tests.git","svn_url":"https://github.com/ONSdigital/dp-api-tests","homepage":null,"size":2443,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"cmd-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls/84"},"html":{"href":"https://github.com/ONSdigital/dp-api-tests/pull/84"},"issue":{"href":"https://api.github.com/repos/ONSdigital/dp-api-tests/issues/84"},"comments":{"href":"https://api.github.com/repos/ONSdigital/dp-api-tests/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/dp-api-tests/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/dp-api-tests/statuses/77cb85f9da6b222433f154282ef1f364ba4be1b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gedge"}}