{"action":"created","issue":{"url":"https://api.github.com/repos/svergeylen/collector/issues/76","repository_url":"https://api.github.com/repos/svergeylen/collector","labels_url":"https://api.github.com/repos/svergeylen/collector/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/svergeylen/collector/issues/76/comments","events_url":"https://api.github.com/repos/svergeylen/collector/issues/76/events","html_url":"https://github.com/svergeylen/collector/pull/76","id":321995055,"number":76,"title":"Déplacement des attachments hors du répertoire public","user":{"login":"dvergeylen","id":8804879,"avatar_url":"https://avatars2.githubusercontent.com/u/8804879?v=4","gravatar_id":"","url":"https://api.github.com/users/dvergeylen","html_url":"https://github.com/dvergeylen","followers_url":"https://api.github.com/users/dvergeylen/followers","following_url":"https://api.github.com/users/dvergeylen/following{/other_user}","gists_url":"https://api.github.com/users/dvergeylen/gists{/gist_id}","starred_url":"https://api.github.com/users/dvergeylen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvergeylen/subscriptions","organizations_url":"https://api.github.com/users/dvergeylen/orgs","repos_url":"https://api.github.com/users/dvergeylen/repos","events_url":"https://api.github.com/users/dvergeylen/events{/privacy}","received_events_url":"https://api.github.com/users/dvergeylen/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-10T16:27:43Z","updated_at":"2018-05-24T13:45:42Z","closed_at":"2018-05-24T12:55:39Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/svergeylen/collector/pulls/76","html_url":"https://github.com/svergeylen/collector/pull/76","diff_url":"https://github.com/svergeylen/collector/pull/76.diff","patch_url":"https://github.com/svergeylen/collector/pull/76.patch"},"body":"Ceci permet de laisser les images privées et non accessibles à tous depuis l'extérieur (nécessité d'être loggé)😎\r\n\r\nUn petit désagrément (qui m'a pris longtemps à trouver) est qu'il faut précéder a.image() de \"/\" +, autrement `image_tag` interprète ceci comme devant être servi comme un asset.\r\n(autrement ceci génèrerait une erreur car les images ne sont pas des assets mais des fichiers envoyés via send_file par un controller, après vérification d'accès).\r\n\r\nIl faut maintenant écrire un script de migration des uploads actuels vers le nouveau répertoire.\r\n\r\nPour chaque attachement, le path est le suivant:\r\n\r\n```\r\n:rails_root/uploaded_files/:attachement_id/:style.:extension\r\n```\r\n\r\nCeci nécessite d'être testé avant d'être déployé (marche chez moi depuis un fresh clone).\r\n\r\nFix #75 "},"comment":{"url":"https://api.github.com/repos/svergeylen/collector/issues/comments/391720292","html_url":"https://github.com/svergeylen/collector/pull/76#issuecomment-391720292","issue_url":"https://api.github.com/repos/svergeylen/collector/issues/76","id":391720292,"user":{"login":"svergeylen","id":2971168,"avatar_url":"https://avatars3.githubusercontent.com/u/2971168?v=4","gravatar_id":"","url":"https://api.github.com/users/svergeylen","html_url":"https://github.com/svergeylen","followers_url":"https://api.github.com/users/svergeylen/followers","following_url":"https://api.github.com/users/svergeylen/following{/other_user}","gists_url":"https://api.github.com/users/svergeylen/gists{/gist_id}","starred_url":"https://api.github.com/users/svergeylen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svergeylen/subscriptions","organizations_url":"https://api.github.com/users/svergeylen/orgs","repos_url":"https://api.github.com/users/svergeylen/repos","events_url":"https://api.github.com/users/svergeylen/events{/privacy}","received_events_url":"https://api.github.com/users/svergeylen/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T13:45:42Z","updated_at":"2018-05-24T13:45:42Z","author_association":"OWNER","body":"Et voilà j'ai fait une belle tache rake pour déplacer les uploads :-) \r\nrake files:move_uploads\r\nJe ne vois pas comment lier cela au commit mais peu importe : 417f018ce6f3429b6d4c188a8cdc1cd9a7e59e8d \r\n"}}
{"actor":{"display_login":"svergeylen"}}