{"action":"created","comment":{"url":"https://api.github.com/repos/openlayers/openlayers/pulls/comments/237137384","pull_request_review_id":179362677,"id":237137384,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzEzNzM4NA==","diff_hunk":"@@ -45,6 +45,11 @@ const LEADING_DIGITS = [1, 2, 5];\n  * @property {HTMLElement|string} [target] Specify a target if you want the control\n  * to be rendered outside of the map's viewport.\n  * @property {Units|string} [units='metric'] Units.\n+ * @property {boolean} [scaleBar=false] Render scalebars instead of a line.\n+ * @property {number} [scaleBarSteps=4] Number of steps the scalebar should use. Use even numbers","path":"src/ol/control/ScaleLine.js","position":5,"original_position":5,"commit_id":"97618c8611c88ede8d68e915dca1383eddda979c","original_commit_id":"97618c8611c88ede8d68e915dca1383eddda979c","user":{"login":"tschaub","id":41094,"node_id":"MDQ6VXNlcjQxMDk0","avatar_url":"https://avatars0.githubusercontent.com/u/41094?v=4","gravatar_id":"","url":"https://api.github.com/users/tschaub","html_url":"https://github.com/tschaub","followers_url":"https://api.github.com/users/tschaub/followers","following_url":"https://api.github.com/users/tschaub/following{/other_user}","gists_url":"https://api.github.com/users/tschaub/gists{/gist_id}","starred_url":"https://api.github.com/users/tschaub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschaub/subscriptions","organizations_url":"https://api.github.com/users/tschaub/orgs","repos_url":"https://api.github.com/users/tschaub/repos","events_url":"https://api.github.com/users/tschaub/events{/privacy}","received_events_url":"https://api.github.com/users/tschaub/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n * @property {number} [steps=4] Number of steps the scalebar should use. Use even numbers\r\n```","created_at":"2018-11-28T15:40:11Z","updated_at":"2018-11-28T15:40:12Z","html_url":"https://github.com/openlayers/openlayers/pull/9013#discussion_r237137384","pull_request_url":"https://api.github.com/repos/openlayers/openlayers/pulls/9013","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openlayers/openlayers/pulls/comments/237137384"},"html":{"href":"https://github.com/openlayers/openlayers/pull/9013#discussion_r237137384"},"pull_request":{"href":"https://api.github.com/repos/openlayers/openlayers/pulls/9013"}}},"pull_request":{"url":"https://api.github.com/repos/openlayers/openlayers/pulls/9013","id":234319261,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzE5MjYx","html_url":"https://github.com/openlayers/openlayers/pull/9013","diff_url":"https://github.com/openlayers/openlayers/pull/9013.diff","patch_url":"https://github.com/openlayers/openlayers/pull/9013.patch","issue_url":"https://api.github.com/repos/openlayers/openlayers/issues/9013","number":9013,"state":"open","locked":false,"title":"Added scalebar option to ol.control.scaleline","user":{"login":"weskamm","id":1381363,"node_id":"MDQ6VXNlcjEzODEzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1381363?v=4","gravatar_id":"","url":"https://api.github.com/users/weskamm","html_url":"https://github.com/weskamm","followers_url":"https://api.github.com/users/weskamm/followers","following_url":"https://api.github.com/users/weskamm/following{/other_user}","gists_url":"https://api.github.com/users/weskamm/gists{/gist_id}","starred_url":"https://api.github.com/users/weskamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weskamm/subscriptions","organizations_url":"https://api.github.com/users/weskamm/orgs","repos_url":"https://api.github.com/users/weskamm/repos","events_url":"https://api.github.com/users/weskamm/events{/privacy}","received_events_url":"https://api.github.com/users/weskamm/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your interest in making OpenLayers better!\r\n\r\nBefore submitting a pull request, it is best to open an issue describing the bug you are fixing or the feature you are proposing to add.\r\n\r\nHere are some other tips that make pull requests easier to review:\r\n\r\n * Commits in the branch are small and logically separated (with no unnecessary merge commits).\r\n * Commit messages are clear.\r\n * Existing tests pass, new functionality is covered by new tests, and fixes have regression tests.\r\n\r\nThanks\r\n-->\r\nThis adds an option to show scalebars instead of a scaleline in the `ScaleLine` control.\r\n\r\n![scalebar](https://user-images.githubusercontent.com/1381363/49162174-9fcd2d80-f32a-11e8-94e5-bc3812d097ad.png)\r\n\r\nExample and API doc have been adjusted.","created_at":"2018-11-28T15:29:13Z","updated_at":"2018-11-28T15:40:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7615572c2b87fde9179f643058a995e7847cb7f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openlayers/openlayers/pulls/9013/commits","review_comments_url":"https://api.github.com/repos/openlayers/openlayers/pulls/9013/comments","review_comment_url":"https://api.github.com/repos/openlayers/openlayers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openlayers/openlayers/issues/9013/comments","statuses_url":"https://api.github.com/repos/openlayers/openlayers/statuses/97618c8611c88ede8d68e915dca1383eddda979c","head":{"label":"weskamm:scalebar","ref":"scalebar","sha":"97618c8611c88ede8d68e915dca1383eddda979c","user":{"login":"weskamm","id":1381363,"node_id":"MDQ6VXNlcjEzODEzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1381363?v=4","gravatar_id":"","url":"https://api.github.com/users/weskamm","html_url":"https://github.com/weskamm","followers_url":"https://api.github.com/users/weskamm/followers","following_url":"https://api.github.com/users/weskamm/following{/other_user}","gists_url":"https://api.github.com/users/weskamm/gists{/gist_id}","starred_url":"https://api.github.com/users/weskamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weskamm/subscriptions","organizations_url":"https://api.github.com/users/weskamm/orgs","repos_url":"https://api.github.com/users/weskamm/repos","events_url":"https://api.github.com/users/weskamm/events{/privacy}","received_events_url":"https://api.github.com/users/weskamm/received_events","type":"User","site_admin":false},"repo":{"id":41020935,"node_id":"MDEwOlJlcG9zaXRvcnk0MTAyMDkzNQ==","name":"ol3","full_name":"weskamm/ol3","private":false,"owner":{"login":"weskamm","id":1381363,"node_id":"MDQ6VXNlcjEzODEzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1381363?v=4","gravatar_id":"","url":"https://api.github.com/users/weskamm","html_url":"https://github.com/weskamm","followers_url":"https://api.github.com/users/weskamm/followers","following_url":"https://api.github.com/users/weskamm/following{/other_user}","gists_url":"https://api.github.com/users/weskamm/gists{/gist_id}","starred_url":"https://api.github.com/users/weskamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weskamm/subscriptions","organizations_url":"https://api.github.com/users/weskamm/orgs","repos_url":"https://api.github.com/users/weskamm/repos","events_url":"https://api.github.com/users/weskamm/events{/privacy}","received_events_url":"https://api.github.com/users/weskamm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/weskamm/ol3","description":"OpenLayers 3","fork":true,"url":"https://api.github.com/repos/weskamm/ol3","forks_url":"https://api.github.com/repos/weskamm/ol3/forks","keys_url":"https://api.github.com/repos/weskamm/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weskamm/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weskamm/ol3/teams","hooks_url":"https://api.github.com/repos/weskamm/ol3/hooks","issue_events_url":"https://api.github.com/repos/weskamm/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/weskamm/ol3/events","assignees_url":"https://api.github.com/repos/weskamm/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/weskamm/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/weskamm/ol3/tags","blobs_url":"https://api.github.com/repos/weskamm/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weskamm/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weskamm/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/weskamm/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weskamm/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/weskamm/ol3/languages","stargazers_url":"https://api.github.com/repos/weskamm/ol3/stargazers","contributors_url":"https://api.github.com/repos/weskamm/ol3/contributors","subscribers_url":"https://api.github.com/repos/weskamm/ol3/subscribers","subscription_url":"https://api.github.com/repos/weskamm/ol3/subscription","commits_url":"https://api.github.com/repos/weskamm/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/weskamm/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/weskamm/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/weskamm/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/weskamm/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/weskamm/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weskamm/ol3/merges","archive_url":"https://api.github.com/repos/weskamm/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weskamm/ol3/downloads","issues_url":"https://api.github.com/repos/weskamm/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/weskamm/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/weskamm/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/weskamm/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weskamm/ol3/labels{/name}","releases_url":"https://api.github.com/repos/weskamm/ol3/releases{/id}","deployments_url":"https://api.github.com/repos/weskamm/ol3/deployments","created_at":"2015-08-19T07:55:14Z","updated_at":"2015-08-19T07:55:17Z","pushed_at":"2018-11-28T15:26:00Z","git_url":"git://github.com/weskamm/ol3.git","ssh_url":"git@github.com:weskamm/ol3.git","clone_url":"https://github.com/weskamm/ol3.git","svn_url":"https://github.com/weskamm/ol3","homepage":"http://openlayers.org","size":31494,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openlayers:master","ref":"master","sha":"85abe3695a48b10e26a9bbf95144e81e5888f448","user":{"login":"openlayers","id":240579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MDU3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/240579?v=4","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"repo":{"id":4723248,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIzMjQ4","name":"openlayers","full_name":"openlayers/openlayers","private":false,"owner":{"login":"openlayers","id":240579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MDU3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/240579?v=4","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openlayers/openlayers","description":"OpenLayers","fork":false,"url":"https://api.github.com/repos/openlayers/openlayers","forks_url":"https://api.github.com/repos/openlayers/openlayers/forks","keys_url":"https://api.github.com/repos/openlayers/openlayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openlayers/openlayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openlayers/openlayers/teams","hooks_url":"https://api.github.com/repos/openlayers/openlayers/hooks","issue_events_url":"https://api.github.com/repos/openlayers/openlayers/issues/events{/number}","events_url":"https://api.github.com/repos/openlayers/openlayers/events","assignees_url":"https://api.github.com/repos/openlayers/openlayers/assignees{/user}","branches_url":"https://api.github.com/repos/openlayers/openlayers/branches{/branch}","tags_url":"https://api.github.com/repos/openlayers/openlayers/tags","blobs_url":"https://api.github.com/repos/openlayers/openlayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openlayers/openlayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openlayers/openlayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/openlayers/openlayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openlayers/openlayers/statuses/{sha}","languages_url":"https://api.github.com/repos/openlayers/openlayers/languages","stargazers_url":"https://api.github.com/repos/openlayers/openlayers/stargazers","contributors_url":"https://api.github.com/repos/openlayers/openlayers/contributors","subscribers_url":"https://api.github.com/repos/openlayers/openlayers/subscribers","subscription_url":"https://api.github.com/repos/openlayers/openlayers/subscription","commits_url":"https://api.github.com/repos/openlayers/openlayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/openlayers/openlayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/openlayers/openlayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/openlayers/openlayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/openlayers/openlayers/contents/{+path}","compare_url":"https://api.github.com/repos/openlayers/openlayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openlayers/openlayers/merges","archive_url":"https://api.github.com/repos/openlayers/openlayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openlayers/openlayers/downloads","issues_url":"https://api.github.com/repos/openlayers/openlayers/issues{/number}","pulls_url":"https://api.github.com/repos/openlayers/openlayers/pulls{/number}","milestones_url":"https://api.github.com/repos/openlayers/openlayers/milestones{/number}","notifications_url":"https://api.github.com/repos/openlayers/openlayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openlayers/openlayers/labels{/name}","releases_url":"https://api.github.com/repos/openlayers/openlayers/releases{/id}","deployments_url":"https://api.github.com/repos/openlayers/openlayers/deployments","created_at":"2012-06-20T06:53:59Z","updated_at":"2018-11-28T09:08:20Z","pushed_at":"2018-11-28T15:29:14Z","git_url":"git://github.com/openlayers/openlayers.git","ssh_url":"git@github.com:openlayers/openlayers.git","clone_url":"https://github.com/openlayers/openlayers.git","svn_url":"https://github.com/openlayers/openlayers","homepage":"https://openlayers.org","size":76161,"stargazers_count":4267,"watchers_count":4267,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1720,"mirror_url":null,"archived":false,"open_issues_count":610,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1720,"open_issues":610,"watchers":4267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openlayers/openlayers/pulls/9013"},"html":{"href":"https://github.com/openlayers/openlayers/pull/9013"},"issue":{"href":"https://api.github.com/repos/openlayers/openlayers/issues/9013"},"comments":{"href":"https://api.github.com/repos/openlayers/openlayers/issues/9013/comments"},"review_comments":{"href":"https://api.github.com/repos/openlayers/openlayers/pulls/9013/comments"},"review_comment":{"href":"https://api.github.com/repos/openlayers/openlayers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openlayers/openlayers/pulls/9013/commits"},"statuses":{"href":"https://api.github.com/repos/openlayers/openlayers/statuses/97618c8611c88ede8d68e915dca1383eddda979c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tschaub"}}