{"action":"created","comment":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/comments/185365860","pull_request_review_id":116739480,"id":185365860,"diff_hunk":"@@ -1,4 +1,5 @@\n ## Unreleased\n+- Set bucket bounds as le labels for Prometheus Stats exporter.","path":"CHANGELOG.md","position":2,"original_position":2,"commit_id":"f41b172dd6340b93b6816d9657d4ea8f253fb77a","original_commit_id":"fb4eedae1ea386699a95884d708b04380b31ab23","user":{"login":"songy23","id":10536136,"avatar_url":"https://avatars3.githubusercontent.com/u/10536136?v=4","gravatar_id":"","url":"https://api.github.com/users/songy23","html_url":"https://github.com/songy23","followers_url":"https://api.github.com/users/songy23/followers","following_url":"https://api.github.com/users/songy23/following{/other_user}","gists_url":"https://api.github.com/users/songy23/gists{/gist_id}","starred_url":"https://api.github.com/users/songy23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songy23/subscriptions","organizations_url":"https://api.github.com/users/songy23/orgs","repos_url":"https://api.github.com/users/songy23/repos","events_url":"https://api.github.com/users/songy23/events{/privacy}","received_events_url":"https://api.github.com/users/songy23/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-05-02T00:05:57Z","updated_at":"2018-05-02T00:35:15Z","html_url":"https://github.com/census-instrumentation/opencensus-java/pull/1167#discussion_r185365860","pull_request_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1167","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/comments/185365860"},"html":{"href":"https://github.com/census-instrumentation/opencensus-java/pull/1167#discussion_r185365860"},"pull_request":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1167"}},"in_reply_to_id":185345860},"pull_request":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1167","id":185048057,"html_url":"https://github.com/census-instrumentation/opencensus-java/pull/1167","diff_url":"https://github.com/census-instrumentation/opencensus-java/pull/1167.diff","patch_url":"https://github.com/census-instrumentation/opencensus-java/pull/1167.patch","issue_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues/1167","number":1167,"state":"open","locked":false,"title":"Set bucket bounds as le labels for Prometheus exporter.","user":{"login":"songy23","id":10536136,"avatar_url":"https://avatars3.githubusercontent.com/u/10536136?v=4","gravatar_id":"","url":"https://api.github.com/users/songy23","html_url":"https://github.com/songy23","followers_url":"https://api.github.com/users/songy23/followers","following_url":"https://api.github.com/users/songy23/following{/other_user}","gists_url":"https://api.github.com/users/songy23/gists{/gist_id}","starred_url":"https://api.github.com/users/songy23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songy23/subscriptions","organizations_url":"https://api.github.com/users/songy23/orgs","repos_url":"https://api.github.com/users/songy23/repos","events_url":"https://api.github.com/users/songy23/events{/privacy}","received_events_url":"https://api.github.com/users/songy23/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/census-instrumentation/opencensus-java/issues/1164.\r\n\r\nPreviously we don't set the bucket bounds for Prometheus `Sample`s, since bucket bounds is a [built-in feature](https://github.com/prometheus/client_java/blob/master/simpleclient/src/main/java/io/prometheus/client/Histogram.java#L329) for Prometheus Histogram. However, as https://github.com/census-instrumentation/opencensus-java/issues/1164 suggested, we can manually set the bucket bounds with the same label `le` that the built-in Histogram uses, to achieve the same output as the built-in Prometheus Histogram `Sample`s.\r\n\r\nPrometheus metrics page with this change:\r\n![image](https://user-images.githubusercontent.com/10536136/39446708-35da19f4-4c74-11e8-90da-37dc36ea0b54.png)\r\nWhich is the expected output for https://github.com/census-instrumentation/opencensus-java/issues/1164. ","created_at":"2018-04-30T19:53:37Z","updated_at":"2018-05-02T00:35:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e676f3b8fc9e1979139679dc2fa1a1582ad1ea37","assignee":{"login":"bogdandrutu","id":1373887,"avatar_url":"https://avatars0.githubusercontent.com/u/1373887?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false},"assignees":[{"login":"bogdandrutu","id":1373887,"avatar_url":"https://avatars0.githubusercontent.com/u/1373887?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false},{"login":"songy23","id":10536136,"avatar_url":"https://avatars3.githubusercontent.com/u/10536136?v=4","gravatar_id":"","url":"https://api.github.com/users/songy23","html_url":"https://github.com/songy23","followers_url":"https://api.github.com/users/songy23/followers","following_url":"https://api.github.com/users/songy23/following{/other_user}","gists_url":"https://api.github.com/users/songy23/gists{/gist_id}","starred_url":"https://api.github.com/users/songy23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songy23/subscriptions","organizations_url":"https://api.github.com/users/songy23/orgs","repos_url":"https://api.github.com/users/songy23/repos","events_url":"https://api.github.com/users/songy23/events{/privacy}","received_events_url":"https://api.github.com/users/songy23/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bogdandrutu","id":1373887,"avatar_url":"https://avatars0.githubusercontent.com/u/1373887?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":912770383,"url":"https://api.github.com/repos/census-instrumentation/opencensus-java/labels/action%20required","name":"action required","color":"6060ff","default":false},{"id":616301408,"url":"https://api.github.com/repos/census-instrumentation/opencensus-java/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false},{"id":415883751,"url":"https://api.github.com/repos/census-instrumentation/opencensus-java/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":678369455,"url":"https://api.github.com/repos/census-instrumentation/opencensus-java/labels/exporters","name":"exporters","color":"c2e0c6","default":false},{"id":566180202,"url":"https://api.github.com/repos/census-instrumentation/opencensus-java/labels/stats","name":"stats","color":"9919ff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1167/commits","review_comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1167/comments","review_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues/1167/comments","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/statuses/f41b172dd6340b93b6816d9657d4ea8f253fb77a","head":{"label":"songy23:prometheus-histogram","ref":"prometheus-histogram","sha":"f41b172dd6340b93b6816d9657d4ea8f253fb77a","user":{"login":"songy23","id":10536136,"avatar_url":"https://avatars3.githubusercontent.com/u/10536136?v=4","gravatar_id":"","url":"https://api.github.com/users/songy23","html_url":"https://github.com/songy23","followers_url":"https://api.github.com/users/songy23/followers","following_url":"https://api.github.com/users/songy23/following{/other_user}","gists_url":"https://api.github.com/users/songy23/gists{/gist_id}","starred_url":"https://api.github.com/users/songy23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songy23/subscriptions","organizations_url":"https://api.github.com/users/songy23/orgs","repos_url":"https://api.github.com/users/songy23/repos","events_url":"https://api.github.com/users/songy23/events{/privacy}","received_events_url":"https://api.github.com/users/songy23/received_events","type":"User","site_admin":false},"repo":{"id":83500104,"name":"instrumentation-java","full_name":"songy23/instrumentation-java","owner":{"login":"songy23","id":10536136,"avatar_url":"https://avatars3.githubusercontent.com/u/10536136?v=4","gravatar_id":"","url":"https://api.github.com/users/songy23","html_url":"https://github.com/songy23","followers_url":"https://api.github.com/users/songy23/followers","following_url":"https://api.github.com/users/songy23/following{/other_user}","gists_url":"https://api.github.com/users/songy23/gists{/gist_id}","starred_url":"https://api.github.com/users/songy23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songy23/subscriptions","organizations_url":"https://api.github.com/users/songy23/orgs","repos_url":"https://api.github.com/users/songy23/repos","events_url":"https://api.github.com/users/songy23/events{/privacy}","received_events_url":"https://api.github.com/users/songy23/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/songy23/instrumentation-java","description":"A stats collection framework","fork":true,"url":"https://api.github.com/repos/songy23/instrumentation-java","forks_url":"https://api.github.com/repos/songy23/instrumentation-java/forks","keys_url":"https://api.github.com/repos/songy23/instrumentation-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/songy23/instrumentation-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/songy23/instrumentation-java/teams","hooks_url":"https://api.github.com/repos/songy23/instrumentation-java/hooks","issue_events_url":"https://api.github.com/repos/songy23/instrumentation-java/issues/events{/number}","events_url":"https://api.github.com/repos/songy23/instrumentation-java/events","assignees_url":"https://api.github.com/repos/songy23/instrumentation-java/assignees{/user}","branches_url":"https://api.github.com/repos/songy23/instrumentation-java/branches{/branch}","tags_url":"https://api.github.com/repos/songy23/instrumentation-java/tags","blobs_url":"https://api.github.com/repos/songy23/instrumentation-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/songy23/instrumentation-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/songy23/instrumentation-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/songy23/instrumentation-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/songy23/instrumentation-java/statuses/{sha}","languages_url":"https://api.github.com/repos/songy23/instrumentation-java/languages","stargazers_url":"https://api.github.com/repos/songy23/instrumentation-java/stargazers","contributors_url":"https://api.github.com/repos/songy23/instrumentation-java/contributors","subscribers_url":"https://api.github.com/repos/songy23/instrumentation-java/subscribers","subscription_url":"https://api.github.com/repos/songy23/instrumentation-java/subscription","commits_url":"https://api.github.com/repos/songy23/instrumentation-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/songy23/instrumentation-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/songy23/instrumentation-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/songy23/instrumentation-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/songy23/instrumentation-java/contents/{+path}","compare_url":"https://api.github.com/repos/songy23/instrumentation-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/songy23/instrumentation-java/merges","archive_url":"https://api.github.com/repos/songy23/instrumentation-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/songy23/instrumentation-java/downloads","issues_url":"https://api.github.com/repos/songy23/instrumentation-java/issues{/number}","pulls_url":"https://api.github.com/repos/songy23/instrumentation-java/pulls{/number}","milestones_url":"https://api.github.com/repos/songy23/instrumentation-java/milestones{/number}","notifications_url":"https://api.github.com/repos/songy23/instrumentation-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/songy23/instrumentation-java/labels{/name}","releases_url":"https://api.github.com/repos/songy23/instrumentation-java/releases{/id}","deployments_url":"https://api.github.com/repos/songy23/instrumentation-java/deployments","created_at":"2017-03-01T02:03:46Z","updated_at":"2017-03-01T02:03:48Z","pushed_at":"2018-05-02T00:35:14Z","git_url":"git://github.com/songy23/instrumentation-java.git","ssh_url":"git@github.com:songy23/instrumentation-java.git","clone_url":"https://github.com/songy23/instrumentation-java.git","svn_url":"https://github.com/songy23/instrumentation-java","homepage":"","size":4673,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"census-instrumentation:master","ref":"master","sha":"25f0932fac496e42b70ebdc5d6d890bdb9f10c48","user":{"login":"census-instrumentation","id":26944525,"avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"repo":{"id":64431348,"name":"opencensus-java","full_name":"census-instrumentation/opencensus-java","owner":{"login":"census-instrumentation","id":26944525,"avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/census-instrumentation/opencensus-java","description":"A stats collection and distributed tracing framework","fork":false,"url":"https://api.github.com/repos/census-instrumentation/opencensus-java","forks_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/forks","keys_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/teams","hooks_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/hooks","issue_events_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues/events{/number}","events_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/events","assignees_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/assignees{/user}","branches_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/branches{/branch}","tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/tags","blobs_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/statuses/{sha}","languages_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/languages","stargazers_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/stargazers","contributors_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/contributors","subscribers_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/subscribers","subscription_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/subscription","commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/contents/{+path}","compare_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/merges","archive_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/downloads","issues_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues{/number}","pulls_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls{/number}","milestones_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/milestones{/number}","notifications_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/labels{/name}","releases_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/releases{/id}","deployments_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/deployments","created_at":"2016-07-28T22:10:03Z","updated_at":"2018-05-01T22:01:25Z","pushed_at":"2018-05-01T22:01:23Z","git_url":"git://github.com/census-instrumentation/opencensus-java.git","ssh_url":"git@github.com:census-instrumentation/opencensus-java.git","clone_url":"https://github.com/census-instrumentation/opencensus-java.git","svn_url":"https://github.com/census-instrumentation/opencensus-java","homepage":"https://opencensus.io","size":4625,"stargazers_count":356,"watchers_count":356,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":87,"open_issues":61,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1167"},"html":{"href":"https://github.com/census-instrumentation/opencensus-java/pull/1167"},"issue":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues/1167"},"comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues/1167/comments"},"review_comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1167/comments"},"review_comment":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1167/commits"},"statuses":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/statuses/f41b172dd6340b93b6816d9657d4ea8f253fb77a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"songy23"}}