{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/171650226","pull_request_review_id":100541785,"id":171650226,"diff_hunk":"@@ -3269,9 +3269,11 @@ napi_status napi_create_async_work(napi_env env,\n - `[in] async_resource_name`: Identifier for the kind of resource that is\n being provided for diagnostic information exposed by the `async_hooks` API.\n - `[in] execute`: The native function which should be called to excute\n-the logic asynchronously.\n+the logic asynchronously. The given function is called from a worker pool\n+thread and executes in parallel with the main event loop thread.\n - `[in] complete`: The native function which will be called when the\n-asynchronous logic is comple or is cancelled.\n+asynchronous logic is comple or is cancelled. The given function is called","path":"doc/api/n-api.md","position":9,"original_position":9,"commit_id":"ab63ce55583e5ede79dca151ecdb0cef23dea935","original_commit_id":"ab63ce55583e5ede79dca151ecdb0cef23dea935","user":{"login":"digitalinfinity","id":158390,"avatar_url":"https://avatars2.githubusercontent.com/u/158390?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalinfinity","html_url":"https://github.com/digitalinfinity","followers_url":"https://api.github.com/users/digitalinfinity/followers","following_url":"https://api.github.com/users/digitalinfinity/following{/other_user}","gists_url":"https://api.github.com/users/digitalinfinity/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalinfinity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalinfinity/subscriptions","organizations_url":"https://api.github.com/users/digitalinfinity/orgs","repos_url":"https://api.github.com/users/digitalinfinity/repos","events_url":"https://api.github.com/users/digitalinfinity/events{/privacy}","received_events_url":"https://api.github.com/users/digitalinfinity/received_events","type":"User","site_admin":false},"body":"should this be completed and not comple?","created_at":"2018-03-01T18:30:09Z","updated_at":"2018-03-01T18:30:09Z","html_url":"https://github.com/nodejs/node/pull/19073#discussion_r171650226","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/19073","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/171650226"},"html":{"href":"https://github.com/nodejs/node/pull/19073#discussion_r171650226"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/19073"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/19073","id":172314723,"html_url":"https://github.com/nodejs/node/pull/19073","diff_url":"https://github.com/nodejs/node/pull/19073.diff","patch_url":"https://github.com/nodejs/node/pull/19073.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/19073","number":19073,"state":"open","locked":false,"title":"doc: fix n-api asynchronous threading documentation","user":{"login":"ebickle","id":2086875,"avatar_url":"https://avatars2.githubusercontent.com/u/2086875?v=4","gravatar_id":"","url":"https://api.github.com/users/ebickle","html_url":"https://github.com/ebickle","followers_url":"https://api.github.com/users/ebickle/followers","following_url":"https://api.github.com/users/ebickle/following{/other_user}","gists_url":"https://api.github.com/users/ebickle/gists{/gist_id}","starred_url":"https://api.github.com/users/ebickle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebickle/subscriptions","organizations_url":"https://api.github.com/users/ebickle/orgs","repos_url":"https://api.github.com/users/ebickle/repos","events_url":"https://api.github.com/users/ebickle/events{/privacy}","received_events_url":"https://api.github.com/users/ebickle/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\nDocumentation for N-API Custom Asynchronous Operations incorrectly stated that async execution happens on the main event loop. Added details to napi_create_async_work about which threads are used to invoke the execute and complete callbacks.\r\n\r\nFixes: #19071\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ndoc","created_at":"2018-03-01T18:20:51Z","updated_at":"2018-03-01T18:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf07061eb9ebf1e229c426f4a37767a605920869","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267517,"url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false},{"id":311670452,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"eb6420","default":false},{"id":364533783,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"c2e0c6","default":false},{"id":574036893,"url":"https://api.github.com/repos/nodejs/node/labels/n-api","name":"n-api","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/19073/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/19073/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19073/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/ab63ce55583e5ede79dca151ecdb0cef23dea935","head":{"label":"ebickle:fix/napi-async-documentation","ref":"fix/napi-async-documentation","sha":"ab63ce55583e5ede79dca151ecdb0cef23dea935","user":{"login":"ebickle","id":2086875,"avatar_url":"https://avatars2.githubusercontent.com/u/2086875?v=4","gravatar_id":"","url":"https://api.github.com/users/ebickle","html_url":"https://github.com/ebickle","followers_url":"https://api.github.com/users/ebickle/followers","following_url":"https://api.github.com/users/ebickle/following{/other_user}","gists_url":"https://api.github.com/users/ebickle/gists{/gist_id}","starred_url":"https://api.github.com/users/ebickle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebickle/subscriptions","organizations_url":"https://api.github.com/users/ebickle/orgs","repos_url":"https://api.github.com/users/ebickle/repos","events_url":"https://api.github.com/users/ebickle/events{/privacy}","received_events_url":"https://api.github.com/users/ebickle/received_events","type":"User","site_admin":false},"repo":{"id":123454512,"name":"node","full_name":"ebickle/node","owner":{"login":"ebickle","id":2086875,"avatar_url":"https://avatars2.githubusercontent.com/u/2086875?v=4","gravatar_id":"","url":"https://api.github.com/users/ebickle","html_url":"https://github.com/ebickle","followers_url":"https://api.github.com/users/ebickle/followers","following_url":"https://api.github.com/users/ebickle/following{/other_user}","gists_url":"https://api.github.com/users/ebickle/gists{/gist_id}","starred_url":"https://api.github.com/users/ebickle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebickle/subscriptions","organizations_url":"https://api.github.com/users/ebickle/orgs","repos_url":"https://api.github.com/users/ebickle/repos","events_url":"https://api.github.com/users/ebickle/events{/privacy}","received_events_url":"https://api.github.com/users/ebickle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebickle/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/ebickle/node","forks_url":"https://api.github.com/repos/ebickle/node/forks","keys_url":"https://api.github.com/repos/ebickle/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebickle/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebickle/node/teams","hooks_url":"https://api.github.com/repos/ebickle/node/hooks","issue_events_url":"https://api.github.com/repos/ebickle/node/issues/events{/number}","events_url":"https://api.github.com/repos/ebickle/node/events","assignees_url":"https://api.github.com/repos/ebickle/node/assignees{/user}","branches_url":"https://api.github.com/repos/ebickle/node/branches{/branch}","tags_url":"https://api.github.com/repos/ebickle/node/tags","blobs_url":"https://api.github.com/repos/ebickle/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebickle/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebickle/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebickle/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebickle/node/statuses/{sha}","languages_url":"https://api.github.com/repos/ebickle/node/languages","stargazers_url":"https://api.github.com/repos/ebickle/node/stargazers","contributors_url":"https://api.github.com/repos/ebickle/node/contributors","subscribers_url":"https://api.github.com/repos/ebickle/node/subscribers","subscription_url":"https://api.github.com/repos/ebickle/node/subscription","commits_url":"https://api.github.com/repos/ebickle/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebickle/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebickle/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebickle/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebickle/node/contents/{+path}","compare_url":"https://api.github.com/repos/ebickle/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebickle/node/merges","archive_url":"https://api.github.com/repos/ebickle/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebickle/node/downloads","issues_url":"https://api.github.com/repos/ebickle/node/issues{/number}","pulls_url":"https://api.github.com/repos/ebickle/node/pulls{/number}","milestones_url":"https://api.github.com/repos/ebickle/node/milestones{/number}","notifications_url":"https://api.github.com/repos/ebickle/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebickle/node/labels{/name}","releases_url":"https://api.github.com/repos/ebickle/node/releases{/id}","deployments_url":"https://api.github.com/repos/ebickle/node/deployments","created_at":"2018-03-01T15:34:38Z","updated_at":"2018-03-01T15:35:06Z","pushed_at":"2018-03-01T18:19:14Z","git_url":"git://github.com/ebickle/node.git","ssh_url":"git@github.com:ebickle/node.git","clone_url":"https://github.com/ebickle/node.git","svn_url":"https://github.com/ebickle/node","homepage":"https://nodejs.org","size":350907,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"740c426b21dde1befa1dbae9bb01174a9e25b525","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-03-01T18:23:25Z","pushed_at":"2018-03-01T18:28:39Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":350915,"stargazers_count":45951,"watchers_count":45951,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9625,"mirror_url":null,"archived":false,"open_issues_count":819,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9625,"open_issues":819,"watchers":45951,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/19073"},"html":{"href":"https://github.com/nodejs/node/pull/19073"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/19073"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/19073/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/19073/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/19073/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/ab63ce55583e5ede79dca151ecdb0cef23dea935"}},"author_association":"NONE"}}
{"actor":{"display_login":"digitalinfinity"}}