{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/204258464","pull_request_review_id":139304783,"id":204258464,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDI1ODQ2NA==","diff_hunk":"@@ -95,11 +100,13 @@ def _worker_loop(dataset, index_queue, data_queue, collate_fn, seed, init_fn, wo\n         try:\n             r = index_queue.get(timeout=MANAGER_STATUS_CHECK_INTERVAL)\n         except queue.Empty:\n-            if watchdog.is_alive():\n+            if watchdog.is_alive() and not done_event.is_set():\n                 continue\n             else:\n                 break\n-        if r is None:\n+        # use done_event so that we can get faster exiting signal even if there\n+        # are still indices in index_queue\n+        if r is None or done_event.is_set():","path":"torch/utils/data/dataloader.py","position":33,"original_position":33,"commit_id":"30b8b2e0059ad2529b147adbe38c0d29d5a6f101","original_commit_id":"30b8b2e0059ad2529b147adbe38c0d29d5a6f101","user":{"login":"apaszke","id":4583066,"node_id":"MDQ6VXNlcjQ1ODMwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/4583066?v=4","gravatar_id":"","url":"https://api.github.com/users/apaszke","html_url":"https://github.com/apaszke","followers_url":"https://api.github.com/users/apaszke/followers","following_url":"https://api.github.com/users/apaszke/following{/other_user}","gists_url":"https://api.github.com/users/apaszke/gists{/gist_id}","starred_url":"https://api.github.com/users/apaszke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apaszke/subscriptions","organizations_url":"https://api.github.com/users/apaszke/orgs","repos_url":"https://api.github.com/users/apaszke/repos","events_url":"https://api.github.com/users/apaszke/events{/privacy}","received_events_url":"https://api.github.com/users/apaszke/received_events","type":"User","site_admin":false},"body":"Does this serve any purpose other than to make them exit faster? If yes, I'd rather not use it, as it complicates the whole protocol for no good reason.","created_at":"2018-07-22T23:10:07Z","updated_at":"2018-07-22T23:47:06Z","html_url":"https://github.com/pytorch/pytorch/pull/9655#discussion_r204258464","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/9655","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/204258464"},"html":{"href":"https://github.com/pytorch/pytorch/pull/9655#discussion_r204258464"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/9655"}}},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/9655","id":202946801,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTQ2ODAx","html_url":"https://github.com/pytorch/pytorch/pull/9655","diff_url":"https://github.com/pytorch/pytorch/pull/9655.diff","patch_url":"https://github.com/pytorch/pytorch/pull/9655.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/9655","number":9655,"state":"open","locked":false,"title":"Fix dataloader hang when it is not completely iterated","user":{"login":"SsnL","id":5674597,"node_id":"MDQ6VXNlcjU2NzQ1OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5674597?v=4","gravatar_id":"","url":"https://api.github.com/users/SsnL","html_url":"https://github.com/SsnL","followers_url":"https://api.github.com/users/SsnL/followers","following_url":"https://api.github.com/users/SsnL/following{/other_user}","gists_url":"https://api.github.com/users/SsnL/gists{/gist_id}","starred_url":"https://api.github.com/users/SsnL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SsnL/subscriptions","organizations_url":"https://api.github.com/users/SsnL/orgs","repos_url":"https://api.github.com/users/SsnL/repos","events_url":"https://api.github.com/users/SsnL/events{/privacy}","received_events_url":"https://api.github.com/users/SsnL/received_events","type":"User","site_admin":false},"body":"second trial of https://github.com/pytorch/pytorch/pull/7140\r\n\r\ncc @csarofeen Let's see if this works. It passes everything locally.","created_at":"2018-07-20T20:19:25Z","updated_at":"2018-07-22T23:47:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4e7217063780930fb6d771be985844785a2fcdd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ezyang","id":13564,"node_id":"MDQ6VXNlcjEzNTY0","avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},{"login":"zdevito","id":370202,"node_id":"MDQ6VXNlcjM3MDIwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/370202?v=4","gravatar_id":"","url":"https://api.github.com/users/zdevito","html_url":"https://github.com/zdevito","followers_url":"https://api.github.com/users/zdevito/followers","following_url":"https://api.github.com/users/zdevito/following{/other_user}","gists_url":"https://api.github.com/users/zdevito/gists{/gist_id}","starred_url":"https://api.github.com/users/zdevito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdevito/subscriptions","organizations_url":"https://api.github.com/users/zdevito/orgs","repos_url":"https://api.github.com/users/zdevito/repos","events_url":"https://api.github.com/users/zdevito/events{/privacy}","received_events_url":"https://api.github.com/users/zdevito/received_events","type":"User","site_admin":false},{"login":"colesbury","id":655866,"node_id":"MDQ6VXNlcjY1NTg2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/655866?v=4","gravatar_id":"","url":"https://api.github.com/users/colesbury","html_url":"https://github.com/colesbury","followers_url":"https://api.github.com/users/colesbury/followers","following_url":"https://api.github.com/users/colesbury/following{/other_user}","gists_url":"https://api.github.com/users/colesbury/gists{/gist_id}","starred_url":"https://api.github.com/users/colesbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colesbury/subscriptions","organizations_url":"https://api.github.com/users/colesbury/orgs","repos_url":"https://api.github.com/users/colesbury/repos","events_url":"https://api.github.com/users/colesbury/events{/privacy}","received_events_url":"https://api.github.com/users/colesbury/received_events","type":"User","site_admin":false},{"login":"soumith","id":1310570,"node_id":"MDQ6VXNlcjEzMTA1NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1310570?v=4","gravatar_id":"","url":"https://api.github.com/users/soumith","html_url":"https://github.com/soumith","followers_url":"https://api.github.com/users/soumith/followers","following_url":"https://api.github.com/users/soumith/following{/other_user}","gists_url":"https://api.github.com/users/soumith/gists{/gist_id}","starred_url":"https://api.github.com/users/soumith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumith/subscriptions","organizations_url":"https://api.github.com/users/soumith/orgs","repos_url":"https://api.github.com/users/soumith/repos","events_url":"https://api.github.com/users/soumith/events{/privacy}","received_events_url":"https://api.github.com/users/soumith/received_events","type":"User","site_admin":false},{"login":"gchanan","id":3768583,"node_id":"MDQ6VXNlcjM3Njg1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/3768583?v=4","gravatar_id":"","url":"https://api.github.com/users/gchanan","html_url":"https://github.com/gchanan","followers_url":"https://api.github.com/users/gchanan/followers","following_url":"https://api.github.com/users/gchanan/following{/other_user}","gists_url":"https://api.github.com/users/gchanan/gists{/gist_id}","starred_url":"https://api.github.com/users/gchanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchanan/subscriptions","organizations_url":"https://api.github.com/users/gchanan/orgs","repos_url":"https://api.github.com/users/gchanan/repos","events_url":"https://api.github.com/users/gchanan/events{/privacy}","received_events_url":"https://api.github.com/users/gchanan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/9655/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/9655/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/9655/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/30b8b2e0059ad2529b147adbe38c0d29d5a6f101","head":{"label":"SsnL:dl","ref":"dl","sha":"30b8b2e0059ad2529b147adbe38c0d29d5a6f101","user":{"login":"SsnL","id":5674597,"node_id":"MDQ6VXNlcjU2NzQ1OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5674597?v=4","gravatar_id":"","url":"https://api.github.com/users/SsnL","html_url":"https://github.com/SsnL","followers_url":"https://api.github.com/users/SsnL/followers","following_url":"https://api.github.com/users/SsnL/following{/other_user}","gists_url":"https://api.github.com/users/SsnL/gists{/gist_id}","starred_url":"https://api.github.com/users/SsnL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SsnL/subscriptions","organizations_url":"https://api.github.com/users/SsnL/orgs","repos_url":"https://api.github.com/users/SsnL/repos","events_url":"https://api.github.com/users/SsnL/events{/privacy}","received_events_url":"https://api.github.com/users/SsnL/received_events","type":"User","site_admin":false},"repo":{"id":103305558,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMzMDU1NTg=","name":"pytorch","full_name":"SsnL/pytorch","owner":{"login":"SsnL","id":5674597,"node_id":"MDQ6VXNlcjU2NzQ1OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5674597?v=4","gravatar_id":"","url":"https://api.github.com/users/SsnL","html_url":"https://github.com/SsnL","followers_url":"https://api.github.com/users/SsnL/followers","following_url":"https://api.github.com/users/SsnL/following{/other_user}","gists_url":"https://api.github.com/users/SsnL/gists{/gist_id}","starred_url":"https://api.github.com/users/SsnL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SsnL/subscriptions","organizations_url":"https://api.github.com/users/SsnL/orgs","repos_url":"https://api.github.com/users/SsnL/repos","events_url":"https://api.github.com/users/SsnL/events{/privacy}","received_events_url":"https://api.github.com/users/SsnL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SsnL/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/SsnL/pytorch","forks_url":"https://api.github.com/repos/SsnL/pytorch/forks","keys_url":"https://api.github.com/repos/SsnL/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SsnL/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SsnL/pytorch/teams","hooks_url":"https://api.github.com/repos/SsnL/pytorch/hooks","issue_events_url":"https://api.github.com/repos/SsnL/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/SsnL/pytorch/events","assignees_url":"https://api.github.com/repos/SsnL/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/SsnL/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/SsnL/pytorch/tags","blobs_url":"https://api.github.com/repos/SsnL/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SsnL/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SsnL/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/SsnL/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SsnL/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/SsnL/pytorch/languages","stargazers_url":"https://api.github.com/repos/SsnL/pytorch/stargazers","contributors_url":"https://api.github.com/repos/SsnL/pytorch/contributors","subscribers_url":"https://api.github.com/repos/SsnL/pytorch/subscribers","subscription_url":"https://api.github.com/repos/SsnL/pytorch/subscription","commits_url":"https://api.github.com/repos/SsnL/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/SsnL/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/SsnL/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/SsnL/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/SsnL/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/SsnL/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SsnL/pytorch/merges","archive_url":"https://api.github.com/repos/SsnL/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SsnL/pytorch/downloads","issues_url":"https://api.github.com/repos/SsnL/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/SsnL/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/SsnL/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/SsnL/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SsnL/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/SsnL/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/SsnL/pytorch/deployments","created_at":"2017-09-12T18:13:43Z","updated_at":"2018-07-20T18:23:28Z","pushed_at":"2018-07-22T16:11:41Z","git_url":"git://github.com/SsnL/pytorch.git","ssh_url":"git@github.com:SsnL/pytorch.git","clone_url":"https://github.com/SsnL/pytorch.git","svn_url":"https://github.com/SsnL/pytorch","homepage":"http://pytorch.org","size":63460,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"3bb8c5eab1029a7de971b7368e43be06ef97182d","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-07-22T23:06:33Z","pushed_at":"2018-07-22T23:43:44Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":64246,"stargazers_count":17265,"watchers_count":17265,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4026,"mirror_url":null,"archived":false,"open_issues_count":1489,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4026,"open_issues":1489,"watchers":17265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/9655"},"html":{"href":"https://github.com/pytorch/pytorch/pull/9655"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/9655"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/9655/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/9655/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/9655/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/30b8b2e0059ad2529b147adbe38c0d29d5a6f101"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"apaszke"}}