{"action":"created","comment":{"url":"https://api.github.com/repos/rancher/rancher/pulls/comments/183130775","pull_request_review_id":114076990,"id":183130775,"diff_hunk":"@@ -703,6 +697,46 @@ func newKibanaDeployment(namespace string) *v1beta2.Deployment {\n \treturn deployment\n }\n \n+func UpdateEmbeddedEndpointWithRetry(deploymentLister rv1beta2.DeploymentLister, podLister rv1.PodLister, serviceLister rv1.ServiceLister, clusterLoggings v3.ClusterLoggingInterface, nodeLister v3.NodeLister, clusterName string, logger logstream.LoggerStream) error {\n+\ttimeout := time.After(3 * time.Minute)\n+\tticker := time.NewTicker(10 * time.Second)\n+\n+\twg := sync.WaitGroup{}\n+\twg.Add(1)\n+\tupdated := false\n+\terrCh := make(chan error, 18)\n+\tgo func() {\n+\t\tdefer wg.Done()\n+\t\tfor {\n+\t\t\tselect {\n+\t\t\tcase <-ticker.C:","path":"pkg/controllers/user/logging/utils/embedded.go","position":220,"original_position":220,"commit_id":"7ed249231e65a12a0acbde4558b426a7e7ed572a","original_commit_id":"7ed249231e65a12a0acbde4558b426a7e7ed572a","user":{"login":"alena1108","id":1562176,"avatar_url":"https://avatars0.githubusercontent.com/u/1562176?v=4","gravatar_id":"","url":"https://api.github.com/users/alena1108","html_url":"https://github.com/alena1108","followers_url":"https://api.github.com/users/alena1108/followers","following_url":"https://api.github.com/users/alena1108/following{/other_user}","gists_url":"https://api.github.com/users/alena1108/gists{/gist_id}","starred_url":"https://api.github.com/users/alena1108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alena1108/subscriptions","organizations_url":"https://api.github.com/users/alena1108/orgs","repos_url":"https://api.github.com/users/alena1108/repos","events_url":"https://api.github.com/users/alena1108/events{/privacy}","received_events_url":"https://api.github.com/users/alena1108/received_events","type":"User","site_admin":false},"body":"we should pass ctx to ticker somehow. So when rancher goes down, ticker has to be notified. You can find some examples in Rancher code on how to do it.","created_at":"2018-04-20T18:13:50Z","updated_at":"2018-04-20T18:13:50Z","html_url":"https://github.com/rancher/rancher/pull/12714#discussion_r183130775","pull_request_url":"https://api.github.com/repos/rancher/rancher/pulls/12714","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/rancher/rancher/pulls/comments/183130775"},"html":{"href":"https://github.com/rancher/rancher/pull/12714#discussion_r183130775"},"pull_request":{"href":"https://api.github.com/repos/rancher/rancher/pulls/12714"}}},"pull_request":{"url":"https://api.github.com/repos/rancher/rancher/pulls/12714","id":181706190,"html_url":"https://github.com/rancher/rancher/pull/12714","diff_url":"https://github.com/rancher/rancher/pull/12714.diff","patch_url":"https://github.com/rancher/rancher/pull/12714.patch","issue_url":"https://api.github.com/repos/rancher/rancher/issues/12714","number":12714,"state":"open","locked":false,"title":"Improve logging","user":{"login":"aiwantaozi","id":5936271,"avatar_url":"https://avatars0.githubusercontent.com/u/5936271?v=4","gravatar_id":"","url":"https://api.github.com/users/aiwantaozi","html_url":"https://github.com/aiwantaozi","followers_url":"https://api.github.com/users/aiwantaozi/followers","following_url":"https://api.github.com/users/aiwantaozi/following{/other_user}","gists_url":"https://api.github.com/users/aiwantaozi/gists{/gist_id}","starred_url":"https://api.github.com/users/aiwantaozi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiwantaozi/subscriptions","organizations_url":"https://api.github.com/users/aiwantaozi/orgs","repos_url":"https://api.github.com/users/aiwantaozi/repos","events_url":"https://api.github.com/users/aiwantaozi/events{/privacy}","received_events_url":"https://api.github.com/users/aiwantaozi/received_events","type":"User","site_admin":false},"body":"improve logging\r\n1. update embedded default request resource quota higher, use optimized jvm option\r\n2. use external ip in embedded\r\n3. add condition in logging.\r\n\r\nRelated types: https://github.com/rancher/types/pull/370\r\nRelated issue: \r\nhttps://github.com/rancher/rancher/issues/12631\r\nhttps://github.com/rancher/rancher/issues/11676\r\n","created_at":"2018-04-15T15:58:49Z","updated_at":"2018-04-20T18:13:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1b5d51c455ca74bae1197788cc3e85bbb2e8fd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rancher/rancher/pulls/12714/commits","review_comments_url":"https://api.github.com/repos/rancher/rancher/pulls/12714/comments","review_comment_url":"https://api.github.com/repos/rancher/rancher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/rancher/issues/12714/comments","statuses_url":"https://api.github.com/repos/rancher/rancher/statuses/7ed249231e65a12a0acbde4558b426a7e7ed572a","head":{"label":"aiwantaozi:improve_logging","ref":"improve_logging","sha":"7ed249231e65a12a0acbde4558b426a7e7ed572a","user":{"login":"aiwantaozi","id":5936271,"avatar_url":"https://avatars0.githubusercontent.com/u/5936271?v=4","gravatar_id":"","url":"https://api.github.com/users/aiwantaozi","html_url":"https://github.com/aiwantaozi","followers_url":"https://api.github.com/users/aiwantaozi/followers","following_url":"https://api.github.com/users/aiwantaozi/following{/other_user}","gists_url":"https://api.github.com/users/aiwantaozi/gists{/gist_id}","starred_url":"https://api.github.com/users/aiwantaozi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiwantaozi/subscriptions","organizations_url":"https://api.github.com/users/aiwantaozi/orgs","repos_url":"https://api.github.com/users/aiwantaozi/repos","events_url":"https://api.github.com/users/aiwantaozi/events{/privacy}","received_events_url":"https://api.github.com/users/aiwantaozi/received_events","type":"User","site_admin":false},"repo":{"id":104641102,"name":"rancher","full_name":"aiwantaozi/rancher","owner":{"login":"aiwantaozi","id":5936271,"avatar_url":"https://avatars0.githubusercontent.com/u/5936271?v=4","gravatar_id":"","url":"https://api.github.com/users/aiwantaozi","html_url":"https://github.com/aiwantaozi","followers_url":"https://api.github.com/users/aiwantaozi/followers","following_url":"https://api.github.com/users/aiwantaozi/following{/other_user}","gists_url":"https://api.github.com/users/aiwantaozi/gists{/gist_id}","starred_url":"https://api.github.com/users/aiwantaozi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiwantaozi/subscriptions","organizations_url":"https://api.github.com/users/aiwantaozi/orgs","repos_url":"https://api.github.com/users/aiwantaozi/repos","events_url":"https://api.github.com/users/aiwantaozi/events{/privacy}","received_events_url":"https://api.github.com/users/aiwantaozi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aiwantaozi/rancher","description":"Complete container management platform","fork":true,"url":"https://api.github.com/repos/aiwantaozi/rancher","forks_url":"https://api.github.com/repos/aiwantaozi/rancher/forks","keys_url":"https://api.github.com/repos/aiwantaozi/rancher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aiwantaozi/rancher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aiwantaozi/rancher/teams","hooks_url":"https://api.github.com/repos/aiwantaozi/rancher/hooks","issue_events_url":"https://api.github.com/repos/aiwantaozi/rancher/issues/events{/number}","events_url":"https://api.github.com/repos/aiwantaozi/rancher/events","assignees_url":"https://api.github.com/repos/aiwantaozi/rancher/assignees{/user}","branches_url":"https://api.github.com/repos/aiwantaozi/rancher/branches{/branch}","tags_url":"https://api.github.com/repos/aiwantaozi/rancher/tags","blobs_url":"https://api.github.com/repos/aiwantaozi/rancher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aiwantaozi/rancher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aiwantaozi/rancher/git/refs{/sha}","trees_url":"https://api.github.com/repos/aiwantaozi/rancher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aiwantaozi/rancher/statuses/{sha}","languages_url":"https://api.github.com/repos/aiwantaozi/rancher/languages","stargazers_url":"https://api.github.com/repos/aiwantaozi/rancher/stargazers","contributors_url":"https://api.github.com/repos/aiwantaozi/rancher/contributors","subscribers_url":"https://api.github.com/repos/aiwantaozi/rancher/subscribers","subscription_url":"https://api.github.com/repos/aiwantaozi/rancher/subscription","commits_url":"https://api.github.com/repos/aiwantaozi/rancher/commits{/sha}","git_commits_url":"https://api.github.com/repos/aiwantaozi/rancher/git/commits{/sha}","comments_url":"https://api.github.com/repos/aiwantaozi/rancher/comments{/number}","issue_comment_url":"https://api.github.com/repos/aiwantaozi/rancher/issues/comments{/number}","contents_url":"https://api.github.com/repos/aiwantaozi/rancher/contents/{+path}","compare_url":"https://api.github.com/repos/aiwantaozi/rancher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aiwantaozi/rancher/merges","archive_url":"https://api.github.com/repos/aiwantaozi/rancher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aiwantaozi/rancher/downloads","issues_url":"https://api.github.com/repos/aiwantaozi/rancher/issues{/number}","pulls_url":"https://api.github.com/repos/aiwantaozi/rancher/pulls{/number}","milestones_url":"https://api.github.com/repos/aiwantaozi/rancher/milestones{/number}","notifications_url":"https://api.github.com/repos/aiwantaozi/rancher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aiwantaozi/rancher/labels{/name}","releases_url":"https://api.github.com/repos/aiwantaozi/rancher/releases{/id}","deployments_url":"https://api.github.com/repos/aiwantaozi/rancher/deployments","created_at":"2017-09-24T12:09:38Z","updated_at":"2017-09-24T12:09:45Z","pushed_at":"2018-04-20T12:59:31Z","git_url":"git://github.com/aiwantaozi/rancher.git","ssh_url":"git@github.com:aiwantaozi/rancher.git","clone_url":"https://github.com/aiwantaozi/rancher.git","svn_url":"https://github.com/aiwantaozi/rancher","homepage":"http://rancher.com","size":56596,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancher:master","ref":"master","sha":"ad6b7e7ddb14b182ceae93326a498f784b956020","user":{"login":"rancher","id":9343010,"avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":26337322,"name":"rancher","full_name":"rancher/rancher","owner":{"login":"rancher","id":9343010,"avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancher/rancher","description":"Complete container management platform","fork":false,"url":"https://api.github.com/repos/rancher/rancher","forks_url":"https://api.github.com/repos/rancher/rancher/forks","keys_url":"https://api.github.com/repos/rancher/rancher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/rancher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/rancher/teams","hooks_url":"https://api.github.com/repos/rancher/rancher/hooks","issue_events_url":"https://api.github.com/repos/rancher/rancher/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/rancher/events","assignees_url":"https://api.github.com/repos/rancher/rancher/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/rancher/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/rancher/tags","blobs_url":"https://api.github.com/repos/rancher/rancher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/rancher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/rancher/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/rancher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/rancher/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/rancher/languages","stargazers_url":"https://api.github.com/repos/rancher/rancher/stargazers","contributors_url":"https://api.github.com/repos/rancher/rancher/contributors","subscribers_url":"https://api.github.com/repos/rancher/rancher/subscribers","subscription_url":"https://api.github.com/repos/rancher/rancher/subscription","commits_url":"https://api.github.com/repos/rancher/rancher/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/rancher/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/rancher/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/rancher/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/rancher/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/rancher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/rancher/merges","archive_url":"https://api.github.com/repos/rancher/rancher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/rancher/downloads","issues_url":"https://api.github.com/repos/rancher/rancher/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/rancher/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/rancher/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/rancher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/rancher/labels{/name}","releases_url":"https://api.github.com/repos/rancher/rancher/releases{/id}","deployments_url":"https://api.github.com/repos/rancher/rancher/deployments","created_at":"2014-11-07T20:49:31Z","updated_at":"2018-04-20T18:06:19Z","pushed_at":"2018-04-20T18:10:18Z","git_url":"git://github.com/rancher/rancher.git","ssh_url":"git@github.com:rancher/rancher.git","clone_url":"https://github.com/rancher/rancher.git","svn_url":"https://github.com/rancher/rancher","homepage":"http://rancher.com","size":32244,"stargazers_count":8204,"watchers_count":8204,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":813,"mirror_url":null,"archived":false,"open_issues_count":1957,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":813,"open_issues":1957,"watchers":8204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/rancher/pulls/12714"},"html":{"href":"https://github.com/rancher/rancher/pull/12714"},"issue":{"href":"https://api.github.com/repos/rancher/rancher/issues/12714"},"comments":{"href":"https://api.github.com/repos/rancher/rancher/issues/12714/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/rancher/pulls/12714/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/rancher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/rancher/pulls/12714/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/rancher/statuses/7ed249231e65a12a0acbde4558b426a7e7ed572a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alena1108"}}