{"action":"created","comment":{"url":"https://api.github.com/repos/container-storage-interface/spec/pulls/comments/226478893","pull_request_review_id":166311826,"id":226478893,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjQ3ODg5Mw==","diff_hunk":"@@ -673,10 +681,10 @@ message CreateVolumeRequest {\n   // topological accessibility information supported by the SP.\n   // This field is OPTIONAL.\n   // This field SHALL NOT be specified unless the SP has the\n-  // ACCESSIBILITY_CONSTRAINTS plugin capability.\n+  // VOLUME_ACCESSIBILITY_CONSTRAINTS plugin capability.\n   // If this field is not specified and the SP has the\n-  // ACCESSIBILITY_CONSTRAINTS plugin capability, the SP MAY choose\n-  // where the provisioned volume is accessible from.\n+  // VOLUME_ACCESSIBILITY_CONSTRAINTS plugin capability, the SP MAY\n+  // choose where the provisioned volume is accessible from.\n   TopologyRequirement accessibility_requirements = 7;","path":"spec.md","position":36,"original_position":36,"commit_id":"0dbe60518aacc7c1ed279eff70345fdfa5cb455d","original_commit_id":"0dbe60518aacc7c1ed279eff70345fdfa5cb455d","user":{"login":"jdef","id":2348332,"node_id":"MDQ6VXNlcjIzNDgzMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2348332?v=4","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"body":"In other words, simply adding \"or snapshot\" to the existing set of documentation (as has been done throughout the PR here) probably isn't sufficient.","created_at":"2018-10-18T21:56:51Z","updated_at":"2018-10-18T21:58:36Z","html_url":"https://github.com/container-storage-interface/spec/pull/274#discussion_r226478893","pull_request_url":"https://api.github.com/repos/container-storage-interface/spec/pulls/274","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/container-storage-interface/spec/pulls/comments/226478893"},"html":{"href":"https://github.com/container-storage-interface/spec/pull/274#discussion_r226478893"},"pull_request":{"href":"https://api.github.com/repos/container-storage-interface/spec/pulls/274"}},"in_reply_to_id":226478549},"pull_request":{"url":"https://api.github.com/repos/container-storage-interface/spec/pulls/274","id":221130247,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTMwMjQ3","html_url":"https://github.com/container-storage-interface/spec/pull/274","diff_url":"https://github.com/container-storage-interface/spec/pull/274.diff","patch_url":"https://github.com/container-storage-interface/spec/pull/274.patch","issue_url":"https://api.github.com/repos/container-storage-interface/spec/issues/274","number":274,"state":"open","locked":false,"title":"Add Topology for Snapshot","user":{"login":"xing-yang","id":1185309,"node_id":"MDQ6VXNlcjExODUzMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1185309?v=4","gravatar_id":"","url":"https://api.github.com/users/xing-yang","html_url":"https://github.com/xing-yang","followers_url":"https://api.github.com/users/xing-yang/followers","following_url":"https://api.github.com/users/xing-yang/following{/other_user}","gists_url":"https://api.github.com/users/xing-yang/gists{/gist_id}","starred_url":"https://api.github.com/users/xing-yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xing-yang/subscriptions","organizations_url":"https://api.github.com/users/xing-yang/orgs","repos_url":"https://api.github.com/users/xing-yang/repos","events_url":"https://api.github.com/users/xing-yang/events{/privacy}","received_events_url":"https://api.github.com/users/xing-yang/received_events","type":"User","site_admin":false},"body":"This PR adds topology requirements for snapshots.","created_at":"2018-10-08T14:06:14Z","updated_at":"2018-10-18T21:58:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ff55a1159eaf90eb7aac303eba7265acc2e619b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/container-storage-interface/spec/pulls/274/commits","review_comments_url":"https://api.github.com/repos/container-storage-interface/spec/pulls/274/comments","review_comment_url":"https://api.github.com/repos/container-storage-interface/spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/container-storage-interface/spec/issues/274/comments","statuses_url":"https://api.github.com/repos/container-storage-interface/spec/statuses/0dbe60518aacc7c1ed279eff70345fdfa5cb455d","head":{"label":"xing-yang:topology","ref":"topology","sha":"0dbe60518aacc7c1ed279eff70345fdfa5cb455d","user":{"login":"xing-yang","id":1185309,"node_id":"MDQ6VXNlcjExODUzMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1185309?v=4","gravatar_id":"","url":"https://api.github.com/users/xing-yang","html_url":"https://github.com/xing-yang","followers_url":"https://api.github.com/users/xing-yang/followers","following_url":"https://api.github.com/users/xing-yang/following{/other_user}","gists_url":"https://api.github.com/users/xing-yang/gists{/gist_id}","starred_url":"https://api.github.com/users/xing-yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xing-yang/subscriptions","organizations_url":"https://api.github.com/users/xing-yang/orgs","repos_url":"https://api.github.com/users/xing-yang/repos","events_url":"https://api.github.com/users/xing-yang/events{/privacy}","received_events_url":"https://api.github.com/users/xing-yang/received_events","type":"User","site_admin":false},"repo":{"id":119099401,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkwOTk0MDE=","name":"spec","full_name":"xing-yang/spec","private":false,"owner":{"login":"xing-yang","id":1185309,"node_id":"MDQ6VXNlcjExODUzMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1185309?v=4","gravatar_id":"","url":"https://api.github.com/users/xing-yang","html_url":"https://github.com/xing-yang","followers_url":"https://api.github.com/users/xing-yang/followers","following_url":"https://api.github.com/users/xing-yang/following{/other_user}","gists_url":"https://api.github.com/users/xing-yang/gists{/gist_id}","starred_url":"https://api.github.com/users/xing-yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xing-yang/subscriptions","organizations_url":"https://api.github.com/users/xing-yang/orgs","repos_url":"https://api.github.com/users/xing-yang/repos","events_url":"https://api.github.com/users/xing-yang/events{/privacy}","received_events_url":"https://api.github.com/users/xing-yang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xing-yang/spec","description":"Container Storage Interface (CSI) Specification.","fork":true,"url":"https://api.github.com/repos/xing-yang/spec","forks_url":"https://api.github.com/repos/xing-yang/spec/forks","keys_url":"https://api.github.com/repos/xing-yang/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xing-yang/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xing-yang/spec/teams","hooks_url":"https://api.github.com/repos/xing-yang/spec/hooks","issue_events_url":"https://api.github.com/repos/xing-yang/spec/issues/events{/number}","events_url":"https://api.github.com/repos/xing-yang/spec/events","assignees_url":"https://api.github.com/repos/xing-yang/spec/assignees{/user}","branches_url":"https://api.github.com/repos/xing-yang/spec/branches{/branch}","tags_url":"https://api.github.com/repos/xing-yang/spec/tags","blobs_url":"https://api.github.com/repos/xing-yang/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xing-yang/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xing-yang/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/xing-yang/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xing-yang/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/xing-yang/spec/languages","stargazers_url":"https://api.github.com/repos/xing-yang/spec/stargazers","contributors_url":"https://api.github.com/repos/xing-yang/spec/contributors","subscribers_url":"https://api.github.com/repos/xing-yang/spec/subscribers","subscription_url":"https://api.github.com/repos/xing-yang/spec/subscription","commits_url":"https://api.github.com/repos/xing-yang/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/xing-yang/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/xing-yang/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/xing-yang/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/xing-yang/spec/contents/{+path}","compare_url":"https://api.github.com/repos/xing-yang/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xing-yang/spec/merges","archive_url":"https://api.github.com/repos/xing-yang/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xing-yang/spec/downloads","issues_url":"https://api.github.com/repos/xing-yang/spec/issues{/number}","pulls_url":"https://api.github.com/repos/xing-yang/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/xing-yang/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/xing-yang/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xing-yang/spec/labels{/name}","releases_url":"https://api.github.com/repos/xing-yang/spec/releases{/id}","deployments_url":"https://api.github.com/repos/xing-yang/spec/deployments","created_at":"2018-01-26T20:24:00Z","updated_at":"2018-01-26T20:24:02Z","pushed_at":"2018-10-15T19:42:44Z","git_url":"git://github.com/xing-yang/spec.git","ssh_url":"git@github.com:xing-yang/spec.git","clone_url":"https://github.com/xing-yang/spec.git","svn_url":"https://github.com/xing-yang/spec","homepage":"","size":817,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"container-storage-interface:master","ref":"master","sha":"7c6a627de8a3e680931b41ea58dcc3a379329704","user":{"login":"container-storage-interface","id":28406793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NDA2Nzkz","avatar_url":"https://avatars1.githubusercontent.com/u/28406793?v=4","gravatar_id":"","url":"https://api.github.com/users/container-storage-interface","html_url":"https://github.com/container-storage-interface","followers_url":"https://api.github.com/users/container-storage-interface/followers","following_url":"https://api.github.com/users/container-storage-interface/following{/other_user}","gists_url":"https://api.github.com/users/container-storage-interface/gists{/gist_id}","starred_url":"https://api.github.com/users/container-storage-interface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/container-storage-interface/subscriptions","organizations_url":"https://api.github.com/users/container-storage-interface/orgs","repos_url":"https://api.github.com/users/container-storage-interface/repos","events_url":"https://api.github.com/users/container-storage-interface/events{/privacy}","received_events_url":"https://api.github.com/users/container-storage-interface/received_events","type":"Organization","site_admin":false},"repo":{"id":91765224,"node_id":"MDEwOlJlcG9zaXRvcnk5MTc2NTIyNA==","name":"spec","full_name":"container-storage-interface/spec","private":false,"owner":{"login":"container-storage-interface","id":28406793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NDA2Nzkz","avatar_url":"https://avatars1.githubusercontent.com/u/28406793?v=4","gravatar_id":"","url":"https://api.github.com/users/container-storage-interface","html_url":"https://github.com/container-storage-interface","followers_url":"https://api.github.com/users/container-storage-interface/followers","following_url":"https://api.github.com/users/container-storage-interface/following{/other_user}","gists_url":"https://api.github.com/users/container-storage-interface/gists{/gist_id}","starred_url":"https://api.github.com/users/container-storage-interface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/container-storage-interface/subscriptions","organizations_url":"https://api.github.com/users/container-storage-interface/orgs","repos_url":"https://api.github.com/users/container-storage-interface/repos","events_url":"https://api.github.com/users/container-storage-interface/events{/privacy}","received_events_url":"https://api.github.com/users/container-storage-interface/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/container-storage-interface/spec","description":"Container Storage Interface (CSI) Specification.","fork":false,"url":"https://api.github.com/repos/container-storage-interface/spec","forks_url":"https://api.github.com/repos/container-storage-interface/spec/forks","keys_url":"https://api.github.com/repos/container-storage-interface/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/container-storage-interface/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/container-storage-interface/spec/teams","hooks_url":"https://api.github.com/repos/container-storage-interface/spec/hooks","issue_events_url":"https://api.github.com/repos/container-storage-interface/spec/issues/events{/number}","events_url":"https://api.github.com/repos/container-storage-interface/spec/events","assignees_url":"https://api.github.com/repos/container-storage-interface/spec/assignees{/user}","branches_url":"https://api.github.com/repos/container-storage-interface/spec/branches{/branch}","tags_url":"https://api.github.com/repos/container-storage-interface/spec/tags","blobs_url":"https://api.github.com/repos/container-storage-interface/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/container-storage-interface/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/container-storage-interface/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/container-storage-interface/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/container-storage-interface/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/container-storage-interface/spec/languages","stargazers_url":"https://api.github.com/repos/container-storage-interface/spec/stargazers","contributors_url":"https://api.github.com/repos/container-storage-interface/spec/contributors","subscribers_url":"https://api.github.com/repos/container-storage-interface/spec/subscribers","subscription_url":"https://api.github.com/repos/container-storage-interface/spec/subscription","commits_url":"https://api.github.com/repos/container-storage-interface/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/container-storage-interface/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/container-storage-interface/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/container-storage-interface/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/container-storage-interface/spec/contents/{+path}","compare_url":"https://api.github.com/repos/container-storage-interface/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/container-storage-interface/spec/merges","archive_url":"https://api.github.com/repos/container-storage-interface/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/container-storage-interface/spec/downloads","issues_url":"https://api.github.com/repos/container-storage-interface/spec/issues{/number}","pulls_url":"https://api.github.com/repos/container-storage-interface/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/container-storage-interface/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/container-storage-interface/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/container-storage-interface/spec/labels{/name}","releases_url":"https://api.github.com/repos/container-storage-interface/spec/releases{/id}","deployments_url":"https://api.github.com/repos/container-storage-interface/spec/deployments","created_at":"2017-05-19T04:23:40Z","updated_at":"2018-10-18T21:58:28Z","pushed_at":"2018-10-15T19:42:45Z","git_url":"git://github.com/container-storage-interface/spec.git","ssh_url":"git@github.com:container-storage-interface/spec.git","clone_url":"https://github.com/container-storage-interface/spec.git","svn_url":"https://github.com/container-storage-interface/spec","homepage":"","size":789,"stargazers_count":278,"watchers_count":278,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":73,"open_issues":90,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/container-storage-interface/spec/pulls/274"},"html":{"href":"https://github.com/container-storage-interface/spec/pull/274"},"issue":{"href":"https://api.github.com/repos/container-storage-interface/spec/issues/274"},"comments":{"href":"https://api.github.com/repos/container-storage-interface/spec/issues/274/comments"},"review_comments":{"href":"https://api.github.com/repos/container-storage-interface/spec/pulls/274/comments"},"review_comment":{"href":"https://api.github.com/repos/container-storage-interface/spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/container-storage-interface/spec/pulls/274/commits"},"statuses":{"href":"https://api.github.com/repos/container-storage-interface/spec/statuses/0dbe60518aacc7c1ed279eff70345fdfa5cb455d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jdef"}}