{"action":"created","issue":{"url":"https://api.github.com/repos/jhu-asco/aerial_autonomy/issues/186","repository_url":"https://api.github.com/repos/jhu-asco/aerial_autonomy","labels_url":"https://api.github.com/repos/jhu-asco/aerial_autonomy/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/jhu-asco/aerial_autonomy/issues/186/comments","events_url":"https://api.github.com/repos/jhu-asco/aerial_autonomy/issues/186/events","html_url":"https://github.com/jhu-asco/aerial_autonomy/pull/186","id":325956917,"number":186,"title":"Add reference trajectory interface","user":{"login":"msheckells","id":3590783,"avatar_url":"https://avatars2.githubusercontent.com/u/3590783?v=4","gravatar_id":"","url":"https://api.github.com/users/msheckells","html_url":"https://github.com/msheckells","followers_url":"https://api.github.com/users/msheckells/followers","following_url":"https://api.github.com/users/msheckells/following{/other_user}","gists_url":"https://api.github.com/users/msheckells/gists{/gist_id}","starred_url":"https://api.github.com/users/msheckells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msheckells/subscriptions","organizations_url":"https://api.github.com/users/msheckells/orgs","repos_url":"https://api.github.com/users/msheckells/repos","events_url":"https://api.github.com/users/msheckells/events{/privacy}","received_events_url":"https://api.github.com/users/msheckells/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"msheckells","id":3590783,"avatar_url":"https://avatars2.githubusercontent.com/u/3590783?v=4","gravatar_id":"","url":"https://api.github.com/users/msheckells","html_url":"https://github.com/msheckells","followers_url":"https://api.github.com/users/msheckells/followers","following_url":"https://api.github.com/users/msheckells/following{/other_user}","gists_url":"https://api.github.com/users/msheckells/gists{/gist_id}","starred_url":"https://api.github.com/users/msheckells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msheckells/subscriptions","organizations_url":"https://api.github.com/users/msheckells/orgs","repos_url":"https://api.github.com/users/msheckells/repos","events_url":"https://api.github.com/users/msheckells/events{/privacy}","received_events_url":"https://api.github.com/users/msheckells/received_events","type":"User","site_admin":false},"assignees":[{"login":"msheckells","id":3590783,"avatar_url":"https://avatars2.githubusercontent.com/u/3590783?v=4","gravatar_id":"","url":"https://api.github.com/users/msheckells","html_url":"https://github.com/msheckells","followers_url":"https://api.github.com/users/msheckells/followers","following_url":"https://api.github.com/users/msheckells/following{/other_user}","gists_url":"https://api.github.com/users/msheckells/gists{/gist_id}","starred_url":"https://api.github.com/users/msheckells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msheckells/subscriptions","organizations_url":"https://api.github.com/users/msheckells/orgs","repos_url":"https://api.github.com/users/msheckells/repos","events_url":"https://api.github.com/users/msheckells/events{/privacy}","received_events_url":"https://api.github.com/users/msheckells/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-05-24T04:08:06Z","updated_at":"2018-05-28T21:57:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jhu-asco/aerial_autonomy/pulls/186","html_url":"https://github.com/jhu-asco/aerial_autonomy/pull/186","diff_url":"https://github.com/jhu-asco/aerial_autonomy/pull/186.diff","patch_url":"https://github.com/jhu-asco/aerial_autonomy/pull/186.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/jhu-asco/aerial_autonomy/186)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/jhu-asco/aerial_autonomy/issues/comments/392608990","html_url":"https://github.com/jhu-asco/aerial_autonomy/pull/186#issuecomment-392608990","issue_url":"https://api.github.com/repos/jhu-asco/aerial_autonomy/issues/186","id":392608990,"user":{"login":"garimellagowtham","id":4968323,"avatar_url":"https://avatars2.githubusercontent.com/u/4968323?v=4","gravatar_id":"","url":"https://api.github.com/users/garimellagowtham","html_url":"https://github.com/garimellagowtham","followers_url":"https://api.github.com/users/garimellagowtham/followers","following_url":"https://api.github.com/users/garimellagowtham/following{/other_user}","gists_url":"https://api.github.com/users/garimellagowtham/gists{/gist_id}","starred_url":"https://api.github.com/users/garimellagowtham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garimellagowtham/subscriptions","organizations_url":"https://api.github.com/users/garimellagowtham/orgs","repos_url":"https://api.github.com/users/garimellagowtham/repos","events_url":"https://api.github.com/users/garimellagowtham/events{/privacy}","received_events_url":"https://api.github.com/users/garimellagowtham/received_events","type":"User","site_admin":false},"created_at":"2018-05-28T21:57:54Z","updated_at":"2018-05-28T21:57:54Z","author_association":"COLLABORATOR","body":"\n\n\n\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[include/aerial_autonomy/types/discrete_reference_trajectory_interpolate.h, line 32 at r1](https://reviewable.io/reviews/jhu-asco/aerial_autonomy/186#-LDGytQu0oG4kNZTbgv5:-LDck7aP15CSUCM8MqQD:bcl9k6o) ([raw file](https://github.com/jhu-asco/aerial_autonomy/blob/39854fb0e65ceb36fcdce9e19d29b052dc636229/include/aerial_autonomy/types/discrete_reference_trajectory_interpolate.h#L32)):*\n<details><summary><i>Previously, msheckells (Matt Sheckells) wrote…</i></summary><blockquote>\n\nIts for the case when you try to access the element at the very beginning of the trajectory, where an element at i-1 does not exist\n</blockquote></details>\n\nYou can write the logic as `if (i == 0) {send the start state} else {compare}` This will make it more clearer than whats written\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/jhu-asco/aerial_autonomy/186)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"garimellagowtham"}}