{"action":"created","issue":{"url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2266","repository_url":"https://api.github.com/repos/HerculesWS/Hercules","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2266/labels{/name}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2266/comments","events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2266/events","html_url":"https://github.com/HerculesWS/Hercules/pull/2266","id":367525788,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTMwMDk5","number":2266,"title":"Fixed a condition in RoDEX attachment","user":{"login":"dastgirp","id":2889931,"node_id":"MDQ6VXNlcjI4ODk5MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/2889931?v=4","gravatar_id":"","url":"https://api.github.com/users/dastgirp","html_url":"https://github.com/dastgirp","followers_url":"https://api.github.com/users/dastgirp/followers","following_url":"https://api.github.com/users/dastgirp/following{/other_user}","gists_url":"https://api.github.com/users/dastgirp/gists{/gist_id}","starred_url":"https://api.github.com/users/dastgirp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dastgirp/subscriptions","organizations_url":"https://api.github.com/users/dastgirp/orgs","repos_url":"https://api.github.com/users/dastgirp/repos","events_url":"https://api.github.com/users/dastgirp/events{/privacy}","received_events_url":"https://api.github.com/users/dastgirp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-07T06:28:42Z","updated_at":"2018-10-07T06:53:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2266","html_url":"https://github.com/HerculesWS/Hercules/pull/2266","diff_url":"https://github.com/HerculesWS/Hercules/pull/2266.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/2266.patch"},"body":"[//]: # (**********************************)\r\n[//]: # (** Fill in the following fields **)\r\n[//]: # (**********************************)\r\n\r\n[//]: # (Note: Lines beginning with syntax such as this one, are comments and will not be visible in your report!)\r\n\r\n### Pull Request Prelude\r\n\r\n[//]: # (Thank you for working on improving Hercules!)\r\n\r\n[//]: # (Please complete these steps and check the following boxes by putting an `x` inside the brackets _before_ filing your Pull Request.)\r\n\r\n- [x] I have followed [proper Hercules code styling][code].\r\n- [x] I have read and understood the [contribution guidelines][cont] before making this PR.\r\n- [x] I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.\r\n\r\n### Changes Proposed\r\n\r\n[//]: # (Describe at length, the changes that this pull request makes.)\r\n\r\nThe condition `if( sd->mail.inbox.msg[i].zeny + sd->status.zeny > MAX_ZENY ) {` would overflow and turn into negative value, resulting in the code never executing even if it exceed MAX_ZENY\r\n\r\n**Affected Branches:** \r\n\r\n[//]: # (Master? Slave?)\r\n\r\n**Issues addressed:**\r\n\r\n[//]: # (Issue Tracker Number if any.)\r\n\r\n### Known Issues and TODO List\r\n\r\n[//]: # (Insert checklist here)\r\n[//]: # (Syntax: - [ ] Checkbox)\r\n\r\n[//]: # (**NOTE** Enable the setting \"[√] Allow edits from maintainers.\" when creating your pull request if you have not already enabled it.)\r\n\r\n[cont]: https://github.com/HerculesWS/Hercules/blob/master/CONTRIBUTING.md\r\n[code]: https://github.com/HerculesWS/Hercules/wiki/Coding-Style\r\n"},"comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments/427630550","html_url":"https://github.com/HerculesWS/Hercules/pull/2266#issuecomment-427630550","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2266","id":427630550,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzYzMDU1MA==","user":{"login":"HerculesWSAPI","id":3249609,"node_id":"MDQ6VXNlcjMyNDk2MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/3249609?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWSAPI","html_url":"https://github.com/HerculesWSAPI","followers_url":"https://api.github.com/users/HerculesWSAPI/followers","following_url":"https://api.github.com/users/HerculesWSAPI/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWSAPI/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWSAPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWSAPI/subscriptions","organizations_url":"https://api.github.com/users/HerculesWSAPI/orgs","repos_url":"https://api.github.com/users/HerculesWSAPI/repos","events_url":"https://api.github.com/users/HerculesWSAPI/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWSAPI/received_events","type":"User","site_admin":false},"created_at":"2018-10-07T06:53:20Z","updated_at":"2018-10-07T06:53:20Z","author_association":"CONTRIBUTOR","body":"This pull request **fixes 1 alert** when merging 64bbdb550b21210c090b93cbdeb3124aff48d607 into 852c13305f67948531bd0277eb1922dbd02b1f26 - [view on LGTM.com](https://lgtm.com/projects/g/HerculesWS/Hercules/rev/pr-4e9db2cf12184275c066c5675d79a3afa6669c28)\n\n**fixed alerts:**\n\n* 1 for Comparison result is always the same\n\n---\n\n*Comment posted by [LGTM.com](https://lgtm.com)*"}}
{"actor":{"display_login":"HerculesWSAPI"}}