{"action":"created","comment":{"url":"https://api.github.com/repos/syndesisio/syndesis/pulls/comments/198800024","pull_request_review_id":132792517,"id":198800024,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODgwMDAyNA==","diff_hunk":"@@ -209,14 +216,18 @@ export class IntegrationConfigureActionComponent implements OnInit, OnDestroy {\n       return;\n     }\n     this.isShapeless = this.currentFlowService.isActionShapeless(descriptor);\n-    if (this.hasActionPropertiesToDisplay(descriptor)) {\n+    if (this.hasNoActionPropertiesToDisplay(descriptor)) {\n       this.loading = false;\n       // TODO figure out how to get a link in here that works\n       this.error = {\n         class: 'alert alert-info',\n         icon: 'pficon pficon-info',\n         message: 'There are no properties to configure for this action.'\n       };\n+      const metadata = this.step.metadata || {};\n+      if (!metadata.configured) {\n+        this.finishUp();","path":"app/ui/src/app/integration/edit-page/action-configure/action-configure.component.ts","position":33,"original_position":33,"commit_id":"d2cc38198e5daf251ca8aec8dcc176999a023d21","original_commit_id":"d2cc38198e5daf251ca8aec8dcc176999a023d21","user":{"login":"kahboom","id":3844502,"node_id":"MDQ6VXNlcjM4NDQ1MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/3844502?v=4","gravatar_id":"","url":"https://api.github.com/users/kahboom","html_url":"https://github.com/kahboom","followers_url":"https://api.github.com/users/kahboom/followers","following_url":"https://api.github.com/users/kahboom/following{/other_user}","gists_url":"https://api.github.com/users/kahboom/gists{/gist_id}","starred_url":"https://api.github.com/users/kahboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kahboom/subscriptions","organizations_url":"https://api.github.com/users/kahboom/orgs","repos_url":"https://api.github.com/users/kahboom/repos","events_url":"https://api.github.com/users/kahboom/events{/privacy}","received_events_url":"https://api.github.com/users/kahboom/received_events","type":"User","site_admin":false},"body":"We could probably do with a better name for this. 😂 ","created_at":"2018-06-28T10:57:06Z","updated_at":"2018-06-28T10:57:42Z","html_url":"https://github.com/syndesisio/syndesis/pull/2924#discussion_r198800024","pull_request_url":"https://api.github.com/repos/syndesisio/syndesis/pulls/2924","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/comments/198800024"},"html":{"href":"https://github.com/syndesisio/syndesis/pull/2924#discussion_r198800024"},"pull_request":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/2924"}}},"pull_request":{"url":"https://api.github.com/repos/syndesisio/syndesis/pulls/2924","id":197991561,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTkxNTYx","html_url":"https://github.com/syndesisio/syndesis/pull/2924","diff_url":"https://github.com/syndesisio/syndesis/pull/2924.diff","patch_url":"https://github.com/syndesisio/syndesis/pull/2924.patch","issue_url":"https://api.github.com/repos/syndesisio/syndesis/issues/2924","number":2924,"state":"open","locked":false,"title":"feat: skip the action config if there's no properties","user":{"login":"gashcrumb","id":351660,"node_id":"MDQ6VXNlcjM1MTY2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/351660?v=4","gravatar_id":"","url":"https://api.github.com/users/gashcrumb","html_url":"https://github.com/gashcrumb","followers_url":"https://api.github.com/users/gashcrumb/followers","following_url":"https://api.github.com/users/gashcrumb/following{/other_user}","gists_url":"https://api.github.com/users/gashcrumb/gists{/gist_id}","starred_url":"https://api.github.com/users/gashcrumb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gashcrumb/subscriptions","organizations_url":"https://api.github.com/users/gashcrumb/orgs","repos_url":"https://api.github.com/users/gashcrumb/repos","events_url":"https://api.github.com/users/gashcrumb/events{/privacy}","received_events_url":"https://api.github.com/users/gashcrumb/received_events","type":"User","site_admin":false},"body":"fixes #2568","created_at":"2018-06-28T10:55:10Z","updated_at":"2018-06-28T10:57:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfbd73c9a70f951cf42c066e187079ff32abd72f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/syndesisio/syndesis/pulls/2924/commits","review_comments_url":"https://api.github.com/repos/syndesisio/syndesis/pulls/2924/comments","review_comment_url":"https://api.github.com/repos/syndesisio/syndesis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syndesisio/syndesis/issues/2924/comments","statuses_url":"https://api.github.com/repos/syndesisio/syndesis/statuses/d2cc38198e5daf251ca8aec8dcc176999a023d21","head":{"label":"gashcrumb:issue-2568","ref":"issue-2568","sha":"d2cc38198e5daf251ca8aec8dcc176999a023d21","user":{"login":"gashcrumb","id":351660,"node_id":"MDQ6VXNlcjM1MTY2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/351660?v=4","gravatar_id":"","url":"https://api.github.com/users/gashcrumb","html_url":"https://github.com/gashcrumb","followers_url":"https://api.github.com/users/gashcrumb/followers","following_url":"https://api.github.com/users/gashcrumb/following{/other_user}","gists_url":"https://api.github.com/users/gashcrumb/gists{/gist_id}","starred_url":"https://api.github.com/users/gashcrumb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gashcrumb/subscriptions","organizations_url":"https://api.github.com/users/gashcrumb/orgs","repos_url":"https://api.github.com/users/gashcrumb/repos","events_url":"https://api.github.com/users/gashcrumb/events{/privacy}","received_events_url":"https://api.github.com/users/gashcrumb/received_events","type":"User","site_admin":false},"repo":{"id":105563821,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1NjM4MjE=","name":"syndesis","full_name":"gashcrumb/syndesis","owner":{"login":"gashcrumb","id":351660,"node_id":"MDQ6VXNlcjM1MTY2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/351660?v=4","gravatar_id":"","url":"https://api.github.com/users/gashcrumb","html_url":"https://github.com/gashcrumb","followers_url":"https://api.github.com/users/gashcrumb/followers","following_url":"https://api.github.com/users/gashcrumb/following{/other_user}","gists_url":"https://api.github.com/users/gashcrumb/gists{/gist_id}","starred_url":"https://api.github.com/users/gashcrumb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gashcrumb/subscriptions","organizations_url":"https://api.github.com/users/gashcrumb/orgs","repos_url":"https://api.github.com/users/gashcrumb/repos","events_url":"https://api.github.com/users/gashcrumb/events{/privacy}","received_events_url":"https://api.github.com/users/gashcrumb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gashcrumb/syndesis","description":"A flexible, customizable, open source platform that provides core integration capabilities as a service.","fork":true,"url":"https://api.github.com/repos/gashcrumb/syndesis","forks_url":"https://api.github.com/repos/gashcrumb/syndesis/forks","keys_url":"https://api.github.com/repos/gashcrumb/syndesis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gashcrumb/syndesis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gashcrumb/syndesis/teams","hooks_url":"https://api.github.com/repos/gashcrumb/syndesis/hooks","issue_events_url":"https://api.github.com/repos/gashcrumb/syndesis/issues/events{/number}","events_url":"https://api.github.com/repos/gashcrumb/syndesis/events","assignees_url":"https://api.github.com/repos/gashcrumb/syndesis/assignees{/user}","branches_url":"https://api.github.com/repos/gashcrumb/syndesis/branches{/branch}","tags_url":"https://api.github.com/repos/gashcrumb/syndesis/tags","blobs_url":"https://api.github.com/repos/gashcrumb/syndesis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gashcrumb/syndesis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gashcrumb/syndesis/git/refs{/sha}","trees_url":"https://api.github.com/repos/gashcrumb/syndesis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gashcrumb/syndesis/statuses/{sha}","languages_url":"https://api.github.com/repos/gashcrumb/syndesis/languages","stargazers_url":"https://api.github.com/repos/gashcrumb/syndesis/stargazers","contributors_url":"https://api.github.com/repos/gashcrumb/syndesis/contributors","subscribers_url":"https://api.github.com/repos/gashcrumb/syndesis/subscribers","subscription_url":"https://api.github.com/repos/gashcrumb/syndesis/subscription","commits_url":"https://api.github.com/repos/gashcrumb/syndesis/commits{/sha}","git_commits_url":"https://api.github.com/repos/gashcrumb/syndesis/git/commits{/sha}","comments_url":"https://api.github.com/repos/gashcrumb/syndesis/comments{/number}","issue_comment_url":"https://api.github.com/repos/gashcrumb/syndesis/issues/comments{/number}","contents_url":"https://api.github.com/repos/gashcrumb/syndesis/contents/{+path}","compare_url":"https://api.github.com/repos/gashcrumb/syndesis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gashcrumb/syndesis/merges","archive_url":"https://api.github.com/repos/gashcrumb/syndesis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gashcrumb/syndesis/downloads","issues_url":"https://api.github.com/repos/gashcrumb/syndesis/issues{/number}","pulls_url":"https://api.github.com/repos/gashcrumb/syndesis/pulls{/number}","milestones_url":"https://api.github.com/repos/gashcrumb/syndesis/milestones{/number}","notifications_url":"https://api.github.com/repos/gashcrumb/syndesis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gashcrumb/syndesis/labels{/name}","releases_url":"https://api.github.com/repos/gashcrumb/syndesis/releases{/id}","deployments_url":"https://api.github.com/repos/gashcrumb/syndesis/deployments","created_at":"2017-10-02T17:31:29Z","updated_at":"2018-06-28T09:15:58Z","pushed_at":"2018-06-28T10:54:50Z","git_url":"git://github.com/gashcrumb/syndesis.git","ssh_url":"git@github.com:gashcrumb/syndesis.git","clone_url":"https://github.com/gashcrumb/syndesis.git","svn_url":"https://github.com/gashcrumb/syndesis","homepage":null,"size":59776,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syndesisio:master","ref":"master","sha":"0aa45fd6886e5196ea9a84e1df03842eb3435ced","user":{"login":"syndesisio","id":23079786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDc5Nzg2","avatar_url":"https://avatars3.githubusercontent.com/u/23079786?v=4","gravatar_id":"","url":"https://api.github.com/users/syndesisio","html_url":"https://github.com/syndesisio","followers_url":"https://api.github.com/users/syndesisio/followers","following_url":"https://api.github.com/users/syndesisio/following{/other_user}","gists_url":"https://api.github.com/users/syndesisio/gists{/gist_id}","starred_url":"https://api.github.com/users/syndesisio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syndesisio/subscriptions","organizations_url":"https://api.github.com/users/syndesisio/orgs","repos_url":"https://api.github.com/users/syndesisio/repos","events_url":"https://api.github.com/users/syndesisio/events{/privacy}","received_events_url":"https://api.github.com/users/syndesisio/received_events","type":"Organization","site_admin":false},"repo":{"id":105563335,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1NjMzMzU=","name":"syndesis","full_name":"syndesisio/syndesis","owner":{"login":"syndesisio","id":23079786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDc5Nzg2","avatar_url":"https://avatars3.githubusercontent.com/u/23079786?v=4","gravatar_id":"","url":"https://api.github.com/users/syndesisio","html_url":"https://github.com/syndesisio","followers_url":"https://api.github.com/users/syndesisio/followers","following_url":"https://api.github.com/users/syndesisio/following{/other_user}","gists_url":"https://api.github.com/users/syndesisio/gists{/gist_id}","starred_url":"https://api.github.com/users/syndesisio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syndesisio/subscriptions","organizations_url":"https://api.github.com/users/syndesisio/orgs","repos_url":"https://api.github.com/users/syndesisio/repos","events_url":"https://api.github.com/users/syndesisio/events{/privacy}","received_events_url":"https://api.github.com/users/syndesisio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/syndesisio/syndesis","description":"A flexible, customizable, open source platform that provides core integration capabilities as a service.","fork":false,"url":"https://api.github.com/repos/syndesisio/syndesis","forks_url":"https://api.github.com/repos/syndesisio/syndesis/forks","keys_url":"https://api.github.com/repos/syndesisio/syndesis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syndesisio/syndesis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syndesisio/syndesis/teams","hooks_url":"https://api.github.com/repos/syndesisio/syndesis/hooks","issue_events_url":"https://api.github.com/repos/syndesisio/syndesis/issues/events{/number}","events_url":"https://api.github.com/repos/syndesisio/syndesis/events","assignees_url":"https://api.github.com/repos/syndesisio/syndesis/assignees{/user}","branches_url":"https://api.github.com/repos/syndesisio/syndesis/branches{/branch}","tags_url":"https://api.github.com/repos/syndesisio/syndesis/tags","blobs_url":"https://api.github.com/repos/syndesisio/syndesis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syndesisio/syndesis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syndesisio/syndesis/git/refs{/sha}","trees_url":"https://api.github.com/repos/syndesisio/syndesis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syndesisio/syndesis/statuses/{sha}","languages_url":"https://api.github.com/repos/syndesisio/syndesis/languages","stargazers_url":"https://api.github.com/repos/syndesisio/syndesis/stargazers","contributors_url":"https://api.github.com/repos/syndesisio/syndesis/contributors","subscribers_url":"https://api.github.com/repos/syndesisio/syndesis/subscribers","subscription_url":"https://api.github.com/repos/syndesisio/syndesis/subscription","commits_url":"https://api.github.com/repos/syndesisio/syndesis/commits{/sha}","git_commits_url":"https://api.github.com/repos/syndesisio/syndesis/git/commits{/sha}","comments_url":"https://api.github.com/repos/syndesisio/syndesis/comments{/number}","issue_comment_url":"https://api.github.com/repos/syndesisio/syndesis/issues/comments{/number}","contents_url":"https://api.github.com/repos/syndesisio/syndesis/contents/{+path}","compare_url":"https://api.github.com/repos/syndesisio/syndesis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syndesisio/syndesis/merges","archive_url":"https://api.github.com/repos/syndesisio/syndesis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syndesisio/syndesis/downloads","issues_url":"https://api.github.com/repos/syndesisio/syndesis/issues{/number}","pulls_url":"https://api.github.com/repos/syndesisio/syndesis/pulls{/number}","milestones_url":"https://api.github.com/repos/syndesisio/syndesis/milestones{/number}","notifications_url":"https://api.github.com/repos/syndesisio/syndesis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syndesisio/syndesis/labels{/name}","releases_url":"https://api.github.com/repos/syndesisio/syndesis/releases{/id}","deployments_url":"https://api.github.com/repos/syndesisio/syndesis/deployments","created_at":"2017-10-02T17:26:55Z","updated_at":"2018-06-27T19:01:57Z","pushed_at":"2018-06-28T10:55:11Z","git_url":"git://github.com/syndesisio/syndesis.git","ssh_url":"git@github.com:syndesisio/syndesis.git","clone_url":"https://github.com/syndesisio/syndesis.git","svn_url":"https://github.com/syndesisio/syndesis","homepage":null,"size":66660,"stargazers_count":50,"watchers_count":50,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":377,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":64,"open_issues":377,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/2924"},"html":{"href":"https://github.com/syndesisio/syndesis/pull/2924"},"issue":{"href":"https://api.github.com/repos/syndesisio/syndesis/issues/2924"},"comments":{"href":"https://api.github.com/repos/syndesisio/syndesis/issues/2924/comments"},"review_comments":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/2924/comments"},"review_comment":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/2924/commits"},"statuses":{"href":"https://api.github.com/repos/syndesisio/syndesis/statuses/d2cc38198e5daf251ca8aec8dcc176999a023d21"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kahboom"}}