{"action":"created","issue":{"url":"https://api.github.com/repos/vimc/jenner/issues/21","repository_url":"https://api.github.com/repos/vimc/jenner","labels_url":"https://api.github.com/repos/vimc/jenner/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/vimc/jenner/issues/21/comments","events_url":"https://api.github.com/repos/vimc/jenner/issues/21/events","html_url":"https://github.com/vimc/jenner/pull/21","id":343071447,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODIxMTM0","number":21,"title":"i1976: add population touchstone  as an extra parameter to fix_coverage_fvps","user":{"login":"xiangli313","id":26968564,"node_id":"MDQ6VXNlcjI2OTY4NTY0","avatar_url":"https://avatars3.githubusercontent.com/u/26968564?v=4","gravatar_id":"","url":"https://api.github.com/users/xiangli313","html_url":"https://github.com/xiangli313","followers_url":"https://api.github.com/users/xiangli313/followers","following_url":"https://api.github.com/users/xiangli313/following{/other_user}","gists_url":"https://api.github.com/users/xiangli313/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangli313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangli313/subscriptions","organizations_url":"https://api.github.com/users/xiangli313/orgs","repos_url":"https://api.github.com/users/xiangli313/repos","events_url":"https://api.github.com/users/xiangli313/events{/privacy}","received_events_url":"https://api.github.com/users/xiangli313/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"xiangli313","id":26968564,"node_id":"MDQ6VXNlcjI2OTY4NTY0","avatar_url":"https://avatars3.githubusercontent.com/u/26968564?v=4","gravatar_id":"","url":"https://api.github.com/users/xiangli313","html_url":"https://github.com/xiangli313","followers_url":"https://api.github.com/users/xiangli313/followers","following_url":"https://api.github.com/users/xiangli313/following{/other_user}","gists_url":"https://api.github.com/users/xiangli313/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangli313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangli313/subscriptions","organizations_url":"https://api.github.com/users/xiangli313/orgs","repos_url":"https://api.github.com/users/xiangli313/repos","events_url":"https://api.github.com/users/xiangli313/events{/privacy}","received_events_url":"https://api.github.com/users/xiangli313/received_events","type":"User","site_admin":false},"assignees":[{"login":"xiangli313","id":26968564,"node_id":"MDQ6VXNlcjI2OTY4NTY0","avatar_url":"https://avatars3.githubusercontent.com/u/26968564?v=4","gravatar_id":"","url":"https://api.github.com/users/xiangli313","html_url":"https://github.com/xiangli313","followers_url":"https://api.github.com/users/xiangli313/followers","following_url":"https://api.github.com/users/xiangli313/following{/other_user}","gists_url":"https://api.github.com/users/xiangli313/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangli313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangli313/subscriptions","organizations_url":"https://api.github.com/users/xiangli313/orgs","repos_url":"https://api.github.com/users/xiangli313/repos","events_url":"https://api.github.com/users/xiangli313/events{/privacy}","received_events_url":"https://api.github.com/users/xiangli313/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-07-20T11:23:05Z","updated_at":"2018-07-20T12:36:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vimc/jenner/pulls/21","html_url":"https://github.com/vimc/jenner/pull/21","diff_url":"https://github.com/vimc/jenner/pull/21.diff","patch_url":"https://github.com/vimc/jenner/pull/21.patch"},"body":"Task:\r\nadd population touchstone as an extra parameter to fix_coverage_fvps to make the function useable for interim update\r\n\r\nYoutrack:\r\nhttps://vimc.myjetbrains.com/youtrack/issue/VIMC-1976\r\n\r\n@richfitz. For the interim update, I need both coverage touchstone and population touchstone to calculate FVPS. So I am adding one extra parameter in `fix_coverage_fvps` function. To make sure this change does not influence elsewhere that used this function, I put this new parameter at the end of the function accompany with a if-clause within the function.\r\n"},"comment":{"url":"https://api.github.com/repos/vimc/jenner/issues/comments/406587944","html_url":"https://github.com/vimc/jenner/pull/21#issuecomment-406587944","issue_url":"https://api.github.com/repos/vimc/jenner/issues/21","id":406587944,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjU4Nzk0NA==","user":{"login":"xiangli313","id":26968564,"node_id":"MDQ6VXNlcjI2OTY4NTY0","avatar_url":"https://avatars3.githubusercontent.com/u/26968564?v=4","gravatar_id":"","url":"https://api.github.com/users/xiangli313","html_url":"https://github.com/xiangli313","followers_url":"https://api.github.com/users/xiangli313/followers","following_url":"https://api.github.com/users/xiangli313/following{/other_user}","gists_url":"https://api.github.com/users/xiangli313/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangli313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangli313/subscriptions","organizations_url":"https://api.github.com/users/xiangli313/orgs","repos_url":"https://api.github.com/users/xiangli313/repos","events_url":"https://api.github.com/users/xiangli313/events{/privacy}","received_events_url":"https://api.github.com/users/xiangli313/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T12:36:29Z","updated_at":"2018-07-20T12:36:29Z","author_association":"CONTRIBUTOR","body":"@richfitz, the two fails are both caused by modellers uploading new dataset. PUS-Ferrari uploaded new estiamtes on 05 July. This caused the fail of `dalys_calculation`. They don't calculate dalys at all. I need to calculate for them later. So we cannot fix it now.\r\n\r\nThe same for LSHTM-Jit's HPV model. They uploaded new estimates in 27 of June, 28 of June and 06 of July, which caused the fail of `impact_calculation, method1`. We cannot fix it neither, as they might also change before passing quality control checks.\r\n"}}
{"actor":{"display_login":"xiangli313"}}