{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/190883634","pull_request_review_id":123358590,"id":190883634,"diff_hunk":"@@ -3867,6 +3867,12 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {\n                   self.diverges.set(cond_diverging);\n               });\n \n+              if ctxt.may_break {","path":"src/librustc_typeck/check/mod.rs","position":17,"original_position":17,"commit_id":"7c503b926262828c099669e14eb5bdd8942f548d","original_commit_id":"7c503b926262828c099669e14eb5bdd8942f548d","user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"body":"It seems like not having this before was the obvious bug...","created_at":"2018-05-25T12:50:42Z","updated_at":"2018-05-25T12:53:21Z","html_url":"https://github.com/rust-lang/rust/pull/51049#discussion_r190883634","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/51049","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/190883634"},"html":{"href":"https://github.com/rust-lang/rust/pull/51049#discussion_r190883634"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/51049"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/51049","id":190437113,"html_url":"https://github.com/rust-lang/rust/pull/51049","diff_url":"https://github.com/rust-lang/rust/pull/51049.diff","patch_url":"https://github.com/rust-lang/rust/pull/51049.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/51049","number":51049,"state":"open","locked":false,"title":"Fix behaviour of divergence in while loop conditions","user":{"login":"varkor","id":3943692,"avatar_url":"https://avatars1.githubusercontent.com/u/3943692?v=4","gravatar_id":"","url":"https://api.github.com/users/varkor","html_url":"https://github.com/varkor","followers_url":"https://api.github.com/users/varkor/followers","following_url":"https://api.github.com/users/varkor/following{/other_user}","gists_url":"https://api.github.com/users/varkor/gists{/gist_id}","starred_url":"https://api.github.com/users/varkor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varkor/subscriptions","organizations_url":"https://api.github.com/users/varkor/orgs","repos_url":"https://api.github.com/users/varkor/repos","events_url":"https://api.github.com/users/varkor/events{/privacy}","received_events_url":"https://api.github.com/users/varkor/received_events","type":"User","site_admin":false},"body":"This fixes `'a: while break 'a {};` being treated as diverging, by tracking break expressions in the same way as in `loop` expressions.\r\n\r\nFixes #50856.\r\n\r\nr? @nikomatsakis ","created_at":"2018-05-24T22:26:52Z","updated_at":"2018-05-25T12:53:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab834fe4d0edc3e88eda7491e7c8059cb95d1bca","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/51049/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/51049/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/51049/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/7c503b926262828c099669e14eb5bdd8942f548d","head":{"label":"varkor:break-while-condition","ref":"break-while-condition","sha":"7c503b926262828c099669e14eb5bdd8942f548d","user":{"login":"varkor","id":3943692,"avatar_url":"https://avatars1.githubusercontent.com/u/3943692?v=4","gravatar_id":"","url":"https://api.github.com/users/varkor","html_url":"https://github.com/varkor","followers_url":"https://api.github.com/users/varkor/followers","following_url":"https://api.github.com/users/varkor/following{/other_user}","gists_url":"https://api.github.com/users/varkor/gists{/gist_id}","starred_url":"https://api.github.com/users/varkor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varkor/subscriptions","organizations_url":"https://api.github.com/users/varkor/orgs","repos_url":"https://api.github.com/users/varkor/repos","events_url":"https://api.github.com/users/varkor/events{/privacy}","received_events_url":"https://api.github.com/users/varkor/received_events","type":"User","site_admin":false},"repo":{"id":106295063,"name":"rust","full_name":"varkor/rust","owner":{"login":"varkor","id":3943692,"avatar_url":"https://avatars1.githubusercontent.com/u/3943692?v=4","gravatar_id":"","url":"https://api.github.com/users/varkor","html_url":"https://github.com/varkor","followers_url":"https://api.github.com/users/varkor/followers","following_url":"https://api.github.com/users/varkor/following{/other_user}","gists_url":"https://api.github.com/users/varkor/gists{/gist_id}","starred_url":"https://api.github.com/users/varkor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varkor/subscriptions","organizations_url":"https://api.github.com/users/varkor/orgs","repos_url":"https://api.github.com/users/varkor/repos","events_url":"https://api.github.com/users/varkor/events{/privacy}","received_events_url":"https://api.github.com/users/varkor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/varkor/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/varkor/rust","forks_url":"https://api.github.com/repos/varkor/rust/forks","keys_url":"https://api.github.com/repos/varkor/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/varkor/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/varkor/rust/teams","hooks_url":"https://api.github.com/repos/varkor/rust/hooks","issue_events_url":"https://api.github.com/repos/varkor/rust/issues/events{/number}","events_url":"https://api.github.com/repos/varkor/rust/events","assignees_url":"https://api.github.com/repos/varkor/rust/assignees{/user}","branches_url":"https://api.github.com/repos/varkor/rust/branches{/branch}","tags_url":"https://api.github.com/repos/varkor/rust/tags","blobs_url":"https://api.github.com/repos/varkor/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/varkor/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/varkor/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/varkor/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/varkor/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/varkor/rust/languages","stargazers_url":"https://api.github.com/repos/varkor/rust/stargazers","contributors_url":"https://api.github.com/repos/varkor/rust/contributors","subscribers_url":"https://api.github.com/repos/varkor/rust/subscribers","subscription_url":"https://api.github.com/repos/varkor/rust/subscription","commits_url":"https://api.github.com/repos/varkor/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/varkor/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/varkor/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/varkor/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/varkor/rust/contents/{+path}","compare_url":"https://api.github.com/repos/varkor/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/varkor/rust/merges","archive_url":"https://api.github.com/repos/varkor/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/varkor/rust/downloads","issues_url":"https://api.github.com/repos/varkor/rust/issues{/number}","pulls_url":"https://api.github.com/repos/varkor/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/varkor/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/varkor/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/varkor/rust/labels{/name}","releases_url":"https://api.github.com/repos/varkor/rust/releases{/id}","deployments_url":"https://api.github.com/repos/varkor/rust/deployments","created_at":"2017-10-09T14:34:36Z","updated_at":"2018-05-17T19:52:15Z","pushed_at":"2018-05-25T08:46:20Z","git_url":"git://github.com/varkor/rust.git","ssh_url":"git@github.com:varkor/rust.git","clone_url":"https://github.com/varkor/rust.git","svn_url":"https://github.com/varkor/rust","homepage":"https://www.rust-lang.org","size":370605,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"07465222ca9454d7c274908424a5e084710efd7e","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-05-25T11:37:31Z","pushed_at":"2018-05-25T12:14:50Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":372354,"stargazers_count":28423,"watchers_count":28423,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4934,"mirror_url":null,"archived":false,"open_issues_count":3808,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4934,"open_issues":3808,"watchers":28423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/51049"},"html":{"href":"https://github.com/rust-lang/rust/pull/51049"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/51049"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/51049/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/51049/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/51049/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/7c503b926262828c099669e14eb5bdd8942f548d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nikomatsakis"}}