{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/comments/243201767","pull_request_review_id":186906268,"id":243201767,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzIwMTc2Nw==","diff_hunk":"@@ -63,7 +63,9 @@ The following guide describes the necessary steps to build and deploy the LoRaEn\n \n ### Setup Azure function facade and [Azure Container registry](https://azure.microsoft.com/en-us/services/container-registry/)\n \n-- Deploy the [function](LoraKeysManagerFacade). In VSCode with the [functions plugin](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions) you can run the command `Azure Functions: Deploy to function app...`. Then you have to select the folder `LoraKeysManagerFacade/bin/Release/netstandard2.0/publish` (unfortunately at time of this writing we saw the behavior that VSCode is proposing the wrong folder) and select for the environment `C#` in version `beta`.\n+- Build and deploy the [Azure function](LoraKeysManagerFacade). The best way is to open the  [Azure function folder](LoraKeysManagerFacade) with Visual Studio Code with the [Azure Functions Plugin](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions) installed. Now run the command `Azure Functions: Deploy to function app...` and provide the name of the Azure function to deploy to. If prompted, select  environment `C#` and  version `V2`.\n+\n+- If you want to just deploy the function from Visual Studio Code with the root project folder `iotedge-lorawan-starterkit` open (of which the Function is a subfolder `/LoRaEngine/LoraKeysManagerFacade`), you need to run the Viusal Studio Command `Azure Functions: Deploy to function app...` and then **manually** choose the folder `LoraKeysManagerFacade/bin/Release/netstandard2.0/publish`. (Unfortunately at time of this writing we saw the behavior that VSCode is proposing the wrong folder). Building the function does not work in this way unfortunately.","path":"LoRaEngine/README.md","position":7,"original_position":7,"commit_id":"9809de1aae2187b6396f7ca728eecba4e3aac7de","original_commit_id":"9809de1aae2187b6396f7ca728eecba4e3aac7de","user":{"login":"TechPreacher","id":841949,"node_id":"MDQ6VXNlcjg0MTk0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/841949?v=4","gravatar_id":"","url":"https://api.github.com/users/TechPreacher","html_url":"https://github.com/TechPreacher","followers_url":"https://api.github.com/users/TechPreacher/followers","following_url":"https://api.github.com/users/TechPreacher/following{/other_user}","gists_url":"https://api.github.com/users/TechPreacher/gists{/gist_id}","starred_url":"https://api.github.com/users/TechPreacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechPreacher/subscriptions","organizations_url":"https://api.github.com/users/TechPreacher/orgs","repos_url":"https://api.github.com/users/TechPreacher/repos","events_url":"https://api.github.com/users/TechPreacher/events{/privacy}","received_events_url":"https://api.github.com/users/TechPreacher/received_events","type":"User","site_admin":false},"body":"Got it! Thanks!","created_at":"2018-12-20T09:21:31Z","updated_at":"2018-12-20T09:21:32Z","html_url":"https://github.com/Azure/iotedge-lorawan-starterkit/pull/71#discussion_r243201767","pull_request_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/71","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/comments/243201767"},"html":{"href":"https://github.com/Azure/iotedge-lorawan-starterkit/pull/71#discussion_r243201767"},"pull_request":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/71"}},"in_reply_to_id":243197259},"pull_request":{"url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/71","id":239907417,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTA3NDE3","html_url":"https://github.com/Azure/iotedge-lorawan-starterkit/pull/71","diff_url":"https://github.com/Azure/iotedge-lorawan-starterkit/pull/71.diff","patch_url":"https://github.com/Azure/iotedge-lorawan-starterkit/pull/71.patch","issue_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/71","number":71,"state":"open","locked":false,"title":"Update Readme to include updating procedure and fix Function installation guide.","user":{"login":"TechPreacher","id":841949,"node_id":"MDQ6VXNlcjg0MTk0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/841949?v=4","gravatar_id":"","url":"https://api.github.com/users/TechPreacher","html_url":"https://github.com/TechPreacher","followers_url":"https://api.github.com/users/TechPreacher/followers","following_url":"https://api.github.com/users/TechPreacher/following{/other_user}","gists_url":"https://api.github.com/users/TechPreacher/gists{/gist_id}","starred_url":"https://api.github.com/users/TechPreacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechPreacher/subscriptions","organizations_url":"https://api.github.com/users/TechPreacher/orgs","repos_url":"https://api.github.com/users/TechPreacher/repos","events_url":"https://api.github.com/users/TechPreacher/events{/privacy}","received_events_url":"https://api.github.com/users/TechPreacher/received_events","type":"User","site_admin":false},"body":"- Readme.md now includes a guide how to update from 0.2.0-preview to 0.3.0-preview.\r\n- LoraEngine/Readme.md has an updated section on how to use VS Code to install the Azure Function Façade.\r\n- Updated Function Façade VS Code setting files to work with Azure Functions V2.\r\n- Bug Fixes and Changes added to the release notes: https://github.com/Azure/iotedge-lorawan-starterkit/releases","created_at":"2018-12-19T16:57:00Z","updated_at":"2018-12-20T09:21:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"238eca14512c377eb1d697d314b03bd7e486229c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Mandur","id":8555833,"node_id":"MDQ6VXNlcjg1NTU4MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/8555833?v=4","gravatar_id":"","url":"https://api.github.com/users/Mandur","html_url":"https://github.com/Mandur","followers_url":"https://api.github.com/users/Mandur/followers","following_url":"https://api.github.com/users/Mandur/following{/other_user}","gists_url":"https://api.github.com/users/Mandur/gists{/gist_id}","starred_url":"https://api.github.com/users/Mandur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mandur/subscriptions","organizations_url":"https://api.github.com/users/Mandur/orgs","repos_url":"https://api.github.com/users/Mandur/repos","events_url":"https://api.github.com/users/Mandur/events{/privacy}","received_events_url":"https://api.github.com/users/Mandur/received_events","type":"User","site_admin":false},{"login":"ronniesa","id":24290518,"node_id":"MDQ6VXNlcjI0MjkwNTE4","avatar_url":"https://avatars0.githubusercontent.com/u/24290518?v=4","gravatar_id":"","url":"https://api.github.com/users/ronniesa","html_url":"https://github.com/ronniesa","followers_url":"https://api.github.com/users/ronniesa/followers","following_url":"https://api.github.com/users/ronniesa/following{/other_user}","gists_url":"https://api.github.com/users/ronniesa/gists{/gist_id}","starred_url":"https://api.github.com/users/ronniesa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronniesa/subscriptions","organizations_url":"https://api.github.com/users/ronniesa/orgs","repos_url":"https://api.github.com/users/ronniesa/repos","events_url":"https://api.github.com/users/ronniesa/events{/privacy}","received_events_url":"https://api.github.com/users/ronniesa/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/71/commits","review_comments_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/71/comments","review_comment_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/71/comments","statuses_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/statuses/9809de1aae2187b6396f7ca728eecba4e3aac7de","head":{"label":"Azure:sac-dev-documentationupdate","ref":"sac-dev-documentationupdate","sha":"9809de1aae2187b6396f7ca728eecba4e3aac7de","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":145098743,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwOTg3NDM=","name":"iotedge-lorawan-starterkit","full_name":"Azure/iotedge-lorawan-starterkit","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/iotedge-lorawan-starterkit","description":"Experimental sample implementation of LoRaWAN components to connect LoRaWAN antenna gateway running IoT Edge directly with Azure IoT.","fork":false,"url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit","forks_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/forks","keys_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/teams","hooks_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/hooks","issue_events_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/events","assignees_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/tags","blobs_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/languages","stargazers_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/stargazers","contributors_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/contributors","subscribers_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/subscribers","subscription_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/subscription","commits_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/merges","archive_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/downloads","issues_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/labels{/name}","releases_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/deployments","created_at":"2018-08-17T09:09:35Z","updated_at":"2018-12-19T11:54:11Z","pushed_at":"2018-12-20T09:11:23Z","git_url":"git://github.com/Azure/iotedge-lorawan-starterkit.git","ssh_url":"git@github.com:Azure/iotedge-lorawan-starterkit.git","clone_url":"https://github.com/Azure/iotedge-lorawan-starterkit.git","svn_url":"https://github.com/Azure/iotedge-lorawan-starterkit","homepage":null,"size":10050,"stargazers_count":18,"watchers_count":18,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":2,"watchers":18,"default_branch":"master"}},"base":{"label":"Azure:dev","ref":"dev","sha":"9c7941616ff62786a59e6599ca5855e1bb1b5b45","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":145098743,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwOTg3NDM=","name":"iotedge-lorawan-starterkit","full_name":"Azure/iotedge-lorawan-starterkit","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/iotedge-lorawan-starterkit","description":"Experimental sample implementation of LoRaWAN components to connect LoRaWAN antenna gateway running IoT Edge directly with Azure IoT.","fork":false,"url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit","forks_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/forks","keys_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/teams","hooks_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/hooks","issue_events_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/events","assignees_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/tags","blobs_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/languages","stargazers_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/stargazers","contributors_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/contributors","subscribers_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/subscribers","subscription_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/subscription","commits_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/merges","archive_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/downloads","issues_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/labels{/name}","releases_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/deployments","created_at":"2018-08-17T09:09:35Z","updated_at":"2018-12-19T11:54:11Z","pushed_at":"2018-12-20T09:11:23Z","git_url":"git://github.com/Azure/iotedge-lorawan-starterkit.git","ssh_url":"git@github.com:Azure/iotedge-lorawan-starterkit.git","clone_url":"https://github.com/Azure/iotedge-lorawan-starterkit.git","svn_url":"https://github.com/Azure/iotedge-lorawan-starterkit","homepage":null,"size":10050,"stargazers_count":18,"watchers_count":18,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":2,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/71"},"html":{"href":"https://github.com/Azure/iotedge-lorawan-starterkit/pull/71"},"issue":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/71"},"comments":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/statuses/9809de1aae2187b6396f7ca728eecba4e3aac7de"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TechPreacher"}}