{"action":"closed","number":16286,"pull_request":{"url":"https://api.github.com/repos/ionic-team/ionic/pulls/16286","id":229845170,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODQ1MTcw","html_url":"https://github.com/ionic-team/ionic/pull/16286","diff_url":"https://github.com/ionic-team/ionic/pull/16286.diff","patch_url":"https://github.com/ionic-team/ionic/pull/16286.patch","issue_url":"https://api.github.com/repos/ionic-team/ionic/issues/16286","number":16286,"state":"closed","locked":false,"title":"fix(datetime): fix changing \"displayFormat\" not updating text","user":{"login":"NiklasMerz","id":3585860,"node_id":"MDQ6VXNlcjM1ODU4NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3585860?v=4","gravatar_id":"","url":"https://api.github.com/users/NiklasMerz","html_url":"https://github.com/NiklasMerz","followers_url":"https://api.github.com/users/NiklasMerz/followers","following_url":"https://api.github.com/users/NiklasMerz/following{/other_user}","gists_url":"https://api.github.com/users/NiklasMerz/gists{/gist_id}","starred_url":"https://api.github.com/users/NiklasMerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiklasMerz/subscriptions","organizations_url":"https://api.github.com/users/NiklasMerz/orgs","repos_url":"https://api.github.com/users/NiklasMerz/repos","events_url":"https://api.github.com/users/NiklasMerz/events{/privacy}","received_events_url":"https://api.github.com/users/NiklasMerz/received_events","type":"User","site_admin":false},"body":"#### Short description of what this resolves:\r\nThis fixes the problem, that the displayed date does not update when the format has changed.\r\n\r\n#### Changes proposed in this pull request:\r\n\r\n- Adds Watch to `displayFormat` Prop\r\n\r\nThis repo contains code for reproducing: https://github.com/NiklasMerz/ion-date-test/tree/v4\r\n\r\n**Ionic Version**: 4.x beta\r\n\r\n**Fixes**: #12072 \r\nSee also https://github.com/ionic-team/ionic-v3/issues/17 for version 3.x. It also has this problem but needs another solution\r\n","created_at":"2018-11-09T23:14:03Z","updated_at":"2018-11-20T20:08:03Z","closed_at":"2018-11-20T20:08:03Z","merged_at":null,"merge_commit_sha":"29cccd138d09effc0c047a350df486b020510fa5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":999100804,"node_id":"MDU6TGFiZWw5OTkxMDA4MDQ=","url":"https://api.github.com/repos/ionic-team/ionic/labels/core","name":"core","color":"1066ff","default":false},{"id":96053308,"node_id":"MDU6TGFiZWw5NjA1MzMwOA==","url":"https://api.github.com/repos/ionic-team/ionic/labels/needs%20reply","name":"needs reply","color":"ffce00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ionic-team/ionic/pulls/16286/commits","review_comments_url":"https://api.github.com/repos/ionic-team/ionic/pulls/16286/comments","review_comment_url":"https://api.github.com/repos/ionic-team/ionic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ionic-team/ionic/issues/16286/comments","statuses_url":"https://api.github.com/repos/ionic-team/ionic/statuses/68e24332d093e083b1f862e3a117f779a4bb3b84","head":{"label":"NiklasMerz:datetime","ref":"datetime","sha":"68e24332d093e083b1f862e3a117f779a4bb3b84","user":{"login":"NiklasMerz","id":3585860,"node_id":"MDQ6VXNlcjM1ODU4NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3585860?v=4","gravatar_id":"","url":"https://api.github.com/users/NiklasMerz","html_url":"https://github.com/NiklasMerz","followers_url":"https://api.github.com/users/NiklasMerz/followers","following_url":"https://api.github.com/users/NiklasMerz/following{/other_user}","gists_url":"https://api.github.com/users/NiklasMerz/gists{/gist_id}","starred_url":"https://api.github.com/users/NiklasMerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiklasMerz/subscriptions","organizations_url":"https://api.github.com/users/NiklasMerz/orgs","repos_url":"https://api.github.com/users/NiklasMerz/repos","events_url":"https://api.github.com/users/NiklasMerz/events{/privacy}","received_events_url":"https://api.github.com/users/NiklasMerz/received_events","type":"User","site_admin":false},"repo":{"id":156926663,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5MjY2NjM=","name":"ionic","full_name":"NiklasMerz/ionic","private":false,"owner":{"login":"NiklasMerz","id":3585860,"node_id":"MDQ6VXNlcjM1ODU4NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3585860?v=4","gravatar_id":"","url":"https://api.github.com/users/NiklasMerz","html_url":"https://github.com/NiklasMerz","followers_url":"https://api.github.com/users/NiklasMerz/followers","following_url":"https://api.github.com/users/NiklasMerz/following{/other_user}","gists_url":"https://api.github.com/users/NiklasMerz/gists{/gist_id}","starred_url":"https://api.github.com/users/NiklasMerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiklasMerz/subscriptions","organizations_url":"https://api.github.com/users/NiklasMerz/orgs","repos_url":"https://api.github.com/users/NiklasMerz/repos","events_url":"https://api.github.com/users/NiklasMerz/events{/privacy}","received_events_url":"https://api.github.com/users/NiklasMerz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NiklasMerz/ionic","description":"Build amazing native and progressive web apps with open web technologies. One app running on everything 🎉","fork":true,"url":"https://api.github.com/repos/NiklasMerz/ionic","forks_url":"https://api.github.com/repos/NiklasMerz/ionic/forks","keys_url":"https://api.github.com/repos/NiklasMerz/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NiklasMerz/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NiklasMerz/ionic/teams","hooks_url":"https://api.github.com/repos/NiklasMerz/ionic/hooks","issue_events_url":"https://api.github.com/repos/NiklasMerz/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/NiklasMerz/ionic/events","assignees_url":"https://api.github.com/repos/NiklasMerz/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/NiklasMerz/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/NiklasMerz/ionic/tags","blobs_url":"https://api.github.com/repos/NiklasMerz/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NiklasMerz/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NiklasMerz/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/NiklasMerz/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NiklasMerz/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/NiklasMerz/ionic/languages","stargazers_url":"https://api.github.com/repos/NiklasMerz/ionic/stargazers","contributors_url":"https://api.github.com/repos/NiklasMerz/ionic/contributors","subscribers_url":"https://api.github.com/repos/NiklasMerz/ionic/subscribers","subscription_url":"https://api.github.com/repos/NiklasMerz/ionic/subscription","commits_url":"https://api.github.com/repos/NiklasMerz/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/NiklasMerz/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/NiklasMerz/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/NiklasMerz/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/NiklasMerz/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/NiklasMerz/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NiklasMerz/ionic/merges","archive_url":"https://api.github.com/repos/NiklasMerz/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NiklasMerz/ionic/downloads","issues_url":"https://api.github.com/repos/NiklasMerz/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/NiklasMerz/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/NiklasMerz/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/NiklasMerz/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NiklasMerz/ionic/labels{/name}","releases_url":"https://api.github.com/repos/NiklasMerz/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/NiklasMerz/ionic/deployments","created_at":"2018-11-09T22:50:34Z","updated_at":"2018-11-09T22:50:41Z","pushed_at":"2018-11-18T19:13:52Z","git_url":"git://github.com/NiklasMerz/ionic.git","ssh_url":"git@github.com:NiklasMerz/ionic.git","clone_url":"https://github.com/NiklasMerz/ionic.git","svn_url":"https://github.com/NiklasMerz/ionic","homepage":"https://ionicframework.com/","size":91241,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ionic-team:master","ref":"master","sha":"52cea5a40436409f0c6849aa4efe375cc298fe2b","user":{"login":"ionic-team","id":3171503,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzE1MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/3171503?v=4","gravatar_id":"","url":"https://api.github.com/users/ionic-team","html_url":"https://github.com/ionic-team","followers_url":"https://api.github.com/users/ionic-team/followers","following_url":"https://api.github.com/users/ionic-team/following{/other_user}","gists_url":"https://api.github.com/users/ionic-team/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-team/subscriptions","organizations_url":"https://api.github.com/users/ionic-team/orgs","repos_url":"https://api.github.com/users/ionic-team/repos","events_url":"https://api.github.com/users/ionic-team/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-team/received_events","type":"Organization","site_admin":false},"repo":{"id":12256376,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1NjM3Ng==","name":"ionic","full_name":"ionic-team/ionic","private":false,"owner":{"login":"ionic-team","id":3171503,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzE1MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/3171503?v=4","gravatar_id":"","url":"https://api.github.com/users/ionic-team","html_url":"https://github.com/ionic-team","followers_url":"https://api.github.com/users/ionic-team/followers","following_url":"https://api.github.com/users/ionic-team/following{/other_user}","gists_url":"https://api.github.com/users/ionic-team/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-team/subscriptions","organizations_url":"https://api.github.com/users/ionic-team/orgs","repos_url":"https://api.github.com/users/ionic-team/repos","events_url":"https://api.github.com/users/ionic-team/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-team/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ionic-team/ionic","description":"Build amazing native and progressive web apps with open web technologies. One app running on everything 🎉","fork":false,"url":"https://api.github.com/repos/ionic-team/ionic","forks_url":"https://api.github.com/repos/ionic-team/ionic/forks","keys_url":"https://api.github.com/repos/ionic-team/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ionic-team/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ionic-team/ionic/teams","hooks_url":"https://api.github.com/repos/ionic-team/ionic/hooks","issue_events_url":"https://api.github.com/repos/ionic-team/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/ionic-team/ionic/events","assignees_url":"https://api.github.com/repos/ionic-team/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/ionic-team/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/ionic-team/ionic/tags","blobs_url":"https://api.github.com/repos/ionic-team/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ionic-team/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ionic-team/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ionic-team/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ionic-team/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/ionic-team/ionic/languages","stargazers_url":"https://api.github.com/repos/ionic-team/ionic/stargazers","contributors_url":"https://api.github.com/repos/ionic-team/ionic/contributors","subscribers_url":"https://api.github.com/repos/ionic-team/ionic/subscribers","subscription_url":"https://api.github.com/repos/ionic-team/ionic/subscription","commits_url":"https://api.github.com/repos/ionic-team/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ionic-team/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ionic-team/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ionic-team/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ionic-team/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/ionic-team/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ionic-team/ionic/merges","archive_url":"https://api.github.com/repos/ionic-team/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ionic-team/ionic/downloads","issues_url":"https://api.github.com/repos/ionic-team/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/ionic-team/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/ionic-team/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/ionic-team/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ionic-team/ionic/labels{/name}","releases_url":"https://api.github.com/repos/ionic-team/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/ionic-team/ionic/deployments","created_at":"2013-08-20T23:06:02Z","updated_at":"2018-11-20T19:19:24Z","pushed_at":"2018-11-20T17:44:48Z","git_url":"git://github.com/ionic-team/ionic.git","ssh_url":"git@github.com:ionic-team/ionic.git","clone_url":"https://github.com/ionic-team/ionic.git","svn_url":"https://github.com/ionic-team/ionic","homepage":"https://ionicframework.com/","size":91207,"stargazers_count":35875,"watchers_count":35875,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12407,"mirror_url":null,"archived":false,"open_issues_count":1336,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12407,"open_issues":1336,"watchers":35875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/16286"},"html":{"href":"https://github.com/ionic-team/ionic/pull/16286"},"issue":{"href":"https://api.github.com/repos/ionic-team/ionic/issues/16286"},"comments":{"href":"https://api.github.com/repos/ionic-team/ionic/issues/16286/comments"},"review_comments":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/16286/comments"},"review_comment":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/16286/commits"},"statuses":{"href":"https://api.github.com/repos/ionic-team/ionic/statuses/68e24332d093e083b1f862e3a117f779a4bb3b84"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":8,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"NiklasMerz"}}