{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dmd/pulls/comments/244221094","pull_request_review_id":188171246,"id":244221094,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDIyMTA5NA==","diff_hunk":"@@ -1259,58 +1261,45 @@ extern(C++):\n          * Ds       char16_t\n          * u <source-name>  # vendor extended type\n          */\n-        char c;\n-        char p = 0;\n+\n+        // Handle any target-specific basic types.\n+        if (auto tm = target.cppTypeMangle(t))\n+        {\n+            bool builtin = (t.ty == Tvoid || t.ty == Tbool || t.isintegral() || t.isreal());","path":"src/dmd/cppmangle.d","position":null,"original_position":63,"commit_id":"edf25f48efa340df12327d986635385b7693ec8b","original_commit_id":"9a82f46d0e67f62940b96d3c18d8c838b4e6dc2e","user":{"login":"ibuclaw","id":397929,"node_id":"MDQ6VXNlcjM5NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"body":"Renamed both this and the writeBasicType parameter to `isFundamentalType`.","created_at":"2018-12-27T20:30:59Z","updated_at":"2018-12-27T20:30:59Z","html_url":"https://github.com/dlang/dmd/pull/9138#discussion_r244221094","pull_request_url":"https://api.github.com/repos/dlang/dmd/pulls/9138","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments/244221094"},"html":{"href":"https://github.com/dlang/dmd/pull/9138#discussion_r244221094"},"pull_request":{"href":"https://api.github.com/repos/dlang/dmd/pulls/9138"}},"in_reply_to_id":243901844},"pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/9138","id":240817539,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwODE3NTM5","html_url":"https://github.com/dlang/dmd/pull/9138","diff_url":"https://github.com/dlang/dmd/pull/9138.diff","patch_url":"https://github.com/dlang/dmd/pull/9138.patch","issue_url":"https://api.github.com/repos/dlang/dmd/issues/9138","number":9138,"state":"open","locked":false,"title":"cppmangle.d: Fix substitution logic in writeBasicType()","user":{"login":"ibuclaw","id":397929,"node_id":"MDQ6VXNlcjM5NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"body":"Specifically fixes nullptr_t and target-specific built-in type mangling (correcting patch in #9129) @JohanEngelen.\r\n\r\nLater on, this will also work for char16_t and char32_t as well.","created_at":"2018-12-25T00:09:51Z","updated_at":"2018-12-27T20:30:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5382f03935121ee1ef0c977edcbcd259a926349","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dmd/pulls/9138/commits","review_comments_url":"https://api.github.com/repos/dlang/dmd/pulls/9138/comments","review_comment_url":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/9138/comments","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/edf25f48efa340df12327d986635385b7693ec8b","head":{"label":"ibuclaw:cppmangle2","ref":"cppmangle2","sha":"edf25f48efa340df12327d986635385b7693ec8b","user":{"login":"ibuclaw","id":397929,"node_id":"MDQ6VXNlcjM5NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"repo":{"id":1653829,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUzODI5","name":"dmd","full_name":"ibuclaw/dmd","private":false,"owner":{"login":"ibuclaw","id":397929,"node_id":"MDQ6VXNlcjM5NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ibuclaw/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/ibuclaw/dmd","forks_url":"https://api.github.com/repos/ibuclaw/dmd/forks","keys_url":"https://api.github.com/repos/ibuclaw/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibuclaw/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibuclaw/dmd/teams","hooks_url":"https://api.github.com/repos/ibuclaw/dmd/hooks","issue_events_url":"https://api.github.com/repos/ibuclaw/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/ibuclaw/dmd/events","assignees_url":"https://api.github.com/repos/ibuclaw/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/ibuclaw/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/ibuclaw/dmd/tags","blobs_url":"https://api.github.com/repos/ibuclaw/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibuclaw/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibuclaw/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibuclaw/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibuclaw/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/ibuclaw/dmd/languages","stargazers_url":"https://api.github.com/repos/ibuclaw/dmd/stargazers","contributors_url":"https://api.github.com/repos/ibuclaw/dmd/contributors","subscribers_url":"https://api.github.com/repos/ibuclaw/dmd/subscribers","subscription_url":"https://api.github.com/repos/ibuclaw/dmd/subscription","commits_url":"https://api.github.com/repos/ibuclaw/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibuclaw/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibuclaw/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibuclaw/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibuclaw/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/ibuclaw/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibuclaw/dmd/merges","archive_url":"https://api.github.com/repos/ibuclaw/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibuclaw/dmd/downloads","issues_url":"https://api.github.com/repos/ibuclaw/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/ibuclaw/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/ibuclaw/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/ibuclaw/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibuclaw/dmd/labels{/name}","releases_url":"https://api.github.com/repos/ibuclaw/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/ibuclaw/dmd/deployments","created_at":"2011-04-23T15:21:22Z","updated_at":"2018-12-27T20:20:16Z","pushed_at":"2018-12-27T20:29:28Z","git_url":"git://github.com/ibuclaw/dmd.git","ssh_url":"git@github.com:ibuclaw/dmd.git","clone_url":"https://github.com/ibuclaw/dmd.git","svn_url":"https://github.com/ibuclaw/dmd","homepage":"d-programming-language.org","size":93679,"stargazers_count":2,"watchers_count":2,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"992843af0f5358ae9431840d23cda5c0c91ed022","user":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MDcw","name":"dmd","full_name":"dlang/dmd","private":false,"owner":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dlang/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/dlang/dmd","forks_url":"https://api.github.com/repos/dlang/dmd/forks","keys_url":"https://api.github.com/repos/dlang/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dmd/teams","hooks_url":"https://api.github.com/repos/dlang/dmd/hooks","issue_events_url":"https://api.github.com/repos/dlang/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dmd/events","assignees_url":"https://api.github.com/repos/dlang/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dmd/tags","blobs_url":"https://api.github.com/repos/dlang/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dmd/languages","stargazers_url":"https://api.github.com/repos/dlang/dmd/stargazers","contributors_url":"https://api.github.com/repos/dlang/dmd/contributors","subscribers_url":"https://api.github.com/repos/dlang/dmd/subscribers","subscription_url":"https://api.github.com/repos/dlang/dmd/subscription","commits_url":"https://api.github.com/repos/dlang/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dmd/merges","archive_url":"https://api.github.com/repos/dlang/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dmd/downloads","issues_url":"https://api.github.com/repos/dlang/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2018-12-27T13:13:01Z","pushed_at":"2018-12-27T20:29:30Z","git_url":"git://github.com/dlang/dmd.git","ssh_url":"git@github.com:dlang/dmd.git","clone_url":"https://github.com/dlang/dmd.git","svn_url":"https://github.com/dlang/dmd","homepage":"dlang.org","size":97609,"stargazers_count":1872,"watchers_count":1872,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":480,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":480,"open_issues":132,"watchers":1872,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/9138"},"html":{"href":"https://github.com/dlang/dmd/pull/9138"},"issue":{"href":"https://api.github.com/repos/dlang/dmd/issues/9138"},"comments":{"href":"https://api.github.com/repos/dlang/dmd/issues/9138/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dmd/pulls/9138/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dmd/pulls/9138/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dmd/statuses/edf25f48efa340df12327d986635385b7693ec8b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ibuclaw"}}