{"action":"created","comment":{"url":"https://api.github.com/repos/biopython/biopython/pulls/comments/180111995","pull_request_review_id":110475703,"id":180111995,"diff_hunk":"@@ -640,3 +623,49 @@ def externalEntityRefHandler(self, context, base, systemId, publicId):\n         handle.close()\n         self.dtd_urls.pop()\n         return 1\n+\n+    def _initialize_directory(self, directory_type):","path":"Bio/Entrez/Parser.py","position":107,"original_position":107,"commit_id":"ee05a28db5e83a2744261515ff7969946cd11fdb","original_commit_id":"ee05a28db5e83a2744261515ff7969946cd11fdb","user":{"login":"peterjc","id":63959,"avatar_url":"https://avatars2.githubusercontent.com/u/63959?v=4","gravatar_id":"","url":"https://api.github.com/users/peterjc","html_url":"https://github.com/peterjc","followers_url":"https://api.github.com/users/peterjc/followers","following_url":"https://api.github.com/users/peterjc/following{/other_user}","gists_url":"https://api.github.com/users/peterjc/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjc/subscriptions","organizations_url":"https://api.github.com/users/peterjc/orgs","repos_url":"https://api.github.com/users/peterjc/repos","events_url":"https://api.github.com/users/peterjc/events{/privacy}","received_events_url":"https://api.github.com/users/peterjc/received_events","type":"User","site_admin":false},"body":"It isn't clear from the docstring what argument ``directory_type`` should be. You use a mix of strings like ``directory_type='XSD'`` and a list like ``directory_type=['DTD', 'XSD']``\r\n\r\nIn anyway case, why not always initialise both the DTD and XSD paths? That would make the internal API simpler too.","created_at":"2018-04-09T14:26:41Z","updated_at":"2018-04-09T14:26:41Z","html_url":"https://github.com/biopython/biopython/pull/1522#discussion_r180111995","pull_request_url":"https://api.github.com/repos/biopython/biopython/pulls/1522","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/biopython/biopython/pulls/comments/180111995"},"html":{"href":"https://github.com/biopython/biopython/pull/1522#discussion_r180111995"},"pull_request":{"href":"https://api.github.com/repos/biopython/biopython/pulls/1522"}}},"pull_request":{"url":"https://api.github.com/repos/biopython/biopython/pulls/1522","id":166153084,"html_url":"https://github.com/biopython/biopython/pull/1522","diff_url":"https://github.com/biopython/biopython/pull/1522.diff","patch_url":"https://github.com/biopython/biopython/pull/1522.patch","issue_url":"https://api.github.com/repos/biopython/biopython/issues/1522","number":1522,"state":"open","locked":false,"title":"Expose Entrez cache to allow user to set custom cache directory (AWS Lambda deployment, etc)","user":{"login":"cparmet","id":25433455,"avatar_url":"https://avatars1.githubusercontent.com/u/25433455?v=4","gravatar_id":"","url":"https://api.github.com/users/cparmet","html_url":"https://github.com/cparmet","followers_url":"https://api.github.com/users/cparmet/followers","following_url":"https://api.github.com/users/cparmet/following{/other_user}","gists_url":"https://api.github.com/users/cparmet/gists{/gist_id}","starred_url":"https://api.github.com/users/cparmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cparmet/subscriptions","organizations_url":"https://api.github.com/users/cparmet/orgs","repos_url":"https://api.github.com/users/cparmet/repos","events_url":"https://api.github.com/users/cparmet/events{/privacy}","received_events_url":"https://api.github.com/users/cparmet/received_events","type":"User","site_admin":false},"body":"This pull request addresses issue #1517 \r\n\r\n\r\nI hereby agree to dual licence this and any previous contributions under both\r\nthe _Biopython License Agreement_ **AND** the _BSD 3-Clause License_.\r\n\r\nI have read the ``CONTRIBUTING.rst`` file and understand that AppVeyor and\r\nTravisCI will be used to confirm the Biopython unit tests and ``flake8`` style\r\nchecks pass with these changes.\r\n\r\nI am happy be thanked by name in the ``NEWS.rst`` and ``CONTRIB.rst`` files,\r\nand have added myself to those files as part of this pull request. (*This\r\nacknowledgement is optional. Note we list the names sorted alphabetically.*)\r\n","created_at":"2018-01-31T02:45:46Z","updated_at":"2018-04-09T14:26:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc2284dff62d84b5e596cae6357bd514686281de","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mdehoon","id":136062,"avatar_url":"https://avatars2.githubusercontent.com/u/136062?v=4","gravatar_id":"","url":"https://api.github.com/users/mdehoon","html_url":"https://github.com/mdehoon","followers_url":"https://api.github.com/users/mdehoon/followers","following_url":"https://api.github.com/users/mdehoon/following{/other_user}","gists_url":"https://api.github.com/users/mdehoon/gists{/gist_id}","starred_url":"https://api.github.com/users/mdehoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdehoon/subscriptions","organizations_url":"https://api.github.com/users/mdehoon/orgs","repos_url":"https://api.github.com/users/mdehoon/repos","events_url":"https://api.github.com/users/mdehoon/events{/privacy}","received_events_url":"https://api.github.com/users/mdehoon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/biopython/biopython/pulls/1522/commits","review_comments_url":"https://api.github.com/repos/biopython/biopython/pulls/1522/comments","review_comment_url":"https://api.github.com/repos/biopython/biopython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biopython/biopython/issues/1522/comments","statuses_url":"https://api.github.com/repos/biopython/biopython/statuses/ee05a28db5e83a2744261515ff7969946cd11fdb","head":{"label":"cparmet:master","ref":"master","sha":"ee05a28db5e83a2744261515ff7969946cd11fdb","user":{"login":"cparmet","id":25433455,"avatar_url":"https://avatars1.githubusercontent.com/u/25433455?v=4","gravatar_id":"","url":"https://api.github.com/users/cparmet","html_url":"https://github.com/cparmet","followers_url":"https://api.github.com/users/cparmet/followers","following_url":"https://api.github.com/users/cparmet/following{/other_user}","gists_url":"https://api.github.com/users/cparmet/gists{/gist_id}","starred_url":"https://api.github.com/users/cparmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cparmet/subscriptions","organizations_url":"https://api.github.com/users/cparmet/orgs","repos_url":"https://api.github.com/users/cparmet/repos","events_url":"https://api.github.com/users/cparmet/events{/privacy}","received_events_url":"https://api.github.com/users/cparmet/received_events","type":"User","site_admin":false},"repo":{"id":119536321,"name":"biopython","full_name":"cparmet/biopython","owner":{"login":"cparmet","id":25433455,"avatar_url":"https://avatars1.githubusercontent.com/u/25433455?v=4","gravatar_id":"","url":"https://api.github.com/users/cparmet","html_url":"https://github.com/cparmet","followers_url":"https://api.github.com/users/cparmet/followers","following_url":"https://api.github.com/users/cparmet/following{/other_user}","gists_url":"https://api.github.com/users/cparmet/gists{/gist_id}","starred_url":"https://api.github.com/users/cparmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cparmet/subscriptions","organizations_url":"https://api.github.com/users/cparmet/orgs","repos_url":"https://api.github.com/users/cparmet/repos","events_url":"https://api.github.com/users/cparmet/events{/privacy}","received_events_url":"https://api.github.com/users/cparmet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cparmet/biopython","description":"Fork of Biopython to create Entrez.cache, Biopython pull request #1522","fork":true,"url":"https://api.github.com/repos/cparmet/biopython","forks_url":"https://api.github.com/repos/cparmet/biopython/forks","keys_url":"https://api.github.com/repos/cparmet/biopython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cparmet/biopython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cparmet/biopython/teams","hooks_url":"https://api.github.com/repos/cparmet/biopython/hooks","issue_events_url":"https://api.github.com/repos/cparmet/biopython/issues/events{/number}","events_url":"https://api.github.com/repos/cparmet/biopython/events","assignees_url":"https://api.github.com/repos/cparmet/biopython/assignees{/user}","branches_url":"https://api.github.com/repos/cparmet/biopython/branches{/branch}","tags_url":"https://api.github.com/repos/cparmet/biopython/tags","blobs_url":"https://api.github.com/repos/cparmet/biopython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cparmet/biopython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cparmet/biopython/git/refs{/sha}","trees_url":"https://api.github.com/repos/cparmet/biopython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cparmet/biopython/statuses/{sha}","languages_url":"https://api.github.com/repos/cparmet/biopython/languages","stargazers_url":"https://api.github.com/repos/cparmet/biopython/stargazers","contributors_url":"https://api.github.com/repos/cparmet/biopython/contributors","subscribers_url":"https://api.github.com/repos/cparmet/biopython/subscribers","subscription_url":"https://api.github.com/repos/cparmet/biopython/subscription","commits_url":"https://api.github.com/repos/cparmet/biopython/commits{/sha}","git_commits_url":"https://api.github.com/repos/cparmet/biopython/git/commits{/sha}","comments_url":"https://api.github.com/repos/cparmet/biopython/comments{/number}","issue_comment_url":"https://api.github.com/repos/cparmet/biopython/issues/comments{/number}","contents_url":"https://api.github.com/repos/cparmet/biopython/contents/{+path}","compare_url":"https://api.github.com/repos/cparmet/biopython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cparmet/biopython/merges","archive_url":"https://api.github.com/repos/cparmet/biopython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cparmet/biopython/downloads","issues_url":"https://api.github.com/repos/cparmet/biopython/issues{/number}","pulls_url":"https://api.github.com/repos/cparmet/biopython/pulls{/number}","milestones_url":"https://api.github.com/repos/cparmet/biopython/milestones{/number}","notifications_url":"https://api.github.com/repos/cparmet/biopython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cparmet/biopython/labels{/name}","releases_url":"https://api.github.com/repos/cparmet/biopython/releases{/id}","deployments_url":"https://api.github.com/repos/cparmet/biopython/deployments","created_at":"2018-01-30T12:59:32Z","updated_at":"2018-04-07T13:13:07Z","pushed_at":"2018-04-07T13:13:06Z","git_url":"git://github.com/cparmet/biopython.git","ssh_url":"git@github.com:cparmet/biopython.git","clone_url":"https://github.com/cparmet/biopython.git","svn_url":"https://github.com/cparmet/biopython","homepage":"https://github.com/biopython/biopython/issues/1517","size":45689,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biopython:master","ref":"master","sha":"1cb73fc4b72bc63b242b6a59d595fabe3cd3f0ae","user":{"login":"biopython","id":54555,"avatar_url":"https://avatars3.githubusercontent.com/u/54555?v=4","gravatar_id":"","url":"https://api.github.com/users/biopython","html_url":"https://github.com/biopython","followers_url":"https://api.github.com/users/biopython/followers","following_url":"https://api.github.com/users/biopython/following{/other_user}","gists_url":"https://api.github.com/users/biopython/gists{/gist_id}","starred_url":"https://api.github.com/users/biopython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biopython/subscriptions","organizations_url":"https://api.github.com/users/biopython/orgs","repos_url":"https://api.github.com/users/biopython/repos","events_url":"https://api.github.com/users/biopython/events{/privacy}","received_events_url":"https://api.github.com/users/biopython/received_events","type":"Organization","site_admin":false},"repo":{"id":151541,"name":"biopython","full_name":"biopython/biopython","owner":{"login":"biopython","id":54555,"avatar_url":"https://avatars3.githubusercontent.com/u/54555?v=4","gravatar_id":"","url":"https://api.github.com/users/biopython","html_url":"https://github.com/biopython","followers_url":"https://api.github.com/users/biopython/followers","following_url":"https://api.github.com/users/biopython/following{/other_user}","gists_url":"https://api.github.com/users/biopython/gists{/gist_id}","starred_url":"https://api.github.com/users/biopython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biopython/subscriptions","organizations_url":"https://api.github.com/users/biopython/orgs","repos_url":"https://api.github.com/users/biopython/repos","events_url":"https://api.github.com/users/biopython/events{/privacy}","received_events_url":"https://api.github.com/users/biopython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biopython/biopython","description":"Official git repository for Biopython (converted from CVS)","fork":false,"url":"https://api.github.com/repos/biopython/biopython","forks_url":"https://api.github.com/repos/biopython/biopython/forks","keys_url":"https://api.github.com/repos/biopython/biopython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biopython/biopython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biopython/biopython/teams","hooks_url":"https://api.github.com/repos/biopython/biopython/hooks","issue_events_url":"https://api.github.com/repos/biopython/biopython/issues/events{/number}","events_url":"https://api.github.com/repos/biopython/biopython/events","assignees_url":"https://api.github.com/repos/biopython/biopython/assignees{/user}","branches_url":"https://api.github.com/repos/biopython/biopython/branches{/branch}","tags_url":"https://api.github.com/repos/biopython/biopython/tags","blobs_url":"https://api.github.com/repos/biopython/biopython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biopython/biopython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biopython/biopython/git/refs{/sha}","trees_url":"https://api.github.com/repos/biopython/biopython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biopython/biopython/statuses/{sha}","languages_url":"https://api.github.com/repos/biopython/biopython/languages","stargazers_url":"https://api.github.com/repos/biopython/biopython/stargazers","contributors_url":"https://api.github.com/repos/biopython/biopython/contributors","subscribers_url":"https://api.github.com/repos/biopython/biopython/subscribers","subscription_url":"https://api.github.com/repos/biopython/biopython/subscription","commits_url":"https://api.github.com/repos/biopython/biopython/commits{/sha}","git_commits_url":"https://api.github.com/repos/biopython/biopython/git/commits{/sha}","comments_url":"https://api.github.com/repos/biopython/biopython/comments{/number}","issue_comment_url":"https://api.github.com/repos/biopython/biopython/issues/comments{/number}","contents_url":"https://api.github.com/repos/biopython/biopython/contents/{+path}","compare_url":"https://api.github.com/repos/biopython/biopython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biopython/biopython/merges","archive_url":"https://api.github.com/repos/biopython/biopython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biopython/biopython/downloads","issues_url":"https://api.github.com/repos/biopython/biopython/issues{/number}","pulls_url":"https://api.github.com/repos/biopython/biopython/pulls{/number}","milestones_url":"https://api.github.com/repos/biopython/biopython/milestones{/number}","notifications_url":"https://api.github.com/repos/biopython/biopython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biopython/biopython/labels{/name}","releases_url":"https://api.github.com/repos/biopython/biopython/releases{/id}","deployments_url":"https://api.github.com/repos/biopython/biopython/deployments","created_at":"2009-03-15T21:09:53Z","updated_at":"2018-04-09T14:09:15Z","pushed_at":"2018-04-09T14:15:33Z","git_url":"git://github.com/biopython/biopython.git","ssh_url":"git@github.com:biopython/biopython.git","clone_url":"https://github.com/biopython/biopython.git","svn_url":"https://github.com/biopython/biopython","homepage":"http://biopython.org/","size":45630,"stargazers_count":1309,"watchers_count":1309,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":740,"mirror_url":null,"archived":false,"open_issues_count":297,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":740,"open_issues":297,"watchers":1309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biopython/biopython/pulls/1522"},"html":{"href":"https://github.com/biopython/biopython/pull/1522"},"issue":{"href":"https://api.github.com/repos/biopython/biopython/issues/1522"},"comments":{"href":"https://api.github.com/repos/biopython/biopython/issues/1522/comments"},"review_comments":{"href":"https://api.github.com/repos/biopython/biopython/pulls/1522/comments"},"review_comment":{"href":"https://api.github.com/repos/biopython/biopython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biopython/biopython/pulls/1522/commits"},"statuses":{"href":"https://api.github.com/repos/biopython/biopython/statuses/ee05a28db5e83a2744261515ff7969946cd11fdb"}},"author_association":"NONE"}}
{"actor":{"display_login":"peterjc"}}