{"action":"created","comment":{"url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/comments/217723336","pull_request_review_id":155508877,"id":217723336,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzcyMzMzNg==","diff_hunk":"@@ -38,5 +44,20 @@ def add_reference(ref, path)\n         .write\n     end\n \n+    # Run the finish_build commands, if they exist. Should any fail,\n+    # halt the build and raise an error.\n+    def finish_build!(path)\n+      steps_path = path/\"finish_build.yml\"\n+      if steps_path.exist?\n+        step_list = StepList.new(YAML.safe_load(File.read(steps_path)))\n+        Dir.chdir(path) do\n+          step_list.steps.each do |step|\n+            _, _, status = runner.run(step.cmd)","path":"lib/fauxpaas/artifact_builder.rb","position":52,"original_position":52,"commit_id":"4b83e4f956e670d4ca46cc3a75159af1c2dfe3b3","original_commit_id":"4b83e4f956e670d4ca46cc3a75159af1c2dfe3b3","user":{"login":"aelkiss","id":3856018,"node_id":"MDQ6VXNlcjM4NTYwMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3856018?v=4","gravatar_id":"","url":"https://api.github.com/users/aelkiss","html_url":"https://github.com/aelkiss","followers_url":"https://api.github.com/users/aelkiss/followers","following_url":"https://api.github.com/users/aelkiss/following{/other_user}","gists_url":"https://api.github.com/users/aelkiss/gists{/gist_id}","starred_url":"https://api.github.com/users/aelkiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aelkiss/subscriptions","organizations_url":"https://api.github.com/users/aelkiss/orgs","repos_url":"https://api.github.com/users/aelkiss/repos","events_url":"https://api.github.com/users/aelkiss/events{/privacy}","received_events_url":"https://api.github.com/users/aelkiss/received_events","type":"User","site_admin":false},"body":"We probably want to add `Bundler.with_clean_env do` around `runner.run`, either here or (probably more appropriately) in the runner itself.","created_at":"2018-09-14T14:02:20Z","updated_at":"2018-09-14T14:02:21Z","html_url":"https://github.com/mlibrary/fauxpaas/pull/60#discussion_r217723336","pull_request_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/60","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/comments/217723336"},"html":{"href":"https://github.com/mlibrary/fauxpaas/pull/60#discussion_r217723336"},"pull_request":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/60","id":215382598,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MzgyNTk4","html_url":"https://github.com/mlibrary/fauxpaas/pull/60","diff_url":"https://github.com/mlibrary/fauxpaas/pull/60.diff","patch_url":"https://github.com/mlibrary/fauxpaas/pull/60.patch","issue_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/60","number":60,"state":"open","locked":false,"title":"Add finish_build steps in ArtifactBuilder","user":{"login":"malakai97","id":3486429,"node_id":"MDQ6VXNlcjM0ODY0Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/3486429?v=4","gravatar_id":"","url":"https://api.github.com/users/malakai97","html_url":"https://github.com/malakai97","followers_url":"https://api.github.com/users/malakai97/followers","following_url":"https://api.github.com/users/malakai97/following{/other_user}","gists_url":"https://api.github.com/users/malakai97/gists{/gist_id}","starred_url":"https://api.github.com/users/malakai97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malakai97/subscriptions","organizations_url":"https://api.github.com/users/malakai97/orgs","repos_url":"https://api.github.com/users/malakai97/repos","events_url":"https://api.github.com/users/malakai97/events{/privacy}","received_events_url":"https://api.github.com/users/malakai97/received_events","type":"User","site_admin":false},"body":"Resolves AEIM-1375\r\n\r\n* Renames after_build -> finish_build\r\n* Add StepList class that (lightly) wraps finish_build.yml and similar\r\n  files.\r\n* Remove running of after_build commands from capistrano.\r\n* Runs the commands in ArtifactBuilder.\r\n* Updates DESIGN.md","created_at":"2018-09-13T18:59:54Z","updated_at":"2018-09-14T14:02:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"424e835250678ba52e1060d1fe776ed48c089e61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/60/commits","review_comments_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/60/comments","review_comment_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/60/comments","statuses_url":"https://api.github.com/repos/mlibrary/fauxpaas/statuses/4b83e4f956e670d4ca46cc3a75159af1c2dfe3b3","head":{"label":"mlibrary:aeim-1375/finish_build","ref":"aeim-1375/finish_build","sha":"4b83e4f956e670d4ca46cc3a75159af1c2dfe3b3","user":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":102662551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2NjI1NTE=","name":"fauxpaas","full_name":"mlibrary/fauxpaas","owner":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlibrary/fauxpaas","description":"Deployment tooling for Ruby projects at MLibrary","fork":false,"url":"https://api.github.com/repos/mlibrary/fauxpaas","forks_url":"https://api.github.com/repos/mlibrary/fauxpaas/forks","keys_url":"https://api.github.com/repos/mlibrary/fauxpaas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlibrary/fauxpaas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlibrary/fauxpaas/teams","hooks_url":"https://api.github.com/repos/mlibrary/fauxpaas/hooks","issue_events_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/events{/number}","events_url":"https://api.github.com/repos/mlibrary/fauxpaas/events","assignees_url":"https://api.github.com/repos/mlibrary/fauxpaas/assignees{/user}","branches_url":"https://api.github.com/repos/mlibrary/fauxpaas/branches{/branch}","tags_url":"https://api.github.com/repos/mlibrary/fauxpaas/tags","blobs_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlibrary/fauxpaas/statuses/{sha}","languages_url":"https://api.github.com/repos/mlibrary/fauxpaas/languages","stargazers_url":"https://api.github.com/repos/mlibrary/fauxpaas/stargazers","contributors_url":"https://api.github.com/repos/mlibrary/fauxpaas/contributors","subscribers_url":"https://api.github.com/repos/mlibrary/fauxpaas/subscribers","subscription_url":"https://api.github.com/repos/mlibrary/fauxpaas/subscription","commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlibrary/fauxpaas/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlibrary/fauxpaas/contents/{+path}","compare_url":"https://api.github.com/repos/mlibrary/fauxpaas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlibrary/fauxpaas/merges","archive_url":"https://api.github.com/repos/mlibrary/fauxpaas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlibrary/fauxpaas/downloads","issues_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues{/number}","pulls_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls{/number}","milestones_url":"https://api.github.com/repos/mlibrary/fauxpaas/milestones{/number}","notifications_url":"https://api.github.com/repos/mlibrary/fauxpaas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlibrary/fauxpaas/labels{/name}","releases_url":"https://api.github.com/repos/mlibrary/fauxpaas/releases{/id}","deployments_url":"https://api.github.com/repos/mlibrary/fauxpaas/deployments","created_at":"2017-09-06T22:01:59Z","updated_at":"2018-09-13T15:25:21Z","pushed_at":"2018-09-14T13:27:08Z","git_url":"git://github.com/mlibrary/fauxpaas.git","ssh_url":"git@github.com:mlibrary/fauxpaas.git","clone_url":"https://github.com/mlibrary/fauxpaas.git","svn_url":"https://github.com/mlibrary/fauxpaas","homepage":"","size":459,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":6,"watchers":0,"default_branch":"develop"}},"base":{"label":"mlibrary:develop","ref":"develop","sha":"b0c6ded8d57e0ed272a45d67d94d620446691cc3","user":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":102662551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2NjI1NTE=","name":"fauxpaas","full_name":"mlibrary/fauxpaas","owner":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlibrary/fauxpaas","description":"Deployment tooling for Ruby projects at MLibrary","fork":false,"url":"https://api.github.com/repos/mlibrary/fauxpaas","forks_url":"https://api.github.com/repos/mlibrary/fauxpaas/forks","keys_url":"https://api.github.com/repos/mlibrary/fauxpaas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlibrary/fauxpaas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlibrary/fauxpaas/teams","hooks_url":"https://api.github.com/repos/mlibrary/fauxpaas/hooks","issue_events_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/events{/number}","events_url":"https://api.github.com/repos/mlibrary/fauxpaas/events","assignees_url":"https://api.github.com/repos/mlibrary/fauxpaas/assignees{/user}","branches_url":"https://api.github.com/repos/mlibrary/fauxpaas/branches{/branch}","tags_url":"https://api.github.com/repos/mlibrary/fauxpaas/tags","blobs_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlibrary/fauxpaas/statuses/{sha}","languages_url":"https://api.github.com/repos/mlibrary/fauxpaas/languages","stargazers_url":"https://api.github.com/repos/mlibrary/fauxpaas/stargazers","contributors_url":"https://api.github.com/repos/mlibrary/fauxpaas/contributors","subscribers_url":"https://api.github.com/repos/mlibrary/fauxpaas/subscribers","subscription_url":"https://api.github.com/repos/mlibrary/fauxpaas/subscription","commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlibrary/fauxpaas/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlibrary/fauxpaas/contents/{+path}","compare_url":"https://api.github.com/repos/mlibrary/fauxpaas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlibrary/fauxpaas/merges","archive_url":"https://api.github.com/repos/mlibrary/fauxpaas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlibrary/fauxpaas/downloads","issues_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues{/number}","pulls_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls{/number}","milestones_url":"https://api.github.com/repos/mlibrary/fauxpaas/milestones{/number}","notifications_url":"https://api.github.com/repos/mlibrary/fauxpaas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlibrary/fauxpaas/labels{/name}","releases_url":"https://api.github.com/repos/mlibrary/fauxpaas/releases{/id}","deployments_url":"https://api.github.com/repos/mlibrary/fauxpaas/deployments","created_at":"2017-09-06T22:01:59Z","updated_at":"2018-09-13T15:25:21Z","pushed_at":"2018-09-14T13:27:08Z","git_url":"git://github.com/mlibrary/fauxpaas.git","ssh_url":"git@github.com:mlibrary/fauxpaas.git","clone_url":"https://github.com/mlibrary/fauxpaas.git","svn_url":"https://github.com/mlibrary/fauxpaas","homepage":"","size":459,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":6,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/60"},"html":{"href":"https://github.com/mlibrary/fauxpaas/pull/60"},"issue":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/issues/60"},"comments":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/statuses/4b83e4f956e670d4ca46cc3a75159af1c2dfe3b3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aelkiss"}}