{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/apm-agent-java/pulls/comments/221058297","pull_request_review_id":159616485,"id":221058297,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTA1ODI5Nw==","diff_hunk":"@@ -0,0 +1,125 @@\n+/*-\n+ * #%L\n+ * Elastic APM Java agent\n+ * %%\n+ * Copyright (C) 2018 Elastic and contributors\n+ * %%\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ * \n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ * \n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ * #L%\n+ */\n+package co.elastic.apm.bci.bytebuddy;\n+\n+import com.blogspot.mydailyjava.weaklockfree.WeakConcurrentMap;\n+import com.googlecode.concurrentlinkedhashmap.ConcurrentLinkedHashMap;\n+import com.googlecode.concurrentlinkedhashmap.Weigher;\n+import net.bytebuddy.agent.builder.AgentBuilder;\n+import net.bytebuddy.description.type.TypeDescription;\n+import net.bytebuddy.pool.TypePool;\n+\n+import java.util.concurrent.ConcurrentMap;\n+\n+/**\n+ * Caches {@link TypeDescription}s which speeds up type matching -\n+ * especially when the matching requires lookup of other {@link TypeDescription}s.\n+ * Such as when in order to match a type, it's superclass has to be determined.\n+ * Without a type pool cache those types would have to be re-loaded from the file system if their {@link Class} file has not been loaded yet.","path":"apm-agent-core/src/main/java/co/elastic/apm/bci/bytebuddy/SizeLimitedLruTypePoolCache.java","position":35,"original_position":35,"commit_id":"645b505859de2ad9269e9c9ee73c7a34ff121509","original_commit_id":"645b505859de2ad9269e9c9ee73c7a34ff121509","user":{"login":"felixbarny","id":2163464,"node_id":"MDQ6VXNlcjIxNjM0NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2163464?v=4","gravatar_id":"","url":"https://api.github.com/users/felixbarny","html_url":"https://github.com/felixbarny","followers_url":"https://api.github.com/users/felixbarny/followers","following_url":"https://api.github.com/users/felixbarny/following{/other_user}","gists_url":"https://api.github.com/users/felixbarny/gists{/gist_id}","starred_url":"https://api.github.com/users/felixbarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixbarny/subscriptions","organizations_url":"https://api.github.com/users/felixbarny/orgs","repos_url":"https://api.github.com/users/felixbarny/repos","events_url":"https://api.github.com/users/felixbarny/events{/privacy}","received_events_url":"https://api.github.com/users/felixbarny/received_events","type":"User","site_admin":false},"body":"~file~","created_at":"2018-09-27T20:01:28Z","updated_at":"2018-09-27T20:01:46Z","html_url":"https://github.com/elastic/apm-agent-java/pull/229#discussion_r221058297","pull_request_url":"https://api.github.com/repos/elastic/apm-agent-java/pulls/229","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/apm-agent-java/pulls/comments/221058297"},"html":{"href":"https://github.com/elastic/apm-agent-java/pull/229#discussion_r221058297"},"pull_request":{"href":"https://api.github.com/repos/elastic/apm-agent-java/pulls/229"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/apm-agent-java/pulls/229","id":218693727,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NjkzNzI3","html_url":"https://github.com/elastic/apm-agent-java/pull/229","diff_url":"https://github.com/elastic/apm-agent-java/pull/229.diff","patch_url":"https://github.com/elastic/apm-agent-java/pull/229.patch","issue_url":"https://api.github.com/repos/elastic/apm-agent-java/issues/229","number":229,"state":"open","locked":false,"title":"Implement SizeLimitedLruTypePoolCache","user":{"login":"felixbarny","id":2163464,"node_id":"MDQ6VXNlcjIxNjM0NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2163464?v=4","gravatar_id":"","url":"https://api.github.com/users/felixbarny","html_url":"https://github.com/felixbarny","followers_url":"https://api.github.com/users/felixbarny/followers","following_url":"https://api.github.com/users/felixbarny/following{/other_user}","gists_url":"https://api.github.com/users/felixbarny/gists{/gist_id}","starred_url":"https://api.github.com/users/felixbarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixbarny/subscriptions","organizations_url":"https://api.github.com/users/felixbarny/orgs","repos_url":"https://api.github.com/users/felixbarny/repos","events_url":"https://api.github.com/users/felixbarny/events{/privacy}","received_events_url":"https://api.github.com/users/felixbarny/received_events","type":"User","site_admin":false},"body":"to speed up type matching","created_at":"2018-09-27T15:22:09Z","updated_at":"2018-09-27T20:01:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da471332b74be17176db5de68ab088d1dee51cc0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/apm-agent-java/pulls/229/commits","review_comments_url":"https://api.github.com/repos/elastic/apm-agent-java/pulls/229/comments","review_comment_url":"https://api.github.com/repos/elastic/apm-agent-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/apm-agent-java/issues/229/comments","statuses_url":"https://api.github.com/repos/elastic/apm-agent-java/statuses/645b505859de2ad9269e9c9ee73c7a34ff121509","head":{"label":"felixbarny:type-pool-cache","ref":"type-pool-cache","sha":"645b505859de2ad9269e9c9ee73c7a34ff121509","user":{"login":"felixbarny","id":2163464,"node_id":"MDQ6VXNlcjIxNjM0NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2163464?v=4","gravatar_id":"","url":"https://api.github.com/users/felixbarny","html_url":"https://github.com/felixbarny","followers_url":"https://api.github.com/users/felixbarny/followers","following_url":"https://api.github.com/users/felixbarny/following{/other_user}","gists_url":"https://api.github.com/users/felixbarny/gists{/gist_id}","starred_url":"https://api.github.com/users/felixbarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixbarny/subscriptions","organizations_url":"https://api.github.com/users/felixbarny/orgs","repos_url":"https://api.github.com/users/felixbarny/repos","events_url":"https://api.github.com/users/felixbarny/events{/privacy}","received_events_url":"https://api.github.com/users/felixbarny/received_events","type":"User","site_admin":false},"repo":{"id":124447180,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ0NDcxODA=","name":"apm-agent-java","full_name":"felixbarny/apm-agent-java","private":false,"owner":{"login":"felixbarny","id":2163464,"node_id":"MDQ6VXNlcjIxNjM0NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2163464?v=4","gravatar_id":"","url":"https://api.github.com/users/felixbarny","html_url":"https://github.com/felixbarny","followers_url":"https://api.github.com/users/felixbarny/followers","following_url":"https://api.github.com/users/felixbarny/following{/other_user}","gists_url":"https://api.github.com/users/felixbarny/gists{/gist_id}","starred_url":"https://api.github.com/users/felixbarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixbarny/subscriptions","organizations_url":"https://api.github.com/users/felixbarny/orgs","repos_url":"https://api.github.com/users/felixbarny/repos","events_url":"https://api.github.com/users/felixbarny/events{/privacy}","received_events_url":"https://api.github.com/users/felixbarny/received_events","type":"User","site_admin":false},"html_url":"https://github.com/felixbarny/apm-agent-java","description":"Elastic APM Java Agent (pre-alpha)","fork":true,"url":"https://api.github.com/repos/felixbarny/apm-agent-java","forks_url":"https://api.github.com/repos/felixbarny/apm-agent-java/forks","keys_url":"https://api.github.com/repos/felixbarny/apm-agent-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felixbarny/apm-agent-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felixbarny/apm-agent-java/teams","hooks_url":"https://api.github.com/repos/felixbarny/apm-agent-java/hooks","issue_events_url":"https://api.github.com/repos/felixbarny/apm-agent-java/issues/events{/number}","events_url":"https://api.github.com/repos/felixbarny/apm-agent-java/events","assignees_url":"https://api.github.com/repos/felixbarny/apm-agent-java/assignees{/user}","branches_url":"https://api.github.com/repos/felixbarny/apm-agent-java/branches{/branch}","tags_url":"https://api.github.com/repos/felixbarny/apm-agent-java/tags","blobs_url":"https://api.github.com/repos/felixbarny/apm-agent-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felixbarny/apm-agent-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felixbarny/apm-agent-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/felixbarny/apm-agent-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felixbarny/apm-agent-java/statuses/{sha}","languages_url":"https://api.github.com/repos/felixbarny/apm-agent-java/languages","stargazers_url":"https://api.github.com/repos/felixbarny/apm-agent-java/stargazers","contributors_url":"https://api.github.com/repos/felixbarny/apm-agent-java/contributors","subscribers_url":"https://api.github.com/repos/felixbarny/apm-agent-java/subscribers","subscription_url":"https://api.github.com/repos/felixbarny/apm-agent-java/subscription","commits_url":"https://api.github.com/repos/felixbarny/apm-agent-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/felixbarny/apm-agent-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/felixbarny/apm-agent-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/felixbarny/apm-agent-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/felixbarny/apm-agent-java/contents/{+path}","compare_url":"https://api.github.com/repos/felixbarny/apm-agent-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felixbarny/apm-agent-java/merges","archive_url":"https://api.github.com/repos/felixbarny/apm-agent-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felixbarny/apm-agent-java/downloads","issues_url":"https://api.github.com/repos/felixbarny/apm-agent-java/issues{/number}","pulls_url":"https://api.github.com/repos/felixbarny/apm-agent-java/pulls{/number}","milestones_url":"https://api.github.com/repos/felixbarny/apm-agent-java/milestones{/number}","notifications_url":"https://api.github.com/repos/felixbarny/apm-agent-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felixbarny/apm-agent-java/labels{/name}","releases_url":"https://api.github.com/repos/felixbarny/apm-agent-java/releases{/id}","deployments_url":"https://api.github.com/repos/felixbarny/apm-agent-java/deployments","created_at":"2018-03-08T20:56:11Z","updated_at":"2018-05-28T08:01:03Z","pushed_at":"2018-09-27T15:21:57Z","git_url":"git://github.com/felixbarny/apm-agent-java.git","ssh_url":"git@github.com:felixbarny/apm-agent-java.git","clone_url":"https://github.com/felixbarny/apm-agent-java.git","svn_url":"https://github.com/felixbarny/apm-agent-java","homepage":"https://www.elastic.co/solutions/apm","size":1766,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"342712960cc8e0584c2e16fccad53e2b8ef035e9","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":121236494,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEyMzY0OTQ=","name":"apm-agent-java","full_name":"elastic/apm-agent-java","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/apm-agent-java","description":"Elastic APM Java Agent (beta)","fork":false,"url":"https://api.github.com/repos/elastic/apm-agent-java","forks_url":"https://api.github.com/repos/elastic/apm-agent-java/forks","keys_url":"https://api.github.com/repos/elastic/apm-agent-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/apm-agent-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/apm-agent-java/teams","hooks_url":"https://api.github.com/repos/elastic/apm-agent-java/hooks","issue_events_url":"https://api.github.com/repos/elastic/apm-agent-java/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/apm-agent-java/events","assignees_url":"https://api.github.com/repos/elastic/apm-agent-java/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/apm-agent-java/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/apm-agent-java/tags","blobs_url":"https://api.github.com/repos/elastic/apm-agent-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/apm-agent-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/apm-agent-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/apm-agent-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/apm-agent-java/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/apm-agent-java/languages","stargazers_url":"https://api.github.com/repos/elastic/apm-agent-java/stargazers","contributors_url":"https://api.github.com/repos/elastic/apm-agent-java/contributors","subscribers_url":"https://api.github.com/repos/elastic/apm-agent-java/subscribers","subscription_url":"https://api.github.com/repos/elastic/apm-agent-java/subscription","commits_url":"https://api.github.com/repos/elastic/apm-agent-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/apm-agent-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/apm-agent-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/apm-agent-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/apm-agent-java/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/apm-agent-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/apm-agent-java/merges","archive_url":"https://api.github.com/repos/elastic/apm-agent-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/apm-agent-java/downloads","issues_url":"https://api.github.com/repos/elastic/apm-agent-java/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/apm-agent-java/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/apm-agent-java/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/apm-agent-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/apm-agent-java/labels{/name}","releases_url":"https://api.github.com/repos/elastic/apm-agent-java/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/apm-agent-java/deployments","created_at":"2018-02-12T11:05:32Z","updated_at":"2018-09-25T12:35:39Z","pushed_at":"2018-09-27T15:22:09Z","git_url":"git://github.com/elastic/apm-agent-java.git","ssh_url":"git@github.com:elastic/apm-agent-java.git","clone_url":"https://github.com/elastic/apm-agent-java.git","svn_url":"https://github.com/elastic/apm-agent-java","homepage":"https://www.elastic.co/guide/en/apm/agent/java/current/index.html","size":1804,"stargazers_count":102,"watchers_count":102,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":27,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/apm-agent-java/pulls/229"},"html":{"href":"https://github.com/elastic/apm-agent-java/pull/229"},"issue":{"href":"https://api.github.com/repos/elastic/apm-agent-java/issues/229"},"comments":{"href":"https://api.github.com/repos/elastic/apm-agent-java/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/apm-agent-java/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/apm-agent-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/apm-agent-java/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/apm-agent-java/statuses/645b505859de2ad9269e9c9ee73c7a34ff121509"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"felixbarny"}}