{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/comments/220182953","pull_request_review_id":158529242,"id":220182953,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDE4Mjk1Mw==","diff_hunk":"@@ -0,0 +1,17 @@\n+apiVersion: kubecontrolplane.config.openshift.io/v1\n+kind: KubeControllerManagerConfig\n+serviceServingCert:\n+  certFile: service-signer.crt\n+extendedArguments:\n+  cloud-config:\n+  - \"/etc/kubernetes/cloud/config\"\n+  root-ca-file:\n+  - \"/etc/kubernetes/secrets/root-ca.crt\"\n+  service-account-private-key-file:\n+  - \"/etc/kubernetes/secrets/service-account.key\"\n+  cluster-signing-cert-file:\n+  - \"/etc/kubernetes/secrets/kube-ca.crt\"\n+  cluster-signing-key-file:\n+  - \"/etc/kubernetes/secrets/kube-ca.key\"\n+  kubeconfig:","path":"manifests/bootkube/config/bootstrap-config-overrides.yaml","position":16,"original_position":16,"commit_id":"f84f9180bc62f0655d224f0191943e23502076ac","original_commit_id":"00bac497a8995327c017b2e13a63a9d883ae82ba","user":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"good to know.","created_at":"2018-09-25T13:04:39Z","updated_at":"2018-09-25T13:04:39Z","html_url":"https://github.com/openshift/cluster-kube-controller-manager-operator/pull/7#discussion_r220182953","pull_request_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/7","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/comments/220182953"},"html":{"href":"https://github.com/openshift/cluster-kube-controller-manager-operator/pull/7#discussion_r220182953"},"pull_request":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/7"}},"in_reply_to_id":220182700},"pull_request":{"url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/7","id":217971691,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3OTcxNjkx","html_url":"https://github.com/openshift/cluster-kube-controller-manager-operator/pull/7","diff_url":"https://github.com/openshift/cluster-kube-controller-manager-operator/pull/7.diff","patch_url":"https://github.com/openshift/cluster-kube-controller-manager-operator/pull/7.patch","issue_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues/7","number":7,"state":"open","locked":false,"title":"render: complete config","user":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-09-25T13:02:11Z","updated_at":"2018-09-25T13:04:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bde19077466e173523320140bc8925bb01a5871","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mfojtik","id":44136,"node_id":"MDQ6VXNlcjQ0MTM2","avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1064873905,"node_id":"MDU6TGFiZWwxMDY0ODczOTA1","url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/labels/approved","name":"approved","color":"ededed","default":false},{"id":1068771154,"node_id":"MDU6TGFiZWwxMDY4NzcxMTU0","url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"ededed","default":false},{"id":1067309749,"node_id":"MDU6TGFiZWwxMDY3MzA5NzQ5","url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/7/commits","review_comments_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/7/comments","review_comment_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues/7/comments","statuses_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/statuses/f84f9180bc62f0655d224f0191943e23502076ac","head":{"label":"sttts:sttts-ctrl-manager-config","ref":"sttts-ctrl-manager-config","sha":"f84f9180bc62f0655d224f0191943e23502076ac","user":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"repo":{"id":150080354,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAwODAzNTQ=","name":"cluster-kube-controller-manager-operator","full_name":"sttts/cluster-kube-controller-manager-operator","private":false,"owner":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sttts/cluster-kube-controller-manager-operator","description":"The kube-controller-manager operator installs and maintains the kube-controller-manager on a cluster","fork":true,"url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator","forks_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/forks","keys_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/teams","hooks_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/hooks","issue_events_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/issues/events{/number}","events_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/events","assignees_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/assignees{/user}","branches_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/branches{/branch}","tags_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/tags","blobs_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/languages","stargazers_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/stargazers","contributors_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/contributors","subscribers_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/subscribers","subscription_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/subscription","commits_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/contents/{+path}","compare_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/merges","archive_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/downloads","issues_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/issues{/number}","pulls_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/labels{/name}","releases_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/releases{/id}","deployments_url":"https://api.github.com/repos/sttts/cluster-kube-controller-manager-operator/deployments","created_at":"2018-09-24T09:30:23Z","updated_at":"2018-09-24T09:30:25Z","pushed_at":"2018-09-25T13:04:16Z","git_url":"git://github.com/sttts/cluster-kube-controller-manager-operator.git","ssh_url":"git@github.com:sttts/cluster-kube-controller-manager-operator.git","clone_url":"https://github.com/sttts/cluster-kube-controller-manager-operator.git","svn_url":"https://github.com/sttts/cluster-kube-controller-manager-operator","homepage":null,"size":15246,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"a17f04a38e83fefc64e4e7002bfc76de7df2f13f","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":148497748,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg0OTc3NDg=","name":"cluster-kube-controller-manager-operator","full_name":"openshift/cluster-kube-controller-manager-operator","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/cluster-kube-controller-manager-operator","description":"The kube-controller-manager operator installs and maintains the kube-controller-manager on a cluster","fork":false,"url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator","forks_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/forks","keys_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/events","assignees_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/merges","archive_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/deployments","created_at":"2018-09-12T14:59:05Z","updated_at":"2018-09-25T07:17:56Z","pushed_at":"2018-09-25T13:04:17Z","git_url":"git://github.com/openshift/cluster-kube-controller-manager-operator.git","ssh_url":"git@github.com:openshift/cluster-kube-controller-manager-operator.git","clone_url":"https://github.com/openshift/cluster-kube-controller-manager-operator.git","svn_url":"https://github.com/openshift/cluster-kube-controller-manager-operator","homepage":null,"size":15311,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/7"},"html":{"href":"https://github.com/openshift/cluster-kube-controller-manager-operator/pull/7"},"issue":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues/7"},"comments":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/statuses/f84f9180bc62f0655d224f0191943e23502076ac"}},"author_association":"NONE"}}
{"actor":{"display_login":"sttts"}}