{"action":"created","comment":{"url":"https://api.github.com/repos/arangodb/arangodb/pulls/comments/189699362","pull_request_review_id":121917469,"id":189699362,"diff_hunk":"@@ -201,13 +203,13 @@ void RocksDBCollection::getPropertiesVPack(velocypack::Builder& result) const {\n }\n \n /// @brief used for updating properties\n-void RocksDBCollection::getPropertiesVPackCoordinator(\n+/*void RocksDBCollection::getPropertiesVPackCoordinator(","path":"arangod/RocksDBEngine/RocksDBCollection.cpp","position":29,"original_position":29,"commit_id":"5331ba9a1f4404bbd1107ff21dd9e78af2724b49","original_commit_id":"5331ba9a1f4404bbd1107ff21dd9e78af2724b49","user":{"login":"jsteemann","id":1423118,"avatar_url":"https://avatars0.githubusercontent.com/u/1423118?v=4","gravatar_id":"","url":"https://api.github.com/users/jsteemann","html_url":"https://github.com/jsteemann","followers_url":"https://api.github.com/users/jsteemann/followers","following_url":"https://api.github.com/users/jsteemann/following{/other_user}","gists_url":"https://api.github.com/users/jsteemann/gists{/gist_id}","starred_url":"https://api.github.com/users/jsteemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsteemann/subscriptions","organizations_url":"https://api.github.com/users/jsteemann/orgs","repos_url":"https://api.github.com/users/jsteemann/repos","events_url":"https://api.github.com/users/jsteemann/events{/privacy}","received_events_url":"https://api.github.com/users/jsteemann/received_events","type":"User","site_admin":false},"body":"can this be removed?","created_at":"2018-05-21T20:10:36Z","updated_at":"2018-05-21T20:17:53Z","html_url":"https://github.com/arangodb/arangodb/pull/5405#discussion_r189699362","pull_request_url":"https://api.github.com/repos/arangodb/arangodb/pulls/5405","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/comments/189699362"},"html":{"href":"https://github.com/arangodb/arangodb/pull/5405#discussion_r189699362"},"pull_request":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/5405"}}},"pull_request":{"url":"https://api.github.com/repos/arangodb/arangodb/pulls/5405","id":189226986,"html_url":"https://github.com/arangodb/arangodb/pull/5405","diff_url":"https://github.com/arangodb/arangodb/pull/5405.diff","patch_url":"https://github.com/arangodb/arangodb/pull/5405.patch","issue_url":"https://api.github.com/repos/arangodb/arangodb/issues/5405","number":5405,"state":"open","locked":false,"title":"Coordinator storage engine","user":{"login":"graetzer","id":865417,"avatar_url":"https://avatars3.githubusercontent.com/u/865417?v=4","gravatar_id":"","url":"https://api.github.com/users/graetzer","html_url":"https://github.com/graetzer","followers_url":"https://api.github.com/users/graetzer/followers","following_url":"https://api.github.com/users/graetzer/following{/other_user}","gists_url":"https://api.github.com/users/graetzer/gists{/gist_id}","starred_url":"https://api.github.com/users/graetzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graetzer/subscriptions","organizations_url":"https://api.github.com/users/graetzer/orgs","repos_url":"https://api.github.com/users/graetzer/repos","events_url":"https://api.github.com/users/graetzer/events{/privacy}","received_events_url":"https://api.github.com/users/graetzer/received_events","type":"User","site_admin":false},"body":"- Coordinator now has a `fake` storage engine\r\n- Simulates the rocksdb / mmfiles behaviour where necessary\r\n- Add `flags` field for `ExecutionNode` serialization to avoid calculating cost estimates \r\n\r\nLong-Term plan is to get rid of most places where we do `if (isCoordinator) {...} else {...}`","created_at":"2018-05-20T09:56:14Z","updated_at":"2018-05-21T20:17:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bade40656e2e82ae6c8b1f0b4dee7f010071d709","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danielhlarkin","id":13419935,"avatar_url":"https://avatars1.githubusercontent.com/u/13419935?v=4","gravatar_id":"","url":"https://api.github.com/users/danielhlarkin","html_url":"https://github.com/danielhlarkin","followers_url":"https://api.github.com/users/danielhlarkin/followers","following_url":"https://api.github.com/users/danielhlarkin/following{/other_user}","gists_url":"https://api.github.com/users/danielhlarkin/gists{/gist_id}","starred_url":"https://api.github.com/users/danielhlarkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielhlarkin/subscriptions","organizations_url":"https://api.github.com/users/danielhlarkin/orgs","repos_url":"https://api.github.com/users/danielhlarkin/repos","events_url":"https://api.github.com/users/danielhlarkin/events{/privacy}","received_events_url":"https://api.github.com/users/danielhlarkin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arangodb/arangodb/pulls/5405/commits","review_comments_url":"https://api.github.com/repos/arangodb/arangodb/pulls/5405/comments","review_comment_url":"https://api.github.com/repos/arangodb/arangodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arangodb/arangodb/issues/5405/comments","statuses_url":"https://api.github.com/repos/arangodb/arangodb/statuses/5331ba9a1f4404bbd1107ff21dd9e78af2724b49","head":{"label":"arangodb:feature/cluster-engine","ref":"feature/cluster-engine","sha":"5331ba9a1f4404bbd1107ff21dd9e78af2724b49","user":{"login":"arangodb","id":5547849,"avatar_url":"https://avatars0.githubusercontent.com/u/5547849?v=4","gravatar_id":"","url":"https://api.github.com/users/arangodb","html_url":"https://github.com/arangodb","followers_url":"https://api.github.com/users/arangodb/followers","following_url":"https://api.github.com/users/arangodb/following{/other_user}","gists_url":"https://api.github.com/users/arangodb/gists{/gist_id}","starred_url":"https://api.github.com/users/arangodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arangodb/subscriptions","organizations_url":"https://api.github.com/users/arangodb/orgs","repos_url":"https://api.github.com/users/arangodb/repos","events_url":"https://api.github.com/users/arangodb/events{/privacy}","received_events_url":"https://api.github.com/users/arangodb/received_events","type":"Organization","site_admin":false},"repo":{"id":2649214,"name":"arangodb","full_name":"arangodb/arangodb","owner":{"login":"arangodb","id":5547849,"avatar_url":"https://avatars0.githubusercontent.com/u/5547849?v=4","gravatar_id":"","url":"https://api.github.com/users/arangodb","html_url":"https://github.com/arangodb","followers_url":"https://api.github.com/users/arangodb/followers","following_url":"https://api.github.com/users/arangodb/following{/other_user}","gists_url":"https://api.github.com/users/arangodb/gists{/gist_id}","starred_url":"https://api.github.com/users/arangodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arangodb/subscriptions","organizations_url":"https://api.github.com/users/arangodb/orgs","repos_url":"https://api.github.com/users/arangodb/repos","events_url":"https://api.github.com/users/arangodb/events{/privacy}","received_events_url":"https://api.github.com/users/arangodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arangodb/arangodb","description":"🥑 ArangoDB is a native multi-model database with flexible data models for documents, graphs, and key-values. Build high performance applications using a convenient SQL-like query language or JavaScript extensions.","fork":false,"url":"https://api.github.com/repos/arangodb/arangodb","forks_url":"https://api.github.com/repos/arangodb/arangodb/forks","keys_url":"https://api.github.com/repos/arangodb/arangodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arangodb/arangodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arangodb/arangodb/teams","hooks_url":"https://api.github.com/repos/arangodb/arangodb/hooks","issue_events_url":"https://api.github.com/repos/arangodb/arangodb/issues/events{/number}","events_url":"https://api.github.com/repos/arangodb/arangodb/events","assignees_url":"https://api.github.com/repos/arangodb/arangodb/assignees{/user}","branches_url":"https://api.github.com/repos/arangodb/arangodb/branches{/branch}","tags_url":"https://api.github.com/repos/arangodb/arangodb/tags","blobs_url":"https://api.github.com/repos/arangodb/arangodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arangodb/arangodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arangodb/arangodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/arangodb/arangodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arangodb/arangodb/statuses/{sha}","languages_url":"https://api.github.com/repos/arangodb/arangodb/languages","stargazers_url":"https://api.github.com/repos/arangodb/arangodb/stargazers","contributors_url":"https://api.github.com/repos/arangodb/arangodb/contributors","subscribers_url":"https://api.github.com/repos/arangodb/arangodb/subscribers","subscription_url":"https://api.github.com/repos/arangodb/arangodb/subscription","commits_url":"https://api.github.com/repos/arangodb/arangodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/arangodb/arangodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/arangodb/arangodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/arangodb/arangodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/arangodb/arangodb/contents/{+path}","compare_url":"https://api.github.com/repos/arangodb/arangodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arangodb/arangodb/merges","archive_url":"https://api.github.com/repos/arangodb/arangodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arangodb/arangodb/downloads","issues_url":"https://api.github.com/repos/arangodb/arangodb/issues{/number}","pulls_url":"https://api.github.com/repos/arangodb/arangodb/pulls{/number}","milestones_url":"https://api.github.com/repos/arangodb/arangodb/milestones{/number}","notifications_url":"https://api.github.com/repos/arangodb/arangodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arangodb/arangodb/labels{/name}","releases_url":"https://api.github.com/repos/arangodb/arangodb/releases{/id}","deployments_url":"https://api.github.com/repos/arangodb/arangodb/deployments","created_at":"2011-10-26T06:42:00Z","updated_at":"2018-05-21T16:04:12Z","pushed_at":"2018-05-21T19:21:52Z","git_url":"git://github.com/arangodb/arangodb.git","ssh_url":"git@github.com:arangodb/arangodb.git","clone_url":"https://github.com/arangodb/arangodb.git","svn_url":"https://github.com/arangodb/arangodb","homepage":"https://www.arangodb.com","size":824804,"stargazers_count":5685,"watchers_count":5685,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":421,"mirror_url":null,"archived":false,"open_issues_count":426,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":421,"open_issues":426,"watchers":5685,"default_branch":"devel"}},"base":{"label":"arangodb:devel","ref":"devel","sha":"cf27c695f96e6070d6494d3867c23e56582963f8","user":{"login":"arangodb","id":5547849,"avatar_url":"https://avatars0.githubusercontent.com/u/5547849?v=4","gravatar_id":"","url":"https://api.github.com/users/arangodb","html_url":"https://github.com/arangodb","followers_url":"https://api.github.com/users/arangodb/followers","following_url":"https://api.github.com/users/arangodb/following{/other_user}","gists_url":"https://api.github.com/users/arangodb/gists{/gist_id}","starred_url":"https://api.github.com/users/arangodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arangodb/subscriptions","organizations_url":"https://api.github.com/users/arangodb/orgs","repos_url":"https://api.github.com/users/arangodb/repos","events_url":"https://api.github.com/users/arangodb/events{/privacy}","received_events_url":"https://api.github.com/users/arangodb/received_events","type":"Organization","site_admin":false},"repo":{"id":2649214,"name":"arangodb","full_name":"arangodb/arangodb","owner":{"login":"arangodb","id":5547849,"avatar_url":"https://avatars0.githubusercontent.com/u/5547849?v=4","gravatar_id":"","url":"https://api.github.com/users/arangodb","html_url":"https://github.com/arangodb","followers_url":"https://api.github.com/users/arangodb/followers","following_url":"https://api.github.com/users/arangodb/following{/other_user}","gists_url":"https://api.github.com/users/arangodb/gists{/gist_id}","starred_url":"https://api.github.com/users/arangodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arangodb/subscriptions","organizations_url":"https://api.github.com/users/arangodb/orgs","repos_url":"https://api.github.com/users/arangodb/repos","events_url":"https://api.github.com/users/arangodb/events{/privacy}","received_events_url":"https://api.github.com/users/arangodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arangodb/arangodb","description":"🥑 ArangoDB is a native multi-model database with flexible data models for documents, graphs, and key-values. Build high performance applications using a convenient SQL-like query language or JavaScript extensions.","fork":false,"url":"https://api.github.com/repos/arangodb/arangodb","forks_url":"https://api.github.com/repos/arangodb/arangodb/forks","keys_url":"https://api.github.com/repos/arangodb/arangodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arangodb/arangodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arangodb/arangodb/teams","hooks_url":"https://api.github.com/repos/arangodb/arangodb/hooks","issue_events_url":"https://api.github.com/repos/arangodb/arangodb/issues/events{/number}","events_url":"https://api.github.com/repos/arangodb/arangodb/events","assignees_url":"https://api.github.com/repos/arangodb/arangodb/assignees{/user}","branches_url":"https://api.github.com/repos/arangodb/arangodb/branches{/branch}","tags_url":"https://api.github.com/repos/arangodb/arangodb/tags","blobs_url":"https://api.github.com/repos/arangodb/arangodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arangodb/arangodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arangodb/arangodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/arangodb/arangodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arangodb/arangodb/statuses/{sha}","languages_url":"https://api.github.com/repos/arangodb/arangodb/languages","stargazers_url":"https://api.github.com/repos/arangodb/arangodb/stargazers","contributors_url":"https://api.github.com/repos/arangodb/arangodb/contributors","subscribers_url":"https://api.github.com/repos/arangodb/arangodb/subscribers","subscription_url":"https://api.github.com/repos/arangodb/arangodb/subscription","commits_url":"https://api.github.com/repos/arangodb/arangodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/arangodb/arangodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/arangodb/arangodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/arangodb/arangodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/arangodb/arangodb/contents/{+path}","compare_url":"https://api.github.com/repos/arangodb/arangodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arangodb/arangodb/merges","archive_url":"https://api.github.com/repos/arangodb/arangodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arangodb/arangodb/downloads","issues_url":"https://api.github.com/repos/arangodb/arangodb/issues{/number}","pulls_url":"https://api.github.com/repos/arangodb/arangodb/pulls{/number}","milestones_url":"https://api.github.com/repos/arangodb/arangodb/milestones{/number}","notifications_url":"https://api.github.com/repos/arangodb/arangodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arangodb/arangodb/labels{/name}","releases_url":"https://api.github.com/repos/arangodb/arangodb/releases{/id}","deployments_url":"https://api.github.com/repos/arangodb/arangodb/deployments","created_at":"2011-10-26T06:42:00Z","updated_at":"2018-05-21T16:04:12Z","pushed_at":"2018-05-21T19:21:52Z","git_url":"git://github.com/arangodb/arangodb.git","ssh_url":"git@github.com:arangodb/arangodb.git","clone_url":"https://github.com/arangodb/arangodb.git","svn_url":"https://github.com/arangodb/arangodb","homepage":"https://www.arangodb.com","size":824804,"stargazers_count":5685,"watchers_count":5685,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":421,"mirror_url":null,"archived":false,"open_issues_count":426,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":421,"open_issues":426,"watchers":5685,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/5405"},"html":{"href":"https://github.com/arangodb/arangodb/pull/5405"},"issue":{"href":"https://api.github.com/repos/arangodb/arangodb/issues/5405"},"comments":{"href":"https://api.github.com/repos/arangodb/arangodb/issues/5405/comments"},"review_comments":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/5405/comments"},"review_comment":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arangodb/arangodb/pulls/5405/commits"},"statuses":{"href":"https://api.github.com/repos/arangodb/arangodb/statuses/5331ba9a1f4404bbd1107ff21dd9e78af2724b49"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jsteemann"}}