{"action":"created","issue":{"url":"https://api.github.com/repos/mischasan/aho-corasick/issues/25","repository_url":"https://api.github.com/repos/mischasan/aho-corasick","labels_url":"https://api.github.com/repos/mischasan/aho-corasick/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/mischasan/aho-corasick/issues/25/comments","events_url":"https://api.github.com/repos/mischasan/aho-corasick/issues/25/events","html_url":"https://github.com/mischasan/aho-corasick/pull/25","id":313077974,"number":25,"title":"Do not re-define ACISM_STATS if already set","user":{"login":"remusao","id":1299873,"avatar_url":"https://avatars1.githubusercontent.com/u/1299873?v=4","gravatar_id":"","url":"https://api.github.com/users/remusao","html_url":"https://github.com/remusao","followers_url":"https://api.github.com/users/remusao/followers","following_url":"https://api.github.com/users/remusao/following{/other_user}","gists_url":"https://api.github.com/users/remusao/gists{/gist_id}","starred_url":"https://api.github.com/users/remusao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remusao/subscriptions","organizations_url":"https://api.github.com/users/remusao/orgs","repos_url":"https://api.github.com/users/remusao/repos","events_url":"https://api.github.com/users/remusao/events{/privacy}","received_events_url":"https://api.github.com/users/remusao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-10T20:30:21Z","updated_at":"2018-04-10T20:57:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mischasan/aho-corasick/pulls/25","html_url":"https://github.com/mischasan/aho-corasick/pull/25","diff_url":"https://github.com/mischasan/aho-corasick/pull/25.diff","patch_url":"https://github.com/mischasan/aho-corasick/pull/25.patch"},"body":"@mischasan Do you think it would make sense to allow disabling `ACISM_STATS` when we want to get maximum perf from `acism_create`?"},"comment":{"url":"https://api.github.com/repos/mischasan/aho-corasick/issues/comments/380244128","html_url":"https://github.com/mischasan/aho-corasick/pull/25#issuecomment-380244128","issue_url":"https://api.github.com/repos/mischasan/aho-corasick/issues/25","id":380244128,"user":{"login":"mischasan","id":1624369,"avatar_url":"https://avatars1.githubusercontent.com/u/1624369?v=4","gravatar_id":"","url":"https://api.github.com/users/mischasan","html_url":"https://github.com/mischasan","followers_url":"https://api.github.com/users/mischasan/followers","following_url":"https://api.github.com/users/mischasan/following{/other_user}","gists_url":"https://api.github.com/users/mischasan/gists{/gist_id}","starred_url":"https://api.github.com/users/mischasan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mischasan/subscriptions","organizations_url":"https://api.github.com/users/mischasan/orgs","repos_url":"https://api.github.com/users/mischasan/repos","events_url":"https://api.github.com/users/mischasan/events{/privacy}","received_events_url":"https://api.github.com/users/mischasan/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T20:57:32Z","updated_at":"2018-04-10T20:57:32Z","author_association":"OWNER","body":" Your patch looks like it *forces* ACISM_STATS, rather than accepting it as\na compile flag (e.g. CPPFLAGS += -DACISM_STATS)\nsince acism_create.c et al do #ifdef ACISM_STATS, not #if ACISM_STATS (ie.\n!= 0)\n\nI never noticed any overhead; HIT amounts to four instructions, most\ncertainly hitting L1 cache.\nBut the stats are more for perf nuts like me; yours to disable as you will.\nOther acism users do acism_create once, then save and share it (mmap it)\nover a long term.\n\nFinally, I'm curious: what kind of use do you have/plan for this?\nAcism is used in a big spam filter (rspamd), some antivirus software, and\nin genome pattern matching.\n\nGood luck, have fun.\n\nOn 10 April 2018 at 13:30, Rémi <notifications@github.com> wrote:\n\n> @mischasan <https://github.com/mischasan> Do you think it would make\n> sense to allow disabling ACISM_STATS when we want to get maximum perf\n> from acism_create?\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/mischasan/aho-corasick/pull/25\n> Commit Summary\n>\n>    - Do not re-define ACISM_STATS if already set\n>\n> File Changes\n>\n>    - *M* acism.h\n>    <https://github.com/mischasan/aho-corasick/pull/25/files#diff-0> (2)\n>\n> Patch Links:\n>\n>    - https://github.com/mischasan/aho-corasick/pull/25.patch\n>    - https://github.com/mischasan/aho-corasick/pull/25.diff\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/mischasan/aho-corasick/pull/25>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABjJMRI1wctoD_bzS8aCHyZPW0AOcqMKks5tnRZegaJpZM4TO8uh>\n> .\n>\n"}}
{"actor":{"display_login":"mischasan"}}