{"action":"created","issue":{"url":"https://api.github.com/repos/pcdshub/pcdsdevices/issues/157","repository_url":"https://api.github.com/repos/pcdshub/pcdsdevices","labels_url":"https://api.github.com/repos/pcdshub/pcdsdevices/issues/157/labels{/name}","comments_url":"https://api.github.com/repos/pcdshub/pcdsdevices/issues/157/comments","events_url":"https://api.github.com/repos/pcdshub/pcdsdevices/issues/157/events","html_url":"https://github.com/pcdshub/pcdsdevices/issues/157","id":299462195,"number":157,"title":"InOutPVPositioner Inheritance does produce valid `device_tuple`","user":{"login":"teddyrendahl","id":25753048,"avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false},"labels":[{"id":560785747,"url":"https://api.github.com/repos/pcdshub/pcdsdevices/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-22T18:37:26Z","updated_at":"2018-02-23T17:45:00Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Current Behavior\r\n<!--- If describing a bug, tell us what happens instead of the expected behavior -->\r\n<!--- If suggesting a change/improvement, explain the difference from current behavior -->\r\nCurrently when you create a `InOutPVPositioner` object and call `.get()` the command fails with an error message such as:\r\n```\r\n__new__() got an unexpected keyword argument 'your_signal'\r\n```\r\nOn further investigation, the traceback reveals that this is raised while trying to create a `self._device_tuple` object. If you look at what this object actually is it looks like:\r\n```\r\nYourDeviceTuple(state, _1, _2, _3, _4)\r\n```\r\nI'm guessing the MRO of these class definitions does not produce a `DeviceTuple` that includes the signals attached by the child class. This causes an issue because when `get` tries to fill the tuple with `component_names` there are no spots in the tuple for all the components. It is worth noting that `component_names` contains **all** the signals, probably just not in time for the `_device_tuple` creation. \r\n\r\n## Your Environment\r\n<!--- Include as many relevant details about the environment you experienced the bug in -->\r\n`ophyd == v1.1.0`"},"comment":{"url":"https://api.github.com/repos/pcdshub/pcdsdevices/issues/comments/368084774","html_url":"https://github.com/pcdshub/pcdsdevices/issues/157#issuecomment-368084774","issue_url":"https://api.github.com/repos/pcdshub/pcdsdevices/issues/157","id":368084774,"user":{"login":"ZLLentz","id":10647860,"avatar_url":"https://avatars3.githubusercontent.com/u/10647860?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLLentz","html_url":"https://github.com/ZLLentz","followers_url":"https://api.github.com/users/ZLLentz/followers","following_url":"https://api.github.com/users/ZLLentz/following{/other_user}","gists_url":"https://api.github.com/users/ZLLentz/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLLentz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLLentz/subscriptions","organizations_url":"https://api.github.com/users/ZLLentz/orgs","repos_url":"https://api.github.com/users/ZLLentz/repos","events_url":"https://api.github.com/users/ZLLentz/events{/privacy}","received_events_url":"https://api.github.com/users/ZLLentz/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T17:45:00Z","updated_at":"2018-02-23T17:45:00Z","author_association":"COLLABORATOR","body":"@teddyrendahl to clarify, do you mean `InOutRecordPositioner` or `InOutPVStatePositioner`?"}}
{"actor":{"display_login":"ZLLentz"}}