{"action":"closed","number":503,"pull_request":{"url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/503","id":213036403,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMDM2NDAz","html_url":"https://github.com/LBNL-UCB-STI/beam/pull/503","diff_url":"https://github.com/LBNL-UCB-STI/beam/pull/503.diff","patch_url":"https://github.com/LBNL-UCB-STI/beam/pull/503.patch","issue_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/503","number":503,"state":"closed","locked":false,"title":"Ridehail tests package - refactor","user":{"login":"carloscaldas","id":12264098,"node_id":"MDQ6VXNlcjEyMjY0MDk4","avatar_url":"https://avatars2.githubusercontent.com/u/12264098?v=4","gravatar_id":"","url":"https://api.github.com/users/carloscaldas","html_url":"https://github.com/carloscaldas","followers_url":"https://api.github.com/users/carloscaldas/followers","following_url":"https://api.github.com/users/carloscaldas/following{/other_user}","gists_url":"https://api.github.com/users/carloscaldas/gists{/gist_id}","starred_url":"https://api.github.com/users/carloscaldas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carloscaldas/subscriptions","organizations_url":"https://api.github.com/users/carloscaldas/orgs","repos_url":"https://api.github.com/users/carloscaldas/repos","events_url":"https://api.github.com/users/carloscaldas/events{/privacy}","received_events_url":"https://api.github.com/users/carloscaldas/received_events","type":"User","site_admin":false},"body":"Small refactor for:\r\n- Extraction methods: avoid redundance\r\n- Linearization of variables declaration: increase readability\r\n- Replaced magic string with constant definition\r\n- Removed commented code\r\n- Removed author\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/lbnl-ucb-sti/beam/503)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-09-04T16:33:21Z","updated_at":"2018-09-05T23:06:27Z","closed_at":"2018-09-05T23:06:27Z","merged_at":"2018-09-05T23:06:27Z","merge_commit_sha":"85d8b249dc351a74772b95d2aedd64d8d3bc1722","assignee":{"login":"carloscaldas","id":12264098,"node_id":"MDQ6VXNlcjEyMjY0MDk4","avatar_url":"https://avatars2.githubusercontent.com/u/12264098?v=4","gravatar_id":"","url":"https://api.github.com/users/carloscaldas","html_url":"https://github.com/carloscaldas","followers_url":"https://api.github.com/users/carloscaldas/followers","following_url":"https://api.github.com/users/carloscaldas/following{/other_user}","gists_url":"https://api.github.com/users/carloscaldas/gists{/gist_id}","starred_url":"https://api.github.com/users/carloscaldas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carloscaldas/subscriptions","organizations_url":"https://api.github.com/users/carloscaldas/orgs","repos_url":"https://api.github.com/users/carloscaldas/repos","events_url":"https://api.github.com/users/carloscaldas/events{/privacy}","received_events_url":"https://api.github.com/users/carloscaldas/received_events","type":"User","site_admin":false},"assignees":[{"login":"carloscaldas","id":12264098,"node_id":"MDQ6VXNlcjEyMjY0MDk4","avatar_url":"https://avatars2.githubusercontent.com/u/12264098?v=4","gravatar_id":"","url":"https://api.github.com/users/carloscaldas","html_url":"https://github.com/carloscaldas","followers_url":"https://api.github.com/users/carloscaldas/followers","following_url":"https://api.github.com/users/carloscaldas/following{/other_user}","gists_url":"https://api.github.com/users/carloscaldas/gists{/gist_id}","starred_url":"https://api.github.com/users/carloscaldas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carloscaldas/subscriptions","organizations_url":"https://api.github.com/users/carloscaldas/orgs","repos_url":"https://api.github.com/users/carloscaldas/repos","events_url":"https://api.github.com/users/carloscaldas/events{/privacy}","received_events_url":"https://api.github.com/users/carloscaldas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":991098998,"node_id":"MDU6TGFiZWw5OTEwOTg5OTg=","url":"https://api.github.com/repos/LBNL-UCB-STI/beam/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/503/commits","review_comments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/503/comments","review_comment_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/503/comments","statuses_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/statuses/d4b42ab56746c84397e80b00cdc80d6b7a084512","head":{"label":"LBNL-UCB-STI:ccaldas/#393-ridehail-refactor01-4ci","ref":"ccaldas/#393-ridehail-refactor01-4ci","sha":"d4b42ab56746c84397e80b00cdc80d6b7a084512","user":{"login":"LBNL-UCB-STI","id":26527414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTI3NDE0","avatar_url":"https://avatars1.githubusercontent.com/u/26527414?v=4","gravatar_id":"","url":"https://api.github.com/users/LBNL-UCB-STI","html_url":"https://github.com/LBNL-UCB-STI","followers_url":"https://api.github.com/users/LBNL-UCB-STI/followers","following_url":"https://api.github.com/users/LBNL-UCB-STI/following{/other_user}","gists_url":"https://api.github.com/users/LBNL-UCB-STI/gists{/gist_id}","starred_url":"https://api.github.com/users/LBNL-UCB-STI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LBNL-UCB-STI/subscriptions","organizations_url":"https://api.github.com/users/LBNL-UCB-STI/orgs","repos_url":"https://api.github.com/users/LBNL-UCB-STI/repos","events_url":"https://api.github.com/users/LBNL-UCB-STI/events{/privacy}","received_events_url":"https://api.github.com/users/LBNL-UCB-STI/received_events","type":"Organization","site_admin":false},"repo":{"id":73118824,"node_id":"MDEwOlJlcG9zaXRvcnk3MzExODgyNA==","name":"beam","full_name":"LBNL-UCB-STI/beam","owner":{"login":"LBNL-UCB-STI","id":26527414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTI3NDE0","avatar_url":"https://avatars1.githubusercontent.com/u/26527414?v=4","gravatar_id":"","url":"https://api.github.com/users/LBNL-UCB-STI","html_url":"https://github.com/LBNL-UCB-STI","followers_url":"https://api.github.com/users/LBNL-UCB-STI/followers","following_url":"https://api.github.com/users/LBNL-UCB-STI/following{/other_user}","gists_url":"https://api.github.com/users/LBNL-UCB-STI/gists{/gist_id}","starred_url":"https://api.github.com/users/LBNL-UCB-STI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LBNL-UCB-STI/subscriptions","organizations_url":"https://api.github.com/users/LBNL-UCB-STI/orgs","repos_url":"https://api.github.com/users/LBNL-UCB-STI/repos","events_url":"https://api.github.com/users/LBNL-UCB-STI/events{/privacy}","received_events_url":"https://api.github.com/users/LBNL-UCB-STI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LBNL-UCB-STI/beam","description":"The Framework for Modeling Behavior, Energy, Autonomy, and Mobility in Transportation Systems","fork":false,"url":"https://api.github.com/repos/LBNL-UCB-STI/beam","forks_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/forks","keys_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/teams","hooks_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/hooks","issue_events_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/events{/number}","events_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/events","assignees_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/assignees{/user}","branches_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/branches{/branch}","tags_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/tags","blobs_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/languages","stargazers_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/stargazers","contributors_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/contributors","subscribers_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/subscribers","subscription_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/subscription","commits_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/contents/{+path}","compare_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/merges","archive_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/downloads","issues_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues{/number}","pulls_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/labels{/name}","releases_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/releases{/id}","deployments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/deployments","created_at":"2016-11-07T20:38:29Z","updated_at":"2018-09-05T19:52:37Z","pushed_at":"2018-09-05T23:06:27Z","git_url":"git://github.com/LBNL-UCB-STI/beam.git","ssh_url":"git@github.com:LBNL-UCB-STI/beam.git","clone_url":"https://github.com/LBNL-UCB-STI/beam.git","svn_url":"https://github.com/LBNL-UCB-STI/beam","homepage":null,"size":89918,"stargazers_count":18,"watchers_count":18,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":10,"open_issues":127,"watchers":18,"default_branch":"master"}},"base":{"label":"LBNL-UCB-STI:master","ref":"master","sha":"9d60da81ae83c716f3b5633a896d5b4065e6baee","user":{"login":"LBNL-UCB-STI","id":26527414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTI3NDE0","avatar_url":"https://avatars1.githubusercontent.com/u/26527414?v=4","gravatar_id":"","url":"https://api.github.com/users/LBNL-UCB-STI","html_url":"https://github.com/LBNL-UCB-STI","followers_url":"https://api.github.com/users/LBNL-UCB-STI/followers","following_url":"https://api.github.com/users/LBNL-UCB-STI/following{/other_user}","gists_url":"https://api.github.com/users/LBNL-UCB-STI/gists{/gist_id}","starred_url":"https://api.github.com/users/LBNL-UCB-STI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LBNL-UCB-STI/subscriptions","organizations_url":"https://api.github.com/users/LBNL-UCB-STI/orgs","repos_url":"https://api.github.com/users/LBNL-UCB-STI/repos","events_url":"https://api.github.com/users/LBNL-UCB-STI/events{/privacy}","received_events_url":"https://api.github.com/users/LBNL-UCB-STI/received_events","type":"Organization","site_admin":false},"repo":{"id":73118824,"node_id":"MDEwOlJlcG9zaXRvcnk3MzExODgyNA==","name":"beam","full_name":"LBNL-UCB-STI/beam","owner":{"login":"LBNL-UCB-STI","id":26527414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTI3NDE0","avatar_url":"https://avatars1.githubusercontent.com/u/26527414?v=4","gravatar_id":"","url":"https://api.github.com/users/LBNL-UCB-STI","html_url":"https://github.com/LBNL-UCB-STI","followers_url":"https://api.github.com/users/LBNL-UCB-STI/followers","following_url":"https://api.github.com/users/LBNL-UCB-STI/following{/other_user}","gists_url":"https://api.github.com/users/LBNL-UCB-STI/gists{/gist_id}","starred_url":"https://api.github.com/users/LBNL-UCB-STI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LBNL-UCB-STI/subscriptions","organizations_url":"https://api.github.com/users/LBNL-UCB-STI/orgs","repos_url":"https://api.github.com/users/LBNL-UCB-STI/repos","events_url":"https://api.github.com/users/LBNL-UCB-STI/events{/privacy}","received_events_url":"https://api.github.com/users/LBNL-UCB-STI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LBNL-UCB-STI/beam","description":"The Framework for Modeling Behavior, Energy, Autonomy, and Mobility in Transportation Systems","fork":false,"url":"https://api.github.com/repos/LBNL-UCB-STI/beam","forks_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/forks","keys_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/teams","hooks_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/hooks","issue_events_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/events{/number}","events_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/events","assignees_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/assignees{/user}","branches_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/branches{/branch}","tags_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/tags","blobs_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/languages","stargazers_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/stargazers","contributors_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/contributors","subscribers_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/subscribers","subscription_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/subscription","commits_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/contents/{+path}","compare_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/merges","archive_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/downloads","issues_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues{/number}","pulls_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/labels{/name}","releases_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/releases{/id}","deployments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/deployments","created_at":"2016-11-07T20:38:29Z","updated_at":"2018-09-05T19:52:37Z","pushed_at":"2018-09-05T23:06:27Z","git_url":"git://github.com/LBNL-UCB-STI/beam.git","ssh_url":"git@github.com:LBNL-UCB-STI/beam.git","clone_url":"https://github.com/LBNL-UCB-STI/beam.git","svn_url":"https://github.com/LBNL-UCB-STI/beam","homepage":null,"size":89918,"stargazers_count":18,"watchers_count":18,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":10,"open_issues":127,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/503"},"html":{"href":"https://github.com/LBNL-UCB-STI/beam/pull/503"},"issue":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/503"},"comments":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/503/comments"},"review_comments":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/503/comments"},"review_comment":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/503/commits"},"statuses":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/statuses/d4b42ab56746c84397e80b00cdc80d6b7a084512"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wrashid","id":13569531,"node_id":"MDQ6VXNlcjEzNTY5NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/13569531?v=4","gravatar_id":"","url":"https://api.github.com/users/wrashid","html_url":"https://github.com/wrashid","followers_url":"https://api.github.com/users/wrashid/followers","following_url":"https://api.github.com/users/wrashid/following{/other_user}","gists_url":"https://api.github.com/users/wrashid/gists{/gist_id}","starred_url":"https://api.github.com/users/wrashid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrashid/subscriptions","organizations_url":"https://api.github.com/users/wrashid/orgs","repos_url":"https://api.github.com/users/wrashid/repos","events_url":"https://api.github.com/users/wrashid/events{/privacy}","received_events_url":"https://api.github.com/users/wrashid/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":15,"additions":163,"deletions":156,"changed_files":16}}
{"actor":{"display_login":"wrashid"}}