{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/19586","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/19586/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19586/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/19586/events","html_url":"https://github.com/nodejs/node/issues/19586","id":308319000,"number":19586,"title":"Signal handlers do not persist","user":{"login":"gireeshpunathil","id":6447530,"avatar_url":"https://avatars2.githubusercontent.com/u/6447530?v=4","gravatar_id":"","url":"https://api.github.com/users/gireeshpunathil","html_url":"https://github.com/gireeshpunathil","followers_url":"https://api.github.com/users/gireeshpunathil/followers","following_url":"https://api.github.com/users/gireeshpunathil/following{/other_user}","gists_url":"https://api.github.com/users/gireeshpunathil/gists{/gist_id}","starred_url":"https://api.github.com/users/gireeshpunathil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gireeshpunathil/subscriptions","organizations_url":"https://api.github.com/users/gireeshpunathil/orgs","repos_url":"https://api.github.com/users/gireeshpunathil/repos","events_url":"https://api.github.com/users/gireeshpunathil/events{/privacy}","received_events_url":"https://api.github.com/users/gireeshpunathil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-25T03:29:13Z","updated_at":"2018-03-25T10:09:29Z","closed_at":null,"author_association":"MEMBER","body":"<!--\r\nThank you for reporting an issue.\r\n\r\nThis issue tracker is for bugs and issues found within Node.js core.\r\nIf you require more general support please file an issue on our help\r\nrepo. https://github.com/nodejs/help\r\n\r\n\r\nPlease fill in as much of the template below as you're able.\r\n\r\nVersion: output of `node -v`\r\nPlatform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)\r\nSubsystem: if known, please specify affected core module name\r\n\r\nIf possible, please provide code that demonstrates the problem, keeping it as\r\nsimple and free of external dependencies as you are able.\r\n-->\r\n\r\n* **Version**: v9.2.0, v8.9.0?\r\n* **Platform**: MacOS (may be all)\r\n* **Subsystem**: process\r\n\r\n<!-- Enter your issue details below this comment. -->\r\n\r\nWith 941c65bba28ed22c09cb262d04512fc7fecab189 , the signal handlers don't block the uv loop, if they are the only handles present. End result is that signal handlers no longer work.\r\n\r\nSteps to reproduce:\r\n#cat /1180.js \r\n```js\r\nprocess.on('SIGTERM', () => console.log('s'))\r\nprocess.kill(process.pid)\r\n```\r\nv9.1.0:\r\n```\r\n#node 1180.js \r\ns\r\n#\r\n```\r\nv9.2.0:\r\n```\r\n#node 1180.js\r\n#\r\n```\r\n\r\nOriginally reported in https://github.com/nodejs/help/issues/1180\r\n\r\n/cc @addaleax "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/375959031","html_url":"https://github.com/nodejs/node/issues/19586#issuecomment-375959031","issue_url":"https://api.github.com/repos/nodejs/node/issues/19586","id":375959031,"user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars0.githubusercontent.com/u/275871?v=4","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"created_at":"2018-03-25T10:09:29Z","updated_at":"2018-03-25T10:09:29Z","author_association":"MEMBER","body":"How did you conclude it was 941c65b?  That commit doesn't seem like a plausible candidate because it doesn't touch anything related to `uv_signal_init()`."}}
{"actor":{"display_login":"bnoordhuis"}}