{"action":"created","comment":{"url":"https://api.github.com/repos/stripe/stripe-ios/pulls/comments/201161452","pull_request_review_id":135606495,"id":201161452,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTE2MTQ1Mg==","diff_hunk":"@@ -0,0 +1,66 @@\n+//\n+//  STPPaymentIntentParamsTest.m\n+//  StripeiOS Tests\n+//\n+//  Created by Daniel Jackson on 7/5/18.\n+//  Copyright © 2018 Stripe, Inc. All rights reserved.\n+//\n+\n+#import <XCTest/XCTest.h>\n+#import \"STPPaymentIntentParams.h\"\n+\n+@interface STPPaymentIntentParamsTest : XCTestCase\n+\n+@end\n+\n+@implementation STPPaymentIntentParamsTest\n+\n+- (void)testInit {\n+    for (STPPaymentIntentParams *params in @[[[STPPaymentIntentParams alloc] initWithClientSecret:@\"secret\"],\n+                                             [[STPPaymentIntentParams alloc] init],\n+                                             [STPPaymentIntentParams new],","path":"Tests/Tests/STPPaymentIntentParamsTest.m","position":21,"original_position":21,"commit_id":"42b009ff1d78ec5776c57a33f400ce91d63cbd9f","original_commit_id":"42b009ff1d78ec5776c57a33f400ce91d63cbd9f","user":{"login":"csabol-stripe","id":36750494,"node_id":"MDQ6VXNlcjM2NzUwNDk0","avatar_url":"https://avatars2.githubusercontent.com/u/36750494?v=4","gravatar_id":"","url":"https://api.github.com/users/csabol-stripe","html_url":"https://github.com/csabol-stripe","followers_url":"https://api.github.com/users/csabol-stripe/followers","following_url":"https://api.github.com/users/csabol-stripe/following{/other_user}","gists_url":"https://api.github.com/users/csabol-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/csabol-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csabol-stripe/subscriptions","organizations_url":"https://api.github.com/users/csabol-stripe/orgs","repos_url":"https://api.github.com/users/csabol-stripe/repos","events_url":"https://api.github.com/users/csabol-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/csabol-stripe/received_events","type":"User","site_admin":false},"body":"no personal preference but mixing `alloc] init]` and `new]` right next to each other reads a bit weird :P","created_at":"2018-07-09T22:03:33Z","updated_at":"2018-07-09T22:05:12Z","html_url":"https://github.com/stripe/stripe-ios/pull/986#discussion_r201161452","pull_request_url":"https://api.github.com/repos/stripe/stripe-ios/pulls/986","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stripe/stripe-ios/pulls/comments/201161452"},"html":{"href":"https://github.com/stripe/stripe-ios/pull/986#discussion_r201161452"},"pull_request":{"href":"https://api.github.com/repos/stripe/stripe-ios/pulls/986"}}},"pull_request":{"url":"https://api.github.com/repos/stripe/stripe-ios/pulls/986","id":199622562,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjIyNTYy","html_url":"https://github.com/stripe/stripe-ios/pull/986","diff_url":"https://github.com/stripe/stripe-ios/pull/986.diff","patch_url":"https://github.com/stripe/stripe-ios/pull/986.patch","issue_url":"https://api.github.com/repos/stripe/stripe-ios/issues/986","number":986,"state":"open","locked":false,"title":"Add method to API that takes STPPaymentIntentParams and confirms them","user":{"login":"danj-stripe","id":30532866,"node_id":"MDQ6VXNlcjMwNTMyODY2","avatar_url":"https://avatars2.githubusercontent.com/u/30532866?v=4","gravatar_id":"","url":"https://api.github.com/users/danj-stripe","html_url":"https://github.com/danj-stripe","followers_url":"https://api.github.com/users/danj-stripe/followers","following_url":"https://api.github.com/users/danj-stripe/following{/other_user}","gists_url":"https://api.github.com/users/danj-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/danj-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danj-stripe/subscriptions","organizations_url":"https://api.github.com/users/danj-stripe/orgs","repos_url":"https://api.github.com/users/danj-stripe/repos","events_url":"https://api.github.com/users/danj-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/danj-stripe/received_events","type":"User","site_admin":false},"body":"## Summary\nAdding support for `/v1/payment_intents/:id/confirm`\n\nThis method takes a STPPaymentIntentParams object, which may have STPSourceParams or a\nSource id, among other fields.\n\n## Motivation\nIOS-792\n\n## Testing\nAdded tests. This is part of a series of PRs, starting with #985 (which this relies on),\nand this was also tested in the sample app.","created_at":"2018-07-06T01:16:48Z","updated_at":"2018-07-09T22:05:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"454f900f4998811b4ebeb65776fda215a3567eb1","assignee":{"login":"csabol-stripe","id":36750494,"node_id":"MDQ6VXNlcjM2NzUwNDk0","avatar_url":"https://avatars2.githubusercontent.com/u/36750494?v=4","gravatar_id":"","url":"https://api.github.com/users/csabol-stripe","html_url":"https://github.com/csabol-stripe","followers_url":"https://api.github.com/users/csabol-stripe/followers","following_url":"https://api.github.com/users/csabol-stripe/following{/other_user}","gists_url":"https://api.github.com/users/csabol-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/csabol-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csabol-stripe/subscriptions","organizations_url":"https://api.github.com/users/csabol-stripe/orgs","repos_url":"https://api.github.com/users/csabol-stripe/repos","events_url":"https://api.github.com/users/csabol-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/csabol-stripe/received_events","type":"User","site_admin":false},"assignees":[{"login":"csabol-stripe","id":36750494,"node_id":"MDQ6VXNlcjM2NzUwNDk0","avatar_url":"https://avatars2.githubusercontent.com/u/36750494?v=4","gravatar_id":"","url":"https://api.github.com/users/csabol-stripe","html_url":"https://github.com/csabol-stripe","followers_url":"https://api.github.com/users/csabol-stripe/followers","following_url":"https://api.github.com/users/csabol-stripe/following{/other_user}","gists_url":"https://api.github.com/users/csabol-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/csabol-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csabol-stripe/subscriptions","organizations_url":"https://api.github.com/users/csabol-stripe/orgs","repos_url":"https://api.github.com/users/csabol-stripe/repos","events_url":"https://api.github.com/users/csabol-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/csabol-stripe/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stripe/stripe-ios/pulls/986/commits","review_comments_url":"https://api.github.com/repos/stripe/stripe-ios/pulls/986/comments","review_comment_url":"https://api.github.com/repos/stripe/stripe-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stripe/stripe-ios/issues/986/comments","statuses_url":"https://api.github.com/repos/stripe/stripe-ios/statuses/42b009ff1d78ec5776c57a33f400ce91d63cbd9f","head":{"label":"stripe:danj/feature/confirm-paymentintent","ref":"danj/feature/confirm-paymentintent","sha":"42b009ff1d78ec5776c57a33f400ce91d63cbd9f","user":{"login":"stripe","id":856813,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NjgxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/856813?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"repo":{"id":6656911,"node_id":"MDEwOlJlcG9zaXRvcnk2NjU2OTEx","name":"stripe-ios","full_name":"stripe/stripe-ios","owner":{"login":"stripe","id":856813,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NjgxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/856813?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stripe/stripe-ios","description":"Stripe iOS SDK    ","fork":false,"url":"https://api.github.com/repos/stripe/stripe-ios","forks_url":"https://api.github.com/repos/stripe/stripe-ios/forks","keys_url":"https://api.github.com/repos/stripe/stripe-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stripe/stripe-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stripe/stripe-ios/teams","hooks_url":"https://api.github.com/repos/stripe/stripe-ios/hooks","issue_events_url":"https://api.github.com/repos/stripe/stripe-ios/issues/events{/number}","events_url":"https://api.github.com/repos/stripe/stripe-ios/events","assignees_url":"https://api.github.com/repos/stripe/stripe-ios/assignees{/user}","branches_url":"https://api.github.com/repos/stripe/stripe-ios/branches{/branch}","tags_url":"https://api.github.com/repos/stripe/stripe-ios/tags","blobs_url":"https://api.github.com/repos/stripe/stripe-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stripe/stripe-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stripe/stripe-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/stripe/stripe-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stripe/stripe-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/stripe/stripe-ios/languages","stargazers_url":"https://api.github.com/repos/stripe/stripe-ios/stargazers","contributors_url":"https://api.github.com/repos/stripe/stripe-ios/contributors","subscribers_url":"https://api.github.com/repos/stripe/stripe-ios/subscribers","subscription_url":"https://api.github.com/repos/stripe/stripe-ios/subscription","commits_url":"https://api.github.com/repos/stripe/stripe-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/stripe/stripe-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/stripe/stripe-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/stripe/stripe-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/stripe/stripe-ios/contents/{+path}","compare_url":"https://api.github.com/repos/stripe/stripe-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stripe/stripe-ios/merges","archive_url":"https://api.github.com/repos/stripe/stripe-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stripe/stripe-ios/downloads","issues_url":"https://api.github.com/repos/stripe/stripe-ios/issues{/number}","pulls_url":"https://api.github.com/repos/stripe/stripe-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/stripe/stripe-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/stripe/stripe-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stripe/stripe-ios/labels{/name}","releases_url":"https://api.github.com/repos/stripe/stripe-ios/releases{/id}","deployments_url":"https://api.github.com/repos/stripe/stripe-ios/deployments","created_at":"2012-11-12T16:55:08Z","updated_at":"2018-07-09T17:45:26Z","pushed_at":"2018-07-09T17:45:27Z","git_url":"git://github.com/stripe/stripe-ios.git","ssh_url":"git@github.com:stripe/stripe-ios.git","clone_url":"https://github.com/stripe/stripe-ios.git","svn_url":"https://github.com/stripe/stripe-ios","homepage":"https://stripe.com","size":102410,"stargazers_count":963,"watchers_count":963,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":445,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":445,"open_issues":11,"watchers":963,"default_branch":"master"}},"base":{"label":"stripe:danj/feature/retrieve-paymentintent","ref":"danj/feature/retrieve-paymentintent","sha":"de5ce3c77314c4a303365b7e24f8cd6853189d2c","user":{"login":"stripe","id":856813,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NjgxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/856813?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"repo":{"id":6656911,"node_id":"MDEwOlJlcG9zaXRvcnk2NjU2OTEx","name":"stripe-ios","full_name":"stripe/stripe-ios","owner":{"login":"stripe","id":856813,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NjgxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/856813?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stripe/stripe-ios","description":"Stripe iOS SDK    ","fork":false,"url":"https://api.github.com/repos/stripe/stripe-ios","forks_url":"https://api.github.com/repos/stripe/stripe-ios/forks","keys_url":"https://api.github.com/repos/stripe/stripe-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stripe/stripe-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stripe/stripe-ios/teams","hooks_url":"https://api.github.com/repos/stripe/stripe-ios/hooks","issue_events_url":"https://api.github.com/repos/stripe/stripe-ios/issues/events{/number}","events_url":"https://api.github.com/repos/stripe/stripe-ios/events","assignees_url":"https://api.github.com/repos/stripe/stripe-ios/assignees{/user}","branches_url":"https://api.github.com/repos/stripe/stripe-ios/branches{/branch}","tags_url":"https://api.github.com/repos/stripe/stripe-ios/tags","blobs_url":"https://api.github.com/repos/stripe/stripe-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stripe/stripe-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stripe/stripe-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/stripe/stripe-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stripe/stripe-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/stripe/stripe-ios/languages","stargazers_url":"https://api.github.com/repos/stripe/stripe-ios/stargazers","contributors_url":"https://api.github.com/repos/stripe/stripe-ios/contributors","subscribers_url":"https://api.github.com/repos/stripe/stripe-ios/subscribers","subscription_url":"https://api.github.com/repos/stripe/stripe-ios/subscription","commits_url":"https://api.github.com/repos/stripe/stripe-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/stripe/stripe-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/stripe/stripe-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/stripe/stripe-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/stripe/stripe-ios/contents/{+path}","compare_url":"https://api.github.com/repos/stripe/stripe-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stripe/stripe-ios/merges","archive_url":"https://api.github.com/repos/stripe/stripe-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stripe/stripe-ios/downloads","issues_url":"https://api.github.com/repos/stripe/stripe-ios/issues{/number}","pulls_url":"https://api.github.com/repos/stripe/stripe-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/stripe/stripe-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/stripe/stripe-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stripe/stripe-ios/labels{/name}","releases_url":"https://api.github.com/repos/stripe/stripe-ios/releases{/id}","deployments_url":"https://api.github.com/repos/stripe/stripe-ios/deployments","created_at":"2012-11-12T16:55:08Z","updated_at":"2018-07-09T17:45:26Z","pushed_at":"2018-07-09T17:45:27Z","git_url":"git://github.com/stripe/stripe-ios.git","ssh_url":"git@github.com:stripe/stripe-ios.git","clone_url":"https://github.com/stripe/stripe-ios.git","svn_url":"https://github.com/stripe/stripe-ios","homepage":"https://stripe.com","size":102410,"stargazers_count":963,"watchers_count":963,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":445,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":445,"open_issues":11,"watchers":963,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stripe/stripe-ios/pulls/986"},"html":{"href":"https://github.com/stripe/stripe-ios/pull/986"},"issue":{"href":"https://api.github.com/repos/stripe/stripe-ios/issues/986"},"comments":{"href":"https://api.github.com/repos/stripe/stripe-ios/issues/986/comments"},"review_comments":{"href":"https://api.github.com/repos/stripe/stripe-ios/pulls/986/comments"},"review_comment":{"href":"https://api.github.com/repos/stripe/stripe-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stripe/stripe-ios/pulls/986/commits"},"statuses":{"href":"https://api.github.com/repos/stripe/stripe-ios/statuses/42b009ff1d78ec5776c57a33f400ce91d63cbd9f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"csabol-stripe"}}