{"action":"created","issue":{"url":"https://api.github.com/repos/spatie/laravel-permission/issues/732","repository_url":"https://api.github.com/repos/spatie/laravel-permission","labels_url":"https://api.github.com/repos/spatie/laravel-permission/issues/732/labels{/name}","comments_url":"https://api.github.com/repos/spatie/laravel-permission/issues/732/comments","events_url":"https://api.github.com/repos/spatie/laravel-permission/issues/732/events","html_url":"https://github.com/spatie/laravel-permission/pull/732","id":320890338,"number":732,"title":"Changed the caching strategy, to improve lookup speed. ","user":{"login":"klincheg","id":1610936,"avatar_url":"https://avatars2.githubusercontent.com/u/1610936?v=4","gravatar_id":"","url":"https://api.github.com/users/klincheg","html_url":"https://github.com/klincheg","followers_url":"https://api.github.com/users/klincheg/followers","following_url":"https://api.github.com/users/klincheg/following{/other_user}","gists_url":"https://api.github.com/users/klincheg/gists{/gist_id}","starred_url":"https://api.github.com/users/klincheg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klincheg/subscriptions","organizations_url":"https://api.github.com/users/klincheg/orgs","repos_url":"https://api.github.com/users/klincheg/repos","events_url":"https://api.github.com/users/klincheg/events{/privacy}","received_events_url":"https://api.github.com/users/klincheg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-07T17:37:44Z","updated_at":"2018-05-13T23:13:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/spatie/laravel-permission/pulls/732","html_url":"https://github.com/spatie/laravel-permission/pull/732","diff_url":"https://github.com/spatie/laravel-permission/pull/732.diff","patch_url":"https://github.com/spatie/laravel-permission/pull/732.patch"},"body":"changed getPermissions method"},"comment":{"url":"https://api.github.com/repos/spatie/laravel-permission/issues/comments/388663008","html_url":"https://github.com/spatie/laravel-permission/pull/732#issuecomment-388663008","issue_url":"https://api.github.com/repos/spatie/laravel-permission/issues/732","id":388663008,"user":{"login":"drbyte","id":404472,"avatar_url":"https://avatars0.githubusercontent.com/u/404472?v=4","gravatar_id":"","url":"https://api.github.com/users/drbyte","html_url":"https://github.com/drbyte","followers_url":"https://api.github.com/users/drbyte/followers","following_url":"https://api.github.com/users/drbyte/following{/other_user}","gists_url":"https://api.github.com/users/drbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/drbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbyte/subscriptions","organizations_url":"https://api.github.com/users/drbyte/orgs","repos_url":"https://api.github.com/users/drbyte/repos","events_url":"https://api.github.com/users/drbyte/events{/privacy}","received_events_url":"https://api.github.com/users/drbyte/received_events","type":"User","site_admin":false},"created_at":"2018-05-13T23:13:48Z","updated_at":"2018-05-13T23:13:48Z","author_association":"COLLABORATOR","body":"@drbyte wrote:\r\n> it appears that your code is reversing the performance improvements added in #710. Please revert your changes to those parts of the Permissions model.\r\n\r\n@klincheg replied:\r\n> I can't revert it because in my PR code selects only needed data. In previous version it was \"select all and after that filter\" But in old version i have a time problem if there are more than 150 permissions in the table (old code in some cases worked more than 2-3 secs, and after my changes time was reduced to 300-500ms)\r\n\r\nThere were benchmark measurements done in #710 and #550 both for exposing performance problems and demonstrating the improvements realized by the changes.\r\nI'm not interested in undoing the improvements made by #710 without substantial proof that they are problematic. In my experience they were positive improvements.\r\n\r\nAre you saying that the changes in #710 actually made performance worse?\r\nIf so, then let's create a test application to demonstrate the problem, showing before-and-after speed statistics."}}
{"actor":{"display_login":"drbyte"}}