{"action":"created","issue":{"url":"https://api.github.com/repos/rails/webpacker/issues/1450","repository_url":"https://api.github.com/repos/rails/webpacker","labels_url":"https://api.github.com/repos/rails/webpacker/issues/1450/labels{/name}","comments_url":"https://api.github.com/repos/rails/webpacker/issues/1450/comments","events_url":"https://api.github.com/repos/rails/webpacker/issues/1450/events","html_url":"https://github.com/rails/webpacker/pull/1450","id":317789234,"number":1450,"title":"#1449 Remove node_modules_path","user":{"login":"tmaier","id":350038,"avatar_url":"https://avatars0.githubusercontent.com/u/350038?v=4","gravatar_id":"","url":"https://api.github.com/users/tmaier","html_url":"https://github.com/tmaier","followers_url":"https://api.github.com/users/tmaier/followers","following_url":"https://api.github.com/users/tmaier/following{/other_user}","gists_url":"https://api.github.com/users/tmaier/gists{/gist_id}","starred_url":"https://api.github.com/users/tmaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmaier/subscriptions","organizations_url":"https://api.github.com/users/tmaier/orgs","repos_url":"https://api.github.com/users/tmaier/repos","events_url":"https://api.github.com/users/tmaier/events{/privacy}","received_events_url":"https://api.github.com/users/tmaier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-25T20:51:41Z","updated_at":"2018-04-25T23:39:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rails/webpacker/pulls/1450","html_url":"https://github.com/rails/webpacker/pull/1450","diff_url":"https://github.com/rails/webpacker/pull/1450.diff","patch_url":"https://github.com/rails/webpacker/pull/1450.patch"},"body":"Fixes #1449\r\n\r\nSuggested CHANGELOG entry:\r\n\r\n```markdown\r\n## Changed\r\n  - Webpacker does not assume anymore the location of `node_modules` [1449]\r\n\r\n## Removed\r\n  - `NODE_PATH` env variable is not set anymore when Webpacker executes `webpack` or `webpack-dev-server` [1449]\r\n```"},"comment":{"url":"https://api.github.com/repos/rails/webpacker/issues/comments/384467007","html_url":"https://github.com/rails/webpacker/pull/1450#issuecomment-384467007","issue_url":"https://api.github.com/repos/rails/webpacker/issues/1450","id":384467007,"user":{"login":"tmaier","id":350038,"avatar_url":"https://avatars0.githubusercontent.com/u/350038?v=4","gravatar_id":"","url":"https://api.github.com/users/tmaier","html_url":"https://github.com/tmaier","followers_url":"https://api.github.com/users/tmaier/followers","following_url":"https://api.github.com/users/tmaier/following{/other_user}","gists_url":"https://api.github.com/users/tmaier/gists{/gist_id}","starred_url":"https://api.github.com/users/tmaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmaier/subscriptions","organizations_url":"https://api.github.com/users/tmaier/orgs","repos_url":"https://api.github.com/users/tmaier/repos","events_url":"https://api.github.com/users/tmaier/events{/privacy}","received_events_url":"https://api.github.com/users/tmaier/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T23:39:33Z","updated_at":"2018-04-25T23:39:33Z","author_association":"NONE","body":"The reason for the failing test run has been identified in #1451.\r\n\r\nI ran the tests manually on Ruby 2.4.4 (Mac):\r\n```text\r\n$ yarn lint\r\nyarn run v1.6.0\r\n$ eslint {package,lib}/\r\n✨  Done in 2.23s.\r\n```\r\n```text\r\n$ yarn test\r\nyarn run v1.6.0\r\n$ jest\r\n PASS  package/config_types/__tests__/config_list.js\r\n PASS  package/config_types/__tests__/config_object.js\r\n PASS  package/__tests__/dev_server.js\r\n PASS  package/__tests__/env.js\r\n PASS  package/__tests__/config.js\r\n PASS  package/utils/__tests__/deep_merge.js\r\n PASS  package/utils/__tests__/deep_assign.js\r\n PASS  package/utils/__tests__/objectify.js\r\n PASS  package/utils/__tests__/get_style_rule.js\r\n PASS  package/environments/__tests__/base.js\r\n PASS  package/__tests__/development.js\r\n PASS  package/__tests__/test.js\r\n PASS  package/__tests__/production.js\r\n PASS  package/__tests__/staging.js\r\n\r\nTest Suites: 14 passed, 14 total\r\nTests:       43 passed, 43 total\r\nSnapshots:   0 total\r\nTime:        4.17s\r\nRan all test suites.\r\n✨  Done in 4.87s.\r\n```\r\n```text\r\n$ bundle exec rubocop\r\nInspecting 56 files\r\n........................................................\r\n\r\n56 files inspected, no offenses detected\r\n```\r\n```text\r\n$ bundle exec rake test\r\n/Users/tmaier/.rbenv/versions/2.4.4/bin/ruby -w -I\"lib:test:lib\" -I\"/Users/tmaier/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/gems/rake-12.3.1/lib\" \"/Users/tmaier/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/gems/rake-12.3.1/lib/rake/rake_test_loader.rb\" \"test/command_test.rb\" \"test/compiler_test.rb\" \"test/configuration_test.rb\" \"test/dev_server_test.rb\" \"test/env_test.rb\" \"test/helper_test.rb\" \"test/manifest_test.rb\" \"test/rake_tasks_test.rb\"\r\nRun options: --seed 16864\r\n\r\n# Running:\r\n\r\n........................................\r\n\r\nFinished in 1.500778s, 26.6528 runs/s, 51.9730 assertions/s.\r\n40 runs, 78 assertions, 0 failures, 0 errors, 0 skips\r\n```"}}
{"actor":{"display_login":"tmaier"}}