{"action":"created","issue":{"url":"https://api.github.com/repos/transloadit/uppy/issues/828","repository_url":"https://api.github.com/repos/transloadit/uppy","labels_url":"https://api.github.com/repos/transloadit/uppy/issues/828/labels{/name}","comments_url":"https://api.github.com/repos/transloadit/uppy/issues/828/comments","events_url":"https://api.github.com/repos/transloadit/uppy/issues/828/events","html_url":"https://github.com/transloadit/uppy/pull/828","id":323115049,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4MDQ5Nzk3","number":828,"title":"Fix auth when redirect URL contains hash","user":{"login":"vially","id":433598,"node_id":"MDQ6VXNlcjQzMzU5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/433598?v=4","gravatar_id":"","url":"https://api.github.com/users/vially","html_url":"https://github.com/vially","followers_url":"https://api.github.com/users/vially/followers","following_url":"https://api.github.com/users/vially/following{/other_user}","gists_url":"https://api.github.com/users/vially/gists{/gist_id}","starred_url":"https://api.github.com/users/vially/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vially/subscriptions","organizations_url":"https://api.github.com/users/vially/orgs","repos_url":"https://api.github.com/users/vially/repos","events_url":"https://api.github.com/users/vially/events{/privacy}","received_events_url":"https://api.github.com/users/vially/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-15T08:27:05Z","updated_at":"2018-06-01T06:54:35Z","closed_at":"2018-05-31T23:49:24Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/transloadit/uppy/pulls/828","html_url":"https://github.com/transloadit/uppy/pull/828","diff_url":"https://github.com/transloadit/uppy/pull/828.diff","patch_url":"https://github.com/transloadit/uppy/pull/828.patch"},"body":"If the source page URL (the page showing the uppy dialog) contains a hash (e.g.: `http://localhost/#/foo/bar`) the authentication did not complete properly.\r\n\r\nThis happened because the previous logic in `checkAuth` did not handle this case properly. \r\n\r\nMore specifically, in the example above, both `authWindowUrl` and `redirect` URL will be: `http://localhost/#/foo/bar?id=12345`. But the previous logic only compared the part before the hash from `authWindowUrl` with the full `redirect` URL (`http://localhost/` != `http://localhost/#/foo/bar?id=12345`).\r\n\r\nThis PR attempts to fix that."},"comment":{"url":"https://api.github.com/repos/transloadit/uppy/issues/comments/393781085","html_url":"https://github.com/transloadit/uppy/pull/828#issuecomment-393781085","issue_url":"https://api.github.com/repos/transloadit/uppy/issues/828","id":393781085,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Mzc4MTA4NQ==","user":{"login":"vially","id":433598,"node_id":"MDQ6VXNlcjQzMzU5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/433598?v=4","gravatar_id":"","url":"https://api.github.com/users/vially","html_url":"https://github.com/vially","followers_url":"https://api.github.com/users/vially/followers","following_url":"https://api.github.com/users/vially/following{/other_user}","gists_url":"https://api.github.com/users/vially/gists{/gist_id}","starred_url":"https://api.github.com/users/vially/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vially/subscriptions","organizations_url":"https://api.github.com/users/vially/orgs","repos_url":"https://api.github.com/users/vially/repos","events_url":"https://api.github.com/users/vially/events{/privacy}","received_events_url":"https://api.github.com/users/vially/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T06:54:35Z","updated_at":"2018-06-01T06:54:35Z","author_association":"CONTRIBUTOR","body":"Great, thanks!"}}
{"actor":{"display_login":"vially"}}