{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/203944491","pull_request_review_id":138936177,"id":203944491,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzk0NDQ5MQ==","diff_hunk":"@@ -1898,19 +1898,43 @@ def test_solve_expo():\n \n \n # logarithmic tests\n-@XFAIL\n def test_logarithmic():\n     assert solveset_real(log(x - 3) + log(x + 3), x) == FiniteSet(\n-        sqrt(10))\n+        -sqrt(10), sqrt(10))","path":"sympy/solvers/tests/test_solveset.py","position":17,"original_position":17,"commit_id":"afc59513e9d0b427bce67a46885c69aa42521204","original_commit_id":"afc59513e9d0b427bce67a46885c69aa42521204","user":{"login":"Yathartha22","id":14955840,"node_id":"MDQ6VXNlcjE0OTU1ODQw","avatar_url":"https://avatars1.githubusercontent.com/u/14955840?v=4","gravatar_id":"","url":"https://api.github.com/users/Yathartha22","html_url":"https://github.com/Yathartha22","followers_url":"https://api.github.com/users/Yathartha22/followers","following_url":"https://api.github.com/users/Yathartha22/following{/other_user}","gists_url":"https://api.github.com/users/Yathartha22/gists{/gist_id}","starred_url":"https://api.github.com/users/Yathartha22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yathartha22/subscriptions","organizations_url":"https://api.github.com/users/Yathartha22/orgs","repos_url":"https://api.github.com/users/Yathartha22/repos","events_url":"https://api.github.com/users/Yathartha22/events{/privacy}","received_events_url":"https://api.github.com/users/Yathartha22/received_events","type":"User","site_admin":false},"body":"> What about log(1-x) - log(3*x) - log(4*x + 1) = 0 for which x = -1/2 is a solution which makes only two args 0?\r\n\r\n[Wolfram alpha](http://www.wolframalpha.com/input/?i=solve(log(1-x)+-+log(3*x)+-+log(4*x+%2B+1),+x)) gives `1/6` as the only solution to this equation. It rules out `-1/2` maybe because `-1/2` makes `log(3*x)` and `log(4*x + 1)` negative.\r\n\r\nTo see we are on the same page what should be followed while removing bad solutions.\r\n\r\n- Any of the solution makes any of the log arg negative should not be included, or\r\n\r\n- Substituting each solution to the original equation and see it evaluates to `0`.\r\n\r\nI think wolfram alpha follows the first criteria, as evident from these two equations:\r\n[log(3*x) - log(1 - x) - log(4*x + 1)](http://www.wolframalpha.com/input/?i=solve(log(3*x)+-+log(1+-+x)+-+log(4*x+%2B+1),+x)) and [log(1-x) - log(3*x) - log(4*x + 1)](http://www.wolframalpha.com/input/?i=solve(log(1-x)+-+log(3*x)+-+log(4*x+%2B+1),+x))\r\n\r\nThe `ConditionSet` case I gave above is valid considering the first case. What do you suggest?\r\n\r\n```python\r\n\r\n>>> ConditionSet(x, And(1 - x >0, 3*x > 0, 4*x + 1), {-1/2, 1/6})\r\n1/6\r\n```","created_at":"2018-07-20T05:57:03Z","updated_at":"2018-07-20T05:57:03Z","html_url":"https://github.com/sympy/sympy/pull/14792#discussion_r203944491","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/14792","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/203944491"},"html":{"href":"https://github.com/sympy/sympy/pull/14792#discussion_r203944491"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14792"}},"in_reply_to_id":203520559},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/14792","id":194083269,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDgzMjY5","html_url":"https://github.com/sympy/sympy/pull/14792","diff_url":"https://github.com/sympy/sympy/pull/14792.diff","patch_url":"https://github.com/sympy/sympy/pull/14792.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/14792","number":14792,"state":"open","locked":false,"title":"log solver for transolve","user":{"login":"Yathartha22","id":14955840,"node_id":"MDQ6VXNlcjE0OTU1ODQw","avatar_url":"https://avatars1.githubusercontent.com/u/14955840?v=4","gravatar_id":"","url":"https://api.github.com/users/Yathartha22","html_url":"https://github.com/Yathartha22","followers_url":"https://api.github.com/users/Yathartha22/followers","following_url":"https://api.github.com/users/Yathartha22/following{/other_user}","gists_url":"https://api.github.com/users/Yathartha22/gists{/gist_id}","starred_url":"https://api.github.com/users/Yathartha22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yathartha22/subscriptions","organizations_url":"https://api.github.com/users/Yathartha22/orgs","repos_url":"https://api.github.com/users/Yathartha22/repos","events_url":"https://api.github.com/users/Yathartha22/events{/privacy}","received_events_url":"https://api.github.com/users/Yathartha22/received_events","type":"User","site_admin":false},"body":"This PR is an extension to #14736 and is built over its branch.\r\n\r\nThe PR aims to implement `log solver` as part of `transolve`.\r\n\r\nTODO's:\r\n\r\n- [x] Documentation for `_log_solver` and `_check_log`\r\n\r\n- [x] Tests for the helpers\r\n\r\n- [x] Improvement in `_check_log` to handle corner cases.","created_at":"2018-06-11T19:44:37Z","updated_at":"2018-07-20T05:57:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"447b31b593bffbab68ca9b7f634eb3a41fcc0ae0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":222869633,"node_id":"MDU6TGFiZWwyMjI4Njk2MzM=","url":"https://api.github.com/repos/sympy/sympy/labels/PR:%20sympy's%20turn","name":"PR: sympy's turn","color":"ffff1a","default":false},{"id":226914699,"node_id":"MDU6TGFiZWwyMjY5MTQ2OTk=","url":"https://api.github.com/repos/sympy/sympy/labels/solvers.solveset","name":"solvers.solveset","color":"0000FF","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/14792/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/14792/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/14792/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/afc59513e9d0b427bce67a46885c69aa42521204","head":{"label":"Yathartha22:transolve_log_solver","ref":"transolve_log_solver","sha":"afc59513e9d0b427bce67a46885c69aa42521204","user":{"login":"Yathartha22","id":14955840,"node_id":"MDQ6VXNlcjE0OTU1ODQw","avatar_url":"https://avatars1.githubusercontent.com/u/14955840?v=4","gravatar_id":"","url":"https://api.github.com/users/Yathartha22","html_url":"https://github.com/Yathartha22","followers_url":"https://api.github.com/users/Yathartha22/followers","following_url":"https://api.github.com/users/Yathartha22/following{/other_user}","gists_url":"https://api.github.com/users/Yathartha22/gists{/gist_id}","starred_url":"https://api.github.com/users/Yathartha22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yathartha22/subscriptions","organizations_url":"https://api.github.com/users/Yathartha22/orgs","repos_url":"https://api.github.com/users/Yathartha22/repos","events_url":"https://api.github.com/users/Yathartha22/events{/privacy}","received_events_url":"https://api.github.com/users/Yathartha22/received_events","type":"User","site_admin":false},"repo":{"id":77686804,"node_id":"MDEwOlJlcG9zaXRvcnk3NzY4NjgwNA==","name":"sympy","full_name":"Yathartha22/sympy","owner":{"login":"Yathartha22","id":14955840,"node_id":"MDQ6VXNlcjE0OTU1ODQw","avatar_url":"https://avatars1.githubusercontent.com/u/14955840?v=4","gravatar_id":"","url":"https://api.github.com/users/Yathartha22","html_url":"https://github.com/Yathartha22","followers_url":"https://api.github.com/users/Yathartha22/followers","following_url":"https://api.github.com/users/Yathartha22/following{/other_user}","gists_url":"https://api.github.com/users/Yathartha22/gists{/gist_id}","starred_url":"https://api.github.com/users/Yathartha22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yathartha22/subscriptions","organizations_url":"https://api.github.com/users/Yathartha22/orgs","repos_url":"https://api.github.com/users/Yathartha22/repos","events_url":"https://api.github.com/users/Yathartha22/events{/privacy}","received_events_url":"https://api.github.com/users/Yathartha22/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Yathartha22/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/Yathartha22/sympy","forks_url":"https://api.github.com/repos/Yathartha22/sympy/forks","keys_url":"https://api.github.com/repos/Yathartha22/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yathartha22/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yathartha22/sympy/teams","hooks_url":"https://api.github.com/repos/Yathartha22/sympy/hooks","issue_events_url":"https://api.github.com/repos/Yathartha22/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/Yathartha22/sympy/events","assignees_url":"https://api.github.com/repos/Yathartha22/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/Yathartha22/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/Yathartha22/sympy/tags","blobs_url":"https://api.github.com/repos/Yathartha22/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yathartha22/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yathartha22/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yathartha22/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yathartha22/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/Yathartha22/sympy/languages","stargazers_url":"https://api.github.com/repos/Yathartha22/sympy/stargazers","contributors_url":"https://api.github.com/repos/Yathartha22/sympy/contributors","subscribers_url":"https://api.github.com/repos/Yathartha22/sympy/subscribers","subscription_url":"https://api.github.com/repos/Yathartha22/sympy/subscription","commits_url":"https://api.github.com/repos/Yathartha22/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yathartha22/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yathartha22/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yathartha22/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yathartha22/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/Yathartha22/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yathartha22/sympy/merges","archive_url":"https://api.github.com/repos/Yathartha22/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yathartha22/sympy/downloads","issues_url":"https://api.github.com/repos/Yathartha22/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/Yathartha22/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/Yathartha22/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/Yathartha22/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yathartha22/sympy/labels{/name}","releases_url":"https://api.github.com/repos/Yathartha22/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/Yathartha22/sympy/deployments","created_at":"2016-12-30T13:07:17Z","updated_at":"2018-07-09T20:26:54Z","pushed_at":"2018-07-18T18:37:22Z","git_url":"git://github.com/Yathartha22/sympy.git","ssh_url":"git@github.com:Yathartha22/sympy.git","clone_url":"https://github.com/Yathartha22/sympy.git","svn_url":"https://github.com/Yathartha22/sympy","homepage":"http://sympy.org/","size":92113,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"fccf0444c1d0b67ddf4a48c28d4f4dd5ce0510a7","user":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"node_id":"MDEwOlJlcG9zaXRvcnk2NDA1MzQ=","name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2018-07-19T21:23:58Z","pushed_at":"2018-07-20T05:27:52Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":92069,"stargazers_count":4952,"watchers_count":4952,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2307,"mirror_url":null,"archived":false,"open_issues_count":3387,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2307,"open_issues":3387,"watchers":4952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14792"},"html":{"href":"https://github.com/sympy/sympy/pull/14792"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/14792"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/14792/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14792/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14792/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/afc59513e9d0b427bce67a46885c69aa42521204"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Yathartha22"}}