{"action":"created","comment":{"url":"https://api.github.com/repos/RH-FMK/skt/pulls/comments/185639566","pull_request_review_id":117070529,"id":185639566,"diff_hunk":"@@ -468,12 +467,8 @@ def bisect_iter(self, bad):\n class kbuilder(object):\n     def __init__(self, path, basecfg, cfgtype=None, makeopts=None,\n                  enable_debuginfo=False):\n-        # FIXME Move expansion up the call stack, as this limits the class\n-        # usefulness, because tilde is a valid path character.\n-        self.path = os.path.expanduser(path)\n-        # FIXME Move expansion up the call stack, as this limits the class\n-        # usefulness, because tilde is a valid path character.\n-        self.basecfg = os.path.expanduser(basecfg)\n+        self.path = path\n+        self.basecfg = basecfg","path":"skt/__init__.py","position":28,"original_position":28,"commit_id":"8a850aefb63c5724c63a409530c47522f5bf2c15","original_commit_id":"c4e695c9893bfb2aec889b55b6a2047c77f165a2","user":{"login":"major","id":89910,"avatar_url":"https://avatars3.githubusercontent.com/u/89910?v=4","gravatar_id":"","url":"https://api.github.com/users/major","html_url":"https://github.com/major","followers_url":"https://api.github.com/users/major/followers","following_url":"https://api.github.com/users/major/following{/other_user}","gists_url":"https://api.github.com/users/major/gists{/gist_id}","starred_url":"https://api.github.com/users/major/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/major/subscriptions","organizations_url":"https://api.github.com/users/major/orgs","repos_url":"https://api.github.com/users/major/repos","events_url":"https://api.github.com/users/major/events{/privacy}","received_events_url":"https://api.github.com/users/major/received_events","type":"User","site_admin":false},"body":"Those are fixed up in 83862e8 and d02ba69.","created_at":"2018-05-02T21:09:46Z","updated_at":"2018-05-02T21:09:46Z","html_url":"https://github.com/RH-FMK/skt/pull/95#discussion_r185639566","pull_request_url":"https://api.github.com/repos/RH-FMK/skt/pulls/95","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RH-FMK/skt/pulls/comments/185639566"},"html":{"href":"https://github.com/RH-FMK/skt/pull/95#discussion_r185639566"},"pull_request":{"href":"https://api.github.com/repos/RH-FMK/skt/pulls/95"}},"in_reply_to_id":185626773},"pull_request":{"url":"https://api.github.com/repos/RH-FMK/skt/pulls/95","id":184135033,"html_url":"https://github.com/RH-FMK/skt/pull/95","diff_url":"https://github.com/RH-FMK/skt/pull/95.diff","patch_url":"https://github.com/RH-FMK/skt/pull/95.patch","issue_url":"https://api.github.com/repos/RH-FMK/skt/issues/95","number":95,"state":"open","locked":false,"title":"Optimize configuration and split out state data","user":{"login":"major","id":89910,"avatar_url":"https://avatars3.githubusercontent.com/u/89910?v=4","gravatar_id":"","url":"https://api.github.com/users/major","html_url":"https://github.com/major","followers_url":"https://api.github.com/users/major/followers","following_url":"https://api.github.com/users/major/following{/other_user}","gists_url":"https://api.github.com/users/major/gists{/gist_id}","starred_url":"https://api.github.com/users/major/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/major/subscriptions","organizations_url":"https://api.github.com/users/major/orgs","repos_url":"https://api.github.com/users/major/repos","events_url":"https://api.github.com/users/major/events{/privacy}","received_events_url":"https://api.github.com/users/major/received_events","type":"User","site_admin":false},"body":"This PR does a few things:\r\n\r\n* Splits configuration and state information into separate files\r\n* Gets absolute paths to directories and files very early in the `skt` run\r\n* Updates Circle-CI to use the new state file\r\n\r\nFixes #27.\r\nFixes #89.\r\nFixes #94.","created_at":"2018-04-25T19:10:47Z","updated_at":"2018-05-02T21:09:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b5711bff1564bff3b5146c49be37e4c5d80a725","assignee":{"login":"major","id":89910,"avatar_url":"https://avatars3.githubusercontent.com/u/89910?v=4","gravatar_id":"","url":"https://api.github.com/users/major","html_url":"https://github.com/major","followers_url":"https://api.github.com/users/major/followers","following_url":"https://api.github.com/users/major/following{/other_user}","gists_url":"https://api.github.com/users/major/gists{/gist_id}","starred_url":"https://api.github.com/users/major/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/major/subscriptions","organizations_url":"https://api.github.com/users/major/orgs","repos_url":"https://api.github.com/users/major/repos","events_url":"https://api.github.com/users/major/events{/privacy}","received_events_url":"https://api.github.com/users/major/received_events","type":"User","site_admin":false},"assignees":[{"login":"major","id":89910,"avatar_url":"https://avatars3.githubusercontent.com/u/89910?v=4","gravatar_id":"","url":"https://api.github.com/users/major","html_url":"https://github.com/major","followers_url":"https://api.github.com/users/major/followers","following_url":"https://api.github.com/users/major/following{/other_user}","gists_url":"https://api.github.com/users/major/gists{/gist_id}","starred_url":"https://api.github.com/users/major/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/major/subscriptions","organizations_url":"https://api.github.com/users/major/orgs","repos_url":"https://api.github.com/users/major/repos","events_url":"https://api.github.com/users/major/events{/privacy}","received_events_url":"https://api.github.com/users/major/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"spbnick","id":549246,"avatar_url":"https://avatars3.githubusercontent.com/u/549246?v=4","gravatar_id":"","url":"https://api.github.com/users/spbnick","html_url":"https://github.com/spbnick","followers_url":"https://api.github.com/users/spbnick/followers","following_url":"https://api.github.com/users/spbnick/following{/other_user}","gists_url":"https://api.github.com/users/spbnick/gists{/gist_id}","starred_url":"https://api.github.com/users/spbnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spbnick/subscriptions","organizations_url":"https://api.github.com/users/spbnick/orgs","repos_url":"https://api.github.com/users/spbnick/repos","events_url":"https://api.github.com/users/spbnick/events{/privacy}","received_events_url":"https://api.github.com/users/spbnick/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RH-FMK/skt/pulls/95/commits","review_comments_url":"https://api.github.com/repos/RH-FMK/skt/pulls/95/comments","review_comment_url":"https://api.github.com/repos/RH-FMK/skt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RH-FMK/skt/issues/95/comments","statuses_url":"https://api.github.com/repos/RH-FMK/skt/statuses/8a850aefb63c5724c63a409530c47522f5bf2c15","head":{"label":"major:separate-state","ref":"separate-state","sha":"8a850aefb63c5724c63a409530c47522f5bf2c15","user":{"login":"major","id":89910,"avatar_url":"https://avatars3.githubusercontent.com/u/89910?v=4","gravatar_id":"","url":"https://api.github.com/users/major","html_url":"https://github.com/major","followers_url":"https://api.github.com/users/major/followers","following_url":"https://api.github.com/users/major/following{/other_user}","gists_url":"https://api.github.com/users/major/gists{/gist_id}","starred_url":"https://api.github.com/users/major/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/major/subscriptions","organizations_url":"https://api.github.com/users/major/orgs","repos_url":"https://api.github.com/users/major/repos","events_url":"https://api.github.com/users/major/events{/privacy}","received_events_url":"https://api.github.com/users/major/received_events","type":"User","site_admin":false},"repo":{"id":126359216,"name":"skt","full_name":"major/skt","owner":{"login":"major","id":89910,"avatar_url":"https://avatars3.githubusercontent.com/u/89910?v=4","gravatar_id":"","url":"https://api.github.com/users/major","html_url":"https://github.com/major","followers_url":"https://api.github.com/users/major/followers","following_url":"https://api.github.com/users/major/following{/other_user}","gists_url":"https://api.github.com/users/major/gists{/gist_id}","starred_url":"https://api.github.com/users/major/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/major/subscriptions","organizations_url":"https://api.github.com/users/major/orgs","repos_url":"https://api.github.com/users/major/repos","events_url":"https://api.github.com/users/major/events{/privacy}","received_events_url":"https://api.github.com/users/major/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/major/skt","description":"\"Sonic Kernel Testing\" - a Linux Kernel testing tool","fork":true,"url":"https://api.github.com/repos/major/skt","forks_url":"https://api.github.com/repos/major/skt/forks","keys_url":"https://api.github.com/repos/major/skt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/major/skt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/major/skt/teams","hooks_url":"https://api.github.com/repos/major/skt/hooks","issue_events_url":"https://api.github.com/repos/major/skt/issues/events{/number}","events_url":"https://api.github.com/repos/major/skt/events","assignees_url":"https://api.github.com/repos/major/skt/assignees{/user}","branches_url":"https://api.github.com/repos/major/skt/branches{/branch}","tags_url":"https://api.github.com/repos/major/skt/tags","blobs_url":"https://api.github.com/repos/major/skt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/major/skt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/major/skt/git/refs{/sha}","trees_url":"https://api.github.com/repos/major/skt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/major/skt/statuses/{sha}","languages_url":"https://api.github.com/repos/major/skt/languages","stargazers_url":"https://api.github.com/repos/major/skt/stargazers","contributors_url":"https://api.github.com/repos/major/skt/contributors","subscribers_url":"https://api.github.com/repos/major/skt/subscribers","subscription_url":"https://api.github.com/repos/major/skt/subscription","commits_url":"https://api.github.com/repos/major/skt/commits{/sha}","git_commits_url":"https://api.github.com/repos/major/skt/git/commits{/sha}","comments_url":"https://api.github.com/repos/major/skt/comments{/number}","issue_comment_url":"https://api.github.com/repos/major/skt/issues/comments{/number}","contents_url":"https://api.github.com/repos/major/skt/contents/{+path}","compare_url":"https://api.github.com/repos/major/skt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/major/skt/merges","archive_url":"https://api.github.com/repos/major/skt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/major/skt/downloads","issues_url":"https://api.github.com/repos/major/skt/issues{/number}","pulls_url":"https://api.github.com/repos/major/skt/pulls{/number}","milestones_url":"https://api.github.com/repos/major/skt/milestones{/number}","notifications_url":"https://api.github.com/repos/major/skt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/major/skt/labels{/name}","releases_url":"https://api.github.com/repos/major/skt/releases{/id}","deployments_url":"https://api.github.com/repos/major/skt/deployments","created_at":"2018-03-22T15:51:16Z","updated_at":"2018-04-06T20:38:09Z","pushed_at":"2018-05-02T20:50:34Z","git_url":"git://github.com/major/skt.git","ssh_url":"git@github.com:major/skt.git","clone_url":"https://github.com/major/skt.git","svn_url":"https://github.com/major/skt","homepage":null,"size":225,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RH-FMK:master","ref":"master","sha":"0633d1703d90ffecb836e795d5dbff6f4fe7a15c","user":{"login":"RH-FMK","id":36988735,"avatar_url":"https://avatars0.githubusercontent.com/u/36988735?v=4","gravatar_id":"","url":"https://api.github.com/users/RH-FMK","html_url":"https://github.com/RH-FMK","followers_url":"https://api.github.com/users/RH-FMK/followers","following_url":"https://api.github.com/users/RH-FMK/following{/other_user}","gists_url":"https://api.github.com/users/RH-FMK/gists{/gist_id}","starred_url":"https://api.github.com/users/RH-FMK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RH-FMK/subscriptions","organizations_url":"https://api.github.com/users/RH-FMK/orgs","repos_url":"https://api.github.com/users/RH-FMK/repos","events_url":"https://api.github.com/users/RH-FMK/events{/privacy}","received_events_url":"https://api.github.com/users/RH-FMK/received_events","type":"Organization","site_admin":false},"repo":{"id":123569786,"name":"skt","full_name":"RH-FMK/skt","owner":{"login":"RH-FMK","id":36988735,"avatar_url":"https://avatars0.githubusercontent.com/u/36988735?v=4","gravatar_id":"","url":"https://api.github.com/users/RH-FMK","html_url":"https://github.com/RH-FMK","followers_url":"https://api.github.com/users/RH-FMK/followers","following_url":"https://api.github.com/users/RH-FMK/following{/other_user}","gists_url":"https://api.github.com/users/RH-FMK/gists{/gist_id}","starred_url":"https://api.github.com/users/RH-FMK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RH-FMK/subscriptions","organizations_url":"https://api.github.com/users/RH-FMK/orgs","repos_url":"https://api.github.com/users/RH-FMK/repos","events_url":"https://api.github.com/users/RH-FMK/events{/privacy}","received_events_url":"https://api.github.com/users/RH-FMK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RH-FMK/skt","description":"\"Sonic Kernel Testing\" - a Linux Kernel testing tool","fork":false,"url":"https://api.github.com/repos/RH-FMK/skt","forks_url":"https://api.github.com/repos/RH-FMK/skt/forks","keys_url":"https://api.github.com/repos/RH-FMK/skt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RH-FMK/skt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RH-FMK/skt/teams","hooks_url":"https://api.github.com/repos/RH-FMK/skt/hooks","issue_events_url":"https://api.github.com/repos/RH-FMK/skt/issues/events{/number}","events_url":"https://api.github.com/repos/RH-FMK/skt/events","assignees_url":"https://api.github.com/repos/RH-FMK/skt/assignees{/user}","branches_url":"https://api.github.com/repos/RH-FMK/skt/branches{/branch}","tags_url":"https://api.github.com/repos/RH-FMK/skt/tags","blobs_url":"https://api.github.com/repos/RH-FMK/skt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RH-FMK/skt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RH-FMK/skt/git/refs{/sha}","trees_url":"https://api.github.com/repos/RH-FMK/skt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RH-FMK/skt/statuses/{sha}","languages_url":"https://api.github.com/repos/RH-FMK/skt/languages","stargazers_url":"https://api.github.com/repos/RH-FMK/skt/stargazers","contributors_url":"https://api.github.com/repos/RH-FMK/skt/contributors","subscribers_url":"https://api.github.com/repos/RH-FMK/skt/subscribers","subscription_url":"https://api.github.com/repos/RH-FMK/skt/subscription","commits_url":"https://api.github.com/repos/RH-FMK/skt/commits{/sha}","git_commits_url":"https://api.github.com/repos/RH-FMK/skt/git/commits{/sha}","comments_url":"https://api.github.com/repos/RH-FMK/skt/comments{/number}","issue_comment_url":"https://api.github.com/repos/RH-FMK/skt/issues/comments{/number}","contents_url":"https://api.github.com/repos/RH-FMK/skt/contents/{+path}","compare_url":"https://api.github.com/repos/RH-FMK/skt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RH-FMK/skt/merges","archive_url":"https://api.github.com/repos/RH-FMK/skt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RH-FMK/skt/downloads","issues_url":"https://api.github.com/repos/RH-FMK/skt/issues{/number}","pulls_url":"https://api.github.com/repos/RH-FMK/skt/pulls{/number}","milestones_url":"https://api.github.com/repos/RH-FMK/skt/milestones{/number}","notifications_url":"https://api.github.com/repos/RH-FMK/skt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RH-FMK/skt/labels{/name}","releases_url":"https://api.github.com/repos/RH-FMK/skt/releases{/id}","deployments_url":"https://api.github.com/repos/RH-FMK/skt/deployments","created_at":"2018-03-02T11:09:58Z","updated_at":"2018-05-02T21:08:05Z","pushed_at":"2018-05-02T21:08:03Z","git_url":"git://github.com/RH-FMK/skt.git","ssh_url":"git@github.com:RH-FMK/skt.git","clone_url":"https://github.com/RH-FMK/skt.git","svn_url":"https://github.com/RH-FMK/skt","homepage":null,"size":183,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":8,"open_issues":37,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RH-FMK/skt/pulls/95"},"html":{"href":"https://github.com/RH-FMK/skt/pull/95"},"issue":{"href":"https://api.github.com/repos/RH-FMK/skt/issues/95"},"comments":{"href":"https://api.github.com/repos/RH-FMK/skt/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/RH-FMK/skt/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/RH-FMK/skt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RH-FMK/skt/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/RH-FMK/skt/statuses/8a850aefb63c5724c63a409530c47522f5bf2c15"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"major"}}