{"action":"closed","number":3390,"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/3390","id":198524921,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTI0OTIx","html_url":"https://github.com/Azure/acs-engine/pull/3390","diff_url":"https://github.com/Azure/acs-engine/pull/3390.diff","patch_url":"https://github.com/Azure/acs-engine/pull/3390.patch","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/3390","number":3390,"state":"closed","locked":false,"title":"changes to fix issue #2312","user":{"login":"maniSbindra","id":6338721,"node_id":"MDQ6VXNlcjYzMzg3MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6338721?v=4","gravatar_id":"","url":"https://api.github.com/users/maniSbindra","html_url":"https://github.com/maniSbindra","followers_url":"https://api.github.com/users/maniSbindra/followers","following_url":"https://api.github.com/users/maniSbindra/following{/other_user}","gists_url":"https://api.github.com/users/maniSbindra/gists{/gist_id}","starred_url":"https://api.github.com/users/maniSbindra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniSbindra/subscriptions","organizations_url":"https://api.github.com/users/maniSbindra/orgs","repos_url":"https://api.github.com/users/maniSbindra/repos","events_url":"https://api.github.com/users/maniSbindra/events{/privacy}","received_events_url":"https://api.github.com/users/maniSbindra/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**: This PR fixes issue #2312 \r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #2312 \r\n\r\n**Special notes for your reviewer**:\r\nThings checked are \r\n* Policy file details from kube-apiserver logs (**Loaded 8 audit policy rules from file /etc/kubernetes/addons/audit-policy.yaml**)\r\n```sh\r\n$ kubectl --namespace=kube-system logs  kube-apiserver-k8s-master-38666652-0  | grep -i audit \r\nI0701 16:55:28.256862       1 reader.go:56] Loaded 8 audit policy rules from file /etc/kubernetes/addons/audit-policy.yaml\r\nk8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filters.(*auditResponseWriter).WriteHeader(0xc4225b6640, 0x1f4)\r\n\t/workspace/anago-v1.8.14-beta.0.16+9d72fafc46543e/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filters/audit.go:215 +0x63\r\nk8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filters.WithAudit.func1(0x7f3176f9ea40, 0xc424f4a9a8, 0xc4254abd00)\r\n\t/workspace/anago-v1.8.14-beta.0.16+9d72fafc46543e/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filters/audit.go:105 +0x52a\r\nk8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filters.(*auditResponseWriter).WriteHeader(0xc42404d9a0, 0x1f4)\r\n\t/workspace/anago-v1.8.14-beta.0.16+9d72fafc46543e/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filters/audit.go:215 +0x63\r\nk8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filters.WithAudit.func1(0x7f3176f9ea40, 0xc42000f8f8, 0xc42282d100)\r\n\t/workspace/anago-v1.8.14-beta.0.16+9d72fafc46543e/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filters/audit.go:105 +0x52a\r\nk8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filters.(*auditResponseWriter).WriteHeader(0xc427e51c70, 0x1f4)\r\n\t/workspace/anago-v1.8.14-beta.0.16+9d72fafc46543e/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filters/audit.go:215 +0x63\r\nk8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filters.WithAudit.func1(0x7f3176f9ea40, 0xc42be54668, 0xc42b0ee300)\r\n\t/workspace/anago-v1.8.14-beta.0.16+9d72fafc46543e/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/endpoints/filters/audit.go:105 +0x52a\r\nIND-CSE:kubeconfig mani$ kl run busybox --image=busybox\r\n```\r\n\r\n* Audit log after exec into API server pod (events related to busybox pod i created)\r\n```sh\r\n$ grep busybox /var/log/audit.log | tail -2\r\n{\"kind\":\"Event\",\"apiVersion\":\"audit.k8s.io/v1beta1\",\"metadata\":{\"creationTimestamp\":\"2018-07-01T17:25:51Z\"},\"level\":\"Request\",\"timestamp\":\"2018-07-01T17:25:51Z\",\"auditID\":\"9b120309-556a-4348-b63f-e712390d9c62\",\"stage\":\"RequestReceived\",\"requestURI\":\"/api/v1/namespaces/default/events/busybox-6944bc9f7b-v2888.153d4e658978585c\",\"verb\":\"patch\",\"user\":{\"username\":\"client\",\"groups\":[\"system:masters\",\"system:authenticated\"]},\"sourceIPs\":[\"10.240.0.4\"],\"objectRef\":{\"resource\":\"events\",\"namespace\":\"default\",\"name\":\"busybox-6944bc9f7b-v2888.153d4e658978585c\",\"apiVersion\":\"v1\"}}\r\n{\"kind\":\"Event\",\"apiVersion\":\"audit.k8s.io/v1beta1\",\"metadata\":{\"creationTimestamp\":\"2018-07-01T17:25:51Z\"},\"level\":\"Request\",\"timestamp\":\"2018-07-01T17:25:51Z\",\"auditID\":\"9b120309-556a-4348-b63f-e712390d9c62\",\"stage\":\"ResponseComplete\",\"requestURI\":\"/api/v1/namespaces/default/events/busybox-6944bc9f7b-v2888.153d4e658978585c\",\"verb\":\"patch\",\"user\":{\"username\":\"client\",\"groups\":[\"system:masters\",\"system:authenticated\"]},\"sourceIPs\":[\"10.240.0.4\"],\"objectRef\":{\"resource\":\"events\",\"namespace\":\"default\",\"name\":\"busybox-6944bc9f7b-v2888.153d4e658978585c\",\"apiVersion\":\"v1\"},\"responseStatus\":{\"metadata\":{},\"code\":200},\"requestObject\":{\"count\":25,\"lastTimestamp\":\"2018-07-01T17:25:51Z\",\"message\":\"Error syncing pod\"}}\r\n```\r\n\r\n* Top few lines of Kubelet logs from master node\r\n```sh\r\n$ journalctl -u kubelet\r\n-- Logs begin at Sun 2018-07-01 16:54:34 UTC, end at Sun 2018-07-01 17:22:31 UTC. --\r\nJul 01 16:54:33 k8s-master-38666652-0 systemd[1]: Stopped Kubelet.\r\nJul 01 16:54:33 k8s-master-38666652-0 systemd[1]: Starting Kubelet...\r\nJul 01 16:54:33 k8s-master-38666652-0 sysctl[9333]: net.ipv4.tcp_retries2 = 8\r\nJul 01 16:54:33 k8s-master-38666652-0 ebtables[9336]: Bridge table: nat\r\nJul 01 16:54:33 k8s-master-38666652-0 ebtables[9336]: Bridge chain: PREROUTING, entries: 0, policy: ACCEPT\r\nJul 01 16:54:33 k8s-master-38666652-0 ebtables[9336]: Bridge chain: OUTPUT, entries: 0, policy: ACCEPT\r\nJul 01 16:54:33 k8s-master-38666652-0 ebtables[9336]: Bridge chain: POSTROUTING, entries: 0, policy: ACCEPT\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: Chain PREROUTING (policy ACCEPT)\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: target     prot opt source               destination\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: DOCKER     all  --  anywhere             anywhere             ADDRTYPE match dst-type LOCAL\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: Chain INPUT (policy ACCEPT)\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: target     prot opt source               destination\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: Chain OUTPUT (policy ACCEPT)\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: target     prot opt source               destination\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: DOCKER     all  --  anywhere            !127.0.0.0/8          ADDRTYPE match dst-type LOCAL\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: Chain POSTROUTING (policy ACCEPT)\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: target     prot opt source               destination\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: MASQUERADE  all  --  172.17.0.0/16        anywhere\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: MASQUERADE  all  --  anywhere            !10.0.0.0/8           destination IP range ! 168.63.129.16-168.63.129.16 ADDRTYPE match dst-type !LOCAL\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: Chain DOCKER (2 references)\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: target     prot opt source               destination\r\nJul 01 16:54:33 k8s-master-38666652-0 iptables[9339]: RETURN     all  --  anywhere             anywhere\r\nJul 01 16:54:33 k8s-master-38666652-0 systemd[1]: Started Kubelet.\r\nJul 01 16:54:34 k8s-master-38666652-0 kubelet[9343]: Flag --keep-terminated-pod-volumes has been deprecated, will be removed in a future version\r\nJul 01 16:54:34 k8s-master-38666652-0 kubelet[9343]: Flag --non-masquerade-cidr has been deprecated, will be removed in a future version\r\nJul 01 16:54:34 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:34.040371    9343 feature_gate.go:162] feature gates: map[]\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.036757    9343 mount_linux.go:213] Detected OS with systemd\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.036783    9343 client.go:75] Connecting to docker on unix:///var/run/docker.sock\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.036805    9343 client.go:95] Start docker client with request timeout=2m0s\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.061277    9343 azure.go:175] azure: using client_id+client_secret to retrieve access token\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.457589    9343 server.go:301] Successfully initialized cloud provider: \"azure\" from the config file: \"/etc/kubernetes/azure.json\"\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.457643    9343 server.go:537] cloud provider determined current node name to be k8s-master-38666652-0\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.460443    9343 manager.go:149] cAdvisor running in container: \"/sys/fs/cgroup/cpu,cpuacct/system.slice/kubelet.service\"\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: W0701 16:54:35.472537    9343 manager.go:157] unable to connect to Rkt api service: rkt: cannot tcp Dial rkt api service: dial tcp 127.0.0.1:15441: get\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: W0701 16:54:35.472683    9343 manager.go:166] unable to connect to CRI-O api service: Get http://%2Fvar%2Frun%2Fcrio.sock/info: dial unix /var/run/crio\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.481054    9343 fs.go:139] Filesystem UUIDs: map[626e2fcc-121d-43b3-9ade-7c313f813a52:/dev/sdc1 84e91f24-0077-40f3-aab8-b49b8e1f4506:/dev\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.481083    9343 fs.go:140] Filesystem partitions: map[tmpfs:{mountpoint:/run major:0 minor:23 fsType:tmpfs blockSize:0} /dev/sda1:{mountp\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.482749    9343 manager.go:216] Machine: {NumCores:2 CpuFrequency:2394453 MemoryCapacity:7284019200 HugePages:[{PageSize:1048576 NumPages\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.483281    9343 manager.go:222] Version: {KernelVersion:4.15.0-1013-azure ContainerOsVersion:Ubuntu 16.04.4 LTS DockerVersion:1.13.1 Dock\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.483792    9343 server.go:425] --cgroups-per-qos enabled, but --cgroup-root was not specified.  defaulting to /\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.485424    9343 container_manager_linux.go:252] container manager verified user specified cgroup-root exists: /\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.485450    9343 container_manager_linux.go:257] Creating Container Manager object based on Node Config: {RuntimeCgroupsName: SystemCgroup\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.485533    9343 container_manager_linux.go:288] Creating device plugin handler: false\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.485598    9343 server.go:537] cloud provider determined current node name to be k8s-master-38666652-0\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.485609    9343 server.go:689] Using root directory: /var/lib/kubelet\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.485651    9343 kubelet.go:350] cloud provider determined current node name to be k8s-master-38666652-0\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.485673    9343 kubelet.go:275] Adding manifest file: /etc/kubernetes/manifests\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.485691    9343 file.go:52] Watching path \"/etc/kubernetes/manifests\"\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.485697    9343 kubelet.go:285] Watching apiserver\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: E0701 16:54:35.489550    9343 reflector.go:205] k8s.io/kubernetes/pkg/kubelet/kubelet.go:415: Failed to list *v1.Service: Get https://10.255.255.5:443/\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: E0701 16:54:35.489754    9343 reflector.go:205] k8s.io/kubernetes/pkg/kubelet/config/apiserver.go:47: Failed to list *v1.Pod: Get https://10.255.255.5:\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: E0701 16:54:35.489842    9343 reflector.go:205] k8s.io/kubernetes/pkg/kubelet/kubelet.go:424: Failed to list *v1.Node: Get https://10.255.255.5:443/api\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: W0701 16:54:35.520356    9343 kubelet_network.go:69] Hairpin mode set to \"promiscuous-bridge\" but kubenet is not enabled, falling back to \"hairpin-veth\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.520394    9343 kubelet.go:520] Hairpin mode set to \"hairpin-veth\"\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.520580    9343 plugins.go:187] Loaded network plugin \"cni\"\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.545547    9343 plugins.go:187] Loaded network plugin \"cni\"\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.545908    9343 docker_service.go:207] Docker cri networking managed by cni\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.555501    9343 docker_service.go:212] Docker Info: &{ID:OP6F:DLWT:KXR6:2KFV:JIAG:RZJZ:CPO4:XA4T:IBGQ:EXQA:IRUU:H6RQ Containers:0 Contain\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.555936    9343 docker_service.go:225] Setting cgroupDriver to cgroupfs\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.557912    9343 docker_legacy.go:151] No legacy containers found, stop performing legacy cleanup.\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.557952    9343 kubelet.go:609] Starting the GRPC server for the docker CRI shim.\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.557966    9343 docker_server.go:51] Start dockershim grpc server\r\nJul 01 16:54:35 k8s-master-38666652-0 kubelet[9343]: I0701 16:54:35.566414    9343 remote_runtime.go:43] Connecting to runtime service unix:///var/run/dockershim.sock\r\n```\r\n\r\n**If applicable**:\r\n- [ ] documentation\r\n- [ ] unit tests\r\n- [ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n\r\n\r\n\r\n","created_at":"2018-07-01T13:41:52Z","updated_at":"2018-07-02T23:36:20Z","closed_at":"2018-07-02T23:36:20Z","merged_at":"2018-07-02T23:36:19Z","merge_commit_sha":"20b95b4352186da066d4ba6b811855e4d614158d","assignee":{"login":"maniSbindra","id":6338721,"node_id":"MDQ6VXNlcjYzMzg3MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6338721?v=4","gravatar_id":"","url":"https://api.github.com/users/maniSbindra","html_url":"https://github.com/maniSbindra","followers_url":"https://api.github.com/users/maniSbindra/followers","following_url":"https://api.github.com/users/maniSbindra/following{/other_user}","gists_url":"https://api.github.com/users/maniSbindra/gists{/gist_id}","starred_url":"https://api.github.com/users/maniSbindra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniSbindra/subscriptions","organizations_url":"https://api.github.com/users/maniSbindra/orgs","repos_url":"https://api.github.com/users/maniSbindra/repos","events_url":"https://api.github.com/users/maniSbindra/events{/privacy}","received_events_url":"https://api.github.com/users/maniSbindra/received_events","type":"User","site_admin":false},"assignees":[{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},{"login":"maniSbindra","id":6338721,"node_id":"MDQ6VXNlcjYzMzg3MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6338721?v=4","gravatar_id":"","url":"https://api.github.com/users/maniSbindra","html_url":"https://github.com/maniSbindra","followers_url":"https://api.github.com/users/maniSbindra/followers","following_url":"https://api.github.com/users/maniSbindra/following{/other_user}","gists_url":"https://api.github.com/users/maniSbindra/gists{/gist_id}","starred_url":"https://api.github.com/users/maniSbindra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniSbindra/subscriptions","organizations_url":"https://api.github.com/users/maniSbindra/orgs","repos_url":"https://api.github.com/users/maniSbindra/repos","events_url":"https://api.github.com/users/maniSbindra/events{/privacy}","received_events_url":"https://api.github.com/users/maniSbindra/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":936414293,"node_id":"MDU6TGFiZWw5MzY0MTQyOTM=","url":"https://api.github.com/repos/Azure/acs-engine/labels/approved","name":"approved","color":"52f2d4","default":false},{"id":616225832,"node_id":"MDU6TGFiZWw2MTYyMjU4MzI=","url":"https://api.github.com/repos/Azure/acs-engine/labels/in%20progress","name":"in progress","color":"b8ddf9","default":false},{"id":936411741,"node_id":"MDU6TGFiZWw5MzY0MTE3NDE=","url":"https://api.github.com/repos/Azure/acs-engine/labels/lgtm","name":"lgtm","color":"11fc63","default":false},{"id":936711751,"node_id":"MDU6TGFiZWw5MzY3MTE3NTE=","url":"https://api.github.com/repos/Azure/acs-engine/labels/size/S","name":"size/S","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acs-engine/pulls/3390/commits","review_comments_url":"https://api.github.com/repos/Azure/acs-engine/pulls/3390/comments","review_comment_url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/3390/comments","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/8bc9f85eeb60bd018502cb212f5e5427838174ac","head":{"label":"maniSbindra:issue-2312-fix","ref":"issue-2312-fix","sha":"8bc9f85eeb60bd018502cb212f5e5427838174ac","user":{"login":"maniSbindra","id":6338721,"node_id":"MDQ6VXNlcjYzMzg3MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6338721?v=4","gravatar_id":"","url":"https://api.github.com/users/maniSbindra","html_url":"https://github.com/maniSbindra","followers_url":"https://api.github.com/users/maniSbindra/followers","following_url":"https://api.github.com/users/maniSbindra/following{/other_user}","gists_url":"https://api.github.com/users/maniSbindra/gists{/gist_id}","starred_url":"https://api.github.com/users/maniSbindra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniSbindra/subscriptions","organizations_url":"https://api.github.com/users/maniSbindra/orgs","repos_url":"https://api.github.com/users/maniSbindra/repos","events_url":"https://api.github.com/users/maniSbindra/events{/privacy}","received_events_url":"https://api.github.com/users/maniSbindra/received_events","type":"User","site_admin":false},"repo":{"id":131207461,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEyMDc0NjE=","name":"acs-engine","full_name":"maniSbindra/acs-engine","owner":{"login":"maniSbindra","id":6338721,"node_id":"MDQ6VXNlcjYzMzg3MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6338721?v=4","gravatar_id":"","url":"https://api.github.com/users/maniSbindra","html_url":"https://github.com/maniSbindra","followers_url":"https://api.github.com/users/maniSbindra/followers","following_url":"https://api.github.com/users/maniSbindra/following{/other_user}","gists_url":"https://api.github.com/users/maniSbindra/gists{/gist_id}","starred_url":"https://api.github.com/users/maniSbindra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniSbindra/subscriptions","organizations_url":"https://api.github.com/users/maniSbindra/orgs","repos_url":"https://api.github.com/users/maniSbindra/repos","events_url":"https://api.github.com/users/maniSbindra/events{/privacy}","received_events_url":"https://api.github.com/users/maniSbindra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maniSbindra/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":true,"url":"https://api.github.com/repos/maniSbindra/acs-engine","forks_url":"https://api.github.com/repos/maniSbindra/acs-engine/forks","keys_url":"https://api.github.com/repos/maniSbindra/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maniSbindra/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maniSbindra/acs-engine/teams","hooks_url":"https://api.github.com/repos/maniSbindra/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/maniSbindra/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/maniSbindra/acs-engine/events","assignees_url":"https://api.github.com/repos/maniSbindra/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/maniSbindra/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/maniSbindra/acs-engine/tags","blobs_url":"https://api.github.com/repos/maniSbindra/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maniSbindra/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maniSbindra/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/maniSbindra/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maniSbindra/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/maniSbindra/acs-engine/languages","stargazers_url":"https://api.github.com/repos/maniSbindra/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/maniSbindra/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/maniSbindra/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/maniSbindra/acs-engine/subscription","commits_url":"https://api.github.com/repos/maniSbindra/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/maniSbindra/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/maniSbindra/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/maniSbindra/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/maniSbindra/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/maniSbindra/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maniSbindra/acs-engine/merges","archive_url":"https://api.github.com/repos/maniSbindra/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maniSbindra/acs-engine/downloads","issues_url":"https://api.github.com/repos/maniSbindra/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/maniSbindra/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/maniSbindra/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/maniSbindra/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maniSbindra/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/maniSbindra/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/maniSbindra/acs-engine/deployments","created_at":"2018-04-26T20:31:05Z","updated_at":"2018-04-26T20:31:09Z","pushed_at":"2018-07-01T17:31:48Z","git_url":"git://github.com/maniSbindra/acs-engine.git","ssh_url":"git@github.com:maniSbindra/acs-engine.git","clone_url":"https://github.com/maniSbindra/acs-engine.git","svn_url":"https://github.com/maniSbindra/acs-engine","homepage":"","size":73365,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"45b5f175c2b769a5ec945a1fd104faeef356507d","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":66011370,"node_id":"MDEwOlJlcG9zaXRvcnk2NjAxMTM3MA==","name":"acs-engine","full_name":"Azure/acs-engine","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/acs-engine","description":"Azure Container Service Engine - provision and deploy container orchestrators on Azure: Kubernetes, DC/OS, and Docker Swarm.","fork":false,"url":"https://api.github.com/repos/Azure/acs-engine","forks_url":"https://api.github.com/repos/Azure/acs-engine/forks","keys_url":"https://api.github.com/repos/Azure/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acs-engine/teams","hooks_url":"https://api.github.com/repos/Azure/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acs-engine/events","assignees_url":"https://api.github.com/repos/Azure/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acs-engine/tags","blobs_url":"https://api.github.com/repos/Azure/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acs-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/acs-engine/subscription","commits_url":"https://api.github.com/repos/Azure/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acs-engine/merges","archive_url":"https://api.github.com/repos/Azure/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acs-engine/downloads","issues_url":"https://api.github.com/repos/Azure/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acs-engine/deployments","created_at":"2016-08-18T16:05:16Z","updated_at":"2018-07-02T20:35:57Z","pushed_at":"2018-07-02T23:36:19Z","git_url":"git://github.com/Azure/acs-engine.git","ssh_url":"git@github.com:Azure/acs-engine.git","clone_url":"https://github.com/Azure/acs-engine.git","svn_url":"https://github.com/Azure/acs-engine","homepage":"","size":83583,"stargazers_count":862,"watchers_count":862,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":548,"mirror_url":null,"archived":false,"open_issues_count":530,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":548,"open_issues":530,"watchers":862,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/3390"},"html":{"href":"https://github.com/Azure/acs-engine/pull/3390"},"issue":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/3390"},"comments":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/3390/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/3390/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/3390/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acs-engine/statuses/8bc9f85eeb60bd018502cb212f5e5427838174ac"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":6,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"jackfrancis"}}