{"action":"created","issue":{"url":"https://api.github.com/repos/bosnet/sebak/issues/784","repository_url":"https://api.github.com/repos/bosnet/sebak","labels_url":"https://api.github.com/repos/bosnet/sebak/issues/784/labels{/name}","comments_url":"https://api.github.com/repos/bosnet/sebak/issues/784/comments","events_url":"https://api.github.com/repos/bosnet/sebak/issues/784/events","html_url":"https://github.com/bosnet/sebak/pull/784","id":383375302,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODU1NzQ4","number":784,"title":"Use consensus voting logic in sync-consensus","user":{"login":"Charleslee522","id":15343839,"node_id":"MDQ6VXNlcjE1MzQzODM5","avatar_url":"https://avatars1.githubusercontent.com/u/15343839?v=4","gravatar_id":"","url":"https://api.github.com/users/Charleslee522","html_url":"https://github.com/Charleslee522","followers_url":"https://api.github.com/users/Charleslee522/followers","following_url":"https://api.github.com/users/Charleslee522/following{/other_user}","gists_url":"https://api.github.com/users/Charleslee522/gists{/gist_id}","starred_url":"https://api.github.com/users/Charleslee522/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Charleslee522/subscriptions","organizations_url":"https://api.github.com/users/Charleslee522/orgs","repos_url":"https://api.github.com/users/Charleslee522/repos","events_url":"https://api.github.com/users/Charleslee522/events{/privacy}","received_events_url":"https://api.github.com/users/Charleslee522/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Charleslee522","id":15343839,"node_id":"MDQ6VXNlcjE1MzQzODM5","avatar_url":"https://avatars1.githubusercontent.com/u/15343839?v=4","gravatar_id":"","url":"https://api.github.com/users/Charleslee522","html_url":"https://github.com/Charleslee522","followers_url":"https://api.github.com/users/Charleslee522/followers","following_url":"https://api.github.com/users/Charleslee522/following{/other_user}","gists_url":"https://api.github.com/users/Charleslee522/gists{/gist_id}","starred_url":"https://api.github.com/users/Charleslee522/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Charleslee522/subscriptions","organizations_url":"https://api.github.com/users/Charleslee522/orgs","repos_url":"https://api.github.com/users/Charleslee522/repos","events_url":"https://api.github.com/users/Charleslee522/events{/privacy}","received_events_url":"https://api.github.com/users/Charleslee522/received_events","type":"User","site_admin":false},"assignees":[{"login":"Charleslee522","id":15343839,"node_id":"MDQ6VXNlcjE1MzQzODM5","avatar_url":"https://avatars1.githubusercontent.com/u/15343839?v=4","gravatar_id":"","url":"https://api.github.com/users/Charleslee522","html_url":"https://github.com/Charleslee522","followers_url":"https://api.github.com/users/Charleslee522/followers","following_url":"https://api.github.com/users/Charleslee522/following{/other_user}","gists_url":"https://api.github.com/users/Charleslee522/gists{/gist_id}","starred_url":"https://api.github.com/users/Charleslee522/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Charleslee522/subscriptions","organizations_url":"https://api.github.com/users/Charleslee522/orgs","repos_url":"https://api.github.com/users/Charleslee522/repos","events_url":"https://api.github.com/users/Charleslee522/events{/privacy}","received_events_url":"https://api.github.com/users/Charleslee522/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-11-22T04:18:10Z","updated_at":"2018-11-23T02:14:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/784","html_url":"https://github.com/bosnet/sebak/pull/784","diff_url":"https://github.com/bosnet/sebak/pull/784.diff","patch_url":"https://github.com/bosnet/sebak/pull/784.patch"},"body":"Actually in old logic, we save height only, doesn't round.\r\nSo in this environment, `4 nodes, threshold=3`\r\n\r\nIf a node receives three ballots like below,\r\n```\r\nB(`ACCEPT`, `YES`, Height:3, Round:2)\r\nB(`ACCEPT`, `YES`, Height:3, Round:0)\r\nB(`ACCEPT`, `YES`, Height:3, Round:1)\r\n```\r\n\r\nthen the node starts sync and confirm with B(`ACCEPT`, `YES`, Height:3, Round:1)\r\nBut the others can confirm B(`ACCEPT`, `YES`, Height:3, Round:2)\r\nSo we should save round in sync-consensus.\r\n\r\nThe most obvious way is using consensus voting logic."},"comment":{"url":"https://api.github.com/repos/bosnet/sebak/issues/comments/441144096","html_url":"https://github.com/bosnet/sebak/pull/784#issuecomment-441144096","issue_url":"https://api.github.com/repos/bosnet/sebak/issues/784","id":441144096,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTE0NDA5Ng==","user":{"login":"Charleslee522","id":15343839,"node_id":"MDQ6VXNlcjE1MzQzODM5","avatar_url":"https://avatars1.githubusercontent.com/u/15343839?v=4","gravatar_id":"","url":"https://api.github.com/users/Charleslee522","html_url":"https://github.com/Charleslee522","followers_url":"https://api.github.com/users/Charleslee522/followers","following_url":"https://api.github.com/users/Charleslee522/following{/other_user}","gists_url":"https://api.github.com/users/Charleslee522/gists{/gist_id}","starred_url":"https://api.github.com/users/Charleslee522/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Charleslee522/subscriptions","organizations_url":"https://api.github.com/users/Charleslee522/orgs","repos_url":"https://api.github.com/users/Charleslee522/repos","events_url":"https://api.github.com/users/Charleslee522/events{/privacy}","received_events_url":"https://api.github.com/users/Charleslee522/received_events","type":"User","site_admin":false},"created_at":"2018-11-23T02:14:28Z","updated_at":"2018-11-23T02:14:28Z","author_association":"CONTRIBUTOR","body":"Oh, integration client test is failed(https://circleci.com/gh/Charleslee522/sebak/3135?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link).\r\nBut this pr is not related with consensus. And it is passed in my local environment.\r\n"}}
{"actor":{"display_login":"Charleslee522"}}