{"action":"created","comment":{"url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/comments/245116630","pull_request_review_id":189161776,"id":245116630,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTExNjYzMA==","diff_hunk":"@@ -0,0 +1,30 @@\n+/* Copyright 2018 The Bazel Authors. All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+   http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package proxy_test\n+\n+import (\n+\t\"testing\"\n+\n+\t\"github.com/bazelbuild/rules_go/tests/core/go_proto_library/proxy\"\n+)\n+\n+func use(interface{}) {}\n+\n+func TestProxy(t *testing.T) {\n+\t// just make sure both types exist\n+\tuse(proxy.A{})\n+  use(proxy.B{})","path":"tests/core/go_proto_library/proxy_test.go","position":29,"original_position":29,"commit_id":"980151cfd162458446025f5425f1bfe2cd7a491e","original_commit_id":"980151cfd162458446025f5425f1bfe2cd7a491e","user":{"login":"vam-google","id":25311427,"node_id":"MDQ6VXNlcjI1MzExNDI3","avatar_url":"https://avatars3.githubusercontent.com/u/25311427?v=4","gravatar_id":"","url":"https://api.github.com/users/vam-google","html_url":"https://github.com/vam-google","followers_url":"https://api.github.com/users/vam-google/followers","following_url":"https://api.github.com/users/vam-google/following{/other_user}","gists_url":"https://api.github.com/users/vam-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vam-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vam-google/subscriptions","organizations_url":"https://api.github.com/users/vam-google/orgs","repos_url":"https://api.github.com/users/vam-google/repos","events_url":"https://api.github.com/users/vam-google/events{/privacy}","received_events_url":"https://api.github.com/users/vam-google/received_events","type":"User","site_admin":false},"body":"Looks like bad formatting (tab vs spaces)","created_at":"2019-01-03T20:01:04Z","updated_at":"2019-01-03T20:01:21Z","html_url":"https://github.com/bazelbuild/rules_go/pull/1870#discussion_r245116630","pull_request_url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1870","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/rules_go/pulls/comments/245116630"},"html":{"href":"https://github.com/bazelbuild/rules_go/pull/1870#discussion_r245116630"},"pull_request":{"href":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1870"}}},"pull_request":{"url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1870","id":240593745,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTkzNzQ1","html_url":"https://github.com/bazelbuild/rules_go/pull/1870","diff_url":"https://github.com/bazelbuild/rules_go/pull/1870.diff","patch_url":"https://github.com/bazelbuild/rules_go/pull/1870.patch","issue_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1870","number":1870,"state":"open","locked":false,"title":"go_proto_library: support proxy proto_library","user":{"login":"jayconrod","id":164791,"node_id":"MDQ6VXNlcjE2NDc5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/164791?v=4","gravatar_id":"","url":"https://api.github.com/users/jayconrod","html_url":"https://github.com/jayconrod","followers_url":"https://api.github.com/users/jayconrod/followers","following_url":"https://api.github.com/users/jayconrod/following{/other_user}","gists_url":"https://api.github.com/users/jayconrod/gists{/gist_id}","starred_url":"https://api.github.com/users/jayconrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayconrod/subscriptions","organizations_url":"https://api.github.com/users/jayconrod/orgs","repos_url":"https://api.github.com/users/jayconrod/repos","events_url":"https://api.github.com/users/jayconrod/events{/privacy}","received_events_url":"https://api.github.com/users/jayconrod/received_events","type":"User","site_admin":false},"body":"In some repositories, a proto_library target will be declared for each\r\n.proto file, even for .proto files in the same package. A\r\nproto_library target with deps and no srcs may be used to combine\r\nseveral proto_library rules.\r\n\r\nWith this change, go_proto_library treats a \"proxy\" proto_library as\r\nif it contained the direct srcs of its deps.\r\n\r\nFixes #1857","created_at":"2018-12-21T22:48:56Z","updated_at":"2019-01-03T20:01:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7781c9ecf7a73e5618789ec8d2d61d3896a88b3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ianthehat","id":858832,"node_id":"MDQ6VXNlcjg1ODgzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/858832?v=4","gravatar_id":"","url":"https://api.github.com/users/ianthehat","html_url":"https://github.com/ianthehat","followers_url":"https://api.github.com/users/ianthehat/followers","following_url":"https://api.github.com/users/ianthehat/following{/other_user}","gists_url":"https://api.github.com/users/ianthehat/gists{/gist_id}","starred_url":"https://api.github.com/users/ianthehat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianthehat/subscriptions","organizations_url":"https://api.github.com/users/ianthehat/orgs","repos_url":"https://api.github.com/users/ianthehat/repos","events_url":"https://api.github.com/users/ianthehat/events{/privacy}","received_events_url":"https://api.github.com/users/ianthehat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":342134177,"node_id":"MDU6TGFiZWwzNDIxMzQxNzc=","url":"https://api.github.com/repos/bazelbuild/rules_go/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1870/commits","review_comments_url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1870/comments","review_comment_url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1870/comments","statuses_url":"https://api.github.com/repos/bazelbuild/rules_go/statuses/980151cfd162458446025f5425f1bfe2cd7a491e","head":{"label":"jayconrod:fix-proto-proxy","ref":"fix-proto-proxy","sha":"980151cfd162458446025f5425f1bfe2cd7a491e","user":{"login":"jayconrod","id":164791,"node_id":"MDQ6VXNlcjE2NDc5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/164791?v=4","gravatar_id":"","url":"https://api.github.com/users/jayconrod","html_url":"https://github.com/jayconrod","followers_url":"https://api.github.com/users/jayconrod/followers","following_url":"https://api.github.com/users/jayconrod/following{/other_user}","gists_url":"https://api.github.com/users/jayconrod/gists{/gist_id}","starred_url":"https://api.github.com/users/jayconrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayconrod/subscriptions","organizations_url":"https://api.github.com/users/jayconrod/orgs","repos_url":"https://api.github.com/users/jayconrod/repos","events_url":"https://api.github.com/users/jayconrod/events{/privacy}","received_events_url":"https://api.github.com/users/jayconrod/received_events","type":"User","site_admin":false},"repo":{"id":81984436,"node_id":"MDEwOlJlcG9zaXRvcnk4MTk4NDQzNg==","name":"rules_go","full_name":"jayconrod/rules_go","private":false,"owner":{"login":"jayconrod","id":164791,"node_id":"MDQ6VXNlcjE2NDc5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/164791?v=4","gravatar_id":"","url":"https://api.github.com/users/jayconrod","html_url":"https://github.com/jayconrod","followers_url":"https://api.github.com/users/jayconrod/followers","following_url":"https://api.github.com/users/jayconrod/following{/other_user}","gists_url":"https://api.github.com/users/jayconrod/gists{/gist_id}","starred_url":"https://api.github.com/users/jayconrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayconrod/subscriptions","organizations_url":"https://api.github.com/users/jayconrod/orgs","repos_url":"https://api.github.com/users/jayconrod/repos","events_url":"https://api.github.com/users/jayconrod/events{/privacy}","received_events_url":"https://api.github.com/users/jayconrod/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jayconrod/rules_go","description":"Go rules for Bazel","fork":true,"url":"https://api.github.com/repos/jayconrod/rules_go","forks_url":"https://api.github.com/repos/jayconrod/rules_go/forks","keys_url":"https://api.github.com/repos/jayconrod/rules_go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayconrod/rules_go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayconrod/rules_go/teams","hooks_url":"https://api.github.com/repos/jayconrod/rules_go/hooks","issue_events_url":"https://api.github.com/repos/jayconrod/rules_go/issues/events{/number}","events_url":"https://api.github.com/repos/jayconrod/rules_go/events","assignees_url":"https://api.github.com/repos/jayconrod/rules_go/assignees{/user}","branches_url":"https://api.github.com/repos/jayconrod/rules_go/branches{/branch}","tags_url":"https://api.github.com/repos/jayconrod/rules_go/tags","blobs_url":"https://api.github.com/repos/jayconrod/rules_go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayconrod/rules_go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayconrod/rules_go/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayconrod/rules_go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayconrod/rules_go/statuses/{sha}","languages_url":"https://api.github.com/repos/jayconrod/rules_go/languages","stargazers_url":"https://api.github.com/repos/jayconrod/rules_go/stargazers","contributors_url":"https://api.github.com/repos/jayconrod/rules_go/contributors","subscribers_url":"https://api.github.com/repos/jayconrod/rules_go/subscribers","subscription_url":"https://api.github.com/repos/jayconrod/rules_go/subscription","commits_url":"https://api.github.com/repos/jayconrod/rules_go/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayconrod/rules_go/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayconrod/rules_go/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayconrod/rules_go/issues/comments{/number}","contents_url":"https://api.github.com/repos/jayconrod/rules_go/contents/{+path}","compare_url":"https://api.github.com/repos/jayconrod/rules_go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayconrod/rules_go/merges","archive_url":"https://api.github.com/repos/jayconrod/rules_go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayconrod/rules_go/downloads","issues_url":"https://api.github.com/repos/jayconrod/rules_go/issues{/number}","pulls_url":"https://api.github.com/repos/jayconrod/rules_go/pulls{/number}","milestones_url":"https://api.github.com/repos/jayconrod/rules_go/milestones{/number}","notifications_url":"https://api.github.com/repos/jayconrod/rules_go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayconrod/rules_go/labels{/name}","releases_url":"https://api.github.com/repos/jayconrod/rules_go/releases{/id}","deployments_url":"https://api.github.com/repos/jayconrod/rules_go/deployments","created_at":"2017-02-14T20:09:34Z","updated_at":"2017-02-14T20:09:36Z","pushed_at":"2019-01-03T19:31:39Z","git_url":"git://github.com/jayconrod/rules_go.git","ssh_url":"git@github.com:jayconrod/rules_go.git","clone_url":"https://github.com/jayconrod/rules_go.git","svn_url":"https://github.com/jayconrod/rules_go","homepage":null,"size":3452,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazelbuild:master","ref":"master","sha":"4bc9ee15d499890d4e31b8208a125db3c313ad58","user":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":53954979,"node_id":"MDEwOlJlcG9zaXRvcnk1Mzk1NDk3OQ==","name":"rules_go","full_name":"bazelbuild/rules_go","private":false,"owner":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bazelbuild/rules_go","description":"Go rules for Bazel","fork":false,"url":"https://api.github.com/repos/bazelbuild/rules_go","forks_url":"https://api.github.com/repos/bazelbuild/rules_go/forks","keys_url":"https://api.github.com/repos/bazelbuild/rules_go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazelbuild/rules_go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazelbuild/rules_go/teams","hooks_url":"https://api.github.com/repos/bazelbuild/rules_go/hooks","issue_events_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/events{/number}","events_url":"https://api.github.com/repos/bazelbuild/rules_go/events","assignees_url":"https://api.github.com/repos/bazelbuild/rules_go/assignees{/user}","branches_url":"https://api.github.com/repos/bazelbuild/rules_go/branches{/branch}","tags_url":"https://api.github.com/repos/bazelbuild/rules_go/tags","blobs_url":"https://api.github.com/repos/bazelbuild/rules_go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazelbuild/rules_go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazelbuild/rules_go/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazelbuild/rules_go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazelbuild/rules_go/statuses/{sha}","languages_url":"https://api.github.com/repos/bazelbuild/rules_go/languages","stargazers_url":"https://api.github.com/repos/bazelbuild/rules_go/stargazers","contributors_url":"https://api.github.com/repos/bazelbuild/rules_go/contributors","subscribers_url":"https://api.github.com/repos/bazelbuild/rules_go/subscribers","subscription_url":"https://api.github.com/repos/bazelbuild/rules_go/subscription","commits_url":"https://api.github.com/repos/bazelbuild/rules_go/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazelbuild/rules_go/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazelbuild/rules_go/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazelbuild/rules_go/contents/{+path}","compare_url":"https://api.github.com/repos/bazelbuild/rules_go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazelbuild/rules_go/merges","archive_url":"https://api.github.com/repos/bazelbuild/rules_go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazelbuild/rules_go/downloads","issues_url":"https://api.github.com/repos/bazelbuild/rules_go/issues{/number}","pulls_url":"https://api.github.com/repos/bazelbuild/rules_go/pulls{/number}","milestones_url":"https://api.github.com/repos/bazelbuild/rules_go/milestones{/number}","notifications_url":"https://api.github.com/repos/bazelbuild/rules_go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazelbuild/rules_go/labels{/name}","releases_url":"https://api.github.com/repos/bazelbuild/rules_go/releases{/id}","deployments_url":"https://api.github.com/repos/bazelbuild/rules_go/deployments","created_at":"2016-03-15T15:15:14Z","updated_at":"2019-01-03T17:21:38Z","pushed_at":"2019-01-03T19:31:55Z","git_url":"git://github.com/bazelbuild/rules_go.git","ssh_url":"git@github.com:bazelbuild/rules_go.git","clone_url":"https://github.com/bazelbuild/rules_go.git","svn_url":"https://github.com/bazelbuild/rules_go","homepage":null,"size":3598,"stargazers_count":408,"watchers_count":408,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":236,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":236,"open_issues":121,"watchers":408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1870"},"html":{"href":"https://github.com/bazelbuild/rules_go/pull/1870"},"issue":{"href":"https://api.github.com/repos/bazelbuild/rules_go/issues/1870"},"comments":{"href":"https://api.github.com/repos/bazelbuild/rules_go/issues/1870/comments"},"review_comments":{"href":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1870/comments"},"review_comment":{"href":"https://api.github.com/repos/bazelbuild/rules_go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1870/commits"},"statuses":{"href":"https://api.github.com/repos/bazelbuild/rules_go/statuses/980151cfd162458446025f5425f1bfe2cd7a491e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vam-google"}}