{"action":"created","comment":{"url":"https://api.github.com/repos/freenas/freenas/pulls/comments/231122271","pull_request_review_id":171542008,"id":231122271,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTEyMjI3MQ==","diff_hunk":"@@ -0,0 +1,21 @@\n+#\n+# SMB.CONF(5)\t\tThe configuration file for the Samba suite \n+#\n+<%\n+    \"\"\"\n+    The username map is required for proper support of microsoft accounts\n+    that are also email addresses. See SMB.CONF(5) for more details.\n+    \"\"\"\n+    users = middleware.call_sync('datastore.query', 'account.bsdusers', [","path":"src/middlewared/middlewared/etc_files/local/smbusername.map","position":9,"original_position":9,"commit_id":"73c7598c7a331e5091d27cfc59a65bc51707dc46","original_commit_id":"73c7598c7a331e5091d27cfc59a65bc51707dc46","user":{"login":"william-gr","id":56250,"node_id":"MDQ6VXNlcjU2MjUw","avatar_url":"https://avatars0.githubusercontent.com/u/56250?v=4","gravatar_id":"","url":"https://api.github.com/users/william-gr","html_url":"https://github.com/william-gr","followers_url":"https://api.github.com/users/william-gr/followers","following_url":"https://api.github.com/users/william-gr/following{/other_user}","gists_url":"https://api.github.com/users/william-gr/gists{/gist_id}","starred_url":"https://api.github.com/users/william-gr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william-gr/subscriptions","organizations_url":"https://api.github.com/users/william-gr/orgs","repos_url":"https://api.github.com/users/william-gr/repos","events_url":"https://api.github.com/users/william-gr/events{/privacy}","received_events_url":"https://api.github.com/users/william-gr/received_events","type":"User","site_admin":false},"body":"Shall we use user.query instead of datastore?","created_at":"2018-11-06T13:32:45Z","updated_at":"2018-11-06T13:49:20Z","html_url":"https://github.com/freenas/freenas/pull/1972#discussion_r231122271","pull_request_url":"https://api.github.com/repos/freenas/freenas/pulls/1972","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/freenas/freenas/pulls/comments/231122271"},"html":{"href":"https://github.com/freenas/freenas/pull/1972#discussion_r231122271"},"pull_request":{"href":"https://api.github.com/repos/freenas/freenas/pulls/1972"}}},"pull_request":{"url":"https://api.github.com/repos/freenas/freenas/pulls/1972","id":225945289,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTQ1Mjg5","html_url":"https://github.com/freenas/freenas/pull/1972","diff_url":"https://github.com/freenas/freenas/pull/1972.diff","patch_url":"https://github.com/freenas/freenas/pull/1972.patch","issue_url":"https://api.github.com/repos/freenas/freenas/issues/1972","number":1972,"state":"open","locked":false,"title":"tkt-35813: Move smb4.conf to etc_files","user":{"login":"anodos325","id":21041515,"node_id":"MDQ6VXNlcjIxMDQxNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/21041515?v=4","gravatar_id":"","url":"https://api.github.com/users/anodos325","html_url":"https://github.com/anodos325","followers_url":"https://api.github.com/users/anodos325/followers","following_url":"https://api.github.com/users/anodos325/following{/other_user}","gists_url":"https://api.github.com/users/anodos325/gists{/gist_id}","starred_url":"https://api.github.com/users/anodos325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anodos325/subscriptions","organizations_url":"https://api.github.com/users/anodos325/orgs","repos_url":"https://api.github.com/users/anodos325/repos","events_url":"https://api.github.com/users/anodos325/events{/privacy}","received_events_url":"https://api.github.com/users/anodos325/received_events","type":"User","site_admin":false},"body":"A couple of changes. Split smb4.conf into two files:\r\n- Global parameters. These require the service to be restarted\r\n- Shares. These changes can be accomplished by reloading the config.\r\nThis allows us to add / modify shares without having to fully regenerate the\r\ndirectory service config information.\r\n\r\ngenerate_smb4_conf.py was left in place because of its role in HA failover, but ix-pre-samba and ix-post-samba were removed. The logic for storing local domain SID in DB is already present in generate_smb4_conf.py. Hence most of this is redundant. Most places that were calling \"ix-pre-samba start\" now accomplish mostly the same via \"midclt call etc.generate smb\". This is first step in untangling these scripts.","created_at":"2018-10-26T00:41:15Z","updated_at":"2018-11-06T13:49:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8859741ecdc2e5cf9ecc88ff61797a13e3ba33cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/freenas/freenas/pulls/1972/commits","review_comments_url":"https://api.github.com/repos/freenas/freenas/pulls/1972/comments","review_comment_url":"https://api.github.com/repos/freenas/freenas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freenas/freenas/issues/1972/comments","statuses_url":"https://api.github.com/repos/freenas/freenas/statuses/73c7598c7a331e5091d27cfc59a65bc51707dc46","head":{"label":"freenas:FIX-35813-MASTER","ref":"FIX-35813-MASTER","sha":"73c7598c7a331e5091d27cfc59a65bc51707dc46","user":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"repo":{"id":8627760,"node_id":"MDEwOlJlcG9zaXRvcnk4NjI3NzYw","name":"freenas","full_name":"freenas/freenas","private":false,"owner":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freenas/freenas","description":"FreeNAS Git Repository","fork":false,"url":"https://api.github.com/repos/freenas/freenas","forks_url":"https://api.github.com/repos/freenas/freenas/forks","keys_url":"https://api.github.com/repos/freenas/freenas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenas/freenas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenas/freenas/teams","hooks_url":"https://api.github.com/repos/freenas/freenas/hooks","issue_events_url":"https://api.github.com/repos/freenas/freenas/issues/events{/number}","events_url":"https://api.github.com/repos/freenas/freenas/events","assignees_url":"https://api.github.com/repos/freenas/freenas/assignees{/user}","branches_url":"https://api.github.com/repos/freenas/freenas/branches{/branch}","tags_url":"https://api.github.com/repos/freenas/freenas/tags","blobs_url":"https://api.github.com/repos/freenas/freenas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenas/freenas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenas/freenas/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenas/freenas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenas/freenas/statuses/{sha}","languages_url":"https://api.github.com/repos/freenas/freenas/languages","stargazers_url":"https://api.github.com/repos/freenas/freenas/stargazers","contributors_url":"https://api.github.com/repos/freenas/freenas/contributors","subscribers_url":"https://api.github.com/repos/freenas/freenas/subscribers","subscription_url":"https://api.github.com/repos/freenas/freenas/subscription","commits_url":"https://api.github.com/repos/freenas/freenas/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenas/freenas/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenas/freenas/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenas/freenas/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenas/freenas/contents/{+path}","compare_url":"https://api.github.com/repos/freenas/freenas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenas/freenas/merges","archive_url":"https://api.github.com/repos/freenas/freenas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenas/freenas/downloads","issues_url":"https://api.github.com/repos/freenas/freenas/issues{/number}","pulls_url":"https://api.github.com/repos/freenas/freenas/pulls{/number}","milestones_url":"https://api.github.com/repos/freenas/freenas/milestones{/number}","notifications_url":"https://api.github.com/repos/freenas/freenas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenas/freenas/labels{/name}","releases_url":"https://api.github.com/repos/freenas/freenas/releases{/id}","deployments_url":"https://api.github.com/repos/freenas/freenas/deployments","created_at":"2013-03-07T13:23:20Z","updated_at":"2018-11-06T13:28:41Z","pushed_at":"2018-11-06T13:33:31Z","git_url":"git://github.com/freenas/freenas.git","ssh_url":"git@github.com:freenas/freenas.git","clone_url":"https://github.com/freenas/freenas.git","svn_url":"https://github.com/freenas/freenas","homepage":"http://www.freenas.org","size":530942,"stargazers_count":1062,"watchers_count":1062,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":299,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":299,"open_issues":8,"watchers":1062,"default_branch":"master"}},"base":{"label":"freenas:master","ref":"master","sha":"3a107408179dba683af61c9b196de8ae16bf17c7","user":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"repo":{"id":8627760,"node_id":"MDEwOlJlcG9zaXRvcnk4NjI3NzYw","name":"freenas","full_name":"freenas/freenas","private":false,"owner":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freenas/freenas","description":"FreeNAS Git Repository","fork":false,"url":"https://api.github.com/repos/freenas/freenas","forks_url":"https://api.github.com/repos/freenas/freenas/forks","keys_url":"https://api.github.com/repos/freenas/freenas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenas/freenas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenas/freenas/teams","hooks_url":"https://api.github.com/repos/freenas/freenas/hooks","issue_events_url":"https://api.github.com/repos/freenas/freenas/issues/events{/number}","events_url":"https://api.github.com/repos/freenas/freenas/events","assignees_url":"https://api.github.com/repos/freenas/freenas/assignees{/user}","branches_url":"https://api.github.com/repos/freenas/freenas/branches{/branch}","tags_url":"https://api.github.com/repos/freenas/freenas/tags","blobs_url":"https://api.github.com/repos/freenas/freenas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenas/freenas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenas/freenas/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenas/freenas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenas/freenas/statuses/{sha}","languages_url":"https://api.github.com/repos/freenas/freenas/languages","stargazers_url":"https://api.github.com/repos/freenas/freenas/stargazers","contributors_url":"https://api.github.com/repos/freenas/freenas/contributors","subscribers_url":"https://api.github.com/repos/freenas/freenas/subscribers","subscription_url":"https://api.github.com/repos/freenas/freenas/subscription","commits_url":"https://api.github.com/repos/freenas/freenas/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenas/freenas/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenas/freenas/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenas/freenas/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenas/freenas/contents/{+path}","compare_url":"https://api.github.com/repos/freenas/freenas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenas/freenas/merges","archive_url":"https://api.github.com/repos/freenas/freenas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenas/freenas/downloads","issues_url":"https://api.github.com/repos/freenas/freenas/issues{/number}","pulls_url":"https://api.github.com/repos/freenas/freenas/pulls{/number}","milestones_url":"https://api.github.com/repos/freenas/freenas/milestones{/number}","notifications_url":"https://api.github.com/repos/freenas/freenas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenas/freenas/labels{/name}","releases_url":"https://api.github.com/repos/freenas/freenas/releases{/id}","deployments_url":"https://api.github.com/repos/freenas/freenas/deployments","created_at":"2013-03-07T13:23:20Z","updated_at":"2018-11-06T13:28:41Z","pushed_at":"2018-11-06T13:33:31Z","git_url":"git://github.com/freenas/freenas.git","ssh_url":"git@github.com:freenas/freenas.git","clone_url":"https://github.com/freenas/freenas.git","svn_url":"https://github.com/freenas/freenas","homepage":"http://www.freenas.org","size":530942,"stargazers_count":1062,"watchers_count":1062,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":299,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":299,"open_issues":8,"watchers":1062,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freenas/freenas/pulls/1972"},"html":{"href":"https://github.com/freenas/freenas/pull/1972"},"issue":{"href":"https://api.github.com/repos/freenas/freenas/issues/1972"},"comments":{"href":"https://api.github.com/repos/freenas/freenas/issues/1972/comments"},"review_comments":{"href":"https://api.github.com/repos/freenas/freenas/pulls/1972/comments"},"review_comment":{"href":"https://api.github.com/repos/freenas/freenas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freenas/freenas/pulls/1972/commits"},"statuses":{"href":"https://api.github.com/repos/freenas/freenas/statuses/73c7598c7a331e5091d27cfc59a65bc51707dc46"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"william-gr"}}