{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/console/pulls/comments/189923092","pull_request_review_id":122195652,"id":189923092,"diff_hunk":"@@ -133,9 +207,18 @@ const TLSSettings = props => <span>\n const RouteDetails: React.SFC<RoutesDetailsProps> = ({obj: route}) => <React.Fragment>\n   <div className=\"co-m-pane__body\">\n     <ResourceSummary resource={route} showPodSelector={false} showNodeSelector={false}>\n+      <dt>Hostname</dt>\n+      <dd>{route.spec.host}</dd>\n+      <dt>Status</dt>\n+      <dd>\n+        <RouteStatus obj={route} />\n+        <RouteWarnings obj={route} />\n+      </dd>\n+      <dt>Location</dt>\n+      <dd><RouteLocation obj={route} /></dd>\n       <dt>Path</dt>\n-      <dd>{route.spec.path || '-'}</dd>\n-      <dt>{route.spec.to.kind || 'Routes To'}</dt>\n+      {route.spec.path ? <dd>{route.spec.path}</dd> : <dd><em>none</em></dd>}\n+      <dt>{_.get(route, 'spec.to.kind') || 'Routes To'}</dt>\n       <dd><ResourceLink kind=\"Service\" name={route.spec.to.name} title={route.spec.to.name} /></dd>","path":"frontend/public/components/routes.tsx","position":null,"original_position":134,"commit_id":"a5910bca6737dafb83bed8760a074eb9bb869952","original_commit_id":"2f1b1ef4f8ad49efcbadd8105a5287c034acb400","user":{"login":"dtaylor113","id":12733153,"avatar_url":"https://avatars2.githubusercontent.com/u/12733153?v=4","gravatar_id":"","url":"https://api.github.com/users/dtaylor113","html_url":"https://github.com/dtaylor113","followers_url":"https://api.github.com/users/dtaylor113/followers","following_url":"https://api.github.com/users/dtaylor113/following{/other_user}","gists_url":"https://api.github.com/users/dtaylor113/gists{/gist_id}","starred_url":"https://api.github.com/users/dtaylor113/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtaylor113/subscriptions","organizations_url":"https://api.github.com/users/dtaylor113/orgs","repos_url":"https://api.github.com/users/dtaylor113/repos","events_url":"https://api.github.com/users/dtaylor113/events{/privacy}","received_events_url":"https://api.github.com/users/dtaylor113/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-05-22T14:29:21Z","updated_at":"2018-05-22T14:29:21Z","html_url":"https://github.com/openshift/console/pull/27#discussion_r189923092","pull_request_url":"https://api.github.com/repos/openshift/console/pulls/27","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/comments/189923092"},"html":{"href":"https://github.com/openshift/console/pull/27#discussion_r189923092"},"pull_request":{"href":"https://api.github.com/repos/openshift/console/pulls/27"}},"in_reply_to_id":189889123},"pull_request":{"url":"https://api.github.com/repos/openshift/console/pulls/27","id":188505015,"html_url":"https://github.com/openshift/console/pull/27","diff_url":"https://github.com/openshift/console/pull/27.diff","patch_url":"https://github.com/openshift/console/pull/27.patch","issue_url":"https://api.github.com/repos/openshift/console/issues/27","number":27,"state":"open","locked":false,"title":"Route Status and Warnings","user":{"login":"dtaylor113","id":12733153,"avatar_url":"https://avatars2.githubusercontent.com/u/12733153?v=4","gravatar_id":"","url":"https://api.github.com/users/dtaylor113","html_url":"https://github.com/dtaylor113","followers_url":"https://api.github.com/users/dtaylor113/followers","following_url":"https://api.github.com/users/dtaylor113/following{/other_user}","gists_url":"https://api.github.com/users/dtaylor113/gists{/gist_id}","starred_url":"https://api.github.com/users/dtaylor113/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtaylor113/subscriptions","organizations_url":"https://api.github.com/users/dtaylor113/orgs","repos_url":"https://api.github.com/users/dtaylor113/repos","events_url":"https://api.github.com/users/dtaylor113/events{/privacy}","received_events_url":"https://api.github.com/users/dtaylor113/received_events","type":"User","site_admin":false},"body":"**Route Listing Page**\r\n- Changed col. header 'Hostname' to 'Location'\r\n- Removed 'Target Port' & 'TLS Termination' columns\r\n- Added 'Status' column\r\n![image](https://user-images.githubusercontent.com/12733153/40248983-9dbb9af0-5a9f-11e8-81e7-90880dd2e471.png)\r\n\r\n**Route Details Page**\r\n- Added 'Hostname', 'Status', and 'Location':\r\n![image](https://user-images.githubusercontent.com/12733153/40249015-ba44dc5e-5a9f-11e8-84c4-c282e9c11c9a.png)\r\n---\r\n![image](https://user-images.githubusercontent.com/12733153/40249030-c4816700-5a9f-11e8-95fa-7cc26933f4a3.png)\r\n---\r\n![image](https://user-images.githubusercontent.com/12733153/40249035-c85597fc-5a9f-11e8-9828-7e929635b308.png)\r\n---\r\n\r\n\r\n\r\n\r\nAddresses:  https://jira.coreos.com/browse/CONSOLE-418","created_at":"2018-05-16T17:24:26Z","updated_at":"2018-05-22T14:29:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8461fe4c9f5346409dc58c101df2b7dfee26166a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kans","id":986627,"avatar_url":"https://avatars3.githubusercontent.com/u/986627?v=4","gravatar_id":"","url":"https://api.github.com/users/kans","html_url":"https://github.com/kans","followers_url":"https://api.github.com/users/kans/followers","following_url":"https://api.github.com/users/kans/following{/other_user}","gists_url":"https://api.github.com/users/kans/gists{/gist_id}","starred_url":"https://api.github.com/users/kans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kans/subscriptions","organizations_url":"https://api.github.com/users/kans/orgs","repos_url":"https://api.github.com/users/kans/repos","events_url":"https://api.github.com/users/kans/events{/privacy}","received_events_url":"https://api.github.com/users/kans/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":926924366,"url":"https://api.github.com/repos/openshift/console/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/console/pulls/27/commits","review_comments_url":"https://api.github.com/repos/openshift/console/pulls/27/comments","review_comment_url":"https://api.github.com/repos/openshift/console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/console/issues/27/comments","statuses_url":"https://api.github.com/repos/openshift/console/statuses/a5910bca6737dafb83bed8760a074eb9bb869952","head":{"label":"dtaylor113:route-pages-updates","ref":"route-pages-updates","sha":"a5910bca6737dafb83bed8760a074eb9bb869952","user":{"login":"dtaylor113","id":12733153,"avatar_url":"https://avatars2.githubusercontent.com/u/12733153?v=4","gravatar_id":"","url":"https://api.github.com/users/dtaylor113","html_url":"https://github.com/dtaylor113","followers_url":"https://api.github.com/users/dtaylor113/followers","following_url":"https://api.github.com/users/dtaylor113/following{/other_user}","gists_url":"https://api.github.com/users/dtaylor113/gists{/gist_id}","starred_url":"https://api.github.com/users/dtaylor113/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtaylor113/subscriptions","organizations_url":"https://api.github.com/users/dtaylor113/orgs","repos_url":"https://api.github.com/users/dtaylor113/repos","events_url":"https://api.github.com/users/dtaylor113/events{/privacy}","received_events_url":"https://api.github.com/users/dtaylor113/received_events","type":"User","site_admin":false},"repo":{"id":133376742,"name":"console","full_name":"dtaylor113/console","owner":{"login":"dtaylor113","id":12733153,"avatar_url":"https://avatars2.githubusercontent.com/u/12733153?v=4","gravatar_id":"","url":"https://api.github.com/users/dtaylor113","html_url":"https://github.com/dtaylor113","followers_url":"https://api.github.com/users/dtaylor113/followers","following_url":"https://api.github.com/users/dtaylor113/following{/other_user}","gists_url":"https://api.github.com/users/dtaylor113/gists{/gist_id}","starred_url":"https://api.github.com/users/dtaylor113/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtaylor113/subscriptions","organizations_url":"https://api.github.com/users/dtaylor113/orgs","repos_url":"https://api.github.com/users/dtaylor113/repos","events_url":"https://api.github.com/users/dtaylor113/events{/privacy}","received_events_url":"https://api.github.com/users/dtaylor113/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtaylor113/console","description":"OpenShift Cluster Console UI","fork":true,"url":"https://api.github.com/repos/dtaylor113/console","forks_url":"https://api.github.com/repos/dtaylor113/console/forks","keys_url":"https://api.github.com/repos/dtaylor113/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtaylor113/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtaylor113/console/teams","hooks_url":"https://api.github.com/repos/dtaylor113/console/hooks","issue_events_url":"https://api.github.com/repos/dtaylor113/console/issues/events{/number}","events_url":"https://api.github.com/repos/dtaylor113/console/events","assignees_url":"https://api.github.com/repos/dtaylor113/console/assignees{/user}","branches_url":"https://api.github.com/repos/dtaylor113/console/branches{/branch}","tags_url":"https://api.github.com/repos/dtaylor113/console/tags","blobs_url":"https://api.github.com/repos/dtaylor113/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtaylor113/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtaylor113/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtaylor113/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtaylor113/console/statuses/{sha}","languages_url":"https://api.github.com/repos/dtaylor113/console/languages","stargazers_url":"https://api.github.com/repos/dtaylor113/console/stargazers","contributors_url":"https://api.github.com/repos/dtaylor113/console/contributors","subscribers_url":"https://api.github.com/repos/dtaylor113/console/subscribers","subscription_url":"https://api.github.com/repos/dtaylor113/console/subscription","commits_url":"https://api.github.com/repos/dtaylor113/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtaylor113/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtaylor113/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtaylor113/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtaylor113/console/contents/{+path}","compare_url":"https://api.github.com/repos/dtaylor113/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtaylor113/console/merges","archive_url":"https://api.github.com/repos/dtaylor113/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtaylor113/console/downloads","issues_url":"https://api.github.com/repos/dtaylor113/console/issues{/number}","pulls_url":"https://api.github.com/repos/dtaylor113/console/pulls{/number}","milestones_url":"https://api.github.com/repos/dtaylor113/console/milestones{/number}","notifications_url":"https://api.github.com/repos/dtaylor113/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtaylor113/console/labels{/name}","releases_url":"https://api.github.com/repos/dtaylor113/console/releases{/id}","deployments_url":"https://api.github.com/repos/dtaylor113/console/deployments","created_at":"2018-05-14T14:48:07Z","updated_at":"2018-05-14T14:48:11Z","pushed_at":"2018-05-22T14:24:59Z","git_url":"git://github.com/dtaylor113/console.git","ssh_url":"git@github.com:dtaylor113/console.git","clone_url":"https://github.com/dtaylor113/console.git","svn_url":"https://github.com/dtaylor113/console","homepage":"","size":86256,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"9c80cb314e89a36f92464d163d499806cf03ad79","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":129436456,"name":"console","full_name":"openshift/console","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/console","description":"OpenShift Cluster Console UI","fork":false,"url":"https://api.github.com/repos/openshift/console","forks_url":"https://api.github.com/repos/openshift/console/forks","keys_url":"https://api.github.com/repos/openshift/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/console/teams","hooks_url":"https://api.github.com/repos/openshift/console/hooks","issue_events_url":"https://api.github.com/repos/openshift/console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/console/events","assignees_url":"https://api.github.com/repos/openshift/console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/console/tags","blobs_url":"https://api.github.com/repos/openshift/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/console/languages","stargazers_url":"https://api.github.com/repos/openshift/console/stargazers","contributors_url":"https://api.github.com/repos/openshift/console/contributors","subscribers_url":"https://api.github.com/repos/openshift/console/subscribers","subscription_url":"https://api.github.com/repos/openshift/console/subscription","commits_url":"https://api.github.com/repos/openshift/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/console/merges","archive_url":"https://api.github.com/repos/openshift/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/console/downloads","issues_url":"https://api.github.com/repos/openshift/console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/console/deployments","created_at":"2018-04-13T17:54:59Z","updated_at":"2018-05-21T22:50:07Z","pushed_at":"2018-05-22T14:25:01Z","git_url":"git://github.com/openshift/console.git","ssh_url":"git@github.com:openshift/console.git","clone_url":"https://github.com/openshift/console.git","svn_url":"https://github.com/openshift/console","homepage":"","size":86266,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":17,"open_issues":19,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/27"},"html":{"href":"https://github.com/openshift/console/pull/27"},"issue":{"href":"https://api.github.com/repos/openshift/console/issues/27"},"comments":{"href":"https://api.github.com/repos/openshift/console/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/console/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/console/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/console/statuses/a5910bca6737dafb83bed8760a074eb9bb869952"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dtaylor113"}}