{"action":"opened","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/13604","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-native","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/13604/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/13604/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/13604/events","html_url":"https://github.com/mapbox/mapbox-gl-native/issues/13604","id":392372528,"node_id":"MDU6SXNzdWUzOTIzNzI1Mjg=","number":13604,"title":"Rename MGLStyle.enablePlacementTransitions","user":{"login":"1ec5","id":1231218,"node_id":"MDQ6VXNlcjEyMzEyMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1231218?v=4","gravatar_id":"","url":"https://api.github.com/users/1ec5","html_url":"https://github.com/1ec5","followers_url":"https://api.github.com/users/1ec5/followers","following_url":"https://api.github.com/users/1ec5/following{/other_user}","gists_url":"https://api.github.com/users/1ec5/gists{/gist_id}","starred_url":"https://api.github.com/users/1ec5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1ec5/subscriptions","organizations_url":"https://api.github.com/users/1ec5/orgs","repos_url":"https://api.github.com/users/1ec5/repos","events_url":"https://api.github.com/users/1ec5/events{/privacy}","received_events_url":"https://api.github.com/users/1ec5/received_events","type":"User","site_admin":false},"labels":[{"id":92400707,"node_id":"MDU6TGFiZWw5MjQwMDcwNw==","url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/iOS","name":"iOS","color":"000000","default":false},{"id":142869898,"node_id":"MDU6TGFiZWwxNDI4Njk4OTg=","url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/macOS","name":"macOS","color":"000000","default":false},{"id":425273839,"node_id":"MDU6TGFiZWw0MjUyNzM4Mzk=","url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/runtime%20styling","name":"runtime styling","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/139","html_url":"https://github.com/mapbox/mapbox-gl-native/milestone/139","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/139/labels","id":3911527,"node_id":"MDk6TWlsZXN0b25lMzkxMTUyNw==","number":139,"title":"release-java","description":null,"creator":{"login":"1ec5","id":1231218,"node_id":"MDQ6VXNlcjEyMzEyMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1231218?v=4","gravatar_id":"","url":"https://api.github.com/users/1ec5","html_url":"https://github.com/1ec5","followers_url":"https://api.github.com/users/1ec5/followers","following_url":"https://api.github.com/users/1ec5/following{/other_user}","gists_url":"https://api.github.com/users/1ec5/gists{/gist_id}","starred_url":"https://api.github.com/users/1ec5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1ec5/subscriptions","organizations_url":"https://api.github.com/users/1ec5/orgs","repos_url":"https://api.github.com/users/1ec5/repos","events_url":"https://api.github.com/users/1ec5/events{/privacy}","received_events_url":"https://api.github.com/users/1ec5/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2018-12-18T23:02:26Z","updated_at":"2018-12-18T23:02:32Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-12-18T23:02:32Z","updated_at":"2018-12-18T23:02:32Z","closed_at":null,"author_association":"MEMBER","body":"#13565 added an `MGLStyle.enablePlacementTransitions` property that should be renamed to either `placementTransitionsEnabled` or preferably `performsPlacementTransitions`. `enablePlacementTransitions` is problematic because it looks like an action method:\r\n\r\n```objc\r\n// Initial state: placement transitions are disabled.\r\n[style enablePlacementTransitions];\r\n// Expected behavior: placement transitions are enabled.\r\n// Actual behavior: nothing changed; return value discarded.\r\n```\r\n\r\nIn this case, `enablesPlacementTransitions` would also be problematic because it’s the developer, not the style, that enables them.\r\n\r\n/cc @fabian-guerra @julianrex"}}
{"actor":{"display_login":"1ec5"}}