{"action":"created","issue":{"url":"https://api.github.com/repos/SO-Close-Vote-Reviewers/UserScripts/issues/133","repository_url":"https://api.github.com/repos/SO-Close-Vote-Reviewers/UserScripts","labels_url":"https://api.github.com/repos/SO-Close-Vote-Reviewers/UserScripts/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/SO-Close-Vote-Reviewers/UserScripts/issues/133/comments","events_url":"https://api.github.com/repos/SO-Close-Vote-Reviewers/UserScripts/issues/133/events","html_url":"https://github.com/SO-Close-Vote-Reviewers/UserScripts/issues/133","id":332758144,"node_id":"MDU6SXNzdWUzMzI3NTgxNDQ=","number":133,"title":"Redundancy in `edits.reason` field","user":{"login":"GaurangTandon","id":6308683,"node_id":"MDQ6VXNlcjYzMDg2ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/6308683?v=4","gravatar_id":"","url":"https://api.github.com/users/GaurangTandon","html_url":"https://github.com/GaurangTandon","followers_url":"https://api.github.com/users/GaurangTandon/followers","following_url":"https://api.github.com/users/GaurangTandon/following{/other_user}","gists_url":"https://api.github.com/users/GaurangTandon/gists{/gist_id}","starred_url":"https://api.github.com/users/GaurangTandon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaurangTandon/subscriptions","organizations_url":"https://api.github.com/users/GaurangTandon/orgs","repos_url":"https://api.github.com/users/GaurangTandon/repos","events_url":"https://api.github.com/users/GaurangTandon/events{/privacy}","received_events_url":"https://api.github.com/users/GaurangTandon/received_events","type":"User","site_admin":false},"labels":[{"id":321599779,"node_id":"MDU6TGFiZWwzMjE1OTk3Nzk=","url":"https://api.github.com/repos/SO-Close-Vote-Reviewers/UserScripts/labels/script:%20Magic%E2%84%A2%20Editor","name":"script: Magic™ Editor","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-15T12:38:59Z","updated_at":"2018-07-03T23:18:53Z","closed_at":null,"author_association":"NONE","body":"For example, if you do Ctrl-F on `App.consts.reasons.grammar`, there's too many successive fields in all having the same `reason`. \r\n\r\nHow about you spin off the same `reason` into a different array? (same for other `App.consts.reasons`)\r\n\r\n------\r\n\r\nFor example, this is how it currently looks like:\r\n\r\n```\r\nApp.edits = {\r\n    ...\r\n    apple: {\r\n        expr: /\\bapple\\b/g,\r\n        replacement: \"Apple\",\r\n        reason: App.consts.reasons.trademark\r\n     },\r\n     iphone: {\r\n        expr: /\\biph?one?\\b/gi,\r\n        replacement: \"iPhone\",\r\n        reason: App.consts.reasons.trademark\r\n    ...\r\n};\r\n```\r\n\r\nHere's how I think it would work better:\r\n\r\n```\r\nApp.edits = {};\r\nApp.edits.trademark = [ // as a nested array\r\n    ...\r\n    [/\\bapple\\b/g, \"Apple\"],\r\n    [/\\biph?one?\\b/gi, \"iPhone\"]\r\n    ...\r\n];\r\n```\r\n\r\nI hope my suggested idea is clear. I would be happy to do a PR for the same."},"comment":{"url":"https://api.github.com/repos/SO-Close-Vote-Reviewers/UserScripts/issues/comments/402318466","html_url":"https://github.com/SO-Close-Vote-Reviewers/UserScripts/issues/133#issuecomment-402318466","issue_url":"https://api.github.com/repos/SO-Close-Vote-Reviewers/UserScripts/issues/133","id":402318466,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjMxODQ2Ng==","user":{"login":"makyen","id":6118940,"node_id":"MDQ6VXNlcjYxMTg5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6118940?v=4","gravatar_id":"","url":"https://api.github.com/users/makyen","html_url":"https://github.com/makyen","followers_url":"https://api.github.com/users/makyen/followers","following_url":"https://api.github.com/users/makyen/following{/other_user}","gists_url":"https://api.github.com/users/makyen/gists{/gist_id}","starred_url":"https://api.github.com/users/makyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makyen/subscriptions","organizations_url":"https://api.github.com/users/makyen/orgs","repos_url":"https://api.github.com/users/makyen/repos","events_url":"https://api.github.com/users/makyen/events{/privacy}","received_events_url":"https://api.github.com/users/makyen/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T23:18:53Z","updated_at":"2018-07-03T23:18:53Z","author_association":"CONTRIBUTOR","body":"I had basically paused making major changes based on an assumption that you were going to make the changes you said you wanted to do in issue #134. (note: please have those changes in a separate PR from the ones you've mentioned in your most recent comment here).\r\n\r\nAs for the changes suggested initially here: I must admit that I've been thinking more about making changes along the lines of what you mentioned initially in this issue and that we discussed, but I'm still undecided as to the doing it. However, I have a structure in mind, should it happen. I'd basically allowed myself to procrastinate on making the decision with the expectation you were making the issue #134 changes and I shouldn't make sweeping changes that might affect those.\r\n\r\nI pushed the changes I mentioned in my earlier comments into the \"[ME-Mak-next-version](https://github.com/SO-Close-Vote-Reviewers/UserScripts/tree/ME-Mak-next-version)\" branch, which was my main reason for [asking you to](https://github.com/SO-Close-Vote-Reviewers/UserScripts/issues/134#issuecomment-397799706) base your changes on that branch and target your PR into that branch. I did it that way because I thought you were planning on beginning work shortly after that point, with the expectation of putting something together into a PR in the *relatively* near future, and I did not want to have multiple versions pushed out to everyone using it in rapid succession.\r\n\r\nIf you expect it to take a while for you to make changes, then I'll re-evaluate pushing those, by themselves, into master. I have no problem doing it either way, but if you expect to have changes in the near future, I'd prefer not to release multiple versions in rapid succession.\r\n\r\nHmmm.... as to the element names: It's certainly good to have those adjustments on Chem.SE. However, I have some concerns about applying them to SO. My concern is the possible use of element names as project, or product names. I have a vague memory of seeing a variety of element names used as project/product names, in which case they would be capitalized, rather than lowercase. However, I'm not coming up with examples off the top of my head.\r\n\r\nHowever, that does not mean we shouldn't have the elements in there.\r\n"}}
{"actor":{"display_login":"makyen"}}