{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/48184","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/48184/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/48184/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/48184/events","html_url":"https://github.com/saltstack/salt/issues/48184","id":333287118,"node_id":"MDU6SXNzdWUzMzMyODcxMTg=","number":48184,"title":"Invalid DMI prevents salt-minion from running","user":{"login":"mmulqueen","id":6616321,"node_id":"MDQ6VXNlcjY2MTYzMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/6616321?v=4","gravatar_id":"","url":"https://api.github.com/users/mmulqueen","html_url":"https://github.com/mmulqueen","followers_url":"https://api.github.com/users/mmulqueen/followers","following_url":"https://api.github.com/users/mmulqueen/following{/other_user}","gists_url":"https://api.github.com/users/mmulqueen/gists{/gist_id}","starred_url":"https://api.github.com/users/mmulqueen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmulqueen/subscriptions","organizations_url":"https://api.github.com/users/mmulqueen/orgs","repos_url":"https://api.github.com/users/mmulqueen/repos","events_url":"https://api.github.com/users/mmulqueen/events{/privacy}","received_events_url":"https://api.github.com/users/mmulqueen/received_events","type":"User","site_admin":false},"labels":[{"id":41387723,"node_id":"MDU6TGFiZWw0MTM4NzcyMw==","url":"https://api.github.com/repos/saltstack/salt/labels/Bug","name":"Bug","color":"e11d21","default":false},{"id":67288742,"node_id":"MDU6TGFiZWw2NzI4ODc0Mg==","url":"https://api.github.com/repos/saltstack/salt/labels/Critical","name":"Critical","color":"e95800","default":false},{"id":194766324,"node_id":"MDU6TGFiZWwxOTQ3NjYzMjQ=","url":"https://api.github.com/repos/saltstack/salt/labels/P4","name":"P4","color":"031a39","default":false},{"id":681622101,"node_id":"MDU6TGFiZWw2ODE2MjIxMDE=","url":"https://api.github.com/repos/saltstack/salt/labels/team-core","name":"team-core","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/saltstack/salt/milestones/13","html_url":"https://github.com/saltstack/salt/milestone/13","labels_url":"https://api.github.com/repos/saltstack/salt/milestones/13/labels","id":9265,"node_id":"MDk6TWlsZXN0b25lOTI2NQ==","number":13,"title":"Approved","description":"All issues that are ready to be worked on, both bugs and features.","creator":{"login":"thatch45","id":507599,"node_id":"MDQ6VXNlcjUwNzU5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/507599?v=4","gravatar_id":"","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"open_issues":2116,"closed_issues":7564,"state":"open","created_at":"2011-05-14T04:00:56Z","updated_at":"2018-06-19T20:42:00Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-06-18T14:11:53Z","updated_at":"2018-06-19T20:45:21Z","closed_at":null,"author_association":"NONE","body":"### Description of Issue/Question\r\n\r\n### Setup\r\n(Please provide relevant configs and/or SLS files (Be sure to remove sensitive info).)\r\n\r\nSalt is setup with the default settings, except the master and master_finger settings.\r\n\r\n### Steps to Reproduce Issue\r\n(Include debug logs if possible and relevant.)\r\n\r\nI've only been able to see this bug on one machine. I've deployed an identical setup on other machines without issue. \r\n\r\nWhen I try to start the salt-minion service or start salt-minion direct, it fails to start and give this traceback:\r\n\r\n```\r\nProcess Process-1:\r\nTraceback (most recent call last):\r\n  File \"/usr/lib/python2.7/multiprocessing/process.py\", line 267, in _bootstrap\r\n    self.run()\r\n  File \"/usr/lib/python2.7/multiprocessing/process.py\", line 114, in run\r\n    self._target(*self._args, **self._kwargs)\r\n  File \"/usr/lib/python2.7/dist-packages/salt/scripts.py\", line 144, in minion_process\r\n    minion.start()\r\n  File \"/usr/lib/python2.7/dist-packages/salt/cli/daemons.py\", line 348, in start\r\n    self.minion.tune_in()\r\n  File \"/usr/lib/python2.7/dist-packages/salt/minion.py\", line 1029, in tune_in\r\n    self._spawn_minions()\r\n  File \"/usr/lib/python2.7/dist-packages/salt/minion.py\", line 978, in _spawn_minions\r\n    jid_queue=self.jid_queue,\r\n  File \"/usr/lib/python2.7/dist-packages/salt/minion.py\", line 959, in _create_minion_object\r\n    jid_queue=jid_queue)\r\n  File \"/usr/lib/python2.7/dist-packages/salt/minion.py\", line 1099, in __init__\r\n    self.opts['grains'] = salt.loader.grains(opts)\r\n  File \"/usr/lib/python2.7/dist-packages/salt/loader.py\", line 734, in grains\r\n    ret = funcs[key]()\r\n  File \"/usr/lib/python2.7/dist-packages/salt/grains/core.py\", line 1788, in os_data\r\n    grains.update(_virtual(grains))\r\n  File \"/usr/lib/python2.7/dist-packages/salt/grains/core.py\", line 872, in _virtual\r\n    if 'VirtualBox' in output:\r\nUnicodeDecodeError: 'ascii' codec can't decode byte 0xff in position 0: ordinal not in range(128)\r\n```\r\n\r\nI've traced this back and I see that the contents of /sys/devices/virtual/dmi/id/product_name is actually\r\n`<FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF><FF> `\r\n\r\nI've temporarily solved this by modifying the code and forcing _virtual to return early ({'virtual': 'physical'}). However, when I do this, I run into a very similar issue later on with _hw_info. Again, I forced that to return early and the problem was solved. This is OK as a temporary fix, but it's not a good fix.\r\n\r\nThis is a physical machine not a virtual machine. It's an Intel NUC from around 2014, with a Celeron N2830 processor.\r\n\r\nYou may be interested to see this bug in Puppet: https://tickets.puppetlabs.com/browse/FACT-1140\r\n\r\n### Versions Report\r\n(Provided by running `salt --versions-report`. Please also mention any differences in master/minion versions.)\r\n\r\n```\r\nSalt Version:\r\n           Salt: 2018.3.1\r\n \r\nDependency Versions:\r\n           cffi: Not Installed\r\n       cherrypy: Not Installed\r\n       dateutil: 2.6.1\r\n      docker-py: Not Installed\r\n          gitdb: Not Installed\r\n      gitpython: Not Installed\r\n          ioflo: Not Installed\r\n         Jinja2: 2.10\r\n        libgit2: Not Installed\r\n        libnacl: Not Installed\r\n       M2Crypto: Not Installed\r\n           Mako: 1.0.7\r\n   msgpack-pure: Not Installed\r\n msgpack-python: 0.5.6\r\n   mysql-python: Not Installed\r\n      pycparser: Not Installed\r\n       pycrypto: 2.6.1\r\n   pycryptodome: Not Installed\r\n         pygit2: Not Installed\r\n         Python: 2.7.15rc1 (default, Apr 15 2018, 21:51:34)\r\n   python-gnupg: 0.4.1\r\n         PyYAML: 3.12\r\n          PyZMQ: 16.0.2\r\n           RAET: Not Installed\r\n          smmap: Not Installed\r\n        timelib: Not Installed\r\n        Tornado: 4.5.3\r\n            ZMQ: 4.2.5\r\n \r\nSystem Versions:\r\n           dist: Ubuntu 18.04 bionic\r\n         locale: UTF-8\r\n        machine: x86_64\r\n        release: 4.15.0-23-generic\r\n         system: Linux\r\n        version: Ubuntu 18.04 bionic\r\n\r\n\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/398539510","html_url":"https://github.com/saltstack/salt/issues/48184#issuecomment-398539510","issue_url":"https://api.github.com/repos/saltstack/salt/issues/48184","id":398539510,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODUzOTUxMA==","user":{"login":"Ch3LL","id":6886822,"node_id":"MDQ6VXNlcjY4ODY4MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/6886822?v=4","gravatar_id":"","url":"https://api.github.com/users/Ch3LL","html_url":"https://github.com/Ch3LL","followers_url":"https://api.github.com/users/Ch3LL/followers","following_url":"https://api.github.com/users/Ch3LL/following{/other_user}","gists_url":"https://api.github.com/users/Ch3LL/gists{/gist_id}","starred_url":"https://api.github.com/users/Ch3LL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ch3LL/subscriptions","organizations_url":"https://api.github.com/users/Ch3LL/orgs","repos_url":"https://api.github.com/users/Ch3LL/repos","events_url":"https://api.github.com/users/Ch3LL/events{/privacy}","received_events_url":"https://api.github.com/users/Ch3LL/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T20:45:21Z","updated_at":"2018-06-19T20:45:21Z","author_association":"CONTRIBUTOR","body":"Can you try fix in https://github.com/saltstack/salt/issues/48184"}}
{"actor":{"display_login":"Ch3LL"}}