{"action":"closed","number":906,"pull_request":{"url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/906","id":226826213,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2ODI2MjEz","html_url":"https://github.com/Electron-Cash/Electron-Cash/pull/906","diff_url":"https://github.com/Electron-Cash/Electron-Cash/pull/906.diff","patch_url":"https://github.com/Electron-Cash/Electron-Cash/pull/906.patch","issue_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues/906","number":906,"state":"closed","locked":false,"title":"required mod to allow complex P2SH processing","user":{"login":"markblundeberg","id":36528214,"node_id":"MDQ6VXNlcjM2NTI4MjE0","avatar_url":"https://avatars0.githubusercontent.com/u/36528214?v=4","gravatar_id":"","url":"https://api.github.com/users/markblundeberg","html_url":"https://github.com/markblundeberg","followers_url":"https://api.github.com/users/markblundeberg/followers","following_url":"https://api.github.com/users/markblundeberg/following{/other_user}","gists_url":"https://api.github.com/users/markblundeberg/gists{/gist_id}","starred_url":"https://api.github.com/users/markblundeberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markblundeberg/subscriptions","organizations_url":"https://api.github.com/users/markblundeberg/orgs","repos_url":"https://api.github.com/users/markblundeberg/repos","events_url":"https://api.github.com/users/markblundeberg/events{/privacy}","received_events_url":"https://api.github.com/users/markblundeberg/received_events","type":"User","site_admin":false},"body":"This modifies one of the internal functions called by `Transaction.sign()`, to allow inputs to have a type of 'unknown' where the scriptCode (used in signing that input) needs to be provided. This allows the `sign()` method to correctly create signatures for OP_CHECKSIG even for unusual smart contracts. It is still up to the developer to correctly set up the input dictionary, and to serialize the proper scriptSig after the signature operation is done. (`sign()` leaves the signature in the input dictionary's `'signatures'` list)\r\n\r\nI have found this particular modification to be essential in coding my custom P2SH codes (atomic swaps and now also coin splitter), so I thought it would be nice to have in mainline. All other necessary code to handle these smart contracts can be done without modifying the core codebase.","created_at":"2018-10-30T08:11:08Z","updated_at":"2018-10-30T09:30:52Z","closed_at":"2018-10-30T09:30:52Z","merged_at":"2018-10-30T09:30:52Z","merge_commit_sha":"c23f97326c1c1cdc5323c39bfabddaadb74edf1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/906/commits","review_comments_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/906/comments","review_comment_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues/906/comments","statuses_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/statuses/30e17600122b166ddd1f0992ff01dcd2bf78ff2f","head":{"label":"markblundeberg:pr-improve-smartcontracts","ref":"pr-improve-smartcontracts","sha":"30e17600122b166ddd1f0992ff01dcd2bf78ff2f","user":{"login":"markblundeberg","id":36528214,"node_id":"MDQ6VXNlcjM2NTI4MjE0","avatar_url":"https://avatars0.githubusercontent.com/u/36528214?v=4","gravatar_id":"","url":"https://api.github.com/users/markblundeberg","html_url":"https://github.com/markblundeberg","followers_url":"https://api.github.com/users/markblundeberg/followers","following_url":"https://api.github.com/users/markblundeberg/following{/other_user}","gists_url":"https://api.github.com/users/markblundeberg/gists{/gist_id}","starred_url":"https://api.github.com/users/markblundeberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markblundeberg/subscriptions","organizations_url":"https://api.github.com/users/markblundeberg/orgs","repos_url":"https://api.github.com/users/markblundeberg/repos","events_url":"https://api.github.com/users/markblundeberg/events{/privacy}","received_events_url":"https://api.github.com/users/markblundeberg/received_events","type":"User","site_admin":false},"repo":{"id":155121911,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUxMjE5MTE=","name":"Electron-Cash","full_name":"markblundeberg/Electron-Cash","private":false,"owner":{"login":"markblundeberg","id":36528214,"node_id":"MDQ6VXNlcjM2NTI4MjE0","avatar_url":"https://avatars0.githubusercontent.com/u/36528214?v=4","gravatar_id":"","url":"https://api.github.com/users/markblundeberg","html_url":"https://github.com/markblundeberg","followers_url":"https://api.github.com/users/markblundeberg/followers","following_url":"https://api.github.com/users/markblundeberg/following{/other_user}","gists_url":"https://api.github.com/users/markblundeberg/gists{/gist_id}","starred_url":"https://api.github.com/users/markblundeberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markblundeberg/subscriptions","organizations_url":"https://api.github.com/users/markblundeberg/orgs","repos_url":"https://api.github.com/users/markblundeberg/repos","events_url":"https://api.github.com/users/markblundeberg/events{/privacy}","received_events_url":"https://api.github.com/users/markblundeberg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/markblundeberg/Electron-Cash","description":"Electrum; Bitcoin thin client","fork":true,"url":"https://api.github.com/repos/markblundeberg/Electron-Cash","forks_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/forks","keys_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/teams","hooks_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/hooks","issue_events_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/issues/events{/number}","events_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/events","assignees_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/assignees{/user}","branches_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/branches{/branch}","tags_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/tags","blobs_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/git/refs{/sha}","trees_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/statuses/{sha}","languages_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/languages","stargazers_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/stargazers","contributors_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/contributors","subscribers_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/subscribers","subscription_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/subscription","commits_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/commits{/sha}","git_commits_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/git/commits{/sha}","comments_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/comments{/number}","issue_comment_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/issues/comments{/number}","contents_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/contents/{+path}","compare_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/merges","archive_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/downloads","issues_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/issues{/number}","pulls_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/pulls{/number}","milestones_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/milestones{/number}","notifications_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/labels{/name}","releases_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/releases{/id}","deployments_url":"https://api.github.com/repos/markblundeberg/Electron-Cash/deployments","created_at":"2018-10-28T22:27:05Z","updated_at":"2018-10-28T22:27:09Z","pushed_at":"2018-10-30T08:05:20Z","git_url":"git://github.com/markblundeberg/Electron-Cash.git","ssh_url":"git@github.com:markblundeberg/Electron-Cash.git","clone_url":"https://github.com/markblundeberg/Electron-Cash.git","svn_url":"https://github.com/markblundeberg/Electron-Cash","homepage":null,"size":28810,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Electron-Cash:master","ref":"master","sha":"f598bd0cf54a37bcba8259380f43c4c7b7c19ba0","user":{"login":"Electron-Cash","id":43519373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTE5Mzcz","avatar_url":"https://avatars3.githubusercontent.com/u/43519373?v=4","gravatar_id":"","url":"https://api.github.com/users/Electron-Cash","html_url":"https://github.com/Electron-Cash","followers_url":"https://api.github.com/users/Electron-Cash/followers","following_url":"https://api.github.com/users/Electron-Cash/following{/other_user}","gists_url":"https://api.github.com/users/Electron-Cash/gists{/gist_id}","starred_url":"https://api.github.com/users/Electron-Cash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Electron-Cash/subscriptions","organizations_url":"https://api.github.com/users/Electron-Cash/orgs","repos_url":"https://api.github.com/users/Electron-Cash/repos","events_url":"https://api.github.com/users/Electron-Cash/events{/privacy}","received_events_url":"https://api.github.com/users/Electron-Cash/received_events","type":"Organization","site_admin":false},"repo":{"id":98333687,"node_id":"MDEwOlJlcG9zaXRvcnk5ODMzMzY4Nw==","name":"Electron-Cash","full_name":"Electron-Cash/Electron-Cash","private":false,"owner":{"login":"Electron-Cash","id":43519373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTE5Mzcz","avatar_url":"https://avatars3.githubusercontent.com/u/43519373?v=4","gravatar_id":"","url":"https://api.github.com/users/Electron-Cash","html_url":"https://github.com/Electron-Cash","followers_url":"https://api.github.com/users/Electron-Cash/followers","following_url":"https://api.github.com/users/Electron-Cash/following{/other_user}","gists_url":"https://api.github.com/users/Electron-Cash/gists{/gist_id}","starred_url":"https://api.github.com/users/Electron-Cash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Electron-Cash/subscriptions","organizations_url":"https://api.github.com/users/Electron-Cash/orgs","repos_url":"https://api.github.com/users/Electron-Cash/repos","events_url":"https://api.github.com/users/Electron-Cash/events{/privacy}","received_events_url":"https://api.github.com/users/Electron-Cash/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Electron-Cash/Electron-Cash","description":"Electrum; Bitcoin thin client","fork":true,"url":"https://api.github.com/repos/Electron-Cash/Electron-Cash","forks_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/forks","keys_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/teams","hooks_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/hooks","issue_events_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues/events{/number}","events_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/events","assignees_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/assignees{/user}","branches_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/branches{/branch}","tags_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/tags","blobs_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/git/refs{/sha}","trees_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/statuses/{sha}","languages_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/languages","stargazers_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/stargazers","contributors_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/contributors","subscribers_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/subscribers","subscription_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/subscription","commits_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/commits{/sha}","git_commits_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/git/commits{/sha}","comments_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/comments{/number}","issue_comment_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues/comments{/number}","contents_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/contents/{+path}","compare_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/merges","archive_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/downloads","issues_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues{/number}","pulls_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls{/number}","milestones_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/milestones{/number}","notifications_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/labels{/name}","releases_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/releases{/id}","deployments_url":"https://api.github.com/repos/Electron-Cash/Electron-Cash/deployments","created_at":"2017-07-25T17:40:55Z","updated_at":"2018-10-26T22:00:59Z","pushed_at":"2018-10-30T09:30:52Z","git_url":"git://github.com/Electron-Cash/Electron-Cash.git","ssh_url":"git@github.com:Electron-Cash/Electron-Cash.git","clone_url":"https://github.com/Electron-Cash/Electron-Cash.git","svn_url":"https://github.com/Electron-Cash/Electron-Cash","homepage":null,"size":28923,"stargazers_count":198,"watchers_count":198,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":83,"open_issues":60,"watchers":198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/906"},"html":{"href":"https://github.com/Electron-Cash/Electron-Cash/pull/906"},"issue":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues/906"},"comments":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/Electron-Cash/Electron-Cash/statuses/30e17600122b166ddd1f0992ff01dcd2bf78ff2f"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cculianu","id":266627,"node_id":"MDQ6VXNlcjI2NjYyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/266627?v=4","gravatar_id":"","url":"https://api.github.com/users/cculianu","html_url":"https://github.com/cculianu","followers_url":"https://api.github.com/users/cculianu/followers","following_url":"https://api.github.com/users/cculianu/following{/other_user}","gists_url":"https://api.github.com/users/cculianu/gists{/gist_id}","starred_url":"https://api.github.com/users/cculianu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cculianu/subscriptions","organizations_url":"https://api.github.com/users/cculianu/orgs","repos_url":"https://api.github.com/users/cculianu/repos","events_url":"https://api.github.com/users/cculianu/events{/privacy}","received_events_url":"https://api.github.com/users/cculianu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":8,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"cculianu"}}