{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/20561","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20561/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20561/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20561/events","html_url":"https://github.com/joomla/joomla-cms/pull/20561","id":325877057,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMTA3ODYz","number":20561,"title":"[4.0] Normalize finder tables and add default values","user":{"login":"Hackwar","id":313866,"node_id":"MDQ6VXNlcjMxMzg2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/313866?v=4","gravatar_id":"","url":"https://api.github.com/users/Hackwar","html_url":"https://github.com/Hackwar","followers_url":"https://api.github.com/users/Hackwar/followers","following_url":"https://api.github.com/users/Hackwar/following{/other_user}","gists_url":"https://api.github.com/users/Hackwar/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackwar/subscriptions","organizations_url":"https://api.github.com/users/Hackwar/orgs","repos_url":"https://api.github.com/users/Hackwar/repos","events_url":"https://api.github.com/users/Hackwar/events{/privacy}","received_events_url":"https://api.github.com/users/Hackwar/received_events","type":"User","site_admin":false},"labels":[{"id":444033883,"node_id":"MDU6TGFiZWw0NDQwMzM4ODM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-05-23T21:18:13Z","updated_at":"2018-07-25T13:37:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20561","html_url":"https://github.com/joomla/joomla-cms/pull/20561","diff_url":"https://github.com/joomla/joomla-cms/pull/20561.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/20561.patch"},"body":"This is a new version of #13517 which originally was supposed to fix #13509. Since all of my finder work is aimed at 4.0, this PR is, too. I also extended this further and since MSSQL is not supported in 4.0 anymore, I've not adopted those changes.\r\n\r\n## Changes\r\n* Changed all field types to be identical across DB systems and across tables\r\n* Added default values for all relevant fields\r\n* Added indexes where appropriate\r\n* Updated component SQL files\r\n\r\n## How to test\r\nI'm quoting the original dev of this PR:\r\n1. SQL code review\r\n2. Test update: Apply patch, manually run the sql query for your Db system, confirm db table, confirm all fine\r\n3. Test install: apply patch, delete configuration.php do a normal install, confirm db table, confirm all fine\r\n\r\n@alikon Can you check the Postgres code? Is there a difference between VARCHAR and CHAR in Postgres? Maybe we want to change the language columns from VARCHAR to CHAR? I'm confused because the original author did not change those.\r\n\r\nThis will create a conflict with #20185, which I still would like people to test and merge. :wink:"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/407756880","html_url":"https://github.com/joomla/joomla-cms/pull/20561#issuecomment-407756880","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20561","id":407756880,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzc1Njg4MA==","user":{"login":"brianteeman","id":1296369,"node_id":"MDQ6VXNlcjEyOTYzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1296369?v=4","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T13:37:56Z","updated_at":"2018-07-25T13:37:56Z","author_association":"CONTRIBUTOR","body":"Why does this component have its own install.sql ??\r\nOther components do not\r\n"}}
{"actor":{"display_login":"brianteeman"}}