{"action":"opened","issue":{"url":"https://api.github.com/repos/jetstack/tarmak/issues/180","repository_url":"https://api.github.com/repos/jetstack/tarmak","labels_url":"https://api.github.com/repos/jetstack/tarmak/issues/180/labels{/name}","comments_url":"https://api.github.com/repos/jetstack/tarmak/issues/180/comments","events_url":"https://api.github.com/repos/jetstack/tarmak/issues/180/events","html_url":"https://github.com/jetstack/tarmak/issues/180","id":315556542,"number":180,"title":"Tarmak provider's vault resources apply changes to vault during plan","user":{"login":"simonswine","id":223048,"avatar_url":"https://avatars0.githubusercontent.com/u/223048?v=4","gravatar_id":"","url":"https://api.github.com/users/simonswine","html_url":"https://github.com/simonswine","followers_url":"https://api.github.com/users/simonswine/followers","following_url":"https://api.github.com/users/simonswine/following{/other_user}","gists_url":"https://api.github.com/users/simonswine/gists{/gist_id}","starred_url":"https://api.github.com/users/simonswine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonswine/subscriptions","organizations_url":"https://api.github.com/users/simonswine/orgs","repos_url":"https://api.github.com/users/simonswine/repos","events_url":"https://api.github.com/users/simonswine/events{/privacy}","received_events_url":"https://api.github.com/users/simonswine/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-18T16:37:39Z","updated_at":"2018-04-18T16:37:39Z","closed_at":null,"author_association":"OWNER","body":"**Is this a BUG REPORT or FEATURE REQUEST?**:\r\n\r\n/kind bug\r\n\r\n**What happened**:\r\n\r\nTarmak's terraform provider creates PKI for clusters in vault during a plan. \r\n\r\n**What you expected to happen**:\r\n\r\n- A plan should not do any action, vault helper should expose a  `.EnsureDryRun()`\r\n- Apply can then use `.Ensure()`, terraform will only do that if a plan requests\r\n- During a terrform destroy it needs to be deleted\r\n- If vault-helper get updated (new version) we should make sure that we run ensure another time\r\n\r\n**Anything else we need to know?**:\r\n\r\nIt might be possible to fix #168 as part of this PR as well\r\n\r\n/assign @JoshVanL \r\n"}}
{"actor":{"display_login":"simonswine"}}