{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/comments/229513404","pull_request_review_id":170033140,"id":229513404,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTUxMzQwNA==","diff_hunk":"@@ -505,6 +529,7 @@ private static Long millisFromTimestamp(Timestamp timestamp) {\n     if (spanId != null) {\n       builder.setSpanId(spanId);\n     }\n+    builder.setTraceSampled(traceSampled);","path":"google-cloud-clients/google-cloud-logging/src/main/java/com/google/cloud/logging/LogEntry.java","position":93,"original_position":93,"commit_id":"6ad70dc3acaabe45d2ed2462a8fccc8f044b02c4","original_commit_id":"6ad70dc3acaabe45d2ed2462a8fccc8f044b02c4","user":{"login":"pongad","id":1617025,"node_id":"MDQ6VXNlcjE2MTcwMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1617025?v=4","gravatar_id":"","url":"https://api.github.com/users/pongad","html_url":"https://github.com/pongad","followers_url":"https://api.github.com/users/pongad/followers","following_url":"https://api.github.com/users/pongad/following{/other_user}","gists_url":"https://api.github.com/users/pongad/gists{/gist_id}","starred_url":"https://api.github.com/users/pongad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pongad/subscriptions","organizations_url":"https://api.github.com/users/pongad/orgs","repos_url":"https://api.github.com/users/pongad/repos","events_url":"https://api.github.com/users/pongad/events{/privacy}","received_events_url":"https://api.github.com/users/pongad/received_events","type":"User","site_admin":false},"body":"Do we need to null check this?","created_at":"2018-10-30T22:46:46Z","updated_at":"2018-10-30T22:46:56Z","html_url":"https://github.com/googleapis/google-cloud-java/pull/3863#discussion_r229513404","pull_request_url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3863","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/comments/229513404"},"html":{"href":"https://github.com/googleapis/google-cloud-java/pull/3863#discussion_r229513404"},"pull_request":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3863"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3863","id":225952306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTUyMzA2","html_url":"https://github.com/googleapis/google-cloud-java/pull/3863","diff_url":"https://github.com/googleapis/google-cloud-java/pull/3863.diff","patch_url":"https://github.com/googleapis/google-cloud-java/pull/3863.patch","issue_url":"https://api.github.com/repos/googleapis/google-cloud-java/issues/3863","number":3863,"state":"open","locked":false,"title":"Add a traceSampled field to the google-cloud-logging LogEntry class.","user":{"login":"sebright","id":19807615,"node_id":"MDQ6VXNlcjE5ODA3NjE1","avatar_url":"https://avatars0.githubusercontent.com/u/19807615?v=4","gravatar_id":"","url":"https://api.github.com/users/sebright","html_url":"https://github.com/sebright","followers_url":"https://api.github.com/users/sebright/followers","following_url":"https://api.github.com/users/sebright/following{/other_user}","gists_url":"https://api.github.com/users/sebright/gists{/gist_id}","starred_url":"https://api.github.com/users/sebright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebright/subscriptions","organizations_url":"https://api.github.com/users/sebright/orgs","repos_url":"https://api.github.com/users/sebright/repos","events_url":"https://api.github.com/users/sebright/events{/privacy}","received_events_url":"https://api.github.com/users/sebright/received_events","type":"User","site_admin":false},"body":"The new field was added to the Stackdriver LogEntry protocol buffer message in\r\nhttps://github.com/googleapis/googleapis/commit/7b34e5a3ed10775fe14d15ffa842870dc3b5400e#diff-a51916a680df6453b6d86586cd7d63f9R149.\r\n\r\n______________________________________________________________________________\r\n\r\nThis change would allow [opencensus-contrib-log-correlation-stackdriver](https://github.com/census-instrumentation/opencensus-java/tree/master/contrib/log_correlation/stackdriver) to set the trace_sampled field in its LoggingEnhancer.\r\n\r\n/cc @g-easy","created_at":"2018-10-26T01:40:16Z","updated_at":"2018-10-30T22:46:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e98661f142d98af98c3c98aafb3136898f7c778c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"yoshi-java","id":2775912,"node_id":"MDQ6VGVhbTI3NzU5MTI=","slug":"yoshi-java","description":"","privacy":"closed","url":"https://api.github.com/teams/2775912","members_url":"https://api.github.com/teams/2775912/members{/member}","repositories_url":"https://api.github.com/teams/2775912/repos","permission":"pull"}],"labels":[{"id":175662188,"node_id":"MDU6TGFiZWwxNzU2NjIxODg=","url":"https://api.github.com/repos/googleapis/google-cloud-java/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3863/commits","review_comments_url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3863/comments","review_comment_url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/google-cloud-java/issues/3863/comments","statuses_url":"https://api.github.com/repos/googleapis/google-cloud-java/statuses/6ad70dc3acaabe45d2ed2462a8fccc8f044b02c4","head":{"label":"sebright:LogEntry-traceSampled-field","ref":"LogEntry-traceSampled-field","sha":"6ad70dc3acaabe45d2ed2462a8fccc8f044b02c4","user":{"login":"sebright","id":19807615,"node_id":"MDQ6VXNlcjE5ODA3NjE1","avatar_url":"https://avatars0.githubusercontent.com/u/19807615?v=4","gravatar_id":"","url":"https://api.github.com/users/sebright","html_url":"https://github.com/sebright","followers_url":"https://api.github.com/users/sebright/followers","following_url":"https://api.github.com/users/sebright/following{/other_user}","gists_url":"https://api.github.com/users/sebright/gists{/gist_id}","starred_url":"https://api.github.com/users/sebright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebright/subscriptions","organizations_url":"https://api.github.com/users/sebright/orgs","repos_url":"https://api.github.com/users/sebright/repos","events_url":"https://api.github.com/users/sebright/events{/privacy}","received_events_url":"https://api.github.com/users/sebright/received_events","type":"User","site_admin":false},"repo":{"id":135679581,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2Nzk1ODE=","name":"google-cloud-java","full_name":"sebright/google-cloud-java","private":false,"owner":{"login":"sebright","id":19807615,"node_id":"MDQ6VXNlcjE5ODA3NjE1","avatar_url":"https://avatars0.githubusercontent.com/u/19807615?v=4","gravatar_id":"","url":"https://api.github.com/users/sebright","html_url":"https://github.com/sebright","followers_url":"https://api.github.com/users/sebright/followers","following_url":"https://api.github.com/users/sebright/following{/other_user}","gists_url":"https://api.github.com/users/sebright/gists{/gist_id}","starred_url":"https://api.github.com/users/sebright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebright/subscriptions","organizations_url":"https://api.github.com/users/sebright/orgs","repos_url":"https://api.github.com/users/sebright/repos","events_url":"https://api.github.com/users/sebright/events{/privacy}","received_events_url":"https://api.github.com/users/sebright/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sebright/google-cloud-java","description":"Google Cloud Client Library for Java","fork":true,"url":"https://api.github.com/repos/sebright/google-cloud-java","forks_url":"https://api.github.com/repos/sebright/google-cloud-java/forks","keys_url":"https://api.github.com/repos/sebright/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebright/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebright/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/sebright/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/sebright/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/sebright/google-cloud-java/events","assignees_url":"https://api.github.com/repos/sebright/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/sebright/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/sebright/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/sebright/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebright/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebright/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebright/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebright/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/sebright/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/sebright/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/sebright/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/sebright/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/sebright/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/sebright/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebright/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebright/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebright/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebright/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/sebright/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebright/google-cloud-java/merges","archive_url":"https://api.github.com/repos/sebright/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebright/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/sebright/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/sebright/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/sebright/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/sebright/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebright/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/sebright/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/sebright/google-cloud-java/deployments","created_at":"2018-06-01T06:54:20Z","updated_at":"2018-09-28T16:20:22Z","pushed_at":"2018-10-30T22:25:50Z","git_url":"git://github.com/sebright/google-cloud-java.git","ssh_url":"git@github.com:sebright/google-cloud-java.git","clone_url":"https://github.com/sebright/google-cloud-java.git","svn_url":"https://github.com/sebright/google-cloud-java","homepage":"https://googlecloudplatform.github.io/google-cloud-java/","size":94037,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"f69e7fafe748bc8ce49c2a8d9375b3b3a4644d5d","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":26181278,"node_id":"MDEwOlJlcG9zaXRvcnkyNjE4MTI3OA==","name":"google-cloud-java","full_name":"googleapis/google-cloud-java","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/google-cloud-java","description":"Google Cloud Client Library for Java","fork":false,"url":"https://api.github.com/repos/googleapis/google-cloud-java","forks_url":"https://api.github.com/repos/googleapis/google-cloud-java/forks","keys_url":"https://api.github.com/repos/googleapis/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/googleapis/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/googleapis/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/google-cloud-java/events","assignees_url":"https://api.github.com/repos/googleapis/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/googleapis/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/googleapis/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/googleapis/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/googleapis/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/googleapis/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/googleapis/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/google-cloud-java/merges","archive_url":"https://api.github.com/repos/googleapis/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/googleapis/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/google-cloud-java/deployments","created_at":"2014-11-04T17:57:16Z","updated_at":"2018-10-30T19:19:37Z","pushed_at":"2018-10-30T22:25:52Z","git_url":"git://github.com/googleapis/google-cloud-java.git","ssh_url":"git@github.com:googleapis/google-cloud-java.git","clone_url":"https://github.com/googleapis/google-cloud-java.git","svn_url":"https://github.com/googleapis/google-cloud-java","homepage":"https://googleapis.github.io/google-cloud-java/","size":543154,"stargazers_count":935,"watchers_count":935,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":571,"mirror_url":null,"archived":false,"open_issues_count":206,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":571,"open_issues":206,"watchers":935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3863"},"html":{"href":"https://github.com/googleapis/google-cloud-java/pull/3863"},"issue":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/issues/3863"},"comments":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/issues/3863/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3863/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3863/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/statuses/6ad70dc3acaabe45d2ed2462a8fccc8f044b02c4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pongad"}}