{"action":"created","issue":{"url":"https://api.github.com/repos/esy/esy/issues/393","repository_url":"https://api.github.com/repos/esy/esy","labels_url":"https://api.github.com/repos/esy/esy/issues/393/labels{/name}","comments_url":"https://api.github.com/repos/esy/esy/issues/393/comments","events_url":"https://api.github.com/repos/esy/esy/issues/393/events","html_url":"https://github.com/esy/esy/issues/393","id":353803689,"node_id":"MDU6SXNzdWUzNTM4MDM2ODk=","number":393,"title":"Windows - Build: esy fails to build at fastreplacestring dependency","user":{"login":"bryphe","id":13532591,"node_id":"MDQ6VXNlcjEzNTMyNTkx","avatar_url":"https://avatars1.githubusercontent.com/u/13532591?v=4","gravatar_id":"","url":"https://api.github.com/users/bryphe","html_url":"https://github.com/bryphe","followers_url":"https://api.github.com/users/bryphe/followers","following_url":"https://api.github.com/users/bryphe/following{/other_user}","gists_url":"https://api.github.com/users/bryphe/gists{/gist_id}","starred_url":"https://api.github.com/users/bryphe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryphe/subscriptions","organizations_url":"https://api.github.com/users/bryphe/orgs","repos_url":"https://api.github.com/users/bryphe/repos","events_url":"https://api.github.com/users/bryphe/events{/privacy}","received_events_url":"https://api.github.com/users/bryphe/received_events","type":"User","site_admin":false},"labels":[{"id":989886465,"node_id":"MDU6TGFiZWw5ODk4ODY0NjU=","url":"https://api.github.com/repos/esy/esy/labels/windows","name":"windows","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-24T14:20:49Z","updated_at":"2018-08-25T01:01:37Z","closed_at":null,"author_association":"COLLABORATOR","body":"\r\n<!-- Please try to reproduce the issue with esy@latest. It may have already been fixed.  -->\r\n**esy version:** `0.2.8`\r\n**Operating System:** Windows\r\n\r\n**Issue:**\r\n\r\nWhen trying to build `esy` on Windows via `esy install` and `esy build`, the `fastreplacestring` dependency fails to build:\r\n\r\n```\r\nesy: error, exiting...\r\n     build failed\r\n       Building fastreplacestring@0.0.3\r\n       Build log:\r\n         # esy-build-package: building: fastreplacestring@0.0.3\r\n         # esy-build-package: running: \"make\"\r\n     \"PREFIX=C:\\Users\\bryph\\.esy\\3_/s/fastreplacestring-0.0.3-84edfab2\"\r\n     \"build\"\r\n         make: g++: Command not found\r\n         make: *** [Makefile:5: build] Error 127\r\n         esy-build-package:\r\n                            command\r\n                            failed:\r\n\r\n     \"make\"\"PREFIX=C:\\Users\\bryph\\.esy\\3_/s/fastreplacestring-0.0.3-84edfab2\"\"build\"\r\n```\r\n\r\n**Additional steps to reproduce:**\r\nOn a windows machine:\r\n- `git clone https://github.com/esy/esy esy-test-build`\r\n- `cd esy-test-build`\r\n- `git checkout windows/lockfile` (needed to have the proper `esy.lock.json`)\r\n- `esy install`\r\n- `esy build`"},"comment":{"url":"https://api.github.com/repos/esy/esy/issues/comments/415918091","html_url":"https://github.com/esy/esy/issues/393#issuecomment-415918091","issue_url":"https://api.github.com/repos/esy/esy/issues/393","id":415918091,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTkxODA5MQ==","user":{"login":"bryphe","id":13532591,"node_id":"MDQ6VXNlcjEzNTMyNTkx","avatar_url":"https://avatars1.githubusercontent.com/u/13532591?v=4","gravatar_id":"","url":"https://api.github.com/users/bryphe","html_url":"https://github.com/bryphe","followers_url":"https://api.github.com/users/bryphe/followers","following_url":"https://api.github.com/users/bryphe/following{/other_user}","gists_url":"https://api.github.com/users/bryphe/gists{/gist_id}","starred_url":"https://api.github.com/users/bryphe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryphe/subscriptions","organizations_url":"https://api.github.com/users/bryphe/orgs","repos_url":"https://api.github.com/users/bryphe/repos","events_url":"https://api.github.com/users/bryphe/events{/privacy}","received_events_url":"https://api.github.com/users/bryphe/received_events","type":"User","site_admin":false},"created_at":"2018-08-25T01:01:37Z","updated_at":"2018-08-25T01:01:37Z","author_association":"COLLABORATOR","body":"Oh, and I tested building it locally with `x86_64-w64-mingw32-g++` instead of `g++`, and it build fine and produced a native Windows executable. So we may not need the precompiled binaries either - we can just use `g++` on Mac/Linux and `x86_64-w64-mingw32-g++` on Windows."}}
{"actor":{"display_login":"bryphe"}}