{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/165295379","pull_request_review_id":93208605,"id":165295379,"diff_hunk":"@@ -27,13 +27,13 @@ void main(void)\n \t\t\treturn;\n \t\t}\n \n-\t\tret = sensor_channel_get(dev, SENSOR_CHAN_PROX, &prox_value);\n-\t\tprintk(\"prox is %d\\n\", prox_value.val1);\n+\t\tret = sensor_channel_get(dev, SENSOR_CHAN_PROX, &value);\n+\t\tprintk(\"prox is %d\\n\", value.val1);","path":"samples/sensor/vl53l0x/src/main.c","position":22,"original_position":16,"commit_id":"b025fe92e146e057b6ce049ca02320c66484bf86","original_commit_id":"52e4b3d927ca3a13b9d36f2c7693481db04a3102","user":{"login":"VVESTM","id":22098252,"avatar_url":"https://avatars2.githubusercontent.com/u/22098252?v=4","gravatar_id":"","url":"https://api.github.com/users/VVESTM","html_url":"https://github.com/VVESTM","followers_url":"https://api.github.com/users/VVESTM/followers","following_url":"https://api.github.com/users/VVESTM/following{/other_user}","gists_url":"https://api.github.com/users/VVESTM/gists{/gist_id}","starred_url":"https://api.github.com/users/VVESTM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VVESTM/subscriptions","organizations_url":"https://api.github.com/users/VVESTM/orgs","repos_url":"https://api.github.com/users/VVESTM/repos","events_url":"https://api.github.com/users/VVESTM/events{/privacy}","received_events_url":"https://api.github.com/users/VVESTM/received_events","type":"User","site_admin":false},"body":"ok, thanks for explanation\r\n","created_at":"2018-02-01T09:17:38Z","updated_at":"2018-02-01T09:17:38Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5927#discussion_r165295379","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5927","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/165295379"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/5927#discussion_r165295379"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5927"}},"in_reply_to_id":165282568},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5927","id":166299678,"html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5927","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5927.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5927.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5927","number":5927,"state":"open","locked":false,"title":"sensors: Redefine SENSOR_CHAN_DISTANCE to be in meters","user":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars3.githubusercontent.com/u/500451?v=4","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"body":"Most of sensor channels defined by Zephyr use the main, unscaled\r\nSI unit. We also have SENSOR_CHAN_ALTITUDE which is defined in\r\nmeters. So, it only makes sense to define distance in meters too\r\n\r\nThe only driver supporting SENSOR_CHAN_DISTANCE as of now is\r\nvl53l0x.c, which was updated accordingly.\r\n\r\nFixes: #5693\r\n\r\nSigned-off-by: Paul Sokolovsky <paul.sokolovsky@linaro.org>","created_at":"2018-01-31T15:55:37Z","updated_at":"2018-02-01T09:17:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"098613ae86baba5303cfcf97e08124512f6ce560","assignee":null,"assignees":[],"requested_reviewers":[{"login":"erwango","id":18574308,"avatar_url":"https://avatars1.githubusercontent.com/u/18574308?v=4","gravatar_id":"","url":"https://api.github.com/users/erwango","html_url":"https://github.com/erwango","followers_url":"https://api.github.com/users/erwango/followers","following_url":"https://api.github.com/users/erwango/following{/other_user}","gists_url":"https://api.github.com/users/erwango/gists{/gist_id}","starred_url":"https://api.github.com/users/erwango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwango/subscriptions","organizations_url":"https://api.github.com/users/erwango/orgs","repos_url":"https://api.github.com/users/erwango/repos","events_url":"https://api.github.com/users/erwango/events{/privacy}","received_events_url":"https://api.github.com/users/erwango/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5927/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5927/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5927/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/b025fe92e146e057b6ce049ca02320c66484bf86","head":{"label":"pfalcon:sensors-dist-meters","ref":"sensors-dist-meters","sha":"b025fe92e146e057b6ce049ca02320c66484bf86","user":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars3.githubusercontent.com/u/500451?v=4","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"repo":{"id":89925445,"name":"zephyr","full_name":"pfalcon/zephyr","owner":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars3.githubusercontent.com/u/500451?v=4","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfalcon/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/pfalcon/zephyr","forks_url":"https://api.github.com/repos/pfalcon/zephyr/forks","keys_url":"https://api.github.com/repos/pfalcon/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfalcon/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfalcon/zephyr/teams","hooks_url":"https://api.github.com/repos/pfalcon/zephyr/hooks","issue_events_url":"https://api.github.com/repos/pfalcon/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/pfalcon/zephyr/events","assignees_url":"https://api.github.com/repos/pfalcon/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/pfalcon/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/pfalcon/zephyr/tags","blobs_url":"https://api.github.com/repos/pfalcon/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfalcon/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfalcon/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfalcon/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfalcon/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/pfalcon/zephyr/languages","stargazers_url":"https://api.github.com/repos/pfalcon/zephyr/stargazers","contributors_url":"https://api.github.com/repos/pfalcon/zephyr/contributors","subscribers_url":"https://api.github.com/repos/pfalcon/zephyr/subscribers","subscription_url":"https://api.github.com/repos/pfalcon/zephyr/subscription","commits_url":"https://api.github.com/repos/pfalcon/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfalcon/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfalcon/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfalcon/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfalcon/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/pfalcon/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfalcon/zephyr/merges","archive_url":"https://api.github.com/repos/pfalcon/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfalcon/zephyr/downloads","issues_url":"https://api.github.com/repos/pfalcon/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/pfalcon/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/pfalcon/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/pfalcon/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfalcon/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/pfalcon/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/pfalcon/zephyr/deployments","created_at":"2017-05-01T13:16:09Z","updated_at":"2017-05-01T13:16:45Z","pushed_at":"2018-02-01T09:07:34Z","git_url":"git://github.com/pfalcon/zephyr.git","ssh_url":"git@github.com:pfalcon/zephyr.git","clone_url":"https://github.com/pfalcon/zephyr.git","svn_url":"https://github.com/pfalcon/zephyr","homepage":"http://zephyrproject.org/doc","size":99539,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"9a238cd538e10c8c6d9e98e8dfae0bb3f04cec2c","user":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-02-01T06:25:07Z","pushed_at":"2018-02-01T09:07:36Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"http://zephyrproject.org/doc","size":99881,"stargazers_count":611,"watchers_count":611,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":439,"mirror_url":null,"archived":false,"open_issues_count":806,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":439,"open_issues":806,"watchers":611,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5927"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/5927"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5927"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5927/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5927/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5927/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/b025fe92e146e057b6ce049ca02320c66484bf86"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"VVESTM"}}