{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/214708308","pull_request_review_id":151819517,"id":214708308,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDcwODMwOA==","diff_hunk":"@@ -83,7 +83,7 @@ In case when `indicesLength` has value 1, the result string will be \"`1 index`\".\n \n The message ids chosen for message keys should always be descriptive of the string, and its role in the interface (button label, title, etc.). Think of them as long variable names. When you have to change a message id, adding a progressive number to the existing key should always be used as a last resort.\n \n-- Message id should start with namespace (`kbn`, `common.ui` and etc.). \n+- Message id should start with namespace (`kbn`, `common.ui` and etc.) that identifies a plugin. ","path":"packages/kbn-i18n/GUIDELINE.md","position":41,"original_position":41,"commit_id":"d77485f7af1986739ea69d4f5c8c54b55e160076","original_commit_id":"d77485f7af1986739ea69d4f5c8c54b55e160076","user":{"login":"azasypkin","id":1713708,"node_id":"MDQ6VXNlcjE3MTM3MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1713708?v=4","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"__nit:__ `a plugin` - not necessarily, we also have `common.ui` that isn't a plugin. Maybe something like \"Message id should start with namespace that identifies a functional area of the app (`common.ui` or `common.server`) or a plugin (`kbn`, `vega` etc.).\" or something along these lines.","created_at":"2018-09-03T14:35:13Z","updated_at":"2018-09-03T14:50:10Z","html_url":"https://github.com/elastic/kibana/pull/22450#discussion_r214708308","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/22450","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/214708308"},"html":{"href":"https://github.com/elastic/kibana/pull/22450#discussion_r214708308"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22450"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/22450","id":211408642,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDA4NjQy","html_url":"https://github.com/elastic/kibana/pull/22450","diff_url":"https://github.com/elastic/kibana/pull/22450.diff","patch_url":"https://github.com/elastic/kibana/pull/22450.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/22450","number":22450,"state":"open","locked":false,"title":"Update Guideline","user":{"login":"maryia-lapata","id":11524637,"node_id":"MDQ6VXNlcjExNTI0NjM3","avatar_url":"https://avatars3.githubusercontent.com/u/11524637?v=4","gravatar_id":"","url":"https://api.github.com/users/maryia-lapata","html_url":"https://github.com/maryia-lapata","followers_url":"https://api.github.com/users/maryia-lapata/followers","following_url":"https://api.github.com/users/maryia-lapata/following{/other_user}","gists_url":"https://api.github.com/users/maryia-lapata/gists{/gist_id}","starred_url":"https://api.github.com/users/maryia-lapata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryia-lapata/subscriptions","organizations_url":"https://api.github.com/users/maryia-lapata/orgs","repos_url":"https://api.github.com/users/maryia-lapata/repos","events_url":"https://api.github.com/users/maryia-lapata/events{/privacy}","received_events_url":"https://api.github.com/users/maryia-lapata/received_events","type":"User","site_admin":false},"body":"Add to  i18n engine Guideline reference to new `mountWithIntl` function defined in `test_utils/enzyme_helpers` and clarify message ids.","created_at":"2018-08-28T12:42:39Z","updated_at":"2018-09-03T14:50:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a59a20a52aeb302a3b1314e7297f71fcab3de280","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pavel06081991","id":7793321,"node_id":"MDQ6VXNlcjc3OTMzMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/7793321?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel06081991","html_url":"https://github.com/pavel06081991","followers_url":"https://api.github.com/users/pavel06081991/followers","following_url":"https://api.github.com/users/pavel06081991/following{/other_user}","gists_url":"https://api.github.com/users/pavel06081991/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel06081991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel06081991/subscriptions","organizations_url":"https://api.github.com/users/pavel06081991/orgs","repos_url":"https://api.github.com/users/pavel06081991/repos","events_url":"https://api.github.com/users/pavel06081991/events{/privacy}","received_events_url":"https://api.github.com/users/pavel06081991/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":470241278,"node_id":"MDU6TGFiZWw0NzAyNDEyNzg=","url":"https://api.github.com/repos/elastic/kibana/labels/:Platform","name":":Platform","color":"fef2c0","default":false},{"id":548254520,"node_id":"MDU6TGFiZWw1NDgyNTQ1MjA=","url":"https://api.github.com/repos/elastic/kibana/labels/:i18n","name":":i18n","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/22450/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/22450/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/22450/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/d77485f7af1986739ea69d4f5c8c54b55e160076","head":{"label":"maryia-lapata:feature/translations/guideline","ref":"feature/translations/guideline","sha":"d77485f7af1986739ea69d4f5c8c54b55e160076","user":{"login":"maryia-lapata","id":11524637,"node_id":"MDQ6VXNlcjExNTI0NjM3","avatar_url":"https://avatars3.githubusercontent.com/u/11524637?v=4","gravatar_id":"","url":"https://api.github.com/users/maryia-lapata","html_url":"https://github.com/maryia-lapata","followers_url":"https://api.github.com/users/maryia-lapata/followers","following_url":"https://api.github.com/users/maryia-lapata/following{/other_user}","gists_url":"https://api.github.com/users/maryia-lapata/gists{/gist_id}","starred_url":"https://api.github.com/users/maryia-lapata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryia-lapata/subscriptions","organizations_url":"https://api.github.com/users/maryia-lapata/orgs","repos_url":"https://api.github.com/users/maryia-lapata/repos","events_url":"https://api.github.com/users/maryia-lapata/events{/privacy}","received_events_url":"https://api.github.com/users/maryia-lapata/received_events","type":"User","site_admin":false},"repo":{"id":136018840,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMTg4NDA=","name":"kibana","full_name":"maryia-lapata/kibana","owner":{"login":"maryia-lapata","id":11524637,"node_id":"MDQ6VXNlcjExNTI0NjM3","avatar_url":"https://avatars3.githubusercontent.com/u/11524637?v=4","gravatar_id":"","url":"https://api.github.com/users/maryia-lapata","html_url":"https://github.com/maryia-lapata","followers_url":"https://api.github.com/users/maryia-lapata/followers","following_url":"https://api.github.com/users/maryia-lapata/following{/other_user}","gists_url":"https://api.github.com/users/maryia-lapata/gists{/gist_id}","starred_url":"https://api.github.com/users/maryia-lapata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryia-lapata/subscriptions","organizations_url":"https://api.github.com/users/maryia-lapata/orgs","repos_url":"https://api.github.com/users/maryia-lapata/repos","events_url":"https://api.github.com/users/maryia-lapata/events{/privacy}","received_events_url":"https://api.github.com/users/maryia-lapata/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maryia-lapata/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/maryia-lapata/kibana","forks_url":"https://api.github.com/repos/maryia-lapata/kibana/forks","keys_url":"https://api.github.com/repos/maryia-lapata/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maryia-lapata/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maryia-lapata/kibana/teams","hooks_url":"https://api.github.com/repos/maryia-lapata/kibana/hooks","issue_events_url":"https://api.github.com/repos/maryia-lapata/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/maryia-lapata/kibana/events","assignees_url":"https://api.github.com/repos/maryia-lapata/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/maryia-lapata/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/maryia-lapata/kibana/tags","blobs_url":"https://api.github.com/repos/maryia-lapata/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maryia-lapata/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maryia-lapata/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/maryia-lapata/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maryia-lapata/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/maryia-lapata/kibana/languages","stargazers_url":"https://api.github.com/repos/maryia-lapata/kibana/stargazers","contributors_url":"https://api.github.com/repos/maryia-lapata/kibana/contributors","subscribers_url":"https://api.github.com/repos/maryia-lapata/kibana/subscribers","subscription_url":"https://api.github.com/repos/maryia-lapata/kibana/subscription","commits_url":"https://api.github.com/repos/maryia-lapata/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/maryia-lapata/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/maryia-lapata/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/maryia-lapata/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/maryia-lapata/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/maryia-lapata/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maryia-lapata/kibana/merges","archive_url":"https://api.github.com/repos/maryia-lapata/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maryia-lapata/kibana/downloads","issues_url":"https://api.github.com/repos/maryia-lapata/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/maryia-lapata/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/maryia-lapata/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/maryia-lapata/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maryia-lapata/kibana/labels{/name}","releases_url":"https://api.github.com/repos/maryia-lapata/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/maryia-lapata/kibana/deployments","created_at":"2018-06-04T12:02:37Z","updated_at":"2018-09-03T13:11:37Z","pushed_at":"2018-09-03T13:12:18Z","git_url":"git://github.com/maryia-lapata/kibana.git","ssh_url":"git@github.com:maryia-lapata/kibana.git","clone_url":"https://github.com/maryia-lapata/kibana.git","svn_url":"https://github.com/maryia-lapata/kibana","homepage":"https://www.elastic.co/products/kibana","size":446421,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"11d6e537068f9c9a4ca90169dab41d0018ba2bc0","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-09-03T12:53:52Z","pushed_at":"2018-09-03T14:50:01Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":451032,"stargazers_count":10012,"watchers_count":10012,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3886,"mirror_url":null,"archived":false,"open_issues_count":3376,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3886,"open_issues":3376,"watchers":10012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22450"},"html":{"href":"https://github.com/elastic/kibana/pull/22450"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/22450"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/22450/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22450/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22450/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/d77485f7af1986739ea69d4f5c8c54b55e160076"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"azasypkin"}}