{"action":"created","issue":{"url":"https://api.github.com/repos/bolt-design-system/bolt/issues/848","repository_url":"https://api.github.com/repos/bolt-design-system/bolt","labels_url":"https://api.github.com/repos/bolt-design-system/bolt/issues/848/labels{/name}","comments_url":"https://api.github.com/repos/bolt-design-system/bolt/issues/848/comments","events_url":"https://api.github.com/repos/bolt-design-system/bolt/issues/848/events","html_url":"https://github.com/bolt-design-system/bolt/pull/848","id":353581357,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTk2NTI5","number":848,"title":"Share component code cleanup and refactor","user":{"login":"mikemai2awesome","id":3027663,"node_id":"MDQ6VXNlcjMwMjc2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3027663?v=4","gravatar_id":"","url":"https://api.github.com/users/mikemai2awesome","html_url":"https://github.com/mikemai2awesome","followers_url":"https://api.github.com/users/mikemai2awesome/followers","following_url":"https://api.github.com/users/mikemai2awesome/following{/other_user}","gists_url":"https://api.github.com/users/mikemai2awesome/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemai2awesome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemai2awesome/subscriptions","organizations_url":"https://api.github.com/users/mikemai2awesome/orgs","repos_url":"https://api.github.com/users/mikemai2awesome/repos","events_url":"https://api.github.com/users/mikemai2awesome/events{/privacy}","received_events_url":"https://api.github.com/users/mikemai2awesome/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-23T22:48:27Z","updated_at":"2018-08-23T23:27:39Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/bolt-design-system/bolt/pulls/848","html_url":"https://github.com/bolt-design-system/bolt/pull/848","diff_url":"https://github.com/bolt-design-system/bolt/pull/848.diff","patch_url":"https://github.com/bolt-design-system/bolt/pull/848.patch"},"body":"## Jira\r\n\r\nhttp://vjira2:8080/browse/BDS-311\r\n\r\n## Summary\r\n\r\nRefactored share component's code to be more efficient.\r\n\r\n## Details\r\n\r\n1. Cleaned up the CSS and twig file.\r\n2. Removed as much overrides as possible.\r\n3. Followed the Bolt conventions and renamed certain props and variables.\r\n4. I pulled in the bolt-list branch https://github.com/bolt-design-system/bolt/pull/842 here, so I can use the newly built component.\r\n\r\n[View demo](https://feature-bds-311-share-component-refactor.bolt-design-system.com/pattern-lab/?p=viewall-components-share)\r\n\r\n<img width=\"893\" alt=\"screen shot 2018-08-23 at 6 47 00 pm\" src=\"https://user-images.githubusercontent.com/3027663/44555811-f7914280-a704-11e8-9014-99a09cb8b51b.png\">\r\n\r\n\r\n## How to test\r\n\r\nPull down the branch and run locally. Navigate to pattern lab and view the share component. Test all the links and copy to clipboard function.\r\n\r\n## Notes\r\n\r\n1. I still don't feel this is as clean as it should be, please do a thorough code review and point out your concerns.\r\n2. While refactoring the share component, I feel that the following components are below our standards and also need a revamp, they are not flexible and hard to use:\r\n    * Tooltip\r\n    * Copy to clipboard\r\n    * Link\r\n"},"comment":{"url":"https://api.github.com/repos/bolt-design-system/bolt/issues/comments/415604606","html_url":"https://github.com/bolt-design-system/bolt/pull/848#issuecomment-415604606","issue_url":"https://api.github.com/repos/bolt-design-system/bolt/issues/848","id":415604606,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTYwNDYwNg==","user":{"login":"bolt-bot","id":36777128,"node_id":"MDQ6VXNlcjM2Nzc3MTI4","avatar_url":"https://avatars0.githubusercontent.com/u/36777128?v=4","gravatar_id":"","url":"https://api.github.com/users/bolt-bot","html_url":"https://github.com/bolt-bot","followers_url":"https://api.github.com/users/bolt-bot/followers","following_url":"https://api.github.com/users/bolt-bot/following{/other_user}","gists_url":"https://api.github.com/users/bolt-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/bolt-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolt-bot/subscriptions","organizations_url":"https://api.github.com/users/bolt-bot/orgs","repos_url":"https://api.github.com/users/bolt-bot/repos","events_url":"https://api.github.com/users/bolt-bot/events{/privacy}","received_events_url":"https://api.github.com/users/bolt-bot/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T23:27:39Z","updated_at":"2018-08-23T23:27:39Z","author_association":"COLLABORATOR","body":":zap: PR built on Travis and deployed a now preview here:\n\n- Branch link: https://feature-bds-311-share-component-refactor.bolt-design-system.com\n- Permalink: https://bolt-design-system-ovdmubdwps.now.sh\n\n<details>\n\n- Commit built: 14e89dd2ac5393ed880809a340b7ad79e11a1804\n- [Travis build](https://travis-ci.org/bolt-design-system/bolt/builds/419891766)\n\n</details>"}}
{"actor":{"display_login":"bolt-bot"}}