{"action":"created","issue":{"url":"https://api.github.com/repos/jsonata-js/jsonata/issues/219","repository_url":"https://api.github.com/repos/jsonata-js/jsonata","labels_url":"https://api.github.com/repos/jsonata-js/jsonata/issues/219/labels{/name}","comments_url":"https://api.github.com/repos/jsonata-js/jsonata/issues/219/comments","events_url":"https://api.github.com/repos/jsonata-js/jsonata/issues/219/events","html_url":"https://github.com/jsonata-js/jsonata/pull/219","id":321910734,"number":219,"title":"async driver for full test suite, and fix all failing cases","user":{"login":"andrew-coleman","id":7985120,"avatar_url":"https://avatars1.githubusercontent.com/u/7985120?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-coleman","html_url":"https://github.com/andrew-coleman","followers_url":"https://api.github.com/users/andrew-coleman/followers","following_url":"https://api.github.com/users/andrew-coleman/following{/other_user}","gists_url":"https://api.github.com/users/andrew-coleman/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-coleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-coleman/subscriptions","organizations_url":"https://api.github.com/users/andrew-coleman/orgs","repos_url":"https://api.github.com/users/andrew-coleman/repos","events_url":"https://api.github.com/users/andrew-coleman/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-coleman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-10T12:15:17Z","updated_at":"2018-05-10T12:33:39Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/jsonata-js/jsonata/pulls/219","html_url":"https://github.com/jsonata-js/jsonata/pull/219","diff_url":"https://github.com/jsonata-js/jsonata/pull/219.diff","patch_url":"https://github.com/jsonata-js/jsonata/pull/219.patch"},"body":"Created a test driver to run the test suite in async mode\r\nFixed all failing test cases.  These all involved functions which needed to asynchronously invoke the evaluator (such as the higher-order functions, the sort syntax & function chaining operator)\r\n\r\nresolves #217 "},"comment":{"url":"https://api.github.com/repos/jsonata-js/jsonata/issues/comments/388040222","html_url":"https://github.com/jsonata-js/jsonata/pull/219#issuecomment-388040222","issue_url":"https://api.github.com/repos/jsonata-js/jsonata/issues/219","id":388040222,"user":{"login":"xogeny","id":1498808,"avatar_url":"https://avatars1.githubusercontent.com/u/1498808?v=4","gravatar_id":"","url":"https://api.github.com/users/xogeny","html_url":"https://github.com/xogeny","followers_url":"https://api.github.com/users/xogeny/followers","following_url":"https://api.github.com/users/xogeny/following{/other_user}","gists_url":"https://api.github.com/users/xogeny/gists{/gist_id}","starred_url":"https://api.github.com/users/xogeny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xogeny/subscriptions","organizations_url":"https://api.github.com/users/xogeny/orgs","repos_url":"https://api.github.com/users/xogeny/repos","events_url":"https://api.github.com/users/xogeny/events{/privacy}","received_events_url":"https://api.github.com/users/xogeny/received_events","type":"User","site_admin":false},"created_at":"2018-05-10T12:33:39Z","updated_at":"2018-05-10T12:33:39Z","author_association":"CONTRIBUTOR","body":"As far as I can tell (correct me if I'm wrong), the change here is to pass a callback to JSONata.  I think more rigor should be employed here.  For example, passing the dataset as a Promise and the bindings as Promises as well.  Ideally, also including variations that do the same with generators.\r\n\r\nIn analyzing this myself, my thinking was that there are essentially 3 fundamental sources for values in JSONata (again, correct me if I'm wrong).  Those are input data set, bindings and results from function evaluations.  It is those cases where we have to check whether something is a \"normal\" value, a Promise or a generator.  So my point here is that it seems that your change looks at the function return values.  But it doesn't exercise the other two cases.  Am I correct?"}}
{"actor":{"display_login":"xogeny"}}