{"action":"closed","number":365,"pull_request":{"url":"https://api.github.com/repos/Shopify/identity_cache/pulls/365","id":175099654,"html_url":"https://github.com/Shopify/identity_cache/pull/365","diff_url":"https://github.com/Shopify/identity_cache/pull/365.diff","patch_url":"https://github.com/Shopify/identity_cache/pull/365.patch","issue_url":"https://api.github.com/repos/Shopify/identity_cache/issues/365","number":365,"state":"closed","locked":false,"title":"Handle missing constants as misses","user":{"login":"denislins","id":832802,"avatar_url":"https://avatars0.githubusercontent.com/u/832802?v=4","gravatar_id":"","url":"https://api.github.com/users/denislins","html_url":"https://github.com/denislins","followers_url":"https://api.github.com/users/denislins/followers","following_url":"https://api.github.com/users/denislins/following{/other_user}","gists_url":"https://api.github.com/users/denislins/gists{/gist_id}","starred_url":"https://api.github.com/users/denislins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denislins/subscriptions","organizations_url":"https://api.github.com/users/denislins/orgs","repos_url":"https://api.github.com/users/denislins/repos","events_url":"https://api.github.com/users/denislins/events{/privacy}","received_events_url":"https://api.github.com/users/denislins/received_events","type":"User","site_admin":false},"body":"While caching embedded associations, IDC caches the model names (aka constants) inside the cache blob. However, when fetching the data a constant might not exist anymore, i.e. it might have been moved, or deleted. This currently raises a `NameError`.\r\n\r\nThis PR aims to fix this issue by handling these cases as normal misses, hitting the database to fetch the requested data. This also deletes the key from the cache since it's no longer valid.","created_at":"2018-03-14T22:12:15Z","updated_at":"2018-03-15T17:58:42Z","closed_at":"2018-03-15T17:58:42Z","merged_at":null,"merge_commit_sha":"d7123b3cf1dab23ef36163ee8cf77a97b3667979","assignee":{"login":"denislins","id":832802,"avatar_url":"https://avatars0.githubusercontent.com/u/832802?v=4","gravatar_id":"","url":"https://api.github.com/users/denislins","html_url":"https://github.com/denislins","followers_url":"https://api.github.com/users/denislins/followers","following_url":"https://api.github.com/users/denislins/following{/other_user}","gists_url":"https://api.github.com/users/denislins/gists{/gist_id}","starred_url":"https://api.github.com/users/denislins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denislins/subscriptions","organizations_url":"https://api.github.com/users/denislins/orgs","repos_url":"https://api.github.com/users/denislins/repos","events_url":"https://api.github.com/users/denislins/events{/privacy}","received_events_url":"https://api.github.com/users/denislins/received_events","type":"User","site_admin":false},"assignees":[{"login":"denislins","id":832802,"avatar_url":"https://avatars0.githubusercontent.com/u/832802?v=4","gravatar_id":"","url":"https://api.github.com/users/denislins","html_url":"https://github.com/denislins","followers_url":"https://api.github.com/users/denislins/followers","following_url":"https://api.github.com/users/denislins/following{/other_user}","gists_url":"https://api.github.com/users/denislins/gists{/gist_id}","starred_url":"https://api.github.com/users/denislins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denislins/subscriptions","organizations_url":"https://api.github.com/users/denislins/orgs","repos_url":"https://api.github.com/users/denislins/repos","events_url":"https://api.github.com/users/denislins/events{/privacy}","received_events_url":"https://api.github.com/users/denislins/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars3.githubusercontent.com/u/47848?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},{"login":"dylanahsmith","id":954402,"avatar_url":"https://avatars3.githubusercontent.com/u/954402?v=4","gravatar_id":"","url":"https://api.github.com/users/dylanahsmith","html_url":"https://github.com/dylanahsmith","followers_url":"https://api.github.com/users/dylanahsmith/followers","following_url":"https://api.github.com/users/dylanahsmith/following{/other_user}","gists_url":"https://api.github.com/users/dylanahsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/dylanahsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylanahsmith/subscriptions","organizations_url":"https://api.github.com/users/dylanahsmith/orgs","repos_url":"https://api.github.com/users/dylanahsmith/repos","events_url":"https://api.github.com/users/dylanahsmith/events{/privacy}","received_events_url":"https://api.github.com/users/dylanahsmith/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":30066430,"url":"https://api.github.com/repos/Shopify/identity_cache/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/identity_cache/pulls/365/commits","review_comments_url":"https://api.github.com/repos/Shopify/identity_cache/pulls/365/comments","review_comment_url":"https://api.github.com/repos/Shopify/identity_cache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/identity_cache/issues/365/comments","statuses_url":"https://api.github.com/repos/Shopify/identity_cache/statuses/3efb10d5598e0a0e42c3e040441e35c0a7c8ffb6","head":{"label":"Shopify:missing-costants","ref":"missing-costants","sha":"3efb10d5598e0a0e42c3e040441e35c0a7c8ffb6","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":8472417,"name":"identity_cache","full_name":"Shopify/identity_cache","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/identity_cache","description":"IdentityCache is a blob level caching solution to plug into ActiveRecord. Don't #find, #fetch!","fork":false,"url":"https://api.github.com/repos/Shopify/identity_cache","forks_url":"https://api.github.com/repos/Shopify/identity_cache/forks","keys_url":"https://api.github.com/repos/Shopify/identity_cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/identity_cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/identity_cache/teams","hooks_url":"https://api.github.com/repos/Shopify/identity_cache/hooks","issue_events_url":"https://api.github.com/repos/Shopify/identity_cache/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/identity_cache/events","assignees_url":"https://api.github.com/repos/Shopify/identity_cache/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/identity_cache/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/identity_cache/tags","blobs_url":"https://api.github.com/repos/Shopify/identity_cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/identity_cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/identity_cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/identity_cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/identity_cache/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/identity_cache/languages","stargazers_url":"https://api.github.com/repos/Shopify/identity_cache/stargazers","contributors_url":"https://api.github.com/repos/Shopify/identity_cache/contributors","subscribers_url":"https://api.github.com/repos/Shopify/identity_cache/subscribers","subscription_url":"https://api.github.com/repos/Shopify/identity_cache/subscription","commits_url":"https://api.github.com/repos/Shopify/identity_cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/identity_cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/identity_cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/identity_cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/identity_cache/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/identity_cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/identity_cache/merges","archive_url":"https://api.github.com/repos/Shopify/identity_cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/identity_cache/downloads","issues_url":"https://api.github.com/repos/Shopify/identity_cache/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/identity_cache/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/identity_cache/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/identity_cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/identity_cache/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/identity_cache/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/identity_cache/deployments","created_at":"2013-02-28T05:19:14Z","updated_at":"2018-03-14T22:51:34Z","pushed_at":"2018-03-15T17:58:42Z","git_url":"git://github.com/Shopify/identity_cache.git","ssh_url":"git@github.com:Shopify/identity_cache.git","clone_url":"https://github.com/Shopify/identity_cache.git","svn_url":"https://github.com/Shopify/identity_cache","homepage":"http://shopify.github.io/identity_cache","size":778,"stargazers_count":1406,"watchers_count":1406,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":148,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":148,"open_issues":19,"watchers":1406,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"58064226361d3e8991722555a1bbb9455dd3abcd","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":8472417,"name":"identity_cache","full_name":"Shopify/identity_cache","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/identity_cache","description":"IdentityCache is a blob level caching solution to plug into ActiveRecord. Don't #find, #fetch!","fork":false,"url":"https://api.github.com/repos/Shopify/identity_cache","forks_url":"https://api.github.com/repos/Shopify/identity_cache/forks","keys_url":"https://api.github.com/repos/Shopify/identity_cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/identity_cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/identity_cache/teams","hooks_url":"https://api.github.com/repos/Shopify/identity_cache/hooks","issue_events_url":"https://api.github.com/repos/Shopify/identity_cache/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/identity_cache/events","assignees_url":"https://api.github.com/repos/Shopify/identity_cache/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/identity_cache/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/identity_cache/tags","blobs_url":"https://api.github.com/repos/Shopify/identity_cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/identity_cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/identity_cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/identity_cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/identity_cache/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/identity_cache/languages","stargazers_url":"https://api.github.com/repos/Shopify/identity_cache/stargazers","contributors_url":"https://api.github.com/repos/Shopify/identity_cache/contributors","subscribers_url":"https://api.github.com/repos/Shopify/identity_cache/subscribers","subscription_url":"https://api.github.com/repos/Shopify/identity_cache/subscription","commits_url":"https://api.github.com/repos/Shopify/identity_cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/identity_cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/identity_cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/identity_cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/identity_cache/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/identity_cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/identity_cache/merges","archive_url":"https://api.github.com/repos/Shopify/identity_cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/identity_cache/downloads","issues_url":"https://api.github.com/repos/Shopify/identity_cache/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/identity_cache/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/identity_cache/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/identity_cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/identity_cache/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/identity_cache/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/identity_cache/deployments","created_at":"2013-02-28T05:19:14Z","updated_at":"2018-03-14T22:51:34Z","pushed_at":"2018-03-15T17:58:42Z","git_url":"git://github.com/Shopify/identity_cache.git","ssh_url":"git@github.com:Shopify/identity_cache.git","clone_url":"https://github.com/Shopify/identity_cache.git","svn_url":"https://github.com/Shopify/identity_cache","homepage":"http://shopify.github.io/identity_cache","size":778,"stargazers_count":1406,"watchers_count":1406,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":148,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":148,"open_issues":19,"watchers":1406,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/identity_cache/pulls/365"},"html":{"href":"https://github.com/Shopify/identity_cache/pull/365"},"issue":{"href":"https://api.github.com/repos/Shopify/identity_cache/issues/365"},"comments":{"href":"https://api.github.com/repos/Shopify/identity_cache/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/identity_cache/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/identity_cache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/identity_cache/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/identity_cache/statuses/3efb10d5598e0a0e42c3e040441e35c0a7c8ffb6"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":110,"deletions":18,"changed_files":3}}
{"actor":{"display_login":"dylanahsmith"}}