{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleContainerTools/krew/issues/60","repository_url":"https://api.github.com/repos/GoogleContainerTools/krew","labels_url":"https://api.github.com/repos/GoogleContainerTools/krew/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/GoogleContainerTools/krew/issues/60/comments","events_url":"https://api.github.com/repos/GoogleContainerTools/krew/issues/60/events","html_url":"https://github.com/GoogleContainerTools/krew/pull/60","id":363839077,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTc1MDM2","number":60,"title":"Convert dashes in plugin names to underscores","user":{"login":"ahmetb","id":159209,"node_id":"MDQ6VXNlcjE1OTIwOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/159209?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmetb","html_url":"https://github.com/ahmetb","followers_url":"https://api.github.com/users/ahmetb/followers","following_url":"https://api.github.com/users/ahmetb/following{/other_user}","gists_url":"https://api.github.com/users/ahmetb/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetb/subscriptions","organizations_url":"https://api.github.com/users/ahmetb/orgs","repos_url":"https://api.github.com/users/ahmetb/repos","events_url":"https://api.github.com/users/ahmetb/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetb/received_events","type":"User","site_admin":false},"labels":[{"id":992070376,"node_id":"MDU6TGFiZWw5OTIwNzAzNzY=","url":"https://api.github.com/repos/GoogleContainerTools/krew/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-26T02:57:51Z","updated_at":"2018-09-26T03:00:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/GoogleContainerTools/krew/pulls/60","html_url":"https://github.com/GoogleContainerTools/krew/pull/60","diff_url":"https://github.com/GoogleContainerTools/krew/pull/60.diff","patch_url":"https://github.com/GoogleContainerTools/krew/pull/60.patch"},"body":"For dashes to be preserved in a plugin's name, its executable name must convert\r\ndashes to underscores.\r\n\r\nFor example a plugin named \"foo-bar\" would today be linked as:\r\n\r\n    kubectl-foo-bar\r\n\r\ntherefore, it can only be invoked as:\r\n\r\n    kubectl foo bar\r\n\r\nHowever, linking the same plugin as:\r\n\r\n    kubectl-foo_bar\r\n\r\nallows plugin to be called as:\r\n\r\n    kubectl foo-bar\r\n    kubectl foo_bar\r\n\r\n- convert OS detection pluginNameToBin() to explicit input for testability\r\n- test pluginNameToBin().\r\n\r\nFixes #59."},"comment":{"url":"https://api.github.com/repos/GoogleContainerTools/krew/issues/comments/424568524","html_url":"https://github.com/GoogleContainerTools/krew/pull/60#issuecomment-424568524","issue_url":"https://api.github.com/repos/GoogleContainerTools/krew/issues/60","id":424568524,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDU2ODUyNA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-09-26T03:00:39Z","updated_at":"2018-09-26T03:00:39Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/GoogleContainerTools/krew/pull/60?src=pr&el=h1) Report\n> Merging [#60](https://codecov.io/gh/GoogleContainerTools/krew/pull/60?src=pr&el=desc) into [master](https://codecov.io/gh/GoogleContainerTools/krew/commit/ebd19c43ed4a64529752a05127a08fb85c3c4ad5?src=pr&el=desc) will **increase** coverage by `0.63%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/GoogleContainerTools/krew/pull/60/graphs/tree.svg?width=650&token=J3nFtARI2m&height=150&src=pr)](https://codecov.io/gh/GoogleContainerTools/krew/pull/60?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master      #60      +/-   ##\n==========================================\n+ Coverage   40.72%   41.36%   +0.63%     \n==========================================\n  Files          12       12              \n  Lines         496      498       +2     \n==========================================\n+ Hits          202      206       +4     \n+ Misses        256      255       -1     \n+ Partials       38       37       -1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/GoogleContainerTools/krew/pull/60?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [pkg/installation/util.go](https://codecov.io/gh/GoogleContainerTools/krew/pull/60/diff?src=pr&el=tree#diff-cGtnL2luc3RhbGxhdGlvbi91dGlsLmdv) | `60% <100%> (ø)` | :arrow_up: |\n| [pkg/installation/install.go](https://codecov.io/gh/GoogleContainerTools/krew/pull/60/diff?src=pr&el=tree#diff-cGtnL2luc3RhbGxhdGlvbi9pbnN0YWxsLmdv) | `22.07% <100%> (+4.74%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/GoogleContainerTools/krew/pull/60?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/GoogleContainerTools/krew/pull/60?src=pr&el=footer). Last update [ebd19c4...a0631a4](https://codecov.io/gh/GoogleContainerTools/krew/pull/60?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}