{"action":"created","issue":{"url":"https://api.github.com/repos/srlanalytics/BDFM/issues/21","repository_url":"https://api.github.com/repos/srlanalytics/BDFM","labels_url":"https://api.github.com/repos/srlanalytics/BDFM/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/srlanalytics/BDFM/issues/21/comments","events_url":"https://api.github.com/repos/srlanalytics/BDFM/issues/21/events","html_url":"https://github.com/srlanalytics/BDFM/pull/21","id":382874230,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDc5NjA0","number":21,"title":"Seas adj we","user":{"login":"christophsax","id":1390827,"node_id":"MDQ6VXNlcjEzOTA4Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/1390827?v=4","gravatar_id":"","url":"https://api.github.com/users/christophsax","html_url":"https://github.com/christophsax","followers_url":"https://api.github.com/users/christophsax/followers","following_url":"https://api.github.com/users/christophsax/following{/other_user}","gists_url":"https://api.github.com/users/christophsax/gists{/gist_id}","starred_url":"https://api.github.com/users/christophsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophsax/subscriptions","organizations_url":"https://api.github.com/users/christophsax/orgs","repos_url":"https://api.github.com/users/christophsax/repos","events_url":"https://api.github.com/users/christophsax/events{/privacy}","received_events_url":"https://api.github.com/users/christophsax/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-20T22:28:24Z","updated_at":"2018-11-21T05:18:49Z","closed_at":"2018-11-21T01:47:27Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/srlanalytics/BDFM/pulls/21","html_url":"https://github.com/srlanalytics/BDFM/pull/21","diff_url":"https://github.com/srlanalytics/BDFM/pull/21.diff","patch_url":"https://github.com/srlanalytics/BDFM/pull/21.patch"},"body":"I guess *data.table* must be properly imported.\r\n\r\nAt the same time, on Line 556, the object to overwrite was `nn`, rather than `N`, so perhaps your error was just that.\r\n\r\nAnyway, I still will try to refactor the thing, perhaps we can do it efficiently without depending on *data.table*. But for the moment, let's keep it that way.\r\n"},"comment":{"url":"https://api.github.com/repos/srlanalytics/BDFM/issues/comments/440534378","html_url":"https://github.com/srlanalytics/BDFM/pull/21#issuecomment-440534378","issue_url":"https://api.github.com/repos/srlanalytics/BDFM/issues/21","id":440534378,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDUzNDM3OA==","user":{"login":"christophsax","id":1390827,"node_id":"MDQ6VXNlcjEzOTA4Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/1390827?v=4","gravatar_id":"","url":"https://api.github.com/users/christophsax","html_url":"https://github.com/christophsax","followers_url":"https://api.github.com/users/christophsax/followers","following_url":"https://api.github.com/users/christophsax/following{/other_user}","gists_url":"https://api.github.com/users/christophsax/gists{/gist_id}","starred_url":"https://api.github.com/users/christophsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophsax/subscriptions","organizations_url":"https://api.github.com/users/christophsax/orgs","repos_url":"https://api.github.com/users/christophsax/repos","events_url":"https://api.github.com/users/christophsax/events{/privacy}","received_events_url":"https://api.github.com/users/christophsax/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T05:18:49Z","updated_at":"2018-11-21T05:18:49Z","author_association":"COLLABORATOR","body":"Agreed: this looks like a weak reason to keep such a big dependency.\r\n\r\nIt is fine to delete merged branches: They are still kept somewhere on GitHub, and can be undeleted:\r\n\r\n<img width=\"730\" alt=\"image\" src=\"https://user-images.githubusercontent.com/1390827/48820368-f0ee8780-ed54-11e8-87fb-5de0612337ee.png\">\r\n\r\nThat makes it easier to keep an overview of the active branches.\r\n"}}
{"actor":{"display_login":"christophsax"}}