{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/210587629","pull_request_review_id":146833163,"id":210587629,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDU4NzYyOQ==","diff_hunk":"@@ -33,21 +33,23 @@\n ---\n module: cnos_backup\n author: \"Anil Kumar Muraleedharan (@amuraleedhar)\"\n-short_description: Backup the current running or startup configuration to a remote server on devices running Lenovo CNOS\n+short_description: Backup the current running or startup configuration to a\n+ remote server on devices running Lenovo CNOS\n description:\n     - This module allows you to work with switch configurations. It provides a\n      way to back up the running or startup configurations of a switch to a\n      remote server. This is achieved by periodically saving a copy of the\n      startup or running configuration of the network device to a remote server\n-     using FTP, SFTP, TFTP, or SCP. The first step is to create a directory from\n+     using FTP, SFTP, TFTP, or SCP. The first step is to create directory from","path":"lib/ansible/modules/network/cnos/cnos_backup.py","position":13,"original_position":13,"commit_id":"9e0a004f4f1ace6ed9ca9a6518f78b4c739d65fb","original_commit_id":"9e0a004f4f1ace6ed9ca9a6518f78b4c739d65fb","user":{"login":"Qalthos","id":649648,"node_id":"MDQ6VXNlcjY0OTY0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/649648?v=4","gravatar_id":"","url":"https://api.github.com/users/Qalthos","html_url":"https://github.com/Qalthos","followers_url":"https://api.github.com/users/Qalthos/followers","following_url":"https://api.github.com/users/Qalthos/following{/other_user}","gists_url":"https://api.github.com/users/Qalthos/gists{/gist_id}","starred_url":"https://api.github.com/users/Qalthos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qalthos/subscriptions","organizations_url":"https://api.github.com/users/Qalthos/orgs","repos_url":"https://api.github.com/users/Qalthos/repos","events_url":"https://api.github.com/users/Qalthos/events{/privacy}","received_events_url":"https://api.github.com/users/Qalthos/received_events","type":"User","site_admin":false},"body":"Did you mean to drop the word 'a' here?","created_at":"2018-08-16T13:08:10Z","updated_at":"2018-08-16T13:08:10Z","html_url":"https://github.com/ansible/ansible/pull/44246#discussion_r210587629","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/44246","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/210587629"},"html":{"href":"https://github.com/ansible/ansible/pull/44246#discussion_r210587629"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/44246"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/44246","id":208757665,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NzU3NjY1","html_url":"https://github.com/ansible/ansible/pull/44246","diff_url":"https://github.com/ansible/ansible/pull/44246.diff","patch_url":"https://github.com/ansible/ansible/pull/44246.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/44246","number":44246,"state":"open","locked":false,"title":"Update cnos_backup.py","user":{"login":"amuraleedhar","id":14107250,"node_id":"MDQ6VXNlcjE0MTA3MjUw","avatar_url":"https://avatars0.githubusercontent.com/u/14107250?v=4","gravatar_id":"","url":"https://api.github.com/users/amuraleedhar","html_url":"https://github.com/amuraleedhar","followers_url":"https://api.github.com/users/amuraleedhar/followers","following_url":"https://api.github.com/users/amuraleedhar/following{/other_user}","gists_url":"https://api.github.com/users/amuraleedhar/gists{/gist_id}","starred_url":"https://api.github.com/users/amuraleedhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuraleedhar/subscriptions","organizations_url":"https://api.github.com/users/amuraleedhar/orgs","repos_url":"https://api.github.com/users/amuraleedhar/repos","events_url":"https://api.github.com/users/amuraleedhar/events{/privacy}","received_events_url":"https://api.github.com/users/amuraleedhar/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nIn this PR I am moving the code which is in util file cnos.py to respective module code. There was a review comment is this regard that util file is of huge size. This is an effort to reduce the size.\r\n\r\nISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\nlib\\ansible\\modules\\network\\cnos\\cnos_backup.py\r\n\r\n##### ANSIBLE VERSION\r\nansible 2.7.0.dev0 (devel f9cbdcd) last updated 2018/07/03 14:55:43 (GMT +550)\r\nconfig file = /etc/ansible/ansible.cfg\r\nconfigured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\nansible python module location = /home/ansible/sheru/ansible/lib/ansible\r\nexecutable location = /home/ansible/sheru/ansible/bin/ansible\r\npython version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\nUnused code in cnos.py will be removed later together with few more modules","created_at":"2018-08-16T06:32:06Z","updated_at":"2018-08-16T13:08:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0c2ec9ba628fc8fda524257da4cd247ae950788","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":947190508,"node_id":"MDU6TGFiZWw5NDcxOTA1MDg=","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.7","name":"affects_2.7","color":"ededed","default":false},{"id":785271699,"node_id":"MDU6TGFiZWw3ODUyNzE2OTk=","url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":501518759,"node_id":"MDU6TGFiZWw1MDE1MTg3NTk=","url":"https://api.github.com/repos/ansible/ansible/labels/community_review","name":"community_review","color":"f9d0c4","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":503572087,"node_id":"MDU6TGFiZWw1MDM1NzIwODc=","url":"https://api.github.com/repos/ansible/ansible/labels/needs_triage","name":"needs_triage","color":"0e8a16","default":false},{"id":339653091,"node_id":"MDU6TGFiZWwzMzk2NTMwOTE=","url":"https://api.github.com/repos/ansible/ansible/labels/networking","name":"networking","color":"c7def8","default":false},{"id":499433698,"node_id":"MDU6TGFiZWw0OTk0MzM2OTg=","url":"https://api.github.com/repos/ansible/ansible/labels/owner_pr","name":"owner_pr","color":"0e8a16","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/44246/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/44246/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/44246/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/9e0a004f4f1ace6ed9ca9a6518f78b4c739d65fb","head":{"label":"amuraleedhar:patch-2","ref":"patch-2","sha":"9e0a004f4f1ace6ed9ca9a6518f78b4c739d65fb","user":{"login":"amuraleedhar","id":14107250,"node_id":"MDQ6VXNlcjE0MTA3MjUw","avatar_url":"https://avatars0.githubusercontent.com/u/14107250?v=4","gravatar_id":"","url":"https://api.github.com/users/amuraleedhar","html_url":"https://github.com/amuraleedhar","followers_url":"https://api.github.com/users/amuraleedhar/followers","following_url":"https://api.github.com/users/amuraleedhar/following{/other_user}","gists_url":"https://api.github.com/users/amuraleedhar/gists{/gist_id}","starred_url":"https://api.github.com/users/amuraleedhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuraleedhar/subscriptions","organizations_url":"https://api.github.com/users/amuraleedhar/orgs","repos_url":"https://api.github.com/users/amuraleedhar/repos","events_url":"https://api.github.com/users/amuraleedhar/events{/privacy}","received_events_url":"https://api.github.com/users/amuraleedhar/received_events","type":"User","site_admin":false},"repo":{"id":97096917,"node_id":"MDEwOlJlcG9zaXRvcnk5NzA5NjkxNw==","name":"ansible","full_name":"amuraleedhar/ansible","owner":{"login":"amuraleedhar","id":14107250,"node_id":"MDQ6VXNlcjE0MTA3MjUw","avatar_url":"https://avatars0.githubusercontent.com/u/14107250?v=4","gravatar_id":"","url":"https://api.github.com/users/amuraleedhar","html_url":"https://github.com/amuraleedhar","followers_url":"https://api.github.com/users/amuraleedhar/followers","following_url":"https://api.github.com/users/amuraleedhar/following{/other_user}","gists_url":"https://api.github.com/users/amuraleedhar/gists{/gist_id}","starred_url":"https://api.github.com/users/amuraleedhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuraleedhar/subscriptions","organizations_url":"https://api.github.com/users/amuraleedhar/orgs","repos_url":"https://api.github.com/users/amuraleedhar/repos","events_url":"https://api.github.com/users/amuraleedhar/events{/privacy}","received_events_url":"https://api.github.com/users/amuraleedhar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amuraleedhar/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/amuraleedhar/ansible","forks_url":"https://api.github.com/repos/amuraleedhar/ansible/forks","keys_url":"https://api.github.com/repos/amuraleedhar/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amuraleedhar/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amuraleedhar/ansible/teams","hooks_url":"https://api.github.com/repos/amuraleedhar/ansible/hooks","issue_events_url":"https://api.github.com/repos/amuraleedhar/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/amuraleedhar/ansible/events","assignees_url":"https://api.github.com/repos/amuraleedhar/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/amuraleedhar/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/amuraleedhar/ansible/tags","blobs_url":"https://api.github.com/repos/amuraleedhar/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amuraleedhar/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amuraleedhar/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/amuraleedhar/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amuraleedhar/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/amuraleedhar/ansible/languages","stargazers_url":"https://api.github.com/repos/amuraleedhar/ansible/stargazers","contributors_url":"https://api.github.com/repos/amuraleedhar/ansible/contributors","subscribers_url":"https://api.github.com/repos/amuraleedhar/ansible/subscribers","subscription_url":"https://api.github.com/repos/amuraleedhar/ansible/subscription","commits_url":"https://api.github.com/repos/amuraleedhar/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/amuraleedhar/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/amuraleedhar/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/amuraleedhar/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/amuraleedhar/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/amuraleedhar/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amuraleedhar/ansible/merges","archive_url":"https://api.github.com/repos/amuraleedhar/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amuraleedhar/ansible/downloads","issues_url":"https://api.github.com/repos/amuraleedhar/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/amuraleedhar/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/amuraleedhar/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/amuraleedhar/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amuraleedhar/ansible/labels{/name}","releases_url":"https://api.github.com/repos/amuraleedhar/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/amuraleedhar/ansible/deployments","created_at":"2017-07-13T08:07:40Z","updated_at":"2018-08-13T11:30:54Z","pushed_at":"2018-08-16T12:36:52Z","git_url":"git://github.com/amuraleedhar/ansible.git","ssh_url":"git@github.com:amuraleedhar/ansible.git","clone_url":"https://github.com/amuraleedhar/ansible.git","svn_url":"https://github.com/amuraleedhar/ansible","homepage":"http://ansible.com/","size":125152,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"f9d4e4d3961d36f127c290ea23d603b03b079ddf","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-08-16T13:00:44Z","pushed_at":"2018-08-16T13:03:31Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":136591,"stargazers_count":31995,"watchers_count":31995,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12427,"mirror_url":null,"archived":false,"open_issues_count":5481,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":12427,"open_issues":5481,"watchers":31995,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/44246"},"html":{"href":"https://github.com/ansible/ansible/pull/44246"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/44246"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/44246/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/44246/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/44246/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/9e0a004f4f1ace6ed9ca9a6518f78b4c739d65fb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Qalthos"}}