{"action":"created","comment":{"url":"https://api.github.com/repos/radusqrt/help-the-kids/pulls/comments/176687563","pull_request_review_id":106435039,"id":176687563,"diff_hunk":"@@ -0,0 +1,65 @@\n+% calculates Cholesky factorization, A = L * L'\n+% A must be symmetrical and positive-definite\n+function [L U x success] = Cholesky (A, b) \n+\n+\t[n n] = size(A); % get the size of the matrix A \n+\tL = zeros(n); % initialize the lower matrix of size N \n+\tsuccess = 0; % I haven't found the factorization yet\n+\t% I assume I can use Cholesky factorization\n+\tcan_apply_Cholesky = 1; \n+\tif A ~= A'\n+\t\t% A is not symmetrical\n+\t\tL = NaN;\n+\t\tU = NaN;\n+\t\tx = NaN;\n+\t\tsuccess = 0;\n+\t\treturn;\n+\tendif\n+\n+\t% check if A is positive definite \n+\tif IsPositiveDefinite(A) == 0\n+\t\tcan_apply_Cholesky = 0;\n+\tendif\n+\n+\tfor i = 1 : n","path":"MN/Algoritmi/LU/Cholesky/Cholesky.m","position":24,"original_position":24,"commit_id":"586a1a93ed4a225ffb0f221b1753c7cf396d7f70","original_commit_id":"586a1a93ed4a225ffb0f221b1753c7cf396d7f70","user":{"login":"radusqrt","id":8861522,"avatar_url":"https://avatars2.githubusercontent.com/u/8861522?v=4","gravatar_id":"","url":"https://api.github.com/users/radusqrt","html_url":"https://github.com/radusqrt","followers_url":"https://api.github.com/users/radusqrt/followers","following_url":"https://api.github.com/users/radusqrt/following{/other_user}","gists_url":"https://api.github.com/users/radusqrt/gists{/gist_id}","starred_url":"https://api.github.com/users/radusqrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radusqrt/subscriptions","organizations_url":"https://api.github.com/users/radusqrt/orgs","repos_url":"https://api.github.com/users/radusqrt/repos","events_url":"https://api.github.com/users/radusqrt/events{/privacy}","received_events_url":"https://api.github.com/users/radusqrt/received_events","type":"User","site_admin":false},"body":"sterge forul asta, il verifici deja in isPositiveDefinite(A)","created_at":"2018-03-23T10:07:55Z","updated_at":"2018-03-23T10:11:15Z","html_url":"https://github.com/radusqrt/help-the-kids/pull/10#discussion_r176687563","pull_request_url":"https://api.github.com/repos/radusqrt/help-the-kids/pulls/10","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/radusqrt/help-the-kids/pulls/comments/176687563"},"html":{"href":"https://github.com/radusqrt/help-the-kids/pull/10#discussion_r176687563"},"pull_request":{"href":"https://api.github.com/repos/radusqrt/help-the-kids/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/radusqrt/help-the-kids/pulls/10","id":176854572,"html_url":"https://github.com/radusqrt/help-the-kids/pull/10","diff_url":"https://github.com/radusqrt/help-the-kids/pull/10.diff","patch_url":"https://github.com/radusqrt/help-the-kids/pull/10.patch","issue_url":"https://api.github.com/repos/radusqrt/help-the-kids/issues/10","number":10,"state":"open","locked":false,"title":"Cholesky 3","user":{"login":"Poppy22","id":17204311,"avatar_url":"https://avatars3.githubusercontent.com/u/17204311?v=4","gravatar_id":"","url":"https://api.github.com/users/Poppy22","html_url":"https://github.com/Poppy22","followers_url":"https://api.github.com/users/Poppy22/followers","following_url":"https://api.github.com/users/Poppy22/following{/other_user}","gists_url":"https://api.github.com/users/Poppy22/gists{/gist_id}","starred_url":"https://api.github.com/users/Poppy22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poppy22/subscriptions","organizations_url":"https://api.github.com/users/Poppy22/orgs","repos_url":"https://api.github.com/users/Poppy22/repos","events_url":"https://api.github.com/users/Poppy22/events{/privacy}","received_events_url":"https://api.github.com/users/Poppy22/received_events","type":"User","site_admin":false},"body":"- Am adus modificarile mentionate. Cand testam, aveam o eroare cand apelez IsDiagonallyDominant in IsPositiveDefinite si nu stiu de la ce e.\r\n\r\n- La Cholesky mai verific sa fie pozitive elementele de pe diagonala principala, e ok?\r\n\r\n- Hmm... pot cumva sa dau re-pull request dintr-un pull request anterior dupa ce aduc modificari, sau trebuie sa il inchid si sa creez unul nou? \r\n\r\n- Chestia asta cu git e misto! ","created_at":"2018-03-22T17:30:40Z","updated_at":"2018-03-23T10:11:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9682f7530c3ec78bc0b089b6b7ef2ceb2fa167ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/radusqrt/help-the-kids/pulls/10/commits","review_comments_url":"https://api.github.com/repos/radusqrt/help-the-kids/pulls/10/comments","review_comment_url":"https://api.github.com/repos/radusqrt/help-the-kids/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radusqrt/help-the-kids/issues/10/comments","statuses_url":"https://api.github.com/repos/radusqrt/help-the-kids/statuses/586a1a93ed4a225ffb0f221b1753c7cf396d7f70","head":{"label":"Poppy22:master","ref":"master","sha":"586a1a93ed4a225ffb0f221b1753c7cf396d7f70","user":{"login":"Poppy22","id":17204311,"avatar_url":"https://avatars3.githubusercontent.com/u/17204311?v=4","gravatar_id":"","url":"https://api.github.com/users/Poppy22","html_url":"https://github.com/Poppy22","followers_url":"https://api.github.com/users/Poppy22/followers","following_url":"https://api.github.com/users/Poppy22/following{/other_user}","gists_url":"https://api.github.com/users/Poppy22/gists{/gist_id}","starred_url":"https://api.github.com/users/Poppy22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poppy22/subscriptions","organizations_url":"https://api.github.com/users/Poppy22/orgs","repos_url":"https://api.github.com/users/Poppy22/repos","events_url":"https://api.github.com/users/Poppy22/events{/privacy}","received_events_url":"https://api.github.com/users/Poppy22/received_events","type":"User","site_admin":false},"repo":{"id":126225062,"name":"help-the-kids","full_name":"Poppy22/help-the-kids","owner":{"login":"Poppy22","id":17204311,"avatar_url":"https://avatars3.githubusercontent.com/u/17204311?v=4","gravatar_id":"","url":"https://api.github.com/users/Poppy22","html_url":"https://github.com/Poppy22","followers_url":"https://api.github.com/users/Poppy22/followers","following_url":"https://api.github.com/users/Poppy22/following{/other_user}","gists_url":"https://api.github.com/users/Poppy22/gists{/gist_id}","starred_url":"https://api.github.com/users/Poppy22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poppy22/subscriptions","organizations_url":"https://api.github.com/users/Poppy22/orgs","repos_url":"https://api.github.com/users/Poppy22/repos","events_url":"https://api.github.com/users/Poppy22/events{/privacy}","received_events_url":"https://api.github.com/users/Poppy22/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Poppy22/help-the-kids","description":"Repository with the purpose of helping the young ones in need on their path to achieving the programmer wisdom.","fork":true,"url":"https://api.github.com/repos/Poppy22/help-the-kids","forks_url":"https://api.github.com/repos/Poppy22/help-the-kids/forks","keys_url":"https://api.github.com/repos/Poppy22/help-the-kids/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Poppy22/help-the-kids/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Poppy22/help-the-kids/teams","hooks_url":"https://api.github.com/repos/Poppy22/help-the-kids/hooks","issue_events_url":"https://api.github.com/repos/Poppy22/help-the-kids/issues/events{/number}","events_url":"https://api.github.com/repos/Poppy22/help-the-kids/events","assignees_url":"https://api.github.com/repos/Poppy22/help-the-kids/assignees{/user}","branches_url":"https://api.github.com/repos/Poppy22/help-the-kids/branches{/branch}","tags_url":"https://api.github.com/repos/Poppy22/help-the-kids/tags","blobs_url":"https://api.github.com/repos/Poppy22/help-the-kids/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Poppy22/help-the-kids/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Poppy22/help-the-kids/git/refs{/sha}","trees_url":"https://api.github.com/repos/Poppy22/help-the-kids/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Poppy22/help-the-kids/statuses/{sha}","languages_url":"https://api.github.com/repos/Poppy22/help-the-kids/languages","stargazers_url":"https://api.github.com/repos/Poppy22/help-the-kids/stargazers","contributors_url":"https://api.github.com/repos/Poppy22/help-the-kids/contributors","subscribers_url":"https://api.github.com/repos/Poppy22/help-the-kids/subscribers","subscription_url":"https://api.github.com/repos/Poppy22/help-the-kids/subscription","commits_url":"https://api.github.com/repos/Poppy22/help-the-kids/commits{/sha}","git_commits_url":"https://api.github.com/repos/Poppy22/help-the-kids/git/commits{/sha}","comments_url":"https://api.github.com/repos/Poppy22/help-the-kids/comments{/number}","issue_comment_url":"https://api.github.com/repos/Poppy22/help-the-kids/issues/comments{/number}","contents_url":"https://api.github.com/repos/Poppy22/help-the-kids/contents/{+path}","compare_url":"https://api.github.com/repos/Poppy22/help-the-kids/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Poppy22/help-the-kids/merges","archive_url":"https://api.github.com/repos/Poppy22/help-the-kids/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Poppy22/help-the-kids/downloads","issues_url":"https://api.github.com/repos/Poppy22/help-the-kids/issues{/number}","pulls_url":"https://api.github.com/repos/Poppy22/help-the-kids/pulls{/number}","milestones_url":"https://api.github.com/repos/Poppy22/help-the-kids/milestones{/number}","notifications_url":"https://api.github.com/repos/Poppy22/help-the-kids/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Poppy22/help-the-kids/labels{/name}","releases_url":"https://api.github.com/repos/Poppy22/help-the-kids/releases{/id}","deployments_url":"https://api.github.com/repos/Poppy22/help-the-kids/deployments","created_at":"2018-03-21T18:42:21Z","updated_at":"2018-03-23T10:03:53Z","pushed_at":"2018-03-23T10:03:52Z","git_url":"git://github.com/Poppy22/help-the-kids.git","ssh_url":"git@github.com:Poppy22/help-the-kids.git","clone_url":"https://github.com/Poppy22/help-the-kids.git","svn_url":"https://github.com/Poppy22/help-the-kids","homepage":null,"size":59,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"radusqrt:master","ref":"master","sha":"9d37d14b749a27635b4e3da644418022934e8f8e","user":{"login":"radusqrt","id":8861522,"avatar_url":"https://avatars2.githubusercontent.com/u/8861522?v=4","gravatar_id":"","url":"https://api.github.com/users/radusqrt","html_url":"https://github.com/radusqrt","followers_url":"https://api.github.com/users/radusqrt/followers","following_url":"https://api.github.com/users/radusqrt/following{/other_user}","gists_url":"https://api.github.com/users/radusqrt/gists{/gist_id}","starred_url":"https://api.github.com/users/radusqrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radusqrt/subscriptions","organizations_url":"https://api.github.com/users/radusqrt/orgs","repos_url":"https://api.github.com/users/radusqrt/repos","events_url":"https://api.github.com/users/radusqrt/events{/privacy}","received_events_url":"https://api.github.com/users/radusqrt/received_events","type":"User","site_admin":false},"repo":{"id":111743400,"name":"help-the-kids","full_name":"radusqrt/help-the-kids","owner":{"login":"radusqrt","id":8861522,"avatar_url":"https://avatars2.githubusercontent.com/u/8861522?v=4","gravatar_id":"","url":"https://api.github.com/users/radusqrt","html_url":"https://github.com/radusqrt","followers_url":"https://api.github.com/users/radusqrt/followers","following_url":"https://api.github.com/users/radusqrt/following{/other_user}","gists_url":"https://api.github.com/users/radusqrt/gists{/gist_id}","starred_url":"https://api.github.com/users/radusqrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radusqrt/subscriptions","organizations_url":"https://api.github.com/users/radusqrt/orgs","repos_url":"https://api.github.com/users/radusqrt/repos","events_url":"https://api.github.com/users/radusqrt/events{/privacy}","received_events_url":"https://api.github.com/users/radusqrt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radusqrt/help-the-kids","description":"Repository with the purpose of helping the young ones in need on their path to achieving the programmer wisdom.","fork":false,"url":"https://api.github.com/repos/radusqrt/help-the-kids","forks_url":"https://api.github.com/repos/radusqrt/help-the-kids/forks","keys_url":"https://api.github.com/repos/radusqrt/help-the-kids/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radusqrt/help-the-kids/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radusqrt/help-the-kids/teams","hooks_url":"https://api.github.com/repos/radusqrt/help-the-kids/hooks","issue_events_url":"https://api.github.com/repos/radusqrt/help-the-kids/issues/events{/number}","events_url":"https://api.github.com/repos/radusqrt/help-the-kids/events","assignees_url":"https://api.github.com/repos/radusqrt/help-the-kids/assignees{/user}","branches_url":"https://api.github.com/repos/radusqrt/help-the-kids/branches{/branch}","tags_url":"https://api.github.com/repos/radusqrt/help-the-kids/tags","blobs_url":"https://api.github.com/repos/radusqrt/help-the-kids/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radusqrt/help-the-kids/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radusqrt/help-the-kids/git/refs{/sha}","trees_url":"https://api.github.com/repos/radusqrt/help-the-kids/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radusqrt/help-the-kids/statuses/{sha}","languages_url":"https://api.github.com/repos/radusqrt/help-the-kids/languages","stargazers_url":"https://api.github.com/repos/radusqrt/help-the-kids/stargazers","contributors_url":"https://api.github.com/repos/radusqrt/help-the-kids/contributors","subscribers_url":"https://api.github.com/repos/radusqrt/help-the-kids/subscribers","subscription_url":"https://api.github.com/repos/radusqrt/help-the-kids/subscription","commits_url":"https://api.github.com/repos/radusqrt/help-the-kids/commits{/sha}","git_commits_url":"https://api.github.com/repos/radusqrt/help-the-kids/git/commits{/sha}","comments_url":"https://api.github.com/repos/radusqrt/help-the-kids/comments{/number}","issue_comment_url":"https://api.github.com/repos/radusqrt/help-the-kids/issues/comments{/number}","contents_url":"https://api.github.com/repos/radusqrt/help-the-kids/contents/{+path}","compare_url":"https://api.github.com/repos/radusqrt/help-the-kids/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radusqrt/help-the-kids/merges","archive_url":"https://api.github.com/repos/radusqrt/help-the-kids/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radusqrt/help-the-kids/downloads","issues_url":"https://api.github.com/repos/radusqrt/help-the-kids/issues{/number}","pulls_url":"https://api.github.com/repos/radusqrt/help-the-kids/pulls{/number}","milestones_url":"https://api.github.com/repos/radusqrt/help-the-kids/milestones{/number}","notifications_url":"https://api.github.com/repos/radusqrt/help-the-kids/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radusqrt/help-the-kids/labels{/name}","releases_url":"https://api.github.com/repos/radusqrt/help-the-kids/releases{/id}","deployments_url":"https://api.github.com/repos/radusqrt/help-the-kids/deployments","created_at":"2017-11-22T23:50:00Z","updated_at":"2018-03-23T08:42:39Z","pushed_at":"2018-03-23T10:03:53Z","git_url":"git://github.com/radusqrt/help-the-kids.git","ssh_url":"git@github.com:radusqrt/help-the-kids.git","clone_url":"https://github.com/radusqrt/help-the-kids.git","svn_url":"https://github.com/radusqrt/help-the-kids","homepage":null,"size":97,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":11,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radusqrt/help-the-kids/pulls/10"},"html":{"href":"https://github.com/radusqrt/help-the-kids/pull/10"},"issue":{"href":"https://api.github.com/repos/radusqrt/help-the-kids/issues/10"},"comments":{"href":"https://api.github.com/repos/radusqrt/help-the-kids/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/radusqrt/help-the-kids/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/radusqrt/help-the-kids/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radusqrt/help-the-kids/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/radusqrt/help-the-kids/statuses/586a1a93ed4a225ffb0f221b1753c7cf396d7f70"}},"author_association":"NONE"}}
{"actor":{"display_login":"radusqrt"}}