{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70862","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70862/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70862/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70862/events","html_url":"https://github.com/kubernetes/kubernetes/pull/70862","id":379116171,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NjU3OTI2","number":70862,"title":"e2e storage tests: usable out-of-tree","user":{"login":"pohly","id":22076,"node_id":"MDQ6VXNlcjIyMDc2","avatar_url":"https://avatars1.githubusercontent.com/u/22076?v=4","gravatar_id":"","url":"https://api.github.com/users/pohly","html_url":"https://github.com/pohly","followers_url":"https://api.github.com/users/pohly/followers","following_url":"https://api.github.com/users/pohly/following{/other_user}","gists_url":"https://api.github.com/users/pohly/gists{/gist_id}","starred_url":"https://api.github.com/users/pohly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pohly/subscriptions","organizations_url":"https://api.github.com/users/pohly/orgs","repos_url":"https://api.github.com/users/pohly/repos","events_url":"https://api.github.com/users/pohly/events{/privacy}","received_events_url":"https://api.github.com/users/pohly/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-09T10:58:57Z","updated_at":"2018-11-12T20:59:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70862","html_url":"https://github.com/kubernetes/kubernetes/pull/70862","diff_url":"https://github.com/kubernetes/kubernetes/pull/70862.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70862.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n\r\n/kind cleanup\r\n\r\n**What this PR does / why we need it**:\r\n\r\nNot all CSI drivers can be tested in Kubernetes (they might not be open) or should not be (if it does not help develop and enhance Kubernetes). Therefore it is useful to make the tests available to out-of-tree drivers without pulling in Kubernetes E2E specific code and tests.\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/438026533","html_url":"https://github.com/kubernetes/kubernetes/pull/70862#issuecomment-438026533","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70862","id":438026533,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODAyNjUzMw==","user":{"login":"mkimuram","id":36450643,"node_id":"MDQ6VXNlcjM2NDUwNjQz","avatar_url":"https://avatars2.githubusercontent.com/u/36450643?v=4","gravatar_id":"","url":"https://api.github.com/users/mkimuram","html_url":"https://github.com/mkimuram","followers_url":"https://api.github.com/users/mkimuram/followers","following_url":"https://api.github.com/users/mkimuram/following{/other_user}","gists_url":"https://api.github.com/users/mkimuram/gists{/gist_id}","starred_url":"https://api.github.com/users/mkimuram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkimuram/subscriptions","organizations_url":"https://api.github.com/users/mkimuram/orgs","repos_url":"https://api.github.com/users/mkimuram/repos","events_url":"https://api.github.com/users/mkimuram/events{/privacy}","received_events_url":"https://api.github.com/users/mkimuram/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T20:59:16Z","updated_at":"2018-11-12T20:59:16Z","author_association":"CONTRIBUTOR","body":"@pohly \r\n\r\nThank you for working on improvement for e2e testing framework.\r\n\r\nI see many improvements on other than just making it \"usable out-of-tree\", like skipping tests efficiently. (They look really nice.) However, could you let me know which exact commits are necessary for this purpose? (I guess that only first one and second one would be needed, if so we would be better to make others to the separate PR.)\r\n\r\nAnd could you share how you could make it use out-of-tree after the changes, so that anyone can confirm that it can be applied to other csi drivers by the changes?\r\n\r\n> Several tests were skipped, probably because of the [Serial] tag:\r\n> Does that look normal?\r\n\r\nYes. I think that tests tagged with [Serial], [Slow], or [Feature:*] are skipped in this job.\r\n(There might be some more checks.)\r\n"}}
{"actor":{"display_login":"mkimuram"}}