{"action":"created","issue":{"url":"https://api.github.com/repos/dcos/dcos-ui/issues/2659","repository_url":"https://api.github.com/repos/dcos/dcos-ui","labels_url":"https://api.github.com/repos/dcos/dcos-ui/issues/2659/labels{/name}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/2659/comments","events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/2659/events","html_url":"https://github.com/dcos/dcos-ui/pull/2659","id":290667134,"number":2659,"title":"refactor(SchemaField): improve framework heading sizes","user":{"login":"ahoskins","id":1527504,"avatar_url":"https://avatars3.githubusercontent.com/u/1527504?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoskins","html_url":"https://github.com/ahoskins","followers_url":"https://api.github.com/users/ahoskins/followers","following_url":"https://api.github.com/users/ahoskins/following{/other_user}","gists_url":"https://api.github.com/users/ahoskins/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoskins/subscriptions","organizations_url":"https://api.github.com/users/ahoskins/orgs","repos_url":"https://api.github.com/users/ahoskins/repos","events_url":"https://api.github.com/users/ahoskins/events{/privacy}","received_events_url":"https://api.github.com/users/ahoskins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"DanielMSchmidt","id":1337046,"avatar_url":"https://avatars2.githubusercontent.com/u/1337046?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielMSchmidt","html_url":"https://github.com/DanielMSchmidt","followers_url":"https://api.github.com/users/DanielMSchmidt/followers","following_url":"https://api.github.com/users/DanielMSchmidt/following{/other_user}","gists_url":"https://api.github.com/users/DanielMSchmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielMSchmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielMSchmidt/subscriptions","organizations_url":"https://api.github.com/users/DanielMSchmidt/orgs","repos_url":"https://api.github.com/users/DanielMSchmidt/repos","events_url":"https://api.github.com/users/DanielMSchmidt/events{/privacy}","received_events_url":"https://api.github.com/users/DanielMSchmidt/received_events","type":"User","site_admin":false},"assignees":[{"login":"DanielMSchmidt","id":1337046,"avatar_url":"https://avatars2.githubusercontent.com/u/1337046?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielMSchmidt","html_url":"https://github.com/DanielMSchmidt","followers_url":"https://api.github.com/users/DanielMSchmidt/followers","following_url":"https://api.github.com/users/DanielMSchmidt/following{/other_user}","gists_url":"https://api.github.com/users/DanielMSchmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielMSchmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielMSchmidt/subscriptions","organizations_url":"https://api.github.com/users/DanielMSchmidt/orgs","repos_url":"https://api.github.com/users/DanielMSchmidt/repos","events_url":"https://api.github.com/users/DanielMSchmidt/events{/privacy}","received_events_url":"https://api.github.com/users/DanielMSchmidt/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dcos/dcos-ui/milestones/7","html_url":"https://github.com/dcos/dcos-ui/milestone/7","labels_url":"https://api.github.com/repos/dcos/dcos-ui/milestones/7/labels","id":3048958,"number":7,"title":"1.12","description":"","creator":{"login":"orlandohohmeier","id":647035,"avatar_url":"https://avatars3.githubusercontent.com/u/647035?v=4","gravatar_id":"","url":"https://api.github.com/users/orlandohohmeier","html_url":"https://github.com/orlandohohmeier","followers_url":"https://api.github.com/users/orlandohohmeier/followers","following_url":"https://api.github.com/users/orlandohohmeier/following{/other_user}","gists_url":"https://api.github.com/users/orlandohohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/orlandohohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlandohohmeier/subscriptions","organizations_url":"https://api.github.com/users/orlandohohmeier/orgs","repos_url":"https://api.github.com/users/orlandohohmeier/repos","events_url":"https://api.github.com/users/orlandohohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/orlandohohmeier/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":16,"state":"open","created_at":"2018-01-19T16:07:51Z","updated_at":"2018-02-13T16:04:49Z","due_on":null,"closed_at":null},"comments":17,"created_at":"2018-01-23T00:33:50Z","updated_at":"2018-02-13T19:01:48Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/2659","html_url":"https://github.com/dcos/dcos-ui/pull/2659","diff_url":"https://github.com/dcos/dcos-ui/pull/2659.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/2659.patch"},"body":"The purpose of this is to make the framework forms more visually parsable. Changes:\r\n1. Give each TitleField it sizing appropriate to it's location in the json schema. Previously, they were all rendered as `<h2>` for simplicity, but this made it hard to notice which were nested fields.\r\n2. Bigger sizing on Placement Constraints widget label.\r\n3. Capitalize each word in all field labels\r\n4. Extra margin below Placement section to visually separate from rest of form\r\n\r\n**Testing**:\r\n1. Turn enterprise off\r\n2. Open the catalog for beta-kafka. Notice the form differences. H1 and H2 and H3 for layers of config headings, and Placement Constraints label is proper size.\r\n\r\nThanks to @leemunroe for suggestions and assistance. \r\n\r\n**Before**:\r\n![screen shot 2018-01-22 at 4 31 58 pm](https://user-images.githubusercontent.com/1527504/35251793-ce29e67e-ff91-11e7-931c-86f6b44c3b78.png)\r\n![screen shot 2018-01-22 at 4 31 50 pm](https://user-images.githubusercontent.com/1527504/35251794-d0ec753e-ff91-11e7-9994-ca1303db50da.png)\r\n\r\n**After**:\r\n![screen shot 2018-01-22 at 4 30 32 pm](https://user-images.githubusercontent.com/1527504/35251798-d837940e-ff91-11e7-8b0d-5b107a6fa0f5.png)\r\n![screen shot 2018-01-22 at 4 30 20 pm](https://user-images.githubusercontent.com/1527504/35251801-daf8d09a-ff91-11e7-8961-fa291f666976.png)\r\n\r\n\r\n**Checklist**\r\n- [ ] Did you add a JIRA issue in a commit message or as part of the branch name?\r\n- [ ] Did you add new unit tests?\r\n- [ ] Did you add new integration tests?\r\n- [ ] If this is a regression, did you write a test to catch this in the future?\r\n\r\n<!-- More info can be found by clicking the \"guidelines for contributing\" link above. -->\r\n"},"comment":{"url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments/365369146","html_url":"https://github.com/dcos/dcos-ui/pull/2659#issuecomment-365369146","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/2659","id":365369146,"user":{"login":"ahoskins","id":1527504,"avatar_url":"https://avatars3.githubusercontent.com/u/1527504?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoskins","html_url":"https://github.com/ahoskins","followers_url":"https://api.github.com/users/ahoskins/followers","following_url":"https://api.github.com/users/ahoskins/following{/other_user}","gists_url":"https://api.github.com/users/ahoskins/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoskins/subscriptions","organizations_url":"https://api.github.com/users/ahoskins/orgs","repos_url":"https://api.github.com/users/ahoskins/repos","events_url":"https://api.github.com/users/ahoskins/events{/privacy}","received_events_url":"https://api.github.com/users/ahoskins/received_events","type":"User","site_admin":false},"created_at":"2018-02-13T19:01:48Z","updated_at":"2018-02-13T19:01:48Z","author_association":"MEMBER","body":"@DanielMSchmidt Thanks. Yes comments have been addressed. This PR is just an \"improvement\" PR, hence not blocker. When someone else gets the time, they can do one last review."}}
{"actor":{"display_login":"ahoskins"}}