{"action":"created","comment":{"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments/176605713","pull_request_review_id":106341272,"id":176605713,"diff_hunk":"@@ -25,11 +29,16 @@ import { HttpClientModule } from \"@angular/common/http\";\n     TranslateModule.forRoot()\n   ],\n   exports: [\n-    LanguageSelect\n+    BrowserModule,\n+    LanguageSelect,\n+    TranslateDatePipe,\n+    TranslateNumberPipe\n   ],\n   providers: [\n     RdwTranslateLoader,\n-    LanguageStore\n+    LanguageStore,\n+    TranslateDatePipe,\n+    TranslateNumberPipe","path":"webapp/src/main/webapp/src/app/shared/i18n/rdw-i18n.module.ts","position":31,"original_position":31,"commit_id":"25a0417071e40ff2c2e73f3b3db44de5ac904777","original_commit_id":"72b05ec679ba111b8b53852852a60dfd084d0789","user":{"login":"esotrope","id":23462925,"avatar_url":"https://avatars3.githubusercontent.com/u/23462925?v=4","gravatar_id":"","url":"https://api.github.com/users/esotrope","html_url":"https://github.com/esotrope","followers_url":"https://api.github.com/users/esotrope/followers","following_url":"https://api.github.com/users/esotrope/following{/other_user}","gists_url":"https://api.github.com/users/esotrope/gists{/gist_id}","starred_url":"https://api.github.com/users/esotrope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esotrope/subscriptions","organizations_url":"https://api.github.com/users/esotrope/orgs","repos_url":"https://api.github.com/users/esotrope/repos","events_url":"https://api.github.com/users/esotrope/events{/privacy}","received_events_url":"https://api.github.com/users/esotrope/received_events","type":"User","site_admin":false},"body":"There have been many times in this project where i am tempted to submit PR to both ngx-translate and ngx-bootstrap","created_at":"2018-03-22T23:48:52Z","updated_at":"2018-03-22T23:48:52Z","html_url":"https://github.com/SmarterApp/RDW_Reporting/pull/1125#discussion_r176605713","pull_request_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1125","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments/176605713"},"html":{"href":"https://github.com/SmarterApp/RDW_Reporting/pull/1125#discussion_r176605713"},"pull_request":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1125"}},"in_reply_to_id":176599444},"pull_request":{"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1125","id":176933328,"html_url":"https://github.com/SmarterApp/RDW_Reporting/pull/1125","diff_url":"https://github.com/SmarterApp/RDW_Reporting/pull/1125.diff","patch_url":"https://github.com/SmarterApp/RDW_Reporting/pull/1125.patch","issue_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/1125","number":1125,"state":"open","locked":false,"title":"Translate dates and numbers that are displayed via the Angular DatePi…","user":{"login":"wtritch","id":617828,"avatar_url":"https://avatars3.githubusercontent.com/u/617828?v=4","gravatar_id":"","url":"https://api.github.com/users/wtritch","html_url":"https://github.com/wtritch","followers_url":"https://api.github.com/users/wtritch/followers","following_url":"https://api.github.com/users/wtritch/following{/other_user}","gists_url":"https://api.github.com/users/wtritch/gists{/gist_id}","starred_url":"https://api.github.com/users/wtritch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtritch/subscriptions","organizations_url":"https://api.github.com/users/wtritch/orgs","repos_url":"https://api.github.com/users/wtritch/repos","events_url":"https://api.github.com/users/wtritch/events{/privacy}","received_events_url":"https://api.github.com/users/wtritch/received_events","type":"User","site_admin":false},"body":"…pe and DecimalPipe using the currently-selected locale.\r\n\r\nUpdate displayed values on locale change.\r\n\r\n![image](https://user-images.githubusercontent.com/617828/37803211-d4440f1c-2dea-11e8-9aa2-1db7eda8f5d5.png)\r\n","created_at":"2018-03-22T23:05:35Z","updated_at":"2018-03-22T23:48:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6ab4e3652ae5ba899b8546fc4fe5663464ca58c","assignee":{"login":"jtreuting","id":341584,"avatar_url":"https://avatars0.githubusercontent.com/u/341584?v=4","gravatar_id":"","url":"https://api.github.com/users/jtreuting","html_url":"https://github.com/jtreuting","followers_url":"https://api.github.com/users/jtreuting/followers","following_url":"https://api.github.com/users/jtreuting/following{/other_user}","gists_url":"https://api.github.com/users/jtreuting/gists{/gist_id}","starred_url":"https://api.github.com/users/jtreuting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtreuting/subscriptions","organizations_url":"https://api.github.com/users/jtreuting/orgs","repos_url":"https://api.github.com/users/jtreuting/repos","events_url":"https://api.github.com/users/jtreuting/events{/privacy}","received_events_url":"https://api.github.com/users/jtreuting/received_events","type":"User","site_admin":false},"assignees":[{"login":"jtreuting","id":341584,"avatar_url":"https://avatars0.githubusercontent.com/u/341584?v=4","gravatar_id":"","url":"https://api.github.com/users/jtreuting","html_url":"https://github.com/jtreuting","followers_url":"https://api.github.com/users/jtreuting/followers","following_url":"https://api.github.com/users/jtreuting/following{/other_user}","gists_url":"https://api.github.com/users/jtreuting/gists{/gist_id}","starred_url":"https://api.github.com/users/jtreuting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtreuting/subscriptions","organizations_url":"https://api.github.com/users/jtreuting/orgs","repos_url":"https://api.github.com/users/jtreuting/repos","events_url":"https://api.github.com/users/jtreuting/events{/privacy}","received_events_url":"https://api.github.com/users/jtreuting/received_events","type":"User","site_admin":false},{"login":"esotrope","id":23462925,"avatar_url":"https://avatars3.githubusercontent.com/u/23462925?v=4","gravatar_id":"","url":"https://api.github.com/users/esotrope","html_url":"https://github.com/esotrope","followers_url":"https://api.github.com/users/esotrope/followers","following_url":"https://api.github.com/users/esotrope/following{/other_user}","gists_url":"https://api.github.com/users/esotrope/gists{/gist_id}","starred_url":"https://api.github.com/users/esotrope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esotrope/subscriptions","organizations_url":"https://api.github.com/users/esotrope/orgs","repos_url":"https://api.github.com/users/esotrope/repos","events_url":"https://api.github.com/users/esotrope/events{/privacy}","received_events_url":"https://api.github.com/users/esotrope/received_events","type":"User","site_admin":false},{"login":"dsnyder-fairway","id":33040425,"avatar_url":"https://avatars1.githubusercontent.com/u/33040425?v=4","gravatar_id":"","url":"https://api.github.com/users/dsnyder-fairway","html_url":"https://github.com/dsnyder-fairway","followers_url":"https://api.github.com/users/dsnyder-fairway/followers","following_url":"https://api.github.com/users/dsnyder-fairway/following{/other_user}","gists_url":"https://api.github.com/users/dsnyder-fairway/gists{/gist_id}","starred_url":"https://api.github.com/users/dsnyder-fairway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsnyder-fairway/subscriptions","organizations_url":"https://api.github.com/users/dsnyder-fairway/orgs","repos_url":"https://api.github.com/users/dsnyder-fairway/repos","events_url":"https://api.github.com/users/dsnyder-fairway/events{/privacy}","received_events_url":"https://api.github.com/users/dsnyder-fairway/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1125/commits","review_comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1125/comments","review_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/1125/comments","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/25a0417071e40ff2c2e73f3b3db44de5ac904777","head":{"label":"SmarterApp:bugfix/translate-date-and-number","ref":"bugfix/translate-date-and-number","sha":"25a0417071e40ff2c2e73f3b3db44de5ac904777","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":81362154,"name":"RDW_Reporting","full_name":"SmarterApp/RDW_Reporting","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/RDW_Reporting","description":"RDW reporting tier (web app, backend services, etc.)","fork":false,"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting","forks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/forks","keys_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/teams","hooks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/events","assignees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/tags","blobs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscription","commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/merges","archive_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/downloads","issues_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/deployments","created_at":"2017-02-08T18:31:23Z","updated_at":"2018-03-22T20:28:52Z","pushed_at":"2018-03-22T23:29:21Z","git_url":"git://github.com/SmarterApp/RDW_Reporting.git","ssh_url":"git@github.com:SmarterApp/RDW_Reporting.git","clone_url":"https://github.com/SmarterApp/RDW_Reporting.git","svn_url":"https://github.com/SmarterApp/RDW_Reporting","homepage":null,"size":23582,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"SmarterApp:develop","ref":"develop","sha":"6404b91d703af909fd2fe30e79919e05be7084fe","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":81362154,"name":"RDW_Reporting","full_name":"SmarterApp/RDW_Reporting","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/RDW_Reporting","description":"RDW reporting tier (web app, backend services, etc.)","fork":false,"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting","forks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/forks","keys_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/teams","hooks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/events","assignees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/tags","blobs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscription","commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/merges","archive_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/downloads","issues_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/deployments","created_at":"2017-02-08T18:31:23Z","updated_at":"2018-03-22T20:28:52Z","pushed_at":"2018-03-22T23:29:21Z","git_url":"git://github.com/SmarterApp/RDW_Reporting.git","ssh_url":"git@github.com:SmarterApp/RDW_Reporting.git","clone_url":"https://github.com/SmarterApp/RDW_Reporting.git","svn_url":"https://github.com/SmarterApp/RDW_Reporting","homepage":null,"size":23582,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1125"},"html":{"href":"https://github.com/SmarterApp/RDW_Reporting/pull/1125"},"issue":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/1125"},"comments":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/1125/comments"},"review_comments":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1125/comments"},"review_comment":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1125/commits"},"statuses":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/25a0417071e40ff2c2e73f3b3db44de5ac904777"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"esotrope"}}