{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/227514818","pull_request_review_id":167574568,"id":227514818,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzUxNDgxOA==","diff_hunk":"@@ -62,13 +62,22 @@\n     aliases:\n       - incremental\n \n+  enable_ipv6:\n+    version_added: 2.8\n+    description:\n+      - Enable IPv6 networking.\n+    type: bool\n+    default: null\n+    required: false\n+\n   ipam_driver:\n     description:\n       - Specify an IPAM driver.\n \n-  ipam_options:","path":"lib/ansible/modules/cloud/docker/docker_network.py","position":16,"original_position":16,"commit_id":"974501f728495a33aba606815f1271a31ef97648","original_commit_id":"974501f728495a33aba606815f1271a31ef97648","user":{"login":"smueller18","id":15823873,"node_id":"MDQ6VXNlcjE1ODIzODcz","avatar_url":"https://avatars3.githubusercontent.com/u/15823873?v=4","gravatar_id":"","url":"https://api.github.com/users/smueller18","html_url":"https://github.com/smueller18","followers_url":"https://api.github.com/users/smueller18/followers","following_url":"https://api.github.com/users/smueller18/following{/other_user}","gists_url":"https://api.github.com/users/smueller18/gists{/gist_id}","starred_url":"https://api.github.com/users/smueller18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smueller18/subscriptions","organizations_url":"https://api.github.com/users/smueller18/orgs","repos_url":"https://api.github.com/users/smueller18/repos","events_url":"https://api.github.com/users/smueller18/events{/privacy}","received_events_url":"https://api.github.com/users/smueller18/received_events","type":"User","site_admin":false},"body":"I see your point. This is a bit sad, because the parameters then differ from the official docker specification. So I will add a deprecation note for `ipam_options` and implement the \"real\" ipam options as parameter `ipam_driver_options`.","created_at":"2018-10-23T18:34:59Z","updated_at":"2018-10-23T18:34:59Z","html_url":"https://github.com/ansible/ansible/pull/47492#discussion_r227514818","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/47492","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/227514818"},"html":{"href":"https://github.com/ansible/ansible/pull/47492#discussion_r227514818"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/47492"}},"in_reply_to_id":227453811},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/47492","id":224978214,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTc4MjE0","html_url":"https://github.com/ansible/ansible/pull/47492","diff_url":"https://github.com/ansible/ansible/pull/47492.diff","patch_url":"https://github.com/ansible/ansible/pull/47492.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/47492","number":47492,"state":"open","locked":false,"title":"[docker_network] add ipv6 support","user":{"login":"smueller18","id":15823873,"node_id":"MDQ6VXNlcjE1ODIzODcz","avatar_url":"https://avatars3.githubusercontent.com/u/15823873?v=4","gravatar_id":"","url":"https://api.github.com/users/smueller18","html_url":"https://github.com/smueller18","followers_url":"https://api.github.com/users/smueller18/followers","following_url":"https://api.github.com/users/smueller18/following{/other_user}","gists_url":"https://api.github.com/users/smueller18/gists{/gist_id}","starred_url":"https://api.github.com/users/smueller18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smueller18/subscriptions","organizations_url":"https://api.github.com/users/smueller18/orgs","repos_url":"https://api.github.com/users/smueller18/repos","events_url":"https://api.github.com/users/smueller18/events{/privacy}","received_events_url":"https://api.github.com/users/smueller18/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nThis PR enables support for IPv6 networks and allows defining IPv6 IPAM config blocks. The configuration options are based on the existing docker-compose documentation https://docs.docker.com/compose/compose-file/compose-file-v2/#ipam .\r\n\r\nSo far, the parameter for IPAM config was named `ipam_options` but in recent docker versions, this is called `ipam_config` (see link above). Here is the example from the docker-compose docs:\r\n```\r\nipam:\r\n  driver: default\r\n  config:\r\n    - subnet: 172.28.0.0/16\r\n      ip_range: 172.28.5.0/24\r\n      gateway: 172.28.5.254\r\n      aux_addresses:\r\n        host1: 172.28.1.5\r\n        host2: 172.28.1.6\r\n        host3: 172.28.1.7\r\n  options:\r\n    foo: bar\r\n    baz: \"0\"\r\n```\r\nSo I changed the parameter name `ipam_options` to `ipam_config`. I also created a branch (https://github.com/smueller18/ansible/tree/docker_network_ipam_options) that handles the new parameter `ipam_options` well, but this change requires docker >= 2.0.0, so I cannot create a pull request for that change until support for docker-py and python 2.6 is dropped.\r\n\r\nFixes #34855\r\n\r\n##### ISSUE TYPE\r\n- Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\ndocker_network\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes -->\r\n```paste below\r\nansible 2.8.0.dev0\r\n  config file = /etc/ansible/ansible.cfg\r\n  configured module search path = ['/home/sm/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']\r\n  ansible python module location = /home/sm/git/github/smueller18/ansible/venv/lib/python3.7/site-packages/ansible-2.8.0.dev0-py3.7.egg/ansible\r\n  executable location = /home/sm/git/github/smueller18/ansible/venv/bin/ansible\r\n  python version = 3.7.0 (default, Aug 30 2018, 22:41:14) [GCC 7.3.0]\r\n```","created_at":"2018-10-23T10:13:59Z","updated_at":"2018-10-23T18:34:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52727d17483a7fcb8f68a738d28a11ff4b4415e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1043397454,"node_id":"MDU6TGFiZWwxMDQzMzk3NDU0","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.8","name":"affects_2.8","color":"ededed","default":false},{"id":61528803,"node_id":"MDU6TGFiZWw2MTUyODgwMw==","url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":500715204,"node_id":"MDU6TGFiZWw1MDA3MTUyMDQ=","url":"https://api.github.com/repos/ansible/ansible/labels/docker","name":"docker","color":"c5def5","default":false},{"id":852590921,"node_id":"MDU6TGFiZWw4NTI1OTA5MjE=","url":"https://api.github.com/repos/ansible/ansible/labels/feature","name":"feature","color":"006b75","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":61436281,"node_id":"MDU6TGFiZWw2MTQzNjI4MQ==","url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":723150340,"node_id":"MDU6TGFiZWw3MjMxNTAzNDA=","url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"c2e0c6","default":false},{"id":383076471,"node_id":"MDU6TGFiZWwzODMwNzY0NzE=","url":"https://api.github.com/repos/ansible/ansible/labels/python3","name":"python3","color":"fbca04","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/47492/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/47492/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/47492/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/974501f728495a33aba606815f1271a31ef97648","head":{"label":"smueller18:docker_network_ipv6","ref":"docker_network_ipv6","sha":"974501f728495a33aba606815f1271a31ef97648","user":{"login":"smueller18","id":15823873,"node_id":"MDQ6VXNlcjE1ODIzODcz","avatar_url":"https://avatars3.githubusercontent.com/u/15823873?v=4","gravatar_id":"","url":"https://api.github.com/users/smueller18","html_url":"https://github.com/smueller18","followers_url":"https://api.github.com/users/smueller18/followers","following_url":"https://api.github.com/users/smueller18/following{/other_user}","gists_url":"https://api.github.com/users/smueller18/gists{/gist_id}","starred_url":"https://api.github.com/users/smueller18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smueller18/subscriptions","organizations_url":"https://api.github.com/users/smueller18/orgs","repos_url":"https://api.github.com/users/smueller18/repos","events_url":"https://api.github.com/users/smueller18/events{/privacy}","received_events_url":"https://api.github.com/users/smueller18/received_events","type":"User","site_admin":false},"repo":{"id":154164608,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQxNjQ2MDg=","name":"ansible","full_name":"smueller18/ansible","private":false,"owner":{"login":"smueller18","id":15823873,"node_id":"MDQ6VXNlcjE1ODIzODcz","avatar_url":"https://avatars3.githubusercontent.com/u/15823873?v=4","gravatar_id":"","url":"https://api.github.com/users/smueller18","html_url":"https://github.com/smueller18","followers_url":"https://api.github.com/users/smueller18/followers","following_url":"https://api.github.com/users/smueller18/following{/other_user}","gists_url":"https://api.github.com/users/smueller18/gists{/gist_id}","starred_url":"https://api.github.com/users/smueller18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smueller18/subscriptions","organizations_url":"https://api.github.com/users/smueller18/orgs","repos_url":"https://api.github.com/users/smueller18/repos","events_url":"https://api.github.com/users/smueller18/events{/privacy}","received_events_url":"https://api.github.com/users/smueller18/received_events","type":"User","site_admin":false},"html_url":"https://github.com/smueller18/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":true,"url":"https://api.github.com/repos/smueller18/ansible","forks_url":"https://api.github.com/repos/smueller18/ansible/forks","keys_url":"https://api.github.com/repos/smueller18/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smueller18/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smueller18/ansible/teams","hooks_url":"https://api.github.com/repos/smueller18/ansible/hooks","issue_events_url":"https://api.github.com/repos/smueller18/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/smueller18/ansible/events","assignees_url":"https://api.github.com/repos/smueller18/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/smueller18/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/smueller18/ansible/tags","blobs_url":"https://api.github.com/repos/smueller18/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smueller18/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smueller18/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/smueller18/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smueller18/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/smueller18/ansible/languages","stargazers_url":"https://api.github.com/repos/smueller18/ansible/stargazers","contributors_url":"https://api.github.com/repos/smueller18/ansible/contributors","subscribers_url":"https://api.github.com/repos/smueller18/ansible/subscribers","subscription_url":"https://api.github.com/repos/smueller18/ansible/subscription","commits_url":"https://api.github.com/repos/smueller18/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/smueller18/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/smueller18/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/smueller18/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/smueller18/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/smueller18/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smueller18/ansible/merges","archive_url":"https://api.github.com/repos/smueller18/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smueller18/ansible/downloads","issues_url":"https://api.github.com/repos/smueller18/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/smueller18/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/smueller18/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/smueller18/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smueller18/ansible/labels{/name}","releases_url":"https://api.github.com/repos/smueller18/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/smueller18/ansible/deployments","created_at":"2018-10-22T15:07:14Z","updated_at":"2018-10-22T23:08:05Z","pushed_at":"2018-10-23T11:17:24Z","git_url":"git://github.com/smueller18/ansible.git","ssh_url":"git@github.com:smueller18/ansible.git","clone_url":"https://github.com/smueller18/ansible.git","svn_url":"https://github.com/smueller18/ansible","homepage":"https://www.ansible.com/","size":136184,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"dcb35c427092b3bc2ef8f9b9e1132a3184b9e20b","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-10-23T18:14:46Z","pushed_at":"2018-10-23T18:24:52Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":144153,"stargazers_count":33338,"watchers_count":33338,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13228,"mirror_url":null,"archived":false,"open_issues_count":5578,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13228,"open_issues":5578,"watchers":33338,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/47492"},"html":{"href":"https://github.com/ansible/ansible/pull/47492"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/47492"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/47492/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/47492/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/47492/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/974501f728495a33aba606815f1271a31ef97648"}},"author_association":"NONE"}}
{"actor":{"display_login":"smueller18"}}