{"action":"closed","number":87,"pull_request":{"url":"https://api.github.com/repos/ruby-numo/numo-narray/pulls/87","id":177769530,"html_url":"https://github.com/ruby-numo/numo-narray/pull/87","diff_url":"https://github.com/ruby-numo/numo-narray/pull/87.diff","patch_url":"https://github.com/ruby-numo/numo-narray/pull/87.patch","issue_url":"https://api.github.com/repos/ruby-numo/numo-narray/issues/87","number":87,"state":"closed","locked":false,"title":"Add static to functions that not necessary to be exported","user":{"login":"sonots","id":2290461,"avatar_url":"https://avatars2.githubusercontent.com/u/2290461?v=4","gravatar_id":"","url":"https://api.github.com/users/sonots","html_url":"https://github.com/sonots","followers_url":"https://api.github.com/users/sonots/followers","following_url":"https://api.github.com/users/sonots/following{/other_user}","gists_url":"https://api.github.com/users/sonots/gists{/gist_id}","starred_url":"https://api.github.com/users/sonots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonots/subscriptions","organizations_url":"https://api.github.com/users/sonots/orgs","repos_url":"https://api.github.com/users/sonots/repos","events_url":"https://api.github.com/users/sonots/events{/privacy}","received_events_url":"https://api.github.com/users/sonots/received_events","type":"User","site_admin":false},"body":"and remove unused functions.\r\n\r\nThis is a kind of **feedbacks** from Cumo to Numo.\r\n\r\n# Background\r\n\r\nI am currently creating CUDA-aware version of Numo, https://github.com/sonots/cumo.\r\nI want to support conversion from Numo::NArray into Cumo::NArray.\r\n\r\nTo do it, I needed to support `require \"numo/narray.so\"` anyway.\r\nI needed to resolve C symbol collisions between Numo and Cumo.\r\n\r\n# What this PR does\r\n\r\nWhile working to resolve symbol conflictions, I noticed that some functions are not used from outside of its file. So, I put `static` for them. I also found that some C functions are even not used from anywhere. So, I removed them.\r\n\r\n# See also\r\n\r\nhttps://github.com/sonots/cumo/pull/48\r\n","created_at":"2018-03-27T14:59:59Z","updated_at":"2018-03-28T08:18:38Z","closed_at":"2018-03-28T08:18:38Z","merged_at":"2018-03-28T08:18:38Z","merge_commit_sha":"642e93a17fa5c0f5eac45dc28200484bdbd073c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ruby-numo/numo-narray/pulls/87/commits","review_comments_url":"https://api.github.com/repos/ruby-numo/numo-narray/pulls/87/comments","review_comment_url":"https://api.github.com/repos/ruby-numo/numo-narray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ruby-numo/numo-narray/issues/87/comments","statuses_url":"https://api.github.com/repos/ruby-numo/numo-narray/statuses/7aa1e257f4991557656a7e2e4ab8bfe9a7ddde06","head":{"label":"sonots:static","ref":"static","sha":"7aa1e257f4991557656a7e2e4ab8bfe9a7ddde06","user":{"login":"sonots","id":2290461,"avatar_url":"https://avatars2.githubusercontent.com/u/2290461?v=4","gravatar_id":"","url":"https://api.github.com/users/sonots","html_url":"https://github.com/sonots","followers_url":"https://api.github.com/users/sonots/followers","following_url":"https://api.github.com/users/sonots/following{/other_user}","gists_url":"https://api.github.com/users/sonots/gists{/gist_id}","starred_url":"https://api.github.com/users/sonots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonots/subscriptions","organizations_url":"https://api.github.com/users/sonots/orgs","repos_url":"https://api.github.com/users/sonots/repos","events_url":"https://api.github.com/users/sonots/events{/privacy}","received_events_url":"https://api.github.com/users/sonots/received_events","type":"User","site_admin":false},"repo":{"id":127002626,"name":"numo-narray","full_name":"sonots/numo-narray","owner":{"login":"sonots","id":2290461,"avatar_url":"https://avatars2.githubusercontent.com/u/2290461?v=4","gravatar_id":"","url":"https://api.github.com/users/sonots","html_url":"https://github.com/sonots","followers_url":"https://api.github.com/users/sonots/followers","following_url":"https://api.github.com/users/sonots/following{/other_user}","gists_url":"https://api.github.com/users/sonots/gists{/gist_id}","starred_url":"https://api.github.com/users/sonots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonots/subscriptions","organizations_url":"https://api.github.com/users/sonots/orgs","repos_url":"https://api.github.com/users/sonots/repos","events_url":"https://api.github.com/users/sonots/events{/privacy}","received_events_url":"https://api.github.com/users/sonots/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sonots/numo-narray","description":"Ruby/Numo::NArray - New NArray class library","fork":true,"url":"https://api.github.com/repos/sonots/numo-narray","forks_url":"https://api.github.com/repos/sonots/numo-narray/forks","keys_url":"https://api.github.com/repos/sonots/numo-narray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonots/numo-narray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonots/numo-narray/teams","hooks_url":"https://api.github.com/repos/sonots/numo-narray/hooks","issue_events_url":"https://api.github.com/repos/sonots/numo-narray/issues/events{/number}","events_url":"https://api.github.com/repos/sonots/numo-narray/events","assignees_url":"https://api.github.com/repos/sonots/numo-narray/assignees{/user}","branches_url":"https://api.github.com/repos/sonots/numo-narray/branches{/branch}","tags_url":"https://api.github.com/repos/sonots/numo-narray/tags","blobs_url":"https://api.github.com/repos/sonots/numo-narray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonots/numo-narray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonots/numo-narray/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonots/numo-narray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonots/numo-narray/statuses/{sha}","languages_url":"https://api.github.com/repos/sonots/numo-narray/languages","stargazers_url":"https://api.github.com/repos/sonots/numo-narray/stargazers","contributors_url":"https://api.github.com/repos/sonots/numo-narray/contributors","subscribers_url":"https://api.github.com/repos/sonots/numo-narray/subscribers","subscription_url":"https://api.github.com/repos/sonots/numo-narray/subscription","commits_url":"https://api.github.com/repos/sonots/numo-narray/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonots/numo-narray/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonots/numo-narray/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonots/numo-narray/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonots/numo-narray/contents/{+path}","compare_url":"https://api.github.com/repos/sonots/numo-narray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonots/numo-narray/merges","archive_url":"https://api.github.com/repos/sonots/numo-narray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonots/numo-narray/downloads","issues_url":"https://api.github.com/repos/sonots/numo-narray/issues{/number}","pulls_url":"https://api.github.com/repos/sonots/numo-narray/pulls{/number}","milestones_url":"https://api.github.com/repos/sonots/numo-narray/milestones{/number}","notifications_url":"https://api.github.com/repos/sonots/numo-narray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonots/numo-narray/labels{/name}","releases_url":"https://api.github.com/repos/sonots/numo-narray/releases{/id}","deployments_url":"https://api.github.com/repos/sonots/numo-narray/deployments","created_at":"2018-03-27T14:51:51Z","updated_at":"2018-03-27T14:51:53Z","pushed_at":"2018-03-28T01:01:47Z","git_url":"git://github.com/sonots/numo-narray.git","ssh_url":"git@github.com:sonots/numo-narray.git","clone_url":"https://github.com/sonots/numo-narray.git","svn_url":"https://github.com/sonots/numo-narray","homepage":"http://ruby-numo.github.io/narray/","size":2489,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ruby-numo:master","ref":"master","sha":"163e0406ecde1656705b4c397b0481721204da2c","user":{"login":"ruby-numo","id":17401382,"avatar_url":"https://avatars0.githubusercontent.com/u/17401382?v=4","gravatar_id":"","url":"https://api.github.com/users/ruby-numo","html_url":"https://github.com/ruby-numo","followers_url":"https://api.github.com/users/ruby-numo/followers","following_url":"https://api.github.com/users/ruby-numo/following{/other_user}","gists_url":"https://api.github.com/users/ruby-numo/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby-numo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby-numo/subscriptions","organizations_url":"https://api.github.com/users/ruby-numo/orgs","repos_url":"https://api.github.com/users/ruby-numo/repos","events_url":"https://api.github.com/users/ruby-numo/events{/privacy}","received_events_url":"https://api.github.com/users/ruby-numo/received_events","type":"Organization","site_admin":false},"repo":{"id":11340157,"name":"numo-narray","full_name":"ruby-numo/numo-narray","owner":{"login":"ruby-numo","id":17401382,"avatar_url":"https://avatars0.githubusercontent.com/u/17401382?v=4","gravatar_id":"","url":"https://api.github.com/users/ruby-numo","html_url":"https://github.com/ruby-numo","followers_url":"https://api.github.com/users/ruby-numo/followers","following_url":"https://api.github.com/users/ruby-numo/following{/other_user}","gists_url":"https://api.github.com/users/ruby-numo/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby-numo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby-numo/subscriptions","organizations_url":"https://api.github.com/users/ruby-numo/orgs","repos_url":"https://api.github.com/users/ruby-numo/repos","events_url":"https://api.github.com/users/ruby-numo/events{/privacy}","received_events_url":"https://api.github.com/users/ruby-numo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ruby-numo/numo-narray","description":"Ruby/Numo::NArray - New NArray class library","fork":false,"url":"https://api.github.com/repos/ruby-numo/numo-narray","forks_url":"https://api.github.com/repos/ruby-numo/numo-narray/forks","keys_url":"https://api.github.com/repos/ruby-numo/numo-narray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruby-numo/numo-narray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruby-numo/numo-narray/teams","hooks_url":"https://api.github.com/repos/ruby-numo/numo-narray/hooks","issue_events_url":"https://api.github.com/repos/ruby-numo/numo-narray/issues/events{/number}","events_url":"https://api.github.com/repos/ruby-numo/numo-narray/events","assignees_url":"https://api.github.com/repos/ruby-numo/numo-narray/assignees{/user}","branches_url":"https://api.github.com/repos/ruby-numo/numo-narray/branches{/branch}","tags_url":"https://api.github.com/repos/ruby-numo/numo-narray/tags","blobs_url":"https://api.github.com/repos/ruby-numo/numo-narray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruby-numo/numo-narray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruby-numo/numo-narray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruby-numo/numo-narray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruby-numo/numo-narray/statuses/{sha}","languages_url":"https://api.github.com/repos/ruby-numo/numo-narray/languages","stargazers_url":"https://api.github.com/repos/ruby-numo/numo-narray/stargazers","contributors_url":"https://api.github.com/repos/ruby-numo/numo-narray/contributors","subscribers_url":"https://api.github.com/repos/ruby-numo/numo-narray/subscribers","subscription_url":"https://api.github.com/repos/ruby-numo/numo-narray/subscription","commits_url":"https://api.github.com/repos/ruby-numo/numo-narray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruby-numo/numo-narray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruby-numo/numo-narray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruby-numo/numo-narray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruby-numo/numo-narray/contents/{+path}","compare_url":"https://api.github.com/repos/ruby-numo/numo-narray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruby-numo/numo-narray/merges","archive_url":"https://api.github.com/repos/ruby-numo/numo-narray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruby-numo/numo-narray/downloads","issues_url":"https://api.github.com/repos/ruby-numo/numo-narray/issues{/number}","pulls_url":"https://api.github.com/repos/ruby-numo/numo-narray/pulls{/number}","milestones_url":"https://api.github.com/repos/ruby-numo/numo-narray/milestones{/number}","notifications_url":"https://api.github.com/repos/ruby-numo/numo-narray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruby-numo/numo-narray/labels{/name}","releases_url":"https://api.github.com/repos/ruby-numo/numo-narray/releases{/id}","deployments_url":"https://api.github.com/repos/ruby-numo/numo-narray/deployments","created_at":"2013-07-11T11:22:52Z","updated_at":"2018-03-27T15:25:19Z","pushed_at":"2018-03-28T08:18:38Z","git_url":"git://github.com/ruby-numo/numo-narray.git","ssh_url":"git@github.com:ruby-numo/numo-narray.git","clone_url":"https://github.com/ruby-numo/numo-narray.git","svn_url":"https://github.com/ruby-numo/numo-narray","homepage":"http://ruby-numo.github.io/narray/","size":2485,"stargazers_count":121,"watchers_count":121,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":19,"open_issues":22,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ruby-numo/numo-narray/pulls/87"},"html":{"href":"https://github.com/ruby-numo/numo-narray/pull/87"},"issue":{"href":"https://api.github.com/repos/ruby-numo/numo-narray/issues/87"},"comments":{"href":"https://api.github.com/repos/ruby-numo/numo-narray/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/ruby-numo/numo-narray/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/ruby-numo/numo-narray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ruby-numo/numo-narray/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/ruby-numo/numo-narray/statuses/7aa1e257f4991557656a7e2e4ab8bfe9a7ddde06"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"masa16","id":170326,"avatar_url":"https://avatars2.githubusercontent.com/u/170326?v=4","gravatar_id":"","url":"https://api.github.com/users/masa16","html_url":"https://github.com/masa16","followers_url":"https://api.github.com/users/masa16/followers","following_url":"https://api.github.com/users/masa16/following{/other_user}","gists_url":"https://api.github.com/users/masa16/gists{/gist_id}","starred_url":"https://api.github.com/users/masa16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masa16/subscriptions","organizations_url":"https://api.github.com/users/masa16/orgs","repos_url":"https://api.github.com/users/masa16/repos","events_url":"https://api.github.com/users/masa16/events{/privacy}","received_events_url":"https://api.github.com/users/masa16/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":50,"deletions":109,"changed_files":19}}
{"actor":{"display_login":"masa16"}}