{"action":"created","comment":{"url":"https://api.github.com/repos/apache/arrow/pulls/comments/223186427","pull_request_review_id":162261664,"id":223186427,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzE4NjQyNw==","diff_hunk":"@@ -0,0 +1,24 @@\n+#!/usr/bin/env bash\n+\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements.  See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership.  The ASF licenses this file\n+# to you under the Apache License, Version 2.0 (the\n+# \"License\"); you may not use this file except in compliance\n+# with the License.  You may obtain a copy of the License at\n+#\n+#   http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing,\n+# software distributed under the License is distributed on an\n+# \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+# KIND, either express or implied.  See the License for the\n+# specific language governing permissions and limitations\n+# under the License.\n+\n+wget -O - http://llvm.org/apt/llvm-snapshot.gpg.key|apt-key add -\n+apt-add-repository -y \\\n+     \"deb http://llvm.org/apt/xenial/ llvm-toolchain-xenial-6.0 main\"\n+apt-get update -qq\n+apt-get install -y -q libclang-6.0-dev clang-6.0 clang-format-6.0 clang-tidy-6.0","path":"dev/docker_common/install_clang_tools_xenial.sh","position":24,"original_position":24,"commit_id":"7e25eaeec52246023fb574da80b6f62bde942a2d","original_commit_id":"7e25eaeec52246023fb574da80b6f62bde942a2d","user":{"login":"wesm","id":329591,"node_id":"MDQ6VXNlcjMyOTU5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"Sure, feel free to go ahead and make changes directly in my branch here","created_at":"2018-10-06T16:03:33Z","updated_at":"2018-10-06T16:03:33Z","html_url":"https://github.com/apache/arrow/pull/2713#discussion_r223186427","pull_request_url":"https://api.github.com/repos/apache/arrow/pulls/2713","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments/223186427"},"html":{"href":"https://github.com/apache/arrow/pull/2713#discussion_r223186427"},"pull_request":{"href":"https://api.github.com/repos/apache/arrow/pulls/2713"}},"in_reply_to_id":223186373},"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/2713","id":220894465,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODk0NDY1","html_url":"https://github.com/apache/arrow/pull/2713","diff_url":"https://github.com/apache/arrow/pull/2713.diff","patch_url":"https://github.com/apache/arrow/pull/2713.patch","issue_url":"https://api.github.com/repos/apache/arrow/issues/2713","number":2713,"state":"open","locked":false,"title":"ARROW-3420: [C++] include-what-you-use cleanups for most of src/arrow, add \"iwyu\" target to top level docker-compose","user":{"login":"wesm","id":329591,"node_id":"MDQ6VXNlcjMyOTU5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"You can run IWYU now with `docker-compose run iwyu`. \r\n\r\nI fixed most of the obvious issues in src/arrow. There are some I couldn't quite figure out. I will leave cleaning src/parquet for a follow up patch. \r\n\r\nIWYU makes some spurious reports thinking that certain headers can be removed when they cannot. Not sure what's going on there.","created_at":"2018-10-06T15:53:08Z","updated_at":"2018-10-06T16:03:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f80f9f3c9e2732b322a4da2b991a9011608e6ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/arrow/pulls/2713/commits","review_comments_url":"https://api.github.com/repos/apache/arrow/pulls/2713/comments","review_comment_url":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/arrow/issues/2713/comments","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/7e25eaeec52246023fb574da80b6f62bde942a2d","head":{"label":"wesm:ARROW-3420","ref":"ARROW-3420","sha":"7e25eaeec52246023fb574da80b6f62bde942a2d","user":{"login":"wesm","id":329591,"node_id":"MDQ6VXNlcjMyOTU5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"repo":{"id":52022289,"node_id":"MDEwOlJlcG9zaXRvcnk1MjAyMjI4OQ==","name":"arrow","full_name":"wesm/arrow","private":false,"owner":{"login":"wesm","id":329591,"node_id":"MDQ6VXNlcjMyOTU5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wesm/arrow","description":"Mirror of Apache Arrow","fork":true,"url":"https://api.github.com/repos/wesm/arrow","forks_url":"https://api.github.com/repos/wesm/arrow/forks","keys_url":"https://api.github.com/repos/wesm/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesm/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesm/arrow/teams","hooks_url":"https://api.github.com/repos/wesm/arrow/hooks","issue_events_url":"https://api.github.com/repos/wesm/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/wesm/arrow/events","assignees_url":"https://api.github.com/repos/wesm/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/wesm/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/wesm/arrow/tags","blobs_url":"https://api.github.com/repos/wesm/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesm/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesm/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesm/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesm/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/wesm/arrow/languages","stargazers_url":"https://api.github.com/repos/wesm/arrow/stargazers","contributors_url":"https://api.github.com/repos/wesm/arrow/contributors","subscribers_url":"https://api.github.com/repos/wesm/arrow/subscribers","subscription_url":"https://api.github.com/repos/wesm/arrow/subscription","commits_url":"https://api.github.com/repos/wesm/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesm/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesm/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesm/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesm/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/wesm/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesm/arrow/merges","archive_url":"https://api.github.com/repos/wesm/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesm/arrow/downloads","issues_url":"https://api.github.com/repos/wesm/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/wesm/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/wesm/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/wesm/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesm/arrow/labels{/name}","releases_url":"https://api.github.com/repos/wesm/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/wesm/arrow/deployments","created_at":"2016-02-18T16:41:50Z","updated_at":"2018-10-06T14:38:10Z","pushed_at":"2018-10-06T15:51:17Z","git_url":"git://github.com/wesm/arrow.git","ssh_url":"git@github.com:wesm/arrow.git","clone_url":"https://github.com/wesm/arrow.git","svn_url":"https://github.com/wesm/arrow","homepage":null,"size":19312,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0e518c44b5aac6391ea5d9fca867bf75a92bcf6d","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":51905353,"node_id":"MDEwOlJlcG9zaXRvcnk1MTkwNTM1Mw==","name":"arrow","full_name":"apache/arrow","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":false,"url":"https://api.github.com/repos/apache/arrow","forks_url":"https://api.github.com/repos/apache/arrow/forks","keys_url":"https://api.github.com/repos/apache/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/arrow/teams","hooks_url":"https://api.github.com/repos/apache/arrow/hooks","issue_events_url":"https://api.github.com/repos/apache/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/arrow/events","assignees_url":"https://api.github.com/repos/apache/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/arrow/tags","blobs_url":"https://api.github.com/repos/apache/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/arrow/languages","stargazers_url":"https://api.github.com/repos/apache/arrow/stargazers","contributors_url":"https://api.github.com/repos/apache/arrow/contributors","subscribers_url":"https://api.github.com/repos/apache/arrow/subscribers","subscription_url":"https://api.github.com/repos/apache/arrow/subscription","commits_url":"https://api.github.com/repos/apache/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/arrow/merges","archive_url":"https://api.github.com/repos/apache/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/arrow/downloads","issues_url":"https://api.github.com/repos/apache/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/arrow/labels{/name}","releases_url":"https://api.github.com/repos/apache/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/arrow/deployments","created_at":"2016-02-17T08:00:23Z","updated_at":"2018-10-06T14:38:08Z","pushed_at":"2018-10-06T15:53:09Z","git_url":"git://github.com/apache/arrow.git","ssh_url":"git@github.com:apache/arrow.git","clone_url":"https://github.com/apache/arrow.git","svn_url":"https://github.com/apache/arrow","homepage":"https://arrow.apache.org","size":18908,"stargazers_count":2529,"watchers_count":2529,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":672,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":672,"open_issues":58,"watchers":2529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/2713"},"html":{"href":"https://github.com/apache/arrow/pull/2713"},"issue":{"href":"https://api.github.com/repos/apache/arrow/issues/2713"},"comments":{"href":"https://api.github.com/repos/apache/arrow/issues/2713/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/arrow/pulls/2713/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/arrow/pulls/2713/commits"},"statuses":{"href":"https://api.github.com/repos/apache/arrow/statuses/7e25eaeec52246023fb574da80b6f62bde942a2d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wesm"}}