{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/helm/pulls/comments/170997931","pull_request_review_id":99773940,"id":170997931,"diff_hunk":"@@ -113,40 +114,65 @@ func createDeployment(client extensionsclient.DeploymentsGetter, opts *Options)\n \n }\n \n-// deployment gets the deployment object that installs Tiller.\n-func deployment(opts *Options) (*v1beta1.Deployment, error) {\n-\treturn generateDeployment(opts)\n+// Deployment gets the deployment object that installs Tiller.\n+func Deployment(opts *Options) (*v1beta1.Deployment, error) {\n+\tdep, err := generateDeployment(opts)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tdep.TypeMeta = metav1.TypeMeta{","path":"cmd/helm/installer/install.go","position":30,"original_position":30,"commit_id":"61e88cbc412a0a77e4eba3dc03b888cc18ea647e","original_commit_id":"61e88cbc412a0a77e4eba3dc03b888cc18ea647e","user":{"login":"ryane","id":7346,"avatar_url":"https://avatars3.githubusercontent.com/u/7346?v=4","gravatar_id":"","url":"https://api.github.com/users/ryane","html_url":"https://github.com/ryane","followers_url":"https://api.github.com/users/ryane/followers","following_url":"https://api.github.com/users/ryane/following{/other_user}","gists_url":"https://api.github.com/users/ryane/gists{/gist_id}","starred_url":"https://api.github.com/users/ryane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryane/subscriptions","organizations_url":"https://api.github.com/users/ryane/orgs","repos_url":"https://api.github.com/users/ryane/repos","events_url":"https://api.github.com/users/ryane/events{/privacy}","received_events_url":"https://api.github.com/users/ryane/received_events","type":"User","site_admin":false},"body":"Yeah I think it probably could be. If you look at the original code, the `TypeMeta` information is only included on the object when generating manifests for `-o` and `--debug` and is injected manually as strings: https://github.com/kubernetes/helm/blob/master/cmd/helm/init.go#L230. So, in order to minimize the potential impact, this PR follows that same pattern: TypeMeta is only included when generating the manifests as strings and not when actually sending the object to the Kubernetes api. \r\n\r\nThat said, I don't see why including TypeMeta on the objects sent to the Kubernetes api would cause a problem. What do you think? ","created_at":"2018-02-27T17:14:05Z","updated_at":"2018-02-27T17:14:05Z","html_url":"https://github.com/kubernetes/helm/pull/3556#discussion_r170997931","pull_request_url":"https://api.github.com/repos/kubernetes/helm/pulls/3556","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/comments/170997931"},"html":{"href":"https://github.com/kubernetes/helm/pull/3556#discussion_r170997931"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/3556"}},"in_reply_to_id":170991511},"pull_request":{"url":"https://api.github.com/repos/kubernetes/helm/pulls/3556","id":170819400,"html_url":"https://github.com/kubernetes/helm/pull/3556","diff_url":"https://github.com/kubernetes/helm/pull/3556.diff","patch_url":"https://github.com/kubernetes/helm/pull/3556.patch","issue_url":"https://api.github.com/repos/kubernetes/helm/issues/3556","number":3556,"state":"open","locked":false,"title":"fix(helm): add service, secret manifests in `init -o`","user":{"login":"ryane","id":7346,"avatar_url":"https://avatars3.githubusercontent.com/u/7346?v=4","gravatar_id":"","url":"https://api.github.com/users/ryane","html_url":"https://github.com/ryane","followers_url":"https://api.github.com/users/ryane/followers","following_url":"https://api.github.com/users/ryane/following{/other_user}","gists_url":"https://api.github.com/users/ryane/gists{/gist_id}","starred_url":"https://api.github.com/users/ryane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryane/subscriptions","organizations_url":"https://api.github.com/users/ryane/orgs","repos_url":"https://api.github.com/users/ryane/repos","events_url":"https://api.github.com/users/ryane/events{/privacy}","received_events_url":"https://api.github.com/users/ryane/received_events","type":"User","site_admin":false},"body":"When `helm init -o yaml|json` is run, the service and optional secret manifests\r\nwill be included in the output. The manifests are included in a Kubernetes\r\n[List](https://godoc.org/k8s.io/apimachinery/pkg/apis/meta/v1#List) object.\r\n\r\nThis also includes some refactoring and consolidates how manifests are output in\r\n`--dry-run` and removes some unnecessary marshaling between Kubernetes objects\r\nand strings.\r\n\r\nFixes #3145","created_at":"2018-02-22T17:43:03Z","updated_at":"2018-02-27T17:14:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2c62cb32f262e624e3fd4ecd5dd30d02c446f6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484574947,"url":"https://api.github.com/repos/kubernetes/helm/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":562687520,"url":"https://api.github.com/repos/kubernetes/helm/labels/feature","name":"feature","color":"0052cc","default":false},{"id":676353308,"url":"https://api.github.com/repos/kubernetes/helm/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/helm/pulls/3556/commits","review_comments_url":"https://api.github.com/repos/kubernetes/helm/pulls/3556/comments","review_comment_url":"https://api.github.com/repos/kubernetes/helm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/helm/issues/3556/comments","statuses_url":"https://api.github.com/repos/kubernetes/helm/statuses/61e88cbc412a0a77e4eba3dc03b888cc18ea647e","head":{"label":"ryane:fix/init-output-service","ref":"fix/init-output-service","sha":"61e88cbc412a0a77e4eba3dc03b888cc18ea647e","user":{"login":"ryane","id":7346,"avatar_url":"https://avatars3.githubusercontent.com/u/7346?v=4","gravatar_id":"","url":"https://api.github.com/users/ryane","html_url":"https://github.com/ryane","followers_url":"https://api.github.com/users/ryane/followers","following_url":"https://api.github.com/users/ryane/following{/other_user}","gists_url":"https://api.github.com/users/ryane/gists{/gist_id}","starred_url":"https://api.github.com/users/ryane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryane/subscriptions","organizations_url":"https://api.github.com/users/ryane/orgs","repos_url":"https://api.github.com/users/ryane/repos","events_url":"https://api.github.com/users/ryane/events{/privacy}","received_events_url":"https://api.github.com/users/ryane/received_events","type":"User","site_admin":false},"repo":{"id":122124830,"name":"helm","full_name":"ryane/helm","owner":{"login":"ryane","id":7346,"avatar_url":"https://avatars3.githubusercontent.com/u/7346?v=4","gravatar_id":"","url":"https://api.github.com/users/ryane","html_url":"https://github.com/ryane","followers_url":"https://api.github.com/users/ryane/followers","following_url":"https://api.github.com/users/ryane/following{/other_user}","gists_url":"https://api.github.com/users/ryane/gists{/gist_id}","starred_url":"https://api.github.com/users/ryane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryane/subscriptions","organizations_url":"https://api.github.com/users/ryane/orgs","repos_url":"https://api.github.com/users/ryane/repos","events_url":"https://api.github.com/users/ryane/events{/privacy}","received_events_url":"https://api.github.com/users/ryane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryane/helm","description":"The Kubernetes Package Manager","fork":true,"url":"https://api.github.com/repos/ryane/helm","forks_url":"https://api.github.com/repos/ryane/helm/forks","keys_url":"https://api.github.com/repos/ryane/helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryane/helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryane/helm/teams","hooks_url":"https://api.github.com/repos/ryane/helm/hooks","issue_events_url":"https://api.github.com/repos/ryane/helm/issues/events{/number}","events_url":"https://api.github.com/repos/ryane/helm/events","assignees_url":"https://api.github.com/repos/ryane/helm/assignees{/user}","branches_url":"https://api.github.com/repos/ryane/helm/branches{/branch}","tags_url":"https://api.github.com/repos/ryane/helm/tags","blobs_url":"https://api.github.com/repos/ryane/helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryane/helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryane/helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryane/helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryane/helm/statuses/{sha}","languages_url":"https://api.github.com/repos/ryane/helm/languages","stargazers_url":"https://api.github.com/repos/ryane/helm/stargazers","contributors_url":"https://api.github.com/repos/ryane/helm/contributors","subscribers_url":"https://api.github.com/repos/ryane/helm/subscribers","subscription_url":"https://api.github.com/repos/ryane/helm/subscription","commits_url":"https://api.github.com/repos/ryane/helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryane/helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryane/helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryane/helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryane/helm/contents/{+path}","compare_url":"https://api.github.com/repos/ryane/helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryane/helm/merges","archive_url":"https://api.github.com/repos/ryane/helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryane/helm/downloads","issues_url":"https://api.github.com/repos/ryane/helm/issues{/number}","pulls_url":"https://api.github.com/repos/ryane/helm/pulls{/number}","milestones_url":"https://api.github.com/repos/ryane/helm/milestones{/number}","notifications_url":"https://api.github.com/repos/ryane/helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryane/helm/labels{/name}","releases_url":"https://api.github.com/repos/ryane/helm/releases{/id}","deployments_url":"https://api.github.com/repos/ryane/helm/deployments","created_at":"2018-02-19T21:49:21Z","updated_at":"2018-02-19T21:49:24Z","pushed_at":"2018-02-24T01:50:11Z","git_url":"git://github.com/ryane/helm.git","ssh_url":"git@github.com:ryane/helm.git","clone_url":"https://github.com/ryane/helm.git","svn_url":"https://github.com/ryane/helm","homepage":"","size":8769,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"d0883dd8138947772239c25e212926d1afb1fcef","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":43723161,"name":"helm","full_name":"kubernetes/helm","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/helm","description":"The Kubernetes Package Manager","fork":false,"url":"https://api.github.com/repos/kubernetes/helm","forks_url":"https://api.github.com/repos/kubernetes/helm/forks","keys_url":"https://api.github.com/repos/kubernetes/helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/helm/teams","hooks_url":"https://api.github.com/repos/kubernetes/helm/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/helm/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/helm/events","assignees_url":"https://api.github.com/repos/kubernetes/helm/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/helm/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/helm/tags","blobs_url":"https://api.github.com/repos/kubernetes/helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/helm/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/helm/languages","stargazers_url":"https://api.github.com/repos/kubernetes/helm/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/helm/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/helm/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/helm/subscription","commits_url":"https://api.github.com/repos/kubernetes/helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/helm/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/helm/merges","archive_url":"https://api.github.com/repos/kubernetes/helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/helm/downloads","issues_url":"https://api.github.com/repos/kubernetes/helm/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/helm/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/helm/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/helm/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/helm/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/helm/deployments","created_at":"2015-10-06T01:07:32Z","updated_at":"2018-02-27T14:32:35Z","pushed_at":"2018-02-27T17:00:53Z","git_url":"git://github.com/kubernetes/helm.git","ssh_url":"git@github.com:kubernetes/helm.git","clone_url":"https://github.com/kubernetes/helm.git","svn_url":"https://github.com/kubernetes/helm","homepage":"","size":9234,"stargazers_count":4288,"watchers_count":4288,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1505,"mirror_url":null,"archived":false,"open_issues_count":447,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1505,"open_issues":447,"watchers":4288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/3556"},"html":{"href":"https://github.com/kubernetes/helm/pull/3556"},"issue":{"href":"https://api.github.com/repos/kubernetes/helm/issues/3556"},"comments":{"href":"https://api.github.com/repos/kubernetes/helm/issues/3556/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/3556/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/3556/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/helm/statuses/61e88cbc412a0a77e4eba3dc03b888cc18ea647e"}},"author_association":"NONE"}}
{"actor":{"display_login":"ryane"}}