{"action":"created","issue":{"url":"https://api.github.com/repos/open-mpi/hwloc/issues/327","repository_url":"https://api.github.com/repos/open-mpi/hwloc","labels_url":"https://api.github.com/repos/open-mpi/hwloc/issues/327/labels{/name}","comments_url":"https://api.github.com/repos/open-mpi/hwloc/issues/327/comments","events_url":"https://api.github.com/repos/open-mpi/hwloc/issues/327/events","html_url":"https://github.com/open-mpi/hwloc/pull/327","id":362978404,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTMxOTE1","number":327,"title":"Support for clang-cl on windows","user":{"login":"isuruf","id":5234427,"node_id":"MDQ6VXNlcjUyMzQ0Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/5234427?v=4","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-23T21:20:12Z","updated_at":"2018-09-24T05:39:19Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/open-mpi/hwloc/pulls/327","html_url":"https://github.com/open-mpi/hwloc/pull/327","diff_url":"https://github.com/open-mpi/hwloc/pull/327.diff","patch_url":"https://github.com/open-mpi/hwloc/pull/327.patch"},"body":"I'm using a simple wrapper around clang-cl for making the configure script work.\r\n\r\nThere are few things that I need to change that I need help with,\r\n\r\n1. Line https://github.com/open-mpi/hwloc/blob/f3ba1fea561c23c5afd1c3856818506fced4c96f/hwloc/Makefile.am#L170 needs to be changed as clang-cl doesn't understand `--output-def` and libtool creates it. It needs to be changed to `-Xlinker -def:.libs/libhwloc.def` depending on whether we are using clang-cl or gnu tools like mingw and cygwin.\r\n\r\n2. strcasecmp check goes through with a warning of implicit declaration.\r\n"},"comment":{"url":"https://api.github.com/repos/open-mpi/hwloc/issues/comments/423880698","html_url":"https://github.com/open-mpi/hwloc/pull/327#issuecomment-423880698","issue_url":"https://api.github.com/repos/open-mpi/hwloc/issues/327","id":423880698,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzg4MDY5OA==","user":{"login":"bgoglin","id":827599,"node_id":"MDQ6VXNlcjgyNzU5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/827599?v=4","gravatar_id":"","url":"https://api.github.com/users/bgoglin","html_url":"https://github.com/bgoglin","followers_url":"https://api.github.com/users/bgoglin/followers","following_url":"https://api.github.com/users/bgoglin/following{/other_user}","gists_url":"https://api.github.com/users/bgoglin/gists{/gist_id}","starred_url":"https://api.github.com/users/bgoglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgoglin/subscriptions","organizations_url":"https://api.github.com/users/bgoglin/orgs","repos_url":"https://api.github.com/users/bgoglin/repos","events_url":"https://api.github.com/users/bgoglin/events{/privacy}","received_events_url":"https://api.github.com/users/bgoglin/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T05:39:19Z","updated_at":"2018-09-24T05:39:19Z","author_association":"CONTRIBUTOR","body":"Given that there's not a single comment in your wrapper, can you explain what it does?\r\n\r\nThere's another good thing about using clang on Windows, it's C99 compliant. MSVC is really a pain on that side. However I was rather thinking of using clang inside a VS solution (but didn't try). If our VS solution isn't compatible with recent VS, it's really annoying to maintain...\r\n\r\n@sthibaul Do you remember why you used that def file for Windows 9 years ago? :)"}}
{"actor":{"display_login":"bgoglin"}}