{"action":"created","issue":{"url":"https://api.github.com/repos/Jekiwijaya/react-navigation-browser-history-helpers/issues/10","repository_url":"https://api.github.com/repos/Jekiwijaya/react-navigation-browser-history-helpers","labels_url":"https://api.github.com/repos/Jekiwijaya/react-navigation-browser-history-helpers/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/Jekiwijaya/react-navigation-browser-history-helpers/issues/10/comments","events_url":"https://api.github.com/repos/Jekiwijaya/react-navigation-browser-history-helpers/issues/10/events","html_url":"https://github.com/Jekiwijaya/react-navigation-browser-history-helpers/pull/10","id":357202946,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjczMzky","number":10,"title":"[FIX]  Default navigation state","user":{"login":"drgx","id":5230095,"node_id":"MDQ6VXNlcjUyMzAwOTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5230095?v=4","gravatar_id":"","url":"https://api.github.com/users/drgx","html_url":"https://github.com/drgx","followers_url":"https://api.github.com/users/drgx/followers","following_url":"https://api.github.com/users/drgx/following{/other_user}","gists_url":"https://api.github.com/users/drgx/gists{/gist_id}","starred_url":"https://api.github.com/users/drgx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drgx/subscriptions","organizations_url":"https://api.github.com/users/drgx/orgs","repos_url":"https://api.github.com/users/drgx/repos","events_url":"https://api.github.com/users/drgx/events{/privacy}","received_events_url":"https://api.github.com/users/drgx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-05T12:20:43Z","updated_at":"2018-09-05T12:33:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Jekiwijaya/react-navigation-browser-history-helpers/pulls/10","html_url":"https://github.com/Jekiwijaya/react-navigation-browser-history-helpers/pull/10","diff_url":"https://github.com/Jekiwijaya/react-navigation-browser-history-helpers/pull/10.diff","patch_url":"https://github.com/Jekiwijaya/react-navigation-browser-history-helpers/pull/10.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/Jekiwijaya/react-navigation-browser-history-helpers/issues/comments/418713451","html_url":"https://github.com/Jekiwijaya/react-navigation-browser-history-helpers/pull/10#issuecomment-418713451","issue_url":"https://api.github.com/repos/Jekiwijaya/react-navigation-browser-history-helpers/issues/10","id":418713451,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODcxMzQ1MQ==","user":{"login":"Jekiwijaya","id":6567775,"node_id":"MDQ6VXNlcjY1Njc3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6567775?v=4","gravatar_id":"","url":"https://api.github.com/users/Jekiwijaya","html_url":"https://github.com/Jekiwijaya","followers_url":"https://api.github.com/users/Jekiwijaya/followers","following_url":"https://api.github.com/users/Jekiwijaya/following{/other_user}","gists_url":"https://api.github.com/users/Jekiwijaya/gists{/gist_id}","starred_url":"https://api.github.com/users/Jekiwijaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jekiwijaya/subscriptions","organizations_url":"https://api.github.com/users/Jekiwijaya/orgs","repos_url":"https://api.github.com/users/Jekiwijaya/repos","events_url":"https://api.github.com/users/Jekiwijaya/events{/privacy}","received_events_url":"https://api.github.com/users/Jekiwijaya/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T12:33:29Z","updated_at":"2018-09-05T12:33:29Z","author_association":"OWNER","body":"- query string still must be needed. But we must remove `query string` that have been registered in routeName / params.\r\n- We may need create a contract, to ignore `state.params`, that dangling with `_` to make it didn't put in query-string everytime params is changed.. Because, there would be a problem, if some component put a value in `state.params` in listener, like `onScroll`. ex: \r\n```\r\n<ScrollView onScroll={(...) => this.props.navigation.setParams(...)}>\r\n....\r\n</ScrollView>\r\n```\r\n- We must also remove params that have `type of function`, since it has no use in query string."}}
{"actor":{"display_login":"Jekiwijaya"}}