{"action":"closed","issue":{"url":"https://api.github.com/repos/jorgebucaran/fisher/issues/448","repository_url":"https://api.github.com/repos/jorgebucaran/fisher","labels_url":"https://api.github.com/repos/jorgebucaran/fisher/issues/448/labels{/name}","comments_url":"https://api.github.com/repos/jorgebucaran/fisher/issues/448/comments","events_url":"https://api.github.com/repos/jorgebucaran/fisher/issues/448/events","html_url":"https://github.com/jorgebucaran/fisher/issues/448","id":359683272,"node_id":"MDU6SXNzdWUzNTk2ODMyNzI=","number":448,"title":"V3 fish_key_bindings API","user":{"login":"jorgebucaran","id":56996,"node_id":"MDQ6VXNlcjU2OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/56996?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebucaran","html_url":"https://github.com/jorgebucaran","followers_url":"https://api.github.com/users/jorgebucaran/followers","following_url":"https://api.github.com/users/jorgebucaran/following{/other_user}","gists_url":"https://api.github.com/users/jorgebucaran/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebucaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebucaran/subscriptions","organizations_url":"https://api.github.com/users/jorgebucaran/orgs","repos_url":"https://api.github.com/users/jorgebucaran/repos","events_url":"https://api.github.com/users/jorgebucaran/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebucaran/received_events","type":"User","site_admin":false},"labels":[{"id":1048523837,"node_id":"MDU6TGFiZWwxMDQ4NTIzODM3","url":"https://api.github.com/repos/jorgebucaran/fisher/labels/Discussion","name":"Discussion","color":"7057ff","default":false},{"id":361754836,"node_id":"MDU6TGFiZWwzNjE3NTQ4MzY=","url":"https://api.github.com/repos/jorgebucaran/fisher/labels/Feature","name":"Feature","color":"e9e9ff","default":false}],"state":"closed","locked":false,"assignee":{"login":"jorgebucaran","id":56996,"node_id":"MDQ6VXNlcjU2OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/56996?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebucaran","html_url":"https://github.com/jorgebucaran","followers_url":"https://api.github.com/users/jorgebucaran/followers","following_url":"https://api.github.com/users/jorgebucaran/following{/other_user}","gists_url":"https://api.github.com/users/jorgebucaran/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebucaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebucaran/subscriptions","organizations_url":"https://api.github.com/users/jorgebucaran/orgs","repos_url":"https://api.github.com/users/jorgebucaran/repos","events_url":"https://api.github.com/users/jorgebucaran/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebucaran/received_events","type":"User","site_admin":false},"assignees":[{"login":"jorgebucaran","id":56996,"node_id":"MDQ6VXNlcjU2OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/56996?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebucaran","html_url":"https://github.com/jorgebucaran","followers_url":"https://api.github.com/users/jorgebucaran/followers","following_url":"https://api.github.com/users/jorgebucaran/following{/other_user}","gists_url":"https://api.github.com/users/jorgebucaran/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebucaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebucaran/subscriptions","organizations_url":"https://api.github.com/users/jorgebucaran/orgs","repos_url":"https://api.github.com/users/jorgebucaran/repos","events_url":"https://api.github.com/users/jorgebucaran/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebucaran/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/jorgebucaran/fisher/milestones/20","html_url":"https://github.com/jorgebucaran/fisher/milestone/20","labels_url":"https://api.github.com/repos/jorgebucaran/fisher/milestones/20/labels","id":3650117,"node_id":"MDk6TWlsZXN0b25lMzY1MDExNw==","number":20,"title":"V3","description":null,"creator":{"login":"jorgebucaran","id":56996,"node_id":"MDQ6VXNlcjU2OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/56996?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebucaran","html_url":"https://github.com/jorgebucaran","followers_url":"https://api.github.com/users/jorgebucaran/followers","following_url":"https://api.github.com/users/jorgebucaran/following{/other_user}","gists_url":"https://api.github.com/users/jorgebucaran/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebucaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebucaran/subscriptions","organizations_url":"https://api.github.com/users/jorgebucaran/orgs","repos_url":"https://api.github.com/users/jorgebucaran/repos","events_url":"https://api.github.com/users/jorgebucaran/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebucaran/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":3,"state":"open","created_at":"2018-09-12T23:03:33Z","updated_at":"2018-10-05T11:45:08Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-09-12T23:03:46Z","updated_at":"2018-10-05T11:45:08Z","closed_at":"2018-10-05T11:45:07Z","author_association":"OWNER","body":"## Summary\r\n\r\nFisher provides key bindings support via fish configuration snippets, so please upgrade your shell. If you are stuck in fish 2.2 or older you can still take advantage of this feature, but you'll need to run configuration snippets manually as [described in the documentation](https://github.com/jorgebucaran/fisher#legacy-fish-support).\r\n\r\nFor fish 2.x (any version prior to 3.0) you'll need the [fish-custom-key-bindings]() (WIP) package. Adding this to your ~/.config/fish/config.fish works as well.\r\n\r\n```fish\r\nif functions -q fish_user_key_bindings\r\n    if not functions -q _keybinder_fish_user_key_bindings\r\n        functions -c fish_user_key_bindings _keybinder_fish_user_key_bindings\r\n    end\r\nend\r\n\r\ntest -z \"$XDG_CONFIG_HOME\"; and set XDG_CONFIG_HOME ~/.config\r\n\r\nfunction fish_user_key_bindings\r\n    for file in $XDG_CONFIG_HOME/fish/conf.d/*_key_bindings.fish\r\n        source $file\r\n    end\r\n    if functions -q _keybinder_fish_user_key_bindings\r\n        _keybinder_fish_user_key_bindings\r\n    end\r\nend\r\n```\r\n\r\nFor fish 3.0 and newer you don't need to do anything. Enjoy!\r\n\r\n## Key Bindings\r\n\r\nTo provide key bindings with your package add them to a configuration snippet. I suggest using the following package structure:\r\n\r\n```\r\nfish-foo\r\n└── conf.d\r\n    └── foo_key_bindings.fish\r\n```\r\n\r\nUnlike functions or completions, which can be erased programmatically, we can't undo a configuration snippet, so you need to provide custom uninstall logic to erase the key bindings. You can do that as follows in `foo_key_bindings.fish`. \r\n\r\n```fish\r\nbind ...\r\n\r\nfunction foo_uninstall --event foo_uninstall\r\n    bind -e ...\r\nend\r\n```\r\n\r\nFor more information see [configuration snippets](https://github.com/jorgebucaran/fisher#configuration-snippets) in the documentation."}}
{"actor":{"display_login":"jorgebucaran"}}