{"action":"created","comment":{"url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments/224773753","pull_request_review_id":164224907,"id":224773753,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDc3Mzc1Mw==","diff_hunk":"@@ -484,19 +494,37 @@ private void findInconsistencyInternal(Map<String, List<VdrBucketId>> oneSet, fi\n         if (currlist.size() > numbuckets_of_root) {\n           currlist.forEach(x -> {\n             if (!bucketIdsOfRoot.contains(x.bucketId)) {\n-              badBuckets.add(x);\n-              if (!this.inconsistent) {\n-                this.inconsistent = true;\n+              String badBucketName = x.vdr.getName();\n+              String[] parts = SystemProperties.SHADOW_SCHEMA_NAME_WITH_SEPARATOR.split(\"_\");\n+              if (badBucketName != null && badBucketName.indexOf(parts[0]) != -1 &&\n+                  badBucketName.indexOf(parts[1]) != -1) {\n+                this.printValidateOutput = true;\n+                badBucketsColumnBuffer.add(x);\n+              } else {\n+                badBuckets.add(x);\n+                if (!this.inconsistent) {\n+                  this.inconsistent = true;\n+                }\n               }\n             }\n           });\n         }\n       }\n \n       if (badBuckets.size() > 0) {\n-        sb.append(\"In \" + rootPR + \" co-location group, parent bucket is missing for these buckets\\n\");\n+        sb.append(\"Colocated bucket not found in this disk store for following buckets.\\n\");\n+        sb.append(\"Either it is an error or you may have used a different disk store for colocated region\\n\");\n         badBuckets.forEach(x -> sb.append(x.vdr.getName() + \"\\n\"));\n-        sb.append(\"\\n\");\n+      }\n+\n+      if (badBucketsColumnBuffer.size() > 0) {\n+        columnBufferSb.append(\"\\nColumn buffer buckets needs to be manually verified.\\n\");\n+        columnBufferSb.append(\"\\nThese have their colocated row buffer buckets in SNAPPY-INTERNAL-DELTA disk store\\n\");","path":"gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PersistentOplogSet.java","position":98,"original_position":98,"commit_id":"d036c3d0a6d7e0465f061f1c097db9187189fa11","original_commit_id":"d036c3d0a6d7e0465f061f1c097db9187189fa11","user":{"login":"sumwale","id":11540628,"node_id":"MDQ6VXNlcjExNTQwNjI4","avatar_url":"https://avatars3.githubusercontent.com/u/11540628?v=4","gravatar_id":"","url":"https://api.github.com/users/sumwale","html_url":"https://github.com/sumwale","followers_url":"https://api.github.com/users/sumwale/followers","following_url":"https://api.github.com/users/sumwale/following{/other_user}","gists_url":"https://api.github.com/users/sumwale/gists{/gist_id}","starred_url":"https://api.github.com/users/sumwale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumwale/subscriptions","organizations_url":"https://api.github.com/users/sumwale/orgs","repos_url":"https://api.github.com/users/sumwale/repos","events_url":"https://api.github.com/users/sumwale/events{/privacy}","received_events_url":"https://api.github.com/users/sumwale/received_events","type":"User","site_admin":false},"body":"break the line","created_at":"2018-10-12T12:55:32Z","updated_at":"2018-10-12T12:58:53Z","html_url":"https://github.com/SnappyDataInc/snappy-store/pull/436#discussion_r224773753","pull_request_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/436","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments/224773753"},"html":{"href":"https://github.com/SnappyDataInc/snappy-store/pull/436#discussion_r224773753"},"pull_request":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/436"}}},"pull_request":{"url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/436","id":222438734,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDM4NzM0","html_url":"https://github.com/SnappyDataInc/snappy-store/pull/436","diff_url":"https://github.com/SnappyDataInc/snappy-store/pull/436.diff","patch_url":"https://github.com/SnappyDataInc/snappy-store/pull/436.patch","issue_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/436","number":436,"state":"open","locked":false,"title":"Snap 2562","user":{"login":"kneeraj","id":1151021,"node_id":"MDQ6VXNlcjExNTEwMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1151021?v=4","gravatar_id":"","url":"https://api.github.com/users/kneeraj","html_url":"https://github.com/kneeraj","followers_url":"https://api.github.com/users/kneeraj/followers","following_url":"https://api.github.com/users/kneeraj/following{/other_user}","gists_url":"https://api.github.com/users/kneeraj/gists{/gist_id}","starred_url":"https://api.github.com/users/kneeraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kneeraj/subscriptions","organizations_url":"https://api.github.com/users/kneeraj/orgs","repos_url":"https://api.github.com/users/kneeraj/repos","events_url":"https://api.github.com/users/kneeraj/events{/privacy}","received_events_url":"https://api.github.com/users/kneeraj/received_events","type":"User","site_admin":false},"body":"## Changes proposed in this pull request\r\n\r\nValidate-disk-store tool is broken for colocation check.\r\nThe reason is that we create a \"SNAPPY_INTERNAL_DELTA\" for row buffer pr region and the column store disk store in the default disk store. This tool was modified to check whether all the related buckets are there or not and the assumption was that all the colocated PRs will use the same DISK STORE for persistence.\r\nThis assumption is not right and in case of column tables we have actually separated the row buffer pr disk store and the column buffer pr diskstore.\r\n\r\nSo right now the tool has been modified to also list all the disk regions, so that at least manually it can be verified.\r\n\r\n## Patch testing\r\n\r\nmanual testing\r\n\r\n## Is precheckin with -Pstore clean?\r\n\r\n## ReleaseNotes changes\r\n\r\nvalidate-disk-store tools should call out as to how we can run the validate command on the disk store and the internal delta disk store and can cross check.\r\n\r\n## Other PRs \r\n\r\nNo.\r\n","created_at":"2018-10-12T11:41:11Z","updated_at":"2018-10-12T12:58:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4b31450ba01816415fb3e7283914cffb0ae411c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"suranjan","id":189977,"node_id":"MDQ6VXNlcjE4OTk3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/189977?v=4","gravatar_id":"","url":"https://api.github.com/users/suranjan","html_url":"https://github.com/suranjan","followers_url":"https://api.github.com/users/suranjan/followers","following_url":"https://api.github.com/users/suranjan/following{/other_user}","gists_url":"https://api.github.com/users/suranjan/gists{/gist_id}","starred_url":"https://api.github.com/users/suranjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suranjan/subscriptions","organizations_url":"https://api.github.com/users/suranjan/orgs","repos_url":"https://api.github.com/users/suranjan/repos","events_url":"https://api.github.com/users/suranjan/events{/privacy}","received_events_url":"https://api.github.com/users/suranjan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/436/commits","review_comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/436/comments","review_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/436/comments","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/d036c3d0a6d7e0465f061f1c097db9187189fa11","head":{"label":"SnappyDataInc:SNAP-2562","ref":"SNAP-2562","sha":"d036c3d0a6d7e0465f061f1c097db9187189fa11","user":{"login":"SnappyDataInc","id":11342682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQyNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48800286,"node_id":"MDEwOlJlcG9zaXRvcnk0ODgwMDI4Ng==","name":"snappy-store","full_name":"SnappyDataInc/snappy-store","private":false,"owner":{"login":"SnappyDataInc","id":11342682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQyNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SnappyDataInc/snappy-store","description":"SnappyStore","fork":true,"url":"https://api.github.com/repos/SnappyDataInc/snappy-store","forks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/deployments","created_at":"2015-12-30T12:44:56Z","updated_at":"2018-10-11T11:42:19Z","pushed_at":"2018-10-12T12:02:40Z","git_url":"git://github.com/SnappyDataInc/snappy-store.git","ssh_url":"git@github.com:SnappyDataInc/snappy-store.git","clone_url":"https://github.com/SnappyDataInc/snappy-store.git","svn_url":"https://github.com/SnappyDataInc/snappy-store","homepage":"","size":130028,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":20,"watchers":35,"default_branch":"snappy/master"}},"base":{"label":"SnappyDataInc:snappy/master","ref":"snappy/master","sha":"1a0ec4345f257d228d9dcbe94b19004224c6c2d9","user":{"login":"SnappyDataInc","id":11342682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQyNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48800286,"node_id":"MDEwOlJlcG9zaXRvcnk0ODgwMDI4Ng==","name":"snappy-store","full_name":"SnappyDataInc/snappy-store","private":false,"owner":{"login":"SnappyDataInc","id":11342682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQyNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SnappyDataInc/snappy-store","description":"SnappyStore","fork":true,"url":"https://api.github.com/repos/SnappyDataInc/snappy-store","forks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/deployments","created_at":"2015-12-30T12:44:56Z","updated_at":"2018-10-11T11:42:19Z","pushed_at":"2018-10-12T12:02:40Z","git_url":"git://github.com/SnappyDataInc/snappy-store.git","ssh_url":"git@github.com:SnappyDataInc/snappy-store.git","clone_url":"https://github.com/SnappyDataInc/snappy-store.git","svn_url":"https://github.com/SnappyDataInc/snappy-store","homepage":"","size":130028,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":20,"watchers":35,"default_branch":"snappy/master"}},"_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/436"},"html":{"href":"https://github.com/SnappyDataInc/snappy-store/pull/436"},"issue":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/436"},"comments":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/436/comments"},"review_comments":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/436/comments"},"review_comment":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/436/commits"},"statuses":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/d036c3d0a6d7e0465f061f1c097db9187189fa11"}},"author_association":"NONE"}}
{"actor":{"display_login":"sumwale"}}