{"action":"created","comment":{"url":"https://api.github.com/repos/canalplus/rx-player/pulls/comments/228878199","pull_request_review_id":169239574,"id":228878199,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODg3ODE5OQ==","diff_hunk":"@@ -169,18 +175,38 @@ export default function StreamLoader({\n       sourceBufferManager,\n       segmentPipelinesManager,\n       bufferOptions\n-    ).pipe(mergeMap((evt) : Observable<IStreamLoaderEvent> => {\n-      switch (evt.type) {\n-        case \"end-of-stream\":\n-          return maintainEndOfStream(mediaSource)\n-            .pipe(ignoreElements(), takeUntil(cancelEndOfStream$));\n-        case \"resume-stream\":\n-          cancelEndOfStream$.next(null);\n-          return EMPTY;\n-        default:\n-          return onBufferEvent(evt);\n-      }\n-    }));\n+    ).pipe(\n+      mergeMap((evt) : Observable<IStreamLoaderEvent> => {\n+        switch (evt.type) {\n+          case \"end-of-stream\":\n+            return maintainEndOfStream(mediaSource)\n+              .pipe(ignoreElements(), takeUntil(cancelEndOfStream$));\n+          case \"resume-stream\":\n+            cancelEndOfStream$.next(null);\n+            return EMPTY;\n+          case \"discontinuity-encountered\":\n+            if (SourceBufferManager.isNative(evt.value.bufferType)) {\n+              log.warn(\"explicit discontinuity seek\", evt.value.nextTime);\n+              mediaElement.currentTime = evt.value.nextTime;\n+            }\n+            return EMPTY;\n+          case \"needs-manifest-refresh\":\n+            log.debug(\"needs manifest to be refreshed\");\n+            // out-of-index messages require a complete reloading of the\n+            // manifest to refresh the current index","path":"src/core/stream/stream_loader.ts","position":120,"original_position":120,"commit_id":"86286e3511838c97dd16b3746d38c6dae942e36d","original_commit_id":"86286e3511838c97dd16b3746d38c6dae942e36d","user":{"login":"peaBerberian","id":8694124,"node_id":"MDQ6VXNlcjg2OTQxMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8694124?v=4","gravatar_id":"","url":"https://api.github.com/users/peaBerberian","html_url":"https://github.com/peaBerberian","followers_url":"https://api.github.com/users/peaBerberian/followers","following_url":"https://api.github.com/users/peaBerberian/following{/other_user}","gists_url":"https://api.github.com/users/peaBerberian/gists{/gist_id}","starred_url":"https://api.github.com/users/peaBerberian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peaBerberian/subscriptions","organizations_url":"https://api.github.com/users/peaBerberian/orgs","repos_url":"https://api.github.com/users/peaBerberian/repos","events_url":"https://api.github.com/users/peaBerberian/events{/privacy}","received_events_url":"https://api.github.com/users/peaBerberian/received_events","type":"User","site_admin":false},"body":"this comment makes no sense here (might me mine, but I just realized that)","created_at":"2018-10-29T10:54:09Z","updated_at":"2018-10-29T10:59:52Z","html_url":"https://github.com/canalplus/rx-player/pull/347#discussion_r228878199","pull_request_url":"https://api.github.com/repos/canalplus/rx-player/pulls/347","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/canalplus/rx-player/pulls/comments/228878199"},"html":{"href":"https://github.com/canalplus/rx-player/pull/347#discussion_r228878199"},"pull_request":{"href":"https://api.github.com/repos/canalplus/rx-player/pulls/347"}}},"pull_request":{"url":"https://api.github.com/repos/canalplus/rx-player/pulls/347","id":224717039,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzE3MDM5","html_url":"https://github.com/canalplus/rx-player/pull/347","diff_url":"https://github.com/canalplus/rx-player/pull/347.diff","patch_url":"https://github.com/canalplus/rx-player/pull/347.patch","issue_url":"https://api.github.com/repos/canalplus/rx-player/issues/347","number":347,"state":"open","locked":false,"title":"Consider minimum update period to refresh manifest (Simpler alternative)","user":{"login":"grenault73","id":12694091,"node_id":"MDQ6VXNlcjEyNjk0MDkx","avatar_url":"https://avatars0.githubusercontent.com/u/12694091?v=4","gravatar_id":"","url":"https://api.github.com/users/grenault73","html_url":"https://github.com/grenault73","followers_url":"https://api.github.com/users/grenault73/followers","following_url":"https://api.github.com/users/grenault73/following{/other_user}","gists_url":"https://api.github.com/users/grenault73/gists{/gist_id}","starred_url":"https://api.github.com/users/grenault73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grenault73/subscriptions","organizations_url":"https://api.github.com/users/grenault73/orgs","repos_url":"https://api.github.com/users/grenault73/repos","events_url":"https://api.github.com/users/grenault73/events{/privacy}","received_events_url":"https://api.github.com/users/grenault73/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-22T15:24:33Z","updated_at":"2018-10-29T10:59:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"651bab2daa3bd2093b480e8d1e9f0d72a98970d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":708433192,"node_id":"MDU6TGFiZWw3MDg0MzMxOTI=","url":"https://api.github.com/repos/canalplus/rx-player/labels/DASH","name":"DASH","color":"fbca04","default":false},{"id":226045898,"node_id":"MDU6TGFiZWwyMjYwNDU4OTg=","url":"https://api.github.com/repos/canalplus/rx-player/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/canalplus/rx-player/pulls/347/commits","review_comments_url":"https://api.github.com/repos/canalplus/rx-player/pulls/347/comments","review_comment_url":"https://api.github.com/repos/canalplus/rx-player/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canalplus/rx-player/issues/347/comments","statuses_url":"https://api.github.com/repos/canalplus/rx-player/statuses/86286e3511838c97dd16b3746d38c6dae942e36d","head":{"label":"canalplus:feat/minimum-update-period2","ref":"feat/minimum-update-period2","sha":"86286e3511838c97dd16b3746d38c6dae942e36d","user":{"login":"canalplus","id":2371279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzEyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2371279?v=4","gravatar_id":"","url":"https://api.github.com/users/canalplus","html_url":"https://github.com/canalplus","followers_url":"https://api.github.com/users/canalplus/followers","following_url":"https://api.github.com/users/canalplus/following{/other_user}","gists_url":"https://api.github.com/users/canalplus/gists{/gist_id}","starred_url":"https://api.github.com/users/canalplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canalplus/subscriptions","organizations_url":"https://api.github.com/users/canalplus/orgs","repos_url":"https://api.github.com/users/canalplus/repos","events_url":"https://api.github.com/users/canalplus/events{/privacy}","received_events_url":"https://api.github.com/users/canalplus/received_events","type":"Organization","site_admin":false},"repo":{"id":37657658,"node_id":"MDEwOlJlcG9zaXRvcnkzNzY1NzY1OA==","name":"rx-player","full_name":"canalplus/rx-player","private":false,"owner":{"login":"canalplus","id":2371279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzEyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2371279?v=4","gravatar_id":"","url":"https://api.github.com/users/canalplus","html_url":"https://github.com/canalplus","followers_url":"https://api.github.com/users/canalplus/followers","following_url":"https://api.github.com/users/canalplus/following{/other_user}","gists_url":"https://api.github.com/users/canalplus/gists{/gist_id}","starred_url":"https://api.github.com/users/canalplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canalplus/subscriptions","organizations_url":"https://api.github.com/users/canalplus/orgs","repos_url":"https://api.github.com/users/canalplus/repos","events_url":"https://api.github.com/users/canalplus/events{/privacy}","received_events_url":"https://api.github.com/users/canalplus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/canalplus/rx-player","description":"Smooth/DASH HTML5 Video Player","fork":false,"url":"https://api.github.com/repos/canalplus/rx-player","forks_url":"https://api.github.com/repos/canalplus/rx-player/forks","keys_url":"https://api.github.com/repos/canalplus/rx-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canalplus/rx-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canalplus/rx-player/teams","hooks_url":"https://api.github.com/repos/canalplus/rx-player/hooks","issue_events_url":"https://api.github.com/repos/canalplus/rx-player/issues/events{/number}","events_url":"https://api.github.com/repos/canalplus/rx-player/events","assignees_url":"https://api.github.com/repos/canalplus/rx-player/assignees{/user}","branches_url":"https://api.github.com/repos/canalplus/rx-player/branches{/branch}","tags_url":"https://api.github.com/repos/canalplus/rx-player/tags","blobs_url":"https://api.github.com/repos/canalplus/rx-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canalplus/rx-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canalplus/rx-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/canalplus/rx-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canalplus/rx-player/statuses/{sha}","languages_url":"https://api.github.com/repos/canalplus/rx-player/languages","stargazers_url":"https://api.github.com/repos/canalplus/rx-player/stargazers","contributors_url":"https://api.github.com/repos/canalplus/rx-player/contributors","subscribers_url":"https://api.github.com/repos/canalplus/rx-player/subscribers","subscription_url":"https://api.github.com/repos/canalplus/rx-player/subscription","commits_url":"https://api.github.com/repos/canalplus/rx-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/canalplus/rx-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/canalplus/rx-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/canalplus/rx-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/canalplus/rx-player/contents/{+path}","compare_url":"https://api.github.com/repos/canalplus/rx-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canalplus/rx-player/merges","archive_url":"https://api.github.com/repos/canalplus/rx-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canalplus/rx-player/downloads","issues_url":"https://api.github.com/repos/canalplus/rx-player/issues{/number}","pulls_url":"https://api.github.com/repos/canalplus/rx-player/pulls{/number}","milestones_url":"https://api.github.com/repos/canalplus/rx-player/milestones{/number}","notifications_url":"https://api.github.com/repos/canalplus/rx-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canalplus/rx-player/labels{/name}","releases_url":"https://api.github.com/repos/canalplus/rx-player/releases{/id}","deployments_url":"https://api.github.com/repos/canalplus/rx-player/deployments","created_at":"2015-06-18T12:16:05Z","updated_at":"2018-10-24T10:33:37Z","pushed_at":"2018-10-29T10:31:22Z","git_url":"git://github.com/canalplus/rx-player.git","ssh_url":"git@github.com:canalplus/rx-player.git","clone_url":"https://github.com/canalplus/rx-player.git","svn_url":"https://github.com/canalplus/rx-player","homepage":"https://developers.canal-plus.com/rx-player/","size":40957,"stargazers_count":339,"watchers_count":339,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":13,"watchers":339,"default_branch":"master"}},"base":{"label":"canalplus:master","ref":"master","sha":"1213feb2abc991b5c3ec48bb2843089454bea1db","user":{"login":"canalplus","id":2371279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzEyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2371279?v=4","gravatar_id":"","url":"https://api.github.com/users/canalplus","html_url":"https://github.com/canalplus","followers_url":"https://api.github.com/users/canalplus/followers","following_url":"https://api.github.com/users/canalplus/following{/other_user}","gists_url":"https://api.github.com/users/canalplus/gists{/gist_id}","starred_url":"https://api.github.com/users/canalplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canalplus/subscriptions","organizations_url":"https://api.github.com/users/canalplus/orgs","repos_url":"https://api.github.com/users/canalplus/repos","events_url":"https://api.github.com/users/canalplus/events{/privacy}","received_events_url":"https://api.github.com/users/canalplus/received_events","type":"Organization","site_admin":false},"repo":{"id":37657658,"node_id":"MDEwOlJlcG9zaXRvcnkzNzY1NzY1OA==","name":"rx-player","full_name":"canalplus/rx-player","private":false,"owner":{"login":"canalplus","id":2371279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzEyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2371279?v=4","gravatar_id":"","url":"https://api.github.com/users/canalplus","html_url":"https://github.com/canalplus","followers_url":"https://api.github.com/users/canalplus/followers","following_url":"https://api.github.com/users/canalplus/following{/other_user}","gists_url":"https://api.github.com/users/canalplus/gists{/gist_id}","starred_url":"https://api.github.com/users/canalplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canalplus/subscriptions","organizations_url":"https://api.github.com/users/canalplus/orgs","repos_url":"https://api.github.com/users/canalplus/repos","events_url":"https://api.github.com/users/canalplus/events{/privacy}","received_events_url":"https://api.github.com/users/canalplus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/canalplus/rx-player","description":"Smooth/DASH HTML5 Video Player","fork":false,"url":"https://api.github.com/repos/canalplus/rx-player","forks_url":"https://api.github.com/repos/canalplus/rx-player/forks","keys_url":"https://api.github.com/repos/canalplus/rx-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canalplus/rx-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canalplus/rx-player/teams","hooks_url":"https://api.github.com/repos/canalplus/rx-player/hooks","issue_events_url":"https://api.github.com/repos/canalplus/rx-player/issues/events{/number}","events_url":"https://api.github.com/repos/canalplus/rx-player/events","assignees_url":"https://api.github.com/repos/canalplus/rx-player/assignees{/user}","branches_url":"https://api.github.com/repos/canalplus/rx-player/branches{/branch}","tags_url":"https://api.github.com/repos/canalplus/rx-player/tags","blobs_url":"https://api.github.com/repos/canalplus/rx-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canalplus/rx-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canalplus/rx-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/canalplus/rx-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canalplus/rx-player/statuses/{sha}","languages_url":"https://api.github.com/repos/canalplus/rx-player/languages","stargazers_url":"https://api.github.com/repos/canalplus/rx-player/stargazers","contributors_url":"https://api.github.com/repos/canalplus/rx-player/contributors","subscribers_url":"https://api.github.com/repos/canalplus/rx-player/subscribers","subscription_url":"https://api.github.com/repos/canalplus/rx-player/subscription","commits_url":"https://api.github.com/repos/canalplus/rx-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/canalplus/rx-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/canalplus/rx-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/canalplus/rx-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/canalplus/rx-player/contents/{+path}","compare_url":"https://api.github.com/repos/canalplus/rx-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canalplus/rx-player/merges","archive_url":"https://api.github.com/repos/canalplus/rx-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canalplus/rx-player/downloads","issues_url":"https://api.github.com/repos/canalplus/rx-player/issues{/number}","pulls_url":"https://api.github.com/repos/canalplus/rx-player/pulls{/number}","milestones_url":"https://api.github.com/repos/canalplus/rx-player/milestones{/number}","notifications_url":"https://api.github.com/repos/canalplus/rx-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canalplus/rx-player/labels{/name}","releases_url":"https://api.github.com/repos/canalplus/rx-player/releases{/id}","deployments_url":"https://api.github.com/repos/canalplus/rx-player/deployments","created_at":"2015-06-18T12:16:05Z","updated_at":"2018-10-24T10:33:37Z","pushed_at":"2018-10-29T10:31:22Z","git_url":"git://github.com/canalplus/rx-player.git","ssh_url":"git@github.com:canalplus/rx-player.git","clone_url":"https://github.com/canalplus/rx-player.git","svn_url":"https://github.com/canalplus/rx-player","homepage":"https://developers.canal-plus.com/rx-player/","size":40957,"stargazers_count":339,"watchers_count":339,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":13,"watchers":339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canalplus/rx-player/pulls/347"},"html":{"href":"https://github.com/canalplus/rx-player/pull/347"},"issue":{"href":"https://api.github.com/repos/canalplus/rx-player/issues/347"},"comments":{"href":"https://api.github.com/repos/canalplus/rx-player/issues/347/comments"},"review_comments":{"href":"https://api.github.com/repos/canalplus/rx-player/pulls/347/comments"},"review_comment":{"href":"https://api.github.com/repos/canalplus/rx-player/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canalplus/rx-player/pulls/347/commits"},"statuses":{"href":"https://api.github.com/repos/canalplus/rx-player/statuses/86286e3511838c97dd16b3746d38c6dae942e36d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"peaBerberian"}}