{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/18730","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/18730/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18730/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/18730/events","html_url":"https://github.com/magento/magento2/pull/18730","id":372343331,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTYwMDI4","number":18730,"title":"Sections LESS mixins: fix the issue with missing rules and incorrect default variables","user":{"login":"dmytro-ch","id":11693779,"node_id":"MDQ6VXNlcjExNjkzNzc5","avatar_url":"https://avatars3.githubusercontent.com/u/11693779?v=4","gravatar_id":"","url":"https://api.github.com/users/dmytro-ch","html_url":"https://github.com/dmytro-ch","followers_url":"https://api.github.com/users/dmytro-ch/followers","following_url":"https://api.github.com/users/dmytro-ch/following{/other_user}","gists_url":"https://api.github.com/users/dmytro-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/dmytro-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmytro-ch/subscriptions","organizations_url":"https://api.github.com/users/dmytro-ch/orgs","repos_url":"https://api.github.com/users/dmytro-ch/repos","events_url":"https://api.github.com/users/dmytro-ch/events{/privacy}","received_events_url":"https://api.github.com/users/dmytro-ch/received_events","type":"User","site_admin":false},"labels":[{"id":944451978,"node_id":"MDU6TGFiZWw5NDQ0NTE5Nzg=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Lib/Frontend","name":"Area: Lib/Frontend","color":"1d76db","default":false},{"id":933221567,"node_id":"MDU6TGFiZWw5MzMyMjE1Njc=","url":"https://api.github.com/repos/magento/magento2/labels/Award:%20bug%20fix","name":"Award: bug fix","color":"c5def5","default":false},{"id":887204232,"node_id":"MDU6TGFiZWw4ODcyMDQyMzI=","url":"https://api.github.com/repos/magento/magento2/labels/Partner:%20Atwix","name":"Partner: Atwix","color":"f9d0c4","default":false},{"id":164491159,"node_id":"MDU6TGFiZWwxNjQ0OTExNTk=","url":"https://api.github.com/repos/magento/magento2/labels/Progress:%20accept","name":"Progress: accept","color":"009800","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false},{"id":882948356,"node_id":"MDU6TGFiZWw4ODI5NDgzNTY=","url":"https://api.github.com/repos/magento/magento2/labels/partners-contribution","name":"partners-contribution","color":"f9d0c4","default":false}],"state":"closed","locked":false,"assignee":{"login":"sidolov","id":11355520,"node_id":"MDQ6VXNlcjExMzU1NTIw","avatar_url":"https://avatars3.githubusercontent.com/u/11355520?v=4","gravatar_id":"","url":"https://api.github.com/users/sidolov","html_url":"https://github.com/sidolov","followers_url":"https://api.github.com/users/sidolov/followers","following_url":"https://api.github.com/users/sidolov/following{/other_user}","gists_url":"https://api.github.com/users/sidolov/gists{/gist_id}","starred_url":"https://api.github.com/users/sidolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidolov/subscriptions","organizations_url":"https://api.github.com/users/sidolov/orgs","repos_url":"https://api.github.com/users/sidolov/repos","events_url":"https://api.github.com/users/sidolov/events{/privacy}","received_events_url":"https://api.github.com/users/sidolov/received_events","type":"User","site_admin":false},"assignees":[{"login":"sidolov","id":11355520,"node_id":"MDQ6VXNlcjExMzU1NTIw","avatar_url":"https://avatars3.githubusercontent.com/u/11355520?v=4","gravatar_id":"","url":"https://api.github.com/users/sidolov","html_url":"https://github.com/sidolov","followers_url":"https://api.github.com/users/sidolov/followers","following_url":"https://api.github.com/users/sidolov/following{/other_user}","gists_url":"https://api.github.com/users/sidolov/gists{/gist_id}","starred_url":"https://api.github.com/users/sidolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidolov/subscriptions","organizations_url":"https://api.github.com/users/sidolov/orgs","repos_url":"https://api.github.com/users/sidolov/repos","events_url":"https://api.github.com/users/sidolov/events{/privacy}","received_events_url":"https://api.github.com/users/sidolov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/magento/magento2/milestones/23","html_url":"https://github.com/magento/magento2/milestone/23","labels_url":"https://api.github.com/repos/magento/magento2/milestones/23/labels","id":3664445,"node_id":"MDk6TWlsZXN0b25lMzY2NDQ0NQ==","number":23,"title":"Release: 2.3.1","description":"Community pull requests delivered to Release: 2.3.1 release","creator":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"open_issues":82,"closed_issues":155,"state":"open","created_at":"2018-09-18T07:31:32Z","updated_at":"2018-10-27T10:19:01Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-10-21T18:34:01Z","updated_at":"2018-10-27T10:19:56Z","closed_at":"2018-10-27T10:18:53Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18730","html_url":"https://github.com/magento/magento2/pull/18730","diff_url":"https://github.com/magento/magento2/pull/18730.diff","patch_url":"https://github.com/magento/magento2/pull/18730.patch"},"body":"There are couple of issues when trying to use mixins for \"tabs\" and \"accordion\".\r\n\r\nThe issue is related to `lib/web/css/source/lib/_sections.less`.\r\nThe default variables are predefined in `lib/web/css/source/lib/variables/_sections.less`.\r\n\r\n### Description (*)\r\nWhen you try to customize the view of \"tabs\" and \"accordion\" components by redefining the default variables in the scope of a custom theme, the following issues appear:\r\n\r\n1. The text color for active \"accordion\" control is not applied.\r\n2. The text-decoration for active control is not working for both \"accordion\" and \"tabs\" components.\r\n3. There are also incorrectly defined default variables for mixins. (e.g. accordion control visited and tab control hover variables etc.).\r\n\r\n\r\n### Fixed Issues (if relevant)\r\n1. magento/magento2#18729: Bug in \"_sections.less\" mixins: missing rules and incorrect default variables\r\n\r\n### Manual testing scenarios (*)\r\nLet's try to define the following variables in the scope of a custom theme.\r\n\r\n```\r\n@tab-control__active__background-color: yellow;\r\n@tab-control__active__color: red;\r\n@tab-control__active__text-decoration: underline;\r\n```\r\n\r\nAssuming that those variables are not defined elsewhere (in the scope of current or parent theme) except the default lib variables file `lib/web/css/source/lib/variables/_sections.less`.\r\n\r\n### Expected Result\r\nThere are red color, yellow background and underline text decoration applied for both accordion and tabs active controls.\r\n\r\n<img width=\"363\" alt=\"screen shot 2018-10-21 at 8 41 00 pm\" src=\"https://user-images.githubusercontent.com/11693779/47270654-c0f66d80-d577-11e8-8724-ea853a85df76.png\">\r\n<img width=\"558\" alt=\"screen shot 2018-10-21 at 8 52 33 pm\" src=\"https://user-images.githubusercontent.com/11693779/47270655-c0f66d80-d577-11e8-98ac-01be9ca5a1df.png\">\r\n\r\n### Contribution checklist (*)\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [x] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/433608633","html_url":"https://github.com/magento/magento2/pull/18730#issuecomment-433608633","issue_url":"https://api.github.com/repos/magento/magento2/issues/18730","id":433608633,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzYwODYzMw==","user":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"created_at":"2018-10-27T10:19:56Z","updated_at":"2018-10-27T10:19:56Z","author_association":"CONTRIBUTOR","body":"Hi @dmytro-ch. Thank you for your contribution. \nWe will aim to release these changes as part of 2.3.1. \nPlease check the release notes for final confirmation."}}
{"actor":{"display_login":"magento-engcom-team"}}