{"action":"created","comment":{"url":"https://api.github.com/repos/flipstone/orville/pulls/comments/237065445","pull_request_review_id":179272606,"id":237065445,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzA2NTQ0NQ==","diff_hunk":"@@ -204,7 +232,7 @@ instance MonadOrvilleControl IO where\n    'liftWithConnection' for 'MonadOrvilleControl' instances when the Monad in\n    question is a wrapper around a type that already implements\n    'MonadOrvilleControl'\n-  |-}\n+  -}","path":"src/Database/Orville/Internal/Monad.hs","position":100,"original_position":100,"commit_id":"14c88698147d026a82c0aefb2971222a249c61f4","original_commit_id":"14c88698147d026a82c0aefb2971222a249c61f4","user":{"login":"qxjit","id":7833,"node_id":"MDQ6VXNlcjc4MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/7833?v=4","gravatar_id":"","url":"https://api.github.com/users/qxjit","html_url":"https://github.com/qxjit","followers_url":"https://api.github.com/users/qxjit/followers","following_url":"https://api.github.com/users/qxjit/following{/other_user}","gists_url":"https://api.github.com/users/qxjit/gists{/gist_id}","starred_url":"https://api.github.com/users/qxjit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qxjit/subscriptions","organizations_url":"https://api.github.com/users/qxjit/orgs","repos_url":"https://api.github.com/users/qxjit/repos","events_url":"https://api.github.com/users/qxjit/events{/privacy}","received_events_url":"https://api.github.com/users/qxjit/received_events","type":"User","site_admin":false},"body":"Yeah. It looks like I got in the habit of using two `|` in these comments at some point, but haddock only cares about the first ones. I'm going to keep cleaning these up as a run across them.","created_at":"2018-11-28T12:36:34Z","updated_at":"2018-11-28T12:36:35Z","html_url":"https://github.com/flipstone/orville/pull/52#discussion_r237065445","pull_request_url":"https://api.github.com/repos/flipstone/orville/pulls/52","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/flipstone/orville/pulls/comments/237065445"},"html":{"href":"https://github.com/flipstone/orville/pull/52#discussion_r237065445"},"pull_request":{"href":"https://api.github.com/repos/flipstone/orville/pulls/52"}},"in_reply_to_id":236931855},"pull_request":{"url":"https://api.github.com/repos/flipstone/orville/pulls/52","id":233932488,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTMyNDg4","html_url":"https://github.com/flipstone/orville/pull/52","diff_url":"https://github.com/flipstone/orville/pull/52.diff","patch_url":"https://github.com/flipstone/orville/pull/52.patch","issue_url":"https://api.github.com/repos/flipstone/orville/issues/52","number":52,"state":"open","locked":false,"title":"Extracts HasOrvilleContext typeclass from MonadOrville.","user":{"login":"qxjit","id":7833,"node_id":"MDQ6VXNlcjc4MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/7833?v=4","gravatar_id":"","url":"https://api.github.com/users/qxjit","html_url":"https://github.com/qxjit","followers_url":"https://api.github.com/users/qxjit/followers","following_url":"https://api.github.com/users/qxjit/following{/other_user}","gists_url":"https://api.github.com/users/qxjit/gists{/gist_id}","starred_url":"https://api.github.com/users/qxjit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qxjit/subscriptions","organizations_url":"https://api.github.com/users/qxjit/orgs","repos_url":"https://api.github.com/users/qxjit/repos","events_url":"https://api.github.com/users/qxjit/events{/privacy}","received_events_url":"https://api.github.com/users/qxjit/received_events","type":"User","site_admin":false},"body":"Originally I was hoping to simply invert the MonadOrvilleControl ->\r\nMonadOrville relationship so that the the functions for managing context were\r\nin the superclass and control functions in the subclass. That failed, however,\r\nbecause then no MonadOrvilleControl instance can exist for IO, because IO lacks\r\nany Orville context to manage.\r\n\r\nInstead, I ended up extracting the context management functions to\r\nHasOrvilleContext and changing MonadOrville to an empty typeclass that has\r\nsuperclass contraints for all the classes that Orville functions need. This\r\nallows the context management functions and the control lifting functions to be\r\nimplemented by different layers of the monad stack, and by different lifting\r\nstrategies. In the end, only the top layer of the monad stack is required to\r\nactually implement *both*, by providing a MonadOrville instance.\r\n\r\nIn practice, this means that there are *three* typeclasses that a user needs to\r\nbe aware of, which is someone annoying. However, `HasOrvilleContext` should\r\nalmost always be derivable and `MonadOrville` instances are trivial, so I think\r\nthis cost is a reasonable tradeoff to provide the flexibility to use either\r\n`MonadUnliftIO` or `MonadBaseControl` (or another solution) as required. For\r\nrelease, we will just need to make sure we have enough documentation and\r\ntutorials in place to satisfy users.","created_at":"2018-11-27T14:32:21Z","updated_at":"2018-11-28T12:36:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f1f40009aec3946499048950b3797f96d54c32a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jbrechtel","id":72143,"node_id":"MDQ6VXNlcjcyMTQz","avatar_url":"https://avatars0.githubusercontent.com/u/72143?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrechtel","html_url":"https://github.com/jbrechtel","followers_url":"https://api.github.com/users/jbrechtel/followers","following_url":"https://api.github.com/users/jbrechtel/following{/other_user}","gists_url":"https://api.github.com/users/jbrechtel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrechtel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrechtel/subscriptions","organizations_url":"https://api.github.com/users/jbrechtel/orgs","repos_url":"https://api.github.com/users/jbrechtel/repos","events_url":"https://api.github.com/users/jbrechtel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrechtel/received_events","type":"User","site_admin":false},{"login":"liminalisht","id":1623516,"node_id":"MDQ6VXNlcjE2MjM1MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1623516?v=4","gravatar_id":"","url":"https://api.github.com/users/liminalisht","html_url":"https://github.com/liminalisht","followers_url":"https://api.github.com/users/liminalisht/followers","following_url":"https://api.github.com/users/liminalisht/following{/other_user}","gists_url":"https://api.github.com/users/liminalisht/gists{/gist_id}","starred_url":"https://api.github.com/users/liminalisht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liminalisht/subscriptions","organizations_url":"https://api.github.com/users/liminalisht/orgs","repos_url":"https://api.github.com/users/liminalisht/repos","events_url":"https://api.github.com/users/liminalisht/events{/privacy}","received_events_url":"https://api.github.com/users/liminalisht/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flipstone/orville/pulls/52/commits","review_comments_url":"https://api.github.com/repos/flipstone/orville/pulls/52/comments","review_comment_url":"https://api.github.com/repos/flipstone/orville/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flipstone/orville/issues/52/comments","statuses_url":"https://api.github.com/repos/flipstone/orville/statuses/14c88698147d026a82c0aefb2971222a249c61f4","head":{"label":"flipstone:qxjit/ch13192/possibly-invert-monadorville-and-monadorvillecontrol","ref":"qxjit/ch13192/possibly-invert-monadorville-and-monadorvillecontrol","sha":"14c88698147d026a82c0aefb2971222a249c61f4","user":{"login":"flipstone","id":210111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDExMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/210111?v=4","gravatar_id":"","url":"https://api.github.com/users/flipstone","html_url":"https://github.com/flipstone","followers_url":"https://api.github.com/users/flipstone/followers","following_url":"https://api.github.com/users/flipstone/following{/other_user}","gists_url":"https://api.github.com/users/flipstone/gists{/gist_id}","starred_url":"https://api.github.com/users/flipstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flipstone/subscriptions","organizations_url":"https://api.github.com/users/flipstone/orgs","repos_url":"https://api.github.com/users/flipstone/repos","events_url":"https://api.github.com/users/flipstone/events{/privacy}","received_events_url":"https://api.github.com/users/flipstone/received_events","type":"Organization","site_admin":false},"repo":{"id":54917584,"node_id":"MDEwOlJlcG9zaXRvcnk1NDkxNzU4NA==","name":"orville","full_name":"flipstone/orville","private":false,"owner":{"login":"flipstone","id":210111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDExMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/210111?v=4","gravatar_id":"","url":"https://api.github.com/users/flipstone","html_url":"https://github.com/flipstone","followers_url":"https://api.github.com/users/flipstone/followers","following_url":"https://api.github.com/users/flipstone/following{/other_user}","gists_url":"https://api.github.com/users/flipstone/gists{/gist_id}","starred_url":"https://api.github.com/users/flipstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flipstone/subscriptions","organizations_url":"https://api.github.com/users/flipstone/orgs","repos_url":"https://api.github.com/users/flipstone/repos","events_url":"https://api.github.com/users/flipstone/events{/privacy}","received_events_url":"https://api.github.com/users/flipstone/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flipstone/orville","description":"Yet another ORM for haskell","fork":false,"url":"https://api.github.com/repos/flipstone/orville","forks_url":"https://api.github.com/repos/flipstone/orville/forks","keys_url":"https://api.github.com/repos/flipstone/orville/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flipstone/orville/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flipstone/orville/teams","hooks_url":"https://api.github.com/repos/flipstone/orville/hooks","issue_events_url":"https://api.github.com/repos/flipstone/orville/issues/events{/number}","events_url":"https://api.github.com/repos/flipstone/orville/events","assignees_url":"https://api.github.com/repos/flipstone/orville/assignees{/user}","branches_url":"https://api.github.com/repos/flipstone/orville/branches{/branch}","tags_url":"https://api.github.com/repos/flipstone/orville/tags","blobs_url":"https://api.github.com/repos/flipstone/orville/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flipstone/orville/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flipstone/orville/git/refs{/sha}","trees_url":"https://api.github.com/repos/flipstone/orville/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flipstone/orville/statuses/{sha}","languages_url":"https://api.github.com/repos/flipstone/orville/languages","stargazers_url":"https://api.github.com/repos/flipstone/orville/stargazers","contributors_url":"https://api.github.com/repos/flipstone/orville/contributors","subscribers_url":"https://api.github.com/repos/flipstone/orville/subscribers","subscription_url":"https://api.github.com/repos/flipstone/orville/subscription","commits_url":"https://api.github.com/repos/flipstone/orville/commits{/sha}","git_commits_url":"https://api.github.com/repos/flipstone/orville/git/commits{/sha}","comments_url":"https://api.github.com/repos/flipstone/orville/comments{/number}","issue_comment_url":"https://api.github.com/repos/flipstone/orville/issues/comments{/number}","contents_url":"https://api.github.com/repos/flipstone/orville/contents/{+path}","compare_url":"https://api.github.com/repos/flipstone/orville/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flipstone/orville/merges","archive_url":"https://api.github.com/repos/flipstone/orville/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flipstone/orville/downloads","issues_url":"https://api.github.com/repos/flipstone/orville/issues{/number}","pulls_url":"https://api.github.com/repos/flipstone/orville/pulls{/number}","milestones_url":"https://api.github.com/repos/flipstone/orville/milestones{/number}","notifications_url":"https://api.github.com/repos/flipstone/orville/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flipstone/orville/labels{/name}","releases_url":"https://api.github.com/repos/flipstone/orville/releases{/id}","deployments_url":"https://api.github.com/repos/flipstone/orville/deployments","created_at":"2016-03-28T19:23:00Z","updated_at":"2018-11-13T13:23:33Z","pushed_at":"2018-11-27T20:49:54Z","git_url":"git://github.com/flipstone/orville.git","ssh_url":"git@github.com:flipstone/orville.git","clone_url":"https://github.com/flipstone/orville.git","svn_url":"https://github.com/flipstone/orville","homepage":null,"size":581,"stargazers_count":5,"watchers_count":5,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"flipstone:0.9_development","ref":"0.9_development","sha":"48341bc42c8aea4360eefade259518541000b9d4","user":{"login":"flipstone","id":210111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDExMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/210111?v=4","gravatar_id":"","url":"https://api.github.com/users/flipstone","html_url":"https://github.com/flipstone","followers_url":"https://api.github.com/users/flipstone/followers","following_url":"https://api.github.com/users/flipstone/following{/other_user}","gists_url":"https://api.github.com/users/flipstone/gists{/gist_id}","starred_url":"https://api.github.com/users/flipstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flipstone/subscriptions","organizations_url":"https://api.github.com/users/flipstone/orgs","repos_url":"https://api.github.com/users/flipstone/repos","events_url":"https://api.github.com/users/flipstone/events{/privacy}","received_events_url":"https://api.github.com/users/flipstone/received_events","type":"Organization","site_admin":false},"repo":{"id":54917584,"node_id":"MDEwOlJlcG9zaXRvcnk1NDkxNzU4NA==","name":"orville","full_name":"flipstone/orville","private":false,"owner":{"login":"flipstone","id":210111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDExMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/210111?v=4","gravatar_id":"","url":"https://api.github.com/users/flipstone","html_url":"https://github.com/flipstone","followers_url":"https://api.github.com/users/flipstone/followers","following_url":"https://api.github.com/users/flipstone/following{/other_user}","gists_url":"https://api.github.com/users/flipstone/gists{/gist_id}","starred_url":"https://api.github.com/users/flipstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flipstone/subscriptions","organizations_url":"https://api.github.com/users/flipstone/orgs","repos_url":"https://api.github.com/users/flipstone/repos","events_url":"https://api.github.com/users/flipstone/events{/privacy}","received_events_url":"https://api.github.com/users/flipstone/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flipstone/orville","description":"Yet another ORM for haskell","fork":false,"url":"https://api.github.com/repos/flipstone/orville","forks_url":"https://api.github.com/repos/flipstone/orville/forks","keys_url":"https://api.github.com/repos/flipstone/orville/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flipstone/orville/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flipstone/orville/teams","hooks_url":"https://api.github.com/repos/flipstone/orville/hooks","issue_events_url":"https://api.github.com/repos/flipstone/orville/issues/events{/number}","events_url":"https://api.github.com/repos/flipstone/orville/events","assignees_url":"https://api.github.com/repos/flipstone/orville/assignees{/user}","branches_url":"https://api.github.com/repos/flipstone/orville/branches{/branch}","tags_url":"https://api.github.com/repos/flipstone/orville/tags","blobs_url":"https://api.github.com/repos/flipstone/orville/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flipstone/orville/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flipstone/orville/git/refs{/sha}","trees_url":"https://api.github.com/repos/flipstone/orville/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flipstone/orville/statuses/{sha}","languages_url":"https://api.github.com/repos/flipstone/orville/languages","stargazers_url":"https://api.github.com/repos/flipstone/orville/stargazers","contributors_url":"https://api.github.com/repos/flipstone/orville/contributors","subscribers_url":"https://api.github.com/repos/flipstone/orville/subscribers","subscription_url":"https://api.github.com/repos/flipstone/orville/subscription","commits_url":"https://api.github.com/repos/flipstone/orville/commits{/sha}","git_commits_url":"https://api.github.com/repos/flipstone/orville/git/commits{/sha}","comments_url":"https://api.github.com/repos/flipstone/orville/comments{/number}","issue_comment_url":"https://api.github.com/repos/flipstone/orville/issues/comments{/number}","contents_url":"https://api.github.com/repos/flipstone/orville/contents/{+path}","compare_url":"https://api.github.com/repos/flipstone/orville/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flipstone/orville/merges","archive_url":"https://api.github.com/repos/flipstone/orville/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flipstone/orville/downloads","issues_url":"https://api.github.com/repos/flipstone/orville/issues{/number}","pulls_url":"https://api.github.com/repos/flipstone/orville/pulls{/number}","milestones_url":"https://api.github.com/repos/flipstone/orville/milestones{/number}","notifications_url":"https://api.github.com/repos/flipstone/orville/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flipstone/orville/labels{/name}","releases_url":"https://api.github.com/repos/flipstone/orville/releases{/id}","deployments_url":"https://api.github.com/repos/flipstone/orville/deployments","created_at":"2016-03-28T19:23:00Z","updated_at":"2018-11-13T13:23:33Z","pushed_at":"2018-11-27T20:49:54Z","git_url":"git://github.com/flipstone/orville.git","ssh_url":"git@github.com:flipstone/orville.git","clone_url":"https://github.com/flipstone/orville.git","svn_url":"https://github.com/flipstone/orville","homepage":null,"size":581,"stargazers_count":5,"watchers_count":5,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flipstone/orville/pulls/52"},"html":{"href":"https://github.com/flipstone/orville/pull/52"},"issue":{"href":"https://api.github.com/repos/flipstone/orville/issues/52"},"comments":{"href":"https://api.github.com/repos/flipstone/orville/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/flipstone/orville/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/flipstone/orville/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flipstone/orville/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/flipstone/orville/statuses/14c88698147d026a82c0aefb2971222a249c61f4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"qxjit"}}