{"action":"created","comment":{"url":"https://api.github.com/repos/freenas/freenas-docs/pulls/comments/245000153","pull_request_review_id":189011362,"id":245000153,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTAwMDE1Mw==","diff_hunk":"@@ -1846,26 +1846,27 @@ for iSNS requests is *5* seconds.\n .. table:: Target Global Configuration Settings\n    :class: longtable\n \n-   +----------------------+-------------+---------------------------------------------------------------------------------------------+\n-   | Setting              | Value       | Description                                                                                 |\n-   |                      |             |                                                                                             |\n-   +======================+=============+=============================================================================================+\n-   | Base Name            | string      | See the \"Constructing iSCSI names using the iqn. format\" section of :rfc:`3721`             |\n-   |                      |             | if unfamiliar with this format.                                                             |\n-   |                      |             |                                                                                             |\n-   +----------------------+-------------+---------------------------------------------------------------------------------------------+\n-   | ISNS Servers         | string      | Enter the hostnames or IP addresses of ISNS servers to be registered iSCSI targets          |\n-   |                      |             | and portals of the system.                                                                  |\n-   |                      |             |                                                                                             |\n-   +----------------------+-------------+---------------------------------------------------------------------------------------------+\n-   | Pool Available       | integer     | Enter the percentage of free space to remain in the pool.                                   |\n-   | Space Threshold      |             | When this percentage is reached, the system issues an alert, but only if zvols are used.    |\n-   |                      |             | See :ref:`VAAI` Threshold Warning for more information.                                     |\n-   +----------------------+-------------+---------------------------------------------------------------------------------------------+\n+   +---------------------------------+------------------------------+-------------------------------------------------------------------------------------------+\n+   | Setting                         | Value                        | Description                                                                               |\n+   |                                 |                              |                                                                                           |\n+   |                                 |                              |                                                                                           |\n+   +=================================+==============================+===========================================================================================+\n+   | Base Name                       | string                       | Lowercase alphanumeric characters plus dot (.), dash (-), and colon (:) are allowed.      |","path":"userguide/sharing.rst","position":25,"original_position":25,"commit_id":"8f981685d7964a82d376bee0cc7f3e6d1aef7333","original_commit_id":"8f981685d7964a82d376bee0cc7f3e6d1aef7333","user":{"login":"Mrt134","id":17933320,"node_id":"MDQ6VXNlcjE3OTMzMzIw","avatar_url":"https://avatars2.githubusercontent.com/u/17933320?v=4","gravatar_id":"","url":"https://api.github.com/users/Mrt134","html_url":"https://github.com/Mrt134","followers_url":"https://api.github.com/users/Mrt134/followers","following_url":"https://api.github.com/users/Mrt134/following{/other_user}","gists_url":"https://api.github.com/users/Mrt134/gists{/gist_id}","starred_url":"https://api.github.com/users/Mrt134/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mrt134/subscriptions","organizations_url":"https://api.github.com/users/Mrt134/orgs","repos_url":"https://api.github.com/users/Mrt134/repos","events_url":"https://api.github.com/users/Mrt134/events{/privacy}","received_events_url":"https://api.github.com/users/Mrt134/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n    | Base Name                       | string                       | Lowercase alphanumeric characters plus dots (.), dashes (-), and colons (:) are allowed.      |\r\n```","created_at":"2019-01-03T13:33:16Z","updated_at":"2019-01-03T13:35:13Z","html_url":"https://github.com/freenas/freenas-docs/pull/537#discussion_r245000153","pull_request_url":"https://api.github.com/repos/freenas/freenas-docs/pulls/537","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/freenas/freenas-docs/pulls/comments/245000153"},"html":{"href":"https://github.com/freenas/freenas-docs/pull/537#discussion_r245000153"},"pull_request":{"href":"https://api.github.com/repos/freenas/freenas-docs/pulls/537"}}},"pull_request":{"url":"https://api.github.com/repos/freenas/freenas-docs/pulls/537","id":241798762,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNzk4NzYy","html_url":"https://github.com/freenas/freenas-docs/pull/537","diff_url":"https://github.com/freenas/freenas-docs/pull/537.diff","patch_url":"https://github.com/freenas/freenas-docs/pull/537.patch","issue_url":"https://api.github.com/repos/freenas/freenas-docs/issues/537","number":537,"state":"open","locked":false,"title":"Add warning about allowed characters in target names (master)","user":{"login":"wblock","id":222640,"node_id":"MDQ6VXNlcjIyMjY0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/222640?v=4","gravatar_id":"","url":"https://api.github.com/users/wblock","html_url":"https://github.com/wblock","followers_url":"https://api.github.com/users/wblock/followers","following_url":"https://api.github.com/users/wblock/following{/other_user}","gists_url":"https://api.github.com/users/wblock/gists{/gist_id}","starred_url":"https://api.github.com/users/wblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wblock/subscriptions","organizations_url":"https://api.github.com/users/wblock/orgs","repos_url":"https://api.github.com/users/wblock/repos","events_url":"https://api.github.com/users/wblock/events{/privacy}","received_events_url":"https://api.github.com/users/wblock/received_events","type":"User","site_admin":false},"body":"Ticket: #66048","created_at":"2019-01-02T17:06:52Z","updated_at":"2019-01-03T13:35:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8ad159a667196fdc80cf6bcd8a623797a49d5f6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"amotin","id":5219480,"node_id":"MDQ6VXNlcjUyMTk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/5219480?v=4","gravatar_id":"","url":"https://api.github.com/users/amotin","html_url":"https://github.com/amotin","followers_url":"https://api.github.com/users/amotin/followers","following_url":"https://api.github.com/users/amotin/following{/other_user}","gists_url":"https://api.github.com/users/amotin/gists{/gist_id}","starred_url":"https://api.github.com/users/amotin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amotin/subscriptions","organizations_url":"https://api.github.com/users/amotin/orgs","repos_url":"https://api.github.com/users/amotin/repos","events_url":"https://api.github.com/users/amotin/events{/privacy}","received_events_url":"https://api.github.com/users/amotin/received_events","type":"User","site_admin":false},{"login":"sambonham","id":18603740,"node_id":"MDQ6VXNlcjE4NjAzNzQw","avatar_url":"https://avatars2.githubusercontent.com/u/18603740?v=4","gravatar_id":"","url":"https://api.github.com/users/sambonham","html_url":"https://github.com/sambonham","followers_url":"https://api.github.com/users/sambonham/followers","following_url":"https://api.github.com/users/sambonham/following{/other_user}","gists_url":"https://api.github.com/users/sambonham/gists{/gist_id}","starred_url":"https://api.github.com/users/sambonham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambonham/subscriptions","organizations_url":"https://api.github.com/users/sambonham/orgs","repos_url":"https://api.github.com/users/sambonham/repos","events_url":"https://api.github.com/users/sambonham/events{/privacy}","received_events_url":"https://api.github.com/users/sambonham/received_events","type":"User","site_admin":false},{"login":"a-stjohn","id":32651598,"node_id":"MDQ6VXNlcjMyNjUxNTk4","avatar_url":"https://avatars1.githubusercontent.com/u/32651598?v=4","gravatar_id":"","url":"https://api.github.com/users/a-stjohn","html_url":"https://github.com/a-stjohn","followers_url":"https://api.github.com/users/a-stjohn/followers","following_url":"https://api.github.com/users/a-stjohn/following{/other_user}","gists_url":"https://api.github.com/users/a-stjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/a-stjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-stjohn/subscriptions","organizations_url":"https://api.github.com/users/a-stjohn/orgs","repos_url":"https://api.github.com/users/a-stjohn/repos","events_url":"https://api.github.com/users/a-stjohn/events{/privacy}","received_events_url":"https://api.github.com/users/a-stjohn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1179128417,"node_id":"MDU6TGFiZWwxMTc5MTI4NDE3","url":"https://api.github.com/repos/freenas/freenas-docs/labels/FN/TN","name":"FN/TN","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/freenas/freenas-docs/pulls/537/commits","review_comments_url":"https://api.github.com/repos/freenas/freenas-docs/pulls/537/comments","review_comment_url":"https://api.github.com/repos/freenas/freenas-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freenas/freenas-docs/issues/537/comments","statuses_url":"https://api.github.com/repos/freenas/freenas-docs/statuses/8f981685d7964a82d376bee0cc7f3e6d1aef7333","head":{"label":"freenas:wb-isci-names-66048-master","ref":"wb-isci-names-66048-master","sha":"8f981685d7964a82d376bee0cc7f3e6d1aef7333","user":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"repo":{"id":63272790,"node_id":"MDEwOlJlcG9zaXRvcnk2MzI3Mjc5MA==","name":"freenas-docs","full_name":"freenas/freenas-docs","private":false,"owner":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freenas/freenas-docs","description":"FreeNAS & TrueNAS Guides","fork":false,"url":"https://api.github.com/repos/freenas/freenas-docs","forks_url":"https://api.github.com/repos/freenas/freenas-docs/forks","keys_url":"https://api.github.com/repos/freenas/freenas-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenas/freenas-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenas/freenas-docs/teams","hooks_url":"https://api.github.com/repos/freenas/freenas-docs/hooks","issue_events_url":"https://api.github.com/repos/freenas/freenas-docs/issues/events{/number}","events_url":"https://api.github.com/repos/freenas/freenas-docs/events","assignees_url":"https://api.github.com/repos/freenas/freenas-docs/assignees{/user}","branches_url":"https://api.github.com/repos/freenas/freenas-docs/branches{/branch}","tags_url":"https://api.github.com/repos/freenas/freenas-docs/tags","blobs_url":"https://api.github.com/repos/freenas/freenas-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenas/freenas-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenas/freenas-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenas/freenas-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenas/freenas-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/freenas/freenas-docs/languages","stargazers_url":"https://api.github.com/repos/freenas/freenas-docs/stargazers","contributors_url":"https://api.github.com/repos/freenas/freenas-docs/contributors","subscribers_url":"https://api.github.com/repos/freenas/freenas-docs/subscribers","subscription_url":"https://api.github.com/repos/freenas/freenas-docs/subscription","commits_url":"https://api.github.com/repos/freenas/freenas-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenas/freenas-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenas/freenas-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenas/freenas-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenas/freenas-docs/contents/{+path}","compare_url":"https://api.github.com/repos/freenas/freenas-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenas/freenas-docs/merges","archive_url":"https://api.github.com/repos/freenas/freenas-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenas/freenas-docs/downloads","issues_url":"https://api.github.com/repos/freenas/freenas-docs/issues{/number}","pulls_url":"https://api.github.com/repos/freenas/freenas-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/freenas/freenas-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/freenas/freenas-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenas/freenas-docs/labels{/name}","releases_url":"https://api.github.com/repos/freenas/freenas-docs/releases{/id}","deployments_url":"https://api.github.com/repos/freenas/freenas-docs/deployments","created_at":"2016-07-13T19:12:31Z","updated_at":"2018-12-31T19:04:10Z","pushed_at":"2019-01-03T13:28:13Z","git_url":"git://github.com/freenas/freenas-docs.git","ssh_url":"git@github.com:freenas/freenas-docs.git","clone_url":"https://github.com/freenas/freenas-docs.git","svn_url":"https://github.com/freenas/freenas-docs","homepage":null,"size":299154,"stargazers_count":11,"watchers_count":11,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":31,"license":null,"forks":18,"open_issues":31,"watchers":11,"default_branch":"master"}},"base":{"label":"freenas:master","ref":"master","sha":"084b4aa29952de67e15c3b2ba6b5fce3c905761e","user":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"repo":{"id":63272790,"node_id":"MDEwOlJlcG9zaXRvcnk2MzI3Mjc5MA==","name":"freenas-docs","full_name":"freenas/freenas-docs","private":false,"owner":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freenas/freenas-docs","description":"FreeNAS & TrueNAS Guides","fork":false,"url":"https://api.github.com/repos/freenas/freenas-docs","forks_url":"https://api.github.com/repos/freenas/freenas-docs/forks","keys_url":"https://api.github.com/repos/freenas/freenas-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenas/freenas-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenas/freenas-docs/teams","hooks_url":"https://api.github.com/repos/freenas/freenas-docs/hooks","issue_events_url":"https://api.github.com/repos/freenas/freenas-docs/issues/events{/number}","events_url":"https://api.github.com/repos/freenas/freenas-docs/events","assignees_url":"https://api.github.com/repos/freenas/freenas-docs/assignees{/user}","branches_url":"https://api.github.com/repos/freenas/freenas-docs/branches{/branch}","tags_url":"https://api.github.com/repos/freenas/freenas-docs/tags","blobs_url":"https://api.github.com/repos/freenas/freenas-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenas/freenas-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenas/freenas-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenas/freenas-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenas/freenas-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/freenas/freenas-docs/languages","stargazers_url":"https://api.github.com/repos/freenas/freenas-docs/stargazers","contributors_url":"https://api.github.com/repos/freenas/freenas-docs/contributors","subscribers_url":"https://api.github.com/repos/freenas/freenas-docs/subscribers","subscription_url":"https://api.github.com/repos/freenas/freenas-docs/subscription","commits_url":"https://api.github.com/repos/freenas/freenas-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenas/freenas-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenas/freenas-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenas/freenas-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenas/freenas-docs/contents/{+path}","compare_url":"https://api.github.com/repos/freenas/freenas-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenas/freenas-docs/merges","archive_url":"https://api.github.com/repos/freenas/freenas-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenas/freenas-docs/downloads","issues_url":"https://api.github.com/repos/freenas/freenas-docs/issues{/number}","pulls_url":"https://api.github.com/repos/freenas/freenas-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/freenas/freenas-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/freenas/freenas-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenas/freenas-docs/labels{/name}","releases_url":"https://api.github.com/repos/freenas/freenas-docs/releases{/id}","deployments_url":"https://api.github.com/repos/freenas/freenas-docs/deployments","created_at":"2016-07-13T19:12:31Z","updated_at":"2018-12-31T19:04:10Z","pushed_at":"2019-01-03T13:28:13Z","git_url":"git://github.com/freenas/freenas-docs.git","ssh_url":"git@github.com:freenas/freenas-docs.git","clone_url":"https://github.com/freenas/freenas-docs.git","svn_url":"https://github.com/freenas/freenas-docs","homepage":null,"size":299154,"stargazers_count":11,"watchers_count":11,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":31,"license":null,"forks":18,"open_issues":31,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freenas/freenas-docs/pulls/537"},"html":{"href":"https://github.com/freenas/freenas-docs/pull/537"},"issue":{"href":"https://api.github.com/repos/freenas/freenas-docs/issues/537"},"comments":{"href":"https://api.github.com/repos/freenas/freenas-docs/issues/537/comments"},"review_comments":{"href":"https://api.github.com/repos/freenas/freenas-docs/pulls/537/comments"},"review_comment":{"href":"https://api.github.com/repos/freenas/freenas-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freenas/freenas-docs/pulls/537/commits"},"statuses":{"href":"https://api.github.com/repos/freenas/freenas-docs/statuses/8f981685d7964a82d376bee0cc7f3e6d1aef7333"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Mrt134"}}