{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/208746949","pull_request_review_id":144622199,"id":208746949,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODc0Njk0OQ==","diff_hunk":"@@ -2131,17 +2223,13 @@ private void mkAssignments(String scratchTopoId) throws Exception {\n             }\n         }\n         // make the new assignments for topologies\n-        Map<String, SchedulerAssignment> newSchedulerAssignments = null;\n         synchronized (schedLock) {\n-            newSchedulerAssignments = computeNewSchedulerAssignments(existingAssignments, topologies, bases, scratchTopoId);\n+            Map<String, SchedulerAssignment> newSchedulerAssignments =\n+                computeNewSchedulerAssignments(existingAssignments, topologies, bases, scratchTopoId);\n \n+            //Should probably change List<Object> to Tuple<String, Long> for better readability","path":"storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java","position":330,"original_position":330,"commit_id":"1b8067d6a0d38167bc5f0d01b3d8ba7f9a7d248c","original_commit_id":"1b8067d6a0d38167bc5f0d01b3d8ba7f9a7d248c","user":{"login":"zd-project","id":11206745,"node_id":"MDQ6VXNlcjExMjA2NzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/11206745?v=4","gravatar_id":"","url":"https://api.github.com/users/zd-project","html_url":"https://github.com/zd-project","followers_url":"https://api.github.com/users/zd-project/followers","following_url":"https://api.github.com/users/zd-project/following{/other_user}","gists_url":"https://api.github.com/users/zd-project/gists{/gist_id}","starred_url":"https://api.github.com/users/zd-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zd-project/subscriptions","organizations_url":"https://api.github.com/users/zd-project/orgs","repos_url":"https://api.github.com/users/zd-project/repos","events_url":"https://api.github.com/users/zd-project/events{/privacy}","received_events_url":"https://api.github.com/users/zd-project/received_events","type":"User","site_admin":false},"body":"Again, probably better with another Jira for general code cleanup","created_at":"2018-08-08T21:47:46Z","updated_at":"2018-08-08T21:47:46Z","html_url":"https://github.com/apache/storm/pull/2764#discussion_r208746949","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/2764","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/208746949"},"html":{"href":"https://github.com/apache/storm/pull/2764#discussion_r208746949"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/2764"}},"in_reply_to_id":208707855},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/2764","id":201384956,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzg0OTU2","html_url":"https://github.com/apache/storm/pull/2764","diff_url":"https://github.com/apache/storm/pull/2764.diff","patch_url":"https://github.com/apache/storm/pull/2764.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/2764","number":2764,"state":"open","locked":false,"title":"STORM-3147: Port ClusterSummary as metrics to StormMetricsRegistry","user":{"login":"zd-project","id":11206745,"node_id":"MDQ6VXNlcjExMjA2NzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/11206745?v=4","gravatar_id":"","url":"https://api.github.com/users/zd-project","html_url":"https://github.com/zd-project","followers_url":"https://api.github.com/users/zd-project/followers","following_url":"https://api.github.com/users/zd-project/following{/other_user}","gists_url":"https://api.github.com/users/zd-project/gists{/gist_id}","starred_url":"https://api.github.com/users/zd-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zd-project/subscriptions","organizations_url":"https://api.github.com/users/zd-project/orgs","repos_url":"https://api.github.com/users/zd-project/repos","events_url":"https://api.github.com/users/zd-project/events{/privacy}","received_events_url":"https://api.github.com/users/zd-project/received_events","type":"User","site_admin":false},"body":"This PR depends on #2771  \r\nThe implementation is kind of ugly right now due to caching and synchronization in metrics update. I hope you can give out some advice in improvement. @revans2 @HeartSaVioR @srdo \r\n\r\n@kishorvpatil I've listed out all metrics I think worth implementing from ClusterSummay in Measured enum. I'm not sure if there's value in SUPERVISOR_TOTAL_RESOURCE, TOPOLOGY_STATUS, and TOPOLOGY_SCHED_STATUS. I'd like to hear what you think.\r\n\r\nI have also discovered a potential bug of scheduler when working on this [STORM-3151](https://issues.apache.org/jira/browse/STORM-3151), can you help confirm it?","created_at":"2018-07-13T19:51:33Z","updated_at":"2018-08-08T21:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"303782103912e78a4b0f14653d9123e8bc39c5bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/2764/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/2764/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/2764/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/1b8067d6a0d38167bc5f0d01b3d8ba7f9a7d248c","head":{"label":"zd-project:STORM-3147","ref":"STORM-3147","sha":"1b8067d6a0d38167bc5f0d01b3d8ba7f9a7d248c","user":{"login":"zd-project","id":11206745,"node_id":"MDQ6VXNlcjExMjA2NzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/11206745?v=4","gravatar_id":"","url":"https://api.github.com/users/zd-project","html_url":"https://github.com/zd-project","followers_url":"https://api.github.com/users/zd-project/followers","following_url":"https://api.github.com/users/zd-project/following{/other_user}","gists_url":"https://api.github.com/users/zd-project/gists{/gist_id}","starred_url":"https://api.github.com/users/zd-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zd-project/subscriptions","organizations_url":"https://api.github.com/users/zd-project/orgs","repos_url":"https://api.github.com/users/zd-project/repos","events_url":"https://api.github.com/users/zd-project/events{/privacy}","received_events_url":"https://api.github.com/users/zd-project/received_events","type":"User","site_admin":false},"repo":{"id":135761957,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3NjE5NTc=","name":"storm","full_name":"zd-project/storm","owner":{"login":"zd-project","id":11206745,"node_id":"MDQ6VXNlcjExMjA2NzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/11206745?v=4","gravatar_id":"","url":"https://api.github.com/users/zd-project","html_url":"https://github.com/zd-project","followers_url":"https://api.github.com/users/zd-project/followers","following_url":"https://api.github.com/users/zd-project/following{/other_user}","gists_url":"https://api.github.com/users/zd-project/gists{/gist_id}","starred_url":"https://api.github.com/users/zd-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zd-project/subscriptions","organizations_url":"https://api.github.com/users/zd-project/orgs","repos_url":"https://api.github.com/users/zd-project/repos","events_url":"https://api.github.com/users/zd-project/events{/privacy}","received_events_url":"https://api.github.com/users/zd-project/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zd-project/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/zd-project/storm","forks_url":"https://api.github.com/repos/zd-project/storm/forks","keys_url":"https://api.github.com/repos/zd-project/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zd-project/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zd-project/storm/teams","hooks_url":"https://api.github.com/repos/zd-project/storm/hooks","issue_events_url":"https://api.github.com/repos/zd-project/storm/issues/events{/number}","events_url":"https://api.github.com/repos/zd-project/storm/events","assignees_url":"https://api.github.com/repos/zd-project/storm/assignees{/user}","branches_url":"https://api.github.com/repos/zd-project/storm/branches{/branch}","tags_url":"https://api.github.com/repos/zd-project/storm/tags","blobs_url":"https://api.github.com/repos/zd-project/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zd-project/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zd-project/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/zd-project/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zd-project/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/zd-project/storm/languages","stargazers_url":"https://api.github.com/repos/zd-project/storm/stargazers","contributors_url":"https://api.github.com/repos/zd-project/storm/contributors","subscribers_url":"https://api.github.com/repos/zd-project/storm/subscribers","subscription_url":"https://api.github.com/repos/zd-project/storm/subscription","commits_url":"https://api.github.com/repos/zd-project/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/zd-project/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/zd-project/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/zd-project/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/zd-project/storm/contents/{+path}","compare_url":"https://api.github.com/repos/zd-project/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zd-project/storm/merges","archive_url":"https://api.github.com/repos/zd-project/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zd-project/storm/downloads","issues_url":"https://api.github.com/repos/zd-project/storm/issues{/number}","pulls_url":"https://api.github.com/repos/zd-project/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/zd-project/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/zd-project/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zd-project/storm/labels{/name}","releases_url":"https://api.github.com/repos/zd-project/storm/releases{/id}","deployments_url":"https://api.github.com/repos/zd-project/storm/deployments","created_at":"2018-06-01T20:47:37Z","updated_at":"2018-08-08T15:15:23Z","pushed_at":"2018-08-08T21:33:38Z","git_url":"git://github.com/zd-project/storm.git","ssh_url":"git@github.com:zd-project/storm.git","clone_url":"https://github.com/zd-project/storm.git","svn_url":"https://github.com/zd-project/storm","homepage":null,"size":175855,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c9efe3be960b3144f0b64954b94f249cfbe50b2a","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzNTQ3MA==","name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","deployments_url":"https://api.github.com/repos/apache/storm/deployments","created_at":"2013-11-05T08:00:14Z","updated_at":"2018-08-08T15:11:48Z","pushed_at":"2018-08-08T18:56:32Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":175842,"stargazers_count":5214,"watchers_count":5214,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3683,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3683,"open_issues":159,"watchers":5214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/2764"},"html":{"href":"https://github.com/apache/storm/pull/2764"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/2764"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/2764/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/2764/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/2764/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/1b8067d6a0d38167bc5f0d01b3d8ba7f9a7d248c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zd-project"}}