{"action":"opened","number":632,"pull_request":{"url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/pulls/632","id":220894614,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODk0NjE0","html_url":"https://github.com/Microsoft/BotBuilder-Samples/pull/632","diff_url":"https://github.com/Microsoft/BotBuilder-Samples/pull/632.diff","patch_url":"https://github.com/Microsoft/BotBuilder-Samples/pull/632.patch","issue_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/issues/632","number":632,"state":"open","locked":false,"title":"fix: fix unreachable code and potential uncaught exception","user":{"login":"jesus-seijas-sp","id":15154218,"node_id":"MDQ6VXNlcjE1MTU0MjE4","avatar_url":"https://avatars3.githubusercontent.com/u/15154218?v=4","gravatar_id":"","url":"https://api.github.com/users/jesus-seijas-sp","html_url":"https://github.com/jesus-seijas-sp","followers_url":"https://api.github.com/users/jesus-seijas-sp/followers","following_url":"https://api.github.com/users/jesus-seijas-sp/following{/other_user}","gists_url":"https://api.github.com/users/jesus-seijas-sp/gists{/gist_id}","starred_url":"https://api.github.com/users/jesus-seijas-sp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesus-seijas-sp/subscriptions","organizations_url":"https://api.github.com/users/jesus-seijas-sp/orgs","repos_url":"https://api.github.com/users/jesus-seijas-sp/repos","events_url":"https://api.github.com/users/jesus-seijas-sp/events{/privacy}","received_events_url":"https://api.github.com/users/jesus-seijas-sp/received_events","type":"User","site_admin":false},"body":"## Proposed Changes\r\nIn the code there is an if structure like \r\n`if (context.activity.text.toLowerCase() === 'quit') { } else if (context.activity.text) {`\r\nThe problem is that if context.activity.text is not defined, then an exception is thrown and the else if checking it is not reachable. \r\nThis PR solves this potential situation.\r\n\r\n","created_at":"2018-10-06T15:55:31Z","updated_at":"2018-10-06T15:55:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/pulls/632/commits","review_comments_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/pulls/632/comments","review_comment_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/issues/632/comments","statuses_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/statuses/394017b3a98183fdb90956f1a1f7f47aa43e58b0","head":{"label":"jesus-seijas-sp:feature/fix-node-console-echo","ref":"feature/fix-node-console-echo","sha":"394017b3a98183fdb90956f1a1f7f47aa43e58b0","user":{"login":"jesus-seijas-sp","id":15154218,"node_id":"MDQ6VXNlcjE1MTU0MjE4","avatar_url":"https://avatars3.githubusercontent.com/u/15154218?v=4","gravatar_id":"","url":"https://api.github.com/users/jesus-seijas-sp","html_url":"https://github.com/jesus-seijas-sp","followers_url":"https://api.github.com/users/jesus-seijas-sp/followers","following_url":"https://api.github.com/users/jesus-seijas-sp/following{/other_user}","gists_url":"https://api.github.com/users/jesus-seijas-sp/gists{/gist_id}","starred_url":"https://api.github.com/users/jesus-seijas-sp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesus-seijas-sp/subscriptions","organizations_url":"https://api.github.com/users/jesus-seijas-sp/orgs","repos_url":"https://api.github.com/users/jesus-seijas-sp/repos","events_url":"https://api.github.com/users/jesus-seijas-sp/events{/privacy}","received_events_url":"https://api.github.com/users/jesus-seijas-sp/received_events","type":"User","site_admin":false},"repo":{"id":151833115,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE4MzMxMTU=","name":"BotBuilder-Samples","full_name":"jesus-seijas-sp/BotBuilder-Samples","private":false,"owner":{"login":"jesus-seijas-sp","id":15154218,"node_id":"MDQ6VXNlcjE1MTU0MjE4","avatar_url":"https://avatars3.githubusercontent.com/u/15154218?v=4","gravatar_id":"","url":"https://api.github.com/users/jesus-seijas-sp","html_url":"https://github.com/jesus-seijas-sp","followers_url":"https://api.github.com/users/jesus-seijas-sp/followers","following_url":"https://api.github.com/users/jesus-seijas-sp/following{/other_user}","gists_url":"https://api.github.com/users/jesus-seijas-sp/gists{/gist_id}","starred_url":"https://api.github.com/users/jesus-seijas-sp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesus-seijas-sp/subscriptions","organizations_url":"https://api.github.com/users/jesus-seijas-sp/orgs","repos_url":"https://api.github.com/users/jesus-seijas-sp/repos","events_url":"https://api.github.com/users/jesus-seijas-sp/events{/privacy}","received_events_url":"https://api.github.com/users/jesus-seijas-sp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jesus-seijas-sp/BotBuilder-Samples","description":"Welcome to the BotBuilder samples repository. Here you will find task-focused samples in C# and Node.js to help you get started with the Bot Builder SDK!","fork":true,"url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples","forks_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/forks","keys_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/teams","hooks_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/hooks","issue_events_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/issues/events{/number}","events_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/events","assignees_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/assignees{/user}","branches_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/branches{/branch}","tags_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/tags","blobs_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/statuses/{sha}","languages_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/languages","stargazers_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/stargazers","contributors_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/contributors","subscribers_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/subscribers","subscription_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/subscription","commits_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/contents/{+path}","compare_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/merges","archive_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/downloads","issues_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/issues{/number}","pulls_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/pulls{/number}","milestones_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/milestones{/number}","notifications_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/labels{/name}","releases_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/releases{/id}","deployments_url":"https://api.github.com/repos/jesus-seijas-sp/BotBuilder-Samples/deployments","created_at":"2018-10-06T11:25:46Z","updated_at":"2018-10-06T11:25:49Z","pushed_at":"2018-10-06T15:50:32Z","git_url":"git://github.com/jesus-seijas-sp/BotBuilder-Samples.git","ssh_url":"git@github.com:jesus-seijas-sp/BotBuilder-Samples.git","clone_url":"https://github.com/jesus-seijas-sp/BotBuilder-Samples.git","svn_url":"https://github.com/jesus-seijas-sp/BotBuilder-Samples","homepage":"https://github.com/Microsoft/BotBuilder","size":43952,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"db817c5bb0ed0d2cb15f17ae65ca54a67d580c75","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":68730444,"node_id":"MDEwOlJlcG9zaXRvcnk2ODczMDQ0NA==","name":"BotBuilder-Samples","full_name":"Microsoft/BotBuilder-Samples","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/BotBuilder-Samples","description":"Welcome to the BotBuilder samples repository. Here you will find task-focused samples in C# and Node.js to help you get started with the Bot Builder SDK!","fork":false,"url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples","forks_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/forks","keys_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/teams","hooks_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/events","assignees_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/tags","blobs_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/languages","stargazers_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/subscription","commits_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/merges","archive_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/downloads","issues_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/deployments","created_at":"2016-09-20T16:17:28Z","updated_at":"2018-10-06T10:23:12Z","pushed_at":"2018-10-05T16:53:57Z","git_url":"git://github.com/Microsoft/BotBuilder-Samples.git","ssh_url":"git@github.com:Microsoft/BotBuilder-Samples.git","clone_url":"https://github.com/Microsoft/BotBuilder-Samples.git","svn_url":"https://github.com/Microsoft/BotBuilder-Samples","homepage":"https://github.com/Microsoft/BotBuilder","size":43952,"stargazers_count":1477,"watchers_count":1477,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2195,"mirror_url":null,"archived":false,"open_issues_count":122,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2195,"open_issues":122,"watchers":1477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/pulls/632"},"html":{"href":"https://github.com/Microsoft/BotBuilder-Samples/pull/632"},"issue":{"href":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/issues/632"},"comments":{"href":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/issues/632/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/pulls/632/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/pulls/632/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/BotBuilder-Samples/statuses/394017b3a98183fdb90956f1a1f7f47aa43e58b0"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"jesus-seijas-sp"}}