{"action":"created","comment":{"url":"https://api.github.com/repos/colehart/BYOBackend/pulls/comments/241172959","pull_request_review_id":184379464,"id":241172959,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTE3Mjk1OQ==","diff_hunk":"@@ -120,24 +120,25 @@ describe('Server file', () => {\n         .then(() => done())\n     })\n \n-    it.skip('GET sends back a 200 status code and correct response object', done => {\n+    it('GET sends back a 200 status code and correct response object', done => {\n \n       chai.request(app)\n         .get('/api/v1/stations/1')\n         .end((error, response) => {\n-          const resultEntry = response.body[0]\n-          const expected = testStations[1]\n+\n+          const stationIDs = response.body.map(station => station.id);","path":"test/server.test.js","position":43,"original_position":13,"commit_id":"f23cd9fe6bc26d19973e70b78f44d0a644aea1e5","original_commit_id":"f23cd9fe6bc26d19973e70b78f44d0a644aea1e5","user":{"login":"colehart","id":36777482,"node_id":"MDQ6VXNlcjM2Nzc3NDgy","avatar_url":"https://avatars0.githubusercontent.com/u/36777482?v=4","gravatar_id":"","url":"https://api.github.com/users/colehart","html_url":"https://github.com/colehart","followers_url":"https://api.github.com/users/colehart/followers","following_url":"https://api.github.com/users/colehart/following{/other_user}","gists_url":"https://api.github.com/users/colehart/gists{/gist_id}","starred_url":"https://api.github.com/users/colehart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colehart/subscriptions","organizations_url":"https://api.github.com/users/colehart/orgs","repos_url":"https://api.github.com/users/colehart/repos","events_url":"https://api.github.com/users/colehart/events{/privacy}","received_events_url":"https://api.github.com/users/colehart/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n          const stationIds = response.body.map(station => station.id);\r\n```","created_at":"2018-12-12T20:26:15Z","updated_at":"2018-12-12T20:30:50Z","html_url":"https://github.com/colehart/BYOBackend/pull/53#discussion_r241172959","pull_request_url":"https://api.github.com/repos/colehart/BYOBackend/pulls/53","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/colehart/BYOBackend/pulls/comments/241172959"},"html":{"href":"https://github.com/colehart/BYOBackend/pull/53#discussion_r241172959"},"pull_request":{"href":"https://api.github.com/repos/colehart/BYOBackend/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/colehart/BYOBackend/pulls/53","id":238164988,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTY0OTg4","html_url":"https://github.com/colehart/BYOBackend/pull/53","diff_url":"https://github.com/colehart/BYOBackend/pull/53.diff","patch_url":"https://github.com/colehart/BYOBackend/pull/53.patch","issue_url":"https://api.github.com/repos/colehart/BYOBackend/issues/53","number":53,"state":"open","locked":false,"title":"47 refactor skipped tests chris freddie","user":{"login":"flevenson","id":37809511,"node_id":"MDQ6VXNlcjM3ODA5NTEx","avatar_url":"https://avatars2.githubusercontent.com/u/37809511?v=4","gravatar_id":"","url":"https://api.github.com/users/flevenson","html_url":"https://github.com/flevenson","followers_url":"https://api.github.com/users/flevenson/followers","following_url":"https://api.github.com/users/flevenson/following{/other_user}","gists_url":"https://api.github.com/users/flevenson/gists{/gist_id}","starred_url":"https://api.github.com/users/flevenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flevenson/subscriptions","organizations_url":"https://api.github.com/users/flevenson/orgs","repos_url":"https://api.github.com/users/flevenson/repos","events_url":"https://api.github.com/users/flevenson/events{/privacy}","received_events_url":"https://api.github.com/users/flevenson/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nThis PR addresses issue #`47`.\r\n\r\nThe changes made to the codebase in this PR:\r\n\r\nThere were multiple tests in the testing suite that were not passing due to travis CI shuffling the database each time. I refactored as many tests as I could (5) to make the testing suite a little more robust.\r\n\r\n## Requests for review\r\n\r\nAreas of concern:\r\n\r\nThis issue is not fully resolved because there were some tests which I found to be impossible to test. Due to the random shuffling of indices i would not recommend having a get request that relies on indexes in two different tables. There is no way to guarantee that X station's id will be X, nor is there a guarantee that Y cafe's ID will be Y, and therefore X station will not necessarily have a corresponding cafe of Y. Thus those get requests will not be guaranteed not to error out.\r\n","created_at":"2018-12-12T20:02:52Z","updated_at":"2018-12-12T20:30:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a63c2c6045d8ca088f7beef528cbc40ff16b2612","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/colehart/BYOBackend/pulls/53/commits","review_comments_url":"https://api.github.com/repos/colehart/BYOBackend/pulls/53/comments","review_comment_url":"https://api.github.com/repos/colehart/BYOBackend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/colehart/BYOBackend/issues/53/comments","statuses_url":"https://api.github.com/repos/colehart/BYOBackend/statuses/f23cd9fe6bc26d19973e70b78f44d0a644aea1e5","head":{"label":"christopherchateau:47-refactor-skipped-tests-chris-freddie","ref":"47-refactor-skipped-tests-chris-freddie","sha":"f23cd9fe6bc26d19973e70b78f44d0a644aea1e5","user":{"login":"christopherchateau","id":26070102,"node_id":"MDQ6VXNlcjI2MDcwMTAy","avatar_url":"https://avatars1.githubusercontent.com/u/26070102?v=4","gravatar_id":"","url":"https://api.github.com/users/christopherchateau","html_url":"https://github.com/christopherchateau","followers_url":"https://api.github.com/users/christopherchateau/followers","following_url":"https://api.github.com/users/christopherchateau/following{/other_user}","gists_url":"https://api.github.com/users/christopherchateau/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherchateau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherchateau/subscriptions","organizations_url":"https://api.github.com/users/christopherchateau/orgs","repos_url":"https://api.github.com/users/christopherchateau/repos","events_url":"https://api.github.com/users/christopherchateau/events{/privacy}","received_events_url":"https://api.github.com/users/christopherchateau/received_events","type":"User","site_admin":false},"repo":{"id":161257382,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEyNTczODI=","name":"BYOBackend","full_name":"christopherchateau/BYOBackend","private":false,"owner":{"login":"christopherchateau","id":26070102,"node_id":"MDQ6VXNlcjI2MDcwMTAy","avatar_url":"https://avatars1.githubusercontent.com/u/26070102?v=4","gravatar_id":"","url":"https://api.github.com/users/christopherchateau","html_url":"https://github.com/christopherchateau","followers_url":"https://api.github.com/users/christopherchateau/followers","following_url":"https://api.github.com/users/christopherchateau/following{/other_user}","gists_url":"https://api.github.com/users/christopherchateau/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherchateau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherchateau/subscriptions","organizations_url":"https://api.github.com/users/christopherchateau/orgs","repos_url":"https://api.github.com/users/christopherchateau/repos","events_url":"https://api.github.com/users/christopherchateau/events{/privacy}","received_events_url":"https://api.github.com/users/christopherchateau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/christopherchateau/BYOBackend","description":null,"fork":true,"url":"https://api.github.com/repos/christopherchateau/BYOBackend","forks_url":"https://api.github.com/repos/christopherchateau/BYOBackend/forks","keys_url":"https://api.github.com/repos/christopherchateau/BYOBackend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christopherchateau/BYOBackend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christopherchateau/BYOBackend/teams","hooks_url":"https://api.github.com/repos/christopherchateau/BYOBackend/hooks","issue_events_url":"https://api.github.com/repos/christopherchateau/BYOBackend/issues/events{/number}","events_url":"https://api.github.com/repos/christopherchateau/BYOBackend/events","assignees_url":"https://api.github.com/repos/christopherchateau/BYOBackend/assignees{/user}","branches_url":"https://api.github.com/repos/christopherchateau/BYOBackend/branches{/branch}","tags_url":"https://api.github.com/repos/christopherchateau/BYOBackend/tags","blobs_url":"https://api.github.com/repos/christopherchateau/BYOBackend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christopherchateau/BYOBackend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christopherchateau/BYOBackend/git/refs{/sha}","trees_url":"https://api.github.com/repos/christopherchateau/BYOBackend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christopherchateau/BYOBackend/statuses/{sha}","languages_url":"https://api.github.com/repos/christopherchateau/BYOBackend/languages","stargazers_url":"https://api.github.com/repos/christopherchateau/BYOBackend/stargazers","contributors_url":"https://api.github.com/repos/christopherchateau/BYOBackend/contributors","subscribers_url":"https://api.github.com/repos/christopherchateau/BYOBackend/subscribers","subscription_url":"https://api.github.com/repos/christopherchateau/BYOBackend/subscription","commits_url":"https://api.github.com/repos/christopherchateau/BYOBackend/commits{/sha}","git_commits_url":"https://api.github.com/repos/christopherchateau/BYOBackend/git/commits{/sha}","comments_url":"https://api.github.com/repos/christopherchateau/BYOBackend/comments{/number}","issue_comment_url":"https://api.github.com/repos/christopherchateau/BYOBackend/issues/comments{/number}","contents_url":"https://api.github.com/repos/christopherchateau/BYOBackend/contents/{+path}","compare_url":"https://api.github.com/repos/christopherchateau/BYOBackend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christopherchateau/BYOBackend/merges","archive_url":"https://api.github.com/repos/christopherchateau/BYOBackend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christopherchateau/BYOBackend/downloads","issues_url":"https://api.github.com/repos/christopherchateau/BYOBackend/issues{/number}","pulls_url":"https://api.github.com/repos/christopherchateau/BYOBackend/pulls{/number}","milestones_url":"https://api.github.com/repos/christopherchateau/BYOBackend/milestones{/number}","notifications_url":"https://api.github.com/repos/christopherchateau/BYOBackend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christopherchateau/BYOBackend/labels{/name}","releases_url":"https://api.github.com/repos/christopherchateau/BYOBackend/releases{/id}","deployments_url":"https://api.github.com/repos/christopherchateau/BYOBackend/deployments","created_at":"2018-12-11T01:06:17Z","updated_at":"2018-12-11T01:06:19Z","pushed_at":"2018-12-12T20:01:31Z","git_url":"git://github.com/christopherchateau/BYOBackend.git","ssh_url":"git@github.com:christopherchateau/BYOBackend.git","clone_url":"https://github.com/christopherchateau/BYOBackend.git","svn_url":"https://github.com/christopherchateau/BYOBackend","homepage":null,"size":256,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"colehart:master","ref":"master","sha":"49cc40bdde2ebc14ebead503377fbdef4e827bf6","user":{"login":"colehart","id":36777482,"node_id":"MDQ6VXNlcjM2Nzc3NDgy","avatar_url":"https://avatars0.githubusercontent.com/u/36777482?v=4","gravatar_id":"","url":"https://api.github.com/users/colehart","html_url":"https://github.com/colehart","followers_url":"https://api.github.com/users/colehart/followers","following_url":"https://api.github.com/users/colehart/following{/other_user}","gists_url":"https://api.github.com/users/colehart/gists{/gist_id}","starred_url":"https://api.github.com/users/colehart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colehart/subscriptions","organizations_url":"https://api.github.com/users/colehart/orgs","repos_url":"https://api.github.com/users/colehart/repos","events_url":"https://api.github.com/users/colehart/events{/privacy}","received_events_url":"https://api.github.com/users/colehart/received_events","type":"User","site_admin":false},"repo":{"id":160251712,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAyNTE3MTI=","name":"BYOBackend","full_name":"colehart/BYOBackend","private":false,"owner":{"login":"colehart","id":36777482,"node_id":"MDQ6VXNlcjM2Nzc3NDgy","avatar_url":"https://avatars0.githubusercontent.com/u/36777482?v=4","gravatar_id":"","url":"https://api.github.com/users/colehart","html_url":"https://github.com/colehart","followers_url":"https://api.github.com/users/colehart/followers","following_url":"https://api.github.com/users/colehart/following{/other_user}","gists_url":"https://api.github.com/users/colehart/gists{/gist_id}","starred_url":"https://api.github.com/users/colehart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colehart/subscriptions","organizations_url":"https://api.github.com/users/colehart/orgs","repos_url":"https://api.github.com/users/colehart/repos","events_url":"https://api.github.com/users/colehart/events{/privacy}","received_events_url":"https://api.github.com/users/colehart/received_events","type":"User","site_admin":false},"html_url":"https://github.com/colehart/BYOBackend","description":null,"fork":false,"url":"https://api.github.com/repos/colehart/BYOBackend","forks_url":"https://api.github.com/repos/colehart/BYOBackend/forks","keys_url":"https://api.github.com/repos/colehart/BYOBackend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colehart/BYOBackend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colehart/BYOBackend/teams","hooks_url":"https://api.github.com/repos/colehart/BYOBackend/hooks","issue_events_url":"https://api.github.com/repos/colehart/BYOBackend/issues/events{/number}","events_url":"https://api.github.com/repos/colehart/BYOBackend/events","assignees_url":"https://api.github.com/repos/colehart/BYOBackend/assignees{/user}","branches_url":"https://api.github.com/repos/colehart/BYOBackend/branches{/branch}","tags_url":"https://api.github.com/repos/colehart/BYOBackend/tags","blobs_url":"https://api.github.com/repos/colehart/BYOBackend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colehart/BYOBackend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colehart/BYOBackend/git/refs{/sha}","trees_url":"https://api.github.com/repos/colehart/BYOBackend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colehart/BYOBackend/statuses/{sha}","languages_url":"https://api.github.com/repos/colehart/BYOBackend/languages","stargazers_url":"https://api.github.com/repos/colehart/BYOBackend/stargazers","contributors_url":"https://api.github.com/repos/colehart/BYOBackend/contributors","subscribers_url":"https://api.github.com/repos/colehart/BYOBackend/subscribers","subscription_url":"https://api.github.com/repos/colehart/BYOBackend/subscription","commits_url":"https://api.github.com/repos/colehart/BYOBackend/commits{/sha}","git_commits_url":"https://api.github.com/repos/colehart/BYOBackend/git/commits{/sha}","comments_url":"https://api.github.com/repos/colehart/BYOBackend/comments{/number}","issue_comment_url":"https://api.github.com/repos/colehart/BYOBackend/issues/comments{/number}","contents_url":"https://api.github.com/repos/colehart/BYOBackend/contents/{+path}","compare_url":"https://api.github.com/repos/colehart/BYOBackend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colehart/BYOBackend/merges","archive_url":"https://api.github.com/repos/colehart/BYOBackend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colehart/BYOBackend/downloads","issues_url":"https://api.github.com/repos/colehart/BYOBackend/issues{/number}","pulls_url":"https://api.github.com/repos/colehart/BYOBackend/pulls{/number}","milestones_url":"https://api.github.com/repos/colehart/BYOBackend/milestones{/number}","notifications_url":"https://api.github.com/repos/colehart/BYOBackend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colehart/BYOBackend/labels{/name}","releases_url":"https://api.github.com/repos/colehart/BYOBackend/releases{/id}","deployments_url":"https://api.github.com/repos/colehart/BYOBackend/deployments","created_at":"2018-12-03T20:47:02Z","updated_at":"2018-12-12T00:12:26Z","pushed_at":"2018-12-12T20:02:52Z","git_url":"git://github.com/colehart/BYOBackend.git","ssh_url":"git@github.com:colehart/BYOBackend.git","clone_url":"https://github.com/colehart/BYOBackend.git","svn_url":"https://github.com/colehart/BYOBackend","homepage":null,"size":236,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":2,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/colehart/BYOBackend/pulls/53"},"html":{"href":"https://github.com/colehart/BYOBackend/pull/53"},"issue":{"href":"https://api.github.com/repos/colehart/BYOBackend/issues/53"},"comments":{"href":"https://api.github.com/repos/colehart/BYOBackend/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/colehart/BYOBackend/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/colehart/BYOBackend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/colehart/BYOBackend/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/colehart/BYOBackend/statuses/f23cd9fe6bc26d19973e70b78f44d0a644aea1e5"}},"author_association":"NONE"}}
{"actor":{"display_login":"colehart"}}