{"action":"created","issue":{"url":"https://api.github.com/repos/flow-typed/flow-typed/issues/2530","repository_url":"https://api.github.com/repos/flow-typed/flow-typed","labels_url":"https://api.github.com/repos/flow-typed/flow-typed/issues/2530/labels{/name}","comments_url":"https://api.github.com/repos/flow-typed/flow-typed/issues/2530/comments","events_url":"https://api.github.com/repos/flow-typed/flow-typed/issues/2530/events","html_url":"https://github.com/flow-typed/flow-typed/pull/2530","id":344094264,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTcxMDgz","number":2530,"title":"fix type coverage on react-redux's connect","user":{"login":"LoganBarnett","id":27005,"node_id":"MDQ6VXNlcjI3MDA1","avatar_url":"https://avatars1.githubusercontent.com/u/27005?v=4","gravatar_id":"","url":"https://api.github.com/users/LoganBarnett","html_url":"https://github.com/LoganBarnett","followers_url":"https://api.github.com/users/LoganBarnett/followers","following_url":"https://api.github.com/users/LoganBarnett/following{/other_user}","gists_url":"https://api.github.com/users/LoganBarnett/gists{/gist_id}","starred_url":"https://api.github.com/users/LoganBarnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoganBarnett/subscriptions","organizations_url":"https://api.github.com/users/LoganBarnett/orgs","repos_url":"https://api.github.com/users/LoganBarnett/repos","events_url":"https://api.github.com/users/LoganBarnett/events{/privacy}","received_events_url":"https://api.github.com/users/LoganBarnett/received_events","type":"User","site_admin":false},"labels":[{"id":261936120,"node_id":"MDU6TGFiZWwyNjE5MzYxMjA=","url":"https://api.github.com/repos/flow-typed/flow-typed/labels/bug","name":"bug","color":"d93f0b","default":true},{"id":874822104,"node_id":"MDU6TGFiZWw4NzQ4MjIxMDQ=","url":"https://api.github.com/repos/flow-typed/flow-typed/labels/libdef","name":"libdef","color":"0052cc","default":false}],"state":"closed","locked":false,"assignee":{"login":"villesau","id":2647016,"node_id":"MDQ6VXNlcjI2NDcwMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2647016?v=4","gravatar_id":"","url":"https://api.github.com/users/villesau","html_url":"https://github.com/villesau","followers_url":"https://api.github.com/users/villesau/followers","following_url":"https://api.github.com/users/villesau/following{/other_user}","gists_url":"https://api.github.com/users/villesau/gists{/gist_id}","starred_url":"https://api.github.com/users/villesau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/villesau/subscriptions","organizations_url":"https://api.github.com/users/villesau/orgs","repos_url":"https://api.github.com/users/villesau/repos","events_url":"https://api.github.com/users/villesau/events{/privacy}","received_events_url":"https://api.github.com/users/villesau/received_events","type":"User","site_admin":false},"assignees":[{"login":"villesau","id":2647016,"node_id":"MDQ6VXNlcjI2NDcwMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2647016?v=4","gravatar_id":"","url":"https://api.github.com/users/villesau","html_url":"https://github.com/villesau","followers_url":"https://api.github.com/users/villesau/followers","following_url":"https://api.github.com/users/villesau/following{/other_user}","gists_url":"https://api.github.com/users/villesau/gists{/gist_id}","starred_url":"https://api.github.com/users/villesau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/villesau/subscriptions","organizations_url":"https://api.github.com/users/villesau/orgs","repos_url":"https://api.github.com/users/villesau/repos","events_url":"https://api.github.com/users/villesau/events{/privacy}","received_events_url":"https://api.github.com/users/villesau/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-07-24T15:40:39Z","updated_at":"2018-08-15T16:57:49Z","closed_at":"2018-08-14T20:06:50Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/flow-typed/flow-typed/pulls/2530","html_url":"https://github.com/flow-typed/flow-typed/pull/2530","diff_url":"https://github.com/flow-typed/flow-typed/pull/2530.diff","patch_url":"https://github.com/flow-typed/flow-typed/pull/2530.patch"},"body":"When I upgraded to `react-redux` to 5, we had a drop in type coverage on `connect`. From some experimentation I found that it's resulting from the type import within the libdef. The types imported from redux aren't overly complex and I understand them to be relatively stable, so I've copied them in directly.\r\n\r\nI've tested this on my internal repo and found the coverage is applied again. I don't know how to express that as a test in the `flow-typed` suite, however. I tried adding `flow-strict` to the test files as well as `[strict]` settings to `cli/.flow-config`, but still no joy. I'd love any other suggestions anyone can think of."},"comment":{"url":"https://api.github.com/repos/flow-typed/flow-typed/issues/comments/413262859","html_url":"https://github.com/flow-typed/flow-typed/pull/2530#issuecomment-413262859","issue_url":"https://api.github.com/repos/flow-typed/flow-typed/issues/2530","id":413262859,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzI2Mjg1OQ==","user":{"login":"pronebird","id":704044,"node_id":"MDQ6VXNlcjcwNDA0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/704044?v=4","gravatar_id":"","url":"https://api.github.com/users/pronebird","html_url":"https://github.com/pronebird","followers_url":"https://api.github.com/users/pronebird/followers","following_url":"https://api.github.com/users/pronebird/following{/other_user}","gists_url":"https://api.github.com/users/pronebird/gists{/gist_id}","starred_url":"https://api.github.com/users/pronebird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pronebird/subscriptions","organizations_url":"https://api.github.com/users/pronebird/orgs","repos_url":"https://api.github.com/users/pronebird/repos","events_url":"https://api.github.com/users/pronebird/events{/privacy}","received_events_url":"https://api.github.com/users/pronebird/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T16:57:49Z","updated_at":"2018-08-15T16:57:49Z","author_association":"CONTRIBUTOR","body":"This PR breaks redux-thunk actions for us.  \r\n\r\nWe used to type `Action` as either being `{ type: ACTION_NAME }` or a `Function`. It's not possible anymore since action is now forced to be `{ type: $Subtype<string> }`."}}
{"actor":{"display_login":"pronebird"}}