{"action":"closed","issue":{"url":"https://api.github.com/repos/prebid/prebid-server/issues/324","repository_url":"https://api.github.com/repos/prebid/prebid-server","labels_url":"https://api.github.com/repos/prebid/prebid-server/issues/324/labels{/name}","comments_url":"https://api.github.com/repos/prebid/prebid-server/issues/324/comments","events_url":"https://api.github.com/repos/prebid/prebid-server/issues/324/events","html_url":"https://github.com/prebid/prebid-server/issues/324","id":294622899,"node_id":"MDU6SXNzdWUyOTQ2MjI4OTk=","number":324,"title":"Support video cache","user":{"login":"bretg","id":4412838,"node_id":"MDQ6VXNlcjQ0MTI4Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/4412838?v=4","gravatar_id":"","url":"https://api.github.com/users/bretg","html_url":"https://github.com/bretg","followers_url":"https://api.github.com/users/bretg/followers","following_url":"https://api.github.com/users/bretg/following{/other_user}","gists_url":"https://api.github.com/users/bretg/gists{/gist_id}","starred_url":"https://api.github.com/users/bretg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bretg/subscriptions","organizations_url":"https://api.github.com/users/bretg/orgs","repos_url":"https://api.github.com/users/bretg/repos","events_url":"https://api.github.com/users/bretg/events{/privacy}","received_events_url":"https://api.github.com/users/bretg/received_events","type":"User","site_admin":false},"labels":[{"id":779065248,"node_id":"MDU6TGFiZWw3NzkwNjUyNDg=","url":"https://api.github.com/repos/prebid/prebid-server/labels/needs%20review","name":"needs review","color":"ffc9d5","default":false}],"state":"closed","locked":false,"assignee":{"login":"mkendall07","id":1870166,"node_id":"MDQ6VXNlcjE4NzAxNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1870166?v=4","gravatar_id":"","url":"https://api.github.com/users/mkendall07","html_url":"https://github.com/mkendall07","followers_url":"https://api.github.com/users/mkendall07/followers","following_url":"https://api.github.com/users/mkendall07/following{/other_user}","gists_url":"https://api.github.com/users/mkendall07/gists{/gist_id}","starred_url":"https://api.github.com/users/mkendall07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkendall07/subscriptions","organizations_url":"https://api.github.com/users/mkendall07/orgs","repos_url":"https://api.github.com/users/mkendall07/repos","events_url":"https://api.github.com/users/mkendall07/events{/privacy}","received_events_url":"https://api.github.com/users/mkendall07/received_events","type":"User","site_admin":false},"assignees":[{"login":"mkendall07","id":1870166,"node_id":"MDQ6VXNlcjE4NzAxNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1870166?v=4","gravatar_id":"","url":"https://api.github.com/users/mkendall07","html_url":"https://github.com/mkendall07","followers_url":"https://api.github.com/users/mkendall07/followers","following_url":"https://api.github.com/users/mkendall07/following{/other_user}","gists_url":"https://api.github.com/users/mkendall07/gists{/gist_id}","starred_url":"https://api.github.com/users/mkendall07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkendall07/subscriptions","organizations_url":"https://api.github.com/users/mkendall07/orgs","repos_url":"https://api.github.com/users/mkendall07/repos","events_url":"https://api.github.com/users/mkendall07/events{/privacy}","received_events_url":"https://api.github.com/users/mkendall07/received_events","type":"User","site_admin":false},{"login":"moonshells","id":33766472,"node_id":"MDQ6VXNlcjMzNzY2NDcy","avatar_url":"https://avatars2.githubusercontent.com/u/33766472?v=4","gravatar_id":"","url":"https://api.github.com/users/moonshells","html_url":"https://github.com/moonshells","followers_url":"https://api.github.com/users/moonshells/followers","following_url":"https://api.github.com/users/moonshells/following{/other_user}","gists_url":"https://api.github.com/users/moonshells/gists{/gist_id}","starred_url":"https://api.github.com/users/moonshells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moonshells/subscriptions","organizations_url":"https://api.github.com/users/moonshells/orgs","repos_url":"https://api.github.com/users/moonshells/repos","events_url":"https://api.github.com/users/moonshells/events{/privacy}","received_events_url":"https://api.github.com/users/moonshells/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2018-02-06T03:45:39Z","updated_at":"2018-08-06T12:29:17Z","closed_at":"2018-08-06T12:29:17Z","author_association":"CONTRIBUTOR","body":"**Behavior:**\r\n\r\nThe `cacheMarkup` flag causes PrebidServer to cache the bids and remove the creative body from the response to the client.\r\n\r\nThe PrebidServerBidAdapter places `cacheMarkup` at the global s2sConfig level.\r\n\r\n**Problem:**\r\n\r\nWhen the same web page contains both video (cached) and banner (uncached), the `s2sConfig.cacheMarkup` flag has to be changed in between requestBids() calls.\r\n\r\nProposed solution:\r\n\r\nDefine `cacheMarkup` per media type.\r\n\r\nThis allows for more control over when Prebid Server caches and responds with `hb_cache_url` and `hb_cache_id`. The client should to be able to tell the server what it wants to do for responses of different media types.\r\n\r\nThe proposed mechanism is to add a prebidServer-options extension to the bidRequest to allow the client to define what should happen for each mediaType. E.g. \r\n```\r\nbidRequest: {\r\n  ext: {\r\n     prebidServer: {\r\n         options: {\r\n             bidCaching: {\r\n                 banner: {\r\n                      cacheMarkup: false\r\n                 },\r\n                 video: {\r\n                     cacheMarkup: true\r\n                     // could be more options in the future, e.g.  ttl: 300 and cacheScope: [all|markup]\r\n                 }\r\n             }\r\n         }\r\n     }\r\n   }\r\n}\r\n```\r\n\r\nWhen `cacheMarkup` is true for the given bid response based on mediaType, Prebid Server caches and responds with `hb_cache_url` and `hb_cache_id`.\r\n\r\nThere could also be a default cacheMarkup value for each mediaType:\r\n- banner: false\r\n- video: true\r\n- native: false\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"dbemiller"}}