{"action":"created","issue":{"url":"https://api.github.com/repos/knative/pkg/issues/98","repository_url":"https://api.github.com/repos/knative/pkg","labels_url":"https://api.github.com/repos/knative/pkg/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/knative/pkg/issues/98/comments","events_url":"https://api.github.com/repos/knative/pkg/issues/98/events","html_url":"https://github.com/knative/pkg/pull/98","id":364028910,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MzE1NDMw","number":98,"title":"Move the use of `VerifyType` in tests","user":{"login":"vdemeester","id":6508,"node_id":"MDQ6VXNlcjY1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"labels":[{"id":1070147540,"node_id":"MDU6TGFiZWwxMDcwMTQ3NTQw","url":"https://api.github.com/repos/knative/pkg/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":1007315520,"node_id":"MDU6TGFiZWwxMDA3MzE1NTIw","url":"https://api.github.com/repos/knative/pkg/labels/size/L","name":"size/L","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-09-26T13:25:10Z","updated_at":"2018-09-27T09:08:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/knative/pkg/pulls/98","html_url":"https://github.com/knative/pkg/pull/98","diff_url":"https://github.com/knative/pkg/pull/98.diff","patch_url":"https://github.com/knative/pkg/pull/98.patch"},"body":"Those calls to `duck.VerifyType` are done at runtime and thus could be\r\ncostly at program startup. Putting them under tests ensure we still\r\nassert those types but during unit testing.\r\n\r\nThis is part of #97 (not clusing it as there will be PRs on `serving`, `eventing` and `build` to follow :wink: \r\n\r\ncc @dprotaso \r\n\r\nSigned-off-by: Vincent Demeester <vdemeest@redhat.com>\r\n"},"comment":{"url":"https://api.github.com/repos/knative/pkg/issues/comments/425017544","html_url":"https://github.com/knative/pkg/pull/98#issuecomment-425017544","issue_url":"https://api.github.com/repos/knative/pkg/issues/98","id":425017544,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTAxNzU0NA==","user":{"login":"covbot","id":38925759,"node_id":"MDQ6VXNlcjM4OTI1NzU5","avatar_url":"https://avatars1.githubusercontent.com/u/38925759?v=4","gravatar_id":"","url":"https://api.github.com/users/covbot","html_url":"https://github.com/covbot","followers_url":"https://api.github.com/users/covbot/followers","following_url":"https://api.github.com/users/covbot/following{/other_user}","gists_url":"https://api.github.com/users/covbot/gists{/gist_id}","starred_url":"https://api.github.com/users/covbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/covbot/subscriptions","organizations_url":"https://api.github.com/users/covbot/orgs","repos_url":"https://api.github.com/users/covbot/repos","events_url":"https://api.github.com/users/covbot/events{/privacy}","received_events_url":"https://api.github.com/users/covbot/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T09:08:55Z","updated_at":"2018-09-27T09:08:55Z","author_association":"NONE","body":"The following is the coverage report on pkg/.\nSay `/test pull-knative-pkg-go-coverage` to re-run this coverage report\n\nFile | Old Coverage | New Coverage | Delta\n---- |:------------:|:------------:|:-----:\n[apis/duck/v1alpha1/conditions_types.go](https://storage.cloud.google.com/knative-prow/pr-logs/pull/knative_pkg/98/pull-knative-pkg-go-coverage/1045238595465515008/artifacts/line-cov.html#file1) | 78.6% | 42.9% | -35.7\n[testing/resource.go](https://storage.cloud.google.com/knative-prow/pr-logs/pull/knative_pkg/98/pull-knative-pkg-go-coverage/1045238595465515008/artifacts/line-cov.html#file8) | Do not exist | 0.0% | \n[webhook/webhook.go](https://storage.cloud.google.com/knative-prow/pr-logs/pull/knative_pkg/98/pull-knative-pkg-go-coverage/1045238595465515008/artifacts/line-cov.html#file9) | 78.8% | 78.5% | -0.3\n"}}
{"actor":{"display_login":"covbot"}}