{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/client/issues/6819","repository_url":"https://api.github.com/repos/owncloud/client","labels_url":"https://api.github.com/repos/owncloud/client/issues/6819/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/client/issues/6819/comments","events_url":"https://api.github.com/repos/owncloud/client/issues/6819/events","html_url":"https://github.com/owncloud/client/pull/6819","id":371061443,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNTkzNTg3","number":6819,"title":"OAuth2: Refresh the token without aborting the sync","user":{"login":"ogoffart","id":959326,"node_id":"MDQ6VXNlcjk1OTMyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/959326?v=4","gravatar_id":"","url":"https://api.github.com/users/ogoffart","html_url":"https://github.com/ogoffart","followers_url":"https://api.github.com/users/ogoffart/followers","following_url":"https://api.github.com/users/ogoffart/following{/other_user}","gists_url":"https://api.github.com/users/ogoffart/gists{/gist_id}","starred_url":"https://api.github.com/users/ogoffart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogoffart/subscriptions","organizations_url":"https://api.github.com/users/ogoffart/orgs","repos_url":"https://api.github.com/users/ogoffart/repos","events_url":"https://api.github.com/users/ogoffart/events{/privacy}","received_events_url":"https://api.github.com/users/ogoffart/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/owncloud/client/milestones/48","html_url":"https://github.com/owncloud/client/milestone/48","labels_url":"https://api.github.com/repos/owncloud/client/milestones/48/labels","id":3292565,"node_id":"MDk6TWlsZXN0b25lMzI5MjU2NQ==","number":48,"title":"2.5.1","description":"","creator":{"login":"ogoffart","id":959326,"node_id":"MDQ6VXNlcjk1OTMyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/959326?v=4","gravatar_id":"","url":"https://api.github.com/users/ogoffart","html_url":"https://github.com/ogoffart","followers_url":"https://api.github.com/users/ogoffart/followers","following_url":"https://api.github.com/users/ogoffart/following{/other_user}","gists_url":"https://api.github.com/users/ogoffart/gists{/gist_id}","starred_url":"https://api.github.com/users/ogoffart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogoffart/subscriptions","organizations_url":"https://api.github.com/users/ogoffart/orgs","repos_url":"https://api.github.com/users/ogoffart/repos","events_url":"https://api.github.com/users/ogoffart/events{/privacy}","received_events_url":"https://api.github.com/users/ogoffart/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":18,"state":"open","created_at":"2018-04-24T12:14:56Z","updated_at":"2018-10-19T10:37:12Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-10-17T12:59:46Z","updated_at":"2018-10-19T10:38:17Z","closed_at":"2018-10-19T10:37:12Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/owncloud/client/pulls/6819","html_url":"https://github.com/owncloud/client/pull/6819","diff_url":"https://github.com/owncloud/client/pull/6819.diff","patch_url":"https://github.com/owncloud/client/pull/6819.patch"},"body":"OAuth2 access token typically only has a token valid for 1 hour.\r\nBefore this patch, when the token was timing out during the sync, the\r\nsync was aborted, and the ConnectionValidator was then requesting a new\r\ntoken, so the sync can be started over.\r\nIf the discovery takes longer than the oauth2 validity, this means that\r\nthe sync can never proceed, as it would be always restarted from scratch.\r\n    \r\nWith this patch, we try to transparently renew the OAuth2 token and restart\r\nthe jobs that failed because the access token was invalid.\r\n    \r\nNote that some changes were required in the GETFile job because it handled\r\nthe error itself and so it was erroring the jobs before its too late.\r\n    \r\nIssue #6814\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/client/issues/comments/431321099","html_url":"https://github.com/owncloud/client/pull/6819#issuecomment-431321099","issue_url":"https://api.github.com/repos/owncloud/client/issues/6819","id":431321099,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTMyMTA5OQ==","user":{"login":"ogoffart","id":959326,"node_id":"MDQ6VXNlcjk1OTMyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/959326?v=4","gravatar_id":"","url":"https://api.github.com/users/ogoffart","html_url":"https://github.com/ogoffart","followers_url":"https://api.github.com/users/ogoffart/followers","following_url":"https://api.github.com/users/ogoffart/following{/other_user}","gists_url":"https://api.github.com/users/ogoffart/gists{/gist_id}","starred_url":"https://api.github.com/users/ogoffart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogoffart/subscriptions","organizations_url":"https://api.github.com/users/ogoffart/orgs","repos_url":"https://api.github.com/users/ogoffart/repos","events_url":"https://api.github.com/users/ogoffart/events{/privacy}","received_events_url":"https://api.github.com/users/ogoffart/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T10:38:17Z","updated_at":"2018-10-19T10:38:17Z","author_association":"COLLABORATOR","body":"@micbar : I just merged the patch, which means that the 2.5.1 daily build from tomorrow will have the patch.  They could try the daily build."}}
{"actor":{"display_login":"ogoffart"}}