{"action":"created","issue":{"url":"https://api.github.com/repos/KeplerGO/lightkurve/issues/203","repository_url":"https://api.github.com/repos/KeplerGO/lightkurve","labels_url":"https://api.github.com/repos/KeplerGO/lightkurve/issues/203/labels{/name}","comments_url":"https://api.github.com/repos/KeplerGO/lightkurve/issues/203/comments","events_url":"https://api.github.com/repos/KeplerGO/lightkurve/issues/203/events","html_url":"https://github.com/KeplerGO/lightkurve/pull/203","id":343823994,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzY1Nzc0","number":203,"title":"Ensure every `LightCurve`, `LightCurveFile`, and `TargetPixelFile` object has a generic targetid","user":{"login":"barentsen","id":817669,"node_id":"MDQ6VXNlcjgxNzY2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/817669?v=4","gravatar_id":"","url":"https://api.github.com/users/barentsen","html_url":"https://github.com/barentsen","followers_url":"https://api.github.com/users/barentsen/followers","following_url":"https://api.github.com/users/barentsen/following{/other_user}","gists_url":"https://api.github.com/users/barentsen/gists{/gist_id}","starred_url":"https://api.github.com/users/barentsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barentsen/subscriptions","organizations_url":"https://api.github.com/users/barentsen/orgs","repos_url":"https://api.github.com/users/barentsen/repos","events_url":"https://api.github.com/users/barentsen/events{/privacy}","received_events_url":"https://api.github.com/users/barentsen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-23T22:53:31Z","updated_at":"2018-07-24T16:08:00Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/KeplerGO/lightkurve/pulls/203","html_url":"https://github.com/KeplerGO/lightkurve/pull/203","diff_url":"https://github.com/KeplerGO/lightkurve/pull/203.diff","patch_url":"https://github.com/KeplerGO/lightkurve/pull/203.patch"},"body":"This PR ensures that every `LightCurve` object, i.e. be it a `KeplerLightCurve` or `TessLightCurve`, has a generic `targetid` attribute that returns either the `keplerid` or `ticid`.\r\n\r\nThis enables tools to print an object's identifier without having to worry about the mission the data came from.\r\n\r\nThe same change is made for `LightCurveFile` and `TargetPixelFile` objects.\r\n\r\nAssigning to @johnnyzhang295 to review!"},"comment":{"url":"https://api.github.com/repos/KeplerGO/lightkurve/issues/comments/407462093","html_url":"https://github.com/KeplerGO/lightkurve/pull/203#issuecomment-407462093","issue_url":"https://api.github.com/repos/KeplerGO/lightkurve/issues/203","id":407462093,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzQ2MjA5Mw==","user":{"login":"barentsen","id":817669,"node_id":"MDQ6VXNlcjgxNzY2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/817669?v=4","gravatar_id":"","url":"https://api.github.com/users/barentsen","html_url":"https://github.com/barentsen","followers_url":"https://api.github.com/users/barentsen/followers","following_url":"https://api.github.com/users/barentsen/following{/other_user}","gists_url":"https://api.github.com/users/barentsen/gists{/gist_id}","starred_url":"https://api.github.com/users/barentsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barentsen/subscriptions","organizations_url":"https://api.github.com/users/barentsen/orgs","repos_url":"https://api.github.com/users/barentsen/repos","events_url":"https://api.github.com/users/barentsen/events{/privacy}","received_events_url":"https://api.github.com/users/barentsen/received_events","type":"User","site_admin":false},"created_at":"2018-07-24T16:08:00Z","updated_at":"2018-07-24T16:08:00Z","author_association":"MEMBER","body":"This is a good point.  I wonder if we should just get rid of `keplerid` and `ticid` and only ever use `targetid` consistently for all objects.  @christinahedges would you agree with such change?"}}
{"actor":{"display_login":"barentsen"}}