{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/165262731","pull_request_review_id":93170581,"id":165262731,"diff_hunk":"@@ -0,0 +1,72 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+using System.Text;\n+\n+namespace System.Buffers\n+{\n+    internal class SpanLiteralExtensions\n+    {\n+        internal static void AppendAsLiteral(ReadOnlySpan<byte> span, StringBuilder sb)\n+        {\n+            for (int i = 0; i < span.Length; i++)\n+            {\n+                AppendCharLiteral((char) span[i], sb);","path":"src/System.Memory/src/System/Buffers/SpanLiteralExtensions.cs","position":15,"original_position":15,"commit_id":"b61fdca6de90aa835081ef31f6936386f3bcaf66","original_commit_id":"98f1efd96db376f11d9adb96ecf2d02b4de6dfec","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars2.githubusercontent.com/u/6668460?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"What is the encoding that this assumes?\r\n\r\nCasting `(byte)` to `(char)` works for ASCII, but not for anything else. Not very globalization friendly.","created_at":"2018-02-01T05:29:04Z","updated_at":"2018-02-01T05:29:04Z","html_url":"https://github.com/dotnet/corefx/pull/26694#discussion_r165262731","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/26694","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/165262731"},"html":{"href":"https://github.com/dotnet/corefx/pull/26694#discussion_r165262731"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/26694"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/26694","id":166129331,"html_url":"https://github.com/dotnet/corefx/pull/26694","diff_url":"https://github.com/dotnet/corefx/pull/26694.diff","patch_url":"https://github.com/dotnet/corefx/pull/26694.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/26694","number":26694,"state":"open","locked":false,"title":"Add ReadOnlyBuffer API","user":{"login":"pakrym","id":1697911,"avatar_url":"https://avatars0.githubusercontent.com/u/1697911?v=4","gravatar_id":"","url":"https://api.github.com/users/pakrym","html_url":"https://github.com/pakrym","followers_url":"https://api.github.com/users/pakrym/followers","following_url":"https://api.github.com/users/pakrym/following{/other_user}","gists_url":"https://api.github.com/users/pakrym/gists{/gist_id}","starred_url":"https://api.github.com/users/pakrym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakrym/subscriptions","organizations_url":"https://api.github.com/users/pakrym/orgs","repos_url":"https://api.github.com/users/pakrym/repos","events_url":"https://api.github.com/users/pakrym/events{/privacy}","received_events_url":"https://api.github.com/users/pakrym/received_events","type":"User","site_admin":false},"body":"/cc @KrzysztofCwalina @davidfowl ","created_at":"2018-01-30T23:44:16Z","updated_at":"2018-02-01T05:29:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"314b59839bbb7f826796ec6c66eb4af1de73738f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidfowl","id":95136,"avatar_url":"https://avatars3.githubusercontent.com/u/95136?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},{"login":"joshfree","id":1302850,"avatar_url":"https://avatars1.githubusercontent.com/u/1302850?v=4","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},{"login":"GrabYourPitchforks","id":1746272,"avatar_url":"https://avatars0.githubusercontent.com/u/1746272?v=4","gravatar_id":"","url":"https://api.github.com/users/GrabYourPitchforks","html_url":"https://github.com/GrabYourPitchforks","followers_url":"https://api.github.com/users/GrabYourPitchforks/followers","following_url":"https://api.github.com/users/GrabYourPitchforks/following{/other_user}","gists_url":"https://api.github.com/users/GrabYourPitchforks/gists{/gist_id}","starred_url":"https://api.github.com/users/GrabYourPitchforks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrabYourPitchforks/subscriptions","organizations_url":"https://api.github.com/users/GrabYourPitchforks/orgs","repos_url":"https://api.github.com/users/GrabYourPitchforks/repos","events_url":"https://api.github.com/users/GrabYourPitchforks/events{/privacy}","received_events_url":"https://api.github.com/users/GrabYourPitchforks/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/26694/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/26694/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/26694/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/b61fdca6de90aa835081ef31f6936386f3bcaf66","head":{"label":"pakrym:pakrym/rob","ref":"pakrym/rob","sha":"b61fdca6de90aa835081ef31f6936386f3bcaf66","user":{"login":"pakrym","id":1697911,"avatar_url":"https://avatars0.githubusercontent.com/u/1697911?v=4","gravatar_id":"","url":"https://api.github.com/users/pakrym","html_url":"https://github.com/pakrym","followers_url":"https://api.github.com/users/pakrym/followers","following_url":"https://api.github.com/users/pakrym/following{/other_user}","gists_url":"https://api.github.com/users/pakrym/gists{/gist_id}","starred_url":"https://api.github.com/users/pakrym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakrym/subscriptions","organizations_url":"https://api.github.com/users/pakrym/orgs","repos_url":"https://api.github.com/users/pakrym/repos","events_url":"https://api.github.com/users/pakrym/events{/privacy}","received_events_url":"https://api.github.com/users/pakrym/received_events","type":"User","site_admin":false},"repo":{"id":119602347,"name":"corefx","full_name":"pakrym/corefx","owner":{"login":"pakrym","id":1697911,"avatar_url":"https://avatars0.githubusercontent.com/u/1697911?v=4","gravatar_id":"","url":"https://api.github.com/users/pakrym","html_url":"https://github.com/pakrym","followers_url":"https://api.github.com/users/pakrym/followers","following_url":"https://api.github.com/users/pakrym/following{/other_user}","gists_url":"https://api.github.com/users/pakrym/gists{/gist_id}","starred_url":"https://api.github.com/users/pakrym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakrym/subscriptions","organizations_url":"https://api.github.com/users/pakrym/orgs","repos_url":"https://api.github.com/users/pakrym/repos","events_url":"https://api.github.com/users/pakrym/events{/privacy}","received_events_url":"https://api.github.com/users/pakrym/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pakrym/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/pakrym/corefx","forks_url":"https://api.github.com/repos/pakrym/corefx/forks","keys_url":"https://api.github.com/repos/pakrym/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pakrym/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pakrym/corefx/teams","hooks_url":"https://api.github.com/repos/pakrym/corefx/hooks","issue_events_url":"https://api.github.com/repos/pakrym/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/pakrym/corefx/events","assignees_url":"https://api.github.com/repos/pakrym/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/pakrym/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/pakrym/corefx/tags","blobs_url":"https://api.github.com/repos/pakrym/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pakrym/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pakrym/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/pakrym/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pakrym/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/pakrym/corefx/languages","stargazers_url":"https://api.github.com/repos/pakrym/corefx/stargazers","contributors_url":"https://api.github.com/repos/pakrym/corefx/contributors","subscribers_url":"https://api.github.com/repos/pakrym/corefx/subscribers","subscription_url":"https://api.github.com/repos/pakrym/corefx/subscription","commits_url":"https://api.github.com/repos/pakrym/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/pakrym/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/pakrym/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/pakrym/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/pakrym/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/pakrym/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pakrym/corefx/merges","archive_url":"https://api.github.com/repos/pakrym/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pakrym/corefx/downloads","issues_url":"https://api.github.com/repos/pakrym/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/pakrym/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/pakrym/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/pakrym/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pakrym/corefx/labels{/name}","releases_url":"https://api.github.com/repos/pakrym/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/pakrym/corefx/deployments","created_at":"2018-01-30T22:25:57Z","updated_at":"2018-01-30T22:26:46Z","pushed_at":"2018-01-31T22:17:49Z","git_url":"git://github.com/pakrym/corefx.git","ssh_url":"git@github.com:pakrym/corefx.git","clone_url":"https://github.com/pakrym/corefx.git","svn_url":"https://github.com/pakrym/corefx","homepage":"https://github.com/dotnet/core","size":168869,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"21486567a754e580dc1c058b97ac42b875f3d80e","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-02-01T03:55:41Z","pushed_at":"2018-02-01T05:11:13Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":167899,"stargazers_count":13303,"watchers_count":13303,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3753,"mirror_url":null,"archived":false,"open_issues_count":2200,"license":null,"forks":3753,"open_issues":2200,"watchers":13303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/26694"},"html":{"href":"https://github.com/dotnet/corefx/pull/26694"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/26694"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/26694/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/26694/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/26694/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/b61fdca6de90aa835081ef31f6936386f3bcaf66"}},"author_association":"NONE"}}
{"actor":{"display_login":"jkotas"}}