{"action":"created","issue":{"url":"https://api.github.com/repos/helmetjs/helmet/issues/182","repository_url":"https://api.github.com/repos/helmetjs/helmet","labels_url":"https://api.github.com/repos/helmetjs/helmet/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/helmetjs/helmet/issues/182/comments","events_url":"https://api.github.com/repos/helmetjs/helmet/issues/182/events","html_url":"https://github.com/helmetjs/helmet/issues/182","id":371659062,"node_id":"MDU6SXNzdWUzNzE2NTkwNjI=","number":182,"title":"DNS Rebinding protection","user":{"login":"brannondorsey","id":3193533,"node_id":"MDQ6VXNlcjMxOTM1MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/3193533?v=4","gravatar_id":"","url":"https://api.github.com/users/brannondorsey","html_url":"https://github.com/brannondorsey","followers_url":"https://api.github.com/users/brannondorsey/followers","following_url":"https://api.github.com/users/brannondorsey/following{/other_user}","gists_url":"https://api.github.com/users/brannondorsey/gists{/gist_id}","starred_url":"https://api.github.com/users/brannondorsey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brannondorsey/subscriptions","organizations_url":"https://api.github.com/users/brannondorsey/orgs","repos_url":"https://api.github.com/users/brannondorsey/repos","events_url":"https://api.github.com/users/brannondorsey/events{/privacy}","received_events_url":"https://api.github.com/users/brannondorsey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-18T18:39:48Z","updated_at":"2018-10-19T21:02:23Z","closed_at":null,"author_association":"NONE","body":"Hi, I'm an independent security researcher and author of [`host-validation`](https://www.npmjs.com/package/host-validation), an NPM module for protecting Express.js servers from DNS rebinding attacks via host header validation. I've done a [fair amount of research on the subject](https://medium.com/@brannondorsey/attacking-private-networks-from-the-internet-with-dns-rebinding-ea7098a2d325) and I think DNS rebinding protection through header validation would be a perfect addition to helmet. I'm happy to spearhead this effort if there is interest. I'm willing to write a PR with updates to the lib, tests, and documentation, pending discussion. This is an amazing project and I'd like to contribute a small bit to make it even better."},"comment":{"url":"https://api.github.com/repos/helmetjs/helmet/issues/comments/431497957","html_url":"https://github.com/helmetjs/helmet/issues/182#issuecomment-431497957","issue_url":"https://api.github.com/repos/helmetjs/helmet/issues/182","id":431497957,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTQ5Nzk1Nw==","user":{"login":"EvanHahn","id":777712,"node_id":"MDQ6VXNlcjc3NzcxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/777712?v=4","gravatar_id":"","url":"https://api.github.com/users/EvanHahn","html_url":"https://github.com/EvanHahn","followers_url":"https://api.github.com/users/EvanHahn/followers","following_url":"https://api.github.com/users/EvanHahn/following{/other_user}","gists_url":"https://api.github.com/users/EvanHahn/gists{/gist_id}","starred_url":"https://api.github.com/users/EvanHahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvanHahn/subscriptions","organizations_url":"https://api.github.com/users/EvanHahn/orgs","repos_url":"https://api.github.com/users/EvanHahn/repos","events_url":"https://api.github.com/users/EvanHahn/events{/privacy}","received_events_url":"https://api.github.com/users/EvanHahn/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T21:02:23Z","updated_at":"2018-10-19T21:02:23Z","author_association":"MEMBER","body":"I didn't know about DNS rebinding—thanks for bringing it to my attention!\r\n\r\nI've never been explicit about this, but I intend Helmet to be a middleware that deals with *response* headers, not request headers. Even though I'd argue that `Host` validation is more important than some of the headers Helmet sets, `Host` validation is a *request* header issue, and therefore out of this project's scope.\r\n\r\nI think there are two action items for Helmet here:\r\n\r\n1. After doing a quick audit of the code, recommend `host-validation` in the [\"see also\" section of Helmet's docs](https://helmetjs.github.io/see-also/).\r\n2. Add documentation that makes Helmet's goal (HTTP *response* headers for Express) more explicit.\r\n\r\nDoes that sound reasonable?\r\n"}}
{"actor":{"display_login":"EvanHahn"}}