{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/tranquility/pulls/comments/224645326","pull_request_review_id":164065940,"id":224645326,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDY0NTMyNg==","diff_hunk":"@@ -725,6 +739,17 @@ object DruidBeams\n       )\n     }\n \n+    /**\n+      * Provide tunings for communication with Druid tasks. Optional, see [[DruidBeamConfig]] for defaults.\n+      *\n+      * @param beamConfig beam config tunings\n+      * @return new builder\n+      */\n+    def generalConfig(generalConfig: PropertiesBasedConfig) = {","path":"core/src/main/scala/com/metamx/tranquility/druid/DruidBeams.scala","position":68,"original_position":68,"commit_id":"b30695fc59998362d73d65760a07520e080c3c9d","original_commit_id":"b30695fc59998362d73d65760a07520e080c3c9d","user":{"login":"gianm","id":1214075,"node_id":"MDQ6VXNlcjEyMTQwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1214075?v=4","gravatar_id":"","url":"https://api.github.com/users/gianm","html_url":"https://github.com/gianm","followers_url":"https://api.github.com/users/gianm/followers","following_url":"https://api.github.com/users/gianm/following{/other_user}","gists_url":"https://api.github.com/users/gianm/gists{/gist_id}","starred_url":"https://api.github.com/users/gianm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianm/subscriptions","organizations_url":"https://api.github.com/users/gianm/orgs","repos_url":"https://api.github.com/users/gianm/repos","events_url":"https://api.github.com/users/gianm/events{/privacy}","received_events_url":"https://api.github.com/users/gianm/received_events","type":"User","site_admin":false},"body":"This is a bit weird. Generally the Builder is set up to take each config option separately. The idea is that if you're using Tranquility programmatically (i.e. using Core or Storm or Samza), each Builder method call is equivalent to specifying a particular property with a property-based config (i.e. using Server or Kafka).\r\n\r\nAny reason it has to be done this way, or would it be possible to split this up into a Builder method for each option?","created_at":"2018-10-12T00:53:21Z","updated_at":"2018-10-12T00:59:26Z","html_url":"https://github.com/druid-io/tranquility/pull/277#discussion_r224645326","pull_request_url":"https://api.github.com/repos/druid-io/tranquility/pulls/277","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/druid-io/tranquility/pulls/comments/224645326"},"html":{"href":"https://github.com/druid-io/tranquility/pull/277#discussion_r224645326"},"pull_request":{"href":"https://api.github.com/repos/druid-io/tranquility/pulls/277"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/tranquility/pulls/277","id":197266573,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MjY2NTcz","html_url":"https://github.com/druid-io/tranquility/pull/277","diff_url":"https://github.com/druid-io/tranquility/pull/277.diff","patch_url":"https://github.com/druid-io/tranquility/pull/277.patch","issue_url":"https://api.github.com/repos/druid-io/tranquility/issues/277","number":277,"state":"open","locked":false,"title":"Support Basic HTTP auth with druid, TLS support for server","user":{"login":"jon-wei","id":8729063,"node_id":"MDQ6VXNlcjg3MjkwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/8729063?v=4","gravatar_id":"","url":"https://api.github.com/users/jon-wei","html_url":"https://github.com/jon-wei","followers_url":"https://api.github.com/users/jon-wei/followers","following_url":"https://api.github.com/users/jon-wei/following{/other_user}","gists_url":"https://api.github.com/users/jon-wei/gists{/gist_id}","starred_url":"https://api.github.com/users/jon-wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon-wei/subscriptions","organizations_url":"https://api.github.com/users/jon-wei/orgs","repos_url":"https://api.github.com/users/jon-wei/repos","events_url":"https://api.github.com/users/jon-wei/events{/privacy}","received_events_url":"https://api.github.com/users/jon-wei/received_events","type":"User","site_admin":false},"body":"This PR adds support for Basic HTTP authentication when Tranquility communicates with Druid.\r\n\r\nThe PR also adds configuration options that allow Tranquility Server to accept requests with TLS and communicate with a TLS-enabled Druid cluster.","created_at":"2018-06-25T23:55:04Z","updated_at":"2018-10-12T00:59:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de15c47ecb02401423ed3f078ab42353d0ec2a07","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":80461842,"node_id":"MDU6TGFiZWw4MDQ2MTg0Mg==","url":"https://api.github.com/repos/druid-io/tranquility/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/tranquility/pulls/277/commits","review_comments_url":"https://api.github.com/repos/druid-io/tranquility/pulls/277/comments","review_comment_url":"https://api.github.com/repos/druid-io/tranquility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/tranquility/issues/277/comments","statuses_url":"https://api.github.com/repos/druid-io/tranquility/statuses/b30695fc59998362d73d65760a07520e080c3c9d","head":{"label":"jon-wei:auth_tls","ref":"auth_tls","sha":"b30695fc59998362d73d65760a07520e080c3c9d","user":{"login":"jon-wei","id":8729063,"node_id":"MDQ6VXNlcjg3MjkwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/8729063?v=4","gravatar_id":"","url":"https://api.github.com/users/jon-wei","html_url":"https://github.com/jon-wei","followers_url":"https://api.github.com/users/jon-wei/followers","following_url":"https://api.github.com/users/jon-wei/following{/other_user}","gists_url":"https://api.github.com/users/jon-wei/gists{/gist_id}","starred_url":"https://api.github.com/users/jon-wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon-wei/subscriptions","organizations_url":"https://api.github.com/users/jon-wei/orgs","repos_url":"https://api.github.com/users/jon-wei/repos","events_url":"https://api.github.com/users/jon-wei/events{/privacy}","received_events_url":"https://api.github.com/users/jon-wei/received_events","type":"User","site_admin":false},"repo":{"id":138222710,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyMjI3MTA=","name":"tranquility","full_name":"jon-wei/tranquility","private":false,"owner":{"login":"jon-wei","id":8729063,"node_id":"MDQ6VXNlcjg3MjkwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/8729063?v=4","gravatar_id":"","url":"https://api.github.com/users/jon-wei","html_url":"https://github.com/jon-wei","followers_url":"https://api.github.com/users/jon-wei/followers","following_url":"https://api.github.com/users/jon-wei/following{/other_user}","gists_url":"https://api.github.com/users/jon-wei/gists{/gist_id}","starred_url":"https://api.github.com/users/jon-wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon-wei/subscriptions","organizations_url":"https://api.github.com/users/jon-wei/orgs","repos_url":"https://api.github.com/users/jon-wei/repos","events_url":"https://api.github.com/users/jon-wei/events{/privacy}","received_events_url":"https://api.github.com/users/jon-wei/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jon-wei/tranquility","description":"Tranquility helps you send real-time event streams to Druid and handles partitioning, replication, service discovery, and schema rollover, seamlessly and without downtime.","fork":true,"url":"https://api.github.com/repos/jon-wei/tranquility","forks_url":"https://api.github.com/repos/jon-wei/tranquility/forks","keys_url":"https://api.github.com/repos/jon-wei/tranquility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jon-wei/tranquility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jon-wei/tranquility/teams","hooks_url":"https://api.github.com/repos/jon-wei/tranquility/hooks","issue_events_url":"https://api.github.com/repos/jon-wei/tranquility/issues/events{/number}","events_url":"https://api.github.com/repos/jon-wei/tranquility/events","assignees_url":"https://api.github.com/repos/jon-wei/tranquility/assignees{/user}","branches_url":"https://api.github.com/repos/jon-wei/tranquility/branches{/branch}","tags_url":"https://api.github.com/repos/jon-wei/tranquility/tags","blobs_url":"https://api.github.com/repos/jon-wei/tranquility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jon-wei/tranquility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jon-wei/tranquility/git/refs{/sha}","trees_url":"https://api.github.com/repos/jon-wei/tranquility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jon-wei/tranquility/statuses/{sha}","languages_url":"https://api.github.com/repos/jon-wei/tranquility/languages","stargazers_url":"https://api.github.com/repos/jon-wei/tranquility/stargazers","contributors_url":"https://api.github.com/repos/jon-wei/tranquility/contributors","subscribers_url":"https://api.github.com/repos/jon-wei/tranquility/subscribers","subscription_url":"https://api.github.com/repos/jon-wei/tranquility/subscription","commits_url":"https://api.github.com/repos/jon-wei/tranquility/commits{/sha}","git_commits_url":"https://api.github.com/repos/jon-wei/tranquility/git/commits{/sha}","comments_url":"https://api.github.com/repos/jon-wei/tranquility/comments{/number}","issue_comment_url":"https://api.github.com/repos/jon-wei/tranquility/issues/comments{/number}","contents_url":"https://api.github.com/repos/jon-wei/tranquility/contents/{+path}","compare_url":"https://api.github.com/repos/jon-wei/tranquility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jon-wei/tranquility/merges","archive_url":"https://api.github.com/repos/jon-wei/tranquility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jon-wei/tranquility/downloads","issues_url":"https://api.github.com/repos/jon-wei/tranquility/issues{/number}","pulls_url":"https://api.github.com/repos/jon-wei/tranquility/pulls{/number}","milestones_url":"https://api.github.com/repos/jon-wei/tranquility/milestones{/number}","notifications_url":"https://api.github.com/repos/jon-wei/tranquility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jon-wei/tranquility/labels{/name}","releases_url":"https://api.github.com/repos/jon-wei/tranquility/releases{/id}","deployments_url":"https://api.github.com/repos/jon-wei/tranquility/deployments","created_at":"2018-06-21T21:17:21Z","updated_at":"2018-06-21T21:17:23Z","pushed_at":"2018-09-28T00:55:37Z","git_url":"git://github.com/jon-wei/tranquility.git","ssh_url":"git@github.com:jon-wei/tranquility.git","clone_url":"https://github.com/jon-wei/tranquility.git","svn_url":"https://github.com/jon-wei/tranquility","homepage":"","size":1047,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"fd548bf768a0d4acacca1347ffcdd98a99e3a853","user":{"login":"druid-io","id":4203474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDM0NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4203474?v=4","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":16817857,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgxNzg1Nw==","name":"tranquility","full_name":"druid-io/tranquility","private":false,"owner":{"login":"druid-io","id":4203474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDM0NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4203474?v=4","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/druid-io/tranquility","description":"Tranquility helps you send real-time event streams to Druid and handles partitioning, replication, service discovery, and schema rollover, seamlessly and without downtime.","fork":false,"url":"https://api.github.com/repos/druid-io/tranquility","forks_url":"https://api.github.com/repos/druid-io/tranquility/forks","keys_url":"https://api.github.com/repos/druid-io/tranquility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/tranquility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/tranquility/teams","hooks_url":"https://api.github.com/repos/druid-io/tranquility/hooks","issue_events_url":"https://api.github.com/repos/druid-io/tranquility/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/tranquility/events","assignees_url":"https://api.github.com/repos/druid-io/tranquility/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/tranquility/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/tranquility/tags","blobs_url":"https://api.github.com/repos/druid-io/tranquility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/tranquility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/tranquility/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/tranquility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/tranquility/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/tranquility/languages","stargazers_url":"https://api.github.com/repos/druid-io/tranquility/stargazers","contributors_url":"https://api.github.com/repos/druid-io/tranquility/contributors","subscribers_url":"https://api.github.com/repos/druid-io/tranquility/subscribers","subscription_url":"https://api.github.com/repos/druid-io/tranquility/subscription","commits_url":"https://api.github.com/repos/druid-io/tranquility/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/tranquility/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/tranquility/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/tranquility/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/tranquility/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/tranquility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/tranquility/merges","archive_url":"https://api.github.com/repos/druid-io/tranquility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/tranquility/downloads","issues_url":"https://api.github.com/repos/druid-io/tranquility/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/tranquility/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/tranquility/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/tranquility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/tranquility/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/tranquility/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/tranquility/deployments","created_at":"2014-02-13T21:30:05Z","updated_at":"2018-10-11T04:28:59Z","pushed_at":"2018-09-28T00:55:38Z","git_url":"git://github.com/druid-io/tranquility.git","ssh_url":"git@github.com:druid-io/tranquility.git","clone_url":"https://github.com/druid-io/tranquility.git","svn_url":"https://github.com/druid-io/tranquility","homepage":"","size":1039,"stargazers_count":368,"watchers_count":368,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":202,"open_issues":81,"watchers":368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/tranquility/pulls/277"},"html":{"href":"https://github.com/druid-io/tranquility/pull/277"},"issue":{"href":"https://api.github.com/repos/druid-io/tranquility/issues/277"},"comments":{"href":"https://api.github.com/repos/druid-io/tranquility/issues/277/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/tranquility/pulls/277/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/tranquility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/tranquility/pulls/277/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/tranquility/statuses/b30695fc59998362d73d65760a07520e080c3c9d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gianm"}}