{"action":"created","comment":{"url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/comments/185214418","pull_request_review_id":116557434,"id":185214418,"diff_hunk":"@@ -1,25 +1,42 @@\n # Places SIMP version related information on the filesystem\n-class simp::version {\n-\n-  file { '/etc/simp':\n-    ensure => 'directory',\n-    owner  => 'root',\n-    group  => 'root',\n-    mode   => '0644'\n+class simp::version () {\n+  # XXX: ToDo: Move /etc/simp creation to a simplib class and use\n+  # moduledata to resolve the variables..\n+  #\n+  # It's needed in more places then here, and they don't need to pull in\n+  # anything else from simp\n+  if (downcase($facts['kernel']) == 'windows') {\n+    $simp_root_dir = \"C:/ProgramData/SIMP\"","path":"manifests/version.pp","position":16,"original_position":16,"commit_id":"672ad77bd2e912fb74121cd3213ac2852a44e9c5","original_commit_id":"672ad77bd2e912fb74121cd3213ac2852a44e9c5","user":{"login":"trevor-vaughan","id":4982601,"avatar_url":"https://avatars0.githubusercontent.com/u/4982601?v=4","gravatar_id":"","url":"https://api.github.com/users/trevor-vaughan","html_url":"https://github.com/trevor-vaughan","followers_url":"https://api.github.com/users/trevor-vaughan/followers","following_url":"https://api.github.com/users/trevor-vaughan/following{/other_user}","gists_url":"https://api.github.com/users/trevor-vaughan/gists{/gist_id}","starred_url":"https://api.github.com/users/trevor-vaughan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevor-vaughan/subscriptions","organizations_url":"https://api.github.com/users/trevor-vaughan/orgs","repos_url":"https://api.github.com/users/trevor-vaughan/repos","events_url":"https://api.github.com/users/trevor-vaughan/events{/privacy}","received_events_url":"https://api.github.com/users/trevor-vaughan/received_events","type":"User","site_admin":false},"body":"Static strings should be single quoted.","created_at":"2018-05-01T12:51:32Z","updated_at":"2018-05-01T12:55:48Z","html_url":"https://github.com/simp/pupmod-simp-simp/pull/152#discussion_r185214418","pull_request_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/152","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/comments/185214418"},"html":{"href":"https://github.com/simp/pupmod-simp-simp/pull/152#discussion_r185214418"},"pull_request":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/152","id":185068495,"html_url":"https://github.com/simp/pupmod-simp-simp/pull/152","diff_url":"https://github.com/simp/pupmod-simp-simp/pull/152.diff","patch_url":"https://github.com/simp/pupmod-simp-simp/pull/152.patch","issue_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/152","number":152,"state":"open","locked":false,"title":"(SIMP-4849) Add Windows support to the module","user":{"login":"heliocentric","id":2577255,"avatar_url":"https://avatars0.githubusercontent.com/u/2577255?v=4","gravatar_id":"","url":"https://api.github.com/users/heliocentric","html_url":"https://github.com/heliocentric","followers_url":"https://api.github.com/users/heliocentric/followers","following_url":"https://api.github.com/users/heliocentric/following{/other_user}","gists_url":"https://api.github.com/users/heliocentric/gists{/gist_id}","starred_url":"https://api.github.com/users/heliocentric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heliocentric/subscriptions","organizations_url":"https://api.github.com/users/heliocentric/orgs","repos_url":"https://api.github.com/users/heliocentric/repos","events_url":"https://api.github.com/users/heliocentric/events{/privacy}","received_events_url":"https://api.github.com/users/heliocentric/received_events","type":"User","site_admin":false},"body":"* Add conditional on Windows platforms, that changes the simp.version\r\n  location depending on whether it was Windows or not.\r\n* Add module data for $facts['puppet_vardir']/simp user, group, and mode\r\n* Add stub data for scenarios, there's no reason to fail a catalog compile\r\n  just by including simp.\r\n\r\nFixes enterprise-meta#338\r\nSIMP-4849 #close","created_at":"2018-04-30T21:23:26Z","updated_at":"2018-05-01T12:55:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86289197ca970ca4ec9df0296c95de07c6962273","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/152/commits","review_comments_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/152/comments","review_comment_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/152/comments","statuses_url":"https://api.github.com/repos/simp/pupmod-simp-simp/statuses/672ad77bd2e912fb74121cd3213ac2852a44e9c5","head":{"label":"heliocentric:SIMP-4849","ref":"SIMP-4849","sha":"672ad77bd2e912fb74121cd3213ac2852a44e9c5","user":{"login":"heliocentric","id":2577255,"avatar_url":"https://avatars0.githubusercontent.com/u/2577255?v=4","gravatar_id":"","url":"https://api.github.com/users/heliocentric","html_url":"https://github.com/heliocentric","followers_url":"https://api.github.com/users/heliocentric/followers","following_url":"https://api.github.com/users/heliocentric/following{/other_user}","gists_url":"https://api.github.com/users/heliocentric/gists{/gist_id}","starred_url":"https://api.github.com/users/heliocentric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heliocentric/subscriptions","organizations_url":"https://api.github.com/users/heliocentric/orgs","repos_url":"https://api.github.com/users/heliocentric/repos","events_url":"https://api.github.com/users/heliocentric/events{/privacy}","received_events_url":"https://api.github.com/users/heliocentric/received_events","type":"User","site_admin":false},"repo":{"id":77541454,"name":"pupmod-simp-simp","full_name":"heliocentric/pupmod-simp-simp","owner":{"login":"heliocentric","id":2577255,"avatar_url":"https://avatars0.githubusercontent.com/u/2577255?v=4","gravatar_id":"","url":"https://api.github.com/users/heliocentric","html_url":"https://github.com/heliocentric","followers_url":"https://api.github.com/users/heliocentric/followers","following_url":"https://api.github.com/users/heliocentric/following{/other_user}","gists_url":"https://api.github.com/users/heliocentric/gists{/gist_id}","starred_url":"https://api.github.com/users/heliocentric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heliocentric/subscriptions","organizations_url":"https://api.github.com/users/heliocentric/orgs","repos_url":"https://api.github.com/users/heliocentric/repos","events_url":"https://api.github.com/users/heliocentric/events{/privacy}","received_events_url":"https://api.github.com/users/heliocentric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heliocentric/pupmod-simp-simp","description":"The SIMP simp Puppet Module","fork":true,"url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp","forks_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/forks","keys_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/teams","hooks_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/hooks","issue_events_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/issues/events{/number}","events_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/events","assignees_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/assignees{/user}","branches_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/branches{/branch}","tags_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/tags","blobs_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/git/refs{/sha}","trees_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/statuses/{sha}","languages_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/languages","stargazers_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/stargazers","contributors_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/contributors","subscribers_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/subscribers","subscription_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/subscription","commits_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/commits{/sha}","git_commits_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/git/commits{/sha}","comments_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/comments{/number}","issue_comment_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/issues/comments{/number}","contents_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/contents/{+path}","compare_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/merges","archive_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/downloads","issues_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/issues{/number}","pulls_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/pulls{/number}","milestones_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/milestones{/number}","notifications_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/labels{/name}","releases_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/releases{/id}","deployments_url":"https://api.github.com/repos/heliocentric/pupmod-simp-simp/deployments","created_at":"2016-12-28T15:12:01Z","updated_at":"2017-03-25T16:48:43Z","pushed_at":"2018-04-30T23:51:57Z","git_url":"git://github.com/heliocentric/pupmod-simp-simp.git","ssh_url":"git@github.com:heliocentric/pupmod-simp-simp.git","clone_url":"https://github.com/heliocentric/pupmod-simp-simp.git","svn_url":"https://github.com/heliocentric/pupmod-simp-simp","homepage":null,"size":557,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simp:master","ref":"master","sha":"cf8670e1f70fb711ff882c6ede7db992e006b36a","user":{"login":"simp","id":12174186,"avatar_url":"https://avatars2.githubusercontent.com/u/12174186?v=4","gravatar_id":"","url":"https://api.github.com/users/simp","html_url":"https://github.com/simp","followers_url":"https://api.github.com/users/simp/followers","following_url":"https://api.github.com/users/simp/following{/other_user}","gists_url":"https://api.github.com/users/simp/gists{/gist_id}","starred_url":"https://api.github.com/users/simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simp/subscriptions","organizations_url":"https://api.github.com/users/simp/orgs","repos_url":"https://api.github.com/users/simp/repos","events_url":"https://api.github.com/users/simp/events{/privacy}","received_events_url":"https://api.github.com/users/simp/received_events","type":"Organization","site_admin":false},"repo":{"id":35873685,"name":"pupmod-simp-simp","full_name":"simp/pupmod-simp-simp","owner":{"login":"simp","id":12174186,"avatar_url":"https://avatars2.githubusercontent.com/u/12174186?v=4","gravatar_id":"","url":"https://api.github.com/users/simp","html_url":"https://github.com/simp","followers_url":"https://api.github.com/users/simp/followers","following_url":"https://api.github.com/users/simp/following{/other_user}","gists_url":"https://api.github.com/users/simp/gists{/gist_id}","starred_url":"https://api.github.com/users/simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simp/subscriptions","organizations_url":"https://api.github.com/users/simp/orgs","repos_url":"https://api.github.com/users/simp/repos","events_url":"https://api.github.com/users/simp/events{/privacy}","received_events_url":"https://api.github.com/users/simp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simp/pupmod-simp-simp","description":"The SIMP simp Puppet Module","fork":false,"url":"https://api.github.com/repos/simp/pupmod-simp-simp","forks_url":"https://api.github.com/repos/simp/pupmod-simp-simp/forks","keys_url":"https://api.github.com/repos/simp/pupmod-simp-simp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simp/pupmod-simp-simp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simp/pupmod-simp-simp/teams","hooks_url":"https://api.github.com/repos/simp/pupmod-simp-simp/hooks","issue_events_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/events{/number}","events_url":"https://api.github.com/repos/simp/pupmod-simp-simp/events","assignees_url":"https://api.github.com/repos/simp/pupmod-simp-simp/assignees{/user}","branches_url":"https://api.github.com/repos/simp/pupmod-simp-simp/branches{/branch}","tags_url":"https://api.github.com/repos/simp/pupmod-simp-simp/tags","blobs_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/refs{/sha}","trees_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simp/pupmod-simp-simp/statuses/{sha}","languages_url":"https://api.github.com/repos/simp/pupmod-simp-simp/languages","stargazers_url":"https://api.github.com/repos/simp/pupmod-simp-simp/stargazers","contributors_url":"https://api.github.com/repos/simp/pupmod-simp-simp/contributors","subscribers_url":"https://api.github.com/repos/simp/pupmod-simp-simp/subscribers","subscription_url":"https://api.github.com/repos/simp/pupmod-simp-simp/subscription","commits_url":"https://api.github.com/repos/simp/pupmod-simp-simp/commits{/sha}","git_commits_url":"https://api.github.com/repos/simp/pupmod-simp-simp/git/commits{/sha}","comments_url":"https://api.github.com/repos/simp/pupmod-simp-simp/comments{/number}","issue_comment_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/comments{/number}","contents_url":"https://api.github.com/repos/simp/pupmod-simp-simp/contents/{+path}","compare_url":"https://api.github.com/repos/simp/pupmod-simp-simp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simp/pupmod-simp-simp/merges","archive_url":"https://api.github.com/repos/simp/pupmod-simp-simp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simp/pupmod-simp-simp/downloads","issues_url":"https://api.github.com/repos/simp/pupmod-simp-simp/issues{/number}","pulls_url":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls{/number}","milestones_url":"https://api.github.com/repos/simp/pupmod-simp-simp/milestones{/number}","notifications_url":"https://api.github.com/repos/simp/pupmod-simp-simp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simp/pupmod-simp-simp/labels{/name}","releases_url":"https://api.github.com/repos/simp/pupmod-simp-simp/releases{/id}","deployments_url":"https://api.github.com/repos/simp/pupmod-simp-simp/deployments","created_at":"2015-05-19T09:49:41Z","updated_at":"2018-04-30T15:55:57Z","pushed_at":"2018-04-30T23:51:58Z","git_url":"git://github.com/simp/pupmod-simp-simp.git","ssh_url":"git@github.com:simp/pupmod-simp-simp.git","clone_url":"https://github.com/simp/pupmod-simp-simp.git","svn_url":"https://github.com/simp/pupmod-simp-simp","homepage":null,"size":588,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":18,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/152"},"html":{"href":"https://github.com/simp/pupmod-simp-simp/pull/152"},"issue":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/152"},"comments":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/simp/pupmod-simp-simp/statuses/672ad77bd2e912fb74121cd3213ac2852a44e9c5"}},"author_association":"OWNER"}}
{"actor":{"display_login":"trevor-vaughan"}}