{"action":"created","issue":{"url":"https://api.github.com/repos/funkey/gunpowder/issues/39","repository_url":"https://api.github.com/repos/funkey/gunpowder","labels_url":"https://api.github.com/repos/funkey/gunpowder/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/funkey/gunpowder/issues/39/comments","events_url":"https://api.github.com/repos/funkey/gunpowder/issues/39/events","html_url":"https://github.com/funkey/gunpowder/pull/39","id":376469352,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Njc5NzE2","number":39,"title":"Iterate over keys in request in SimpleAugment","user":{"login":"hanslovsky","id":1086317,"node_id":"MDQ6VXNlcjEwODYzMTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1086317?v=4","gravatar_id":"","url":"https://api.github.com/users/hanslovsky","html_url":"https://github.com/hanslovsky","followers_url":"https://api.github.com/users/hanslovsky/followers","following_url":"https://api.github.com/users/hanslovsky/following{/other_user}","gists_url":"https://api.github.com/users/hanslovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/hanslovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanslovsky/subscriptions","organizations_url":"https://api.github.com/users/hanslovsky/orgs","repos_url":"https://api.github.com/users/hanslovsky/repos","events_url":"https://api.github.com/users/hanslovsky/events{/privacy}","received_events_url":"https://api.github.com/users/hanslovsky/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-01T16:31:57Z","updated_at":"2018-11-02T13:43:28Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/funkey/gunpowder/pulls/39","html_url":"https://github.com/funkey/gunpowder/pull/39","diff_url":"https://github.com/funkey/gunpowder/pull/39.diff","patch_url":"https://github.com/funkey/gunpowder/pull/39.patch"},"body":"Instead of iterating over arrays/points in the batch, iterate over the requested keys.\r\n\r\n - assert that all requested keys are present\r\n - remove keys from batch that were not requested\r\n\r\nFixes #37 \r\n\r\nI didn't test for points as I have no appropriate data set/pipeline."},"comment":{"url":"https://api.github.com/repos/funkey/gunpowder/issues/comments/435384131","html_url":"https://github.com/funkey/gunpowder/pull/39#issuecomment-435384131","issue_url":"https://api.github.com/repos/funkey/gunpowder/issues/39","id":435384131,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTM4NDEzMQ==","user":{"login":"hanslovsky","id":1086317,"node_id":"MDQ6VXNlcjEwODYzMTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1086317?v=4","gravatar_id":"","url":"https://api.github.com/users/hanslovsky","html_url":"https://github.com/hanslovsky","followers_url":"https://api.github.com/users/hanslovsky/followers","following_url":"https://api.github.com/users/hanslovsky/following{/other_user}","gists_url":"https://api.github.com/users/hanslovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/hanslovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanslovsky/subscriptions","organizations_url":"https://api.github.com/users/hanslovsky/orgs","repos_url":"https://api.github.com/users/hanslovsky/repos","events_url":"https://api.github.com/users/hanslovsky/events{/privacy}","received_events_url":"https://api.github.com/users/hanslovsky/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T13:43:28Z","updated_at":"2018-11-02T13:43:28Z","author_association":"NONE","body":"The build failed for python3.5:\r\n```\r\n======================================================================\r\nFAIL: test_output (tests.cases.precache.TestPreCache)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/travis/build/funkey/gunpowder/tests/cases/precache.py\", line 46, in test_output\r\n    self.assertTrue(time.time() - start < 2)\r\nAssertionError: False is not true\r\n```\r\n\r\nThis seems unrelated to my PR. Also, I suggest replacing `self.assertTrue` with [`self.assertLess`](https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertLess):\r\n```python\r\n\"\"\"Just like self.assertTrue(a < b), but with a nicer default message.\"\"\"\r\n```"}}
{"actor":{"display_login":"hanslovsky"}}