{"action":"created","issue":{"url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/issues/176","repository_url":"https://api.github.com/repos/SAFE-Stack/SAFE-template","labels_url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/issues/176/labels{/name}","comments_url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/issues/176/comments","events_url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/issues/176/events","html_url":"https://github.com/SAFE-Stack/SAFE-template/issues/176","id":378066103,"node_id":"MDU6SXNzdWUzNzgwNjYxMDM=","number":176,"title":"Fulma Admin template does not open burger-menu on small screens","user":{"login":"Zaid-Ajaj","id":13316248,"node_id":"MDQ6VXNlcjEzMzE2MjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/13316248?v=4","gravatar_id":"","url":"https://api.github.com/users/Zaid-Ajaj","html_url":"https://github.com/Zaid-Ajaj","followers_url":"https://api.github.com/users/Zaid-Ajaj/followers","following_url":"https://api.github.com/users/Zaid-Ajaj/following{/other_user}","gists_url":"https://api.github.com/users/Zaid-Ajaj/gists{/gist_id}","starred_url":"https://api.github.com/users/Zaid-Ajaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zaid-Ajaj/subscriptions","organizations_url":"https://api.github.com/users/Zaid-Ajaj/orgs","repos_url":"https://api.github.com/users/Zaid-Ajaj/repos","events_url":"https://api.github.com/users/Zaid-Ajaj/events{/privacy}","received_events_url":"https://api.github.com/users/Zaid-Ajaj/received_events","type":"User","site_admin":false},"labels":[{"id":847783412,"node_id":"MDU6TGFiZWw4NDc3ODM0MTI=","url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/labels/Status:%20Available","name":"Status: Available","color":"bfe5bf","default":false},{"id":847783928,"node_id":"MDU6TGFiZWw4NDc3ODM5Mjg=","url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/labels/Type:%20Bug","name":"Type: Bug","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-06T22:44:42Z","updated_at":"2018-12-05T12:41:39Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Clicking on the burger-menu button on small screen does not show the navigation menu\r\n\r\n### Safe template with `--layout fulma-admin` \r\n![fulma-admin-safe](https://user-images.githubusercontent.com/13316248/48098696-c4e3ea00-e21d-11e8-83e4-554e97090f66.gif)\r\n\r\n### Original Bulma Admin template\r\n![fulma-admin-original](https://user-images.githubusercontent.com/13316248/48098711-ca413480-e21d-11e8-81bd-fc2867b10816.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/issues/comments/444471768","html_url":"https://github.com/SAFE-Stack/SAFE-template/issues/176#issuecomment-444471768","issue_url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/issues/176","id":444471768,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDQ3MTc2OA==","user":{"login":"theimowski","id":5909015,"node_id":"MDQ6VXNlcjU5MDkwMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5909015?v=4","gravatar_id":"","url":"https://api.github.com/users/theimowski","html_url":"https://github.com/theimowski","followers_url":"https://api.github.com/users/theimowski/followers","following_url":"https://api.github.com/users/theimowski/following{/other_user}","gists_url":"https://api.github.com/users/theimowski/gists{/gist_id}","starred_url":"https://api.github.com/users/theimowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theimowski/subscriptions","organizations_url":"https://api.github.com/users/theimowski/orgs","repos_url":"https://api.github.com/users/theimowski/repos","events_url":"https://api.github.com/users/theimowski/events{/privacy}","received_events_url":"https://api.github.com/users/theimowski/received_events","type":"User","site_admin":false},"created_at":"2018-12-05T12:41:39Z","updated_at":"2018-12-05T12:41:39Z","author_association":"MEMBER","body":"I've been thinking about this, and came to a conclusion that if we wanted to support that, then we'd ideally implement the burger behaviour via Elmish, which implies new Message just for specific layouts (fulma-admin is not the only one affected).\r\nThis in turn would complicate the template itself, adding another conditions.\r\n\r\nIMO, we should remove the burger altogether from the layouts, and leave it to the user if one wants to add it.\r\n\r\nWe loose consistency with bulma-templates, but gain simplicity which in this case is more important.\r\n@Zaid-Ajaj is this fine with you?"}}
{"actor":{"display_login":"theimowski"}}