{"action":"closed","number":2422,"pull_request":{"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/2422","id":194723025,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzIzMDI1","html_url":"https://github.com/phonegap/phonegap-plugin-push/pull/2422","diff_url":"https://github.com/phonegap/phonegap-plugin-push/pull/2422.diff","patch_url":"https://github.com/phonegap/phonegap-plugin-push/pull/2422.patch","issue_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/2422","number":2422,"state":"closed","locked":false,"title":"v1.x Fixes NotificationChannel error on Android 8.0","user":{"login":"maleriepace","id":1656430,"node_id":"MDQ6VXNlcjE2NTY0MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1656430?v=4","gravatar_id":"","url":"https://api.github.com/users/maleriepace","html_url":"https://github.com/maleriepace","followers_url":"https://api.github.com/users/maleriepace/followers","following_url":"https://api.github.com/users/maleriepace/following{/other_user}","gists_url":"https://api.github.com/users/maleriepace/gists{/gist_id}","starred_url":"https://api.github.com/users/maleriepace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maleriepace/subscriptions","organizations_url":"https://api.github.com/users/maleriepace/orgs","repos_url":"https://api.github.com/users/maleriepace/repos","events_url":"https://api.github.com/users/maleriepace/events{/privacy}","received_events_url":"https://api.github.com/users/maleriepace/received_events","type":"User","site_admin":false},"body":"## Description\r\nAdded a NotificationChannel which is required for GCM push notifications to work on Android 8.0\r\n\r\n## Related Issue\r\n#2421 \r\n\r\n## Motivation and Context\r\nWhen sending a push notification to a device running Android 8.0, the following message was displayed: Developer warning for package \"my-package\". Failed to post notification on channel \"null\". See log for details.'\r\n\r\n## How Has This Been Tested?\r\nI have tested this on Android 8.0 and 7.1 emulators and now correctly receive push notifications\r\n\r\n## Types of changes\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n","created_at":"2018-06-13T21:39:39Z","updated_at":"2018-07-04T01:36:29Z","closed_at":"2018-07-04T01:36:29Z","merged_at":null,"merge_commit_sha":"7e5aa581869a788e2a971a1dc2bc314833a15835","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/2422/commits","review_comments_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/2422/comments","review_comment_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/2422/comments","statuses_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/statuses/c51a0d896365b9aad4f76d2f86d6c5051eeed7de","head":{"label":"Coyote-Logistics:v1.x-Android8.0","ref":"v1.x-Android8.0","sha":"c51a0d896365b9aad4f76d2f86d6c5051eeed7de","user":{"login":"Coyote-Logistics","id":39313088,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzEzMDg4","avatar_url":"https://avatars2.githubusercontent.com/u/39313088?v=4","gravatar_id":"","url":"https://api.github.com/users/Coyote-Logistics","html_url":"https://github.com/Coyote-Logistics","followers_url":"https://api.github.com/users/Coyote-Logistics/followers","following_url":"https://api.github.com/users/Coyote-Logistics/following{/other_user}","gists_url":"https://api.github.com/users/Coyote-Logistics/gists{/gist_id}","starred_url":"https://api.github.com/users/Coyote-Logistics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coyote-Logistics/subscriptions","organizations_url":"https://api.github.com/users/Coyote-Logistics/orgs","repos_url":"https://api.github.com/users/Coyote-Logistics/repos","events_url":"https://api.github.com/users/Coyote-Logistics/events{/privacy}","received_events_url":"https://api.github.com/users/Coyote-Logistics/received_events","type":"Organization","site_admin":false},"repo":{"id":137265329,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyNjUzMjk=","name":"phonegap-plugin-push","full_name":"Coyote-Logistics/phonegap-plugin-push","owner":{"login":"Coyote-Logistics","id":39313088,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzEzMDg4","avatar_url":"https://avatars2.githubusercontent.com/u/39313088?v=4","gravatar_id":"","url":"https://api.github.com/users/Coyote-Logistics","html_url":"https://github.com/Coyote-Logistics","followers_url":"https://api.github.com/users/Coyote-Logistics/followers","following_url":"https://api.github.com/users/Coyote-Logistics/following{/other_user}","gists_url":"https://api.github.com/users/Coyote-Logistics/gists{/gist_id}","starred_url":"https://api.github.com/users/Coyote-Logistics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coyote-Logistics/subscriptions","organizations_url":"https://api.github.com/users/Coyote-Logistics/orgs","repos_url":"https://api.github.com/users/Coyote-Logistics/repos","events_url":"https://api.github.com/users/Coyote-Logistics/events{/privacy}","received_events_url":"https://api.github.com/users/Coyote-Logistics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Coyote-Logistics/phonegap-plugin-push","description":"Register and receive push notifications","fork":true,"url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push","forks_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/forks","keys_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/teams","hooks_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/hooks","issue_events_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/issues/events{/number}","events_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/events","assignees_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/assignees{/user}","branches_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/branches{/branch}","tags_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/tags","blobs_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/statuses/{sha}","languages_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/languages","stargazers_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/stargazers","contributors_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/contributors","subscribers_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/subscribers","subscription_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/subscription","commits_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/contents/{+path}","compare_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/merges","archive_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/downloads","issues_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/issues{/number}","pulls_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/pulls{/number}","milestones_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/milestones{/number}","notifications_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/labels{/name}","releases_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/releases{/id}","deployments_url":"https://api.github.com/repos/Coyote-Logistics/phonegap-plugin-push/deployments","created_at":"2018-06-13T20:10:27Z","updated_at":"2018-06-13T20:10:29Z","pushed_at":"2018-06-13T21:24:46Z","git_url":"git://github.com/Coyote-Logistics/phonegap-plugin-push.git","ssh_url":"git@github.com:Coyote-Logistics/phonegap-plugin-push.git","clone_url":"https://github.com/Coyote-Logistics/phonegap-plugin-push.git","svn_url":"https://github.com/Coyote-Logistics/phonegap-plugin-push","homepage":null,"size":23126,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phonegap:v1.x","ref":"v1.x","sha":"13b8c3a2f1eab3f29b4800a0c6159369d7b9ceca","user":{"login":"phonegap","id":60365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMzY1","avatar_url":"https://avatars0.githubusercontent.com/u/60365?v=4","gravatar_id":"","url":"https://api.github.com/users/phonegap","html_url":"https://github.com/phonegap","followers_url":"https://api.github.com/users/phonegap/followers","following_url":"https://api.github.com/users/phonegap/following{/other_user}","gists_url":"https://api.github.com/users/phonegap/gists{/gist_id}","starred_url":"https://api.github.com/users/phonegap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phonegap/subscriptions","organizations_url":"https://api.github.com/users/phonegap/orgs","repos_url":"https://api.github.com/users/phonegap/repos","events_url":"https://api.github.com/users/phonegap/events{/privacy}","received_events_url":"https://api.github.com/users/phonegap/received_events","type":"Organization","site_admin":false},"repo":{"id":33494287,"node_id":"MDEwOlJlcG9zaXRvcnkzMzQ5NDI4Nw==","name":"phonegap-plugin-push","full_name":"phonegap/phonegap-plugin-push","owner":{"login":"phonegap","id":60365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMzY1","avatar_url":"https://avatars0.githubusercontent.com/u/60365?v=4","gravatar_id":"","url":"https://api.github.com/users/phonegap","html_url":"https://github.com/phonegap","followers_url":"https://api.github.com/users/phonegap/followers","following_url":"https://api.github.com/users/phonegap/following{/other_user}","gists_url":"https://api.github.com/users/phonegap/gists{/gist_id}","starred_url":"https://api.github.com/users/phonegap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phonegap/subscriptions","organizations_url":"https://api.github.com/users/phonegap/orgs","repos_url":"https://api.github.com/users/phonegap/repos","events_url":"https://api.github.com/users/phonegap/events{/privacy}","received_events_url":"https://api.github.com/users/phonegap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phonegap/phonegap-plugin-push","description":"Register and receive push notifications","fork":false,"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push","forks_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/forks","keys_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/teams","hooks_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/hooks","issue_events_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/events{/number}","events_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/events","assignees_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/assignees{/user}","branches_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/branches{/branch}","tags_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/tags","blobs_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/statuses/{sha}","languages_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/languages","stargazers_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/stargazers","contributors_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/contributors","subscribers_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/subscribers","subscription_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/subscription","commits_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/contents/{+path}","compare_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/merges","archive_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/downloads","issues_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues{/number}","pulls_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls{/number}","milestones_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/milestones{/number}","notifications_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/labels{/name}","releases_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/releases{/id}","deployments_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/deployments","created_at":"2015-04-06T17:13:51Z","updated_at":"2018-07-04T00:21:11Z","pushed_at":"2018-07-03T20:48:15Z","git_url":"git://github.com/phonegap/phonegap-plugin-push.git","ssh_url":"git@github.com:phonegap/phonegap-plugin-push.git","clone_url":"https://github.com/phonegap/phonegap-plugin-push.git","svn_url":"https://github.com/phonegap/phonegap-plugin-push","homepage":null,"size":23179,"stargazers_count":1709,"watchers_count":1709,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1146,"mirror_url":null,"archived":false,"open_issues_count":185,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1146,"open_issues":185,"watchers":1709,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/2422"},"html":{"href":"https://github.com/phonegap/phonegap-plugin-push/pull/2422"},"issue":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/2422"},"comments":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/2422/comments"},"review_comments":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/2422/comments"},"review_comment":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/2422/commits"},"statuses":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/statuses/c51a0d896365b9aad4f76d2f86d6c5051eeed7de"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":12,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"macdonst"}}