{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/213169234","pull_request_review_id":149947612,"id":213169234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzE2OTIzNA==","diff_hunk":"@@ -95,17 +95,17 @@ protected override async Task InitializeAsync(CancellationToken cancellationToke\n                 Workspace.AdviseSolutionEvents(solution);\n             }\n \n-            LoadComponentsInUIContextOnceSolutionFullyLoaded(cancellationToken);\n+            await LoadComponentsInUIContextOnceSolutionFullyLoadedAsync(cancellationToken);\n         }\n \n-        protected override void LoadComponentsInUIContext(CancellationToken cancellationToken)\n+        protected override async Task LoadComponentsInUIContextAsync(CancellationToken cancellationToken)\n         {\n             ForegroundObject.AssertIsForeground();","path":"src/VisualStudio/Core/Def/Implementation/LanguageService/AbstractPackage`2.cs","position":11,"original_position":11,"commit_id":"127b299f4a8affb107ea3d7a76f0d6b938d884ce","original_commit_id":"127b299f4a8affb107ea3d7a76f0d6b938d884ce","user":{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"body":"❗️ Don't call `AssertIsForeground` in an asynchronous method. Instance, use `SwitchToMainThreadAsync` to switch to the main thread if needed (the switch is a NOP if the code is already on the main thread).\r\n\r\n:memo: This appears a few times in this pull request, but I only commented on it here.","created_at":"2018-08-28T02:32:31Z","updated_at":"2018-08-28T02:33:45Z","html_url":"https://github.com/dotnet/roslyn/pull/29560#discussion_r213169234","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29560","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/213169234"},"html":{"href":"https://github.com/dotnet/roslyn/pull/29560#discussion_r213169234"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29560"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/29560","id":211265718,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjY1NzE4","html_url":"https://github.com/dotnet/roslyn/pull/29560","diff_url":"https://github.com/dotnet/roslyn/pull/29560.diff","patch_url":"https://github.com/dotnet/roslyn/pull/29560.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/29560","number":29560,"state":"open","locked":false,"title":"for personal review only","user":{"login":"JieCarolHu","id":17056651,"node_id":"MDQ6VXNlcjE3MDU2NjUx","avatar_url":"https://avatars1.githubusercontent.com/u/17056651?v=4","gravatar_id":"","url":"https://api.github.com/users/JieCarolHu","html_url":"https://github.com/JieCarolHu","followers_url":"https://api.github.com/users/JieCarolHu/followers","following_url":"https://api.github.com/users/JieCarolHu/following{/other_user}","gists_url":"https://api.github.com/users/JieCarolHu/gists{/gist_id}","starred_url":"https://api.github.com/users/JieCarolHu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieCarolHu/subscriptions","organizations_url":"https://api.github.com/users/JieCarolHu/orgs","repos_url":"https://api.github.com/users/JieCarolHu/repos","events_url":"https://api.github.com/users/JieCarolHu/events{/privacy}","received_events_url":"https://api.github.com/users/JieCarolHu/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-28T00:10:08Z","updated_at":"2018-08-28T02:33:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"121114299087e916aa98b418a2ab2bbfdd0211d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":278927730,"node_id":"MDU6TGFiZWwyNzg5Mjc3MzA=","url":"https://api.github.com/repos/dotnet/roslyn/labels/PR%20For%20Personal%20Review%20Only","name":"PR For Personal Review Only","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29560/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29560/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/29560/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/127b299f4a8affb107ea3d7a76f0d6b938d884ce","head":{"label":"JieCarolHu:vso639092B","ref":"vso639092B","sha":"127b299f4a8affb107ea3d7a76f0d6b938d884ce","user":{"login":"JieCarolHu","id":17056651,"node_id":"MDQ6VXNlcjE3MDU2NjUx","avatar_url":"https://avatars1.githubusercontent.com/u/17056651?v=4","gravatar_id":"","url":"https://api.github.com/users/JieCarolHu","html_url":"https://github.com/JieCarolHu","followers_url":"https://api.github.com/users/JieCarolHu/followers","following_url":"https://api.github.com/users/JieCarolHu/following{/other_user}","gists_url":"https://api.github.com/users/JieCarolHu/gists{/gist_id}","starred_url":"https://api.github.com/users/JieCarolHu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieCarolHu/subscriptions","organizations_url":"https://api.github.com/users/JieCarolHu/orgs","repos_url":"https://api.github.com/users/JieCarolHu/repos","events_url":"https://api.github.com/users/JieCarolHu/events{/privacy}","received_events_url":"https://api.github.com/users/JieCarolHu/received_events","type":"User","site_admin":false},"repo":{"id":117298628,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcyOTg2Mjg=","name":"roslyn","full_name":"JieCarolHu/roslyn","owner":{"login":"JieCarolHu","id":17056651,"node_id":"MDQ6VXNlcjE3MDU2NjUx","avatar_url":"https://avatars1.githubusercontent.com/u/17056651?v=4","gravatar_id":"","url":"https://api.github.com/users/JieCarolHu","html_url":"https://github.com/JieCarolHu","followers_url":"https://api.github.com/users/JieCarolHu/followers","following_url":"https://api.github.com/users/JieCarolHu/following{/other_user}","gists_url":"https://api.github.com/users/JieCarolHu/gists{/gist_id}","starred_url":"https://api.github.com/users/JieCarolHu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieCarolHu/subscriptions","organizations_url":"https://api.github.com/users/JieCarolHu/orgs","repos_url":"https://api.github.com/users/JieCarolHu/repos","events_url":"https://api.github.com/users/JieCarolHu/events{/privacy}","received_events_url":"https://api.github.com/users/JieCarolHu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JieCarolHu/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/JieCarolHu/roslyn","forks_url":"https://api.github.com/repos/JieCarolHu/roslyn/forks","keys_url":"https://api.github.com/repos/JieCarolHu/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JieCarolHu/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JieCarolHu/roslyn/teams","hooks_url":"https://api.github.com/repos/JieCarolHu/roslyn/hooks","issue_events_url":"https://api.github.com/repos/JieCarolHu/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/JieCarolHu/roslyn/events","assignees_url":"https://api.github.com/repos/JieCarolHu/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/JieCarolHu/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/JieCarolHu/roslyn/tags","blobs_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JieCarolHu/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/JieCarolHu/roslyn/languages","stargazers_url":"https://api.github.com/repos/JieCarolHu/roslyn/stargazers","contributors_url":"https://api.github.com/repos/JieCarolHu/roslyn/contributors","subscribers_url":"https://api.github.com/repos/JieCarolHu/roslyn/subscribers","subscription_url":"https://api.github.com/repos/JieCarolHu/roslyn/subscription","commits_url":"https://api.github.com/repos/JieCarolHu/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/JieCarolHu/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/JieCarolHu/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/JieCarolHu/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/JieCarolHu/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JieCarolHu/roslyn/merges","archive_url":"https://api.github.com/repos/JieCarolHu/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JieCarolHu/roslyn/downloads","issues_url":"https://api.github.com/repos/JieCarolHu/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/JieCarolHu/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/JieCarolHu/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/JieCarolHu/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JieCarolHu/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/JieCarolHu/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/JieCarolHu/roslyn/deployments","created_at":"2018-01-12T23:44:20Z","updated_at":"2018-01-12T23:45:01Z","pushed_at":"2018-08-27T23:11:26Z","git_url":"git://github.com/JieCarolHu/roslyn.git","ssh_url":"git@github.com:JieCarolHu/roslyn.git","clone_url":"https://github.com/JieCarolHu/roslyn.git","svn_url":"https://github.com/JieCarolHu/roslyn","homepage":"","size":379527,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"8a34dfb2e06bdb4807c82419b5bb36e692967139","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-08-27T22:19:05Z","pushed_at":"2018-08-28T01:46:00Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":438417,"stargazers_count":9759,"watchers_count":9759,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2321,"mirror_url":null,"archived":false,"open_issues_count":5105,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2321,"open_issues":5105,"watchers":9759,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29560"},"html":{"href":"https://github.com/dotnet/roslyn/pull/29560"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/29560"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/29560/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29560/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29560/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/127b299f4a8affb107ea3d7a76f0d6b938d884ce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sharwell"}}