{"action":"closed","number":37,"pull_request":{"url":"https://api.github.com/repos/safex/safexcore/pulls/37","id":211732998,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzMyOTk4","html_url":"https://github.com/safex/safexcore/pull/37","diff_url":"https://github.com/safex/safexcore/pull/37.diff","patch_url":"https://github.com/safex/safexcore/pull/37.patch","issue_url":"https://api.github.com/repos/safex/safexcore/issues/37","number":37,"state":"closed","locked":false,"title":"XMR Batch of Changes #2","user":{"login":"zarnoevic","id":25465258,"node_id":"MDQ6VXNlcjI1NDY1MjU4","avatar_url":"https://avatars2.githubusercontent.com/u/25465258?v=4","gravatar_id":"","url":"https://api.github.com/users/zarnoevic","html_url":"https://github.com/zarnoevic","followers_url":"https://api.github.com/users/zarnoevic/followers","following_url":"https://api.github.com/users/zarnoevic/following{/other_user}","gists_url":"https://api.github.com/users/zarnoevic/gists{/gist_id}","starred_url":"https://api.github.com/users/zarnoevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarnoevic/subscriptions","organizations_url":"https://api.github.com/users/zarnoevic/orgs","repos_url":"https://api.github.com/users/zarnoevic/repos","events_url":"https://api.github.com/users/zarnoevic/events{/privacy}","received_events_url":"https://api.github.com/users/zarnoevic/received_events","type":"User","site_admin":false},"body":"It is confirmed that this merge would not result in additional tests failure.\r\nYou can see the tests log here:\r\n\r\nhttps://github.com/zarnoevic/safexcore/tree/50dd1f3c6d3a5a03e4714a0c05296e6fee12327d\r\n\r\nYou can see the process used for selecting and integrating these changes here:\r\nhttps://github.com/zarnoevic/safexcore/blob/update_methodology/Updating%20Safex%20from%20Monero.pdf\r\n\r\nMatching internal document describing the same process:\r\nhttps://safexdevs.atlassian.net/wiki/spaces/SM/pages/8388611/Updating+Safex+from+Monero\r\n","created_at":"2018-08-29T12:21:08Z","updated_at":"2018-08-30T11:05:42Z","closed_at":"2018-08-30T11:05:42Z","merged_at":null,"merge_commit_sha":"edc7fdcca3c707af598625c82d9496f2161b7771","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ddabek","id":10568692,"node_id":"MDQ6VXNlcjEwNTY4Njky","avatar_url":"https://avatars2.githubusercontent.com/u/10568692?v=4","gravatar_id":"","url":"https://api.github.com/users/ddabek","html_url":"https://github.com/ddabek","followers_url":"https://api.github.com/users/ddabek/followers","following_url":"https://api.github.com/users/ddabek/following{/other_user}","gists_url":"https://api.github.com/users/ddabek/gists{/gist_id}","starred_url":"https://api.github.com/users/ddabek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddabek/subscriptions","organizations_url":"https://api.github.com/users/ddabek/orgs","repos_url":"https://api.github.com/users/ddabek/repos","events_url":"https://api.github.com/users/ddabek/events{/privacy}","received_events_url":"https://api.github.com/users/ddabek/received_events","type":"User","site_admin":false},{"login":"atanmarko","id":12594650,"node_id":"MDQ6VXNlcjEyNTk0NjUw","avatar_url":"https://avatars2.githubusercontent.com/u/12594650?v=4","gravatar_id":"","url":"https://api.github.com/users/atanmarko","html_url":"https://github.com/atanmarko","followers_url":"https://api.github.com/users/atanmarko/followers","following_url":"https://api.github.com/users/atanmarko/following{/other_user}","gists_url":"https://api.github.com/users/atanmarko/gists{/gist_id}","starred_url":"https://api.github.com/users/atanmarko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atanmarko/subscriptions","organizations_url":"https://api.github.com/users/atanmarko/orgs","repos_url":"https://api.github.com/users/atanmarko/repos","events_url":"https://api.github.com/users/atanmarko/events{/privacy}","received_events_url":"https://api.github.com/users/atanmarko/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/safex/safexcore/pulls/37/commits","review_comments_url":"https://api.github.com/repos/safex/safexcore/pulls/37/comments","review_comment_url":"https://api.github.com/repos/safex/safexcore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/safex/safexcore/issues/37/comments","statuses_url":"https://api.github.com/repos/safex/safexcore/statuses/9c07668081372036c9436d1352c23a071065493e","head":{"label":"zarnoevic:xmr_batch_2","ref":"xmr_batch_2","sha":"9c07668081372036c9436d1352c23a071065493e","user":{"login":"zarnoevic","id":25465258,"node_id":"MDQ6VXNlcjI1NDY1MjU4","avatar_url":"https://avatars2.githubusercontent.com/u/25465258?v=4","gravatar_id":"","url":"https://api.github.com/users/zarnoevic","html_url":"https://github.com/zarnoevic","followers_url":"https://api.github.com/users/zarnoevic/followers","following_url":"https://api.github.com/users/zarnoevic/following{/other_user}","gists_url":"https://api.github.com/users/zarnoevic/gists{/gist_id}","starred_url":"https://api.github.com/users/zarnoevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarnoevic/subscriptions","organizations_url":"https://api.github.com/users/zarnoevic/orgs","repos_url":"https://api.github.com/users/zarnoevic/repos","events_url":"https://api.github.com/users/zarnoevic/events{/privacy}","received_events_url":"https://api.github.com/users/zarnoevic/received_events","type":"User","site_admin":false},"repo":{"id":143154648,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxNTQ2NDg=","name":"safexcore","full_name":"zarnoevic/safexcore","owner":{"login":"zarnoevic","id":25465258,"node_id":"MDQ6VXNlcjI1NDY1MjU4","avatar_url":"https://avatars2.githubusercontent.com/u/25465258?v=4","gravatar_id":"","url":"https://api.github.com/users/zarnoevic","html_url":"https://github.com/zarnoevic","followers_url":"https://api.github.com/users/zarnoevic/followers","following_url":"https://api.github.com/users/zarnoevic/following{/other_user}","gists_url":"https://api.github.com/users/zarnoevic/gists{/gist_id}","starred_url":"https://api.github.com/users/zarnoevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarnoevic/subscriptions","organizations_url":"https://api.github.com/users/zarnoevic/orgs","repos_url":"https://api.github.com/users/zarnoevic/repos","events_url":"https://api.github.com/users/zarnoevic/events{/privacy}","received_events_url":"https://api.github.com/users/zarnoevic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zarnoevic/safexcore","description":"reference implementation of Safex Blockchain in C++ ","fork":true,"url":"https://api.github.com/repos/zarnoevic/safexcore","forks_url":"https://api.github.com/repos/zarnoevic/safexcore/forks","keys_url":"https://api.github.com/repos/zarnoevic/safexcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zarnoevic/safexcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zarnoevic/safexcore/teams","hooks_url":"https://api.github.com/repos/zarnoevic/safexcore/hooks","issue_events_url":"https://api.github.com/repos/zarnoevic/safexcore/issues/events{/number}","events_url":"https://api.github.com/repos/zarnoevic/safexcore/events","assignees_url":"https://api.github.com/repos/zarnoevic/safexcore/assignees{/user}","branches_url":"https://api.github.com/repos/zarnoevic/safexcore/branches{/branch}","tags_url":"https://api.github.com/repos/zarnoevic/safexcore/tags","blobs_url":"https://api.github.com/repos/zarnoevic/safexcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zarnoevic/safexcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zarnoevic/safexcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/zarnoevic/safexcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zarnoevic/safexcore/statuses/{sha}","languages_url":"https://api.github.com/repos/zarnoevic/safexcore/languages","stargazers_url":"https://api.github.com/repos/zarnoevic/safexcore/stargazers","contributors_url":"https://api.github.com/repos/zarnoevic/safexcore/contributors","subscribers_url":"https://api.github.com/repos/zarnoevic/safexcore/subscribers","subscription_url":"https://api.github.com/repos/zarnoevic/safexcore/subscription","commits_url":"https://api.github.com/repos/zarnoevic/safexcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/zarnoevic/safexcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/zarnoevic/safexcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/zarnoevic/safexcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/zarnoevic/safexcore/contents/{+path}","compare_url":"https://api.github.com/repos/zarnoevic/safexcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zarnoevic/safexcore/merges","archive_url":"https://api.github.com/repos/zarnoevic/safexcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zarnoevic/safexcore/downloads","issues_url":"https://api.github.com/repos/zarnoevic/safexcore/issues{/number}","pulls_url":"https://api.github.com/repos/zarnoevic/safexcore/pulls{/number}","milestones_url":"https://api.github.com/repos/zarnoevic/safexcore/milestones{/number}","notifications_url":"https://api.github.com/repos/zarnoevic/safexcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zarnoevic/safexcore/labels{/name}","releases_url":"https://api.github.com/repos/zarnoevic/safexcore/releases{/id}","deployments_url":"https://api.github.com/repos/zarnoevic/safexcore/deployments","created_at":"2018-08-01T12:43:39Z","updated_at":"2018-08-08T12:45:32Z","pushed_at":"2018-08-30T11:00:06Z","git_url":"git://github.com/zarnoevic/safexcore.git","ssh_url":"git@github.com:zarnoevic/safexcore.git","clone_url":"https://github.com/zarnoevic/safexcore.git","svn_url":"https://github.com/zarnoevic/safexcore","homepage":null,"size":144100,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"safex:develop","ref":"develop","sha":"2810f2b44d7c3f96b8b4f7f827ff4dde1a27cd19","user":{"login":"safex","id":12075405,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDc1NDA1","avatar_url":"https://avatars0.githubusercontent.com/u/12075405?v=4","gravatar_id":"","url":"https://api.github.com/users/safex","html_url":"https://github.com/safex","followers_url":"https://api.github.com/users/safex/followers","following_url":"https://api.github.com/users/safex/following{/other_user}","gists_url":"https://api.github.com/users/safex/gists{/gist_id}","starred_url":"https://api.github.com/users/safex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safex/subscriptions","organizations_url":"https://api.github.com/users/safex/orgs","repos_url":"https://api.github.com/users/safex/repos","events_url":"https://api.github.com/users/safex/events{/privacy}","received_events_url":"https://api.github.com/users/safex/received_events","type":"Organization","site_admin":false},"repo":{"id":140000115,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMDAxMTU=","name":"safexcore","full_name":"safex/safexcore","owner":{"login":"safex","id":12075405,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDc1NDA1","avatar_url":"https://avatars0.githubusercontent.com/u/12075405?v=4","gravatar_id":"","url":"https://api.github.com/users/safex","html_url":"https://github.com/safex","followers_url":"https://api.github.com/users/safex/followers","following_url":"https://api.github.com/users/safex/following{/other_user}","gists_url":"https://api.github.com/users/safex/gists{/gist_id}","starred_url":"https://api.github.com/users/safex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safex/subscriptions","organizations_url":"https://api.github.com/users/safex/orgs","repos_url":"https://api.github.com/users/safex/repos","events_url":"https://api.github.com/users/safex/events{/privacy}","received_events_url":"https://api.github.com/users/safex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/safex/safexcore","description":"reference implementation of Safex Blockchain in C++ ","fork":false,"url":"https://api.github.com/repos/safex/safexcore","forks_url":"https://api.github.com/repos/safex/safexcore/forks","keys_url":"https://api.github.com/repos/safex/safexcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/safex/safexcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/safex/safexcore/teams","hooks_url":"https://api.github.com/repos/safex/safexcore/hooks","issue_events_url":"https://api.github.com/repos/safex/safexcore/issues/events{/number}","events_url":"https://api.github.com/repos/safex/safexcore/events","assignees_url":"https://api.github.com/repos/safex/safexcore/assignees{/user}","branches_url":"https://api.github.com/repos/safex/safexcore/branches{/branch}","tags_url":"https://api.github.com/repos/safex/safexcore/tags","blobs_url":"https://api.github.com/repos/safex/safexcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/safex/safexcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/safex/safexcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/safex/safexcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/safex/safexcore/statuses/{sha}","languages_url":"https://api.github.com/repos/safex/safexcore/languages","stargazers_url":"https://api.github.com/repos/safex/safexcore/stargazers","contributors_url":"https://api.github.com/repos/safex/safexcore/contributors","subscribers_url":"https://api.github.com/repos/safex/safexcore/subscribers","subscription_url":"https://api.github.com/repos/safex/safexcore/subscription","commits_url":"https://api.github.com/repos/safex/safexcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/safex/safexcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/safex/safexcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/safex/safexcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/safex/safexcore/contents/{+path}","compare_url":"https://api.github.com/repos/safex/safexcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/safex/safexcore/merges","archive_url":"https://api.github.com/repos/safex/safexcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/safex/safexcore/downloads","issues_url":"https://api.github.com/repos/safex/safexcore/issues{/number}","pulls_url":"https://api.github.com/repos/safex/safexcore/pulls{/number}","milestones_url":"https://api.github.com/repos/safex/safexcore/milestones{/number}","notifications_url":"https://api.github.com/repos/safex/safexcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/safex/safexcore/labels{/name}","releases_url":"https://api.github.com/repos/safex/safexcore/releases{/id}","deployments_url":"https://api.github.com/repos/safex/safexcore/deployments","created_at":"2018-07-06T15:16:24Z","updated_at":"2018-08-22T12:04:48Z","pushed_at":"2018-08-30T10:09:22Z","git_url":"git://github.com/safex/safexcore.git","ssh_url":"git@github.com:safex/safexcore.git","clone_url":"https://github.com/safex/safexcore.git","svn_url":"https://github.com/safex/safexcore","homepage":null,"size":7872,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/safex/safexcore/pulls/37"},"html":{"href":"https://github.com/safex/safexcore/pull/37"},"issue":{"href":"https://api.github.com/repos/safex/safexcore/issues/37"},"comments":{"href":"https://api.github.com/repos/safex/safexcore/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/safex/safexcore/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/safex/safexcore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/safex/safexcore/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/safex/safexcore/statuses/9c07668081372036c9436d1352c23a071065493e"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":10,"additions":200,"deletions":22,"changed_files":8}}
{"actor":{"display_login":"zarnoevic"}}