{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments/172026972","pull_request_review_id":100985239,"id":172026972,"diff_hunk":"@@ -80,4 +82,20 @@ - (void)testFarScrollToVisible\n   FBAssertVisibleCell(cellName);\n }\n \n+- (void)testAttributeWithNullScrollToVisible\n+{\n+  NSError *error;\n+  NSArray<XCUIElement *> *queryMatches = [self.testedApplication fb_descendantsMatchingClassChain:@\"XCUIElementTypeWindow[1]/XCUIElementTypeOther[1]/XCUIElementTypeOther[1]/XCUIElementTypeOther[1]/XCUIElementTypeTable[1]/XCUIElementTypeCell[60]\" shouldReturnAfterFirstMatch:NO];","path":"WebDriverAgentTests/IntegrationTests/FBScrollingTests.m","position":25,"original_position":25,"commit_id":"725785d1c88da6b89abc635649e6385c36359488","original_commit_id":"725785d1c88da6b89abc635649e6385c36359488","user":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"body":"this class chain can be replaced with `**/XCUIElementTypeTable/XCUIElementTypeCell[60]`","created_at":"2018-03-03T20:05:11Z","updated_at":"2018-03-03T20:05:11Z","html_url":"https://github.com/facebook/WebDriverAgent/pull/879#discussion_r172026972","pull_request_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/879","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments/172026972"},"html":{"href":"https://github.com/facebook/WebDriverAgent/pull/879#discussion_r172026972"},"pull_request":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/879"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/879","id":172671014,"html_url":"https://github.com/facebook/WebDriverAgent/pull/879","diff_url":"https://github.com/facebook/WebDriverAgent/pull/879.diff","patch_url":"https://github.com/facebook/WebDriverAgent/pull/879.patch","issue_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/879","number":879,"state":"open","locked":false,"title":"Fix fb_framelessFuzzyMatchesElement method","user":{"login":"lingtingSir","id":10089068,"avatar_url":"https://avatars0.githubusercontent.com/u/10089068?v=4","gravatar_id":"","url":"https://api.github.com/users/lingtingSir","html_url":"https://github.com/lingtingSir","followers_url":"https://api.github.com/users/lingtingSir/followers","following_url":"https://api.github.com/users/lingtingSir/following{/other_user}","gists_url":"https://api.github.com/users/lingtingSir/gists{/gist_id}","starred_url":"https://api.github.com/users/lingtingSir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingtingSir/subscriptions","organizations_url":"https://api.github.com/users/lingtingSir/orgs","repos_url":"https://api.github.com/users/lingtingSir/repos","events_url":"https://api.github.com/users/lingtingSir/events{/privacy}","received_events_url":"https://api.github.com/users/lingtingSir/received_events","type":"User","site_admin":false},"body":"In XCUIElementTypeTable,attribute values of many XCUIElementTypeCell\ninstances are null.When fb_scrollToVisibleWithNormalizedScrollDistance\nfunction is called by XCUIElementTypeCell instance,it is unable to\naccurately slide the specified UI element.","created_at":"2018-03-03T15:03:36Z","updated_at":"2018-03-03T20:05:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b91d75d35b72802f4a6ab8981ab73a95a539d6e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":255940325,"url":"https://api.github.com/repos/facebook/WebDriverAgent/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/879/commits","review_comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/879/comments","review_comment_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/879/comments","statuses_url":"https://api.github.com/repos/facebook/WebDriverAgent/statuses/725785d1c88da6b89abc635649e6385c36359488","head":{"label":"lingtingSir:master","ref":"master","sha":"725785d1c88da6b89abc635649e6385c36359488","user":{"login":"lingtingSir","id":10089068,"avatar_url":"https://avatars0.githubusercontent.com/u/10089068?v=4","gravatar_id":"","url":"https://api.github.com/users/lingtingSir","html_url":"https://github.com/lingtingSir","followers_url":"https://api.github.com/users/lingtingSir/followers","following_url":"https://api.github.com/users/lingtingSir/following{/other_user}","gists_url":"https://api.github.com/users/lingtingSir/gists{/gist_id}","starred_url":"https://api.github.com/users/lingtingSir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingtingSir/subscriptions","organizations_url":"https://api.github.com/users/lingtingSir/orgs","repos_url":"https://api.github.com/users/lingtingSir/repos","events_url":"https://api.github.com/users/lingtingSir/events{/privacy}","received_events_url":"https://api.github.com/users/lingtingSir/received_events","type":"User","site_admin":false},"repo":{"id":123698427,"name":"WebDriverAgent","full_name":"lingtingSir/WebDriverAgent","owner":{"login":"lingtingSir","id":10089068,"avatar_url":"https://avatars0.githubusercontent.com/u/10089068?v=4","gravatar_id":"","url":"https://api.github.com/users/lingtingSir","html_url":"https://github.com/lingtingSir","followers_url":"https://api.github.com/users/lingtingSir/followers","following_url":"https://api.github.com/users/lingtingSir/following{/other_user}","gists_url":"https://api.github.com/users/lingtingSir/gists{/gist_id}","starred_url":"https://api.github.com/users/lingtingSir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingtingSir/subscriptions","organizations_url":"https://api.github.com/users/lingtingSir/orgs","repos_url":"https://api.github.com/users/lingtingSir/repos","events_url":"https://api.github.com/users/lingtingSir/events{/privacy}","received_events_url":"https://api.github.com/users/lingtingSir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lingtingSir/WebDriverAgent","description":"A WebDriver server for iOS that runs inside the Simulator.","fork":true,"url":"https://api.github.com/repos/lingtingSir/WebDriverAgent","forks_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/forks","keys_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/teams","hooks_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/hooks","issue_events_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/issues/events{/number}","events_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/events","assignees_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/assignees{/user}","branches_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/branches{/branch}","tags_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/tags","blobs_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/languages","stargazers_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/stargazers","contributors_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/contributors","subscribers_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/subscribers","subscription_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/subscription","commits_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/contents/{+path}","compare_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/merges","archive_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/downloads","issues_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/issues{/number}","pulls_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/labels{/name}","releases_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/releases{/id}","deployments_url":"https://api.github.com/repos/lingtingSir/WebDriverAgent/deployments","created_at":"2018-03-03T14:19:00Z","updated_at":"2018-03-03T14:19:03Z","pushed_at":"2018-03-03T15:03:33Z","git_url":"git://github.com/lingtingSir/WebDriverAgent.git","ssh_url":"git@github.com:lingtingSir/WebDriverAgent.git","clone_url":"https://github.com/lingtingSir/WebDriverAgent.git","svn_url":"https://github.com/lingtingSir/WebDriverAgent","homepage":null,"size":15904,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"20246d3e3f1fd26a9579664a696206139d8615cd","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":41855272,"name":"WebDriverAgent","full_name":"facebook/WebDriverAgent","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/WebDriverAgent","description":"A WebDriver server for iOS that runs inside the Simulator.","fork":false,"url":"https://api.github.com/repos/facebook/WebDriverAgent","forks_url":"https://api.github.com/repos/facebook/WebDriverAgent/forks","keys_url":"https://api.github.com/repos/facebook/WebDriverAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/WebDriverAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/WebDriverAgent/teams","hooks_url":"https://api.github.com/repos/facebook/WebDriverAgent/hooks","issue_events_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/WebDriverAgent/events","assignees_url":"https://api.github.com/repos/facebook/WebDriverAgent/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/WebDriverAgent/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/WebDriverAgent/tags","blobs_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/WebDriverAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/WebDriverAgent/languages","stargazers_url":"https://api.github.com/repos/facebook/WebDriverAgent/stargazers","contributors_url":"https://api.github.com/repos/facebook/WebDriverAgent/contributors","subscribers_url":"https://api.github.com/repos/facebook/WebDriverAgent/subscribers","subscription_url":"https://api.github.com/repos/facebook/WebDriverAgent/subscription","commits_url":"https://api.github.com/repos/facebook/WebDriverAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/WebDriverAgent/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/WebDriverAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/WebDriverAgent/merges","archive_url":"https://api.github.com/repos/facebook/WebDriverAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/WebDriverAgent/downloads","issues_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/WebDriverAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/WebDriverAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/WebDriverAgent/labels{/name}","releases_url":"https://api.github.com/repos/facebook/WebDriverAgent/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/WebDriverAgent/deployments","created_at":"2015-09-03T11:00:00Z","updated_at":"2018-03-03T12:29:17Z","pushed_at":"2018-03-03T15:03:37Z","git_url":"git://github.com/facebook/WebDriverAgent.git","ssh_url":"git@github.com:facebook/WebDriverAgent.git","clone_url":"https://github.com/facebook/WebDriverAgent.git","svn_url":"https://github.com/facebook/WebDriverAgent","homepage":null,"size":15902,"stargazers_count":2600,"watchers_count":2600,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":507,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":507,"open_issues":44,"watchers":2600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/879"},"html":{"href":"https://github.com/facebook/WebDriverAgent/pull/879"},"issue":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/issues/879"},"comments":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/issues/879/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/879/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/879/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/statuses/725785d1c88da6b89abc635649e6385c36359488"}},"author_association":"NONE"}}
{"actor":{"display_login":"mykola-mokhnach"}}