{"action":"created","issue":{"url":"https://api.github.com/repos/oppia/oppia/issues/5471","repository_url":"https://api.github.com/repos/oppia/oppia","labels_url":"https://api.github.com/repos/oppia/oppia/issues/5471/labels{/name}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5471/comments","events_url":"https://api.github.com/repos/oppia/oppia/issues/5471/events","html_url":"https://github.com/oppia/oppia/pull/5471","id":348952560,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTgzODI5","number":5471,"title":"Fix #4231: override modal-open to fix not scrolling bug in editor tab","user":{"login":"unit-00","id":10623811,"node_id":"MDQ6VXNlcjEwNjIzODEx","avatar_url":"https://avatars3.githubusercontent.com/u/10623811?v=4","gravatar_id":"","url":"https://api.github.com/users/unit-00","html_url":"https://github.com/unit-00","followers_url":"https://api.github.com/users/unit-00/followers","following_url":"https://api.github.com/users/unit-00/following{/other_user}","gists_url":"https://api.github.com/users/unit-00/gists{/gist_id}","starred_url":"https://api.github.com/users/unit-00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unit-00/subscriptions","organizations_url":"https://api.github.com/users/unit-00/orgs","repos_url":"https://api.github.com/users/unit-00/repos","events_url":"https://api.github.com/users/unit-00/events{/privacy}","received_events_url":"https://api.github.com/users/unit-00/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"prasanna08","id":8678373,"node_id":"MDQ6VXNlcjg2NzgzNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/8678373?v=4","gravatar_id":"","url":"https://api.github.com/users/prasanna08","html_url":"https://github.com/prasanna08","followers_url":"https://api.github.com/users/prasanna08/followers","following_url":"https://api.github.com/users/prasanna08/following{/other_user}","gists_url":"https://api.github.com/users/prasanna08/gists{/gist_id}","starred_url":"https://api.github.com/users/prasanna08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasanna08/subscriptions","organizations_url":"https://api.github.com/users/prasanna08/orgs","repos_url":"https://api.github.com/users/prasanna08/repos","events_url":"https://api.github.com/users/prasanna08/events{/privacy}","received_events_url":"https://api.github.com/users/prasanna08/received_events","type":"User","site_admin":false},"assignees":[{"login":"prasanna08","id":8678373,"node_id":"MDQ6VXNlcjg2NzgzNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/8678373?v=4","gravatar_id":"","url":"https://api.github.com/users/prasanna08","html_url":"https://github.com/prasanna08","followers_url":"https://api.github.com/users/prasanna08/followers","following_url":"https://api.github.com/users/prasanna08/following{/other_user}","gists_url":"https://api.github.com/users/prasanna08/gists{/gist_id}","starred_url":"https://api.github.com/users/prasanna08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasanna08/subscriptions","organizations_url":"https://api.github.com/users/prasanna08/orgs","repos_url":"https://api.github.com/users/prasanna08/repos","events_url":"https://api.github.com/users/prasanna08/events{/privacy}","received_events_url":"https://api.github.com/users/prasanna08/received_events","type":"User","site_admin":false},{"login":"vibhor98","id":26625980,"node_id":"MDQ6VXNlcjI2NjI1OTgw","avatar_url":"https://avatars3.githubusercontent.com/u/26625980?v=4","gravatar_id":"","url":"https://api.github.com/users/vibhor98","html_url":"https://github.com/vibhor98","followers_url":"https://api.github.com/users/vibhor98/followers","following_url":"https://api.github.com/users/vibhor98/following{/other_user}","gists_url":"https://api.github.com/users/vibhor98/gists{/gist_id}","starred_url":"https://api.github.com/users/vibhor98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vibhor98/subscriptions","organizations_url":"https://api.github.com/users/vibhor98/orgs","repos_url":"https://api.github.com/users/vibhor98/repos","events_url":"https://api.github.com/users/vibhor98/events{/privacy}","received_events_url":"https://api.github.com/users/vibhor98/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-08-09T02:06:45Z","updated_at":"2018-08-10T09:18:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5471","html_url":"https://github.com/oppia/oppia/pull/5471","diff_url":"https://github.com/oppia/oppia/pull/5471.diff","patch_url":"https://github.com/oppia/oppia/pull/5471.patch"},"body":"<!--\r\n  - Thanks for submitting code to Oppia! Please fill out the following as part of\r\n  - your pull request so we can review your code more easily.\r\n  -->\r\n\r\n## Explanation\r\n<!--\r\n  - Explain what your PR does. If this PR fixes an existing bug, please include \r\n  - \"Fixes #bugnum:\" in the explanation so that GitHub can auto-close the issue \r\n  - when this PR is merged.\r\n  -->\r\nFixes #4231: This PR fixes the bug where people can't scroll down in the editor tab during the `Add Response` phase after changing the `If the learner's answer` option.\r\n\r\nThis fix was done via overriding the .modal-open css in exploration_editor.\r\n\r\n@vibhor98 and @prasanna08 , during my testing, this has fixed the problem of not being able to scroll down but it introduces another problem of being able to scroll the body in the very bottom where the the modal ends. \r\ne.g. \r\n![image](https://user-images.githubusercontent.com/10623811/43873952-d1e7ebce-9b3d-11e8-9af2-b2b1658d4d99.png)\r\n\r\nIf you scroll up from there, the rest of the body scrolls.\r\n\r\nDo you guys have any tip on how to go about this?\r\n\r\n## Checklist\r\n- [x] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes.\r\n- [x] The PR explanation includes the words \"Fixes #bugnum: ...\".\r\n- [x] The linter/Karma presubmit checks have passed.\r\n  - These should run automatically, but if not, you can manually trigger them locally using `python scripts/pre_commit_linter.py` and `bash scripts/run_frontend_tests.sh`.\r\n- [x] The PR is made from a branch that's **not** called \"develop\".\r\n- [x] The PR follows the [style guide](https://github.com/oppia/oppia/wiki/Coding-style-guide).\r\n- [ ] The PR is assigned to an appropriate reviewer.\r\n  - If you're a new contributor, please ask on [Gitter](https://gitter.im/oppia/oppia-chat) for someone to assign a reviewer.\r\n  - If you're not sure who the appropriate reviewer is, please assign to the issue's \"owner\" -- see the \"talk-to\" label on the issue.\r\n"},"comment":{"url":"https://api.github.com/repos/oppia/oppia/issues/comments/412027353","html_url":"https://github.com/oppia/oppia/pull/5471#issuecomment-412027353","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5471","id":412027353,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjAyNzM1Mw==","user":{"login":"unit-00","id":10623811,"node_id":"MDQ6VXNlcjEwNjIzODEx","avatar_url":"https://avatars3.githubusercontent.com/u/10623811?v=4","gravatar_id":"","url":"https://api.github.com/users/unit-00","html_url":"https://github.com/unit-00","followers_url":"https://api.github.com/users/unit-00/followers","following_url":"https://api.github.com/users/unit-00/following{/other_user}","gists_url":"https://api.github.com/users/unit-00/gists{/gist_id}","starred_url":"https://api.github.com/users/unit-00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unit-00/subscriptions","organizations_url":"https://api.github.com/users/unit-00/orgs","repos_url":"https://api.github.com/users/unit-00/repos","events_url":"https://api.github.com/users/unit-00/events{/privacy}","received_events_url":"https://api.github.com/users/unit-00/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T09:18:42Z","updated_at":"2018-08-10T09:18:42Z","author_association":"CONTRIBUTOR","body":"Hi @vibhor98 , \r\n\r\nI'm doing the testing on chrome v68. \r\n\r\nAlso, I finally realized why I was getting a different result! I was testing the scrolling based on this [SO post](https://stackoverflow.com/questions/29052649/expect-an-element-to-have-a-scroll), and scrolling with two-finger swipe instead of dragging the scroll bar. \r\n\r\nI did not realize dragging the scrollbar would have a different result than swiping. \r\n\r\nWhen I dragged it just now, I could not drag it as well.\r\n\r\nDo you have any suggestion of what to look at?\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"unit-00"}}