{"action":"opened","number":1188,"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/1188","id":174755604,"html_url":"https://github.com/terraform-providers/terraform-provider-google/pull/1188","diff_url":"https://github.com/terraform-providers/terraform-provider-google/pull/1188.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-google/pull/1188.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/1188","number":1188,"state":"open","locked":false,"title":"Force validation of region for cloudfunctions.","user":{"login":"ndmckinley","id":605324,"avatar_url":"https://avatars2.githubusercontent.com/u/605324?v=4","gravatar_id":"","url":"https://api.github.com/users/ndmckinley","html_url":"https://github.com/ndmckinley","followers_url":"https://api.github.com/users/ndmckinley/followers","following_url":"https://api.github.com/users/ndmckinley/following{/other_user}","gists_url":"https://api.github.com/users/ndmckinley/gists{/gist_id}","starred_url":"https://api.github.com/users/ndmckinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndmckinley/subscriptions","organizations_url":"https://api.github.com/users/ndmckinley/orgs","repos_url":"https://api.github.com/users/ndmckinley/repos","events_url":"https://api.github.com/users/ndmckinley/events{/privacy}","received_events_url":"https://api.github.com/users/ndmckinley/received_events","type":"User","site_admin":false},"body":"This fixes #1173.  The issue is that neither the user nor I knew that `australia-southeast1` is not a valid region for cloud functions, which meant that the 400 error they got back was confusing to both of us (and my lack of repro, since my test cases run in `us-central1`, was doubly confusing).  Since `ValidateFunc`s don't run on `d.Set()`, calling the function explicitly is the way to go to make this error obvious right away.\r\n\r\nI tested this locally with the user's repro case, and the error is clear and helpful.","created_at":"2018-03-13T18:47:14Z","updated_at":"2018-03-13T18:47:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/1188/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/1188/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/1188/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/statuses/137bc0011503936366d875f167a7c1a913576a42","head":{"label":"ndmckinley:fix-cf-region","ref":"fix-cf-region","sha":"137bc0011503936366d875f167a7c1a913576a42","user":{"login":"ndmckinley","id":605324,"avatar_url":"https://avatars2.githubusercontent.com/u/605324?v=4","gravatar_id":"","url":"https://api.github.com/users/ndmckinley","html_url":"https://github.com/ndmckinley","followers_url":"https://api.github.com/users/ndmckinley/followers","following_url":"https://api.github.com/users/ndmckinley/following{/other_user}","gists_url":"https://api.github.com/users/ndmckinley/gists{/gist_id}","starred_url":"https://api.github.com/users/ndmckinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndmckinley/subscriptions","organizations_url":"https://api.github.com/users/ndmckinley/orgs","repos_url":"https://api.github.com/users/ndmckinley/repos","events_url":"https://api.github.com/users/ndmckinley/events{/privacy}","received_events_url":"https://api.github.com/users/ndmckinley/received_events","type":"User","site_admin":false},"repo":{"id":112267983,"name":"terraform-provider-google","full_name":"ndmckinley/terraform-provider-google","owner":{"login":"ndmckinley","id":605324,"avatar_url":"https://avatars2.githubusercontent.com/u/605324?v=4","gravatar_id":"","url":"https://api.github.com/users/ndmckinley","html_url":"https://github.com/ndmckinley","followers_url":"https://api.github.com/users/ndmckinley/followers","following_url":"https://api.github.com/users/ndmckinley/following{/other_user}","gists_url":"https://api.github.com/users/ndmckinley/gists{/gist_id}","starred_url":"https://api.github.com/users/ndmckinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndmckinley/subscriptions","organizations_url":"https://api.github.com/users/ndmckinley/orgs","repos_url":"https://api.github.com/users/ndmckinley/repos","events_url":"https://api.github.com/users/ndmckinley/events{/privacy}","received_events_url":"https://api.github.com/users/ndmckinley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ndmckinley/terraform-provider-google","description":"Terraform Google Cloud provider","fork":true,"url":"https://api.github.com/repos/ndmckinley/terraform-provider-google","forks_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/forks","keys_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/teams","hooks_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/hooks","issue_events_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/issues/events{/number}","events_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/events","assignees_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/assignees{/user}","branches_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/branches{/branch}","tags_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/tags","blobs_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/statuses/{sha}","languages_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/languages","stargazers_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/stargazers","contributors_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/contributors","subscribers_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/subscribers","subscription_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/subscription","commits_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/contents/{+path}","compare_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/merges","archive_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/downloads","issues_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/issues{/number}","pulls_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/pulls{/number}","milestones_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/milestones{/number}","notifications_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/labels{/name}","releases_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/releases{/id}","deployments_url":"https://api.github.com/repos/ndmckinley/terraform-provider-google/deployments","created_at":"2017-11-28T01:10:03Z","updated_at":"2017-11-28T01:10:06Z","pushed_at":"2018-03-13T18:43:12Z","git_url":"git://github.com/ndmckinley/terraform-provider-google.git","ssh_url":"git@github.com:ndmckinley/terraform-provider-google.git","clone_url":"https://github.com/ndmckinley/terraform-provider-google.git","svn_url":"https://github.com/ndmckinley/terraform-provider-google","homepage":"https://www.terraform.io/docs/providers/google/","size":9796,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"99860f39e48e2816db0701b40f5ddb8b32d9d6d8","user":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93446075,"name":"terraform-provider-google","full_name":"terraform-providers/terraform-provider-google","owner":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-google","description":"Terraform Google Cloud provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-google","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/deployments","created_at":"2017-06-05T20:54:02Z","updated_at":"2018-03-13T18:46:31Z","pushed_at":"2018-03-13T18:46:27Z","git_url":"git://github.com/terraform-providers/terraform-provider-google.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-google.git","clone_url":"https://github.com/terraform-providers/terraform-provider-google.git","svn_url":"https://github.com/terraform-providers/terraform-provider-google","homepage":"https://www.terraform.io/docs/providers/google/","size":9802,"stargazers_count":185,"watchers_count":185,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":156,"open_issues":127,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/1188"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-google/pull/1188"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/1188"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/1188/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/1188/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/1188/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/statuses/137bc0011503936366d875f167a7c1a913576a42"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":15,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"ndmckinley"}}