{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/222938350","pull_request_review_id":161947859,"id":222938350,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjkzODM1MA==","diff_hunk":"@@ -288,6 +288,14 @@ public function configureOptions(OptionsResolver $resolver)\n         $resolver->setAllowedTypes('years', 'array');\n         $resolver->setAllowedTypes('months', 'array');\n         $resolver->setAllowedTypes('days', 'array');\n+\n+        $resolver->setNormalizer('html5', function (Options $options, $html5) {\n+            if ($html5 && 'single_text' === $options['widget'] && self::HTML5_FORMAT !== $options['format']) {\n+                @trigger_error(sprintf('Using a custom format when the \"html5\" option of the %s is enabled is deprecated since Symfony 4.2.', self::class), E_USER_DEPRECATED);","path":"src/Symfony/Component/Form/Extension/Core/Type/DateType.php","position":16,"original_position":16,"commit_id":"055dc6c3b8623912490f9d320ba41d66ba1c16c7","original_commit_id":"055dc6c3b8623912490f9d320ba41d66ba1c16c7","user":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"will this code path throw in Symfony 5? or will we just ignore the property?\r\nif throw => the code should be added as a commented line\r\nif ignore => might end up being confusing","created_at":"2018-10-05T09:05:06Z","updated_at":"2018-10-05T09:07:02Z","html_url":"https://github.com/symfony/symfony/pull/28723#discussion_r222938350","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/28723","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/222938350"},"html":{"href":"https://github.com/symfony/symfony/pull/28723#discussion_r222938350"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28723"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/28723","id":220335985,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMzM1OTg1","html_url":"https://github.com/symfony/symfony/pull/28723","diff_url":"https://github.com/symfony/symfony/pull/28723.diff","patch_url":"https://github.com/symfony/symfony/pull/28723.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/28723","number":28723,"state":"open","locked":false,"title":"[Form] deprecate custom formats with HTML5 widgets","user":{"login":"xabbuh","id":1957048,"node_id":"MDQ6VXNlcjE5NTcwNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1957048?v=4","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | \r\n| License       | MIT\r\n| Doc PR        | ","created_at":"2018-10-04T11:07:22Z","updated_at":"2018-10-05T09:07:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a35c55ab49ccd38ff79278df26721a7e55f65f95","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":337186922,"node_id":"MDU6TGFiZWwzMzcxODY5MjI=","url":"https://api.github.com/repos/symfony/symfony/labels/Deprecation","name":"Deprecation","color":"f1c40f","default":false},{"id":99594,"node_id":"MDU6TGFiZWw5OTU5NA==","url":"https://api.github.com/repos/symfony/symfony/labels/Form","name":"Form","color":"DDDDDD","default":false},{"id":237003792,"node_id":"MDU6TGFiZWwyMzcwMDM3OTI=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/18","html_url":"https://github.com/symfony/symfony/milestone/18","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/18/labels","id":3234645,"node_id":"MDk6TWlsZXN0b25lMzIzNDY0NQ==","number":18,"title":"next","description":"https://symfony.com/roadmap?version=4.2#checker","creator":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":147,"closed_issues":288,"state":"open","created_at":"2018-04-02T12:03:21Z","updated_at":"2018-10-05T07:45:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/28723/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/28723/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/28723/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/055dc6c3b8623912490f9d320ba41d66ba1c16c7","head":{"label":"xabbuh:html5-singletext-format-deprecation","ref":"html5-singletext-format-deprecation","sha":"055dc6c3b8623912490f9d320ba41d66ba1c16c7","user":{"login":"xabbuh","id":1957048,"node_id":"MDQ6VXNlcjE5NTcwNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1957048?v=4","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"repo":{"id":9551743,"node_id":"MDEwOlJlcG9zaXRvcnk5NTUxNzQz","name":"symfony","full_name":"xabbuh/symfony","private":false,"owner":{"login":"xabbuh","id":1957048,"node_id":"MDQ6VXNlcjE5NTcwNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1957048?v=4","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xabbuh/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/xabbuh/symfony","forks_url":"https://api.github.com/repos/xabbuh/symfony/forks","keys_url":"https://api.github.com/repos/xabbuh/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xabbuh/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xabbuh/symfony/teams","hooks_url":"https://api.github.com/repos/xabbuh/symfony/hooks","issue_events_url":"https://api.github.com/repos/xabbuh/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/xabbuh/symfony/events","assignees_url":"https://api.github.com/repos/xabbuh/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/xabbuh/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/xabbuh/symfony/tags","blobs_url":"https://api.github.com/repos/xabbuh/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xabbuh/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xabbuh/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/xabbuh/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xabbuh/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/xabbuh/symfony/languages","stargazers_url":"https://api.github.com/repos/xabbuh/symfony/stargazers","contributors_url":"https://api.github.com/repos/xabbuh/symfony/contributors","subscribers_url":"https://api.github.com/repos/xabbuh/symfony/subscribers","subscription_url":"https://api.github.com/repos/xabbuh/symfony/subscription","commits_url":"https://api.github.com/repos/xabbuh/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/xabbuh/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/xabbuh/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/xabbuh/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/xabbuh/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/xabbuh/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xabbuh/symfony/merges","archive_url":"https://api.github.com/repos/xabbuh/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xabbuh/symfony/downloads","issues_url":"https://api.github.com/repos/xabbuh/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/xabbuh/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/xabbuh/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/xabbuh/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xabbuh/symfony/labels{/name}","releases_url":"https://api.github.com/repos/xabbuh/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/xabbuh/symfony/deployments","created_at":"2013-04-19T18:23:15Z","updated_at":"2014-07-05T08:26:55Z","pushed_at":"2018-10-05T07:45:37Z","git_url":"git://github.com/xabbuh/symfony.git","ssh_url":"git@github.com:xabbuh/symfony.git","clone_url":"https://github.com/xabbuh/symfony.git","svn_url":"https://github.com/xabbuh/symfony","homepage":"symfony.com","size":120536,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"3e7b029524bf724abfd603c17795af39bb289615","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-10-05T08:15:06Z","pushed_at":"2018-10-05T08:58:36Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":125742,"stargazers_count":18751,"watchers_count":18751,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6440,"mirror_url":null,"archived":false,"open_issues_count":854,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6440,"open_issues":854,"watchers":18751,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28723"},"html":{"href":"https://github.com/symfony/symfony/pull/28723"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/28723"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/28723/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28723/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28723/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/055dc6c3b8623912490f9d320ba41d66ba1c16c7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nicolas-grekas"}}