{"action":"created","comment":{"url":"https://api.github.com/repos/zulip/zulip/pulls/comments/181914192","pull_request_review_id":112622818,"id":181914192,"diff_hunk":"@@ -14,6 +14,30 @@\n NAME_TO_CODEPOINT_PATH = os.path.join(settings.STATIC_ROOT, \"generated\", \"emoji\", \"name_to_codepoint.json\")\n CODEPOINT_TO_NAME_PATH = os.path.join(settings.STATIC_ROOT, \"generated\", \"emoji\", \"codepoint_to_name.json\")\n \n+# Emoticons and which emoji they should become. Duplicate emoji are allowed.\n+# Changes here should be mimicked in `static/js/emoji.js`.\n+EMOTICON_CONVERSIONS = {","path":"zerver/lib/emoji.py","position":null,"original_position":6,"commit_id":"a7f54a4ff0fd3e7dce0fac0ee03418b8c978a5c8","original_commit_id":"fd8a76dadaa4053aa07c7be9824f7406f22a8bee","user":{"login":"timabbott","id":2746074,"avatar_url":"https://avatars0.githubusercontent.com/u/2746074?v=4","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"body":"@HarshitOnGitHub just checking in on this; might be a good quick thing for you to fix post release?","created_at":"2018-04-16T23:27:03Z","updated_at":"2018-04-16T23:27:03Z","html_url":"https://github.com/zulip/zulip/pull/8081#discussion_r181914192","pull_request_url":"https://api.github.com/repos/zulip/zulip/pulls/8081","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments/181914192"},"html":{"href":"https://github.com/zulip/zulip/pull/8081#discussion_r181914192"},"pull_request":{"href":"https://api.github.com/repos/zulip/zulip/pulls/8081"}},"in_reply_to_id":172011655},"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/8081","id":163093483,"html_url":"https://github.com/zulip/zulip/pull/8081","diff_url":"https://github.com/zulip/zulip/pull/8081.diff","patch_url":"https://github.com/zulip/zulip/pull/8081.patch","issue_url":"https://api.github.com/repos/zulip/zulip/issues/8081","number":8081,"state":"closed","locked":false,"title":"display: Give users the option to translate emoticons into emoji.","user":{"login":"skunkmb","id":17259768,"avatar_url":"https://avatars3.githubusercontent.com/u/17259768?v=4","gravatar_id":"","url":"https://api.github.com/users/skunkmb","html_url":"https://github.com/skunkmb","followers_url":"https://api.github.com/users/skunkmb/followers","following_url":"https://api.github.com/users/skunkmb/following{/other_user}","gists_url":"https://api.github.com/users/skunkmb/gists{/gist_id}","starred_url":"https://api.github.com/users/skunkmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skunkmb/subscriptions","organizations_url":"https://api.github.com/users/skunkmb/orgs","repos_url":"https://api.github.com/users/skunkmb/repos","events_url":"https://api.github.com/users/skunkmb/events{/privacy}","received_events_url":"https://api.github.com/users/skunkmb/received_events","type":"User","site_admin":false},"body":"This adds an option, `Translate emoticons`, in the display settings, which lets user have emoticons like `:)`, `<3`, `:(` and more translated into emoji like :smiley:, :heart:, :slightly_frowning_face:, etc. in their messages.\r\n\r\n 1. A proprety `translate_emoticons` is added to the user model.\r\n 2. New functions are added to `static/js/emoji.js` and `zerver/lib/emoji.py` which can convert emoticons into the emoji.\r\n 3. The translator is added as a Markdown preprocessor in `markdown.js` for immediately after a message is sent and in `compose.js` for showing the Markdown preview.\r\n 3. The translator is also used on the backend in `check_message` for translating emoticons whenever a user with the setting on sends a message.\r\n 4. Add a setting in the `Display settings` for turning this feature on or off.","created_at":"2018-01-16T05:35:38Z","updated_at":"2018-04-16T23:27:03Z","closed_at":"2018-03-04T23:40:21Z","merged_at":null,"merge_commit_sha":"bc40e7f0b6e8e4099ecb562def83104a20bbc6a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":804160549,"url":"https://api.github.com/repos/zulip/zulip/labels/size:%20XL","name":"size: XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip/pulls/8081/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip/pulls/8081/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/8081/comments","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/a7f54a4ff0fd3e7dce0fac0ee03418b8c978a5c8","head":{"label":"skunkmb:translate-emoji","ref":"translate-emoji","sha":"a7f54a4ff0fd3e7dce0fac0ee03418b8c978a5c8","user":{"login":"skunkmb","id":17259768,"avatar_url":"https://avatars3.githubusercontent.com/u/17259768?v=4","gravatar_id":"","url":"https://api.github.com/users/skunkmb","html_url":"https://github.com/skunkmb","followers_url":"https://api.github.com/users/skunkmb/followers","following_url":"https://api.github.com/users/skunkmb/following{/other_user}","gists_url":"https://api.github.com/users/skunkmb/gists{/gist_id}","starred_url":"https://api.github.com/users/skunkmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skunkmb/subscriptions","organizations_url":"https://api.github.com/users/skunkmb/orgs","repos_url":"https://api.github.com/users/skunkmb/repos","events_url":"https://api.github.com/users/skunkmb/events{/privacy}","received_events_url":"https://api.github.com/users/skunkmb/received_events","type":"User","site_admin":false},"repo":{"id":112412225,"name":"zulip","full_name":"skunkmb/zulip","owner":{"login":"skunkmb","id":17259768,"avatar_url":"https://avatars3.githubusercontent.com/u/17259768?v=4","gravatar_id":"","url":"https://api.github.com/users/skunkmb","html_url":"https://github.com/skunkmb","followers_url":"https://api.github.com/users/skunkmb/followers","following_url":"https://api.github.com/users/skunkmb/following{/other_user}","gists_url":"https://api.github.com/users/skunkmb/gists{/gist_id}","starred_url":"https://api.github.com/users/skunkmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skunkmb/subscriptions","organizations_url":"https://api.github.com/users/skunkmb/orgs","repos_url":"https://api.github.com/users/skunkmb/repos","events_url":"https://api.github.com/users/skunkmb/events{/privacy}","received_events_url":"https://api.github.com/users/skunkmb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skunkmb/zulip","description":"Zulip server - powerful open source team chat","fork":true,"url":"https://api.github.com/repos/skunkmb/zulip","forks_url":"https://api.github.com/repos/skunkmb/zulip/forks","keys_url":"https://api.github.com/repos/skunkmb/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skunkmb/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skunkmb/zulip/teams","hooks_url":"https://api.github.com/repos/skunkmb/zulip/hooks","issue_events_url":"https://api.github.com/repos/skunkmb/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/skunkmb/zulip/events","assignees_url":"https://api.github.com/repos/skunkmb/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/skunkmb/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/skunkmb/zulip/tags","blobs_url":"https://api.github.com/repos/skunkmb/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skunkmb/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skunkmb/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/skunkmb/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skunkmb/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/skunkmb/zulip/languages","stargazers_url":"https://api.github.com/repos/skunkmb/zulip/stargazers","contributors_url":"https://api.github.com/repos/skunkmb/zulip/contributors","subscribers_url":"https://api.github.com/repos/skunkmb/zulip/subscribers","subscription_url":"https://api.github.com/repos/skunkmb/zulip/subscription","commits_url":"https://api.github.com/repos/skunkmb/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/skunkmb/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/skunkmb/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/skunkmb/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/skunkmb/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/skunkmb/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skunkmb/zulip/merges","archive_url":"https://api.github.com/repos/skunkmb/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skunkmb/zulip/downloads","issues_url":"https://api.github.com/repos/skunkmb/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/skunkmb/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/skunkmb/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/skunkmb/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skunkmb/zulip/labels{/name}","releases_url":"https://api.github.com/repos/skunkmb/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/skunkmb/zulip/deployments","created_at":"2017-11-29T01:50:22Z","updated_at":"2017-11-29T01:50:30Z","pushed_at":"2018-04-06T04:13:52Z","git_url":"git://github.com/skunkmb/zulip.git","ssh_url":"git@github.com:skunkmb/zulip.git","clone_url":"https://github.com/skunkmb/zulip.git","svn_url":"https://github.com/skunkmb/zulip","homepage":"https://zulip.org/","size":199680,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"7f144b9b955902c08590737d6f5fa226929afb79","user":{"login":"zulip","id":4921959,"avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":43160685,"name":"zulip","full_name":"zulip/zulip","owner":{"login":"zulip","id":4921959,"avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip","description":"Zulip server - powerful open source team chat","fork":false,"url":"https://api.github.com/repos/zulip/zulip","forks_url":"https://api.github.com/repos/zulip/zulip/forks","keys_url":"https://api.github.com/repos/zulip/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip/teams","hooks_url":"https://api.github.com/repos/zulip/zulip/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip/events","assignees_url":"https://api.github.com/repos/zulip/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip/tags","blobs_url":"https://api.github.com/repos/zulip/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip/subscription","commits_url":"https://api.github.com/repos/zulip/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip/merges","archive_url":"https://api.github.com/repos/zulip/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip/downloads","issues_url":"https://api.github.com/repos/zulip/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip/deployments","created_at":"2015-09-25T16:37:25Z","updated_at":"2018-04-16T23:14:13Z","pushed_at":"2018-04-16T23:13:23Z","git_url":"git://github.com/zulip/zulip.git","ssh_url":"git@github.com:zulip/zulip.git","clone_url":"https://github.com/zulip/zulip.git","svn_url":"https://github.com/zulip/zulip","homepage":"https://zulip.org/","size":199885,"stargazers_count":6222,"watchers_count":6222,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2119,"mirror_url":null,"archived":false,"open_issues_count":1013,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2119,"open_issues":1013,"watchers":6222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/8081"},"html":{"href":"https://github.com/zulip/zulip/pull/8081"},"issue":{"href":"https://api.github.com/repos/zulip/zulip/issues/8081"},"comments":{"href":"https://api.github.com/repos/zulip/zulip/issues/8081/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip/pulls/8081/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip/pulls/8081/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip/statuses/a7f54a4ff0fd3e7dce0fac0ee03418b8c978a5c8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"timabbott"}}