{"action":"created","issue":{"url":"https://api.github.com/repos/svalinn/DAGMC/issues/525","repository_url":"https://api.github.com/repos/svalinn/DAGMC","labels_url":"https://api.github.com/repos/svalinn/DAGMC/issues/525/labels{/name}","comments_url":"https://api.github.com/repos/svalinn/DAGMC/issues/525/comments","events_url":"https://api.github.com/repos/svalinn/DAGMC/issues/525/events","html_url":"https://github.com/svalinn/DAGMC/pull/525","id":251018552,"node_id":"MDExOlB1bGxSZXF1ZXN0MTM2MzEzMDk5","number":525,"title":"[bug fix] DAGMC Advanced tallies were not producing vector tagged mes…","user":{"login":"makeclean","id":2439754,"node_id":"MDQ6VXNlcjI0Mzk3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2439754?v=4","gravatar_id":"","url":"https://api.github.com/users/makeclean","html_url":"https://github.com/makeclean","followers_url":"https://api.github.com/users/makeclean/followers","following_url":"https://api.github.com/users/makeclean/following{/other_user}","gists_url":"https://api.github.com/users/makeclean/gists{/gist_id}","starred_url":"https://api.github.com/users/makeclean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makeclean/subscriptions","organizations_url":"https://api.github.com/users/makeclean/orgs","repos_url":"https://api.github.com/users/makeclean/repos","events_url":"https://api.github.com/users/makeclean/events{/privacy}","received_events_url":"https://api.github.com/users/makeclean/received_events","type":"User","site_admin":false},"labels":[{"id":20501178,"node_id":"MDU6TGFiZWwyMDUwMTE3OA==","url":"https://api.github.com/repos/svalinn/DAGMC/labels/1-New","name":"1-New","color":"d7e102","default":false},{"id":12859878,"node_id":"MDU6TGFiZWwxMjg1OTg3OA==","url":"https://api.github.com/repos/svalinn/DAGMC/labels/Type:%20Defect","name":"Type: Defect","color":"e10c02","default":false}],"state":"open","locked":false,"assignee":{"login":"makeclean","id":2439754,"node_id":"MDQ6VXNlcjI0Mzk3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2439754?v=4","gravatar_id":"","url":"https://api.github.com/users/makeclean","html_url":"https://github.com/makeclean","followers_url":"https://api.github.com/users/makeclean/followers","following_url":"https://api.github.com/users/makeclean/following{/other_user}","gists_url":"https://api.github.com/users/makeclean/gists{/gist_id}","starred_url":"https://api.github.com/users/makeclean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makeclean/subscriptions","organizations_url":"https://api.github.com/users/makeclean/orgs","repos_url":"https://api.github.com/users/makeclean/repos","events_url":"https://api.github.com/users/makeclean/events{/privacy}","received_events_url":"https://api.github.com/users/makeclean/received_events","type":"User","site_admin":false},"assignees":[{"login":"makeclean","id":2439754,"node_id":"MDQ6VXNlcjI0Mzk3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2439754?v=4","gravatar_id":"","url":"https://api.github.com/users/makeclean","html_url":"https://github.com/makeclean","followers_url":"https://api.github.com/users/makeclean/followers","following_url":"https://api.github.com/users/makeclean/following{/other_user}","gists_url":"https://api.github.com/users/makeclean/gists{/gist_id}","starred_url":"https://api.github.com/users/makeclean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makeclean/subscriptions","organizations_url":"https://api.github.com/users/makeclean/orgs","repos_url":"https://api.github.com/users/makeclean/repos","events_url":"https://api.github.com/users/makeclean/events{/privacy}","received_events_url":"https://api.github.com/users/makeclean/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-08-17T17:37:52Z","updated_at":"2018-12-06T20:56:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/svalinn/DAGMC/pulls/525","html_url":"https://github.com/svalinn/DAGMC/pull/525","diff_url":"https://github.com/svalinn/DAGMC/pull/525.diff","patch_url":"https://github.com/svalinn/DAGMC/pull/525.patch"},"body":"This PR modified the underlying routines to fix a number of issues regarding the DAGMC mesh tallies interfacing with pyne.r2s. The routines produced n_group+2 scalar tags, when we should have produced a single n_group sized vector tag. The +2 tags comes form 0-bottom group, and a total group tag. This has been modified for both the KDE tally and Tetmesh tracklength tally. \r\n\r\nA future fix could figure out how automatically tag the total group into a separate TOTAL_TAG, it may need some reworking of the logic, refactor into a common tagging function maybe?"},"comment":{"url":"https://api.github.com/repos/svalinn/DAGMC/issues/comments/445026715","html_url":"https://github.com/svalinn/DAGMC/pull/525#issuecomment-445026715","issue_url":"https://api.github.com/repos/svalinn/DAGMC/issues/525","id":445026715,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTAyNjcxNQ==","user":{"login":"cadangelo","id":2279088,"node_id":"MDQ6VXNlcjIyNzkwODg=","avatar_url":"https://avatars1.githubusercontent.com/u/2279088?v=4","gravatar_id":"","url":"https://api.github.com/users/cadangelo","html_url":"https://github.com/cadangelo","followers_url":"https://api.github.com/users/cadangelo/followers","following_url":"https://api.github.com/users/cadangelo/following{/other_user}","gists_url":"https://api.github.com/users/cadangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/cadangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cadangelo/subscriptions","organizations_url":"https://api.github.com/users/cadangelo/orgs","repos_url":"https://api.github.com/users/cadangelo/repos","events_url":"https://api.github.com/users/cadangelo/events{/privacy}","received_events_url":"https://api.github.com/users/cadangelo/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T20:56:38Z","updated_at":"2018-12-06T20:56:38Z","author_association":"NONE","body":"This PR is good to go!  My previous issue with the number of energy bins was my mistake."}}
{"actor":{"display_login":"cadangelo"}}