{"action":"created","comment":{"url":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments/237855155","pull_request_review_id":180258472,"id":237855155,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzg1NTE1NQ==","diff_hunk":"@@ -73,10 +73,13 @@ impl Hash for ActionWrapper {\n pub enum Action {\n     /// entry to Commit\n     /// MUST already have passed all callback checks\n-    Commit(Entry),\n+    Commit((Entry, Option<Address>)),\n     /// GetEntry by address\n     GetEntry(Address),\n-\n+    ///\n+    UpdateEntry((Address, Address)),","path":"core/src/action.rs","position":10,"original_position":10,"commit_id":"339ad782c137dd95480723d85fcbaef04d1eca5a","original_commit_id":"339ad782c137dd95480723d85fcbaef04d1eca5a","user":{"login":"sphinxc0re","id":3702016,"node_id":"MDQ6VXNlcjM3MDIwMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3702016?v=4","gravatar_id":"","url":"https://api.github.com/users/sphinxc0re","html_url":"https://github.com/sphinxc0re","followers_url":"https://api.github.com/users/sphinxc0re/followers","following_url":"https://api.github.com/users/sphinxc0re/following{/other_user}","gists_url":"https://api.github.com/users/sphinxc0re/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinxc0re/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinxc0re/subscriptions","organizations_url":"https://api.github.com/users/sphinxc0re/orgs","repos_url":"https://api.github.com/users/sphinxc0re/repos","events_url":"https://api.github.com/users/sphinxc0re/events{/privacy}","received_events_url":"https://api.github.com/users/sphinxc0re/received_events","type":"User","site_admin":false},"body":"Why the extra `()` ","created_at":"2018-11-30T13:12:28Z","updated_at":"2018-11-30T13:12:31Z","html_url":"https://github.com/holochain/holochain-rust/pull/657#discussion_r237855155","pull_request_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/657","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments/237855155"},"html":{"href":"https://github.com/holochain/holochain-rust/pull/657#discussion_r237855155"},"pull_request":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/657"}}},"pull_request":{"url":"https://api.github.com/repos/holochain/holochain-rust/pulls/657","id":232822349,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODIyMzQ5","html_url":"https://github.com/holochain/holochain-rust/pull/657","diff_url":"https://github.com/holochain/holochain-rust/pull/657.diff","patch_url":"https://github.com/holochain/holochain-rust/pull/657.patch","issue_url":"https://api.github.com/repos/holochain/holochain-rust/issues/657","number":657,"state":"open","locked":false,"title":"Crud works locally","user":{"login":"ddd-mtl","id":34140573,"node_id":"MDQ6VXNlcjM0MTQwNTcz","avatar_url":"https://avatars3.githubusercontent.com/u/34140573?v=4","gravatar_id":"","url":"https://api.github.com/users/ddd-mtl","html_url":"https://github.com/ddd-mtl","followers_url":"https://api.github.com/users/ddd-mtl/followers","following_url":"https://api.github.com/users/ddd-mtl/following{/other_user}","gists_url":"https://api.github.com/users/ddd-mtl/gists{/gist_id}","starred_url":"https://api.github.com/users/ddd-mtl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddd-mtl/subscriptions","organizations_url":"https://api.github.com/users/ddd-mtl/orgs","repos_url":"https://api.github.com/users/ddd-mtl/repos","events_url":"https://api.github.com/users/ddd-mtl/events{/privacy}","received_events_url":"https://api.github.com/users/ddd-mtl/received_events","type":"User","site_admin":false},"body":"See: https://hackmd.io/VH6oxwQWSKG1M9nqXNfNZg?both\r\n\r\n# CRUD works locally\r\nImplemented hc_update_entry() and hc_remove_entry()\r\n\r\n## API changes\r\n@Connoropolous \r\n\r\nHDK API now has get_entry_initial() and get_entry_history().\r\nget_entry() gets latest entry.\r\n\r\n## Internals\r\n\r\nAdded UpdateEntry and RemoveEntry actions and ActionCreators.\r\nEverything is mostly done in the DHT, since metadata is stored in its eav store.\r\nDHT now holds a generic actions hashMap that returns an address.\r\n\r\nAdded link_crud in ChainHeader which is filled in by the Action::Commit which now has an extra argument: Option<Address>. Normal commit action is None, while modify entry commit is Some(...).\r\n\r\nFound decent work-around for missing update/remove_eav() api in eav store.\r\n\r\n### get_entry\r\nThe Ribosome's hc_get_entry() now takes a GetEntryArgs as input which holds a GetEntryOptions.\r\nIt gives back a GetEntryResult which holds all the entries it walked.\r\nThe get_entry action creator now walks the crud-links in a recursive way. see get_entry_rec()\r\nTests got changed accordingly.\r\n\r\n## Misc.\r\nUpdated build.bat script for local windows building.\r\n","created_at":"2018-11-21T23:26:11Z","updated_at":"2018-11-30T13:12:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e9507a7f873a43f14f5e1245abe237ac75bbb5a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zippy","id":3563,"node_id":"MDQ6VXNlcjM1NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/3563?v=4","gravatar_id":"","url":"https://api.github.com/users/zippy","html_url":"https://github.com/zippy","followers_url":"https://api.github.com/users/zippy/followers","following_url":"https://api.github.com/users/zippy/following{/other_user}","gists_url":"https://api.github.com/users/zippy/gists{/gist_id}","starred_url":"https://api.github.com/users/zippy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zippy/subscriptions","organizations_url":"https://api.github.com/users/zippy/orgs","repos_url":"https://api.github.com/users/zippy/repos","events_url":"https://api.github.com/users/zippy/events{/privacy}","received_events_url":"https://api.github.com/users/zippy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":937673517,"node_id":"MDU6TGFiZWw5Mzc2NzM1MTc=","url":"https://api.github.com/repos/holochain/holochain-rust/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/657/commits","review_comments_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/657/comments","review_comment_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/issues/657/comments","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/339ad782c137dd95480723d85fcbaef04d1eca5a","head":{"label":"holochain:crud","ref":"crud","sha":"339ad782c137dd95480723d85fcbaef04d1eca5a","user":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"repo":{"id":133449383,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDkzODM=","name":"holochain-rust","full_name":"holochain/holochain-rust","private":false,"owner":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/holochain/holochain-rust","description":"The core Holochain framework written in Rust, a container API for that, and hdk-rust library for Zomes","fork":false,"url":"https://api.github.com/repos/holochain/holochain-rust","forks_url":"https://api.github.com/repos/holochain/holochain-rust/forks","keys_url":"https://api.github.com/repos/holochain/holochain-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holochain/holochain-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holochain/holochain-rust/teams","hooks_url":"https://api.github.com/repos/holochain/holochain-rust/hooks","issue_events_url":"https://api.github.com/repos/holochain/holochain-rust/issues/events{/number}","events_url":"https://api.github.com/repos/holochain/holochain-rust/events","assignees_url":"https://api.github.com/repos/holochain/holochain-rust/assignees{/user}","branches_url":"https://api.github.com/repos/holochain/holochain-rust/branches{/branch}","tags_url":"https://api.github.com/repos/holochain/holochain-rust/tags","blobs_url":"https://api.github.com/repos/holochain/holochain-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holochain/holochain-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holochain/holochain-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/holochain/holochain-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/holochain/holochain-rust/languages","stargazers_url":"https://api.github.com/repos/holochain/holochain-rust/stargazers","contributors_url":"https://api.github.com/repos/holochain/holochain-rust/contributors","subscribers_url":"https://api.github.com/repos/holochain/holochain-rust/subscribers","subscription_url":"https://api.github.com/repos/holochain/holochain-rust/subscription","commits_url":"https://api.github.com/repos/holochain/holochain-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/holochain/holochain-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/holochain/holochain-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/holochain/holochain-rust/contents/{+path}","compare_url":"https://api.github.com/repos/holochain/holochain-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holochain/holochain-rust/merges","archive_url":"https://api.github.com/repos/holochain/holochain-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holochain/holochain-rust/downloads","issues_url":"https://api.github.com/repos/holochain/holochain-rust/issues{/number}","pulls_url":"https://api.github.com/repos/holochain/holochain-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/holochain/holochain-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/holochain/holochain-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holochain/holochain-rust/labels{/name}","releases_url":"https://api.github.com/repos/holochain/holochain-rust/releases{/id}","deployments_url":"https://api.github.com/repos/holochain/holochain-rust/deployments","created_at":"2018-05-15T02:42:12Z","updated_at":"2018-11-30T09:00:30Z","pushed_at":"2018-11-30T09:08:51Z","git_url":"git://github.com/holochain/holochain-rust.git","ssh_url":"git@github.com:holochain/holochain-rust.git","clone_url":"https://github.com/holochain/holochain-rust.git","svn_url":"https://github.com/holochain/holochain-rust","homepage":"","size":169067,"stargazers_count":233,"watchers_count":233,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":201,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":50,"open_issues":201,"watchers":233,"default_branch":"develop"}},"base":{"label":"holochain:develop","ref":"develop","sha":"664721dee87163fd0fae41994a7caeb01530c4ac","user":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"repo":{"id":133449383,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDkzODM=","name":"holochain-rust","full_name":"holochain/holochain-rust","private":false,"owner":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/holochain/holochain-rust","description":"The core Holochain framework written in Rust, a container API for that, and hdk-rust library for Zomes","fork":false,"url":"https://api.github.com/repos/holochain/holochain-rust","forks_url":"https://api.github.com/repos/holochain/holochain-rust/forks","keys_url":"https://api.github.com/repos/holochain/holochain-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holochain/holochain-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holochain/holochain-rust/teams","hooks_url":"https://api.github.com/repos/holochain/holochain-rust/hooks","issue_events_url":"https://api.github.com/repos/holochain/holochain-rust/issues/events{/number}","events_url":"https://api.github.com/repos/holochain/holochain-rust/events","assignees_url":"https://api.github.com/repos/holochain/holochain-rust/assignees{/user}","branches_url":"https://api.github.com/repos/holochain/holochain-rust/branches{/branch}","tags_url":"https://api.github.com/repos/holochain/holochain-rust/tags","blobs_url":"https://api.github.com/repos/holochain/holochain-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holochain/holochain-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holochain/holochain-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/holochain/holochain-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/holochain/holochain-rust/languages","stargazers_url":"https://api.github.com/repos/holochain/holochain-rust/stargazers","contributors_url":"https://api.github.com/repos/holochain/holochain-rust/contributors","subscribers_url":"https://api.github.com/repos/holochain/holochain-rust/subscribers","subscription_url":"https://api.github.com/repos/holochain/holochain-rust/subscription","commits_url":"https://api.github.com/repos/holochain/holochain-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/holochain/holochain-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/holochain/holochain-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/holochain/holochain-rust/contents/{+path}","compare_url":"https://api.github.com/repos/holochain/holochain-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holochain/holochain-rust/merges","archive_url":"https://api.github.com/repos/holochain/holochain-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holochain/holochain-rust/downloads","issues_url":"https://api.github.com/repos/holochain/holochain-rust/issues{/number}","pulls_url":"https://api.github.com/repos/holochain/holochain-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/holochain/holochain-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/holochain/holochain-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holochain/holochain-rust/labels{/name}","releases_url":"https://api.github.com/repos/holochain/holochain-rust/releases{/id}","deployments_url":"https://api.github.com/repos/holochain/holochain-rust/deployments","created_at":"2018-05-15T02:42:12Z","updated_at":"2018-11-30T09:00:30Z","pushed_at":"2018-11-30T09:08:51Z","git_url":"git://github.com/holochain/holochain-rust.git","ssh_url":"git@github.com:holochain/holochain-rust.git","clone_url":"https://github.com/holochain/holochain-rust.git","svn_url":"https://github.com/holochain/holochain-rust","homepage":"","size":169067,"stargazers_count":233,"watchers_count":233,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":201,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":50,"open_issues":201,"watchers":233,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/657"},"html":{"href":"https://github.com/holochain/holochain-rust/pull/657"},"issue":{"href":"https://api.github.com/repos/holochain/holochain-rust/issues/657"},"comments":{"href":"https://api.github.com/repos/holochain/holochain-rust/issues/657/comments"},"review_comments":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/657/comments"},"review_comment":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/657/commits"},"statuses":{"href":"https://api.github.com/repos/holochain/holochain-rust/statuses/339ad782c137dd95480723d85fcbaef04d1eca5a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sphinxc0re"}}