{"action":"created","issue":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5692","repository_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5692/labels{/name}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5692/comments","events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5692/events","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5692","id":305981956,"number":5692,"title":"render_image_region","user":{"login":"jburel","id":1022396,"avatar_url":"https://avatars1.githubusercontent.com/u/1022396?v=4","gravatar_id":"","url":"https://api.github.com/users/jburel","html_url":"https://github.com/jburel","followers_url":"https://api.github.com/users/jburel/followers","following_url":"https://api.github.com/users/jburel/following{/other_user}","gists_url":"https://api.github.com/users/jburel/gists{/gist_id}","starred_url":"https://api.github.com/users/jburel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburel/subscriptions","organizations_url":"https://api.github.com/users/jburel/orgs","repos_url":"https://api.github.com/users/jburel/repos","events_url":"https://api.github.com/users/jburel/events{/privacy}","received_events_url":"https://api.github.com/users/jburel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-03-16T15:54:18Z","updated_at":"2018-03-20T09:42:13Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/5692","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5692","diff_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5692.diff","patch_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5692.patch"},"body":"# What this PR does\r\n\r\nIgnore resolution level for non pyramid file\r\nThe problem is also present for small image as soon as the resolution specified was not 0.\r\n\r\n# Testing this PR\r\n\r\nTest 1:\r\n1. Open a big image and draw a rectangle 3kx3k.\r\n1. Generate an image using the image from ROIs script\r\n1. View the image using ``/webgateway/render_image_region/ImageID/0/0/?tile=0,0,0,512,512``\r\nthis should no longer return a 404.\r\n\r\nTest 2:\r\n1. Open any small image e.g. dv\r\n1. View the image using ``/webgateway/render_image_region/ImageID/0/0/?tile=1,0,0,512,512``\r\nA 404 will be returned and prevent error like\r\n```\r\nrepo/openmicroscopy/dist/lib/python/omero_api_PyramidService_ice.py\", line 324, in setResolutionLevel\r\n    return _M_omero.api.PyramidService._op_setResolutionLevel.invoke(self, ((resolutionLevel, ), _ctx))\r\n\r\n```\r\n\r\nTest 3:\r\n* Open any pyramid\r\n* View the image using ``/webgateway/render_image_region/ImageID/0/0/?tile=0,0,0,512,512``\r\n* View the image using ``/webgateway/render_image_region/ImageID/0/0/?region=0,0,512,512``\r\n\r\nTest 4:\r\nNegative resolution\r\n1. Open any small image e.g. dv\r\n1. View the image using ``/webgateway/render_image_region/ImageID/0/0/?tile=-1,0,0,512,512``\r\nA \"invalid resolution message\" will be returned\r\n\r\nCheck that the tests are green\r\n\r\ncc @will-moore @chris-allan \r\n\r\nproblem test 1 reported https://trello.com/c/AdRIcaBJ/37-viewing-large-non-tiled-image-fails\r\ntest 2: found while investigating"},"comment":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/comments/374534124","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5692#issuecomment-374534124","issue_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5692","id":374534124,"user":{"login":"chris-allan","id":487082,"avatar_url":"https://avatars1.githubusercontent.com/u/487082?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-allan","html_url":"https://github.com/chris-allan","followers_url":"https://api.github.com/users/chris-allan/followers","following_url":"https://api.github.com/users/chris-allan/following{/other_user}","gists_url":"https://api.github.com/users/chris-allan/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-allan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-allan/subscriptions","organizations_url":"https://api.github.com/users/chris-allan/orgs","repos_url":"https://api.github.com/users/chris-allan/repos","events_url":"https://api.github.com/users/chris-allan/events{/privacy}","received_events_url":"https://api.github.com/users/chris-allan/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T09:42:12Z","updated_at":"2018-03-20T09:42:12Z","author_association":"OWNER","body":"That would certainly be worth investigating. However, I don't know what the impact of that change may be."}}
{"actor":{"display_login":"chris-allan"}}