{"action":"closed","number":21172,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/21172","id":237404588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDA0NTg4","html_url":"https://github.com/apple/swift/pull/21172","diff_url":"https://github.com/apple/swift/pull/21172.diff","patch_url":"https://github.com/apple/swift/pull/21172.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/21172","number":21172,"state":"closed","locked":false,"title":"SILCombine: peephole to propagate resilient enum cases","user":{"login":"eeckstein","id":15270291,"node_id":"MDQ6VXNlcjE1MjcwMjkx","avatar_url":"https://avatars0.githubusercontent.com/u/15270291?v=4","gravatar_id":"","url":"https://api.github.com/users/eeckstein","html_url":"https://github.com/eeckstein","followers_url":"https://api.github.com/users/eeckstein/followers","following_url":"https://api.github.com/users/eeckstein/following{/other_user}","gists_url":"https://api.github.com/users/eeckstein/gists{/gist_id}","starred_url":"https://api.github.com/users/eeckstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeckstein/subscriptions","organizations_url":"https://api.github.com/users/eeckstein/orgs","repos_url":"https://api.github.com/users/eeckstein/repos","events_url":"https://api.github.com/users/eeckstein/events{/privacy}","received_events_url":"https://api.github.com/users/eeckstein/received_events","type":"User","site_admin":false},"body":"Basically the pattern to optimize is:\r\n    inject_enum_addr %stackloc, #SomeCase\r\n    switch_enum_addr %stackloc ...\r\n    \r\nThis works even if the enum is resilient or not a loadable type (e.g. an enum with a not loadable payload) and the case does not have a payload. As long as we don't have opaque values in SIL we need this peephole to optimize the pattern.\r\nThis change fixes the code generation for Float.rounded().\r\n    \r\nrdar://problem/46353885\r\n","created_at":"2018-12-10T17:29:50Z","updated_at":"2018-12-11T16:21:29Z","closed_at":"2018-12-11T16:21:29Z","merged_at":"2018-12-11T16:21:29Z","merge_commit_sha":"7732b984bd449c205e0275cf92a158fd94bb0778","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/21172/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/21172/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/21172/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/5c17f0f6f857a6c16e4afbd58b4a36a47dd6f2f6","head":{"label":"eeckstein:silcombine-enums","ref":"silcombine-enums","sha":"5c17f0f6f857a6c16e4afbd58b4a36a47dd6f2f6","user":{"login":"eeckstein","id":15270291,"node_id":"MDQ6VXNlcjE1MjcwMjkx","avatar_url":"https://avatars0.githubusercontent.com/u/15270291?v=4","gravatar_id":"","url":"https://api.github.com/users/eeckstein","html_url":"https://github.com/eeckstein","followers_url":"https://api.github.com/users/eeckstein/followers","following_url":"https://api.github.com/users/eeckstein/following{/other_user}","gists_url":"https://api.github.com/users/eeckstein/gists{/gist_id}","starred_url":"https://api.github.com/users/eeckstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeckstein/subscriptions","organizations_url":"https://api.github.com/users/eeckstein/orgs","repos_url":"https://api.github.com/users/eeckstein/repos","events_url":"https://api.github.com/users/eeckstein/events{/privacy}","received_events_url":"https://api.github.com/users/eeckstein/received_events","type":"User","site_admin":false},"repo":{"id":52555464,"node_id":"MDEwOlJlcG9zaXRvcnk1MjU1NTQ2NA==","name":"swift","full_name":"eeckstein/swift","private":false,"owner":{"login":"eeckstein","id":15270291,"node_id":"MDQ6VXNlcjE1MjcwMjkx","avatar_url":"https://avatars0.githubusercontent.com/u/15270291?v=4","gravatar_id":"","url":"https://api.github.com/users/eeckstein","html_url":"https://github.com/eeckstein","followers_url":"https://api.github.com/users/eeckstein/followers","following_url":"https://api.github.com/users/eeckstein/following{/other_user}","gists_url":"https://api.github.com/users/eeckstein/gists{/gist_id}","starred_url":"https://api.github.com/users/eeckstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeckstein/subscriptions","organizations_url":"https://api.github.com/users/eeckstein/orgs","repos_url":"https://api.github.com/users/eeckstein/repos","events_url":"https://api.github.com/users/eeckstein/events{/privacy}","received_events_url":"https://api.github.com/users/eeckstein/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eeckstein/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/eeckstein/swift","forks_url":"https://api.github.com/repos/eeckstein/swift/forks","keys_url":"https://api.github.com/repos/eeckstein/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eeckstein/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eeckstein/swift/teams","hooks_url":"https://api.github.com/repos/eeckstein/swift/hooks","issue_events_url":"https://api.github.com/repos/eeckstein/swift/issues/events{/number}","events_url":"https://api.github.com/repos/eeckstein/swift/events","assignees_url":"https://api.github.com/repos/eeckstein/swift/assignees{/user}","branches_url":"https://api.github.com/repos/eeckstein/swift/branches{/branch}","tags_url":"https://api.github.com/repos/eeckstein/swift/tags","blobs_url":"https://api.github.com/repos/eeckstein/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eeckstein/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eeckstein/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/eeckstein/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eeckstein/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/eeckstein/swift/languages","stargazers_url":"https://api.github.com/repos/eeckstein/swift/stargazers","contributors_url":"https://api.github.com/repos/eeckstein/swift/contributors","subscribers_url":"https://api.github.com/repos/eeckstein/swift/subscribers","subscription_url":"https://api.github.com/repos/eeckstein/swift/subscription","commits_url":"https://api.github.com/repos/eeckstein/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/eeckstein/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/eeckstein/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/eeckstein/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/eeckstein/swift/contents/{+path}","compare_url":"https://api.github.com/repos/eeckstein/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eeckstein/swift/merges","archive_url":"https://api.github.com/repos/eeckstein/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eeckstein/swift/downloads","issues_url":"https://api.github.com/repos/eeckstein/swift/issues{/number}","pulls_url":"https://api.github.com/repos/eeckstein/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/eeckstein/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/eeckstein/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eeckstein/swift/labels{/name}","releases_url":"https://api.github.com/repos/eeckstein/swift/releases{/id}","deployments_url":"https://api.github.com/repos/eeckstein/swift/deployments","created_at":"2016-02-25T20:42:45Z","updated_at":"2016-02-25T20:43:11Z","pushed_at":"2018-12-11T00:14:41Z","git_url":"git://github.com/eeckstein/swift.git","ssh_url":"git@github.com:eeckstein/swift.git","clone_url":"https://github.com/eeckstein/swift.git","svn_url":"https://github.com/eeckstein/swift","homepage":"https://swift.org/","size":337518,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"a8f55022284d13fe9ead95f02e3b6bdedeb0be60","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-12-11T15:59:52Z","pushed_at":"2018-12-11T16:21:29Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":372124,"stargazers_count":46004,"watchers_count":46004,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7309,"mirror_url":null,"archived":false,"open_issues_count":444,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7309,"open_issues":444,"watchers":46004,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/21172"},"html":{"href":"https://github.com/apple/swift/pull/21172"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/21172"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/21172/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/21172/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/21172/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/5c17f0f6f857a6c16e4afbd58b4a36a47dd6f2f6"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"eeckstein","id":15270291,"node_id":"MDQ6VXNlcjE1MjcwMjkx","avatar_url":"https://avatars0.githubusercontent.com/u/15270291?v=4","gravatar_id":"","url":"https://api.github.com/users/eeckstein","html_url":"https://github.com/eeckstein","followers_url":"https://api.github.com/users/eeckstein/followers","following_url":"https://api.github.com/users/eeckstein/following{/other_user}","gists_url":"https://api.github.com/users/eeckstein/gists{/gist_id}","starred_url":"https://api.github.com/users/eeckstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeckstein/subscriptions","organizations_url":"https://api.github.com/users/eeckstein/orgs","repos_url":"https://api.github.com/users/eeckstein/repos","events_url":"https://api.github.com/users/eeckstein/events{/privacy}","received_events_url":"https://api.github.com/users/eeckstein/received_events","type":"User","site_admin":false},"comments":19,"review_comments":8,"maintainer_can_modify":false,"commits":2,"additions":180,"deletions":26,"changed_files":6}}
{"actor":{"display_login":"eeckstein"}}