{"action":"created","issue":{"url":"https://api.github.com/repos/RPCS3/rpcs3/issues/5315","repository_url":"https://api.github.com/repos/RPCS3/rpcs3","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/5315/labels{/name}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/5315/comments","events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/5315/events","html_url":"https://github.com/RPCS3/rpcs3/pull/5315","id":378318235,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDUwOTQ0","number":5315,"title":"[WIP][Testers Needed] rsx: FIFO processing rewrite","user":{"login":"kd-11","id":15904127,"node_id":"MDQ6VXNlcjE1OTA0MTI3","avatar_url":"https://avatars2.githubusercontent.com/u/15904127?v=4","gravatar_id":"","url":"https://api.github.com/users/kd-11","html_url":"https://github.com/kd-11","followers_url":"https://api.github.com/users/kd-11/followers","following_url":"https://api.github.com/users/kd-11/following{/other_user}","gists_url":"https://api.github.com/users/kd-11/gists{/gist_id}","starred_url":"https://api.github.com/users/kd-11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kd-11/subscriptions","organizations_url":"https://api.github.com/users/kd-11/orgs","repos_url":"https://api.github.com/users/kd-11/repos","events_url":"https://api.github.com/users/kd-11/events{/privacy}","received_events_url":"https://api.github.com/users/kd-11/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":37,"created_at":"2018-11-07T14:44:22Z","updated_at":"2018-11-08T21:48:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/5315","html_url":"https://github.com/RPCS3/rpcs3/pull/5315","diff_url":"https://github.com/RPCS3/rpcs3/pull/5315.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/5315.patch"},"body":"This PR essentially does 2 things:\r\n1. Refactors FIFO processing into something more readable, including separation of the main loop from the flattener.\r\n2. Significantly reworks how draw calls are processed. This part is still very unfinished, but the idea is to completely ignore the FIFO begin/end commands and use our own mechanisms to decide where to mark the scope of draw calls. The reorganization and optimization here results in quite a good fps boost in applications that are limited by RSX performance.\r\n\r\nOther minor improvements include:\r\n1. Fixes some minor bug in the surface_store that could return an empty set when asked to get an overlapping list with at least one confirmed hit.\r\n2. Make the FIFO flattener engage dynamically depending on load to avoid slowdown when the extra processing overhead is not required.\r\n\r\nAt some point late in development, I scrapped the older system with the prebuffered queues and optimization passes. The performance hit of FIFO preprocessing was quite high and the prebuffering caused race conditions in poorly synchronized applications. This should be resolved in the final version, which has greatly simplified FIFO processing.\r\n\r\nSo, what does this all mean? Well, you could potentially get a ~10% boost in applications with an RSX bottleneck. This may not mean much for some applications, but the gains are significant at high draw call counts. Most other applications may only show a few fps gain."},"comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments/437168187","html_url":"https://github.com/RPCS3/rpcs3/pull/5315#issuecomment-437168187","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/5315","id":437168187,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzE2ODE4Nw==","user":{"login":"vietnam13231","id":16107604,"node_id":"MDQ6VXNlcjE2MTA3NjA0","avatar_url":"https://avatars1.githubusercontent.com/u/16107604?v=4","gravatar_id":"","url":"https://api.github.com/users/vietnam13231","html_url":"https://github.com/vietnam13231","followers_url":"https://api.github.com/users/vietnam13231/followers","following_url":"https://api.github.com/users/vietnam13231/following{/other_user}","gists_url":"https://api.github.com/users/vietnam13231/gists{/gist_id}","starred_url":"https://api.github.com/users/vietnam13231/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietnam13231/subscriptions","organizations_url":"https://api.github.com/users/vietnam13231/orgs","repos_url":"https://api.github.com/users/vietnam13231/repos","events_url":"https://api.github.com/users/vietnam13231/events{/privacy}","received_events_url":"https://api.github.com/users/vietnam13231/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T21:48:27Z","updated_at":"2018-11-08T21:48:27Z","author_association":"NONE","body":"P5: no changes on my PC.\r\nInfamous: same as Hasster1\r\nETERNAL SONATA: Problem fixed, max FPS (not counting small dives).\r\nNieR Replikant: Back to normal...ish? Plays the same as in master, but crashes whole emulator after exit (though that may be because of SPU LLVM)."}}
{"actor":{"display_login":"vietnam13231"}}