{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/21354","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/21354/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/21354/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/21354/events","html_url":"https://github.com/dotnet/coreclr/issues/21354","id":387314439,"node_id":"MDU6SXNzdWUzODczMTQ0Mzk=","number":21354,"title":"Incorrect culture-specific formatting for Vector64/128/256 types","user":{"login":"jkotas","id":6668460,"node_id":"MDQ6VXNlcjY2Njg0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6668460?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"labels":[{"id":172143003,"node_id":"MDU6TGFiZWwxNzIxNDMwMDM=","url":"https://api.github.com/repos/dotnet/coreclr/labels/bug","name":"bug","color":"1d76db","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dotnet/coreclr/milestones/18","html_url":"https://github.com/dotnet/coreclr/milestone/18","labels_url":"https://api.github.com/repos/dotnet/coreclr/milestones/18/labels","id":3246413,"node_id":"MDk6TWlsZXN0b25lMzI0NjQxMw==","number":18,"title":"3.0","description":".NET Core 3.0, next major release after 2.1. See [official release dates](https://github.com/dotnet/core/blob/master/roadmap.md) for details.\r\n\r\nWe will move important issues from Future to 3.0 as the priorities and dates for next release become more clear.","creator":{"login":"karelz","id":5776068,"node_id":"MDQ6VXNlcjU3NzYwNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5776068?v=4","gravatar_id":"","url":"https://api.github.com/users/karelz","html_url":"https://github.com/karelz","followers_url":"https://api.github.com/users/karelz/followers","following_url":"https://api.github.com/users/karelz/following{/other_user}","gists_url":"https://api.github.com/users/karelz/gists{/gist_id}","starred_url":"https://api.github.com/users/karelz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelz/subscriptions","organizations_url":"https://api.github.com/users/karelz/orgs","repos_url":"https://api.github.com/users/karelz/repos","events_url":"https://api.github.com/users/karelz/events{/privacy}","received_events_url":"https://api.github.com/users/karelz/received_events","type":"User","site_admin":false},"open_issues":276,"closed_issues":378,"state":"open","created_at":"2018-04-05T22:09:22Z","updated_at":"2018-12-04T20:52:32Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-12-04T14:33:37Z","updated_at":"2018-12-04T21:36:03Z","closed_at":null,"author_association":"MEMBER","body":"From https://github.com/tannergooding/coreclr/commit/211d963a42c8988770afa4d2edcbe9be0ed0b8a8#r31551940: \r\n\r\n@tannergooding I do not think that the use of NumberGroupSeparator is correct. NumberGroupSeparator is the string that is used to separate thousands or similar quantities (like 1,000,000,000 in en-US culture). For example, it is . in number of cultures - that would make the formatting here pretty nonsensical.\r\n\r\nI think it is dubious for these vector types to implement IFormattable. I think they should just implement plain vanilla ToString, and do not bother with IFormattable. IFormattable makes sense to types that are meant to be displayed to the user directly. It is not the case here."},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/444267649","html_url":"https://github.com/dotnet/coreclr/issues/21354#issuecomment-444267649","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/21354","id":444267649,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDI2NzY0OQ==","user":{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"created_at":"2018-12-04T21:36:03Z","updated_at":"2018-12-04T21:36:03Z","author_association":"MEMBER","body":"So it sounds like the current suggestion is:\r\n* Remove the `IFormattable` interface\r\n* Remove the `ToString(string)` and `ToString(string, IFormatProvider)` methods\r\n* Update `ToString()` to use CultureInfo.InvariantInfo\r\n* Update `ToString()` to use `G17` for `double` and `G9` for `float` (required so that users can differentiate values, since just `G` won't always allow that today).\r\n\r\nMaybe, longer term, we need something which can logically dictate the correct symbols to use when grouping a collection of items and how the elements should be separated?\r\n-- This seems like a decently common scenario and something we don't have a way to handle today. Users trying to do their own thing will hit the scenarios you listed above."}}
{"actor":{"display_login":"tannergooding"}}