{"action":"created","issue":{"url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/38","repository_url":"https://api.github.com/repos/Ensembl/ensembl-xref","labels_url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/38/comments","events_url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/38/events","html_url":"https://github.com/Ensembl/ensembl-xref/pull/38","id":390753180,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDQ4Mzg5","number":38,"title":"Feature/perlcritic compliance","user":{"login":"avullo","id":6085263,"node_id":"MDQ6VXNlcjYwODUyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/6085263?v=4","gravatar_id":"","url":"https://api.github.com/users/avullo","html_url":"https://github.com/avullo","followers_url":"https://api.github.com/users/avullo/followers","following_url":"https://api.github.com/users/avullo/following{/other_user}","gists_url":"https://api.github.com/users/avullo/gists{/gist_id}","starred_url":"https://api.github.com/users/avullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avullo/subscriptions","organizations_url":"https://api.github.com/users/avullo/orgs","repos_url":"https://api.github.com/users/avullo/repos","events_url":"https://api.github.com/users/avullo/events{/privacy}","received_events_url":"https://api.github.com/users/avullo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-13T16:18:12Z","updated_at":"2018-12-14T07:40:58Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Ensembl/ensembl-xref/pulls/38","html_url":"https://github.com/Ensembl/ensembl-xref/pull/38","diff_url":"https://github.com/Ensembl/ensembl-xref/pull/38.diff","patch_url":"https://github.com/Ensembl/ensembl-xref/pull/38.patch"},"body":"## Requirements\r\n\r\n- Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;\r\n- Review the [contributing guidelines](https://github.com/Ensembl/ensembl/blob/master/CONTRIBUTING.md#why-could-my-pull-request-be-rejected) for this repository; remember in particular:\r\n    - do not modify code without testing for regression\r\n    - provide simple unit tests to test the changes\r\n    - if you change the schema you must patch the test databases as well, see [Updating the schema](https://github.com/Ensembl/ensembl/blob/master/CONTRIBUTING.md#updating-the-schema)\r\n    - the PR must not fail unit testing\r\n\r\n## Description\r\n\r\nRelax constraint at a global level to allow mapper to pass. Refactor some parsers to make them fully compliant.\r\n\r\n## Use case\r\n\r\nperlcritic is failing but cannot waste time at the moment to make it pass the test on the mapper. We have to focus at the moment on getting the thing done. This introduces a temporary relaxation at a global level which prevent to disable critic at file level so that it's more likely we don't forget to address the issue at a later stage.\r\nAt the same time, it fixes some critics on various parsers and make them pass the critic.  \r\n\r\n## Benefits\r\n\r\nOne step closer to having the full test suit pass.\r\n\r\n## Possible Drawbacks\r\n\r\nWe have to remember to address the temporarily disabled critic.\r\n\r\n## Testing\r\n\r\n_Have you added/modified unit tests to test the changes?_\r\n\r\nNo\r\n\r\n_If so, do the tests pass/fail?_\r\n\r\n_Have you run the entire test suite and no regression was detected?_\r\n\r\nYes, except the usual apache bookkeeping and pod failures."},"comment":{"url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/comments/447241832","html_url":"https://github.com/Ensembl/ensembl-xref/pull/38#issuecomment-447241832","issue_url":"https://api.github.com/repos/Ensembl/ensembl-xref/issues/38","id":447241832,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzI0MTgzMg==","user":{"login":"avullo","id":6085263,"node_id":"MDQ6VXNlcjYwODUyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/6085263?v=4","gravatar_id":"","url":"https://api.github.com/users/avullo","html_url":"https://github.com/avullo","followers_url":"https://api.github.com/users/avullo/followers","following_url":"https://api.github.com/users/avullo/following{/other_user}","gists_url":"https://api.github.com/users/avullo/gists{/gist_id}","starred_url":"https://api.github.com/users/avullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avullo/subscriptions","organizations_url":"https://api.github.com/users/avullo/orgs","repos_url":"https://api.github.com/users/avullo/repos","events_url":"https://api.github.com/users/avullo/events{/privacy}","received_events_url":"https://api.github.com/users/avullo/received_events","type":"User","site_admin":false},"created_at":"2018-12-14T07:40:58Z","updated_at":"2018-12-14T07:40:58Z","author_association":"MEMBER","body":"Sorry spoke too early, the arrayexpress test fails, reverting to previous commit."}}
{"actor":{"display_login":"avullo"}}