{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/188797425","pull_request_review_id":120849568,"id":188797425,"diff_hunk":"@@ -135,22 +134,35 @@ UMA_EXEFLAGS+=/INCREMENTAL:NO /NOLOGO /LARGEADDRESSAWARE\n #\t/Zd Add line number info\n #\t/Zi Add symbolic debug info\n #\t/Gd Use C calls (i.e. prepend underscored to symbols)\n-#\n-ASFLAGS+=/c /Cp /W3 /nologo /safeseh /coff /Zm /Zd /Zi /Gd -DWIN32\n+ASFLAGS+=/c /Cp /W3 /nologo /Zd /Zi -DWIN32 -D_WIN32 -DOMR_OS_WINDOWS\n+<#if uma.spec.processor.x86>\n+ASFLAGS+=/safeseh /coff /Zm /Gd\n <#elseif uma.spec.processor.amd64>\n-ASFLAGS+=/c /Cp /W3 /nologo /Zd /Zi  -DWIN32 -DWIN64 -DJ9HAMMER\n+ASFLAGS+=-DWIN64 -D_WIN64 -DJ9HAMMER\n </#if>\n+\n+CFLAGS+=-DWIN32 -D_WIN32 -DOMR_OS_WINDOWS\n+CXXFLAGS+=-DWIN32 -D_WIN32 -DOMR_OS_WINDOWS\n+ifdef USE_MINGW\n+  MINGW_CXXFLAGS+=-DWIN32 -D_WIN32 -DOMR_OS_WINDOWS\n+endif\n+\n <#if uma.spec.processor.amd64>\n-  <#if uma.spec.flags.build_newCompiler.enabled>\n-    CFLAGS+=-D_AMD64_=1 -DWIN64 -D_WIN64 -DWIN32 -D_WIN32 -DJ9HAMMER\n-    CXXFLAGS+=-D_AMD64_=1 -DWIN64 -D_WIN64 -DWIN32 -D_WIN32 -DJ9HAMMER\n-  <#else>\n-    CFLAGS+=-D_AMD64_=1 -DWIN64 -D_WIN64 -DWIN32 -D_WIN32 -DJ9HAMMER /FIPRE64PRA.H -Wp64\n-    CXXFLAGS+=-D_AMD64_=1 -DWIN64 -D_WIN64 -DWIN32 -D_WIN32 -DJ9HAMMER /FIPRE64PRA.H -Wp64\n+  CFLAGS+=-D_AMD64_=1 -DWIN64 -D_WIN64 -DJ9HAMMER\n+  CXXFLAGS+=-D_AMD64_=1 -DWIN64 -D_WIN64 -DJ9HAMMER\n+  <#if !uma.spec.flags.build_newCompiler.enabled>","path":"runtime/makelib/targets.mk.win.inc.ftl","position":37,"original_position":37,"commit_id":"9f469f6ba4a7777831bd9050ddaa6ee7e6742395","original_commit_id":"9f469f6ba4a7777831bd9050ddaa6ee7e6742395","user":{"login":"youngar","id":2892549,"avatar_url":"https://avatars0.githubusercontent.com/u/2892549?v=4","gravatar_id":"","url":"https://api.github.com/users/youngar","html_url":"https://github.com/youngar","followers_url":"https://api.github.com/users/youngar/followers","following_url":"https://api.github.com/users/youngar/following{/other_user}","gists_url":"https://api.github.com/users/youngar/gists{/gist_id}","starred_url":"https://api.github.com/users/youngar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youngar/subscriptions","organizations_url":"https://api.github.com/users/youngar/orgs","repos_url":"https://api.github.com/users/youngar/repos","events_url":"https://api.github.com/users/youngar/events{/privacy}","received_events_url":"https://api.github.com/users/youngar/received_events","type":"User","site_admin":false},"body":"It looks like it is enabled in our specs: \r\n```xml\r\nbuildspecs/j9.flags:159:        <flag id=\"build_newCompiler\">\r\nbuildspecs/win_x86-64.spec:141:         <flag id=\"build_newCompiler\" value=\"true\"/>\r\nbuildspecs/win_x86-64_cmprssptrs.spec:137:              <flag id=\"build_newCompiler\" value=\"true\"/>\r\nbuildspecs/win_x86.spec:140:            <flag id=\"build_newCompiler\" value=\"true\"/>\r\n```\r\nI will delete this flag, but should I delete the compile options?","created_at":"2018-05-16T23:03:48Z","updated_at":"2018-05-16T23:03:48Z","html_url":"https://github.com/eclipse/openj9/pull/1922#discussion_r188797425","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/1922","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/188797425"},"html":{"href":"https://github.com/eclipse/openj9/pull/1922#discussion_r188797425"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/1922"}},"in_reply_to_id":188765705},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/1922","id":188552051,"html_url":"https://github.com/eclipse/openj9/pull/1922","diff_url":"https://github.com/eclipse/openj9/pull/1922.diff","patch_url":"https://github.com/eclipse/openj9/pull/1922.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/1922","number":1922,"state":"open","locked":false,"title":"[WIP] Add new OMR platform define for Windows","user":{"login":"youngar","id":2892549,"avatar_url":"https://avatars0.githubusercontent.com/u/2892549?v=4","gravatar_id":"","url":"https://api.github.com/users/youngar","html_url":"https://github.com/youngar","followers_url":"https://api.github.com/users/youngar/followers","following_url":"https://api.github.com/users/youngar/following{/other_user}","gists_url":"https://api.github.com/users/youngar/gists{/gist_id}","starred_url":"https://api.github.com/users/youngar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youngar/subscriptions","organizations_url":"https://api.github.com/users/youngar/orgs","repos_url":"https://api.github.com/users/youngar/repos","events_url":"https://api.github.com/users/youngar/events{/privacy}","received_events_url":"https://api.github.com/users/youngar/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-16T20:34:10Z","updated_at":"2018-05-16T23:03:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c0ff34109a2fe5102feeffee8e7438b77a606b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/1922/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/1922/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/1922/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/9f469f6ba4a7777831bd9050ddaa6ee7e6742395","head":{"label":"youngar:master","ref":"master","sha":"9f469f6ba4a7777831bd9050ddaa6ee7e6742395","user":{"login":"youngar","id":2892549,"avatar_url":"https://avatars0.githubusercontent.com/u/2892549?v=4","gravatar_id":"","url":"https://api.github.com/users/youngar","html_url":"https://github.com/youngar","followers_url":"https://api.github.com/users/youngar/followers","following_url":"https://api.github.com/users/youngar/following{/other_user}","gists_url":"https://api.github.com/users/youngar/gists{/gist_id}","starred_url":"https://api.github.com/users/youngar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youngar/subscriptions","organizations_url":"https://api.github.com/users/youngar/orgs","repos_url":"https://api.github.com/users/youngar/repos","events_url":"https://api.github.com/users/youngar/events{/privacy}","received_events_url":"https://api.github.com/users/youngar/received_events","type":"User","site_admin":false},"repo":{"id":103953860,"name":"openj9","full_name":"youngar/openj9","owner":{"login":"youngar","id":2892549,"avatar_url":"https://avatars0.githubusercontent.com/u/2892549?v=4","gravatar_id":"","url":"https://api.github.com/users/youngar","html_url":"https://github.com/youngar","followers_url":"https://api.github.com/users/youngar/followers","following_url":"https://api.github.com/users/youngar/following{/other_user}","gists_url":"https://api.github.com/users/youngar/gists{/gist_id}","starred_url":"https://api.github.com/users/youngar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youngar/subscriptions","organizations_url":"https://api.github.com/users/youngar/orgs","repos_url":"https://api.github.com/users/youngar/repos","events_url":"https://api.github.com/users/youngar/events{/privacy}","received_events_url":"https://api.github.com/users/youngar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/youngar/openj9","description":"OpenJ9","fork":true,"url":"https://api.github.com/repos/youngar/openj9","forks_url":"https://api.github.com/repos/youngar/openj9/forks","keys_url":"https://api.github.com/repos/youngar/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youngar/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youngar/openj9/teams","hooks_url":"https://api.github.com/repos/youngar/openj9/hooks","issue_events_url":"https://api.github.com/repos/youngar/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/youngar/openj9/events","assignees_url":"https://api.github.com/repos/youngar/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/youngar/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/youngar/openj9/tags","blobs_url":"https://api.github.com/repos/youngar/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youngar/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youngar/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/youngar/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youngar/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/youngar/openj9/languages","stargazers_url":"https://api.github.com/repos/youngar/openj9/stargazers","contributors_url":"https://api.github.com/repos/youngar/openj9/contributors","subscribers_url":"https://api.github.com/repos/youngar/openj9/subscribers","subscription_url":"https://api.github.com/repos/youngar/openj9/subscription","commits_url":"https://api.github.com/repos/youngar/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/youngar/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/youngar/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/youngar/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/youngar/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/youngar/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youngar/openj9/merges","archive_url":"https://api.github.com/repos/youngar/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youngar/openj9/downloads","issues_url":"https://api.github.com/repos/youngar/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/youngar/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/youngar/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/youngar/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youngar/openj9/labels{/name}","releases_url":"https://api.github.com/repos/youngar/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/youngar/openj9/deployments","created_at":"2017-09-18T15:02:23Z","updated_at":"2018-05-16T20:35:52Z","pushed_at":"2018-05-16T20:35:50Z","git_url":"git://github.com/youngar/openj9.git","ssh_url":"git@github.com:youngar/openj9.git","clone_url":"https://github.com/youngar/openj9.git","svn_url":"https://github.com/youngar/openj9","homepage":null,"size":29306,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"6ba60fd2992afe6b21eb512c06892481a0d0e57b","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"name":"openj9","full_name":"eclipse/openj9","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-05-16T21:15:03Z","pushed_at":"2018-05-16T21:52:03Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":29328,"stargazers_count":1246,"watchers_count":1246,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":253,"mirror_url":null,"archived":false,"open_issues_count":357,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":253,"open_issues":357,"watchers":1246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/1922"},"html":{"href":"https://github.com/eclipse/openj9/pull/1922"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/1922"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/1922/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/1922/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/1922/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/9f469f6ba4a7777831bd9050ddaa6ee7e6742395"}},"author_association":"NONE"}}
{"actor":{"display_login":"youngar"}}