{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/4068","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/4068/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/4068/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/4068/events","html_url":"https://github.com/codice/ddf/pull/4068","id":384461827,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjU5Mjc3","number":4068,"title":"DDF-4333 Convert existing threat models to Threat Dragon format","user":{"login":"brjeter","id":8130140,"node_id":"MDQ6VXNlcjgxMzAxNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/8130140?v=4","gravatar_id":"","url":"https://api.github.com/users/brjeter","html_url":"https://github.com/brjeter","followers_url":"https://api.github.com/users/brjeter/followers","following_url":"https://api.github.com/users/brjeter/following{/other_user}","gists_url":"https://api.github.com/users/brjeter/gists{/gist_id}","starred_url":"https://api.github.com/users/brjeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brjeter/subscriptions","organizations_url":"https://api.github.com/users/brjeter/orgs","repos_url":"https://api.github.com/users/brjeter/repos","events_url":"https://api.github.com/users/brjeter/events{/privacy}","received_events_url":"https://api.github.com/users/brjeter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"assignees":[{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},{"login":"shaundmorris","id":4359166,"node_id":"MDQ6VXNlcjQzNTkxNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/4359166?v=4","gravatar_id":"","url":"https://api.github.com/users/shaundmorris","html_url":"https://github.com/shaundmorris","followers_url":"https://api.github.com/users/shaundmorris/followers","following_url":"https://api.github.com/users/shaundmorris/following{/other_user}","gists_url":"https://api.github.com/users/shaundmorris/gists{/gist_id}","starred_url":"https://api.github.com/users/shaundmorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaundmorris/subscriptions","organizations_url":"https://api.github.com/users/shaundmorris/orgs","repos_url":"https://api.github.com/users/shaundmorris/repos","events_url":"https://api.github.com/users/shaundmorris/events{/privacy}","received_events_url":"https://api.github.com/users/shaundmorris/received_events","type":"User","site_admin":false},{"login":"stustison","id":4391679,"node_id":"MDQ6VXNlcjQzOTE2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4391679?v=4","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-11-26T18:46:49Z","updated_at":"2018-11-26T20:16:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/4068","html_url":"https://github.com/codice/ddf/pull/4068","diff_url":"https://github.com/codice/ddf/pull/4068.diff","patch_url":"https://github.com/codice/ddf/pull/4068.patch"},"body":"#### What does this PR do?\r\nSee the screenshots on this PR for the diagrams.\r\n#### Who is reviewing it? \r\n@Kjames5269 @blen-desta \r\n#### Select relevant component teams: \r\n@codice/security \r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n@coyotesqrl \r\n@shaundmorris\r\n@stustison \r\n#### How should this be tested?\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[DDF-4333](https://codice.atlassian.net/browse/DDF-4333)\r\n#### Screenshots\r\n![image](https://user-images.githubusercontent.com/8130140/49034874-6781ef80-f170-11e8-9312-b9ed78111b0e.png)\r\n![image](https://user-images.githubusercontent.com/8130140/49034898-75377500-f170-11e8-8ec0-a1e3efd17ffd.png)\r\n![image](https://user-images.githubusercontent.com/8130140/49034915-7d8fb000-f170-11e8-8dbd-9ec0abb0e23d.png)\r\n![image](https://user-images.githubusercontent.com/8130140/49034927-86808180-f170-11e8-8865-b234b3271d35.png)\r\n![image](https://user-images.githubusercontent.com/8130140/49034945-9730f780-f170-11e8-8036-db777c3df227.png)\r\n![image](https://user-images.githubusercontent.com/8130140/49034958-a152f600-f170-11e8-8f1d-6fd7f1e3886f.png)\r\n![image](https://user-images.githubusercontent.com/8130140/49034984-b760b680-f170-11e8-918e-5dd175fa276e.png)\r\n![image](https://user-images.githubusercontent.com/8130140/49034998-be87c480-f170-11e8-975c-dc789c474f36.png)\r\n![image](https://user-images.githubusercontent.com/8130140/49035008-c8112c80-f170-11e8-88ce-cc78941573f5.png)\r\n![image](https://user-images.githubusercontent.com/8130140/49035024-d19a9480-f170-11e8-8690-b70f3ff792f6.png)\r\n![image](https://user-images.githubusercontent.com/8130140/49035029-d6f7df00-f170-11e8-94cf-842ffff0f425.png)\r\n![image](https://user-images.githubusercontent.com/8130140/49035041-df501a00-f170-11e8-8bb7-8367a47ec7ea.png)\r\n\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/441782535","html_url":"https://github.com/codice/ddf/pull/4068#issuecomment-441782535","issue_url":"https://api.github.com/repos/codice/ddf/issues/4068","id":441782535,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTc4MjUzNQ==","user":{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"created_at":"2018-11-26T20:16:36Z","updated_at":"2018-11-26T20:16:36Z","author_association":"MEMBER","body":"✏️ In this model, it seems weird to include the interactions between Solr and the file system as those are internal to how Solr works. Unless we should always be including minimized modeling of third-party internals.\r\nhttps://user-images.githubusercontent.com/8130140/49034998-be87c480-f170-11e8-975c-dc789c474f36.png"}}
{"actor":{"display_login":"coyotesqrl"}}