{"action":"created","comment":{"url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls/comments/244968948","pull_request_review_id":188972555,"id":244968948,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDk2ODk0OA==","diff_hunk":"@@ -197,41 +198,56 @@ def RunGroupCommand(self, argin):\n         return argout\n         # PROTECTED REGION END #    //  SKATestDevice.RunGroupCommand\n \n-    def devLogMsg(self, dev_log_msg, dev_log_level):\n+    def dev_logging(self, dev_log_msg, dev_log_level):\n         #Element Level Logging\n-        if self._element_logging_level >= 1 and dev_log_level == 1:\n+        if self._element_logging_level >= int(tango.LogLevel.LOG_FATAL) \\","path":"skabase/SKATestDevice/SKATestDevice/SKATestDevice.py","position":157,"original_position":60,"commit_id":"9980b32a1c9b0e4f1a28269dd898e1d857857cac","original_commit_id":"ff30146dcdcec0a0588d0f0f22c3da69ec5f9683","user":{"login":"lochanitis","id":42574118,"node_id":"MDQ6VXNlcjQyNTc0MTE4","avatar_url":"https://avatars1.githubusercontent.com/u/42574118?v=4","gravatar_id":"","url":"https://api.github.com/users/lochanitis","html_url":"https://github.com/lochanitis","followers_url":"https://api.github.com/users/lochanitis/followers","following_url":"https://api.github.com/users/lochanitis/following{/other_user}","gists_url":"https://api.github.com/users/lochanitis/gists{/gist_id}","starred_url":"https://api.github.com/users/lochanitis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lochanitis/subscriptions","organizations_url":"https://api.github.com/users/lochanitis/orgs","repos_url":"https://api.github.com/users/lochanitis/repos","events_url":"https://api.github.com/users/lochanitis/events{/privacy}","received_events_url":"https://api.github.com/users/lochanitis/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2019-01-03T11:12:45Z","updated_at":"2019-01-03T11:12:45Z","html_url":"https://github.com/ska-telescope/lmc-base-classes/pull/84#discussion_r244968948","pull_request_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls/84","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls/comments/244968948"},"html":{"href":"https://github.com/ska-telescope/lmc-base-classes/pull/84#discussion_r244968948"},"pull_request":{"href":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls/84"}},"in_reply_to_id":244955887},"pull_request":{"url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls/84","id":239478555,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NDc4NTU1","html_url":"https://github.com/ska-telescope/lmc-base-classes/pull/84","diff_url":"https://github.com/ska-telescope/lmc-base-classes/pull/84.diff","patch_url":"https://github.com/ska-telescope/lmc-base-classes/pull/84.patch","issue_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/issues/84","number":84,"state":"open","locked":false,"title":"Logger Class Enhancements","user":{"login":"lochanitis","id":42574118,"node_id":"MDQ6VXNlcjQyNTc0MTE4","avatar_url":"https://avatars1.githubusercontent.com/u/42574118?v=4","gravatar_id":"","url":"https://api.github.com/users/lochanitis","html_url":"https://github.com/lochanitis","followers_url":"https://api.github.com/users/lochanitis/followers","following_url":"https://api.github.com/users/lochanitis/following{/other_user}","gists_url":"https://api.github.com/users/lochanitis/gists{/gist_id}","starred_url":"https://api.github.com/users/lochanitis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lochanitis/subscriptions","organizations_url":"https://api.github.com/users/lochanitis/orgs","repos_url":"https://api.github.com/users/lochanitis/repos","events_url":"https://api.github.com/users/lochanitis/events{/privacy}","received_events_url":"https://api.github.com/users/lochanitis/received_events","type":"User","site_admin":false},"body":"Added functionalities for setting logging levels of Element Logger, Central Logger and Syslog. \r\nAdded function 'devlogmsg' in Test Device to log into different targets using TLS and Python logging.","created_at":"2018-12-18T12:53:30Z","updated_at":"2019-01-03T11:12:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9501d8f75b21b30a1afba30e468df9c6ae2a9aa1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kmadisa","id":16665803,"node_id":"MDQ6VXNlcjE2NjY1ODAz","avatar_url":"https://avatars2.githubusercontent.com/u/16665803?v=4","gravatar_id":"","url":"https://api.github.com/users/kmadisa","html_url":"https://github.com/kmadisa","followers_url":"https://api.github.com/users/kmadisa/followers","following_url":"https://api.github.com/users/kmadisa/following{/other_user}","gists_url":"https://api.github.com/users/kmadisa/gists{/gist_id}","starred_url":"https://api.github.com/users/kmadisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmadisa/subscriptions","organizations_url":"https://api.github.com/users/kmadisa/orgs","repos_url":"https://api.github.com/users/kmadisa/repos","events_url":"https://api.github.com/users/kmadisa/events{/privacy}","received_events_url":"https://api.github.com/users/kmadisa/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls/84/commits","review_comments_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls/84/comments","review_comment_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/issues/84/comments","statuses_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/statuses/9980b32a1c9b0e4f1a28269dd898e1d857857cac","head":{"label":"ska-telescope:lochan","ref":"lochan","sha":"9980b32a1c9b0e4f1a28269dd898e1d857857cac","user":{"login":"ska-telescope","id":31858908,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODU4OTA4","avatar_url":"https://avatars0.githubusercontent.com/u/31858908?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-telescope","html_url":"https://github.com/ska-telescope","followers_url":"https://api.github.com/users/ska-telescope/followers","following_url":"https://api.github.com/users/ska-telescope/following{/other_user}","gists_url":"https://api.github.com/users/ska-telescope/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-telescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-telescope/subscriptions","organizations_url":"https://api.github.com/users/ska-telescope/orgs","repos_url":"https://api.github.com/users/ska-telescope/repos","events_url":"https://api.github.com/users/ska-telescope/events{/privacy}","received_events_url":"https://api.github.com/users/ska-telescope/received_events","type":"Organization","site_admin":false},"repo":{"id":98997157,"node_id":"MDEwOlJlcG9zaXRvcnk5ODk5NzE1Nw==","name":"lmc-base-classes","full_name":"ska-telescope/lmc-base-classes","private":false,"owner":{"login":"ska-telescope","id":31858908,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODU4OTA4","avatar_url":"https://avatars0.githubusercontent.com/u/31858908?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-telescope","html_url":"https://github.com/ska-telescope","followers_url":"https://api.github.com/users/ska-telescope/followers","following_url":"https://api.github.com/users/ska-telescope/following{/other_user}","gists_url":"https://api.github.com/users/ska-telescope/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-telescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-telescope/subscriptions","organizations_url":"https://api.github.com/users/ska-telescope/orgs","repos_url":"https://api.github.com/users/ska-telescope/repos","events_url":"https://api.github.com/users/ska-telescope/events{/privacy}","received_events_url":"https://api.github.com/users/ska-telescope/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ska-telescope/lmc-base-classes","description":"LMC Base Classes Software Development Kit Project","fork":false,"url":"https://api.github.com/repos/ska-telescope/lmc-base-classes","forks_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/forks","keys_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/teams","hooks_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/hooks","issue_events_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/issues/events{/number}","events_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/events","assignees_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/assignees{/user}","branches_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/branches{/branch}","tags_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/tags","blobs_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/languages","stargazers_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/stargazers","contributors_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/contributors","subscribers_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/subscribers","subscription_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/subscription","commits_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/contents/{+path}","compare_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/merges","archive_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/downloads","issues_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/issues{/number}","pulls_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/labels{/name}","releases_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/releases{/id}","deployments_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/deployments","created_at":"2017-08-01T12:08:59Z","updated_at":"2018-12-11T09:24:27Z","pushed_at":"2019-01-03T10:25:02Z","git_url":"git://github.com/ska-telescope/lmc-base-classes.git","ssh_url":"git@github.com:ska-telescope/lmc-base-classes.git","clone_url":"https://github.com/ska-telescope/lmc-base-classes.git","svn_url":"https://github.com/ska-telescope/lmc-base-classes","homepage":"","size":1172,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"ska-telescope:master","ref":"master","sha":"cad1def8290087d2cf8819d9f344a2d8b741a089","user":{"login":"ska-telescope","id":31858908,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODU4OTA4","avatar_url":"https://avatars0.githubusercontent.com/u/31858908?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-telescope","html_url":"https://github.com/ska-telescope","followers_url":"https://api.github.com/users/ska-telescope/followers","following_url":"https://api.github.com/users/ska-telescope/following{/other_user}","gists_url":"https://api.github.com/users/ska-telescope/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-telescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-telescope/subscriptions","organizations_url":"https://api.github.com/users/ska-telescope/orgs","repos_url":"https://api.github.com/users/ska-telescope/repos","events_url":"https://api.github.com/users/ska-telescope/events{/privacy}","received_events_url":"https://api.github.com/users/ska-telescope/received_events","type":"Organization","site_admin":false},"repo":{"id":98997157,"node_id":"MDEwOlJlcG9zaXRvcnk5ODk5NzE1Nw==","name":"lmc-base-classes","full_name":"ska-telescope/lmc-base-classes","private":false,"owner":{"login":"ska-telescope","id":31858908,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODU4OTA4","avatar_url":"https://avatars0.githubusercontent.com/u/31858908?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-telescope","html_url":"https://github.com/ska-telescope","followers_url":"https://api.github.com/users/ska-telescope/followers","following_url":"https://api.github.com/users/ska-telescope/following{/other_user}","gists_url":"https://api.github.com/users/ska-telescope/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-telescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-telescope/subscriptions","organizations_url":"https://api.github.com/users/ska-telescope/orgs","repos_url":"https://api.github.com/users/ska-telescope/repos","events_url":"https://api.github.com/users/ska-telescope/events{/privacy}","received_events_url":"https://api.github.com/users/ska-telescope/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ska-telescope/lmc-base-classes","description":"LMC Base Classes Software Development Kit Project","fork":false,"url":"https://api.github.com/repos/ska-telescope/lmc-base-classes","forks_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/forks","keys_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/teams","hooks_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/hooks","issue_events_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/issues/events{/number}","events_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/events","assignees_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/assignees{/user}","branches_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/branches{/branch}","tags_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/tags","blobs_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/languages","stargazers_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/stargazers","contributors_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/contributors","subscribers_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/subscribers","subscription_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/subscription","commits_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/contents/{+path}","compare_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/merges","archive_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/downloads","issues_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/issues{/number}","pulls_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/labels{/name}","releases_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/releases{/id}","deployments_url":"https://api.github.com/repos/ska-telescope/lmc-base-classes/deployments","created_at":"2017-08-01T12:08:59Z","updated_at":"2018-12-11T09:24:27Z","pushed_at":"2019-01-03T10:25:02Z","git_url":"git://github.com/ska-telescope/lmc-base-classes.git","ssh_url":"git@github.com:ska-telescope/lmc-base-classes.git","clone_url":"https://github.com/ska-telescope/lmc-base-classes.git","svn_url":"https://github.com/ska-telescope/lmc-base-classes","homepage":"","size":1172,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls/84"},"html":{"href":"https://github.com/ska-telescope/lmc-base-classes/pull/84"},"issue":{"href":"https://api.github.com/repos/ska-telescope/lmc-base-classes/issues/84"},"comments":{"href":"https://api.github.com/repos/ska-telescope/lmc-base-classes/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ska-telescope/lmc-base-classes/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/ska-telescope/lmc-base-classes/statuses/9980b32a1c9b0e4f1a28269dd898e1d857857cac"}},"author_association":"NONE"}}
{"actor":{"display_login":"lochanitis"}}