{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/211651619","pull_request_review_id":148118567,"id":211651619,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTY1MTYxOQ==","diff_hunk":"@@ -47,11 +47,7 @@ const (\n // Cluster type based on resolution\n // For inbound (sidecar only): Cluster for each inbound endpoint port and for each service port\n func (configgen *ConfigGeneratorImpl) BuildClusters(env *model.Environment, proxy *model.Proxy, push *model.PushContext) ([]*v2.Cluster, error) {\n-\tclusters := make([]*v2.Cluster, 0)\n-\n-\tservices := push.Services\n-\n-\tclusters = append(clusters, configgen.buildOutboundClusters(env, proxy, push, services)...)","path":"pilot/pkg/networking/core/v1alpha3/cluster.go","position":8,"original_position":8,"commit_id":"be35a5f9f91461704d0b3b417459b3a4e4c9d31e","original_commit_id":"be35a5f9f91461704d0b3b417459b3a4e4c9d31e","user":{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"please undo this change.. this file is changing in another PR and the logic below is also going to change","created_at":"2018-08-21T15:29:52Z","updated_at":"2018-08-21T15:29:52Z","html_url":"https://github.com/istio/istio/pull/8102#discussion_r211651619","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/8102","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/211651619"},"html":{"href":"https://github.com/istio/istio/pull/8102#discussion_r211651619"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/8102"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/8102","id":209756210,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NzU2MjEw","html_url":"https://github.com/istio/istio/pull/8102","diff_url":"https://github.com/istio/istio/pull/8102.diff","patch_url":"https://github.com/istio/istio/pull/8102.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/8102","number":8102,"state":"open","locked":false,"title":"cleanup in pilot","user":{"login":"hzxuzhonghu","id":13374016,"node_id":"MDQ6VXNlcjEzMzc0MDE2","avatar_url":"https://avatars3.githubusercontent.com/u/13374016?v=4","gravatar_id":"","url":"https://api.github.com/users/hzxuzhonghu","html_url":"https://github.com/hzxuzhonghu","followers_url":"https://api.github.com/users/hzxuzhonghu/followers","following_url":"https://api.github.com/users/hzxuzhonghu/following{/other_user}","gists_url":"https://api.github.com/users/hzxuzhonghu/gists{/gist_id}","starred_url":"https://api.github.com/users/hzxuzhonghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzxuzhonghu/subscriptions","organizations_url":"https://api.github.com/users/hzxuzhonghu/orgs","repos_url":"https://api.github.com/users/hzxuzhonghu/repos","events_url":"https://api.github.com/users/hzxuzhonghu/events{/privacy}","received_events_url":"https://api.github.com/users/hzxuzhonghu/received_events","type":"User","site_admin":false},"body":"This is minor cleanup.","created_at":"2018-08-21T09:06:25Z","updated_at":"2018-08-21T15:29:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"867d4cbe892229be7cb1ce1c4ca93d57c7842c16","assignee":{"login":"ZackButcher","id":1923135,"node_id":"MDQ6VXNlcjE5MjMxMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1923135?v=4","gravatar_id":"","url":"https://api.github.com/users/ZackButcher","html_url":"https://github.com/ZackButcher","followers_url":"https://api.github.com/users/ZackButcher/followers","following_url":"https://api.github.com/users/ZackButcher/following{/other_user}","gists_url":"https://api.github.com/users/ZackButcher/gists{/gist_id}","starred_url":"https://api.github.com/users/ZackButcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZackButcher/subscriptions","organizations_url":"https://api.github.com/users/ZackButcher/orgs","repos_url":"https://api.github.com/users/ZackButcher/repos","events_url":"https://api.github.com/users/ZackButcher/events{/privacy}","received_events_url":"https://api.github.com/users/ZackButcher/received_events","type":"User","site_admin":false},"assignees":[{"login":"ZackButcher","id":1923135,"node_id":"MDQ6VXNlcjE5MjMxMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1923135?v=4","gravatar_id":"","url":"https://api.github.com/users/ZackButcher","html_url":"https://github.com/ZackButcher","followers_url":"https://api.github.com/users/ZackButcher/followers","following_url":"https://api.github.com/users/ZackButcher/following{/other_user}","gists_url":"https://api.github.com/users/ZackButcher/gists{/gist_id}","starred_url":"https://api.github.com/users/ZackButcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZackButcher/subscriptions","organizations_url":"https://api.github.com/users/ZackButcher/orgs","repos_url":"https://api.github.com/users/ZackButcher/repos","events_url":"https://api.github.com/users/ZackButcher/events{/privacy}","received_events_url":"https://api.github.com/users/ZackButcher/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/8102/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/8102/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/8102/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/be35a5f9f91461704d0b3b417459b3a4e4c9d31e","head":{"label":"hzxuzhonghu:rm-nolint","ref":"rm-nolint","sha":"be35a5f9f91461704d0b3b417459b3a4e4c9d31e","user":{"login":"hzxuzhonghu","id":13374016,"node_id":"MDQ6VXNlcjEzMzc0MDE2","avatar_url":"https://avatars3.githubusercontent.com/u/13374016?v=4","gravatar_id":"","url":"https://api.github.com/users/hzxuzhonghu","html_url":"https://github.com/hzxuzhonghu","followers_url":"https://api.github.com/users/hzxuzhonghu/followers","following_url":"https://api.github.com/users/hzxuzhonghu/following{/other_user}","gists_url":"https://api.github.com/users/hzxuzhonghu/gists{/gist_id}","starred_url":"https://api.github.com/users/hzxuzhonghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzxuzhonghu/subscriptions","organizations_url":"https://api.github.com/users/hzxuzhonghu/orgs","repos_url":"https://api.github.com/users/hzxuzhonghu/repos","events_url":"https://api.github.com/users/hzxuzhonghu/events{/privacy}","received_events_url":"https://api.github.com/users/hzxuzhonghu/received_events","type":"User","site_admin":false},"repo":{"id":139953100,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5NTMxMDA=","name":"istio","full_name":"hzxuzhonghu/istio","owner":{"login":"hzxuzhonghu","id":13374016,"node_id":"MDQ6VXNlcjEzMzc0MDE2","avatar_url":"https://avatars3.githubusercontent.com/u/13374016?v=4","gravatar_id":"","url":"https://api.github.com/users/hzxuzhonghu","html_url":"https://github.com/hzxuzhonghu","followers_url":"https://api.github.com/users/hzxuzhonghu/followers","following_url":"https://api.github.com/users/hzxuzhonghu/following{/other_user}","gists_url":"https://api.github.com/users/hzxuzhonghu/gists{/gist_id}","starred_url":"https://api.github.com/users/hzxuzhonghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzxuzhonghu/subscriptions","organizations_url":"https://api.github.com/users/hzxuzhonghu/orgs","repos_url":"https://api.github.com/users/hzxuzhonghu/repos","events_url":"https://api.github.com/users/hzxuzhonghu/events{/privacy}","received_events_url":"https://api.github.com/users/hzxuzhonghu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hzxuzhonghu/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/hzxuzhonghu/istio","forks_url":"https://api.github.com/repos/hzxuzhonghu/istio/forks","keys_url":"https://api.github.com/repos/hzxuzhonghu/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hzxuzhonghu/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hzxuzhonghu/istio/teams","hooks_url":"https://api.github.com/repos/hzxuzhonghu/istio/hooks","issue_events_url":"https://api.github.com/repos/hzxuzhonghu/istio/issues/events{/number}","events_url":"https://api.github.com/repos/hzxuzhonghu/istio/events","assignees_url":"https://api.github.com/repos/hzxuzhonghu/istio/assignees{/user}","branches_url":"https://api.github.com/repos/hzxuzhonghu/istio/branches{/branch}","tags_url":"https://api.github.com/repos/hzxuzhonghu/istio/tags","blobs_url":"https://api.github.com/repos/hzxuzhonghu/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hzxuzhonghu/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hzxuzhonghu/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/hzxuzhonghu/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hzxuzhonghu/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/hzxuzhonghu/istio/languages","stargazers_url":"https://api.github.com/repos/hzxuzhonghu/istio/stargazers","contributors_url":"https://api.github.com/repos/hzxuzhonghu/istio/contributors","subscribers_url":"https://api.github.com/repos/hzxuzhonghu/istio/subscribers","subscription_url":"https://api.github.com/repos/hzxuzhonghu/istio/subscription","commits_url":"https://api.github.com/repos/hzxuzhonghu/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/hzxuzhonghu/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/hzxuzhonghu/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/hzxuzhonghu/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/hzxuzhonghu/istio/contents/{+path}","compare_url":"https://api.github.com/repos/hzxuzhonghu/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hzxuzhonghu/istio/merges","archive_url":"https://api.github.com/repos/hzxuzhonghu/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hzxuzhonghu/istio/downloads","issues_url":"https://api.github.com/repos/hzxuzhonghu/istio/issues{/number}","pulls_url":"https://api.github.com/repos/hzxuzhonghu/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/hzxuzhonghu/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/hzxuzhonghu/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hzxuzhonghu/istio/labels{/name}","releases_url":"https://api.github.com/repos/hzxuzhonghu/istio/releases{/id}","deployments_url":"https://api.github.com/repos/hzxuzhonghu/istio/deployments","created_at":"2018-07-06T08:03:09Z","updated_at":"2018-07-06T08:03:17Z","pushed_at":"2018-08-21T11:54:26Z","git_url":"git://github.com/hzxuzhonghu/istio.git","ssh_url":"git@github.com:hzxuzhonghu/istio.git","clone_url":"https://github.com/hzxuzhonghu/istio.git","svn_url":"https://github.com/hzxuzhonghu/istio","homepage":"https://istio.io","size":45715,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"8f279d9c126fd30c6e497ae85be836da0f272909","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-08-21T15:28:15Z","pushed_at":"2018-08-21T15:27:55Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":46261,"stargazers_count":10982,"watchers_count":10982,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1568,"mirror_url":null,"archived":false,"open_issues_count":915,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1568,"open_issues":915,"watchers":10982,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/8102"},"html":{"href":"https://github.com/istio/istio/pull/8102"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/8102"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/8102/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/8102/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/8102/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/be35a5f9f91461704d0b3b417459b3a4e4c9d31e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rshriram"}}