{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69103","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69103/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69103/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69103/events","html_url":"https://github.com/kubernetes/kubernetes/pull/69103","id":364090535,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MzYxOTc4","number":69103,"title":"E2E: handling extra files","user":{"login":"pohly","id":22076,"node_id":"MDQ6VXNlcjIyMDc2","avatar_url":"https://avatars1.githubusercontent.com/u/22076?v=4","gravatar_id":"","url":"https://api.github.com/users/pohly","html_url":"https://github.com/pohly","followers_url":"https://api.github.com/users/pohly/followers","following_url":"https://api.github.com/users/pohly/following{/other_user}","gists_url":"https://api.github.com/users/pohly/gists{/gist_id}","starred_url":"https://api.github.com/users/pohly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pohly/subscriptions","organizations_url":"https://api.github.com/users/pohly/orgs","repos_url":"https://api.github.com/users/pohly/repos","events_url":"https://api.github.com/users/pohly/events{/privacy}","received_events_url":"https://api.github.com/users/pohly/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253451057,"node_id":"MDU6TGFiZWwyNTM0NTEwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"timothysc","id":169553,"node_id":"MDQ6VXNlcjE2OTU1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"assignees":[{"login":"timothysc","id":169553,"node_id":"MDQ6VXNlcjE2OTU1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-09-26T15:31:46Z","updated_at":"2018-10-02T01:11:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69103","html_url":"https://github.com/kubernetes/kubernetes/pull/69103","diff_url":"https://github.com/kubernetes/kubernetes/pull/69103.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/69103.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThere is an on-going effort to make test/e2e.test self-contained by building all files that are needed at runtime into the binary via bindata. Tests which support that do so by retrieving files from the test/e2e/generated package. The downside of that approach is that such tests only work in Kubernetes itself. As described in issue #66649, making tests reusable outside of Kubernetes is useful, for example for testing other CSI drivers.\r\n\r\nThis PR adds an API (test/e2e/framework/testfiles) that decouples tests from the actual code that retrieves files. In the test/e2e test suite, access via --repo-root is kept in addition to retrieval from bindata, so everything works as before.\r\n\r\nThe goal is *not* to get rid of --repo-root. However, by converting some tests to use the new API, those tests no longer depend on --repo-root, so we get a step closer to that goal - if it still is a goal. Some tests depend on extra files (for example, test/e2e/framework/ingress/ingress_utils.go for providing the optional secret.yaml) which cannot be built into the binary.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nPartial fix #66649 (main goal)\r\nPartial fix #23987 (side effect)\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThis depends on PR #68187 getting merged first. The first commit here is from that PR.\r\n\r\nThis is a subset of PR #68483.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n\r\n/sig testing"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/426113915","html_url":"https://github.com/kubernetes/kubernetes/pull/69103#issuecomment-426113915","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69103","id":426113915,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjExMzkxNQ==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T01:11:57Z","updated_at":"2018-10-02T01:11:57Z","author_association":"CONTRIBUTOR","body":"@pohly: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-bazel-test | 318aa5e7d35dbc6bbb5ce88d62f5f7a4416ff6c4 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69103/pull-kubernetes-bazel-test/62150/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-gce | 318aa5e7d35dbc6bbb5ce88d62f5f7a4416ff6c4 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69103/pull-kubernetes-e2e-gce/54426/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-kops-aws | 318aa5e7d35dbc6bbb5ce88d62f5f7a4416ff6c4 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69103/pull-kubernetes-e2e-kops-aws/107923/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-bazel-build | 318aa5e7d35dbc6bbb5ce88d62f5f7a4416ff6c4 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69103/pull-kubernetes-bazel-build/59568/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-typecheck | 318aa5e7d35dbc6bbb5ce88d62f5f7a4416ff6c4 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69103/pull-kubernetes-typecheck/26343/) | `/test pull-kubernetes-typecheck`\npull-kubernetes-e2e-gce-100-performance | 318aa5e7d35dbc6bbb5ce88d62f5f7a4416ff6c4 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69103/pull-kubernetes-e2e-gce-100-performance/21709/) | `/test pull-kubernetes-e2e-gce-100-performance`\npull-kubernetes-node-e2e | 318aa5e7d35dbc6bbb5ce88d62f5f7a4416ff6c4 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69103/pull-kubernetes-node-e2e/106073/) | `/test pull-kubernetes-node-e2e`\npull-kubernetes-kubemark-e2e-gce-big | 318aa5e7d35dbc6bbb5ce88d62f5f7a4416ff6c4 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69103/pull-kubernetes-kubemark-e2e-gce-big/23904/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/69103). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/pohly). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}