{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/170751226","pull_request_review_id":99485573,"id":170751226,"diff_hunk":"@@ -78,16 +78,14 @@ def set_tags(tag_source)\n     @tags = tag_source.tags\n   end\n \n-  # Return a copy of the tag list, so someone can't ask for our tags\n-  # and then modify them.\n   def tags\n     @tags ||= new_tags\n-    @tags.dup\n+    @tags","path":"lib/puppet/util/tagging.rb","position":9,"original_position":9,"commit_id":"44d44f1263cffa1021bc77dc4374ccebad2d53ce","original_commit_id":"44d44f1263cffa1021bc77dc4374ccebad2d53ce","user":{"login":"pcarlisle","id":1234752,"avatar_url":"https://avatars0.githubusercontent.com/u/1234752?v=4","gravatar_id":"","url":"https://api.github.com/users/pcarlisle","html_url":"https://github.com/pcarlisle","followers_url":"https://api.github.com/users/pcarlisle/followers","following_url":"https://api.github.com/users/pcarlisle/following{/other_user}","gists_url":"https://api.github.com/users/pcarlisle/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarlisle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarlisle/subscriptions","organizations_url":"https://api.github.com/users/pcarlisle/orgs","repos_url":"https://api.github.com/users/pcarlisle/repos","events_url":"https://api.github.com/users/pcarlisle/events{/privacy}","received_events_url":"https://api.github.com/users/pcarlisle/received_events","type":"User","site_admin":false},"body":"definitely need a second opinion on the safety of this change","created_at":"2018-02-26T22:03:55Z","updated_at":"2018-02-26T22:03:55Z","html_url":"https://github.com/puppetlabs/puppet/pull/6683#discussion_r170751226","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6683","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/170751226"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/6683#discussion_r170751226"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6683"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6683","id":171502332,"html_url":"https://github.com/puppetlabs/puppet/pull/6683","diff_url":"https://github.com/puppetlabs/puppet/pull/6683.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/6683.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/6683","number":6683,"state":"open","locked":false,"title":"(maint) Some minor improvements to garbage generation","user":{"login":"pcarlisle","id":1234752,"avatar_url":"https://avatars0.githubusercontent.com/u/1234752?v=4","gravatar_id":"","url":"https://api.github.com/users/pcarlisle","html_url":"https://github.com/pcarlisle","followers_url":"https://api.github.com/users/pcarlisle/followers","following_url":"https://api.github.com/users/pcarlisle/following{/other_user}","gists_url":"https://api.github.com/users/pcarlisle/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarlisle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarlisle/subscriptions","organizations_url":"https://api.github.com/users/pcarlisle/orgs","repos_url":"https://api.github.com/users/pcarlisle/repos","events_url":"https://api.github.com/users/pcarlisle/events{/privacy}","received_events_url":"https://api.github.com/users/pcarlisle/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-02-26T21:53:03Z","updated_at":"2018-02-26T22:03:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c12768520135e37cd5c7ea22a47b05c3399d999c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6683/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6683/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/6683/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/44d44f1263cffa1021bc77dc4374ccebad2d53ce","head":{"label":"pcarlisle:minor-garbage-fixes","ref":"minor-garbage-fixes","sha":"44d44f1263cffa1021bc77dc4374ccebad2d53ce","user":{"login":"pcarlisle","id":1234752,"avatar_url":"https://avatars0.githubusercontent.com/u/1234752?v=4","gravatar_id":"","url":"https://api.github.com/users/pcarlisle","html_url":"https://github.com/pcarlisle","followers_url":"https://api.github.com/users/pcarlisle/followers","following_url":"https://api.github.com/users/pcarlisle/following{/other_user}","gists_url":"https://api.github.com/users/pcarlisle/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarlisle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarlisle/subscriptions","organizations_url":"https://api.github.com/users/pcarlisle/orgs","repos_url":"https://api.github.com/users/pcarlisle/repos","events_url":"https://api.github.com/users/pcarlisle/events{/privacy}","received_events_url":"https://api.github.com/users/pcarlisle/received_events","type":"User","site_admin":false},"repo":{"id":2894917,"name":"puppet","full_name":"pcarlisle/puppet","owner":{"login":"pcarlisle","id":1234752,"avatar_url":"https://avatars0.githubusercontent.com/u/1234752?v=4","gravatar_id":"","url":"https://api.github.com/users/pcarlisle","html_url":"https://github.com/pcarlisle","followers_url":"https://api.github.com/users/pcarlisle/followers","following_url":"https://api.github.com/users/pcarlisle/following{/other_user}","gists_url":"https://api.github.com/users/pcarlisle/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarlisle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarlisle/subscriptions","organizations_url":"https://api.github.com/users/pcarlisle/orgs","repos_url":"https://api.github.com/users/pcarlisle/repos","events_url":"https://api.github.com/users/pcarlisle/events{/privacy}","received_events_url":"https://api.github.com/users/pcarlisle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pcarlisle/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/pcarlisle/puppet","forks_url":"https://api.github.com/repos/pcarlisle/puppet/forks","keys_url":"https://api.github.com/repos/pcarlisle/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcarlisle/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcarlisle/puppet/teams","hooks_url":"https://api.github.com/repos/pcarlisle/puppet/hooks","issue_events_url":"https://api.github.com/repos/pcarlisle/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/pcarlisle/puppet/events","assignees_url":"https://api.github.com/repos/pcarlisle/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/pcarlisle/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/pcarlisle/puppet/tags","blobs_url":"https://api.github.com/repos/pcarlisle/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcarlisle/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcarlisle/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcarlisle/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcarlisle/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/pcarlisle/puppet/languages","stargazers_url":"https://api.github.com/repos/pcarlisle/puppet/stargazers","contributors_url":"https://api.github.com/repos/pcarlisle/puppet/contributors","subscribers_url":"https://api.github.com/repos/pcarlisle/puppet/subscribers","subscription_url":"https://api.github.com/repos/pcarlisle/puppet/subscription","commits_url":"https://api.github.com/repos/pcarlisle/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcarlisle/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcarlisle/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcarlisle/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcarlisle/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/pcarlisle/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcarlisle/puppet/merges","archive_url":"https://api.github.com/repos/pcarlisle/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcarlisle/puppet/downloads","issues_url":"https://api.github.com/repos/pcarlisle/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/pcarlisle/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/pcarlisle/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/pcarlisle/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcarlisle/puppet/labels{/name}","releases_url":"https://api.github.com/repos/pcarlisle/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/pcarlisle/puppet/deployments","created_at":"2011-12-01T23:27:50Z","updated_at":"2014-05-08T23:45:26Z","pushed_at":"2018-02-26T22:03:04Z","git_url":"git://github.com/pcarlisle/puppet.git","ssh_url":"git@github.com:pcarlisle/puppet.git","clone_url":"https://github.com/pcarlisle/puppet.git","svn_url":"https://github.com/pcarlisle/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":62932,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"5d3dfc059723d7b7e3ee401a3de6fec48f83463a","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2018-02-26T21:54:39Z","pushed_at":"2018-02-26T22:03:06Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":63361,"stargazers_count":4900,"watchers_count":4900,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1985,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1985,"open_issues":41,"watchers":4900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6683"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/6683"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/6683"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/6683/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6683/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6683/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/44d44f1263cffa1021bc77dc4374ccebad2d53ce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pcarlisle"}}