{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/18910","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/18910/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/18910/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/18910/events","html_url":"https://github.com/ampproject/amphtml/pull/18910","id":373230640,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjA4NzI3","number":18910,"title":"✨amp-consent v2: Fullscreen API Support & UX","user":{"login":"torch2424","id":1448289,"node_id":"MDQ6VXNlcjE0NDgyODk=","avatar_url":"https://avatars1.githubusercontent.com/u/1448289?v=4","gravatar_id":"","url":"https://api.github.com/users/torch2424","html_url":"https://github.com/torch2424","followers_url":"https://api.github.com/users/torch2424/followers","following_url":"https://api.github.com/users/torch2424/following{/other_user}","gists_url":"https://api.github.com/users/torch2424/gists{/gist_id}","starred_url":"https://api.github.com/users/torch2424/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch2424/subscriptions","organizations_url":"https://api.github.com/users/torch2424/orgs","repos_url":"https://api.github.com/users/torch2424/repos","events_url":"https://api.github.com/users/torch2424/events{/privacy}","received_events_url":"https://api.github.com/users/torch2424/received_events","type":"User","site_admin":false},"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"zhouyx","id":5419904,"node_id":"MDQ6VXNlcjU0MTk5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"assignees":[{"login":"zhouyx","id":5419904,"node_id":"MDQ6VXNlcjU0MTk5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},{"login":"lannka","id":8496897,"node_id":"MDQ6VXNlcjg0OTY4OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8496897?v=4","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-10-23T22:33:47Z","updated_at":"2018-11-16T23:35:43Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/18910","html_url":"https://github.com/ampproject/amphtml/pull/18910","diff_url":"https://github.com/ampproject/amphtml/pull/18910.diff","patch_url":"https://github.com/ampproject/amphtml/pull/18910.patch"},"body":"relates to #18828\r\n\r\n* Added a JS API for `.postMessage` on the parent frame to request fullscreen, and exit fullscreen.\r\n* Added CSS to support a smoot transition between consent frame states. Using CSS3 Transisitions, and CSS3 3DTransforms (For GPU Acceleration).\r\n* Fixed Linting Warnings for Error Messages\r\n* Updated `/test/manual/diy-consent.html`\r\n\r\nConsole Errors were there before this PR, as they manually add a top to the consent element. Perhaps @zhouyx would have context on why that is 😄 \r\n\r\n# Example\r\n\r\n**After PR Comments**\r\n\r\n![ampconsentfullscreen](https://user-images.githubusercontent.com/1448289/47882623-62d35100-dde7-11e8-983e-f06091b01dd6.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/439560976","html_url":"https://github.com/ampproject/amphtml/pull/18910#issuecomment-439560976","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/18910","id":439560976,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTU2MDk3Ng==","user":{"login":"torch2424","id":1448289,"node_id":"MDQ6VXNlcjE0NDgyODk=","avatar_url":"https://avatars1.githubusercontent.com/u/1448289?v=4","gravatar_id":"","url":"https://api.github.com/users/torch2424","html_url":"https://github.com/torch2424","followers_url":"https://api.github.com/users/torch2424/followers","following_url":"https://api.github.com/users/torch2424/following{/other_user}","gists_url":"https://api.github.com/users/torch2424/gists{/gist_id}","starred_url":"https://api.github.com/users/torch2424/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch2424/subscriptions","organizations_url":"https://api.github.com/users/torch2424/orgs","repos_url":"https://api.github.com/users/torch2424/repos","events_url":"https://api.github.com/users/torch2424/events{/privacy}","received_events_url":"https://api.github.com/users/torch2424/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T23:35:43Z","updated_at":"2018-11-16T23:35:43Z","author_association":"MEMBER","body":"Discussed offline with @zhouyx We agreed that we should keep the class names so that in the CMP case they are forced to follow our UI Flow. This is because of several reasons:\r\n\r\n1. Publishers that want a custom UI probably want to not use a CMP anyways, and roll their own\r\n\r\n2. CMPs may not necessarily have responsive content in their iframe, and allowing publishers to dynamically do anything with their content could make things more difficult for all parties.\r\n\r\n3. We can always offer alternative UIs in the CMP config that we offer. From meetings with CMPs, some already have a system where the user picks one of X UIs to use on their website.\r\n\r\nTherefore, for our MVP, we will be enforcing the footer bar, to slide in from bottom UI."}}
{"actor":{"display_login":"torch2424"}}