{"action":"created","issue":{"url":"https://api.github.com/repos/jetstack/cert-manager/issues/309","repository_url":"https://api.github.com/repos/jetstack/cert-manager","labels_url":"https://api.github.com/repos/jetstack/cert-manager/issues/309/labels{/name}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/issues/309/comments","events_url":"https://api.github.com/repos/jetstack/cert-manager/issues/309/events","html_url":"https://github.com/jetstack/cert-manager/pull/309","id":296049198,"number":309,"title":"WIP: Rewrite ACME issuer for v2, and make validation process asynchronous","user":{"login":"munnerz","id":203583,"avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false},"labels":[{"id":728658007,"url":"https://api.github.com/repos/jetstack/cert-manager/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":727722560,"url":"https://api.github.com/repos/jetstack/cert-manager/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":728658202,"url":"https://api.github.com/repos/jetstack/cert-manager/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jetstack/cert-manager/milestones/6","html_url":"https://github.com/jetstack/cert-manager/milestone/6","labels_url":"https://api.github.com/repos/jetstack/cert-manager/milestones/6/labels","id":2886634,"number":6,"title":"v0.3","description":"","creator":{"login":"munnerz","id":203583,"avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":6,"state":"open","created_at":"2017-11-03T18:01:15Z","updated_at":"2018-03-22T14:19:02Z","due_on":"2018-03-22T07:00:00Z","closed_at":null},"comments":9,"created_at":"2018-02-09T23:59:02Z","updated_at":"2018-03-23T12:31:32Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/jetstack/cert-manager/pulls/309","html_url":"https://github.com/jetstack/cert-manager/pull/309","diff_url":"https://github.com/jetstack/cert-manager/pull/309.diff","patch_url":"https://github.com/jetstack/cert-manager/pull/309.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nAdds support for the ACME v2 protocol in favour of v1\r\n\r\n**Which issue this PR fixes**: fixes #273\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThis PR is not ready **yet**. We need to validate and ensure boulder runs with the v2 protocol enabled during our e2e tests. In future we can switch to something like [pebble](https://github.com/letsencrypt/pebble), a lightweight alternative to boulder.\r\n\r\nI have also copied across the upcoming `golang.org/x/crypto/acme/v2` package from the gerrit codereview so we can get ahead of the curve on testing this: https://go-review.googlesource.com/c/crypto/+/86635\r\n\r\nI have also not tested whether it is possible to obtain wildcard certificates with this **yet**\r\n\r\n**Release note**:\r\n```release-note\r\nRemove support for ACMEv1 in favour of ACMEv2\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/jetstack/cert-manager/issues/comments/375650588","html_url":"https://github.com/jetstack/cert-manager/pull/309#issuecomment-375650588","issue_url":"https://api.github.com/repos/jetstack/cert-manager/issues/309","id":375650588,"user":{"login":"jetstack-bot","id":32282838,"avatar_url":"https://avatars1.githubusercontent.com/u/32282838?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack-bot","html_url":"https://github.com/jetstack-bot","followers_url":"https://api.github.com/users/jetstack-bot/followers","following_url":"https://api.github.com/users/jetstack-bot/following{/other_user}","gists_url":"https://api.github.com/users/jetstack-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack-bot/subscriptions","organizations_url":"https://api.github.com/users/jetstack-bot/orgs","repos_url":"https://api.github.com/users/jetstack-bot/repos","events_url":"https://api.github.com/users/jetstack-bot/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack-bot/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T12:31:32Z","updated_at":"2018-03-23T12:31:32Z","author_association":"COLLABORATOR","body":"@munnerz: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\ncert-manager-e2e-v1-7 | 7cd1e829d1e8e90457ecc489cf32576182323db1 | [link](https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_cert-manager/309/cert-manager-e2e-v1-7/278/) | `/test e2e v1.7`\ncert-manager-e2e-v1-9 | 7cd1e829d1e8e90457ecc489cf32576182323db1 | [link](https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_cert-manager/309/cert-manager-e2e-v1-9/270/) | `/test e2e v1.9`\ncert-manager-e2e-v1-8 | 7cd1e829d1e8e90457ecc489cf32576182323db1 | [link](https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_cert-manager/309/cert-manager-e2e-v1-8/294/) | `/test e2e v1.8`\n\n[Full PR test history](https://jetstack-build-infra.appspot.com/pr/jetstack_cert-manager/309). [Your PR dashboard](https://jetstack-build-infra.appspot.com/pr/munnerz). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/jetstack/cert-manager/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"jetstack-bot"}}