{"action":"closed","number":145,"pull_request":{"url":"https://api.github.com/repos/HashEngineering/dash-wallet/pulls/145","id":226300886,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzAwODg2","html_url":"https://github.com/HashEngineering/dash-wallet/pull/145","diff_url":"https://github.com/HashEngineering/dash-wallet/pull/145.diff","patch_url":"https://github.com/HashEngineering/dash-wallet/pull/145.patch","issue_url":"https://api.github.com/repos/HashEngineering/dash-wallet/issues/145","number":145,"state":"closed","locked":false,"title":"Fix wallet wipe","user":{"login":"HashEngineering","id":5956129,"node_id":"MDQ6VXNlcjU5NTYxMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5956129?v=4","gravatar_id":"","url":"https://api.github.com/users/HashEngineering","html_url":"https://github.com/HashEngineering","followers_url":"https://api.github.com/users/HashEngineering/followers","following_url":"https://api.github.com/users/HashEngineering/following{/other_user}","gists_url":"https://api.github.com/users/HashEngineering/gists{/gist_id}","starred_url":"https://api.github.com/users/HashEngineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashEngineering/subscriptions","organizations_url":"https://api.github.com/users/HashEngineering/orgs","repos_url":"https://api.github.com/users/HashEngineering/repos","events_url":"https://api.github.com/users/HashEngineering/events{/privacy}","received_events_url":"https://api.github.com/users/HashEngineering/received_events","type":"User","site_admin":false},"body":"Purpose:\r\nPrevent Brute forcing by adding the code to reset the wallet after the PIN is entered incorrectly 8 times and also to allow for logging to show that the \r\n\r\nIn WalletApplication, I removed the delete all files methods and replaced it with:\r\n1.  Create a new wallet (nonencrypted)\r\n2.  Replace current wallet (user forgot their PIN that encrypts it) with new wallet (nonencrypted)\r\n\r\nThis method will preserve all settings and logs (for diagnosis of problems and so we will know that the user wiped the wallet).\r\n\r\nThe other code that closes the app remains the same.  The user must restart the app and it will be as if it was a fresh install.  The user will need to enter the mandatory PIN.\r\n\r\nThe second part of this is to add the code that will wipe the wallet after the PIN is entered incorrectly 8 times.\r\n\r\n**Testing:**\r\nInstall the app with this PR.\r\nEnter the PIN wrong 4 times to see the dialog that allows reset.\r\nGo to the Settings on the android and set the time ahead to skip waiting between entering incorrect PIN's.\r\nOn the 8th attempt, ensure that the app doesn't allow canceling the Reset Dialog.  Ensure that there is not another way to reenter the PIN to keep trying.  The app should require a reset.","created_at":"2018-10-27T15:06:18Z","updated_at":"2018-10-30T19:03:46Z","closed_at":"2018-10-30T19:03:46Z","merged_at":"2018-10-30T19:03:46Z","merge_commit_sha":"c114e2e646968b51009c2c3cca7f95bd74d9c18b","assignee":{"login":"HashEngineering","id":5956129,"node_id":"MDQ6VXNlcjU5NTYxMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5956129?v=4","gravatar_id":"","url":"https://api.github.com/users/HashEngineering","html_url":"https://github.com/HashEngineering","followers_url":"https://api.github.com/users/HashEngineering/followers","following_url":"https://api.github.com/users/HashEngineering/following{/other_user}","gists_url":"https://api.github.com/users/HashEngineering/gists{/gist_id}","starred_url":"https://api.github.com/users/HashEngineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashEngineering/subscriptions","organizations_url":"https://api.github.com/users/HashEngineering/orgs","repos_url":"https://api.github.com/users/HashEngineering/repos","events_url":"https://api.github.com/users/HashEngineering/events{/privacy}","received_events_url":"https://api.github.com/users/HashEngineering/received_events","type":"User","site_admin":false},"assignees":[{"login":"HashEngineering","id":5956129,"node_id":"MDQ6VXNlcjU5NTYxMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5956129?v=4","gravatar_id":"","url":"https://api.github.com/users/HashEngineering","html_url":"https://github.com/HashEngineering","followers_url":"https://api.github.com/users/HashEngineering/followers","following_url":"https://api.github.com/users/HashEngineering/following{/other_user}","gists_url":"https://api.github.com/users/HashEngineering/gists{/gist_id}","starred_url":"https://api.github.com/users/HashEngineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashEngineering/subscriptions","organizations_url":"https://api.github.com/users/HashEngineering/orgs","repos_url":"https://api.github.com/users/HashEngineering/repos","events_url":"https://api.github.com/users/HashEngineering/events{/privacy}","received_events_url":"https://api.github.com/users/HashEngineering/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tomasz-ludek","id":8437401,"node_id":"MDQ6VXNlcjg0Mzc0MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/8437401?v=4","gravatar_id":"","url":"https://api.github.com/users/tomasz-ludek","html_url":"https://github.com/tomasz-ludek","followers_url":"https://api.github.com/users/tomasz-ludek/followers","following_url":"https://api.github.com/users/tomasz-ludek/following{/other_user}","gists_url":"https://api.github.com/users/tomasz-ludek/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasz-ludek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasz-ludek/subscriptions","organizations_url":"https://api.github.com/users/tomasz-ludek/orgs","repos_url":"https://api.github.com/users/tomasz-ludek/repos","events_url":"https://api.github.com/users/tomasz-ludek/events{/privacy}","received_events_url":"https://api.github.com/users/tomasz-ludek/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":103679871,"node_id":"MDU6TGFiZWwxMDM2Nzk4NzE=","url":"https://api.github.com/repos/HashEngineering/dash-wallet/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/HashEngineering/dash-wallet/pulls/145/commits","review_comments_url":"https://api.github.com/repos/HashEngineering/dash-wallet/pulls/145/comments","review_comment_url":"https://api.github.com/repos/HashEngineering/dash-wallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HashEngineering/dash-wallet/issues/145/comments","statuses_url":"https://api.github.com/repos/HashEngineering/dash-wallet/statuses/1a63b56268d8cda6faede311159c5527ac229ae2","head":{"label":"HashEngineering:fix-wallet-wipe","ref":"fix-wallet-wipe","sha":"1a63b56268d8cda6faede311159c5527ac229ae2","user":{"login":"HashEngineering","id":5956129,"node_id":"MDQ6VXNlcjU5NTYxMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5956129?v=4","gravatar_id":"","url":"https://api.github.com/users/HashEngineering","html_url":"https://github.com/HashEngineering","followers_url":"https://api.github.com/users/HashEngineering/followers","following_url":"https://api.github.com/users/HashEngineering/following{/other_user}","gists_url":"https://api.github.com/users/HashEngineering/gists{/gist_id}","starred_url":"https://api.github.com/users/HashEngineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashEngineering/subscriptions","organizations_url":"https://api.github.com/users/HashEngineering/orgs","repos_url":"https://api.github.com/users/HashEngineering/repos","events_url":"https://api.github.com/users/HashEngineering/events{/privacy}","received_events_url":"https://api.github.com/users/HashEngineering/received_events","type":"User","site_admin":false},"repo":{"id":20371637,"node_id":"MDEwOlJlcG9zaXRvcnkyMDM3MTYzNw==","name":"dash-wallet","full_name":"HashEngineering/dash-wallet","private":false,"owner":{"login":"HashEngineering","id":5956129,"node_id":"MDQ6VXNlcjU5NTYxMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5956129?v=4","gravatar_id":"","url":"https://api.github.com/users/HashEngineering","html_url":"https://github.com/HashEngineering","followers_url":"https://api.github.com/users/HashEngineering/followers","following_url":"https://api.github.com/users/HashEngineering/following{/other_user}","gists_url":"https://api.github.com/users/HashEngineering/gists{/gist_id}","starred_url":"https://api.github.com/users/HashEngineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashEngineering/subscriptions","organizations_url":"https://api.github.com/users/HashEngineering/orgs","repos_url":"https://api.github.com/users/HashEngineering/repos","events_url":"https://api.github.com/users/HashEngineering/events{/privacy}","received_events_url":"https://api.github.com/users/HashEngineering/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HashEngineering/dash-wallet","description":"Dash Wallet for Android","fork":false,"url":"https://api.github.com/repos/HashEngineering/dash-wallet","forks_url":"https://api.github.com/repos/HashEngineering/dash-wallet/forks","keys_url":"https://api.github.com/repos/HashEngineering/dash-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HashEngineering/dash-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HashEngineering/dash-wallet/teams","hooks_url":"https://api.github.com/repos/HashEngineering/dash-wallet/hooks","issue_events_url":"https://api.github.com/repos/HashEngineering/dash-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/HashEngineering/dash-wallet/events","assignees_url":"https://api.github.com/repos/HashEngineering/dash-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/HashEngineering/dash-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/HashEngineering/dash-wallet/tags","blobs_url":"https://api.github.com/repos/HashEngineering/dash-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HashEngineering/dash-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HashEngineering/dash-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/HashEngineering/dash-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HashEngineering/dash-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/HashEngineering/dash-wallet/languages","stargazers_url":"https://api.github.com/repos/HashEngineering/dash-wallet/stargazers","contributors_url":"https://api.github.com/repos/HashEngineering/dash-wallet/contributors","subscribers_url":"https://api.github.com/repos/HashEngineering/dash-wallet/subscribers","subscription_url":"https://api.github.com/repos/HashEngineering/dash-wallet/subscription","commits_url":"https://api.github.com/repos/HashEngineering/dash-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/HashEngineering/dash-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/HashEngineering/dash-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/HashEngineering/dash-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/HashEngineering/dash-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/HashEngineering/dash-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HashEngineering/dash-wallet/merges","archive_url":"https://api.github.com/repos/HashEngineering/dash-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HashEngineering/dash-wallet/downloads","issues_url":"https://api.github.com/repos/HashEngineering/dash-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/HashEngineering/dash-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/HashEngineering/dash-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/HashEngineering/dash-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HashEngineering/dash-wallet/labels{/name}","releases_url":"https://api.github.com/repos/HashEngineering/dash-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/HashEngineering/dash-wallet/deployments","created_at":"2014-06-01T05:43:00Z","updated_at":"2018-10-30T18:54:32Z","pushed_at":"2018-10-30T19:03:47Z","git_url":"git://github.com/HashEngineering/dash-wallet.git","ssh_url":"git@github.com:HashEngineering/dash-wallet.git","clone_url":"https://github.com/HashEngineering/dash-wallet.git","svn_url":"https://github.com/HashEngineering/dash-wallet","homepage":"http://www.hashengineeringsolutions.com/?page_id=196","size":69169,"stargazers_count":61,"watchers_count":61,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":88,"open_issues":24,"watchers":61,"default_branch":"master"}},"base":{"label":"HashEngineering:master","ref":"master","sha":"4e121fd93003cd4cc6906fa5b8ec30248269697f","user":{"login":"HashEngineering","id":5956129,"node_id":"MDQ6VXNlcjU5NTYxMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5956129?v=4","gravatar_id":"","url":"https://api.github.com/users/HashEngineering","html_url":"https://github.com/HashEngineering","followers_url":"https://api.github.com/users/HashEngineering/followers","following_url":"https://api.github.com/users/HashEngineering/following{/other_user}","gists_url":"https://api.github.com/users/HashEngineering/gists{/gist_id}","starred_url":"https://api.github.com/users/HashEngineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashEngineering/subscriptions","organizations_url":"https://api.github.com/users/HashEngineering/orgs","repos_url":"https://api.github.com/users/HashEngineering/repos","events_url":"https://api.github.com/users/HashEngineering/events{/privacy}","received_events_url":"https://api.github.com/users/HashEngineering/received_events","type":"User","site_admin":false},"repo":{"id":20371637,"node_id":"MDEwOlJlcG9zaXRvcnkyMDM3MTYzNw==","name":"dash-wallet","full_name":"HashEngineering/dash-wallet","private":false,"owner":{"login":"HashEngineering","id":5956129,"node_id":"MDQ6VXNlcjU5NTYxMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5956129?v=4","gravatar_id":"","url":"https://api.github.com/users/HashEngineering","html_url":"https://github.com/HashEngineering","followers_url":"https://api.github.com/users/HashEngineering/followers","following_url":"https://api.github.com/users/HashEngineering/following{/other_user}","gists_url":"https://api.github.com/users/HashEngineering/gists{/gist_id}","starred_url":"https://api.github.com/users/HashEngineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashEngineering/subscriptions","organizations_url":"https://api.github.com/users/HashEngineering/orgs","repos_url":"https://api.github.com/users/HashEngineering/repos","events_url":"https://api.github.com/users/HashEngineering/events{/privacy}","received_events_url":"https://api.github.com/users/HashEngineering/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HashEngineering/dash-wallet","description":"Dash Wallet for Android","fork":false,"url":"https://api.github.com/repos/HashEngineering/dash-wallet","forks_url":"https://api.github.com/repos/HashEngineering/dash-wallet/forks","keys_url":"https://api.github.com/repos/HashEngineering/dash-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HashEngineering/dash-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HashEngineering/dash-wallet/teams","hooks_url":"https://api.github.com/repos/HashEngineering/dash-wallet/hooks","issue_events_url":"https://api.github.com/repos/HashEngineering/dash-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/HashEngineering/dash-wallet/events","assignees_url":"https://api.github.com/repos/HashEngineering/dash-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/HashEngineering/dash-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/HashEngineering/dash-wallet/tags","blobs_url":"https://api.github.com/repos/HashEngineering/dash-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HashEngineering/dash-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HashEngineering/dash-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/HashEngineering/dash-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HashEngineering/dash-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/HashEngineering/dash-wallet/languages","stargazers_url":"https://api.github.com/repos/HashEngineering/dash-wallet/stargazers","contributors_url":"https://api.github.com/repos/HashEngineering/dash-wallet/contributors","subscribers_url":"https://api.github.com/repos/HashEngineering/dash-wallet/subscribers","subscription_url":"https://api.github.com/repos/HashEngineering/dash-wallet/subscription","commits_url":"https://api.github.com/repos/HashEngineering/dash-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/HashEngineering/dash-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/HashEngineering/dash-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/HashEngineering/dash-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/HashEngineering/dash-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/HashEngineering/dash-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HashEngineering/dash-wallet/merges","archive_url":"https://api.github.com/repos/HashEngineering/dash-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HashEngineering/dash-wallet/downloads","issues_url":"https://api.github.com/repos/HashEngineering/dash-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/HashEngineering/dash-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/HashEngineering/dash-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/HashEngineering/dash-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HashEngineering/dash-wallet/labels{/name}","releases_url":"https://api.github.com/repos/HashEngineering/dash-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/HashEngineering/dash-wallet/deployments","created_at":"2014-06-01T05:43:00Z","updated_at":"2018-10-30T18:54:32Z","pushed_at":"2018-10-30T19:03:47Z","git_url":"git://github.com/HashEngineering/dash-wallet.git","ssh_url":"git@github.com:HashEngineering/dash-wallet.git","clone_url":"https://github.com/HashEngineering/dash-wallet.git","svn_url":"https://github.com/HashEngineering/dash-wallet","homepage":"http://www.hashengineeringsolutions.com/?page_id=196","size":69169,"stargazers_count":61,"watchers_count":61,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":88,"open_issues":24,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HashEngineering/dash-wallet/pulls/145"},"html":{"href":"https://github.com/HashEngineering/dash-wallet/pull/145"},"issue":{"href":"https://api.github.com/repos/HashEngineering/dash-wallet/issues/145"},"comments":{"href":"https://api.github.com/repos/HashEngineering/dash-wallet/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/HashEngineering/dash-wallet/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/HashEngineering/dash-wallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HashEngineering/dash-wallet/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/HashEngineering/dash-wallet/statuses/1a63b56268d8cda6faede311159c5527ac229ae2"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"HashEngineering","id":5956129,"node_id":"MDQ6VXNlcjU5NTYxMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5956129?v=4","gravatar_id":"","url":"https://api.github.com/users/HashEngineering","html_url":"https://github.com/HashEngineering","followers_url":"https://api.github.com/users/HashEngineering/followers","following_url":"https://api.github.com/users/HashEngineering/following{/other_user}","gists_url":"https://api.github.com/users/HashEngineering/gists{/gist_id}","starred_url":"https://api.github.com/users/HashEngineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashEngineering/subscriptions","organizations_url":"https://api.github.com/users/HashEngineering/orgs","repos_url":"https://api.github.com/users/HashEngineering/repos","events_url":"https://api.github.com/users/HashEngineering/events{/privacy}","received_events_url":"https://api.github.com/users/HashEngineering/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":84,"deletions":48,"changed_files":4}}
{"actor":{"display_login":"HashEngineering"}}