{"action":"created","issue":{"url":"https://api.github.com/repos/f-o-a-m/hs-web3/issues/27","repository_url":"https://api.github.com/repos/f-o-a-m/hs-web3","labels_url":"https://api.github.com/repos/f-o-a-m/hs-web3/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/f-o-a-m/hs-web3/issues/27/comments","events_url":"https://api.github.com/repos/f-o-a-m/hs-web3/issues/27/events","html_url":"https://github.com/f-o-a-m/hs-web3/pull/27","id":374045513,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODM2NzI3","number":27,"title":"Bugfix/error unification","user":{"login":"CaptJakk","id":4033651,"node_id":"MDQ6VXNlcjQwMzM2NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/4033651?v=4","gravatar_id":"","url":"https://api.github.com/users/CaptJakk","html_url":"https://github.com/CaptJakk","followers_url":"https://api.github.com/users/CaptJakk/followers","following_url":"https://api.github.com/users/CaptJakk/following{/other_user}","gists_url":"https://api.github.com/users/CaptJakk/gists{/gist_id}","starred_url":"https://api.github.com/users/CaptJakk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaptJakk/subscriptions","organizations_url":"https://api.github.com/users/CaptJakk/orgs","repos_url":"https://api.github.com/users/CaptJakk/repos","events_url":"https://api.github.com/users/CaptJakk/events{/privacy}","received_events_url":"https://api.github.com/users/CaptJakk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-25T17:08:31Z","updated_at":"2018-11-05T18:00:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/f-o-a-m/hs-web3/pulls/27","html_url":"https://github.com/f-o-a-m/hs-web3/pull/27","diff_url":"https://github.com/f-o-a-m/hs-web3/pull/27.diff","patch_url":"https://github.com/f-o-a-m/hs-web3/pull/27.patch"},"body":"It appears that even though there are provisions in the web3 error type, that all json rpc exceptions are piggy backing on the IO exception system. This fix adds a unification step in the runWeb3With' function so that the exceptions generated by JsonRPC are marshalled into the larger Web3Error type. We have run into this several times and we hacked around it in our client code. I figured this would be a valuable change to upstream. It doesn't change any of the API, it simply makes it such that all errors are being propagated via the same mechanism, rather than having some errors coming through Either/Except, and others coming from the IO exception system."},"comment":{"url":"https://api.github.com/repos/f-o-a-m/hs-web3/issues/comments/435972641","html_url":"https://github.com/f-o-a-m/hs-web3/pull/27#issuecomment-435972641","issue_url":"https://api.github.com/repos/f-o-a-m/hs-web3/issues/27","id":435972641,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTk3MjY0MQ==","user":{"login":"CaptJakk","id":4033651,"node_id":"MDQ6VXNlcjQwMzM2NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/4033651?v=4","gravatar_id":"","url":"https://api.github.com/users/CaptJakk","html_url":"https://github.com/CaptJakk","followers_url":"https://api.github.com/users/CaptJakk/followers","following_url":"https://api.github.com/users/CaptJakk/following{/other_user}","gists_url":"https://api.github.com/users/CaptJakk/gists{/gist_id}","starred_url":"https://api.github.com/users/CaptJakk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaptJakk/subscriptions","organizations_url":"https://api.github.com/users/CaptJakk/orgs","repos_url":"https://api.github.com/users/CaptJakk/repos","events_url":"https://api.github.com/users/CaptJakk/events{/privacy}","received_events_url":"https://api.github.com/users/CaptJakk/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T18:00:44Z","updated_at":"2018-11-05T18:00:44Z","author_association":"NONE","body":"Any opinion on getting this merged?"}}
{"actor":{"display_login":"CaptJakk"}}