{"action":"created","issue":{"url":"https://api.github.com/repos/bpoore/pbm-react/issues/6","repository_url":"https://api.github.com/repos/bpoore/pbm-react","labels_url":"https://api.github.com/repos/bpoore/pbm-react/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/bpoore/pbm-react/issues/6/comments","events_url":"https://api.github.com/repos/bpoore/pbm-react/issues/6/events","html_url":"https://github.com/bpoore/pbm-react/pull/6","id":347256651,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTIzNTI1","number":6,"title":"draft styles of sign up / login pages","user":{"login":"RyanTG","id":632682,"node_id":"MDQ6VXNlcjYzMjY4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/632682?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanTG","html_url":"https://github.com/RyanTG","followers_url":"https://api.github.com/users/RyanTG/followers","following_url":"https://api.github.com/users/RyanTG/following{/other_user}","gists_url":"https://api.github.com/users/RyanTG/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanTG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanTG/subscriptions","organizations_url":"https://api.github.com/users/RyanTG/orgs","repos_url":"https://api.github.com/users/RyanTG/repos","events_url":"https://api.github.com/users/RyanTG/events{/privacy}","received_events_url":"https://api.github.com/users/RyanTG/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-03T04:38:03Z","updated_at":"2018-08-06T20:11:49Z","closed_at":"2018-08-06T20:06:53Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bpoore/pbm-react/pulls/6","html_url":"https://github.com/bpoore/pbm-react/pull/6","diff_url":"https://github.com/bpoore/pbm-react/pull/6.diff","patch_url":"https://github.com/bpoore/pbm-react/pull/6.patch"},"body":"Definitely not done here. But it's a draft.\r\n\r\nOn the Sign Up page, the errors end up pushing the input containers off the screen (at least on my little phone). But that _might_ be resolved once that top margin issue is fixed.\r\n\r\nOn the SignupLogin page, I removed the blue background on the top logo, because that logo resizes to the screen, and the background has to have a fixed height (as far as I know right now). And so while it looks PERFECT on my screen, it might not on larger screens - the logo might grow larger than the blue background.\r\n\r\nALL backgrounds are drafts at this point - especially that Sign Up one - I added that only a couple minutes ago. I may change the designs and/or the image formats (smaller jpgs or gifs instead of massive pngs, in case there are performance issues).\r\n\r\nOH, how do I run tests?\r\n"},"comment":{"url":"https://api.github.com/repos/bpoore/pbm-react/issues/comments/410838122","html_url":"https://github.com/bpoore/pbm-react/pull/6#issuecomment-410838122","issue_url":"https://api.github.com/repos/bpoore/pbm-react/issues/6","id":410838122,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDgzODEyMg==","user":{"login":"bpoore","id":7720282,"node_id":"MDQ6VXNlcjc3MjAyODI=","avatar_url":"https://avatars3.githubusercontent.com/u/7720282?v=4","gravatar_id":"","url":"https://api.github.com/users/bpoore","html_url":"https://github.com/bpoore","followers_url":"https://api.github.com/users/bpoore/followers","following_url":"https://api.github.com/users/bpoore/following{/other_user}","gists_url":"https://api.github.com/users/bpoore/gists{/gist_id}","starred_url":"https://api.github.com/users/bpoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpoore/subscriptions","organizations_url":"https://api.github.com/users/bpoore/orgs","repos_url":"https://api.github.com/users/bpoore/repos","events_url":"https://api.github.com/users/bpoore/events{/privacy}","received_events_url":"https://api.github.com/users/bpoore/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T20:11:49Z","updated_at":"2018-08-06T20:11:49Z","author_association":"OWNER","body":"@RyanTG \r\n\r\nRunning tests: in a new terminal window run npm (or yarn) test. That will run all the tests as well as watch for any changes made to files to run the tests again. Currently, not all tests are passing for the entire project. For screens I've recently worked on, tests are passing (login, signup, signuplogin). When you make changes to files, most likely, the 'snapshots' are going to fail... this is expected as the snapshots are renderings of screens, components, etc, so changes to styles will cause them to fail. In order to update snapshots, preferably, you'll first look at what the changes are and if they changes are expected based on your new code, simply entering 'u' will update the snapshots.\r\n\r\nIf you want to run tests specific to a file you're working on, you can enter 'p' and then all or part of the filename.\r\n\r\nLet me know if you have any questions! I'll update the snapshots for this PR."}}
{"actor":{"display_login":"bpoore"}}