{"action":"created","issue":{"url":"https://api.github.com/repos/LedgerHQ/ledger-dotnet-api/issues/13","repository_url":"https://api.github.com/repos/LedgerHQ/ledger-dotnet-api","labels_url":"https://api.github.com/repos/LedgerHQ/ledger-dotnet-api/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/LedgerHQ/ledger-dotnet-api/issues/13/comments","events_url":"https://api.github.com/repos/LedgerHQ/ledger-dotnet-api/issues/13/events","html_url":"https://github.com/LedgerHQ/ledger-dotnet-api/pull/13","id":341285873,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDc3Mzkw","number":13,"title":"Switch to Hid.Net","user":{"login":"MelbourneDeveloper","id":16697547,"node_id":"MDQ6VXNlcjE2Njk3NTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/16697547?v=4","gravatar_id":"","url":"https://api.github.com/users/MelbourneDeveloper","html_url":"https://github.com/MelbourneDeveloper","followers_url":"https://api.github.com/users/MelbourneDeveloper/followers","following_url":"https://api.github.com/users/MelbourneDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/MelbourneDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/MelbourneDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MelbourneDeveloper/subscriptions","organizations_url":"https://api.github.com/users/MelbourneDeveloper/orgs","repos_url":"https://api.github.com/users/MelbourneDeveloper/repos","events_url":"https://api.github.com/users/MelbourneDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/MelbourneDeveloper/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2018-07-15T02:16:43Z","updated_at":"2018-07-19T03:41:25Z","closed_at":"2018-07-17T14:58:20Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/LedgerHQ/ledger-dotnet-api/pulls/13","html_url":"https://github.com/LedgerHQ/ledger-dotnet-api/pull/13","diff_url":"https://github.com/LedgerHQ/ledger-dotnet-api/pull/13.diff","patch_url":"https://github.com/LedgerHQ/ledger-dotnet-api/pull/13.patch"},"body":"This pull request removes the HidLibrary dependency and replaces it with the Hid.Net dependency. The units tests have been split between .NET 4.5.2, and .NET Core 2.0. There should be no breaking changes in .NET 4.5.2 because this code will remain specific to Windows. However, the .NET Standard 2.0 DLL removes some functionality and therefore there are some #ifs for the two versions. \r\n\r\nTo see where code is different across the two platforms, have a look at GetLedgerAsync in NanoSTests."},"comment":{"url":"https://api.github.com/repos/LedgerHQ/ledger-dotnet-api/issues/comments/406145004","html_url":"https://github.com/LedgerHQ/ledger-dotnet-api/pull/13#issuecomment-406145004","issue_url":"https://api.github.com/repos/LedgerHQ/ledger-dotnet-api/issues/13","id":406145004,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjE0NTAwNA==","user":{"login":"NicolasDorier","id":3020646,"node_id":"MDQ6VXNlcjMwMjA2NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3020646?v=4","gravatar_id":"","url":"https://api.github.com/users/NicolasDorier","html_url":"https://github.com/NicolasDorier","followers_url":"https://api.github.com/users/NicolasDorier/followers","following_url":"https://api.github.com/users/NicolasDorier/following{/other_user}","gists_url":"https://api.github.com/users/NicolasDorier/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasDorier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasDorier/subscriptions","organizations_url":"https://api.github.com/users/NicolasDorier/orgs","repos_url":"https://api.github.com/users/NicolasDorier/repos","events_url":"https://api.github.com/users/NicolasDorier/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasDorier/received_events","type":"User","site_admin":false},"created_at":"2018-07-19T03:41:25Z","updated_at":"2018-07-19T03:41:25Z","author_association":"COLLABORATOR","body":"@MelbourneDeveloper you can.\r\n\r\nJust attach, and keep in a locked list what get attached and detached, and make the provider return that list synchronously.\r\n\r\n> Another problem is ... What if the device is not connected at the time of calling CreateFromDescription? CreateFromDescription works fine on Windows in a controlled unit test but in other situations, the code will need to poll it again and again until the device is connected.\r\n\r\nI doubt it will happen, as `CreateFromDescription` will be called only if it is in the above locked list."}}
{"actor":{"display_login":"NicolasDorier"}}