{"action":"created","comment":{"url":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/comments/210255633","pull_request_review_id":146426968,"id":210255633,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDI1NTYzMw==","diff_hunk":"@@ -18,7 +18,9 @@ The signature of this rule is compatible with nodejs_binary.\n \n load(\n     \"//lang:image.bzl\",\n-    \"app_layer\",\n+    \"app_layer_attrs\",\n+    \"app_layer_impl\",","path":"nodejs/image.bzl","position":6,"original_position":6,"commit_id":"db073940f780262b5689657e4b89c738a953a1c8","original_commit_id":"db073940f780262b5689657e4b89c738a953a1c8","user":{"login":"nlopezgi","id":4062751,"node_id":"MDQ6VXNlcjQwNjI3NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4062751?v=4","gravatar_id":"","url":"https://api.github.com/users/nlopezgi","html_url":"https://github.com/nlopezgi","followers_url":"https://api.github.com/users/nlopezgi/followers","following_url":"https://api.github.com/users/nlopezgi/following{/other_user}","gists_url":"https://api.github.com/users/nlopezgi/gists{/gist_id}","starred_url":"https://api.github.com/users/nlopezgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlopezgi/subscriptions","organizations_url":"https://api.github.com/users/nlopezgi/orgs","repos_url":"https://api.github.com/users/nlopezgi/repos","events_url":"https://api.github.com/users/nlopezgi/events{/privacy}","received_events_url":"https://api.github.com/users/nlopezgi/received_events","type":"User","site_admin":false},"body":"can you alias these with lang_ so that they are visibly distinct from the ones declared here","created_at":"2018-08-15T12:44:19Z","updated_at":"2018-08-15T12:57:19Z","html_url":"https://github.com/bazelbuild/rules_docker/pull/487#discussion_r210255633","pull_request_url":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/487","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/comments/210255633"},"html":{"href":"https://github.com/bazelbuild/rules_docker/pull/487#discussion_r210255633"},"pull_request":{"href":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/487"}}},"pull_request":{"url":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/487","id":208425207,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDI1MjA3","html_url":"https://github.com/bazelbuild/rules_docker/pull/487","diff_url":"https://github.com/bazelbuild/rules_docker/pull/487.diff","patch_url":"https://github.com/bazelbuild/rules_docker/pull/487.patch","issue_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/487","number":487,"state":"open","locked":false,"title":"Fix nodejs_image layering","user":{"login":"Globegitter","id":2580254,"node_id":"MDQ6VXNlcjI1ODAyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2580254?v=4","gravatar_id":"","url":"https://api.github.com/users/Globegitter","html_url":"https://github.com/Globegitter","followers_url":"https://api.github.com/users/Globegitter/followers","following_url":"https://api.github.com/users/Globegitter/following{/other_user}","gists_url":"https://api.github.com/users/Globegitter/gists{/gist_id}","starred_url":"https://api.github.com/users/Globegitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Globegitter/subscriptions","organizations_url":"https://api.github.com/users/Globegitter/orgs","repos_url":"https://api.github.com/users/Globegitter/repos","events_url":"https://api.github.com/users/Globegitter/events{/privacy}","received_events_url":"https://api.github.com/users/Globegitter/received_events","type":"User","site_admin":false},"body":"This builds upon #342 and fixes the layering for the nodejs_image making it work with the latest rules. This is dependent on https://github.com/bazelbuild/rules_nodejs/pull/283 being merged into rules_nodejs.\r\n\r\nThe top layer of the example nodejs_image goes down from 64MB to ~60KB. From one of our own apps it reduces it from ~223MB to ~28MB","created_at":"2018-08-14T22:12:03Z","updated_at":"2018-08-15T12:57:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e064a8758163e5f27f14266969ee0e9132063d69","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":577265609,"node_id":"MDU6TGFiZWw1NzcyNjU2MDk=","url":"https://api.github.com/repos/bazelbuild/rules_docker/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/487/commits","review_comments_url":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/487/comments","review_comment_url":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/487/comments","statuses_url":"https://api.github.com/repos/bazelbuild/rules_docker/statuses/db073940f780262b5689657e4b89c738a953a1c8","head":{"label":"Globegitter:nodejs-layering","ref":"nodejs-layering","sha":"db073940f780262b5689657e4b89c738a953a1c8","user":{"login":"Globegitter","id":2580254,"node_id":"MDQ6VXNlcjI1ODAyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2580254?v=4","gravatar_id":"","url":"https://api.github.com/users/Globegitter","html_url":"https://github.com/Globegitter","followers_url":"https://api.github.com/users/Globegitter/followers","following_url":"https://api.github.com/users/Globegitter/following{/other_user}","gists_url":"https://api.github.com/users/Globegitter/gists{/gist_id}","starred_url":"https://api.github.com/users/Globegitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Globegitter/subscriptions","organizations_url":"https://api.github.com/users/Globegitter/orgs","repos_url":"https://api.github.com/users/Globegitter/repos","events_url":"https://api.github.com/users/Globegitter/events{/privacy}","received_events_url":"https://api.github.com/users/Globegitter/received_events","type":"User","site_admin":false},"repo":{"id":126808847,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4MDg4NDc=","name":"rules_docker","full_name":"Globegitter/rules_docker","owner":{"login":"Globegitter","id":2580254,"node_id":"MDQ6VXNlcjI1ODAyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2580254?v=4","gravatar_id":"","url":"https://api.github.com/users/Globegitter","html_url":"https://github.com/Globegitter","followers_url":"https://api.github.com/users/Globegitter/followers","following_url":"https://api.github.com/users/Globegitter/following{/other_user}","gists_url":"https://api.github.com/users/Globegitter/gists{/gist_id}","starred_url":"https://api.github.com/users/Globegitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Globegitter/subscriptions","organizations_url":"https://api.github.com/users/Globegitter/orgs","repos_url":"https://api.github.com/users/Globegitter/repos","events_url":"https://api.github.com/users/Globegitter/events{/privacy}","received_events_url":"https://api.github.com/users/Globegitter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Globegitter/rules_docker","description":"Rules for building and handling Docker images with Bazel","fork":true,"url":"https://api.github.com/repos/Globegitter/rules_docker","forks_url":"https://api.github.com/repos/Globegitter/rules_docker/forks","keys_url":"https://api.github.com/repos/Globegitter/rules_docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Globegitter/rules_docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Globegitter/rules_docker/teams","hooks_url":"https://api.github.com/repos/Globegitter/rules_docker/hooks","issue_events_url":"https://api.github.com/repos/Globegitter/rules_docker/issues/events{/number}","events_url":"https://api.github.com/repos/Globegitter/rules_docker/events","assignees_url":"https://api.github.com/repos/Globegitter/rules_docker/assignees{/user}","branches_url":"https://api.github.com/repos/Globegitter/rules_docker/branches{/branch}","tags_url":"https://api.github.com/repos/Globegitter/rules_docker/tags","blobs_url":"https://api.github.com/repos/Globegitter/rules_docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Globegitter/rules_docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Globegitter/rules_docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Globegitter/rules_docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Globegitter/rules_docker/statuses/{sha}","languages_url":"https://api.github.com/repos/Globegitter/rules_docker/languages","stargazers_url":"https://api.github.com/repos/Globegitter/rules_docker/stargazers","contributors_url":"https://api.github.com/repos/Globegitter/rules_docker/contributors","subscribers_url":"https://api.github.com/repos/Globegitter/rules_docker/subscribers","subscription_url":"https://api.github.com/repos/Globegitter/rules_docker/subscription","commits_url":"https://api.github.com/repos/Globegitter/rules_docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Globegitter/rules_docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Globegitter/rules_docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Globegitter/rules_docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Globegitter/rules_docker/contents/{+path}","compare_url":"https://api.github.com/repos/Globegitter/rules_docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Globegitter/rules_docker/merges","archive_url":"https://api.github.com/repos/Globegitter/rules_docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Globegitter/rules_docker/downloads","issues_url":"https://api.github.com/repos/Globegitter/rules_docker/issues{/number}","pulls_url":"https://api.github.com/repos/Globegitter/rules_docker/pulls{/number}","milestones_url":"https://api.github.com/repos/Globegitter/rules_docker/milestones{/number}","notifications_url":"https://api.github.com/repos/Globegitter/rules_docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Globegitter/rules_docker/labels{/name}","releases_url":"https://api.github.com/repos/Globegitter/rules_docker/releases{/id}","deployments_url":"https://api.github.com/repos/Globegitter/rules_docker/deployments","created_at":"2018-03-26T09:56:57Z","updated_at":"2018-03-26T09:56:59Z","pushed_at":"2018-08-14T22:09:39Z","git_url":"git://github.com/Globegitter/rules_docker.git","ssh_url":"git@github.com:Globegitter/rules_docker.git","clone_url":"https://github.com/Globegitter/rules_docker.git","svn_url":"https://github.com/Globegitter/rules_docker","homepage":"","size":1174,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazelbuild:master","ref":"master","sha":"dc3982577c41f27770e970669ce8fee3d2e44f80","user":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":86749899,"node_id":"MDEwOlJlcG9zaXRvcnk4Njc0OTg5OQ==","name":"rules_docker","full_name":"bazelbuild/rules_docker","owner":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazelbuild/rules_docker","description":"Rules for building and handling Docker images with Bazel","fork":false,"url":"https://api.github.com/repos/bazelbuild/rules_docker","forks_url":"https://api.github.com/repos/bazelbuild/rules_docker/forks","keys_url":"https://api.github.com/repos/bazelbuild/rules_docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazelbuild/rules_docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazelbuild/rules_docker/teams","hooks_url":"https://api.github.com/repos/bazelbuild/rules_docker/hooks","issue_events_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/events{/number}","events_url":"https://api.github.com/repos/bazelbuild/rules_docker/events","assignees_url":"https://api.github.com/repos/bazelbuild/rules_docker/assignees{/user}","branches_url":"https://api.github.com/repos/bazelbuild/rules_docker/branches{/branch}","tags_url":"https://api.github.com/repos/bazelbuild/rules_docker/tags","blobs_url":"https://api.github.com/repos/bazelbuild/rules_docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazelbuild/rules_docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazelbuild/rules_docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazelbuild/rules_docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazelbuild/rules_docker/statuses/{sha}","languages_url":"https://api.github.com/repos/bazelbuild/rules_docker/languages","stargazers_url":"https://api.github.com/repos/bazelbuild/rules_docker/stargazers","contributors_url":"https://api.github.com/repos/bazelbuild/rules_docker/contributors","subscribers_url":"https://api.github.com/repos/bazelbuild/rules_docker/subscribers","subscription_url":"https://api.github.com/repos/bazelbuild/rules_docker/subscription","commits_url":"https://api.github.com/repos/bazelbuild/rules_docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazelbuild/rules_docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazelbuild/rules_docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazelbuild/rules_docker/contents/{+path}","compare_url":"https://api.github.com/repos/bazelbuild/rules_docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazelbuild/rules_docker/merges","archive_url":"https://api.github.com/repos/bazelbuild/rules_docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazelbuild/rules_docker/downloads","issues_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues{/number}","pulls_url":"https://api.github.com/repos/bazelbuild/rules_docker/pulls{/number}","milestones_url":"https://api.github.com/repos/bazelbuild/rules_docker/milestones{/number}","notifications_url":"https://api.github.com/repos/bazelbuild/rules_docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazelbuild/rules_docker/labels{/name}","releases_url":"https://api.github.com/repos/bazelbuild/rules_docker/releases{/id}","deployments_url":"https://api.github.com/repos/bazelbuild/rules_docker/deployments","created_at":"2017-03-30T21:19:58Z","updated_at":"2018-08-15T02:31:04Z","pushed_at":"2018-08-14T23:01:38Z","git_url":"git://github.com/bazelbuild/rules_docker.git","ssh_url":"git@github.com:bazelbuild/rules_docker.git","clone_url":"https://github.com/bazelbuild/rules_docker.git","svn_url":"https://github.com/bazelbuild/rules_docker","homepage":"","size":1151,"stargazers_count":247,"watchers_count":247,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":150,"open_issues":80,"watchers":247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/487"},"html":{"href":"https://github.com/bazelbuild/rules_docker/pull/487"},"issue":{"href":"https://api.github.com/repos/bazelbuild/rules_docker/issues/487"},"comments":{"href":"https://api.github.com/repos/bazelbuild/rules_docker/issues/487/comments"},"review_comments":{"href":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/487/comments"},"review_comment":{"href":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/487/commits"},"statuses":{"href":"https://api.github.com/repos/bazelbuild/rules_docker/statuses/db073940f780262b5689657e4b89c738a953a1c8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nlopezgi"}}