{"action":"created","issue":{"url":"https://api.github.com/repos/WaterwayData/FeatureSpace/issues/32","repository_url":"https://api.github.com/repos/WaterwayData/FeatureSpace","labels_url":"https://api.github.com/repos/WaterwayData/FeatureSpace/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/WaterwayData/FeatureSpace/issues/32/comments","events_url":"https://api.github.com/repos/WaterwayData/FeatureSpace/issues/32/events","html_url":"https://github.com/WaterwayData/FeatureSpace/issues/32","id":341670093,"node_id":"MDU6SXNzdWUzNDE2NzAwOTM=","number":32,"title":"Reload FeatureSpace metadata right before adding to it and saving it, so we can edit it in parallel","user":{"login":"awaterman5","id":16964341,"node_id":"MDQ6VXNlcjE2OTY0MzQx","avatar_url":"https://avatars1.githubusercontent.com/u/16964341?v=4","gravatar_id":"","url":"https://api.github.com/users/awaterman5","html_url":"https://github.com/awaterman5","followers_url":"https://api.github.com/users/awaterman5/followers","following_url":"https://api.github.com/users/awaterman5/following{/other_user}","gists_url":"https://api.github.com/users/awaterman5/gists{/gist_id}","starred_url":"https://api.github.com/users/awaterman5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awaterman5/subscriptions","organizations_url":"https://api.github.com/users/awaterman5/orgs","repos_url":"https://api.github.com/users/awaterman5/repos","events_url":"https://api.github.com/users/awaterman5/events{/privacy}","received_events_url":"https://api.github.com/users/awaterman5/received_events","type":"User","site_admin":false},"labels":[{"id":1023281477,"node_id":"MDU6TGFiZWwxMDIzMjgxNDc3","url":"https://api.github.com/repos/WaterwayData/FeatureSpace/labels/feature:backups","name":"feature:backups","color":"fc7f20","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-16T20:37:21Z","updated_at":"2018-11-18T20:00:30Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"One feature of FeatureSpace is an ability to work on the same FeatureSpace model in parallel in two different notebooks.\r\n\r\nHowever right now one notebook will edit the FeatureSpace instance (after it was loaded initially) and the other is writing to the same file, but they're not getting each other's updates.\r\n\r\nIf we automatically pull the featurespace object out of file before making changes to it and re-saving, then this will be reduced to a race condition and much less frequent."},"comment":{"url":"https://api.github.com/repos/WaterwayData/FeatureSpace/issues/comments/439721069","html_url":"https://github.com/WaterwayData/FeatureSpace/issues/32#issuecomment-439721069","issue_url":"https://api.github.com/repos/WaterwayData/FeatureSpace/issues/32","id":439721069,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTcyMTA2OQ==","user":{"login":"awaterman5","id":16964341,"node_id":"MDQ6VXNlcjE2OTY0MzQx","avatar_url":"https://avatars1.githubusercontent.com/u/16964341?v=4","gravatar_id":"","url":"https://api.github.com/users/awaterman5","html_url":"https://github.com/awaterman5","followers_url":"https://api.github.com/users/awaterman5/followers","following_url":"https://api.github.com/users/awaterman5/following{/other_user}","gists_url":"https://api.github.com/users/awaterman5/gists{/gist_id}","starred_url":"https://api.github.com/users/awaterman5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awaterman5/subscriptions","organizations_url":"https://api.github.com/users/awaterman5/orgs","repos_url":"https://api.github.com/users/awaterman5/repos","events_url":"https://api.github.com/users/awaterman5/events{/privacy}","received_events_url":"https://api.github.com/users/awaterman5/received_events","type":"User","site_admin":false},"created_at":"2018-11-18T20:00:30Z","updated_at":"2018-11-18T20:00:30Z","author_association":"CONTRIBUTOR","body":"After #51, #55, and #56, this changes to needing to \"check-out\" and \"check-in\" each FeatureSet or Batch one-by-one:\r\n* When updating an existing FeatureSet, just update the `latest_filename` inside the batch's metadata file for that FeatureSet\r\n* When adding a new FeatureSet, also update the `latest_filename` for the batch in the Project-level metadata file, since now the batch's metadata is changing too.\r\n\r\nThen to catch \"race conditions\" where both users are editing the same metadata, we should look for when the last_updated timestamp has changed from when we initially \"checked out\" this FeatureSet or Batch when we go to \"check in\" the changes.  In that case we can either overwrite the changes or show a warning/error sign to the user saying we won't overwrite the changes from the other user. "}}
{"actor":{"display_login":"awaterman5"}}