{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/apm-server/pulls/comments/166355995","pull_request_review_id":94405731,"id":166355995,"diff_hunk":"@@ -29,7 +29,7 @@ func isServerUp(secure bool, host string, numRetries int, retryInterval time.Dur\n \n \tfor i := 0; i <= numRetries; i++ {\n \t\tif check() {\n-\t\t\tlogp.Info(\"HTTP Server ready\")\n+\t\t\tlogp.NewLogger(\"HTTP Client\").Info(\"HTTP Server ready\")","path":"beater/client.go","position":5,"original_position":5,"commit_id":"077210418f28df4319ebe960e1ee748111d97e39","original_commit_id":"077210418f28df4319ebe960e1ee748111d97e39","user":{"login":"andrewkroh","id":4565752,"avatar_url":"https://avatars2.githubusercontent.com/u/4565752?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkroh","html_url":"https://github.com/andrewkroh","followers_url":"https://api.github.com/users/andrewkroh/followers","following_url":"https://api.github.com/users/andrewkroh/following{/other_user}","gists_url":"https://api.github.com/users/andrewkroh/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkroh/subscriptions","organizations_url":"https://api.github.com/users/andrewkroh/orgs","repos_url":"https://api.github.com/users/andrewkroh/repos","events_url":"https://api.github.com/users/andrewkroh/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkroh/received_events","type":"User","site_admin":false},"body":"While there is absolutely no requirement to use single word keys, conventionally we have named the loggers using lowercase and no spaces like `http_client` or `httpclient` or `http.client`.","created_at":"2018-02-06T16:17:45Z","updated_at":"2018-02-06T16:23:35Z","html_url":"https://github.com/elastic/apm-server/pull/583#discussion_r166355995","pull_request_url":"https://api.github.com/repos/elastic/apm-server/pulls/583","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/apm-server/pulls/comments/166355995"},"html":{"href":"https://github.com/elastic/apm-server/pull/583#discussion_r166355995"},"pull_request":{"href":"https://api.github.com/repos/elastic/apm-server/pulls/583"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/apm-server/pulls/583","id":166231145,"html_url":"https://github.com/elastic/apm-server/pull/583","diff_url":"https://github.com/elastic/apm-server/pull/583.diff","patch_url":"https://github.com/elastic/apm-server/pull/583.patch","issue_url":"https://api.github.com/repos/elastic/apm-server/issues/583","number":583,"state":"open","locked":false,"title":"remove deprecated usages of logp","user":{"login":"jalvz","id":3432712,"avatar_url":"https://avatars3.githubusercontent.com/u/3432712?v=4","gravatar_id":"","url":"https://api.github.com/users/jalvz","html_url":"https://github.com/jalvz","followers_url":"https://api.github.com/users/jalvz/followers","following_url":"https://api.github.com/users/jalvz/following{/other_user}","gists_url":"https://api.github.com/users/jalvz/gists{/gist_id}","starred_url":"https://api.github.com/users/jalvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalvz/subscriptions","organizations_url":"https://api.github.com/users/jalvz/orgs","repos_url":"https://api.github.com/users/jalvz/repos","events_url":"https://api.github.com/users/jalvz/events{/privacy}","received_events_url":"https://api.github.com/users/jalvz/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-01-31T11:17:09Z","updated_at":"2018-02-06T16:23:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"235c758d684a86465452c1c3098ff79005e82780","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/apm-server/pulls/583/commits","review_comments_url":"https://api.github.com/repos/elastic/apm-server/pulls/583/comments","review_comment_url":"https://api.github.com/repos/elastic/apm-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/apm-server/issues/583/comments","statuses_url":"https://api.github.com/repos/elastic/apm-server/statuses/077210418f28df4319ebe960e1ee748111d97e39","head":{"label":"jalvz:remove-log-deprecation-warnings","ref":"remove-log-deprecation-warnings","sha":"077210418f28df4319ebe960e1ee748111d97e39","user":{"login":"jalvz","id":3432712,"avatar_url":"https://avatars3.githubusercontent.com/u/3432712?v=4","gravatar_id":"","url":"https://api.github.com/users/jalvz","html_url":"https://github.com/jalvz","followers_url":"https://api.github.com/users/jalvz/followers","following_url":"https://api.github.com/users/jalvz/following{/other_user}","gists_url":"https://api.github.com/users/jalvz/gists{/gist_id}","starred_url":"https://api.github.com/users/jalvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalvz/subscriptions","organizations_url":"https://api.github.com/users/jalvz/orgs","repos_url":"https://api.github.com/users/jalvz/repos","events_url":"https://api.github.com/users/jalvz/events{/privacy}","received_events_url":"https://api.github.com/users/jalvz/received_events","type":"User","site_admin":false},"repo":{"id":100604018,"name":"apm-server","full_name":"jalvz/apm-server","owner":{"login":"jalvz","id":3432712,"avatar_url":"https://avatars3.githubusercontent.com/u/3432712?v=4","gravatar_id":"","url":"https://api.github.com/users/jalvz","html_url":"https://github.com/jalvz","followers_url":"https://api.github.com/users/jalvz/followers","following_url":"https://api.github.com/users/jalvz/following{/other_user}","gists_url":"https://api.github.com/users/jalvz/gists{/gist_id}","starred_url":"https://api.github.com/users/jalvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalvz/subscriptions","organizations_url":"https://api.github.com/users/jalvz/orgs","repos_url":"https://api.github.com/users/jalvz/repos","events_url":"https://api.github.com/users/jalvz/events{/privacy}","received_events_url":"https://api.github.com/users/jalvz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jalvz/apm-server","description":"APM Server (Experimental)","fork":true,"url":"https://api.github.com/repos/jalvz/apm-server","forks_url":"https://api.github.com/repos/jalvz/apm-server/forks","keys_url":"https://api.github.com/repos/jalvz/apm-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jalvz/apm-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jalvz/apm-server/teams","hooks_url":"https://api.github.com/repos/jalvz/apm-server/hooks","issue_events_url":"https://api.github.com/repos/jalvz/apm-server/issues/events{/number}","events_url":"https://api.github.com/repos/jalvz/apm-server/events","assignees_url":"https://api.github.com/repos/jalvz/apm-server/assignees{/user}","branches_url":"https://api.github.com/repos/jalvz/apm-server/branches{/branch}","tags_url":"https://api.github.com/repos/jalvz/apm-server/tags","blobs_url":"https://api.github.com/repos/jalvz/apm-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jalvz/apm-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jalvz/apm-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/jalvz/apm-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jalvz/apm-server/statuses/{sha}","languages_url":"https://api.github.com/repos/jalvz/apm-server/languages","stargazers_url":"https://api.github.com/repos/jalvz/apm-server/stargazers","contributors_url":"https://api.github.com/repos/jalvz/apm-server/contributors","subscribers_url":"https://api.github.com/repos/jalvz/apm-server/subscribers","subscription_url":"https://api.github.com/repos/jalvz/apm-server/subscription","commits_url":"https://api.github.com/repos/jalvz/apm-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/jalvz/apm-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/jalvz/apm-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/jalvz/apm-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/jalvz/apm-server/contents/{+path}","compare_url":"https://api.github.com/repos/jalvz/apm-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jalvz/apm-server/merges","archive_url":"https://api.github.com/repos/jalvz/apm-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jalvz/apm-server/downloads","issues_url":"https://api.github.com/repos/jalvz/apm-server/issues{/number}","pulls_url":"https://api.github.com/repos/jalvz/apm-server/pulls{/number}","milestones_url":"https://api.github.com/repos/jalvz/apm-server/milestones{/number}","notifications_url":"https://api.github.com/repos/jalvz/apm-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jalvz/apm-server/labels{/name}","releases_url":"https://api.github.com/repos/jalvz/apm-server/releases{/id}","deployments_url":"https://api.github.com/repos/jalvz/apm-server/deployments","created_at":"2017-08-17T13:01:39Z","updated_at":"2017-08-17T13:01:40Z","pushed_at":"2018-02-06T13:14:37Z","git_url":"git://github.com/jalvz/apm-server.git","ssh_url":"git@github.com:jalvz/apm-server.git","clone_url":"https://github.com/jalvz/apm-server.git","svn_url":"https://github.com/jalvz/apm-server","homepage":"","size":5811,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"28fba6d0c23e534764cf4e8631e507c8260a35c0","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":99251094,"name":"apm-server","full_name":"elastic/apm-server","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/apm-server","description":"APM Server (Beta)","fork":false,"url":"https://api.github.com/repos/elastic/apm-server","forks_url":"https://api.github.com/repos/elastic/apm-server/forks","keys_url":"https://api.github.com/repos/elastic/apm-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/apm-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/apm-server/teams","hooks_url":"https://api.github.com/repos/elastic/apm-server/hooks","issue_events_url":"https://api.github.com/repos/elastic/apm-server/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/apm-server/events","assignees_url":"https://api.github.com/repos/elastic/apm-server/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/apm-server/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/apm-server/tags","blobs_url":"https://api.github.com/repos/elastic/apm-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/apm-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/apm-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/apm-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/apm-server/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/apm-server/languages","stargazers_url":"https://api.github.com/repos/elastic/apm-server/stargazers","contributors_url":"https://api.github.com/repos/elastic/apm-server/contributors","subscribers_url":"https://api.github.com/repos/elastic/apm-server/subscribers","subscription_url":"https://api.github.com/repos/elastic/apm-server/subscription","commits_url":"https://api.github.com/repos/elastic/apm-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/apm-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/apm-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/apm-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/apm-server/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/apm-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/apm-server/merges","archive_url":"https://api.github.com/repos/elastic/apm-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/apm-server/downloads","issues_url":"https://api.github.com/repos/elastic/apm-server/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/apm-server/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/apm-server/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/apm-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/apm-server/labels{/name}","releases_url":"https://api.github.com/repos/elastic/apm-server/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/apm-server/deployments","created_at":"2017-08-03T16:03:34Z","updated_at":"2018-02-06T14:17:21Z","pushed_at":"2018-02-06T16:15:22Z","git_url":"git://github.com/elastic/apm-server.git","ssh_url":"git@github.com:elastic/apm-server.git","clone_url":"https://github.com/elastic/apm-server.git","svn_url":"https://github.com/elastic/apm-server","homepage":"","size":6156,"stargazers_count":266,"watchers_count":266,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":50,"open_issues":49,"watchers":266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/apm-server/pulls/583"},"html":{"href":"https://github.com/elastic/apm-server/pull/583"},"issue":{"href":"https://api.github.com/repos/elastic/apm-server/issues/583"},"comments":{"href":"https://api.github.com/repos/elastic/apm-server/issues/583/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/apm-server/pulls/583/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/apm-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/apm-server/pulls/583/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/apm-server/statuses/077210418f28df4319ebe960e1ee748111d97e39"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andrewkroh"}}