{"action":"closed","number":10869,"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/10869","id":231726819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzI2ODE5","html_url":"https://github.com/PX4/Firmware/pull/10869","diff_url":"https://github.com/PX4/Firmware/pull/10869.diff","patch_url":"https://github.com/PX4/Firmware/pull/10869.patch","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/10869","number":10869,"state":"closed","locked":false,"title":"Simplify px4_log.c by always using a FILE* for standard output.","user":{"login":"m-ou-se","id":783247,"node_id":"MDQ6VXNlcjc4MzI0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/783247?v=4","gravatar_id":"","url":"https://api.github.com/users/m-ou-se","html_url":"https://github.com/m-ou-se","followers_url":"https://api.github.com/users/m-ou-se/followers","following_url":"https://api.github.com/users/m-ou-se/following{/other_user}","gists_url":"https://api.github.com/users/m-ou-se/gists{/gist_id}","starred_url":"https://api.github.com/users/m-ou-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-ou-se/subscriptions","organizations_url":"https://api.github.com/users/m-ou-se/orgs","repos_url":"https://api.github.com/users/m-ou-se/repos","events_url":"https://api.github.com/users/m-ou-se/events{/privacy}","received_events_url":"https://api.github.com/users/m-ou-se/received_events","type":"User","site_admin":false},"body":"The threads running commands for clients through the Posix daemon used\r\nto write to a char buffer through snprintf (etc.) which was then written\r\ndirectly to the file descriptor, whereas in the other case printf\r\n(etc.) was used to write to stdout. Both versions used some\r\nmacro's and repeated code to have the same output.\r\n\r\nThis change unifies these two cases by using a FILE* in both cases. The\r\n(line) buffering is done by the standard C library's implementation\r\n(just like with stdout), and px4_log.c now uses the same code in all\r\ncases (using fprintf, etc.) for printing (colored) output.","created_at":"2018-11-17T13:02:27Z","updated_at":"2018-11-23T11:15:42Z","closed_at":"2018-11-23T11:15:42Z","merged_at":"2018-11-23T11:15:42Z","merge_commit_sha":"e9fb17c51af834532d34c1d74707838d8c28a849","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PX4/Firmware/pulls/10869/commits","review_comments_url":"https://api.github.com/repos/PX4/Firmware/pulls/10869/comments","review_comment_url":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/10869/comments","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/8e11b45ea4b26000486c5e72c6da0e9465d688ad","head":{"label":"m-ou-se:stdout-file-ptr","ref":"stdout-file-ptr","sha":"8e11b45ea4b26000486c5e72c6da0e9465d688ad","user":{"login":"m-ou-se","id":783247,"node_id":"MDQ6VXNlcjc4MzI0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/783247?v=4","gravatar_id":"","url":"https://api.github.com/users/m-ou-se","html_url":"https://github.com/m-ou-se","followers_url":"https://api.github.com/users/m-ou-se/followers","following_url":"https://api.github.com/users/m-ou-se/following{/other_user}","gists_url":"https://api.github.com/users/m-ou-se/gists{/gist_id}","starred_url":"https://api.github.com/users/m-ou-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-ou-se/subscriptions","organizations_url":"https://api.github.com/users/m-ou-se/orgs","repos_url":"https://api.github.com/users/m-ou-se/repos","events_url":"https://api.github.com/users/m-ou-se/events{/privacy}","received_events_url":"https://api.github.com/users/m-ou-se/received_events","type":"User","site_admin":false},"repo":{"id":154830425,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4MzA0MjU=","name":"Firmware","full_name":"m-ou-se/Firmware","private":false,"owner":{"login":"m-ou-se","id":783247,"node_id":"MDQ6VXNlcjc4MzI0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/783247?v=4","gravatar_id":"","url":"https://api.github.com/users/m-ou-se","html_url":"https://github.com/m-ou-se","followers_url":"https://api.github.com/users/m-ou-se/followers","following_url":"https://api.github.com/users/m-ou-se/following{/other_user}","gists_url":"https://api.github.com/users/m-ou-se/gists{/gist_id}","starred_url":"https://api.github.com/users/m-ou-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-ou-se/subscriptions","organizations_url":"https://api.github.com/users/m-ou-se/orgs","repos_url":"https://api.github.com/users/m-ou-se/repos","events_url":"https://api.github.com/users/m-ou-se/events{/privacy}","received_events_url":"https://api.github.com/users/m-ou-se/received_events","type":"User","site_admin":false},"html_url":"https://github.com/m-ou-se/Firmware","description":"PX4 Autopilot Software","fork":true,"url":"https://api.github.com/repos/m-ou-se/Firmware","forks_url":"https://api.github.com/repos/m-ou-se/Firmware/forks","keys_url":"https://api.github.com/repos/m-ou-se/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-ou-se/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-ou-se/Firmware/teams","hooks_url":"https://api.github.com/repos/m-ou-se/Firmware/hooks","issue_events_url":"https://api.github.com/repos/m-ou-se/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/m-ou-se/Firmware/events","assignees_url":"https://api.github.com/repos/m-ou-se/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/m-ou-se/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/m-ou-se/Firmware/tags","blobs_url":"https://api.github.com/repos/m-ou-se/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-ou-se/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-ou-se/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-ou-se/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-ou-se/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/m-ou-se/Firmware/languages","stargazers_url":"https://api.github.com/repos/m-ou-se/Firmware/stargazers","contributors_url":"https://api.github.com/repos/m-ou-se/Firmware/contributors","subscribers_url":"https://api.github.com/repos/m-ou-se/Firmware/subscribers","subscription_url":"https://api.github.com/repos/m-ou-se/Firmware/subscription","commits_url":"https://api.github.com/repos/m-ou-se/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-ou-se/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-ou-se/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-ou-se/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-ou-se/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/m-ou-se/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-ou-se/Firmware/merges","archive_url":"https://api.github.com/repos/m-ou-se/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-ou-se/Firmware/downloads","issues_url":"https://api.github.com/repos/m-ou-se/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/m-ou-se/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/m-ou-se/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/m-ou-se/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-ou-se/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/m-ou-se/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/m-ou-se/Firmware/deployments","created_at":"2018-10-26T12:22:43Z","updated_at":"2018-10-26T12:22:56Z","pushed_at":"2018-11-19T12:12:46Z","git_url":"git://github.com/m-ou-se/Firmware.git","ssh_url":"git@github.com:m-ou-se/Firmware.git","clone_url":"https://github.com/m-ou-se/Firmware.git","svn_url":"https://github.com/m-ou-se/Firmware","homepage":"http://px4.io","size":103603,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"26bac9594f1451f48a654da2e67c62f1c1950148","user":{"login":"PX4","id":2096014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTYwMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjk4Nzkw","name":"Firmware","full_name":"PX4/Firmware","private":false,"owner":{"login":"PX4","id":2096014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTYwMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PX4/Firmware","description":"PX4 Autopilot Software","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/Firmware/deployments","created_at":"2012-08-04T21:19:36Z","updated_at":"2018-11-23T09:40:59Z","pushed_at":"2018-11-23T11:15:42Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"https://px4.io","size":104853,"stargazers_count":2121,"watchers_count":2121,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6253,"mirror_url":null,"archived":false,"open_issues_count":668,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6253,"open_issues":668,"watchers":2121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/10869"},"html":{"href":"https://github.com/PX4/Firmware/pull/10869"},"issue":{"href":"https://api.github.com/repos/PX4/Firmware/issues/10869"},"comments":{"href":"https://api.github.com/repos/PX4/Firmware/issues/10869/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/10869/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/10869/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/Firmware/statuses/8e11b45ea4b26000486c5e72c6da0e9465d688ad"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bkueng","id":281593,"node_id":"MDQ6VXNlcjI4MTU5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/281593?v=4","gravatar_id":"","url":"https://api.github.com/users/bkueng","html_url":"https://github.com/bkueng","followers_url":"https://api.github.com/users/bkueng/followers","following_url":"https://api.github.com/users/bkueng/following{/other_user}","gists_url":"https://api.github.com/users/bkueng/gists{/gist_id}","starred_url":"https://api.github.com/users/bkueng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkueng/subscriptions","organizations_url":"https://api.github.com/users/bkueng/orgs","repos_url":"https://api.github.com/users/bkueng/repos","events_url":"https://api.github.com/users/bkueng/events{/privacy}","received_events_url":"https://api.github.com/users/bkueng/received_events","type":"User","site_admin":false},"comments":10,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":113,"deletions":189,"changed_files":21}}
{"actor":{"display_login":"bkueng"}}