{"action":"created","comment":{"url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/comments/185282090","pull_request_review_id":116638761,"id":185282090,"diff_hunk":"@@ -2,14 +2,15 @@\n //!\n //! Attribute parsing occurs in multiple stages:\n //!\n-//! 1. Builder options on the struct are parsed into `OptionsBuilder<StructMode>`.\n-//! 1. The `OptionsBuilder<StructMode>` instance is converted into a starting point for the\n-//!    per-field options (`OptionsBuilder<FieldMode>`) and the finished struct-level config,\n-//!    called `StructOptions`.\n-//! 1. Each struct field is parsed, with discovered attributes overriding or augmenting the\n-//!    options specified at the struct level. This creates one `OptionsBuilder<FieldMode>` per\n-//!    struct field on the input/target type. Once complete, these get converted into\n-//!    `FieldOptions` instances.\n+//! 1. Builder options on the struct are parsed into","path":"derive_builder/src/options/mod.rs","position":12,"original_position":12,"commit_id":"dfc1e695cb6a47d656a8fa2a3364ba9756faf556","original_commit_id":"dfc1e695cb6a47d656a8fa2a3364ba9756faf556","user":{"login":"TedDriggs","id":4805575,"avatar_url":"https://avatars2.githubusercontent.com/u/4805575?v=4","gravatar_id":"","url":"https://api.github.com/users/TedDriggs","html_url":"https://github.com/TedDriggs","followers_url":"https://api.github.com/users/TedDriggs/followers","following_url":"https://api.github.com/users/TedDriggs/following{/other_user}","gists_url":"https://api.github.com/users/TedDriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/TedDriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TedDriggs/subscriptions","organizations_url":"https://api.github.com/users/TedDriggs/orgs","repos_url":"https://api.github.com/users/TedDriggs/repos","events_url":"https://api.github.com/users/TedDriggs/events{/privacy}","received_events_url":"https://api.github.com/users/TedDriggs/received_events","type":"User","site_admin":false},"body":"@azriel91 please undo the formatting on comments; this has broken the ordered list rendering.","created_at":"2018-05-01T17:36:59Z","updated_at":"2018-05-01T17:39:26Z","html_url":"https://github.com/colin-kiegel/rust-derive-builder/pull/111#discussion_r185282090","pull_request_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/111","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/comments/185282090"},"html":{"href":"https://github.com/colin-kiegel/rust-derive-builder/pull/111#discussion_r185282090"},"pull_request":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/111","id":173018854,"html_url":"https://github.com/colin-kiegel/rust-derive-builder/pull/111","diff_url":"https://github.com/colin-kiegel/rust-derive-builder/pull/111.diff","patch_url":"https://github.com/colin-kiegel/rust-derive-builder/pull/111.patch","issue_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/111","number":111,"state":"open","locked":false,"title":"Disable derive clone on owned pattern","user":{"login":"azriel91","id":2993230,"avatar_url":"https://avatars3.githubusercontent.com/u/2993230?v=4","gravatar_id":"","url":"https://api.github.com/users/azriel91","html_url":"https://github.com/azriel91","followers_url":"https://api.github.com/users/azriel91/followers","following_url":"https://api.github.com/users/azriel91/following{/other_user}","gists_url":"https://api.github.com/users/azriel91/gists{/gist_id}","starred_url":"https://api.github.com/users/azriel91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azriel91/subscriptions","organizations_url":"https://api.github.com/users/azriel91/orgs","repos_url":"https://api.github.com/users/azriel91/repos","events_url":"https://api.github.com/users/azriel91/events{/privacy}","received_events_url":"https://api.github.com/users/azriel91/received_events","type":"User","site_admin":false},"body":"Attempts to address #97, here's the quick summary:\r\n\r\n* Made `Clone` optionally derived on the `Builder`, depending on the `BuilderPattern` on the struct as well as on each of the fields. I'm not sure if the way it calculates and passes the \"mark this as should derive `Clone`\" is a good way &mdash; it was the quickest way to get *most* of the tests to pass.\r\n* Ran current Rustfmt over the repository.\r\n* Updated top level docs (minor).\r\n* Updated changelog.\r\n\r\nThe `./dev/checkfeatures.sh` run fails, but I couldn't figure out how to make it pass:\r\n\r\n* `getopts 0.2.17` fails to compile:\r\n\r\n    ```\r\n    $ ./dev/checkfeatures.sh\r\n\r\n    Running `cd derive_builder && rustup run 1.15.0 cargo test --all --color always --features \"skeptic_tests\"`\r\n       Compiling getopts v0.2.17\r\n    error[E0301]: cannot mutably borrow in a pattern guard\r\n       --> /home/azriel/.cargo/registry/src/github.com-1ecc6299db9ec823/getopts-0.2.17/src/lib.rs:405:73\r\n        |\r\n    405 |                         } else if was_long || name_pos < names.len() || args.peek().map_or(true, |n| is_arg(&n)) {\r\n        |                                                                         ^^^^ borrowed mutably in pattern guard\r\n\r\n    error: aborting due to previous error\r\n\r\n    error: Could not compile `getopts`.\r\n    ```\r\n\r\n* `Cargo.lock` says `compiletest_rs 0.3.7` depends on `getopts 0.2.17`.\r\n* `Cargo.toml` in `derive_builder` says:\r\n\r\n    ```toml\r\n    [dependencies]\r\n    # ... omitted\r\n    compiletest_rs = { version = \"0.3.3\", optional = true }\r\n    ```\r\n\r\nWhich, to me says \"use version `0.3.3` of compiletest_rs\" but cargo is disobeying that. Then I became sad because I tried munging dependencies, but cargo always chose `0.3.7` of `compiletest_rs`. I did delete `Cargo.lock` and try again + some other variations. Maybe this issue would solve that: https://github.com/rust-lang/cargo/issues/4100\r\n\r\n<details>\r\n<summary><i>Re-enactment of how I did this PR</I></summary>\r\n\r\n* Ripgrep: `rg -F owned`.\r\n* Hack code.\r\n* `cargo test`\r\n* `rg -F '::Owned'`.\r\n* Fix compile errors.\r\n* Read `CONTRIBUTING.md`\r\n* Do what it says, ish 😀.\r\n</details>","created_at":"2018-03-05T23:39:45Z","updated_at":"2018-05-01T17:39:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c2787f70210b2aa8acc359c3b9b10cee88c4be6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/111/commits","review_comments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/111/comments","review_comment_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/111/comments","statuses_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/statuses/dfc1e695cb6a47d656a8fa2a3364ba9756faf556","head":{"label":"azriel91:issue-97/disable-derive-clone-on-owned-pattern","ref":"issue-97/disable-derive-clone-on-owned-pattern","sha":"dfc1e695cb6a47d656a8fa2a3364ba9756faf556","user":{"login":"azriel91","id":2993230,"avatar_url":"https://avatars3.githubusercontent.com/u/2993230?v=4","gravatar_id":"","url":"https://api.github.com/users/azriel91","html_url":"https://github.com/azriel91","followers_url":"https://api.github.com/users/azriel91/followers","following_url":"https://api.github.com/users/azriel91/following{/other_user}","gists_url":"https://api.github.com/users/azriel91/gists{/gist_id}","starred_url":"https://api.github.com/users/azriel91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azriel91/subscriptions","organizations_url":"https://api.github.com/users/azriel91/orgs","repos_url":"https://api.github.com/users/azriel91/repos","events_url":"https://api.github.com/users/azriel91/events{/privacy}","received_events_url":"https://api.github.com/users/azriel91/received_events","type":"User","site_admin":false},"repo":{"id":83864781,"name":"rust-derive-builder","full_name":"azriel91/rust-derive-builder","owner":{"login":"azriel91","id":2993230,"avatar_url":"https://avatars3.githubusercontent.com/u/2993230?v=4","gravatar_id":"","url":"https://api.github.com/users/azriel91","html_url":"https://github.com/azriel91","followers_url":"https://api.github.com/users/azriel91/followers","following_url":"https://api.github.com/users/azriel91/following{/other_user}","gists_url":"https://api.github.com/users/azriel91/gists{/gist_id}","starred_url":"https://api.github.com/users/azriel91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azriel91/subscriptions","organizations_url":"https://api.github.com/users/azriel91/orgs","repos_url":"https://api.github.com/users/azriel91/repos","events_url":"https://api.github.com/users/azriel91/events{/privacy}","received_events_url":"https://api.github.com/users/azriel91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/azriel91/rust-derive-builder","description":"derive builder implementation for rust structs","fork":true,"url":"https://api.github.com/repos/azriel91/rust-derive-builder","forks_url":"https://api.github.com/repos/azriel91/rust-derive-builder/forks","keys_url":"https://api.github.com/repos/azriel91/rust-derive-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azriel91/rust-derive-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azriel91/rust-derive-builder/teams","hooks_url":"https://api.github.com/repos/azriel91/rust-derive-builder/hooks","issue_events_url":"https://api.github.com/repos/azriel91/rust-derive-builder/issues/events{/number}","events_url":"https://api.github.com/repos/azriel91/rust-derive-builder/events","assignees_url":"https://api.github.com/repos/azriel91/rust-derive-builder/assignees{/user}","branches_url":"https://api.github.com/repos/azriel91/rust-derive-builder/branches{/branch}","tags_url":"https://api.github.com/repos/azriel91/rust-derive-builder/tags","blobs_url":"https://api.github.com/repos/azriel91/rust-derive-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azriel91/rust-derive-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azriel91/rust-derive-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/azriel91/rust-derive-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azriel91/rust-derive-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/azriel91/rust-derive-builder/languages","stargazers_url":"https://api.github.com/repos/azriel91/rust-derive-builder/stargazers","contributors_url":"https://api.github.com/repos/azriel91/rust-derive-builder/contributors","subscribers_url":"https://api.github.com/repos/azriel91/rust-derive-builder/subscribers","subscription_url":"https://api.github.com/repos/azriel91/rust-derive-builder/subscription","commits_url":"https://api.github.com/repos/azriel91/rust-derive-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/azriel91/rust-derive-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/azriel91/rust-derive-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/azriel91/rust-derive-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/azriel91/rust-derive-builder/contents/{+path}","compare_url":"https://api.github.com/repos/azriel91/rust-derive-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azriel91/rust-derive-builder/merges","archive_url":"https://api.github.com/repos/azriel91/rust-derive-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azriel91/rust-derive-builder/downloads","issues_url":"https://api.github.com/repos/azriel91/rust-derive-builder/issues{/number}","pulls_url":"https://api.github.com/repos/azriel91/rust-derive-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/azriel91/rust-derive-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/azriel91/rust-derive-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azriel91/rust-derive-builder/labels{/name}","releases_url":"https://api.github.com/repos/azriel91/rust-derive-builder/releases{/id}","deployments_url":"https://api.github.com/repos/azriel91/rust-derive-builder/deployments","created_at":"2017-03-04T04:26:43Z","updated_at":"2017-03-04T04:26:45Z","pushed_at":"2018-03-12T22:15:37Z","git_url":"git://github.com/azriel91/rust-derive-builder.git","ssh_url":"git@github.com:azriel91/rust-derive-builder.git","clone_url":"https://github.com/azriel91/rust-derive-builder.git","svn_url":"https://github.com/azriel91/rust-derive-builder","homepage":"https://colin-kiegel.github.io/rust-derive-builder/","size":930,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"colin-kiegel:master","ref":"master","sha":"1a6c5a72a8110355f5bfc66a5ca5dcbd90df0dfb","user":{"login":"colin-kiegel","id":7691186,"avatar_url":"https://avatars3.githubusercontent.com/u/7691186?v=4","gravatar_id":"","url":"https://api.github.com/users/colin-kiegel","html_url":"https://github.com/colin-kiegel","followers_url":"https://api.github.com/users/colin-kiegel/followers","following_url":"https://api.github.com/users/colin-kiegel/following{/other_user}","gists_url":"https://api.github.com/users/colin-kiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/colin-kiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colin-kiegel/subscriptions","organizations_url":"https://api.github.com/users/colin-kiegel/orgs","repos_url":"https://api.github.com/users/colin-kiegel/repos","events_url":"https://api.github.com/users/colin-kiegel/events{/privacy}","received_events_url":"https://api.github.com/users/colin-kiegel/received_events","type":"User","site_admin":false},"repo":{"id":65087808,"name":"rust-derive-builder","full_name":"colin-kiegel/rust-derive-builder","owner":{"login":"colin-kiegel","id":7691186,"avatar_url":"https://avatars3.githubusercontent.com/u/7691186?v=4","gravatar_id":"","url":"https://api.github.com/users/colin-kiegel","html_url":"https://github.com/colin-kiegel","followers_url":"https://api.github.com/users/colin-kiegel/followers","following_url":"https://api.github.com/users/colin-kiegel/following{/other_user}","gists_url":"https://api.github.com/users/colin-kiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/colin-kiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colin-kiegel/subscriptions","organizations_url":"https://api.github.com/users/colin-kiegel/orgs","repos_url":"https://api.github.com/users/colin-kiegel/repos","events_url":"https://api.github.com/users/colin-kiegel/events{/privacy}","received_events_url":"https://api.github.com/users/colin-kiegel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colin-kiegel/rust-derive-builder","description":"derive builder implementation for rust structs","fork":false,"url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder","forks_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/forks","keys_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/teams","hooks_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/hooks","issue_events_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/events{/number}","events_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/events","assignees_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/assignees{/user}","branches_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/branches{/branch}","tags_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/tags","blobs_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/languages","stargazers_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/stargazers","contributors_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/contributors","subscribers_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/subscribers","subscription_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/subscription","commits_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/contents/{+path}","compare_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/merges","archive_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/downloads","issues_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues{/number}","pulls_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/labels{/name}","releases_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/releases{/id}","deployments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/deployments","created_at":"2016-08-06T15:03:46Z","updated_at":"2018-05-01T03:10:47Z","pushed_at":"2018-03-12T22:15:39Z","git_url":"git://github.com/colin-kiegel/rust-derive-builder.git","ssh_url":"git@github.com:colin-kiegel/rust-derive-builder.git","clone_url":"https://github.com/colin-kiegel/rust-derive-builder.git","svn_url":"https://github.com/colin-kiegel/rust-derive-builder","homepage":"https://colin-kiegel.github.io/rust-derive-builder/","size":944,"stargazers_count":191,"watchers_count":191,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":30,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/111"},"html":{"href":"https://github.com/colin-kiegel/rust-derive-builder/pull/111"},"issue":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/111"},"comments":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/statuses/dfc1e695cb6a47d656a8fa2a3364ba9756faf556"}},"author_association":"NONE"}}
{"actor":{"display_login":"TedDriggs"}}