{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments/176793126","pull_request_review_id":106564782,"id":176793126,"diff_hunk":"@@ -0,0 +1,52 @@\n+// Copyright (c) .NET Foundation. All rights reserved.\n+// Licensed under the MIT License. See License.txt in the project root for license information.\n+\n+#include \"stdafx.h\"\n+#include \"CppUnitTest.h\"\n+\n+using namespace Microsoft::VisualStudio::CppUnitTestFramework;\n+\n+namespace AspNetCoreModuleTests\n+{\n+    TEST_CLASS(UTILITY_TESTS)\n+    {\n+    public:\n+\n+        TEST_METHOD(PassUnexpandedString_ExpandsResult)\n+        {\n+            HRESULT hr = S_OK;\n+            PCWSTR unexpandedString = L\"ANCM_TEST_ENV_VAR\";\n+            PCWSTR unexpandedStringValue = L\"foobar\";\n+            STRU   struExpandedString;\n+            SetEnvironmentVariable(L\"ANCM_TEST_ENV_VAR\", unexpandedStringValue);\n+\n+            hr = UTILITY::GetExpandedEnvironmentString(L\"%ANCM_TEST_ENV_VAR%\", &struExpandedString);","path":"test/AspNetCoreModuleTests/utility_tests.cpp","position":23,"original_position":23,"commit_id":"222fddbb3fd1c11cd6bde75bbf63e49afa49a077","original_commit_id":"222fddbb3fd1c11cd6bde75bbf63e49afa49a077","user":{"login":"pan-wang","id":18172635,"avatar_url":"https://avatars0.githubusercontent.com/u/18172635?v=4","gravatar_id":"","url":"https://api.github.com/users/pan-wang","html_url":"https://github.com/pan-wang","followers_url":"https://api.github.com/users/pan-wang/followers","following_url":"https://api.github.com/users/pan-wang/following{/other_user}","gists_url":"https://api.github.com/users/pan-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/pan-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pan-wang/subscriptions","organizations_url":"https://api.github.com/users/pan-wang/orgs","repos_url":"https://api.github.com/users/pan-wang/repos","events_url":"https://api.github.com/users/pan-wang/events{/privacy}","received_events_url":"https://api.github.com/users/pan-wang/received_events","type":"User","site_admin":false},"body":"it will be better to put the input as \"%ANCM_TEST_ENV_VAR%/test\" to make sure the resolved string is still valid.\r\nHow about if user give two parameters and both contains environment variables?","created_at":"2018-03-23T16:35:04Z","updated_at":"2018-03-23T16:35:04Z","html_url":"https://github.com/aspnet/IISIntegration/pull/715#discussion_r176793126","pull_request_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/715","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments/176793126"},"html":{"href":"https://github.com/aspnet/IISIntegration/pull/715#discussion_r176793126"},"pull_request":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/715"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/715","id":176851279,"html_url":"https://github.com/aspnet/IISIntegration/pull/715","diff_url":"https://github.com/aspnet/IISIntegration/pull/715.diff","patch_url":"https://github.com/aspnet/IISIntegration/pull/715.patch","issue_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/715","number":715,"state":"open","locked":false,"title":"Expand environment variables processPath and arguments, reject invalid processPaths.","user":{"login":"jkotalik","id":8302101,"avatar_url":"https://avatars0.githubusercontent.com/u/8302101?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotalik","html_url":"https://github.com/jkotalik","followers_url":"https://api.github.com/users/jkotalik/followers","following_url":"https://api.github.com/users/jkotalik/following{/other_user}","gists_url":"https://api.github.com/users/jkotalik/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotalik/subscriptions","organizations_url":"https://api.github.com/users/jkotalik/orgs","repos_url":"https://api.github.com/users/jkotalik/repos","events_url":"https://api.github.com/users/jkotalik/events{/privacy}","received_events_url":"https://api.github.com/users/jkotalik/received_events","type":"User","site_admin":false},"body":"For #686. This should have no impact on stress/perf scenarios, purely usability.","created_at":"2018-03-22T17:19:04Z","updated_at":"2018-03-23T16:35:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab61aa7290d39e6673afa4155bee9cc357571a20","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bangbingsyb","id":13987831,"avatar_url":"https://avatars0.githubusercontent.com/u/13987831?v=4","gravatar_id":"","url":"https://api.github.com/users/bangbingsyb","html_url":"https://github.com/bangbingsyb","followers_url":"https://api.github.com/users/bangbingsyb/followers","following_url":"https://api.github.com/users/bangbingsyb/following{/other_user}","gists_url":"https://api.github.com/users/bangbingsyb/gists{/gist_id}","starred_url":"https://api.github.com/users/bangbingsyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangbingsyb/subscriptions","organizations_url":"https://api.github.com/users/bangbingsyb/orgs","repos_url":"https://api.github.com/users/bangbingsyb/repos","events_url":"https://api.github.com/users/bangbingsyb/events{/privacy}","received_events_url":"https://api.github.com/users/bangbingsyb/received_events","type":"User","site_admin":false},{"login":"jhkimnew","id":20650163,"avatar_url":"https://avatars2.githubusercontent.com/u/20650163?v=4","gravatar_id":"","url":"https://api.github.com/users/jhkimnew","html_url":"https://github.com/jhkimnew","followers_url":"https://api.github.com/users/jhkimnew/followers","following_url":"https://api.github.com/users/jhkimnew/following{/other_user}","gists_url":"https://api.github.com/users/jhkimnew/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkimnew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkimnew/subscriptions","organizations_url":"https://api.github.com/users/jhkimnew/orgs","repos_url":"https://api.github.com/users/jhkimnew/repos","events_url":"https://api.github.com/users/jhkimnew/events{/privacy}","received_events_url":"https://api.github.com/users/jhkimnew/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/715/commits","review_comments_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/715/comments","review_comment_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/715/comments","statuses_url":"https://api.github.com/repos/aspnet/IISIntegration/statuses/222fddbb3fd1c11cd6bde75bbf63e49afa49a077","head":{"label":"aspnet:jkotalik/cleanupParsing","ref":"jkotalik/cleanupParsing","sha":"222fddbb3fd1c11cd6bde75bbf63e49afa49a077","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42883699,"name":"IISIntegration","full_name":"aspnet/IISIntegration","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/IISIntegration","description":"ASP.NET Core IIS integration","fork":false,"url":"https://api.github.com/repos/aspnet/IISIntegration","forks_url":"https://api.github.com/repos/aspnet/IISIntegration/forks","keys_url":"https://api.github.com/repos/aspnet/IISIntegration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/IISIntegration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/IISIntegration/teams","hooks_url":"https://api.github.com/repos/aspnet/IISIntegration/hooks","issue_events_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/IISIntegration/events","assignees_url":"https://api.github.com/repos/aspnet/IISIntegration/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/IISIntegration/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/IISIntegration/tags","blobs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/IISIntegration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/IISIntegration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/IISIntegration/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/IISIntegration/languages","stargazers_url":"https://api.github.com/repos/aspnet/IISIntegration/stargazers","contributors_url":"https://api.github.com/repos/aspnet/IISIntegration/contributors","subscribers_url":"https://api.github.com/repos/aspnet/IISIntegration/subscribers","subscription_url":"https://api.github.com/repos/aspnet/IISIntegration/subscription","commits_url":"https://api.github.com/repos/aspnet/IISIntegration/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/IISIntegration/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/IISIntegration/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/IISIntegration/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/IISIntegration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/IISIntegration/merges","archive_url":"https://api.github.com/repos/aspnet/IISIntegration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/IISIntegration/downloads","issues_url":"https://api.github.com/repos/aspnet/IISIntegration/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/IISIntegration/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/IISIntegration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/IISIntegration/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/IISIntegration/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/IISIntegration/deployments","created_at":"2015-09-21T17:55:09Z","updated_at":"2018-03-23T05:50:41Z","pushed_at":"2018-03-23T15:38:13Z","git_url":"git://github.com/aspnet/IISIntegration.git","ssh_url":"git@github.com:aspnet/IISIntegration.git","clone_url":"https://github.com/aspnet/IISIntegration.git","svn_url":"https://github.com/aspnet/IISIntegration","homepage":"","size":3003,"stargazers_count":88,"watchers_count":88,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":39,"open_issues":72,"watchers":88,"default_branch":"dev"}},"base":{"label":"aspnet:release/2.1","ref":"release/2.1","sha":"f1058f8575eeaa5caea688195565811207b19cab","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42883699,"name":"IISIntegration","full_name":"aspnet/IISIntegration","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/IISIntegration","description":"ASP.NET Core IIS integration","fork":false,"url":"https://api.github.com/repos/aspnet/IISIntegration","forks_url":"https://api.github.com/repos/aspnet/IISIntegration/forks","keys_url":"https://api.github.com/repos/aspnet/IISIntegration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/IISIntegration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/IISIntegration/teams","hooks_url":"https://api.github.com/repos/aspnet/IISIntegration/hooks","issue_events_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/IISIntegration/events","assignees_url":"https://api.github.com/repos/aspnet/IISIntegration/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/IISIntegration/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/IISIntegration/tags","blobs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/IISIntegration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/IISIntegration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/IISIntegration/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/IISIntegration/languages","stargazers_url":"https://api.github.com/repos/aspnet/IISIntegration/stargazers","contributors_url":"https://api.github.com/repos/aspnet/IISIntegration/contributors","subscribers_url":"https://api.github.com/repos/aspnet/IISIntegration/subscribers","subscription_url":"https://api.github.com/repos/aspnet/IISIntegration/subscription","commits_url":"https://api.github.com/repos/aspnet/IISIntegration/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/IISIntegration/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/IISIntegration/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/IISIntegration/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/IISIntegration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/IISIntegration/merges","archive_url":"https://api.github.com/repos/aspnet/IISIntegration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/IISIntegration/downloads","issues_url":"https://api.github.com/repos/aspnet/IISIntegration/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/IISIntegration/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/IISIntegration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/IISIntegration/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/IISIntegration/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/IISIntegration/deployments","created_at":"2015-09-21T17:55:09Z","updated_at":"2018-03-23T05:50:41Z","pushed_at":"2018-03-23T15:38:13Z","git_url":"git://github.com/aspnet/IISIntegration.git","ssh_url":"git@github.com:aspnet/IISIntegration.git","clone_url":"https://github.com/aspnet/IISIntegration.git","svn_url":"https://github.com/aspnet/IISIntegration","homepage":"","size":3003,"stargazers_count":88,"watchers_count":88,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":39,"open_issues":72,"watchers":88,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/715"},"html":{"href":"https://github.com/aspnet/IISIntegration/pull/715"},"issue":{"href":"https://api.github.com/repos/aspnet/IISIntegration/issues/715"},"comments":{"href":"https://api.github.com/repos/aspnet/IISIntegration/issues/715/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/715/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/715/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/IISIntegration/statuses/222fddbb3fd1c11cd6bde75bbf63e49afa49a077"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pan-wang"}}