{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments/223596239","pull_request_review_id":162754402,"id":223596239,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzU5NjIzOQ==","diff_hunk":"@@ -1,10 +1,10 @@\n-import { MissingContext } from '@aws-cdk/cx-api';\n+import cxapi = require('@aws-cdk/cx-api');\n import { Mode, SDK } from './api';\n import { debug } from './logging';\n import { Settings } from './settings';\n \n export interface ContextProviderPlugin {\n-  getValue(scope: string[], args: string[]): Promise<any>;\n+  getValue(filter: cxapi.ContextProviderProps): Promise<any>;","path":"packages/aws-cdk/lib/contextplugins.ts","position":9,"original_position":9,"commit_id":"f6c1ec2ffd29fec8909b90cb7daaf311013ab610","original_commit_id":"f6c1ec2ffd29fec8909b90cb7daaf311013ab610","user":{"login":"rix0rrr","id":524162,"node_id":"MDQ6VXNlcjUyNDE2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/524162?v=4","gravatar_id":"","url":"https://api.github.com/users/rix0rrr","html_url":"https://github.com/rix0rrr","followers_url":"https://api.github.com/users/rix0rrr/followers","following_url":"https://api.github.com/users/rix0rrr/following{/other_user}","gists_url":"https://api.github.com/users/rix0rrr/gists{/gist_id}","starred_url":"https://api.github.com/users/rix0rrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rix0rrr/subscriptions","organizations_url":"https://api.github.com/users/rix0rrr/orgs","repos_url":"https://api.github.com/users/rix0rrr/repos","events_url":"https://api.github.com/users/rix0rrr/events{/privacy}","received_events_url":"https://api.github.com/users/rix0rrr/received_events","type":"User","site_admin":false},"body":"\"filter\"?","created_at":"2018-10-09T08:06:14Z","updated_at":"2018-10-09T08:10:47Z","html_url":"https://github.com/awslabs/aws-cdk/pull/823#discussion_r223596239","pull_request_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/823","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments/223596239"},"html":{"href":"https://github.com/awslabs/aws-cdk/pull/823#discussion_r223596239"},"pull_request":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/823"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/823","id":219555589,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTU1NTg5","html_url":"https://github.com/awslabs/aws-cdk/pull/823","diff_url":"https://github.com/awslabs/aws-cdk/pull/823.diff","patch_url":"https://github.com/awslabs/aws-cdk/pull/823.patch","issue_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/823","number":823,"state":"open","locked":false,"title":"feat(context-providers) Enable arguments to be passed as property object","user":{"login":"moofish32","id":664280,"node_id":"MDQ6VXNlcjY2NDI4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/664280?v=4","gravatar_id":"","url":"https://api.github.com/users/moofish32","html_url":"https://github.com/moofish32","followers_url":"https://api.github.com/users/moofish32/followers","following_url":"https://api.github.com/users/moofish32/following{/other_user}","gists_url":"https://api.github.com/users/moofish32/gists{/gist_id}","starred_url":"https://api.github.com/users/moofish32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moofish32/subscriptions","organizations_url":"https://api.github.com/users/moofish32/orgs","repos_url":"https://api.github.com/users/moofish32/repos","events_url":"https://api.github.com/users/moofish32/events{/privacy}","received_events_url":"https://api.github.com/users/moofish32/received_events","type":"User","site_admin":false},"body":"This is a first draft at updates originally from #425\n\nI am attempting to apply some types to context providers where there were just arrays. \nThe arrays were good because of ordering, but I've attempted to preserve that with a sort. \n\nI would like to implement a VPC Provider because I find imports for VPCs painful. In addition\nto solving a customer problems VPC Provider will stress the ability to return a complex type.\n\nIs this design in the right direction?\n\nTODO - fix commit message this is a BREAKING Change\n\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.","created_at":"2018-10-02T00:42:24Z","updated_at":"2018-10-09T08:10:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63cc82ecbe7798fdcb92764229793742e46e5ead","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/823/commits","review_comments_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/823/comments","review_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/823/comments","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/f6c1ec2ffd29fec8909b90cb7daaf311013ab610","head":{"label":"moofish32:context-provider-fix","ref":"context-provider-fix","sha":"f6c1ec2ffd29fec8909b90cb7daaf311013ab610","user":{"login":"moofish32","id":664280,"node_id":"MDQ6VXNlcjY2NDI4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/664280?v=4","gravatar_id":"","url":"https://api.github.com/users/moofish32","html_url":"https://github.com/moofish32","followers_url":"https://api.github.com/users/moofish32/followers","following_url":"https://api.github.com/users/moofish32/following{/other_user}","gists_url":"https://api.github.com/users/moofish32/gists{/gist_id}","starred_url":"https://api.github.com/users/moofish32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moofish32/subscriptions","organizations_url":"https://api.github.com/users/moofish32/orgs","repos_url":"https://api.github.com/users/moofish32/repos","events_url":"https://api.github.com/users/moofish32/events{/privacy}","received_events_url":"https://api.github.com/users/moofish32/received_events","type":"User","site_admin":false},"repo":{"id":143065635,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNjU2MzU=","name":"aws-cdk","full_name":"moofish32/aws-cdk","private":false,"owner":{"login":"moofish32","id":664280,"node_id":"MDQ6VXNlcjY2NDI4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/664280?v=4","gravatar_id":"","url":"https://api.github.com/users/moofish32","html_url":"https://github.com/moofish32","followers_url":"https://api.github.com/users/moofish32/followers","following_url":"https://api.github.com/users/moofish32/following{/other_user}","gists_url":"https://api.github.com/users/moofish32/gists{/gist_id}","starred_url":"https://api.github.com/users/moofish32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moofish32/subscriptions","organizations_url":"https://api.github.com/users/moofish32/orgs","repos_url":"https://api.github.com/users/moofish32/repos","events_url":"https://api.github.com/users/moofish32/events{/privacy}","received_events_url":"https://api.github.com/users/moofish32/received_events","type":"User","site_admin":false},"html_url":"https://github.com/moofish32/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":true,"url":"https://api.github.com/repos/moofish32/aws-cdk","forks_url":"https://api.github.com/repos/moofish32/aws-cdk/forks","keys_url":"https://api.github.com/repos/moofish32/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moofish32/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moofish32/aws-cdk/teams","hooks_url":"https://api.github.com/repos/moofish32/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/moofish32/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/moofish32/aws-cdk/events","assignees_url":"https://api.github.com/repos/moofish32/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/moofish32/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/moofish32/aws-cdk/tags","blobs_url":"https://api.github.com/repos/moofish32/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moofish32/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moofish32/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/moofish32/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moofish32/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/moofish32/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/moofish32/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/moofish32/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/moofish32/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/moofish32/aws-cdk/subscription","commits_url":"https://api.github.com/repos/moofish32/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/moofish32/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/moofish32/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/moofish32/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/moofish32/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/moofish32/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moofish32/aws-cdk/merges","archive_url":"https://api.github.com/repos/moofish32/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moofish32/aws-cdk/downloads","issues_url":"https://api.github.com/repos/moofish32/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/moofish32/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/moofish32/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/moofish32/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moofish32/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/moofish32/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/moofish32/aws-cdk/deployments","created_at":"2018-07-31T20:39:17Z","updated_at":"2018-07-31T20:39:21Z","pushed_at":"2018-10-09T08:04:35Z","git_url":"git://github.com/moofish32/aws-cdk.git","ssh_url":"git@github.com:moofish32/aws-cdk.git","clone_url":"https://github.com/moofish32/aws-cdk.git","svn_url":"https://github.com/moofish32/aws-cdk","homepage":"https://awslabs.github.io/aws-cdk","size":52489,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"eb4bacfff68a2f2549572c5714057af01c12b7aa","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":105808767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MDg3Njc=","name":"aws-cdk","full_name":"awslabs/aws-cdk","private":false,"owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awslabs/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":false,"url":"https://api.github.com/repos/awslabs/aws-cdk","forks_url":"https://api.github.com/repos/awslabs/aws-cdk/forks","keys_url":"https://api.github.com/repos/awslabs/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-cdk/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-cdk/events","assignees_url":"https://api.github.com/repos/awslabs/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-cdk/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-cdk/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-cdk/merges","archive_url":"https://api.github.com/repos/awslabs/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-cdk/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-cdk/deployments","created_at":"2017-10-04T19:22:36Z","updated_at":"2018-10-09T04:21:10Z","pushed_at":"2018-10-09T08:04:36Z","git_url":"git://github.com/awslabs/aws-cdk.git","ssh_url":"git@github.com:awslabs/aws-cdk.git","clone_url":"https://github.com/awslabs/aws-cdk.git","svn_url":"https://github.com/awslabs/aws-cdk","homepage":"https://awslabs.github.io/aws-cdk","size":113981,"stargazers_count":944,"watchers_count":944,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":244,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":66,"open_issues":244,"watchers":944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/823"},"html":{"href":"https://github.com/awslabs/aws-cdk/pull/823"},"issue":{"href":"https://api.github.com/repos/awslabs/aws-cdk/issues/823"},"comments":{"href":"https://api.github.com/repos/awslabs/aws-cdk/issues/823/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/823/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/823/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/aws-cdk/statuses/f6c1ec2ffd29fec8909b90cb7daaf311013ab610"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rix0rrr"}}