{"action":"created","comment":{"url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments/203306107","pull_request_review_id":138166385,"id":203306107,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzMwNjEwNw==","diff_hunk":"@@ -473,22 +488,35 @@ def modify_domain_xml():\n             for x in xrange(at_times):\n                 ret = virsh.detach_device(vm_name, dev_xml.xml,\n                                           flagstr=attach_option)\n+                if ret.stderr and host_unplug_errors:\n+                    for known_error in host_unplug_errors:\n+                        if (known_error[0] == known_error[-1]) and \\\n+                           known_error.startswith((\"'\")):\n+                            known_error = known_error[1:-1]\n+                        if known_error in ret.stderr:\n+                            unplug_failed_with_known_error = True\n+                            logging.debug(\"Known error occured in Host, while\"\n+                                          \" hot unplug: %s\", known_error)\n+                if unplug_failed_with_known_error:\n+                    break","path":"libvirt/tests/src/libvirt_mem.py","position":70,"original_position":70,"commit_id":"dd4a4f3ce4222b2fe85cb0057223799edd355602","original_commit_id":"dd4a4f3ce4222b2fe85cb0057223799edd355602","user":{"login":"harihare","id":16549932,"node_id":"MDQ6VXNlcjE2NTQ5OTMy","avatar_url":"https://avatars2.githubusercontent.com/u/16549932?v=4","gravatar_id":"","url":"https://api.github.com/users/harihare","html_url":"https://github.com/harihare","followers_url":"https://api.github.com/users/harihare/followers","following_url":"https://api.github.com/users/harihare/following{/other_user}","gists_url":"https://api.github.com/users/harihare/gists{/gist_id}","starred_url":"https://api.github.com/users/harihare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harihare/subscriptions","organizations_url":"https://api.github.com/users/harihare/orgs","repos_url":"https://api.github.com/users/harihare/repos","events_url":"https://api.github.com/users/harihare/events{/privacy}","received_events_url":"https://api.github.com/users/harihare/received_events","type":"User","site_admin":false},"body":"Break is  called only when the known failure has occurred. For all unknown errors the test will fail. As discussed it is working fine.  ","created_at":"2018-07-18T09:13:13Z","updated_at":"2018-07-18T09:13:13Z","html_url":"https://github.com/autotest/tp-libvirt/pull/1700#discussion_r203306107","pull_request_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/1700","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments/203306107"},"html":{"href":"https://github.com/autotest/tp-libvirt/pull/1700#discussion_r203306107"},"pull_request":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/1700"}},"in_reply_to_id":202969726},"pull_request":{"url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/1700","id":198241113,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MjQxMTEz","html_url":"https://github.com/autotest/tp-libvirt/pull/1700","diff_url":"https://github.com/autotest/tp-libvirt/pull/1700.diff","patch_url":"https://github.com/autotest/tp-libvirt/pull/1700.patch","issue_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/1700","number":1700,"state":"open","locked":false,"title":"Enable tests for max slots.","user":{"login":"harihare","id":16549932,"node_id":"MDQ6VXNlcjE2NTQ5OTMy","avatar_url":"https://avatars2.githubusercontent.com/u/16549932?v=4","gravatar_id":"","url":"https://api.github.com/users/harihare","html_url":"https://github.com/harihare","followers_url":"https://api.github.com/users/harihare/followers","following_url":"https://api.github.com/users/harihare/following{/other_user}","gists_url":"https://api.github.com/users/harihare/gists{/gist_id}","starred_url":"https://api.github.com/users/harihare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harihare/subscriptions","organizations_url":"https://api.github.com/users/harihare/orgs","repos_url":"https://api.github.com/users/harihare/repos","events_url":"https://api.github.com/users/harihare/events{/privacy}","received_events_url":"https://api.github.com/users/harihare/received_events","type":"User","site_admin":false},"body":"Added tests scenarious to cover max_slots.\r\n\r\nSigned-off-by: Hariharan T.S <hari@linux.vnet.ibm.com>","created_at":"2018-06-29T07:52:29Z","updated_at":"2018-07-18T09:13:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6cdc3ddd214bfed3e77b2a4c61c4a998032f9b4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/1700/commits","review_comments_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/1700/comments","review_comment_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/1700/comments","statuses_url":"https://api.github.com/repos/autotest/tp-libvirt/statuses/dd4a4f3ce4222b2fe85cb0057223799edd355602","head":{"label":"harihare:hp_max","ref":"hp_max","sha":"dd4a4f3ce4222b2fe85cb0057223799edd355602","user":{"login":"harihare","id":16549932,"node_id":"MDQ6VXNlcjE2NTQ5OTMy","avatar_url":"https://avatars2.githubusercontent.com/u/16549932?v=4","gravatar_id":"","url":"https://api.github.com/users/harihare","html_url":"https://github.com/harihare","followers_url":"https://api.github.com/users/harihare/followers","following_url":"https://api.github.com/users/harihare/following{/other_user}","gists_url":"https://api.github.com/users/harihare/gists{/gist_id}","starred_url":"https://api.github.com/users/harihare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harihare/subscriptions","organizations_url":"https://api.github.com/users/harihare/orgs","repos_url":"https://api.github.com/users/harihare/repos","events_url":"https://api.github.com/users/harihare/events{/privacy}","received_events_url":"https://api.github.com/users/harihare/received_events","type":"User","site_admin":false},"repo":{"id":126858608,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4NTg2MDg=","name":"tp-libvirt","full_name":"harihare/tp-libvirt","owner":{"login":"harihare","id":16549932,"node_id":"MDQ6VXNlcjE2NTQ5OTMy","avatar_url":"https://avatars2.githubusercontent.com/u/16549932?v=4","gravatar_id":"","url":"https://api.github.com/users/harihare","html_url":"https://github.com/harihare","followers_url":"https://api.github.com/users/harihare/followers","following_url":"https://api.github.com/users/harihare/following{/other_user}","gists_url":"https://api.github.com/users/harihare/gists{/gist_id}","starred_url":"https://api.github.com/users/harihare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harihare/subscriptions","organizations_url":"https://api.github.com/users/harihare/orgs","repos_url":"https://api.github.com/users/harihare/repos","events_url":"https://api.github.com/users/harihare/events{/privacy}","received_events_url":"https://api.github.com/users/harihare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harihare/tp-libvirt","description":"Test Provider for Libvirt and related virtualization backends","fork":true,"url":"https://api.github.com/repos/harihare/tp-libvirt","forks_url":"https://api.github.com/repos/harihare/tp-libvirt/forks","keys_url":"https://api.github.com/repos/harihare/tp-libvirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harihare/tp-libvirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harihare/tp-libvirt/teams","hooks_url":"https://api.github.com/repos/harihare/tp-libvirt/hooks","issue_events_url":"https://api.github.com/repos/harihare/tp-libvirt/issues/events{/number}","events_url":"https://api.github.com/repos/harihare/tp-libvirt/events","assignees_url":"https://api.github.com/repos/harihare/tp-libvirt/assignees{/user}","branches_url":"https://api.github.com/repos/harihare/tp-libvirt/branches{/branch}","tags_url":"https://api.github.com/repos/harihare/tp-libvirt/tags","blobs_url":"https://api.github.com/repos/harihare/tp-libvirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harihare/tp-libvirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harihare/tp-libvirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/harihare/tp-libvirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harihare/tp-libvirt/statuses/{sha}","languages_url":"https://api.github.com/repos/harihare/tp-libvirt/languages","stargazers_url":"https://api.github.com/repos/harihare/tp-libvirt/stargazers","contributors_url":"https://api.github.com/repos/harihare/tp-libvirt/contributors","subscribers_url":"https://api.github.com/repos/harihare/tp-libvirt/subscribers","subscription_url":"https://api.github.com/repos/harihare/tp-libvirt/subscription","commits_url":"https://api.github.com/repos/harihare/tp-libvirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/harihare/tp-libvirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/harihare/tp-libvirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/harihare/tp-libvirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/harihare/tp-libvirt/contents/{+path}","compare_url":"https://api.github.com/repos/harihare/tp-libvirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harihare/tp-libvirt/merges","archive_url":"https://api.github.com/repos/harihare/tp-libvirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harihare/tp-libvirt/downloads","issues_url":"https://api.github.com/repos/harihare/tp-libvirt/issues{/number}","pulls_url":"https://api.github.com/repos/harihare/tp-libvirt/pulls{/number}","milestones_url":"https://api.github.com/repos/harihare/tp-libvirt/milestones{/number}","notifications_url":"https://api.github.com/repos/harihare/tp-libvirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harihare/tp-libvirt/labels{/name}","releases_url":"https://api.github.com/repos/harihare/tp-libvirt/releases{/id}","deployments_url":"https://api.github.com/repos/harihare/tp-libvirt/deployments","created_at":"2018-03-26T16:36:41Z","updated_at":"2018-06-29T07:44:29Z","pushed_at":"2018-07-12T18:41:19Z","git_url":"git://github.com/harihare/tp-libvirt.git","ssh_url":"git@github.com:harihare/tp-libvirt.git","clone_url":"https://github.com/harihare/tp-libvirt.git","svn_url":"https://github.com/harihare/tp-libvirt","homepage":null,"size":12726,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"6c8c0f56e8d5443119e4aada349e8e4e01d5fd54","user":{"login":"autotest","id":472856,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/472856?v=4","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":16180517,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE4MDUxNw==","name":"tp-libvirt","full_name":"autotest/tp-libvirt","owner":{"login":"autotest","id":472856,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/472856?v=4","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autotest/tp-libvirt","description":"Test Provider for Libvirt and related virtualization backends","fork":false,"url":"https://api.github.com/repos/autotest/tp-libvirt","forks_url":"https://api.github.com/repos/autotest/tp-libvirt/forks","keys_url":"https://api.github.com/repos/autotest/tp-libvirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/tp-libvirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/tp-libvirt/teams","hooks_url":"https://api.github.com/repos/autotest/tp-libvirt/hooks","issue_events_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/tp-libvirt/events","assignees_url":"https://api.github.com/repos/autotest/tp-libvirt/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/tp-libvirt/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/tp-libvirt/tags","blobs_url":"https://api.github.com/repos/autotest/tp-libvirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/tp-libvirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/tp-libvirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/tp-libvirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/tp-libvirt/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/tp-libvirt/languages","stargazers_url":"https://api.github.com/repos/autotest/tp-libvirt/stargazers","contributors_url":"https://api.github.com/repos/autotest/tp-libvirt/contributors","subscribers_url":"https://api.github.com/repos/autotest/tp-libvirt/subscribers","subscription_url":"https://api.github.com/repos/autotest/tp-libvirt/subscription","commits_url":"https://api.github.com/repos/autotest/tp-libvirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/tp-libvirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/tp-libvirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/autotest/tp-libvirt/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/tp-libvirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/tp-libvirt/merges","archive_url":"https://api.github.com/repos/autotest/tp-libvirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/tp-libvirt/downloads","issues_url":"https://api.github.com/repos/autotest/tp-libvirt/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/tp-libvirt/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/tp-libvirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/tp-libvirt/labels{/name}","releases_url":"https://api.github.com/repos/autotest/tp-libvirt/releases{/id}","deployments_url":"https://api.github.com/repos/autotest/tp-libvirt/deployments","created_at":"2014-01-23T17:58:18Z","updated_at":"2018-07-18T01:17:17Z","pushed_at":"2018-07-18T06:49:01Z","git_url":"git://github.com/autotest/tp-libvirt.git","ssh_url":"git@github.com:autotest/tp-libvirt.git","clone_url":"https://github.com/autotest/tp-libvirt.git","svn_url":"https://github.com/autotest/tp-libvirt","homepage":null,"size":12790,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":106,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":106,"open_issues":95,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/1700"},"html":{"href":"https://github.com/autotest/tp-libvirt/pull/1700"},"issue":{"href":"https://api.github.com/repos/autotest/tp-libvirt/issues/1700"},"comments":{"href":"https://api.github.com/repos/autotest/tp-libvirt/issues/1700/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/1700/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/1700/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/tp-libvirt/statuses/dd4a4f3ce4222b2fe85cb0057223799edd355602"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"harihare"}}