{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/libprio/issues/17","repository_url":"https://api.github.com/repos/mozilla/libprio","labels_url":"https://api.github.com/repos/mozilla/libprio/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/libprio/issues/17/comments","events_url":"https://api.github.com/repos/mozilla/libprio/issues/17/events","html_url":"https://github.com/mozilla/libprio/issues/17","id":353822444,"node_id":"MDU6SXNzdWUzNTM4MjI0NDQ=","number":17,"title":"libprio does not compile with MSVC","user":{"login":"rhelmer","id":61412,"node_id":"MDQ6VXNlcjYxNDEy","avatar_url":"https://avatars0.githubusercontent.com/u/61412?v=4","gravatar_id":"","url":"https://api.github.com/users/rhelmer","html_url":"https://github.com/rhelmer","followers_url":"https://api.github.com/users/rhelmer/followers","following_url":"https://api.github.com/users/rhelmer/following{/other_user}","gists_url":"https://api.github.com/users/rhelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhelmer/subscriptions","organizations_url":"https://api.github.com/users/rhelmer/orgs","repos_url":"https://api.github.com/users/rhelmer/repos","events_url":"https://api.github.com/users/rhelmer/events{/privacy}","received_events_url":"https://api.github.com/users/rhelmer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-24T15:08:39Z","updated_at":"2018-08-24T17:46:41Z","closed_at":null,"author_association":"MEMBER","body":"Most Firefox builders use Clang/LLVM nowadays but one of our builders still uses MSVC so this came up:\r\n\r\nhttps://treeherder.mozilla.org/logviewer.html#?job_id=195697225&repo=mozilla-central&lineNumber=6090\r\n\r\n10:05:12     INFO -  z:/build/build/src/third_party/prio/prio/encrypt.c(80): error C2057: expected constant expression\r\n10:05:12     INFO -  z:/build/build/src/third_party/prio/prio/encrypt.c(80): error C2466: cannot allocate an array of constant size 0\r\n10:05:12     INFO -  z:/build/build/src/third_party/prio/prio/encrypt.c(80): error C2133: 'key_bytes': unknown size\r\n10:05:12     INFO -  z:/build/build/src/third_party/prio/prio/encrypt.c(84): error C2057: expected constant expression\r\n10:05:12     INFO -  z:/build/build/src/third_party/prio/prio/encrypt.c(84): error C2466: cannot allocate an array of constant size 0\r\n10:05:12     INFO -  z:/build/build/src/third_party/prio/prio/encrypt.c(84): error C2133: 'spki_data': unknown size\r\n10:05:12     INFO -  z:/build/build/src/third_party/prio/prio/encrypt.c(281): error C2057: expected constant expression\r\n10:05:12     INFO -  z:/build/build/src/third_party/prio/prio/encrypt.c(281): error C2466: cannot allocate an array of constant size 0\r\n10:05:12     INFO -  z:/build/build/src/third_party/prio/prio/encrypt.c(281): error C2133: 'aadBuf': unknown size\r\n10:05:12     INFO -  z:/build/build/src/third_party/prio/prio/encrypt.c(319): error C2057: expected constant expression\r\n10:05:12     INFO -  z:/build/build/src/third_party/prio/prio/encrypt.c(319): error C2466: cannot allocate an array of constant size 0\r\n10:05:12     INFO -  z:/build/build/src/third_party/prio/prio/encrypt.c(319): error C2133: 'aad_buf': unknown size\r\n\r\nI believe this is because MSVC doesn't support VLAs (variable length arrays), it wants the array size to be specified at compile time:\r\n\r\nhttps://stackoverflow.com/questions/5246900/enabling-vlasvariable-length-arrays-in-ms-visual-c"},"comment":{"url":"https://api.github.com/repos/mozilla/libprio/issues/comments/415832217","html_url":"https://github.com/mozilla/libprio/issues/17#issuecomment-415832217","issue_url":"https://api.github.com/repos/mozilla/libprio/issues/17","id":415832217,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTgzMjIxNw==","user":{"login":"rhelmer","id":61412,"node_id":"MDQ6VXNlcjYxNDEy","avatar_url":"https://avatars0.githubusercontent.com/u/61412?v=4","gravatar_id":"","url":"https://api.github.com/users/rhelmer","html_url":"https://github.com/rhelmer","followers_url":"https://api.github.com/users/rhelmer/followers","following_url":"https://api.github.com/users/rhelmer/following{/other_user}","gists_url":"https://api.github.com/users/rhelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhelmer/subscriptions","organizations_url":"https://api.github.com/users/rhelmer/orgs","repos_url":"https://api.github.com/users/rhelmer/repos","events_url":"https://api.github.com/users/rhelmer/events{/privacy}","received_events_url":"https://api.github.com/users/rhelmer/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T17:46:41Z","updated_at":"2018-08-24T17:46:41Z","author_association":"MEMBER","body":"Hm. So, I *do* think it's valuable for libprio to compile w/ MSVC so this is worth fixing, but since this is a Tier-2 platform for Firefox, and confidence is high that we will switch to Clang soon, I might just not build prio on Firefox when MSVC is in use so we don't have to rush on this."}}
{"actor":{"display_login":"rhelmer"}}