{"action":"created","issue":{"url":"https://api.github.com/repos/igrigorik/em-http-request/issues/316","repository_url":"https://api.github.com/repos/igrigorik/em-http-request","labels_url":"https://api.github.com/repos/igrigorik/em-http-request/issues/316/labels{/name}","comments_url":"https://api.github.com/repos/igrigorik/em-http-request/issues/316/comments","events_url":"https://api.github.com/repos/igrigorik/em-http-request/issues/316/events","html_url":"https://github.com/igrigorik/em-http-request/issues/316","id":311030268,"node_id":"MDU6SXNzdWUzMTEwMzAyNjg=","number":316,"title":"Tests fail with newer http-parser library (2.1 was okay, 2.7.1 is failing)","user":{"login":"cbiedl","id":5489007,"node_id":"MDQ6VXNlcjU0ODkwMDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5489007?v=4","gravatar_id":"","url":"https://api.github.com/users/cbiedl","html_url":"https://github.com/cbiedl","followers_url":"https://api.github.com/users/cbiedl/followers","following_url":"https://api.github.com/users/cbiedl/following{/other_user}","gists_url":"https://api.github.com/users/cbiedl/gists{/gist_id}","starred_url":"https://api.github.com/users/cbiedl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbiedl/subscriptions","organizations_url":"https://api.github.com/users/cbiedl/orgs","repos_url":"https://api.github.com/users/cbiedl/repos","events_url":"https://api.github.com/users/cbiedl/events{/privacy}","received_events_url":"https://api.github.com/users/cbiedl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-03T23:13:29Z","updated_at":"2018-07-31T15:37:21Z","closed_at":null,"author_association":"NONE","body":"Hello,\r\n\r\nas reported in the Debian BTS <https://bugs.debian.org/881627>, em-http-request started to fail the test suite after http-parser was upgraded from 2.1 to 2.7.1, the problem still exists with the most recent version 2.8.1.\r\n\r\nThe most important error lines are:\r\n```\r\n     NoMethodError:\r\n       undefined method `continue?' for nil:NilClass\r\n     # ./lib/em-http/http_connection.rb:134:in `block in post_init'\r\n```\r\n\r\nAfter staring at the code for a long time and using Ruby's \"Tracer\" it seems http-parser calls message_complete more often than in earlier times but your library cannot deal with this. I might be completely wrong here, especially since I couldn't find any releated change in http-parser. Before starting a fairly annoying `git bisect` session, I'm asking you to take a look - my Ruby knowledge is basically \"guessing from looking at the code\".\r\n"},"comment":{"url":"https://api.github.com/repos/igrigorik/em-http-request/issues/comments/409265960","html_url":"https://github.com/igrigorik/em-http-request/issues/316#issuecomment-409265960","issue_url":"https://api.github.com/repos/igrigorik/em-http-request/issues/316","id":409265960,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTI2NTk2MA==","user":{"login":"boutil","id":990732,"node_id":"MDQ6VXNlcjk5MDczMg==","avatar_url":"https://avatars2.githubusercontent.com/u/990732?v=4","gravatar_id":"","url":"https://api.github.com/users/boutil","html_url":"https://github.com/boutil","followers_url":"https://api.github.com/users/boutil/followers","following_url":"https://api.github.com/users/boutil/following{/other_user}","gists_url":"https://api.github.com/users/boutil/gists{/gist_id}","starred_url":"https://api.github.com/users/boutil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutil/subscriptions","organizations_url":"https://api.github.com/users/boutil/orgs","repos_url":"https://api.github.com/users/boutil/repos","events_url":"https://api.github.com/users/boutil/events{/privacy}","received_events_url":"https://api.github.com/users/boutil/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T15:37:21Z","updated_at":"2018-07-31T15:37:21Z","author_association":"NONE","body":"Hi,\r\n\r\nFor the record, I think that the bug report @cbiedl wanted to point out is: \r\nhttps://bugs.debian.org/cgi-bin/bugreport.cgi?bug=882308 (not 881627)."}}
{"actor":{"display_login":"boutil"}}