{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/184025996","pull_request_review_id":115135997,"id":184025996,"diff_hunk":"@@ -212,11 +212,11 @@\n \n #define TZDRAM_BASE\t\t\t(CFG_DDR_TEETZ_RESERVED_START)\n #define TZDRAM_SIZE\t\t\t\t(CFG_DDR_TEETZ_RESERVED_SIZE - \\\n-\t\t\t\t\t\tCFG_PUB_RAM_SIZE)\n+\t\t\t\t\t\t\tCFG_PUB_RAM_SIZE)\n \n-#define CFG_SHMEM_START\t\t\t(CFG_DDR_TEETZ_RESERVED_START + \\\n+#define TEE_SHMEM_START\t\t\t(CFG_DDR_TEETZ_RESERVED_START + \\\n \t\t\t\t\t\tTZDRAM_SIZE)\n-#define CFG_SHMEM_SIZE\t\t\tCFG_PUB_RAM_SIZE\n+#define TEE_SHMEM_SIZE\t\t\tCFG_PUB_RAM_SIZE","path":"core/arch/arm/plat-zynq7k/platform_config.h","position":25,"original_position":11,"commit_id":"2eb78fef8239b4338d39dad365678193ef7a1487","original_commit_id":"5d55229fd93a7a7b70a8a94fdc104644d8f0a168","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars0.githubusercontent.com/u/6150306?v=4","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"body":"We should consider replacing `CFG_PUB_RAM_SIZE` with `CFG_SHMEM_SIZE`, doesn't have to be done in this commit though.","created_at":"2018-04-25T11:33:39Z","updated_at":"2018-04-25T11:33:45Z","html_url":"https://github.com/OP-TEE/optee_os/pull/2275#discussion_r184025996","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2275","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/184025996"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2275#discussion_r184025996"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2275"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2275","id":183750010,"html_url":"https://github.com/OP-TEE/optee_os/pull/2275","diff_url":"https://github.com/OP-TEE/optee_os/pull/2275.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/2275.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2275","number":2275,"state":"open","locked":false,"title":"Cleanup CFG_'s generic configurations","user":{"login":"etienne-lms","id":19990310,"avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"body":"`CFG_xxx` are configuration directive and should not be set from the C/Asm source files.\r\n\r\n`CFG_TEE_RAM_xxx` and `CFG_TA_RAM_xxx` are never set from the env and very few platforms offer `CFG_SHMEM_xxx`. This change removes `CFG_` prefix from these as well as `TEE_LOAD_ADDR`.\r\n\r\nHowever, platforms can allows some configurations to be taken into account from platform_config.h, i.e:\r\n```c\r\n#ifdef CFG_TEE_LOAD_ADDR\r\n#define TEE_LOAD_ADDR      CFG_TEE_LOAD_ADDR\r\n#else\r\n#define TEE_LOAD_ADDR      TEE_RAM_START\r\n#endif\r\n```\r\nThis change does not modify the platform implementation, it is (should be) only about renaming.\r\n\r\nThis change is the first step for removing all `CFG_xxx` definitions from **platform_config.h** files, as proposed by https://github.com/OP-TEE/optee_os/pull/2273.\r\n\r\n","created_at":"2018-04-24T14:10:44Z","updated_at":"2018-04-25T11:33:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"941aa3778ba2a5d5e7bb45e3201516c4227dbf4b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2275/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2275/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2275/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/2eb78fef8239b4338d39dad365678193ef7a1487","head":{"label":"etienne-lms:gen-cfg","ref":"gen-cfg","sha":"2eb78fef8239b4338d39dad365678193ef7a1487","user":{"login":"etienne-lms","id":19990310,"avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"repo":{"id":62886797,"name":"optee_os","full_name":"etienne-lms/optee_os","owner":{"login":"etienne-lms","id":19990310,"avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/etienne-lms/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/etienne-lms/optee_os","forks_url":"https://api.github.com/repos/etienne-lms/optee_os/forks","keys_url":"https://api.github.com/repos/etienne-lms/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etienne-lms/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etienne-lms/optee_os/teams","hooks_url":"https://api.github.com/repos/etienne-lms/optee_os/hooks","issue_events_url":"https://api.github.com/repos/etienne-lms/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/etienne-lms/optee_os/events","assignees_url":"https://api.github.com/repos/etienne-lms/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/etienne-lms/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/etienne-lms/optee_os/tags","blobs_url":"https://api.github.com/repos/etienne-lms/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etienne-lms/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etienne-lms/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/etienne-lms/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etienne-lms/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/etienne-lms/optee_os/languages","stargazers_url":"https://api.github.com/repos/etienne-lms/optee_os/stargazers","contributors_url":"https://api.github.com/repos/etienne-lms/optee_os/contributors","subscribers_url":"https://api.github.com/repos/etienne-lms/optee_os/subscribers","subscription_url":"https://api.github.com/repos/etienne-lms/optee_os/subscription","commits_url":"https://api.github.com/repos/etienne-lms/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/etienne-lms/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/etienne-lms/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/etienne-lms/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/etienne-lms/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/etienne-lms/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etienne-lms/optee_os/merges","archive_url":"https://api.github.com/repos/etienne-lms/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etienne-lms/optee_os/downloads","issues_url":"https://api.github.com/repos/etienne-lms/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/etienne-lms/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/etienne-lms/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/etienne-lms/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etienne-lms/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/etienne-lms/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/etienne-lms/optee_os/deployments","created_at":"2016-07-08T12:24:05Z","updated_at":"2016-07-08T12:24:09Z","pushed_at":"2018-04-24T14:09:26Z","git_url":"git://github.com/etienne-lms/optee_os.git","ssh_url":"git@github.com:etienne-lms/optee_os.git","clone_url":"https://github.com/etienne-lms/optee_os.git","svn_url":"https://github.com/etienne-lms/optee_os","homepage":null,"size":13271,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"9a159b2fcb11df3b78b14e7f305a9b9240d04bd7","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/optee_os/deployments","created_at":"2014-05-26T17:18:57Z","updated_at":"2018-04-25T10:49:23Z","pushed_at":"2018-04-25T10:49:12Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":12923,"stargazers_count":381,"watchers_count":381,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":333,"mirror_url":null,"archived":false,"open_issues_count":171,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":333,"open_issues":171,"watchers":381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2275"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2275"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2275"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2275/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2275/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2275/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/2eb78fef8239b4338d39dad365678193ef7a1487"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jenswi-linaro"}}