{"action":"created","comment":{"url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls/comments/224657340","pull_request_review_id":164081057,"id":224657340,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDY1NzM0MA==","diff_hunk":"@@ -0,0 +1,29 @@\n+package com.elavon.converge.util;\n+\n+public class RequestUtil {\n+\n+    private static final String HYPHEN = \"-\";\n+    private static final String DEFAULT_POYNT_USER = \"PoyntUser\";\n+\n+    public static String getDeviceUserValue(String firstName, String lastName, String nickname) {\n+        StringBuilder userBuilder = new StringBuilder();\n+        if (nickname != null && nickname.length() > 0) {\n+            if((firstName != null && firstName.length() > 0) ||\n+                    (lastName != null && lastName.length() > 0)) {\n+                userBuilder.append(nickname).append(HYPHEN);\n+            }\n+        }\n+        if (firstName != null && firstName.length() > 0) {\n+            if(lastName != null && lastName.length() > 0) {\n+                userBuilder.append(firstName).append(HYPHEN);","path":"app/src/main/java/com/elavon/converge/util/RequestUtil.java","position":18,"original_position":18,"commit_id":"fcc0df1b833a7084e3eb419d349c2d1e394cd636","original_commit_id":"fcc0df1b833a7084e3eb419d349c2d1e394cd636","user":{"login":"ppalavilli","id":354338,"node_id":"MDQ6VXNlcjM1NDMzOA==","avatar_url":"https://avatars3.githubusercontent.com/u/354338?v=4","gravatar_id":"","url":"https://api.github.com/users/ppalavilli","html_url":"https://github.com/ppalavilli","followers_url":"https://api.github.com/users/ppalavilli/followers","following_url":"https://api.github.com/users/ppalavilli/following{/other_user}","gists_url":"https://api.github.com/users/ppalavilli/gists{/gist_id}","starred_url":"https://api.github.com/users/ppalavilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppalavilli/subscriptions","organizations_url":"https://api.github.com/users/ppalavilli/orgs","repos_url":"https://api.github.com/users/ppalavilli/repos","events_url":"https://api.github.com/users/ppalavilli/events{/privacy}","received_events_url":"https://api.github.com/users/ppalavilli/received_events","type":"User","site_admin":false},"body":"rather than appending - prepend so when there is no last name the user won't be \"nickname-firstname-\" ","created_at":"2018-10-12T02:42:20Z","updated_at":"2018-10-12T02:42:20Z","html_url":"https://github.com/poynt/ElavonConvergeProcessor/pull/51#discussion_r224657340","pull_request_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls/51","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls/comments/224657340"},"html":{"href":"https://github.com/poynt/ElavonConvergeProcessor/pull/51#discussion_r224657340"},"pull_request":{"href":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls/51","id":221449236,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNDQ5MjM2","html_url":"https://github.com/poynt/ElavonConvergeProcessor/pull/51","diff_url":"https://github.com/poynt/ElavonConvergeProcessor/pull/51.diff","patch_url":"https://github.com/poynt/ElavonConvergeProcessor/pull/51.patch","issue_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/issues/51","number":51,"state":"open","locked":false,"title":"Device User Info in Elavon APIs","user":{"login":"abhi-poynt","id":41158114,"node_id":"MDQ6VXNlcjQxMTU4MTE0","avatar_url":"https://avatars2.githubusercontent.com/u/41158114?v=4","gravatar_id":"","url":"https://api.github.com/users/abhi-poynt","html_url":"https://github.com/abhi-poynt","followers_url":"https://api.github.com/users/abhi-poynt/followers","following_url":"https://api.github.com/users/abhi-poynt/following{/other_user}","gists_url":"https://api.github.com/users/abhi-poynt/gists{/gist_id}","starred_url":"https://api.github.com/users/abhi-poynt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhi-poynt/subscriptions","organizations_url":"https://api.github.com/users/abhi-poynt/orgs","repos_url":"https://api.github.com/users/abhi-poynt/repos","events_url":"https://api.github.com/users/abhi-poynt/events{/privacy}","received_events_url":"https://api.github.com/users/abhi-poynt/received_events","type":"User","site_admin":false},"body":"Issue / Jira :\r\nhttps://poyntc.atlassian.net/browse/DEV-1377\r\n\r\nTargeted Release :\r\nOct, 2018\r\n\r\nRoot Cause :\r\n\r\n\r\nSolution :\r\n\r\n\r\nNotes :\r\n\r\n\r\nTest Cases :\r\n","created_at":"2018-10-09T13:55:31Z","updated_at":"2018-10-12T02:42:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74b6ea252cda6b235366ca457a65f285b1248f58","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls/51/commits","review_comments_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls/51/comments","review_comment_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/issues/51/comments","statuses_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/statuses/fcc0df1b833a7084e3eb419d349c2d1e394cd636","head":{"label":"abhi-poynt:DEV-1377","ref":"DEV-1377","sha":"fcc0df1b833a7084e3eb419d349c2d1e394cd636","user":{"login":"abhi-poynt","id":41158114,"node_id":"MDQ6VXNlcjQxMTU4MTE0","avatar_url":"https://avatars2.githubusercontent.com/u/41158114?v=4","gravatar_id":"","url":"https://api.github.com/users/abhi-poynt","html_url":"https://github.com/abhi-poynt","followers_url":"https://api.github.com/users/abhi-poynt/followers","following_url":"https://api.github.com/users/abhi-poynt/following{/other_user}","gists_url":"https://api.github.com/users/abhi-poynt/gists{/gist_id}","starred_url":"https://api.github.com/users/abhi-poynt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhi-poynt/subscriptions","organizations_url":"https://api.github.com/users/abhi-poynt/orgs","repos_url":"https://api.github.com/users/abhi-poynt/repos","events_url":"https://api.github.com/users/abhi-poynt/events{/privacy}","received_events_url":"https://api.github.com/users/abhi-poynt/received_events","type":"User","site_admin":false},"repo":{"id":144140261,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQxNDAyNjE=","name":"ElavonConvergeProcessor","full_name":"abhi-poynt/ElavonConvergeProcessor","private":false,"owner":{"login":"abhi-poynt","id":41158114,"node_id":"MDQ6VXNlcjQxMTU4MTE0","avatar_url":"https://avatars2.githubusercontent.com/u/41158114?v=4","gravatar_id":"","url":"https://api.github.com/users/abhi-poynt","html_url":"https://github.com/abhi-poynt","followers_url":"https://api.github.com/users/abhi-poynt/followers","following_url":"https://api.github.com/users/abhi-poynt/following{/other_user}","gists_url":"https://api.github.com/users/abhi-poynt/gists{/gist_id}","starred_url":"https://api.github.com/users/abhi-poynt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhi-poynt/subscriptions","organizations_url":"https://api.github.com/users/abhi-poynt/orgs","repos_url":"https://api.github.com/users/abhi-poynt/repos","events_url":"https://api.github.com/users/abhi-poynt/events{/privacy}","received_events_url":"https://api.github.com/users/abhi-poynt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/abhi-poynt/ElavonConvergeProcessor","description":null,"fork":true,"url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor","forks_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/forks","keys_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/teams","hooks_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/hooks","issue_events_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/issues/events{/number}","events_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/events","assignees_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/assignees{/user}","branches_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/branches{/branch}","tags_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/tags","blobs_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/statuses/{sha}","languages_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/languages","stargazers_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/stargazers","contributors_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/contributors","subscribers_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/subscribers","subscription_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/subscription","commits_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/contents/{+path}","compare_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/merges","archive_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/downloads","issues_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/issues{/number}","pulls_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/pulls{/number}","milestones_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/milestones{/number}","notifications_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/labels{/name}","releases_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/releases{/id}","deployments_url":"https://api.github.com/repos/abhi-poynt/ElavonConvergeProcessor/deployments","created_at":"2018-08-09T10:56:33Z","updated_at":"2018-09-14T06:19:50Z","pushed_at":"2018-10-11T08:57:13Z","git_url":"git://github.com/abhi-poynt/ElavonConvergeProcessor.git","ssh_url":"git@github.com:abhi-poynt/ElavonConvergeProcessor.git","clone_url":"https://github.com/abhi-poynt/ElavonConvergeProcessor.git","svn_url":"https://github.com/abhi-poynt/ElavonConvergeProcessor","homepage":null,"size":536,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"poynt:develop","ref":"develop","sha":"6ad49e669b286fe7fe779b2ae672064afb675406","user":{"login":"poynt","id":5994663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTQ2NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5994663?v=4","gravatar_id":"","url":"https://api.github.com/users/poynt","html_url":"https://github.com/poynt","followers_url":"https://api.github.com/users/poynt/followers","following_url":"https://api.github.com/users/poynt/following{/other_user}","gists_url":"https://api.github.com/users/poynt/gists{/gist_id}","starred_url":"https://api.github.com/users/poynt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poynt/subscriptions","organizations_url":"https://api.github.com/users/poynt/orgs","repos_url":"https://api.github.com/users/poynt/repos","events_url":"https://api.github.com/users/poynt/events{/privacy}","received_events_url":"https://api.github.com/users/poynt/received_events","type":"Organization","site_admin":false},"repo":{"id":107744664,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc3NDQ2NjQ=","name":"ElavonConvergeProcessor","full_name":"poynt/ElavonConvergeProcessor","private":false,"owner":{"login":"poynt","id":5994663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTQ2NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5994663?v=4","gravatar_id":"","url":"https://api.github.com/users/poynt","html_url":"https://github.com/poynt","followers_url":"https://api.github.com/users/poynt/followers","following_url":"https://api.github.com/users/poynt/following{/other_user}","gists_url":"https://api.github.com/users/poynt/gists{/gist_id}","starred_url":"https://api.github.com/users/poynt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poynt/subscriptions","organizations_url":"https://api.github.com/users/poynt/orgs","repos_url":"https://api.github.com/users/poynt/repos","events_url":"https://api.github.com/users/poynt/events{/privacy}","received_events_url":"https://api.github.com/users/poynt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/poynt/ElavonConvergeProcessor","description":null,"fork":false,"url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor","forks_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/forks","keys_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/teams","hooks_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/hooks","issue_events_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/issues/events{/number}","events_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/events","assignees_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/assignees{/user}","branches_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/branches{/branch}","tags_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/tags","blobs_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/git/refs{/sha}","trees_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/statuses/{sha}","languages_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/languages","stargazers_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/stargazers","contributors_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/contributors","subscribers_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/subscribers","subscription_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/subscription","commits_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/commits{/sha}","git_commits_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/git/commits{/sha}","comments_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/comments{/number}","issue_comment_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/issues/comments{/number}","contents_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/contents/{+path}","compare_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/merges","archive_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/downloads","issues_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/issues{/number}","pulls_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls{/number}","milestones_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/milestones{/number}","notifications_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/labels{/name}","releases_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/releases{/id}","deployments_url":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/deployments","created_at":"2017-10-21T02:21:15Z","updated_at":"2018-10-12T02:41:09Z","pushed_at":"2018-10-12T02:41:08Z","git_url":"git://github.com/poynt/ElavonConvergeProcessor.git","ssh_url":"git@github.com:poynt/ElavonConvergeProcessor.git","clone_url":"https://github.com/poynt/ElavonConvergeProcessor.git","svn_url":"https://github.com/poynt/ElavonConvergeProcessor","homepage":null,"size":531,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":11,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls/51"},"html":{"href":"https://github.com/poynt/ElavonConvergeProcessor/pull/51"},"issue":{"href":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/issues/51"},"comments":{"href":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/poynt/ElavonConvergeProcessor/statuses/fcc0df1b833a7084e3eb419d349c2d1e394cd636"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ppalavilli"}}