{"action":"created","comment":{"url":"https://api.github.com/repos/conversationai/conversationai-models/pulls/comments/232516481","pull_request_review_id":173728766,"id":232516481,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjUxNjQ4MQ==","diff_hunk":"@@ -48,12 +48,14 @@ def _input_fn_from_file(self, filepath: str) -> types.FeatureAndLabelTensors:\n \n     parsed_dataset = dataset.map(\n         self._read_tf_example, num_parallel_calls=multiprocessing.cpu_count())\n+    return parsed_dataset\n \n-    padded_shapes = ({\n-        self._text_feature: [],\n-    }, {label: [] for label in self._labels})\n-    batched_dataset = parsed_dataset.prefetch(self._num_prefetch)\n-    return batched_dataset\n+    #padded_shapes = ({ self._text_feature: [] },","path":"experiments/tf_trainer/common/tfrecord_simple.py","position":11,"original_position":11,"commit_id":"df9d60d298f2002051097a415943cb85e2102bb2","original_commit_id":"df9d60d298f2002051097a415943cb85e2102bb2","user":{"login":"fprost","id":28877982,"node_id":"MDQ6VXNlcjI4ODc3OTgy","avatar_url":"https://avatars0.githubusercontent.com/u/28877982?v=4","gravatar_id":"","url":"https://api.github.com/users/fprost","html_url":"https://github.com/fprost","followers_url":"https://api.github.com/users/fprost/followers","following_url":"https://api.github.com/users/fprost/following{/other_user}","gists_url":"https://api.github.com/users/fprost/gists{/gist_id}","starred_url":"https://api.github.com/users/fprost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fprost/subscriptions","organizations_url":"https://api.github.com/users/fprost/orgs","repos_url":"https://api.github.com/users/fprost/repos","events_url":"https://api.github.com/users/fprost/events{/privacy}","received_events_url":"https://api.github.com/users/fprost/received_events","type":"User","site_admin":false},"body":"You need to keep some level of batching done, as mentioned in the email.\r\nBucket_by_sequence_length is not required.","created_at":"2018-11-12T01:30:09Z","updated_at":"2018-11-12T01:30:09Z","html_url":"https://github.com/conversationai/conversationai-models/pull/178#discussion_r232516481","pull_request_url":"https://api.github.com/repos/conversationai/conversationai-models/pulls/178","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/conversationai/conversationai-models/pulls/comments/232516481"},"html":{"href":"https://github.com/conversationai/conversationai-models/pull/178#discussion_r232516481"},"pull_request":{"href":"https://api.github.com/repos/conversationai/conversationai-models/pulls/178"}},"in_reply_to_id":232494898},"pull_request":{"url":"https://api.github.com/repos/conversationai/conversationai-models/pulls/178","id":229910604,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTEwNjA0","html_url":"https://github.com/conversationai/conversationai-models/pull/178","diff_url":"https://github.com/conversationai/conversationai-models/pull/178.diff","patch_url":"https://github.com/conversationai/conversationai-models/pull/178.patch","issue_url":"https://api.github.com/repos/conversationai/conversationai-models/issues/178","number":178,"state":"open","locked":false,"title":"Add test for simple record reader, fix various problems and comments.","user":{"login":"sorensenjs","id":8582676,"node_id":"MDQ6VXNlcjg1ODI2NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/8582676?v=4","gravatar_id":"","url":"https://api.github.com/users/sorensenjs","html_url":"https://github.com/sorensenjs","followers_url":"https://api.github.com/users/sorensenjs/followers","following_url":"https://api.github.com/users/sorensenjs/following{/other_user}","gists_url":"https://api.github.com/users/sorensenjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sorensenjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorensenjs/subscriptions","organizations_url":"https://api.github.com/users/sorensenjs/orgs","repos_url":"https://api.github.com/users/sorensenjs/repos","events_url":"https://api.github.com/users/sorensenjs/events{/privacy}","received_events_url":"https://api.github.com/users/sorensenjs/received_events","type":"User","site_admin":false},"body":"Trying to get to the bottom of the too-good performance questions.\r\nPTAL","created_at":"2018-11-10T20:09:19Z","updated_at":"2018-11-12T01:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"867af85cb780fa01658998ff603f0e2ba93e8433","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fprost","id":28877982,"node_id":"MDQ6VXNlcjI4ODc3OTgy","avatar_url":"https://avatars0.githubusercontent.com/u/28877982?v=4","gravatar_id":"","url":"https://api.github.com/users/fprost","html_url":"https://github.com/fprost","followers_url":"https://api.github.com/users/fprost/followers","following_url":"https://api.github.com/users/fprost/following{/other_user}","gists_url":"https://api.github.com/users/fprost/gists{/gist_id}","starred_url":"https://api.github.com/users/fprost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fprost/subscriptions","organizations_url":"https://api.github.com/users/fprost/orgs","repos_url":"https://api.github.com/users/fprost/repos","events_url":"https://api.github.com/users/fprost/events{/privacy}","received_events_url":"https://api.github.com/users/fprost/received_events","type":"User","site_admin":false},{"login":"nthain","id":30469739,"node_id":"MDQ6VXNlcjMwNDY5NzM5","avatar_url":"https://avatars2.githubusercontent.com/u/30469739?v=4","gravatar_id":"","url":"https://api.github.com/users/nthain","html_url":"https://github.com/nthain","followers_url":"https://api.github.com/users/nthain/followers","following_url":"https://api.github.com/users/nthain/following{/other_user}","gists_url":"https://api.github.com/users/nthain/gists{/gist_id}","starred_url":"https://api.github.com/users/nthain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nthain/subscriptions","organizations_url":"https://api.github.com/users/nthain/orgs","repos_url":"https://api.github.com/users/nthain/repos","events_url":"https://api.github.com/users/nthain/events{/privacy}","received_events_url":"https://api.github.com/users/nthain/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/conversationai/conversationai-models/pulls/178/commits","review_comments_url":"https://api.github.com/repos/conversationai/conversationai-models/pulls/178/comments","review_comment_url":"https://api.github.com/repos/conversationai/conversationai-models/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conversationai/conversationai-models/issues/178/comments","statuses_url":"https://api.github.com/repos/conversationai/conversationai-models/statuses/df9d60d298f2002051097a415943cb85e2102bb2","head":{"label":"conversationai:tfreadrefactor","ref":"tfreadrefactor","sha":"df9d60d298f2002051097a415943cb85e2102bb2","user":{"login":"conversationai","id":23317692,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzE3Njky","avatar_url":"https://avatars1.githubusercontent.com/u/23317692?v=4","gravatar_id":"","url":"https://api.github.com/users/conversationai","html_url":"https://github.com/conversationai","followers_url":"https://api.github.com/users/conversationai/followers","following_url":"https://api.github.com/users/conversationai/following{/other_user}","gists_url":"https://api.github.com/users/conversationai/gists{/gist_id}","starred_url":"https://api.github.com/users/conversationai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conversationai/subscriptions","organizations_url":"https://api.github.com/users/conversationai/orgs","repos_url":"https://api.github.com/users/conversationai/repos","events_url":"https://api.github.com/users/conversationai/events{/privacy}","received_events_url":"https://api.github.com/users/conversationai/received_events","type":"Organization","site_admin":false},"repo":{"id":123941779,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5NDE3Nzk=","name":"conversationai-models","full_name":"conversationai/conversationai-models","private":false,"owner":{"login":"conversationai","id":23317692,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzE3Njky","avatar_url":"https://avatars1.githubusercontent.com/u/23317692?v=4","gravatar_id":"","url":"https://api.github.com/users/conversationai","html_url":"https://github.com/conversationai","followers_url":"https://api.github.com/users/conversationai/followers","following_url":"https://api.github.com/users/conversationai/following{/other_user}","gists_url":"https://api.github.com/users/conversationai/gists{/gist_id}","starred_url":"https://api.github.com/users/conversationai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conversationai/subscriptions","organizations_url":"https://api.github.com/users/conversationai/orgs","repos_url":"https://api.github.com/users/conversationai/repos","events_url":"https://api.github.com/users/conversationai/events{/privacy}","received_events_url":"https://api.github.com/users/conversationai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/conversationai/conversationai-models","description":"A repository to house model building experiments and tools that are part of the Conversation AI effort.","fork":false,"url":"https://api.github.com/repos/conversationai/conversationai-models","forks_url":"https://api.github.com/repos/conversationai/conversationai-models/forks","keys_url":"https://api.github.com/repos/conversationai/conversationai-models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conversationai/conversationai-models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conversationai/conversationai-models/teams","hooks_url":"https://api.github.com/repos/conversationai/conversationai-models/hooks","issue_events_url":"https://api.github.com/repos/conversationai/conversationai-models/issues/events{/number}","events_url":"https://api.github.com/repos/conversationai/conversationai-models/events","assignees_url":"https://api.github.com/repos/conversationai/conversationai-models/assignees{/user}","branches_url":"https://api.github.com/repos/conversationai/conversationai-models/branches{/branch}","tags_url":"https://api.github.com/repos/conversationai/conversationai-models/tags","blobs_url":"https://api.github.com/repos/conversationai/conversationai-models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conversationai/conversationai-models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conversationai/conversationai-models/git/refs{/sha}","trees_url":"https://api.github.com/repos/conversationai/conversationai-models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conversationai/conversationai-models/statuses/{sha}","languages_url":"https://api.github.com/repos/conversationai/conversationai-models/languages","stargazers_url":"https://api.github.com/repos/conversationai/conversationai-models/stargazers","contributors_url":"https://api.github.com/repos/conversationai/conversationai-models/contributors","subscribers_url":"https://api.github.com/repos/conversationai/conversationai-models/subscribers","subscription_url":"https://api.github.com/repos/conversationai/conversationai-models/subscription","commits_url":"https://api.github.com/repos/conversationai/conversationai-models/commits{/sha}","git_commits_url":"https://api.github.com/repos/conversationai/conversationai-models/git/commits{/sha}","comments_url":"https://api.github.com/repos/conversationai/conversationai-models/comments{/number}","issue_comment_url":"https://api.github.com/repos/conversationai/conversationai-models/issues/comments{/number}","contents_url":"https://api.github.com/repos/conversationai/conversationai-models/contents/{+path}","compare_url":"https://api.github.com/repos/conversationai/conversationai-models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conversationai/conversationai-models/merges","archive_url":"https://api.github.com/repos/conversationai/conversationai-models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conversationai/conversationai-models/downloads","issues_url":"https://api.github.com/repos/conversationai/conversationai-models/issues{/number}","pulls_url":"https://api.github.com/repos/conversationai/conversationai-models/pulls{/number}","milestones_url":"https://api.github.com/repos/conversationai/conversationai-models/milestones{/number}","notifications_url":"https://api.github.com/repos/conversationai/conversationai-models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conversationai/conversationai-models/labels{/name}","releases_url":"https://api.github.com/repos/conversationai/conversationai-models/releases{/id}","deployments_url":"https://api.github.com/repos/conversationai/conversationai-models/deployments","created_at":"2018-03-05T15:46:21Z","updated_at":"2018-11-10T16:04:51Z","pushed_at":"2018-11-12T00:07:11Z","git_url":"git://github.com/conversationai/conversationai-models.git","ssh_url":"git@github.com:conversationai/conversationai-models.git","clone_url":"https://github.com/conversationai/conversationai-models.git","svn_url":"https://github.com/conversationai/conversationai-models","homepage":null,"size":3626,"stargazers_count":40,"watchers_count":40,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":31,"watchers":40,"default_branch":"master"}},"base":{"label":"conversationai:master","ref":"master","sha":"0ab95705a427e33d5030c8235237dacafac80789","user":{"login":"conversationai","id":23317692,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzE3Njky","avatar_url":"https://avatars1.githubusercontent.com/u/23317692?v=4","gravatar_id":"","url":"https://api.github.com/users/conversationai","html_url":"https://github.com/conversationai","followers_url":"https://api.github.com/users/conversationai/followers","following_url":"https://api.github.com/users/conversationai/following{/other_user}","gists_url":"https://api.github.com/users/conversationai/gists{/gist_id}","starred_url":"https://api.github.com/users/conversationai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conversationai/subscriptions","organizations_url":"https://api.github.com/users/conversationai/orgs","repos_url":"https://api.github.com/users/conversationai/repos","events_url":"https://api.github.com/users/conversationai/events{/privacy}","received_events_url":"https://api.github.com/users/conversationai/received_events","type":"Organization","site_admin":false},"repo":{"id":123941779,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5NDE3Nzk=","name":"conversationai-models","full_name":"conversationai/conversationai-models","private":false,"owner":{"login":"conversationai","id":23317692,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzE3Njky","avatar_url":"https://avatars1.githubusercontent.com/u/23317692?v=4","gravatar_id":"","url":"https://api.github.com/users/conversationai","html_url":"https://github.com/conversationai","followers_url":"https://api.github.com/users/conversationai/followers","following_url":"https://api.github.com/users/conversationai/following{/other_user}","gists_url":"https://api.github.com/users/conversationai/gists{/gist_id}","starred_url":"https://api.github.com/users/conversationai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conversationai/subscriptions","organizations_url":"https://api.github.com/users/conversationai/orgs","repos_url":"https://api.github.com/users/conversationai/repos","events_url":"https://api.github.com/users/conversationai/events{/privacy}","received_events_url":"https://api.github.com/users/conversationai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/conversationai/conversationai-models","description":"A repository to house model building experiments and tools that are part of the Conversation AI effort.","fork":false,"url":"https://api.github.com/repos/conversationai/conversationai-models","forks_url":"https://api.github.com/repos/conversationai/conversationai-models/forks","keys_url":"https://api.github.com/repos/conversationai/conversationai-models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conversationai/conversationai-models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conversationai/conversationai-models/teams","hooks_url":"https://api.github.com/repos/conversationai/conversationai-models/hooks","issue_events_url":"https://api.github.com/repos/conversationai/conversationai-models/issues/events{/number}","events_url":"https://api.github.com/repos/conversationai/conversationai-models/events","assignees_url":"https://api.github.com/repos/conversationai/conversationai-models/assignees{/user}","branches_url":"https://api.github.com/repos/conversationai/conversationai-models/branches{/branch}","tags_url":"https://api.github.com/repos/conversationai/conversationai-models/tags","blobs_url":"https://api.github.com/repos/conversationai/conversationai-models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conversationai/conversationai-models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conversationai/conversationai-models/git/refs{/sha}","trees_url":"https://api.github.com/repos/conversationai/conversationai-models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conversationai/conversationai-models/statuses/{sha}","languages_url":"https://api.github.com/repos/conversationai/conversationai-models/languages","stargazers_url":"https://api.github.com/repos/conversationai/conversationai-models/stargazers","contributors_url":"https://api.github.com/repos/conversationai/conversationai-models/contributors","subscribers_url":"https://api.github.com/repos/conversationai/conversationai-models/subscribers","subscription_url":"https://api.github.com/repos/conversationai/conversationai-models/subscription","commits_url":"https://api.github.com/repos/conversationai/conversationai-models/commits{/sha}","git_commits_url":"https://api.github.com/repos/conversationai/conversationai-models/git/commits{/sha}","comments_url":"https://api.github.com/repos/conversationai/conversationai-models/comments{/number}","issue_comment_url":"https://api.github.com/repos/conversationai/conversationai-models/issues/comments{/number}","contents_url":"https://api.github.com/repos/conversationai/conversationai-models/contents/{+path}","compare_url":"https://api.github.com/repos/conversationai/conversationai-models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conversationai/conversationai-models/merges","archive_url":"https://api.github.com/repos/conversationai/conversationai-models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conversationai/conversationai-models/downloads","issues_url":"https://api.github.com/repos/conversationai/conversationai-models/issues{/number}","pulls_url":"https://api.github.com/repos/conversationai/conversationai-models/pulls{/number}","milestones_url":"https://api.github.com/repos/conversationai/conversationai-models/milestones{/number}","notifications_url":"https://api.github.com/repos/conversationai/conversationai-models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conversationai/conversationai-models/labels{/name}","releases_url":"https://api.github.com/repos/conversationai/conversationai-models/releases{/id}","deployments_url":"https://api.github.com/repos/conversationai/conversationai-models/deployments","created_at":"2018-03-05T15:46:21Z","updated_at":"2018-11-10T16:04:51Z","pushed_at":"2018-11-12T00:07:11Z","git_url":"git://github.com/conversationai/conversationai-models.git","ssh_url":"git@github.com:conversationai/conversationai-models.git","clone_url":"https://github.com/conversationai/conversationai-models.git","svn_url":"https://github.com/conversationai/conversationai-models","homepage":null,"size":3626,"stargazers_count":40,"watchers_count":40,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":31,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conversationai/conversationai-models/pulls/178"},"html":{"href":"https://github.com/conversationai/conversationai-models/pull/178"},"issue":{"href":"https://api.github.com/repos/conversationai/conversationai-models/issues/178"},"comments":{"href":"https://api.github.com/repos/conversationai/conversationai-models/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/conversationai/conversationai-models/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/conversationai/conversationai-models/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conversationai/conversationai-models/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/conversationai/conversationai-models/statuses/df9d60d298f2002051097a415943cb85e2102bb2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"fprost"}}