{"action":"closed","number":199,"pull_request":{"url":"https://api.github.com/repos/jxnblk/mdx-deck/pulls/199","id":222184035,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTg0MDM1","html_url":"https://github.com/jxnblk/mdx-deck/pull/199","diff_url":"https://github.com/jxnblk/mdx-deck/pull/199.diff","patch_url":"https://github.com/jxnblk/mdx-deck/pull/199.patch","issue_url":"https://api.github.com/repos/jxnblk/mdx-deck/issues/199","number":199,"state":"closed","locked":false,"title":"Take out \", 10\" from an if check","user":{"login":"jnielson94","id":13559161,"node_id":"MDQ6VXNlcjEzNTU5MTYx","avatar_url":"https://avatars3.githubusercontent.com/u/13559161?v=4","gravatar_id":"","url":"https://api.github.com/users/jnielson94","html_url":"https://github.com/jnielson94","followers_url":"https://api.github.com/users/jnielson94/followers","following_url":"https://api.github.com/users/jnielson94/following{/other_user}","gists_url":"https://api.github.com/users/jnielson94/gists{/gist_id}","starred_url":"https://api.github.com/users/jnielson94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnielson94/subscriptions","organizations_url":"https://api.github.com/users/jnielson94/orgs","repos_url":"https://api.github.com/users/jnielson94/repos","events_url":"https://api.github.com/users/jnielson94/events{/privacy}","received_events_url":"https://api.github.com/users/jnielson94/received_events","type":"User","site_admin":false},"body":"I ran into an issue when I was running a hosted version of an mdx-deck, and I think this is the cause. There were localStorage keys changing outside of these two, and I think the \", 10\" in this condition was causing it to always be true.\r\n\r\nI ran the tests and they still pass, and the demo still looked to be working. @jxnblk Were you attached to this \", 10\"? Or was it just a stray bit of code?\r\n\r\nThe resulting behavior was a total crash of mdx-deck since it managed to set the step to NaN. I tried to reproduce locally by adding and changing a custom localStorage key, but it seems like the development version of react gives this warning and doesn't actually set the prop:\r\n\r\n```\r\nreact-dom.development.js:515 Warning: Received NaN for the `step` attribute. If this is expected, cast the value to a string.\r\n    in div (created by styled.div)\r\n    in styled.div (created by SlideDeck)\r\n    in div (created by Swipeable)\r\n    in Swipeable (created by SlideDeck)\r\n    in Provider (created by SlideDeck)\r\n    in MDXProvider (created by SlideDeck)\r\n    in ThemeProvider (created by SlideDeck)\r\n    in HeadProvider (created by SlideDeck)\r\n    in SlideDeck (created by App)\r\n    in App\r\n```","created_at":"2018-10-11T15:33:16Z","updated_at":"2018-11-18T15:53:54Z","closed_at":"2018-11-18T15:53:54Z","merged_at":"2018-11-18T15:53:54Z","merge_commit_sha":"257d97118ca25f768f495cf7b464f12bd7de25cb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jxnblk/mdx-deck/pulls/199/commits","review_comments_url":"https://api.github.com/repos/jxnblk/mdx-deck/pulls/199/comments","review_comment_url":"https://api.github.com/repos/jxnblk/mdx-deck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jxnblk/mdx-deck/issues/199/comments","statuses_url":"https://api.github.com/repos/jxnblk/mdx-deck/statuses/c7c735678dc45733c20ef6ee1f565557a72e0284","head":{"label":"jnielson94:patch-1","ref":"patch-1","sha":"c7c735678dc45733c20ef6ee1f565557a72e0284","user":{"login":"jnielson94","id":13559161,"node_id":"MDQ6VXNlcjEzNTU5MTYx","avatar_url":"https://avatars3.githubusercontent.com/u/13559161?v=4","gravatar_id":"","url":"https://api.github.com/users/jnielson94","html_url":"https://github.com/jnielson94","followers_url":"https://api.github.com/users/jnielson94/followers","following_url":"https://api.github.com/users/jnielson94/following{/other_user}","gists_url":"https://api.github.com/users/jnielson94/gists{/gist_id}","starred_url":"https://api.github.com/users/jnielson94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnielson94/subscriptions","organizations_url":"https://api.github.com/users/jnielson94/orgs","repos_url":"https://api.github.com/users/jnielson94/repos","events_url":"https://api.github.com/users/jnielson94/events{/privacy}","received_events_url":"https://api.github.com/users/jnielson94/received_events","type":"User","site_admin":false},"repo":{"id":152607135,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI2MDcxMzU=","name":"mdx-deck","full_name":"jnielson94/mdx-deck","private":false,"owner":{"login":"jnielson94","id":13559161,"node_id":"MDQ6VXNlcjEzNTU5MTYx","avatar_url":"https://avatars3.githubusercontent.com/u/13559161?v=4","gravatar_id":"","url":"https://api.github.com/users/jnielson94","html_url":"https://github.com/jnielson94","followers_url":"https://api.github.com/users/jnielson94/followers","following_url":"https://api.github.com/users/jnielson94/following{/other_user}","gists_url":"https://api.github.com/users/jnielson94/gists{/gist_id}","starred_url":"https://api.github.com/users/jnielson94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnielson94/subscriptions","organizations_url":"https://api.github.com/users/jnielson94/orgs","repos_url":"https://api.github.com/users/jnielson94/repos","events_url":"https://api.github.com/users/jnielson94/events{/privacy}","received_events_url":"https://api.github.com/users/jnielson94/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jnielson94/mdx-deck","description":":spades: MDX-based presentation decks","fork":true,"url":"https://api.github.com/repos/jnielson94/mdx-deck","forks_url":"https://api.github.com/repos/jnielson94/mdx-deck/forks","keys_url":"https://api.github.com/repos/jnielson94/mdx-deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jnielson94/mdx-deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jnielson94/mdx-deck/teams","hooks_url":"https://api.github.com/repos/jnielson94/mdx-deck/hooks","issue_events_url":"https://api.github.com/repos/jnielson94/mdx-deck/issues/events{/number}","events_url":"https://api.github.com/repos/jnielson94/mdx-deck/events","assignees_url":"https://api.github.com/repos/jnielson94/mdx-deck/assignees{/user}","branches_url":"https://api.github.com/repos/jnielson94/mdx-deck/branches{/branch}","tags_url":"https://api.github.com/repos/jnielson94/mdx-deck/tags","blobs_url":"https://api.github.com/repos/jnielson94/mdx-deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jnielson94/mdx-deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jnielson94/mdx-deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/jnielson94/mdx-deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jnielson94/mdx-deck/statuses/{sha}","languages_url":"https://api.github.com/repos/jnielson94/mdx-deck/languages","stargazers_url":"https://api.github.com/repos/jnielson94/mdx-deck/stargazers","contributors_url":"https://api.github.com/repos/jnielson94/mdx-deck/contributors","subscribers_url":"https://api.github.com/repos/jnielson94/mdx-deck/subscribers","subscription_url":"https://api.github.com/repos/jnielson94/mdx-deck/subscription","commits_url":"https://api.github.com/repos/jnielson94/mdx-deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/jnielson94/mdx-deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/jnielson94/mdx-deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/jnielson94/mdx-deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/jnielson94/mdx-deck/contents/{+path}","compare_url":"https://api.github.com/repos/jnielson94/mdx-deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jnielson94/mdx-deck/merges","archive_url":"https://api.github.com/repos/jnielson94/mdx-deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jnielson94/mdx-deck/downloads","issues_url":"https://api.github.com/repos/jnielson94/mdx-deck/issues{/number}","pulls_url":"https://api.github.com/repos/jnielson94/mdx-deck/pulls{/number}","milestones_url":"https://api.github.com/repos/jnielson94/mdx-deck/milestones{/number}","notifications_url":"https://api.github.com/repos/jnielson94/mdx-deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jnielson94/mdx-deck/labels{/name}","releases_url":"https://api.github.com/repos/jnielson94/mdx-deck/releases{/id}","deployments_url":"https://api.github.com/repos/jnielson94/mdx-deck/deployments","created_at":"2018-10-11T14:40:58Z","updated_at":"2018-10-11T14:41:00Z","pushed_at":"2018-10-11T14:45:10Z","git_url":"git://github.com/jnielson94/mdx-deck.git","ssh_url":"git@github.com:jnielson94/mdx-deck.git","clone_url":"https://github.com/jnielson94/mdx-deck.git","svn_url":"https://github.com/jnielson94/mdx-deck","homepage":"https://jxnblk.com/mdx-deck","size":2133,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jxnblk:master","ref":"master","sha":"321e3261ec11c0a633e2bbe249a2c204b88ae13d","user":{"login":"jxnblk","id":3451712,"node_id":"MDQ6VXNlcjM0NTE3MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3451712?v=4","gravatar_id":"","url":"https://api.github.com/users/jxnblk","html_url":"https://github.com/jxnblk","followers_url":"https://api.github.com/users/jxnblk/followers","following_url":"https://api.github.com/users/jxnblk/following{/other_user}","gists_url":"https://api.github.com/users/jxnblk/gists{/gist_id}","starred_url":"https://api.github.com/users/jxnblk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jxnblk/subscriptions","organizations_url":"https://api.github.com/users/jxnblk/orgs","repos_url":"https://api.github.com/users/jxnblk/repos","events_url":"https://api.github.com/users/jxnblk/events{/privacy}","received_events_url":"https://api.github.com/users/jxnblk/received_events","type":"User","site_admin":false},"repo":{"id":142714512,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI3MTQ1MTI=","name":"mdx-deck","full_name":"jxnblk/mdx-deck","private":false,"owner":{"login":"jxnblk","id":3451712,"node_id":"MDQ6VXNlcjM0NTE3MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3451712?v=4","gravatar_id":"","url":"https://api.github.com/users/jxnblk","html_url":"https://github.com/jxnblk","followers_url":"https://api.github.com/users/jxnblk/followers","following_url":"https://api.github.com/users/jxnblk/following{/other_user}","gists_url":"https://api.github.com/users/jxnblk/gists{/gist_id}","starred_url":"https://api.github.com/users/jxnblk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jxnblk/subscriptions","organizations_url":"https://api.github.com/users/jxnblk/orgs","repos_url":"https://api.github.com/users/jxnblk/repos","events_url":"https://api.github.com/users/jxnblk/events{/privacy}","received_events_url":"https://api.github.com/users/jxnblk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jxnblk/mdx-deck","description":":spades: MDX-based presentation decks","fork":false,"url":"https://api.github.com/repos/jxnblk/mdx-deck","forks_url":"https://api.github.com/repos/jxnblk/mdx-deck/forks","keys_url":"https://api.github.com/repos/jxnblk/mdx-deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jxnblk/mdx-deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jxnblk/mdx-deck/teams","hooks_url":"https://api.github.com/repos/jxnblk/mdx-deck/hooks","issue_events_url":"https://api.github.com/repos/jxnblk/mdx-deck/issues/events{/number}","events_url":"https://api.github.com/repos/jxnblk/mdx-deck/events","assignees_url":"https://api.github.com/repos/jxnblk/mdx-deck/assignees{/user}","branches_url":"https://api.github.com/repos/jxnblk/mdx-deck/branches{/branch}","tags_url":"https://api.github.com/repos/jxnblk/mdx-deck/tags","blobs_url":"https://api.github.com/repos/jxnblk/mdx-deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jxnblk/mdx-deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jxnblk/mdx-deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/jxnblk/mdx-deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jxnblk/mdx-deck/statuses/{sha}","languages_url":"https://api.github.com/repos/jxnblk/mdx-deck/languages","stargazers_url":"https://api.github.com/repos/jxnblk/mdx-deck/stargazers","contributors_url":"https://api.github.com/repos/jxnblk/mdx-deck/contributors","subscribers_url":"https://api.github.com/repos/jxnblk/mdx-deck/subscribers","subscription_url":"https://api.github.com/repos/jxnblk/mdx-deck/subscription","commits_url":"https://api.github.com/repos/jxnblk/mdx-deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/jxnblk/mdx-deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/jxnblk/mdx-deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/jxnblk/mdx-deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/jxnblk/mdx-deck/contents/{+path}","compare_url":"https://api.github.com/repos/jxnblk/mdx-deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jxnblk/mdx-deck/merges","archive_url":"https://api.github.com/repos/jxnblk/mdx-deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jxnblk/mdx-deck/downloads","issues_url":"https://api.github.com/repos/jxnblk/mdx-deck/issues{/number}","pulls_url":"https://api.github.com/repos/jxnblk/mdx-deck/pulls{/number}","milestones_url":"https://api.github.com/repos/jxnblk/mdx-deck/milestones{/number}","notifications_url":"https://api.github.com/repos/jxnblk/mdx-deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jxnblk/mdx-deck/labels{/name}","releases_url":"https://api.github.com/repos/jxnblk/mdx-deck/releases{/id}","deployments_url":"https://api.github.com/repos/jxnblk/mdx-deck/deployments","created_at":"2018-07-28T22:36:10Z","updated_at":"2018-11-18T15:51:57Z","pushed_at":"2018-11-18T15:53:54Z","git_url":"git://github.com/jxnblk/mdx-deck.git","ssh_url":"git@github.com:jxnblk/mdx-deck.git","clone_url":"https://github.com/jxnblk/mdx-deck.git","svn_url":"https://github.com/jxnblk/mdx-deck","homepage":"https://jxnblk.com/mdx-deck","size":2278,"stargazers_count":5669,"watchers_count":5669,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":196,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":196,"open_issues":58,"watchers":5669,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jxnblk/mdx-deck/pulls/199"},"html":{"href":"https://github.com/jxnblk/mdx-deck/pull/199"},"issue":{"href":"https://api.github.com/repos/jxnblk/mdx-deck/issues/199"},"comments":{"href":"https://api.github.com/repos/jxnblk/mdx-deck/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/jxnblk/mdx-deck/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/jxnblk/mdx-deck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jxnblk/mdx-deck/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/jxnblk/mdx-deck/statuses/c7c735678dc45733c20ef6ee1f565557a72e0284"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jxnblk","id":3451712,"node_id":"MDQ6VXNlcjM0NTE3MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3451712?v=4","gravatar_id":"","url":"https://api.github.com/users/jxnblk","html_url":"https://github.com/jxnblk","followers_url":"https://api.github.com/users/jxnblk/followers","following_url":"https://api.github.com/users/jxnblk/following{/other_user}","gists_url":"https://api.github.com/users/jxnblk/gists{/gist_id}","starred_url":"https://api.github.com/users/jxnblk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jxnblk/subscriptions","organizations_url":"https://api.github.com/users/jxnblk/orgs","repos_url":"https://api.github.com/users/jxnblk/repos","events_url":"https://api.github.com/users/jxnblk/events{/privacy}","received_events_url":"https://api.github.com/users/jxnblk/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"jxnblk"}}