{"action":"closed","number":22710,"pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/22710","id":220315322,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMzE1MzIy","html_url":"https://github.com/godotengine/godot/pull/22710","diff_url":"https://github.com/godotengine/godot/pull/22710.diff","patch_url":"https://github.com/godotengine/godot/pull/22710.patch","issue_url":"https://api.github.com/repos/godotengine/godot/issues/22710","number":22710,"state":"closed","locked":false,"title":"Fix some OSX and iOS Clang warnings","user":{"login":"akien-mga","id":4701338,"node_id":"MDQ6VXNlcjQ3MDEzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"body":"Fixes the following XCode 9.4.1 warnings:\r\n```\r\ncore/os/memory.cpp:175:13: warning: unused variable 's' [-Wunused-variable]\r\ndrivers/coremidi/core_midi.cpp:68:14: warning: comparison between NULL and non-pointer ('MIDIEndpointRef' (aka 'unsigned int') and NULL) [-Wnull-arithmetic]\r\ndrivers/gles2/rasterizer_gles2.cpp:77:24: warning: unused function '_gl_debug_print' [-Wunused-function,34]\r\ndrivers/unix/thread_posix.cpp:106:12: warning: unused variable 'running_thread' [-Wunused-variable,34]\r\nmodules/gdnative/nativescript/nativescript.h:371:16: warning: in-class initialization of non-static data member is a C++11 extension [-Wc++11-extensions]\r\nplatform/iphone/gl_view.mm:56:14: warning: unused variable 'video_previous_volume' [-Wunused-variable,34]\r\nplatform/iphone/gl_view.mm:251:12: warning: unused function 'get_first_id' [-Wunused-function,34]\r\nplatform/osx/os_osx.mm:79:15: warning: unused function 'convertRectToBacking' [-Wunused-function]\r\n```\r\n\r\n*Edit:* Removed mention of `platform/iphone/main.m:45:15: warning: unused variable 'app' [-Wunused-variable,34]`, didn't fix it eventually.","created_at":"2018-10-04T09:53:34Z","updated_at":"2018-10-04T10:04:55Z","closed_at":"2018-10-04T10:04:55Z","merged_at":"2018-10-04T10:04:55Z","merge_commit_sha":"f92a29adfea7fb37a306da2202738ebfa1fb79b2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"karroffel","id":5209613,"node_id":"MDQ6VXNlcjUyMDk2MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/5209613?v=4","gravatar_id":"","url":"https://api.github.com/users/karroffel","html_url":"https://github.com/karroffel","followers_url":"https://api.github.com/users/karroffel/followers","following_url":"https://api.github.com/users/karroffel/following{/other_user}","gists_url":"https://api.github.com/users/karroffel/gists{/gist_id}","starred_url":"https://api.github.com/users/karroffel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karroffel/subscriptions","organizations_url":"https://api.github.com/users/karroffel/orgs","repos_url":"https://api.github.com/users/karroffel/repos","events_url":"https://api.github.com/users/karroffel/events{/privacy}","received_events_url":"https://api.github.com/users/karroffel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":73330064,"node_id":"MDU6TGFiZWw3MzMzMDA2NA==","url":"https://api.github.com/repos/godotengine/godot/labels/bug","name":"bug","color":"ff2222","default":true},{"id":73330066,"node_id":"MDU6TGFiZWw3MzMzMDA2Ng==","url":"https://api.github.com/repos/godotengine/godot/labels/enhancement","name":"enhancement","color":"44bbff","default":true},{"id":279097519,"node_id":"MDU6TGFiZWwyNzkwOTc1MTk=","url":"https://api.github.com/repos/godotengine/godot/labels/platform:ios","name":"platform:ios","color":"dddddd","default":false},{"id":279097780,"node_id":"MDU6TGFiZWwyNzkwOTc3ODA=","url":"https://api.github.com/repos/godotengine/godot/labels/platform:osx","name":"platform:osx","color":"dddddd","default":false},{"id":279097966,"node_id":"MDU6TGFiZWwyNzkwOTc5NjY=","url":"https://api.github.com/repos/godotengine/godot/labels/topic:core","name":"topic:core","color":"ffdd44","default":false}],"milestone":{"url":"https://api.github.com/repos/godotengine/godot/milestones/7","html_url":"https://github.com/godotengine/godot/milestone/7","labels_url":"https://api.github.com/repos/godotengine/godot/milestones/7/labels","id":2529217,"node_id":"MDk6TWlsZXN0b25lMjUyOTIxNw==","number":7,"title":"3.1","description":"","creator":{"login":"akien-mga","id":4701338,"node_id":"MDQ6VXNlcjQ3MDEzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"open_issues":922,"closed_issues":3774,"state":"open","created_at":"2017-05-18T13:33:56Z","updated_at":"2018-10-04T10:04:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/godotengine/godot/pulls/22710/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot/pulls/22710/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/22710/comments","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/97b9697ea2601f0fd92e3f326c6db29e0598638f","head":{"label":"akien-mga:fix-warnings","ref":"fix-warnings","sha":"97b9697ea2601f0fd92e3f326c6db29e0598638f","user":{"login":"akien-mga","id":4701338,"node_id":"MDQ6VXNlcjQ3MDEzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"repo":{"id":35956903,"node_id":"MDEwOlJlcG9zaXRvcnkzNTk1NjkwMw==","name":"godot","full_name":"akien-mga/godot","private":false,"owner":{"login":"akien-mga","id":4701338,"node_id":"MDQ6VXNlcjQ3MDEzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"html_url":"https://github.com/akien-mga/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":true,"url":"https://api.github.com/repos/akien-mga/godot","forks_url":"https://api.github.com/repos/akien-mga/godot/forks","keys_url":"https://api.github.com/repos/akien-mga/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akien-mga/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akien-mga/godot/teams","hooks_url":"https://api.github.com/repos/akien-mga/godot/hooks","issue_events_url":"https://api.github.com/repos/akien-mga/godot/issues/events{/number}","events_url":"https://api.github.com/repos/akien-mga/godot/events","assignees_url":"https://api.github.com/repos/akien-mga/godot/assignees{/user}","branches_url":"https://api.github.com/repos/akien-mga/godot/branches{/branch}","tags_url":"https://api.github.com/repos/akien-mga/godot/tags","blobs_url":"https://api.github.com/repos/akien-mga/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akien-mga/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akien-mga/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/akien-mga/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akien-mga/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/akien-mga/godot/languages","stargazers_url":"https://api.github.com/repos/akien-mga/godot/stargazers","contributors_url":"https://api.github.com/repos/akien-mga/godot/contributors","subscribers_url":"https://api.github.com/repos/akien-mga/godot/subscribers","subscription_url":"https://api.github.com/repos/akien-mga/godot/subscription","commits_url":"https://api.github.com/repos/akien-mga/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/akien-mga/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/akien-mga/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/akien-mga/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/akien-mga/godot/contents/{+path}","compare_url":"https://api.github.com/repos/akien-mga/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akien-mga/godot/merges","archive_url":"https://api.github.com/repos/akien-mga/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akien-mga/godot/downloads","issues_url":"https://api.github.com/repos/akien-mga/godot/issues{/number}","pulls_url":"https://api.github.com/repos/akien-mga/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/akien-mga/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/akien-mga/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akien-mga/godot/labels{/name}","releases_url":"https://api.github.com/repos/akien-mga/godot/releases{/id}","deployments_url":"https://api.github.com/repos/akien-mga/godot/deployments","created_at":"2015-05-20T15:31:24Z","updated_at":"2018-08-29T07:50:26Z","pushed_at":"2018-10-04T09:51:08Z","git_url":"git://github.com/akien-mga/godot.git","ssh_url":"git@github.com:akien-mga/godot.git","clone_url":"https://github.com/akien-mga/godot.git","svn_url":"https://github.com/akien-mga/godot","homepage":"https://godotengine.org/","size":264423,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"cfa373c69f6af64d9fce8f1773a4b795f361a34c","user":{"login":"godotengine","id":6318500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMTg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":15634981,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYzNDk4MQ==","name":"godot","full_name":"godotengine/godot","private":false,"owner":{"login":"godotengine","id":6318500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMTg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/godotengine/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":false,"url":"https://api.github.com/repos/godotengine/godot","forks_url":"https://api.github.com/repos/godotengine/godot/forks","keys_url":"https://api.github.com/repos/godotengine/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot/teams","hooks_url":"https://api.github.com/repos/godotengine/godot/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot/events","assignees_url":"https://api.github.com/repos/godotengine/godot/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot/tags","blobs_url":"https://api.github.com/repos/godotengine/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot/subscription","commits_url":"https://api.github.com/repos/godotengine/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot/merges","archive_url":"https://api.github.com/repos/godotengine/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot/downloads","issues_url":"https://api.github.com/repos/godotengine/godot/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot/deployments","created_at":"2014-01-04T16:05:36Z","updated_at":"2018-10-04T08:09:52Z","pushed_at":"2018-10-04T10:04:55Z","git_url":"git://github.com/godotengine/godot.git","ssh_url":"git@github.com:godotengine/godot.git","clone_url":"https://github.com/godotengine/godot.git","svn_url":"https://github.com/godotengine/godot","homepage":"https://godotengine.org","size":264783,"stargazers_count":16851,"watchers_count":16851,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3471,"mirror_url":null,"archived":false,"open_issues_count":3928,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3471,"open_issues":3928,"watchers":16851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/22710"},"html":{"href":"https://github.com/godotengine/godot/pull/22710"},"issue":{"href":"https://api.github.com/repos/godotengine/godot/issues/22710"},"comments":{"href":"https://api.github.com/repos/godotengine/godot/issues/22710/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot/pulls/22710/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot/pulls/22710/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot/statuses/97b9697ea2601f0fd92e3f326c6db29e0598638f"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"akien-mga","id":4701338,"node_id":"MDQ6VXNlcjQ3MDEzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":22,"changed_files":6}}
{"actor":{"display_login":"akien-mga"}}