{"action":"created","comment":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/comments/176344417","pull_request_review_id":106028199,"id":176344417,"diff_hunk":"@@ -123,7 +123,7 @@ function target()\n \t\t\tfi\n \t\tdone\n \n-\t\tpouch pull registry.hub.docker.com/library/busybox:latest >/dev/null\n+\t\t#pouch pull registry.hub.docker.com/library/busybox:latest >/dev/null","path":"hack/make.sh","position":5,"original_position":5,"commit_id":"80e681fac62f2ed1c06a0d4588cdb34985297504","original_commit_id":"80e681fac62f2ed1c06a0d4588cdb34985297504","user":{"login":"allencloud","id":9465626,"avatar_url":"https://avatars3.githubusercontent.com/u/9465626?v=4","gravatar_id":"","url":"https://api.github.com/users/allencloud","html_url":"https://github.com/allencloud","followers_url":"https://api.github.com/users/allencloud/followers","following_url":"https://api.github.com/users/allencloud/following{/other_user}","gists_url":"https://api.github.com/users/allencloud/gists{/gist_id}","starred_url":"https://api.github.com/users/allencloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allencloud/subscriptions","organizations_url":"https://api.github.com/users/allencloud/orgs","repos_url":"https://api.github.com/users/allencloud/repos","events_url":"https://api.github.com/users/allencloud/events{/privacy}","received_events_url":"https://api.github.com/users/allencloud/received_events","type":"User","site_admin":false},"body":"I wish that we can lock down one usable image and in every test suite, we use this image. \r\nSo we can remove `command.PouchRun(\"pull\", busyboxImage).Assert(c, icmd.Success)\r\n}` in every test suite. Only when we need another image, we pull that image.\r\n\r\nAlthough when pulling an existent image costs no time ideally, actually it will take pouch daemon about 2 or 3 second to process. If we remove that command `command.PouchRun(\"pull\", busyboxImage).Assert(c, icmd.Success)}`, I think we could reduce maybe several minutes to finish the CI. \r\n@Letty5411 @HusterWan ","created_at":"2018-03-22T08:57:16Z","updated_at":"2018-03-22T08:57:16Z","html_url":"https://github.com/alibaba/pouch/pull/943#discussion_r176344417","pull_request_url":"https://api.github.com/repos/alibaba/pouch/pulls/943","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/comments/176344417"},"html":{"href":"https://github.com/alibaba/pouch/pull/943#discussion_r176344417"},"pull_request":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/943"}}},"pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/943","id":176690501,"html_url":"https://github.com/alibaba/pouch/pull/943","diff_url":"https://github.com/alibaba/pouch/pull/943.diff","patch_url":"https://github.com/alibaba/pouch/pull/943.patch","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/943","number":943,"state":"open","locked":false,"title":"[WIP] test: use stable image tag","user":{"login":"Letty5411","id":14540559,"avatar_url":"https://avatars0.githubusercontent.com/u/14540559?v=4","gravatar_id":"","url":"https://api.github.com/users/Letty5411","html_url":"https://github.com/Letty5411","followers_url":"https://api.github.com/users/Letty5411/followers","following_url":"https://api.github.com/users/Letty5411/following{/other_user}","gists_url":"https://api.github.com/users/Letty5411/gists{/gist_id}","starred_url":"https://api.github.com/users/Letty5411/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Letty5411/subscriptions","organizations_url":"https://api.github.com/users/Letty5411/orgs","repos_url":"https://api.github.com/users/Letty5411/repos","events_url":"https://api.github.com/users/Letty5411/events{/privacy}","received_events_url":"https://api.github.com/users/Letty5411/received_events","type":"User","site_admin":false},"body":"Signed-off-by: letty <letty.ll@alibaba-inc.com>\r\n\r\n<!-- \r\nPlease make sure you have read and understood the contributing guidelines;\r\nhttps://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md -->\r\n\r\n### Ⅰ. Describe what this PR did\r\nUse stable image tag for CI test. And user could also change default test images by setting environment\r\nvariable.\r\n### Ⅱ. Does this pull request fix one issue?\r\n<!--If that, add \"fixes #xxxx\" below in the next line, for example, fixes #15. Otherwise, add \"NONE\" -->\r\n\r\n\r\n### Ⅲ. Describe how you did it\r\n\r\n\r\n### Ⅳ. Describe how to verify it\r\n\r\n\r\n### Ⅴ. Special notes for reviews\r\n\r\n\r\n","created_at":"2018-03-22T06:58:35Z","updated_at":"2018-03-22T08:57:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21ee4dde3f4cbc13cda4dead403ab24825bad41a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":722339975,"url":"https://api.github.com/repos/alibaba/pouch/labels/areas/test","name":"areas/test","color":"1d76db","default":false},{"id":722355122,"url":"https://api.github.com/repos/alibaba/pouch/labels/size/L","name":"size/L","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/alibaba/pouch/pulls/943/commits","review_comments_url":"https://api.github.com/repos/alibaba/pouch/pulls/943/comments","review_comment_url":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/943/comments","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/80e681fac62f2ed1c06a0d4588cdb34985297504","head":{"label":"Letty5411:0322","ref":"0322","sha":"80e681fac62f2ed1c06a0d4588cdb34985297504","user":{"login":"Letty5411","id":14540559,"avatar_url":"https://avatars0.githubusercontent.com/u/14540559?v=4","gravatar_id":"","url":"https://api.github.com/users/Letty5411","html_url":"https://github.com/Letty5411","followers_url":"https://api.github.com/users/Letty5411/followers","following_url":"https://api.github.com/users/Letty5411/following{/other_user}","gists_url":"https://api.github.com/users/Letty5411/gists{/gist_id}","starred_url":"https://api.github.com/users/Letty5411/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Letty5411/subscriptions","organizations_url":"https://api.github.com/users/Letty5411/orgs","repos_url":"https://api.github.com/users/Letty5411/repos","events_url":"https://api.github.com/users/Letty5411/events{/privacy}","received_events_url":"https://api.github.com/users/Letty5411/received_events","type":"User","site_admin":false},"repo":{"id":115474627,"name":"pouch","full_name":"Letty5411/pouch","owner":{"login":"Letty5411","id":14540559,"avatar_url":"https://avatars0.githubusercontent.com/u/14540559?v=4","gravatar_id":"","url":"https://api.github.com/users/Letty5411","html_url":"https://github.com/Letty5411","followers_url":"https://api.github.com/users/Letty5411/followers","following_url":"https://api.github.com/users/Letty5411/following{/other_user}","gists_url":"https://api.github.com/users/Letty5411/gists{/gist_id}","starred_url":"https://api.github.com/users/Letty5411/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Letty5411/subscriptions","organizations_url":"https://api.github.com/users/Letty5411/orgs","repos_url":"https://api.github.com/users/Letty5411/repos","events_url":"https://api.github.com/users/Letty5411/events{/privacy}","received_events_url":"https://api.github.com/users/Letty5411/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Letty5411/pouch","description":"Pouch is an open-source project created to promote the container technology movement.","fork":true,"url":"https://api.github.com/repos/Letty5411/pouch","forks_url":"https://api.github.com/repos/Letty5411/pouch/forks","keys_url":"https://api.github.com/repos/Letty5411/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Letty5411/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Letty5411/pouch/teams","hooks_url":"https://api.github.com/repos/Letty5411/pouch/hooks","issue_events_url":"https://api.github.com/repos/Letty5411/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/Letty5411/pouch/events","assignees_url":"https://api.github.com/repos/Letty5411/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/Letty5411/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/Letty5411/pouch/tags","blobs_url":"https://api.github.com/repos/Letty5411/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Letty5411/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Letty5411/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Letty5411/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Letty5411/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/Letty5411/pouch/languages","stargazers_url":"https://api.github.com/repos/Letty5411/pouch/stargazers","contributors_url":"https://api.github.com/repos/Letty5411/pouch/contributors","subscribers_url":"https://api.github.com/repos/Letty5411/pouch/subscribers","subscription_url":"https://api.github.com/repos/Letty5411/pouch/subscription","commits_url":"https://api.github.com/repos/Letty5411/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Letty5411/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Letty5411/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Letty5411/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Letty5411/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/Letty5411/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Letty5411/pouch/merges","archive_url":"https://api.github.com/repos/Letty5411/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Letty5411/pouch/downloads","issues_url":"https://api.github.com/repos/Letty5411/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/Letty5411/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/Letty5411/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/Letty5411/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Letty5411/pouch/labels{/name}","releases_url":"https://api.github.com/repos/Letty5411/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/Letty5411/pouch/deployments","created_at":"2017-12-27T02:54:54Z","updated_at":"2018-03-22T02:55:58Z","pushed_at":"2018-03-22T08:18:22Z","git_url":"git://github.com/Letty5411/pouch.git","ssh_url":"git@github.com:Letty5411/pouch.git","clone_url":"https://github.com/Letty5411/pouch.git","svn_url":"https://github.com/Letty5411/pouch","homepage":"","size":7817,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"alibaba:master","ref":"master","sha":"6cf0ce563b6d5f9130d8be5c4d14e81512b74708","user":{"login":"alibaba","id":1961952,"avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"repo":{"id":102555965,"name":"pouch","full_name":"alibaba/pouch","owner":{"login":"alibaba","id":1961952,"avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alibaba/pouch","description":"Pouch is an open-source project created to promote the container technology movement.","fork":false,"url":"https://api.github.com/repos/alibaba/pouch","forks_url":"https://api.github.com/repos/alibaba/pouch/forks","keys_url":"https://api.github.com/repos/alibaba/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alibaba/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alibaba/pouch/teams","hooks_url":"https://api.github.com/repos/alibaba/pouch/hooks","issue_events_url":"https://api.github.com/repos/alibaba/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/alibaba/pouch/events","assignees_url":"https://api.github.com/repos/alibaba/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/alibaba/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/alibaba/pouch/tags","blobs_url":"https://api.github.com/repos/alibaba/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alibaba/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alibaba/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/alibaba/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/alibaba/pouch/languages","stargazers_url":"https://api.github.com/repos/alibaba/pouch/stargazers","contributors_url":"https://api.github.com/repos/alibaba/pouch/contributors","subscribers_url":"https://api.github.com/repos/alibaba/pouch/subscribers","subscription_url":"https://api.github.com/repos/alibaba/pouch/subscription","commits_url":"https://api.github.com/repos/alibaba/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/alibaba/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/alibaba/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/alibaba/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/alibaba/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/alibaba/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alibaba/pouch/merges","archive_url":"https://api.github.com/repos/alibaba/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alibaba/pouch/downloads","issues_url":"https://api.github.com/repos/alibaba/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/alibaba/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/alibaba/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/alibaba/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alibaba/pouch/labels{/name}","releases_url":"https://api.github.com/repos/alibaba/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/alibaba/pouch/deployments","created_at":"2017-09-06T03:01:51Z","updated_at":"2018-03-22T08:52:50Z","pushed_at":"2018-03-22T08:56:09Z","git_url":"git://github.com/alibaba/pouch.git","ssh_url":"git@github.com:alibaba/pouch.git","clone_url":"https://github.com/alibaba/pouch.git","svn_url":"https://github.com/alibaba/pouch","homepage":"","size":7793,"stargazers_count":2273,"watchers_count":2273,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":405,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":405,"open_issues":96,"watchers":2273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/943"},"html":{"href":"https://github.com/alibaba/pouch/pull/943"},"issue":{"href":"https://api.github.com/repos/alibaba/pouch/issues/943"},"comments":{"href":"https://api.github.com/repos/alibaba/pouch/issues/943/comments"},"review_comments":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/943/comments"},"review_comment":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/943/commits"},"statuses":{"href":"https://api.github.com/repos/alibaba/pouch/statuses/80e681fac62f2ed1c06a0d4588cdb34985297504"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"allencloud"}}