{"action":"created","comment":{"url":"https://api.github.com/repos/dojo/widgets/pulls/comments/202053635","pull_request_review_id":136673890,"id":202053635,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjA1MzYzNQ==","diff_hunk":"@@ -48,14 +48,14 @@ import { customElement } from '@dojo/widget-core/decorators/customElement';\n export interface ComboBoxProperties extends ThemedProperties, LabeledProperties {\n \tclearable?: boolean;\n \tdisabled?: boolean;\n-\tgetResultLabel?(result: any): string;\n+\tgetResultLabel?(result: any): DNode;\n \tgetResultSelected?(result: any): boolean;\n \twidgetId?: string;\n \tinputProperties?: TextInputProperties;\n \tinvalid?: boolean;\n \tisResultDisabled?(result: any): boolean;\n \tonBlur?(value: string, key?: string | number): void;\n-\tonChange?(value: string, key?: string | number): void;\n+\tonChange?(value: DNode, key?: string | number): void;","path":"src/combobox/index.ts","position":13,"original_position":13,"commit_id":"761edd0c7b10d8a293cea6bb429b4caa4610e515","original_commit_id":"761edd0c7b10d8a293cea6bb429b4caa4610e515","user":{"login":"smhigley","id":3819570,"node_id":"MDQ6VXNlcjM4MTk1NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3819570?v=4","gravatar_id":"","url":"https://api.github.com/users/smhigley","html_url":"https://github.com/smhigley","followers_url":"https://api.github.com/users/smhigley/followers","following_url":"https://api.github.com/users/smhigley/following{/other_user}","gists_url":"https://api.github.com/users/smhigley/gists{/gist_id}","starred_url":"https://api.github.com/users/smhigley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smhigley/subscriptions","organizations_url":"https://api.github.com/users/smhigley/orgs","repos_url":"https://api.github.com/users/smhigley/repos","events_url":"https://api.github.com/users/smhigley/events{/privacy}","received_events_url":"https://api.github.com/users/smhigley/received_events","type":"User","site_admin":false},"body":"The other, possibly easier, option is to add `getResultValue` and return that in `onChange`. That might be better anyway, since `onChange` now is used for both typing in the `TextInput` and selecting a result.","created_at":"2018-07-12T14:23:04Z","updated_at":"2018-07-12T14:23:04Z","html_url":"https://github.com/dojo/widgets/pull/563#discussion_r202053635","pull_request_url":"https://api.github.com/repos/dojo/widgets/pulls/563","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dojo/widgets/pulls/comments/202053635"},"html":{"href":"https://github.com/dojo/widgets/pull/563#discussion_r202053635"},"pull_request":{"href":"https://api.github.com/repos/dojo/widgets/pulls/563"}},"in_reply_to_id":202048684},"pull_request":{"url":"https://api.github.com/repos/dojo/widgets/pulls/563","id":201013571,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDEzNTcx","html_url":"https://github.com/dojo/widgets/pull/563","diff_url":"https://github.com/dojo/widgets/pull/563.diff","patch_url":"https://github.com/dojo/widgets/pull/563.patch","issue_url":"https://api.github.com/repos/dojo/widgets/issues/563","number":563,"state":"open","locked":false,"title":"Change comobobox getResultLabel type to match select and listbox","user":{"login":"smhigley","id":3819570,"node_id":"MDQ6VXNlcjM4MTk1NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3819570?v=4","gravatar_id":"","url":"https://api.github.com/users/smhigley","html_url":"https://github.com/smhigley","followers_url":"https://api.github.com/users/smhigley/followers","following_url":"https://api.github.com/users/smhigley/following{/other_user}","gists_url":"https://api.github.com/users/smhigley/gists{/gist_id}","starred_url":"https://api.github.com/users/smhigley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smhigley/subscriptions","organizations_url":"https://api.github.com/users/smhigley/orgs","repos_url":"https://api.github.com/users/smhigley/repos","events_url":"https://api.github.com/users/smhigley/events{/privacy}","received_events_url":"https://api.github.com/users/smhigley/received_events","type":"User","site_admin":false},"body":"**Type:** feature\r\n\r\nThe following has been addressed in the PR:\r\n\r\n* [ ] There is a related issue\r\n* [x] All code matches the [style guide](https://github.com/dojo/meta/blob/master/STYLE.md)\r\n* [ ] Unit or Functional tests are included in the PR\r\n\r\n<!--\r\nOur bots should ensure:\r\n\r\n* [ ] All contributors have signed a CLA\r\n* [ ] The PR passes CI testing\r\n* [ ] Code coverage is maintained\r\n* [ ] The PR has been reviewed and approved\r\n-->\r\n\r\n**Description:**\r\n\r\nBoth `Select` and `Listbox` allow a `DNode` return type for `getOptionLabel`. It makes sense to update `ComboBox` to allow the same.\r\n","created_at":"2018-07-12T14:07:06Z","updated_at":"2018-07-12T14:23:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc16cb7a559dd34092bc901a0ff2c4a4c70fb313","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dojo/widgets/pulls/563/commits","review_comments_url":"https://api.github.com/repos/dojo/widgets/pulls/563/comments","review_comment_url":"https://api.github.com/repos/dojo/widgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/widgets/issues/563/comments","statuses_url":"https://api.github.com/repos/dojo/widgets/statuses/761edd0c7b10d8a293cea6bb429b4caa4610e515","head":{"label":"smhigley:combobox-option-type","ref":"combobox-option-type","sha":"761edd0c7b10d8a293cea6bb429b4caa4610e515","user":{"login":"smhigley","id":3819570,"node_id":"MDQ6VXNlcjM4MTk1NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3819570?v=4","gravatar_id":"","url":"https://api.github.com/users/smhigley","html_url":"https://github.com/smhigley","followers_url":"https://api.github.com/users/smhigley/followers","following_url":"https://api.github.com/users/smhigley/following{/other_user}","gists_url":"https://api.github.com/users/smhigley/gists{/gist_id}","starred_url":"https://api.github.com/users/smhigley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smhigley/subscriptions","organizations_url":"https://api.github.com/users/smhigley/orgs","repos_url":"https://api.github.com/users/smhigley/repos","events_url":"https://api.github.com/users/smhigley/events{/privacy}","received_events_url":"https://api.github.com/users/smhigley/received_events","type":"User","site_admin":false},"repo":{"id":80783166,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc4MzE2Ng==","name":"widgets","full_name":"smhigley/widgets","owner":{"login":"smhigley","id":3819570,"node_id":"MDQ6VXNlcjM4MTk1NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3819570?v=4","gravatar_id":"","url":"https://api.github.com/users/smhigley","html_url":"https://github.com/smhigley","followers_url":"https://api.github.com/users/smhigley/followers","following_url":"https://api.github.com/users/smhigley/following{/other_user}","gists_url":"https://api.github.com/users/smhigley/gists{/gist_id}","starred_url":"https://api.github.com/users/smhigley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smhigley/subscriptions","organizations_url":"https://api.github.com/users/smhigley/orgs","repos_url":"https://api.github.com/users/smhigley/repos","events_url":"https://api.github.com/users/smhigley/events{/privacy}","received_events_url":"https://api.github.com/users/smhigley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smhigley/widgets","description":":rocket: UI components for dojo2.","fork":true,"url":"https://api.github.com/repos/smhigley/widgets","forks_url":"https://api.github.com/repos/smhigley/widgets/forks","keys_url":"https://api.github.com/repos/smhigley/widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smhigley/widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smhigley/widgets/teams","hooks_url":"https://api.github.com/repos/smhigley/widgets/hooks","issue_events_url":"https://api.github.com/repos/smhigley/widgets/issues/events{/number}","events_url":"https://api.github.com/repos/smhigley/widgets/events","assignees_url":"https://api.github.com/repos/smhigley/widgets/assignees{/user}","branches_url":"https://api.github.com/repos/smhigley/widgets/branches{/branch}","tags_url":"https://api.github.com/repos/smhigley/widgets/tags","blobs_url":"https://api.github.com/repos/smhigley/widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smhigley/widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smhigley/widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/smhigley/widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smhigley/widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/smhigley/widgets/languages","stargazers_url":"https://api.github.com/repos/smhigley/widgets/stargazers","contributors_url":"https://api.github.com/repos/smhigley/widgets/contributors","subscribers_url":"https://api.github.com/repos/smhigley/widgets/subscribers","subscription_url":"https://api.github.com/repos/smhigley/widgets/subscription","commits_url":"https://api.github.com/repos/smhigley/widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/smhigley/widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/smhigley/widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/smhigley/widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/smhigley/widgets/contents/{+path}","compare_url":"https://api.github.com/repos/smhigley/widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smhigley/widgets/merges","archive_url":"https://api.github.com/repos/smhigley/widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smhigley/widgets/downloads","issues_url":"https://api.github.com/repos/smhigley/widgets/issues{/number}","pulls_url":"https://api.github.com/repos/smhigley/widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/smhigley/widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/smhigley/widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smhigley/widgets/labels{/name}","releases_url":"https://api.github.com/repos/smhigley/widgets/releases{/id}","deployments_url":"https://api.github.com/repos/smhigley/widgets/deployments","created_at":"2017-02-03T00:33:10Z","updated_at":"2017-02-03T00:33:11Z","pushed_at":"2018-07-12T14:05:12Z","git_url":"git://github.com/smhigley/widgets.git","ssh_url":"git@github.com:smhigley/widgets.git","clone_url":"https://github.com/smhigley/widgets.git","svn_url":"https://github.com/smhigley/widgets","homepage":"","size":2416,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"2ecc8174401c0914d7fb01d7a021d6c8c84f803f","user":{"login":"dojo","id":86896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":79911519,"node_id":"MDEwOlJlcG9zaXRvcnk3OTkxMTUxOQ==","name":"widgets","full_name":"dojo/widgets","owner":{"login":"dojo","id":86896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/widgets","description":":rocket: Dojo 2 - UI components.","fork":false,"url":"https://api.github.com/repos/dojo/widgets","forks_url":"https://api.github.com/repos/dojo/widgets/forks","keys_url":"https://api.github.com/repos/dojo/widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/widgets/teams","hooks_url":"https://api.github.com/repos/dojo/widgets/hooks","issue_events_url":"https://api.github.com/repos/dojo/widgets/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/widgets/events","assignees_url":"https://api.github.com/repos/dojo/widgets/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/widgets/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/widgets/tags","blobs_url":"https://api.github.com/repos/dojo/widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/widgets/languages","stargazers_url":"https://api.github.com/repos/dojo/widgets/stargazers","contributors_url":"https://api.github.com/repos/dojo/widgets/contributors","subscribers_url":"https://api.github.com/repos/dojo/widgets/subscribers","subscription_url":"https://api.github.com/repos/dojo/widgets/subscription","commits_url":"https://api.github.com/repos/dojo/widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/widgets/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/widgets/merges","archive_url":"https://api.github.com/repos/dojo/widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/widgets/downloads","issues_url":"https://api.github.com/repos/dojo/widgets/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/widgets/labels{/name}","releases_url":"https://api.github.com/repos/dojo/widgets/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/widgets/deployments","created_at":"2017-01-24T12:55:57Z","updated_at":"2018-07-10T22:34:36Z","pushed_at":"2018-07-12T14:07:07Z","git_url":"git://github.com/dojo/widgets.git","ssh_url":"git@github.com:dojo/widgets.git","clone_url":"https://github.com/dojo/widgets.git","svn_url":"https://github.com/dojo/widgets","homepage":"http://dojo.io","size":2651,"stargazers_count":31,"watchers_count":31,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":27,"open_issues":35,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/widgets/pulls/563"},"html":{"href":"https://github.com/dojo/widgets/pull/563"},"issue":{"href":"https://api.github.com/repos/dojo/widgets/issues/563"},"comments":{"href":"https://api.github.com/repos/dojo/widgets/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/widgets/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/widgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/widgets/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/widgets/statuses/761edd0c7b10d8a293cea6bb429b4caa4610e515"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"smhigley"}}