{"action":"created","comment":{"url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls/comments/209978027","pull_request_review_id":146093238,"id":209978027,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTk3ODAyNw==","diff_hunk":"@@ -128,7 +128,9 @@ public void run() {\n                 if (values.size() == 1) {\n                     Number value = values.get(\"value\");\n                     TaggedMeasure taggedMeasure = new TaggedMeasure(new GaugeMeasure(metricName, value.doubleValue()));\n-                    taggedMeasure.addTag(new Tag(\"source\", source));\n+                    for (Tag tag : this.tags) {\n+                        taggedMeasure.addTag(tag);\n+                    }","path":"src/main/java/com/appoptics/integrations/kafka/broker/Reporter.java","position":53,"original_position":53,"commit_id":"98fece4947ae0cc77bddff4a721c6c5d894d5f58","original_commit_id":"98fece4947ae0cc77bddff4a721c6c5d894d5f58","user":{"login":"masih","id":301855,"node_id":"MDQ6VXNlcjMwMTg1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/301855?v=4","gravatar_id":"","url":"https://api.github.com/users/masih","html_url":"https://github.com/masih","followers_url":"https://api.github.com/users/masih/followers","following_url":"https://api.github.com/users/masih/following{/other_user}","gists_url":"https://api.github.com/users/masih/gists{/gist_id}","starred_url":"https://api.github.com/users/masih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masih/subscriptions","organizations_url":"https://api.github.com/users/masih/orgs","repos_url":"https://api.github.com/users/masih/repos","events_url":"https://api.github.com/users/masih/events{/privacy}","received_events_url":"https://api.github.com/users/masih/received_events","type":"User","site_admin":false},"body":"since this is repeated twice, maybe it should be refactored into a method that takes a `TaggedMeasure` and a collection of `Tag`s and adds them all. e.g. `void addAllTags(TaggedMeasure taggedMeasure, Collection<? extends Tag> tags) { ...}`","created_at":"2018-08-14T14:40:23Z","updated_at":"2018-08-14T14:42:02Z","html_url":"https://github.com/appoptics/kafka-appoptics-reporter/pull/2#discussion_r209978027","pull_request_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls/comments/209978027"},"html":{"href":"https://github.com/appoptics/kafka-appoptics-reporter/pull/2#discussion_r209978027"},"pull_request":{"href":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls/2","id":207924861,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3OTI0ODYx","html_url":"https://github.com/appoptics/kafka-appoptics-reporter/pull/2","diff_url":"https://github.com/appoptics/kafka-appoptics-reporter/pull/2.diff","patch_url":"https://github.com/appoptics/kafka-appoptics-reporter/pull/2.patch","issue_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/issues/2","number":2,"state":"open","locked":false,"title":"Custom Tags support, refactor Reporter Builder","user":{"login":"Beaujr","id":7605195,"node_id":"MDQ6VXNlcjc2MDUxOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/7605195?v=4","gravatar_id":"","url":"https://api.github.com/users/Beaujr","html_url":"https://github.com/Beaujr","followers_url":"https://api.github.com/users/Beaujr/followers","following_url":"https://api.github.com/users/Beaujr/following{/other_user}","gists_url":"https://api.github.com/users/Beaujr/gists{/gist_id}","starred_url":"https://api.github.com/users/Beaujr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beaujr/subscriptions","organizations_url":"https://api.github.com/users/Beaujr/orgs","repos_url":"https://api.github.com/users/Beaujr/repos","events_url":"https://api.github.com/users/Beaujr/events{/privacy}","received_events_url":"https://api.github.com/users/Beaujr/received_events","type":"User","site_admin":false},"body":"Refactor the Reporter to Accept a list of Tag objects\r\nMove the creation of the Source tag to the KafkaAppopticsReporter\r\nMake Source Tag optional","created_at":"2018-08-13T09:53:40Z","updated_at":"2018-08-14T14:42:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b90a1aebda73173aa1c478d8e8e378255c0b696b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls/2/commits","review_comments_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls/2/comments","review_comment_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/issues/2/comments","statuses_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/statuses/98fece4947ae0cc77bddff4a721c6c5d894d5f58","head":{"label":"Beaujr:feature/custom_tags","ref":"feature/custom_tags","sha":"98fece4947ae0cc77bddff4a721c6c5d894d5f58","user":{"login":"Beaujr","id":7605195,"node_id":"MDQ6VXNlcjc2MDUxOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/7605195?v=4","gravatar_id":"","url":"https://api.github.com/users/Beaujr","html_url":"https://github.com/Beaujr","followers_url":"https://api.github.com/users/Beaujr/followers","following_url":"https://api.github.com/users/Beaujr/following{/other_user}","gists_url":"https://api.github.com/users/Beaujr/gists{/gist_id}","starred_url":"https://api.github.com/users/Beaujr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beaujr/subscriptions","organizations_url":"https://api.github.com/users/Beaujr/orgs","repos_url":"https://api.github.com/users/Beaujr/repos","events_url":"https://api.github.com/users/Beaujr/events{/privacy}","received_events_url":"https://api.github.com/users/Beaujr/received_events","type":"User","site_admin":false},"repo":{"id":144560255,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1NjAyNTU=","name":"kafka-appoptics-reporter","full_name":"Beaujr/kafka-appoptics-reporter","owner":{"login":"Beaujr","id":7605195,"node_id":"MDQ6VXNlcjc2MDUxOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/7605195?v=4","gravatar_id":"","url":"https://api.github.com/users/Beaujr","html_url":"https://github.com/Beaujr","followers_url":"https://api.github.com/users/Beaujr/followers","following_url":"https://api.github.com/users/Beaujr/following{/other_user}","gists_url":"https://api.github.com/users/Beaujr/gists{/gist_id}","starred_url":"https://api.github.com/users/Beaujr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beaujr/subscriptions","organizations_url":"https://api.github.com/users/Beaujr/orgs","repos_url":"https://api.github.com/users/Beaujr/repos","events_url":"https://api.github.com/users/Beaujr/events{/privacy}","received_events_url":"https://api.github.com/users/Beaujr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Beaujr/kafka-appoptics-reporter","description":"AppOptics Reporter for Kafka Broker Metrics","fork":true,"url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter","forks_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/forks","keys_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/teams","hooks_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/hooks","issue_events_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/issues/events{/number}","events_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/events","assignees_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/assignees{/user}","branches_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/branches{/branch}","tags_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/tags","blobs_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/statuses/{sha}","languages_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/languages","stargazers_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/stargazers","contributors_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/contributors","subscribers_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/subscribers","subscription_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/subscription","commits_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/contents/{+path}","compare_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/merges","archive_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/downloads","issues_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/issues{/number}","pulls_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/pulls{/number}","milestones_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/milestones{/number}","notifications_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/labels{/name}","releases_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/releases{/id}","deployments_url":"https://api.github.com/repos/Beaujr/kafka-appoptics-reporter/deployments","created_at":"2018-08-13T09:49:28Z","updated_at":"2018-08-13T09:49:30Z","pushed_at":"2018-08-13T15:12:24Z","git_url":"git://github.com/Beaujr/kafka-appoptics-reporter.git","ssh_url":"git@github.com:Beaujr/kafka-appoptics-reporter.git","clone_url":"https://github.com/Beaujr/kafka-appoptics-reporter.git","svn_url":"https://github.com/Beaujr/kafka-appoptics-reporter","homepage":null,"size":885,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appoptics:master","ref":"master","sha":"b061b9dcd8f38070b75d39a1363bf6c155f58db4","user":{"login":"appoptics","id":31021562,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMDIxNTYy","avatar_url":"https://avatars2.githubusercontent.com/u/31021562?v=4","gravatar_id":"","url":"https://api.github.com/users/appoptics","html_url":"https://github.com/appoptics","followers_url":"https://api.github.com/users/appoptics/followers","following_url":"https://api.github.com/users/appoptics/following{/other_user}","gists_url":"https://api.github.com/users/appoptics/gists{/gist_id}","starred_url":"https://api.github.com/users/appoptics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appoptics/subscriptions","organizations_url":"https://api.github.com/users/appoptics/orgs","repos_url":"https://api.github.com/users/appoptics/repos","events_url":"https://api.github.com/users/appoptics/events{/privacy}","received_events_url":"https://api.github.com/users/appoptics/received_events","type":"Organization","site_admin":false},"repo":{"id":119089059,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkwODkwNTk=","name":"kafka-appoptics-reporter","full_name":"appoptics/kafka-appoptics-reporter","owner":{"login":"appoptics","id":31021562,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMDIxNTYy","avatar_url":"https://avatars2.githubusercontent.com/u/31021562?v=4","gravatar_id":"","url":"https://api.github.com/users/appoptics","html_url":"https://github.com/appoptics","followers_url":"https://api.github.com/users/appoptics/followers","following_url":"https://api.github.com/users/appoptics/following{/other_user}","gists_url":"https://api.github.com/users/appoptics/gists{/gist_id}","starred_url":"https://api.github.com/users/appoptics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appoptics/subscriptions","organizations_url":"https://api.github.com/users/appoptics/orgs","repos_url":"https://api.github.com/users/appoptics/repos","events_url":"https://api.github.com/users/appoptics/events{/privacy}","received_events_url":"https://api.github.com/users/appoptics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appoptics/kafka-appoptics-reporter","description":"AppOptics Reporter for Kafka Broker Metrics","fork":false,"url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter","forks_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/forks","keys_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/teams","hooks_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/hooks","issue_events_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/issues/events{/number}","events_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/events","assignees_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/assignees{/user}","branches_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/branches{/branch}","tags_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/tags","blobs_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/statuses/{sha}","languages_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/languages","stargazers_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/stargazers","contributors_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/contributors","subscribers_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/subscribers","subscription_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/subscription","commits_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/contents/{+path}","compare_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/merges","archive_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/downloads","issues_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/issues{/number}","pulls_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls{/number}","milestones_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/milestones{/number}","notifications_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/labels{/name}","releases_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/releases{/id}","deployments_url":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/deployments","created_at":"2018-01-26T18:39:00Z","updated_at":"2018-05-31T11:33:39Z","pushed_at":"2018-08-13T15:12:25Z","git_url":"git://github.com/appoptics/kafka-appoptics-reporter.git","ssh_url":"git@github.com:appoptics/kafka-appoptics-reporter.git","clone_url":"https://github.com/appoptics/kafka-appoptics-reporter.git","svn_url":"https://github.com/appoptics/kafka-appoptics-reporter","homepage":null,"size":883,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls/2"},"html":{"href":"https://github.com/appoptics/kafka-appoptics-reporter/pull/2"},"issue":{"href":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/issues/2"},"comments":{"href":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/appoptics/kafka-appoptics-reporter/statuses/98fece4947ae0cc77bddff4a721c6c5d894d5f58"}},"author_association":"NONE"}}
{"actor":{"display_login":"masih"}}