{"action":"created","issue":{"url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10688","repository_url":"https://api.github.com/repos/cockpit-project/cockpit","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10688/labels{/name}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10688/comments","events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10688/events","html_url":"https://github.com/cockpit-project/cockpit/pull/10688","id":384857963,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTYwNjM2","number":10688,"title":"machines: Remove target disk element from ui","user":{"login":"KKoukiou","id":14921356,"node_id":"MDQ6VXNlcjE0OTIxMzU2","avatar_url":"https://avatars1.githubusercontent.com/u/14921356?v=4","gravatar_id":"","url":"https://api.github.com/users/KKoukiou","html_url":"https://github.com/KKoukiou","followers_url":"https://api.github.com/users/KKoukiou/followers","following_url":"https://api.github.com/users/KKoukiou/following{/other_user}","gists_url":"https://api.github.com/users/KKoukiou/gists{/gist_id}","starred_url":"https://api.github.com/users/KKoukiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KKoukiou/subscriptions","organizations_url":"https://api.github.com/users/KKoukiou/orgs","repos_url":"https://api.github.com/users/KKoukiou/repos","events_url":"https://api.github.com/users/KKoukiou/events{/privacy}","received_events_url":"https://api.github.com/users/KKoukiou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-27T15:44:57Z","updated_at":"2018-11-28T07:15:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10688","html_url":"https://github.com/cockpit-project/cockpit/pull/10688","diff_url":"https://github.com/cockpit-project/cockpit/pull/10688.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/10688.patch"},"body":"So, in this PR I am removing the target element from disks from the disk creation modal dialog and also from the disks listing.\r\nThe reason is that the <target> element for disks in libvirt, is not meant to show the mapping of the disk to the guest filesystem, aka the /dev/vda inside the guest if we choose virtio disk target vda. It's just a libvirt way to sort disks and it's not guaranteed that guest mapping will be there same as libvirt target. ( And in most cases it will not)\r\n\r\nAlso I did some cleanup in the css of the disk creation dialog. "},"comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments/442344152","html_url":"https://github.com/cockpit-project/cockpit/pull/10688#issuecomment-442344152","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10688","id":442344152,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjM0NDE1Mg==","user":{"login":"martinpitt","id":200109,"node_id":"MDQ6VXNlcjIwMDEwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/200109?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T07:15:11Z","updated_at":"2018-11-28T07:15:11Z","author_association":"MEMBER","body":"Looks good to me, aside from the checkbox placement issue that @andreasn pointed out. Thanks!"}}
{"actor":{"display_login":"martinpitt"}}