{"action":"closed","number":742,"pull_request":{"url":"https://api.github.com/repos/Adslot/adslot-ui/pulls/742","id":210627994,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjI3OTk0","html_url":"https://github.com/Adslot/adslot-ui/pull/742","diff_url":"https://github.com/Adslot/adslot-ui/pull/742.diff","patch_url":"https://github.com/Adslot/adslot-ui/pull/742.patch","issue_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/742","number":742,"state":"closed","locked":false,"title":"Fix: remove checkbox and radio gDSFP","user":{"login":"xiaofan2406","id":2403390,"node_id":"MDQ6VXNlcjI0MDMzOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2403390?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaofan2406","html_url":"https://github.com/xiaofan2406","followers_url":"https://api.github.com/users/xiaofan2406/followers","following_url":"https://api.github.com/users/xiaofan2406/following{/other_user}","gists_url":"https://api.github.com/users/xiaofan2406/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaofan2406/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaofan2406/subscriptions","organizations_url":"https://api.github.com/users/xiaofan2406/orgs","repos_url":"https://api.github.com/users/xiaofan2406/repos","events_url":"https://api.github.com/users/xiaofan2406/events{/privacy}","received_events_url":"https://api.github.com/users/xiaofan2406/received_events","type":"User","site_admin":false},"body":"\r\n\r\n\r\n## Description\r\n\r\n- Remove the checkbox, radios gDSFP\r\n- Checkbox and Radio now are always controlled, except when they are used with their group components.\r\n\r\nMigration:\r\n\r\nbefore:\r\n```\r\nRadioGroup.onChange(event)\r\nCheckboxGroup.onChange(value, event, name)\r\n```\r\n\r\nafter:\r\n```\r\nRadioGroup.onChange(value)\r\nCheckboxGroup.onChange(checkedValues, name)\r\n```\r\n\r\n## Motivation and Background Context\r\n\r\nBecause of React 16.4.2 was breaking change for gDSFP\r\n\r\n## Does this PR introduce a breaking change?\r\n<!--- If this PR contains a breaking change, please describe the impact and migration path for existing applications. -->\r\n\r\n- [X] Yes\r\n- [ ] No\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Check-list:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the [Contributing](CONTRIBUTING.md) document.\r\n- [ ] I've thought about and labelled my PR/commit message appropriately.\r\n- [x] If this PR introduces breaking changes I've described the impact and migration path for existing applications.\r\n- [x] CI is green (coverage, linting, tests).\r\n- [x] I have updated the documentation accordingly.\r\n- [ ] I've two LGTMs/Approvals.\r\n- [ ] I've fixed or replied to all my code-review comments.\r\n- [ ] I've manually tested with a buddy.\r\n- [x] I've squashed my commits into one.\r\n","created_at":"2018-08-24T03:09:55Z","updated_at":"2018-08-24T04:41:41Z","closed_at":"2018-08-24T04:41:40Z","merged_at":"2018-08-24T04:41:40Z","merge_commit_sha":"43c07c8b5f7cf3cefd8b6a349674f943b22b2ffd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Adslot/adslot-ui/pulls/742/commits","review_comments_url":"https://api.github.com/repos/Adslot/adslot-ui/pulls/742/comments","review_comment_url":"https://api.github.com/repos/Adslot/adslot-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/742/comments","statuses_url":"https://api.github.com/repos/Adslot/adslot-ui/statuses/bc343b0d950d08f80a8b627bfb44c0688dca8b24","head":{"label":"Adslot:fix-checkbox","ref":"fix-checkbox","sha":"bc343b0d950d08f80a8b627bfb44c0688dca8b24","user":{"login":"Adslot","id":767098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NzA5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/767098?v=4","gravatar_id":"","url":"https://api.github.com/users/Adslot","html_url":"https://github.com/Adslot","followers_url":"https://api.github.com/users/Adslot/followers","following_url":"https://api.github.com/users/Adslot/following{/other_user}","gists_url":"https://api.github.com/users/Adslot/gists{/gist_id}","starred_url":"https://api.github.com/users/Adslot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adslot/subscriptions","organizations_url":"https://api.github.com/users/Adslot/orgs","repos_url":"https://api.github.com/users/Adslot/repos","events_url":"https://api.github.com/users/Adslot/events{/privacy}","received_events_url":"https://api.github.com/users/Adslot/received_events","type":"Organization","site_admin":false},"repo":{"id":45156258,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE1NjI1OA==","name":"adslot-ui","full_name":"Adslot/adslot-ui","owner":{"login":"Adslot","id":767098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NzA5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/767098?v=4","gravatar_id":"","url":"https://api.github.com/users/Adslot","html_url":"https://github.com/Adslot","followers_url":"https://api.github.com/users/Adslot/followers","following_url":"https://api.github.com/users/Adslot/following{/other_user}","gists_url":"https://api.github.com/users/Adslot/gists{/gist_id}","starred_url":"https://api.github.com/users/Adslot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adslot/subscriptions","organizations_url":"https://api.github.com/users/Adslot/orgs","repos_url":"https://api.github.com/users/Adslot/repos","events_url":"https://api.github.com/users/Adslot/events{/privacy}","received_events_url":"https://api.github.com/users/Adslot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Adslot/adslot-ui","description":"Core component library. By Adslot","fork":false,"url":"https://api.github.com/repos/Adslot/adslot-ui","forks_url":"https://api.github.com/repos/Adslot/adslot-ui/forks","keys_url":"https://api.github.com/repos/Adslot/adslot-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adslot/adslot-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adslot/adslot-ui/teams","hooks_url":"https://api.github.com/repos/Adslot/adslot-ui/hooks","issue_events_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Adslot/adslot-ui/events","assignees_url":"https://api.github.com/repos/Adslot/adslot-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Adslot/adslot-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Adslot/adslot-ui/tags","blobs_url":"https://api.github.com/repos/Adslot/adslot-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adslot/adslot-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adslot/adslot-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adslot/adslot-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adslot/adslot-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Adslot/adslot-ui/languages","stargazers_url":"https://api.github.com/repos/Adslot/adslot-ui/stargazers","contributors_url":"https://api.github.com/repos/Adslot/adslot-ui/contributors","subscribers_url":"https://api.github.com/repos/Adslot/adslot-ui/subscribers","subscription_url":"https://api.github.com/repos/Adslot/adslot-ui/subscription","commits_url":"https://api.github.com/repos/Adslot/adslot-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adslot/adslot-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adslot/adslot-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Adslot/adslot-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Adslot/adslot-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adslot/adslot-ui/merges","archive_url":"https://api.github.com/repos/Adslot/adslot-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adslot/adslot-ui/downloads","issues_url":"https://api.github.com/repos/Adslot/adslot-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Adslot/adslot-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Adslot/adslot-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Adslot/adslot-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adslot/adslot-ui/labels{/name}","releases_url":"https://api.github.com/repos/Adslot/adslot-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Adslot/adslot-ui/deployments","created_at":"2015-10-29T02:51:12Z","updated_at":"2018-08-17T07:20:27Z","pushed_at":"2018-08-24T04:41:40Z","git_url":"git://github.com/Adslot/adslot-ui.git","ssh_url":"git@github.com:Adslot/adslot-ui.git","clone_url":"https://github.com/Adslot/adslot-ui.git","svn_url":"https://github.com/Adslot/adslot-ui","homepage":"https://adslot.github.io/adslot-ui/","size":14732,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":4,"open_issues":20,"watchers":14,"default_branch":"master"}},"base":{"label":"Adslot:master","ref":"master","sha":"50d725456436c2ef132c2d5672494c48de9eef4b","user":{"login":"Adslot","id":767098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NzA5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/767098?v=4","gravatar_id":"","url":"https://api.github.com/users/Adslot","html_url":"https://github.com/Adslot","followers_url":"https://api.github.com/users/Adslot/followers","following_url":"https://api.github.com/users/Adslot/following{/other_user}","gists_url":"https://api.github.com/users/Adslot/gists{/gist_id}","starred_url":"https://api.github.com/users/Adslot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adslot/subscriptions","organizations_url":"https://api.github.com/users/Adslot/orgs","repos_url":"https://api.github.com/users/Adslot/repos","events_url":"https://api.github.com/users/Adslot/events{/privacy}","received_events_url":"https://api.github.com/users/Adslot/received_events","type":"Organization","site_admin":false},"repo":{"id":45156258,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE1NjI1OA==","name":"adslot-ui","full_name":"Adslot/adslot-ui","owner":{"login":"Adslot","id":767098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NzA5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/767098?v=4","gravatar_id":"","url":"https://api.github.com/users/Adslot","html_url":"https://github.com/Adslot","followers_url":"https://api.github.com/users/Adslot/followers","following_url":"https://api.github.com/users/Adslot/following{/other_user}","gists_url":"https://api.github.com/users/Adslot/gists{/gist_id}","starred_url":"https://api.github.com/users/Adslot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adslot/subscriptions","organizations_url":"https://api.github.com/users/Adslot/orgs","repos_url":"https://api.github.com/users/Adslot/repos","events_url":"https://api.github.com/users/Adslot/events{/privacy}","received_events_url":"https://api.github.com/users/Adslot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Adslot/adslot-ui","description":"Core component library. By Adslot","fork":false,"url":"https://api.github.com/repos/Adslot/adslot-ui","forks_url":"https://api.github.com/repos/Adslot/adslot-ui/forks","keys_url":"https://api.github.com/repos/Adslot/adslot-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adslot/adslot-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adslot/adslot-ui/teams","hooks_url":"https://api.github.com/repos/Adslot/adslot-ui/hooks","issue_events_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Adslot/adslot-ui/events","assignees_url":"https://api.github.com/repos/Adslot/adslot-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Adslot/adslot-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Adslot/adslot-ui/tags","blobs_url":"https://api.github.com/repos/Adslot/adslot-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adslot/adslot-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adslot/adslot-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adslot/adslot-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adslot/adslot-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Adslot/adslot-ui/languages","stargazers_url":"https://api.github.com/repos/Adslot/adslot-ui/stargazers","contributors_url":"https://api.github.com/repos/Adslot/adslot-ui/contributors","subscribers_url":"https://api.github.com/repos/Adslot/adslot-ui/subscribers","subscription_url":"https://api.github.com/repos/Adslot/adslot-ui/subscription","commits_url":"https://api.github.com/repos/Adslot/adslot-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adslot/adslot-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adslot/adslot-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Adslot/adslot-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Adslot/adslot-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adslot/adslot-ui/merges","archive_url":"https://api.github.com/repos/Adslot/adslot-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adslot/adslot-ui/downloads","issues_url":"https://api.github.com/repos/Adslot/adslot-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Adslot/adslot-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Adslot/adslot-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Adslot/adslot-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adslot/adslot-ui/labels{/name}","releases_url":"https://api.github.com/repos/Adslot/adslot-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Adslot/adslot-ui/deployments","created_at":"2015-10-29T02:51:12Z","updated_at":"2018-08-17T07:20:27Z","pushed_at":"2018-08-24T04:41:40Z","git_url":"git://github.com/Adslot/adslot-ui.git","ssh_url":"git@github.com:Adslot/adslot-ui.git","clone_url":"https://github.com/Adslot/adslot-ui.git","svn_url":"https://github.com/Adslot/adslot-ui","homepage":"https://adslot.github.io/adslot-ui/","size":14732,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":4,"open_issues":20,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Adslot/adslot-ui/pulls/742"},"html":{"href":"https://github.com/Adslot/adslot-ui/pull/742"},"issue":{"href":"https://api.github.com/repos/Adslot/adslot-ui/issues/742"},"comments":{"href":"https://api.github.com/repos/Adslot/adslot-ui/issues/742/comments"},"review_comments":{"href":"https://api.github.com/repos/Adslot/adslot-ui/pulls/742/comments"},"review_comment":{"href":"https://api.github.com/repos/Adslot/adslot-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Adslot/adslot-ui/pulls/742/commits"},"statuses":{"href":"https://api.github.com/repos/Adslot/adslot-ui/statuses/bc343b0d950d08f80a8b627bfb44c0688dca8b24"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ChaoLiangSuper","id":15777593,"node_id":"MDQ6VXNlcjE1Nzc3NTkz","avatar_url":"https://avatars3.githubusercontent.com/u/15777593?v=4","gravatar_id":"","url":"https://api.github.com/users/ChaoLiangSuper","html_url":"https://github.com/ChaoLiangSuper","followers_url":"https://api.github.com/users/ChaoLiangSuper/followers","following_url":"https://api.github.com/users/ChaoLiangSuper/following{/other_user}","gists_url":"https://api.github.com/users/ChaoLiangSuper/gists{/gist_id}","starred_url":"https://api.github.com/users/ChaoLiangSuper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChaoLiangSuper/subscriptions","organizations_url":"https://api.github.com/users/ChaoLiangSuper/orgs","repos_url":"https://api.github.com/users/ChaoLiangSuper/repos","events_url":"https://api.github.com/users/ChaoLiangSuper/events{/privacy}","received_events_url":"https://api.github.com/users/ChaoLiangSuper/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":175,"deletions":359,"changed_files":14}}
{"actor":{"display_login":"ChaoLiangSuper"}}