{"action":"created","comment":{"url":"https://api.github.com/repos/apache/guacamole-client/pulls/comments/185388553","pull_request_review_id":116765499,"id":185388553,"diff_hunk":"@@ -41,7 +41,7 @@ <h2>{{'MANAGE_CONNECTION.SECTION_HEADER_EDIT_CONNECTION' | translate}}</h2>\n     <!-- Connection attributes section -->\n     <div class=\"attributes\">\n         <guac-form namespace=\"'CONNECTION_ATTRIBUTES'\" content=\"attributes\"\n-                   model=\"connection.attributes\" model-only=\"!canChangeAllAttributes()\"></guac-form>\n+                   model=\"connection.attributes\" model-only=\"managementPermissions.canChangeAllAttributes\"></guac-form>","path":"guacamole/src/main/webapp/app/manage/templates/manageConnection.html","position":null,"original_position":5,"commit_id":"244dd19aa0b5b17f28443465d927b6f0d34b21db","original_commit_id":"b0a625cdeac44be74fa3a75cec317f10e6620bca","user":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars1.githubusercontent.com/u/4632905?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"body":"OK. I've rebased away the mistake.","created_at":"2018-05-02T03:59:05Z","updated_at":"2018-05-02T03:59:05Z","html_url":"https://github.com/apache/guacamole-client/pull/282#discussion_r185388553","pull_request_url":"https://api.github.com/repos/apache/guacamole-client/pulls/282","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/guacamole-client/pulls/comments/185388553"},"html":{"href":"https://github.com/apache/guacamole-client/pull/282#discussion_r185388553"},"pull_request":{"href":"https://api.github.com/repos/apache/guacamole-client/pulls/282"}},"in_reply_to_id":185387927},"pull_request":{"url":"https://api.github.com/repos/apache/guacamole-client/pulls/282","id":185325605,"html_url":"https://github.com/apache/guacamole-client/pull/282","diff_url":"https://github.com/apache/guacamole-client/pull/282.diff","patch_url":"https://github.com/apache/guacamole-client/pull/282.patch","issue_url":"https://api.github.com/repos/apache/guacamole-client/issues/282","number":282,"state":"open","locked":false,"title":"GUACAMOLE-220: Extract common base for management UI.","user":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars1.githubusercontent.com/u/4632905?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"body":"A necessary basis for the user group management interface (which adds yet another management tab), these changes extract the common base code used by the various existing management tabs, which up until now has been largely duplicated.\r\n\r\nNew directives have been added to take care of data source tabs, permission management, and the save/cancel/clone/delete buttons. The permission test logic driving those buttons and other parts of each management tab has been moved into common class, as well.\r\n\r\nThis is a net increase in code due to the amount of documentation added, and a massive net decrease in the amount of code within the management controllers.","created_at":"2018-05-02T03:15:44Z","updated_at":"2018-05-02T03:59:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfb6c26acebad63c11b76dc2086c7fbf30448b06","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/guacamole-client/pulls/282/commits","review_comments_url":"https://api.github.com/repos/apache/guacamole-client/pulls/282/comments","review_comment_url":"https://api.github.com/repos/apache/guacamole-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/guacamole-client/issues/282/comments","statuses_url":"https://api.github.com/repos/apache/guacamole-client/statuses/244dd19aa0b5b17f28443465d927b6f0d34b21db","head":{"label":"mike-jumper:extract-common-ui","ref":"extract-common-ui","sha":"244dd19aa0b5b17f28443465d927b6f0d34b21db","user":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars1.githubusercontent.com/u/4632905?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"repo":{"id":54506694,"name":"guacamole-client","full_name":"mike-jumper/guacamole-client","owner":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars1.githubusercontent.com/u/4632905?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike-jumper/guacamole-client","description":"Mirror of Apache Guacamole Client","fork":true,"url":"https://api.github.com/repos/mike-jumper/guacamole-client","forks_url":"https://api.github.com/repos/mike-jumper/guacamole-client/forks","keys_url":"https://api.github.com/repos/mike-jumper/guacamole-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike-jumper/guacamole-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike-jumper/guacamole-client/teams","hooks_url":"https://api.github.com/repos/mike-jumper/guacamole-client/hooks","issue_events_url":"https://api.github.com/repos/mike-jumper/guacamole-client/issues/events{/number}","events_url":"https://api.github.com/repos/mike-jumper/guacamole-client/events","assignees_url":"https://api.github.com/repos/mike-jumper/guacamole-client/assignees{/user}","branches_url":"https://api.github.com/repos/mike-jumper/guacamole-client/branches{/branch}","tags_url":"https://api.github.com/repos/mike-jumper/guacamole-client/tags","blobs_url":"https://api.github.com/repos/mike-jumper/guacamole-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike-jumper/guacamole-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike-jumper/guacamole-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike-jumper/guacamole-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike-jumper/guacamole-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mike-jumper/guacamole-client/languages","stargazers_url":"https://api.github.com/repos/mike-jumper/guacamole-client/stargazers","contributors_url":"https://api.github.com/repos/mike-jumper/guacamole-client/contributors","subscribers_url":"https://api.github.com/repos/mike-jumper/guacamole-client/subscribers","subscription_url":"https://api.github.com/repos/mike-jumper/guacamole-client/subscription","commits_url":"https://api.github.com/repos/mike-jumper/guacamole-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike-jumper/guacamole-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike-jumper/guacamole-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike-jumper/guacamole-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike-jumper/guacamole-client/contents/{+path}","compare_url":"https://api.github.com/repos/mike-jumper/guacamole-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike-jumper/guacamole-client/merges","archive_url":"https://api.github.com/repos/mike-jumper/guacamole-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike-jumper/guacamole-client/downloads","issues_url":"https://api.github.com/repos/mike-jumper/guacamole-client/issues{/number}","pulls_url":"https://api.github.com/repos/mike-jumper/guacamole-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mike-jumper/guacamole-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mike-jumper/guacamole-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike-jumper/guacamole-client/labels{/name}","releases_url":"https://api.github.com/repos/mike-jumper/guacamole-client/releases{/id}","deployments_url":"https://api.github.com/repos/mike-jumper/guacamole-client/deployments","created_at":"2016-03-22T20:30:39Z","updated_at":"2018-04-30T21:41:40Z","pushed_at":"2018-05-02T03:58:37Z","git_url":"git://github.com/mike-jumper/guacamole-client.git","ssh_url":"git@github.com:mike-jumper/guacamole-client.git","clone_url":"https://github.com/mike-jumper/guacamole-client.git","svn_url":"https://github.com/mike-jumper/guacamole-client","homepage":"","size":17260,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8181a96060a8da4d6acc079ab37f8e3ccb415bdb","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":54452622,"name":"guacamole-client","full_name":"apache/guacamole-client","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/guacamole-client","description":"Mirror of Apache Guacamole Client","fork":false,"url":"https://api.github.com/repos/apache/guacamole-client","forks_url":"https://api.github.com/repos/apache/guacamole-client/forks","keys_url":"https://api.github.com/repos/apache/guacamole-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/guacamole-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/guacamole-client/teams","hooks_url":"https://api.github.com/repos/apache/guacamole-client/hooks","issue_events_url":"https://api.github.com/repos/apache/guacamole-client/issues/events{/number}","events_url":"https://api.github.com/repos/apache/guacamole-client/events","assignees_url":"https://api.github.com/repos/apache/guacamole-client/assignees{/user}","branches_url":"https://api.github.com/repos/apache/guacamole-client/branches{/branch}","tags_url":"https://api.github.com/repos/apache/guacamole-client/tags","blobs_url":"https://api.github.com/repos/apache/guacamole-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/guacamole-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/guacamole-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/guacamole-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/guacamole-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/guacamole-client/languages","stargazers_url":"https://api.github.com/repos/apache/guacamole-client/stargazers","contributors_url":"https://api.github.com/repos/apache/guacamole-client/contributors","subscribers_url":"https://api.github.com/repos/apache/guacamole-client/subscribers","subscription_url":"https://api.github.com/repos/apache/guacamole-client/subscription","commits_url":"https://api.github.com/repos/apache/guacamole-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/guacamole-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/guacamole-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/guacamole-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/guacamole-client/contents/{+path}","compare_url":"https://api.github.com/repos/apache/guacamole-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/guacamole-client/merges","archive_url":"https://api.github.com/repos/apache/guacamole-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/guacamole-client/downloads","issues_url":"https://api.github.com/repos/apache/guacamole-client/issues{/number}","pulls_url":"https://api.github.com/repos/apache/guacamole-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/guacamole-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/guacamole-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/guacamole-client/labels{/name}","releases_url":"https://api.github.com/repos/apache/guacamole-client/releases{/id}","deployments_url":"https://api.github.com/repos/apache/guacamole-client/deployments","created_at":"2016-03-22T07:00:06Z","updated_at":"2018-05-01T05:03:30Z","pushed_at":"2018-05-02T03:58:38Z","git_url":"git://github.com/apache/guacamole-client.git","ssh_url":"git@github.com:apache/guacamole-client.git","clone_url":"https://github.com/apache/guacamole-client.git","svn_url":"https://github.com/apache/guacamole-client","homepage":"","size":17033,"stargazers_count":364,"watchers_count":364,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":145,"open_issues":14,"watchers":364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/guacamole-client/pulls/282"},"html":{"href":"https://github.com/apache/guacamole-client/pull/282"},"issue":{"href":"https://api.github.com/repos/apache/guacamole-client/issues/282"},"comments":{"href":"https://api.github.com/repos/apache/guacamole-client/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/guacamole-client/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/guacamole-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/guacamole-client/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/apache/guacamole-client/statuses/244dd19aa0b5b17f28443465d927b6f0d34b21db"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mike-jumper"}}