{"action":"created","comment":{"url":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/comments/190055883","pull_request_review_id":122356442,"id":190055883,"diff_hunk":"@@ -279,6 +293,66 @@ describe('JobsTableComponent', () => {\n     });\n   }))\n \n+  it('should select multiple jobs on shift-click', async( () => {\n+    fixture.detectChanges();\n+    const jobCheckboxes = getJobCheckboxes();\n+    jobCheckboxes[1].nativeElement.click();\n+    testComponent.jobsTableComponent.updateCheckBoxSelection(jobs[3], shiftClick);\n+    fixture.detectChanges();\n+\n+    expect(jobCheckboxes.map(c => c.nativeElement.checked))\n+      .toEqual([false, true, true, true, false]);\n+  }))\n+\n+  it('should select multiple jobs on shift-click (reverse order)', async( () => {","path":"ui/src/app/job-list/table/table.component.spec.ts","position":36,"original_position":36,"commit_id":"3a7e72898f755120809e8e0b33d83b0170e49b90","original_commit_id":"3a7e72898f755120809e8e0b33d83b0170e49b90","user":{"login":"calbach","id":822298,"avatar_url":"https://avatars0.githubusercontent.com/u/822298?v=4","gravatar_id":"","url":"https://api.github.com/users/calbach","html_url":"https://github.com/calbach","followers_url":"https://api.github.com/users/calbach/followers","following_url":"https://api.github.com/users/calbach/following{/other_user}","gists_url":"https://api.github.com/users/calbach/gists{/gist_id}","starred_url":"https://api.github.com/users/calbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calbach/subscriptions","organizations_url":"https://api.github.com/users/calbach/orgs","repos_url":"https://api.github.com/users/calbach/repos","events_url":"https://api.github.com/users/calbach/events{/privacy}","received_events_url":"https://api.github.com/users/calbach/received_events","type":"User","site_admin":false},"body":"nit: One last thing I just noticed - please drop the space after async( `async( ()` -> `async(()`","created_at":"2018-05-22T21:16:34Z","updated_at":"2018-05-22T21:17:19Z","html_url":"https://github.com/DataBiosphere/job-manager/pull/279#discussion_r190055883","pull_request_url":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/279","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/comments/190055883"},"html":{"href":"https://github.com/DataBiosphere/job-manager/pull/279#discussion_r190055883"},"pull_request":{"href":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/279"}}},"pull_request":{"url":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/279","id":188847234,"html_url":"https://github.com/DataBiosphere/job-manager/pull/279","diff_url":"https://github.com/DataBiosphere/job-manager/pull/279.diff","patch_url":"https://github.com/DataBiosphere/job-manager/pull/279.patch","issue_url":"https://api.github.com/repos/DataBiosphere/job-manager/issues/279","number":279,"state":"open","locked":false,"title":"added handler for shift-clicking on job checkbox to select multiple jobs","user":{"login":"rsasch","id":1713505,"avatar_url":"https://avatars1.githubusercontent.com/u/1713505?v=4","gravatar_id":"","url":"https://api.github.com/users/rsasch","html_url":"https://github.com/rsasch","followers_url":"https://api.github.com/users/rsasch/followers","following_url":"https://api.github.com/users/rsasch/following{/other_user}","gists_url":"https://api.github.com/users/rsasch/gists{/gist_id}","starred_url":"https://api.github.com/users/rsasch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsasch/subscriptions","organizations_url":"https://api.github.com/users/rsasch/orgs","repos_url":"https://api.github.com/users/rsasch/repos","events_url":"https://api.github.com/users/rsasch/events{/privacy}","received_events_url":"https://api.github.com/users/rsasch/received_events","type":"User","site_admin":false},"body":"see https://elastc.com/c/UhPkLrGx/327-shift-select-many","created_at":"2018-05-17T20:07:33Z","updated_at":"2018-05-22T21:17:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97333e6c74491b486bd30c996d70a4b234715d76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/279/commits","review_comments_url":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/279/comments","review_comment_url":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataBiosphere/job-manager/issues/279/comments","statuses_url":"https://api.github.com/repos/DataBiosphere/job-manager/statuses/3a7e72898f755120809e8e0b33d83b0170e49b90","head":{"label":"DataBiosphere:rsasch/shift-click","ref":"rsasch/shift-click","sha":"3a7e72898f755120809e8e0b33d83b0170e49b90","user":{"login":"DataBiosphere","id":32805087,"avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":101917710,"name":"job-manager","full_name":"DataBiosphere/job-manager","owner":{"login":"DataBiosphere","id":32805087,"avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataBiosphere/job-manager","description":"Job Manager API and UI for interacting with asynchronous batch jobs and workflows.","fork":false,"url":"https://api.github.com/repos/DataBiosphere/job-manager","forks_url":"https://api.github.com/repos/DataBiosphere/job-manager/forks","keys_url":"https://api.github.com/repos/DataBiosphere/job-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataBiosphere/job-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataBiosphere/job-manager/teams","hooks_url":"https://api.github.com/repos/DataBiosphere/job-manager/hooks","issue_events_url":"https://api.github.com/repos/DataBiosphere/job-manager/issues/events{/number}","events_url":"https://api.github.com/repos/DataBiosphere/job-manager/events","assignees_url":"https://api.github.com/repos/DataBiosphere/job-manager/assignees{/user}","branches_url":"https://api.github.com/repos/DataBiosphere/job-manager/branches{/branch}","tags_url":"https://api.github.com/repos/DataBiosphere/job-manager/tags","blobs_url":"https://api.github.com/repos/DataBiosphere/job-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataBiosphere/job-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataBiosphere/job-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataBiosphere/job-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataBiosphere/job-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/DataBiosphere/job-manager/languages","stargazers_url":"https://api.github.com/repos/DataBiosphere/job-manager/stargazers","contributors_url":"https://api.github.com/repos/DataBiosphere/job-manager/contributors","subscribers_url":"https://api.github.com/repos/DataBiosphere/job-manager/subscribers","subscription_url":"https://api.github.com/repos/DataBiosphere/job-manager/subscription","commits_url":"https://api.github.com/repos/DataBiosphere/job-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataBiosphere/job-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataBiosphere/job-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataBiosphere/job-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataBiosphere/job-manager/contents/{+path}","compare_url":"https://api.github.com/repos/DataBiosphere/job-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataBiosphere/job-manager/merges","archive_url":"https://api.github.com/repos/DataBiosphere/job-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataBiosphere/job-manager/downloads","issues_url":"https://api.github.com/repos/DataBiosphere/job-manager/issues{/number}","pulls_url":"https://api.github.com/repos/DataBiosphere/job-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/DataBiosphere/job-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/DataBiosphere/job-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataBiosphere/job-manager/labels{/name}","releases_url":"https://api.github.com/repos/DataBiosphere/job-manager/releases{/id}","deployments_url":"https://api.github.com/repos/DataBiosphere/job-manager/deployments","created_at":"2017-08-30T18:51:22Z","updated_at":"2018-05-22T20:39:32Z","pushed_at":"2018-05-22T21:12:52Z","git_url":"git://github.com/DataBiosphere/job-manager.git","ssh_url":"git@github.com:DataBiosphere/job-manager.git","clone_url":"https://github.com/DataBiosphere/job-manager.git","svn_url":"https://github.com/DataBiosphere/job-manager","homepage":"","size":1048,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":8,"watchers":5,"default_branch":"master"}},"base":{"label":"DataBiosphere:master","ref":"master","sha":"33d78705e875dcf578f8c2b808f545bb004e48ff","user":{"login":"DataBiosphere","id":32805087,"avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":101917710,"name":"job-manager","full_name":"DataBiosphere/job-manager","owner":{"login":"DataBiosphere","id":32805087,"avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataBiosphere/job-manager","description":"Job Manager API and UI for interacting with asynchronous batch jobs and workflows.","fork":false,"url":"https://api.github.com/repos/DataBiosphere/job-manager","forks_url":"https://api.github.com/repos/DataBiosphere/job-manager/forks","keys_url":"https://api.github.com/repos/DataBiosphere/job-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataBiosphere/job-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataBiosphere/job-manager/teams","hooks_url":"https://api.github.com/repos/DataBiosphere/job-manager/hooks","issue_events_url":"https://api.github.com/repos/DataBiosphere/job-manager/issues/events{/number}","events_url":"https://api.github.com/repos/DataBiosphere/job-manager/events","assignees_url":"https://api.github.com/repos/DataBiosphere/job-manager/assignees{/user}","branches_url":"https://api.github.com/repos/DataBiosphere/job-manager/branches{/branch}","tags_url":"https://api.github.com/repos/DataBiosphere/job-manager/tags","blobs_url":"https://api.github.com/repos/DataBiosphere/job-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataBiosphere/job-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataBiosphere/job-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataBiosphere/job-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataBiosphere/job-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/DataBiosphere/job-manager/languages","stargazers_url":"https://api.github.com/repos/DataBiosphere/job-manager/stargazers","contributors_url":"https://api.github.com/repos/DataBiosphere/job-manager/contributors","subscribers_url":"https://api.github.com/repos/DataBiosphere/job-manager/subscribers","subscription_url":"https://api.github.com/repos/DataBiosphere/job-manager/subscription","commits_url":"https://api.github.com/repos/DataBiosphere/job-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataBiosphere/job-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataBiosphere/job-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataBiosphere/job-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataBiosphere/job-manager/contents/{+path}","compare_url":"https://api.github.com/repos/DataBiosphere/job-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataBiosphere/job-manager/merges","archive_url":"https://api.github.com/repos/DataBiosphere/job-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataBiosphere/job-manager/downloads","issues_url":"https://api.github.com/repos/DataBiosphere/job-manager/issues{/number}","pulls_url":"https://api.github.com/repos/DataBiosphere/job-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/DataBiosphere/job-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/DataBiosphere/job-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataBiosphere/job-manager/labels{/name}","releases_url":"https://api.github.com/repos/DataBiosphere/job-manager/releases{/id}","deployments_url":"https://api.github.com/repos/DataBiosphere/job-manager/deployments","created_at":"2017-08-30T18:51:22Z","updated_at":"2018-05-22T20:39:32Z","pushed_at":"2018-05-22T21:12:52Z","git_url":"git://github.com/DataBiosphere/job-manager.git","ssh_url":"git@github.com:DataBiosphere/job-manager.git","clone_url":"https://github.com/DataBiosphere/job-manager.git","svn_url":"https://github.com/DataBiosphere/job-manager","homepage":"","size":1048,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":8,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/279"},"html":{"href":"https://github.com/DataBiosphere/job-manager/pull/279"},"issue":{"href":"https://api.github.com/repos/DataBiosphere/job-manager/issues/279"},"comments":{"href":"https://api.github.com/repos/DataBiosphere/job-manager/issues/279/comments"},"review_comments":{"href":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/279/comments"},"review_comment":{"href":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/279/commits"},"statuses":{"href":"https://api.github.com/repos/DataBiosphere/job-manager/statuses/3a7e72898f755120809e8e0b33d83b0170e49b90"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"calbach"}}