{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/190867778","pull_request_review_id":123338858,"id":190867778,"diff_hunk":"@@ -1,478 +0,0 @@\n-/**************************************************************************//**","path":"boards/mbed_lpc1768/system.c","position":1,"original_position":1,"commit_id":"88e04d21791275c08202de5152e02fd17720061e","original_commit_id":"88e04d21791275c08202de5152e02fd17720061e","user":{"login":"smlng","id":10532675,"avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"body":"oops, just for fun? 😄 ","created_at":"2018-05-25T11:39:55Z","updated_at":"2018-05-25T11:39:55Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/9194#discussion_r190867778","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9194","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/190867778"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/9194#discussion_r190867778"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9194"}},"in_reply_to_id":190867515},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9194","id":190535688,"html_url":"https://github.com/RIOT-OS/RIOT/pull/9194","diff_url":"https://github.com/RIOT-OS/RIOT/pull/9194.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/9194.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9194","number":9194,"state":"open","locked":false,"title":"board/cpu init: move cpu_init() from board_init() to startup","user":{"login":"smlng","id":10532675,"avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"body":"<!--\r\nThe RIOT community cares a lot about code quality.\r\nTherefore, before describing what your contribution is about, we would like\r\nyou to make sure that your modifications are compliant with the RIOT\r\ncoding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.\r\n-->\r\n\r\n### Contribution description\r\n\r\nDuring \"boot\" of RIOT the initial startup (reset) function defined per CPU calls `board_init()` which then calls `cpu_init()` and maybe inits some LEDs and buttons afterwards. IMHO its a bit weird that `board_init` calls `cpu_init` instead of handling this in the startup function by calling `board_init` after `cpu_init`.\r\n\r\nThis PR moves the `cpu_init` function accordingly. I tested with Arduinos, PhyNode and Remote-RevB, which all work. However, some boards have very special startup routines so if anybody could check the following boards to verify they still work, would be great:\r\n\r\n- [ ] chronos\r\n- [ ] mbed_lpc1768\r\n- [ ] msba2\r\n- [ ] msb-430\r\n- [ ] mulle (@gebart ?)\r\n- [ ] seeeduino_arch-pro\r\n- [ ] telosb\r\n- [ ] waspmote-pro\r\n\r\n\r\n\r\n### Issues/PRs references\r\n\r\n<!--\r\nExamples: Fixes #1234. See also #5678. Depends on PR #9876.\r\n\r\nPlease use keywords (e.g., fixes, resolve) with the links to the issues you\r\nresolved, this way they will be automatically closed when your pull request\r\nis merged. See https://help.github.com/articles/closing-issues-using-keywords/.\r\n-->","created_at":"2018-05-25T09:47:49Z","updated_at":"2018-05-25T11:39:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41fdb7cd95e8f44f19a5e18c6a0fb1d32aa2af4a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gebart","id":317506,"avatar_url":"https://avatars1.githubusercontent.com/u/317506?v=4","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":214816571,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Ready%20for%20CI%20build","name":"Ready for CI build","color":"bfdadc","default":false},{"id":87985768,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/WIP","name":"WIP","color":"009800","default":false},{"id":122032371,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/cleanup","name":"cleanup","color":"FF7c7c","default":false},{"id":23399100,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/enhancement","name":"enhancement","color":"f17070","default":true},{"id":719186188,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/help%20wanted","name":"help wanted","color":"ff0000","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9194/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9194/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9194/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/88e04d21791275c08202de5152e02fd17720061e","head":{"label":"smlng:pr/cpu_init","ref":"pr/cpu_init","sha":"88e04d21791275c08202de5152e02fd17720061e","user":{"login":"smlng","id":10532675,"avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"repo":{"id":42542335,"name":"RIOT","full_name":"smlng/RIOT","owner":{"login":"smlng","id":10532675,"avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smlng/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/smlng/RIOT","forks_url":"https://api.github.com/repos/smlng/RIOT/forks","keys_url":"https://api.github.com/repos/smlng/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smlng/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smlng/RIOT/teams","hooks_url":"https://api.github.com/repos/smlng/RIOT/hooks","issue_events_url":"https://api.github.com/repos/smlng/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/smlng/RIOT/events","assignees_url":"https://api.github.com/repos/smlng/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/smlng/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/smlng/RIOT/tags","blobs_url":"https://api.github.com/repos/smlng/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smlng/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smlng/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/smlng/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smlng/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/smlng/RIOT/languages","stargazers_url":"https://api.github.com/repos/smlng/RIOT/stargazers","contributors_url":"https://api.github.com/repos/smlng/RIOT/contributors","subscribers_url":"https://api.github.com/repos/smlng/RIOT/subscribers","subscription_url":"https://api.github.com/repos/smlng/RIOT/subscription","commits_url":"https://api.github.com/repos/smlng/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/smlng/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/smlng/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/smlng/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/smlng/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/smlng/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smlng/RIOT/merges","archive_url":"https://api.github.com/repos/smlng/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smlng/RIOT/downloads","issues_url":"https://api.github.com/repos/smlng/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/smlng/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/smlng/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/smlng/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smlng/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/smlng/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/smlng/RIOT/deployments","created_at":"2015-09-15T19:44:22Z","updated_at":"2018-05-25T08:39:32Z","pushed_at":"2018-05-25T11:36:31Z","git_url":"git://github.com/smlng/RIOT.git","ssh_url":"git@github.com:smlng/RIOT.git","clone_url":"https://github.com/smlng/RIOT.git","svn_url":"https://github.com/smlng/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":52405,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"9657274d0d7f8b88095f9bf866759a34df23c935","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2018-05-25T11:12:34Z","pushed_at":"2018-05-25T11:36:32Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":52351,"stargazers_count":1797,"watchers_count":1797,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1068,"mirror_url":null,"archived":false,"open_issues_count":763,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":1068,"open_issues":763,"watchers":1797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9194"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/9194"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9194"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9194/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9194/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9194/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/88e04d21791275c08202de5152e02fd17720061e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"smlng"}}