{"action":"created","comment":{"url":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments/191690390","pull_request_review_id":124305964,"id":191690390,"diff_hunk":"@@ -180,10 +197,13 @@ def testRunfilesLibrariesFindRunfilesWithRunfilesManifestEnvvar(self):\n     self.AssertExitCode(exit_code, 0, stderr)\n     bazel_bin = stdout[0]\n \n-    for lang in [(\"java\", \"Java\"),\n-                 (\"sh\", \"Bash\")]:  # TODO(laszlocsomor): add \"cc\" when ready.\n+    for lang in [(\"java\", \"Java\"), (\"sh\", \"Bash\"), (\"cc\", \"C++\")]:\n       exit_code, _, stderr = self.RunBazel([\n-          \"build\", \"--experimental_enable_runfiles=no\", \"//bar:bar-\" + lang[0]\n+          \"build\",\n+          \"--verbose_failures\",\n+          \"--experimental_shortened_obj_file_path\",","path":"src/test/py/bazel/runfiles_test.py","position":108,"original_position":108,"commit_id":"5d55c1f0f7037688c908ae7e53051580501f811d","original_commit_id":"5d55c1f0f7037688c908ae7e53051580501f811d","user":{"login":"meteorcloudy","id":4171702,"avatar_url":"https://avatars2.githubusercontent.com/u/4171702?v=4","gravatar_id":"","url":"https://api.github.com/users/meteorcloudy","html_url":"https://github.com/meteorcloudy","followers_url":"https://api.github.com/users/meteorcloudy/followers","following_url":"https://api.github.com/users/meteorcloudy/following{/other_user}","gists_url":"https://api.github.com/users/meteorcloudy/gists{/gist_id}","starred_url":"https://api.github.com/users/meteorcloudy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteorcloudy/subscriptions","organizations_url":"https://api.github.com/users/meteorcloudy/orgs","repos_url":"https://api.github.com/users/meteorcloudy/repos","events_url":"https://api.github.com/users/meteorcloudy/events{/privacy}","received_events_url":"https://api.github.com/users/meteorcloudy/received_events","type":"User","site_admin":false},"body":"Same here","created_at":"2018-05-30T08:55:50Z","updated_at":"2018-05-30T09:02:35Z","html_url":"https://github.com/bazelbuild/bazel/pull/5293#discussion_r191690390","pull_request_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/5293","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments/191690390"},"html":{"href":"https://github.com/bazelbuild/bazel/pull/5293#discussion_r191690390"},"pull_request":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/5293"}}},"pull_request":{"url":"https://api.github.com/repos/bazelbuild/bazel/pulls/5293","id":191179117,"html_url":"https://github.com/bazelbuild/bazel/pull/5293","diff_url":"https://github.com/bazelbuild/bazel/pull/5293.diff","patch_url":"https://github.com/bazelbuild/bazel/pull/5293.patch","issue_url":"https://api.github.com/repos/bazelbuild/bazel/issues/5293","number":5293,"state":"open","locked":false,"title":"runfiles,cc: C++ runfiles library in @bazel_tools","user":{"login":"laszlocsomor","id":10532244,"avatar_url":"https://avatars0.githubusercontent.com/u/10532244?v=4","gravatar_id":"","url":"https://api.github.com/users/laszlocsomor","html_url":"https://github.com/laszlocsomor","followers_url":"https://api.github.com/users/laszlocsomor/followers","following_url":"https://api.github.com/users/laszlocsomor/following{/other_user}","gists_url":"https://api.github.com/users/laszlocsomor/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlocsomor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlocsomor/subscriptions","organizations_url":"https://api.github.com/users/laszlocsomor/orgs","repos_url":"https://api.github.com/users/laszlocsomor/repos","events_url":"https://api.github.com/users/laszlocsomor/events{/privacy}","received_events_url":"https://api.github.com/users/laszlocsomor/received_events","type":"User","site_admin":false},"body":"Add the C++ runfiles library to\r\n@bazel_tools//tools/cpp/runfiles:runfiles.\r\n\r\nRELNOTES[NEW]: C++,runfiles: to access data-dependencies (runfiles) in C++ programs, use the runfiles library built into Bazel. For usage info, see https://github.com/bazelbuild/bazel/blob/master/tools/cpp/runfiles/runfiles.h\r\n\r\nChange-Id: I5057a9f477289eea7244c60105e77fc71652a817","created_at":"2018-05-29T15:08:44Z","updated_at":"2018-05-30T09:02:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67f386aebe9366dc46eb943e9e36450be5faa42a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":323761238,"url":"https://api.github.com/repos/bazelbuild/bazel/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/5293/commits","review_comments_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/5293/comments","review_comment_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazelbuild/bazel/issues/5293/comments","statuses_url":"https://api.github.com/repos/bazelbuild/bazel/statuses/5d55c1f0f7037688c908ae7e53051580501f811d","head":{"label":"laszlocsomor:cpp-runfiles2","ref":"cpp-runfiles2","sha":"5d55c1f0f7037688c908ae7e53051580501f811d","user":{"login":"laszlocsomor","id":10532244,"avatar_url":"https://avatars0.githubusercontent.com/u/10532244?v=4","gravatar_id":"","url":"https://api.github.com/users/laszlocsomor","html_url":"https://github.com/laszlocsomor","followers_url":"https://api.github.com/users/laszlocsomor/followers","following_url":"https://api.github.com/users/laszlocsomor/following{/other_user}","gists_url":"https://api.github.com/users/laszlocsomor/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlocsomor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlocsomor/subscriptions","organizations_url":"https://api.github.com/users/laszlocsomor/orgs","repos_url":"https://api.github.com/users/laszlocsomor/repos","events_url":"https://api.github.com/users/laszlocsomor/events{/privacy}","received_events_url":"https://api.github.com/users/laszlocsomor/received_events","type":"User","site_admin":false},"repo":{"id":123130698,"name":"bazel","full_name":"laszlocsomor/bazel","owner":{"login":"laszlocsomor","id":10532244,"avatar_url":"https://avatars0.githubusercontent.com/u/10532244?v=4","gravatar_id":"","url":"https://api.github.com/users/laszlocsomor","html_url":"https://github.com/laszlocsomor","followers_url":"https://api.github.com/users/laszlocsomor/followers","following_url":"https://api.github.com/users/laszlocsomor/following{/other_user}","gists_url":"https://api.github.com/users/laszlocsomor/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlocsomor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlocsomor/subscriptions","organizations_url":"https://api.github.com/users/laszlocsomor/orgs","repos_url":"https://api.github.com/users/laszlocsomor/repos","events_url":"https://api.github.com/users/laszlocsomor/events{/privacy}","received_events_url":"https://api.github.com/users/laszlocsomor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laszlocsomor/bazel","description":"a fast, scalable, multi-language and extensible build system","fork":true,"url":"https://api.github.com/repos/laszlocsomor/bazel","forks_url":"https://api.github.com/repos/laszlocsomor/bazel/forks","keys_url":"https://api.github.com/repos/laszlocsomor/bazel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laszlocsomor/bazel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laszlocsomor/bazel/teams","hooks_url":"https://api.github.com/repos/laszlocsomor/bazel/hooks","issue_events_url":"https://api.github.com/repos/laszlocsomor/bazel/issues/events{/number}","events_url":"https://api.github.com/repos/laszlocsomor/bazel/events","assignees_url":"https://api.github.com/repos/laszlocsomor/bazel/assignees{/user}","branches_url":"https://api.github.com/repos/laszlocsomor/bazel/branches{/branch}","tags_url":"https://api.github.com/repos/laszlocsomor/bazel/tags","blobs_url":"https://api.github.com/repos/laszlocsomor/bazel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laszlocsomor/bazel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laszlocsomor/bazel/git/refs{/sha}","trees_url":"https://api.github.com/repos/laszlocsomor/bazel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laszlocsomor/bazel/statuses/{sha}","languages_url":"https://api.github.com/repos/laszlocsomor/bazel/languages","stargazers_url":"https://api.github.com/repos/laszlocsomor/bazel/stargazers","contributors_url":"https://api.github.com/repos/laszlocsomor/bazel/contributors","subscribers_url":"https://api.github.com/repos/laszlocsomor/bazel/subscribers","subscription_url":"https://api.github.com/repos/laszlocsomor/bazel/subscription","commits_url":"https://api.github.com/repos/laszlocsomor/bazel/commits{/sha}","git_commits_url":"https://api.github.com/repos/laszlocsomor/bazel/git/commits{/sha}","comments_url":"https://api.github.com/repos/laszlocsomor/bazel/comments{/number}","issue_comment_url":"https://api.github.com/repos/laszlocsomor/bazel/issues/comments{/number}","contents_url":"https://api.github.com/repos/laszlocsomor/bazel/contents/{+path}","compare_url":"https://api.github.com/repos/laszlocsomor/bazel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laszlocsomor/bazel/merges","archive_url":"https://api.github.com/repos/laszlocsomor/bazel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laszlocsomor/bazel/downloads","issues_url":"https://api.github.com/repos/laszlocsomor/bazel/issues{/number}","pulls_url":"https://api.github.com/repos/laszlocsomor/bazel/pulls{/number}","milestones_url":"https://api.github.com/repos/laszlocsomor/bazel/milestones{/number}","notifications_url":"https://api.github.com/repos/laszlocsomor/bazel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laszlocsomor/bazel/labels{/name}","releases_url":"https://api.github.com/repos/laszlocsomor/bazel/releases{/id}","deployments_url":"https://api.github.com/repos/laszlocsomor/bazel/deployments","created_at":"2018-02-27T13:09:26Z","updated_at":"2018-05-28T07:56:25Z","pushed_at":"2018-05-29T15:07:22Z","git_url":"git://github.com/laszlocsomor/bazel.git","ssh_url":"git@github.com:laszlocsomor/bazel.git","clone_url":"https://github.com/laszlocsomor/bazel.git","svn_url":"https://github.com/laszlocsomor/bazel","homepage":"https://bazel.build","size":464745,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazelbuild:master","ref":"master","sha":"6ee1a8184bd2afd21da7c96359d202ad43d32264","user":{"login":"bazelbuild","id":11684617,"avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":20773773,"name":"bazel","full_name":"bazelbuild/bazel","owner":{"login":"bazelbuild","id":11684617,"avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazelbuild/bazel","description":"a fast, scalable, multi-language and extensible build system","fork":false,"url":"https://api.github.com/repos/bazelbuild/bazel","forks_url":"https://api.github.com/repos/bazelbuild/bazel/forks","keys_url":"https://api.github.com/repos/bazelbuild/bazel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazelbuild/bazel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazelbuild/bazel/teams","hooks_url":"https://api.github.com/repos/bazelbuild/bazel/hooks","issue_events_url":"https://api.github.com/repos/bazelbuild/bazel/issues/events{/number}","events_url":"https://api.github.com/repos/bazelbuild/bazel/events","assignees_url":"https://api.github.com/repos/bazelbuild/bazel/assignees{/user}","branches_url":"https://api.github.com/repos/bazelbuild/bazel/branches{/branch}","tags_url":"https://api.github.com/repos/bazelbuild/bazel/tags","blobs_url":"https://api.github.com/repos/bazelbuild/bazel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazelbuild/bazel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazelbuild/bazel/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazelbuild/bazel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazelbuild/bazel/statuses/{sha}","languages_url":"https://api.github.com/repos/bazelbuild/bazel/languages","stargazers_url":"https://api.github.com/repos/bazelbuild/bazel/stargazers","contributors_url":"https://api.github.com/repos/bazelbuild/bazel/contributors","subscribers_url":"https://api.github.com/repos/bazelbuild/bazel/subscribers","subscription_url":"https://api.github.com/repos/bazelbuild/bazel/subscription","commits_url":"https://api.github.com/repos/bazelbuild/bazel/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazelbuild/bazel/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazelbuild/bazel/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazelbuild/bazel/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazelbuild/bazel/contents/{+path}","compare_url":"https://api.github.com/repos/bazelbuild/bazel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazelbuild/bazel/merges","archive_url":"https://api.github.com/repos/bazelbuild/bazel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazelbuild/bazel/downloads","issues_url":"https://api.github.com/repos/bazelbuild/bazel/issues{/number}","pulls_url":"https://api.github.com/repos/bazelbuild/bazel/pulls{/number}","milestones_url":"https://api.github.com/repos/bazelbuild/bazel/milestones{/number}","notifications_url":"https://api.github.com/repos/bazelbuild/bazel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazelbuild/bazel/labels{/name}","releases_url":"https://api.github.com/repos/bazelbuild/bazel/releases{/id}","deployments_url":"https://api.github.com/repos/bazelbuild/bazel/deployments","created_at":"2014-06-12T16:00:38Z","updated_at":"2018-05-30T07:59:37Z","pushed_at":"2018-05-30T08:46:16Z","git_url":"git://github.com/bazelbuild/bazel.git","ssh_url":"git@github.com:bazelbuild/bazel.git","clone_url":"https://github.com/bazelbuild/bazel.git","svn_url":"https://github.com/bazelbuild/bazel","homepage":"https://bazel.build","size":465120,"stargazers_count":9049,"watchers_count":9049,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1409,"mirror_url":null,"archived":false,"open_issues_count":1370,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1409,"open_issues":1370,"watchers":9049,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/5293"},"html":{"href":"https://github.com/bazelbuild/bazel/pull/5293"},"issue":{"href":"https://api.github.com/repos/bazelbuild/bazel/issues/5293"},"comments":{"href":"https://api.github.com/repos/bazelbuild/bazel/issues/5293/comments"},"review_comments":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/5293/comments"},"review_comment":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/5293/commits"},"statuses":{"href":"https://api.github.com/repos/bazelbuild/bazel/statuses/5d55c1f0f7037688c908ae7e53051580501f811d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"meteorcloudy"}}