{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/237061200","pull_request_review_id":179267412,"id":237061200,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzA2MTIwMA==","diff_hunk":"@@ -927,6 +997,11 @@ protected void onFoundPeersUpdated() {\n \n     private void startElectionScheduler() {\n         assert electionScheduler == null : electionScheduler;\n+\n+        if (getLocalNode().isMasterNode() == false) {","path":"server/src/main/java/org/elasticsearch/cluster/coordination/Coordinator.java","position":165,"original_position":165,"commit_id":"a1e393fcdb03131ed735d8e8488515557603a86d","original_commit_id":"a1e393fcdb03131ed735d8e8488515557603a86d","user":{"login":"ywelsch","id":3718355,"node_id":"MDQ6VXNlcjM3MTgzNTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3718355?v=4","gravatar_id":"","url":"https://api.github.com/users/ywelsch","html_url":"https://github.com/ywelsch","followers_url":"https://api.github.com/users/ywelsch/followers","following_url":"https://api.github.com/users/ywelsch/following{/other_user}","gists_url":"https://api.github.com/users/ywelsch/gists{/gist_id}","starred_url":"https://api.github.com/users/ywelsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywelsch/subscriptions","organizations_url":"https://api.github.com/users/ywelsch/orgs","repos_url":"https://api.github.com/users/ywelsch/repos","events_url":"https://api.github.com/users/ywelsch/events{/privacy}","received_events_url":"https://api.github.com/users/ywelsch/received_events","type":"User","site_admin":false},"body":"can you make a separate PR with this change (+ corresponding assertions + test). This issue has caused build failures (see https://elasticsearch-ci.elastic.co/view/All/job/elastic+elasticsearch+zen2+feature-branch-periodic/16/testReport/junit/org.elasticsearch.client.transport/NodeDisconnectIT/testNotifyOnDisconnect/ ).","created_at":"2018-11-28T12:23:03Z","updated_at":"2018-11-28T12:23:03Z","html_url":"https://github.com/elastic/elasticsearch/pull/35737#discussion_r237061200","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/35737","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/237061200"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/35737#discussion_r237061200"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/35737"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/35737","id":232319801,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMzE5ODAx","html_url":"https://github.com/elastic/elasticsearch/pull/35737","diff_url":"https://github.com/elastic/elasticsearch/pull/35737.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/35737.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/35737","number":35737,"state":"open","locked":false,"title":"[Zen2] Support rolling upgrades from Zen1","user":{"login":"DaveCTurner","id":5058284,"node_id":"MDQ6VXNlcjUwNTgyODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5058284?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveCTurner","html_url":"https://github.com/DaveCTurner","followers_url":"https://api.github.com/users/DaveCTurner/followers","following_url":"https://api.github.com/users/DaveCTurner/following{/other_user}","gists_url":"https://api.github.com/users/DaveCTurner/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveCTurner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveCTurner/subscriptions","organizations_url":"https://api.github.com/users/DaveCTurner/orgs","repos_url":"https://api.github.com/users/DaveCTurner/repos","events_url":"https://api.github.com/users/DaveCTurner/events{/privacy}","received_events_url":"https://api.github.com/users/DaveCTurner/received_events","type":"User","site_admin":false},"body":"We support rolling upgrades from Zen1 by keeping the master as a Zen1 node\r\nuntil there are no more Zen1 nodes in the cluster, using the following\r\nprinciples:\r\n\r\n- Zen1 nodes will never vote for Zen2 nodes\r\n- Zen2 nodes will, while not bootstrapped, vote for Zen1 nodes\r\n- Zen2 nodes that were previously part of a mixed cluster will automatically\r\n  (and unsafely) bootstrap themselves when the last Zen1 node leaves.","created_at":"2018-11-20T13:37:16Z","updated_at":"2018-11-28T12:23:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6781fd008fbe6dab1d282a33d87af0cd4e7230d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":881394071,"node_id":"MDU6TGFiZWw4ODEzOTQwNzE=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Distributed/ZenDiscovery","name":":Distributed/ZenDiscovery","color":"0e8a16","default":false},{"id":23174,"node_id":"MDU6TGFiZWwyMzE3NA==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Eenhancement","name":">enhancement","color":"4a4ea8","default":false},{"id":130371191,"node_id":"MDU6TGFiZWwxMzAzNzExOTE=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/WIP","name":"WIP","color":"fef2c0","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/35737/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/35737/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/35737/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/a1e393fcdb03131ed735d8e8488515557603a86d","head":{"label":"DaveCTurner:2018-11-19-rolling-upgrade-to-zen2","ref":"2018-11-19-rolling-upgrade-to-zen2","sha":"a1e393fcdb03131ed735d8e8488515557603a86d","user":{"login":"DaveCTurner","id":5058284,"node_id":"MDQ6VXNlcjUwNTgyODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5058284?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveCTurner","html_url":"https://github.com/DaveCTurner","followers_url":"https://api.github.com/users/DaveCTurner/followers","following_url":"https://api.github.com/users/DaveCTurner/following{/other_user}","gists_url":"https://api.github.com/users/DaveCTurner/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveCTurner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveCTurner/subscriptions","organizations_url":"https://api.github.com/users/DaveCTurner/orgs","repos_url":"https://api.github.com/users/DaveCTurner/repos","events_url":"https://api.github.com/users/DaveCTurner/events{/privacy}","received_events_url":"https://api.github.com/users/DaveCTurner/received_events","type":"User","site_admin":false},"repo":{"id":104302209,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQzMDIyMDk=","name":"elasticsearch","full_name":"DaveCTurner/elasticsearch","private":false,"owner":{"login":"DaveCTurner","id":5058284,"node_id":"MDQ6VXNlcjUwNTgyODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5058284?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveCTurner","html_url":"https://github.com/DaveCTurner","followers_url":"https://api.github.com/users/DaveCTurner/followers","following_url":"https://api.github.com/users/DaveCTurner/following{/other_user}","gists_url":"https://api.github.com/users/DaveCTurner/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveCTurner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveCTurner/subscriptions","organizations_url":"https://api.github.com/users/DaveCTurner/orgs","repos_url":"https://api.github.com/users/DaveCTurner/repos","events_url":"https://api.github.com/users/DaveCTurner/events{/privacy}","received_events_url":"https://api.github.com/users/DaveCTurner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DaveCTurner/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/DaveCTurner/elasticsearch","forks_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/forks","keys_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/teams","hooks_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/events","assignees_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/tags","blobs_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/subscription","commits_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/merges","archive_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/downloads","issues_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/DaveCTurner/elasticsearch/deployments","created_at":"2017-09-21T04:38:01Z","updated_at":"2018-11-26T09:56:10Z","pushed_at":"2018-11-28T11:43:41Z","git_url":"git://github.com/DaveCTurner/elasticsearch.git","ssh_url":"git@github.com:DaveCTurner/elasticsearch.git","clone_url":"https://github.com/DaveCTurner/elasticsearch.git","svn_url":"https://github.com/DaveCTurner/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":530726,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:zen2","ref":"zen2","sha":"a68a46450bd040a46d9a947c073debad1c9cd895","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"node_id":"MDEwOlJlcG9zaXRvcnk1MDc3NzU=","name":"elasticsearch","full_name":"elastic/elasticsearch","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2018-11-28T12:01:16Z","pushed_at":"2018-11-28T12:05:08Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":534849,"stargazers_count":36367,"watchers_count":36367,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12301,"mirror_url":null,"archived":false,"open_issues_count":1812,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12301,"open_issues":1812,"watchers":36367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/35737"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/35737"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/35737"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/35737/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/35737/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/35737/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/a1e393fcdb03131ed735d8e8488515557603a86d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ywelsch"}}