{"action":"created","issue":{"url":"https://api.github.com/repos/GeoNet/delta/issues/273","repository_url":"https://api.github.com/repos/GeoNet/delta","labels_url":"https://api.github.com/repos/GeoNet/delta/issues/273/labels{/name}","comments_url":"https://api.github.com/repos/GeoNet/delta/issues/273/comments","events_url":"https://api.github.com/repos/GeoNet/delta/issues/273/events","html_url":"https://github.com/GeoNet/delta/pull/273","id":315002680,"number":273,"title":"add triggered field in streams file","user":{"login":"ozym","id":2042827,"avatar_url":"https://avatars3.githubusercontent.com/u/2042827?v=4","gravatar_id":"","url":"https://api.github.com/users/ozym","html_url":"https://github.com/ozym","followers_url":"https://api.github.com/users/ozym/followers","following_url":"https://api.github.com/users/ozym/following{/other_user}","gists_url":"https://api.github.com/users/ozym/gists{/gist_id}","starred_url":"https://api.github.com/users/ozym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ozym/subscriptions","organizations_url":"https://api.github.com/users/ozym/orgs","repos_url":"https://api.github.com/users/ozym/repos","events_url":"https://api.github.com/users/ozym/events{/privacy}","received_events_url":"https://api.github.com/users/ozym/received_events","type":"User","site_admin":false},"labels":[{"id":267411449,"url":"https://api.github.com/repos/GeoNet/delta/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"ozym","id":2042827,"avatar_url":"https://avatars3.githubusercontent.com/u/2042827?v=4","gravatar_id":"","url":"https://api.github.com/users/ozym","html_url":"https://github.com/ozym","followers_url":"https://api.github.com/users/ozym/followers","following_url":"https://api.github.com/users/ozym/following{/other_user}","gists_url":"https://api.github.com/users/ozym/gists{/gist_id}","starred_url":"https://api.github.com/users/ozym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ozym/subscriptions","organizations_url":"https://api.github.com/users/ozym/orgs","repos_url":"https://api.github.com/users/ozym/repos","events_url":"https://api.github.com/users/ozym/events{/privacy}","received_events_url":"https://api.github.com/users/ozym/received_events","type":"User","site_admin":false},"assignees":[{"login":"ozym","id":2042827,"avatar_url":"https://avatars3.githubusercontent.com/u/2042827?v=4","gravatar_id":"","url":"https://api.github.com/users/ozym","html_url":"https://github.com/ozym","followers_url":"https://api.github.com/users/ozym/followers","following_url":"https://api.github.com/users/ozym/following{/other_user}","gists_url":"https://api.github.com/users/ozym/gists{/gist_id}","starred_url":"https://api.github.com/users/ozym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ozym/subscriptions","organizations_url":"https://api.github.com/users/ozym/orgs","repos_url":"https://api.github.com/users/ozym/repos","events_url":"https://api.github.com/users/ozym/events{/privacy}","received_events_url":"https://api.github.com/users/ozym/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-04-17T10:39:33Z","updated_at":"2018-05-08T02:26:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/GeoNet/delta/pulls/273","html_url":"https://github.com/GeoNet/delta/pull/273","diff_url":"https://github.com/GeoNet/delta/pull/273.diff","patch_url":"https://github.com/GeoNet/delta/pull/273.patch"},"body":"@quiffman it was a little tricky to use the response (recorder / sensor) pair on its own to determine whether a stream was triggered or not.\r\n\r\nI've added an extra Boolean column (field) in the Streams file to indicate a triggered channel, or not. I've also updated the current streams file to match what would be given from the existing response files. This will allow us to retrospectively turn some trial streams into continuous, which we can't do now.\r\n\r\nI've built the full existing stations.xml file before and after these changes and they agree apart from the creation date as expected. But it would be good that this can be verified, the stationxml tool is the only one that uses this information.\r\n\r\n/cc @nbalfour "},"comment":{"url":"https://api.github.com/repos/GeoNet/delta/issues/comments/387264725","html_url":"https://github.com/GeoNet/delta/pull/273#issuecomment-387264725","issue_url":"https://api.github.com/repos/GeoNet/delta/issues/273","id":387264725,"user":{"login":"quiffman","id":1026117,"avatar_url":"https://avatars3.githubusercontent.com/u/1026117?v=4","gravatar_id":"","url":"https://api.github.com/users/quiffman","html_url":"https://github.com/quiffman","followers_url":"https://api.github.com/users/quiffman/followers","following_url":"https://api.github.com/users/quiffman/following{/other_user}","gists_url":"https://api.github.com/users/quiffman/gists{/gist_id}","starred_url":"https://api.github.com/users/quiffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quiffman/subscriptions","organizations_url":"https://api.github.com/users/quiffman/orgs","repos_url":"https://api.github.com/users/quiffman/repos","events_url":"https://api.github.com/users/quiffman/events{/privacy}","received_events_url":"https://api.github.com/users/quiffman/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T02:26:53Z","updated_at":"2018-05-08T02:26:53Z","author_association":"OWNER","body":"@nbalfour @salichon - I know we've spoken about this already, but can you just confirm that you're happy with this approach, please?\r\n\r\nUnfortunately, this PR fell off my radar and is now in conflict...\r\nAs I mentioned earlier, this really needs to be a \"stop-everything\" merge. Because it changes _every line_ in the `streams.csv` file and git/github struggles to manage that automatically."}}
{"actor":{"display_login":"quiffman"}}