{"action":"created","issue":{"url":"https://api.github.com/repos/CatchRelease/arbor/issues/49","repository_url":"https://api.github.com/repos/CatchRelease/arbor","labels_url":"https://api.github.com/repos/CatchRelease/arbor/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/CatchRelease/arbor/issues/49/comments","events_url":"https://api.github.com/repos/CatchRelease/arbor/issues/49/events","html_url":"https://github.com/CatchRelease/arbor/pull/49","id":389973789,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODQzMDcx","number":49,"title":"Extract Menu and MenuItem components","user":{"login":"dgalarza","id":105694,"node_id":"MDQ6VXNlcjEwNTY5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/105694?v=4","gravatar_id":"","url":"https://api.github.com/users/dgalarza","html_url":"https://github.com/dgalarza","followers_url":"https://api.github.com/users/dgalarza/followers","following_url":"https://api.github.com/users/dgalarza/following{/other_user}","gists_url":"https://api.github.com/users/dgalarza/gists{/gist_id}","starred_url":"https://api.github.com/users/dgalarza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgalarza/subscriptions","organizations_url":"https://api.github.com/users/dgalarza/orgs","repos_url":"https://api.github.com/users/dgalarza/repos","events_url":"https://api.github.com/users/dgalarza/events{/privacy}","received_events_url":"https://api.github.com/users/dgalarza/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-12-11T22:04:44Z","updated_at":"2018-12-12T20:30:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/CatchRelease/arbor/pulls/49","html_url":"https://github.com/CatchRelease/arbor/pull/49","diff_url":"https://github.com/CatchRelease/arbor/pull/49.diff","patch_url":"https://github.com/CatchRelease/arbor/pull/49.patch"},"body":"[#162292672]\r\n\r\n![image](https://user-images.githubusercontent.com/105694/49833209-cfd2f280-fd66-11e8-88af-20f5058931ac.png)\r\n\r\nStill to come in a future PR - keyboard navigation / accessibility."},"comment":{"url":"https://api.github.com/repos/CatchRelease/arbor/issues/comments/446732937","html_url":"https://github.com/CatchRelease/arbor/pull/49#issuecomment-446732937","issue_url":"https://api.github.com/repos/CatchRelease/arbor/issues/49","id":446732937,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjczMjkzNw==","user":{"login":"mayravherman","id":7792024,"node_id":"MDQ6VXNlcjc3OTIwMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7792024?v=4","gravatar_id":"","url":"https://api.github.com/users/mayravherman","html_url":"https://github.com/mayravherman","followers_url":"https://api.github.com/users/mayravherman/followers","following_url":"https://api.github.com/users/mayravherman/following{/other_user}","gists_url":"https://api.github.com/users/mayravherman/gists{/gist_id}","starred_url":"https://api.github.com/users/mayravherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayravherman/subscriptions","organizations_url":"https://api.github.com/users/mayravherman/orgs","repos_url":"https://api.github.com/users/mayravherman/repos","events_url":"https://api.github.com/users/mayravherman/events{/privacy}","received_events_url":"https://api.github.com/users/mayravherman/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T20:30:19Z","updated_at":"2018-12-12T20:30:19Z","author_association":"CONTRIBUTOR","body":"The popover is not automatically part of the menu. Menu is just a list of\nItems with keyboard focus and accessibility considerations. Popover is\ngeneric enough so we could still use it for popovers with a header,\ndescription, and action button. It holds onclick definitions and keyboard\nfocus. i.e. keyboard-down or space on any trigger opens the popover.\n\nThe Dropdown component is composed of Popover with content=Menu and\ntrigger=Button (implicitly set by wrapping a Button with Popover).\n\nOn Wed, Dec 12, 2018 at 3:22 PM Michael Carey <notifications@github.com>\nwrote:\n\n> On the menu navigation, I think it can wait but I definitely don't want\n> that story to get lost as it's pretty vital for a11y.\n>\n> When it comes to whether or not the popover is automatically part of the\n> menu, i'll defer to your judgement. I do think if we're not going to do\n> that, it makes sense to have our example show how best to set it up in a\n> way where it closes on item click so we don't get 10 different\n> implementations.\n>\n> —\n> You are receiving this because you were mentioned.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/CatchRelease/arbor/pull/49#issuecomment-446730578>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AHblmHI0t5jiqkGHoVMffbJgxl544myIks5u4WWHgaJpZM4ZOVAS>\n> .\n>\n-- \nMayrav Herman\n"}}
{"actor":{"display_login":"mayravherman"}}