{"action":"created","issue":{"url":"https://api.github.com/repos/cakephp/cakephp/issues/12746","repository_url":"https://api.github.com/repos/cakephp/cakephp","labels_url":"https://api.github.com/repos/cakephp/cakephp/issues/12746/labels{/name}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/12746/comments","events_url":"https://api.github.com/repos/cakephp/cakephp/issues/12746/events","html_url":"https://github.com/cakephp/cakephp/pull/12746","id":382697864,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMzQ0MzIx","number":12746,"title":"Include prefer lowest and simplify checks","user":{"login":"dereuromark","id":39854,"node_id":"MDQ6VXNlcjM5ODU0","avatar_url":"https://avatars0.githubusercontent.com/u/39854?v=4","gravatar_id":"","url":"https://api.github.com/users/dereuromark","html_url":"https://github.com/dereuromark","followers_url":"https://api.github.com/users/dereuromark/followers","following_url":"https://api.github.com/users/dereuromark/following{/other_user}","gists_url":"https://api.github.com/users/dereuromark/gists{/gist_id}","starred_url":"https://api.github.com/users/dereuromark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereuromark/subscriptions","organizations_url":"https://api.github.com/users/dereuromark/orgs","repos_url":"https://api.github.com/users/dereuromark/repos","events_url":"https://api.github.com/users/dereuromark/events{/privacy}","received_events_url":"https://api.github.com/users/dereuromark/received_events","type":"User","site_admin":false},"labels":[{"id":60506670,"node_id":"MDU6TGFiZWw2MDUwNjY3MA==","url":"https://api.github.com/repos/cakephp/cakephp/labels/testing","name":"testing","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp/milestones/189","html_url":"https://github.com/cakephp/cakephp/milestone/189","labels_url":"https://api.github.com/repos/cakephp/cakephp/milestones/189/labels","id":3940715,"node_id":"MDk6TWlsZXN0b25lMzk0MDcxNQ==","number":189,"title":"3.7.3","description":"Bugfixes for 3.7","creator":{"login":"markstory","id":24086,"node_id":"MDQ6VXNlcjI0MDg2","avatar_url":"https://avatars3.githubusercontent.com/u/24086?v=4","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":4,"state":"open","created_at":"2019-01-04T03:20:24Z","updated_at":"2019-01-04T14:47:21Z","due_on":"2019-01-19T08:00:00Z","closed_at":null},"comments":12,"created_at":"2018-11-20T14:49:43Z","updated_at":"2019-01-04T17:18:58Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/12746","html_url":"https://github.com/cakephp/cakephp/pull/12746","diff_url":"https://github.com/cakephp/cakephp/pull/12746.diff","patch_url":"https://github.com/cakephp/cakephp/pull/12746.patch"},"body":"We have way too many jobs IMO, I think we can cut down a bit on the matrix of all PHP versions vs all DB types. Usually testing min and max should be enough between php versions.\r\nBut I dont want to touch too much\r\n\r\nFor now:\r\n- Simplify checks together\r\n- Add prefer lowest as we have more and more dependencies in core, and as such min requirements should also be tested.\r\n\r\nThis way the current job count doesnt increase.\r\nCS on top of phpstan is fair IMO as the stickler auto-fixes them now anyway.\r\nSo having a combined \"checks\" run seems like a pragmatic way moving forward.\r\n"},"comment":{"url":"https://api.github.com/repos/cakephp/cakephp/issues/comments/451508369","html_url":"https://github.com/cakephp/cakephp/pull/12746#issuecomment-451508369","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/12746","id":451508369,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTUwODM2OQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2019-01-04T17:18:58Z","updated_at":"2019-01-04T17:18:58Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/cakephp/cakephp/pull/12746?src=pr&el=h1) Report\n> Merging [#12746](https://codecov.io/gh/cakephp/cakephp/pull/12746?src=pr&el=desc) into [master](https://codecov.io/gh/cakephp/cakephp/commit/0be30d0c02cf955e58fedb2d47d8264e38342820?src=pr&el=desc) will **increase** coverage by `0.57%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/cakephp/cakephp/pull/12746/graphs/tree.svg?width=650&token=Mqp2cXjYwN&height=150&src=pr)](https://codecov.io/gh/cakephp/cakephp/pull/12746?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master   #12746      +/-   ##\n============================================\n+ Coverage     90.42%      91%   +0.57%     \n  Complexity    14043    14043              \n============================================\n  Files           522      522              \n  Lines         36121    36113       -8     \n============================================\n+ Hits          32663    32864     +201     \n+ Misses         3458     3249     -209\n```\n\n\n| [Impacted Files](https://codecov.io/gh/cakephp/cakephp/pull/12746?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [src/Http/Session.php](https://codecov.io/gh/cakephp/cakephp/pull/12746/diff?src=pr&el=tree#diff-c3JjL0h0dHAvU2Vzc2lvbi5waHA=) | `75.8% <0%> (-0.54%)` | `100% <0%> (ø)` | |\n| [src/Database/Schema/MysqlSchema.php](https://codecov.io/gh/cakephp/cakephp/pull/12746/diff?src=pr&el=tree#diff-c3JjL0RhdGFiYXNlL1NjaGVtYS9NeXNxbFNjaGVtYS5waHA=) | `78.98% <0%> (+0.23%)` | `115% <0%> (ø)` | :arrow_down: |\n| [src/Http/Client/Adapter/Curl.php](https://codecov.io/gh/cakephp/cakephp/pull/12746/diff?src=pr&el=tree#diff-c3JjL0h0dHAvQ2xpZW50L0FkYXB0ZXIvQ3VybC5waHA=) | `89.85% <0%> (+0.3%)` | `20% <0%> (ø)` | :arrow_down: |\n| [src/Database/Schema/SqlserverSchema.php](https://codecov.io/gh/cakephp/cakephp/pull/12746/diff?src=pr&el=tree#diff-c3JjL0RhdGFiYXNlL1NjaGVtYS9TcWxzZXJ2ZXJTY2hlbWEucGhw) | `74.36% <0%> (+0.31%)` | `112% <0%> (ø)` | :arrow_down: |\n| [src/Utility/Text.php](https://codecov.io/gh/cakephp/cakephp/pull/12746/diff?src=pr&el=tree#diff-c3JjL1V0aWxpdHkvVGV4dC5waHA=) | `98.5% <0%> (+0.42%)` | `163% <0%> (ø)` | :arrow_down: |\n| [src/View/Helper/PaginatorHelper.php](https://codecov.io/gh/cakephp/cakephp/pull/12746/diff?src=pr&el=tree#diff-c3JjL1ZpZXcvSGVscGVyL1BhZ2luYXRvckhlbHBlci5waHA=) | `99.3% <0%> (+0.46%)` | `164% <0%> (ø)` | :arrow_down: |\n| [src/Utility/Hash.php](https://codecov.io/gh/cakephp/cakephp/pull/12746/diff?src=pr&el=tree#diff-c3JjL1V0aWxpdHkvSGFzaC5waHA=) | `97.7% <0%> (+0.62%)` | `247% <0%> (ø)` | :arrow_down: |\n| [src/Shell/I18nShell.php](https://codecov.io/gh/cakephp/cakephp/pull/12746/diff?src=pr&el=tree#diff-c3JjL1NoZWxsL0kxOG5TaGVsbC5waHA=) | `55% <0%> (+0.9%)` | `13% <0%> (ø)` | :arrow_down: |\n| [src/View/Helper/FormHelper.php](https://codecov.io/gh/cakephp/cakephp/pull/12746/diff?src=pr&el=tree#diff-c3JjL1ZpZXcvSGVscGVyL0Zvcm1IZWxwZXIucGhw) | `95.25% <0%> (+1.03%)` | `384% <0%> (ø)` | :arrow_down: |\n| [src/Http/Client/Auth/Oauth.php](https://codecov.io/gh/cakephp/cakephp/pull/12746/diff?src=pr&el=tree#diff-c3JjL0h0dHAvQ2xpZW50L0F1dGgvT2F1dGgucGhw) | `91.78% <0%> (+2.05%)` | `40% <0%> (ø)` | :arrow_down: |\n| ... and [6 more](https://codecov.io/gh/cakephp/cakephp/pull/12746/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/cakephp/cakephp/pull/12746?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/cakephp/cakephp/pull/12746?src=pr&el=footer). Last update [0be30d0...3487401](https://codecov.io/gh/cakephp/cakephp/pull/12746?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}