{"action":"created","issue":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/1850","repository_url":"https://api.github.com/repos/DivanteLtd/vue-storefront","labels_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/1850/labels{/name}","comments_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/1850/comments","events_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/1850/events","html_url":"https://github.com/DivanteLtd/vue-storefront/pull/1850","id":369307797,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjgxNzc4","number":1850,"title":"Sending emails is done through vs-api","user":{"login":"akbarik","id":15943863,"node_id":"MDQ6VXNlcjE1OTQzODYz","avatar_url":"https://avatars2.githubusercontent.com/u/15943863?v=4","gravatar_id":"","url":"https://api.github.com/users/akbarik","html_url":"https://github.com/akbarik","followers_url":"https://api.github.com/users/akbarik/followers","following_url":"https://api.github.com/users/akbarik/following{/other_user}","gists_url":"https://api.github.com/users/akbarik/gists{/gist_id}","starred_url":"https://api.github.com/users/akbarik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akbarik/subscriptions","organizations_url":"https://api.github.com/users/akbarik/orgs","repos_url":"https://api.github.com/users/akbarik/repos","events_url":"https://api.github.com/users/akbarik/events{/privacy}","received_events_url":"https://api.github.com/users/akbarik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-11T21:14:33Z","updated_at":"2018-10-12T06:52:15Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/pulls/1850","html_url":"https://github.com/DivanteLtd/vue-storefront/pull/1850","diff_url":"https://github.com/DivanteLtd/vue-storefront/pull/1850.diff","patch_url":"https://github.com/DivanteLtd/vue-storefront/pull/1850.patch"},"body":"### Related issues\r\n\r\nhttps://github.com/DivanteLtd/vue-storefront/issues/1812\r\n\r\n### Short description and why it's useful\r\n\r\nThere's a new endpoint in vs-api that send emails using nodemailer library. Now frontend doesn't rely on customer's mail application, it just sends data to vs-api which handles email sending. New module called \"mailer\" has been created for this. In config file one can define the email address and need for confirmation.\r\n\r\n### Upgrade Notes and Changelog\r\n\r\n- [x] No upgrade steps required (100% backward compatibility)\r\n- [ ] I've updated the [Upgrade notes](https://github.com/DivanteLtd/vue-storefront/blob/develop/doc/Upgrade%20notes.md) and [Changelog](https://github.com/DivanteLtd/vue-storefront/blob/develop/CHANGELOG.md) on how to port existing VS sites with this new feature\r\n\r\n### Contribution and curently important rules acceptance\r\n\r\n- [x] I read and followed [contribution rules](https://github.com/DivanteLtd/vue-storefront/blob/master/CONTRIBUTING.md)\r\n- [x] I read the [TypeScript Action Plan](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/TypeScript%20Action%20Plan.md) and adjusted my PR according to it\r\n- [x] I read about [Vue Storefront Modules](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/api-modules/about-modules.md) and [refactoring plan for them](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/api-modules/refactoring-to-modules.md)\r\n"},"comment":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/comments/429223473","html_url":"https://github.com/DivanteLtd/vue-storefront/pull/1850#issuecomment-429223473","issue_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/1850","id":429223473,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTIyMzQ3Mw==","user":{"login":"pkarw","id":211899,"node_id":"MDQ6VXNlcjIxMTg5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/211899?v=4","gravatar_id":"","url":"https://api.github.com/users/pkarw","html_url":"https://github.com/pkarw","followers_url":"https://api.github.com/users/pkarw/followers","following_url":"https://api.github.com/users/pkarw/following{/other_user}","gists_url":"https://api.github.com/users/pkarw/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarw/subscriptions","organizations_url":"https://api.github.com/users/pkarw/orgs","repos_url":"https://api.github.com/users/pkarw/repos","events_url":"https://api.github.com/users/pkarw/events{/privacy}","received_events_url":"https://api.github.com/users/pkarw/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T06:52:15Z","updated_at":"2018-10-12T06:52:15Z","author_association":"COLLABORATOR","body":"Thanks @akbarik! We just need to make it more secure - please check the comment in the API PR"}}
{"actor":{"display_login":"pkarw"}}