{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments/243982600","pull_request_review_id":187878877,"id":243982600,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzk4MjYwMA==","diff_hunk":"@@ -121,6 +138,10 @@ else if (!result.containsKey(AvailableSettings.USE_NEW_ID_GENERATOR_MAPPINGS)) {\n \t\t}\n \t}\n \n+\tprivate void applyArchiveScanner(Map<String, Object> result) {\n+\t\tresult.put(AvailableSettings.SCANNER, this.archiveScanner);","path":"spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/orm/jpa/HibernateProperties.java","position":50,"original_position":50,"commit_id":"46c9a7b201fa77d17904f406601f66273a2efce8","original_commit_id":"46c9a7b201fa77d17904f406601f66273a2efce8","user":{"login":"snicoll","id":490484,"node_id":"MDQ6VXNlcjQ5MDQ4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/490484?v=4","gravatar_id":"","url":"https://api.github.com/users/snicoll","html_url":"https://github.com/snicoll","followers_url":"https://api.github.com/users/snicoll/followers","following_url":"https://api.github.com/users/snicoll/following{/other_user}","gists_url":"https://api.github.com/users/snicoll/gists{/gist_id}","starred_url":"https://api.github.com/users/snicoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snicoll/subscriptions","organizations_url":"https://api.github.com/users/snicoll/orgs","repos_url":"https://api.github.com/users/snicoll/repos","events_url":"https://api.github.com/users/snicoll/events{/privacy}","received_events_url":"https://api.github.com/users/snicoll/received_events","type":"User","site_admin":false},"body":"That's not checking if a user has set the property","created_at":"2018-12-26T11:15:54Z","updated_at":"2018-12-26T11:16:32Z","html_url":"https://github.com/spring-projects/spring-boot/pull/15565#discussion_r243982600","pull_request_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/15565","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments/243982600"},"html":{"href":"https://github.com/spring-projects/spring-boot/pull/15565#discussion_r243982600"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/15565"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/15565","id":240875576,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwODc1NTc2","html_url":"https://github.com/spring-projects/spring-boot/pull/15565","diff_url":"https://github.com/spring-projects/spring-boot/pull/15565.diff","patch_url":"https://github.com/spring-projects/spring-boot/pull/15565.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/15565","number":15565,"state":"open","locked":false,"title":"Consider disable Hibernate entity scanning for default JPA setup","user":{"login":"ayudovin","id":34862741,"node_id":"MDQ6VXNlcjM0ODYyNzQx","avatar_url":"https://avatars1.githubusercontent.com/u/34862741?v=4","gravatar_id":"","url":"https://api.github.com/users/ayudovin","html_url":"https://github.com/ayudovin","followers_url":"https://api.github.com/users/ayudovin/followers","following_url":"https://api.github.com/users/ayudovin/following{/other_user}","gists_url":"https://api.github.com/users/ayudovin/gists{/gist_id}","starred_url":"https://api.github.com/users/ayudovin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayudovin/subscriptions","organizations_url":"https://api.github.com/users/ayudovin/orgs","repos_url":"https://api.github.com/users/ayudovin/repos","events_url":"https://api.github.com/users/ayudovin/events{/privacy}","received_events_url":"https://api.github.com/users/ayudovin/received_events","type":"User","site_admin":false},"body":"this [enhancement](https://github.com/spring-projects/spring-boot/issues/15321) ","created_at":"2018-12-25T13:48:06Z","updated_at":"2018-12-26T11:16:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e4e7f93632ce8d6d4febc7a6ea3aa1cf6afe22d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":97741072,"node_id":"MDU6TGFiZWw5Nzc0MTA3Mg==","url":"https://api.github.com/repos/spring-projects/spring-boot/labels/status:%20waiting-for-feedback","name":"status: waiting-for-feedback","color":"fef2c0","default":false},{"id":293438798,"node_id":"MDU6TGFiZWwyOTM0Mzg3OTg=","url":"https://api.github.com/repos/spring-projects/spring-boot/labels/status:%20waiting-for-triage","name":"status: waiting-for-triage","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/15565/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/15565/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/15565/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-boot/statuses/46c9a7b201fa77d17904f406601f66273a2efce8","head":{"label":"ayudovin:hibernate-entity-scanning","ref":"hibernate-entity-scanning","sha":"46c9a7b201fa77d17904f406601f66273a2efce8","user":{"login":"ayudovin","id":34862741,"node_id":"MDQ6VXNlcjM0ODYyNzQx","avatar_url":"https://avatars1.githubusercontent.com/u/34862741?v=4","gravatar_id":"","url":"https://api.github.com/users/ayudovin","html_url":"https://github.com/ayudovin","followers_url":"https://api.github.com/users/ayudovin/followers","following_url":"https://api.github.com/users/ayudovin/following{/other_user}","gists_url":"https://api.github.com/users/ayudovin/gists{/gist_id}","starred_url":"https://api.github.com/users/ayudovin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayudovin/subscriptions","organizations_url":"https://api.github.com/users/ayudovin/orgs","repos_url":"https://api.github.com/users/ayudovin/repos","events_url":"https://api.github.com/users/ayudovin/events{/privacy}","received_events_url":"https://api.github.com/users/ayudovin/received_events","type":"User","site_admin":false},"repo":{"id":141891149,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE4OTExNDk=","name":"spring-boot","full_name":"ayudovin/spring-boot","private":false,"owner":{"login":"ayudovin","id":34862741,"node_id":"MDQ6VXNlcjM0ODYyNzQx","avatar_url":"https://avatars1.githubusercontent.com/u/34862741?v=4","gravatar_id":"","url":"https://api.github.com/users/ayudovin","html_url":"https://github.com/ayudovin","followers_url":"https://api.github.com/users/ayudovin/followers","following_url":"https://api.github.com/users/ayudovin/following{/other_user}","gists_url":"https://api.github.com/users/ayudovin/gists{/gist_id}","starred_url":"https://api.github.com/users/ayudovin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayudovin/subscriptions","organizations_url":"https://api.github.com/users/ayudovin/orgs","repos_url":"https://api.github.com/users/ayudovin/repos","events_url":"https://api.github.com/users/ayudovin/events{/privacy}","received_events_url":"https://api.github.com/users/ayudovin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ayudovin/spring-boot","description":"Spring Boot","fork":true,"url":"https://api.github.com/repos/ayudovin/spring-boot","forks_url":"https://api.github.com/repos/ayudovin/spring-boot/forks","keys_url":"https://api.github.com/repos/ayudovin/spring-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ayudovin/spring-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ayudovin/spring-boot/teams","hooks_url":"https://api.github.com/repos/ayudovin/spring-boot/hooks","issue_events_url":"https://api.github.com/repos/ayudovin/spring-boot/issues/events{/number}","events_url":"https://api.github.com/repos/ayudovin/spring-boot/events","assignees_url":"https://api.github.com/repos/ayudovin/spring-boot/assignees{/user}","branches_url":"https://api.github.com/repos/ayudovin/spring-boot/branches{/branch}","tags_url":"https://api.github.com/repos/ayudovin/spring-boot/tags","blobs_url":"https://api.github.com/repos/ayudovin/spring-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ayudovin/spring-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ayudovin/spring-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ayudovin/spring-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ayudovin/spring-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/ayudovin/spring-boot/languages","stargazers_url":"https://api.github.com/repos/ayudovin/spring-boot/stargazers","contributors_url":"https://api.github.com/repos/ayudovin/spring-boot/contributors","subscribers_url":"https://api.github.com/repos/ayudovin/spring-boot/subscribers","subscription_url":"https://api.github.com/repos/ayudovin/spring-boot/subscription","commits_url":"https://api.github.com/repos/ayudovin/spring-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ayudovin/spring-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ayudovin/spring-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ayudovin/spring-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ayudovin/spring-boot/contents/{+path}","compare_url":"https://api.github.com/repos/ayudovin/spring-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ayudovin/spring-boot/merges","archive_url":"https://api.github.com/repos/ayudovin/spring-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ayudovin/spring-boot/downloads","issues_url":"https://api.github.com/repos/ayudovin/spring-boot/issues{/number}","pulls_url":"https://api.github.com/repos/ayudovin/spring-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/ayudovin/spring-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/ayudovin/spring-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ayudovin/spring-boot/labels{/name}","releases_url":"https://api.github.com/repos/ayudovin/spring-boot/releases{/id}","deployments_url":"https://api.github.com/repos/ayudovin/spring-boot/deployments","created_at":"2018-07-22T11:46:48Z","updated_at":"2018-12-25T10:43:13Z","pushed_at":"2018-12-26T10:09:18Z","git_url":"git://github.com/ayudovin/spring-boot.git","ssh_url":"git@github.com:ayudovin/spring-boot.git","clone_url":"https://github.com/ayudovin/spring-boot.git","svn_url":"https://github.com/ayudovin/spring-boot","homepage":"https://spring.io/projects/spring-boot","size":84923,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"c9f08605633bb31dceea817fb3c70c61f903b985","user":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":6296790,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjk2Nzkw","name":"spring-boot","full_name":"spring-projects/spring-boot","private":false,"owner":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spring-projects/spring-boot","description":"Spring Boot","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-boot","forks_url":"https://api.github.com/repos/spring-projects/spring-boot/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-boot/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-boot/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-boot/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-boot/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-boot/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-boot/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-boot/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-boot/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-boot/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-boot/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-boot/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-boot/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-boot/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-boot/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-boot/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-boot/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-boot/deployments","created_at":"2012-10-19T15:02:57Z","updated_at":"2018-12-26T09:58:59Z","pushed_at":"2018-12-26T10:09:26Z","git_url":"git://github.com/spring-projects/spring-boot.git","ssh_url":"git@github.com:spring-projects/spring-boot.git","clone_url":"https://github.com/spring-projects/spring-boot.git","svn_url":"https://github.com/spring-projects/spring-boot","homepage":"https://spring.io/projects/spring-boot","size":84959,"stargazers_count":32467,"watchers_count":32467,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22133,"mirror_url":null,"archived":false,"open_issues_count":398,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22133,"open_issues":398,"watchers":32467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/15565"},"html":{"href":"https://github.com/spring-projects/spring-boot/pull/15565"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-boot/issues/15565"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-boot/issues/15565/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/15565/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/15565/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-boot/statuses/46c9a7b201fa77d17904f406601f66273a2efce8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"snicoll"}}