{"action":"created","comment":{"url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments/237240188","pull_request_review_id":179491296,"id":237240188,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzI0MDE4OA==","diff_hunk":"@@ -0,0 +1,72 @@\n+/*\n+ * All definitions are based on the specification for SPDX expressions:\n+ * https://spdx.org/spdx-specification-21-web-version#h.jxpfx0ykyb60\n+ */\n+\n+grammar SpdxExpression;\n+\n+@header {\n+package com.here.ort.model.spdx;\n+}\n+\n+/*\n+ * Parser Rules\n+ */\n+\n+licenseRefExpression\n+    :\n+    LICENSEREF\n+    ;\n+\n+licenseExceptionExpression\n+    :\n+    IDSTRING\n+    ;\n+\n+licenseIdExpression\n+    :\n+    IDSTRING\n+    (PLUS)?\n+    ;\n+\n+simpleExpression\n+    :\n+    licenseRefExpression\n+    | licenseIdExpression\n+    ;\n+\n+compoundExpression\n+    :\n+    simpleExpression\n+    | simpleExpression WITH licenseExceptionExpression\n+    | compoundExpression AND compoundExpression\n+    | compoundExpression OR compoundExpression\n+    | OPEN compoundExpression CLOSE\n+    ;\n+\n+licenseExpression\n+    :\n+    (simpleExpression | compoundExpression)\n+    EOF\n+    ;\n+\n+","path":"model/src/main/antlr/com/here/ort/model/spdx/SpdxExpression.g4","position":53,"original_position":53,"commit_id":"c2fa16539519ccfff6bc745ef5122bd878bf14e6","original_commit_id":"c2fa16539519ccfff6bc745ef5122bd878bf14e6","user":{"login":"sschuberth","id":349154,"node_id":"MDQ6VXNlcjM0OTE1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/349154?v=4","gravatar_id":"","url":"https://api.github.com/users/sschuberth","html_url":"https://github.com/sschuberth","followers_url":"https://api.github.com/users/sschuberth/followers","following_url":"https://api.github.com/users/sschuberth/following{/other_user}","gists_url":"https://api.github.com/users/sschuberth/gists{/gist_id}","starred_url":"https://api.github.com/users/sschuberth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sschuberth/subscriptions","organizations_url":"https://api.github.com/users/sschuberth/orgs","repos_url":"https://api.github.com/users/sschuberth/repos","events_url":"https://api.github.com/users/sschuberth/events{/privacy}","received_events_url":"https://api.github.com/users/sschuberth/received_events","type":"User","site_admin":false},"body":"Nit: Duplicate blank line.","created_at":"2018-11-28T20:01:30Z","updated_at":"2018-11-28T20:11:15Z","html_url":"https://github.com/heremaps/oss-review-toolkit/pull/1072#discussion_r237240188","pull_request_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/1072","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments/237240188"},"html":{"href":"https://github.com/heremaps/oss-review-toolkit/pull/1072#discussion_r237240188"},"pull_request":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/1072"}}},"pull_request":{"url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/1072","id":234328606,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzI4NjA2","html_url":"https://github.com/heremaps/oss-review-toolkit/pull/1072","diff_url":"https://github.com/heremaps/oss-review-toolkit/pull/1072.diff","patch_url":"https://github.com/heremaps/oss-review-toolkit/pull/1072.patch","issue_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/1072","number":1072,"state":"open","locked":false,"title":"model: Add a parser for SPDX expressions","user":{"login":"mnonnenmacher","id":2741977,"node_id":"MDQ6VXNlcjI3NDE5Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/2741977?v=4","gravatar_id":"","url":"https://api.github.com/users/mnonnenmacher","html_url":"https://github.com/mnonnenmacher","followers_url":"https://api.github.com/users/mnonnenmacher/followers","following_url":"https://api.github.com/users/mnonnenmacher/following{/other_user}","gists_url":"https://api.github.com/users/mnonnenmacher/gists{/gist_id}","starred_url":"https://api.github.com/users/mnonnenmacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnonnenmacher/subscriptions","organizations_url":"https://api.github.com/users/mnonnenmacher/orgs","repos_url":"https://api.github.com/users/mnonnenmacher/repos","events_url":"https://api.github.com/users/mnonnenmacher/events{/privacy}","received_events_url":"https://api.github.com/users/mnonnenmacher/received_events","type":"User","site_admin":false},"body":"Implement a parser for SPDX expressions as specified in [1] using ANTLR\r\n[2]. This is a prerequisite for implementing the evaluation of SPDX\r\nexpressions which will be used by upcoming features like evaluating the\r\ncompatibility of a license choice with an SPDX expression.\r\n\r\n[1] https://spdx.org/spdx-specification-21-web-version#h.jxpfx0ykyb60\r\n[2] https://www.antlr.org/\r\n\r\nSigned-off-by: Martin Nonnenmacher <martin.nonnenmacher@here.com>\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/heremaps/oss-review-toolkit/1072)\n<!-- Reviewable:end -->\n","created_at":"2018-11-28T15:52:55Z","updated_at":"2018-11-28T20:11:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc1caaca45e186bb41b3c05039766accfc4fad61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/1072/commits","review_comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/1072/comments","review_comment_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/1072/comments","statuses_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/c2fa16539519ccfff6bc745ef5122bd878bf14e6","head":{"label":"heremaps:spdx-expression-parser","ref":"spdx-expression-parser","sha":"c2fa16539519ccfff6bc745ef5122bd878bf14e6","user":{"login":"heremaps","id":2835506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzU1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"repo":{"id":107540288,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1NDAyODg=","name":"oss-review-toolkit","full_name":"heremaps/oss-review-toolkit","private":false,"owner":{"login":"heremaps","id":2835506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzU1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/heremaps/oss-review-toolkit","description":"A suite of tools to assist with reviewing Open Source Software dependencies.","fork":false,"url":"https://api.github.com/repos/heremaps/oss-review-toolkit","forks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/forks","keys_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/teams","hooks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/hooks","issue_events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/events","assignees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/tags","blobs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/languages","stargazers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/stargazers","contributors_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contributors","subscribers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscribers","subscription_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscription","commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/merges","archive_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/downloads","issues_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/deployments","created_at":"2017-10-19T11:59:49Z","updated_at":"2018-11-28T08:53:18Z","pushed_at":"2018-11-28T16:04:38Z","git_url":"git://github.com/heremaps/oss-review-toolkit.git","ssh_url":"git@github.com:heremaps/oss-review-toolkit.git","clone_url":"https://github.com/heremaps/oss-review-toolkit.git","svn_url":"https://github.com/heremaps/oss-review-toolkit","homepage":null,"size":57054,"stargazers_count":117,"watchers_count":117,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":55,"watchers":117,"default_branch":"master"}},"base":{"label":"heremaps:master","ref":"master","sha":"3630ec83ff037d4bf91bac24980cb02ef4919f2d","user":{"login":"heremaps","id":2835506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzU1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"repo":{"id":107540288,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1NDAyODg=","name":"oss-review-toolkit","full_name":"heremaps/oss-review-toolkit","private":false,"owner":{"login":"heremaps","id":2835506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzU1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/heremaps/oss-review-toolkit","description":"A suite of tools to assist with reviewing Open Source Software dependencies.","fork":false,"url":"https://api.github.com/repos/heremaps/oss-review-toolkit","forks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/forks","keys_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/teams","hooks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/hooks","issue_events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/events","assignees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/tags","blobs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/languages","stargazers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/stargazers","contributors_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contributors","subscribers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscribers","subscription_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscription","commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/merges","archive_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/downloads","issues_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/deployments","created_at":"2017-10-19T11:59:49Z","updated_at":"2018-11-28T08:53:18Z","pushed_at":"2018-11-28T16:04:38Z","git_url":"git://github.com/heremaps/oss-review-toolkit.git","ssh_url":"git@github.com:heremaps/oss-review-toolkit.git","clone_url":"https://github.com/heremaps/oss-review-toolkit.git","svn_url":"https://github.com/heremaps/oss-review-toolkit","homepage":null,"size":57054,"stargazers_count":117,"watchers_count":117,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":55,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/1072"},"html":{"href":"https://github.com/heremaps/oss-review-toolkit/pull/1072"},"issue":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/1072"},"comments":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/1072/comments"},"review_comments":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/1072/comments"},"review_comment":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/1072/commits"},"statuses":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/c2fa16539519ccfff6bc745ef5122bd878bf14e6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sschuberth"}}