{"action":"created","issue":{"url":"https://api.github.com/repos/cloudfoundry-incubator/cf-operator/issues/29","repository_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-operator","labels_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-operator/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-operator/issues/29/comments","events_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-operator/issues/29/events","html_url":"https://github.com/cloudfoundry-incubator/cf-operator/pull/29","id":388402789,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2Njc2MTIz","number":29,"title":"Refactor dir structure and Dockerfile","user":{"login":"qu1queee","id":4812480,"node_id":"MDQ6VXNlcjQ4MTI0ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/4812480?v=4","gravatar_id":"","url":"https://api.github.com/users/qu1queee","html_url":"https://github.com/qu1queee","followers_url":"https://api.github.com/users/qu1queee/followers","following_url":"https://api.github.com/users/qu1queee/following{/other_user}","gists_url":"https://api.github.com/users/qu1queee/gists{/gist_id}","starred_url":"https://api.github.com/users/qu1queee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qu1queee/subscriptions","organizations_url":"https://api.github.com/users/qu1queee/orgs","repos_url":"https://api.github.com/users/qu1queee/repos","events_url":"https://api.github.com/users/qu1queee/events{/privacy}","received_events_url":"https://api.github.com/users/qu1queee/received_events","type":"User","site_admin":false},"labels":[{"id":1109201428,"node_id":"MDU6TGFiZWwxMTA5MjAxNDI4","url":"https://api.github.com/repos/cloudfoundry-incubator/cf-operator/labels/scheduled","name":"scheduled","color":"BFD4F2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-06T21:21:01Z","updated_at":"2018-12-07T12:03:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cloudfoundry-incubator/cf-operator/pulls/29","html_url":"https://github.com/cloudfoundry-incubator/cf-operator/pull/29","diff_url":"https://github.com/cloudfoundry-incubator/cf-operator/pull/29.diff","patch_url":"https://github.com/cloudfoundry-incubator/cf-operator/pull/29.patch"},"body":"1. Refactor the location of the `main.go` and cobra classes\r\n   This include:\r\n   - move `main.go` inside `cmd/cf-operator`, in order to follow\r\n     generic project layout standards.\r\n   - place the cobra classes `root.go` and `version.go` under \r\n    `cmd/internal`. So, they will not be next to `main.go`.\r\n   - Refactor any reference towards the old dir locations.\r\n\r\n2. The `cfcontainerization/cf-operator` Dockerfile, can be build by\r\n   using the multistage, where in the first stage we build the\r\n   cf-operator binary, and then in the final stage we insert them.\r\n   This should improve:\r\n   - No need to run make/build before make/image.\r\n   - In the future, if more golang repos are needed inside the image,\r\n     it should improve the building image time."},"comment":{"url":"https://api.github.com/repos/cloudfoundry-incubator/cf-operator/issues/comments/445212539","html_url":"https://github.com/cloudfoundry-incubator/cf-operator/pull/29#issuecomment-445212539","issue_url":"https://api.github.com/repos/cloudfoundry-incubator/cf-operator/issues/29","id":445212539,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTIxMjUzOQ==","user":{"login":"manno","id":393653,"node_id":"MDQ6VXNlcjM5MzY1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/393653?v=4","gravatar_id":"","url":"https://api.github.com/users/manno","html_url":"https://github.com/manno","followers_url":"https://api.github.com/users/manno/followers","following_url":"https://api.github.com/users/manno/following{/other_user}","gists_url":"https://api.github.com/users/manno/gists{/gist_id}","starred_url":"https://api.github.com/users/manno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manno/subscriptions","organizations_url":"https://api.github.com/users/manno/orgs","repos_url":"https://api.github.com/users/manno/repos","events_url":"https://api.github.com/users/manno/events{/privacy}","received_events_url":"https://api.github.com/users/manno/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T12:03:01Z","updated_at":"2018-12-07T12:03:01Z","author_association":"MEMBER","body":"Definitely makes sense to move the Dockerfile if it makes things easier with dockerhub. \r\n@aduffeck does this affect our Concourse pipelines?\r\n\r\nhttps://github.com/golang-standards doesn't convince me, but I'm always wary of things that look official, but are not. (I should put my vim config at github.com/default-vim/config for fun).\r\nI see no harm in moving main.go.\r\n\r\nAnyone else got opinions?"}}
{"actor":{"display_login":"manno"}}