{"action":"closed","number":8363,"pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/8363","id":174552009,"html_url":"https://github.com/librenms/librenms/pull/8363","diff_url":"https://github.com/librenms/librenms/pull/8363.diff","patch_url":"https://github.com/librenms/librenms/pull/8363.patch","issue_url":"https://api.github.com/repos/librenms/librenms/issues/8363","number":8363,"state":"closed","locked":false,"title":"Auto IPv6/IPv4 detection when adding host","user":{"login":"murrant","id":39462,"avatar_url":"https://avatars2.githubusercontent.com/u/39462?v=4","gravatar_id":"","url":"https://api.github.com/users/murrant","html_url":"https://github.com/murrant","followers_url":"https://api.github.com/users/murrant/followers","following_url":"https://api.github.com/users/murrant/following{/other_user}","gists_url":"https://api.github.com/users/murrant/gists{/gist_id}","starred_url":"https://api.github.com/users/murrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrant/subscriptions","organizations_url":"https://api.github.com/users/murrant/orgs","repos_url":"https://api.github.com/users/murrant/repos","events_url":"https://api.github.com/users/murrant/events{/privacy}","received_events_url":"https://api.github.com/users/murrant/received_events","type":"User","site_admin":false},"body":"Fallback to ipv4 if snmpd isn't listening on ipv6 (as our example configures)\r\nUpdate snmpd.conf example to listen on IPv6\r\nrefactor dnslookup() supports auto (ipv6 then ipv4) and hosts file for ipv4 at least.\r\nImprove layout in the device snmp settings page\r\n\r\nTested adding:\r\nipv4 only\r\ndual ipv4 listen only\r\ndual dual listen\r\n\r\n![image](https://user-images.githubusercontent.com/39462/37322271-88663662-264a-11e8-9987-9e085ba01379.png)\r\n\r\n\r\nDO NOT DELETE THIS TEXT\r\n\r\n#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n\r\n#### Testers\r\n\r\nIf you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`\r\n","created_at":"2018-03-13T03:54:44Z","updated_at":"2018-04-24T06:16:35Z","closed_at":"2018-04-24T06:16:35Z","merged_at":null,"merge_commit_sha":"da6edb1e7a5cba0eedf4c079123a778b35bbd1b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":301956724,"url":"https://api.github.com/repos/librenms/librenms/labels/Blocker%20:no_entry_sign:","name":"Blocker :no_entry_sign:","color":"000000","default":false},{"id":62946218,"url":"https://api.github.com/repos/librenms/librenms/labels/Enhancement","name":"Enhancement","color":"99ff33","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/librenms/librenms/pulls/8363/commits","review_comments_url":"https://api.github.com/repos/librenms/librenms/pulls/8363/comments","review_comment_url":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/8363/comments","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/99aced583dfafffd850b9431f55a30dd221dab27","head":{"label":"murrant:ipv6-auto","ref":"ipv6-auto","sha":"99aced583dfafffd850b9431f55a30dd221dab27","user":{"login":"murrant","id":39462,"avatar_url":"https://avatars2.githubusercontent.com/u/39462?v=4","gravatar_id":"","url":"https://api.github.com/users/murrant","html_url":"https://github.com/murrant","followers_url":"https://api.github.com/users/murrant/followers","following_url":"https://api.github.com/users/murrant/following{/other_user}","gists_url":"https://api.github.com/users/murrant/gists{/gist_id}","starred_url":"https://api.github.com/users/murrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrant/subscriptions","organizations_url":"https://api.github.com/users/murrant/orgs","repos_url":"https://api.github.com/users/murrant/repos","events_url":"https://api.github.com/users/murrant/events{/privacy}","received_events_url":"https://api.github.com/users/murrant/received_events","type":"User","site_admin":false},"repo":{"id":46134177,"name":"librenms","full_name":"murrant/librenms","owner":{"login":"murrant","id":39462,"avatar_url":"https://avatars2.githubusercontent.com/u/39462?v=4","gravatar_id":"","url":"https://api.github.com/users/murrant","html_url":"https://github.com/murrant","followers_url":"https://api.github.com/users/murrant/followers","following_url":"https://api.github.com/users/murrant/following{/other_user}","gists_url":"https://api.github.com/users/murrant/gists{/gist_id}","starred_url":"https://api.github.com/users/murrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrant/subscriptions","organizations_url":"https://api.github.com/users/murrant/orgs","repos_url":"https://api.github.com/users/murrant/repos","events_url":"https://api.github.com/users/murrant/events{/privacy}","received_events_url":"https://api.github.com/users/murrant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/murrant/librenms","description":"Community-based GPL-licensed network monitoring system","fork":true,"url":"https://api.github.com/repos/murrant/librenms","forks_url":"https://api.github.com/repos/murrant/librenms/forks","keys_url":"https://api.github.com/repos/murrant/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/murrant/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/murrant/librenms/teams","hooks_url":"https://api.github.com/repos/murrant/librenms/hooks","issue_events_url":"https://api.github.com/repos/murrant/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/murrant/librenms/events","assignees_url":"https://api.github.com/repos/murrant/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/murrant/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/murrant/librenms/tags","blobs_url":"https://api.github.com/repos/murrant/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/murrant/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/murrant/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/murrant/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/murrant/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/murrant/librenms/languages","stargazers_url":"https://api.github.com/repos/murrant/librenms/stargazers","contributors_url":"https://api.github.com/repos/murrant/librenms/contributors","subscribers_url":"https://api.github.com/repos/murrant/librenms/subscribers","subscription_url":"https://api.github.com/repos/murrant/librenms/subscription","commits_url":"https://api.github.com/repos/murrant/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/murrant/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/murrant/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/murrant/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/murrant/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/murrant/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/murrant/librenms/merges","archive_url":"https://api.github.com/repos/murrant/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/murrant/librenms/downloads","issues_url":"https://api.github.com/repos/murrant/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/murrant/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/murrant/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/murrant/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/murrant/librenms/labels{/name}","releases_url":"https://api.github.com/repos/murrant/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/murrant/librenms/deployments","created_at":"2015-11-13T16:39:59Z","updated_at":"2018-04-24T06:12:55Z","pushed_at":"2018-04-24T06:13:48Z","git_url":"git://github.com/murrant/librenms.git","ssh_url":"git@github.com:murrant/librenms.git","clone_url":"https://github.com/murrant/librenms.git","svn_url":"https://github.com/murrant/librenms","homepage":"http://www.librenms.org/","size":128524,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"librenms:master","ref":"master","sha":"e3d44c54d2493a842d4ddf1c2f57e7080f8a8011","user":{"login":"librenms","id":5791783,"avatar_url":"https://avatars2.githubusercontent.com/u/5791783?v=4","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"repo":{"id":13914116,"name":"librenms","full_name":"librenms/librenms","owner":{"login":"librenms","id":5791783,"avatar_url":"https://avatars2.githubusercontent.com/u/5791783?v=4","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/librenms/librenms","description":"Community-based GPL-licensed network monitoring system","fork":false,"url":"https://api.github.com/repos/librenms/librenms","forks_url":"https://api.github.com/repos/librenms/librenms/forks","keys_url":"https://api.github.com/repos/librenms/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/librenms/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/librenms/librenms/teams","hooks_url":"https://api.github.com/repos/librenms/librenms/hooks","issue_events_url":"https://api.github.com/repos/librenms/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/librenms/librenms/events","assignees_url":"https://api.github.com/repos/librenms/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/librenms/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/librenms/librenms/tags","blobs_url":"https://api.github.com/repos/librenms/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/librenms/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/librenms/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/librenms/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/librenms/librenms/languages","stargazers_url":"https://api.github.com/repos/librenms/librenms/stargazers","contributors_url":"https://api.github.com/repos/librenms/librenms/contributors","subscribers_url":"https://api.github.com/repos/librenms/librenms/subscribers","subscription_url":"https://api.github.com/repos/librenms/librenms/subscription","commits_url":"https://api.github.com/repos/librenms/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/librenms/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/librenms/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/librenms/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/librenms/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/librenms/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/librenms/librenms/merges","archive_url":"https://api.github.com/repos/librenms/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/librenms/librenms/downloads","issues_url":"https://api.github.com/repos/librenms/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/librenms/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/librenms/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/librenms/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/librenms/librenms/labels{/name}","releases_url":"https://api.github.com/repos/librenms/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/librenms/librenms/deployments","created_at":"2013-10-28T01:37:13Z","updated_at":"2018-04-24T02:55:59Z","pushed_at":"2018-04-24T06:14:00Z","git_url":"git://github.com/librenms/librenms.git","ssh_url":"git@github.com:librenms/librenms.git","clone_url":"https://github.com/librenms/librenms.git","svn_url":"https://github.com/librenms/librenms","homepage":"http://www.librenms.org/","size":128490,"stargazers_count":1012,"watchers_count":1012,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":800,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":800,"open_issues":72,"watchers":1012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/8363"},"html":{"href":"https://github.com/librenms/librenms/pull/8363"},"issue":{"href":"https://api.github.com/repos/librenms/librenms/issues/8363"},"comments":{"href":"https://api.github.com/repos/librenms/librenms/issues/8363/comments"},"review_comments":{"href":"https://api.github.com/repos/librenms/librenms/pulls/8363/comments"},"review_comment":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/librenms/librenms/pulls/8363/commits"},"statuses":{"href":"https://api.github.com/repos/librenms/librenms/statuses/99aced583dfafffd850b9431f55a30dd221dab27"}},"author_association":"MEMBER","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":14,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":143,"deletions":108,"changed_files":9}}
{"actor":{"display_login":"murrant"}}