{"action":"created","issue":{"url":"https://api.github.com/repos/stripe/stripe-php/issues/494","repository_url":"https://api.github.com/repos/stripe/stripe-php","labels_url":"https://api.github.com/repos/stripe/stripe-php/issues/494/labels{/name}","comments_url":"https://api.github.com/repos/stripe/stripe-php/issues/494/comments","events_url":"https://api.github.com/repos/stripe/stripe-php/issues/494/events","html_url":"https://github.com/stripe/stripe-php/pull/494","id":339908951,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDQ3NjU3","number":494,"title":"Enable HTTP/2 support","user":{"login":"ob-stripe","id":23086931,"node_id":"MDQ6VXNlcjIzMDg2OTMx","avatar_url":"https://avatars0.githubusercontent.com/u/23086931?v=4","gravatar_id":"","url":"https://api.github.com/users/ob-stripe","html_url":"https://github.com/ob-stripe","followers_url":"https://api.github.com/users/ob-stripe/followers","following_url":"https://api.github.com/users/ob-stripe/following{/other_user}","gists_url":"https://api.github.com/users/ob-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/ob-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ob-stripe/subscriptions","organizations_url":"https://api.github.com/users/ob-stripe/orgs","repos_url":"https://api.github.com/users/ob-stripe/repos","events_url":"https://api.github.com/users/ob-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/ob-stripe/received_events","type":"User","site_admin":false},"labels":[{"id":379315326,"node_id":"MDU6TGFiZWwzNzkzMTUzMjY=","url":"https://api.github.com/repos/stripe/stripe-php/labels/approved","name":"approved","color":"2DA239","default":false}],"state":"closed","locked":false,"assignee":{"login":"brandur-stripe","id":23105990,"node_id":"MDQ6VXNlcjIzMTA1OTkw","avatar_url":"https://avatars3.githubusercontent.com/u/23105990?v=4","gravatar_id":"","url":"https://api.github.com/users/brandur-stripe","html_url":"https://github.com/brandur-stripe","followers_url":"https://api.github.com/users/brandur-stripe/followers","following_url":"https://api.github.com/users/brandur-stripe/following{/other_user}","gists_url":"https://api.github.com/users/brandur-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/brandur-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandur-stripe/subscriptions","organizations_url":"https://api.github.com/users/brandur-stripe/orgs","repos_url":"https://api.github.com/users/brandur-stripe/repos","events_url":"https://api.github.com/users/brandur-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/brandur-stripe/received_events","type":"User","site_admin":false},"assignees":[{"login":"brandur-stripe","id":23105990,"node_id":"MDQ6VXNlcjIzMTA1OTkw","avatar_url":"https://avatars3.githubusercontent.com/u/23105990?v=4","gravatar_id":"","url":"https://api.github.com/users/brandur-stripe","html_url":"https://github.com/brandur-stripe","followers_url":"https://api.github.com/users/brandur-stripe/followers","following_url":"https://api.github.com/users/brandur-stripe/following{/other_user}","gists_url":"https://api.github.com/users/brandur-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/brandur-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandur-stripe/subscriptions","organizations_url":"https://api.github.com/users/brandur-stripe/orgs","repos_url":"https://api.github.com/users/brandur-stripe/repos","events_url":"https://api.github.com/users/brandur-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/brandur-stripe/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-07-10T16:04:04Z","updated_at":"2018-07-16T10:58:36Z","closed_at":"2018-07-11T08:16:21Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/stripe/stripe-php/pulls/494","html_url":"https://github.com/stripe/stripe-php/pull/494","diff_url":"https://github.com/stripe/stripe-php/pull/494.diff","patch_url":"https://github.com/stripe/stripe-php/pull/494.patch"},"body":"r? @brandur-stripe \r\ncc @stripe/api-libraries \r\n\r\nThe API doesn't support HTTP/2 yet, but it will Soon™.\r\n\r\nThis should be safe to merge now. Per curl's [documentation](https://curl.haxx.se/libcurl/c/CURLOPT_HTTP_VERSION.html):\r\n> libcurl will fall back to HTTP 1.1 if HTTP 2 can't be negotiated with the server. \r\n"},"comment":{"url":"https://api.github.com/repos/stripe/stripe-php/issues/comments/405212302","html_url":"https://github.com/stripe/stripe-php/pull/494#issuecomment-405212302","issue_url":"https://api.github.com/repos/stripe/stripe-php/issues/494","id":405212302,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTIxMjMwMg==","user":{"login":"ob-stripe","id":23086931,"node_id":"MDQ6VXNlcjIzMDg2OTMx","avatar_url":"https://avatars0.githubusercontent.com/u/23086931?v=4","gravatar_id":"","url":"https://api.github.com/users/ob-stripe","html_url":"https://github.com/ob-stripe","followers_url":"https://api.github.com/users/ob-stripe/followers","following_url":"https://api.github.com/users/ob-stripe/following{/other_user}","gists_url":"https://api.github.com/users/ob-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/ob-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ob-stripe/subscriptions","organizations_url":"https://api.github.com/users/ob-stripe/orgs","repos_url":"https://api.github.com/users/ob-stripe/repos","events_url":"https://api.github.com/users/ob-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/ob-stripe/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T10:58:36Z","updated_at":"2018-07-16T10:58:36Z","author_association":"COLLABORATOR","body":"The issue is that it is possible to use an older PHP version (e.g. 5.4) where the curl constants are not defined with a newer ext-curl version that does support features like HTTP/2.\r\n\r\nThankfully, curl is robust enough that providing an unknown value for a configuration option simply results in curl using the default value for that option, so it is safe to pass these values regardless of which ext-curl version is used.\r\n\r\nRe. PSR-4, I'm also not sure that what we do in the library is in violation of the spec. I assume it's because the constants are not constrained to the `\\Stripe` namespace? We could \"fix\" that, but I'm not sure it's worth the trouble. In practice, what are the chances that someone would define constants with the same names but different values in their own code?\r\n"}}
{"actor":{"display_login":"ob-stripe"}}