{"action":"created","issue":{"url":"https://api.github.com/repos/vuejs/vue-test-utils/issues/692","repository_url":"https://api.github.com/repos/vuejs/vue-test-utils","labels_url":"https://api.github.com/repos/vuejs/vue-test-utils/issues/692/labels{/name}","comments_url":"https://api.github.com/repos/vuejs/vue-test-utils/issues/692/comments","events_url":"https://api.github.com/repos/vuejs/vue-test-utils/issues/692/events","html_url":"https://github.com/vuejs/vue-test-utils/pull/692","id":330711949,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjU1MTY3","number":692,"title":"Update `find` and `findAll` to be more robust","user":{"login":"lmiller1990","id":19196536,"node_id":"MDQ6VXNlcjE5MTk2NTM2","avatar_url":"https://avatars1.githubusercontent.com/u/19196536?v=4","gravatar_id":"","url":"https://api.github.com/users/lmiller1990","html_url":"https://github.com/lmiller1990","followers_url":"https://api.github.com/users/lmiller1990/followers","following_url":"https://api.github.com/users/lmiller1990/following{/other_user}","gists_url":"https://api.github.com/users/lmiller1990/gists{/gist_id}","starred_url":"https://api.github.com/users/lmiller1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmiller1990/subscriptions","organizations_url":"https://api.github.com/users/lmiller1990/orgs","repos_url":"https://api.github.com/users/lmiller1990/repos","events_url":"https://api.github.com/users/lmiller1990/events{/privacy}","received_events_url":"https://api.github.com/users/lmiller1990/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-08T15:50:49Z","updated_at":"2018-06-09T07:37:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vuejs/vue-test-utils/pulls/692","html_url":"https://github.com/vuejs/vue-test-utils/pull/692","diff_url":"https://github.com/vuejs/vue-test-utils/pull/692.diff","patch_url":"https://github.com/vuejs/vue-test-utils/pull/692.patch"},"body":"Second attempt at #651 . First attempt and related comments in #681 which I closed in favor of this.\r\n\r\nAllows users to use `find` and `findAll` on a `tag`. Example:\r\n\r\n```js\r\nwrapper = shallowMount(ComponentWithChild)\r\n\r\nexpect(wrapper.find(\"child-component\").exists()).toBe(true)\r\n```\r\n\r\n@eddyerburgh thanks for previous feedback, updated using a `TAG_SELECTOR` and `isTagSelector` method.\r\n\r\n@38elements not sure how you feel about this feature but I updated using some of your comments on the previous PR, mainly not using the external npm packages for html/svg elements."},"comment":{"url":"https://api.github.com/repos/vuejs/vue-test-utils/issues/comments/395948194","html_url":"https://github.com/vuejs/vue-test-utils/pull/692#issuecomment-395948194","issue_url":"https://api.github.com/repos/vuejs/vue-test-utils/issues/692","id":395948194,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTk0ODE5NA==","user":{"login":"38elements","id":2399132,"node_id":"MDQ6VXNlcjIzOTkxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2399132?v=4","gravatar_id":"","url":"https://api.github.com/users/38elements","html_url":"https://github.com/38elements","followers_url":"https://api.github.com/users/38elements/followers","following_url":"https://api.github.com/users/38elements/following{/other_user}","gists_url":"https://api.github.com/users/38elements/gists{/gist_id}","starred_url":"https://api.github.com/users/38elements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/38elements/subscriptions","organizations_url":"https://api.github.com/users/38elements/orgs","repos_url":"https://api.github.com/users/38elements/repos","events_url":"https://api.github.com/users/38elements/events{/privacy}","received_events_url":"https://api.github.com/users/38elements/received_events","type":"User","site_admin":false},"created_at":"2018-06-09T07:37:22Z","updated_at":"2018-06-09T07:37:22Z","author_association":"CONTRIBUTOR","body":"> Can you create an issue to discuss it.\r\n\r\nI think that it is better to create a new issue.\r\nSince this feature is not essential, it is unnecessary to hurry.\r\nSince it is difficult to remove existing feature, it is necessary to consider well.\r\n\r\n> we're implementing similar behavior with #687.\r\n\r\n#687 is not the similar behavior.\r\nCSS Selector does not return not existing element.\r\nThere is a problem which Wrapper.vm is empty even if the returned element has Vue instance.\r\n#687 resolves this problem.\r\nIMHO, #687 might be bug fix, not changing feature."}}
{"actor":{"display_login":"38elements"}}