{"action":"created","issue":{"url":"https://api.github.com/repos/steemit/condenser/issues/2434","repository_url":"https://api.github.com/repos/steemit/condenser","labels_url":"https://api.github.com/repos/steemit/condenser/issues/2434/labels{/name}","comments_url":"https://api.github.com/repos/steemit/condenser/issues/2434/comments","events_url":"https://api.github.com/repos/steemit/condenser/issues/2434/events","html_url":"https://github.com/steemit/condenser/pull/2434","id":292970938,"number":2434,"title":"remove dependency on react-foundation-components library, refs #2253","user":{"login":"gl2748","id":3374538,"avatar_url":"https://avatars2.githubusercontent.com/u/3374538?v=4","gravatar_id":"","url":"https://api.github.com/users/gl2748","html_url":"https://github.com/gl2748","followers_url":"https://api.github.com/users/gl2748/followers","following_url":"https://api.github.com/users/gl2748/following{/other_user}","gists_url":"https://api.github.com/users/gl2748/gists{/gist_id}","starred_url":"https://api.github.com/users/gl2748/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gl2748/subscriptions","organizations_url":"https://api.github.com/users/gl2748/orgs","repos_url":"https://api.github.com/users/gl2748/repos","events_url":"https://api.github.com/users/gl2748/events{/privacy}","received_events_url":"https://api.github.com/users/gl2748/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-01-30T23:03:22Z","updated_at":"2018-02-02T17:53:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/steemit/condenser/pulls/2434","html_url":"https://github.com/steemit/condenser/pull/2434","diff_url":"https://github.com/steemit/condenser/pull/2434.diff","patch_url":"https://github.com/steemit/condenser/pull/2434.patch"},"body":"Fixes #2253 \r\nFixes #2303 \r\nThe `react-foundation-components` library is a bug-bear, inconsistently maintained and unpredictable.\r\nWe'd rather not use it, but unfortunately it is used extensively our codebase.\r\n\r\nThis PR zaps the `react-foundation-components` dependency aiming for parity where possible, and subject to review, with a couple beneficial changes - namely:\r\n\r\n## 1. Dropdowns styled for night mode. Fixes #2303\r\n\r\n### Before:\r\n![before_real](https://user-images.githubusercontent.com/3374538/35402079-aaf71bd0-01b8-11e8-8cba-9aa7a3755687.gif)\r\n\r\n### After:\r\n![after](https://user-images.githubusercontent.com/3374538/35402094-b4a65614-01b8-11e8-8637-c01ac88406bc.gif)\r\n\r\n\r\n## 2. 'Flag' actions are consistently presented in a modal format - described here: https://github.com/steemit/condenser/issues/2258#issuecomment-355985057\r\n\r\n### Demonstration of Flagging interaction change - no more dropdown...:\r\n### Before.\r\n![b4_flag](https://user-images.githubusercontent.com/3374538/35402389-b14e84f4-01b9-11e8-83a5-069559d59a57.gif)\r\n\r\n### After.\r\n![after_flag2](https://user-images.githubusercontent.com/3374538/35402534-1fa47940-01ba-11e8-8c25-f7bde98b839f.gif)\r\n\r\nToDo.\r\n- [x] Look through the wording for the flag action / modal text.\r\n- [ ] Remove Steemit maintained fork of https://github.com/steemit/foundation-sites.\r\n- [x] PR review feedback.\r\n- [x]  Product feedback."},"comment":{"url":"https://api.github.com/repos/steemit/condenser/issues/comments/362656772","html_url":"https://github.com/steemit/condenser/pull/2434#issuecomment-362656772","issue_url":"https://api.github.com/repos/steemit/condenser/issues/2434","id":362656772,"user":{"login":"gl2748","id":3374538,"avatar_url":"https://avatars2.githubusercontent.com/u/3374538?v=4","gravatar_id":"","url":"https://api.github.com/users/gl2748","html_url":"https://github.com/gl2748","followers_url":"https://api.github.com/users/gl2748/followers","following_url":"https://api.github.com/users/gl2748/following{/other_user}","gists_url":"https://api.github.com/users/gl2748/gists{/gist_id}","starred_url":"https://api.github.com/users/gl2748/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gl2748/subscriptions","organizations_url":"https://api.github.com/users/gl2748/orgs","repos_url":"https://api.github.com/users/gl2748/repos","events_url":"https://api.github.com/users/gl2748/events{/privacy}","received_events_url":"https://api.github.com/users/gl2748/received_events","type":"User","site_admin":false},"created_at":"2018-02-02T17:53:17Z","updated_at":"2018-02-02T17:53:17Z","author_association":"CONTRIBUTOR","body":"# 1. First Flag Action - Flagging content with no prior interaction.\r\n![first_flag_action](https://user-images.githubusercontent.com/3374538/35747281-ea752582-0806-11e8-8181-323984606c10.gif)\r\n\r\n# 2. Second  Flag Action - Unflagging previously flagged content.\r\n![second_flag_action](https://user-images.githubusercontent.com/3374538/35747308-068a8e24-0807-11e8-81ae-768df565e674.gif)\r\n\r\n# 3. Third Flag Action - Voting up previously flagged content.\r\n![third_flag_action](https://user-images.githubusercontent.com/3374538/35747327-1ce1039c-0807-11e8-9745-36b2e6d03766.gif)\r\n\r\n#4. Forth Flag Action - Flagging previouslt voted-up content.\r\n![forth_flag_action](https://user-images.githubusercontent.com/3374538/35747344-3284033e-0807-11e8-8f81-c235f6f43b19.gif)\r\n"}}
{"actor":{"display_login":"gl2748"}}