{"action":"created","comment":{"url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments/237143654","pull_request_review_id":179370340,"id":237143654,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzE0MzY1NA==","diff_hunk":"@@ -3482,6 +3510,198 @@ string RDMHTTPModule::SetCurve(const HTTPRequest *request,\n   return error;\n }\n \n+/**\n+ * @brief Handle the request for Dimmer Info.\n+ */\n+string RDMHTTPModule::GetDimmerInfo(HTTPResponse *response,\n+                                    unsigned int universe_id,\n+                                    const UID &uid) {\n+  string error;\n+  m_rdm_api.GetDimmerInfo(\n+    universe_id,\n+    uid,\n+    ola::rdm::ROOT_RDM_DEVICE,\n+    NewSingleCallback(this,\n+                      &RDMHTTPModule::GetDimmerInfoHandler,\n+                      response),\n+    &error);\n+  return error;\n+}\n+\n+/*\n+ * @brief Handle the response to a dimmer info call and build the response\n+ */\n+void RDMHTTPModule::GetDimmerInfoHandler(HTTPResponse *response,\n+                                         const ola::rdm::ResponseStatus &status,\n+    const ola::rdm::DimmerInfoDescriptor &info) {\n+  if (CheckForRDMError(response, status)) {\n+    return;\n+  }\n+\n+  JsonSection section;\n+  section.AddItem(new UIntItem(\"Minimum Level Lower Limit\",\n+    info.min_level_lower_limit));","path":"olad/RDMHTTPModule.cpp","position":null,"original_position":104,"commit_id":"ad59d36b89c130526a1b605f01a7e93940c40078","original_commit_id":"12c8018a7f0689b478a854eb9d4bd890810b0256","user":{"login":"peternewman","id":6216436,"node_id":"MDQ6VXNlcjYyMTY0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6216436?v=4","gravatar_id":"","url":"https://api.github.com/users/peternewman","html_url":"https://github.com/peternewman","followers_url":"https://api.github.com/users/peternewman/followers","following_url":"https://api.github.com/users/peternewman/following{/other_user}","gists_url":"https://api.github.com/users/peternewman/gists{/gist_id}","starred_url":"https://api.github.com/users/peternewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peternewman/subscriptions","organizations_url":"https://api.github.com/users/peternewman/orgs","repos_url":"https://api.github.com/users/peternewman/repos","events_url":"https://api.github.com/users/peternewman/events{/privacy}","received_events_url":"https://api.github.com/users/peternewman/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-11-28T15:52:08Z","updated_at":"2018-11-28T15:52:09Z","html_url":"https://github.com/OpenLightingProject/ola/pull/1494#discussion_r237143654","pull_request_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1494","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments/237143654"},"html":{"href":"https://github.com/OpenLightingProject/ola/pull/1494#discussion_r237143654"},"pull_request":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1494"}},"in_reply_to_id":219352439},"pull_request":{"url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1494","id":217001155,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDAxMTU1","html_url":"https://github.com/OpenLightingProject/ola/pull/1494","diff_url":"https://github.com/OpenLightingProject/ola/pull/1494.diff","patch_url":"https://github.com/OpenLightingProject/ola/pull/1494.patch","issue_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/1494","number":1494,"state":"open","locked":false,"title":"Implement DIMMER_INFO, DIMMER_MINIMUM, and DIMMER_MAXIMUM PIDs per E1.37-1","user":{"login":"kecramer","id":6415432,"node_id":"MDQ6VXNlcjY0MTU0MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6415432?v=4","gravatar_id":"","url":"https://api.github.com/users/kecramer","html_url":"https://github.com/kecramer","followers_url":"https://api.github.com/users/kecramer/followers","following_url":"https://api.github.com/users/kecramer/following{/other_user}","gists_url":"https://api.github.com/users/kecramer/gists{/gist_id}","starred_url":"https://api.github.com/users/kecramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kecramer/subscriptions","organizations_url":"https://api.github.com/users/kecramer/orgs","repos_url":"https://api.github.com/users/kecramer/repos","events_url":"https://api.github.com/users/kecramer/events{/privacy}","received_events_url":"https://api.github.com/users/kecramer/received_events","type":"User","site_admin":false},"body":"Includes code from https://github.com/OpenLightingProject/ola/pull/1483 ","created_at":"2018-09-20T14:49:56Z","updated_at":"2018-11-28T15:52:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aacba5dd0c94eea9761fd31a192d2b8c84540f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/OpenLightingProject/ola/milestones/9","html_url":"https://github.com/OpenLightingProject/ola/milestone/9","labels_url":"https://api.github.com/repos/OpenLightingProject/ola/milestones/9/labels","id":1457508,"node_id":"MDk6TWlsZXN0b25lMTQ1NzUwOA==","number":9,"title":"0.11.0","description":"New features","creator":{"login":"peternewman","id":6216436,"node_id":"MDQ6VXNlcjYyMTY0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6216436?v=4","gravatar_id":"","url":"https://api.github.com/users/peternewman","html_url":"https://github.com/peternewman","followers_url":"https://api.github.com/users/peternewman/followers","following_url":"https://api.github.com/users/peternewman/following{/other_user}","gists_url":"https://api.github.com/users/peternewman/gists{/gist_id}","starred_url":"https://api.github.com/users/peternewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peternewman/subscriptions","organizations_url":"https://api.github.com/users/peternewman/orgs","repos_url":"https://api.github.com/users/peternewman/repos","events_url":"https://api.github.com/users/peternewman/events{/privacy}","received_events_url":"https://api.github.com/users/peternewman/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":174,"state":"open","created_at":"2015-12-12T22:03:07Z","updated_at":"2018-11-27T17:23:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1494/commits","review_comments_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1494/comments","review_comment_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/1494/comments","statuses_url":"https://api.github.com/repos/OpenLightingProject/ola/statuses/ad59d36b89c130526a1b605f01a7e93940c40078","head":{"label":"kecramer:dimmer-pids","ref":"dimmer-pids","sha":"ad59d36b89c130526a1b605f01a7e93940c40078","user":{"login":"kecramer","id":6415432,"node_id":"MDQ6VXNlcjY0MTU0MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6415432?v=4","gravatar_id":"","url":"https://api.github.com/users/kecramer","html_url":"https://github.com/kecramer","followers_url":"https://api.github.com/users/kecramer/followers","following_url":"https://api.github.com/users/kecramer/following{/other_user}","gists_url":"https://api.github.com/users/kecramer/gists{/gist_id}","starred_url":"https://api.github.com/users/kecramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kecramer/subscriptions","organizations_url":"https://api.github.com/users/kecramer/orgs","repos_url":"https://api.github.com/users/kecramer/repos","events_url":"https://api.github.com/users/kecramer/events{/privacy}","received_events_url":"https://api.github.com/users/kecramer/received_events","type":"User","site_admin":false},"repo":{"id":145019351,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwMTkzNTE=","name":"ola","full_name":"kecramer/ola","private":false,"owner":{"login":"kecramer","id":6415432,"node_id":"MDQ6VXNlcjY0MTU0MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6415432?v=4","gravatar_id":"","url":"https://api.github.com/users/kecramer","html_url":"https://github.com/kecramer","followers_url":"https://api.github.com/users/kecramer/followers","following_url":"https://api.github.com/users/kecramer/following{/other_user}","gists_url":"https://api.github.com/users/kecramer/gists{/gist_id}","starred_url":"https://api.github.com/users/kecramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kecramer/subscriptions","organizations_url":"https://api.github.com/users/kecramer/orgs","repos_url":"https://api.github.com/users/kecramer/repos","events_url":"https://api.github.com/users/kecramer/events{/privacy}","received_events_url":"https://api.github.com/users/kecramer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kecramer/ola","description":"The Open Lighting Architecture - The Travel Adaptor for the Lighting Industry","fork":true,"url":"https://api.github.com/repos/kecramer/ola","forks_url":"https://api.github.com/repos/kecramer/ola/forks","keys_url":"https://api.github.com/repos/kecramer/ola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kecramer/ola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kecramer/ola/teams","hooks_url":"https://api.github.com/repos/kecramer/ola/hooks","issue_events_url":"https://api.github.com/repos/kecramer/ola/issues/events{/number}","events_url":"https://api.github.com/repos/kecramer/ola/events","assignees_url":"https://api.github.com/repos/kecramer/ola/assignees{/user}","branches_url":"https://api.github.com/repos/kecramer/ola/branches{/branch}","tags_url":"https://api.github.com/repos/kecramer/ola/tags","blobs_url":"https://api.github.com/repos/kecramer/ola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kecramer/ola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kecramer/ola/git/refs{/sha}","trees_url":"https://api.github.com/repos/kecramer/ola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kecramer/ola/statuses/{sha}","languages_url":"https://api.github.com/repos/kecramer/ola/languages","stargazers_url":"https://api.github.com/repos/kecramer/ola/stargazers","contributors_url":"https://api.github.com/repos/kecramer/ola/contributors","subscribers_url":"https://api.github.com/repos/kecramer/ola/subscribers","subscription_url":"https://api.github.com/repos/kecramer/ola/subscription","commits_url":"https://api.github.com/repos/kecramer/ola/commits{/sha}","git_commits_url":"https://api.github.com/repos/kecramer/ola/git/commits{/sha}","comments_url":"https://api.github.com/repos/kecramer/ola/comments{/number}","issue_comment_url":"https://api.github.com/repos/kecramer/ola/issues/comments{/number}","contents_url":"https://api.github.com/repos/kecramer/ola/contents/{+path}","compare_url":"https://api.github.com/repos/kecramer/ola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kecramer/ola/merges","archive_url":"https://api.github.com/repos/kecramer/ola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kecramer/ola/downloads","issues_url":"https://api.github.com/repos/kecramer/ola/issues{/number}","pulls_url":"https://api.github.com/repos/kecramer/ola/pulls{/number}","milestones_url":"https://api.github.com/repos/kecramer/ola/milestones{/number}","notifications_url":"https://api.github.com/repos/kecramer/ola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kecramer/ola/labels{/name}","releases_url":"https://api.github.com/repos/kecramer/ola/releases{/id}","deployments_url":"https://api.github.com/repos/kecramer/ola/deployments","created_at":"2018-08-16T17:26:18Z","updated_at":"2018-08-16T17:26:24Z","pushed_at":"2018-10-31T10:49:21Z","git_url":"git://github.com/kecramer/ola.git","ssh_url":"git@github.com:kecramer/ola.git","clone_url":"https://github.com/kecramer/ola.git","svn_url":"https://github.com/kecramer/ola","homepage":"https://www.openlighting.org/ola/","size":22069,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenLightingProject:master","ref":"master","sha":"b31846b81ab44496f5a9f909d818b23156f6cfe9","user":{"login":"OpenLightingProject","id":6199314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxOTkzMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6199314?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLightingProject","html_url":"https://github.com/OpenLightingProject","followers_url":"https://api.github.com/users/OpenLightingProject/followers","following_url":"https://api.github.com/users/OpenLightingProject/following{/other_user}","gists_url":"https://api.github.com/users/OpenLightingProject/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLightingProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLightingProject/subscriptions","organizations_url":"https://api.github.com/users/OpenLightingProject/orgs","repos_url":"https://api.github.com/users/OpenLightingProject/repos","events_url":"https://api.github.com/users/OpenLightingProject/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLightingProject/received_events","type":"Organization","site_admin":false},"repo":{"id":15233168,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIzMzE2OA==","name":"ola","full_name":"OpenLightingProject/ola","private":false,"owner":{"login":"OpenLightingProject","id":6199314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxOTkzMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6199314?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLightingProject","html_url":"https://github.com/OpenLightingProject","followers_url":"https://api.github.com/users/OpenLightingProject/followers","following_url":"https://api.github.com/users/OpenLightingProject/following{/other_user}","gists_url":"https://api.github.com/users/OpenLightingProject/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLightingProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLightingProject/subscriptions","organizations_url":"https://api.github.com/users/OpenLightingProject/orgs","repos_url":"https://api.github.com/users/OpenLightingProject/repos","events_url":"https://api.github.com/users/OpenLightingProject/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLightingProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenLightingProject/ola","description":"The Open Lighting Architecture - The Travel Adaptor for the Lighting Industry","fork":false,"url":"https://api.github.com/repos/OpenLightingProject/ola","forks_url":"https://api.github.com/repos/OpenLightingProject/ola/forks","keys_url":"https://api.github.com/repos/OpenLightingProject/ola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLightingProject/ola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLightingProject/ola/teams","hooks_url":"https://api.github.com/repos/OpenLightingProject/ola/hooks","issue_events_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLightingProject/ola/events","assignees_url":"https://api.github.com/repos/OpenLightingProject/ola/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLightingProject/ola/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLightingProject/ola/tags","blobs_url":"https://api.github.com/repos/OpenLightingProject/ola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLightingProject/ola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLightingProject/ola/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLightingProject/ola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLightingProject/ola/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLightingProject/ola/languages","stargazers_url":"https://api.github.com/repos/OpenLightingProject/ola/stargazers","contributors_url":"https://api.github.com/repos/OpenLightingProject/ola/contributors","subscribers_url":"https://api.github.com/repos/OpenLightingProject/ola/subscribers","subscription_url":"https://api.github.com/repos/OpenLightingProject/ola/subscription","commits_url":"https://api.github.com/repos/OpenLightingProject/ola/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLightingProject/ola/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLightingProject/ola/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLightingProject/ola/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLightingProject/ola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLightingProject/ola/merges","archive_url":"https://api.github.com/repos/OpenLightingProject/ola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLightingProject/ola/downloads","issues_url":"https://api.github.com/repos/OpenLightingProject/ola/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLightingProject/ola/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLightingProject/ola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLightingProject/ola/labels{/name}","releases_url":"https://api.github.com/repos/OpenLightingProject/ola/releases{/id}","deployments_url":"https://api.github.com/repos/OpenLightingProject/ola/deployments","created_at":"2013-12-16T18:06:52Z","updated_at":"2018-11-23T11:41:39Z","pushed_at":"2018-11-27T17:23:40Z","git_url":"git://github.com/OpenLightingProject/ola.git","ssh_url":"git@github.com:OpenLightingProject/ola.git","clone_url":"https://github.com/OpenLightingProject/ola.git","svn_url":"https://github.com/OpenLightingProject/ola","homepage":"https://www.openlighting.org/ola/","size":22026,"stargazers_count":294,"watchers_count":294,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":126,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":126,"open_issues":180,"watchers":294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1494"},"html":{"href":"https://github.com/OpenLightingProject/ola/pull/1494"},"issue":{"href":"https://api.github.com/repos/OpenLightingProject/ola/issues/1494"},"comments":{"href":"https://api.github.com/repos/OpenLightingProject/ola/issues/1494/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1494/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1494/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLightingProject/ola/statuses/ad59d36b89c130526a1b605f01a7e93940c40078"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"peternewman"}}