{"action":"created","comment":{"url":"https://api.github.com/repos/vanessa/pokebattle/pulls/comments/182572736","pull_request_review_id":113383560,"id":182572736,"diff_hunk":"@@ -81,3 +92,7 @@ def get_context_data(self, **kwargs):\n \n     def get_success_url(self):\n         return reverse('battles:details', kwargs={'pk': self.kwargs['pk']})\n+\n+    def form_valid(self, form):\n+        form.save()\n+        return super().form_valid(form)","path":"battles/views.py","position":47,"original_position":47,"commit_id":"74effdebd2c40ab8d199a1706f925b01679822d0","original_commit_id":"74effdebd2c40ab8d199a1706f925b01679822d0","user":{"login":"rsarai","id":17428455,"avatar_url":"https://avatars1.githubusercontent.com/u/17428455?v=4","gravatar_id":"","url":"https://api.github.com/users/rsarai","html_url":"https://github.com/rsarai","followers_url":"https://api.github.com/users/rsarai/followers","following_url":"https://api.github.com/users/rsarai/following{/other_user}","gists_url":"https://api.github.com/users/rsarai/gists{/gist_id}","starred_url":"https://api.github.com/users/rsarai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsarai/subscriptions","organizations_url":"https://api.github.com/users/rsarai/orgs","repos_url":"https://api.github.com/users/rsarai/repos","events_url":"https://api.github.com/users/rsarai/events{/privacy}","received_events_url":"https://api.github.com/users/rsarai/received_events","type":"User","site_admin":false},"body":"Did you considered inherit from a `CreateView`? Cause you wouldn't need to override the `form_valid`","created_at":"2018-04-18T21:18:58Z","updated_at":"2018-04-18T21:44:26Z","html_url":"https://github.com/vanessa/pokebattle/pull/3#discussion_r182572736","pull_request_url":"https://api.github.com/repos/vanessa/pokebattle/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/vanessa/pokebattle/pulls/comments/182572736"},"html":{"href":"https://github.com/vanessa/pokebattle/pull/3#discussion_r182572736"},"pull_request":{"href":"https://api.github.com/repos/vanessa/pokebattle/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/vanessa/pokebattle/pulls/3","id":180738569,"html_url":"https://github.com/vanessa/pokebattle/pull/3","diff_url":"https://github.com/vanessa/pokebattle/pull/3.diff","patch_url":"https://github.com/vanessa/pokebattle/pull/3.patch","issue_url":"https://api.github.com/repos/vanessa/pokebattle/issues/3","number":3,"state":"open","locked":false,"title":"Add battle team feature","user":{"login":"vanessa","id":23136832,"avatar_url":"https://avatars3.githubusercontent.com/u/23136832?v=4","gravatar_id":"","url":"https://api.github.com/users/vanessa","html_url":"https://github.com/vanessa","followers_url":"https://api.github.com/users/vanessa/followers","following_url":"https://api.github.com/users/vanessa/following{/other_user}","gists_url":"https://api.github.com/users/vanessa/gists{/gist_id}","starred_url":"https://api.github.com/users/vanessa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanessa/subscriptions","organizations_url":"https://api.github.com/users/vanessa/orgs","repos_url":"https://api.github.com/users/vanessa/repos","events_url":"https://api.github.com/users/vanessa/events{/privacy}","received_events_url":"https://api.github.com/users/vanessa/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail. Are there any deploy restrictions? -->\r\nNow users can select a team for their battles.\r\n\r\nhttps://trello.com/c/mzOC8u7O/4-as-the-opponent-trainer-i-select-my-pkns-to-battle\r\n\r\nThe tests are correct, it's just CircleCI that's somewhat weird. If you run the tests locally it's working.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n\r\n## Screenshots (if appropriate):\r\n![image](https://user-images.githubusercontent.com/23136832/38585554-a8b3dafc-3cf0-11e8-9fe3-e0c7b34999fb.png)\r\n\r\n## Steps to reproduce (if appropriate):\r\n<!--- Describe the expected success & failure flows in detail -->\r\n\r\n## Critical points affected:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n- [ ] Signup flow\r\n- [ ] Battle creation\r\n- [x] Battle team choosing\r\n- [ ] Battle execution\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Improvement (non-breaking change which improves functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Technical debt (refactoring existing code)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My change requires documentation updates.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] My change requires dependencies updates.\r\n- [ ] I have updated the dependencies accordingly.\r\n- [ ] My change affected critical flows & code.\r\n- [ ] I have tested the critical flows & code accordingly.\r\n- [ ] My change requires environment variables updates.\r\n- [ ] I have described the environment variables accordingly.\r\n","created_at":"2018-04-10T21:55:04Z","updated_at":"2018-04-18T21:44:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13955239e45f552bbae90c3464d084ff075d1d15","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vanessa/pokebattle/pulls/3/commits","review_comments_url":"https://api.github.com/repos/vanessa/pokebattle/pulls/3/comments","review_comment_url":"https://api.github.com/repos/vanessa/pokebattle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vanessa/pokebattle/issues/3/comments","statuses_url":"https://api.github.com/repos/vanessa/pokebattle/statuses/74effdebd2c40ab8d199a1706f925b01679822d0","head":{"label":"vanessa:add-battle-team","ref":"add-battle-team","sha":"74effdebd2c40ab8d199a1706f925b01679822d0","user":{"login":"vanessa","id":23136832,"avatar_url":"https://avatars3.githubusercontent.com/u/23136832?v=4","gravatar_id":"","url":"https://api.github.com/users/vanessa","html_url":"https://github.com/vanessa","followers_url":"https://api.github.com/users/vanessa/followers","following_url":"https://api.github.com/users/vanessa/following{/other_user}","gists_url":"https://api.github.com/users/vanessa/gists{/gist_id}","starred_url":"https://api.github.com/users/vanessa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanessa/subscriptions","organizations_url":"https://api.github.com/users/vanessa/orgs","repos_url":"https://api.github.com/users/vanessa/repos","events_url":"https://api.github.com/users/vanessa/events{/privacy}","received_events_url":"https://api.github.com/users/vanessa/received_events","type":"User","site_admin":false},"repo":{"id":125147775,"name":"pokebattle","full_name":"vanessa/pokebattle","owner":{"login":"vanessa","id":23136832,"avatar_url":"https://avatars3.githubusercontent.com/u/23136832?v=4","gravatar_id":"","url":"https://api.github.com/users/vanessa","html_url":"https://github.com/vanessa","followers_url":"https://api.github.com/users/vanessa/followers","following_url":"https://api.github.com/users/vanessa/following{/other_user}","gists_url":"https://api.github.com/users/vanessa/gists{/gist_id}","starred_url":"https://api.github.com/users/vanessa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanessa/subscriptions","organizations_url":"https://api.github.com/users/vanessa/orgs","repos_url":"https://api.github.com/users/vanessa/repos","events_url":"https://api.github.com/users/vanessa/events{/privacy}","received_events_url":"https://api.github.com/users/vanessa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vanessa/pokebattle","description":"A simple Pokemon battle system using Django and PokeAPI.","fork":false,"url":"https://api.github.com/repos/vanessa/pokebattle","forks_url":"https://api.github.com/repos/vanessa/pokebattle/forks","keys_url":"https://api.github.com/repos/vanessa/pokebattle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanessa/pokebattle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanessa/pokebattle/teams","hooks_url":"https://api.github.com/repos/vanessa/pokebattle/hooks","issue_events_url":"https://api.github.com/repos/vanessa/pokebattle/issues/events{/number}","events_url":"https://api.github.com/repos/vanessa/pokebattle/events","assignees_url":"https://api.github.com/repos/vanessa/pokebattle/assignees{/user}","branches_url":"https://api.github.com/repos/vanessa/pokebattle/branches{/branch}","tags_url":"https://api.github.com/repos/vanessa/pokebattle/tags","blobs_url":"https://api.github.com/repos/vanessa/pokebattle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanessa/pokebattle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanessa/pokebattle/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanessa/pokebattle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanessa/pokebattle/statuses/{sha}","languages_url":"https://api.github.com/repos/vanessa/pokebattle/languages","stargazers_url":"https://api.github.com/repos/vanessa/pokebattle/stargazers","contributors_url":"https://api.github.com/repos/vanessa/pokebattle/contributors","subscribers_url":"https://api.github.com/repos/vanessa/pokebattle/subscribers","subscription_url":"https://api.github.com/repos/vanessa/pokebattle/subscription","commits_url":"https://api.github.com/repos/vanessa/pokebattle/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanessa/pokebattle/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanessa/pokebattle/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanessa/pokebattle/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanessa/pokebattle/contents/{+path}","compare_url":"https://api.github.com/repos/vanessa/pokebattle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanessa/pokebattle/merges","archive_url":"https://api.github.com/repos/vanessa/pokebattle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanessa/pokebattle/downloads","issues_url":"https://api.github.com/repos/vanessa/pokebattle/issues{/number}","pulls_url":"https://api.github.com/repos/vanessa/pokebattle/pulls{/number}","milestones_url":"https://api.github.com/repos/vanessa/pokebattle/milestones{/number}","notifications_url":"https://api.github.com/repos/vanessa/pokebattle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanessa/pokebattle/labels{/name}","releases_url":"https://api.github.com/repos/vanessa/pokebattle/releases{/id}","deployments_url":"https://api.github.com/repos/vanessa/pokebattle/deployments","created_at":"2018-03-14T03:08:22Z","updated_at":"2018-04-10T19:54:29Z","pushed_at":"2018-04-17T22:30:14Z","git_url":"git://github.com/vanessa/pokebattle.git","ssh_url":"git@github.com:vanessa/pokebattle.git","clone_url":"https://github.com/vanessa/pokebattle.git","svn_url":"https://github.com/vanessa/pokebattle","homepage":"https://pokebattle-vanessa.herokuapp.com","size":635,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":1,"default_branch":"develop"}},"base":{"label":"vanessa:develop","ref":"develop","sha":"ab5b45bf28572faf5ece6b3b99e8088a27408839","user":{"login":"vanessa","id":23136832,"avatar_url":"https://avatars3.githubusercontent.com/u/23136832?v=4","gravatar_id":"","url":"https://api.github.com/users/vanessa","html_url":"https://github.com/vanessa","followers_url":"https://api.github.com/users/vanessa/followers","following_url":"https://api.github.com/users/vanessa/following{/other_user}","gists_url":"https://api.github.com/users/vanessa/gists{/gist_id}","starred_url":"https://api.github.com/users/vanessa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanessa/subscriptions","organizations_url":"https://api.github.com/users/vanessa/orgs","repos_url":"https://api.github.com/users/vanessa/repos","events_url":"https://api.github.com/users/vanessa/events{/privacy}","received_events_url":"https://api.github.com/users/vanessa/received_events","type":"User","site_admin":false},"repo":{"id":125147775,"name":"pokebattle","full_name":"vanessa/pokebattle","owner":{"login":"vanessa","id":23136832,"avatar_url":"https://avatars3.githubusercontent.com/u/23136832?v=4","gravatar_id":"","url":"https://api.github.com/users/vanessa","html_url":"https://github.com/vanessa","followers_url":"https://api.github.com/users/vanessa/followers","following_url":"https://api.github.com/users/vanessa/following{/other_user}","gists_url":"https://api.github.com/users/vanessa/gists{/gist_id}","starred_url":"https://api.github.com/users/vanessa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanessa/subscriptions","organizations_url":"https://api.github.com/users/vanessa/orgs","repos_url":"https://api.github.com/users/vanessa/repos","events_url":"https://api.github.com/users/vanessa/events{/privacy}","received_events_url":"https://api.github.com/users/vanessa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vanessa/pokebattle","description":"A simple Pokemon battle system using Django and PokeAPI.","fork":false,"url":"https://api.github.com/repos/vanessa/pokebattle","forks_url":"https://api.github.com/repos/vanessa/pokebattle/forks","keys_url":"https://api.github.com/repos/vanessa/pokebattle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanessa/pokebattle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanessa/pokebattle/teams","hooks_url":"https://api.github.com/repos/vanessa/pokebattle/hooks","issue_events_url":"https://api.github.com/repos/vanessa/pokebattle/issues/events{/number}","events_url":"https://api.github.com/repos/vanessa/pokebattle/events","assignees_url":"https://api.github.com/repos/vanessa/pokebattle/assignees{/user}","branches_url":"https://api.github.com/repos/vanessa/pokebattle/branches{/branch}","tags_url":"https://api.github.com/repos/vanessa/pokebattle/tags","blobs_url":"https://api.github.com/repos/vanessa/pokebattle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanessa/pokebattle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanessa/pokebattle/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanessa/pokebattle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanessa/pokebattle/statuses/{sha}","languages_url":"https://api.github.com/repos/vanessa/pokebattle/languages","stargazers_url":"https://api.github.com/repos/vanessa/pokebattle/stargazers","contributors_url":"https://api.github.com/repos/vanessa/pokebattle/contributors","subscribers_url":"https://api.github.com/repos/vanessa/pokebattle/subscribers","subscription_url":"https://api.github.com/repos/vanessa/pokebattle/subscription","commits_url":"https://api.github.com/repos/vanessa/pokebattle/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanessa/pokebattle/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanessa/pokebattle/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanessa/pokebattle/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanessa/pokebattle/contents/{+path}","compare_url":"https://api.github.com/repos/vanessa/pokebattle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanessa/pokebattle/merges","archive_url":"https://api.github.com/repos/vanessa/pokebattle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanessa/pokebattle/downloads","issues_url":"https://api.github.com/repos/vanessa/pokebattle/issues{/number}","pulls_url":"https://api.github.com/repos/vanessa/pokebattle/pulls{/number}","milestones_url":"https://api.github.com/repos/vanessa/pokebattle/milestones{/number}","notifications_url":"https://api.github.com/repos/vanessa/pokebattle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanessa/pokebattle/labels{/name}","releases_url":"https://api.github.com/repos/vanessa/pokebattle/releases{/id}","deployments_url":"https://api.github.com/repos/vanessa/pokebattle/deployments","created_at":"2018-03-14T03:08:22Z","updated_at":"2018-04-10T19:54:29Z","pushed_at":"2018-04-17T22:30:14Z","git_url":"git://github.com/vanessa/pokebattle.git","ssh_url":"git@github.com:vanessa/pokebattle.git","clone_url":"https://github.com/vanessa/pokebattle.git","svn_url":"https://github.com/vanessa/pokebattle","homepage":"https://pokebattle-vanessa.herokuapp.com","size":635,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/vanessa/pokebattle/pulls/3"},"html":{"href":"https://github.com/vanessa/pokebattle/pull/3"},"issue":{"href":"https://api.github.com/repos/vanessa/pokebattle/issues/3"},"comments":{"href":"https://api.github.com/repos/vanessa/pokebattle/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/vanessa/pokebattle/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/vanessa/pokebattle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vanessa/pokebattle/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/vanessa/pokebattle/statuses/74effdebd2c40ab8d199a1706f925b01679822d0"}},"author_association":"OWNER"}}
{"actor":{"display_login":"rsarai"}}