{"action":"closed","number":68,"pull_request":{"url":"https://api.github.com/repos/magento-research/venia-pwa-concept/pulls/68","id":187101972,"html_url":"https://github.com/magento-research/venia-pwa-concept/pull/68","diff_url":"https://github.com/magento-research/venia-pwa-concept/pull/68.diff","patch_url":"https://github.com/magento-research/venia-pwa-concept/pull/68.patch","issue_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/issues/68","number":68,"state":"closed","locked":false,"title":"fix(sw): handle dev serviceworker 404","user":{"login":"zetlen","id":1643758,"avatar_url":"https://avatars3.githubusercontent.com/u/1643758?v=4","gravatar_id":"","url":"https://api.github.com/users/zetlen","html_url":"https://github.com/zetlen","followers_url":"https://api.github.com/users/zetlen/followers","following_url":"https://api.github.com/users/zetlen/following{/other_user}","gists_url":"https://api.github.com/users/zetlen/gists{/gist_id}","starred_url":"https://api.github.com/users/zetlen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetlen/subscriptions","organizations_url":"https://api.github.com/users/zetlen/orgs","repos_url":"https://api.github.com/users/zetlen/repos","events_url":"https://api.github.com/users/zetlen/events{/privacy}","received_events_url":"https://api.github.com/users/zetlen/received_events","type":"User","site_admin":false},"body":"Modified `src/index.js` to only register a service worker if `process.env.SERVICE_WORKER_FILE_NAME` is truthy.\r\n\r\nModified `webpack.config.js` to set `process.env.SERVICE_WORKER_FILE_NAME` to `false` in development mode, unless the special `ENABLE_SERVICE_WORKER_DEBUGGING` env var is truthy.\r\n\r\nNow, service workers are only generated OR requested:\r\n - in production\r\n - when they are directly under development, indicated by the env var `ENABLE_SERVICE_WORKER_DEBUGGING`.\r\n\r\nFixes #64.","created_at":"2018-05-10T05:06:30Z","updated_at":"2018-05-21T19:44:38Z","closed_at":"2018-05-21T19:44:38Z","merged_at":"2018-05-21T19:44:38Z","merge_commit_sha":"5874874310daaf88d62a96a2d28e7ad9d04d355d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jimbo","id":2110986,"avatar_url":"https://avatars1.githubusercontent.com/u/2110986?v=4","gravatar_id":"","url":"https://api.github.com/users/jimbo","html_url":"https://github.com/jimbo","followers_url":"https://api.github.com/users/jimbo/followers","following_url":"https://api.github.com/users/jimbo/following{/other_user}","gists_url":"https://api.github.com/users/jimbo/gists{/gist_id}","starred_url":"https://api.github.com/users/jimbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimbo/subscriptions","organizations_url":"https://api.github.com/users/jimbo/orgs","repos_url":"https://api.github.com/users/jimbo/repos","events_url":"https://api.github.com/users/jimbo/events{/privacy}","received_events_url":"https://api.github.com/users/jimbo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/pulls/68/commits","review_comments_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/pulls/68/comments","review_comment_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/issues/68/comments","statuses_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/statuses/575b8db3479e184b538656cde3d8a39e79ea923c","head":{"label":"magento-research:zetlen/no-register-sw-in-dev","ref":"zetlen/no-register-sw-in-dev","sha":"575b8db3479e184b538656cde3d8a39e79ea923c","user":{"login":"magento-research","id":26729824,"avatar_url":"https://avatars0.githubusercontent.com/u/26729824?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-research","html_url":"https://github.com/magento-research","followers_url":"https://api.github.com/users/magento-research/followers","following_url":"https://api.github.com/users/magento-research/following{/other_user}","gists_url":"https://api.github.com/users/magento-research/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-research/subscriptions","organizations_url":"https://api.github.com/users/magento-research/orgs","repos_url":"https://api.github.com/users/magento-research/repos","events_url":"https://api.github.com/users/magento-research/events{/privacy}","received_events_url":"https://api.github.com/users/magento-research/received_events","type":"Organization","site_admin":false},"repo":{"id":112776997,"name":"venia-pwa-concept","full_name":"magento-research/venia-pwa-concept","owner":{"login":"magento-research","id":26729824,"avatar_url":"https://avatars0.githubusercontent.com/u/26729824?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-research","html_url":"https://github.com/magento-research","followers_url":"https://api.github.com/users/magento-research/followers","following_url":"https://api.github.com/users/magento-research/following{/other_user}","gists_url":"https://api.github.com/users/magento-research/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-research/subscriptions","organizations_url":"https://api.github.com/users/magento-research/orgs","repos_url":"https://api.github.com/users/magento-research/repos","events_url":"https://api.github.com/users/magento-research/events{/privacy}","received_events_url":"https://api.github.com/users/magento-research/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento-research/venia-pwa-concept","description":"⚠️Experimental playground of the new PWA theme for Magento 2 based on the Peregrine component library and Buildpack tools","fork":false,"url":"https://api.github.com/repos/magento-research/venia-pwa-concept","forks_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/forks","keys_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/teams","hooks_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/hooks","issue_events_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/issues/events{/number}","events_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/events","assignees_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/assignees{/user}","branches_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/branches{/branch}","tags_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/tags","blobs_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/statuses/{sha}","languages_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/languages","stargazers_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/stargazers","contributors_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/contributors","subscribers_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/subscribers","subscription_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/subscription","commits_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/contents/{+path}","compare_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/merges","archive_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/downloads","issues_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/issues{/number}","pulls_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/pulls{/number}","milestones_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/milestones{/number}","notifications_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/labels{/name}","releases_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/releases{/id}","deployments_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/deployments","created_at":"2017-12-01T19:10:47Z","updated_at":"2018-05-18T20:05:11Z","pushed_at":"2018-05-21T19:44:38Z","git_url":"git://github.com/magento-research/venia-pwa-concept.git","ssh_url":"git@github.com:magento-research/venia-pwa-concept.git","clone_url":"https://github.com/magento-research/venia-pwa-concept.git","svn_url":"https://github.com/magento-research/venia-pwa-concept","homepage":"","size":1464,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":6,"open_issues":13,"watchers":27,"default_branch":"master"}},"base":{"label":"magento-research:master","ref":"master","sha":"5f1be992069853abe721f957245c307cc09f7b7f","user":{"login":"magento-research","id":26729824,"avatar_url":"https://avatars0.githubusercontent.com/u/26729824?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-research","html_url":"https://github.com/magento-research","followers_url":"https://api.github.com/users/magento-research/followers","following_url":"https://api.github.com/users/magento-research/following{/other_user}","gists_url":"https://api.github.com/users/magento-research/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-research/subscriptions","organizations_url":"https://api.github.com/users/magento-research/orgs","repos_url":"https://api.github.com/users/magento-research/repos","events_url":"https://api.github.com/users/magento-research/events{/privacy}","received_events_url":"https://api.github.com/users/magento-research/received_events","type":"Organization","site_admin":false},"repo":{"id":112776997,"name":"venia-pwa-concept","full_name":"magento-research/venia-pwa-concept","owner":{"login":"magento-research","id":26729824,"avatar_url":"https://avatars0.githubusercontent.com/u/26729824?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-research","html_url":"https://github.com/magento-research","followers_url":"https://api.github.com/users/magento-research/followers","following_url":"https://api.github.com/users/magento-research/following{/other_user}","gists_url":"https://api.github.com/users/magento-research/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-research/subscriptions","organizations_url":"https://api.github.com/users/magento-research/orgs","repos_url":"https://api.github.com/users/magento-research/repos","events_url":"https://api.github.com/users/magento-research/events{/privacy}","received_events_url":"https://api.github.com/users/magento-research/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento-research/venia-pwa-concept","description":"⚠️Experimental playground of the new PWA theme for Magento 2 based on the Peregrine component library and Buildpack tools","fork":false,"url":"https://api.github.com/repos/magento-research/venia-pwa-concept","forks_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/forks","keys_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/teams","hooks_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/hooks","issue_events_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/issues/events{/number}","events_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/events","assignees_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/assignees{/user}","branches_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/branches{/branch}","tags_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/tags","blobs_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/statuses/{sha}","languages_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/languages","stargazers_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/stargazers","contributors_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/contributors","subscribers_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/subscribers","subscription_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/subscription","commits_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/contents/{+path}","compare_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/merges","archive_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/downloads","issues_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/issues{/number}","pulls_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/pulls{/number}","milestones_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/milestones{/number}","notifications_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/labels{/name}","releases_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/releases{/id}","deployments_url":"https://api.github.com/repos/magento-research/venia-pwa-concept/deployments","created_at":"2017-12-01T19:10:47Z","updated_at":"2018-05-18T20:05:11Z","pushed_at":"2018-05-21T19:44:38Z","git_url":"git://github.com/magento-research/venia-pwa-concept.git","ssh_url":"git@github.com:magento-research/venia-pwa-concept.git","clone_url":"https://github.com/magento-research/venia-pwa-concept.git","svn_url":"https://github.com/magento-research/venia-pwa-concept","homepage":"","size":1464,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":6,"open_issues":13,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magento-research/venia-pwa-concept/pulls/68"},"html":{"href":"https://github.com/magento-research/venia-pwa-concept/pull/68"},"issue":{"href":"https://api.github.com/repos/magento-research/venia-pwa-concept/issues/68"},"comments":{"href":"https://api.github.com/repos/magento-research/venia-pwa-concept/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/magento-research/venia-pwa-concept/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/magento-research/venia-pwa-concept/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento-research/venia-pwa-concept/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/magento-research/venia-pwa-concept/statuses/575b8db3479e184b538656cde3d8a39e79ea923c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zetlen","id":1643758,"avatar_url":"https://avatars3.githubusercontent.com/u/1643758?v=4","gravatar_id":"","url":"https://api.github.com/users/zetlen","html_url":"https://github.com/zetlen","followers_url":"https://api.github.com/users/zetlen/followers","following_url":"https://api.github.com/users/zetlen/following{/other_user}","gists_url":"https://api.github.com/users/zetlen/gists{/gist_id}","starred_url":"https://api.github.com/users/zetlen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetlen/subscriptions","organizations_url":"https://api.github.com/users/zetlen/orgs","repos_url":"https://api.github.com/users/zetlen/repos","events_url":"https://api.github.com/users/zetlen/events{/privacy}","received_events_url":"https://api.github.com/users/zetlen/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":4,"additions":33,"deletions":14,"changed_files":3}}
{"actor":{"display_login":"zetlen"}}