{"action":"created","comment":{"url":"https://api.github.com/repos/freenas/freenas/pulls/comments/239826163","pull_request_review_id":182716870,"id":239826163,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTgyNjE2Mw==","diff_hunk":"@@ -143,6 +146,11 @@ def __call__(self, value):\n             raise ValueError('Please provide a valid MAC address')\n \n \n+class ReplicationSnapshotNamingSchema:\n+    def __call__(self, value):\n+        validate_snapshot_naming_schema(value)","path":"src/middlewared/middlewared/validators.py","position":17,"original_position":17,"commit_id":"fb4b2c76c1fd5a0fbf96b5738b4ffe9d837a9c55","original_commit_id":"85240201ee8fa8dcc9781455feaf17480245f320","user":{"login":"william-gr","id":56250,"node_id":"MDQ6VXNlcjU2MjUw","avatar_url":"https://avatars0.githubusercontent.com/u/56250?v=4","gravatar_id":"","url":"https://api.github.com/users/william-gr","html_url":"https://github.com/william-gr","followers_url":"https://api.github.com/users/william-gr/followers","following_url":"https://api.github.com/users/william-gr/following{/other_user}","gists_url":"https://api.github.com/users/william-gr/gists{/gist_id}","starred_url":"https://api.github.com/users/william-gr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william-gr/subscriptions","organizations_url":"https://api.github.com/users/william-gr/orgs","repos_url":"https://api.github.com/users/william-gr/repos","events_url":"https://api.github.com/users/william-gr/events{/privacy}","received_events_url":"https://api.github.com/users/william-gr/received_events","type":"User","site_admin":false},"body":"Fair enough","created_at":"2018-12-07T14:32:15Z","updated_at":"2018-12-07T14:32:15Z","html_url":"https://github.com/freenas/freenas/pull/1921#discussion_r239826163","pull_request_url":"https://api.github.com/repos/freenas/freenas/pulls/1921","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/freenas/freenas/pulls/comments/239826163"},"html":{"href":"https://github.com/freenas/freenas/pull/1921#discussion_r239826163"},"pull_request":{"href":"https://api.github.com/repos/freenas/freenas/pulls/1921"}},"in_reply_to_id":239798011},"pull_request":{"url":"https://api.github.com/repos/freenas/freenas/pulls/1921","id":223351033,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMzUxMDMz","html_url":"https://github.com/freenas/freenas/pull/1921","diff_url":"https://github.com/freenas/freenas/pull/1921.diff","patch_url":"https://github.com/freenas/freenas/pull/1921.patch","issue_url":"https://api.github.com/repos/freenas/freenas/issues/1921","number":1921,"state":"open","locked":false,"title":"tkt-27076: zettarepl UI","user":{"login":"themylogin","id":669257,"node_id":"MDQ6VXNlcjY2OTI1Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/669257?v=4","gravatar_id":"","url":"https://api.github.com/users/themylogin","html_url":"https://github.com/themylogin","followers_url":"https://api.github.com/users/themylogin/followers","following_url":"https://api.github.com/users/themylogin/following{/other_user}","gists_url":"https://api.github.com/users/themylogin/gists{/gist_id}","starred_url":"https://api.github.com/users/themylogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themylogin/subscriptions","organizations_url":"https://api.github.com/users/themylogin/orgs","repos_url":"https://api.github.com/users/themylogin/repos","events_url":"https://api.github.com/users/themylogin/events{/privacy}","received_events_url":"https://api.github.com/users/themylogin/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-16T18:26:10Z","updated_at":"2018-12-07T14:32:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16fbd0928e47397e078f60f41fbf4250b4d82236","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/freenas/freenas/pulls/1921/commits","review_comments_url":"https://api.github.com/repos/freenas/freenas/pulls/1921/comments","review_comment_url":"https://api.github.com/repos/freenas/freenas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freenas/freenas/issues/1921/comments","statuses_url":"https://api.github.com/repos/freenas/freenas/statuses/fb4b2c76c1fd5a0fbf96b5738b4ffe9d837a9c55","head":{"label":"freenas:FIX-27076","ref":"FIX-27076","sha":"fb4b2c76c1fd5a0fbf96b5738b4ffe9d837a9c55","user":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"repo":{"id":8627760,"node_id":"MDEwOlJlcG9zaXRvcnk4NjI3NzYw","name":"freenas","full_name":"freenas/freenas","private":false,"owner":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freenas/freenas","description":"FreeNAS Git Repository","fork":false,"url":"https://api.github.com/repos/freenas/freenas","forks_url":"https://api.github.com/repos/freenas/freenas/forks","keys_url":"https://api.github.com/repos/freenas/freenas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenas/freenas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenas/freenas/teams","hooks_url":"https://api.github.com/repos/freenas/freenas/hooks","issue_events_url":"https://api.github.com/repos/freenas/freenas/issues/events{/number}","events_url":"https://api.github.com/repos/freenas/freenas/events","assignees_url":"https://api.github.com/repos/freenas/freenas/assignees{/user}","branches_url":"https://api.github.com/repos/freenas/freenas/branches{/branch}","tags_url":"https://api.github.com/repos/freenas/freenas/tags","blobs_url":"https://api.github.com/repos/freenas/freenas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenas/freenas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenas/freenas/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenas/freenas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenas/freenas/statuses/{sha}","languages_url":"https://api.github.com/repos/freenas/freenas/languages","stargazers_url":"https://api.github.com/repos/freenas/freenas/stargazers","contributors_url":"https://api.github.com/repos/freenas/freenas/contributors","subscribers_url":"https://api.github.com/repos/freenas/freenas/subscribers","subscription_url":"https://api.github.com/repos/freenas/freenas/subscription","commits_url":"https://api.github.com/repos/freenas/freenas/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenas/freenas/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenas/freenas/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenas/freenas/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenas/freenas/contents/{+path}","compare_url":"https://api.github.com/repos/freenas/freenas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenas/freenas/merges","archive_url":"https://api.github.com/repos/freenas/freenas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenas/freenas/downloads","issues_url":"https://api.github.com/repos/freenas/freenas/issues{/number}","pulls_url":"https://api.github.com/repos/freenas/freenas/pulls{/number}","milestones_url":"https://api.github.com/repos/freenas/freenas/milestones{/number}","notifications_url":"https://api.github.com/repos/freenas/freenas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenas/freenas/labels{/name}","releases_url":"https://api.github.com/repos/freenas/freenas/releases{/id}","deployments_url":"https://api.github.com/repos/freenas/freenas/deployments","created_at":"2013-03-07T13:23:20Z","updated_at":"2018-12-07T11:40:40Z","pushed_at":"2018-12-07T14:27:21Z","git_url":"git://github.com/freenas/freenas.git","ssh_url":"git@github.com:freenas/freenas.git","clone_url":"https://github.com/freenas/freenas.git","svn_url":"https://github.com/freenas/freenas","homepage":"http://www.freenas.org","size":531486,"stargazers_count":1092,"watchers_count":1092,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":303,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":303,"open_issues":11,"watchers":1092,"default_branch":"master"}},"base":{"label":"freenas:master","ref":"master","sha":"1151b4d31b30643dba2665e07811906024bd8dfd","user":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"repo":{"id":8627760,"node_id":"MDEwOlJlcG9zaXRvcnk4NjI3NzYw","name":"freenas","full_name":"freenas/freenas","private":false,"owner":{"login":"freenas","id":3792476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTI0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freenas/freenas","description":"FreeNAS Git Repository","fork":false,"url":"https://api.github.com/repos/freenas/freenas","forks_url":"https://api.github.com/repos/freenas/freenas/forks","keys_url":"https://api.github.com/repos/freenas/freenas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenas/freenas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenas/freenas/teams","hooks_url":"https://api.github.com/repos/freenas/freenas/hooks","issue_events_url":"https://api.github.com/repos/freenas/freenas/issues/events{/number}","events_url":"https://api.github.com/repos/freenas/freenas/events","assignees_url":"https://api.github.com/repos/freenas/freenas/assignees{/user}","branches_url":"https://api.github.com/repos/freenas/freenas/branches{/branch}","tags_url":"https://api.github.com/repos/freenas/freenas/tags","blobs_url":"https://api.github.com/repos/freenas/freenas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenas/freenas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenas/freenas/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenas/freenas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenas/freenas/statuses/{sha}","languages_url":"https://api.github.com/repos/freenas/freenas/languages","stargazers_url":"https://api.github.com/repos/freenas/freenas/stargazers","contributors_url":"https://api.github.com/repos/freenas/freenas/contributors","subscribers_url":"https://api.github.com/repos/freenas/freenas/subscribers","subscription_url":"https://api.github.com/repos/freenas/freenas/subscription","commits_url":"https://api.github.com/repos/freenas/freenas/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenas/freenas/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenas/freenas/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenas/freenas/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenas/freenas/contents/{+path}","compare_url":"https://api.github.com/repos/freenas/freenas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenas/freenas/merges","archive_url":"https://api.github.com/repos/freenas/freenas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenas/freenas/downloads","issues_url":"https://api.github.com/repos/freenas/freenas/issues{/number}","pulls_url":"https://api.github.com/repos/freenas/freenas/pulls{/number}","milestones_url":"https://api.github.com/repos/freenas/freenas/milestones{/number}","notifications_url":"https://api.github.com/repos/freenas/freenas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenas/freenas/labels{/name}","releases_url":"https://api.github.com/repos/freenas/freenas/releases{/id}","deployments_url":"https://api.github.com/repos/freenas/freenas/deployments","created_at":"2013-03-07T13:23:20Z","updated_at":"2018-12-07T11:40:40Z","pushed_at":"2018-12-07T14:27:21Z","git_url":"git://github.com/freenas/freenas.git","ssh_url":"git@github.com:freenas/freenas.git","clone_url":"https://github.com/freenas/freenas.git","svn_url":"https://github.com/freenas/freenas","homepage":"http://www.freenas.org","size":531486,"stargazers_count":1092,"watchers_count":1092,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":303,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":303,"open_issues":11,"watchers":1092,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freenas/freenas/pulls/1921"},"html":{"href":"https://github.com/freenas/freenas/pull/1921"},"issue":{"href":"https://api.github.com/repos/freenas/freenas/issues/1921"},"comments":{"href":"https://api.github.com/repos/freenas/freenas/issues/1921/comments"},"review_comments":{"href":"https://api.github.com/repos/freenas/freenas/pulls/1921/comments"},"review_comment":{"href":"https://api.github.com/repos/freenas/freenas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freenas/freenas/pulls/1921/commits"},"statuses":{"href":"https://api.github.com/repos/freenas/freenas/statuses/fb4b2c76c1fd5a0fbf96b5738b4ffe9d837a9c55"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"william-gr"}}