{"action":"created","comment":{"url":"https://api.github.com/repos/govCMS/govcmslagoon/pulls/comments/244965992","pull_request_review_id":188968724,"id":244965992,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDk2NTk5Mg==","diff_hunk":"@@ -24,3 +24,8 @@ LOCALDEV_URL_NGINX=http://govcms-lagoon-nginx.docker.amazee.io\n \n # Namespace for resulting Docker images.\n DOCKERHUB_NAMESPACE=govcmslagoon\n+\n+# X-Frame-Options header. Default disallows embedding content (e.g via iFrame) from any external domain.\n+# Note: Seckit click-jacking configuration will need altering to suit if changed.\n+# See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options\n+X_FRAME_OPTIONS=SameOrigin","path":".env.default","position":8,"original_position":8,"commit_id":"31abff76dd2b5b93cd0633aef442b4409b7d8cd5","original_commit_id":"31abff76dd2b5b93cd0633aef442b4409b7d8cd5","user":{"login":"srowlands","id":1256274,"node_id":"MDQ6VXNlcjEyNTYyNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1256274?v=4","gravatar_id":"","url":"https://api.github.com/users/srowlands","html_url":"https://github.com/srowlands","followers_url":"https://api.github.com/users/srowlands/followers","following_url":"https://api.github.com/users/srowlands/following{/other_user}","gists_url":"https://api.github.com/users/srowlands/gists{/gist_id}","starred_url":"https://api.github.com/users/srowlands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowlands/subscriptions","organizations_url":"https://api.github.com/users/srowlands/orgs","repos_url":"https://api.github.com/users/srowlands/repos","events_url":"https://api.github.com/users/srowlands/events{/privacy}","received_events_url":"https://api.github.com/users/srowlands/received_events","type":"User","site_admin":false},"body":"Defaults to SameOrigin. May be `none|allowall|allow-from` etc","created_at":"2019-01-03T10:59:26Z","updated_at":"2019-01-03T10:59:26Z","html_url":"https://github.com/govCMS/govcmslagoon/pull/58#discussion_r244965992","pull_request_url":"https://api.github.com/repos/govCMS/govcmslagoon/pulls/58","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/govCMS/govcmslagoon/pulls/comments/244965992"},"html":{"href":"https://github.com/govCMS/govcmslagoon/pull/58#discussion_r244965992"},"pull_request":{"href":"https://api.github.com/repos/govCMS/govcmslagoon/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/govCMS/govcmslagoon/pulls/58","id":241962301,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxOTYyMzAx","html_url":"https://github.com/govCMS/govcmslagoon/pull/58","diff_url":"https://github.com/govCMS/govcmslagoon/pull/58.diff","patch_url":"https://github.com/govCMS/govcmslagoon/pull/58.patch","issue_url":"https://api.github.com/repos/govCMS/govcmslagoon/issues/58","number":58,"state":"open","locked":false,"title":"Allow x-frame-options override to Nginx + Drupal core.","user":{"login":"srowlands","id":1256274,"node_id":"MDQ6VXNlcjEyNTYyNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1256274?v=4","gravatar_id":"","url":"https://api.github.com/users/srowlands","html_url":"https://github.com/srowlands","followers_url":"https://api.github.com/users/srowlands/followers","following_url":"https://api.github.com/users/srowlands/following{/other_user}","gists_url":"https://api.github.com/users/srowlands/gists{/gist_id}","starred_url":"https://api.github.com/users/srowlands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowlands/subscriptions","organizations_url":"https://api.github.com/users/srowlands/orgs","repos_url":"https://api.github.com/users/srowlands/repos","events_url":"https://api.github.com/users/srowlands/events{/privacy}","received_events_url":"https://api.github.com/users/srowlands/received_events","type":"User","site_admin":false},"body":"D8 version: https://github.com/govCMS/govcms8lagoon/pull/19\r\n\r\nProvides support to individual projects allowing control over X-Frame-Options when embedding content elsewhere.\r\n\r\nThe default remains as `SAMEORIGIN`, and a change in `.env` alone is not enough to make the change occur. Seckit click-jacking will also need to be disabled, as it is installed with a default header value of `SAMEORIGIN` as well - so this needs to be configured to suit in cases where this is allowed.","created_at":"2019-01-03T10:57:58Z","updated_at":"2019-01-03T10:59:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c32c8a42acad708b300e5b78f5013fb1d64444cb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"thom8","id":331453,"node_id":"MDQ6VXNlcjMzMTQ1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/331453?v=4","gravatar_id":"","url":"https://api.github.com/users/thom8","html_url":"https://github.com/thom8","followers_url":"https://api.github.com/users/thom8/followers","following_url":"https://api.github.com/users/thom8/following{/other_user}","gists_url":"https://api.github.com/users/thom8/gists{/gist_id}","starred_url":"https://api.github.com/users/thom8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thom8/subscriptions","organizations_url":"https://api.github.com/users/thom8/orgs","repos_url":"https://api.github.com/users/thom8/repos","events_url":"https://api.github.com/users/thom8/events{/privacy}","received_events_url":"https://api.github.com/users/thom8/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/govCMS/govcmslagoon/pulls/58/commits","review_comments_url":"https://api.github.com/repos/govCMS/govcmslagoon/pulls/58/comments","review_comment_url":"https://api.github.com/repos/govCMS/govcmslagoon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/govCMS/govcmslagoon/issues/58/comments","statuses_url":"https://api.github.com/repos/govCMS/govcmslagoon/statuses/31abff76dd2b5b93cd0633aef442b4409b7d8cd5","head":{"label":"govCMS:feature/GCMSLG-1-xframeoptions","ref":"feature/GCMSLG-1-xframeoptions","sha":"31abff76dd2b5b93cd0633aef442b4409b7d8cd5","user":{"login":"govCMS","id":9474842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NzQ4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9474842?v=4","gravatar_id":"","url":"https://api.github.com/users/govCMS","html_url":"https://github.com/govCMS","followers_url":"https://api.github.com/users/govCMS/followers","following_url":"https://api.github.com/users/govCMS/following{/other_user}","gists_url":"https://api.github.com/users/govCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/govCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govCMS/subscriptions","organizations_url":"https://api.github.com/users/govCMS/orgs","repos_url":"https://api.github.com/users/govCMS/repos","events_url":"https://api.github.com/users/govCMS/events{/privacy}","received_events_url":"https://api.github.com/users/govCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":146371616,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzNzE2MTY=","name":"govcmslagoon","full_name":"govCMS/govcmslagoon","private":false,"owner":{"login":"govCMS","id":9474842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NzQ4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9474842?v=4","gravatar_id":"","url":"https://api.github.com/users/govCMS","html_url":"https://github.com/govCMS","followers_url":"https://api.github.com/users/govCMS/followers","following_url":"https://api.github.com/users/govCMS/following{/other_user}","gists_url":"https://api.github.com/users/govCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/govCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govCMS/subscriptions","organizations_url":"https://api.github.com/users/govCMS/orgs","repos_url":"https://api.github.com/users/govCMS/repos","events_url":"https://api.github.com/users/govCMS/events{/privacy}","received_events_url":"https://api.github.com/users/govCMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/govCMS/govcmslagoon","description":"GovCMS Lagoon","fork":false,"url":"https://api.github.com/repos/govCMS/govcmslagoon","forks_url":"https://api.github.com/repos/govCMS/govcmslagoon/forks","keys_url":"https://api.github.com/repos/govCMS/govcmslagoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/govCMS/govcmslagoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/govCMS/govcmslagoon/teams","hooks_url":"https://api.github.com/repos/govCMS/govcmslagoon/hooks","issue_events_url":"https://api.github.com/repos/govCMS/govcmslagoon/issues/events{/number}","events_url":"https://api.github.com/repos/govCMS/govcmslagoon/events","assignees_url":"https://api.github.com/repos/govCMS/govcmslagoon/assignees{/user}","branches_url":"https://api.github.com/repos/govCMS/govcmslagoon/branches{/branch}","tags_url":"https://api.github.com/repos/govCMS/govcmslagoon/tags","blobs_url":"https://api.github.com/repos/govCMS/govcmslagoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/govCMS/govcmslagoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/govCMS/govcmslagoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/govCMS/govcmslagoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/govCMS/govcmslagoon/statuses/{sha}","languages_url":"https://api.github.com/repos/govCMS/govcmslagoon/languages","stargazers_url":"https://api.github.com/repos/govCMS/govcmslagoon/stargazers","contributors_url":"https://api.github.com/repos/govCMS/govcmslagoon/contributors","subscribers_url":"https://api.github.com/repos/govCMS/govcmslagoon/subscribers","subscription_url":"https://api.github.com/repos/govCMS/govcmslagoon/subscription","commits_url":"https://api.github.com/repos/govCMS/govcmslagoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/govCMS/govcmslagoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/govCMS/govcmslagoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/govCMS/govcmslagoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/govCMS/govcmslagoon/contents/{+path}","compare_url":"https://api.github.com/repos/govCMS/govcmslagoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/govCMS/govcmslagoon/merges","archive_url":"https://api.github.com/repos/govCMS/govcmslagoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/govCMS/govcmslagoon/downloads","issues_url":"https://api.github.com/repos/govCMS/govcmslagoon/issues{/number}","pulls_url":"https://api.github.com/repos/govCMS/govcmslagoon/pulls{/number}","milestones_url":"https://api.github.com/repos/govCMS/govcmslagoon/milestones{/number}","notifications_url":"https://api.github.com/repos/govCMS/govcmslagoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/govCMS/govcmslagoon/labels{/name}","releases_url":"https://api.github.com/repos/govCMS/govcmslagoon/releases{/id}","deployments_url":"https://api.github.com/repos/govCMS/govcmslagoon/deployments","created_at":"2018-08-28T00:54:35Z","updated_at":"2018-12-11T05:10:24Z","pushed_at":"2019-01-03T10:57:59Z","git_url":"git://github.com/govCMS/govcmslagoon.git","ssh_url":"git@github.com:govCMS/govcmslagoon.git","clone_url":"https://github.com/govCMS/govcmslagoon.git","svn_url":"https://github.com/govCMS/govcmslagoon","homepage":"","size":565,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"govCMS:master","ref":"master","sha":"0328c2923b033f148a7beb2cd7c42b2b32c6ebaa","user":{"login":"govCMS","id":9474842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NzQ4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9474842?v=4","gravatar_id":"","url":"https://api.github.com/users/govCMS","html_url":"https://github.com/govCMS","followers_url":"https://api.github.com/users/govCMS/followers","following_url":"https://api.github.com/users/govCMS/following{/other_user}","gists_url":"https://api.github.com/users/govCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/govCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govCMS/subscriptions","organizations_url":"https://api.github.com/users/govCMS/orgs","repos_url":"https://api.github.com/users/govCMS/repos","events_url":"https://api.github.com/users/govCMS/events{/privacy}","received_events_url":"https://api.github.com/users/govCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":146371616,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzNzE2MTY=","name":"govcmslagoon","full_name":"govCMS/govcmslagoon","private":false,"owner":{"login":"govCMS","id":9474842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NzQ4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9474842?v=4","gravatar_id":"","url":"https://api.github.com/users/govCMS","html_url":"https://github.com/govCMS","followers_url":"https://api.github.com/users/govCMS/followers","following_url":"https://api.github.com/users/govCMS/following{/other_user}","gists_url":"https://api.github.com/users/govCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/govCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govCMS/subscriptions","organizations_url":"https://api.github.com/users/govCMS/orgs","repos_url":"https://api.github.com/users/govCMS/repos","events_url":"https://api.github.com/users/govCMS/events{/privacy}","received_events_url":"https://api.github.com/users/govCMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/govCMS/govcmslagoon","description":"GovCMS Lagoon","fork":false,"url":"https://api.github.com/repos/govCMS/govcmslagoon","forks_url":"https://api.github.com/repos/govCMS/govcmslagoon/forks","keys_url":"https://api.github.com/repos/govCMS/govcmslagoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/govCMS/govcmslagoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/govCMS/govcmslagoon/teams","hooks_url":"https://api.github.com/repos/govCMS/govcmslagoon/hooks","issue_events_url":"https://api.github.com/repos/govCMS/govcmslagoon/issues/events{/number}","events_url":"https://api.github.com/repos/govCMS/govcmslagoon/events","assignees_url":"https://api.github.com/repos/govCMS/govcmslagoon/assignees{/user}","branches_url":"https://api.github.com/repos/govCMS/govcmslagoon/branches{/branch}","tags_url":"https://api.github.com/repos/govCMS/govcmslagoon/tags","blobs_url":"https://api.github.com/repos/govCMS/govcmslagoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/govCMS/govcmslagoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/govCMS/govcmslagoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/govCMS/govcmslagoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/govCMS/govcmslagoon/statuses/{sha}","languages_url":"https://api.github.com/repos/govCMS/govcmslagoon/languages","stargazers_url":"https://api.github.com/repos/govCMS/govcmslagoon/stargazers","contributors_url":"https://api.github.com/repos/govCMS/govcmslagoon/contributors","subscribers_url":"https://api.github.com/repos/govCMS/govcmslagoon/subscribers","subscription_url":"https://api.github.com/repos/govCMS/govcmslagoon/subscription","commits_url":"https://api.github.com/repos/govCMS/govcmslagoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/govCMS/govcmslagoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/govCMS/govcmslagoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/govCMS/govcmslagoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/govCMS/govcmslagoon/contents/{+path}","compare_url":"https://api.github.com/repos/govCMS/govcmslagoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/govCMS/govcmslagoon/merges","archive_url":"https://api.github.com/repos/govCMS/govcmslagoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/govCMS/govcmslagoon/downloads","issues_url":"https://api.github.com/repos/govCMS/govcmslagoon/issues{/number}","pulls_url":"https://api.github.com/repos/govCMS/govcmslagoon/pulls{/number}","milestones_url":"https://api.github.com/repos/govCMS/govcmslagoon/milestones{/number}","notifications_url":"https://api.github.com/repos/govCMS/govcmslagoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/govCMS/govcmslagoon/labels{/name}","releases_url":"https://api.github.com/repos/govCMS/govcmslagoon/releases{/id}","deployments_url":"https://api.github.com/repos/govCMS/govcmslagoon/deployments","created_at":"2018-08-28T00:54:35Z","updated_at":"2018-12-11T05:10:24Z","pushed_at":"2019-01-03T10:57:59Z","git_url":"git://github.com/govCMS/govcmslagoon.git","ssh_url":"git@github.com:govCMS/govcmslagoon.git","clone_url":"https://github.com/govCMS/govcmslagoon.git","svn_url":"https://github.com/govCMS/govcmslagoon","homepage":"","size":565,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/govCMS/govcmslagoon/pulls/58"},"html":{"href":"https://github.com/govCMS/govcmslagoon/pull/58"},"issue":{"href":"https://api.github.com/repos/govCMS/govcmslagoon/issues/58"},"comments":{"href":"https://api.github.com/repos/govCMS/govcmslagoon/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/govCMS/govcmslagoon/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/govCMS/govcmslagoon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/govCMS/govcmslagoon/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/govCMS/govcmslagoon/statuses/31abff76dd2b5b93cd0633aef442b4409b7d8cd5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"srowlands"}}