{"action":"created","issue":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5826","repository_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5826/labels{/name}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5826/comments","events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5826/events","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5826","id":351619366,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MTY3NDU1","number":5826,"title":"have import calculate the uploaded file checksum only once, not twice","user":{"login":"mtbc","id":2630707,"node_id":"MDQ6VXNlcjI2MzA3MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2630707?v=4","gravatar_id":"","url":"https://api.github.com/users/mtbc","html_url":"https://github.com/mtbc","followers_url":"https://api.github.com/users/mtbc/followers","following_url":"https://api.github.com/users/mtbc/following{/other_user}","gists_url":"https://api.github.com/users/mtbc/gists{/gist_id}","starred_url":"https://api.github.com/users/mtbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtbc/subscriptions","organizations_url":"https://api.github.com/users/mtbc/orgs","repos_url":"https://api.github.com/users/mtbc/repos","events_url":"https://api.github.com/users/mtbc/events{/privacy}","received_events_url":"https://api.github.com/users/mtbc/received_events","type":"User","site_admin":false},"labels":[{"id":12053304,"node_id":"MDU6TGFiZWwxMjA1MzMwNA==","url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/labels/develop","name":"develop","color":"02e10c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/milestones/58","html_url":"https://github.com/openmicroscopy/openmicroscopy/milestone/58","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/milestones/58/labels","id":3525182,"node_id":"MDk6TWlsZXN0b25lMzUyNTE4Mg==","number":58,"title":"5.4.8","description":"","creator":{"login":"jburel","id":1022396,"node_id":"MDQ6VXNlcjEwMjIzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1022396?v=4","gravatar_id":"","url":"https://api.github.com/users/jburel","html_url":"https://github.com/jburel","followers_url":"https://api.github.com/users/jburel/followers","following_url":"https://api.github.com/users/jburel/following{/other_user}","gists_url":"https://api.github.com/users/jburel/gists{/gist_id}","starred_url":"https://api.github.com/users/jburel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburel/subscriptions","organizations_url":"https://api.github.com/users/jburel/orgs","repos_url":"https://api.github.com/users/jburel/repos","events_url":"https://api.github.com/users/jburel/events{/privacy}","received_events_url":"https://api.github.com/users/jburel/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":5,"state":"open","created_at":"2018-07-26T12:26:32Z","updated_at":"2018-08-29T06:58:06Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2018-08-17T14:35:28Z","updated_at":"2018-08-30T07:44:32Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/5826","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5826","diff_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5826.diff","patch_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5826.patch"},"body":"# What this PR does\r\n\r\n@joshmoore discovered that import calculates each file checksum twice over. This PR reduces that to being only once.\r\n\r\n# Testing this PR\r\n\r\nImport should still work fine with no regressions. To try to break it: In the CLI you can try the `--checksum-algorithm` option and with the server configuration you can adjust `omero.checksum.supported` to force selection of different algorithms.\r\n\r\n# Related reading\r\n\r\nhttps://trello.com/c/BPrkScBc/36-file-upload-should-be-faster"},"comment":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/comments/417222494","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5826#issuecomment-417222494","issue_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5826","id":417222494,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzIyMjQ5NA==","user":{"login":"mtbc","id":2630707,"node_id":"MDQ6VXNlcjI2MzA3MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2630707?v=4","gravatar_id":"","url":"https://api.github.com/users/mtbc","html_url":"https://github.com/mtbc","followers_url":"https://api.github.com/users/mtbc/followers","following_url":"https://api.github.com/users/mtbc/following{/other_user}","gists_url":"https://api.github.com/users/mtbc/gists{/gist_id}","starred_url":"https://api.github.com/users/mtbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtbc/subscriptions","organizations_url":"https://api.github.com/users/mtbc/orgs","repos_url":"https://api.github.com/users/mtbc/repos","events_url":"https://api.github.com/users/mtbc/events{/privacy}","received_events_url":"https://api.github.com/users/mtbc/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T07:44:32Z","updated_at":"2018-08-30T07:44:32Z","author_association":"MEMBER","body":"After hacking the server to make the query fail:\r\n```\r\n2018-08-30 08:41:58,784 ERROR [    o.s.blitz.repo.ManagedImportProcessI] (.Server-10) no server checksum on imported file cf4b0d48-0998-491e-94c7-0a8fa7c53240_556/2018-08/30/08-41-57.762/image.fake\r\njava.lang.IndexOutOfBoundsException: Index: 0, Size: 0\r\n\tat java.util.ArrayList.rangeCheck(ArrayList.java:657) ~[na:1.8.0_181]\r\n\tat java.util.ArrayList.get(ArrayList.java:433) ~[na:1.8.0_181]\r\n\tat ome.services.blitz.repo.ManagedImportProcessI.verifyUpload(ManagedImportProcessI.java:350) ~[blitz.jar:na]\r\n...\r\n```"}}
{"actor":{"display_login":"mtbc"}}