{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/comments/175325501","pull_request_review_id":104834371,"id":175325501,"diff_hunk":"@@ -78,8 +79,11 @@ const JaegerAPI = {\n   fetchTrace(id) {\n     return getJSON(`${this.apiRoot}traces/${id}`);\n   },\n+  archiveTrace(id) {","path":"src/api/jaeger.js","position":20,"original_position":20,"commit_id":"69a2ac898aabd81da37defcf2f94e8c80f1322b6","original_commit_id":"a0f014ba5ed5054d12cce6703d8e61835191376b","user":{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars2.githubusercontent.com/u/3523016?v=4","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"body":"we ARE providing a message on successful save.","created_at":"2018-03-19T03:45:40Z","updated_at":"2018-03-19T03:45:40Z","html_url":"https://github.com/jaegertracing/jaeger-ui/pull/194#discussion_r175325501","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/194","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/comments/175325501"},"html":{"href":"https://github.com/jaegertracing/jaeger-ui/pull/194#discussion_r175325501"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/194"}},"in_reply_to_id":172648657},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/194","id":173086011,"html_url":"https://github.com/jaegertracing/jaeger-ui/pull/194","diff_url":"https://github.com/jaegertracing/jaeger-ui/pull/194.diff","patch_url":"https://github.com/jaegertracing/jaeger-ui/pull/194.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/194","number":194,"state":"open","locked":false,"title":"Support archiving traces, enabled via UI config","user":{"login":"tiffon","id":2304337,"avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false},"body":"Partially addresses #7.\r\n\r\n## TODO\r\n\r\n- ~Add a tooltip on the archive button that states it's for archiving a trace~\r\n- [x] See about getting an icon that is more iconic of archiving\r\n\r\n## Enabling Archiving\r\n\r\nThe archive functionality is hidden behind the UI config flag `archiveEnabled`, which is `false`, by default as archiving only works with Cassandra.\r\n\r\n## Normal UX\r\n\r\nClicking the archive button raises a notification with a loading spinner.\r\n\r\nWhen the HTTP call completes, the spinner notification is closed (if the user did not close it) and a second notification is raised showing the outcome. \r\n\r\nIf the outcome is success, then a success message is shown.\r\n\r\nIf the outcome is an error, then error details are shown.\r\n\r\n## Small Edge Case\r\n\r\nThe user should acknowledge the result notification (success or error). This is done by closing the notification. If the user doesn't close the notification but exits the trace view, the notification will be redisplayed if the user re-enters that trace detail (for that particular trace) during the session. The same applies if the user exits the trace view while the archive is in progress.\r\n\r\n## Screens\r\n\r\n### The archive button\r\n\r\n<img width=\"544\" alt=\"screen shot 2018-03-08 at 11 04 31 am\" src=\"https://user-images.githubusercontent.com/2304337/37161413-a01f229c-22c0-11e8-8243-c8505f26eadf.png\">\r\n\r\n--------\r\n\r\n### Button hover\r\n\r\n<img width=\"541\" alt=\"screen shot 2018-03-08 at 11 04 42 am\" src=\"https://user-images.githubusercontent.com/2304337/37161425-a8fc8152-22c0-11e8-821f-390dfb9644c8.png\">\r\n\r\n--------\r\n\r\n### In progress notification\r\n\r\n<img width=\"1160\" alt=\"02-in-progress\" src=\"https://user-images.githubusercontent.com/2304337/37020795-1ba9ab12-20eb-11e8-8119-c0b949230bc1.png\">\r\n\r\n--------\r\n\r\n### Success notification\r\n\r\n<img width=\"1160\" alt=\"03-success\" src=\"https://user-images.githubusercontent.com/2304337/37020798-20f5e900-20eb-11e8-8990-70993dae4bad.png\">\r\n\r\n--------\r\n\r\n### Error notification\r\nNote: This error is shown just as an example of an error to show. This particular error should be very easy to avoid as the system administrator needs to simple keep archiving disabled if they're not using Cassandra.\r\n\r\nAlso, the error message styling (global) was tweaked a bit.\r\n\r\n<img width=\"1160\" alt=\"04-error-message\" src=\"https://user-images.githubusercontent.com/2304337/37020807-26442912-20eb-11e8-950a-35f0d0571ccb.png\">\r\n\r\n--------\r\n\r\n### Button is hidden due to UI config\r\n\r\n<img width=\"1160\" alt=\"05-button-disabled\" src=\"https://user-images.githubusercontent.com/2304337/37020811-2a69ecf2-20eb-11e8-9cf1-c7c09cfc2224.png\">","created_at":"2018-03-06T08:17:51Z","updated_at":"2018-03-19T03:45:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b44e13a918518700e5115a8f9ed2f5a0015d19a","assignee":{"login":"tiffon","id":2304337,"avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false},"assignees":[{"login":"tiffon","id":2304337,"avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":786707068,"url":"https://api.github.com/repos/jaegertracing/jaeger-ui/labels/review","name":"review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/194/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/194/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/194/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/statuses/69a2ac898aabd81da37defcf2f94e8c80f1322b6","head":{"label":"jaegertracing:archive-button","ref":"archive-button","sha":"69a2ac898aabd81da37defcf2f94e8c80f1322b6","user":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":82920852,"name":"jaeger-ui","full_name":"jaegertracing/jaeger-ui","owner":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/jaeger-ui","description":"Web UI for Jaeger","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger-ui","forks_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/deployments","created_at":"2017-02-23T11:30:29Z","updated_at":"2018-03-18T13:50:03Z","pushed_at":"2018-03-19T03:36:44Z","git_url":"git://github.com/jaegertracing/jaeger-ui.git","ssh_url":"git@github.com:jaegertracing/jaeger-ui.git","clone_url":"https://github.com/jaegertracing/jaeger-ui.git","svn_url":"https://github.com/jaegertracing/jaeger-ui","homepage":"http://jaegertracing.io/","size":2350,"stargazers_count":96,"watchers_count":96,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":22,"open_issues":37,"watchers":96,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"2e6d1a429fb4ec2345d0a6e2f7e804b371079323","user":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":82920852,"name":"jaeger-ui","full_name":"jaegertracing/jaeger-ui","owner":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/jaeger-ui","description":"Web UI for Jaeger","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger-ui","forks_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/deployments","created_at":"2017-02-23T11:30:29Z","updated_at":"2018-03-18T13:50:03Z","pushed_at":"2018-03-19T03:36:44Z","git_url":"git://github.com/jaegertracing/jaeger-ui.git","ssh_url":"git@github.com:jaegertracing/jaeger-ui.git","clone_url":"https://github.com/jaegertracing/jaeger-ui.git","svn_url":"https://github.com/jaegertracing/jaeger-ui","homepage":"http://jaegertracing.io/","size":2350,"stargazers_count":96,"watchers_count":96,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":22,"open_issues":37,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/194"},"html":{"href":"https://github.com/jaegertracing/jaeger-ui/pull/194"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/194"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/statuses/69a2ac898aabd81da37defcf2f94e8c80f1322b6"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"yurishkuro"}}