{"action":"created","issue":{"url":"https://api.github.com/repos/monero-project/monero/issues/3261","repository_url":"https://api.github.com/repos/monero-project/monero","labels_url":"https://api.github.com/repos/monero-project/monero/issues/3261/labels{/name}","comments_url":"https://api.github.com/repos/monero-project/monero/issues/3261/comments","events_url":"https://api.github.com/repos/monero-project/monero/issues/3261/events","html_url":"https://github.com/monero-project/monero/pull/3261","id":296940061,"number":3261,"title":"Use `genesis_tx` parameter in `generate_genesis_block`.","user":{"login":"jeandudey","id":5952531,"avatar_url":"https://avatars0.githubusercontent.com/u/5952531?v=4","gravatar_id":"","url":"https://api.github.com/users/jeandudey","html_url":"https://github.com/jeandudey","followers_url":"https://api.github.com/users/jeandudey/followers","following_url":"https://api.github.com/users/jeandudey/following{/other_user}","gists_url":"https://api.github.com/users/jeandudey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeandudey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeandudey/subscriptions","organizations_url":"https://api.github.com/users/jeandudey/orgs","repos_url":"https://api.github.com/users/jeandudey/repos","events_url":"https://api.github.com/users/jeandudey/events{/privacy}","received_events_url":"https://api.github.com/users/jeandudey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-14T00:54:08Z","updated_at":"2018-02-14T13:05:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/monero-project/monero/pulls/3261","html_url":"https://github.com/monero-project/monero/pull/3261","diff_url":"https://github.com/monero-project/monero/pull/3261.diff","patch_url":"https://github.com/monero-project/monero/pull/3261.patch"},"body":"This might probably break testnet because it was using the mainnet genesis tx."},"comment":{"url":"https://api.github.com/repos/monero-project/monero/issues/comments/365601294","html_url":"https://github.com/monero-project/monero/pull/3261#issuecomment-365601294","issue_url":"https://api.github.com/repos/monero-project/monero/issues/3261","id":365601294,"user":{"login":"jeandudey","id":5952531,"avatar_url":"https://avatars0.githubusercontent.com/u/5952531?v=4","gravatar_id":"","url":"https://api.github.com/users/jeandudey","html_url":"https://github.com/jeandudey","followers_url":"https://api.github.com/users/jeandudey/followers","following_url":"https://api.github.com/users/jeandudey/following{/other_user}","gists_url":"https://api.github.com/users/jeandudey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeandudey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeandudey/subscriptions","organizations_url":"https://api.github.com/users/jeandudey/orgs","repos_url":"https://api.github.com/users/jeandudey/repos","events_url":"https://api.github.com/users/jeandudey/events{/privacy}","received_events_url":"https://api.github.com/users/jeandudey/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T13:05:30Z","updated_at":"2018-02-14T13:05:30Z","author_association":"NONE","body":"@moneromooo-monero in that case I think i can change the `testnet::GENESIS_TX` constant to be the same as the mainnet `GENESIS_TX`, in theory anything can't be broke because these constants are only used in `generate_genesis_tx`. Or we can remove the `genesis_tx` parameter and remove these branches at [`Blockchain::init`][1].\r\n\r\n[1]: https://github.com/monero-project/monero/blob/master/src/cryptonote_core/blockchain.cpp#L370"}}
{"actor":{"display_login":"jeandudey"}}