{"action":"created","comment":{"url":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments/170465472","pull_request_review_id":99154356,"id":170465472,"diff_hunk":"@@ -8,24 +10,34 @@ export const globals = {\n   'graphql-anywhere': 'graphqlAnywhere',\n };\n \n-export default (name, override = {}) =>\n-  Object.assign(\n+export default (name, override = {}) => {\n+  const config = Object.assign(\n     {\n       input: 'lib/index.js',\n-      output: {\n-        file: 'lib/bundle.umd.js',\n-        format: 'umd',\n-      },\n+      //output: merged separately\n+      onwarn,\n+      external: Object.keys(globals),\n+    },\n+    override,\n+  );\n+\n+  config.output = Object.assign(\n+    {\n+      file: 'lib/bundle.umd.js',\n+      format: 'umd',\n       name,","path":"rollup.config.js","position":31,"original_position":31,"commit_id":"41752ba17a40736dfc388cfc28aab40fce2bde7b","original_commit_id":"41752ba17a40736dfc388cfc28aab40fce2bde7b","user":{"login":"fbartho","id":209712,"avatar_url":"https://avatars2.githubusercontent.com/u/209712?v=4","gravatar_id":"","url":"https://api.github.com/users/fbartho","html_url":"https://github.com/fbartho","followers_url":"https://api.github.com/users/fbartho/followers","following_url":"https://api.github.com/users/fbartho/following{/other_user}","gists_url":"https://api.github.com/users/fbartho/gists{/gist_id}","starred_url":"https://api.github.com/users/fbartho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbartho/subscriptions","organizations_url":"https://api.github.com/users/fbartho/orgs","repos_url":"https://api.github.com/users/fbartho/repos","events_url":"https://api.github.com/users/fbartho/events{/privacy}","received_events_url":"https://api.github.com/users/fbartho/received_events","type":"User","site_admin":false},"body":"If you look at the structure of this diff, I think there's a bug.\r\n\r\nIt looks like you're embedding fields that were outside of `config.output`, into the output object. ","created_at":"2018-02-25T20:13:50Z","updated_at":"2018-02-25T20:15:06Z","html_url":"https://github.com/apollographql/apollo-client/pull/3042#discussion_r170465472","pull_request_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/3042","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments/170465472"},"html":{"href":"https://github.com/apollographql/apollo-client/pull/3042#discussion_r170465472"},"pull_request":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/3042"}}},"pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-client/pulls/3042","id":170026176,"html_url":"https://github.com/apollographql/apollo-client/pull/3042","diff_url":"https://github.com/apollographql/apollo-client/pull/3042.diff","patch_url":"https://github.com/apollographql/apollo-client/pull/3042.patch","issue_url":"https://api.github.com/repos/apollographql/apollo-client/issues/3042","number":3042,"state":"open","locked":false,"title":"Sourcemaps for jest coverage and rollup bundles","user":{"login":"evans","id":5565407,"avatar_url":"https://avatars0.githubusercontent.com/u/5565407?v=4","gravatar_id":"","url":"https://api.github.com/users/evans","html_url":"https://github.com/evans","followers_url":"https://api.github.com/users/evans/followers","following_url":"https://api.github.com/users/evans/following{/other_user}","gists_url":"https://api.github.com/users/evans/gists{/gist_id}","starred_url":"https://api.github.com/users/evans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evans/subscriptions","organizations_url":"https://api.github.com/users/evans/orgs","repos_url":"https://api.github.com/users/evans/repos","events_url":"https://api.github.com/users/evans/events{/privacy}","received_events_url":"https://api.github.com/users/evans/received_events","type":"User","site_admin":false},"body":"The ts-jest package requires the `coverageMap` option to be enabled to get accurate coverage mapping back to the typescript files.\r\n\r\nThe rollup bundles' sourcemaps were pointing to the compiled javascript files, now they point a the ts files.","created_at":"2018-02-19T18:15:33Z","updated_at":"2018-02-25T20:15:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30c9e48481f3a5e447dfa055fede2fcaa4020b6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/3042/commits","review_comments_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/3042/comments","review_comment_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/issues/3042/comments","statuses_url":"https://api.github.com/repos/apollographql/apollo-client/statuses/41752ba17a40736dfc388cfc28aab40fce2bde7b","head":{"label":"apollographql:sourcemaps","ref":"sourcemaps","sha":"41752ba17a40736dfc388cfc28aab40fce2bde7b","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":52630616,"name":"apollo-client","full_name":"apollographql/apollo-client","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-client","description":":rocket: A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-client","forks_url":"https://api.github.com/repos/apollographql/apollo-client/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-client/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-client/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-client/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-client/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-client/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-client/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-client/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-client/deployments","created_at":"2016-02-26T20:25:00Z","updated_at":"2018-02-25T19:43:10Z","pushed_at":"2018-02-25T18:37:08Z","git_url":"git://github.com/apollographql/apollo-client.git","ssh_url":"git@github.com:apollographql/apollo-client.git","clone_url":"https://github.com/apollographql/apollo-client.git","svn_url":"https://github.com/apollographql/apollo-client","homepage":"https://www.apollographql.com/client/","size":8947,"stargazers_count":6169,"watchers_count":6169,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":623,"mirror_url":null,"archived":false,"open_issues_count":227,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":623,"open_issues":227,"watchers":6169,"default_branch":"master"}},"base":{"label":"apollographql:master","ref":"master","sha":"132a8b2693d1e81f632bd3d032ac9ef0ceae4a5d","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":52630616,"name":"apollo-client","full_name":"apollographql/apollo-client","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-client","description":":rocket: A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-client","forks_url":"https://api.github.com/repos/apollographql/apollo-client/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-client/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-client/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-client/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-client/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-client/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-client/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-client/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-client/deployments","created_at":"2016-02-26T20:25:00Z","updated_at":"2018-02-25T19:43:10Z","pushed_at":"2018-02-25T18:37:08Z","git_url":"git://github.com/apollographql/apollo-client.git","ssh_url":"git@github.com:apollographql/apollo-client.git","clone_url":"https://github.com/apollographql/apollo-client.git","svn_url":"https://github.com/apollographql/apollo-client","homepage":"https://www.apollographql.com/client/","size":8947,"stargazers_count":6169,"watchers_count":6169,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":623,"mirror_url":null,"archived":false,"open_issues_count":227,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":623,"open_issues":227,"watchers":6169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/3042"},"html":{"href":"https://github.com/apollographql/apollo-client/pull/3042"},"issue":{"href":"https://api.github.com/repos/apollographql/apollo-client/issues/3042"},"comments":{"href":"https://api.github.com/repos/apollographql/apollo-client/issues/3042/comments"},"review_comments":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/3042/comments"},"review_comment":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/3042/commits"},"statuses":{"href":"https://api.github.com/repos/apollographql/apollo-client/statuses/41752ba17a40736dfc388cfc28aab40fce2bde7b"}},"author_association":"OWNER"}}
{"actor":{"display_login":"fbartho"}}