{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/25196","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/25196/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/25196/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/25196/events","html_url":"https://github.com/cockroachdb/cockroach/pull/25196","id":319080165,"number":25196,"title":"acceptance: add a regression test for migrations","user":{"login":"andreimatei","id":377201,"avatar_url":"https://avatars1.githubusercontent.com/u/377201?v=4","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"assignees":[{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-05-01T00:28:06Z","updated_at":"2018-05-02T17:32:11Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/25196","html_url":"https://github.com/cockroachdb/cockroach/pull/25196","diff_url":"https://github.com/cockroachdb/cockroach/pull/25196.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/25196.patch"},"body":"We used to have a bug where a 2.0-beta node couldn't come up in a 1.1\r\ncluster if there were too many tables. This patch is a test for that.\r\nThe bug was #22370; it was a more general KV bug but migrations\r\ntriggered it.\r\n\r\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/386057911","html_url":"https://github.com/cockroachdb/cockroach/pull/25196#issuecomment-386057911","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/25196","id":386057911,"user":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T17:32:11Z","updated_at":"2018-05-02T17:32:11Z","author_association":"OWNER","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\n---\n\nReview status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.\n\n---\n\n*[pkg/acceptance/version_upgrade_test.go, line 285 at r1](https://reviewable.io/reviews/cockroachdb/cockroach/25196#-LBWuEI3CpyZSKOdHBML:-LBWuEI3CpyZSKOdHBMM:b5098t4) ([raw file](https://github.com/cockroachdb/cockroach/blob/6e7a3a81ebcf7846fd24c09d07a2c87240b464d4/pkg/acceptance/version_upgrade_test.go#L285)):*\n> ```Go\n> \t}\n> \tfor i := 0; i < 100; i++ {\n> \t\t_, err := db.Exec(fmt.Sprintf(\"create table lotsatables.t%d (x int primary key)\", i))\n> ```\n\nWhat's up with the `d` at the end of the table name?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/cockroachdb/cockroach/25196#-:-LBWuJXGDwvazOIADc52:bnfp4nl)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"nvanbenschoten"}}