{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/23004","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/23004/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/23004/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/23004/events","html_url":"https://github.com/mantidproject/mantid/pull/23004","id":342431134,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzMyNzEx","number":23004,"title":"Indirect - Data Analysis - Normalize by lowest temperature in ElasticWindowMultiple","user":{"login":"brandonhewer","id":15521164,"node_id":"MDQ6VXNlcjE1NTIxMTY0","avatar_url":"https://avatars0.githubusercontent.com/u/15521164?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonhewer","html_url":"https://github.com/brandonhewer","followers_url":"https://api.github.com/users/brandonhewer/followers","following_url":"https://api.github.com/users/brandonhewer/following{/other_user}","gists_url":"https://api.github.com/users/brandonhewer/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonhewer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonhewer/subscriptions","organizations_url":"https://api.github.com/users/brandonhewer/orgs","repos_url":"https://api.github.com/users/brandonhewer/repos","events_url":"https://api.github.com/users/brandonhewer/events{/privacy}","received_events_url":"https://api.github.com/users/brandonhewer/received_events","type":"User","site_admin":false},"labels":[{"id":172781547,"node_id":"MDU6TGFiZWwxNzI3ODE1NDc=","url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Indirect%20Inelastic","name":"Component: Indirect Inelastic","color":"009800","default":false},{"id":40046083,"node_id":"MDU6TGFiZWw0MDA0NjA4Mw==","url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Bug","name":"Misc: Bug","color":"d4c5f9","default":false},{"id":35408850,"node_id":"MDU6TGFiZWwzNTQwODg1MA==","url":"https://api.github.com/repos/mantidproject/mantid/labels/Priority:%20High","name":"Priority: High","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":{"login":"martyngigg","id":733773,"node_id":"MDQ6VXNlcjczMzc3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/733773?v=4","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"assignees":[{"login":"martyngigg","id":733773,"node_id":"MDQ6VXNlcjczMzc3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/733773?v=4","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/67","html_url":"https://github.com/mantidproject/mantid/milestone/67","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/67/labels","id":3113719,"node_id":"MDk6TWlsZXN0b25lMzExMzcxOQ==","number":67,"title":"Release 3.13","description":"Code Freeze: 29th June\r\nBeta Test: 3rd-17th July","creator":{"login":"NickDraper","id":1017173,"node_id":"MDQ6VXNlcjEwMTcxNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":662,"state":"open","created_at":"2018-02-13T15:37:12Z","updated_at":"2018-07-19T08:25:16Z","due_on":"2018-07-23T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-07-18T17:55:49Z","updated_at":"2018-07-19T09:20:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/23004","html_url":"https://github.com/mantidproject/mantid/pull/23004","diff_url":"https://github.com/mantidproject/mantid/pull/23004.diff","patch_url":"https://github.com/mantidproject/mantid/pull/23004.patch"},"body":"\r\n**Report to:** Sanghamitra\r\n\r\nIn the ElasticWindowMultiple algorithm, each spectrum should be normalized by the y-value corresponding to the lowest temperature -- this is currently not the case and as a result the output of this algorithm is incorrect.\r\n\r\nThe ElasticWindowMultiple algorithm already sorts the x-axis -- as such the y-value value corresponding to the lowest temperature is always the first y-value in the spectrum.\r\n\r\nThis PR modifies the call to normalize_by_index in ElasticWindowMultiple -- simply passing 0.\r\n\r\n**To test:**\r\n1. Navigate to Interfaces > Indirect > Data Analysis > Elwin.\r\n2. Provide the supplied file as input.\r\n3. Tick the option ‘Normalise to lowest temperature’\r\n4. Click 'Run'.\r\n5. The output `*_elt` workspace should be equivalent to transposing the `*_eq` workspace, sorting the x-axis and then normalizing each column by the first column (as such the first column should be filled with 1s).\r\n\r\n**Test Files:**\r\n[irs26176_graphite002_red.zip](https://github.com/mantidproject/mantid/files/2206818/irs26176_graphite002_red.zip)\r\n\r\n\r\n<!-- Instructions for testing. -->\r\n\r\nFixes #23002. <!-- and fix #xxxx or close #xxxx xor resolves #xxxx -->\r\n\r\nDoes this update require release notes?\r\n- [ ] Yes\r\n- [ ] No\r\n<!--\r\nIf yes, edit the file docs/source/release/... \r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/406212333","html_url":"https://github.com/mantidproject/mantid/pull/23004#issuecomment-406212333","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/23004","id":406212333,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjIxMjMzMw==","user":{"login":"keeeto","id":3697636,"node_id":"MDQ6VXNlcjM2OTc2MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3697636?v=4","gravatar_id":"","url":"https://api.github.com/users/keeeto","html_url":"https://github.com/keeeto","followers_url":"https://api.github.com/users/keeeto/followers","following_url":"https://api.github.com/users/keeeto/following{/other_user}","gists_url":"https://api.github.com/users/keeeto/gists{/gist_id}","starred_url":"https://api.github.com/users/keeeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keeeto/subscriptions","organizations_url":"https://api.github.com/users/keeeto/orgs","repos_url":"https://api.github.com/users/keeeto/repos","events_url":"https://api.github.com/users/keeeto/events{/privacy}","received_events_url":"https://api.github.com/users/keeeto/received_events","type":"User","site_admin":false},"created_at":"2018-07-19T09:20:10Z","updated_at":"2018-07-19T09:20:10Z","author_association":"CONTRIBUTOR","body":"I don't see an `_elt` file - does this mean `_elf`?"}}
{"actor":{"display_login":"keeeto"}}