{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc/issues/16979","repository_url":"https://api.github.com/repos/grpc/grpc","labels_url":"https://api.github.com/repos/grpc/grpc/issues/16979/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/16979/comments","events_url":"https://api.github.com/repos/grpc/grpc/issues/16979/events","html_url":"https://github.com/grpc/grpc/pull/16979","id":373237011,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjEzNzc1","number":16979,"title":"Fix deadlock issue in HTTP2 connector","user":{"login":"yashykt","id":4181124,"node_id":"MDQ6VXNlcjQxODExMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4181124?v=4","gravatar_id":"","url":"https://api.github.com/users/yashykt","html_url":"https://github.com/yashykt","followers_url":"https://api.github.com/users/yashykt/followers","following_url":"https://api.github.com/users/yashykt/following{/other_user}","gists_url":"https://api.github.com/users/yashykt/gists{/gist_id}","starred_url":"https://api.github.com/users/yashykt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yashykt/subscriptions","organizations_url":"https://api.github.com/users/yashykt/orgs","repos_url":"https://api.github.com/users/yashykt/repos","events_url":"https://api.github.com/users/yashykt/events{/privacy}","received_events_url":"https://api.github.com/users/yashykt/received_events","type":"User","site_admin":false},"labels":[{"id":166332944,"node_id":"MDU6TGFiZWwxNjYzMzI5NDQ=","url":"https://api.github.com/repos/grpc/grpc/labels/lang/node","name":"lang/node","color":"fad8c7","default":false},{"id":961831639,"node_id":"MDU6TGFiZWw5NjE4MzE2Mzk=","url":"https://api.github.com/repos/grpc/grpc/labels/release%20notes:%20yes","name":"release notes: yes","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"ncteisen","id":6148140,"node_id":"MDQ6VXNlcjYxNDgxNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6148140?v=4","gravatar_id":"","url":"https://api.github.com/users/ncteisen","html_url":"https://github.com/ncteisen","followers_url":"https://api.github.com/users/ncteisen/followers","following_url":"https://api.github.com/users/ncteisen/following{/other_user}","gists_url":"https://api.github.com/users/ncteisen/gists{/gist_id}","starred_url":"https://api.github.com/users/ncteisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncteisen/subscriptions","organizations_url":"https://api.github.com/users/ncteisen/orgs","repos_url":"https://api.github.com/users/ncteisen/repos","events_url":"https://api.github.com/users/ncteisen/events{/privacy}","received_events_url":"https://api.github.com/users/ncteisen/received_events","type":"User","site_admin":false},"assignees":[{"login":"ncteisen","id":6148140,"node_id":"MDQ6VXNlcjYxNDgxNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6148140?v=4","gravatar_id":"","url":"https://api.github.com/users/ncteisen","html_url":"https://github.com/ncteisen","followers_url":"https://api.github.com/users/ncteisen/followers","following_url":"https://api.github.com/users/ncteisen/following{/other_user}","gists_url":"https://api.github.com/users/ncteisen/gists{/gist_id}","starred_url":"https://api.github.com/users/ncteisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncteisen/subscriptions","organizations_url":"https://api.github.com/users/ncteisen/orgs","repos_url":"https://api.github.com/users/ncteisen/repos","events_url":"https://api.github.com/users/ncteisen/events{/privacy}","received_events_url":"https://api.github.com/users/ncteisen/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-10-23T22:59:51Z","updated_at":"2018-10-25T00:55:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/16979","html_url":"https://github.com/grpc/grpc/pull/16979","diff_url":"https://github.com/grpc/grpc/pull/16979.diff","patch_url":"https://github.com/grpc/grpc/pull/16979.patch"},"body":"Fix for #16427\r\nSome tcp connect implementations require flushing closures before returning. This would result in a deadlock for the connector because the closure itself needs a lock, and currently the closure would be run while holding the lock."},"comment":{"url":"https://api.github.com/repos/grpc/grpc/issues/comments/432876604","html_url":"https://github.com/grpc/grpc/pull/16979#issuecomment-432876604","issue_url":"https://api.github.com/repos/grpc/grpc/issues/16979","id":432876604,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjg3NjYwNA==","user":{"login":"ncteisen","id":6148140,"node_id":"MDQ6VXNlcjYxNDgxNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6148140?v=4","gravatar_id":"","url":"https://api.github.com/users/ncteisen","html_url":"https://github.com/ncteisen","followers_url":"https://api.github.com/users/ncteisen/followers","following_url":"https://api.github.com/users/ncteisen/following{/other_user}","gists_url":"https://api.github.com/users/ncteisen/gists{/gist_id}","starred_url":"https://api.github.com/users/ncteisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncteisen/subscriptions","organizations_url":"https://api.github.com/users/ncteisen/orgs","repos_url":"https://api.github.com/users/ncteisen/repos","events_url":"https://api.github.com/users/ncteisen/events{/privacy}","received_events_url":"https://api.github.com/users/ncteisen/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T00:55:51Z","updated_at":"2018-10-25T00:55:51Z","author_association":"CONTRIBUTOR","body":"So `grpc_tcp_client_connect` is now doing all of its mutations outside of a lock? How do we have a guarantee that the things it is touching won't be modified or deallocated? Could you add a note in the code about how this is safe"}}
{"actor":{"display_login":"ncteisen"}}