{"action":"created","comment":{"url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls/comments/196052341","pull_request_review_id":129531621,"id":196052341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjA1MjM0MQ==","diff_hunk":"@@ -43,40 +43,32 @@ export class KickOffJenkinsBuild implements HandleCommand<HandlerResult> {\n \n     @Parameter({\n         description: \"team name\",\n-        required: false,\n         displayable: false,\n+        required: false,\n     })\n     public teamName: string;\n \n-    @Parameter({\n+    @RecursiveParameter({\n         description: \"project name\",\n-        required: false,\n-        displayable: false,\n     })\n     public projectName: string;\n \n-    @Parameter({\n+    @RecursiveParameter({\n         description: \"application name\",\n-        required: false,\n-        displayable: false,\n     })\n     public applicationName: string;\n \n-    public handle(ctx: HandlerContext): Promise<HandlerResult> {\n-        if (_.isEmpty(this.teamName) || _.isEmpty(this.projectName) || _.isEmpty(this.applicationName)) {","path":"src/gluon/jenkins/JenkinsBuild.ts","position":60,"original_position":52,"commit_id":"8371ec3c5fce7fd9daf2fac7db440259755b813f","original_commit_id":"5652e87dff715f5772bb8d064450dc288cef6d08","user":{"login":"kbristow","id":4415392,"node_id":"MDQ6VXNlcjQ0MTUzOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/4415392?v=4","gravatar_id":"","url":"https://api.github.com/users/kbristow","html_url":"https://github.com/kbristow","followers_url":"https://api.github.com/users/kbristow/followers","following_url":"https://api.github.com/users/kbristow/following{/other_user}","gists_url":"https://api.github.com/users/kbristow/gists{/gist_id}","starred_url":"https://api.github.com/users/kbristow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbristow/subscriptions","organizations_url":"https://api.github.com/users/kbristow/orgs","repos_url":"https://api.github.com/users/kbristow/repos","events_url":"https://api.github.com/users/kbristow/events{/privacy}","received_events_url":"https://api.github.com/users/kbristow/received_events","type":"User","site_admin":false},"body":"Implementation basically this 1 class and 1 function if you are interested.\r\n\r\nhttps://github.com/absa-subatomic/quantum-mechanic/blob/master/src/gluon/shared/RecursiveParameterRequestCommand.ts#L63\r\n\r\nhttps://github.com/absa-subatomic/quantum-mechanic/blob/master/src/gluon/shared/RecursiveParameterRequestCommand.ts#L49\r\n\r\n","created_at":"2018-06-18T12:04:57Z","updated_at":"2018-06-18T12:04:58Z","html_url":"https://github.com/absa-subatomic/quantum-mechanic/pull/205#discussion_r196052341","pull_request_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls/205","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls/comments/196052341"},"html":{"href":"https://github.com/absa-subatomic/quantum-mechanic/pull/205#discussion_r196052341"},"pull_request":{"href":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls/205"}},"in_reply_to_id":196026813},"pull_request":{"url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls/205","id":195467084,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDY3MDg0","html_url":"https://github.com/absa-subatomic/quantum-mechanic/pull/205","diff_url":"https://github.com/absa-subatomic/quantum-mechanic/pull/205.diff","patch_url":"https://github.com/absa-subatomic/quantum-mechanic/pull/205.patch","issue_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/issues/205","number":205,"state":"open","locked":false,"title":"Migrate to recursive","user":{"login":"KieranHons","id":7325498,"node_id":"MDQ6VXNlcjczMjU0OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7325498?v=4","gravatar_id":"","url":"https://api.github.com/users/KieranHons","html_url":"https://github.com/KieranHons","followers_url":"https://api.github.com/users/KieranHons/followers","following_url":"https://api.github.com/users/KieranHons/following{/other_user}","gists_url":"https://api.github.com/users/KieranHons/gists{/gist_id}","starred_url":"https://api.github.com/users/KieranHons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KieranHons/subscriptions","organizations_url":"https://api.github.com/users/KieranHons/orgs","repos_url":"https://api.github.com/users/KieranHons/repos","events_url":"https://api.github.com/users/KieranHons/events{/privacy}","received_events_url":"https://api.github.com/users/KieranHons/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-18T09:27:39Z","updated_at":"2018-06-18T12:04:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90a14b9f32fe8ad480a9a63d131e7b75e9aaea72","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chriskieser","id":3274639,"node_id":"MDQ6VXNlcjMyNzQ2Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3274639?v=4","gravatar_id":"","url":"https://api.github.com/users/chriskieser","html_url":"https://github.com/chriskieser","followers_url":"https://api.github.com/users/chriskieser/followers","following_url":"https://api.github.com/users/chriskieser/following{/other_user}","gists_url":"https://api.github.com/users/chriskieser/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskieser/subscriptions","organizations_url":"https://api.github.com/users/chriskieser/orgs","repos_url":"https://api.github.com/users/chriskieser/repos","events_url":"https://api.github.com/users/chriskieser/events{/privacy}","received_events_url":"https://api.github.com/users/chriskieser/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls/205/commits","review_comments_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls/205/comments","review_comment_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/issues/205/comments","statuses_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/statuses/8371ec3c5fce7fd9daf2fac7db440259755b813f","head":{"label":"absa-subatomic:migrate-to-recursive","ref":"migrate-to-recursive","sha":"8371ec3c5fce7fd9daf2fac7db440259755b813f","user":{"login":"absa-subatomic","id":36147006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MTQ3MDA2","avatar_url":"https://avatars0.githubusercontent.com/u/36147006?v=4","gravatar_id":"","url":"https://api.github.com/users/absa-subatomic","html_url":"https://github.com/absa-subatomic","followers_url":"https://api.github.com/users/absa-subatomic/followers","following_url":"https://api.github.com/users/absa-subatomic/following{/other_user}","gists_url":"https://api.github.com/users/absa-subatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/absa-subatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/absa-subatomic/subscriptions","organizations_url":"https://api.github.com/users/absa-subatomic/orgs","repos_url":"https://api.github.com/users/absa-subatomic/repos","events_url":"https://api.github.com/users/absa-subatomic/events{/privacy}","received_events_url":"https://api.github.com/users/absa-subatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":120258858,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAyNTg4NTg=","name":"quantum-mechanic","full_name":"absa-subatomic/quantum-mechanic","owner":{"login":"absa-subatomic","id":36147006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MTQ3MDA2","avatar_url":"https://avatars0.githubusercontent.com/u/36147006?v=4","gravatar_id":"","url":"https://api.github.com/users/absa-subatomic","html_url":"https://github.com/absa-subatomic","followers_url":"https://api.github.com/users/absa-subatomic/followers","following_url":"https://api.github.com/users/absa-subatomic/following{/other_user}","gists_url":"https://api.github.com/users/absa-subatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/absa-subatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/absa-subatomic/subscriptions","organizations_url":"https://api.github.com/users/absa-subatomic/orgs","repos_url":"https://api.github.com/users/absa-subatomic/repos","events_url":"https://api.github.com/users/absa-subatomic/events{/privacy}","received_events_url":"https://api.github.com/users/absa-subatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/absa-subatomic/quantum-mechanic","description":null,"fork":false,"url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic","forks_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/forks","keys_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/teams","hooks_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/hooks","issue_events_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/issues/events{/number}","events_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/events","assignees_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/assignees{/user}","branches_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/branches{/branch}","tags_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/tags","blobs_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/git/refs{/sha}","trees_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/statuses/{sha}","languages_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/languages","stargazers_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/stargazers","contributors_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/contributors","subscribers_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/subscribers","subscription_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/subscription","commits_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/commits{/sha}","git_commits_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/git/commits{/sha}","comments_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/comments{/number}","issue_comment_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/issues/comments{/number}","contents_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/contents/{+path}","compare_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/merges","archive_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/downloads","issues_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/issues{/number}","pulls_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls{/number}","milestones_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/milestones{/number}","notifications_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/labels{/name}","releases_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/releases{/id}","deployments_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/deployments","created_at":"2018-02-05T05:25:45Z","updated_at":"2018-06-18T09:23:49Z","pushed_at":"2018-06-18T11:55:24Z","git_url":"git://github.com/absa-subatomic/quantum-mechanic.git","ssh_url":"git@github.com:absa-subatomic/quantum-mechanic.git","clone_url":"https://github.com/absa-subatomic/quantum-mechanic.git","svn_url":"https://github.com/absa-subatomic/quantum-mechanic","homepage":null,"size":581,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":40,"watchers":0,"default_branch":"master"}},"base":{"label":"absa-subatomic:master","ref":"master","sha":"2df2fc8af69097cc716ce4093ef607a21527f799","user":{"login":"absa-subatomic","id":36147006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MTQ3MDA2","avatar_url":"https://avatars0.githubusercontent.com/u/36147006?v=4","gravatar_id":"","url":"https://api.github.com/users/absa-subatomic","html_url":"https://github.com/absa-subatomic","followers_url":"https://api.github.com/users/absa-subatomic/followers","following_url":"https://api.github.com/users/absa-subatomic/following{/other_user}","gists_url":"https://api.github.com/users/absa-subatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/absa-subatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/absa-subatomic/subscriptions","organizations_url":"https://api.github.com/users/absa-subatomic/orgs","repos_url":"https://api.github.com/users/absa-subatomic/repos","events_url":"https://api.github.com/users/absa-subatomic/events{/privacy}","received_events_url":"https://api.github.com/users/absa-subatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":120258858,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAyNTg4NTg=","name":"quantum-mechanic","full_name":"absa-subatomic/quantum-mechanic","owner":{"login":"absa-subatomic","id":36147006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MTQ3MDA2","avatar_url":"https://avatars0.githubusercontent.com/u/36147006?v=4","gravatar_id":"","url":"https://api.github.com/users/absa-subatomic","html_url":"https://github.com/absa-subatomic","followers_url":"https://api.github.com/users/absa-subatomic/followers","following_url":"https://api.github.com/users/absa-subatomic/following{/other_user}","gists_url":"https://api.github.com/users/absa-subatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/absa-subatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/absa-subatomic/subscriptions","organizations_url":"https://api.github.com/users/absa-subatomic/orgs","repos_url":"https://api.github.com/users/absa-subatomic/repos","events_url":"https://api.github.com/users/absa-subatomic/events{/privacy}","received_events_url":"https://api.github.com/users/absa-subatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/absa-subatomic/quantum-mechanic","description":null,"fork":false,"url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic","forks_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/forks","keys_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/teams","hooks_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/hooks","issue_events_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/issues/events{/number}","events_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/events","assignees_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/assignees{/user}","branches_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/branches{/branch}","tags_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/tags","blobs_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/git/refs{/sha}","trees_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/statuses/{sha}","languages_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/languages","stargazers_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/stargazers","contributors_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/contributors","subscribers_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/subscribers","subscription_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/subscription","commits_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/commits{/sha}","git_commits_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/git/commits{/sha}","comments_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/comments{/number}","issue_comment_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/issues/comments{/number}","contents_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/contents/{+path}","compare_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/merges","archive_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/downloads","issues_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/issues{/number}","pulls_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls{/number}","milestones_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/milestones{/number}","notifications_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/labels{/name}","releases_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/releases{/id}","deployments_url":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/deployments","created_at":"2018-02-05T05:25:45Z","updated_at":"2018-06-18T09:23:49Z","pushed_at":"2018-06-18T11:55:24Z","git_url":"git://github.com/absa-subatomic/quantum-mechanic.git","ssh_url":"git@github.com:absa-subatomic/quantum-mechanic.git","clone_url":"https://github.com/absa-subatomic/quantum-mechanic.git","svn_url":"https://github.com/absa-subatomic/quantum-mechanic","homepage":null,"size":581,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":40,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls/205"},"html":{"href":"https://github.com/absa-subatomic/quantum-mechanic/pull/205"},"issue":{"href":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/issues/205"},"comments":{"href":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/issues/205/comments"},"review_comments":{"href":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls/205/comments"},"review_comment":{"href":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/pulls/205/commits"},"statuses":{"href":"https://api.github.com/repos/absa-subatomic/quantum-mechanic/statuses/8371ec3c5fce7fd9daf2fac7db440259755b813f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kbristow"}}