{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/168937176","pull_request_review_id":97389319,"id":168937176,"diff_hunk":"@@ -832,18 +833,18 @@ declare class Dockerode {\n   createContainer(options: Dockerode.ContainerCreateOptions, callback: Callback<Dockerode.Container>): void;\n   createContainer(options: Dockerode.ContainerCreateOptions): Promise<Dockerode.Container>;\n \n-  createImage(options: {}, callback: Callback<Dockerode.Image>): void;\n-  createImage(auth: any, options: {}, callback: Callback<Dockerode.Image>): void;\n-  createImage(options: {}): Promise<Dockerode.Image>;\n-  createImage(auth: any, options: {}): Promise<Dockerode.Image>;\n+  createImage(options: {}, callback: Callback<any>): void;","path":"types/dockerode/index.d.ts","position":16,"original_position":16,"commit_id":"8923b0dbcbacff3df0e517cfdb130cb550181cfb","original_commit_id":"8923b0dbcbacff3df0e517cfdb130cb550181cfb","user":{"login":"Seikho","id":5344189,"avatar_url":"https://avatars0.githubusercontent.com/u/5344189?v=4","gravatar_id":"","url":"https://api.github.com/users/Seikho","html_url":"https://github.com/Seikho","followers_url":"https://api.github.com/users/Seikho/followers","following_url":"https://api.github.com/users/Seikho/following{/other_user}","gists_url":"https://api.github.com/users/Seikho/gists{/gist_id}","starred_url":"https://api.github.com/users/Seikho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Seikho/subscriptions","organizations_url":"https://api.github.com/users/Seikho/orgs","repos_url":"https://api.github.com/users/Seikho/repos","events_url":"https://api.github.com/users/Seikho/events{/privacy}","received_events_url":"https://api.github.com/users/Seikho/received_events","type":"User","site_admin":false},"body":"Why are you changing these `any`? ","created_at":"2018-02-18T01:05:15Z","updated_at":"2018-02-18T01:06:00Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23744#discussion_r168937176","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23744","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/168937176"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23744#discussion_r168937176"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23744"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23744","id":169807192,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23744","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23744.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23744.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23744","number":23744,"state":"open","locked":false,"title":"Update types used for image creation in Dockerode","user":{"login":"thegecko","id":61341,"avatar_url":"https://avatars1.githubusercontent.com/u/61341?v=4","gravatar_id":"","url":"https://api.github.com/users/thegecko","html_url":"https://github.com/thegecko","followers_url":"https://api.github.com/users/thegecko/followers","following_url":"https://api.github.com/users/thegecko/following{/other_user}","gists_url":"https://api.github.com/users/thegecko/gists{/gist_id}","starred_url":"https://api.github.com/users/thegecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thegecko/subscriptions","organizations_url":"https://api.github.com/users/thegecko/orgs","repos_url":"https://api.github.com/users/thegecko/repos","events_url":"https://api.github.com/users/thegecko/events{/privacy}","received_events_url":"https://api.github.com/users/thegecko/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes:\r\nAll file-based functions also accept streams: https://github.com/apocas/dockerode/blob/master/lib/docker.js#L184\r\n- [x] Increase the version number in the header if appropriate.\r\n- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\n_Notes_\r\n\r\n- Changes were found/tested during the usage of Dockerode with TypeScript\r\n- The return type for createImage is actually `HTTP.IncomingMessage`, but followed the style of using `any` in the same way as similar methods\r\n- IMO, `any` return types should be replaced with correct types in a future PR\r\n\r\n","created_at":"2018-02-17T23:41:56Z","updated_at":"2018-02-18T01:06:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e30126c7ef76530a7261557c193bee60f484202f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":397523192,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23744/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23744/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23744/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/8923b0dbcbacff3df0e517cfdb130cb550181cfb","head":{"label":"thegecko:master","ref":"master","sha":"8923b0dbcbacff3df0e517cfdb130cb550181cfb","user":{"login":"thegecko","id":61341,"avatar_url":"https://avatars1.githubusercontent.com/u/61341?v=4","gravatar_id":"","url":"https://api.github.com/users/thegecko","html_url":"https://github.com/thegecko","followers_url":"https://api.github.com/users/thegecko/followers","following_url":"https://api.github.com/users/thegecko/following{/other_user}","gists_url":"https://api.github.com/users/thegecko/gists{/gist_id}","starred_url":"https://api.github.com/users/thegecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thegecko/subscriptions","organizations_url":"https://api.github.com/users/thegecko/orgs","repos_url":"https://api.github.com/users/thegecko/repos","events_url":"https://api.github.com/users/thegecko/events{/privacy}","received_events_url":"https://api.github.com/users/thegecko/received_events","type":"User","site_admin":false},"repo":{"id":121768890,"name":"DefinitelyTyped","full_name":"thegecko/DefinitelyTyped","owner":{"login":"thegecko","id":61341,"avatar_url":"https://avatars1.githubusercontent.com/u/61341?v=4","gravatar_id":"","url":"https://api.github.com/users/thegecko","html_url":"https://github.com/thegecko","followers_url":"https://api.github.com/users/thegecko/followers","following_url":"https://api.github.com/users/thegecko/following{/other_user}","gists_url":"https://api.github.com/users/thegecko/gists{/gist_id}","starred_url":"https://api.github.com/users/thegecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thegecko/subscriptions","organizations_url":"https://api.github.com/users/thegecko/orgs","repos_url":"https://api.github.com/users/thegecko/repos","events_url":"https://api.github.com/users/thegecko/events{/privacy}","received_events_url":"https://api.github.com/users/thegecko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thegecko/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/thegecko/DefinitelyTyped","forks_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/thegecko/DefinitelyTyped/deployments","created_at":"2018-02-16T15:52:14Z","updated_at":"2018-02-16T15:52:37Z","pushed_at":"2018-02-17T23:30:35Z","git_url":"git://github.com/thegecko/DefinitelyTyped.git","ssh_url":"git@github.com:thegecko/DefinitelyTyped.git","clone_url":"https://github.com/thegecko/DefinitelyTyped.git","svn_url":"https://github.com/thegecko/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":287286,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"628c63919ccf65554f6178755944d488c95369a1","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-02-17T19:42:04Z","pushed_at":"2018-02-18T00:40:12Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":288192,"stargazers_count":14309,"watchers_count":14309,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11914,"mirror_url":null,"archived":false,"open_issues_count":2022,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11914,"open_issues":2022,"watchers":14309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23744"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23744"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23744"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23744/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23744/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23744/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/8923b0dbcbacff3df0e517cfdb130cb550181cfb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Seikho"}}