{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/authentication/pulls/comments/172704109","pull_request_review_id":101767245,"id":172704109,"diff_hunk":"@@ -98,11 +98,11 @@ protected function getTokenFromQuery(ServerRequestInterface $request, $queryPara\n     {\n         $queryParams = $request->getQueryParams();\n \n-        if (isset($queryParams[$queryParam])) {\n-            return $queryParams[$queryParam];\n+        if (!array_key_exists($queryParam, $queryParams)) {","path":"src/Authenticator/TokenAuthenticator.php","position":21,"original_position":21,"commit_id":"3f1e22bd1fb219c92b082691b5d0f4483f8f7a01","original_commit_id":"3f1e22bd1fb219c92b082691b5d0f4483f8f7a01","user":{"login":"dereuromark","id":39854,"avatar_url":"https://avatars0.githubusercontent.com/u/39854?v=4","gravatar_id":"","url":"https://api.github.com/users/dereuromark","html_url":"https://github.com/dereuromark","followers_url":"https://api.github.com/users/dereuromark/followers","following_url":"https://api.github.com/users/dereuromark/following{/other_user}","gists_url":"https://api.github.com/users/dereuromark/gists{/gist_id}","starred_url":"https://api.github.com/users/dereuromark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereuromark/subscriptions","organizations_url":"https://api.github.com/users/dereuromark/orgs","repos_url":"https://api.github.com/users/dereuromark/repos","events_url":"https://api.github.com/users/dereuromark/events{/privacy}","received_events_url":"https://api.github.com/users/dereuromark/received_events","type":"User","site_admin":false},"body":"isset doesnt do any auto-cast. array_key_exists() usually goes a) too fur, b) is 10-100x slower.","created_at":"2018-03-07T00:14:16Z","updated_at":"2018-03-07T00:14:16Z","html_url":"https://github.com/cakephp/authentication/pull/181#discussion_r172704109","pull_request_url":"https://api.github.com/repos/cakephp/authentication/pulls/181","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cakephp/authentication/pulls/comments/172704109"},"html":{"href":"https://github.com/cakephp/authentication/pull/181#discussion_r172704109"},"pull_request":{"href":"https://api.github.com/repos/cakephp/authentication/pulls/181"}},"in_reply_to_id":172671081},"pull_request":{"url":"https://api.github.com/repos/cakephp/authentication/pulls/181","id":173280503,"html_url":"https://github.com/cakephp/authentication/pull/181","diff_url":"https://github.com/cakephp/authentication/pull/181.diff","patch_url":"https://github.com/cakephp/authentication/pull/181.patch","issue_url":"https://api.github.com/repos/cakephp/authentication/issues/181","number":181,"state":"open","locked":false,"title":"more strict on nulls, ::class over string-class, early returns","user":{"login":"inoas","id":20972207,"avatar_url":"https://avatars0.githubusercontent.com/u/20972207?v=4","gravatar_id":"","url":"https://api.github.com/users/inoas","html_url":"https://github.com/inoas","followers_url":"https://api.github.com/users/inoas/followers","following_url":"https://api.github.com/users/inoas/following{/other_user}","gists_url":"https://api.github.com/users/inoas/gists{/gist_id}","starred_url":"https://api.github.com/users/inoas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoas/subscriptions","organizations_url":"https://api.github.com/users/inoas/orgs","repos_url":"https://api.github.com/users/inoas/repos","events_url":"https://api.github.com/users/inoas/events{/privacy}","received_events_url":"https://api.github.com/users/inoas/received_events","type":"User","site_admin":false},"body":"I hope I got the (hopefully) better parts of https://github.com/cakephp/authentication/pull/175 isolated.\r\nI still have a very bad feeling about `isset()` and `empty()` TBH and I feel things my gut feeling is that things might bite back in 7.1/7.2.","created_at":"2018-03-06T21:03:43Z","updated_at":"2018-03-07T00:14:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20ad298b291cf571f7f368abf588fa40c0ef7651","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cakephp/authentication/pulls/181/commits","review_comments_url":"https://api.github.com/repos/cakephp/authentication/pulls/181/comments","review_comment_url":"https://api.github.com/repos/cakephp/authentication/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/authentication/issues/181/comments","statuses_url":"https://api.github.com/repos/cakephp/authentication/statuses/3f1e22bd1fb219c92b082691b5d0f4483f8f7a01","head":{"label":"inoas:null-vs-empty-+-classes","ref":"null-vs-empty-+-classes","sha":"3f1e22bd1fb219c92b082691b5d0f4483f8f7a01","user":{"login":"inoas","id":20972207,"avatar_url":"https://avatars0.githubusercontent.com/u/20972207?v=4","gravatar_id":"","url":"https://api.github.com/users/inoas","html_url":"https://github.com/inoas","followers_url":"https://api.github.com/users/inoas/followers","following_url":"https://api.github.com/users/inoas/following{/other_user}","gists_url":"https://api.github.com/users/inoas/gists{/gist_id}","starred_url":"https://api.github.com/users/inoas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoas/subscriptions","organizations_url":"https://api.github.com/users/inoas/orgs","repos_url":"https://api.github.com/users/inoas/repos","events_url":"https://api.github.com/users/inoas/events{/privacy}","received_events_url":"https://api.github.com/users/inoas/received_events","type":"User","site_admin":false},"repo":{"id":114033092,"name":"authentication","full_name":"inoas/authentication","owner":{"login":"inoas","id":20972207,"avatar_url":"https://avatars0.githubusercontent.com/u/20972207?v=4","gravatar_id":"","url":"https://api.github.com/users/inoas","html_url":"https://github.com/inoas","followers_url":"https://api.github.com/users/inoas/followers","following_url":"https://api.github.com/users/inoas/following{/other_user}","gists_url":"https://api.github.com/users/inoas/gists{/gist_id}","starred_url":"https://api.github.com/users/inoas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoas/subscriptions","organizations_url":"https://api.github.com/users/inoas/orgs","repos_url":"https://api.github.com/users/inoas/repos","events_url":"https://api.github.com/users/inoas/events{/privacy}","received_events_url":"https://api.github.com/users/inoas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inoas/authentication","description":null,"fork":true,"url":"https://api.github.com/repos/inoas/authentication","forks_url":"https://api.github.com/repos/inoas/authentication/forks","keys_url":"https://api.github.com/repos/inoas/authentication/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inoas/authentication/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inoas/authentication/teams","hooks_url":"https://api.github.com/repos/inoas/authentication/hooks","issue_events_url":"https://api.github.com/repos/inoas/authentication/issues/events{/number}","events_url":"https://api.github.com/repos/inoas/authentication/events","assignees_url":"https://api.github.com/repos/inoas/authentication/assignees{/user}","branches_url":"https://api.github.com/repos/inoas/authentication/branches{/branch}","tags_url":"https://api.github.com/repos/inoas/authentication/tags","blobs_url":"https://api.github.com/repos/inoas/authentication/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inoas/authentication/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inoas/authentication/git/refs{/sha}","trees_url":"https://api.github.com/repos/inoas/authentication/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inoas/authentication/statuses/{sha}","languages_url":"https://api.github.com/repos/inoas/authentication/languages","stargazers_url":"https://api.github.com/repos/inoas/authentication/stargazers","contributors_url":"https://api.github.com/repos/inoas/authentication/contributors","subscribers_url":"https://api.github.com/repos/inoas/authentication/subscribers","subscription_url":"https://api.github.com/repos/inoas/authentication/subscription","commits_url":"https://api.github.com/repos/inoas/authentication/commits{/sha}","git_commits_url":"https://api.github.com/repos/inoas/authentication/git/commits{/sha}","comments_url":"https://api.github.com/repos/inoas/authentication/comments{/number}","issue_comment_url":"https://api.github.com/repos/inoas/authentication/issues/comments{/number}","contents_url":"https://api.github.com/repos/inoas/authentication/contents/{+path}","compare_url":"https://api.github.com/repos/inoas/authentication/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inoas/authentication/merges","archive_url":"https://api.github.com/repos/inoas/authentication/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inoas/authentication/downloads","issues_url":"https://api.github.com/repos/inoas/authentication/issues{/number}","pulls_url":"https://api.github.com/repos/inoas/authentication/pulls{/number}","milestones_url":"https://api.github.com/repos/inoas/authentication/milestones{/number}","notifications_url":"https://api.github.com/repos/inoas/authentication/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inoas/authentication/labels{/name}","releases_url":"https://api.github.com/repos/inoas/authentication/releases{/id}","deployments_url":"https://api.github.com/repos/inoas/authentication/deployments","created_at":"2017-12-12T19:55:57Z","updated_at":"2017-12-12T19:55:59Z","pushed_at":"2018-03-06T21:28:32Z","git_url":"git://github.com/inoas/authentication.git","ssh_url":"git@github.com:inoas/authentication.git","clone_url":"https://github.com/inoas/authentication.git","svn_url":"https://github.com/inoas/authentication","homepage":null,"size":792,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"df699b8f2be05cfd2bd13c7e173fa419cfe97115","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":75036358,"name":"authentication","full_name":"cakephp/authentication","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/authentication","description":null,"fork":false,"url":"https://api.github.com/repos/cakephp/authentication","forks_url":"https://api.github.com/repos/cakephp/authentication/forks","keys_url":"https://api.github.com/repos/cakephp/authentication/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/authentication/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/authentication/teams","hooks_url":"https://api.github.com/repos/cakephp/authentication/hooks","issue_events_url":"https://api.github.com/repos/cakephp/authentication/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/authentication/events","assignees_url":"https://api.github.com/repos/cakephp/authentication/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/authentication/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/authentication/tags","blobs_url":"https://api.github.com/repos/cakephp/authentication/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/authentication/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/authentication/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/authentication/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/authentication/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/authentication/languages","stargazers_url":"https://api.github.com/repos/cakephp/authentication/stargazers","contributors_url":"https://api.github.com/repos/cakephp/authentication/contributors","subscribers_url":"https://api.github.com/repos/cakephp/authentication/subscribers","subscription_url":"https://api.github.com/repos/cakephp/authentication/subscription","commits_url":"https://api.github.com/repos/cakephp/authentication/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/authentication/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/authentication/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/authentication/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/authentication/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/authentication/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/authentication/merges","archive_url":"https://api.github.com/repos/cakephp/authentication/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/authentication/downloads","issues_url":"https://api.github.com/repos/cakephp/authentication/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/authentication/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/authentication/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/authentication/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/authentication/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/authentication/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/authentication/deployments","created_at":"2016-11-29T02:50:33Z","updated_at":"2018-02-10T10:32:57Z","pushed_at":"2018-03-06T21:28:38Z","git_url":"git://github.com/cakephp/authentication.git","ssh_url":"git@github.com:cakephp/authentication.git","clone_url":"https://github.com/cakephp/authentication.git","svn_url":"https://github.com/cakephp/authentication","homepage":null,"size":777,"stargazers_count":34,"watchers_count":34,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13,"open_issues":2,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/authentication/pulls/181"},"html":{"href":"https://github.com/cakephp/authentication/pull/181"},"issue":{"href":"https://api.github.com/repos/cakephp/authentication/issues/181"},"comments":{"href":"https://api.github.com/repos/cakephp/authentication/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/authentication/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/authentication/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/authentication/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/authentication/statuses/3f1e22bd1fb219c92b082691b5d0f4483f8f7a01"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dereuromark"}}