{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/187569769","pull_request_review_id":119377253,"id":187569769,"diff_hunk":"@@ -3,10 +3,15 @@\n \n #include \"DataFormats/Common/interface/SortedCollection.h\"\n #include \"DataFormats/FTLDigi/interface/FTLDataFrameT.h\"\n-#include \"DataFormats/ForwardDetId/interface/FastTimeDetId.h\"\n+#include \"DataFormats/ForwardDetId/interface/BTLDetId.h\"\n+#include \"DataFormats/ForwardDetId/interface/ETLDetId.h\"\n #include \"DataFormats/FTLDigi/interface/FTLSample.h\"\n \n-typedef FTLDataFrameT<FastTimeDetId,FTLSample> FTLDataFrame;","path":"DataFormats/FTLDigi/interface/FTLDigiCollections.h","position":9,"original_position":9,"commit_id":"d2170e2b7e5b38a08ef6576165788c1627274386","original_commit_id":"89972a4dce367bee6d0d5ee1f28220954d858961","user":{"login":"fabiocos","id":4058194,"avatar_url":"https://avatars3.githubusercontent.com/u/4058194?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiocos","html_url":"https://github.com/fabiocos","followers_url":"https://api.github.com/users/fabiocos/followers","following_url":"https://api.github.com/users/fabiocos/following{/other_user}","gists_url":"https://api.github.com/users/fabiocos/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocos/subscriptions","organizations_url":"https://api.github.com/users/fabiocos/orgs","repos_url":"https://api.github.com/users/fabiocos/repos","events_url":"https://api.github.com/users/fabiocos/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocos/received_events","type":"User","site_admin":false},"body":"we want to keep backward compatibility to read old data, so it is better to keep this (although practically useless)","created_at":"2018-05-11T09:47:51Z","updated_at":"2018-05-11T09:47:51Z","html_url":"https://github.com/cms-sw/cmssw/pull/23126#discussion_r187569769","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23126","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/187569769"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/23126#discussion_r187569769"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23126"}},"in_reply_to_id":185854234},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23126","id":185689608,"html_url":"https://github.com/cms-sw/cmssw/pull/23126","diff_url":"https://github.com/cms-sw/cmssw/pull/23126.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/23126.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23126","number":23126,"state":"open","locked":false,"title":"MTD: ideal geometry based on detailed volume description, numbering scheme, adapt the existing Sim-DIGI-RECO chain to it","user":{"login":"fabiocos","id":4058194,"avatar_url":"https://avatars3.githubusercontent.com/u/4058194?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiocos","html_url":"https://github.com/fabiocos","followers_url":"https://api.github.com/users/fabiocos/followers","following_url":"https://api.github.com/users/fabiocos/following{/other_user}","gists_url":"https://api.github.com/users/fabiocos/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocos/subscriptions","organizations_url":"https://api.github.com/users/fabiocos/orgs","repos_url":"https://api.github.com/users/fabiocos/repos","events_url":"https://api.github.com/users/fabiocos/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocos/received_events","type":"User","site_admin":false},"body":"This PR is the first step to move from the initial simplified MTD description currently present in the release to a detailed ideal geometry based on detailed volumes for both sensitive and passive materials. The detailed xml description is based on the tkLayout tool, the initial work of @ghugo83 and @lgray, and the contribution of @hardenbr .\r\n\r\nFor the barrel part (BTL) two alternative scenarios are presented for the crystal layout, flat tiles and long bars. The first scenario (labeled here D90 in the geometry configurations) includes a detailed description of the passive materials as provided by T. Tabarelli, the second one (D91) is based on the implementation of @hardenbr according to the design by C. Tully, using a simplified description of the passive material (aluminum plates).\r\nThe interface with the tracker description (currently PhaseII scenario TiltedTracker404) has been agreed with the tracker experts @ghugo83 @boudoul @emiglior , so as to keep the existing tracker description unchanged, but move the Outer Tracker Support Tube into a separate file outside of the Phase2OTBarrel volume. The BTL mother volume is placed in between these two.\r\n\r\nThe endcap (ETL) description is at present that provided by L. Gray, and should be possibly updated according to the latest plans. This volume is placed within the CALO volume.\r\n\r\nNo overlap is internally detected for the BTL scenario D90 and ETL, while scenario D91 contains some residual tiny overlaps (order of 20 nm) to be fixed in a revision. The whole tracker volume (including BTL) has been tested to be free of overlaps, once the support tube is removed from the tracker.xml file as now described separately in the otst.xml file.\r\n\r\nA numbering scheme, based on the volume hierarchy, is provided in the new Geometry/MTDCommonData package, and a test class is also provided, to probe it vs the volume structure (verified to correspond to the wanted design). The present top level DetId (Forward, FastTiming) is kept. The Geant4 interface has been adapted to use this numbering scheme when producing hits (for the rest the interface is unchanged at present).\r\n\r\nThe DIGI and local RECO steps have been adapted by @casarsa to use the new numbering scheme, specializing the digi collections for BTL and ETL. No other change is made at present, keeping updates of the DIGI format and of the algorithms for a next PR. \r\n\r\nThanks to @boudoul the D90 and D91 geometry scenarios have been added to PyReleaseValidation in a similar way as the other PhaseII test scenarios, and single muon workflows 22407 (D90) and 22807 (D91) have been tested to run and produce collections as expected (simple classed to inspect digis and reco hits have been provided, for hits the existing code in SimG4Core/Application/test has been used).","created_at":"2018-05-03T11:40:53Z","updated_at":"2018-05-11T09:47:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11ff6d7f383a299f3b3166ce63f02eb2ac802ebe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52882317,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-approved","name":"geometry-approved","color":"2cbe4e","default":false},{"id":69634213,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/new-package-pending","name":"new-package-pending","color":"e11d21","default":false},{"id":52881747,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":149441697,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pdmv-pending","name":"pdmv-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":52820523,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131220,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-rejected","name":"tests-rejected","color":"e11d21","default":false},{"id":530655448,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/upgrade-pending","name":"upgrade-pending","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":44,"closed_issues":288,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-05-11T09:35:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23126/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23126/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23126/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/d2170e2b7e5b38a08ef6576165788c1627274386","head":{"label":"fabiocos:fc-simMTD-devel-102X","ref":"fc-simMTD-devel-102X","sha":"d2170e2b7e5b38a08ef6576165788c1627274386","user":{"login":"fabiocos","id":4058194,"avatar_url":"https://avatars3.githubusercontent.com/u/4058194?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiocos","html_url":"https://github.com/fabiocos","followers_url":"https://api.github.com/users/fabiocos/followers","following_url":"https://api.github.com/users/fabiocos/following{/other_user}","gists_url":"https://api.github.com/users/fabiocos/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocos/subscriptions","organizations_url":"https://api.github.com/users/fabiocos/orgs","repos_url":"https://api.github.com/users/fabiocos/repos","events_url":"https://api.github.com/users/fabiocos/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocos/received_events","type":"User","site_admin":false},"repo":{"id":11260036,"name":"cmssw","full_name":"fabiocos/cmssw","owner":{"login":"fabiocos","id":4058194,"avatar_url":"https://avatars3.githubusercontent.com/u/4058194?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiocos","html_url":"https://github.com/fabiocos","followers_url":"https://api.github.com/users/fabiocos/followers","following_url":"https://api.github.com/users/fabiocos/following{/other_user}","gists_url":"https://api.github.com/users/fabiocos/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocos/subscriptions","organizations_url":"https://api.github.com/users/fabiocos/orgs","repos_url":"https://api.github.com/users/fabiocos/repos","events_url":"https://api.github.com/users/fabiocos/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabiocos/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/fabiocos/cmssw","forks_url":"https://api.github.com/repos/fabiocos/cmssw/forks","keys_url":"https://api.github.com/repos/fabiocos/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabiocos/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabiocos/cmssw/teams","hooks_url":"https://api.github.com/repos/fabiocos/cmssw/hooks","issue_events_url":"https://api.github.com/repos/fabiocos/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/fabiocos/cmssw/events","assignees_url":"https://api.github.com/repos/fabiocos/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/fabiocos/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/fabiocos/cmssw/tags","blobs_url":"https://api.github.com/repos/fabiocos/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabiocos/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabiocos/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabiocos/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabiocos/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/fabiocos/cmssw/languages","stargazers_url":"https://api.github.com/repos/fabiocos/cmssw/stargazers","contributors_url":"https://api.github.com/repos/fabiocos/cmssw/contributors","subscribers_url":"https://api.github.com/repos/fabiocos/cmssw/subscribers","subscription_url":"https://api.github.com/repos/fabiocos/cmssw/subscription","commits_url":"https://api.github.com/repos/fabiocos/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabiocos/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabiocos/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabiocos/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabiocos/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/fabiocos/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabiocos/cmssw/merges","archive_url":"https://api.github.com/repos/fabiocos/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabiocos/cmssw/downloads","issues_url":"https://api.github.com/repos/fabiocos/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/fabiocos/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/fabiocos/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/fabiocos/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabiocos/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/fabiocos/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/fabiocos/cmssw/deployments","created_at":"2013-07-08T17:02:44Z","updated_at":"2018-03-21T09:11:22Z","pushed_at":"2018-05-10T20:50:50Z","git_url":"git://github.com/fabiocos/cmssw.git","ssh_url":"git@github.com:fabiocos/cmssw.git","clone_url":"https://github.com/fabiocos/cmssw.git","svn_url":"https://github.com/fabiocos/cmssw","homepage":"cms-sw.github.io/cmssw","size":879614,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:master","ref":"master","sha":"5b098bfc3f3f37db779faab54023ff9955b53d22","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-05-11T07:29:24Z","pushed_at":"2018-05-11T09:34:44Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1001445,"stargazers_count":548,"watchers_count":548,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2561,"mirror_url":null,"archived":false,"open_issues_count":430,"license":null,"forks":2561,"open_issues":430,"watchers":548,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23126"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/23126"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23126"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23126/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23126/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23126/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/d2170e2b7e5b38a08ef6576165788c1627274386"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fabiocos"}}