{"action":"created","comment":{"url":"https://api.github.com/repos/ember-learn/guides-source/pulls/comments/238076616","pull_request_review_id":180538325,"id":238076616,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODA3NjYxNg==","diff_hunk":"@@ -174,39 +178,6 @@ for your app's models. Both routes and their corresponding controllers have acce\n this shared store; when they need to display or modify a model, they\n first ask the store for it.\n \n-## Convention Over Configuration with JSON API","path":"guides/v3.5.0/models/index.md","position":37,"original_position":37,"commit_id":"46cc55464d125ce10e0c0cb09f225a200cde5ac6","original_commit_id":"46cc55464d125ce10e0c0cb09f225a200cde5ac6","user":{"login":"ppcano","id":825430,"node_id":"MDQ6VXNlcjgyNTQzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/825430?v=4","gravatar_id":"","url":"https://api.github.com/users/ppcano","html_url":"https://github.com/ppcano","followers_url":"https://api.github.com/users/ppcano/followers","following_url":"https://api.github.com/users/ppcano/following{/other_user}","gists_url":"https://api.github.com/users/ppcano/gists{/gist_id}","starred_url":"https://api.github.com/users/ppcano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppcano/subscriptions","organizations_url":"https://api.github.com/users/ppcano/orgs","repos_url":"https://api.github.com/users/ppcano/repos","events_url":"https://api.github.com/users/ppcano/events{/privacy}","received_events_url":"https://api.github.com/users/ppcano/received_events","type":"User","site_admin":false},"body":"@jessica-jordan \r\n\r\nI think this part is useful too. In fact, the content you mentioned in this comment has been moved to the `Ember Flexibility` section in this PR like:\r\n\r\n> By default, Ember Data is designed to work out of the box with [JSON API][json-api]\r\nJSON API is a formal specification for building conventional, robust, and performant\r\nAPIs that allow clients and servers to communicate model data.\r\n\r\nWe can extend and/or improve this or any other part, I didn't try more changes because I was not sure how to complete it.","created_at":"2018-12-01T21:07:24Z","updated_at":"2018-12-01T21:07:25Z","html_url":"https://github.com/ember-learn/guides-source/pull/288#discussion_r238076616","pull_request_url":"https://api.github.com/repos/ember-learn/guides-source/pulls/288","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ember-learn/guides-source/pulls/comments/238076616"},"html":{"href":"https://github.com/ember-learn/guides-source/pull/288#discussion_r238076616"},"pull_request":{"href":"https://api.github.com/repos/ember-learn/guides-source/pulls/288"}},"in_reply_to_id":238066442},"pull_request":{"url":"https://api.github.com/repos/ember-learn/guides-source/pulls/288","id":233907492,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTA3NDky","html_url":"https://github.com/ember-learn/guides-source/pull/288","diff_url":"https://github.com/ember-learn/guides-source/pull/288.diff","patch_url":"https://github.com/ember-learn/guides-source/pull/288.patch","issue_url":"https://api.github.com/repos/ember-learn/guides-source/issues/288","number":288,"state":"open","locked":false,"title":"Models: reformulate the JSON/API content ","user":{"login":"ppcano","id":825430,"node_id":"MDQ6VXNlcjgyNTQzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/825430?v=4","gravatar_id":"","url":"https://api.github.com/users/ppcano","html_url":"https://github.com/ppcano","followers_url":"https://api.github.com/users/ppcano/followers","following_url":"https://api.github.com/users/ppcano/following{/other_user}","gists_url":"https://api.github.com/users/ppcano/gists{/gist_id}","starred_url":"https://api.github.com/users/ppcano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppcano/subscriptions","organizations_url":"https://api.github.com/users/ppcano/orgs","repos_url":"https://api.github.com/users/ppcano/repos","events_url":"https://api.github.com/users/ppcano/events{/privacy}","received_events_url":"https://api.github.com/users/ppcano/received_events","type":"User","site_admin":false},"body":"Previously discussed at #240 \r\n\r\n\r\nThe PR moves the content of the `JSON-API on Ember Data` to the `Ember Data Flexibility` section and remove the rest of the content of the `Convention Over Configuration with JSON API`.\r\n\r\n@jenweber commented:\r\n\r\n> The JSONAPI section was probably written when the project was brand-new. I have a feeling that we can keep the same content level with fewer words, now that the project is better established and known.\r\n\r\nI tried to reformulate the content a bit, but I ended up removing the rest of the `Convention Over Configuration with JSON API`, feel free anyone to suggest any better form. ","created_at":"2018-11-27T13:18:21Z","updated_at":"2018-12-01T21:07:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c4442fc56bd5885cbb9c56ba3817d677f740795","assignee":{"login":"jessica-jordan","id":8811742,"node_id":"MDQ6VXNlcjg4MTE3NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8811742?v=4","gravatar_id":"","url":"https://api.github.com/users/jessica-jordan","html_url":"https://github.com/jessica-jordan","followers_url":"https://api.github.com/users/jessica-jordan/followers","following_url":"https://api.github.com/users/jessica-jordan/following{/other_user}","gists_url":"https://api.github.com/users/jessica-jordan/gists{/gist_id}","starred_url":"https://api.github.com/users/jessica-jordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessica-jordan/subscriptions","organizations_url":"https://api.github.com/users/jessica-jordan/orgs","repos_url":"https://api.github.com/users/jessica-jordan/repos","events_url":"https://api.github.com/users/jessica-jordan/events{/privacy}","received_events_url":"https://api.github.com/users/jessica-jordan/received_events","type":"User","site_admin":false},"assignees":[{"login":"jessica-jordan","id":8811742,"node_id":"MDQ6VXNlcjg4MTE3NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8811742?v=4","gravatar_id":"","url":"https://api.github.com/users/jessica-jordan","html_url":"https://github.com/jessica-jordan","followers_url":"https://api.github.com/users/jessica-jordan/followers","following_url":"https://api.github.com/users/jessica-jordan/following{/other_user}","gists_url":"https://api.github.com/users/jessica-jordan/gists{/gist_id}","starred_url":"https://api.github.com/users/jessica-jordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessica-jordan/subscriptions","organizations_url":"https://api.github.com/users/jessica-jordan/orgs","repos_url":"https://api.github.com/users/jessica-jordan/repos","events_url":"https://api.github.com/users/jessica-jordan/events{/privacy}","received_events_url":"https://api.github.com/users/jessica-jordan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":987841086,"node_id":"MDU6TGFiZWw5ODc4NDEwODY=","url":"https://api.github.com/repos/ember-learn/guides-source/labels/needs%20contributor%20response","name":"needs contributor response","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ember-learn/guides-source/pulls/288/commits","review_comments_url":"https://api.github.com/repos/ember-learn/guides-source/pulls/288/comments","review_comment_url":"https://api.github.com/repos/ember-learn/guides-source/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-learn/guides-source/issues/288/comments","statuses_url":"https://api.github.com/repos/ember-learn/guides-source/statuses/46cc55464d125ce10e0c0cb09f225a200cde5ac6","head":{"label":"ppcano:json-api-tweaks","ref":"json-api-tweaks","sha":"46cc55464d125ce10e0c0cb09f225a200cde5ac6","user":{"login":"ppcano","id":825430,"node_id":"MDQ6VXNlcjgyNTQzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/825430?v=4","gravatar_id":"","url":"https://api.github.com/users/ppcano","html_url":"https://github.com/ppcano","followers_url":"https://api.github.com/users/ppcano/followers","following_url":"https://api.github.com/users/ppcano/following{/other_user}","gists_url":"https://api.github.com/users/ppcano/gists{/gist_id}","starred_url":"https://api.github.com/users/ppcano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppcano/subscriptions","organizations_url":"https://api.github.com/users/ppcano/orgs","repos_url":"https://api.github.com/users/ppcano/repos","events_url":"https://api.github.com/users/ppcano/events{/privacy}","received_events_url":"https://api.github.com/users/ppcano/received_events","type":"User","site_admin":false},"repo":{"id":155908621,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU5MDg2MjE=","name":"guides-source","full_name":"ppcano/guides-source","private":false,"owner":{"login":"ppcano","id":825430,"node_id":"MDQ6VXNlcjgyNTQzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/825430?v=4","gravatar_id":"","url":"https://api.github.com/users/ppcano","html_url":"https://github.com/ppcano","followers_url":"https://api.github.com/users/ppcano/followers","following_url":"https://api.github.com/users/ppcano/following{/other_user}","gists_url":"https://api.github.com/users/ppcano/gists{/gist_id}","starred_url":"https://api.github.com/users/ppcano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppcano/subscriptions","organizations_url":"https://api.github.com/users/ppcano/orgs","repos_url":"https://api.github.com/users/ppcano/repos","events_url":"https://api.github.com/users/ppcano/events{/privacy}","received_events_url":"https://api.github.com/users/ppcano/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ppcano/guides-source","description":"This repository contains the written content for the Ember.js Guides","fork":true,"url":"https://api.github.com/repos/ppcano/guides-source","forks_url":"https://api.github.com/repos/ppcano/guides-source/forks","keys_url":"https://api.github.com/repos/ppcano/guides-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppcano/guides-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppcano/guides-source/teams","hooks_url":"https://api.github.com/repos/ppcano/guides-source/hooks","issue_events_url":"https://api.github.com/repos/ppcano/guides-source/issues/events{/number}","events_url":"https://api.github.com/repos/ppcano/guides-source/events","assignees_url":"https://api.github.com/repos/ppcano/guides-source/assignees{/user}","branches_url":"https://api.github.com/repos/ppcano/guides-source/branches{/branch}","tags_url":"https://api.github.com/repos/ppcano/guides-source/tags","blobs_url":"https://api.github.com/repos/ppcano/guides-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppcano/guides-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppcano/guides-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppcano/guides-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppcano/guides-source/statuses/{sha}","languages_url":"https://api.github.com/repos/ppcano/guides-source/languages","stargazers_url":"https://api.github.com/repos/ppcano/guides-source/stargazers","contributors_url":"https://api.github.com/repos/ppcano/guides-source/contributors","subscribers_url":"https://api.github.com/repos/ppcano/guides-source/subscribers","subscription_url":"https://api.github.com/repos/ppcano/guides-source/subscription","commits_url":"https://api.github.com/repos/ppcano/guides-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppcano/guides-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppcano/guides-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppcano/guides-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppcano/guides-source/contents/{+path}","compare_url":"https://api.github.com/repos/ppcano/guides-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppcano/guides-source/merges","archive_url":"https://api.github.com/repos/ppcano/guides-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppcano/guides-source/downloads","issues_url":"https://api.github.com/repos/ppcano/guides-source/issues{/number}","pulls_url":"https://api.github.com/repos/ppcano/guides-source/pulls{/number}","milestones_url":"https://api.github.com/repos/ppcano/guides-source/milestones{/number}","notifications_url":"https://api.github.com/repos/ppcano/guides-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppcano/guides-source/labels{/name}","releases_url":"https://api.github.com/repos/ppcano/guides-source/releases{/id}","deployments_url":"https://api.github.com/repos/ppcano/guides-source/deployments","created_at":"2018-11-02T18:47:39Z","updated_at":"2018-11-27T12:32:21Z","pushed_at":"2018-11-27T13:04:33Z","git_url":"git://github.com/ppcano/guides-source.git","ssh_url":"git@github.com:ppcano/guides-source.git","clone_url":"https://github.com/ppcano/guides-source.git","svn_url":"https://github.com/ppcano/guides-source","homepage":"https://guides.emberjs.com/","size":18754,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-learn:master","ref":"master","sha":"cce6e6aa6cb1710c714c831de8647e0d06a19af3","user":{"login":"ember-learn","id":18540472,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTQwNDcy","avatar_url":"https://avatars1.githubusercontent.com/u/18540472?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-learn","html_url":"https://github.com/ember-learn","followers_url":"https://api.github.com/users/ember-learn/followers","following_url":"https://api.github.com/users/ember-learn/following{/other_user}","gists_url":"https://api.github.com/users/ember-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-learn/subscriptions","organizations_url":"https://api.github.com/users/ember-learn/orgs","repos_url":"https://api.github.com/users/ember-learn/repos","events_url":"https://api.github.com/users/ember-learn/events{/privacy}","received_events_url":"https://api.github.com/users/ember-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":105325202,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUzMjUyMDI=","name":"guides-source","full_name":"ember-learn/guides-source","private":false,"owner":{"login":"ember-learn","id":18540472,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTQwNDcy","avatar_url":"https://avatars1.githubusercontent.com/u/18540472?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-learn","html_url":"https://github.com/ember-learn","followers_url":"https://api.github.com/users/ember-learn/followers","following_url":"https://api.github.com/users/ember-learn/following{/other_user}","gists_url":"https://api.github.com/users/ember-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-learn/subscriptions","organizations_url":"https://api.github.com/users/ember-learn/orgs","repos_url":"https://api.github.com/users/ember-learn/repos","events_url":"https://api.github.com/users/ember-learn/events{/privacy}","received_events_url":"https://api.github.com/users/ember-learn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ember-learn/guides-source","description":"This repository contains the written content for the Ember.js Guides","fork":false,"url":"https://api.github.com/repos/ember-learn/guides-source","forks_url":"https://api.github.com/repos/ember-learn/guides-source/forks","keys_url":"https://api.github.com/repos/ember-learn/guides-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-learn/guides-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-learn/guides-source/teams","hooks_url":"https://api.github.com/repos/ember-learn/guides-source/hooks","issue_events_url":"https://api.github.com/repos/ember-learn/guides-source/issues/events{/number}","events_url":"https://api.github.com/repos/ember-learn/guides-source/events","assignees_url":"https://api.github.com/repos/ember-learn/guides-source/assignees{/user}","branches_url":"https://api.github.com/repos/ember-learn/guides-source/branches{/branch}","tags_url":"https://api.github.com/repos/ember-learn/guides-source/tags","blobs_url":"https://api.github.com/repos/ember-learn/guides-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-learn/guides-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-learn/guides-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-learn/guides-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-learn/guides-source/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-learn/guides-source/languages","stargazers_url":"https://api.github.com/repos/ember-learn/guides-source/stargazers","contributors_url":"https://api.github.com/repos/ember-learn/guides-source/contributors","subscribers_url":"https://api.github.com/repos/ember-learn/guides-source/subscribers","subscription_url":"https://api.github.com/repos/ember-learn/guides-source/subscription","commits_url":"https://api.github.com/repos/ember-learn/guides-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-learn/guides-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-learn/guides-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-learn/guides-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-learn/guides-source/contents/{+path}","compare_url":"https://api.github.com/repos/ember-learn/guides-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-learn/guides-source/merges","archive_url":"https://api.github.com/repos/ember-learn/guides-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-learn/guides-source/downloads","issues_url":"https://api.github.com/repos/ember-learn/guides-source/issues{/number}","pulls_url":"https://api.github.com/repos/ember-learn/guides-source/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-learn/guides-source/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-learn/guides-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-learn/guides-source/labels{/name}","releases_url":"https://api.github.com/repos/ember-learn/guides-source/releases{/id}","deployments_url":"https://api.github.com/repos/ember-learn/guides-source/deployments","created_at":"2017-09-29T23:27:33Z","updated_at":"2018-12-01T17:06:33Z","pushed_at":"2018-12-01T17:06:30Z","git_url":"git://github.com/ember-learn/guides-source.git","ssh_url":"git@github.com:ember-learn/guides-source.git","clone_url":"https://github.com/ember-learn/guides-source.git","svn_url":"https://github.com/ember-learn/guides-source","homepage":"https://guides.emberjs.com/","size":18787,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":69,"license":null,"forks":133,"open_issues":69,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-learn/guides-source/pulls/288"},"html":{"href":"https://github.com/ember-learn/guides-source/pull/288"},"issue":{"href":"https://api.github.com/repos/ember-learn/guides-source/issues/288"},"comments":{"href":"https://api.github.com/repos/ember-learn/guides-source/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-learn/guides-source/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-learn/guides-source/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-learn/guides-source/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/ember-learn/guides-source/statuses/46cc55464d125ce10e0c0cb09f225a200cde5ac6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ppcano"}}