{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/194814472","pull_request_review_id":128057464,"id":194814472,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDgxNDQ3Mg==","diff_hunk":"@@ -15,4 +16,4 @@\n  *\n  * Returns 0 on success and non-zero on failure.\n  */\n-extern \"C\" int32_t HttpNative_EnsureCurlIsInitialized();\n+DLLEXPORT int32_t HttpNative_EnsureCurlIsInitialized(void);","path":"src/Native/Unix/System.Net.Http.Native/pal_curlinit.h","position":13,"original_position":13,"commit_id":"509af4b53826277ba34322022679af3daee060b4","original_commit_id":"509af4b53826277ba34322022679af3daee060b4","user":{"login":"stephentoub","id":2642209,"node_id":"MDQ6VXNlcjI2NDIyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"> we are not consistent already\r\n\r\n😦 ","created_at":"2018-06-12T16:55:40Z","updated_at":"2018-06-12T16:55:41Z","html_url":"https://github.com/dotnet/corefx/pull/30229#discussion_r194814472","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/30229","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/194814472"},"html":{"href":"https://github.com/dotnet/corefx/pull/30229#discussion_r194814472"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30229"}},"in_reply_to_id":194459360},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/30229","id":193769969,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzY5OTY5","html_url":"https://github.com/dotnet/corefx/pull/30229","diff_url":"https://github.com/dotnet/corefx/pull/30229.diff","patch_url":"https://github.com/dotnet/corefx/pull/30229.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/30229","number":30229,"state":"open","locked":false,"title":"Convert System.Net.Http.Native to C","user":{"login":"kasper3","id":33230602,"node_id":"MDQ6VXNlcjMzMjMwNjAy","avatar_url":"https://avatars3.githubusercontent.com/u/33230602?v=4","gravatar_id":"","url":"https://api.github.com/users/kasper3","html_url":"https://github.com/kasper3","followers_url":"https://api.github.com/users/kasper3/followers","following_url":"https://api.github.com/users/kasper3/following{/other_user}","gists_url":"https://api.github.com/users/kasper3/gists{/gist_id}","starred_url":"https://api.github.com/users/kasper3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasper3/subscriptions","organizations_url":"https://api.github.com/users/kasper3/orgs","repos_url":"https://api.github.com/users/kasper3/repos","events_url":"https://api.github.com/users/kasper3/events{/privacy}","received_events_url":"https://api.github.com/users/kasper3/received_events","type":"User","site_admin":false},"body":"<del>`git mv` (to rename a file) has a limit, if the change exceeds to some thousand characters, it doesn't show it as inline diff, but instead as if a file was deleted and a new one was added. This is what happened in `pal_easy.c`.</del>","created_at":"2018-06-09T10:11:52Z","updated_at":"2018-06-12T16:55:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57b3fa26f4107921a7555d46655854c44c7e74af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/30229/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/30229/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/30229/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/509af4b53826277ba34322022679af3daee060b4","head":{"label":"kasper3:cpp-toc-net","ref":"cpp-toc-net","sha":"509af4b53826277ba34322022679af3daee060b4","user":{"login":"kasper3","id":33230602,"node_id":"MDQ6VXNlcjMzMjMwNjAy","avatar_url":"https://avatars3.githubusercontent.com/u/33230602?v=4","gravatar_id":"","url":"https://api.github.com/users/kasper3","html_url":"https://github.com/kasper3","followers_url":"https://api.github.com/users/kasper3/followers","following_url":"https://api.github.com/users/kasper3/following{/other_user}","gists_url":"https://api.github.com/users/kasper3/gists{/gist_id}","starred_url":"https://api.github.com/users/kasper3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasper3/subscriptions","organizations_url":"https://api.github.com/users/kasper3/orgs","repos_url":"https://api.github.com/users/kasper3/repos","events_url":"https://api.github.com/users/kasper3/events{/privacy}","received_events_url":"https://api.github.com/users/kasper3/received_events","type":"User","site_admin":false},"repo":{"id":129694979,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk2OTQ5Nzk=","name":"corefx","full_name":"kasper3/corefx","owner":{"login":"kasper3","id":33230602,"node_id":"MDQ6VXNlcjMzMjMwNjAy","avatar_url":"https://avatars3.githubusercontent.com/u/33230602?v=4","gravatar_id":"","url":"https://api.github.com/users/kasper3","html_url":"https://github.com/kasper3","followers_url":"https://api.github.com/users/kasper3/followers","following_url":"https://api.github.com/users/kasper3/following{/other_user}","gists_url":"https://api.github.com/users/kasper3/gists{/gist_id}","starred_url":"https://api.github.com/users/kasper3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasper3/subscriptions","organizations_url":"https://api.github.com/users/kasper3/orgs","repos_url":"https://api.github.com/users/kasper3/repos","events_url":"https://api.github.com/users/kasper3/events{/privacy}","received_events_url":"https://api.github.com/users/kasper3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kasper3/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/kasper3/corefx","forks_url":"https://api.github.com/repos/kasper3/corefx/forks","keys_url":"https://api.github.com/repos/kasper3/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kasper3/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kasper3/corefx/teams","hooks_url":"https://api.github.com/repos/kasper3/corefx/hooks","issue_events_url":"https://api.github.com/repos/kasper3/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/kasper3/corefx/events","assignees_url":"https://api.github.com/repos/kasper3/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/kasper3/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/kasper3/corefx/tags","blobs_url":"https://api.github.com/repos/kasper3/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kasper3/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kasper3/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/kasper3/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kasper3/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/kasper3/corefx/languages","stargazers_url":"https://api.github.com/repos/kasper3/corefx/stargazers","contributors_url":"https://api.github.com/repos/kasper3/corefx/contributors","subscribers_url":"https://api.github.com/repos/kasper3/corefx/subscribers","subscription_url":"https://api.github.com/repos/kasper3/corefx/subscription","commits_url":"https://api.github.com/repos/kasper3/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/kasper3/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/kasper3/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/kasper3/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/kasper3/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/kasper3/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kasper3/corefx/merges","archive_url":"https://api.github.com/repos/kasper3/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kasper3/corefx/downloads","issues_url":"https://api.github.com/repos/kasper3/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/kasper3/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/kasper3/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/kasper3/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kasper3/corefx/labels{/name}","releases_url":"https://api.github.com/repos/kasper3/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/kasper3/corefx/deployments","created_at":"2018-04-16T06:25:28Z","updated_at":"2018-05-02T14:03:47Z","pushed_at":"2018-06-12T15:36:12Z","git_url":"git://github.com/kasper3/corefx.git","ssh_url":"git@github.com:kasper3/corefx.git","clone_url":"https://github.com/kasper3/corefx.git","svn_url":"https://github.com/kasper3/corefx","homepage":"https://github.com/dotnet/core","size":179048,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"70ec0ad490754fa64ab06dde1d1f10e4d36a83a9","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-06-12T16:07:11Z","pushed_at":"2018-06-12T16:32:18Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":179040,"stargazers_count":14148,"watchers_count":14148,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4095,"mirror_url":null,"archived":false,"open_issues_count":2303,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4095,"open_issues":2303,"watchers":14148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30229"},"html":{"href":"https://github.com/dotnet/corefx/pull/30229"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/30229"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/30229/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30229/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30229/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/509af4b53826277ba34322022679af3daee060b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stephentoub"}}