{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/211371661","pull_request_review_id":147777578,"id":211371661,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTM3MTY2MQ==","diff_hunk":"@@ -750,6 +750,9 @@ Returns `true` if the entire data was flushed successfully to the kernel\n buffer. Returns `false` if all or part of the data was queued in user memory.\n `'drain'` will be emitted when the buffer is free again.\n \n+Note that when `write` is called with empty string or buffer, it does ","path":"doc/api/http.md","position":4,"original_position":4,"commit_id":"116d32045aa936ddb006a9003567b32520b2ec61","original_commit_id":"116d32045aa936ddb006a9003567b32520b2ec61","user":{"login":"Trott","id":718899,"node_id":"MDQ6VXNlcjcxODg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"body":"Nit, you can ignore this, but my mild preference: Remove `Note that`","created_at":"2018-08-20T18:56:49Z","updated_at":"2018-08-20T18:56:49Z","html_url":"https://github.com/nodejs/node/pull/22118#discussion_r211371661","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/22118","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/211371661"},"html":{"href":"https://github.com/nodejs/node/pull/22118#discussion_r211371661"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/22118"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22118","id":206183301,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTgzMzAx","html_url":"https://github.com/nodejs/node/pull/22118","diff_url":"https://github.com/nodejs/node/pull/22118.diff","patch_url":"https://github.com/nodejs/node/pull/22118.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/22118","number":22118,"state":"open","locked":false,"title":"http: Adding doc and debug for calling empty string on write function","user":{"login":"antsmartian","id":1241511,"node_id":"MDQ6VXNlcjEyNDE1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1241511?v=4","gravatar_id":"","url":"https://api.github.com/users/antsmartian","html_url":"https://github.com/antsmartian","followers_url":"https://api.github.com/users/antsmartian/followers","following_url":"https://api.github.com/users/antsmartian/following{/other_user}","gists_url":"https://api.github.com/users/antsmartian/gists{/gist_id}","starred_url":"https://api.github.com/users/antsmartian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antsmartian/subscriptions","organizations_url":"https://api.github.com/users/antsmartian/orgs","repos_url":"https://api.github.com/users/antsmartian/repos","events_url":"https://api.github.com/users/antsmartian/events{/privacy}","received_events_url":"https://api.github.com/users/antsmartian/received_events","type":"User","site_admin":false},"body":"Addresses the issue : https://github.com/nodejs/node/issues/22066\r\n\r\nRemoving the empty check would be a breaking change, however I'm not sure why such check is in first place. May be need input from the community. \r\n\r\nIn the meantime,  I thought its worth to add documentation and at the same time to add `debug` log, so that when users feel `write` with empty string or buffer hangs, they can run in debug mode to find out the reason. \r\n\r\nIf the content fits for the documentation, I guess we need to add the same to `http2` as well. \r\n\r\nOpen to feedbacks and thoughts.  \r\n\r\n##### Checklist\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-08-04T08:44:15Z","updated_at":"2018-08-20T18:56:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc74dc4806e9c86628a4a5e6e03ef7e27656607e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267422,"node_id":"MDU6TGFiZWwxNTUyNjc0MjI=","url":"https://api.github.com/repos/nodejs/node/labels/http","name":"http","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/22118/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/22118/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22118/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/116d32045aa936ddb006a9003567b32520b2ec61","head":{"label":"antsmartian:22066","ref":"22066","sha":"116d32045aa936ddb006a9003567b32520b2ec61","user":{"login":"antsmartian","id":1241511,"node_id":"MDQ6VXNlcjEyNDE1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1241511?v=4","gravatar_id":"","url":"https://api.github.com/users/antsmartian","html_url":"https://github.com/antsmartian","followers_url":"https://api.github.com/users/antsmartian/followers","following_url":"https://api.github.com/users/antsmartian/following{/other_user}","gists_url":"https://api.github.com/users/antsmartian/gists{/gist_id}","starred_url":"https://api.github.com/users/antsmartian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antsmartian/subscriptions","organizations_url":"https://api.github.com/users/antsmartian/orgs","repos_url":"https://api.github.com/users/antsmartian/repos","events_url":"https://api.github.com/users/antsmartian/events{/privacy}","received_events_url":"https://api.github.com/users/antsmartian/received_events","type":"User","site_admin":false},"repo":{"id":140859357,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA4NTkzNTc=","name":"node","full_name":"antsmartian/node","owner":{"login":"antsmartian","id":1241511,"node_id":"MDQ6VXNlcjEyNDE1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1241511?v=4","gravatar_id":"","url":"https://api.github.com/users/antsmartian","html_url":"https://github.com/antsmartian","followers_url":"https://api.github.com/users/antsmartian/followers","following_url":"https://api.github.com/users/antsmartian/following{/other_user}","gists_url":"https://api.github.com/users/antsmartian/gists{/gist_id}","starred_url":"https://api.github.com/users/antsmartian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antsmartian/subscriptions","organizations_url":"https://api.github.com/users/antsmartian/orgs","repos_url":"https://api.github.com/users/antsmartian/repos","events_url":"https://api.github.com/users/antsmartian/events{/privacy}","received_events_url":"https://api.github.com/users/antsmartian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antsmartian/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/antsmartian/node","forks_url":"https://api.github.com/repos/antsmartian/node/forks","keys_url":"https://api.github.com/repos/antsmartian/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antsmartian/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antsmartian/node/teams","hooks_url":"https://api.github.com/repos/antsmartian/node/hooks","issue_events_url":"https://api.github.com/repos/antsmartian/node/issues/events{/number}","events_url":"https://api.github.com/repos/antsmartian/node/events","assignees_url":"https://api.github.com/repos/antsmartian/node/assignees{/user}","branches_url":"https://api.github.com/repos/antsmartian/node/branches{/branch}","tags_url":"https://api.github.com/repos/antsmartian/node/tags","blobs_url":"https://api.github.com/repos/antsmartian/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antsmartian/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antsmartian/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/antsmartian/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antsmartian/node/statuses/{sha}","languages_url":"https://api.github.com/repos/antsmartian/node/languages","stargazers_url":"https://api.github.com/repos/antsmartian/node/stargazers","contributors_url":"https://api.github.com/repos/antsmartian/node/contributors","subscribers_url":"https://api.github.com/repos/antsmartian/node/subscribers","subscription_url":"https://api.github.com/repos/antsmartian/node/subscription","commits_url":"https://api.github.com/repos/antsmartian/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/antsmartian/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/antsmartian/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/antsmartian/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/antsmartian/node/contents/{+path}","compare_url":"https://api.github.com/repos/antsmartian/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antsmartian/node/merges","archive_url":"https://api.github.com/repos/antsmartian/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antsmartian/node/downloads","issues_url":"https://api.github.com/repos/antsmartian/node/issues{/number}","pulls_url":"https://api.github.com/repos/antsmartian/node/pulls{/number}","milestones_url":"https://api.github.com/repos/antsmartian/node/milestones{/number}","notifications_url":"https://api.github.com/repos/antsmartian/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antsmartian/node/labels{/name}","releases_url":"https://api.github.com/repos/antsmartian/node/releases{/id}","deployments_url":"https://api.github.com/repos/antsmartian/node/deployments","created_at":"2018-07-13T14:49:10Z","updated_at":"2018-07-13T14:49:34Z","pushed_at":"2018-08-20T14:20:59Z","git_url":"git://github.com/antsmartian/node.git","ssh_url":"git@github.com:antsmartian/node.git","clone_url":"https://github.com/antsmartian/node.git","svn_url":"https://github.com/antsmartian/node","homepage":"https://nodejs.org","size":401016,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"d3d59821dd136a36dc2e1b4a7d02c936762240f4","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-08-20T18:55:24Z","pushed_at":"2018-08-20T18:54:34Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":402828,"stargazers_count":52446,"watchers_count":52446,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11088,"mirror_url":null,"archived":false,"open_issues_count":845,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11088,"open_issues":845,"watchers":52446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/22118"},"html":{"href":"https://github.com/nodejs/node/pull/22118"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/22118"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/22118/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/22118/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/22118/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/116d32045aa936ddb006a9003567b32520b2ec61"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Trott"}}