{"action":"created","issue":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1311","repository_url":"https://api.github.com/repos/kubevirt/kubevirt","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1311/labels{/name}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1311/comments","events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1311/events","html_url":"https://github.com/kubevirt/kubevirt/pull/1311","id":341133325,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzc5NjUx","number":1311,"title":"Allow build-time configuration of Image Pull Policy","user":{"login":"benwatcisco","id":41089520,"node_id":"MDQ6VXNlcjQxMDg5NTIw","avatar_url":"https://avatars0.githubusercontent.com/u/41089520?v=4","gravatar_id":"","url":"https://api.github.com/users/benwatcisco","html_url":"https://github.com/benwatcisco","followers_url":"https://api.github.com/users/benwatcisco/followers","following_url":"https://api.github.com/users/benwatcisco/following{/other_user}","gists_url":"https://api.github.com/users/benwatcisco/gists{/gist_id}","starred_url":"https://api.github.com/users/benwatcisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwatcisco/subscriptions","organizations_url":"https://api.github.com/users/benwatcisco/orgs","repos_url":"https://api.github.com/users/benwatcisco/repos","events_url":"https://api.github.com/users/benwatcisco/events{/privacy}","received_events_url":"https://api.github.com/users/benwatcisco/received_events","type":"User","site_admin":false},"labels":[{"id":971140812,"node_id":"MDU6TGFiZWw5NzExNDA4MTI=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":583176013,"node_id":"MDU6TGFiZWw1ODMxNzYwMTM=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-13T19:25:41Z","updated_at":"2018-07-16T08:36:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1311","html_url":"https://github.com/kubevirt/kubevirt/pull/1311","diff_url":"https://github.com/kubevirt/kubevirt/pull/1311.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/1311.patch"},"body":"**What this PR does / why we need it**:\r\nThis adds the ability to set container \"Image Pull Policy\" at build time.  This can be helpful in a developer workflow by setting the policy to \"Always\".  In such a case worker nodes will always pull the latest kubevirt images, removing the need for the developer to either use ephemeral Docker tags or to explicitly pull on each worker node.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nNone\r\n\r\n```release-note\r\nUser can set the ImagePullPolicy that will be applied to manifests by setting the IMAGE_PULL_POLICY environment variable.\r\nThis defaults to \"IfNotPresent\" (previous behavior)\r\n```"},"comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments/405180154","html_url":"https://github.com/kubevirt/kubevirt/pull/1311#issuecomment-405180154","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1311","id":405180154,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTE4MDE1NA==","user":{"login":"rmohr","id":4534621,"node_id":"MDQ6VXNlcjQ1MzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4534621?v=4","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T08:36:02Z","updated_at":"2018-07-16T08:36:02Z","author_association":"MEMBER","body":"@benwatcisco I see, here is the part I was missing in #1314. I am not sure if that is the right thing to do. I was thinking in the past about this too. I then decided to have the push/pull logic inside the providers and pre-pull all images to all nodes, in order to make the test executions and the developer experience more consistent. It is very hard to write tests with reasonable timeout expectations if you don't know if images are going to be pulled or not. Also as an engineer I found it hard to differentiate between pull-delays and real issues during development.\r\n\r\nPre-pulling might however not be an option for big clusters. So I am not against it either. It looks like it is a necessity for the external provider to work."}}
{"actor":{"display_login":"rmohr"}}