{"action":"created","issue":{"url":"https://api.github.com/repos/ole-vi/planet/issues/598","repository_url":"https://api.github.com/repos/ole-vi/planet","labels_url":"https://api.github.com/repos/ole-vi/planet/issues/598/labels{/name}","comments_url":"https://api.github.com/repos/ole-vi/planet/issues/598/comments","events_url":"https://api.github.com/repos/ole-vi/planet/issues/598/events","html_url":"https://github.com/ole-vi/planet/pull/598","id":312649909,"number":598,"title":"[WIP] 564 profile image crop","user":{"login":"ArashDai","id":8280071,"avatar_url":"https://avatars3.githubusercontent.com/u/8280071?v=4","gravatar_id":"","url":"https://api.github.com/users/ArashDai","html_url":"https://github.com/ArashDai","followers_url":"https://api.github.com/users/ArashDai/followers","following_url":"https://api.github.com/users/ArashDai/following{/other_user}","gists_url":"https://api.github.com/users/ArashDai/gists{/gist_id}","starred_url":"https://api.github.com/users/ArashDai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArashDai/subscriptions","organizations_url":"https://api.github.com/users/ArashDai/orgs","repos_url":"https://api.github.com/users/ArashDai/repos","events_url":"https://api.github.com/users/ArashDai/events{/privacy}","received_events_url":"https://api.github.com/users/ArashDai/received_events","type":"User","site_admin":false},"labels":[{"id":710547614,"url":"https://api.github.com/repos/ole-vi/planet/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-09T19:07:41Z","updated_at":"2018-04-14T02:47:55Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ole-vi/planet/pulls/598","html_url":"https://github.com/ole-vi/planet/pull/598","diff_url":"https://github.com/ole-vi/planet/pull/598.diff","patch_url":"https://github.com/ole-vi/planet/pull/598.patch"},"body":"Work in progress, current issue Error: Template parse errors: There is no directive with \"exportAs\" set to \"croppie\""},"comment":{"url":"https://api.github.com/repos/ole-vi/planet/issues/comments/381298305","html_url":"https://github.com/ole-vi/planet/pull/598#issuecomment-381298305","issue_url":"https://api.github.com/repos/ole-vi/planet/issues/598","id":381298305,"user":{"login":"Tille88","id":16757941,"avatar_url":"https://avatars2.githubusercontent.com/u/16757941?v=4","gravatar_id":"","url":"https://api.github.com/users/Tille88","html_url":"https://github.com/Tille88","followers_url":"https://api.github.com/users/Tille88/followers","following_url":"https://api.github.com/users/Tille88/following{/other_user}","gists_url":"https://api.github.com/users/Tille88/gists{/gist_id}","starred_url":"https://api.github.com/users/Tille88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tille88/subscriptions","organizations_url":"https://api.github.com/users/Tille88/orgs","repos_url":"https://api.github.com/users/Tille88/repos","events_url":"https://api.github.com/users/Tille88/events{/privacy}","received_events_url":"https://api.github.com/users/Tille88/received_events","type":"User","site_admin":false},"created_at":"2018-04-14T02:47:55Z","updated_at":"2018-04-14T02:47:55Z","author_association":"MEMBER","body":"Took me a little while to figure out what was meant by the lack of update: \r\nFor me, the image is changed after clicking 'update', **but the small thumbnail in the upper left navbar is not updated.**\r\nMaybe the image shown is not updated for others, but that is the behavior I am seeing.\r\n\r\nFor improvements, I left one comment in the code on improved documentation, and then:\r\n- If the croppie-stuff is not used, it would be better in my opinion to comment it out so I would be certain what code is doing what\r\n- I would still want a 'select crop'-option to give the user the feeling of having it locked down/being in control, before going back to another screen.\r\n- The CSS styling will be important, so moving that up the list of todos for review would make sense IMHO\r\n- For the image update, since it comes from /app/home/home.component.ts => userImageSrc() from database source, so I guess it could be having automatic updates through dataflow if you would alter that to an image component/property in there instead of having an active function call (i.e. userImageSrc)?\r\n  - I'm too new to Angular, but the regular JS-way of doing it to not make things too coupled would probably be some kind of event of image change firing and listened on in a parent-level component through event delegation. \r\n  - Also, I'm too new to give any suggestions on this here, maybe you even deal with events through creating observable 'event streams'? If more than this change would be needed, then instead of having image update event, perhaps having a user detail update event firing on write to db that could be used repeatedly throughout the codebase."}}
{"actor":{"display_login":"Tille88"}}