{"action":"closed","number":104,"pull_request":{"url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/104","id":209976772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTc2Nzcy","html_url":"https://github.com/sul-dlss/pre-assembly/pull/104","diff_url":"https://github.com/sul-dlss/pre-assembly/pull/104.diff","patch_url":"https://github.com/sul-dlss/pre-assembly/pull/104.patch","issue_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/104","number":104,"state":"closed","locked":false,"title":"Do not double-assign RAILS_ENV","user":{"login":"atz","id":109954,"node_id":"MDQ6VXNlcjEwOTk1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/109954?v=4","gravatar_id":"","url":"https://api.github.com/users/atz","html_url":"https://github.com/atz","followers_url":"https://api.github.com/users/atz/followers","following_url":"https://api.github.com/users/atz/following{/other_user}","gists_url":"https://api.github.com/users/atz/gists{/gist_id}","starred_url":"https://api.github.com/users/atz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atz/subscriptions","organizations_url":"https://api.github.com/users/atz/orgs","repos_url":"https://api.github.com/users/atz/repos","events_url":"https://api.github.com/users/atz/events{/privacy}","received_events_url":"https://api.github.com/users/atz/received_events","type":"User","site_admin":false},"body":"Effectively, boot was assigning RAILS_ENV, which is counterproductive.  Having a default value is fine, but otherwise allow `Rails.env` to take its own default.","created_at":"2018-08-21T22:47:21Z","updated_at":"2018-08-21T22:53:23Z","closed_at":"2018-08-21T22:53:23Z","merged_at":"2018-08-21T22:53:23Z","merge_commit_sha":"56f28947db1a991d5ad4f0920ccad8cdc2f22db7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1023448210,"node_id":"MDU6TGFiZWwxMDIzNDQ4MjEw","url":"https://api.github.com/repos/sul-dlss/pre-assembly/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/104/commits","review_comments_url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/104/comments","review_comment_url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/104/comments","statuses_url":"https://api.github.com/repos/sul-dlss/pre-assembly/statuses/45615e8756f1a3a7fb653ecec233fc38667b70df","head":{"label":"sul-dlss:boot_fix","ref":"boot_fix","sha":"45615e8756f1a3a7fb653ecec233fc38667b70df","user":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":22521770,"node_id":"MDEwOlJlcG9zaXRvcnkyMjUyMTc3MA==","name":"pre-assembly","full_name":"sul-dlss/pre-assembly","owner":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/pre-assembly","description":null,"fork":false,"url":"https://api.github.com/repos/sul-dlss/pre-assembly","forks_url":"https://api.github.com/repos/sul-dlss/pre-assembly/forks","keys_url":"https://api.github.com/repos/sul-dlss/pre-assembly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/pre-assembly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/pre-assembly/teams","hooks_url":"https://api.github.com/repos/sul-dlss/pre-assembly/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/pre-assembly/events","assignees_url":"https://api.github.com/repos/sul-dlss/pre-assembly/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/pre-assembly/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/pre-assembly/tags","blobs_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/pre-assembly/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/pre-assembly/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/pre-assembly/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/pre-assembly/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/pre-assembly/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/pre-assembly/subscription","commits_url":"https://api.github.com/repos/sul-dlss/pre-assembly/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/pre-assembly/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/pre-assembly/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/pre-assembly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/pre-assembly/merges","archive_url":"https://api.github.com/repos/sul-dlss/pre-assembly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/pre-assembly/downloads","issues_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/pre-assembly/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/pre-assembly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/pre-assembly/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/pre-assembly/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/pre-assembly/deployments","created_at":"2014-08-01T18:07:56Z","updated_at":"2018-08-21T22:32:25Z","pushed_at":"2018-08-21T22:53:23Z","git_url":"git://github.com/sul-dlss/pre-assembly.git","ssh_url":"git@github.com:sul-dlss/pre-assembly.git","clone_url":"https://github.com/sul-dlss/pre-assembly.git","svn_url":"https://github.com/sul-dlss/pre-assembly","homepage":"https://consul.stanford.edu/display/chimera/Automated+Accessioning+and+Object+Remediation+%28pre-assembly+and+assembly%29","size":1608,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":25,"watchers":1,"default_branch":"master"}},"base":{"label":"sul-dlss:master","ref":"master","sha":"4882513de99afa1874658764943e34ba31779502","user":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":22521770,"node_id":"MDEwOlJlcG9zaXRvcnkyMjUyMTc3MA==","name":"pre-assembly","full_name":"sul-dlss/pre-assembly","owner":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/pre-assembly","description":null,"fork":false,"url":"https://api.github.com/repos/sul-dlss/pre-assembly","forks_url":"https://api.github.com/repos/sul-dlss/pre-assembly/forks","keys_url":"https://api.github.com/repos/sul-dlss/pre-assembly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/pre-assembly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/pre-assembly/teams","hooks_url":"https://api.github.com/repos/sul-dlss/pre-assembly/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/pre-assembly/events","assignees_url":"https://api.github.com/repos/sul-dlss/pre-assembly/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/pre-assembly/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/pre-assembly/tags","blobs_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/pre-assembly/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/pre-assembly/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/pre-assembly/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/pre-assembly/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/pre-assembly/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/pre-assembly/subscription","commits_url":"https://api.github.com/repos/sul-dlss/pre-assembly/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/pre-assembly/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/pre-assembly/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/pre-assembly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/pre-assembly/merges","archive_url":"https://api.github.com/repos/sul-dlss/pre-assembly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/pre-assembly/downloads","issues_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/pre-assembly/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/pre-assembly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/pre-assembly/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/pre-assembly/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/pre-assembly/deployments","created_at":"2014-08-01T18:07:56Z","updated_at":"2018-08-21T22:32:25Z","pushed_at":"2018-08-21T22:53:23Z","git_url":"git://github.com/sul-dlss/pre-assembly.git","ssh_url":"git@github.com:sul-dlss/pre-assembly.git","clone_url":"https://github.com/sul-dlss/pre-assembly.git","svn_url":"https://github.com/sul-dlss/pre-assembly","homepage":"https://consul.stanford.edu/display/chimera/Automated+Accessioning+and+Object+Remediation+%28pre-assembly+and+assembly%29","size":1608,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":25,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/104"},"html":{"href":"https://github.com/sul-dlss/pre-assembly/pull/104"},"issue":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/104"},"comments":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/statuses/45615e8756f1a3a7fb653ecec233fc38667b70df"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"SaravShah","id":7877303,"node_id":"MDQ6VXNlcjc4NzczMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7877303?v=4","gravatar_id":"","url":"https://api.github.com/users/SaravShah","html_url":"https://github.com/SaravShah","followers_url":"https://api.github.com/users/SaravShah/followers","following_url":"https://api.github.com/users/SaravShah/following{/other_user}","gists_url":"https://api.github.com/users/SaravShah/gists{/gist_id}","starred_url":"https://api.github.com/users/SaravShah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaravShah/subscriptions","organizations_url":"https://api.github.com/users/SaravShah/orgs","repos_url":"https://api.github.com/users/SaravShah/repos","events_url":"https://api.github.com/users/SaravShah/events{/privacy}","received_events_url":"https://api.github.com/users/SaravShah/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"SaravShah"}}