{"action":"closed","issue":{"url":"https://api.github.com/repos/Microsoft/UWPCommunityToolkit/issues/1774","repository_url":"https://api.github.com/repos/Microsoft/UWPCommunityToolkit","labels_url":"https://api.github.com/repos/Microsoft/UWPCommunityToolkit/issues/1774/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/UWPCommunityToolkit/issues/1774/comments","events_url":"https://api.github.com/repos/Microsoft/UWPCommunityToolkit/issues/1774/events","html_url":"https://github.com/Microsoft/UWPCommunityToolkit/issues/1774","id":292074598,"number":1774,"title":"Connected animations does not support multiple sources to same page.","user":{"login":"azchohfi","id":527713,"avatar_url":"https://avatars3.githubusercontent.com/u/527713?v=4","gravatar_id":"","url":"https://api.github.com/users/azchohfi","html_url":"https://github.com/azchohfi","followers_url":"https://api.github.com/users/azchohfi/followers","following_url":"https://api.github.com/users/azchohfi/following{/other_user}","gists_url":"https://api.github.com/users/azchohfi/gists{/gist_id}","starred_url":"https://api.github.com/users/azchohfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azchohfi/subscriptions","organizations_url":"https://api.github.com/users/azchohfi/orgs","repos_url":"https://api.github.com/users/azchohfi/repos","events_url":"https://api.github.com/users/azchohfi/events{/privacy}","received_events_url":"https://api.github.com/users/azchohfi/received_events","type":"User","site_admin":false},"labels":[{"id":464292363,"url":"https://api.github.com/repos/Microsoft/UWPCommunityToolkit/labels/PR%20in%20progress","name":"PR in progress","color":"006b75","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-01-27T00:57:09Z","updated_at":"2018-02-21T22:59:14Z","closed_at":"2018-02-21T22:59:14Z","author_association":"CONTRIBUTOR","body":"## I'm submitting a...\r\n<!-- Check one of the following options with \"x\" -->\r\n```\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[X] Bug report \r\n[] Feature request\r\n[ ] Sample app request\r\n[ ] Documentation issue or request\r\n[ ] Question of Support request => Please do not submit support request here, instead see https://github.com/Microsoft/UWPCommunityToolkit/blob/master/contributing.md#question\r\n```\r\n\r\n## Current behavior\r\nSuppose you have one page with two ListViews or GridViews, and clicking on an item from both elements navigate to the same page. Suppose you add a connected animation using the XAML helpers (animations:Connected.ListItemElementName and animations:Connected.ListItemKey). You could have done that by using a Style to a ListView or GridView, or whatever. Right now, if you do that, it will crash when you navigate. This is not a scenario supported by the current code.\r\n\r\n## Expected behavior\r\nIt should not crash. It should navigate, with the connected animation from the right ListViewBase to the next page.\r\n\r\n## Minimal reproduction of the problem with instructions\r\nPage 1:\r\n```\r\n<GridView Column=\"0\" ItemsSource=\"{x:Bind ViewModel.X}\" animations:Connected.ListItemElementName=\"Image\" animations:Connected.ListItemKey=\"imageKey\">\r\n<GridView.ItemTemplate>\r\n...\r\n</GridView.ItemTemplate>\r\n</GridView>\r\n<GridView Column=\"1\" ItemsSource=\"{x:Bind ViewModel.Y}\" animations:Connected.ListItemElementName=\"Image\" animations:Connected.ListItemKey=\"imageKey\">\r\n<GridView.ItemTemplate>\r\n...\r\n</GridView.ItemTemplate>\r\n</GridView>\r\n```\r\nPage 2:\r\n`<Image Source=\"{x:Bind ViewModel....}\" animations:Connected.Key=\"imageKey\"/>`\r\n\r\n## Environment\r\n<!-- For bug reports Check one or more of the following options with \"x\" -->\r\n```\r\nNuget Package(s): Microsoft.Toolkit.Uwp.UI.Controls\r\n\r\nPackage Version(s): 2.1.1\r\n\r\nWindows 10 Build Number:\r\n- [ ] Anniversary Update (14393) \r\n- [ ] Creators Update (15063)\r\n- [X] Fall Creators Update (16299)\r\n- [ ] Insider Build (xxxxx)\r\n\r\nApp min and target version:\r\n- [ ] Anniversary Update (14393) \r\n- [ ] Creators Update (15063)\r\n- [X] Fall Creators Update (16299)\r\n- [ ] Insider Build (xxxxx)\r\n\r\nDevice form factor:\r\n- [X] Desktop\r\n- [ ] Mobile\r\n- [ ] Xbox\r\n- [ ] Surface Hub\r\n- [ ] IoT\r\n\r\nVisual Studio \r\n- [ ] 2017 15.3\r\n- [ ] 2017 15.4\r\n- [X] 2017 15.5\r\n\r\n```\r\n"}}
{"actor":{"display_login":"nmetulev"}}