{"action":"closed","number":4450,"pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/4450","id":205627232,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NjI3MjMy","html_url":"https://github.com/prometheus/prometheus/pull/4450","diff_url":"https://github.com/prometheus/prometheus/pull/4450.diff","patch_url":"https://github.com/prometheus/prometheus/pull/4450.patch","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/4450","number":4450,"state":"closed","locked":false,"title":"Fixes #4447, correctly parse VMs with empty tags","user":{"login":"johscheuer","id":9477533,"node_id":"MDQ6VXNlcjk0Nzc1MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/9477533?v=4","gravatar_id":"","url":"https://api.github.com/users/johscheuer","html_url":"https://github.com/johscheuer","followers_url":"https://api.github.com/users/johscheuer/followers","following_url":"https://api.github.com/users/johscheuer/following{/other_user}","gists_url":"https://api.github.com/users/johscheuer/gists{/gist_id}","starred_url":"https://api.github.com/users/johscheuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johscheuer/subscriptions","organizations_url":"https://api.github.com/users/johscheuer/orgs","repos_url":"https://api.github.com/users/johscheuer/repos","events_url":"https://api.github.com/users/johscheuer/events{/privacy}","received_events_url":"https://api.github.com/users/johscheuer/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Johannes M. Scheuermann <joh.scheuer@gmail.com>\r\n\r\nThis PR fixes: https://github.com/prometheus/prometheus/issues/4447 \r\n\r\nIn https://github.com/prometheus/prometheus/pull/4202 we changed from pointers to values and introduced an error by parsing empty tags. This PR corrects the parsing mechanism and adds simple unit tests for the VM parsing.","created_at":"2018-08-02T06:06:16Z","updated_at":"2018-08-02T09:10:18Z","closed_at":"2018-08-02T09:10:18Z","merged_at":"2018-08-02T09:10:17Z","merge_commit_sha":"f978f5bba3cfc756eeb34533ba7c4ec7e5d44dbe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/prometheus/pulls/4450/commits","review_comments_url":"https://api.github.com/repos/prometheus/prometheus/pulls/4450/comments","review_comment_url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/4450/comments","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/6dcf0495e7e15a2eb145f7f6349ee502cb841241","head":{"label":"johscheuer:bug-fix/azure-scrape-tags","ref":"bug-fix/azure-scrape-tags","sha":"6dcf0495e7e15a2eb145f7f6349ee502cb841241","user":{"login":"johscheuer","id":9477533,"node_id":"MDQ6VXNlcjk0Nzc1MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/9477533?v=4","gravatar_id":"","url":"https://api.github.com/users/johscheuer","html_url":"https://github.com/johscheuer","followers_url":"https://api.github.com/users/johscheuer/followers","following_url":"https://api.github.com/users/johscheuer/following{/other_user}","gists_url":"https://api.github.com/users/johscheuer/gists{/gist_id}","starred_url":"https://api.github.com/users/johscheuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johscheuer/subscriptions","organizations_url":"https://api.github.com/users/johscheuer/orgs","repos_url":"https://api.github.com/users/johscheuer/repos","events_url":"https://api.github.com/users/johscheuer/events{/privacy}","received_events_url":"https://api.github.com/users/johscheuer/received_events","type":"User","site_admin":false},"repo":{"id":135291160,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyOTExNjA=","name":"prometheus","full_name":"johscheuer/prometheus","owner":{"login":"johscheuer","id":9477533,"node_id":"MDQ6VXNlcjk0Nzc1MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/9477533?v=4","gravatar_id":"","url":"https://api.github.com/users/johscheuer","html_url":"https://github.com/johscheuer","followers_url":"https://api.github.com/users/johscheuer/followers","following_url":"https://api.github.com/users/johscheuer/following{/other_user}","gists_url":"https://api.github.com/users/johscheuer/gists{/gist_id}","starred_url":"https://api.github.com/users/johscheuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johscheuer/subscriptions","organizations_url":"https://api.github.com/users/johscheuer/orgs","repos_url":"https://api.github.com/users/johscheuer/repos","events_url":"https://api.github.com/users/johscheuer/events{/privacy}","received_events_url":"https://api.github.com/users/johscheuer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johscheuer/prometheus","description":"The Prometheus monitoring system and time series database.","fork":true,"url":"https://api.github.com/repos/johscheuer/prometheus","forks_url":"https://api.github.com/repos/johscheuer/prometheus/forks","keys_url":"https://api.github.com/repos/johscheuer/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johscheuer/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johscheuer/prometheus/teams","hooks_url":"https://api.github.com/repos/johscheuer/prometheus/hooks","issue_events_url":"https://api.github.com/repos/johscheuer/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/johscheuer/prometheus/events","assignees_url":"https://api.github.com/repos/johscheuer/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/johscheuer/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/johscheuer/prometheus/tags","blobs_url":"https://api.github.com/repos/johscheuer/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johscheuer/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johscheuer/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/johscheuer/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johscheuer/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/johscheuer/prometheus/languages","stargazers_url":"https://api.github.com/repos/johscheuer/prometheus/stargazers","contributors_url":"https://api.github.com/repos/johscheuer/prometheus/contributors","subscribers_url":"https://api.github.com/repos/johscheuer/prometheus/subscribers","subscription_url":"https://api.github.com/repos/johscheuer/prometheus/subscription","commits_url":"https://api.github.com/repos/johscheuer/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/johscheuer/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/johscheuer/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/johscheuer/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/johscheuer/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/johscheuer/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johscheuer/prometheus/merges","archive_url":"https://api.github.com/repos/johscheuer/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johscheuer/prometheus/downloads","issues_url":"https://api.github.com/repos/johscheuer/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/johscheuer/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/johscheuer/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/johscheuer/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johscheuer/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/johscheuer/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/johscheuer/prometheus/deployments","created_at":"2018-05-29T12:15:08Z","updated_at":"2018-05-29T12:15:12Z","pushed_at":"2018-08-02T06:04:14Z","git_url":"git://github.com/johscheuer/prometheus.git","ssh_url":"git@github.com:johscheuer/prometheus.git","clone_url":"https://github.com/johscheuer/prometheus.git","svn_url":"https://github.com/johscheuer/prometheus","homepage":"https://prometheus.io/","size":37013,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"70c98a06f13a167795f867640f6702adaaef2e2f","user":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":6838921,"node_id":"MDEwOlJlcG9zaXRvcnk2ODM4OTIx","name":"prometheus","full_name":"prometheus/prometheus","owner":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/prometheus","description":"The Prometheus monitoring system and time series database.","fork":false,"url":"https://api.github.com/repos/prometheus/prometheus","forks_url":"https://api.github.com/repos/prometheus/prometheus/forks","keys_url":"https://api.github.com/repos/prometheus/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/prometheus/teams","hooks_url":"https://api.github.com/repos/prometheus/prometheus/hooks","issue_events_url":"https://api.github.com/repos/prometheus/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/prometheus/events","assignees_url":"https://api.github.com/repos/prometheus/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/prometheus/tags","blobs_url":"https://api.github.com/repos/prometheus/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/prometheus/languages","stargazers_url":"https://api.github.com/repos/prometheus/prometheus/stargazers","contributors_url":"https://api.github.com/repos/prometheus/prometheus/contributors","subscribers_url":"https://api.github.com/repos/prometheus/prometheus/subscribers","subscription_url":"https://api.github.com/repos/prometheus/prometheus/subscription","commits_url":"https://api.github.com/repos/prometheus/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/prometheus/merges","archive_url":"https://api.github.com/repos/prometheus/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/prometheus/downloads","issues_url":"https://api.github.com/repos/prometheus/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/prometheus/deployments","created_at":"2012-11-24T11:14:12Z","updated_at":"2018-08-02T08:52:27Z","pushed_at":"2018-08-02T09:10:17Z","git_url":"git://github.com/prometheus/prometheus.git","ssh_url":"git@github.com:prometheus/prometheus.git","clone_url":"https://github.com/prometheus/prometheus.git","svn_url":"https://github.com/prometheus/prometheus","homepage":"https://prometheus.io/","size":39485,"stargazers_count":17888,"watchers_count":17888,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2338,"mirror_url":null,"archived":false,"open_issues_count":275,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2338,"open_issues":275,"watchers":17888,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4450"},"html":{"href":"https://github.com/prometheus/prometheus/pull/4450"},"issue":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/4450"},"comments":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/4450/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4450/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4450/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/prometheus/statuses/6dcf0495e7e15a2eb145f7f6349ee502cb841241"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"brian-brazil","id":7115638,"node_id":"MDQ6VXNlcjcxMTU2Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7115638?v=4","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":207,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"brian-brazil"}}