{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments/208242366","pull_request_review_id":144009682,"id":208242366,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODI0MjM2Ng==","diff_hunk":"@@ -558,6 +567,16 @@ export class CloudFrontWebDistribution extends cdk.Construct {\n \n     }\n \n+    public validate(): string[] {","path":"packages/@aws-cdk/aws-cloudfront/lib/web_distribution.ts","position":35,"original_position":35,"commit_id":"64c6a32f4e568620dcd40ac18241bfa79d849a55","original_commit_id":"64c6a32f4e568620dcd40ac18241bfa79d849a55","user":{"login":"eladb","id":598796,"node_id":"MDQ6VXNlcjU5ODc5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/598796?v=4","gravatar_id":"","url":"https://api.github.com/users/eladb","html_url":"https://github.com/eladb","followers_url":"https://api.github.com/users/eladb/followers","following_url":"https://api.github.com/users/eladb/following{/other_user}","gists_url":"https://api.github.com/users/eladb/gists{/gist_id}","starred_url":"https://api.github.com/users/eladb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladb/subscriptions","organizations_url":"https://api.github.com/users/eladb/orgs","repos_url":"https://api.github.com/users/eladb/repos","events_url":"https://api.github.com/users/eladb/events{/privacy}","received_events_url":"https://api.github.com/users/eladb/received_events","type":"User","site_admin":false},"body":"Yap. It's a hook that allows you to perform validations just before synthesis. But the sooner you can perform a validation, the better, because the error will include the most context for the user to be able to understand what they did wrong.","created_at":"2018-08-07T14:01:24Z","updated_at":"2018-08-07T14:01:24Z","html_url":"https://github.com/awslabs/aws-cdk/pull/514#discussion_r208242366","pull_request_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/514","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments/208242366"},"html":{"href":"https://github.com/awslabs/aws-cdk/pull/514#discussion_r208242366"},"pull_request":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/514"}},"in_reply_to_id":208115214},"pull_request":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/514","id":206496762,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDk2NzYy","html_url":"https://github.com/awslabs/aws-cdk/pull/514","diff_url":"https://github.com/awslabs/aws-cdk/pull/514.diff","patch_url":"https://github.com/awslabs/aws-cdk/pull/514.patch","issue_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/514","number":514,"state":"open","locked":false,"title":"Fix CloudFront origin error","user":{"login":"mindstorms6","id":92937,"node_id":"MDQ6VXNlcjkyOTM3","avatar_url":"https://avatars1.githubusercontent.com/u/92937?v=4","gravatar_id":"","url":"https://api.github.com/users/mindstorms6","html_url":"https://github.com/mindstorms6","followers_url":"https://api.github.com/users/mindstorms6/followers","following_url":"https://api.github.com/users/mindstorms6/following{/other_user}","gists_url":"https://api.github.com/users/mindstorms6/gists{/gist_id}","starred_url":"https://api.github.com/users/mindstorms6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindstorms6/subscriptions","organizations_url":"https://api.github.com/users/mindstorms6/orgs","repos_url":"https://api.github.com/users/mindstorms6/repos","events_url":"https://api.github.com/users/mindstorms6/events{/privacy}","received_events_url":"https://api.github.com/users/mindstorms6/received_events","type":"User","site_admin":false},"body":"When using CloudFront without an origin access identity, we were failing to include the \"empty\" property S3OriginConfig - this fixes that.\r\n\r\nAlso adds an integ test and a validate that verifies this.\r\n\r\nShould fix #508\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.\r\n","created_at":"2018-08-06T19:40:25Z","updated_at":"2018-08-07T14:01:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00861af0042493ec94e19baf06a746d0335c106a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/514/commits","review_comments_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/514/comments","review_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/514/comments","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/64c6a32f4e568620dcd40ac18241bfa79d849a55","head":{"label":"mindstorms6:508-cloudfront-origin","ref":"508-cloudfront-origin","sha":"64c6a32f4e568620dcd40ac18241bfa79d849a55","user":{"login":"mindstorms6","id":92937,"node_id":"MDQ6VXNlcjkyOTM3","avatar_url":"https://avatars1.githubusercontent.com/u/92937?v=4","gravatar_id":"","url":"https://api.github.com/users/mindstorms6","html_url":"https://github.com/mindstorms6","followers_url":"https://api.github.com/users/mindstorms6/followers","following_url":"https://api.github.com/users/mindstorms6/following{/other_user}","gists_url":"https://api.github.com/users/mindstorms6/gists{/gist_id}","starred_url":"https://api.github.com/users/mindstorms6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindstorms6/subscriptions","organizations_url":"https://api.github.com/users/mindstorms6/orgs","repos_url":"https://api.github.com/users/mindstorms6/repos","events_url":"https://api.github.com/users/mindstorms6/events{/privacy}","received_events_url":"https://api.github.com/users/mindstorms6/received_events","type":"User","site_admin":false},"repo":{"id":143649920,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2NDk5MjA=","name":"aws-cdk-1","full_name":"mindstorms6/aws-cdk-1","owner":{"login":"mindstorms6","id":92937,"node_id":"MDQ6VXNlcjkyOTM3","avatar_url":"https://avatars1.githubusercontent.com/u/92937?v=4","gravatar_id":"","url":"https://api.github.com/users/mindstorms6","html_url":"https://github.com/mindstorms6","followers_url":"https://api.github.com/users/mindstorms6/followers","following_url":"https://api.github.com/users/mindstorms6/following{/other_user}","gists_url":"https://api.github.com/users/mindstorms6/gists{/gist_id}","starred_url":"https://api.github.com/users/mindstorms6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindstorms6/subscriptions","organizations_url":"https://api.github.com/users/mindstorms6/orgs","repos_url":"https://api.github.com/users/mindstorms6/repos","events_url":"https://api.github.com/users/mindstorms6/events{/privacy}","received_events_url":"https://api.github.com/users/mindstorms6/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mindstorms6/aws-cdk-1","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":true,"url":"https://api.github.com/repos/mindstorms6/aws-cdk-1","forks_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/forks","keys_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/teams","hooks_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/hooks","issue_events_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/issues/events{/number}","events_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/events","assignees_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/assignees{/user}","branches_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/branches{/branch}","tags_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/tags","blobs_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/statuses/{sha}","languages_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/languages","stargazers_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/stargazers","contributors_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/contributors","subscribers_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/subscribers","subscription_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/subscription","commits_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/contents/{+path}","compare_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/merges","archive_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/downloads","issues_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/issues{/number}","pulls_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/pulls{/number}","milestones_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/milestones{/number}","notifications_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/labels{/name}","releases_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/releases{/id}","deployments_url":"https://api.github.com/repos/mindstorms6/aws-cdk-1/deployments","created_at":"2018-08-05T21:45:57Z","updated_at":"2018-08-05T21:53:50Z","pushed_at":"2018-08-07T00:55:09Z","git_url":"git://github.com/mindstorms6/aws-cdk-1.git","ssh_url":"git@github.com:mindstorms6/aws-cdk-1.git","clone_url":"https://github.com/mindstorms6/aws-cdk-1.git","svn_url":"https://github.com/mindstorms6/aws-cdk-1","homepage":"https://awslabs.github.io/aws-cdk","size":71070,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"9f0b114714e99f1a4a4eadd57e58649beca5ab80","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":105808767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MDg3Njc=","name":"aws-cdk","full_name":"awslabs/aws-cdk","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":false,"url":"https://api.github.com/repos/awslabs/aws-cdk","forks_url":"https://api.github.com/repos/awslabs/aws-cdk/forks","keys_url":"https://api.github.com/repos/awslabs/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-cdk/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-cdk/events","assignees_url":"https://api.github.com/repos/awslabs/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-cdk/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-cdk/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-cdk/merges","archive_url":"https://api.github.com/repos/awslabs/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-cdk/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-cdk/deployments","created_at":"2017-10-04T19:22:36Z","updated_at":"2018-08-07T13:46:57Z","pushed_at":"2018-08-07T13:07:37Z","git_url":"git://github.com/awslabs/aws-cdk.git","ssh_url":"git@github.com:awslabs/aws-cdk.git","clone_url":"https://github.com/awslabs/aws-cdk.git","svn_url":"https://github.com/awslabs/aws-cdk","homepage":"https://awslabs.github.io/aws-cdk","size":71095,"stargazers_count":468,"watchers_count":468,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":198,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":198,"watchers":468,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/514"},"html":{"href":"https://github.com/awslabs/aws-cdk/pull/514"},"issue":{"href":"https://api.github.com/repos/awslabs/aws-cdk/issues/514"},"comments":{"href":"https://api.github.com/repos/awslabs/aws-cdk/issues/514/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/514/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/514/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/aws-cdk/statuses/64c6a32f4e568620dcd40ac18241bfa79d849a55"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eladb"}}