{"action":"created","comment":{"url":"https://api.github.com/repos/omarnyte/http-server/pulls/comments/202171619","pull_request_review_id":136819861,"id":202171619,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjE3MTYxOQ==","diff_hunk":"@@ -0,0 +1,59 @@\n+import static org.junit.Assert.assertEquals;\n+import org.junit.Before;\n+import org.junit.Test;\n+\n+public class ResponseTest {\n+\n+  private Response goodResponse = new Response();\n+  private Response badResponse = new Response();","path":"src/test/java/Response/ResponseTest.java","position":null,"original_position":8,"commit_id":"f6d4c281e43ea29bac05359683c6dd68142715ec","original_commit_id":"c12ea36cc1330e3b1f8f4da75e64eb2de36c41ac","user":{"login":"omarnyte","id":6590135,"node_id":"MDQ6VXNlcjY1OTAxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6590135?v=4","gravatar_id":"","url":"https://api.github.com/users/omarnyte","html_url":"https://github.com/omarnyte","followers_url":"https://api.github.com/users/omarnyte/followers","following_url":"https://api.github.com/users/omarnyte/following{/other_user}","gists_url":"https://api.github.com/users/omarnyte/gists{/gist_id}","starred_url":"https://api.github.com/users/omarnyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarnyte/subscriptions","organizations_url":"https://api.github.com/users/omarnyte/orgs","repos_url":"https://api.github.com/users/omarnyte/repos","events_url":"https://api.github.com/users/omarnyte/events{/privacy}","received_events_url":"https://api.github.com/users/omarnyte/received_events","type":"User","site_admin":false},"body":"I've changed the name to `response`.","created_at":"2018-07-12T20:39:47Z","updated_at":"2018-07-12T20:39:47Z","html_url":"https://github.com/omarnyte/http-server/pull/1#discussion_r202171619","pull_request_url":"https://api.github.com/repos/omarnyte/http-server/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/omarnyte/http-server/pulls/comments/202171619"},"html":{"href":"https://github.com/omarnyte/http-server/pull/1#discussion_r202171619"},"pull_request":{"href":"https://api.github.com/repos/omarnyte/http-server/pulls/1"}},"in_reply_to_id":201565499},"pull_request":{"url":"https://api.github.com/repos/omarnyte/http-server/pulls/1","id":200231613,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMjMxNjEz","html_url":"https://github.com/omarnyte/http-server/pull/1","diff_url":"https://github.com/omarnyte/http-server/pull/1.diff","patch_url":"https://github.com/omarnyte/http-server/pull/1.patch","issue_url":"https://api.github.com/repos/omarnyte/http-server/issues/1","number":1,"state":"open","locked":false,"title":"#1: The server responds to GET requests to the root","user":{"login":"omarnyte","id":6590135,"node_id":"MDQ6VXNlcjY1OTAxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6590135?v=4","gravatar_id":"","url":"https://api.github.com/users/omarnyte","html_url":"https://github.com/omarnyte","followers_url":"https://api.github.com/users/omarnyte/followers","following_url":"https://api.github.com/users/omarnyte/following{/other_user}","gists_url":"https://api.github.com/users/omarnyte/gists{/gist_id}","starred_url":"https://api.github.com/users/omarnyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarnyte/subscriptions","organizations_url":"https://api.github.com/users/omarnyte/orgs","repos_url":"https://api.github.com/users/omarnyte/repos","events_url":"https://api.github.com/users/omarnyte/events{/privacy}","received_events_url":"https://api.github.com/users/omarnyte/received_events","type":"User","site_admin":false},"body":"This pull request completes Story #1 of the HTTP Server.\r\n\r\n## Request\r\nThe `Request` class has been refactored with the Builder pattern. All tests that create requests have been updated to create `Request` objects correctly. \r\n\r\n## Response \r\nI've removed any validation logic from the `Response` class.\r\n\r\n## Router \r\nA router is now instantiated with a hashmap of routes passed in as an argument. That map is currently created in the main `HTTPServer` class.  \r\n\r\n## Server\r\nCurrently, the `start` method includes the following code: \r\n``` java        \r\nif (requestString == \"\") {\r\n  continue;\r\n}\r\n```\r\nWithout this code, empty input from the client was being pased to `RequestParser`, which resulted in a NullPointerException when trying to `split` null. I will spend more time addressing this issue in the following story. ","created_at":"2018-07-09T22:00:07Z","updated_at":"2018-07-12T20:39:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43e12acc6e530a11bde0c09ffe2cbc39f4e387e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/omarnyte/http-server/pulls/1/commits","review_comments_url":"https://api.github.com/repos/omarnyte/http-server/pulls/1/comments","review_comment_url":"https://api.github.com/repos/omarnyte/http-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omarnyte/http-server/issues/1/comments","statuses_url":"https://api.github.com/repos/omarnyte/http-server/statuses/f6d4c281e43ea29bac05359683c6dd68142715ec","head":{"label":"omarnyte:ft/GET-reqest-to-root","ref":"ft/GET-reqest-to-root","sha":"f6d4c281e43ea29bac05359683c6dd68142715ec","user":{"login":"omarnyte","id":6590135,"node_id":"MDQ6VXNlcjY1OTAxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6590135?v=4","gravatar_id":"","url":"https://api.github.com/users/omarnyte","html_url":"https://github.com/omarnyte","followers_url":"https://api.github.com/users/omarnyte/followers","following_url":"https://api.github.com/users/omarnyte/following{/other_user}","gists_url":"https://api.github.com/users/omarnyte/gists{/gist_id}","starred_url":"https://api.github.com/users/omarnyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarnyte/subscriptions","organizations_url":"https://api.github.com/users/omarnyte/orgs","repos_url":"https://api.github.com/users/omarnyte/repos","events_url":"https://api.github.com/users/omarnyte/events{/privacy}","received_events_url":"https://api.github.com/users/omarnyte/received_events","type":"User","site_admin":false},"repo":{"id":138929827,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg5Mjk4Mjc=","name":"http-server","full_name":"omarnyte/http-server","owner":{"login":"omarnyte","id":6590135,"node_id":"MDQ6VXNlcjY1OTAxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6590135?v=4","gravatar_id":"","url":"https://api.github.com/users/omarnyte","html_url":"https://github.com/omarnyte","followers_url":"https://api.github.com/users/omarnyte/followers","following_url":"https://api.github.com/users/omarnyte/following{/other_user}","gists_url":"https://api.github.com/users/omarnyte/gists{/gist_id}","starred_url":"https://api.github.com/users/omarnyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarnyte/subscriptions","organizations_url":"https://api.github.com/users/omarnyte/orgs","repos_url":"https://api.github.com/users/omarnyte/repos","events_url":"https://api.github.com/users/omarnyte/events{/privacy}","received_events_url":"https://api.github.com/users/omarnyte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omarnyte/http-server","description":null,"fork":false,"url":"https://api.github.com/repos/omarnyte/http-server","forks_url":"https://api.github.com/repos/omarnyte/http-server/forks","keys_url":"https://api.github.com/repos/omarnyte/http-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omarnyte/http-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omarnyte/http-server/teams","hooks_url":"https://api.github.com/repos/omarnyte/http-server/hooks","issue_events_url":"https://api.github.com/repos/omarnyte/http-server/issues/events{/number}","events_url":"https://api.github.com/repos/omarnyte/http-server/events","assignees_url":"https://api.github.com/repos/omarnyte/http-server/assignees{/user}","branches_url":"https://api.github.com/repos/omarnyte/http-server/branches{/branch}","tags_url":"https://api.github.com/repos/omarnyte/http-server/tags","blobs_url":"https://api.github.com/repos/omarnyte/http-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omarnyte/http-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omarnyte/http-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/omarnyte/http-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omarnyte/http-server/statuses/{sha}","languages_url":"https://api.github.com/repos/omarnyte/http-server/languages","stargazers_url":"https://api.github.com/repos/omarnyte/http-server/stargazers","contributors_url":"https://api.github.com/repos/omarnyte/http-server/contributors","subscribers_url":"https://api.github.com/repos/omarnyte/http-server/subscribers","subscription_url":"https://api.github.com/repos/omarnyte/http-server/subscription","commits_url":"https://api.github.com/repos/omarnyte/http-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/omarnyte/http-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/omarnyte/http-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/omarnyte/http-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/omarnyte/http-server/contents/{+path}","compare_url":"https://api.github.com/repos/omarnyte/http-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omarnyte/http-server/merges","archive_url":"https://api.github.com/repos/omarnyte/http-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omarnyte/http-server/downloads","issues_url":"https://api.github.com/repos/omarnyte/http-server/issues{/number}","pulls_url":"https://api.github.com/repos/omarnyte/http-server/pulls{/number}","milestones_url":"https://api.github.com/repos/omarnyte/http-server/milestones{/number}","notifications_url":"https://api.github.com/repos/omarnyte/http-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omarnyte/http-server/labels{/name}","releases_url":"https://api.github.com/repos/omarnyte/http-server/releases{/id}","deployments_url":"https://api.github.com/repos/omarnyte/http-server/deployments","created_at":"2018-06-27T20:29:53Z","updated_at":"2018-06-29T22:55:40Z","pushed_at":"2018-07-11T23:32:02Z","git_url":"git://github.com/omarnyte/http-server.git","ssh_url":"git@github.com:omarnyte/http-server.git","clone_url":"https://github.com/omarnyte/http-server.git","svn_url":"https://github.com/omarnyte/http-server","homepage":null,"size":71,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"omarnyte:master","ref":"master","sha":"1229d738f55378eb46b5ef95d458d5dd166968b3","user":{"login":"omarnyte","id":6590135,"node_id":"MDQ6VXNlcjY1OTAxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6590135?v=4","gravatar_id":"","url":"https://api.github.com/users/omarnyte","html_url":"https://github.com/omarnyte","followers_url":"https://api.github.com/users/omarnyte/followers","following_url":"https://api.github.com/users/omarnyte/following{/other_user}","gists_url":"https://api.github.com/users/omarnyte/gists{/gist_id}","starred_url":"https://api.github.com/users/omarnyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarnyte/subscriptions","organizations_url":"https://api.github.com/users/omarnyte/orgs","repos_url":"https://api.github.com/users/omarnyte/repos","events_url":"https://api.github.com/users/omarnyte/events{/privacy}","received_events_url":"https://api.github.com/users/omarnyte/received_events","type":"User","site_admin":false},"repo":{"id":138929827,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg5Mjk4Mjc=","name":"http-server","full_name":"omarnyte/http-server","owner":{"login":"omarnyte","id":6590135,"node_id":"MDQ6VXNlcjY1OTAxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6590135?v=4","gravatar_id":"","url":"https://api.github.com/users/omarnyte","html_url":"https://github.com/omarnyte","followers_url":"https://api.github.com/users/omarnyte/followers","following_url":"https://api.github.com/users/omarnyte/following{/other_user}","gists_url":"https://api.github.com/users/omarnyte/gists{/gist_id}","starred_url":"https://api.github.com/users/omarnyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarnyte/subscriptions","organizations_url":"https://api.github.com/users/omarnyte/orgs","repos_url":"https://api.github.com/users/omarnyte/repos","events_url":"https://api.github.com/users/omarnyte/events{/privacy}","received_events_url":"https://api.github.com/users/omarnyte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omarnyte/http-server","description":null,"fork":false,"url":"https://api.github.com/repos/omarnyte/http-server","forks_url":"https://api.github.com/repos/omarnyte/http-server/forks","keys_url":"https://api.github.com/repos/omarnyte/http-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omarnyte/http-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omarnyte/http-server/teams","hooks_url":"https://api.github.com/repos/omarnyte/http-server/hooks","issue_events_url":"https://api.github.com/repos/omarnyte/http-server/issues/events{/number}","events_url":"https://api.github.com/repos/omarnyte/http-server/events","assignees_url":"https://api.github.com/repos/omarnyte/http-server/assignees{/user}","branches_url":"https://api.github.com/repos/omarnyte/http-server/branches{/branch}","tags_url":"https://api.github.com/repos/omarnyte/http-server/tags","blobs_url":"https://api.github.com/repos/omarnyte/http-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omarnyte/http-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omarnyte/http-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/omarnyte/http-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omarnyte/http-server/statuses/{sha}","languages_url":"https://api.github.com/repos/omarnyte/http-server/languages","stargazers_url":"https://api.github.com/repos/omarnyte/http-server/stargazers","contributors_url":"https://api.github.com/repos/omarnyte/http-server/contributors","subscribers_url":"https://api.github.com/repos/omarnyte/http-server/subscribers","subscription_url":"https://api.github.com/repos/omarnyte/http-server/subscription","commits_url":"https://api.github.com/repos/omarnyte/http-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/omarnyte/http-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/omarnyte/http-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/omarnyte/http-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/omarnyte/http-server/contents/{+path}","compare_url":"https://api.github.com/repos/omarnyte/http-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omarnyte/http-server/merges","archive_url":"https://api.github.com/repos/omarnyte/http-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omarnyte/http-server/downloads","issues_url":"https://api.github.com/repos/omarnyte/http-server/issues{/number}","pulls_url":"https://api.github.com/repos/omarnyte/http-server/pulls{/number}","milestones_url":"https://api.github.com/repos/omarnyte/http-server/milestones{/number}","notifications_url":"https://api.github.com/repos/omarnyte/http-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omarnyte/http-server/labels{/name}","releases_url":"https://api.github.com/repos/omarnyte/http-server/releases{/id}","deployments_url":"https://api.github.com/repos/omarnyte/http-server/deployments","created_at":"2018-06-27T20:29:53Z","updated_at":"2018-06-29T22:55:40Z","pushed_at":"2018-07-11T23:32:02Z","git_url":"git://github.com/omarnyte/http-server.git","ssh_url":"git@github.com:omarnyte/http-server.git","clone_url":"https://github.com/omarnyte/http-server.git","svn_url":"https://github.com/omarnyte/http-server","homepage":null,"size":71,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omarnyte/http-server/pulls/1"},"html":{"href":"https://github.com/omarnyte/http-server/pull/1"},"issue":{"href":"https://api.github.com/repos/omarnyte/http-server/issues/1"},"comments":{"href":"https://api.github.com/repos/omarnyte/http-server/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/omarnyte/http-server/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/omarnyte/http-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omarnyte/http-server/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/omarnyte/http-server/statuses/f6d4c281e43ea29bac05359683c6dd68142715ec"}},"author_association":"OWNER"}}
{"actor":{"display_login":"omarnyte"}}