{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/178436301","pull_request_review_id":108496887,"id":178436301,"diff_hunk":"@@ -191,6 +190,7 @@ class CChainState {\n     CBlockIndex* FindMostWorkChain();\n     bool ReceivedBlockTransactions(const CBlock &block, CValidationState& state, CBlockIndex *pindexNew, const CDiskBlockPos& pos, const Consensus::Params& consensusParams);\n \n+    void PruneBlockIndexCandidates();","path":"src/validation.cpp","position":51,"original_position":14,"commit_id":"4576f1de6725bab583797d081421b992872fd616","original_commit_id":"fb6a932e9bde3db424c7805452bc3abf603a20f1","user":{"login":"promag","id":3534524,"avatar_url":"https://avatars1.githubusercontent.com/u/3534524?v=4","gravatar_id":"","url":"https://api.github.com/users/promag","html_url":"https://github.com/promag","followers_url":"https://api.github.com/users/promag/followers","following_url":"https://api.github.com/users/promag/following{/other_user}","gists_url":"https://api.github.com/users/promag/gists{/gist_id}","starred_url":"https://api.github.com/users/promag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/promag/subscriptions","organizations_url":"https://api.github.com/users/promag/orgs","repos_url":"https://api.github.com/users/promag/repos","events_url":"https://api.github.com/users/promag/events{/privacy}","received_events_url":"https://api.github.com/users/promag/received_events","type":"User","site_admin":false},"body":"Oh missed the visibility change.","created_at":"2018-03-31T16:42:32Z","updated_at":"2018-03-31T16:42:32Z","html_url":"https://github.com/bitcoin/bitcoin/pull/12802#discussion_r178436301","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12802","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/178436301"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/12802#discussion_r178436301"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12802"}},"in_reply_to_id":178429948},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12802","id":177845855,"html_url":"https://github.com/bitcoin/bitcoin/pull/12802","diff_url":"https://github.com/bitcoin/bitcoin/pull/12802.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/12802.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12802","number":12802,"state":"open","locked":false,"title":"Colonel Mustard in the Lounge with the Lead Pipe (killed mapBlockIndex outside of validation)","user":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars0.githubusercontent.com/u/649246?v=4","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"body":"Replaces #10692 after #11041 was merged. Stops exporting mapBlockIndex in validation.h entirely, also making it const inside of validation.cpp outside of CChainState. Also makes chainActive const everywhere outside of CChainState and, together, removes all non-const CBlockIndex*s outside of validation/(mostly CChainState).\r\n\r\nSorry, no lyrics this time.","created_at":"2018-03-27T19:47:15Z","updated_at":"2018-03-31T16:42:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5062182c306dae2d6bf25d3c4f955383a2042f81","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135961,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6","default":false},{"id":118379652,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Validation","name":"Validation","color":"6060aa","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12802/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12802/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12802/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/4576f1de6725bab583797d081421b992872fd616","head":{"label":"TheBlueMatt:2018-03-const-cblockindex","ref":"2018-03-const-cblockindex","sha":"4576f1de6725bab583797d081421b992872fd616","user":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars0.githubusercontent.com/u/649246?v=4","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"repo":{"id":1443291,"name":"bitcoin","full_name":"TheBlueMatt/bitcoin","owner":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars0.githubusercontent.com/u/649246?v=4","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheBlueMatt/bitcoin","description":"Bitcoin (dont fork from here, fork from bitcoin/bitcoin)","fork":true,"url":"https://api.github.com/repos/TheBlueMatt/bitcoin","forks_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/forks","keys_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/teams","hooks_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/events","assignees_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/tags","blobs_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/languages","stargazers_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/subscription","commits_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/merges","archive_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/downloads","issues_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/deployments","created_at":"2011-03-05T14:14:49Z","updated_at":"2018-03-29T14:32:19Z","pushed_at":"2018-03-29T14:32:15Z","git_url":"git://github.com/TheBlueMatt/bitcoin.git","ssh_url":"git@github.com:TheBlueMatt/bitcoin.git","clone_url":"https://github.com/TheBlueMatt/bitcoin.git","svn_url":"https://github.com/TheBlueMatt/bitcoin","homepage":"http://www.bitcoin.org/","size":101082,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":1,"watchers":15,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"624bee96597c1d59018e58131b8285c0b332700d","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-03-31T16:37:29Z","pushed_at":"2018-03-31T16:40:27Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":103707,"stargazers_count":30066,"watchers_count":30066,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":18004,"mirror_url":null,"archived":false,"open_issues_count":792,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":18004,"open_issues":792,"watchers":30066,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12802"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/12802"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/12802"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/12802/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12802/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12802/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/4576f1de6725bab583797d081421b992872fd616"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"promag"}}