{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angularfire2/issues/1608","repository_url":"https://api.github.com/repos/angular/angularfire2","labels_url":"https://api.github.com/repos/angular/angularfire2/issues/1608/labels{/name}","comments_url":"https://api.github.com/repos/angular/angularfire2/issues/1608/comments","events_url":"https://api.github.com/repos/angular/angularfire2/issues/1608/events","html_url":"https://github.com/angular/angularfire2/issues/1608","id":321751036,"number":1608,"title":"angularfire2@5.0.0-rc.7 breaks Karma test runner","user":{"login":"byrondover","id":874361,"avatar_url":"https://avatars0.githubusercontent.com/u/874361?v=4","gravatar_id":"","url":"https://api.github.com/users/byrondover","html_url":"https://github.com/byrondover","followers_url":"https://api.github.com/users/byrondover/followers","following_url":"https://api.github.com/users/byrondover/following{/other_user}","gists_url":"https://api.github.com/users/byrondover/gists{/gist_id}","starred_url":"https://api.github.com/users/byrondover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byrondover/subscriptions","organizations_url":"https://api.github.com/users/byrondover/orgs","repos_url":"https://api.github.com/users/byrondover/repos","events_url":"https://api.github.com/users/byrondover/events{/privacy}","received_events_url":"https://api.github.com/users/byrondover/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-09T22:43:53Z","updated_at":"2018-05-12T22:28:52Z","closed_at":"2018-05-12T22:28:52Z","author_association":"CONTRIBUTOR","body":"<!--\r\n\r\nIMPORTANT! YOU MUST FOLLOW THESE INSTRUCTIONS OR YOUR ISSUE WILL BE CLOSED.\r\n\r\nThank you for contributing to the Angular and Firebase communities!\r\n\r\nHave a usage question?\r\n=======================\r\nWe get lots of those and we love helping you, but GitHub is not the best place for them and they will be closed. Here are some resources to get help:\r\n\r\n- Go through the Developer's Guide: https://github.com/angular/angularfire2#developer-guide\r\n\r\nIf the official documentation doesn't help, try asking through our officially supported channels:\r\n\r\n- Firebase Google Group: https://groups.google.com/forum/#!forum/firebase-talk\r\n- Stack Overflow: https://stackoverflow.com/questions/tagged/angular (include the firebase and angularfire tags, too!)\r\n\r\n*Please avoid double posting across multiple channels!*\r\n\r\nThink you found a bug?\r\n=======================\r\nYeah, we're definitely not perfect! Please use the bug report template below and include a minimal repro when opening the issue.\r\n\r\nHave a feature request?\r\n========================\r\nGreat, we love hearing how we can improve our products! Remove the template below and\r\nprovide an explanation of your feature request. Provide code samples if applicable. Try to\r\nthink about what it will allow you to do that you can't do today? How will it make current\r\nworkarounds straightforward? What potential bugs and edge cases does it help to avoid?\r\n\r\n-->\r\n\r\nAfter upgrading from AngularFire2 `5.0.0-rc.6.0` to `5.0.0-rc.7`, Karma appears to no longer detect unit tests defined in `**/*.spec.ts` files.\r\n\r\nReproducible as follows.\r\n\r\n1. Follow the AngularFire setup steps defined in [docs/install-and-setup.md](https://github.com/angular/angularfire2/blob/master/docs/install-and-setup.md).\r\n1. Launch Karma by running `ng test`.\r\n\r\nI am not very familiar Karma bootstrap mechanics, so if there's something obvious I'm missing, please feel free to point me in right direction and close this issue.\r\n\r\n### Version info\r\n\r\n<!-- What versions of the following libraries are you using? Note that your issue may already\r\nbe fixed in the latest versions. -->\r\n\r\n**Angular:** 6.0.0\r\n\r\n```\r\n% ng --version\r\n\r\n     _                      _                 ____ _     ___\r\n    / \\   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|\r\n   / △ \\ | '_ \\ / _` | | | | |/ _` | '__|   | |   | |    | |\r\n  / ___ \\| | | | (_| | |_| | | (_| | |      | |___| |___ | |\r\n /_/   \\_\\_| |_|\\__, |\\__,_|_|\\__,_|_|       \\____|_____|___|\r\n                |___/\r\n\r\n\r\nAngular CLI: 6.0.0\r\nNode: 9.11.1\r\nOS: darwin x64\r\nAngular: 6.0.0\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... http, language-service, platform-browser\r\n... platform-browser-dynamic, router\r\n\r\nPackage                           Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect         0.6.0\r\n@angular-devkit/build-angular     0.6.0\r\n@angular-devkit/build-optimizer   0.6.0\r\n@angular-devkit/core              0.6.0\r\n@angular-devkit/schematics        0.6.0\r\n@ngtools/webpack                  6.0.0\r\n@schematics/angular               0.6.0\r\n@schematics/update                0.6.0\r\nrxjs                              6.1.0\r\ntypescript                        2.7.2\r\nwebpack                           4.6.0\r\n```\r\n\r\n**Firebase:** 4.13.1\r\n\r\n**AngularFire:** 5.0.0-rc.7\r\n\r\n**Browser:** Chrome OS v66.0.3359\r\n\r\n**Operating system:** macOS Sierra v10.12.6\r\n\r\n### How to reproduce these conditions\r\n\r\n**Failing test unit, Plunkr, or JSFiddle demonstrating the problem**\r\n\r\nI have created two (2) stock Angular repos demonstrating the issue.\r\n\r\n- <https://github.com/byrondover/angular-with-rc6>\r\n- <https://github.com/byrondover/angular-with-rc7>\r\n\r\nTo reproduce, clone these repos separately, then run `npm install` / `yarn` followed by `ng test` in each to demonstrate the difference between stock Karma unit tests with AngularFire2 `5.0.0-rc.6.0` vs `5.0.0-rc.7`.\r\n\r\n<!-- \r\nProvide a failing test unit, or create a minimal, complete, and \r\nverifiable example (http://stackoverflow.com/help/mcve) using either \r\nPlunker (http://plnkr.co/) or JSFiddle (https://jsfiddle.net/).\r\n-->\r\n\r\n**Steps to set up and reproduce**\r\n\r\n1. Follow the setup steps defined in [docs/install-and-setup.md](https://github.com/angular/angularfire2/blob/master/docs/install-and-setup.md).\r\n1. Launch Karma by running `ng test`.\r\n\r\n### Debug output\r\n\r\n** Errors in the JavaScript console **\r\n\r\n```shell\r\n% ng test\r\n 10% building modules 1/1 modules 0 active(node:10914) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead\r\n09 05 2018 15:03:55.728:INFO [karma]: Karma v1.7.1 server started at http://0.0.0.0:9876/\r\n09 05 2018 15:03:55.730:INFO [launcher]: Launching browser Chrome with unlimited concurrency\r\n09 05 2018 15:03:55.736:INFO [launcher]: Starting browser Chrome\r\n09 05 2018 15:04:01.932:INFO [Chrome 66.0.3359 (Mac OS X 10.12.6)]: Connected on socket utmTD_2mcCpKpxdsAAAA with id 16434490\r\nChrome 66.0.3359 (Mac OS X 10.12.6): Executed 0 of 0 ERROR (0.011 secs / 0 secs)\r\n```\r\n\r\n** Output from `firebase.database().enableLogging(true);` **\r\n\r\nNot sure how to enable this.\r\n\r\n** Screenshots **\r\n\r\n<img width=\"966\" alt=\"screen shot 2018-05-09 at 3 04 49 pm\" src=\"https://user-images.githubusercontent.com/874361/39842192-699a97f0-539a-11e8-98e1-78b29c0fcc1b.png\">\r\n\r\n### Expected behavior\r\n\r\n<!-- What is the expected behavior? -->\r\n\r\nKarma test runner detects and runs stock Angular unit tests after installing `angularfire2@5.0.0-rc.7`.\r\n\r\n```shell\r\n% ng test\r\n 10% building modules 1/1 modules 0 active(node:11534) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead\r\n09 05 2018 15:19:20.618:INFO [karma]: Karma v1.7.1 server started at http://0.0.0.0:9876/\r\n09 05 2018 15:19:20.619:INFO [launcher]: Launching browser Chrome with unlimited concurrency\r\n09 05 2018 15:19:20.627:INFO [launcher]: Starting browser Chrome\r\n09 05 2018 15:19:27.630:INFO [Chrome 66.0.3359 (Mac OS X 10.12.6)]: Connected on socket wYUrolw6Rpe90NquAAAA with id 50594180\r\nChrome 66.0.3359 (Mac OS X 10.12.6): Executed 3 of 3 SUCCESS (0.195 secs / 0.17 secs)\r\n```\r\n\r\n### Actual behavior\r\n\r\n<!-- What is the actual behavior? -->\r\n\r\nKarma test runner seems to no longer detect stock Angular unit tests after installing `angularfire2@5.0.0-rc.7`.\r\n\r\n```shell\r\n% ng test\r\n 10% building modules 1/1 modules 0 active(node:10914) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead\r\n09 05 2018 15:03:55.728:INFO [karma]: Karma v1.7.1 server started at http://0.0.0.0:9876/\r\n09 05 2018 15:03:55.730:INFO [launcher]: Launching browser Chrome with unlimited concurrency\r\n09 05 2018 15:03:55.736:INFO [launcher]: Starting browser Chrome\r\n09 05 2018 15:04:01.932:INFO [Chrome 66.0.3359 (Mac OS X 10.12.6)]: Connected on socket utmTD_2mcCpKpxdsAAAA with id 16434490\r\nChrome 66.0.3359 (Mac OS X 10.12.6): Executed 0 of 0 ERROR (0.011 secs / 0 secs)\r\n```"},"comment":{"url":"https://api.github.com/repos/angular/angularfire2/issues/comments/388587785","html_url":"https://github.com/angular/angularfire2/issues/1608#issuecomment-388587785","issue_url":"https://api.github.com/repos/angular/angularfire2/issues/1608","id":388587785,"user":{"login":"jamesdaniels","id":44975,"avatar_url":"https://avatars3.githubusercontent.com/u/44975?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesdaniels","html_url":"https://github.com/jamesdaniels","followers_url":"https://api.github.com/users/jamesdaniels/followers","following_url":"https://api.github.com/users/jamesdaniels/following{/other_user}","gists_url":"https://api.github.com/users/jamesdaniels/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesdaniels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesdaniels/subscriptions","organizations_url":"https://api.github.com/users/jamesdaniels/orgs","repos_url":"https://api.github.com/users/jamesdaniels/repos","events_url":"https://api.github.com/users/jamesdaniels/events{/privacy}","received_events_url":"https://api.github.com/users/jamesdaniels/received_events","type":"User","site_admin":false},"created_at":"2018-05-12T22:28:52Z","updated_at":"2018-05-12T22:28:52Z","author_association":"MEMBER","body":"We didn't support Angular 6 until just now. Can you confirm if this is still an issue in `angularfire2@next` and open a new issue if so?"}}
{"actor":{"display_login":"jamesdaniels"}}