{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments/172678634","pull_request_review_id":101738060,"id":172678634,"diff_hunk":"@@ -167,9 +168,40 @@ class RippleAPI extends EventEmitter {\n     })\n   }\n \n+  /**\n+   * Returns objects owned by an account.\n+   * For an account's trust lines and balances,\n+   * see `getTrustlines` and `getBalances`.\n+   */\n+  async requestAll(\n+    command: 'account_objects',\n+    params: AccountObjectsRequest\n+  ): Promise<AccountObjectsResponse[]> {\n+    // TODO: Prevent access to non-validated ledger versions\n+    const results = await (<Function>this._requestAll)(command, params, {\n+      collect: 'account_objects'\n+    })\n+\n+    return results.reduce((result, singleResult) => {\n+      const invariants = ['account', 'ledger_hash',\n+        'ledger_index', 'ledger_current_index', 'validated']\n+\n+      invariants.forEach(field => {\n+        if (result[field] !== singleResult[field]) {\n+          throw new errors.UnexpectedError(\n+            `paginated response contains mismatched ${field}: ` +\n+            `${result[field]} !== ${singleResult[field]}`\n+          )\n+        }\n+      })\n+\n+      result.account_objects.push(singleResult.account_objects)","path":"src/api.ts","position":null,"original_position":39,"commit_id":"0079d8a8bb3032f39bcdbcb9751e67d30a471566","original_commit_id":"cc85a47d69f136eafc130555128e92e24191c285","user":{"login":"intelliot","id":81505,"avatar_url":"https://avatars3.githubusercontent.com/u/81505?v=4","gravatar_id":"","url":"https://api.github.com/users/intelliot","html_url":"https://github.com/intelliot","followers_url":"https://api.github.com/users/intelliot/followers","following_url":"https://api.github.com/users/intelliot/following{/other_user}","gists_url":"https://api.github.com/users/intelliot/gists{/gist_id}","starred_url":"https://api.github.com/users/intelliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelliot/subscriptions","organizations_url":"https://api.github.com/users/intelliot/orgs","repos_url":"https://api.github.com/users/intelliot/repos","events_url":"https://api.github.com/users/intelliot/events{/privacy}","received_events_url":"https://api.github.com/users/intelliot/received_events","type":"User","site_admin":false},"body":"In https://github.com/ripple/ripple-lib/pull/861/commits/0079d8a8bb3032f39bcdbcb9751e67d30a471566 I changed it to `concat` which may avoid any argument length limit.","created_at":"2018-03-06T22:13:53Z","updated_at":"2018-03-06T22:13:53Z","html_url":"https://github.com/ripple/ripple-lib/pull/861#discussion_r172678634","pull_request_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/861","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments/172678634"},"html":{"href":"https://github.com/ripple/ripple-lib/pull/861#discussion_r172678634"},"pull_request":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/861"}},"in_reply_to_id":172416596},"pull_request":{"url":"https://api.github.com/repos/ripple/ripple-lib/pulls/861","id":172610733,"html_url":"https://github.com/ripple/ripple-lib/pull/861","diff_url":"https://github.com/ripple/ripple-lib/pull/861.diff","patch_url":"https://github.com/ripple/ripple-lib/pull/861.patch","issue_url":"https://api.github.com/repos/ripple/ripple-lib/issues/861","number":861,"state":"open","locked":false,"title":"Add requestAll('account_objects', ...)","user":{"login":"intelliot","id":81505,"avatar_url":"https://avatars3.githubusercontent.com/u/81505?v=4","gravatar_id":"","url":"https://api.github.com/users/intelliot","html_url":"https://github.com/intelliot","followers_url":"https://api.github.com/users/intelliot/followers","following_url":"https://api.github.com/users/intelliot/following{/other_user}","gists_url":"https://api.github.com/users/intelliot/gists{/gist_id}","starred_url":"https://api.github.com/users/intelliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelliot/subscriptions","organizations_url":"https://api.github.com/users/intelliot/orgs","repos_url":"https://api.github.com/users/intelliot/repos","events_url":"https://api.github.com/users/intelliot/events{/privacy}","received_events_url":"https://api.github.com/users/intelliot/received_events","type":"User","site_admin":false},"body":"Use `requestAll` for rippled `account_objects` command. See https://ripple.com/build/rippled-apis/#account-objects","created_at":"2018-03-02T21:36:55Z","updated_at":"2018-03-06T22:13:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9c7860b8ab3f3fdc5dfe1a00526c7a805e3bf69","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dncohen","id":256216,"avatar_url":"https://avatars2.githubusercontent.com/u/256216?v=4","gravatar_id":"","url":"https://api.github.com/users/dncohen","html_url":"https://github.com/dncohen","followers_url":"https://api.github.com/users/dncohen/followers","following_url":"https://api.github.com/users/dncohen/following{/other_user}","gists_url":"https://api.github.com/users/dncohen/gists{/gist_id}","starred_url":"https://api.github.com/users/dncohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dncohen/subscriptions","organizations_url":"https://api.github.com/users/dncohen/orgs","repos_url":"https://api.github.com/users/dncohen/repos","events_url":"https://api.github.com/users/dncohen/events{/privacy}","received_events_url":"https://api.github.com/users/dncohen/received_events","type":"User","site_admin":false},{"login":"shekenahglory","id":4000880,"avatar_url":"https://avatars3.githubusercontent.com/u/4000880?v=4","gravatar_id":"","url":"https://api.github.com/users/shekenahglory","html_url":"https://github.com/shekenahglory","followers_url":"https://api.github.com/users/shekenahglory/followers","following_url":"https://api.github.com/users/shekenahglory/following{/other_user}","gists_url":"https://api.github.com/users/shekenahglory/gists{/gist_id}","starred_url":"https://api.github.com/users/shekenahglory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shekenahglory/subscriptions","organizations_url":"https://api.github.com/users/shekenahglory/orgs","repos_url":"https://api.github.com/users/shekenahglory/repos","events_url":"https://api.github.com/users/shekenahglory/events{/privacy}","received_events_url":"https://api.github.com/users/shekenahglory/received_events","type":"User","site_admin":false},{"login":"wilsonianb","id":5885521,"avatar_url":"https://avatars1.githubusercontent.com/u/5885521?v=4","gravatar_id":"","url":"https://api.github.com/users/wilsonianb","html_url":"https://github.com/wilsonianb","followers_url":"https://api.github.com/users/wilsonianb/followers","following_url":"https://api.github.com/users/wilsonianb/following{/other_user}","gists_url":"https://api.github.com/users/wilsonianb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonianb/subscriptions","organizations_url":"https://api.github.com/users/wilsonianb/orgs","repos_url":"https://api.github.com/users/wilsonianb/repos","events_url":"https://api.github.com/users/wilsonianb/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonianb/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/861/commits","review_comments_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/861/comments","review_comment_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/issues/861/comments","statuses_url":"https://api.github.com/repos/ripple/ripple-lib/statuses/0079d8a8bb3032f39bcdbcb9751e67d30a471566","head":{"label":"ripple:requestAll-account_objects","ref":"requestAll-account_objects","sha":"0079d8a8bb3032f39bcdbcb9751e67d30a471566","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":9681561,"name":"ripple-lib","full_name":"ripple/ripple-lib","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/ripple-lib","description":"A JavaScript API for interacting with Ripple in Node.js and the browser","fork":false,"url":"https://api.github.com/repos/ripple/ripple-lib","forks_url":"https://api.github.com/repos/ripple/ripple-lib/forks","keys_url":"https://api.github.com/repos/ripple/ripple-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/ripple-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/ripple-lib/teams","hooks_url":"https://api.github.com/repos/ripple/ripple-lib/hooks","issue_events_url":"https://api.github.com/repos/ripple/ripple-lib/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/ripple-lib/events","assignees_url":"https://api.github.com/repos/ripple/ripple-lib/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/ripple-lib/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/ripple-lib/tags","blobs_url":"https://api.github.com/repos/ripple/ripple-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/ripple-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/ripple-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/ripple-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/ripple-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/ripple-lib/languages","stargazers_url":"https://api.github.com/repos/ripple/ripple-lib/stargazers","contributors_url":"https://api.github.com/repos/ripple/ripple-lib/contributors","subscribers_url":"https://api.github.com/repos/ripple/ripple-lib/subscribers","subscription_url":"https://api.github.com/repos/ripple/ripple-lib/subscription","commits_url":"https://api.github.com/repos/ripple/ripple-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/ripple-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/ripple-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/ripple-lib/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/ripple-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/ripple-lib/merges","archive_url":"https://api.github.com/repos/ripple/ripple-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/ripple-lib/downloads","issues_url":"https://api.github.com/repos/ripple/ripple-lib/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/ripple-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/ripple-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/ripple-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/ripple-lib/labels{/name}","releases_url":"https://api.github.com/repos/ripple/ripple-lib/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/ripple-lib/deployments","created_at":"2013-04-25T21:17:19Z","updated_at":"2018-03-05T22:20:40Z","pushed_at":"2018-03-06T08:24:57Z","git_url":"git://github.com/ripple/ripple-lib.git","ssh_url":"git@github.com:ripple/ripple-lib.git","clone_url":"https://github.com/ripple/ripple-lib.git","svn_url":"https://github.com/ripple/ripple-lib","homepage":"","size":13956,"stargazers_count":643,"watchers_count":643,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":250,"open_issues":38,"watchers":643,"default_branch":"develop"}},"base":{"label":"ripple:add-ledger-command-3","ref":"add-ledger-command-3","sha":"7e3c62dc4954b42609050a024268b15fc1bca845","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":9681561,"name":"ripple-lib","full_name":"ripple/ripple-lib","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/ripple-lib","description":"A JavaScript API for interacting with Ripple in Node.js and the browser","fork":false,"url":"https://api.github.com/repos/ripple/ripple-lib","forks_url":"https://api.github.com/repos/ripple/ripple-lib/forks","keys_url":"https://api.github.com/repos/ripple/ripple-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/ripple-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/ripple-lib/teams","hooks_url":"https://api.github.com/repos/ripple/ripple-lib/hooks","issue_events_url":"https://api.github.com/repos/ripple/ripple-lib/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/ripple-lib/events","assignees_url":"https://api.github.com/repos/ripple/ripple-lib/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/ripple-lib/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/ripple-lib/tags","blobs_url":"https://api.github.com/repos/ripple/ripple-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/ripple-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/ripple-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/ripple-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/ripple-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/ripple-lib/languages","stargazers_url":"https://api.github.com/repos/ripple/ripple-lib/stargazers","contributors_url":"https://api.github.com/repos/ripple/ripple-lib/contributors","subscribers_url":"https://api.github.com/repos/ripple/ripple-lib/subscribers","subscription_url":"https://api.github.com/repos/ripple/ripple-lib/subscription","commits_url":"https://api.github.com/repos/ripple/ripple-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/ripple-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/ripple-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/ripple-lib/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/ripple-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/ripple-lib/merges","archive_url":"https://api.github.com/repos/ripple/ripple-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/ripple-lib/downloads","issues_url":"https://api.github.com/repos/ripple/ripple-lib/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/ripple-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/ripple-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/ripple-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/ripple-lib/labels{/name}","releases_url":"https://api.github.com/repos/ripple/ripple-lib/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/ripple-lib/deployments","created_at":"2013-04-25T21:17:19Z","updated_at":"2018-03-05T22:20:40Z","pushed_at":"2018-03-06T08:24:57Z","git_url":"git://github.com/ripple/ripple-lib.git","ssh_url":"git@github.com:ripple/ripple-lib.git","clone_url":"https://github.com/ripple/ripple-lib.git","svn_url":"https://github.com/ripple/ripple-lib","homepage":"","size":13956,"stargazers_count":643,"watchers_count":643,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":250,"open_issues":38,"watchers":643,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/861"},"html":{"href":"https://github.com/ripple/ripple-lib/pull/861"},"issue":{"href":"https://api.github.com/repos/ripple/ripple-lib/issues/861"},"comments":{"href":"https://api.github.com/repos/ripple/ripple-lib/issues/861/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/861/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/861/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/ripple-lib/statuses/0079d8a8bb3032f39bcdbcb9751e67d30a471566"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"intelliot"}}