{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/230424183","pull_request_review_id":171165780,"id":230424183,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDQyNDE4Mw==","diff_hunk":"@@ -130,12 +130,20 @@ object Helpers {\n    * INTERNAL API\n    */\n   private[akka] final implicit class ConfigOps(val config: Config) extends AnyVal {\n+\n+    import JavaDurationConverters._\n+\n     def getMillisDuration(path: String): FiniteDuration = getDuration(path, TimeUnit.MILLISECONDS)\n \n     def getNanosDuration(path: String): FiniteDuration = getDuration(path, TimeUnit.NANOSECONDS)\n \n     private def getDuration(path: String, unit: TimeUnit): FiniteDuration =\n       Duration(config.getDuration(path, unit), unit)\n+\n+    def getPotentiallyInfiniteDuration(path: String): Duration = config.getString(path) match {\n+      case \"infinite\" => Duration.Inf\n+      case _ => config.getDuration(path).asScala","path":"akka-actor/src/main/scala/akka/util/Helpers.scala","position":null,"original_position":16,"commit_id":"a41c77f1df63036e6cbe20da7cdf98f9c2525f33","original_commit_id":"3ac220e485d9bb1356754f163f335c943c13613e","user":{"login":"patriknw","id":336161,"node_id":"MDQ6VXNlcjMzNjE2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/336161?v=4","gravatar_id":"","url":"https://api.github.com/users/patriknw","html_url":"https://github.com/patriknw","followers_url":"https://api.github.com/users/patriknw/followers","following_url":"https://api.github.com/users/patriknw/following{/other_user}","gists_url":"https://api.github.com/users/patriknw/gists{/gist_id}","starred_url":"https://api.github.com/users/patriknw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriknw/subscriptions","organizations_url":"https://api.github.com/users/patriknw/orgs","repos_url":"https://api.github.com/users/patriknw/repos","events_url":"https://api.github.com/users/patriknw/events{/privacy}","received_events_url":"https://api.github.com/users/patriknw/received_events","type":"User","site_admin":false},"body":"why? we use `Undefined` in some places, e.g. https://github.com/akka/akka/blob/master/akka-cluster/src/main/scala/akka/cluster/ClusterSettings.scala#L89","created_at":"2018-11-02T15:56:36Z","updated_at":"2018-11-02T15:56:36Z","html_url":"https://github.com/akka/akka/pull/25845#discussion_r230424183","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/25845","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/230424183"},"html":{"href":"https://github.com/akka/akka/pull/25845#discussion_r230424183"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/25845"}},"in_reply_to_id":230324405},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/25845","id":227248631,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MjQ4NjMx","html_url":"https://github.com/akka/akka/pull/25845","diff_url":"https://github.com/akka/akka/pull/25845.diff","patch_url":"https://github.com/akka/akka/pull/25845.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/25845","number":25845,"state":"open","locked":false,"title":"Standardise support for reading infinite durations from Config","user":{"login":"ennru","id":458526,"node_id":"MDQ6VXNlcjQ1ODUyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/458526?v=4","gravatar_id":"","url":"https://api.github.com/users/ennru","html_url":"https://github.com/ennru","followers_url":"https://api.github.com/users/ennru/followers","following_url":"https://api.github.com/users/ennru/following{/other_user}","gists_url":"https://api.github.com/users/ennru/gists{/gist_id}","starred_url":"https://api.github.com/users/ennru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ennru/subscriptions","organizations_url":"https://api.github.com/users/ennru/orgs","repos_url":"https://api.github.com/users/ennru/repos","events_url":"https://api.github.com/users/ennru/events{/privacy}","received_events_url":"https://api.github.com/users/ennru/received_events","type":"User","site_admin":false},"body":"This bit from Alpakka Kafka might be relevant across Akka.","created_at":"2018-10-31T11:24:29Z","updated_at":"2018-11-02T15:56:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c03adc0a29c2909c3945db939d5748d8df4ba27f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":101450254,"node_id":"MDU6TGFiZWwxMDE0NTAyNTQ=","url":"https://api.github.com/repos/akka/akka/labels/validating","name":"validating","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/25845/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/25845/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/25845/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/a41c77f1df63036e6cbe20da7cdf98f9c2525f33","head":{"label":"ennru:ennru_read-infinite-duration-from-config","ref":"ennru_read-infinite-duration-from-config","sha":"a41c77f1df63036e6cbe20da7cdf98f9c2525f33","user":{"login":"ennru","id":458526,"node_id":"MDQ6VXNlcjQ1ODUyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/458526?v=4","gravatar_id":"","url":"https://api.github.com/users/ennru","html_url":"https://github.com/ennru","followers_url":"https://api.github.com/users/ennru/followers","following_url":"https://api.github.com/users/ennru/following{/other_user}","gists_url":"https://api.github.com/users/ennru/gists{/gist_id}","starred_url":"https://api.github.com/users/ennru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ennru/subscriptions","organizations_url":"https://api.github.com/users/ennru/orgs","repos_url":"https://api.github.com/users/ennru/repos","events_url":"https://api.github.com/users/ennru/events{/privacy}","received_events_url":"https://api.github.com/users/ennru/received_events","type":"User","site_admin":false},"repo":{"id":37187164,"node_id":"MDEwOlJlcG9zaXRvcnkzNzE4NzE2NA==","name":"akka","full_name":"ennru/akka","private":false,"owner":{"login":"ennru","id":458526,"node_id":"MDQ6VXNlcjQ1ODUyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/458526?v=4","gravatar_id":"","url":"https://api.github.com/users/ennru","html_url":"https://github.com/ennru","followers_url":"https://api.github.com/users/ennru/followers","following_url":"https://api.github.com/users/ennru/following{/other_user}","gists_url":"https://api.github.com/users/ennru/gists{/gist_id}","starred_url":"https://api.github.com/users/ennru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ennru/subscriptions","organizations_url":"https://api.github.com/users/ennru/orgs","repos_url":"https://api.github.com/users/ennru/repos","events_url":"https://api.github.com/users/ennru/events{/privacy}","received_events_url":"https://api.github.com/users/ennru/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ennru/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/ennru/akka","forks_url":"https://api.github.com/repos/ennru/akka/forks","keys_url":"https://api.github.com/repos/ennru/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ennru/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ennru/akka/teams","hooks_url":"https://api.github.com/repos/ennru/akka/hooks","issue_events_url":"https://api.github.com/repos/ennru/akka/issues/events{/number}","events_url":"https://api.github.com/repos/ennru/akka/events","assignees_url":"https://api.github.com/repos/ennru/akka/assignees{/user}","branches_url":"https://api.github.com/repos/ennru/akka/branches{/branch}","tags_url":"https://api.github.com/repos/ennru/akka/tags","blobs_url":"https://api.github.com/repos/ennru/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ennru/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ennru/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ennru/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ennru/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/ennru/akka/languages","stargazers_url":"https://api.github.com/repos/ennru/akka/stargazers","contributors_url":"https://api.github.com/repos/ennru/akka/contributors","subscribers_url":"https://api.github.com/repos/ennru/akka/subscribers","subscription_url":"https://api.github.com/repos/ennru/akka/subscription","commits_url":"https://api.github.com/repos/ennru/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ennru/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ennru/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ennru/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/ennru/akka/contents/{+path}","compare_url":"https://api.github.com/repos/ennru/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ennru/akka/merges","archive_url":"https://api.github.com/repos/ennru/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ennru/akka/downloads","issues_url":"https://api.github.com/repos/ennru/akka/issues{/number}","pulls_url":"https://api.github.com/repos/ennru/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/ennru/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/ennru/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ennru/akka/labels{/name}","releases_url":"https://api.github.com/repos/ennru/akka/releases{/id}","deployments_url":"https://api.github.com/repos/ennru/akka/deployments","created_at":"2015-06-10T09:14:47Z","updated_at":"2016-01-14T18:45:41Z","pushed_at":"2018-11-02T15:54:34Z","git_url":"git://github.com/ennru/akka.git","ssh_url":"git@github.com:ennru/akka.git","clone_url":"https://github.com/ennru/akka.git","svn_url":"https://github.com/ennru/akka","homepage":"http://akka.io","size":210291,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"6329a7b77ee99529c6b486029f14b3e3f01f00a0","user":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAwMTM=","name":"akka","full_name":"akka/akka","private":false,"owner":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/akka/akka","description":"Build highly concurrent, distributed, and resilient message-driven applications on the JVM","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2018-11-02T14:44:53Z","pushed_at":"2018-11-02T15:54:39Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":215131,"stargazers_count":9175,"watchers_count":9175,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2888,"mirror_url":null,"archived":false,"open_issues_count":816,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2888,"open_issues":816,"watchers":9175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/25845"},"html":{"href":"https://github.com/akka/akka/pull/25845"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/25845"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/25845/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/25845/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/25845/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/a41c77f1df63036e6cbe20da7cdf98f9c2525f33"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"patriknw"}}