{"action":"created","issue":{"url":"https://api.github.com/repos/bosnet/sebak/issues/167","repository_url":"https://api.github.com/repos/bosnet/sebak","labels_url":"https://api.github.com/repos/bosnet/sebak/issues/167/labels{/name}","comments_url":"https://api.github.com/repos/bosnet/sebak/issues/167/comments","events_url":"https://api.github.com/repos/bosnet/sebak/issues/167/events","html_url":"https://github.com/bosnet/sebak/pull/167","id":337400944,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTk0Njk2","number":167,"title":"remove not neccessary check","user":{"login":"kfangw","id":973304,"node_id":"MDQ6VXNlcjk3MzMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/973304?v=4","gravatar_id":"","url":"https://api.github.com/users/kfangw","html_url":"https://github.com/kfangw","followers_url":"https://api.github.com/users/kfangw/followers","following_url":"https://api.github.com/users/kfangw/following{/other_user}","gists_url":"https://api.github.com/users/kfangw/gists{/gist_id}","starred_url":"https://api.github.com/users/kfangw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfangw/subscriptions","organizations_url":"https://api.github.com/users/kfangw/orgs","repos_url":"https://api.github.com/users/kfangw/repos","events_url":"https://api.github.com/users/kfangw/events{/privacy}","received_events_url":"https://api.github.com/users/kfangw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-02T07:33:57Z","updated_at":"2018-07-02T11:48:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/167","html_url":"https://github.com/bosnet/sebak/pull/167","diff_url":"https://github.com/bosnet/sebak/pull/167.diff","patch_url":"https://github.com/bosnet/sebak/pull/167.patch"},"body":"### Requirements\r\n\r\nIt is not necessary to validate source/target of the transaction which indicated by the checkpoint.\r\n\r\nBy definition of `checkpoint`(#60), only thing needed to be validate is `<sub>` part.\r\nThat validation is done at https://github.com/bosnet/sebak/blob/167c97afe15193a58806f1462ece06ba17d016e4/lib/node_runner_checker.go#L301-L304\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bosnet/sebak/issues/comments/401778550","html_url":"https://github.com/bosnet/sebak/pull/167#issuecomment-401778550","issue_url":"https://api.github.com/repos/bosnet/sebak/issues/167","id":401778550,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTc3ODU1MA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T11:48:04Z","updated_at":"2018-07-02T11:48:04Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/bosnet/sebak/pull/167?src=pr&el=h1) Report\n> Merging [#167](https://codecov.io/gh/bosnet/sebak/pull/167?src=pr&el=desc) into [master](https://codecov.io/gh/bosnet/sebak/commit/167c97afe15193a58806f1462ece06ba17d016e4?src=pr&el=desc) will **increase** coverage by `0.57%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/bosnet/sebak/pull/167/graphs/tree.svg?src=pr&width=650&token=npRPkUTGpQ&height=150)](https://codecov.io/gh/bosnet/sebak/pull/167?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #167      +/-   ##\n==========================================\n+ Coverage   60.25%   60.82%   +0.57%     \n==========================================\n  Files          44       44              \n  Lines        3218     3196      -22     \n==========================================\n+ Hits         1939     1944       +5     \n+ Misses       1033     1016      -17     \n+ Partials      246      236      -10\n```\n\n\n| [Impacted Files](https://codecov.io/gh/bosnet/sebak/pull/167?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [go/src/boscoin.io/sebak/lib/block\\_transaction.go](https://codecov.io/gh/bosnet/sebak/pull/167/diff?src=pr&el=tree#diff-Z28vc3JjL2Jvc2NvaW4uaW8vc2ViYWsvbGliL2Jsb2NrX3RyYW5zYWN0aW9uLmdv) | `75.2% <0%> (-2.15%)` | :arrow_down: |\n| [go/src/boscoin.io/sebak/lib/network/init.go](https://codecov.io/gh/bosnet/sebak/pull/167/diff?src=pr&el=tree#diff-Z28vc3JjL2Jvc2NvaW4uaW8vc2ViYWsvbGliL25ldHdvcmsvaW5pdC5nbw==) | `100% <0%> (ø)` | :arrow_up: |\n| [go/src/boscoin.io/sebak/lib/ballot.go](https://codecov.io/gh/bosnet/sebak/pull/167/diff?src=pr&el=tree#diff-Z28vc3JjL2Jvc2NvaW4uaW8vc2ViYWsvbGliL2JhbGxvdC5nbw==) | `77.48% <0%> (+1.73%)` | :arrow_up: |\n| [...scoin.io/sebak/lib/network/http2\\_network\\_client.go](https://codecov.io/gh/bosnet/sebak/pull/167/diff?src=pr&el=tree#diff-Z28vc3JjL2Jvc2NvaW4uaW8vc2ViYWsvbGliL25ldHdvcmsvaHR0cDJfbmV0d29ya19jbGllbnQuZ28=) | `65.55% <0%> (+2.22%)` | :arrow_up: |\n| [go/src/boscoin.io/sebak/lib/api.go](https://codecov.io/gh/bosnet/sebak/pull/167/diff?src=pr&el=tree#diff-Z28vc3JjL2Jvc2NvaW4uaW8vc2ViYWsvbGliL2FwaS5nbw==) | `64.86% <0%> (+2.7%)` | :arrow_up: |\n| [go/src/boscoin.io/sebak/lib/voting.go](https://codecov.io/gh/bosnet/sebak/pull/167/diff?src=pr&el=tree#diff-Z28vc3JjL2Jvc2NvaW4uaW8vc2ViYWsvbGliL3ZvdGluZy5nbw==) | `68.69% <0%> (+3.47%)` | :arrow_up: |\n| [go/src/boscoin.io/sebak/lib/operation\\_payment.go](https://codecov.io/gh/bosnet/sebak/pull/167/diff?src=pr&el=tree#diff-Z28vc3JjL2Jvc2NvaW4uaW8vc2ViYWsvbGliL29wZXJhdGlvbl9wYXltZW50Lmdv) | `54.05% <0%> (+4.05%)` | :arrow_up: |\n| [go/src/boscoin.io/sebak/lib/node\\_runner\\_checker.go](https://codecov.io/gh/bosnet/sebak/pull/167/diff?src=pr&el=tree#diff-Z28vc3JjL2Jvc2NvaW4uaW8vc2ViYWsvbGliL25vZGVfcnVubmVyX2NoZWNrZXIuZ28=) | `78.65% <0%> (+4.78%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/bosnet/sebak/pull/167?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/bosnet/sebak/pull/167?src=pr&el=footer). Last update [167c97a...4d2df93](https://codecov.io/gh/bosnet/sebak/pull/167?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}