{"action":"created","comment":{"url":"https://api.github.com/repos/endpass/endpass-wallet/pulls/comments/225539452","pull_request_review_id":165155498,"id":225539452,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTUzOTQ1Mg==","diff_hunk":"@@ -127,11 +127,15 @@ const validateNetwork = (context, { network }) => {\n   return Promise.all([net.getNetworkType(), net.getId()]);\n };\n \n-const subscribeOnBlockUpdates = async ({ commit, dispatch }) => {\n+const subscribeOnBlockUpdates = async ({ commit, dispatch, getters }) => {\n   await dispatch('unsubscribeOnBlockUpdates');\n \n   const interval = setInterval(async () => {\n-    commit(mutationsTypes.SET_BLOCK_NUMBER, await web3.eth.getBlockNumber());\n+    const networkId = getters.activeNetwork;\n+    const blockNumber = await web3.eth.getBlockNumber();","path":"src/store/web3/actions.js","position":11,"original_position":11,"commit_id":"b5e5e61fbe46bb5fed6189f9ef1b2eb68b468d8c","original_commit_id":"b5e5e61fbe46bb5fed6189f9ef1b2eb68b468d8c","user":{"login":"lamartire","id":13414205,"node_id":"MDQ6VXNlcjEzNDE0MjA1","avatar_url":"https://avatars0.githubusercontent.com/u/13414205?v=4","gravatar_id":"","url":"https://api.github.com/users/lamartire","html_url":"https://github.com/lamartire","followers_url":"https://api.github.com/users/lamartire/followers","following_url":"https://api.github.com/users/lamartire/following{/other_user}","gists_url":"https://api.github.com/users/lamartire/gists{/gist_id}","starred_url":"https://api.github.com/users/lamartire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamartire/subscriptions","organizations_url":"https://api.github.com/users/lamartire/orgs","repos_url":"https://api.github.com/users/lamartire/repos","events_url":"https://api.github.com/users/lamartire/events{/privacy}","received_events_url":"https://api.github.com/users/lamartire/received_events","type":"User","site_admin":false},"body":"[Тут](https://github.com/endpass/endpass-wallet/pull/273/files#diff-e5a47be43977db8f4262bd04abd40b0fR12) ты делаешь деструктуризацию `web3` извлекая утилиты. Может вообще не делать ее и везде использовать просто web3?","created_at":"2018-10-16T13:30:35Z","updated_at":"2018-10-16T13:39:57Z","html_url":"https://github.com/endpass/endpass-wallet/pull/273#discussion_r225539452","pull_request_url":"https://api.github.com/repos/endpass/endpass-wallet/pulls/273","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/endpass/endpass-wallet/pulls/comments/225539452"},"html":{"href":"https://github.com/endpass/endpass-wallet/pull/273#discussion_r225539452"},"pull_request":{"href":"https://api.github.com/repos/endpass/endpass-wallet/pulls/273"}}},"pull_request":{"url":"https://api.github.com/repos/endpass/endpass-wallet/pulls/273","id":223209523,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjA5NTIz","html_url":"https://github.com/endpass/endpass-wallet/pull/273","diff_url":"https://github.com/endpass/endpass-wallet/pull/273.diff","patch_url":"https://github.com/endpass/endpass-wallet/pull/273.patch","issue_url":"https://api.github.com/repos/endpass/endpass-wallet/issues/273","number":273,"state":"open","locked":false,"title":"Add processing of the incoming transactions","user":{"login":"kazurus","id":32077191,"node_id":"MDQ6VXNlcjMyMDc3MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/32077191?v=4","gravatar_id":"","url":"https://api.github.com/users/kazurus","html_url":"https://github.com/kazurus","followers_url":"https://api.github.com/users/kazurus/followers","following_url":"https://api.github.com/users/kazurus/following{/other_user}","gists_url":"https://api.github.com/users/kazurus/gists{/gist_id}","starred_url":"https://api.github.com/users/kazurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazurus/subscriptions","organizations_url":"https://api.github.com/users/kazurus/orgs","repos_url":"https://api.github.com/users/kazurus/repos","events_url":"https://api.github.com/users/kazurus/events{/privacy}","received_events_url":"https://api.github.com/users/kazurus/received_events","type":"User","site_admin":false},"body":"Add processing of the incoming transactions:\n- show notification\n- add to the history","created_at":"2018-10-16T11:15:24Z","updated_at":"2018-10-16T13:39:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b411d04e7cd360ce0042dcc2b8ba3e38964dff16","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endpass/endpass-wallet/pulls/273/commits","review_comments_url":"https://api.github.com/repos/endpass/endpass-wallet/pulls/273/comments","review_comment_url":"https://api.github.com/repos/endpass/endpass-wallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endpass/endpass-wallet/issues/273/comments","statuses_url":"https://api.github.com/repos/endpass/endpass-wallet/statuses/b5e5e61fbe46bb5fed6189f9ef1b2eb68b468d8c","head":{"label":"kazurus:improve/pending-transactions","ref":"improve/pending-transactions","sha":"b5e5e61fbe46bb5fed6189f9ef1b2eb68b468d8c","user":{"login":"kazurus","id":32077191,"node_id":"MDQ6VXNlcjMyMDc3MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/32077191?v=4","gravatar_id":"","url":"https://api.github.com/users/kazurus","html_url":"https://github.com/kazurus","followers_url":"https://api.github.com/users/kazurus/followers","following_url":"https://api.github.com/users/kazurus/following{/other_user}","gists_url":"https://api.github.com/users/kazurus/gists{/gist_id}","starred_url":"https://api.github.com/users/kazurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazurus/subscriptions","organizations_url":"https://api.github.com/users/kazurus/orgs","repos_url":"https://api.github.com/users/kazurus/repos","events_url":"https://api.github.com/users/kazurus/events{/privacy}","received_events_url":"https://api.github.com/users/kazurus/received_events","type":"User","site_admin":false},"repo":{"id":134812101,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ4MTIxMDE=","name":"endpass-wallet","full_name":"kazurus/endpass-wallet","private":false,"owner":{"login":"kazurus","id":32077191,"node_id":"MDQ6VXNlcjMyMDc3MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/32077191?v=4","gravatar_id":"","url":"https://api.github.com/users/kazurus","html_url":"https://github.com/kazurus","followers_url":"https://api.github.com/users/kazurus/followers","following_url":"https://api.github.com/users/kazurus/following{/other_user}","gists_url":"https://api.github.com/users/kazurus/gists{/gist_id}","starred_url":"https://api.github.com/users/kazurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazurus/subscriptions","organizations_url":"https://api.github.com/users/kazurus/orgs","repos_url":"https://api.github.com/users/kazurus/repos","events_url":"https://api.github.com/users/kazurus/events{/privacy}","received_events_url":"https://api.github.com/users/kazurus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kazurus/endpass-wallet","description":"Lightweight, easy to use Ethereum wallet","fork":true,"url":"https://api.github.com/repos/kazurus/endpass-wallet","forks_url":"https://api.github.com/repos/kazurus/endpass-wallet/forks","keys_url":"https://api.github.com/repos/kazurus/endpass-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kazurus/endpass-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kazurus/endpass-wallet/teams","hooks_url":"https://api.github.com/repos/kazurus/endpass-wallet/hooks","issue_events_url":"https://api.github.com/repos/kazurus/endpass-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/kazurus/endpass-wallet/events","assignees_url":"https://api.github.com/repos/kazurus/endpass-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/kazurus/endpass-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/kazurus/endpass-wallet/tags","blobs_url":"https://api.github.com/repos/kazurus/endpass-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kazurus/endpass-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kazurus/endpass-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/kazurus/endpass-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kazurus/endpass-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/kazurus/endpass-wallet/languages","stargazers_url":"https://api.github.com/repos/kazurus/endpass-wallet/stargazers","contributors_url":"https://api.github.com/repos/kazurus/endpass-wallet/contributors","subscribers_url":"https://api.github.com/repos/kazurus/endpass-wallet/subscribers","subscription_url":"https://api.github.com/repos/kazurus/endpass-wallet/subscription","commits_url":"https://api.github.com/repos/kazurus/endpass-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/kazurus/endpass-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/kazurus/endpass-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/kazurus/endpass-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/kazurus/endpass-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/kazurus/endpass-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kazurus/endpass-wallet/merges","archive_url":"https://api.github.com/repos/kazurus/endpass-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kazurus/endpass-wallet/downloads","issues_url":"https://api.github.com/repos/kazurus/endpass-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/kazurus/endpass-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/kazurus/endpass-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/kazurus/endpass-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kazurus/endpass-wallet/labels{/name}","releases_url":"https://api.github.com/repos/kazurus/endpass-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/kazurus/endpass-wallet/deployments","created_at":"2018-05-25T06:18:48Z","updated_at":"2018-10-16T09:53:28Z","pushed_at":"2018-10-16T11:14:26Z","git_url":"git://github.com/kazurus/endpass-wallet.git","ssh_url":"git@github.com:kazurus/endpass-wallet.git","clone_url":"https://github.com/kazurus/endpass-wallet.git","svn_url":"https://github.com/kazurus/endpass-wallet","homepage":null,"size":7171,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"endpass:master","ref":"master","sha":"73293c14393ddbf875eb647389f61774f610bddf","user":{"login":"endpass","id":35308615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzA4NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/35308615?v=4","gravatar_id":"","url":"https://api.github.com/users/endpass","html_url":"https://github.com/endpass","followers_url":"https://api.github.com/users/endpass/followers","following_url":"https://api.github.com/users/endpass/following{/other_user}","gists_url":"https://api.github.com/users/endpass/gists{/gist_id}","starred_url":"https://api.github.com/users/endpass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endpass/subscriptions","organizations_url":"https://api.github.com/users/endpass/orgs","repos_url":"https://api.github.com/users/endpass/repos","events_url":"https://api.github.com/users/endpass/events{/privacy}","received_events_url":"https://api.github.com/users/endpass/received_events","type":"Organization","site_admin":false},"repo":{"id":128846976,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4NDY5NzY=","name":"endpass-wallet","full_name":"endpass/endpass-wallet","private":false,"owner":{"login":"endpass","id":35308615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzA4NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/35308615?v=4","gravatar_id":"","url":"https://api.github.com/users/endpass","html_url":"https://github.com/endpass","followers_url":"https://api.github.com/users/endpass/followers","following_url":"https://api.github.com/users/endpass/following{/other_user}","gists_url":"https://api.github.com/users/endpass/gists{/gist_id}","starred_url":"https://api.github.com/users/endpass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endpass/subscriptions","organizations_url":"https://api.github.com/users/endpass/orgs","repos_url":"https://api.github.com/users/endpass/repos","events_url":"https://api.github.com/users/endpass/events{/privacy}","received_events_url":"https://api.github.com/users/endpass/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/endpass/endpass-wallet","description":"Lightweight, easy to use Ethereum wallet","fork":false,"url":"https://api.github.com/repos/endpass/endpass-wallet","forks_url":"https://api.github.com/repos/endpass/endpass-wallet/forks","keys_url":"https://api.github.com/repos/endpass/endpass-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endpass/endpass-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endpass/endpass-wallet/teams","hooks_url":"https://api.github.com/repos/endpass/endpass-wallet/hooks","issue_events_url":"https://api.github.com/repos/endpass/endpass-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/endpass/endpass-wallet/events","assignees_url":"https://api.github.com/repos/endpass/endpass-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/endpass/endpass-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/endpass/endpass-wallet/tags","blobs_url":"https://api.github.com/repos/endpass/endpass-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endpass/endpass-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endpass/endpass-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/endpass/endpass-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endpass/endpass-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/endpass/endpass-wallet/languages","stargazers_url":"https://api.github.com/repos/endpass/endpass-wallet/stargazers","contributors_url":"https://api.github.com/repos/endpass/endpass-wallet/contributors","subscribers_url":"https://api.github.com/repos/endpass/endpass-wallet/subscribers","subscription_url":"https://api.github.com/repos/endpass/endpass-wallet/subscription","commits_url":"https://api.github.com/repos/endpass/endpass-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/endpass/endpass-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/endpass/endpass-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/endpass/endpass-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/endpass/endpass-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/endpass/endpass-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endpass/endpass-wallet/merges","archive_url":"https://api.github.com/repos/endpass/endpass-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endpass/endpass-wallet/downloads","issues_url":"https://api.github.com/repos/endpass/endpass-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/endpass/endpass-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/endpass/endpass-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/endpass/endpass-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endpass/endpass-wallet/labels{/name}","releases_url":"https://api.github.com/repos/endpass/endpass-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/endpass/endpass-wallet/deployments","created_at":"2018-04-09T23:50:15Z","updated_at":"2018-10-16T13:36:47Z","pushed_at":"2018-10-16T13:36:44Z","git_url":"git://github.com/endpass/endpass-wallet.git","ssh_url":"git@github.com:endpass/endpass-wallet.git","clone_url":"https://github.com/endpass/endpass-wallet.git","svn_url":"https://github.com/endpass/endpass-wallet","homepage":"https://wallet.endpass.com","size":7188,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endpass/endpass-wallet/pulls/273"},"html":{"href":"https://github.com/endpass/endpass-wallet/pull/273"},"issue":{"href":"https://api.github.com/repos/endpass/endpass-wallet/issues/273"},"comments":{"href":"https://api.github.com/repos/endpass/endpass-wallet/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/endpass/endpass-wallet/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/endpass/endpass-wallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endpass/endpass-wallet/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/endpass/endpass-wallet/statuses/b5e5e61fbe46bb5fed6189f9ef1b2eb68b468d8c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lamartire"}}