{"action":"created","comment":{"url":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls/comments/177474845","pull_request_review_id":107351467,"id":177474845,"diff_hunk":"@@ -10,7 +11,32 @@ export default function loadAddDeck(context, payload, done) {\n       && (store.userid !== undefined && store.userid !== null && store.userid !== '')\n       && (store.jwt !== undefined && store.jwt !== null && store.jwt !== ''))) {\n         context.executeAction(navigateAction, {url: '/'});//, reqId: payload.navigate.reqId});\n-        $('.ui.login.modal').modal('show');\n+        //prepraring the modal\n+        context.executeAction(updateTrap,{activeTrap:true});\n+        //hidden the other page elements to readers\n+        $('#app').attr('aria-hidden','true');\n+\n+        $('.ui.login.modal')\n+        .modal({\n+            onVisible: () => {","path":"actions/loadAddDeck.js","position":21,"original_position":21,"commit_id":"ff55eba7845edb6941203d85b35fbf393e4ebed9","original_commit_id":"ff55eba7845edb6941203d85b35fbf393e4ebed9","user":{"login":"Sole-Valero","id":12048866,"avatar_url":"https://avatars1.githubusercontent.com/u/12048866?v=4","gravatar_id":"","url":"https://api.github.com/users/Sole-Valero","html_url":"https://github.com/Sole-Valero","followers_url":"https://api.github.com/users/Sole-Valero/followers","following_url":"https://api.github.com/users/Sole-Valero/following{/other_user}","gists_url":"https://api.github.com/users/Sole-Valero/gists{/gist_id}","starred_url":"https://api.github.com/users/Sole-Valero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sole-Valero/subscriptions","organizations_url":"https://api.github.com/users/Sole-Valero/orgs","repos_url":"https://api.github.com/users/Sole-Valero/repos","events_url":"https://api.github.com/users/Sole-Valero/events{/privacy}","received_events_url":"https://api.github.com/users/Sole-Valero/received_events","type":"User","site_admin":false},"body":"I think this hould be checked for the original programmer who choose use toggle instead...I have tried to undertand all the code, and I think than toggle was use to hide in all cases...but original programmers should check it.\r\n","created_at":"2018-03-27T15:46:09Z","updated_at":"2018-03-27T15:46:09Z","html_url":"https://github.com/slidewiki/slidewiki-platform/pull/814#discussion_r177474845","pull_request_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls/814","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls/comments/177474845"},"html":{"href":"https://github.com/slidewiki/slidewiki-platform/pull/814#discussion_r177474845"},"pull_request":{"href":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls/814"}},"in_reply_to_id":177455723},"pull_request":{"url":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls/814","id":177455754,"html_url":"https://github.com/slidewiki/slidewiki-platform/pull/814","diff_url":"https://github.com/slidewiki/slidewiki-platform/pull/814.diff","patch_url":"https://github.com/slidewiki/slidewiki-platform/pull/814.patch","issue_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/issues/814","number":814,"state":"open","locked":false,"title":"Swik 2065 fix sign in modal","user":{"login":"Sole-Valero","id":12048866,"avatar_url":"https://avatars1.githubusercontent.com/u/12048866?v=4","gravatar_id":"","url":"https://api.github.com/users/Sole-Valero","html_url":"https://github.com/Sole-Valero","followers_url":"https://api.github.com/users/Sole-Valero/followers","following_url":"https://api.github.com/users/Sole-Valero/following{/other_user}","gists_url":"https://api.github.com/users/Sole-Valero/gists{/gist_id}","starred_url":"https://api.github.com/users/Sole-Valero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sole-Valero/subscriptions","organizations_url":"https://api.github.com/users/Sole-Valero/orgs","repos_url":"https://api.github.com/users/Sole-Valero/repos","events_url":"https://api.github.com/users/Sole-Valero/events{/privacy}","received_events_url":"https://api.github.com/users/Sole-Valero/received_events","type":"User","site_admin":false},"body":"Missing aria-labels has been added to the sigin modal. Also, the modal content is surronded by the react trap component. In order to manage the trap, the modal has been connected to an store, and a new action to activate the trap is called when the modal is open. Also, the same action is called when the onHidden method occurs, deactivating the trap. \r\nThe main functionality has not been modified, so the modal should performs as before.\r\nIt is available from my  server: svalero.dsic.upv.es:3000\r\n","created_at":"2018-03-26T14:00:40Z","updated_at":"2018-03-27T15:46:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87df8c49626b7d8795bdbe095354bdb2154ebc21","assignee":{"login":"abijames","id":2734520,"avatar_url":"https://avatars0.githubusercontent.com/u/2734520?v=4","gravatar_id":"","url":"https://api.github.com/users/abijames","html_url":"https://github.com/abijames","followers_url":"https://api.github.com/users/abijames/followers","following_url":"https://api.github.com/users/abijames/following{/other_user}","gists_url":"https://api.github.com/users/abijames/gists{/gist_id}","starred_url":"https://api.github.com/users/abijames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abijames/subscriptions","organizations_url":"https://api.github.com/users/abijames/orgs","repos_url":"https://api.github.com/users/abijames/repos","events_url":"https://api.github.com/users/abijames/events{/privacy}","received_events_url":"https://api.github.com/users/abijames/received_events","type":"User","site_admin":false},"assignees":[{"login":"abijames","id":2734520,"avatar_url":"https://avatars0.githubusercontent.com/u/2734520?v=4","gravatar_id":"","url":"https://api.github.com/users/abijames","html_url":"https://github.com/abijames","followers_url":"https://api.github.com/users/abijames/followers","following_url":"https://api.github.com/users/abijames/following{/other_user}","gists_url":"https://api.github.com/users/abijames/gists{/gist_id}","starred_url":"https://api.github.com/users/abijames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abijames/subscriptions","organizations_url":"https://api.github.com/users/abijames/orgs","repos_url":"https://api.github.com/users/abijames/repos","events_url":"https://api.github.com/users/abijames/events{/privacy}","received_events_url":"https://api.github.com/users/abijames/received_events","type":"User","site_admin":false},{"login":"kadevgraaf","id":16732304,"avatar_url":"https://avatars0.githubusercontent.com/u/16732304?v=4","gravatar_id":"","url":"https://api.github.com/users/kadevgraaf","html_url":"https://github.com/kadevgraaf","followers_url":"https://api.github.com/users/kadevgraaf/followers","following_url":"https://api.github.com/users/kadevgraaf/following{/other_user}","gists_url":"https://api.github.com/users/kadevgraaf/gists{/gist_id}","starred_url":"https://api.github.com/users/kadevgraaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadevgraaf/subscriptions","organizations_url":"https://api.github.com/users/kadevgraaf/orgs","repos_url":"https://api.github.com/users/kadevgraaf/repos","events_url":"https://api.github.com/users/kadevgraaf/events{/privacy}","received_events_url":"https://api.github.com/users/kadevgraaf/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls/814/commits","review_comments_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls/814/comments","review_comment_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/issues/814/comments","statuses_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/statuses/ff55eba7845edb6941203d85b35fbf393e4ebed9","head":{"label":"slidewiki:SWIK-2065-fixSignInModal","ref":"SWIK-2065-fixSignInModal","sha":"ff55eba7845edb6941203d85b35fbf393e4ebed9","user":{"login":"slidewiki","id":16650126,"avatar_url":"https://avatars3.githubusercontent.com/u/16650126?v=4","gravatar_id":"","url":"https://api.github.com/users/slidewiki","html_url":"https://github.com/slidewiki","followers_url":"https://api.github.com/users/slidewiki/followers","following_url":"https://api.github.com/users/slidewiki/following{/other_user}","gists_url":"https://api.github.com/users/slidewiki/gists{/gist_id}","starred_url":"https://api.github.com/users/slidewiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slidewiki/subscriptions","organizations_url":"https://api.github.com/users/slidewiki/orgs","repos_url":"https://api.github.com/users/slidewiki/repos","events_url":"https://api.github.com/users/slidewiki/events{/privacy}","received_events_url":"https://api.github.com/users/slidewiki/received_events","type":"Organization","site_admin":false},"repo":{"id":50826566,"name":"slidewiki-platform","full_name":"slidewiki/slidewiki-platform","owner":{"login":"slidewiki","id":16650126,"avatar_url":"https://avatars3.githubusercontent.com/u/16650126?v=4","gravatar_id":"","url":"https://api.github.com/users/slidewiki","html_url":"https://github.com/slidewiki","followers_url":"https://api.github.com/users/slidewiki/followers","following_url":"https://api.github.com/users/slidewiki/following{/other_user}","gists_url":"https://api.github.com/users/slidewiki/gists{/gist_id}","starred_url":"https://api.github.com/users/slidewiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slidewiki/subscriptions","organizations_url":"https://api.github.com/users/slidewiki/orgs","repos_url":"https://api.github.com/users/slidewiki/repos","events_url":"https://api.github.com/users/slidewiki/events{/privacy}","received_events_url":"https://api.github.com/users/slidewiki/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slidewiki/slidewiki-platform","description":"SlideWiki Platform","fork":false,"url":"https://api.github.com/repos/slidewiki/slidewiki-platform","forks_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/forks","keys_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/teams","hooks_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/hooks","issue_events_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/issues/events{/number}","events_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/events","assignees_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/assignees{/user}","branches_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/branches{/branch}","tags_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/tags","blobs_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/languages","stargazers_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/stargazers","contributors_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/contributors","subscribers_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/subscribers","subscription_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/subscription","commits_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/contents/{+path}","compare_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/merges","archive_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/downloads","issues_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/issues{/number}","pulls_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/labels{/name}","releases_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/releases{/id}","deployments_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/deployments","created_at":"2016-02-01T08:48:35Z","updated_at":"2018-03-26T12:49:22Z","pushed_at":"2018-03-27T15:33:21Z","git_url":"git://github.com/slidewiki/slidewiki-platform.git","ssh_url":"git@github.com:slidewiki/slidewiki-platform.git","clone_url":"https://github.com/slidewiki/slidewiki-platform.git","svn_url":"https://github.com/slidewiki/slidewiki-platform","homepage":null,"size":18977,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":8,"open_issues":18,"watchers":31,"default_branch":"master"}},"base":{"label":"slidewiki:master","ref":"master","sha":"7a9adc162f7728bde5596e03a50f36deb13f08ea","user":{"login":"slidewiki","id":16650126,"avatar_url":"https://avatars3.githubusercontent.com/u/16650126?v=4","gravatar_id":"","url":"https://api.github.com/users/slidewiki","html_url":"https://github.com/slidewiki","followers_url":"https://api.github.com/users/slidewiki/followers","following_url":"https://api.github.com/users/slidewiki/following{/other_user}","gists_url":"https://api.github.com/users/slidewiki/gists{/gist_id}","starred_url":"https://api.github.com/users/slidewiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slidewiki/subscriptions","organizations_url":"https://api.github.com/users/slidewiki/orgs","repos_url":"https://api.github.com/users/slidewiki/repos","events_url":"https://api.github.com/users/slidewiki/events{/privacy}","received_events_url":"https://api.github.com/users/slidewiki/received_events","type":"Organization","site_admin":false},"repo":{"id":50826566,"name":"slidewiki-platform","full_name":"slidewiki/slidewiki-platform","owner":{"login":"slidewiki","id":16650126,"avatar_url":"https://avatars3.githubusercontent.com/u/16650126?v=4","gravatar_id":"","url":"https://api.github.com/users/slidewiki","html_url":"https://github.com/slidewiki","followers_url":"https://api.github.com/users/slidewiki/followers","following_url":"https://api.github.com/users/slidewiki/following{/other_user}","gists_url":"https://api.github.com/users/slidewiki/gists{/gist_id}","starred_url":"https://api.github.com/users/slidewiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slidewiki/subscriptions","organizations_url":"https://api.github.com/users/slidewiki/orgs","repos_url":"https://api.github.com/users/slidewiki/repos","events_url":"https://api.github.com/users/slidewiki/events{/privacy}","received_events_url":"https://api.github.com/users/slidewiki/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slidewiki/slidewiki-platform","description":"SlideWiki Platform","fork":false,"url":"https://api.github.com/repos/slidewiki/slidewiki-platform","forks_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/forks","keys_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/teams","hooks_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/hooks","issue_events_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/issues/events{/number}","events_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/events","assignees_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/assignees{/user}","branches_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/branches{/branch}","tags_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/tags","blobs_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/languages","stargazers_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/stargazers","contributors_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/contributors","subscribers_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/subscribers","subscription_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/subscription","commits_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/contents/{+path}","compare_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/merges","archive_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/downloads","issues_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/issues{/number}","pulls_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/labels{/name}","releases_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/releases{/id}","deployments_url":"https://api.github.com/repos/slidewiki/slidewiki-platform/deployments","created_at":"2016-02-01T08:48:35Z","updated_at":"2018-03-26T12:49:22Z","pushed_at":"2018-03-27T15:33:21Z","git_url":"git://github.com/slidewiki/slidewiki-platform.git","ssh_url":"git@github.com:slidewiki/slidewiki-platform.git","clone_url":"https://github.com/slidewiki/slidewiki-platform.git","svn_url":"https://github.com/slidewiki/slidewiki-platform","homepage":null,"size":18977,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":8,"open_issues":18,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls/814"},"html":{"href":"https://github.com/slidewiki/slidewiki-platform/pull/814"},"issue":{"href":"https://api.github.com/repos/slidewiki/slidewiki-platform/issues/814"},"comments":{"href":"https://api.github.com/repos/slidewiki/slidewiki-platform/issues/814/comments"},"review_comments":{"href":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls/814/comments"},"review_comment":{"href":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slidewiki/slidewiki-platform/pulls/814/commits"},"statuses":{"href":"https://api.github.com/repos/slidewiki/slidewiki-platform/statuses/ff55eba7845edb6941203d85b35fbf393e4ebed9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Sole-Valero"}}