{"action":"created","issue":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2187","repository_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2187/labels{/name}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2187/comments","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2187/events","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2187","id":320347656,"number":2187,"title":"Fix ArgumentSanitizer for stream def","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars2.githubusercontent.com/u/151690?v=4","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"labels":[{"id":286486351,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/labels/in%20pr","name":"in pr","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-04T16:53:06Z","updated_at":"2018-05-04T16:57:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/2187","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2187","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2187.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2187.patch"},"body":" - Shouldn't persist sanitized version of stream definition when updating the properties during skipper update\r\n   - Remove test method that checks for sanitized stream definition from database\r\n - Fix regex to handle dots and dashes in the stream definition string\r\n - Add test\r\n\r\nResolves #2185"},"comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/comments/386663329","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2187#issuecomment-386663329","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2187","id":386663329,"user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars2.githubusercontent.com/u/151690?v=4","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T16:57:56Z","updated_at":"2018-05-04T16:57:56Z","author_association":"CONTRIBUTOR","body":"There are couple of issues addressed in this PR:\r\n\r\n1) We were persisting the sanitized version of stream definition into DB \r\n\r\n2) The `regex` in Stream definition sanitizer did not handle the dot/dash characters that could possibly part of the properties `key` (property key for ex: `twitter.credentials.access-token`) as well as they property `value` (for example password with `-` in it). The `dots` in the properties can mostly be introduced when we update the stream dsl via skipper manifest."}}
{"actor":{"display_login":"ilayaperumalg"}}