{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/38263","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/38263/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/38263/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/38263/events","html_url":"https://github.com/NixOS/nixpkgs/pull/38263","id":310277142,"number":38263,"title":"grub: support initrd secrets","user":{"login":"lopsided98","id":5624721,"avatar_url":"https://avatars3.githubusercontent.com/u/5624721?v=4","gravatar_id":"","url":"https://api.github.com/users/lopsided98","html_url":"https://github.com/lopsided98","followers_url":"https://api.github.com/users/lopsided98/followers","following_url":"https://api.github.com/users/lopsided98/following{/other_user}","gists_url":"https://api.github.com/users/lopsided98/gists{/gist_id}","starred_url":"https://api.github.com/users/lopsided98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lopsided98/subscriptions","organizations_url":"https://api.github.com/users/lopsided98/orgs","repos_url":"https://api.github.com/users/lopsided98/repos","events_url":"https://api.github.com/users/lopsided98/events{/privacy}","received_events_url":"https://api.github.com/users/lopsided98/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-31T22:33:59Z","updated_at":"2018-04-07T03:52:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/38263","html_url":"https://github.com/NixOS/nixpkgs/pull/38263","diff_url":"https://github.com/NixOS/nixpkgs/pull/38263.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/38263.patch"},"body":"###### Motivation for this change\r\n\r\nThis PR fixes #26175 by adding support for `boot.initrd.secrets` to grub. \r\n\r\n###### Things done\r\n\r\nThe Grub specific option `boot.loader.grub.extraInitrd` (#22969) is removed in favor of the generic `boot.initrd.secrets` option. My implementation is similar to how `extraInitrd` was implemented, except it runs `append-initrd-secrets` instead of using a user supplied initrd. I use a separate second initrd, rather than appending to the main initrd (as is done for systemd-boot), because grub allows the option of not copying the initrd from the nix store, so it may be immutable.\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/379429883","html_url":"https://github.com/NixOS/nixpkgs/pull/38263#issuecomment-379429883","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/38263","id":379429883,"user":{"login":"lopsided98","id":5624721,"avatar_url":"https://avatars3.githubusercontent.com/u/5624721?v=4","gravatar_id":"","url":"https://api.github.com/users/lopsided98","html_url":"https://github.com/lopsided98","followers_url":"https://api.github.com/users/lopsided98/followers","following_url":"https://api.github.com/users/lopsided98/following{/other_user}","gists_url":"https://api.github.com/users/lopsided98/gists{/gist_id}","starred_url":"https://api.github.com/users/lopsided98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lopsided98/subscriptions","organizations_url":"https://api.github.com/users/lopsided98/orgs","repos_url":"https://api.github.com/users/lopsided98/repos","events_url":"https://api.github.com/users/lopsided98/events{/privacy}","received_events_url":"https://api.github.com/users/lopsided98/received_events","type":"User","site_admin":false},"created_at":"2018-04-07T03:52:47Z","updated_at":"2018-04-07T03:52:47Z","author_association":"CONTRIBUTOR","body":"There doesn't seem to be a single maintainer for grub so I'll just cc @joachifm. Let me know if someone else would be better to review this."}}
{"actor":{"display_login":"lopsided98"}}