{"action":"created","issue":{"url":"https://api.github.com/repos/google/xsecurelock/issues/32","repository_url":"https://api.github.com/repos/google/xsecurelock","labels_url":"https://api.github.com/repos/google/xsecurelock/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/google/xsecurelock/issues/32/comments","events_url":"https://api.github.com/repos/google/xsecurelock/issues/32/events","html_url":"https://github.com/google/xsecurelock/pull/32","id":330278808,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMzI2NDIz","number":32,"title":"saver_child should not inherit xss-lock's sleep lock","user":{"login":"piec","id":781471,"node_id":"MDQ6VXNlcjc4MTQ3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/781471?v=4","gravatar_id":"","url":"https://api.github.com/users/piec","html_url":"https://github.com/piec","followers_url":"https://api.github.com/users/piec/followers","following_url":"https://api.github.com/users/piec/following{/other_user}","gists_url":"https://api.github.com/users/piec/gists{/gist_id}","starred_url":"https://api.github.com/users/piec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piec/subscriptions","organizations_url":"https://api.github.com/users/piec/orgs","repos_url":"https://api.github.com/users/piec/repos","events_url":"https://api.github.com/users/piec/events{/privacy}","received_events_url":"https://api.github.com/users/piec/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-07T13:43:58Z","updated_at":"2018-06-14T21:04:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/google/xsecurelock/pulls/32","html_url":"https://github.com/google/xsecurelock/pull/32","diff_url":"https://github.com/google/xsecurelock/pull/32.diff","patch_url":"https://github.com/google/xsecurelock/pull/32.patch"},"body":"Hi,\r\n\r\nThanks for making xsecurelock it's great :+1: \r\n\r\nI noticed that I was hitting systemd's inhibitor timeout when using it with xss-lock's sleep lock transfer.\r\nActually the lock is inherited by the xsecurelock'saver process when forking.\r\nThis patch closes the lock in the child process after forking so that the lock is released correctly.\r\n\r\nThis patch is a quick fix, tell me if you want me to change things\r\n\r\nCheers,\r\nPierre\r\n\r\n---\r\nMore info:\r\n* What you see in the logs if the lock is not released:\r\n```\r\nsystemd-logind[14711]: Delay lock is active (UID 1000, PID 5243/n/a) but inhibitor timeout is reached.\r\n```\r\n* The systemd-logind timeout value is set with [`InhibitDelayMaxSec`](https://www.freedesktop.org/software/systemd/man/logind.conf.html#InhibitDelayMaxSec=) (default value 5s)\r\n* By default systemd ignores the inhibitors when suspending because of the lid. [`LidSwitchIgnoreInhibited` default value](https://www.freedesktop.org/software/systemd/man/logind.conf.html#PowerKeyIgnoreInhibited=) is yes "},"comment":{"url":"https://api.github.com/repos/google/xsecurelock/issues/comments/397437771","html_url":"https://github.com/google/xsecurelock/pull/32#issuecomment-397437771","issue_url":"https://api.github.com/repos/google/xsecurelock/issues/32","id":397437771,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzQzNzc3MQ==","user":{"login":"divVerent","id":251568,"node_id":"MDQ6VXNlcjI1MTU2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/251568?v=4","gravatar_id":"","url":"https://api.github.com/users/divVerent","html_url":"https://github.com/divVerent","followers_url":"https://api.github.com/users/divVerent/followers","following_url":"https://api.github.com/users/divVerent/following{/other_user}","gists_url":"https://api.github.com/users/divVerent/gists{/gist_id}","starred_url":"https://api.github.com/users/divVerent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divVerent/subscriptions","organizations_url":"https://api.github.com/users/divVerent/orgs","repos_url":"https://api.github.com/users/divVerent/repos","events_url":"https://api.github.com/users/divVerent/events{/privacy}","received_events_url":"https://api.github.com/users/divVerent/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T21:04:13Z","updated_at":"2018-06-14T21:04:13Z","author_association":"CONTRIBUTOR","body":"Great - can you do that? If not, I may find time for that in a few days."}}
{"actor":{"display_login":"divVerent"}}