{"action":"created","comment":{"url":"https://api.github.com/repos/TheJumpCloud/support/pulls/comments/206932184","pull_request_review_id":142440948,"id":206932184,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjkzMjE4NA==","diff_hunk":"@@ -0,0 +1,8 @@\n+defaults write /Library/LaunchAgents/com.jumpcloud.jcagent-tray Disabled -bool true\n+mkdir -p /opt/jc_user_ro\n+touch /opt/jc_user_ro/dont_show_tray_app\n+PERMISSIONS=\"$(ls -l /opt/jc_user_ro/dont_show_tray_app | cut -c -10)\"\n+if [ \"$PERMISSIONS\" != \"-rw-r--r--\" ]; then","path":"scripts/macos/hide_mac_app.sh","position":5,"original_position":5,"commit_id":"1079fdb80e6aa292433188bc8372130acde5bc01","original_commit_id":"1079fdb80e6aa292433188bc8372130acde5bc01","user":{"login":"jc-rob","id":20047903,"node_id":"MDQ6VXNlcjIwMDQ3OTAz","avatar_url":"https://avatars1.githubusercontent.com/u/20047903?v=4","gravatar_id":"","url":"https://api.github.com/users/jc-rob","html_url":"https://github.com/jc-rob","followers_url":"https://api.github.com/users/jc-rob/followers","following_url":"https://api.github.com/users/jc-rob/following{/other_user}","gists_url":"https://api.github.com/users/jc-rob/gists{/gist_id}","starred_url":"https://api.github.com/users/jc-rob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc-rob/subscriptions","organizations_url":"https://api.github.com/users/jc-rob/orgs","repos_url":"https://api.github.com/users/jc-rob/repos","events_url":"https://api.github.com/users/jc-rob/events{/privacy}","received_events_url":"https://api.github.com/users/jc-rob/received_events","type":"User","site_admin":false},"body":"are these permissions critical for this script to accomplish its purpose? If so, instead of just bailing if they aren't correct, why not set the perms if wrong?","created_at":"2018-08-01T15:41:54Z","updated_at":"2018-08-01T15:41:54Z","html_url":"https://github.com/TheJumpCloud/support/pull/33#discussion_r206932184","pull_request_url":"https://api.github.com/repos/TheJumpCloud/support/pulls/33","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TheJumpCloud/support/pulls/comments/206932184"},"html":{"href":"https://github.com/TheJumpCloud/support/pull/33#discussion_r206932184"},"pull_request":{"href":"https://api.github.com/repos/TheJumpCloud/support/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/TheJumpCloud/support/pulls/33","id":205464249,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDY0MjQ5","html_url":"https://github.com/TheJumpCloud/support/pull/33","diff_url":"https://github.com/TheJumpCloud/support/pull/33.diff","patch_url":"https://github.com/TheJumpCloud/support/pull/33.patch","issue_url":"https://api.github.com/repos/TheJumpCloud/support/issues/33","number":33,"state":"open","locked":false,"title":"Create hide_mac_app.sh","user":{"login":"kyle-randolph","id":20173512,"node_id":"MDQ6VXNlcjIwMTczNTEy","avatar_url":"https://avatars1.githubusercontent.com/u/20173512?v=4","gravatar_id":"","url":"https://api.github.com/users/kyle-randolph","html_url":"https://github.com/kyle-randolph","followers_url":"https://api.github.com/users/kyle-randolph/followers","following_url":"https://api.github.com/users/kyle-randolph/following{/other_user}","gists_url":"https://api.github.com/users/kyle-randolph/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-randolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-randolph/subscriptions","organizations_url":"https://api.github.com/users/kyle-randolph/orgs","repos_url":"https://api.github.com/users/kyle-randolph/repos","events_url":"https://api.github.com/users/kyle-randolph/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-randolph/received_events","type":"User","site_admin":false},"body":"This short script hides the Mac App from displaying for JumpCloud managed users. This must be run as root on systems where you would like to hide the Mac App.","created_at":"2018-08-01T15:28:02Z","updated_at":"2018-08-01T15:41:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44e6125042490b398717f4a7d0f8baf2d8e5f2e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TheJumpCloud/support/pulls/33/commits","review_comments_url":"https://api.github.com/repos/TheJumpCloud/support/pulls/33/comments","review_comment_url":"https://api.github.com/repos/TheJumpCloud/support/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheJumpCloud/support/issues/33/comments","statuses_url":"https://api.github.com/repos/TheJumpCloud/support/statuses/1079fdb80e6aa292433188bc8372130acde5bc01","head":{"label":"TheJumpCloud:hide-mac-app","ref":"hide-mac-app","sha":"1079fdb80e6aa292433188bc8372130acde5bc01","user":{"login":"TheJumpCloud","id":4927461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5Mjc0NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/4927461?v=4","gravatar_id":"","url":"https://api.github.com/users/TheJumpCloud","html_url":"https://github.com/TheJumpCloud","followers_url":"https://api.github.com/users/TheJumpCloud/followers","following_url":"https://api.github.com/users/TheJumpCloud/following{/other_user}","gists_url":"https://api.github.com/users/TheJumpCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/TheJumpCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheJumpCloud/subscriptions","organizations_url":"https://api.github.com/users/TheJumpCloud/orgs","repos_url":"https://api.github.com/users/TheJumpCloud/repos","events_url":"https://api.github.com/users/TheJumpCloud/events{/privacy}","received_events_url":"https://api.github.com/users/TheJumpCloud/received_events","type":"Organization","site_admin":false},"repo":{"id":84246551,"node_id":"MDEwOlJlcG9zaXRvcnk4NDI0NjU1MQ==","name":"support","full_name":"TheJumpCloud/support","owner":{"login":"TheJumpCloud","id":4927461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5Mjc0NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/4927461?v=4","gravatar_id":"","url":"https://api.github.com/users/TheJumpCloud","html_url":"https://github.com/TheJumpCloud","followers_url":"https://api.github.com/users/TheJumpCloud/followers","following_url":"https://api.github.com/users/TheJumpCloud/following{/other_user}","gists_url":"https://api.github.com/users/TheJumpCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/TheJumpCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheJumpCloud/subscriptions","organizations_url":"https://api.github.com/users/TheJumpCloud/orgs","repos_url":"https://api.github.com/users/TheJumpCloud/repos","events_url":"https://api.github.com/users/TheJumpCloud/events{/privacy}","received_events_url":"https://api.github.com/users/TheJumpCloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheJumpCloud/support","description":"Public scripts and examples for managing JumpCloud managed systems and service endpoints","fork":false,"url":"https://api.github.com/repos/TheJumpCloud/support","forks_url":"https://api.github.com/repos/TheJumpCloud/support/forks","keys_url":"https://api.github.com/repos/TheJumpCloud/support/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheJumpCloud/support/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheJumpCloud/support/teams","hooks_url":"https://api.github.com/repos/TheJumpCloud/support/hooks","issue_events_url":"https://api.github.com/repos/TheJumpCloud/support/issues/events{/number}","events_url":"https://api.github.com/repos/TheJumpCloud/support/events","assignees_url":"https://api.github.com/repos/TheJumpCloud/support/assignees{/user}","branches_url":"https://api.github.com/repos/TheJumpCloud/support/branches{/branch}","tags_url":"https://api.github.com/repos/TheJumpCloud/support/tags","blobs_url":"https://api.github.com/repos/TheJumpCloud/support/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheJumpCloud/support/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheJumpCloud/support/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheJumpCloud/support/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheJumpCloud/support/statuses/{sha}","languages_url":"https://api.github.com/repos/TheJumpCloud/support/languages","stargazers_url":"https://api.github.com/repos/TheJumpCloud/support/stargazers","contributors_url":"https://api.github.com/repos/TheJumpCloud/support/contributors","subscribers_url":"https://api.github.com/repos/TheJumpCloud/support/subscribers","subscription_url":"https://api.github.com/repos/TheJumpCloud/support/subscription","commits_url":"https://api.github.com/repos/TheJumpCloud/support/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheJumpCloud/support/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheJumpCloud/support/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheJumpCloud/support/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheJumpCloud/support/contents/{+path}","compare_url":"https://api.github.com/repos/TheJumpCloud/support/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheJumpCloud/support/merges","archive_url":"https://api.github.com/repos/TheJumpCloud/support/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheJumpCloud/support/downloads","issues_url":"https://api.github.com/repos/TheJumpCloud/support/issues{/number}","pulls_url":"https://api.github.com/repos/TheJumpCloud/support/pulls{/number}","milestones_url":"https://api.github.com/repos/TheJumpCloud/support/milestones{/number}","notifications_url":"https://api.github.com/repos/TheJumpCloud/support/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheJumpCloud/support/labels{/name}","releases_url":"https://api.github.com/repos/TheJumpCloud/support/releases{/id}","deployments_url":"https://api.github.com/repos/TheJumpCloud/support/deployments","created_at":"2017-03-07T21:12:35Z","updated_at":"2018-07-30T20:48:16Z","pushed_at":"2018-08-01T15:28:02Z","git_url":"git://github.com/TheJumpCloud/support.git","ssh_url":"git@github.com:TheJumpCloud/support.git","clone_url":"https://github.com/TheJumpCloud/support.git","svn_url":"https://github.com/TheJumpCloud/support","homepage":"","size":4957,"stargazers_count":26,"watchers_count":26,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":22,"open_issues":2,"watchers":26,"default_branch":"master"}},"base":{"label":"TheJumpCloud:master","ref":"master","sha":"caa82c9ee590ea005f444a4e010ce91694b2857d","user":{"login":"TheJumpCloud","id":4927461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5Mjc0NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/4927461?v=4","gravatar_id":"","url":"https://api.github.com/users/TheJumpCloud","html_url":"https://github.com/TheJumpCloud","followers_url":"https://api.github.com/users/TheJumpCloud/followers","following_url":"https://api.github.com/users/TheJumpCloud/following{/other_user}","gists_url":"https://api.github.com/users/TheJumpCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/TheJumpCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheJumpCloud/subscriptions","organizations_url":"https://api.github.com/users/TheJumpCloud/orgs","repos_url":"https://api.github.com/users/TheJumpCloud/repos","events_url":"https://api.github.com/users/TheJumpCloud/events{/privacy}","received_events_url":"https://api.github.com/users/TheJumpCloud/received_events","type":"Organization","site_admin":false},"repo":{"id":84246551,"node_id":"MDEwOlJlcG9zaXRvcnk4NDI0NjU1MQ==","name":"support","full_name":"TheJumpCloud/support","owner":{"login":"TheJumpCloud","id":4927461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5Mjc0NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/4927461?v=4","gravatar_id":"","url":"https://api.github.com/users/TheJumpCloud","html_url":"https://github.com/TheJumpCloud","followers_url":"https://api.github.com/users/TheJumpCloud/followers","following_url":"https://api.github.com/users/TheJumpCloud/following{/other_user}","gists_url":"https://api.github.com/users/TheJumpCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/TheJumpCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheJumpCloud/subscriptions","organizations_url":"https://api.github.com/users/TheJumpCloud/orgs","repos_url":"https://api.github.com/users/TheJumpCloud/repos","events_url":"https://api.github.com/users/TheJumpCloud/events{/privacy}","received_events_url":"https://api.github.com/users/TheJumpCloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheJumpCloud/support","description":"Public scripts and examples for managing JumpCloud managed systems and service endpoints","fork":false,"url":"https://api.github.com/repos/TheJumpCloud/support","forks_url":"https://api.github.com/repos/TheJumpCloud/support/forks","keys_url":"https://api.github.com/repos/TheJumpCloud/support/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheJumpCloud/support/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheJumpCloud/support/teams","hooks_url":"https://api.github.com/repos/TheJumpCloud/support/hooks","issue_events_url":"https://api.github.com/repos/TheJumpCloud/support/issues/events{/number}","events_url":"https://api.github.com/repos/TheJumpCloud/support/events","assignees_url":"https://api.github.com/repos/TheJumpCloud/support/assignees{/user}","branches_url":"https://api.github.com/repos/TheJumpCloud/support/branches{/branch}","tags_url":"https://api.github.com/repos/TheJumpCloud/support/tags","blobs_url":"https://api.github.com/repos/TheJumpCloud/support/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheJumpCloud/support/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheJumpCloud/support/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheJumpCloud/support/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheJumpCloud/support/statuses/{sha}","languages_url":"https://api.github.com/repos/TheJumpCloud/support/languages","stargazers_url":"https://api.github.com/repos/TheJumpCloud/support/stargazers","contributors_url":"https://api.github.com/repos/TheJumpCloud/support/contributors","subscribers_url":"https://api.github.com/repos/TheJumpCloud/support/subscribers","subscription_url":"https://api.github.com/repos/TheJumpCloud/support/subscription","commits_url":"https://api.github.com/repos/TheJumpCloud/support/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheJumpCloud/support/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheJumpCloud/support/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheJumpCloud/support/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheJumpCloud/support/contents/{+path}","compare_url":"https://api.github.com/repos/TheJumpCloud/support/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheJumpCloud/support/merges","archive_url":"https://api.github.com/repos/TheJumpCloud/support/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheJumpCloud/support/downloads","issues_url":"https://api.github.com/repos/TheJumpCloud/support/issues{/number}","pulls_url":"https://api.github.com/repos/TheJumpCloud/support/pulls{/number}","milestones_url":"https://api.github.com/repos/TheJumpCloud/support/milestones{/number}","notifications_url":"https://api.github.com/repos/TheJumpCloud/support/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheJumpCloud/support/labels{/name}","releases_url":"https://api.github.com/repos/TheJumpCloud/support/releases{/id}","deployments_url":"https://api.github.com/repos/TheJumpCloud/support/deployments","created_at":"2017-03-07T21:12:35Z","updated_at":"2018-07-30T20:48:16Z","pushed_at":"2018-08-01T15:28:02Z","git_url":"git://github.com/TheJumpCloud/support.git","ssh_url":"git@github.com:TheJumpCloud/support.git","clone_url":"https://github.com/TheJumpCloud/support.git","svn_url":"https://github.com/TheJumpCloud/support","homepage":"","size":4957,"stargazers_count":26,"watchers_count":26,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":22,"open_issues":2,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TheJumpCloud/support/pulls/33"},"html":{"href":"https://github.com/TheJumpCloud/support/pull/33"},"issue":{"href":"https://api.github.com/repos/TheJumpCloud/support/issues/33"},"comments":{"href":"https://api.github.com/repos/TheJumpCloud/support/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/TheJumpCloud/support/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/TheJumpCloud/support/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheJumpCloud/support/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/TheJumpCloud/support/statuses/1079fdb80e6aa292433188bc8372130acde5bc01"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jc-rob"}}