{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/194636253","pull_request_review_id":127843345,"id":194636253,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDYzNjI1Mw==","diff_hunk":"@@ -165,6 +165,13 @@ def nodes\n           ::Crowbar::UpgradeStatus.new.start_step(:nodes)\n         end\n       else\n+        # At this point params[:component] should be a node, if it is not,\n+        # raise an error.\n+        unless Node.all.map { |n| n.name }.include? params[:component]\n+          raise ::Crowbar::Error::UpgradeError.new(\n+           \"Component must be all, controllers or a node name.\"","path":"crowbar_framework/app/controllers/api/upgrade_controller.rb","position":8,"original_position":8,"commit_id":"e44880e0069ea8eed5ad08274631905768aa20f2","original_commit_id":"e44880e0069ea8eed5ad08274631905768aa20f2","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Layout/FirstParameterIndentation: Indent the first parameter one step more than the start of the previous line.","created_at":"2018-06-12T07:20:10Z","updated_at":"2018-06-12T07:20:10Z","html_url":"https://github.com/crowbar/crowbar-core/pull/1603#discussion_r194636253","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1603","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/194636253"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/1603#discussion_r194636253"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1603"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1603","id":194186978,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTg2OTc4","html_url":"https://github.com/crowbar/crowbar-core/pull/1603","diff_url":"https://github.com/crowbar/crowbar-core/pull/1603.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/1603.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1603","number":1603,"state":"open","locked":false,"title":"upgrade: Check input is a valid node for nodes","user":{"login":"s-t-e-v-e-n-k","id":15225059,"node_id":"MDQ6VXNlcjE1MjI1MDU5","avatar_url":"https://avatars0.githubusercontent.com/u/15225059?v=4","gravatar_id":"","url":"https://api.github.com/users/s-t-e-v-e-n-k","html_url":"https://github.com/s-t-e-v-e-n-k","followers_url":"https://api.github.com/users/s-t-e-v-e-n-k/followers","following_url":"https://api.github.com/users/s-t-e-v-e-n-k/following{/other_user}","gists_url":"https://api.github.com/users/s-t-e-v-e-n-k/gists{/gist_id}","starred_url":"https://api.github.com/users/s-t-e-v-e-n-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-t-e-v-e-n-k/subscriptions","organizations_url":"https://api.github.com/users/s-t-e-v-e-n-k/orgs","repos_url":"https://api.github.com/users/s-t-e-v-e-n-k/repos","events_url":"https://api.github.com/users/s-t-e-v-e-n-k/events{/privacy}","received_events_url":"https://api.github.com/users/s-t-e-v-e-n-k/received_events","type":"User","site_admin":false},"body":"The else clause for upgrade nodes assumes input is valid, and if it\r\nisn't, returns an unhelpful message about how controller nodes need to\r\nbe upgraded first. Validate the input to provide a helpful error.\r\n\r\nPlease help potential reviewers to understand this pull request and speed\r\nup the process by writing a meaningful pull request message.\r\n\r\nAnswering the following questions can help, but is optional.\r\n\r\n**Why is this change necessary?**\r\n\r\n**How does it address the issue?**\r\n\r\n**Is there additional information worth sharing like links to a Trello\r\ncard, bug references, testing advice or dependencies to other pull\r\nrequests?**\r\n","created_at":"2018-06-12T07:19:36Z","updated_at":"2018-06-12T07:20:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65569d22de5c4690581abe16fae166954c477e36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":264031606,"node_id":"MDU6TGFiZWwyNjQwMzE2MDY=","url":"https://api.github.com/repos/crowbar/crowbar-core/labels/wip","name":"wip","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1603/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1603/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1603/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/e44880e0069ea8eed5ad08274631905768aa20f2","head":{"label":"s-t-e-v-e-n-k:also-catch-invalid-component","ref":"also-catch-invalid-component","sha":"e44880e0069ea8eed5ad08274631905768aa20f2","user":{"login":"s-t-e-v-e-n-k","id":15225059,"node_id":"MDQ6VXNlcjE1MjI1MDU5","avatar_url":"https://avatars0.githubusercontent.com/u/15225059?v=4","gravatar_id":"","url":"https://api.github.com/users/s-t-e-v-e-n-k","html_url":"https://github.com/s-t-e-v-e-n-k","followers_url":"https://api.github.com/users/s-t-e-v-e-n-k/followers","following_url":"https://api.github.com/users/s-t-e-v-e-n-k/following{/other_user}","gists_url":"https://api.github.com/users/s-t-e-v-e-n-k/gists{/gist_id}","starred_url":"https://api.github.com/users/s-t-e-v-e-n-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-t-e-v-e-n-k/subscriptions","organizations_url":"https://api.github.com/users/s-t-e-v-e-n-k/orgs","repos_url":"https://api.github.com/users/s-t-e-v-e-n-k/repos","events_url":"https://api.github.com/users/s-t-e-v-e-n-k/events{/privacy}","received_events_url":"https://api.github.com/users/s-t-e-v-e-n-k/received_events","type":"User","site_admin":false},"repo":{"id":65170579,"node_id":"MDEwOlJlcG9zaXRvcnk2NTE3MDU3OQ==","name":"crowbar-core","full_name":"s-t-e-v-e-n-k/crowbar-core","owner":{"login":"s-t-e-v-e-n-k","id":15225059,"node_id":"MDQ6VXNlcjE1MjI1MDU5","avatar_url":"https://avatars0.githubusercontent.com/u/15225059?v=4","gravatar_id":"","url":"https://api.github.com/users/s-t-e-v-e-n-k","html_url":"https://github.com/s-t-e-v-e-n-k","followers_url":"https://api.github.com/users/s-t-e-v-e-n-k/followers","following_url":"https://api.github.com/users/s-t-e-v-e-n-k/following{/other_user}","gists_url":"https://api.github.com/users/s-t-e-v-e-n-k/gists{/gist_id}","starred_url":"https://api.github.com/users/s-t-e-v-e-n-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-t-e-v-e-n-k/subscriptions","organizations_url":"https://api.github.com/users/s-t-e-v-e-n-k/orgs","repos_url":"https://api.github.com/users/s-t-e-v-e-n-k/repos","events_url":"https://api.github.com/users/s-t-e-v-e-n-k/events{/privacy}","received_events_url":"https://api.github.com/users/s-t-e-v-e-n-k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s-t-e-v-e-n-k/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core","forks_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/forks","keys_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/teams","hooks_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/events","assignees_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/tags","blobs_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/subscription","commits_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/merges","archive_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/downloads","issues_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/s-t-e-v-e-n-k/crowbar-core/deployments","created_at":"2016-08-08T03:45:24Z","updated_at":"2016-08-08T03:45:27Z","pushed_at":"2018-06-12T07:19:03Z","git_url":"git://github.com/s-t-e-v-e-n-k/crowbar-core.git","ssh_url":"git@github.com:s-t-e-v-e-n-k/crowbar-core.git","clone_url":"https://github.com/s-t-e-v-e-n-k/crowbar-core.git","svn_url":"https://github.com/s-t-e-v-e-n-k/crowbar-core","homepage":null,"size":108992,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"4a0e99b60406a3fd0e5ef55e2578e3ae08db9cbc","user":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"node_id":"MDEwOlJlcG9zaXRvcnkzOTAwMzIyNw==","name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2018-06-11T19:10:08Z","pushed_at":"2018-06-12T07:19:37Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":109239,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":45,"license":null,"forks":59,"open_issues":45,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1603"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/1603"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/1603"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/1603/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1603/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1603/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/e44880e0069ea8eed5ad08274631905768aa20f2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}