{"action":"created","comment":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments/172891861","pull_request_review_id":101960817,"id":172891861,"diff_hunk":"@@ -0,0 +1,26 @@\n+package uk.ac.stfc.isis.ibex.journal;\n+\n+import java.util.EnumMap;\n+\n+import uk.ac.stfc.isis.ibex.model.ModelObject;\n+\n+public class JournalRow extends ModelObject {","path":"base/uk.ac.stfc.isis.ibex.journal/src/uk/ac/stfc/isis/ibex/journal/JournalRow.java","position":7,"original_position":7,"commit_id":"8dcb3b137f1ccb80555986309d4dfd8cd0db758b","original_commit_id":"8dcb3b137f1ccb80555986309d4dfd8cd0db758b","user":{"login":"ThomasLohnert","id":18398579,"avatar_url":"https://avatars1.githubusercontent.com/u/18398579?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasLohnert","html_url":"https://github.com/ThomasLohnert","followers_url":"https://api.github.com/users/ThomasLohnert/followers","following_url":"https://api.github.com/users/ThomasLohnert/following{/other_user}","gists_url":"https://api.github.com/users/ThomasLohnert/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasLohnert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasLohnert/subscriptions","organizations_url":"https://api.github.com/users/ThomasLohnert/orgs","repos_url":"https://api.github.com/users/ThomasLohnert/repos","events_url":"https://api.github.com/users/ThomasLohnert/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasLohnert/received_events","type":"User","site_admin":false},"body":"Class is missing Javadoc","created_at":"2018-03-07T16:01:38Z","updated_at":"2018-03-07T16:34:14Z","html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/650#discussion_r172891861","pull_request_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/650","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments/172891861"},"html":{"href":"https://github.com/ISISComputingGroup/ibex_gui/pull/650#discussion_r172891861"},"pull_request":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/650"}}},"pull_request":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/650","id":173134101,"html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/650","diff_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/650.diff","patch_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/650.patch","issue_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/650","number":650,"state":"open","locked":false,"title":"Ticket2905 journal viewer table","user":{"login":"Tom-Willemsen","id":24375813,"avatar_url":"https://avatars1.githubusercontent.com/u/24375813?v=4","gravatar_id":"","url":"https://api.github.com/users/Tom-Willemsen","html_url":"https://github.com/Tom-Willemsen","followers_url":"https://api.github.com/users/Tom-Willemsen/followers","following_url":"https://api.github.com/users/Tom-Willemsen/following{/other_user}","gists_url":"https://api.github.com/users/Tom-Willemsen/gists{/gist_id}","starred_url":"https://api.github.com/users/Tom-Willemsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tom-Willemsen/subscriptions","organizations_url":"https://api.github.com/users/Tom-Willemsen/orgs","repos_url":"https://api.github.com/users/Tom-Willemsen/repos","events_url":"https://api.github.com/users/Tom-Willemsen/events{/privacy}","received_events_url":"https://api.github.com/users/Tom-Willemsen/received_events","type":"User","site_admin":false},"body":"### Description of work\r\n\r\nAdds a table to visualise the Journal in IBEX.\r\n\r\nAfter discussion with @John-Holt-Tessella I also removed the continuous refresh, in favour of refreshing whenever the perspective is reopened.\r\n\r\n### Ticket\r\n\r\nhttps://github.com/ISISComputingGroup/IBEX/issues/2905\r\n\r\n### Acceptance criteria\r\n\r\n- Table displays journal data appropriately\r\n\r\n### Unit tests\r\n\r\nNothing testable, just GUI code.\r\n\r\n### System tests\r\n\r\nNo current system test framework\r\n\r\n### Documentation\r\n\r\nNot needed\r\n\r\n---\r\n\r\n#### Code Review\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Do the changes function as described and is it robust?\r\n- [ ] Have the changes been documented in the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev)?\r\n\r\n### Final Steps\r\n- [ ] Reviewer has moved the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev) entry for this ticket in the \"Changes merged into master\" section\r\n\r\n","created_at":"2018-03-06T11:45:03Z","updated_at":"2018-03-07T16:34:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69631c576b4855525d3edd65db88ac736129e783","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/650/commits","review_comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/650/comments","review_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/650/comments","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/8dcb3b137f1ccb80555986309d4dfd8cd0db758b","head":{"label":"ISISComputingGroup:Ticket2905_journal_viewer_table","ref":"Ticket2905_journal_viewer_table","sha":"8dcb3b137f1ccb80555986309d4dfd8cd0db758b","user":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":36387668,"name":"ibex_gui","full_name":"ISISComputingGroup/ibex_gui","owner":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISISComputingGroup/ibex_gui","description":"The IBEX GUI repository","fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui","forks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/deployments","created_at":"2015-05-27T18:37:00Z","updated_at":"2017-11-10T02:14:15Z","pushed_at":"2018-03-07T15:22:15Z","git_url":"git://github.com/ISISComputingGroup/ibex_gui.git","ssh_url":"git@github.com:ISISComputingGroup/ibex_gui.git","clone_url":"https://github.com/ISISComputingGroup/ibex_gui.git","svn_url":"https://github.com/ISISComputingGroup/ibex_gui","homepage":"","size":29250,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"ISISComputingGroup:master","ref":"master","sha":"de398e34c8c8e19e7c4258e0d3653d11e53b1b5f","user":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":36387668,"name":"ibex_gui","full_name":"ISISComputingGroup/ibex_gui","owner":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISISComputingGroup/ibex_gui","description":"The IBEX GUI repository","fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui","forks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/deployments","created_at":"2015-05-27T18:37:00Z","updated_at":"2017-11-10T02:14:15Z","pushed_at":"2018-03-07T15:22:15Z","git_url":"git://github.com/ISISComputingGroup/ibex_gui.git","ssh_url":"git@github.com:ISISComputingGroup/ibex_gui.git","clone_url":"https://github.com/ISISComputingGroup/ibex_gui.git","svn_url":"https://github.com/ISISComputingGroup/ibex_gui","homepage":"","size":29250,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/650"},"html":{"href":"https://github.com/ISISComputingGroup/ibex_gui/pull/650"},"issue":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/650"},"comments":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/650/comments"},"review_comments":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/650/comments"},"review_comment":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/650/commits"},"statuses":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/8dcb3b137f1ccb80555986309d4dfd8cd0db758b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ThomasLohnert"}}