{"action":"created","comment":{"url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls/comments/188360641","pull_request_review_id":120323270,"id":188360641,"diff_hunk":"@@ -41,28 +41,27 @@ harness = false\n # match exactly, since the build.rs uses the crate itself as a library.\n \n [dependencies]\n-byteorder = {version = \"1\", default-features = false }\n+rand = { version = \"0.5.0-pre\", default-features = false, git = \"https://github.com/rust-lang-nursery/rand\" }","path":"Cargo.toml","position":5,"original_position":5,"commit_id":"b37f540ca8d2af5407467405bde15836e28ea5fb","original_commit_id":"b37f540ca8d2af5407467405bde15836e28ea5fb","user":{"login":"hdevalence","id":44879,"avatar_url":"https://avatars2.githubusercontent.com/u/44879?v=4","gravatar_id":"","url":"https://api.github.com/users/hdevalence","html_url":"https://github.com/hdevalence","followers_url":"https://api.github.com/users/hdevalence/followers","following_url":"https://api.github.com/users/hdevalence/following{/other_user}","gists_url":"https://api.github.com/users/hdevalence/gists{/gist_id}","starred_url":"https://api.github.com/users/hdevalence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdevalence/subscriptions","organizations_url":"https://api.github.com/users/hdevalence/orgs","repos_url":"https://api.github.com/users/hdevalence/repos","events_url":"https://api.github.com/users/hdevalence/events{/privacy}","received_events_url":"https://api.github.com/users/hdevalence/received_events","type":"User","site_admin":false},"body":"I think it should be `0.5.0-pre.2`.","created_at":"2018-05-15T16:52:58Z","updated_at":"2018-05-15T16:52:58Z","html_url":"https://github.com/dalek-cryptography/curve25519-dalek/pull/141#discussion_r188360641","pull_request_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls/141","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls/comments/188360641"},"html":{"href":"https://github.com/dalek-cryptography/curve25519-dalek/pull/141#discussion_r188360641"},"pull_request":{"href":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls/141"}},"in_reply_to_id":188150883},"pull_request":{"url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls/141","id":187950467,"html_url":"https://github.com/dalek-cryptography/curve25519-dalek/pull/141","diff_url":"https://github.com/dalek-cryptography/curve25519-dalek/pull/141.diff","patch_url":"https://github.com/dalek-cryptography/curve25519-dalek/pull/141.patch","issue_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/issues/141","number":141,"state":"open","locked":false,"title":"[WIP] upgrade to rand 0.5","user":{"login":"hdevalence","id":44879,"avatar_url":"https://avatars2.githubusercontent.com/u/44879?v=4","gravatar_id":"","url":"https://api.github.com/users/hdevalence","html_url":"https://github.com/hdevalence","followers_url":"https://api.github.com/users/hdevalence/followers","following_url":"https://api.github.com/users/hdevalence/following{/other_user}","gists_url":"https://api.github.com/users/hdevalence/gists{/gist_id}","starred_url":"https://api.github.com/users/hdevalence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdevalence/subscriptions","organizations_url":"https://api.github.com/users/hdevalence/orgs","repos_url":"https://api.github.com/users/hdevalence/repos","events_url":"https://api.github.com/users/hdevalence/events{/privacy}","received_events_url":"https://api.github.com/users/hdevalence/received_events","type":"User","site_admin":false},"body":"This specifies the git repository, because `impl CryptoRng for OsRng` was only\r\nadded after the last pre-release (in https://github.com/rust-lang-nursery/rand/pull/414)\r\n\r\nOnce the 0.5 version of `rand` is released, we can edit this commit to remove\r\nthe git dependency, and then merge it.\r\n\r\nCloses #132 ","created_at":"2018-05-14T21:03:54Z","updated_at":"2018-05-15T16:52:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52c89b08d0cd248f65d503c1fe6edabd4390c871","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":721869840,"url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/labels/api%20-%20design","name":"api - design","color":"ebf765","default":false},{"id":496900301,"url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/milestones/2","html_url":"https://github.com/dalek-cryptography/curve25519-dalek/milestone/2","labels_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/milestones/2/labels","id":3346779,"number":2,"title":"0.17.0","description":"The next `curve25519-dalek` release, with breaking API changes.","creator":{"login":"hdevalence","id":44879,"avatar_url":"https://avatars2.githubusercontent.com/u/44879?v=4","gravatar_id":"","url":"https://api.github.com/users/hdevalence","html_url":"https://github.com/hdevalence","followers_url":"https://api.github.com/users/hdevalence/followers","following_url":"https://api.github.com/users/hdevalence/following{/other_user}","gists_url":"https://api.github.com/users/hdevalence/gists{/gist_id}","starred_url":"https://api.github.com/users/hdevalence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdevalence/subscriptions","organizations_url":"https://api.github.com/users/hdevalence/orgs","repos_url":"https://api.github.com/users/hdevalence/repos","events_url":"https://api.github.com/users/hdevalence/events{/privacy}","received_events_url":"https://api.github.com/users/hdevalence/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":2,"state":"open","created_at":"2018-05-14T20:49:55Z","updated_at":"2018-05-15T02:28:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls/141/commits","review_comments_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls/141/comments","review_comment_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/issues/141/comments","statuses_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/statuses/b37f540ca8d2af5407467405bde15836e28ea5fb","head":{"label":"dalek-cryptography:rand-0.5","ref":"rand-0.5","sha":"b37f540ca8d2af5407467405bde15836e28ea5fb","user":{"login":"dalek-cryptography","id":35540388,"avatar_url":"https://avatars3.githubusercontent.com/u/35540388?v=4","gravatar_id":"","url":"https://api.github.com/users/dalek-cryptography","html_url":"https://github.com/dalek-cryptography","followers_url":"https://api.github.com/users/dalek-cryptography/followers","following_url":"https://api.github.com/users/dalek-cryptography/following{/other_user}","gists_url":"https://api.github.com/users/dalek-cryptography/gists{/gist_id}","starred_url":"https://api.github.com/users/dalek-cryptography/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalek-cryptography/subscriptions","organizations_url":"https://api.github.com/users/dalek-cryptography/orgs","repos_url":"https://api.github.com/users/dalek-cryptography/repos","events_url":"https://api.github.com/users/dalek-cryptography/events{/privacy}","received_events_url":"https://api.github.com/users/dalek-cryptography/received_events","type":"Organization","site_admin":false},"repo":{"id":75924987,"name":"curve25519-dalek","full_name":"dalek-cryptography/curve25519-dalek","owner":{"login":"dalek-cryptography","id":35540388,"avatar_url":"https://avatars3.githubusercontent.com/u/35540388?v=4","gravatar_id":"","url":"https://api.github.com/users/dalek-cryptography","html_url":"https://github.com/dalek-cryptography","followers_url":"https://api.github.com/users/dalek-cryptography/followers","following_url":"https://api.github.com/users/dalek-cryptography/following{/other_user}","gists_url":"https://api.github.com/users/dalek-cryptography/gists{/gist_id}","starred_url":"https://api.github.com/users/dalek-cryptography/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalek-cryptography/subscriptions","organizations_url":"https://api.github.com/users/dalek-cryptography/orgs","repos_url":"https://api.github.com/users/dalek-cryptography/repos","events_url":"https://api.github.com/users/dalek-cryptography/events{/privacy}","received_events_url":"https://api.github.com/users/dalek-cryptography/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dalek-cryptography/curve25519-dalek","description":"A pure-Rust implementation of group operations on Ristretto and Curve25519","fork":false,"url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek","forks_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/forks","keys_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/teams","hooks_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/hooks","issue_events_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/issues/events{/number}","events_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/events","assignees_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/assignees{/user}","branches_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/branches{/branch}","tags_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/tags","blobs_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/git/refs{/sha}","trees_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/statuses/{sha}","languages_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/languages","stargazers_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/stargazers","contributors_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/contributors","subscribers_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/subscribers","subscription_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/subscription","commits_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/commits{/sha}","git_commits_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/git/commits{/sha}","comments_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/comments{/number}","issue_comment_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/issues/comments{/number}","contents_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/contents/{+path}","compare_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/merges","archive_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/downloads","issues_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/issues{/number}","pulls_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls{/number}","milestones_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/milestones{/number}","notifications_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/labels{/name}","releases_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/releases{/id}","deployments_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/deployments","created_at":"2016-12-08T09:50:02Z","updated_at":"2018-05-15T13:32:06Z","pushed_at":"2018-05-15T03:25:35Z","git_url":"git://github.com/dalek-cryptography/curve25519-dalek.git","ssh_url":"git@github.com:dalek-cryptography/curve25519-dalek.git","clone_url":"https://github.com/dalek-cryptography/curve25519-dalek.git","svn_url":"https://github.com/dalek-cryptography/curve25519-dalek","homepage":"","size":1903,"stargazers_count":178,"watchers_count":178,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":33,"open_issues":14,"watchers":178,"default_branch":"master"}},"base":{"label":"dalek-cryptography:develop","ref":"develop","sha":"615095817ba9f01fadb8633d1bdbe8013e9318ed","user":{"login":"dalek-cryptography","id":35540388,"avatar_url":"https://avatars3.githubusercontent.com/u/35540388?v=4","gravatar_id":"","url":"https://api.github.com/users/dalek-cryptography","html_url":"https://github.com/dalek-cryptography","followers_url":"https://api.github.com/users/dalek-cryptography/followers","following_url":"https://api.github.com/users/dalek-cryptography/following{/other_user}","gists_url":"https://api.github.com/users/dalek-cryptography/gists{/gist_id}","starred_url":"https://api.github.com/users/dalek-cryptography/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalek-cryptography/subscriptions","organizations_url":"https://api.github.com/users/dalek-cryptography/orgs","repos_url":"https://api.github.com/users/dalek-cryptography/repos","events_url":"https://api.github.com/users/dalek-cryptography/events{/privacy}","received_events_url":"https://api.github.com/users/dalek-cryptography/received_events","type":"Organization","site_admin":false},"repo":{"id":75924987,"name":"curve25519-dalek","full_name":"dalek-cryptography/curve25519-dalek","owner":{"login":"dalek-cryptography","id":35540388,"avatar_url":"https://avatars3.githubusercontent.com/u/35540388?v=4","gravatar_id":"","url":"https://api.github.com/users/dalek-cryptography","html_url":"https://github.com/dalek-cryptography","followers_url":"https://api.github.com/users/dalek-cryptography/followers","following_url":"https://api.github.com/users/dalek-cryptography/following{/other_user}","gists_url":"https://api.github.com/users/dalek-cryptography/gists{/gist_id}","starred_url":"https://api.github.com/users/dalek-cryptography/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalek-cryptography/subscriptions","organizations_url":"https://api.github.com/users/dalek-cryptography/orgs","repos_url":"https://api.github.com/users/dalek-cryptography/repos","events_url":"https://api.github.com/users/dalek-cryptography/events{/privacy}","received_events_url":"https://api.github.com/users/dalek-cryptography/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dalek-cryptography/curve25519-dalek","description":"A pure-Rust implementation of group operations on Ristretto and Curve25519","fork":false,"url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek","forks_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/forks","keys_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/teams","hooks_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/hooks","issue_events_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/issues/events{/number}","events_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/events","assignees_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/assignees{/user}","branches_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/branches{/branch}","tags_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/tags","blobs_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/git/refs{/sha}","trees_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/statuses/{sha}","languages_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/languages","stargazers_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/stargazers","contributors_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/contributors","subscribers_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/subscribers","subscription_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/subscription","commits_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/commits{/sha}","git_commits_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/git/commits{/sha}","comments_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/comments{/number}","issue_comment_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/issues/comments{/number}","contents_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/contents/{+path}","compare_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/merges","archive_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/downloads","issues_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/issues{/number}","pulls_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls{/number}","milestones_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/milestones{/number}","notifications_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/labels{/name}","releases_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/releases{/id}","deployments_url":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/deployments","created_at":"2016-12-08T09:50:02Z","updated_at":"2018-05-15T13:32:06Z","pushed_at":"2018-05-15T03:25:35Z","git_url":"git://github.com/dalek-cryptography/curve25519-dalek.git","ssh_url":"git@github.com:dalek-cryptography/curve25519-dalek.git","clone_url":"https://github.com/dalek-cryptography/curve25519-dalek.git","svn_url":"https://github.com/dalek-cryptography/curve25519-dalek","homepage":"","size":1903,"stargazers_count":178,"watchers_count":178,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":33,"open_issues":14,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls/141"},"html":{"href":"https://github.com/dalek-cryptography/curve25519-dalek/pull/141"},"issue":{"href":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/issues/141"},"comments":{"href":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/dalek-cryptography/curve25519-dalek/statuses/b37f540ca8d2af5407467405bde15836e28ea5fb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"hdevalence"}}