{"push_id":3014705714,"size":1,"distinct_size":1,"ref":"refs/heads/2018-11-02-remove-v8-branch","head":"6afdcbeeb77789af1b003fbab6c3af98ef5b0391","before":"0d33c8717d0616ed78a9d79737ad81d73a43b9f7","commits":[{"sha":"6afdcbeeb77789af1b003fbab6c3af98ef5b0391","author":{"name":"Damien Lespiau","email":"99e6b749acbfbe2a596df99e91d24d6e1fdbee00@weave.works"},"message":"Don't use shallow clones for update the v8 submodule branch\n\nThe shallow setting this is the cause of those two errors:\n\nSubmodule 'depot_tools' (https://chromium.googlesource.com/chromium/tools/depot_tools.git) registered for path 'depot_tools'\nSubmodule 'v8' (https://github.com/v8/v8.git) registered for path 'v8'\nCloning into '/go/src/github.com/ry/v8worker2/depot_tools'...\nCloning into '/go/src/github.com/ry/v8worker2/v8'...\nFrom https://chromium.googlesource.com/chromium/tools/depot_tools\n * branch              f16fdf3165b8b86d10386d18a6b6075169c10e15 -> FETCH_HEAD\nerror: no such remote ref fe12316ec4b4a101923e395791ca55442e62f4cc\nFetched in submodule path 'v8', but it did not contain fe12316ec4b4a101923e395791ca55442e62f4cc. Direct fetching of that commit failed.\npackage github.com/ry/v8worker2: exit status 1\n\nand:\n\ndepot_tools update failed. Conflict in /go/src/github.com/dlespiau/v8worker2/depot_tools\n\nCurrent theory is that shallow clones aren't enough to find the right commit,\neven when specifying the right branch to look for it.\n\nSo:\n\n- Don't use shallow clones\n- Specify the right branch where to find 6.8 releases, this should help when\n  updating the submodule if one wants to follow the 6.8.x.y releases.\n\nFixes: #9","distinct":true,"url":"https://api.github.com/repos/dlespiau/v8worker2/commits/6afdcbeeb77789af1b003fbab6c3af98ef5b0391"}]}
{"actor":{"display_login":"dlespiau"}}