{"action":"created","issue":{"url":"https://api.github.com/repos/redhat-developer/odo/issues/856","repository_url":"https://api.github.com/repos/redhat-developer/odo","labels_url":"https://api.github.com/repos/redhat-developer/odo/issues/856/labels{/name}","comments_url":"https://api.github.com/repos/redhat-developer/odo/issues/856/comments","events_url":"https://api.github.com/repos/redhat-developer/odo/issues/856/events","html_url":"https://github.com/redhat-developer/odo/pull/856","id":372461390,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NjM1ODcz","number":856,"title":"Make link handling common across both components and services","user":{"login":"geoand","id":4374975,"node_id":"MDQ6VXNlcjQzNzQ5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"labels":[{"id":814000951,"node_id":"MDU6TGFiZWw4MTQwMDA5NTE=","url":"https://api.github.com/repos/redhat-developer/odo/labels/kind/enhancement","name":"kind/enhancement","color":"a2eeef","default":false},{"id":827801537,"node_id":"MDU6TGFiZWw4Mjc4MDE1Mzc=","url":"https://api.github.com/repos/redhat-developer/odo/labels/rebase%20needed","name":"rebase needed","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2018-10-22T10:04:56Z","updated_at":"2018-11-02T14:42:32Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/redhat-developer/odo/pulls/856","html_url":"https://github.com/redhat-developer/odo/pull/856","diff_url":"https://github.com/redhat-developer/odo/pull/856.diff","patch_url":"https://github.com/redhat-developer/odo/pull/856.patch"},"body":"This is done by making `link` always \"inject\" a secret into the\r\nDeploymentConfig of the source component.\r\nIn the case of services, the secret is created indirectly via the\r\nServiceBinding (this was implemented in #723).\r\nIn the case of components, the secret is created when when we create\r\nthe component. In such cases on secret is created per exposed port.\r\n\r\nFixes: #652 (see [this](https://github.com/redhat-developer/odo/issues/652#issuecomment-431317769) and [this](https://github.com/redhat-developer/odo/issues/652#issuecomment-431452720))\r\n\r\nTo test the changes:\r\n\r\nFor component to component linking:\r\n1. Create a backend application\r\n2. Create a frontend application\r\n3. `odo link --to-component backend`\r\n4. Exec into the frontend pod and make sure `COMPONENT_BACKEND_HOST=backend-app`\r\n\r\nFor component to service linking:\r\nFollow the same instructions that were used to test the existing component-to-service linking functionality. The only thing that changes in this case is that now `--to-service` needs to be supplied to `odo link`\r\n\r\nThe changes here are orthogonal to the ones in #847. There will probably need to be a PR rebase for whichever one is merged second :)\r\n"},"comment":{"url":"https://api.github.com/repos/redhat-developer/odo/issues/comments/435402478","html_url":"https://github.com/redhat-developer/odo/pull/856#issuecomment-435402478","issue_url":"https://api.github.com/repos/redhat-developer/odo/issues/856","id":435402478,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTQwMjQ3OA==","user":{"login":"kadel","id":57206,"node_id":"MDQ6VXNlcjU3MjA2","avatar_url":"https://avatars1.githubusercontent.com/u/57206?v=4","gravatar_id":"","url":"https://api.github.com/users/kadel","html_url":"https://github.com/kadel","followers_url":"https://api.github.com/users/kadel/followers","following_url":"https://api.github.com/users/kadel/following{/other_user}","gists_url":"https://api.github.com/users/kadel/gists{/gist_id}","starred_url":"https://api.github.com/users/kadel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadel/subscriptions","organizations_url":"https://api.github.com/users/kadel/orgs","repos_url":"https://api.github.com/users/kadel/repos","events_url":"https://api.github.com/users/kadel/events{/privacy}","received_events_url":"https://api.github.com/users/kadel/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T14:42:32Z","updated_at":"2018-11-02T14:42:32Z","author_association":"MEMBER","body":"> PR has been rebased.\r\n\r\nit needs another rebase :-( \r\n\r\n> \r\n> @jorgemoralespou @kadel Should we keep this open until the proposal about the linking is complete and then introduce all the missing functionality into this PR?\r\n\r\nIf we keep this PR open you will have to rebase it, again and again, that would be huge pain :-(\r\n\r\nThis PR can be the first step towards implementation using `access-info` primitive. I think that this can go in.\r\n\r\nBut there is one thing that I would definitely change here. That is `--to-service` `--to-component` flags. We don't have those flags in current odo version, and it looks like that almost everyone agrees that type should be automatically detected by odo. I don't want to introduce those flags and then in next version remove it. \r\n\r\n@geoand Do you think that you could look into adding autodetection whatever it is service or component that user wants to link to, so we can remove those flags?"}}
{"actor":{"display_login":"kadel"}}