{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/230522123","pull_request_review_id":171288736,"id":230522123,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDUyMjEyMw==","diff_hunk":"@@ -1349,11 +1350,15 @@ def hipify(\n     # Extract all of the kernel parameter and template type information.\n     if add_static_casts_option:\n         KernelTemplateParams = {}\n+        # ignore caffe2/utils/math_gpu.cu for static_casts as PowKernel\n+        # conflicts with kernel in caffe2/operators/pow_op.cu.\n+        # Need to figure out a long-term solution.\n         for filepath in all_files:\n-            get_kernel_template_params(\n-                filepath,\n-                KernelTemplateParams,\n-                CAFFE2_TEMPLATE_MAP if hipify_caffe2 else PYTORCH_TEMPLATE_MAP)\n+            if \"math_gpu.cu\" not in os.path.basename(filepath):","path":"tools/amd_build/pyHIPIFY/hipify_python.py","position":22,"original_position":22,"commit_id":"aa4514b2abfe8067d7b55b90e8f2f4dbdaa4375e","original_commit_id":"aa4514b2abfe8067d7b55b90e8f2f4dbdaa4375e","user":{"login":"bddppq","id":9300575,"node_id":"MDQ6VXNlcjkzMDA1NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9300575?v=4","gravatar_id":"","url":"https://api.github.com/users/bddppq","html_url":"https://github.com/bddppq","followers_url":"https://api.github.com/users/bddppq/followers","following_url":"https://api.github.com/users/bddppq/following{/other_user}","gists_url":"https://api.github.com/users/bddppq/gists{/gist_id}","starred_url":"https://api.github.com/users/bddppq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bddppq/subscriptions","organizations_url":"https://api.github.com/users/bddppq/orgs","repos_url":"https://api.github.com/users/bddppq/repos","events_url":"https://api.github.com/users/bddppq/events{/privacy}","received_events_url":"https://api.github.com/users/bddppq/received_events","type":"User","site_admin":false},"body":"Yep sgtm (but please add a comment there so people don't change it back)","created_at":"2018-11-02T22:12:00Z","updated_at":"2018-11-02T22:12:00Z","html_url":"https://github.com/pytorch/pytorch/pull/13521#discussion_r230522123","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/13521","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/230522123"},"html":{"href":"https://github.com/pytorch/pytorch/pull/13521#discussion_r230522123"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/13521"}},"in_reply_to_id":230489231},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/13521","id":228037674,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDM3Njc0","html_url":"https://github.com/pytorch/pytorch/pull/13521","diff_url":"https://github.com/pytorch/pytorch/pull/13521.diff","patch_url":"https://github.com/pytorch/pytorch/pull/13521.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/13521","number":13521,"state":"open","locked":false,"title":"Hipify caffe2/utils/math_gpu.cu","user":{"login":"rohithkrn","id":1936544,"node_id":"MDQ6VXNlcjE5MzY1NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1936544?v=4","gravatar_id":"","url":"https://api.github.com/users/rohithkrn","html_url":"https://github.com/rohithkrn","followers_url":"https://api.github.com/users/rohithkrn/followers","following_url":"https://api.github.com/users/rohithkrn/following{/other_user}","gists_url":"https://api.github.com/users/rohithkrn/gists{/gist_id}","starred_url":"https://api.github.com/users/rohithkrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohithkrn/subscriptions","organizations_url":"https://api.github.com/users/rohithkrn/orgs","repos_url":"https://api.github.com/users/rohithkrn/repos","events_url":"https://api.github.com/users/rohithkrn/events{/privacy}","received_events_url":"https://api.github.com/users/rohithkrn/received_events","type":"User","site_admin":false},"body":"This PR adds caffe2/utils/math_gpu.cu to pyHipify\r\n\r\n@bddppq @petrex ","created_at":"2018-11-02T19:29:46Z","updated_at":"2018-11-02T22:12:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8533c480793340814963276a05bdecc9b45d1066","assignee":null,"assignees":[],"requested_reviewers":[{"login":"BIT-silence","id":3357667,"node_id":"MDQ6VXNlcjMzNTc2Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/3357667?v=4","gravatar_id":"","url":"https://api.github.com/users/BIT-silence","html_url":"https://github.com/BIT-silence","followers_url":"https://api.github.com/users/BIT-silence/followers","following_url":"https://api.github.com/users/BIT-silence/following{/other_user}","gists_url":"https://api.github.com/users/BIT-silence/gists{/gist_id}","starred_url":"https://api.github.com/users/BIT-silence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BIT-silence/subscriptions","organizations_url":"https://api.github.com/users/BIT-silence/orgs","repos_url":"https://api.github.com/users/BIT-silence/repos","events_url":"https://api.github.com/users/BIT-silence/events{/privacy}","received_events_url":"https://api.github.com/users/BIT-silence/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1078897659,"node_id":"MDU6TGFiZWwxMDc4ODk3NjU5","url":"https://api.github.com/repos/pytorch/pytorch/labels/rocm","name":"rocm","color":"499cd1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/13521/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/13521/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/13521/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/aa4514b2abfe8067d7b55b90e8f2f4dbdaa4375e","head":{"label":"ROCmSoftwarePlatform:rn/hipify_math_util","ref":"rn/hipify_math_util","sha":"aa4514b2abfe8067d7b55b90e8f2f4dbdaa4375e","user":{"login":"ROCmSoftwarePlatform","id":16900697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTAwNjk3","avatar_url":"https://avatars0.githubusercontent.com/u/16900697?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCmSoftwarePlatform","html_url":"https://github.com/ROCmSoftwarePlatform","followers_url":"https://api.github.com/users/ROCmSoftwarePlatform/followers","following_url":"https://api.github.com/users/ROCmSoftwarePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ROCmSoftwarePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCmSoftwarePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCmSoftwarePlatform/subscriptions","organizations_url":"https://api.github.com/users/ROCmSoftwarePlatform/orgs","repos_url":"https://api.github.com/users/ROCmSoftwarePlatform/repos","events_url":"https://api.github.com/users/ROCmSoftwarePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ROCmSoftwarePlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":128132891,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxMzI4OTE=","name":"pytorch","full_name":"ROCmSoftwarePlatform/pytorch","private":false,"owner":{"login":"ROCmSoftwarePlatform","id":16900697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTAwNjk3","avatar_url":"https://avatars0.githubusercontent.com/u/16900697?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCmSoftwarePlatform","html_url":"https://github.com/ROCmSoftwarePlatform","followers_url":"https://api.github.com/users/ROCmSoftwarePlatform/followers","following_url":"https://api.github.com/users/ROCmSoftwarePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ROCmSoftwarePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCmSoftwarePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCmSoftwarePlatform/subscriptions","organizations_url":"https://api.github.com/users/ROCmSoftwarePlatform/orgs","repos_url":"https://api.github.com/users/ROCmSoftwarePlatform/repos","events_url":"https://api.github.com/users/ROCmSoftwarePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ROCmSoftwarePlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ROCmSoftwarePlatform/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch","forks_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/forks","keys_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/teams","hooks_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/hooks","issue_events_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/events","assignees_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/tags","blobs_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/languages","stargazers_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/stargazers","contributors_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/contributors","subscribers_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/subscribers","subscription_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/subscription","commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/merges","archive_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/downloads","issues_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/pytorch/deployments","created_at":"2018-04-04T23:08:21Z","updated_at":"2018-11-02T21:09:08Z","pushed_at":"2018-11-02T21:17:55Z","git_url":"git://github.com/ROCmSoftwarePlatform/pytorch.git","ssh_url":"git@github.com:ROCmSoftwarePlatform/pytorch.git","clone_url":"https://github.com/ROCmSoftwarePlatform/pytorch.git","svn_url":"https://github.com/ROCmSoftwarePlatform/pytorch","homepage":"http://pytorch.org","size":85937,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":23,"watchers":22,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"7b48a7c3f659f4749ebb612110879d4ffccd24e2","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-11-02T22:10:42Z","pushed_at":"2018-11-02T22:09:12Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":84643,"stargazers_count":20702,"watchers_count":20702,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4918,"mirror_url":null,"archived":false,"open_issues_count":2068,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4918,"open_issues":2068,"watchers":20702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/13521"},"html":{"href":"https://github.com/pytorch/pytorch/pull/13521"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/13521"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/13521/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/13521/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/13521/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/aa4514b2abfe8067d7b55b90e8f2f4dbdaa4375e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bddppq"}}