{"action":"closed","number":3334,"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3334","id":181021825,"html_url":"https://github.com/MarkUsProject/Markus/pull/3334","diff_url":"https://github.com/MarkUsProject/Markus/pull/3334.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/3334.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/3334","number":3334,"state":"closed","locked":false,"title":"js: always activate the selected rubric criterion mark","user":{"login":"mishaschwartz","id":4380924,"avatar_url":"https://avatars2.githubusercontent.com/u/4380924?v=4","gravatar_id":"","url":"https://api.github.com/users/mishaschwartz","html_url":"https://github.com/mishaschwartz","followers_url":"https://api.github.com/users/mishaschwartz/followers","following_url":"https://api.github.com/users/mishaschwartz/following{/other_user}","gists_url":"https://api.github.com/users/mishaschwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/mishaschwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishaschwartz/subscriptions","organizations_url":"https://api.github.com/users/mishaschwartz/orgs","repos_url":"https://api.github.com/users/mishaschwartz/repos","events_url":"https://api.github.com/users/mishaschwartz/events{/privacy}","received_events_url":"https://api.github.com/users/mishaschwartz/received_events","type":"User","site_admin":false},"body":"Pressing enter/return when a criterion mark is \"active\" will select the active criterion mark. \r\nHowever, selecting a criterion mark by clicking on it did not also mark it as \"active\".\r\nThis meant that it was possible to click on a criterion mark and then hit enter, which would select the previous mark since it was still marked as \"active\", effectively reverting the action taken by clicking.\r\n\r\nThis update ensures that clicking on a criterion mark (or selecting it in any way) also has the effect of marking the selected criterion mark as \"active\". \r\n\r\nFixes #3332 ","created_at":"2018-04-11T20:40:37Z","updated_at":"2018-04-12T21:03:52Z","closed_at":"2018-04-12T21:03:52Z","merged_at":"2018-04-12T21:03:52Z","merge_commit_sha":"687c65ed43e9eac8c01dc28644de7a49650b523c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3334/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3334/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/3334/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/97d70528fab70234c4ba661897dbb73f130b6859","head":{"label":"mishaschwartz:focus-selected-mark","ref":"focus-selected-mark","sha":"97d70528fab70234c4ba661897dbb73f130b6859","user":{"login":"mishaschwartz","id":4380924,"avatar_url":"https://avatars2.githubusercontent.com/u/4380924?v=4","gravatar_id":"","url":"https://api.github.com/users/mishaschwartz","html_url":"https://github.com/mishaschwartz","followers_url":"https://api.github.com/users/mishaschwartz/followers","following_url":"https://api.github.com/users/mishaschwartz/following{/other_user}","gists_url":"https://api.github.com/users/mishaschwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/mishaschwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishaschwartz/subscriptions","organizations_url":"https://api.github.com/users/mishaschwartz/orgs","repos_url":"https://api.github.com/users/mishaschwartz/repos","events_url":"https://api.github.com/users/mishaschwartz/events{/privacy}","received_events_url":"https://api.github.com/users/mishaschwartz/received_events","type":"User","site_admin":false},"repo":{"id":120653567,"name":"Markus","full_name":"mishaschwartz/Markus","owner":{"login":"mishaschwartz","id":4380924,"avatar_url":"https://avatars2.githubusercontent.com/u/4380924?v=4","gravatar_id":"","url":"https://api.github.com/users/mishaschwartz","html_url":"https://github.com/mishaschwartz","followers_url":"https://api.github.com/users/mishaschwartz/followers","following_url":"https://api.github.com/users/mishaschwartz/following{/other_user}","gists_url":"https://api.github.com/users/mishaschwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/mishaschwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishaschwartz/subscriptions","organizations_url":"https://api.github.com/users/mishaschwartz/orgs","repos_url":"https://api.github.com/users/mishaschwartz/repos","events_url":"https://api.github.com/users/mishaschwartz/events{/privacy}","received_events_url":"https://api.github.com/users/mishaschwartz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mishaschwartz/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/mishaschwartz/Markus","forks_url":"https://api.github.com/repos/mishaschwartz/Markus/forks","keys_url":"https://api.github.com/repos/mishaschwartz/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mishaschwartz/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mishaschwartz/Markus/teams","hooks_url":"https://api.github.com/repos/mishaschwartz/Markus/hooks","issue_events_url":"https://api.github.com/repos/mishaschwartz/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/mishaschwartz/Markus/events","assignees_url":"https://api.github.com/repos/mishaschwartz/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/mishaschwartz/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/mishaschwartz/Markus/tags","blobs_url":"https://api.github.com/repos/mishaschwartz/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mishaschwartz/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mishaschwartz/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/mishaschwartz/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mishaschwartz/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/mishaschwartz/Markus/languages","stargazers_url":"https://api.github.com/repos/mishaschwartz/Markus/stargazers","contributors_url":"https://api.github.com/repos/mishaschwartz/Markus/contributors","subscribers_url":"https://api.github.com/repos/mishaschwartz/Markus/subscribers","subscription_url":"https://api.github.com/repos/mishaschwartz/Markus/subscription","commits_url":"https://api.github.com/repos/mishaschwartz/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/mishaschwartz/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/mishaschwartz/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/mishaschwartz/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/mishaschwartz/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/mishaschwartz/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mishaschwartz/Markus/merges","archive_url":"https://api.github.com/repos/mishaschwartz/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mishaschwartz/Markus/downloads","issues_url":"https://api.github.com/repos/mishaschwartz/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/mishaschwartz/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/mishaschwartz/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/mishaschwartz/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mishaschwartz/Markus/labels{/name}","releases_url":"https://api.github.com/repos/mishaschwartz/Markus/releases{/id}","deployments_url":"https://api.github.com/repos/mishaschwartz/Markus/deployments","created_at":"2018-02-07T18:22:07Z","updated_at":"2018-02-07T18:22:17Z","pushed_at":"2018-04-12T15:21:35Z","git_url":"git://github.com/mishaschwartz/Markus.git","ssh_url":"git@github.com:mishaschwartz/Markus.git","clone_url":"https://github.com/mishaschwartz/Markus.git","svn_url":"https://github.com/mishaschwartz/Markus","homepage":"http://www.markusproject.org","size":114175,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkUsProject:master","ref":"master","sha":"84f5e7776320dc70e11a243b9cb1b299db113a4c","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars1.githubusercontent.com/u/415874?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars1.githubusercontent.com/u/415874?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","deployments_url":"https://api.github.com/repos/MarkUsProject/Markus/deployments","created_at":"2010-09-26T16:18:08Z","updated_at":"2018-04-12T20:35:04Z","pushed_at":"2018-04-12T21:03:52Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":114185,"stargazers_count":168,"watchers_count":168,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":191,"open_issues":112,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3334"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/3334"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/3334"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/3334/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3334/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3334/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/97d70528fab70234c4ba661897dbb73f130b6859"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"david-yz-liu","id":3333115,"avatar_url":"https://avatars2.githubusercontent.com/u/3333115?v=4","gravatar_id":"","url":"https://api.github.com/users/david-yz-liu","html_url":"https://github.com/david-yz-liu","followers_url":"https://api.github.com/users/david-yz-liu/followers","following_url":"https://api.github.com/users/david-yz-liu/following{/other_user}","gists_url":"https://api.github.com/users/david-yz-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/david-yz-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-yz-liu/subscriptions","organizations_url":"https://api.github.com/users/david-yz-liu/orgs","repos_url":"https://api.github.com/users/david-yz-liu/repos","events_url":"https://api.github.com/users/david-yz-liu/events{/privacy}","received_events_url":"https://api.github.com/users/david-yz-liu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"david-yz-liu"}}