{"action":"created","issue":{"url":"https://api.github.com/repos/govm-project/govm/issues/1","repository_url":"https://api.github.com/repos/govm-project/govm","labels_url":"https://api.github.com/repos/govm-project/govm/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/govm-project/govm/issues/1/comments","events_url":"https://api.github.com/repos/govm-project/govm/issues/1/events","html_url":"https://github.com/govm-project/govm/pull/1","id":369845922,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjc5MDMx","number":1,"title":"Add initial namespace support","user":{"login":"PeterCP","id":6062312,"node_id":"MDQ6VXNlcjYwNjIzMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6062312?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterCP","html_url":"https://github.com/PeterCP","followers_url":"https://api.github.com/users/PeterCP/followers","following_url":"https://api.github.com/users/PeterCP/following{/other_user}","gists_url":"https://api.github.com/users/PeterCP/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterCP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterCP/subscriptions","organizations_url":"https://api.github.com/users/PeterCP/orgs","repos_url":"https://api.github.com/users/PeterCP/repos","events_url":"https://api.github.com/users/PeterCP/events{/privacy}","received_events_url":"https://api.github.com/users/PeterCP/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-13T22:07:13Z","updated_at":"2018-10-16T00:15:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/govm-project/govm/pulls/1","html_url":"https://github.com/govm-project/govm/pull/1","diff_url":"https://github.com/govm-project/govm/pull/1.diff","patch_url":"https://github.com/govm-project/govm/pull/1.patch"},"body":"On machines with multiple users, each user can see other users' virtual\r\nmachines. This patch adds initial support for namespaces, which helps\r\ndivide VMs into individual users' namespaces. Also, VM containers will\r\nnow be named `govm.<namespace>.<VMName>` to more easily identify them as\r\ngovm VMs from `docker ps`. Additionally, `govm` commands now accept a\r\n`--namespace` flag to change namespaces, and the `govm list` command\r\nalso accepts a `--all` flag to list VMs from all namespaces. Note that\r\nthere is nothing stopping any user from creating or deleting VMs in\r\nanother user's namespace."},"comment":{"url":"https://api.github.com/repos/govm-project/govm/issues/comments/430057388","html_url":"https://github.com/govm-project/govm/pull/1#issuecomment-430057388","issue_url":"https://api.github.com/repos/govm-project/govm/issues/1","id":430057388,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDA1NzM4OA==","user":{"login":"PeterCP","id":6062312,"node_id":"MDQ6VXNlcjYwNjIzMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6062312?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterCP","html_url":"https://github.com/PeterCP","followers_url":"https://api.github.com/users/PeterCP/followers","following_url":"https://api.github.com/users/PeterCP/following{/other_user}","gists_url":"https://api.github.com/users/PeterCP/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterCP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterCP/subscriptions","organizations_url":"https://api.github.com/users/PeterCP/orgs","repos_url":"https://api.github.com/users/PeterCP/repos","events_url":"https://api.github.com/users/PeterCP/events{/privacy}","received_events_url":"https://api.github.com/users/PeterCP/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T00:15:40Z","updated_at":"2018-10-16T00:15:40Z","author_association":"NONE","body":"That probably happens because the change requires VMs to be created with the changed version. This is because the VM container receives two new labels: `vmName` and `namespace`. Now, when the list command doesn't receive the `--all` flag, it uses these labels to filter out containers by namespace by asking for a `namespace=<namespace>` label.\r\n\r\nWas the `devstack` VM created using the current `master` branch or was it created using the PR's branch? If it was created using `master` then it should be solved by renaming the container using the new format (e.g. `docker container rename devstack govm.<namespace>.<VMName>`). Note that the default namespace for a user is the user's username, so if your user's username is `erick0z` then you should rename the container with `docker rename devstack govm.erick0z.devstack`.\r\n\r\nNow, if the VM was created using the PR's branch, please tell me so I can figure out the problem."}}
{"actor":{"display_login":"PeterCP"}}