{"push_id":2431373197,"size":16,"distinct_size":3,"ref":"refs/heads/verify-build","head":"4165610e0eaf94e15ec240d822699d3e077db69d","before":"8903ac63bd97fe39dab3aea0ab72ffaf4a649d1f","commits":[{"sha":"668a4b36b94e8e22ecbe6bcea692041a9abcb0d0","author":{"name":"Aditya Pahuja","email":"a46204998c9aafdf9d2ce4bcda1e3dda980e0b48@digital.cabinet-office.gov.uk"},"message":"ABD-35: Upgrade to use latest version of rest-utils\n\nto support the ability to send encrypted events to either a source queue\nor a stub queue. If the source queue name is not present, encrypted\nevent messages will be sent to the stub queue. If the source queue is\npresent, encrypted event messages will be sent to the source queue. The\nstub queue will just write the encrypted event message to the standard\noutput.\n\nAuthors: @adityapahuja","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/668a4b36b94e8e22ecbe6bcea692041a9abcb0d0"},{"sha":"16e66c6731b70bcd406e43da20a0d500e25b8a17","author":{"name":"Michael Walker","email":"62f4787b62cfced9066cfb677e70831664a48e34@softwire.com"},"message":"Merge pull request #33 from alphagov/abd-35/update-to-send-events-to-stub-sqs\n\nABD-35: Upgrade to use latest version of rest-utils","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/16e66c6731b70bcd406e43da20a0d500e25b8a17"},{"sha":"188e72c14d2439d3c94b95f5819930eee1ed7035","author":{"name":"Christopher Holmes","email":"03fe63a3b3873f748839efe7f711e85c301a7bcf@digital.cabinet-office.gov.uk"},"message":"refactor: rewrite Response generator tests\n\nThese tests were broken and were not testing the right things. Fixes\ninclude:\n- Testing that we are actually encryption assertions (and including\nthem)\n- Testing that we are skipping signature when we don't want them (we\nwere actually signing before and then comparing with a message that had\na signature (not good!))\n- Test that we are using the right features for legacy and profile\nsupport (this wasn't being tested properly and the fact that we have\ncaching within saml-engine wasn't being caught)\n\n`ConfigStubRule` was also behaving awkwardly so I've rewritten it using\nwiremock, which should help us to migrate the rest of hub later.","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/188e72c14d2439d3c94b95f5819930eee1ed7035"},{"sha":"51daf00319ac7d8cd13938ad581c48b044d00ef9","author":{"name":"Christopher Holmes","email":"03fe63a3b3873f748839efe7f711e85c301a7bcf@digital.cabinet-office.gov.uk"},"message":"refactor: remove unused variable","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/51daf00319ac7d8cd13938ad581c48b044d00ef9"},{"sha":"ab622ea9132cca3100f61e45e680aeadc2ed16e2","author":{"name":"Christopher Holmes","email":"03fe63a3b3873f748839efe7f711e85c301a7bcf@digital.cabinet-office.gov.uk"},"message":"refactor: rename methods on ConfigStubRule","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/ab622ea9132cca3100f61e45e680aeadc2ed16e2"},{"sha":"36e2a272329ecaefeb5d5b16932fa8afdc4899e4","author":{"name":"thomasalanlee","email":"72ec5635e1a25668af52a1eea92e4a2db41b8b73@gmail.com"},"message":"Merge pull request #36 from alphagov/refactor_response_generator_test\n\nrefactor: rewrite Response generator tests","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/36e2a272329ecaefeb5d5b16932fa8afdc4899e4"},{"sha":"fce1643797be38086eced0efc1e5e7e05012ccf5","author":{"name":"Christopher Holmes","email":"03fe63a3b3873f748839efe7f711e85c301a7bcf@digital.cabinet-office.gov.uk"},"message":"refactor: assert metadata directly in tests\n\nrather than coverting to a custom Dto object and then comparing it's not\ndifficult to instead read the Saml object as an `EntityDescriptor` and\nthen assert on the things we care about.\n\nThis should allow us to delete a bunch of dead code in verify-hub-saml.","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/fce1643797be38086eced0efc1e5e7e05012ccf5"},{"sha":"81bfd9e5ce62b362333d1ae9eebb77cd67870f31","author":{"name":"Christopher Holmes","email":"03fe63a3b3873f748839efe7f711e85c301a7bcf@digital.cabinet-office.gov.uk"},"message":"refactor: optimize imports to appease import police","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/81bfd9e5ce62b362333d1ae9eebb77cd67870f31"},{"sha":"e26ee164ef2100918cc816330539540ddb354174","author":{"name":"Christopher Holmes","email":"03fe63a3b3873f748839efe7f711e85c301a7bcf@digital.cabinet-office.gov.uk"},"message":"refactor: check for null in test","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/e26ee164ef2100918cc816330539540ddb354174"},{"sha":"e280925cbc606b718afce316e422547fe063a3b9","author":{"name":"William Palmer","email":"491c25887c510937c39a9c053d5403a4884583bc@users.noreply.github.com"},"message":"Merge pull request #37 from alphagov/refactor_read_metadata_output_directly_in_tests\n\nrefactor: assert metadata directly in tests","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/e280925cbc606b718afce316e422547fe063a3b9"},{"sha":"d0d6ddc95f6631b9751700ab15f922153e44d725","author":{"name":"Minno Dang","email":"fbed492d5624867d61ab1bda366f679590546a71@digital.cabinet-office.gov.uk"},"message":"EID-430: Update verify-hub-saml to version 115\n\nUpdated and fixed following based on library updates\n- Using Java Util Optional rather than Google Common\n- Removal of saml-domain-objects mean we lose the\n  domain.core PersistentIdBuilder. But since we already have a\nsamlengine PersistentIdBuilder, we got it to build both.\n- Updated Usages of SAML Response DestinationValidators and\n  AssertionDecrypters\n- common-utils was removed from saml-serializers so we have to\n  explicitly set saml-proxy and saml-soap-proxy to depend on ida-utils\ndependencies.\n\nCo-authored-by: Felix Millne <felix.millne@digital.cabinet-office.gov.uk>","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/d0d6ddc95f6631b9751700ab15f922153e44d725"},{"sha":"867e6cafb84a1de3e1df93e4e7680d7b44a8f670","author":{"name":"Kornelis Sietsma","email":"a429e57ad8bca69bbd09d4cb035db80c42d6b105@digital.cabinet-office.gov.uk"},"message":"ABD21: upgrade to new event emitter to enable encryption\n\nsolo: @kornysietsma","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/867e6cafb84a1de3e1df93e4e7680d7b44a8f670"},{"sha":"3fbd024a0e89f65c0b6193e17b3bcbec818e29d0","author":{"name":"Rory Irvine","email":"a76581c1bfaeb258c25660c862963c7b12c6e467@users.noreply.github.com"},"message":"Merge pull request #39 from alphagov/abd21-update-event-emitter\n\nABD21: upgrade to new event emitter to enable encryption","distinct":false,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/3fbd024a0e89f65c0b6193e17b3bcbec818e29d0"},{"sha":"2984248f45e2afb1878366dce06ef7302efe5d31","author":{"name":"William Palmer","email":"8990e2d8d70ec1cacb72496fbc5fd83193ac814d@digital.cabinet-office.gov.uk"},"message":"remove ida-gradle & idea","distinct":true,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/2984248f45e2afb1878366dce06ef7302efe5d31"},{"sha":"f4dacede8163b34e2e229619a85503ecd3fa2a5a","author":{"name":"William Palmer","email":"8990e2d8d70ec1cacb72496fbc5fd83193ac814d@digital.cabinet-office.gov.uk"},"message":"build useful artefacts for verify-local-startup","distinct":true,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/f4dacede8163b34e2e229619a85503ecd3fa2a5a"},{"sha":"4165610e0eaf94e15ec240d822699d3e077db69d","author":{"name":"William Palmer","email":"8990e2d8d70ec1cacb72496fbc5fd83193ac814d@digital.cabinet-office.gov.uk"},"message":"set the version to the build number","distinct":true,"url":"https://api.github.com/repos/willp-bl/verify-hub/commits/4165610e0eaf94e15ec240d822699d3e077db69d"}]}
{"actor":{"display_login":"willp-bl"}}