{"action":"created","issue":{"url":"https://api.github.com/repos/apache/nifi/issues/2589","repository_url":"https://api.github.com/repos/apache/nifi","labels_url":"https://api.github.com/repos/apache/nifi/issues/2589/labels{/name}","comments_url":"https://api.github.com/repos/apache/nifi/issues/2589/comments","events_url":"https://api.github.com/repos/apache/nifi/issues/2589/events","html_url":"https://github.com/apache/nifi/pull/2589","id":309296269,"number":2589,"title":"NIFI-4993: Accept null user at querying ProvenanceRepository","user":{"login":"ijokarumawak","id":1107620,"avatar_url":"https://avatars1.githubusercontent.com/u/1107620?v=4","gravatar_id":"","url":"https://api.github.com/users/ijokarumawak","html_url":"https://github.com/ijokarumawak","followers_url":"https://api.github.com/users/ijokarumawak/followers","following_url":"https://api.github.com/users/ijokarumawak/following{/other_user}","gists_url":"https://api.github.com/users/ijokarumawak/gists{/gist_id}","starred_url":"https://api.github.com/users/ijokarumawak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijokarumawak/subscriptions","organizations_url":"https://api.github.com/users/ijokarumawak/orgs","repos_url":"https://api.github.com/users/ijokarumawak/repos","events_url":"https://api.github.com/users/ijokarumawak/events{/privacy}","received_events_url":"https://api.github.com/users/ijokarumawak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-28T09:52:29Z","updated_at":"2018-03-28T16:15:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/nifi/pulls/2589","html_url":"https://github.com/apache/nifi/pull/2589","diff_url":"https://github.com/apache/nifi/pull/2589.diff","patch_url":"https://github.com/apache/nifi/pull/2589.patch"},"body":"## For reviewer(s)\r\n\r\nPlease be aware that there is another major issue with 'complete path' strategy, that is #2542. It should be easier to confirm this fix if that PR is cherry-picked as well when you review this PR (in case if that one is not merged yet to master branch when you review this one).\r\n\r\n---\r\n\r\nBefore this fix, if provenance lineage is qualied by a user who does\r\nnot have 'view the data' plivilege for a component which emits\r\nprovenance events those create new FlowFile, then lineage computation stops\r\nat such component, instead of connecting other available events with\r\nthe created FlowFile lineage node. Expected edges are not created\r\nbecause PlaceholderProvenanceEvent returns 'UNKNOWN'\r\nevent type, edge population logics relying on that type do not work.\r\n\r\nThis PR modifies existing provenance repository implementations to accept 'null' NiFi user so that NiFi internal component can query lineage without NiFi user and authorization.\r\n\r\n---\r\n\r\nThank you for submitting a contribution to Apache NiFi.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced \r\n     in the commit message?\r\n\r\n- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n- [ ] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? \r\n- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?\r\n- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?\r\n- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?\r\n\r\n### For documentation related changes:\r\n- [x] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/nifi/issues/comments/376945756","html_url":"https://github.com/apache/nifi/pull/2589#issuecomment-376945756","issue_url":"https://api.github.com/repos/apache/nifi/issues/2589","id":376945756,"user":{"login":"markap14","id":184268,"avatar_url":"https://avatars2.githubusercontent.com/u/184268?v=4","gravatar_id":"","url":"https://api.github.com/users/markap14","html_url":"https://github.com/markap14","followers_url":"https://api.github.com/users/markap14/followers","following_url":"https://api.github.com/users/markap14/following{/other_user}","gists_url":"https://api.github.com/users/markap14/gists{/gist_id}","starred_url":"https://api.github.com/users/markap14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markap14/subscriptions","organizations_url":"https://api.github.com/users/markap14/orgs","repos_url":"https://api.github.com/users/markap14/repos","events_url":"https://api.github.com/users/markap14/events{/privacy}","received_events_url":"https://api.github.com/users/markap14/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T16:15:49Z","updated_at":"2018-03-28T16:15:49Z","author_association":"CONTRIBUTOR","body":"@ijokarumawak thanks for the latest updates. All looks good to me at this point. +1 merged to master."}}
{"actor":{"display_login":"markap14"}}