{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/cyrusimap/zeroskip/pulls/2","id":205868411,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODY4NDEx","html_url":"https://github.com/cyrusimap/zeroskip/pull/2","diff_url":"https://github.com/cyrusimap/zeroskip/pull/2.diff","patch_url":"https://github.com/cyrusimap/zeroskip/pull/2.patch","issue_url":"https://api.github.com/repos/cyrusimap/zeroskip/issues/2","number":2,"state":"open","locked":false,"title":"Build and silence warnings on Darwin (macOS)","user":{"login":"robn","id":130670,"node_id":"MDQ6VXNlcjEzMDY3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/130670?v=4","gravatar_id":"","url":"https://api.github.com/users/robn","html_url":"https://github.com/robn","followers_url":"https://api.github.com/users/robn/followers","following_url":"https://api.github.com/users/robn/following{/other_user}","gists_url":"https://api.github.com/users/robn/gists{/gist_id}","starred_url":"https://api.github.com/users/robn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robn/subscriptions","organizations_url":"https://api.github.com/users/robn/orgs","repos_url":"https://api.github.com/users/robn/repos","events_url":"https://api.github.com/users/robn/events{/privacy}","received_events_url":"https://api.github.com/users/robn/received_events","type":"User","site_admin":false},"body":"This gets it building and silences all but one warning on Darwin, as in:\r\n\r\n```\r\nConfigured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/4.2.1\r\nApple LLVM version 9.1.0 (clang-902.0.39.2)\r\nTarget: x86_64-apple-darwin17.6.0\r\nThread model: posix\r\nInstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin\r\n```\r\n\r\nIt seems to at least sort of work; using the `zeroskip` tool I can create a db and set/get a key. Tests `zst-abort-transaction` and `zst-fetchnext-simple` segfault, the others pass. I've not looked into why.\r\n\r\nI've not tested to see if this breaks compilation on other platforms.\r\n\r\nI highly encourage you to consider each commit separately; I've tried to leave good explanations in the commit messages. Most of them could probably be done in a better way, especially ones that flip feature defines or compiler attributes (configure should take care of more of that) or that play with the actual code (like strarray or struct stat changes).\r\n\r\nThere's one warning left that I can't figure out how to fix:\r\n\r\n```\r\nutil.c:194:35: warning: initializing 'char *const' with an expression of type\r\n      'const char [2]' discards qualifiers\r\n      [-Wincompatible-pointer-types-discards-qualifiers]\r\n        char *const def_path[] = {\".\", NULL};\r\n                                  ^~~\r\n```\r\n\r\n(and same in zeroskip.c).\r\n\r\nThere doesn't seem to be a sensible set of casts that will allow the string literal to be used here, and I haven't been able to find any other workaround (and I confess; I don't fully understand the complaint).\r\n\r\nThis was fun to do :)","created_at":"2018-08-02T21:36:33Z","updated_at":"2018-08-02T21:36:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cyrusimap/zeroskip/pulls/2/commits","review_comments_url":"https://api.github.com/repos/cyrusimap/zeroskip/pulls/2/comments","review_comment_url":"https://api.github.com/repos/cyrusimap/zeroskip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyrusimap/zeroskip/issues/2/comments","statuses_url":"https://api.github.com/repos/cyrusimap/zeroskip/statuses/f5c6059f70f7e165f8c3b4e45ff574f2de0d6c13","head":{"label":"robn:macos","ref":"macos","sha":"f5c6059f70f7e165f8c3b4e45ff574f2de0d6c13","user":{"login":"robn","id":130670,"node_id":"MDQ6VXNlcjEzMDY3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/130670?v=4","gravatar_id":"","url":"https://api.github.com/users/robn","html_url":"https://github.com/robn","followers_url":"https://api.github.com/users/robn/followers","following_url":"https://api.github.com/users/robn/following{/other_user}","gists_url":"https://api.github.com/users/robn/gists{/gist_id}","starred_url":"https://api.github.com/users/robn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robn/subscriptions","organizations_url":"https://api.github.com/users/robn/orgs","repos_url":"https://api.github.com/users/robn/repos","events_url":"https://api.github.com/users/robn/events{/privacy}","received_events_url":"https://api.github.com/users/robn/received_events","type":"User","site_admin":false},"repo":{"id":143215111,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyMTUxMTE=","name":"zeroskip","full_name":"robn/zeroskip","owner":{"login":"robn","id":130670,"node_id":"MDQ6VXNlcjEzMDY3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/130670?v=4","gravatar_id":"","url":"https://api.github.com/users/robn","html_url":"https://github.com/robn","followers_url":"https://api.github.com/users/robn/followers","following_url":"https://api.github.com/users/robn/following{/other_user}","gists_url":"https://api.github.com/users/robn/gists{/gist_id}","starred_url":"https://api.github.com/users/robn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robn/subscriptions","organizations_url":"https://api.github.com/users/robn/orgs","repos_url":"https://api.github.com/users/robn/repos","events_url":"https://api.github.com/users/robn/events{/privacy}","received_events_url":"https://api.github.com/users/robn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robn/zeroskip","description":"Zeroskip is a key-value database format.","fork":true,"url":"https://api.github.com/repos/robn/zeroskip","forks_url":"https://api.github.com/repos/robn/zeroskip/forks","keys_url":"https://api.github.com/repos/robn/zeroskip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robn/zeroskip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robn/zeroskip/teams","hooks_url":"https://api.github.com/repos/robn/zeroskip/hooks","issue_events_url":"https://api.github.com/repos/robn/zeroskip/issues/events{/number}","events_url":"https://api.github.com/repos/robn/zeroskip/events","assignees_url":"https://api.github.com/repos/robn/zeroskip/assignees{/user}","branches_url":"https://api.github.com/repos/robn/zeroskip/branches{/branch}","tags_url":"https://api.github.com/repos/robn/zeroskip/tags","blobs_url":"https://api.github.com/repos/robn/zeroskip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robn/zeroskip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robn/zeroskip/git/refs{/sha}","trees_url":"https://api.github.com/repos/robn/zeroskip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robn/zeroskip/statuses/{sha}","languages_url":"https://api.github.com/repos/robn/zeroskip/languages","stargazers_url":"https://api.github.com/repos/robn/zeroskip/stargazers","contributors_url":"https://api.github.com/repos/robn/zeroskip/contributors","subscribers_url":"https://api.github.com/repos/robn/zeroskip/subscribers","subscription_url":"https://api.github.com/repos/robn/zeroskip/subscription","commits_url":"https://api.github.com/repos/robn/zeroskip/commits{/sha}","git_commits_url":"https://api.github.com/repos/robn/zeroskip/git/commits{/sha}","comments_url":"https://api.github.com/repos/robn/zeroskip/comments{/number}","issue_comment_url":"https://api.github.com/repos/robn/zeroskip/issues/comments{/number}","contents_url":"https://api.github.com/repos/robn/zeroskip/contents/{+path}","compare_url":"https://api.github.com/repos/robn/zeroskip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robn/zeroskip/merges","archive_url":"https://api.github.com/repos/robn/zeroskip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robn/zeroskip/downloads","issues_url":"https://api.github.com/repos/robn/zeroskip/issues{/number}","pulls_url":"https://api.github.com/repos/robn/zeroskip/pulls{/number}","milestones_url":"https://api.github.com/repos/robn/zeroskip/milestones{/number}","notifications_url":"https://api.github.com/repos/robn/zeroskip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robn/zeroskip/labels{/name}","releases_url":"https://api.github.com/repos/robn/zeroskip/releases{/id}","deployments_url":"https://api.github.com/repos/robn/zeroskip/deployments","created_at":"2018-08-01T22:35:23Z","updated_at":"2018-08-01T22:35:24Z","pushed_at":"2018-08-02T21:19:08Z","git_url":"git://github.com/robn/zeroskip.git","ssh_url":"git@github.com:robn/zeroskip.git","clone_url":"https://github.com/robn/zeroskip.git","svn_url":"https://github.com/robn/zeroskip","homepage":"","size":500,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cyrusimap:master","ref":"master","sha":"4255d46fb57e67d8c6f9865298dd3cd5ca18dadb","user":{"login":"cyrusimap","id":19419965,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE5OTY1","avatar_url":"https://avatars2.githubusercontent.com/u/19419965?v=4","gravatar_id":"","url":"https://api.github.com/users/cyrusimap","html_url":"https://github.com/cyrusimap","followers_url":"https://api.github.com/users/cyrusimap/followers","following_url":"https://api.github.com/users/cyrusimap/following{/other_user}","gists_url":"https://api.github.com/users/cyrusimap/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrusimap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrusimap/subscriptions","organizations_url":"https://api.github.com/users/cyrusimap/orgs","repos_url":"https://api.github.com/users/cyrusimap/repos","events_url":"https://api.github.com/users/cyrusimap/events{/privacy}","received_events_url":"https://api.github.com/users/cyrusimap/received_events","type":"Organization","site_admin":false},"repo":{"id":118535812,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg1MzU4MTI=","name":"zeroskip","full_name":"cyrusimap/zeroskip","owner":{"login":"cyrusimap","id":19419965,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE5OTY1","avatar_url":"https://avatars2.githubusercontent.com/u/19419965?v=4","gravatar_id":"","url":"https://api.github.com/users/cyrusimap","html_url":"https://github.com/cyrusimap","followers_url":"https://api.github.com/users/cyrusimap/followers","following_url":"https://api.github.com/users/cyrusimap/following{/other_user}","gists_url":"https://api.github.com/users/cyrusimap/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrusimap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrusimap/subscriptions","organizations_url":"https://api.github.com/users/cyrusimap/orgs","repos_url":"https://api.github.com/users/cyrusimap/repos","events_url":"https://api.github.com/users/cyrusimap/events{/privacy}","received_events_url":"https://api.github.com/users/cyrusimap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyrusimap/zeroskip","description":"Zeroskip is a key-value database format.","fork":false,"url":"https://api.github.com/repos/cyrusimap/zeroskip","forks_url":"https://api.github.com/repos/cyrusimap/zeroskip/forks","keys_url":"https://api.github.com/repos/cyrusimap/zeroskip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyrusimap/zeroskip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyrusimap/zeroskip/teams","hooks_url":"https://api.github.com/repos/cyrusimap/zeroskip/hooks","issue_events_url":"https://api.github.com/repos/cyrusimap/zeroskip/issues/events{/number}","events_url":"https://api.github.com/repos/cyrusimap/zeroskip/events","assignees_url":"https://api.github.com/repos/cyrusimap/zeroskip/assignees{/user}","branches_url":"https://api.github.com/repos/cyrusimap/zeroskip/branches{/branch}","tags_url":"https://api.github.com/repos/cyrusimap/zeroskip/tags","blobs_url":"https://api.github.com/repos/cyrusimap/zeroskip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyrusimap/zeroskip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyrusimap/zeroskip/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyrusimap/zeroskip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyrusimap/zeroskip/statuses/{sha}","languages_url":"https://api.github.com/repos/cyrusimap/zeroskip/languages","stargazers_url":"https://api.github.com/repos/cyrusimap/zeroskip/stargazers","contributors_url":"https://api.github.com/repos/cyrusimap/zeroskip/contributors","subscribers_url":"https://api.github.com/repos/cyrusimap/zeroskip/subscribers","subscription_url":"https://api.github.com/repos/cyrusimap/zeroskip/subscription","commits_url":"https://api.github.com/repos/cyrusimap/zeroskip/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyrusimap/zeroskip/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyrusimap/zeroskip/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyrusimap/zeroskip/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyrusimap/zeroskip/contents/{+path}","compare_url":"https://api.github.com/repos/cyrusimap/zeroskip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyrusimap/zeroskip/merges","archive_url":"https://api.github.com/repos/cyrusimap/zeroskip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyrusimap/zeroskip/downloads","issues_url":"https://api.github.com/repos/cyrusimap/zeroskip/issues{/number}","pulls_url":"https://api.github.com/repos/cyrusimap/zeroskip/pulls{/number}","milestones_url":"https://api.github.com/repos/cyrusimap/zeroskip/milestones{/number}","notifications_url":"https://api.github.com/repos/cyrusimap/zeroskip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyrusimap/zeroskip/labels{/name}","releases_url":"https://api.github.com/repos/cyrusimap/zeroskip/releases{/id}","deployments_url":"https://api.github.com/repos/cyrusimap/zeroskip/deployments","created_at":"2018-01-23T00:49:17Z","updated_at":"2018-08-02T12:19:05Z","pushed_at":"2018-08-02T12:19:03Z","git_url":"git://github.com/cyrusimap/zeroskip.git","ssh_url":"git@github.com:cyrusimap/zeroskip.git","clone_url":"https://github.com/cyrusimap/zeroskip.git","svn_url":"https://github.com/cyrusimap/zeroskip","homepage":"","size":498,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyrusimap/zeroskip/pulls/2"},"html":{"href":"https://github.com/cyrusimap/zeroskip/pull/2"},"issue":{"href":"https://api.github.com/repos/cyrusimap/zeroskip/issues/2"},"comments":{"href":"https://api.github.com/repos/cyrusimap/zeroskip/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/cyrusimap/zeroskip/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/cyrusimap/zeroskip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyrusimap/zeroskip/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/cyrusimap/zeroskip/statuses/f5c6059f70f7e165f8c3b4e45ff574f2de0d6c13"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":14,"additions":60,"deletions":60,"changed_files":13}}
{"actor":{"display_login":"robn"}}