{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Scaffolding/pulls/comments/182852275","pull_request_review_id":113735062,"id":182852275,"diff_hunk":"@@ -0,0 +1,121 @@\n+<Project DefaultTarget=\"GenerateShims\">\n+  <Import Project=\"$(MSBuildThisFileDirectory)\\ShimGeneratorInner.targets\" />\n+\n+  <Target Name=\"BuildEmbedAppNameInHostTask\">\n+    <!--<Message Text=\"*** BuildEmbedAppNameInHostTask ***\" Importance=\"high\"/>-->\n+\n+    <MSBuild BuildInParallel=\"False\"\n+             Targets=\"Restore;Build\"","path":"tools/GlobalToolShimGenerator/ShimGenerator.targets","position":8,"original_position":8,"commit_id":"22137a0dfb88165de7bd4d7602effb8238ebc0b5","original_commit_id":"22137a0dfb88165de7bd4d7602effb8238ebc0b5","user":{"login":"natemcmaster","id":2696087,"avatar_url":"https://avatars0.githubusercontent.com/u/2696087?v=4","gravatar_id":"","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"body":"Can you ensure this works on a clean machine? It typically doesn't because there are targets that need to be imported after restore and the project needs to be re-evaluated.\r\n\r\nAlso, any reason this can't just run in the normal restore? I'm concerned we will passing in other important properties for restore.","created_at":"2018-04-19T19:01:29Z","updated_at":"2018-04-19T19:05:06Z","html_url":"https://github.com/aspnet/Scaffolding/pull/757#discussion_r182852275","pull_request_url":"https://api.github.com/repos/aspnet/Scaffolding/pulls/757","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Scaffolding/pulls/comments/182852275"},"html":{"href":"https://github.com/aspnet/Scaffolding/pull/757#discussion_r182852275"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Scaffolding/pulls/757"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Scaffolding/pulls/757","id":182838162,"html_url":"https://github.com/aspnet/Scaffolding/pull/757","diff_url":"https://github.com/aspnet/Scaffolding/pull/757.diff","patch_url":"https://github.com/aspnet/Scaffolding/pull/757.patch","issue_url":"https://api.github.com/repos/aspnet/Scaffolding/issues/757","number":757,"state":"open","locked":false,"title":"Pack pre generated shims in the scaffolding tool package","user":{"login":"prafullbhosale","id":1521254,"avatar_url":"https://avatars1.githubusercontent.com/u/1521254?v=4","gravatar_id":"","url":"https://api.github.com/users/prafullbhosale","html_url":"https://github.com/prafullbhosale","followers_url":"https://api.github.com/users/prafullbhosale/followers","following_url":"https://api.github.com/users/prafullbhosale/following{/other_user}","gists_url":"https://api.github.com/users/prafullbhosale/gists{/gist_id}","starred_url":"https://api.github.com/users/prafullbhosale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prafullbhosale/subscriptions","organizations_url":"https://api.github.com/users/prafullbhosale/orgs","repos_url":"https://api.github.com/users/prafullbhosale/repos","events_url":"https://api.github.com/users/prafullbhosale/events{/privacy}","received_events_url":"https://api.github.com/users/prafullbhosale/received_events","type":"User","site_admin":false},"body":"Addresses aspnet/universe/issues/1027","created_at":"2018-04-19T16:54:11Z","updated_at":"2018-04-19T19:05:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e694cbfc9e3454427fb641363eae968ca03f4b3a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Scaffolding/pulls/757/commits","review_comments_url":"https://api.github.com/repos/aspnet/Scaffolding/pulls/757/comments","review_comment_url":"https://api.github.com/repos/aspnet/Scaffolding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Scaffolding/issues/757/comments","statuses_url":"https://api.github.com/repos/aspnet/Scaffolding/statuses/22137a0dfb88165de7bd4d7602effb8238ebc0b5","head":{"label":"aspnet:pb/globaltoolshim","ref":"pb/globaltoolshim","sha":"22137a0dfb88165de7bd4d7602effb8238ebc0b5","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":21291278,"name":"Scaffolding","full_name":"aspnet/Scaffolding","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Scaffolding","description":"Code generators to speed up development.","fork":false,"url":"https://api.github.com/repos/aspnet/Scaffolding","forks_url":"https://api.github.com/repos/aspnet/Scaffolding/forks","keys_url":"https://api.github.com/repos/aspnet/Scaffolding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Scaffolding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Scaffolding/teams","hooks_url":"https://api.github.com/repos/aspnet/Scaffolding/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Scaffolding/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Scaffolding/events","assignees_url":"https://api.github.com/repos/aspnet/Scaffolding/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Scaffolding/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Scaffolding/tags","blobs_url":"https://api.github.com/repos/aspnet/Scaffolding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Scaffolding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Scaffolding/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Scaffolding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Scaffolding/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Scaffolding/languages","stargazers_url":"https://api.github.com/repos/aspnet/Scaffolding/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Scaffolding/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Scaffolding/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Scaffolding/subscription","commits_url":"https://api.github.com/repos/aspnet/Scaffolding/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Scaffolding/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Scaffolding/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Scaffolding/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Scaffolding/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Scaffolding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Scaffolding/merges","archive_url":"https://api.github.com/repos/aspnet/Scaffolding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Scaffolding/downloads","issues_url":"https://api.github.com/repos/aspnet/Scaffolding/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Scaffolding/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Scaffolding/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Scaffolding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Scaffolding/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Scaffolding/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Scaffolding/deployments","created_at":"2014-06-27T22:39:14Z","updated_at":"2018-04-18T21:26:03Z","pushed_at":"2018-04-19T18:04:50Z","git_url":"git://github.com/aspnet/Scaffolding.git","ssh_url":"git@github.com:aspnet/Scaffolding.git","clone_url":"https://github.com/aspnet/Scaffolding.git","svn_url":"https://github.com/aspnet/Scaffolding","homepage":"","size":3520,"stargazers_count":195,"watchers_count":195,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":79,"open_issues":117,"watchers":195,"default_branch":"dev"}},"base":{"label":"aspnet:release/2.1","ref":"release/2.1","sha":"729f698958c54e82e040d7e10a6b65398c706ac8","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":21291278,"name":"Scaffolding","full_name":"aspnet/Scaffolding","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Scaffolding","description":"Code generators to speed up development.","fork":false,"url":"https://api.github.com/repos/aspnet/Scaffolding","forks_url":"https://api.github.com/repos/aspnet/Scaffolding/forks","keys_url":"https://api.github.com/repos/aspnet/Scaffolding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Scaffolding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Scaffolding/teams","hooks_url":"https://api.github.com/repos/aspnet/Scaffolding/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Scaffolding/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Scaffolding/events","assignees_url":"https://api.github.com/repos/aspnet/Scaffolding/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Scaffolding/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Scaffolding/tags","blobs_url":"https://api.github.com/repos/aspnet/Scaffolding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Scaffolding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Scaffolding/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Scaffolding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Scaffolding/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Scaffolding/languages","stargazers_url":"https://api.github.com/repos/aspnet/Scaffolding/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Scaffolding/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Scaffolding/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Scaffolding/subscription","commits_url":"https://api.github.com/repos/aspnet/Scaffolding/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Scaffolding/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Scaffolding/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Scaffolding/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Scaffolding/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Scaffolding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Scaffolding/merges","archive_url":"https://api.github.com/repos/aspnet/Scaffolding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Scaffolding/downloads","issues_url":"https://api.github.com/repos/aspnet/Scaffolding/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Scaffolding/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Scaffolding/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Scaffolding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Scaffolding/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Scaffolding/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Scaffolding/deployments","created_at":"2014-06-27T22:39:14Z","updated_at":"2018-04-18T21:26:03Z","pushed_at":"2018-04-19T18:04:50Z","git_url":"git://github.com/aspnet/Scaffolding.git","ssh_url":"git@github.com:aspnet/Scaffolding.git","clone_url":"https://github.com/aspnet/Scaffolding.git","svn_url":"https://github.com/aspnet/Scaffolding","homepage":"","size":3520,"stargazers_count":195,"watchers_count":195,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":79,"open_issues":117,"watchers":195,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Scaffolding/pulls/757"},"html":{"href":"https://github.com/aspnet/Scaffolding/pull/757"},"issue":{"href":"https://api.github.com/repos/aspnet/Scaffolding/issues/757"},"comments":{"href":"https://api.github.com/repos/aspnet/Scaffolding/issues/757/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Scaffolding/pulls/757/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Scaffolding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Scaffolding/pulls/757/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Scaffolding/statuses/22137a0dfb88165de7bd4d7602effb8238ebc0b5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"natemcmaster"}}