{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/206064832","pull_request_review_id":141451125,"id":206064832,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjA2NDgzMg==","diff_hunk":"@@ -181,6 +181,22 @@ def get_ps_output():\n         assert len(get_ps_output().split()) <= 4, 'UCR app has more than 4 processes running in its pid namespace'\n \n \n+def test_memory_profiling(dcos_api_session):\n+    # Test that we can fetch raw memory profiles\n+    master_ip = dcos_api_session.masters[0]\n+    r0 = dcos_api_session.get(\n+        '/memory-profiler/start', host=master_ip, port=5050)\n+    assert r0.status_code == 200","path":"packages/dcos-integration-test/extra/test_mesos.py","position":null,"original_position":9,"commit_id":"ac67a238748e8a0c1fc57a0ba5667986c97d3870","original_commit_id":"e4782e903d19de5eca9bb0d5604975e0e881cdcc","user":{"login":"lava","id":51410,"node_id":"MDQ6VXNlcjUxNDEw","avatar_url":"https://avatars1.githubusercontent.com/u/51410?v=4","gravatar_id":"","url":"https://api.github.com/users/lava","html_url":"https://github.com/lava","followers_url":"https://api.github.com/users/lava/followers","following_url":"https://api.github.com/users/lava/following{/other_user}","gists_url":"https://api.github.com/users/lava/gists{/gist_id}","starred_url":"https://api.github.com/users/lava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lava/subscriptions","organizations_url":"https://api.github.com/users/lava/orgs","repos_url":"https://api.github.com/users/lava/repos","events_url":"https://api.github.com/users/lava/events{/privacy}","received_events_url":"https://api.github.com/users/lava/received_events","type":"User","site_admin":false},"body":"Ok, done.","created_at":"2018-07-30T09:17:55Z","updated_at":"2018-07-30T09:17:55Z","html_url":"https://github.com/dcos/dcos/pull/3123#discussion_r206064832","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/3123","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/206064832"},"html":{"href":"https://github.com/dcos/dcos/pull/3123#discussion_r206064832"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/3123"}},"in_reply_to_id":205761023},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/3123","id":202535649,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTM1NjQ5","html_url":"https://github.com/dcos/dcos/pull/3123","diff_url":"https://github.com/dcos/dcos/pull/3123.diff","patch_url":"https://github.com/dcos/dcos/pull/3123.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/3123","number":3123,"state":"open","locked":false,"title":"Enable Mesos jemalloc and memory profiling support in DC/OS","user":{"login":"lava","id":51410,"node_id":"MDQ6VXNlcjUxNDEw","avatar_url":"https://avatars1.githubusercontent.com/u/51410?v=4","gravatar_id":"","url":"https://api.github.com/users/lava","html_url":"https://github.com/lava","followers_url":"https://api.github.com/users/lava/followers","following_url":"https://api.github.com/users/lava/following{/other_user}","gists_url":"https://api.github.com/users/lava/gists{/gist_id}","starred_url":"https://api.github.com/users/lava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lava/subscriptions","organizations_url":"https://api.github.com/users/lava/orgs","repos_url":"https://api.github.com/users/lava/repos","events_url":"https://api.github.com/users/lava/events{/privacy}","received_events_url":"https://api.github.com/users/lava/received_events","type":"User","site_admin":false},"body":"\r\n## High-level description\r\n\r\nThis pull request enables usage of the memory profiling support that was introduced with Mesos 1.6.\r\n\r\nIt consists of three commits:\r\n - The first consists of preparatory cleanup work\r\n - The second changes the Mesos build to use the jemalloc memory allocator by default, to improve general performance of the `mesos-master` and `mesos-agent` binaries.\r\n- The third enables support for capturing memory profiles using a libprocess endpoint.\r\n\r\n## Corresponding DC/OS tickets (obligatory)\r\n\r\nThese DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:\r\n\r\n  - [DCOS_OSS-2137](https://jira.mesosphere.com/browse/DCOS_OSS-2137) Enable Mesos memory profiling in DC/OS images.\r\n\r\n\r\n## Checklist for all PRs\r\n\r\n  - [x] Added a comprehensible changelog entry to `CHANGES.md` or explain why this is not a user-facing change:\r\n  - [x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here: \r\n  - [x] Read the [DC/OS contributing guidelines](https://github.com/dcos/dcos/blob/master/contributing.md)\r\n  - [x] Followed relevant code rules [Rules for Packages and Systemd](https://github.com/dcos/dcos/tree/master/docs)\r\n\r\n\r\n## Checklist for component/package updates:\r\n\r\nIf you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath `packages`), then in addition to the above please also include:\r\n\r\n  - [ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): [example](https://github.com/dcos/dcos-mesos-modules/compare/f6fa27d7c40f4207ba3bb2274e2cfe79b62a395a...6660b90fbbf69a15ef46d0184e36755881d6a5ae)\r\n  - [ ] Test Results: [link to CI job test results for component]\r\n  - [ ] Code Coverage (if available): [link to code coverage report]\r\n___\r\n**PLEASE FILL IN THE TEMPLATE ABOVE** / **DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE**\r\n\r\n\r\n## Instructions and review process\r\n\r\n**What is the review process and when will my changes land?**\r\n\r\nAll PRs require 2 approvals using GitHub's [pull request reviews](https://help.github.com/articles/about-pull-request-reviews/).\r\n\r\nReviewers should be:\r\n* Developers who understand the code being modified.\r\n* Developers responsible for code that interacts with or depends on the code being modified.\r\n\r\nIt is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has **2 ship-it's**, **no red reviews**, and **all tests are green** it will be included in the [next train](https://github.com/dcos/dcos/blob/master/contributing.md).","created_at":"2018-07-19T11:58:10Z","updated_at":"2018-07-30T09:17:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2186a9487ac5dcf6685f465099ad505edc432bdb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":364878184,"node_id":"MDU6TGFiZWwzNjQ4NzgxODQ=","url":"https://api.github.com/repos/dcos/dcos/labels/Ready%20For%20Review","name":"Ready For Review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/3123/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/3123/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/3123/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/ac67a238748e8a0c1fc57a0ba5667986c97d3870","head":{"label":"lava:bevers/jemalloc","ref":"bevers/jemalloc","sha":"ac67a238748e8a0c1fc57a0ba5667986c97d3870","user":{"login":"lava","id":51410,"node_id":"MDQ6VXNlcjUxNDEw","avatar_url":"https://avatars1.githubusercontent.com/u/51410?v=4","gravatar_id":"","url":"https://api.github.com/users/lava","html_url":"https://github.com/lava","followers_url":"https://api.github.com/users/lava/followers","following_url":"https://api.github.com/users/lava/following{/other_user}","gists_url":"https://api.github.com/users/lava/gists{/gist_id}","starred_url":"https://api.github.com/users/lava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lava/subscriptions","organizations_url":"https://api.github.com/users/lava/orgs","repos_url":"https://api.github.com/users/lava/repos","events_url":"https://api.github.com/users/lava/events{/privacy}","received_events_url":"https://api.github.com/users/lava/received_events","type":"User","site_admin":false},"repo":{"id":141564628,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1NjQ2Mjg=","name":"dcos","full_name":"lava/dcos","owner":{"login":"lava","id":51410,"node_id":"MDQ6VXNlcjUxNDEw","avatar_url":"https://avatars1.githubusercontent.com/u/51410?v=4","gravatar_id":"","url":"https://api.github.com/users/lava","html_url":"https://github.com/lava","followers_url":"https://api.github.com/users/lava/followers","following_url":"https://api.github.com/users/lava/following{/other_user}","gists_url":"https://api.github.com/users/lava/gists{/gist_id}","starred_url":"https://api.github.com/users/lava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lava/subscriptions","organizations_url":"https://api.github.com/users/lava/orgs","repos_url":"https://api.github.com/users/lava/repos","events_url":"https://api.github.com/users/lava/events{/privacy}","received_events_url":"https://api.github.com/users/lava/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lava/dcos","description":"DC/OS - The Datacenter Operating System ","fork":true,"url":"https://api.github.com/repos/lava/dcos","forks_url":"https://api.github.com/repos/lava/dcos/forks","keys_url":"https://api.github.com/repos/lava/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lava/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lava/dcos/teams","hooks_url":"https://api.github.com/repos/lava/dcos/hooks","issue_events_url":"https://api.github.com/repos/lava/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/lava/dcos/events","assignees_url":"https://api.github.com/repos/lava/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/lava/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/lava/dcos/tags","blobs_url":"https://api.github.com/repos/lava/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lava/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lava/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/lava/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lava/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/lava/dcos/languages","stargazers_url":"https://api.github.com/repos/lava/dcos/stargazers","contributors_url":"https://api.github.com/repos/lava/dcos/contributors","subscribers_url":"https://api.github.com/repos/lava/dcos/subscribers","subscription_url":"https://api.github.com/repos/lava/dcos/subscription","commits_url":"https://api.github.com/repos/lava/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/lava/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/lava/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/lava/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/lava/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/lava/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lava/dcos/merges","archive_url":"https://api.github.com/repos/lava/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lava/dcos/downloads","issues_url":"https://api.github.com/repos/lava/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/lava/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/lava/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/lava/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lava/dcos/labels{/name}","releases_url":"https://api.github.com/repos/lava/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/lava/dcos/deployments","created_at":"2018-07-19T10:35:38Z","updated_at":"2018-07-19T10:35:41Z","pushed_at":"2018-07-30T09:17:25Z","git_url":"git://github.com/lava/dcos.git","ssh_url":"git@github.com:lava/dcos.git","clone_url":"https://github.com/lava/dcos.git","svn_url":"https://github.com/lava/dcos","homepage":"https://dcos.io","size":6500,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"f0bbf773ab37c8ec0a377a3d552e49863ff378c2","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"node_id":"MDEwOlJlcG9zaXRvcnk1NjE4NDA1MA==","name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS - The Datacenter Operating System ","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2018-07-30T03:27:57Z","pushed_at":"2018-07-30T09:17:27Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":6535,"stargazers_count":2012,"watchers_count":2012,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":403,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":403,"open_issues":111,"watchers":2012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/3123"},"html":{"href":"https://github.com/dcos/dcos/pull/3123"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/3123"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/3123/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/3123/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/3123/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/ac67a238748e8a0c1fc57a0ba5667986c97d3870"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lava"}}