{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/osquery/pulls/comments/188886174","pull_request_review_id":120952112,"id":188886174,"diff_hunk":"@@ -0,0 +1,70 @@\n+/**\n+ *  Copyright (c) 2018-present, Facebook, Inc.\n+ *  All rights reserved.\n+ *\n+ *  This source code is licensed under both the Apache 2.0 license (found in the\n+ *  LICENSE file in the root directory of this source tree) and the GPLv2 (found\n+ *  in the COPYING file in the root directory of this source tree).\n+ *  You may select, at your option, one of the above-listed licenses.\n+ */\n+\n+#pragma once\n+\n+#include <string>\n+\n+namespace osquery {\n+class Status;\n+\n+class Error {","path":"include/osquery/error.h","position":18,"original_position":18,"commit_id":"9e8a05e4bed585a9c006360a8db8237adf7e762a","original_commit_id":"9e8a05e4bed585a9c006360a8db8237adf7e762a","user":{"login":"akindyakov","id":2223470,"avatar_url":"https://avatars1.githubusercontent.com/u/2223470?v=4","gravatar_id":"","url":"https://api.github.com/users/akindyakov","html_url":"https://github.com/akindyakov","followers_url":"https://api.github.com/users/akindyakov/followers","following_url":"https://api.github.com/users/akindyakov/following{/other_user}","gists_url":"https://api.github.com/users/akindyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/akindyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akindyakov/subscriptions","organizations_url":"https://api.github.com/users/akindyakov/orgs","repos_url":"https://api.github.com/users/akindyakov/repos","events_url":"https://api.github.com/users/akindyakov/events{/privacy}","received_events_url":"https://api.github.com/users/akindyakov/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2018-05-17T09:02:51Z","updated_at":"2018-05-17T09:02:52Z","html_url":"https://github.com/facebook/osquery/pull/4396#discussion_r188886174","pull_request_url":"https://api.github.com/repos/facebook/osquery/pulls/4396","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/188886174"},"html":{"href":"https://github.com/facebook/osquery/pull/4396#discussion_r188886174"},"pull_request":{"href":"https://api.github.com/repos/facebook/osquery/pulls/4396"}},"in_reply_to_id":188689409},"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/4396","id":188422909,"html_url":"https://github.com/facebook/osquery/pull/4396","diff_url":"https://github.com/facebook/osquery/pull/4396.diff","patch_url":"https://github.com/facebook/osquery/pull/4396.patch","issue_url":"https://api.github.com/repos/facebook/osquery/issues/4396","number":4396,"state":"open","locked":false,"title":"osquery::Error && osquery::Expected","user":{"login":"mkareta","id":1892895,"avatar_url":"https://avatars2.githubusercontent.com/u/1892895?v=4","gravatar_id":"","url":"https://api.github.com/users/mkareta","html_url":"https://github.com/mkareta","followers_url":"https://api.github.com/users/mkareta/followers","following_url":"https://api.github.com/users/mkareta/following{/other_user}","gists_url":"https://api.github.com/users/mkareta/gists{/gist_id}","starred_url":"https://api.github.com/users/mkareta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkareta/subscriptions","organizations_url":"https://api.github.com/users/mkareta/orgs","repos_url":"https://api.github.com/users/mkareta/repos","events_url":"https://api.github.com/users/mkareta/events{/privacy}","received_events_url":"https://api.github.com/users/mkareta/received_events","type":"User","site_admin":false},"body":"Added new class for specifing errors that includes error domain, code, message and underlying error.\r\nAdded new class Expected fot fucntions that return either result or error. \r\n\r\n","created_at":"2018-05-16T12:55:25Z","updated_at":"2018-05-17T09:02:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4595df5f28fcd5ce7191b26bb15851de73fe0183","assignee":{"login":"mkareta","id":1892895,"avatar_url":"https://avatars2.githubusercontent.com/u/1892895?v=4","gravatar_id":"","url":"https://api.github.com/users/mkareta","html_url":"https://github.com/mkareta","followers_url":"https://api.github.com/users/mkareta/followers","following_url":"https://api.github.com/users/mkareta/following{/other_user}","gists_url":"https://api.github.com/users/mkareta/gists{/gist_id}","starred_url":"https://api.github.com/users/mkareta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkareta/subscriptions","organizations_url":"https://api.github.com/users/mkareta/orgs","repos_url":"https://api.github.com/users/mkareta/repos","events_url":"https://api.github.com/users/mkareta/events{/privacy}","received_events_url":"https://api.github.com/users/mkareta/received_events","type":"User","site_admin":false},"assignees":[{"login":"mkareta","id":1892895,"avatar_url":"https://avatars2.githubusercontent.com/u/1892895?v=4","gravatar_id":"","url":"https://api.github.com/users/mkareta","html_url":"https://github.com/mkareta","followers_url":"https://api.github.com/users/mkareta/followers","following_url":"https://api.github.com/users/mkareta/following{/other_user}","gists_url":"https://api.github.com/users/mkareta/gists{/gist_id}","starred_url":"https://api.github.com/users/mkareta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkareta/subscriptions","organizations_url":"https://api.github.com/users/mkareta/orgs","repos_url":"https://api.github.com/users/mkareta/repos","events_url":"https://api.github.com/users/mkareta/events{/privacy}","received_events_url":"https://api.github.com/users/mkareta/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"muffins","id":1328916,"avatar_url":"https://avatars1.githubusercontent.com/u/1328916?v=4","gravatar_id":"","url":"https://api.github.com/users/muffins","html_url":"https://github.com/muffins","followers_url":"https://api.github.com/users/muffins/followers","following_url":"https://api.github.com/users/muffins/following{/other_user}","gists_url":"https://api.github.com/users/muffins/gists{/gist_id}","starred_url":"https://api.github.com/users/muffins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffins/subscriptions","organizations_url":"https://api.github.com/users/muffins/orgs","repos_url":"https://api.github.com/users/muffins/repos","events_url":"https://api.github.com/users/muffins/events{/privacy}","received_events_url":"https://api.github.com/users/muffins/received_events","type":"User","site_admin":false},{"login":"fmanco","id":1463347,"avatar_url":"https://avatars3.githubusercontent.com/u/1463347?v=4","gravatar_id":"","url":"https://api.github.com/users/fmanco","html_url":"https://github.com/fmanco","followers_url":"https://api.github.com/users/fmanco/followers","following_url":"https://api.github.com/users/fmanco/following{/other_user}","gists_url":"https://api.github.com/users/fmanco/gists{/gist_id}","starred_url":"https://api.github.com/users/fmanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmanco/subscriptions","organizations_url":"https://api.github.com/users/fmanco/orgs","repos_url":"https://api.github.com/users/fmanco/repos","events_url":"https://api.github.com/users/fmanco/events{/privacy}","received_events_url":"https://api.github.com/users/fmanco/received_events","type":"User","site_admin":false},{"login":"obelisk","id":2386877,"avatar_url":"https://avatars1.githubusercontent.com/u/2386877?v=4","gravatar_id":"","url":"https://api.github.com/users/obelisk","html_url":"https://github.com/obelisk","followers_url":"https://api.github.com/users/obelisk/followers","following_url":"https://api.github.com/users/obelisk/following{/other_user}","gists_url":"https://api.github.com/users/obelisk/gists{/gist_id}","starred_url":"https://api.github.com/users/obelisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obelisk/subscriptions","organizations_url":"https://api.github.com/users/obelisk/orgs","repos_url":"https://api.github.com/users/obelisk/repos","events_url":"https://api.github.com/users/obelisk/events{/privacy}","received_events_url":"https://api.github.com/users/obelisk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196858822,"url":"https://api.github.com/repos/facebook/osquery/labels/cla%20signed","name":"cla signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/osquery/pulls/4396/commits","review_comments_url":"https://api.github.com/repos/facebook/osquery/pulls/4396/comments","review_comment_url":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/4396/comments","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/9e8a05e4bed585a9c006360a8db8237adf7e762a","head":{"label":"mkareta:expected","ref":"expected","sha":"9e8a05e4bed585a9c006360a8db8237adf7e762a","user":{"login":"mkareta","id":1892895,"avatar_url":"https://avatars2.githubusercontent.com/u/1892895?v=4","gravatar_id":"","url":"https://api.github.com/users/mkareta","html_url":"https://github.com/mkareta","followers_url":"https://api.github.com/users/mkareta/followers","following_url":"https://api.github.com/users/mkareta/following{/other_user}","gists_url":"https://api.github.com/users/mkareta/gists{/gist_id}","starred_url":"https://api.github.com/users/mkareta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkareta/subscriptions","organizations_url":"https://api.github.com/users/mkareta/orgs","repos_url":"https://api.github.com/users/mkareta/repos","events_url":"https://api.github.com/users/mkareta/events{/privacy}","received_events_url":"https://api.github.com/users/mkareta/received_events","type":"User","site_admin":false},"repo":{"id":128243524,"name":"osquery","full_name":"mkareta/osquery","owner":{"login":"mkareta","id":1892895,"avatar_url":"https://avatars2.githubusercontent.com/u/1892895?v=4","gravatar_id":"","url":"https://api.github.com/users/mkareta","html_url":"https://github.com/mkareta","followers_url":"https://api.github.com/users/mkareta/followers","following_url":"https://api.github.com/users/mkareta/following{/other_user}","gists_url":"https://api.github.com/users/mkareta/gists{/gist_id}","starred_url":"https://api.github.com/users/mkareta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkareta/subscriptions","organizations_url":"https://api.github.com/users/mkareta/orgs","repos_url":"https://api.github.com/users/mkareta/repos","events_url":"https://api.github.com/users/mkareta/events{/privacy}","received_events_url":"https://api.github.com/users/mkareta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkareta/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":true,"url":"https://api.github.com/repos/mkareta/osquery","forks_url":"https://api.github.com/repos/mkareta/osquery/forks","keys_url":"https://api.github.com/repos/mkareta/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkareta/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkareta/osquery/teams","hooks_url":"https://api.github.com/repos/mkareta/osquery/hooks","issue_events_url":"https://api.github.com/repos/mkareta/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/mkareta/osquery/events","assignees_url":"https://api.github.com/repos/mkareta/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/mkareta/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/mkareta/osquery/tags","blobs_url":"https://api.github.com/repos/mkareta/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkareta/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkareta/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkareta/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkareta/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/mkareta/osquery/languages","stargazers_url":"https://api.github.com/repos/mkareta/osquery/stargazers","contributors_url":"https://api.github.com/repos/mkareta/osquery/contributors","subscribers_url":"https://api.github.com/repos/mkareta/osquery/subscribers","subscription_url":"https://api.github.com/repos/mkareta/osquery/subscription","commits_url":"https://api.github.com/repos/mkareta/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkareta/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkareta/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkareta/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkareta/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/mkareta/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkareta/osquery/merges","archive_url":"https://api.github.com/repos/mkareta/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkareta/osquery/downloads","issues_url":"https://api.github.com/repos/mkareta/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/mkareta/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/mkareta/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/mkareta/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkareta/osquery/labels{/name}","releases_url":"https://api.github.com/repos/mkareta/osquery/releases{/id}","deployments_url":"https://api.github.com/repos/mkareta/osquery/deployments","created_at":"2018-04-05T17:52:18Z","updated_at":"2018-04-29T11:08:58Z","pushed_at":"2018-05-16T12:37:35Z","git_url":"git://github.com/mkareta/osquery.git","ssh_url":"git@github.com:mkareta/osquery.git","clone_url":"https://github.com/mkareta/osquery.git","svn_url":"https://github.com/mkareta/osquery","homepage":"https://osquery.io","size":14707,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"fa9615730179130e1e2819870bb0d7195b87cebe","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":22394357,"name":"osquery","full_name":"facebook/osquery","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":false,"url":"https://api.github.com/repos/facebook/osquery","forks_url":"https://api.github.com/repos/facebook/osquery/forks","keys_url":"https://api.github.com/repos/facebook/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/osquery/teams","hooks_url":"https://api.github.com/repos/facebook/osquery/hooks","issue_events_url":"https://api.github.com/repos/facebook/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/osquery/events","assignees_url":"https://api.github.com/repos/facebook/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/osquery/tags","blobs_url":"https://api.github.com/repos/facebook/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/osquery/languages","stargazers_url":"https://api.github.com/repos/facebook/osquery/stargazers","contributors_url":"https://api.github.com/repos/facebook/osquery/contributors","subscribers_url":"https://api.github.com/repos/facebook/osquery/subscribers","subscription_url":"https://api.github.com/repos/facebook/osquery/subscription","commits_url":"https://api.github.com/repos/facebook/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/osquery/merges","archive_url":"https://api.github.com/repos/facebook/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/osquery/downloads","issues_url":"https://api.github.com/repos/facebook/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/osquery/labels{/name}","releases_url":"https://api.github.com/repos/facebook/osquery/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/osquery/deployments","created_at":"2014-07-29T20:27:33Z","updated_at":"2018-05-17T08:45:42Z","pushed_at":"2018-05-17T06:50:04Z","git_url":"git://github.com/facebook/osquery.git","ssh_url":"git@github.com:facebook/osquery.git","clone_url":"https://github.com/facebook/osquery.git","svn_url":"https://github.com/facebook/osquery","homepage":"https://osquery.io","size":14699,"stargazers_count":12336,"watchers_count":12336,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1389,"mirror_url":null,"archived":false,"open_issues_count":229,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1389,"open_issues":229,"watchers":12336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/4396"},"html":{"href":"https://github.com/facebook/osquery/pull/4396"},"issue":{"href":"https://api.github.com/repos/facebook/osquery/issues/4396"},"comments":{"href":"https://api.github.com/repos/facebook/osquery/issues/4396/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/osquery/pulls/4396/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/osquery/pulls/4396/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/osquery/statuses/9e8a05e4bed585a9c006360a8db8237adf7e762a"}},"author_association":"NONE"}}
{"actor":{"display_login":"akindyakov"}}