{"action":"created","issue":{"url":"https://api.github.com/repos/dealii/dealii/issues/7027","repository_url":"https://api.github.com/repos/dealii/dealii","labels_url":"https://api.github.com/repos/dealii/dealii/issues/7027/labels{/name}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/7027/comments","events_url":"https://api.github.com/repos/dealii/dealii/issues/7027/events","html_url":"https://github.com/dealii/dealii/pull/7027","id":347633240,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjAwODg0","number":7027,"title":" Check for consistent manifold ids in 2D when creating a Triangulation","user":{"login":"masterleinad","id":2423533,"node_id":"MDQ6VXNlcjI0MjM1MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-04T17:03:49Z","updated_at":"2018-08-06T09:30:40Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/7027","html_url":"https://github.com/dealii/dealii/pull/7027","diff_url":"https://github.com/dealii/dealii/pull/7027.diff","patch_url":"https://github.com/dealii/dealii/pull/7027.patch"},"body":"Fixes #6397, i.e. replaces `invalid_manifold_id` by ` flat_manifold_id`. I decided to deprecate the constant rather than removing it outright. Even if it is very unlikely that anyone has used this constant outside the internals of the library, I prefer to make sure that we stay backward-compatible here as well.\r\n\r\nAdditionally, this PR introduces another check for consistent manifold ids when creating a two-dimensional `Triangulation`. The corresponding check for the three-dimensional case is already in place."},"comment":{"url":"https://api.github.com/repos/dealii/dealii/issues/comments/410647174","html_url":"https://github.com/dealii/dealii/pull/7027#issuecomment-410647174","issue_url":"https://api.github.com/repos/dealii/dealii/issues/7027","id":410647174,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDY0NzE3NA==","user":{"login":"masterleinad","id":2423533,"node_id":"MDQ6VXNlcjI0MjM1MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T09:30:40Z","updated_at":"2018-08-06T09:30:40Z","author_association":"MEMBER","body":"I restored the old behavior where we allow to set boundary ids on internal faces, but not `numbers::internal_face_boundary_id` for boundary faces. For this PR, this seems to be the most appropriate way. I opened #7033 for a better solution to this."}}
{"actor":{"display_login":"masterleinad"}}