{"action":"created","issue":{"url":"https://api.github.com/repos/tronprotocol/java-tron/issues/119","repository_url":"https://api.github.com/repos/tronprotocol/java-tron","labels_url":"https://api.github.com/repos/tronprotocol/java-tron/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/tronprotocol/java-tron/issues/119/comments","events_url":"https://api.github.com/repos/tronprotocol/java-tron/issues/119/events","html_url":"https://github.com/tronprotocol/java-tron/issues/119","id":296089051,"number":119,"title":"This automatic tests are not automatic","user":{"login":"abarranco","id":783682,"avatar_url":"https://avatars2.githubusercontent.com/u/783682?v=4","gravatar_id":"","url":"https://api.github.com/users/abarranco","html_url":"https://github.com/abarranco","followers_url":"https://api.github.com/users/abarranco/followers","following_url":"https://api.github.com/users/abarranco/following{/other_user}","gists_url":"https://api.github.com/users/abarranco/gists{/gist_id}","starred_url":"https://api.github.com/users/abarranco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarranco/subscriptions","organizations_url":"https://api.github.com/users/abarranco/orgs","repos_url":"https://api.github.com/users/abarranco/repos","events_url":"https://api.github.com/users/abarranco/events{/privacy}","received_events_url":"https://api.github.com/users/abarranco/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-02-10T09:55:28Z","updated_at":"2018-03-28T18:11:53Z","closed_at":"2018-03-28T18:11:53Z","author_association":"NONE","body":"https://github.com/tronprotocol/java-tron/blob/7615871e4bfaace69b1f5f04b36d3813bbe240b3/src/test/java/org/tron/core/BlockchainTest.java#L61\r\n\r\nWhat's te point on logging something in the console ¿?¿? Nobody are gonna see it, and the test is not going to fail, so you can make a new version even if the version has any bugs on it.\r\n\r\nThe test must always follow the pattern, // GIVEN // WHEN  // THEN\r\n\r\nYou need to assert things like:\r\nassertNotNull(blockchain.getLastHash());\r\n\r\nThat is automatic, that will fail if hash is null, and you won't be able to make a new version with that bug.\r\n\r\nIf the hash must start with \"000\" for example you need to assert that.\r\n\r\nThis applies to 9x% of the testing code u guys have here. You need to re-do this tests. I am a java developer myself, and i was a tron holder until i saw this code. You can't refactor things with this tests, you can't improve the code with security. You need better tests and you need it for yesterday.\r\n"},"comment":{"url":"https://api.github.com/repos/tronprotocol/java-tron/issues/comments/376983483","html_url":"https://github.com/tronprotocol/java-tron/issues/119#issuecomment-376983483","issue_url":"https://api.github.com/repos/tronprotocol/java-tron/issues/119","id":376983483,"user":{"login":"Rovak","id":376155,"avatar_url":"https://avatars1.githubusercontent.com/u/376155?v=4","gravatar_id":"","url":"https://api.github.com/users/Rovak","html_url":"https://github.com/Rovak","followers_url":"https://api.github.com/users/Rovak/followers","following_url":"https://api.github.com/users/Rovak/following{/other_user}","gists_url":"https://api.github.com/users/Rovak/gists{/gist_id}","starred_url":"https://api.github.com/users/Rovak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rovak/subscriptions","organizations_url":"https://api.github.com/users/Rovak/orgs","repos_url":"https://api.github.com/users/Rovak/repos","events_url":"https://api.github.com/users/Rovak/events{/privacy}","received_events_url":"https://api.github.com/users/Rovak/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T18:11:52Z","updated_at":"2018-03-28T18:11:52Z","author_association":"MEMBER","body":"The concerns as given by @abarranco have been fixed in the `develop` branch. I could only find 2 tests of the 135 tests which were only logging and they will be fixed shortly.\r\n\r\nFeel free to reopen this issue if there are any other tests that need attention, or open a new issue."}}
{"actor":{"display_login":"Rovak"}}