{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/230154026","pull_request_review_id":170827159,"id":230154026,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDE1NDAyNg==","diff_hunk":"@@ -0,0 +1,52 @@\n+#","path":"Dockerfile.builder","position":1,"original_position":1,"commit_id":"5dd15e513be3c63246aeb60fbce79536011d90b6","original_commit_id":"9c9cf3bbc248b984e9d0f3bfdd47ed8b2290c6bf","user":{"login":"jrajahalme","id":6518235,"node_id":"MDQ6VXNlcjY1MTgyMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6518235?v=4","gravatar_id":"","url":"https://api.github.com/users/jrajahalme","html_url":"https://github.com/jrajahalme","followers_url":"https://api.github.com/users/jrajahalme/followers","following_url":"https://api.github.com/users/jrajahalme/following{/other_user}","gists_url":"https://api.github.com/users/jrajahalme/gists{/gist_id}","starred_url":"https://api.github.com/users/jrajahalme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrajahalme/subscriptions","organizations_url":"https://api.github.com/users/jrajahalme/orgs","repos_url":"https://api.github.com/users/jrajahalme/repos","events_url":"https://api.github.com/users/jrajahalme/events{/privacy}","received_events_url":"https://api.github.com/users/jrajahalme/received_events","type":"User","site_admin":false},"body":"Added comment:\r\n```\r\n#\r\n# Cilium build-time dependencies.\r\n# Image created from this file is used to build Cilium.\r\n#\r\n```\r\n\r\nNote that while I removed the most obvious Envoy dependencies from here, I'm not sure if all that remains is really needed to build Cilium. Maybe you can have look?","created_at":"2018-11-01T18:44:10Z","updated_at":"2018-11-01T18:44:10Z","html_url":"https://github.com/cilium/cilium/pull/6123#discussion_r230154026","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/6123","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/230154026"},"html":{"href":"https://github.com/cilium/cilium/pull/6123#discussion_r230154026"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/6123"}},"in_reply_to_id":230066466},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/6123","id":227162325,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTYyMzI1","html_url":"https://github.com/cilium/cilium/pull/6123","diff_url":"https://github.com/cilium/cilium/pull/6123.diff","patch_url":"https://github.com/cilium/cilium/pull/6123.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/6123","number":6123,"state":"open","locked":false,"title":"envoy: Use github.com/cilium/proxy","user":{"login":"jrajahalme","id":6518235,"node_id":"MDQ6VXNlcjY1MTgyMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6518235?v=4","gravatar_id":"","url":"https://api.github.com/users/jrajahalme","html_url":"https://github.com/jrajahalme","followers_url":"https://api.github.com/users/jrajahalme/followers","following_url":"https://api.github.com/users/jrajahalme/following{/other_user}","gists_url":"https://api.github.com/users/jrajahalme/gists{/gist_id}","starred_url":"https://api.github.com/users/jrajahalme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrajahalme/subscriptions","organizations_url":"https://api.github.com/users/jrajahalme/orgs","repos_url":"https://api.github.com/users/jrajahalme/repos","events_url":"https://api.github.com/users/jrajahalme/events{/privacy}","received_events_url":"https://api.github.com/users/jrajahalme/received_events","type":"User","site_admin":false},"body":"Add a new variable `envoy.RequiredEnvoyVersionSHA` and check that the\r\nrunning Envoy version matches that instead of the current Cilium SHA.\r\n\r\nThis requires that Envoy version dependency is manually updated, but\r\nallows Cilium SHA to advance without requiring to rebuild Envoy.\r\n\r\nPull cilium-envoy from docker image `cilium/cilium-envoy:<CILIUM_ENVOY_SHA>`, where `<CILIUM_ENVOY_SHA>` is the git SHA of the dependency to the new github.com/cilium/proxy repo.\r\n\r\nUse a new (experimental) builder image from which the Envoy build dependencies have been removed.\r\n\r\nPull in the generated protobuf API files via a vendor dependency to github.com/cilium/proxy. This is also referred to via a SHA, which may be different from the CILIUM_ENVOY_SHA due to the protobufs maybe changing less often.\r\n\r\nProxy dependency to the go build generated `libcilium.h` that captures the exported function prototypes from `proxylib/proxylib.go` is currently handled manually without any checks. This means that if `proxylib/proxylib.go` exported function prototypes are changed Envoy will fail when calling those functions.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/6123)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-10-31T05:17:39Z","updated_at":"2018-11-01T18:44:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5567806b8a7d38aa8a5f79739cd7a5ac3e5ba4f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"proxy","id":2519788,"node_id":"MDQ6VGVhbTI1MTk3ODg=","slug":"proxy","description":"Proxy layer","privacy":"closed","url":"https://api.github.com/teams/2519788","members_url":"https://api.github.com/teams/2519788/members{/member}","repositories_url":"https://api.github.com/teams/2519788/repos","permission":"pull"},{"name":"docs","id":2519789,"node_id":"MDQ6VGVhbTI1MTk3ODk=","slug":"docs","description":"Documentation","privacy":"closed","url":"https://api.github.com/teams/2519789","members_url":"https://api.github.com/teams/2519789/members{/member}","repositories_url":"https://api.github.com/teams/2519789/repos","permission":"pull"},{"name":"janitors","id":2519796,"node_id":"MDQ6VGVhbTI1MTk3OTY=","slug":"janitors","description":"Rotating team of janitors for unowned code","privacy":"closed","url":"https://api.github.com/teams/2519796","members_url":"https://api.github.com/teams/2519796/members{/member}","repositories_url":"https://api.github.com/teams/2519796/repos","permission":"pull"}],"labels":[{"id":721424175,"node_id":"MDU6TGFiZWw3MjE0MjQxNzU=","url":"https://api.github.com/repos/cilium/cilium/labels/area/proxy","name":"area/proxy","color":"fef2c0","default":false},{"id":1108973997,"node_id":"MDU6TGFiZWwxMTA4OTczOTk3","url":"https://api.github.com/repos/cilium/cilium/labels/halloween-special","name":"halloween-special","color":"fbca04","default":false},{"id":300384441,"node_id":"MDU6TGFiZWwzMDAzODQ0NDE=","url":"https://api.github.com/repos/cilium/cilium/labels/kind/enhancement","name":"kind/enhancement","color":"84b6eb","default":false},{"id":934739756,"node_id":"MDU6TGFiZWw5MzQ3Mzk3NTY=","url":"https://api.github.com/repos/cilium/cilium/labels/needs-rebase","name":"needs-rebase","color":"fbca04","default":false},{"id":403149902,"node_id":"MDU6TGFiZWw0MDMxNDk5MDI=","url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/cilium/cilium/milestones/19","html_url":"https://github.com/cilium/cilium/milestone/19","labels_url":"https://api.github.com/repos/cilium/cilium/milestones/19/labels","id":3736768,"node_id":"MDk6TWlsZXN0b25lMzczNjc2OA==","number":19,"title":"1.4-feature","description":"","creator":{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":31,"state":"open","created_at":"2018-10-14T10:00:27Z","updated_at":"2018-11-01T15:33:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/6123/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/6123/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/6123/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/5dd15e513be3c63246aeb60fbce79536011d90b6","head":{"label":"cilium:pr/envoy-separation","ref":"pr/envoy-separation","sha":"5dd15e513be3c63246aeb60fbce79536011d90b6","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","private":false,"owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-11-01T18:41:08Z","pushed_at":"2018-11-01T18:06:36Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":72499,"stargazers_count":3001,"watchers_count":3001,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":270,"mirror_url":null,"archived":false,"open_issues_count":526,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":270,"open_issues":526,"watchers":3001,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"866bae5c901d16c794447d25254d2aa5f072337a","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","private":false,"owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-11-01T18:41:08Z","pushed_at":"2018-11-01T18:06:36Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":72499,"stargazers_count":3001,"watchers_count":3001,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":270,"mirror_url":null,"archived":false,"open_issues_count":526,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":270,"open_issues":526,"watchers":3001,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/6123"},"html":{"href":"https://github.com/cilium/cilium/pull/6123"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/6123"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/6123/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/6123/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/6123/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/5dd15e513be3c63246aeb60fbce79536011d90b6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jrajahalme"}}