{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/179834998","pull_request_review_id":110158260,"id":179834998,"diff_hunk":"@@ -0,0 +1,87 @@\n+{\r\n+  \"apiVersion\": \"vlabs\",\r\n+  \"properties\": {\r\n+    \"orchestratorProfile\": {\r\n+      \"orchestratorType\": \"OpenShift\",\r\n+      \"openShiftConfig\": {\r\n+        \"clusterUsername\": \"demo\",\r\n+        \"clusterPassword\": \"demo\"\r\n+      }\r\n+    },\r\n+    \"azProfile\": {\r\n+      \"tenantId\": \"YOUR TENANT ID\",\r\n+      \"subscriptionId\": \"YOUR SUBSCRIPTION ID\",\r\n+      \"resourceGroup\": \"YOUR RESOURCE GROUP\",\r\n+      \"location\": \"YOUR LOCATION\"\r\n+    },\r\n+    \"masterProfile\": {\r\n+      \"count\": 1,\r\n+      \"dnsPrefix\": \"YOUR DNS PREFIX\",\r\n+      \"imageReference\": {\r\n+        \"name\": \"YOUR IMAGE\",\r\n+        \"resourceGroup\": \"YOUR IMAGE RESOURCE GROUP\"\r\n+      },\r\n+      \"storageProfile\": \"ManagedDisks\",\r\n+      \"vmSize\": \"Standard_D4s_v3\"\r\n+    },\r\n+    \"agentPoolProfiles\": [\r\n+      {\r\n+        \"availabilityProfile\": \"AvailabilitySet\",\r\n+        \"count\": 1,\r\n+        \"imageReference\": {\r\n+          \"name\": \"YOUR IMAGE\",\r\n+          \"resourceGroup\": \"YOUR IMAGE RESOURCE GROUP\"\r\n+        },\r\n+        \"name\": \"compute\",\r\n+        \"storageProfile\": \"ManagedDisks\",\r\n+        \"vmSize\": \"Standard_D4s_v3\"\r\n+      },\r\n+      {\r\n+        \"availabilityProfile\": \"AvailabilitySet\",\r","path":"examples/openshift.json","position":40,"original_position":40,"commit_id":"2f47645864d9bc67eca1da1aa65757de5f9c4372","original_commit_id":"2f47645864d9bc67eca1da1aa65757de5f9c4372","user":{"login":"khenidak","id":10683203,"avatar_url":"https://avatars2.githubusercontent.com/u/10683203?v=4","gravatar_id":"","url":"https://api.github.com/users/khenidak","html_url":"https://github.com/khenidak","followers_url":"https://api.github.com/users/khenidak/followers","following_url":"https://api.github.com/users/khenidak/following{/other_user}","gists_url":"https://api.github.com/users/khenidak/gists{/gist_id}","starred_url":"https://api.github.com/users/khenidak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khenidak/subscriptions","organizations_url":"https://api.github.com/users/khenidak/orgs","repos_url":"https://api.github.com/users/khenidak/repos","events_url":"https://api.github.com/users/khenidak/events{/privacy}","received_events_url":"https://api.github.com/users/khenidak/received_events","type":"User","site_admin":false},"body":"Right. Should we add a validation for for using VMSS w/ OpenShift","created_at":"2018-04-06T18:09:09Z","updated_at":"2018-04-06T18:09:09Z","html_url":"https://github.com/Azure/acs-engine/pull/2611#discussion_r179834998","pull_request_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2611","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/179834998"},"html":{"href":"https://github.com/Azure/acs-engine/pull/2611#discussion_r179834998"},"pull_request":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2611"}},"in_reply_to_id":179813732},"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/2611","id":179901869,"html_url":"https://github.com/Azure/acs-engine/pull/2611","diff_url":"https://github.com/Azure/acs-engine/pull/2611.diff","patch_url":"https://github.com/Azure/acs-engine/pull/2611.patch","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/2611","number":2611,"state":"open","locked":false,"title":"Add first cut of the OpenShift orchestrator ","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"@jim-minter @pweil- @jackfrancis @khenidak ","created_at":"2018-04-06T09:49:20Z","updated_at":"2018-04-06T18:09:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ef3976d6a388601710cd2060ff07adddab9a476","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2611/commits","review_comments_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2611/comments","review_comment_url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/2611/comments","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/2f47645864d9bc67eca1da1aa65757de5f9c4372","head":{"label":"kargakis:openshift-orchestrator","ref":"openshift-orchestrator","sha":"2f47645864d9bc67eca1da1aa65757de5f9c4372","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"repo":{"id":123582194,"name":"acs-engine","full_name":"kargakis/acs-engine","owner":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kargakis/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":true,"url":"https://api.github.com/repos/kargakis/acs-engine","forks_url":"https://api.github.com/repos/kargakis/acs-engine/forks","keys_url":"https://api.github.com/repos/kargakis/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kargakis/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kargakis/acs-engine/teams","hooks_url":"https://api.github.com/repos/kargakis/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/kargakis/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/kargakis/acs-engine/events","assignees_url":"https://api.github.com/repos/kargakis/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/kargakis/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/kargakis/acs-engine/tags","blobs_url":"https://api.github.com/repos/kargakis/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kargakis/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kargakis/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/kargakis/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kargakis/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/kargakis/acs-engine/languages","stargazers_url":"https://api.github.com/repos/kargakis/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/kargakis/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/kargakis/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/kargakis/acs-engine/subscription","commits_url":"https://api.github.com/repos/kargakis/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/kargakis/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/kargakis/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/kargakis/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/kargakis/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/kargakis/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kargakis/acs-engine/merges","archive_url":"https://api.github.com/repos/kargakis/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kargakis/acs-engine/downloads","issues_url":"https://api.github.com/repos/kargakis/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/kargakis/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/kargakis/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/kargakis/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kargakis/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/kargakis/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/kargakis/acs-engine/deployments","created_at":"2018-03-02T13:26:46Z","updated_at":"2018-04-06T18:00:05Z","pushed_at":"2018-04-06T18:00:03Z","git_url":"git://github.com/kargakis/acs-engine.git","ssh_url":"git@github.com:kargakis/acs-engine.git","clone_url":"https://github.com/kargakis/acs-engine.git","svn_url":"https://github.com/kargakis/acs-engine","homepage":"","size":65424,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"4b5420e71c68b2066f19625dafd3ab087dc4f976","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":66011370,"name":"acs-engine","full_name":"Azure/acs-engine","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/acs-engine","forks_url":"https://api.github.com/repos/Azure/acs-engine/forks","keys_url":"https://api.github.com/repos/Azure/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acs-engine/teams","hooks_url":"https://api.github.com/repos/Azure/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acs-engine/events","assignees_url":"https://api.github.com/repos/Azure/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acs-engine/tags","blobs_url":"https://api.github.com/repos/Azure/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acs-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/acs-engine/subscription","commits_url":"https://api.github.com/repos/Azure/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acs-engine/merges","archive_url":"https://api.github.com/repos/Azure/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acs-engine/downloads","issues_url":"https://api.github.com/repos/Azure/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acs-engine/deployments","created_at":"2016-08-18T16:05:16Z","updated_at":"2018-04-06T18:08:56Z","pushed_at":"2018-04-06T18:08:50Z","git_url":"git://github.com/Azure/acs-engine.git","ssh_url":"git@github.com:Azure/acs-engine.git","clone_url":"https://github.com/Azure/acs-engine.git","svn_url":"https://github.com/Azure/acs-engine","homepage":"","size":75543,"stargazers_count":726,"watchers_count":726,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":466,"mirror_url":null,"archived":false,"open_issues_count":432,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":466,"open_issues":432,"watchers":726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2611"},"html":{"href":"https://github.com/Azure/acs-engine/pull/2611"},"issue":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/2611"},"comments":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/2611/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2611/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2611/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acs-engine/statuses/2f47645864d9bc67eca1da1aa65757de5f9c4372"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"khenidak"}}