{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/two-way-message/pulls/comments/244101151","pull_request_review_id":188025482,"id":244101151,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDEwMTE1MQ==","diff_hunk":"@@ -42,7 +42,7 @@ class TwoWayMessageController @Inject()(twms: TwoWayMessageService)\n   def validateAndPostMessage(requestBody: JsValue): Future[Result] =\n     requestBody.validate[TwoWayMessage] match {\n       case _: JsSuccess[_] => twms.post(requestBody.as[TwoWayMessage])\n-      case e: JsError => Future.successful(BadRequest(Json.obj(\"error\" -> \"OK\", \"message\" -> JsError.toJson(e))))\n+      case e: JsError => Future.successful(BadRequest(Json.obj(\"error\" -> \"400\", \"message\" -> JsError.toJson(e))))","path":"app/uk/gov/hmrc/twowaymessage/controllers/TwoWayMessageController.scala","position":5,"original_position":5,"commit_id":"375a2a6325ee0ca1e30af853f5e41a250317152c","original_commit_id":"375a2a6325ee0ca1e30af853f5e41a250317152c","user":{"login":"elabeca","id":1290092,"node_id":"MDQ6VXNlcjEyOTAwOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1290092?v=4","gravatar_id":"","url":"https://api.github.com/users/elabeca","html_url":"https://github.com/elabeca","followers_url":"https://api.github.com/users/elabeca/followers","following_url":"https://api.github.com/users/elabeca/following{/other_user}","gists_url":"https://api.github.com/users/elabeca/gists{/gist_id}","starred_url":"https://api.github.com/users/elabeca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elabeca/subscriptions","organizations_url":"https://api.github.com/users/elabeca/orgs","repos_url":"https://api.github.com/users/elabeca/repos","events_url":"https://api.github.com/users/elabeca/events{/privacy}","received_events_url":"https://api.github.com/users/elabeca/received_events","type":"User","site_admin":false},"body":"I agree but only going by what the story states. So unable to change in this case.","created_at":"2018-12-27T08:02:57Z","updated_at":"2018-12-27T08:02:58Z","html_url":"https://github.com/hmrc/two-way-message/pull/8#discussion_r244101151","pull_request_url":"https://api.github.com/repos/hmrc/two-way-message/pulls/8","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmrc/two-way-message/pulls/comments/244101151"},"html":{"href":"https://github.com/hmrc/two-way-message/pull/8#discussion_r244101151"},"pull_request":{"href":"https://api.github.com/repos/hmrc/two-way-message/pulls/8"}},"in_reply_to_id":244101014},"pull_request":{"url":"https://api.github.com/repos/hmrc/two-way-message/pulls/8","id":240763874,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNzYzODc0","html_url":"https://github.com/hmrc/two-way-message/pull/8","diff_url":"https://github.com/hmrc/two-way-message/pull/8.diff","patch_url":"https://github.com/hmrc/two-way-message/pull/8.patch","issue_url":"https://api.github.com/repos/hmrc/two-way-message/issues/8","number":8,"state":"open","locked":false,"title":"[DC-1629|DC-1633] - Fix error messages output as per the story descriptions","user":{"login":"elabeca","id":1290092,"node_id":"MDQ6VXNlcjEyOTAwOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1290092?v=4","gravatar_id":"","url":"https://api.github.com/users/elabeca","html_url":"https://github.com/elabeca","followers_url":"https://api.github.com/users/elabeca/followers","following_url":"https://api.github.com/users/elabeca/following{/other_user}","gists_url":"https://api.github.com/users/elabeca/gists{/gist_id}","starred_url":"https://api.github.com/users/elabeca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elabeca/subscriptions","organizations_url":"https://api.github.com/users/elabeca/orgs","repos_url":"https://api.github.com/users/elabeca/repos","events_url":"https://api.github.com/users/elabeca/events{/privacy}","received_events_url":"https://api.github.com/users/elabeca/received_events","type":"User","site_admin":false},"body":"This will apply a fix where the message service raised errors (including getMetadata) didn't return the expected output. ","created_at":"2018-12-24T11:48:27Z","updated_at":"2018-12-27T08:02:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0decd754553763a67f184872e3dacddf8a3510a2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lxol","id":356638,"node_id":"MDQ6VXNlcjM1NjYzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/356638?v=4","gravatar_id":"","url":"https://api.github.com/users/lxol","html_url":"https://github.com/lxol","followers_url":"https://api.github.com/users/lxol/followers","following_url":"https://api.github.com/users/lxol/following{/other_user}","gists_url":"https://api.github.com/users/lxol/gists{/gist_id}","starred_url":"https://api.github.com/users/lxol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxol/subscriptions","organizations_url":"https://api.github.com/users/lxol/orgs","repos_url":"https://api.github.com/users/lxol/repos","events_url":"https://api.github.com/users/lxol/events{/privacy}","received_events_url":"https://api.github.com/users/lxol/received_events","type":"User","site_admin":false},{"login":"andy1138","id":455080,"node_id":"MDQ6VXNlcjQ1NTA4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/455080?v=4","gravatar_id":"","url":"https://api.github.com/users/andy1138","html_url":"https://github.com/andy1138","followers_url":"https://api.github.com/users/andy1138/followers","following_url":"https://api.github.com/users/andy1138/following{/other_user}","gists_url":"https://api.github.com/users/andy1138/gists{/gist_id}","starred_url":"https://api.github.com/users/andy1138/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy1138/subscriptions","organizations_url":"https://api.github.com/users/andy1138/orgs","repos_url":"https://api.github.com/users/andy1138/repos","events_url":"https://api.github.com/users/andy1138/events{/privacy}","received_events_url":"https://api.github.com/users/andy1138/received_events","type":"User","site_admin":false},{"login":"rwalpole","id":2248695,"node_id":"MDQ6VXNlcjIyNDg2OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2248695?v=4","gravatar_id":"","url":"https://api.github.com/users/rwalpole","html_url":"https://github.com/rwalpole","followers_url":"https://api.github.com/users/rwalpole/followers","following_url":"https://api.github.com/users/rwalpole/following{/other_user}","gists_url":"https://api.github.com/users/rwalpole/gists{/gist_id}","starred_url":"https://api.github.com/users/rwalpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwalpole/subscriptions","organizations_url":"https://api.github.com/users/rwalpole/orgs","repos_url":"https://api.github.com/users/rwalpole/repos","events_url":"https://api.github.com/users/rwalpole/events{/privacy}","received_events_url":"https://api.github.com/users/rwalpole/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/two-way-message/pulls/8/commits","review_comments_url":"https://api.github.com/repos/hmrc/two-way-message/pulls/8/comments","review_comment_url":"https://api.github.com/repos/hmrc/two-way-message/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/two-way-message/issues/8/comments","statuses_url":"https://api.github.com/repos/hmrc/two-way-message/statuses/375a2a6325ee0ca1e30af853f5e41a250317152c","head":{"label":"hmrc:DC-1633-handle-errors","ref":"DC-1633-handle-errors","sha":"375a2a6325ee0ca1e30af853f5e41a250317152c","user":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":157854207,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4NTQyMDc=","name":"two-way-message","full_name":"hmrc/two-way-message","private":false,"owner":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmrc/two-way-message","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/two-way-message","forks_url":"https://api.github.com/repos/hmrc/two-way-message/forks","keys_url":"https://api.github.com/repos/hmrc/two-way-message/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/two-way-message/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/two-way-message/teams","hooks_url":"https://api.github.com/repos/hmrc/two-way-message/hooks","issue_events_url":"https://api.github.com/repos/hmrc/two-way-message/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/two-way-message/events","assignees_url":"https://api.github.com/repos/hmrc/two-way-message/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/two-way-message/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/two-way-message/tags","blobs_url":"https://api.github.com/repos/hmrc/two-way-message/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/two-way-message/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/two-way-message/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/two-way-message/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/two-way-message/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/two-way-message/languages","stargazers_url":"https://api.github.com/repos/hmrc/two-way-message/stargazers","contributors_url":"https://api.github.com/repos/hmrc/two-way-message/contributors","subscribers_url":"https://api.github.com/repos/hmrc/two-way-message/subscribers","subscription_url":"https://api.github.com/repos/hmrc/two-way-message/subscription","commits_url":"https://api.github.com/repos/hmrc/two-way-message/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/two-way-message/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/two-way-message/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/two-way-message/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/two-way-message/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/two-way-message/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/two-way-message/merges","archive_url":"https://api.github.com/repos/hmrc/two-way-message/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/two-way-message/downloads","issues_url":"https://api.github.com/repos/hmrc/two-way-message/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/two-way-message/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/two-way-message/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/two-way-message/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/two-way-message/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/two-way-message/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/two-way-message/deployments","created_at":"2018-11-16T10:50:13Z","updated_at":"2018-12-21T13:00:59Z","pushed_at":"2018-12-24T13:18:09Z","git_url":"git://github.com/hmrc/two-way-message.git","ssh_url":"git@github.com:hmrc/two-way-message.git","clone_url":"https://github.com/hmrc/two-way-message.git","svn_url":"https://github.com/hmrc/two-way-message","homepage":"","size":43,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"a3ef01691e633627aff2c898c3a01ed79ef51fd1","user":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":157854207,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4NTQyMDc=","name":"two-way-message","full_name":"hmrc/two-way-message","private":false,"owner":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmrc/two-way-message","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/two-way-message","forks_url":"https://api.github.com/repos/hmrc/two-way-message/forks","keys_url":"https://api.github.com/repos/hmrc/two-way-message/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/two-way-message/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/two-way-message/teams","hooks_url":"https://api.github.com/repos/hmrc/two-way-message/hooks","issue_events_url":"https://api.github.com/repos/hmrc/two-way-message/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/two-way-message/events","assignees_url":"https://api.github.com/repos/hmrc/two-way-message/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/two-way-message/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/two-way-message/tags","blobs_url":"https://api.github.com/repos/hmrc/two-way-message/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/two-way-message/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/two-way-message/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/two-way-message/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/two-way-message/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/two-way-message/languages","stargazers_url":"https://api.github.com/repos/hmrc/two-way-message/stargazers","contributors_url":"https://api.github.com/repos/hmrc/two-way-message/contributors","subscribers_url":"https://api.github.com/repos/hmrc/two-way-message/subscribers","subscription_url":"https://api.github.com/repos/hmrc/two-way-message/subscription","commits_url":"https://api.github.com/repos/hmrc/two-way-message/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/two-way-message/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/two-way-message/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/two-way-message/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/two-way-message/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/two-way-message/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/two-way-message/merges","archive_url":"https://api.github.com/repos/hmrc/two-way-message/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/two-way-message/downloads","issues_url":"https://api.github.com/repos/hmrc/two-way-message/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/two-way-message/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/two-way-message/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/two-way-message/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/two-way-message/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/two-way-message/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/two-way-message/deployments","created_at":"2018-11-16T10:50:13Z","updated_at":"2018-12-21T13:00:59Z","pushed_at":"2018-12-24T13:18:09Z","git_url":"git://github.com/hmrc/two-way-message.git","ssh_url":"git@github.com:hmrc/two-way-message.git","clone_url":"https://github.com/hmrc/two-way-message.git","svn_url":"https://github.com/hmrc/two-way-message","homepage":"","size":43,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/two-way-message/pulls/8"},"html":{"href":"https://github.com/hmrc/two-way-message/pull/8"},"issue":{"href":"https://api.github.com/repos/hmrc/two-way-message/issues/8"},"comments":{"href":"https://api.github.com/repos/hmrc/two-way-message/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/two-way-message/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/two-way-message/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/two-way-message/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/two-way-message/statuses/375a2a6325ee0ca1e30af853f5e41a250317152c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"elabeca"}}