{"action":"created","issue":{"url":"https://api.github.com/repos/infinispan/infinispan/issues/5997","repository_url":"https://api.github.com/repos/infinispan/infinispan","labels_url":"https://api.github.com/repos/infinispan/infinispan/issues/5997/labels{/name}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/5997/comments","events_url":"https://api.github.com/repos/infinispan/infinispan/issues/5997/events","html_url":"https://github.com/infinispan/infinispan/pull/5997","id":324594121,"number":5997,"title":"ISPN-5451 data container striping","user":{"login":"wburns","id":648175,"avatar_url":"https://avatars1.githubusercontent.com/u/648175?v=4","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"labels":[{"id":142381603,"url":"https://api.github.com/repos/infinispan/infinispan/labels/Preview","name":"Preview","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-05-19T02:29:42Z","updated_at":"2018-05-21T18:29:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/5997","html_url":"https://github.com/infinispan/infinispan/pull/5997","diff_url":"https://github.com/infinispan/infinispan/pull/5997.diff","patch_url":"https://github.com/infinispan/infinispan/pull/5997.patch"},"body":"https://issues.jboss.org/browse/ISPN-5451\r\n\r\nInitial on heap implementation"},"comment":{"url":"https://api.github.com/repos/infinispan/infinispan/issues/comments/390741427","html_url":"https://github.com/infinispan/infinispan/pull/5997#issuecomment-390741427","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/5997","id":390741427,"user":{"login":"wburns","id":648175,"avatar_url":"https://avatars1.githubusercontent.com/u/648175?v=4","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"created_at":"2018-05-21T18:29:23Z","updated_at":"2018-05-21T18:29:23Z","author_association":"CONTRIBUTOR","body":"Very quickly changing the https://github.com/infinispan/infinispan-benchmarks/tree/master/iteration to do a test for inserts with already precomputed keys and values I got the following:\r\n\r\n```\r\nSEGMENTED\r\n\r\nBenchmark          (keyObjectSize)  (nodes)  (useIdentityCache)  (useStrings)  (valueObjectSize)   Mode  Cnt     Score    Error  Units\r\nJMHBenchmarks.put               10        6                true         false               1000  thrpt   20  8839.924 ± 69.350  ops/s\r\n\r\nBenchmark                                           (keyObjectSize)  (nodes)  (useIdentityCache)  (useStrings)  (valueObjectSize)   Mode  Cnt      Score       Error   Units\r\nJMHBenchmarks.put                                                10        6                true         false               1000  thrpt   20   8587.319 ±    70.790   ops/s\r\nJMHBenchmarks.put:·gc.alloc.rate                                 10        6                true         false               1000  thrpt   20    130.952 ±    22.624  MB/sec\r\nJMHBenchmarks.put:·gc.alloc.rate.norm                            10        6                true         false               1000  thrpt   20  24037.155 ±  3990.484    B/op\r\nJMHBenchmarks.put:·gc.churn.PS_Eden_Space                        10        6                true         false               1000  thrpt   20    133.564 ±   283.264  MB/sec\r\nJMHBenchmarks.put:·gc.churn.PS_Eden_Space.norm                   10        6                true         false               1000  thrpt   20  24622.623 ± 52220.116    B/op\r\nJMHBenchmarks.put:·gc.churn.PS_Survivor_Space                    10        6                true         false               1000  thrpt   20      0.031 ±     0.085  MB/sec\r\nJMHBenchmarks.put:·gc.churn.PS_Survivor_Space.norm               10        6                true         false               1000  thrpt   20      5.809 ±    15.653    B/op\r\nJMHBenchmarks.put:·gc.count                                      10        6                true         false               1000  thrpt   20      3.000              counts\r\nJMHBenchmarks.put:·gc.time                                       10        6                true         false               1000  thrpt   20     16.000                  ms\r\n\r\n\r\nMASTER\r\n\r\nBenchmark          (keyObjectSize)  (nodes)  (useIdentityCache)  (useStrings)  (valueObjectSize)   Mode  Cnt     Score     Error  Units\r\nJMHBenchmarks.put               10        6                true         false               1000  thrpt   20  8688.200 ± 171.789  ops/s\r\n\r\n\r\nBenchmark                                           (keyObjectSize)  (nodes)  (useIdentityCache)  (useStrings)  (valueObjectSize)   Mode  Cnt      Score       Error   Units\r\nJMHBenchmarks.put                                                10        6                true         false               1000  thrpt   20   8763.348 ±    53.413   ops/s\r\nJMHBenchmarks.put:·gc.alloc.rate                                 10        6                true         false               1000  thrpt   20    133.793 ±    22.774  MB/sec\r\nJMHBenchmarks.put:·gc.alloc.rate.norm                            10        6                true         false               1000  thrpt   20  24022.719 ±  3991.557    B/op\r\nJMHBenchmarks.put:·gc.churn.PS_Eden_Space                        10        6                true         false               1000  thrpt   20    133.562 ±   283.259  MB/sec\r\nJMHBenchmarks.put:·gc.churn.PS_Eden_Space.norm                   10        6                true         false               1000  thrpt   20  24132.248 ± 51179.819    B/op\r\nJMHBenchmarks.put:·gc.churn.PS_Survivor_Space                    10        6                true         false               1000  thrpt   20      0.014 ±     0.053  MB/sec\r\nJMHBenchmarks.put:·gc.churn.PS_Survivor_Space.norm               10        6                true         false               1000  thrpt   20      2.445 ±     9.496    B/op\r\nJMHBenchmarks.put:·gc.count                                      10        6                true         false               1000  thrpt   20      3.000              counts\r\nJMHBenchmarks.put:·gc.time                                       10        6                true         false               1000  thrpt   20     16.000                  ms\r\n\r\n```\r\n\r\nThis was found with 2 runs of jmh for master and this branch. One without and one with `-prof gc` set. The results seem pretty consistent within each other.\r\n\r\nFrom the code the only difference for a `Cache.put` and `Cache.get` should be one additional single segment lookup and array access for a given key."}}
{"actor":{"display_login":"wburns"}}