{"action":"created","comment":{"url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls/comments/184391097","pull_request_review_id":115576993,"id":184391097,"diff_hunk":"@@ -0,0 +1,147 @@\n+# RPC design refactoring\n+\n+* Proposal: [SDL-NNNN](nnnn-rpc-design-refactoring.md)\n+* Author: [Alexander Kutsan](https://github.com/LuxoftAKutsan)\n+* Status: **Awaiting review**\n+* Impacted Platforms: [Core]\n+\n+## Introduction\n+\n+Rework design of application manager layer to:\n+ - Reduce coupling between components\n+ - Reduce responsibility of ApplicationManager class\n+ - Provide plugin architecture for easy adding additional functionality and RPC groups   \n+\n+## Motivation\n+\n+SDL core project is actively implements new features and new functionality. \n+To keep project on track and reduce rick of regression during implementation\n+some refactoring of application manager layer should be done. \n+\n+### Reduce coupling between components and use dependency injection practice\n+\n+Now Application manager is service locator and need to passed in each component","path":"proposals/nnnn-rpc-design-refactoring.md","position":23,"original_position":23,"commit_id":"8d012290fa502ff7cc425b22c5ffef4a5b2a73c7","original_commit_id":"8d012290fa502ff7cc425b22c5ffef4a5b2a73c7","user":{"login":"AByzhynar","id":6764851,"avatar_url":"https://avatars1.githubusercontent.com/u/6764851?v=4","gravatar_id":"","url":"https://api.github.com/users/AByzhynar","html_url":"https://github.com/AByzhynar","followers_url":"https://api.github.com/users/AByzhynar/followers","following_url":"https://api.github.com/users/AByzhynar/following{/other_user}","gists_url":"https://api.github.com/users/AByzhynar/gists{/gist_id}","starred_url":"https://api.github.com/users/AByzhynar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AByzhynar/subscriptions","organizations_url":"https://api.github.com/users/AByzhynar/orgs","repos_url":"https://api.github.com/users/AByzhynar/repos","events_url":"https://api.github.com/users/AByzhynar/events{/privacy}","received_events_url":"https://api.github.com/users/AByzhynar/received_events","type":"User","site_admin":false},"body":"@LuxoftAKutsan `need to be passed`","created_at":"2018-04-26T13:35:48Z","updated_at":"2018-04-26T13:35:48Z","html_url":"https://github.com/LuxoftAKutsan/sdl_evolution/pull/18#discussion_r184391097","pull_request_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls/18","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls/comments/184391097"},"html":{"href":"https://github.com/LuxoftAKutsan/sdl_evolution/pull/18#discussion_r184391097"},"pull_request":{"href":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls/18","id":184088022,"html_url":"https://github.com/LuxoftAKutsan/sdl_evolution/pull/18","diff_url":"https://github.com/LuxoftAKutsan/sdl_evolution/pull/18.diff","patch_url":"https://github.com/LuxoftAKutsan/sdl_evolution/pull/18.patch","issue_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/issues/18","number":18,"state":"open","locked":false,"title":"Rpc design refactoring","user":{"login":"LuxoftAKutsan","id":11158563,"avatar_url":"https://avatars1.githubusercontent.com/u/11158563?v=4","gravatar_id":"","url":"https://api.github.com/users/LuxoftAKutsan","html_url":"https://github.com/LuxoftAKutsan","followers_url":"https://api.github.com/users/LuxoftAKutsan/followers","following_url":"https://api.github.com/users/LuxoftAKutsan/following{/other_user}","gists_url":"https://api.github.com/users/LuxoftAKutsan/gists{/gist_id}","starred_url":"https://api.github.com/users/LuxoftAKutsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuxoftAKutsan/subscriptions","organizations_url":"https://api.github.com/users/LuxoftAKutsan/orgs","repos_url":"https://api.github.com/users/LuxoftAKutsan/repos","events_url":"https://api.github.com/users/LuxoftAKutsan/events{/privacy}","received_events_url":"https://api.github.com/users/LuxoftAKutsan/received_events","type":"User","site_admin":false},"body":"SDL refactoring done within RC implementation","created_at":"2018-04-25T16:09:39Z","updated_at":"2018-04-26T13:35:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65ff85cb841cd4e363e094a828d1182fe1ce2419","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls/18/commits","review_comments_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls/18/comments","review_comment_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/issues/18/comments","statuses_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/statuses/8d012290fa502ff7cc425b22c5ffef4a5b2a73c7","head":{"label":"LuxoftAKutsan:rpc_design_refactoring","ref":"rpc_design_refactoring","sha":"8d012290fa502ff7cc425b22c5ffef4a5b2a73c7","user":{"login":"LuxoftAKutsan","id":11158563,"avatar_url":"https://avatars1.githubusercontent.com/u/11158563?v=4","gravatar_id":"","url":"https://api.github.com/users/LuxoftAKutsan","html_url":"https://github.com/LuxoftAKutsan","followers_url":"https://api.github.com/users/LuxoftAKutsan/followers","following_url":"https://api.github.com/users/LuxoftAKutsan/following{/other_user}","gists_url":"https://api.github.com/users/LuxoftAKutsan/gists{/gist_id}","starred_url":"https://api.github.com/users/LuxoftAKutsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuxoftAKutsan/subscriptions","organizations_url":"https://api.github.com/users/LuxoftAKutsan/orgs","repos_url":"https://api.github.com/users/LuxoftAKutsan/repos","events_url":"https://api.github.com/users/LuxoftAKutsan/events{/privacy}","received_events_url":"https://api.github.com/users/LuxoftAKutsan/received_events","type":"User","site_admin":false},"repo":{"id":79335838,"name":"sdl_evolution","full_name":"LuxoftAKutsan/sdl_evolution","owner":{"login":"LuxoftAKutsan","id":11158563,"avatar_url":"https://avatars1.githubusercontent.com/u/11158563?v=4","gravatar_id":"","url":"https://api.github.com/users/LuxoftAKutsan","html_url":"https://github.com/LuxoftAKutsan","followers_url":"https://api.github.com/users/LuxoftAKutsan/followers","following_url":"https://api.github.com/users/LuxoftAKutsan/following{/other_user}","gists_url":"https://api.github.com/users/LuxoftAKutsan/gists{/gist_id}","starred_url":"https://api.github.com/users/LuxoftAKutsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuxoftAKutsan/subscriptions","organizations_url":"https://api.github.com/users/LuxoftAKutsan/orgs","repos_url":"https://api.github.com/users/LuxoftAKutsan/repos","events_url":"https://api.github.com/users/LuxoftAKutsan/events{/privacy}","received_events_url":"https://api.github.com/users/LuxoftAKutsan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LuxoftAKutsan/sdl_evolution","description":"Tracking and proposing changes to SDL's public APIs.","fork":true,"url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution","forks_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/forks","keys_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/teams","hooks_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/hooks","issue_events_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/issues/events{/number}","events_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/events","assignees_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/assignees{/user}","branches_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/branches{/branch}","tags_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/tags","blobs_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/statuses/{sha}","languages_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/languages","stargazers_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/stargazers","contributors_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/contributors","subscribers_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/subscribers","subscription_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/subscription","commits_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/contents/{+path}","compare_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/merges","archive_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/downloads","issues_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/issues{/number}","pulls_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls{/number}","milestones_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/milestones{/number}","notifications_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/labels{/name}","releases_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/releases{/id}","deployments_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/deployments","created_at":"2017-01-18T12:00:54Z","updated_at":"2018-04-24T16:12:08Z","pushed_at":"2018-04-25T16:09:40Z","git_url":"git://github.com/LuxoftAKutsan/sdl_evolution.git","ssh_url":"git@github.com:LuxoftAKutsan/sdl_evolution.git","clone_url":"https://github.com/LuxoftAKutsan/sdl_evolution.git","svn_url":"https://github.com/LuxoftAKutsan/sdl_evolution","homepage":"https://smartdevicelink.github.io/sdl_evolution/","size":8640,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"LuxoftAKutsan:master","ref":"master","sha":"4d9e1fbb48d9199eb6dd3b685983d964b617e1fa","user":{"login":"LuxoftAKutsan","id":11158563,"avatar_url":"https://avatars1.githubusercontent.com/u/11158563?v=4","gravatar_id":"","url":"https://api.github.com/users/LuxoftAKutsan","html_url":"https://github.com/LuxoftAKutsan","followers_url":"https://api.github.com/users/LuxoftAKutsan/followers","following_url":"https://api.github.com/users/LuxoftAKutsan/following{/other_user}","gists_url":"https://api.github.com/users/LuxoftAKutsan/gists{/gist_id}","starred_url":"https://api.github.com/users/LuxoftAKutsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuxoftAKutsan/subscriptions","organizations_url":"https://api.github.com/users/LuxoftAKutsan/orgs","repos_url":"https://api.github.com/users/LuxoftAKutsan/repos","events_url":"https://api.github.com/users/LuxoftAKutsan/events{/privacy}","received_events_url":"https://api.github.com/users/LuxoftAKutsan/received_events","type":"User","site_admin":false},"repo":{"id":79335838,"name":"sdl_evolution","full_name":"LuxoftAKutsan/sdl_evolution","owner":{"login":"LuxoftAKutsan","id":11158563,"avatar_url":"https://avatars1.githubusercontent.com/u/11158563?v=4","gravatar_id":"","url":"https://api.github.com/users/LuxoftAKutsan","html_url":"https://github.com/LuxoftAKutsan","followers_url":"https://api.github.com/users/LuxoftAKutsan/followers","following_url":"https://api.github.com/users/LuxoftAKutsan/following{/other_user}","gists_url":"https://api.github.com/users/LuxoftAKutsan/gists{/gist_id}","starred_url":"https://api.github.com/users/LuxoftAKutsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuxoftAKutsan/subscriptions","organizations_url":"https://api.github.com/users/LuxoftAKutsan/orgs","repos_url":"https://api.github.com/users/LuxoftAKutsan/repos","events_url":"https://api.github.com/users/LuxoftAKutsan/events{/privacy}","received_events_url":"https://api.github.com/users/LuxoftAKutsan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LuxoftAKutsan/sdl_evolution","description":"Tracking and proposing changes to SDL's public APIs.","fork":true,"url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution","forks_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/forks","keys_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/teams","hooks_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/hooks","issue_events_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/issues/events{/number}","events_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/events","assignees_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/assignees{/user}","branches_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/branches{/branch}","tags_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/tags","blobs_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/statuses/{sha}","languages_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/languages","stargazers_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/stargazers","contributors_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/contributors","subscribers_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/subscribers","subscription_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/subscription","commits_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/contents/{+path}","compare_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/merges","archive_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/downloads","issues_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/issues{/number}","pulls_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls{/number}","milestones_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/milestones{/number}","notifications_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/labels{/name}","releases_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/releases{/id}","deployments_url":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/deployments","created_at":"2017-01-18T12:00:54Z","updated_at":"2018-04-24T16:12:08Z","pushed_at":"2018-04-25T16:09:40Z","git_url":"git://github.com/LuxoftAKutsan/sdl_evolution.git","ssh_url":"git@github.com:LuxoftAKutsan/sdl_evolution.git","clone_url":"https://github.com/LuxoftAKutsan/sdl_evolution.git","svn_url":"https://github.com/LuxoftAKutsan/sdl_evolution","homepage":"https://smartdevicelink.github.io/sdl_evolution/","size":8640,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls/18"},"html":{"href":"https://github.com/LuxoftAKutsan/sdl_evolution/pull/18"},"issue":{"href":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/issues/18"},"comments":{"href":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/LuxoftAKutsan/sdl_evolution/statuses/8d012290fa502ff7cc425b22c5ffef4a5b2a73c7"}},"author_association":"OWNER"}}
{"actor":{"display_login":"AByzhynar"}}