{"action":"created","comment":{"url":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls/comments/199677476","pull_request_review_id":133841970,"id":199677476,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTY3NzQ3Ng==","diff_hunk":"@@ -29,7 +29,8 @@ <h4 class=\"card-title\" id=\"from-actions-top-left\">Created Users</h4>\n                     <tr>\n                         <td th:text=\"${user.name}\"></td>\n                         <td th:text=\"${user.userId}\"></td>\n-                        <td th:text=\"${user.createdAt != null ? user.createdAt : user.updatedAt }\"></td>\n+                        <td th:text=\"${user.createdAt != null ?","path":"src/main/resources/templates/dean/fragments/user_table.html","position":5,"original_position":5,"commit_id":"632d140bb4c3daa755935ab55749616c75fd61a8","original_commit_id":"632d140bb4c3daa755935ab55749616c75fd61a8","user":{"login":"mohdomama","id":21140415,"node_id":"MDQ6VXNlcjIxMTQwNDE1","avatar_url":"https://avatars3.githubusercontent.com/u/21140415?v=4","gravatar_id":"","url":"https://api.github.com/users/mohdomama","html_url":"https://github.com/mohdomama","followers_url":"https://api.github.com/users/mohdomama/followers","following_url":"https://api.github.com/users/mohdomama/following{/other_user}","gists_url":"https://api.github.com/users/mohdomama/gists{/gist_id}","starred_url":"https://api.github.com/users/mohdomama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohdomama/subscriptions","organizations_url":"https://api.github.com/users/mohdomama/orgs","repos_url":"https://api.github.com/users/mohdomama/repos","events_url":"https://api.github.com/users/mohdomama/events{/privacy}","received_events_url":"https://api.github.com/users/mohdomama/received_events","type":"User","site_admin":false},"body":"This means that if `createdAt` is not null, display `createdAt`. Else display `updatedAt`. Shouldn't it be the other way round?  ","created_at":"2018-07-03T03:55:59Z","updated_at":"2018-07-03T03:55:59Z","html_url":"https://github.com/zhcet-amu/zhcet-web/pull/138#discussion_r199677476","pull_request_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls/138","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls/comments/199677476"},"html":{"href":"https://github.com/zhcet-amu/zhcet-web/pull/138#discussion_r199677476"},"pull_request":{"href":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls/138"}}},"pull_request":{"url":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls/138","id":198615058,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NjE1MDU4","html_url":"https://github.com/zhcet-amu/zhcet-web/pull/138","diff_url":"https://github.com/zhcet-amu/zhcet-web/pull/138.diff","patch_url":"https://github.com/zhcet-amu/zhcet-web/pull/138.patch","issue_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/issues/138","number":138,"state":"open","locked":false,"title":"fix: improve date display in dean/admin","user":{"login":"mohdomama","id":21140415,"node_id":"MDQ6VXNlcjIxMTQwNDE1","avatar_url":"https://avatars3.githubusercontent.com/u/21140415?v=4","gravatar_id":"","url":"https://api.github.com/users/mohdomama","html_url":"https://github.com/mohdomama","followers_url":"https://api.github.com/users/mohdomama/followers","following_url":"https://api.github.com/users/mohdomama/following{/other_user}","gists_url":"https://api.github.com/users/mohdomama/gists{/gist_id}","starred_url":"https://api.github.com/users/mohdomama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohdomama/subscriptions","organizations_url":"https://api.github.com/users/mohdomama/orgs","repos_url":"https://api.github.com/users/mohdomama/repos","events_url":"https://api.github.com/users/mohdomama/events{/privacy}","received_events_url":"https://api.github.com/users/mohdomama/received_events","type":"User","site_admin":false},"body":"fixes #138 \r\nAs of now I am displaying date and time in two different columns. It can be made prettier with `DateTimeFormatter`. For that, either I have to add a new field in `BaseEntity`model which returns a formatted date and time or pass the `DateTimeFormatter` object in the view itself and format the date there. Which will be better ?","created_at":"2018-07-02T09:06:41Z","updated_at":"2018-07-03T03:55:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07651cb8cc02c93ed0203bbca7b4c41db4bf6733","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls/138/commits","review_comments_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls/138/comments","review_comment_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/issues/138/comments","statuses_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/statuses/632d140bb4c3daa755935ab55749616c75fd61a8","head":{"label":"mohdomama:fix_date_display","ref":"fix_date_display","sha":"632d140bb4c3daa755935ab55749616c75fd61a8","user":{"login":"mohdomama","id":21140415,"node_id":"MDQ6VXNlcjIxMTQwNDE1","avatar_url":"https://avatars3.githubusercontent.com/u/21140415?v=4","gravatar_id":"","url":"https://api.github.com/users/mohdomama","html_url":"https://github.com/mohdomama","followers_url":"https://api.github.com/users/mohdomama/followers","following_url":"https://api.github.com/users/mohdomama/following{/other_user}","gists_url":"https://api.github.com/users/mohdomama/gists{/gist_id}","starred_url":"https://api.github.com/users/mohdomama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohdomama/subscriptions","organizations_url":"https://api.github.com/users/mohdomama/orgs","repos_url":"https://api.github.com/users/mohdomama/repos","events_url":"https://api.github.com/users/mohdomama/events{/privacy}","received_events_url":"https://api.github.com/users/mohdomama/received_events","type":"User","site_admin":false},"repo":{"id":136273860,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyNzM4NjA=","name":"zhcet-web","full_name":"mohdomama/zhcet-web","owner":{"login":"mohdomama","id":21140415,"node_id":"MDQ6VXNlcjIxMTQwNDE1","avatar_url":"https://avatars3.githubusercontent.com/u/21140415?v=4","gravatar_id":"","url":"https://api.github.com/users/mohdomama","html_url":"https://github.com/mohdomama","followers_url":"https://api.github.com/users/mohdomama/followers","following_url":"https://api.github.com/users/mohdomama/following{/other_user}","gists_url":"https://api.github.com/users/mohdomama/gists{/gist_id}","starred_url":"https://api.github.com/users/mohdomama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohdomama/subscriptions","organizations_url":"https://api.github.com/users/mohdomama/orgs","repos_url":"https://api.github.com/users/mohdomama/repos","events_url":"https://api.github.com/users/mohdomama/events{/privacy}","received_events_url":"https://api.github.com/users/mohdomama/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mohdomama/zhcet-web","description":"A spring boot server for college management","fork":true,"url":"https://api.github.com/repos/mohdomama/zhcet-web","forks_url":"https://api.github.com/repos/mohdomama/zhcet-web/forks","keys_url":"https://api.github.com/repos/mohdomama/zhcet-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mohdomama/zhcet-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mohdomama/zhcet-web/teams","hooks_url":"https://api.github.com/repos/mohdomama/zhcet-web/hooks","issue_events_url":"https://api.github.com/repos/mohdomama/zhcet-web/issues/events{/number}","events_url":"https://api.github.com/repos/mohdomama/zhcet-web/events","assignees_url":"https://api.github.com/repos/mohdomama/zhcet-web/assignees{/user}","branches_url":"https://api.github.com/repos/mohdomama/zhcet-web/branches{/branch}","tags_url":"https://api.github.com/repos/mohdomama/zhcet-web/tags","blobs_url":"https://api.github.com/repos/mohdomama/zhcet-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mohdomama/zhcet-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mohdomama/zhcet-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/mohdomama/zhcet-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mohdomama/zhcet-web/statuses/{sha}","languages_url":"https://api.github.com/repos/mohdomama/zhcet-web/languages","stargazers_url":"https://api.github.com/repos/mohdomama/zhcet-web/stargazers","contributors_url":"https://api.github.com/repos/mohdomama/zhcet-web/contributors","subscribers_url":"https://api.github.com/repos/mohdomama/zhcet-web/subscribers","subscription_url":"https://api.github.com/repos/mohdomama/zhcet-web/subscription","commits_url":"https://api.github.com/repos/mohdomama/zhcet-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/mohdomama/zhcet-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/mohdomama/zhcet-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/mohdomama/zhcet-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/mohdomama/zhcet-web/contents/{+path}","compare_url":"https://api.github.com/repos/mohdomama/zhcet-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mohdomama/zhcet-web/merges","archive_url":"https://api.github.com/repos/mohdomama/zhcet-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mohdomama/zhcet-web/downloads","issues_url":"https://api.github.com/repos/mohdomama/zhcet-web/issues{/number}","pulls_url":"https://api.github.com/repos/mohdomama/zhcet-web/pulls{/number}","milestones_url":"https://api.github.com/repos/mohdomama/zhcet-web/milestones{/number}","notifications_url":"https://api.github.com/repos/mohdomama/zhcet-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mohdomama/zhcet-web/labels{/name}","releases_url":"https://api.github.com/repos/mohdomama/zhcet-web/releases{/id}","deployments_url":"https://api.github.com/repos/mohdomama/zhcet-web/deployments","created_at":"2018-06-06T04:57:15Z","updated_at":"2018-07-02T08:59:41Z","pushed_at":"2018-07-03T03:47:46Z","git_url":"git://github.com/mohdomama/zhcet-web.git","ssh_url":"git@github.com:mohdomama/zhcet-web.git","clone_url":"https://github.com/mohdomama/zhcet-web.git","svn_url":"https://github.com/mohdomama/zhcet-web","homepage":"https://zhcet.herokuapp.com","size":2237,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zhcet-amu:master","ref":"master","sha":"4c36fe4a4d990ddcca54591857e6a7c625ab395f","user":{"login":"zhcet-amu","id":32874388,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODc0Mzg4","avatar_url":"https://avatars3.githubusercontent.com/u/32874388?v=4","gravatar_id":"","url":"https://api.github.com/users/zhcet-amu","html_url":"https://github.com/zhcet-amu","followers_url":"https://api.github.com/users/zhcet-amu/followers","following_url":"https://api.github.com/users/zhcet-amu/following{/other_user}","gists_url":"https://api.github.com/users/zhcet-amu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhcet-amu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhcet-amu/subscriptions","organizations_url":"https://api.github.com/users/zhcet-amu/orgs","repos_url":"https://api.github.com/users/zhcet-amu/repos","events_url":"https://api.github.com/users/zhcet-amu/events{/privacy}","received_events_url":"https://api.github.com/users/zhcet-amu/received_events","type":"Organization","site_admin":false},"repo":{"id":93876837,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg3NjgzNw==","name":"zhcet-web","full_name":"zhcet-amu/zhcet-web","owner":{"login":"zhcet-amu","id":32874388,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODc0Mzg4","avatar_url":"https://avatars3.githubusercontent.com/u/32874388?v=4","gravatar_id":"","url":"https://api.github.com/users/zhcet-amu","html_url":"https://github.com/zhcet-amu","followers_url":"https://api.github.com/users/zhcet-amu/followers","following_url":"https://api.github.com/users/zhcet-amu/following{/other_user}","gists_url":"https://api.github.com/users/zhcet-amu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhcet-amu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhcet-amu/subscriptions","organizations_url":"https://api.github.com/users/zhcet-amu/orgs","repos_url":"https://api.github.com/users/zhcet-amu/repos","events_url":"https://api.github.com/users/zhcet-amu/events{/privacy}","received_events_url":"https://api.github.com/users/zhcet-amu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zhcet-amu/zhcet-web","description":"A spring boot server for college management","fork":false,"url":"https://api.github.com/repos/zhcet-amu/zhcet-web","forks_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/forks","keys_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/teams","hooks_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/hooks","issue_events_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/issues/events{/number}","events_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/events","assignees_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/assignees{/user}","branches_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/branches{/branch}","tags_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/tags","blobs_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/statuses/{sha}","languages_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/languages","stargazers_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/stargazers","contributors_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/contributors","subscribers_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/subscribers","subscription_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/subscription","commits_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/contents/{+path}","compare_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/merges","archive_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/downloads","issues_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/issues{/number}","pulls_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls{/number}","milestones_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/milestones{/number}","notifications_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/labels{/name}","releases_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/releases{/id}","deployments_url":"https://api.github.com/repos/zhcet-amu/zhcet-web/deployments","created_at":"2017-06-09T16:20:11Z","updated_at":"2018-06-30T13:22:19Z","pushed_at":"2018-07-03T03:47:47Z","git_url":"git://github.com/zhcet-amu/zhcet-web.git","ssh_url":"git@github.com:zhcet-amu/zhcet-web.git","clone_url":"https://github.com/zhcet-amu/zhcet-web.git","svn_url":"https://github.com/zhcet-amu/zhcet-web","homepage":"https://zhcet.herokuapp.com","size":2242,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls/138"},"html":{"href":"https://github.com/zhcet-amu/zhcet-web/pull/138"},"issue":{"href":"https://api.github.com/repos/zhcet-amu/zhcet-web/issues/138"},"comments":{"href":"https://api.github.com/repos/zhcet-amu/zhcet-web/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zhcet-amu/zhcet-web/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/zhcet-amu/zhcet-web/statuses/632d140bb4c3daa755935ab55749616c75fd61a8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mohdomama"}}