{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/218244496","pull_request_review_id":156139652,"id":218244496,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODI0NDQ5Ng==","diff_hunk":"@@ -534,7 +534,7 @@ public RoleMappedData(IDataView data, IEnumerable<KeyValuePair<RoleMappedSchema.\n         /// <param name=\"opt\">Whether to consider the column names specified \"optional\" or not. If <c>false</c> then any non-empty\n         /// values for the column names that does not appear in <paramref name=\"data\"/>'s schema will result in an exception being thrown,\n         /// but if <c>true</c> such values will be ignored</param>\n-        public RoleMappedData(IDataView data, string label, string feature,\n+        public RoleMappedData(IDataView data, string label, string feature = null,","path":"src/Microsoft.ML.Core/Data/RoleMappedSchema.cs","position":5,"original_position":5,"commit_id":"77392ee3e8ed91742c0c94c982225ccb344e69c0","original_commit_id":"77392ee3e8ed91742c0c94c982225ccb344e69c0","user":{"login":"artidoro","id":11949572,"node_id":"MDQ6VXNlcjExOTQ5NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/11949572?v=4","gravatar_id":"","url":"https://api.github.com/users/artidoro","html_url":"https://github.com/artidoro","followers_url":"https://api.github.com/users/artidoro/followers","following_url":"https://api.github.com/users/artidoro/following{/other_user}","gists_url":"https://api.github.com/users/artidoro/gists{/gist_id}","starred_url":"https://api.github.com/users/artidoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artidoro/subscriptions","organizations_url":"https://api.github.com/users/artidoro/orgs","repos_url":"https://api.github.com/users/artidoro/repos","events_url":"https://api.github.com/users/artidoro/events{/privacy}","received_events_url":"https://api.github.com/users/artidoro/received_events","type":"User","site_admin":false},"body":"I will handle this in my code then! Sorry about that\r\n\r\n---\r\nIn reply to: [218244002](https://github.com/dotnet/machinelearning/pull/876#discussion_r218244002) [](ancestors = 218244002)","created_at":"2018-09-17T22:12:19Z","updated_at":"2018-09-17T22:12:19Z","html_url":"https://github.com/dotnet/machinelearning/pull/876#discussion_r218244496","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/876","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/218244496"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/876#discussion_r218244496"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/876"}},"in_reply_to_id":218244002},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/876","id":214460271,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDYwMjcx","html_url":"https://github.com/dotnet/machinelearning/pull/876","diff_url":"https://github.com/dotnet/machinelearning/pull/876.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/876.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/876","number":876,"state":"open","locked":false,"title":"Conversion of prior and random trainers to estimators","user":{"login":"artidoro","id":11949572,"node_id":"MDQ6VXNlcjExOTQ5NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/11949572?v=4","gravatar_id":"","url":"https://api.github.com/users/artidoro","html_url":"https://github.com/artidoro","followers_url":"https://api.github.com/users/artidoro/followers","following_url":"https://api.github.com/users/artidoro/following{/other_user}","gists_url":"https://api.github.com/users/artidoro/gists{/gist_id}","starred_url":"https://api.github.com/users/artidoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artidoro/subscriptions","organizations_url":"https://api.github.com/users/artidoro/orgs","repos_url":"https://api.github.com/users/artidoro/repos","events_url":"https://api.github.com/users/artidoro/events{/privacy}","received_events_url":"https://api.github.com/users/artidoro/received_events","type":"User","site_admin":false},"body":"Fixes #875.\r\n\r\nConverted prior and random trainers to estimators. \r\nI still need to write the tests and am working on that now, but any comments are more than welcome in the meantime.\r\n\r\n","created_at":"2018-09-10T22:17:27Z","updated_at":"2018-09-17T22:12:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0265d89dcd66c85e3c3dc1e3711024e101de7e72","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/876/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/876/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/876/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/77392ee3e8ed91742c0c94c982225ccb344e69c0","head":{"label":"artidoro:estimators","ref":"estimators","sha":"77392ee3e8ed91742c0c94c982225ccb344e69c0","user":{"login":"artidoro","id":11949572,"node_id":"MDQ6VXNlcjExOTQ5NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/11949572?v=4","gravatar_id":"","url":"https://api.github.com/users/artidoro","html_url":"https://github.com/artidoro","followers_url":"https://api.github.com/users/artidoro/followers","following_url":"https://api.github.com/users/artidoro/following{/other_user}","gists_url":"https://api.github.com/users/artidoro/gists{/gist_id}","starred_url":"https://api.github.com/users/artidoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artidoro/subscriptions","organizations_url":"https://api.github.com/users/artidoro/orgs","repos_url":"https://api.github.com/users/artidoro/repos","events_url":"https://api.github.com/users/artidoro/events{/privacy}","received_events_url":"https://api.github.com/users/artidoro/received_events","type":"User","site_admin":false},"repo":{"id":146929905,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5Mjk5MDU=","name":"machinelearning","full_name":"artidoro/machinelearning","private":false,"owner":{"login":"artidoro","id":11949572,"node_id":"MDQ6VXNlcjExOTQ5NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/11949572?v=4","gravatar_id":"","url":"https://api.github.com/users/artidoro","html_url":"https://github.com/artidoro","followers_url":"https://api.github.com/users/artidoro/followers","following_url":"https://api.github.com/users/artidoro/following{/other_user}","gists_url":"https://api.github.com/users/artidoro/gists{/gist_id}","starred_url":"https://api.github.com/users/artidoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artidoro/subscriptions","organizations_url":"https://api.github.com/users/artidoro/orgs","repos_url":"https://api.github.com/users/artidoro/repos","events_url":"https://api.github.com/users/artidoro/events{/privacy}","received_events_url":"https://api.github.com/users/artidoro/received_events","type":"User","site_admin":false},"html_url":"https://github.com/artidoro/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/artidoro/machinelearning","forks_url":"https://api.github.com/repos/artidoro/machinelearning/forks","keys_url":"https://api.github.com/repos/artidoro/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artidoro/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artidoro/machinelearning/teams","hooks_url":"https://api.github.com/repos/artidoro/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/artidoro/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/artidoro/machinelearning/events","assignees_url":"https://api.github.com/repos/artidoro/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/artidoro/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/artidoro/machinelearning/tags","blobs_url":"https://api.github.com/repos/artidoro/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artidoro/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artidoro/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/artidoro/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artidoro/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/artidoro/machinelearning/languages","stargazers_url":"https://api.github.com/repos/artidoro/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/artidoro/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/artidoro/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/artidoro/machinelearning/subscription","commits_url":"https://api.github.com/repos/artidoro/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/artidoro/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/artidoro/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/artidoro/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/artidoro/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/artidoro/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artidoro/machinelearning/merges","archive_url":"https://api.github.com/repos/artidoro/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artidoro/machinelearning/downloads","issues_url":"https://api.github.com/repos/artidoro/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/artidoro/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/artidoro/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/artidoro/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artidoro/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/artidoro/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/artidoro/machinelearning/deployments","created_at":"2018-08-31T18:37:49Z","updated_at":"2018-09-04T23:11:36Z","pushed_at":"2018-09-17T22:08:01Z","git_url":"git://github.com/artidoro/machinelearning.git","ssh_url":"git@github.com:artidoro/machinelearning.git","clone_url":"https://github.com/artidoro/machinelearning.git","svn_url":"https://github.com/artidoro/machinelearning","homepage":"https://dot.net/ml","size":22223,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a8b844ccee21b7639e1b0c24fefd1e69088f0d7e","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2018-09-17T21:15:06Z","pushed_at":"2018-09-17T22:08:03Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"git@github.com:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":22166,"stargazers_count":3632,"watchers_count":3632,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":577,"mirror_url":null,"archived":false,"open_issues_count":303,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":577,"open_issues":303,"watchers":3632,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/876"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/876"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/876"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/876/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/876/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/876/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/77392ee3e8ed91742c0c94c982225ccb344e69c0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"artidoro"}}