{"action":"opened","number":225,"pull_request":{"url":"https://api.github.com/repos/kiali/kiali/pulls/225","id":191049777,"html_url":"https://github.com/kiali/kiali/pull/225","diff_url":"https://github.com/kiali/kiali/pull/225.diff","patch_url":"https://github.com/kiali/kiali/pull/225.patch","issue_url":"https://api.github.com/repos/kiali/kiali/issues/225","number":225,"state":"open","locked":false,"title":"Fix data races","user":{"login":"simonpasquier","id":2587585,"avatar_url":"https://avatars1.githubusercontent.com/u/2587585?v=4","gravatar_id":"","url":"https://api.github.com/users/simonpasquier","html_url":"https://github.com/simonpasquier","followers_url":"https://api.github.com/users/simonpasquier/followers","following_url":"https://api.github.com/users/simonpasquier/following{/other_user}","gists_url":"https://api.github.com/users/simonpasquier/gists{/gist_id}","starred_url":"https://api.github.com/users/simonpasquier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonpasquier/subscriptions","organizations_url":"https://api.github.com/users/simonpasquier/orgs","repos_url":"https://api.github.com/users/simonpasquier/repos","events_url":"https://api.github.com/users/simonpasquier/events{/privacy}","received_events_url":"https://api.github.com/users/simonpasquier/received_events","type":"User","site_admin":false},"body":"This PR adds a Makefile target (`make test-race`) to run the tests with [race detection](https://golang.org/doc/articles/race_detector.html) enabled. It also fixes the reported data races. It might be good in the future to use this target with the CI as it can surface problems that are hard to debug in live conditions.","created_at":"2018-05-29T07:03:13Z","updated_at":"2018-05-29T07:03:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali/pulls/225/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali/pulls/225/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali/issues/225/comments","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/3a7e30323003d26980105e6af9661a0fc6975842","head":{"label":"simonpasquier:fix-data-races","ref":"fix-data-races","sha":"3a7e30323003d26980105e6af9661a0fc6975842","user":{"login":"simonpasquier","id":2587585,"avatar_url":"https://avatars1.githubusercontent.com/u/2587585?v=4","gravatar_id":"","url":"https://api.github.com/users/simonpasquier","html_url":"https://github.com/simonpasquier","followers_url":"https://api.github.com/users/simonpasquier/followers","following_url":"https://api.github.com/users/simonpasquier/following{/other_user}","gists_url":"https://api.github.com/users/simonpasquier/gists{/gist_id}","starred_url":"https://api.github.com/users/simonpasquier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonpasquier/subscriptions","organizations_url":"https://api.github.com/users/simonpasquier/orgs","repos_url":"https://api.github.com/users/simonpasquier/repos","events_url":"https://api.github.com/users/simonpasquier/events{/privacy}","received_events_url":"https://api.github.com/users/simonpasquier/received_events","type":"User","site_admin":false},"repo":{"id":135253702,"name":"kiali","full_name":"simonpasquier/kiali","owner":{"login":"simonpasquier","id":2587585,"avatar_url":"https://avatars1.githubusercontent.com/u/2587585?v=4","gravatar_id":"","url":"https://api.github.com/users/simonpasquier","html_url":"https://github.com/simonpasquier","followers_url":"https://api.github.com/users/simonpasquier/followers","following_url":"https://api.github.com/users/simonpasquier/following{/other_user}","gists_url":"https://api.github.com/users/simonpasquier/gists{/gist_id}","starred_url":"https://api.github.com/users/simonpasquier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonpasquier/subscriptions","organizations_url":"https://api.github.com/users/simonpasquier/orgs","repos_url":"https://api.github.com/users/simonpasquier/repos","events_url":"https://api.github.com/users/simonpasquier/events{/privacy}","received_events_url":"https://api.github.com/users/simonpasquier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simonpasquier/kiali","description":"Kiali project","fork":true,"url":"https://api.github.com/repos/simonpasquier/kiali","forks_url":"https://api.github.com/repos/simonpasquier/kiali/forks","keys_url":"https://api.github.com/repos/simonpasquier/kiali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonpasquier/kiali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonpasquier/kiali/teams","hooks_url":"https://api.github.com/repos/simonpasquier/kiali/hooks","issue_events_url":"https://api.github.com/repos/simonpasquier/kiali/issues/events{/number}","events_url":"https://api.github.com/repos/simonpasquier/kiali/events","assignees_url":"https://api.github.com/repos/simonpasquier/kiali/assignees{/user}","branches_url":"https://api.github.com/repos/simonpasquier/kiali/branches{/branch}","tags_url":"https://api.github.com/repos/simonpasquier/kiali/tags","blobs_url":"https://api.github.com/repos/simonpasquier/kiali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonpasquier/kiali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonpasquier/kiali/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonpasquier/kiali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonpasquier/kiali/statuses/{sha}","languages_url":"https://api.github.com/repos/simonpasquier/kiali/languages","stargazers_url":"https://api.github.com/repos/simonpasquier/kiali/stargazers","contributors_url":"https://api.github.com/repos/simonpasquier/kiali/contributors","subscribers_url":"https://api.github.com/repos/simonpasquier/kiali/subscribers","subscription_url":"https://api.github.com/repos/simonpasquier/kiali/subscription","commits_url":"https://api.github.com/repos/simonpasquier/kiali/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonpasquier/kiali/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonpasquier/kiali/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonpasquier/kiali/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonpasquier/kiali/contents/{+path}","compare_url":"https://api.github.com/repos/simonpasquier/kiali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonpasquier/kiali/merges","archive_url":"https://api.github.com/repos/simonpasquier/kiali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonpasquier/kiali/downloads","issues_url":"https://api.github.com/repos/simonpasquier/kiali/issues{/number}","pulls_url":"https://api.github.com/repos/simonpasquier/kiali/pulls{/number}","milestones_url":"https://api.github.com/repos/simonpasquier/kiali/milestones{/number}","notifications_url":"https://api.github.com/repos/simonpasquier/kiali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonpasquier/kiali/labels{/name}","releases_url":"https://api.github.com/repos/simonpasquier/kiali/releases{/id}","deployments_url":"https://api.github.com/repos/simonpasquier/kiali/deployments","created_at":"2018-05-29T06:52:08Z","updated_at":"2018-05-29T06:52:10Z","pushed_at":"2018-05-29T06:53:01Z","git_url":"git://github.com/simonpasquier/kiali.git","ssh_url":"git@github.com:simonpasquier/kiali.git","clone_url":"https://github.com/simonpasquier/kiali.git","svn_url":"https://github.com/simonpasquier/kiali","homepage":"","size":10735,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"66fdc778d797e9b0743c5583763de81f96ab663d","user":{"login":"kiali","id":36001875,"avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120181748,"name":"kiali","full_name":"kiali/kiali","owner":{"login":"kiali","id":36001875,"avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiali/kiali","description":"Kiali project","fork":false,"url":"https://api.github.com/repos/kiali/kiali","forks_url":"https://api.github.com/repos/kiali/kiali/forks","keys_url":"https://api.github.com/repos/kiali/kiali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali/teams","hooks_url":"https://api.github.com/repos/kiali/kiali/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali/events","assignees_url":"https://api.github.com/repos/kiali/kiali/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali/tags","blobs_url":"https://api.github.com/repos/kiali/kiali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali/subscription","commits_url":"https://api.github.com/repos/kiali/kiali/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali/merges","archive_url":"https://api.github.com/repos/kiali/kiali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali/downloads","issues_url":"https://api.github.com/repos/kiali/kiali/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali/deployments","created_at":"2018-02-04T12:11:57Z","updated_at":"2018-05-28T15:37:22Z","pushed_at":"2018-05-28T18:45:42Z","git_url":"git://github.com/kiali/kiali.git","ssh_url":"git@github.com:kiali/kiali.git","clone_url":"https://github.com/kiali/kiali.git","svn_url":"https://github.com/kiali/kiali","homepage":"","size":10735,"stargazers_count":53,"watchers_count":53,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":22,"open_issues":17,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali/pulls/225"},"html":{"href":"https://github.com/kiali/kiali/pull/225"},"issue":{"href":"https://api.github.com/repos/kiali/kiali/issues/225"},"comments":{"href":"https://api.github.com/repos/kiali/kiali/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali/statuses/3a7e30323003d26980105e6af9661a0fc6975842"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":179,"deletions":214,"changed_files":11}}
{"actor":{"display_login":"simonpasquier"}}