{"action":"opened","number":330,"pull_request":{"url":"https://api.github.com/repos/jetstack/tarmak/pulls/330","id":196365950,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MzY1OTUw","html_url":"https://github.com/jetstack/tarmak/pull/330","diff_url":"https://github.com/jetstack/tarmak/pull/330.diff","patch_url":"https://github.com/jetstack/tarmak/pull/330.patch","issue_url":"https://api.github.com/repos/jetstack/tarmak/issues/330","number":330,"state":"open","locked":false,"title":"Fix duplicate ELB name error","user":{"login":"MattiasGees","id":2216724,"node_id":"MDQ6VXNlcjIyMTY3MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2216724?v=4","gravatar_id":"","url":"https://api.github.com/users/MattiasGees","html_url":"https://github.com/MattiasGees","followers_url":"https://api.github.com/users/MattiasGees/followers","following_url":"https://api.github.com/users/MattiasGees/following{/other_user}","gists_url":"https://api.github.com/users/MattiasGees/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiasGees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiasGees/subscriptions","organizations_url":"https://api.github.com/users/MattiasGees/orgs","repos_url":"https://api.github.com/users/MattiasGees/repos","events_url":"https://api.github.com/users/MattiasGees/events{/privacy}","received_events_url":"https://api.github.com/users/MattiasGees/received_events","type":"User","site_admin":false},"body":"\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nWhen you bring up an Jenkins in your cluster, you will get an AWS/Terraform error to tell you that you try to create 2 ELBs with the same name. This changes solves this by adding the Name of the role to the ELB name. This also fixes the double `-` in the name.\r\n\r\n```\r\nDEBU[0136] Error: Error applying plan:  app=tarmak module=terraform std=err\r\nDEBU[0136]                                               app=tarmak module=terraform std=err\r\nDEBU[0136] 1 error occurred:                             app=tarmak module=terraform std=err\r\nDEBU[0136]                                               app=tarmak module=terraform std=err\r\nDEBU[0136] * module.kubernetes.aws_elb.kubernetes_worker: 1 error occurred:  app=tarmak module=terraform std=err\r\nDEBU[0136]                                               app=tarmak module=terraform std=err\r\nDEBU[0136] * aws_elb.kubernetes_worker: DuplicateLoadBalancerName: Load Balancer named mattiasmulticluster--ingress already exists and it is configured with different parameters.  app=tarmak module=terraform std=err\r\nDEBU[0136] \tstatus code: 400, request id: 49e7eaf5-7527-11e8-88b4-d950d7f894c9  app=tarmak module=terraform std=err\r\nDEBU[0136]                                               app=tarmak module=terraform std=err\r\nDEBU[0136] Terraform does not automatically rollback in the face of errors.  app=tarmak module=terraform std=err\r\nDEBU[0136] Instead, your Terraform state file has been partially updated with  app=tarmak module=terraform std=err\r\nDEBU[0136] any resources that successfully completed. Please address the error  app=tarmak module=terraform std=err\r\nDEBU[0136] above and apply again to incrementally change your infrastructure.  app=tarmak module=terraform std=err\r\nDEBU[0136]                                               app=tarmak module=terraform std=err\r\nDEBU[0136]                                   app=tarmak module=terraform std=err\r\nERRO[0136] Tarmak exited with an error: exit status 1    error=\"exit status 1\"\r\n```\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\nThis can be a breaking change, but there is no real way around it I think.\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nFix duplicate ELB name\r\n```\r\n","created_at":"2018-06-21T07:59:31Z","updated_at":"2018-06-21T07:59:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jetstack/tarmak/pulls/330/commits","review_comments_url":"https://api.github.com/repos/jetstack/tarmak/pulls/330/comments","review_comment_url":"https://api.github.com/repos/jetstack/tarmak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jetstack/tarmak/issues/330/comments","statuses_url":"https://api.github.com/repos/jetstack/tarmak/statuses/7ed36aa3aacf61647594076d9eb2a2bfde8b99f4","head":{"label":"MattiasGees:elb-bug","ref":"elb-bug","sha":"7ed36aa3aacf61647594076d9eb2a2bfde8b99f4","user":{"login":"MattiasGees","id":2216724,"node_id":"MDQ6VXNlcjIyMTY3MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2216724?v=4","gravatar_id":"","url":"https://api.github.com/users/MattiasGees","html_url":"https://github.com/MattiasGees","followers_url":"https://api.github.com/users/MattiasGees/followers","following_url":"https://api.github.com/users/MattiasGees/following{/other_user}","gists_url":"https://api.github.com/users/MattiasGees/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiasGees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiasGees/subscriptions","organizations_url":"https://api.github.com/users/MattiasGees/orgs","repos_url":"https://api.github.com/users/MattiasGees/repos","events_url":"https://api.github.com/users/MattiasGees/events{/privacy}","received_events_url":"https://api.github.com/users/MattiasGees/received_events","type":"User","site_admin":false},"repo":{"id":133013190,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwMTMxOTA=","name":"tarmak","full_name":"MattiasGees/tarmak","owner":{"login":"MattiasGees","id":2216724,"node_id":"MDQ6VXNlcjIyMTY3MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2216724?v=4","gravatar_id":"","url":"https://api.github.com/users/MattiasGees","html_url":"https://github.com/MattiasGees","followers_url":"https://api.github.com/users/MattiasGees/followers","following_url":"https://api.github.com/users/MattiasGees/following{/other_user}","gists_url":"https://api.github.com/users/MattiasGees/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiasGees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiasGees/subscriptions","organizations_url":"https://api.github.com/users/MattiasGees/orgs","repos_url":"https://api.github.com/users/MattiasGees/repos","events_url":"https://api.github.com/users/MattiasGees/events{/privacy}","received_events_url":"https://api.github.com/users/MattiasGees/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MattiasGees/tarmak","description":"A toolkit for Kubernetes cluster provisioning and lifecycle management","fork":true,"url":"https://api.github.com/repos/MattiasGees/tarmak","forks_url":"https://api.github.com/repos/MattiasGees/tarmak/forks","keys_url":"https://api.github.com/repos/MattiasGees/tarmak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MattiasGees/tarmak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MattiasGees/tarmak/teams","hooks_url":"https://api.github.com/repos/MattiasGees/tarmak/hooks","issue_events_url":"https://api.github.com/repos/MattiasGees/tarmak/issues/events{/number}","events_url":"https://api.github.com/repos/MattiasGees/tarmak/events","assignees_url":"https://api.github.com/repos/MattiasGees/tarmak/assignees{/user}","branches_url":"https://api.github.com/repos/MattiasGees/tarmak/branches{/branch}","tags_url":"https://api.github.com/repos/MattiasGees/tarmak/tags","blobs_url":"https://api.github.com/repos/MattiasGees/tarmak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MattiasGees/tarmak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MattiasGees/tarmak/git/refs{/sha}","trees_url":"https://api.github.com/repos/MattiasGees/tarmak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MattiasGees/tarmak/statuses/{sha}","languages_url":"https://api.github.com/repos/MattiasGees/tarmak/languages","stargazers_url":"https://api.github.com/repos/MattiasGees/tarmak/stargazers","contributors_url":"https://api.github.com/repos/MattiasGees/tarmak/contributors","subscribers_url":"https://api.github.com/repos/MattiasGees/tarmak/subscribers","subscription_url":"https://api.github.com/repos/MattiasGees/tarmak/subscription","commits_url":"https://api.github.com/repos/MattiasGees/tarmak/commits{/sha}","git_commits_url":"https://api.github.com/repos/MattiasGees/tarmak/git/commits{/sha}","comments_url":"https://api.github.com/repos/MattiasGees/tarmak/comments{/number}","issue_comment_url":"https://api.github.com/repos/MattiasGees/tarmak/issues/comments{/number}","contents_url":"https://api.github.com/repos/MattiasGees/tarmak/contents/{+path}","compare_url":"https://api.github.com/repos/MattiasGees/tarmak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MattiasGees/tarmak/merges","archive_url":"https://api.github.com/repos/MattiasGees/tarmak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MattiasGees/tarmak/downloads","issues_url":"https://api.github.com/repos/MattiasGees/tarmak/issues{/number}","pulls_url":"https://api.github.com/repos/MattiasGees/tarmak/pulls{/number}","milestones_url":"https://api.github.com/repos/MattiasGees/tarmak/milestones{/number}","notifications_url":"https://api.github.com/repos/MattiasGees/tarmak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MattiasGees/tarmak/labels{/name}","releases_url":"https://api.github.com/repos/MattiasGees/tarmak/releases{/id}","deployments_url":"https://api.github.com/repos/MattiasGees/tarmak/deployments","created_at":"2018-05-11T08:36:29Z","updated_at":"2018-06-20T11:14:16Z","pushed_at":"2018-06-21T07:57:47Z","git_url":"git://github.com/MattiasGees/tarmak.git","ssh_url":"git@github.com:MattiasGees/tarmak.git","clone_url":"https://github.com/MattiasGees/tarmak.git","svn_url":"https://github.com/MattiasGees/tarmak","homepage":"","size":83575,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jetstack:master","ref":"master","sha":"dca5cb3fcd40908ad6807da5bf7bc69edc3ea227","user":{"login":"jetstack","id":13183983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTgzOTgz","avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"repo":{"id":96748966,"node_id":"MDEwOlJlcG9zaXRvcnk5Njc0ODk2Ng==","name":"tarmak","full_name":"jetstack/tarmak","owner":{"login":"jetstack","id":13183983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTgzOTgz","avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jetstack/tarmak","description":"A toolkit for Kubernetes cluster provisioning and lifecycle management","fork":false,"url":"https://api.github.com/repos/jetstack/tarmak","forks_url":"https://api.github.com/repos/jetstack/tarmak/forks","keys_url":"https://api.github.com/repos/jetstack/tarmak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jetstack/tarmak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jetstack/tarmak/teams","hooks_url":"https://api.github.com/repos/jetstack/tarmak/hooks","issue_events_url":"https://api.github.com/repos/jetstack/tarmak/issues/events{/number}","events_url":"https://api.github.com/repos/jetstack/tarmak/events","assignees_url":"https://api.github.com/repos/jetstack/tarmak/assignees{/user}","branches_url":"https://api.github.com/repos/jetstack/tarmak/branches{/branch}","tags_url":"https://api.github.com/repos/jetstack/tarmak/tags","blobs_url":"https://api.github.com/repos/jetstack/tarmak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jetstack/tarmak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jetstack/tarmak/git/refs{/sha}","trees_url":"https://api.github.com/repos/jetstack/tarmak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jetstack/tarmak/statuses/{sha}","languages_url":"https://api.github.com/repos/jetstack/tarmak/languages","stargazers_url":"https://api.github.com/repos/jetstack/tarmak/stargazers","contributors_url":"https://api.github.com/repos/jetstack/tarmak/contributors","subscribers_url":"https://api.github.com/repos/jetstack/tarmak/subscribers","subscription_url":"https://api.github.com/repos/jetstack/tarmak/subscription","commits_url":"https://api.github.com/repos/jetstack/tarmak/commits{/sha}","git_commits_url":"https://api.github.com/repos/jetstack/tarmak/git/commits{/sha}","comments_url":"https://api.github.com/repos/jetstack/tarmak/comments{/number}","issue_comment_url":"https://api.github.com/repos/jetstack/tarmak/issues/comments{/number}","contents_url":"https://api.github.com/repos/jetstack/tarmak/contents/{+path}","compare_url":"https://api.github.com/repos/jetstack/tarmak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jetstack/tarmak/merges","archive_url":"https://api.github.com/repos/jetstack/tarmak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jetstack/tarmak/downloads","issues_url":"https://api.github.com/repos/jetstack/tarmak/issues{/number}","pulls_url":"https://api.github.com/repos/jetstack/tarmak/pulls{/number}","milestones_url":"https://api.github.com/repos/jetstack/tarmak/milestones{/number}","notifications_url":"https://api.github.com/repos/jetstack/tarmak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jetstack/tarmak/labels{/name}","releases_url":"https://api.github.com/repos/jetstack/tarmak/releases{/id}","deployments_url":"https://api.github.com/repos/jetstack/tarmak/deployments","created_at":"2017-07-10T07:32:26Z","updated_at":"2018-06-20T08:47:51Z","pushed_at":"2018-06-21T07:30:08Z","git_url":"git://github.com/jetstack/tarmak.git","ssh_url":"git@github.com:jetstack/tarmak.git","clone_url":"https://github.com/jetstack/tarmak.git","svn_url":"https://github.com/jetstack/tarmak","homepage":"","size":83556,"stargazers_count":162,"watchers_count":162,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":85,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/330"},"html":{"href":"https://github.com/jetstack/tarmak/pull/330"},"issue":{"href":"https://api.github.com/repos/jetstack/tarmak/issues/330"},"comments":{"href":"https://api.github.com/repos/jetstack/tarmak/issues/330/comments"},"review_comments":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/330/comments"},"review_comment":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/330/commits"},"statuses":{"href":"https://api.github.com/repos/jetstack/tarmak/statuses/7ed36aa3aacf61647594076d9eb2a2bfde8b99f4"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"MattiasGees"}}