{"action":"created","comment":{"url":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls/comments/208201705","pull_request_review_id":143959432,"id":208201705,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODIwMTcwNQ==","diff_hunk":"@@ -1,13 +1,20 @@\n import numpy as np\n+import math\n+from ..protocol.pond import Pond\n \n+DEFAULT_PROTOCOL = Pond\n+\n+# TODO\n+# split backward function in compute_gradient and compute_backpropagated_error ?\n \n class Layer:\n-    pass\n+    prot = DEFAULT_PROTOCOL","path":"src/tensorflow_encrypted/layer/core.py","position":null,"original_position":12,"commit_id":"4265d0e486cf34cd036eebcc2f48b30856c3856b","original_commit_id":"13456fb8f293b76ab9f2299f9c0c822f5227f212","user":{"login":"mortendahl","id":5921097,"node_id":"MDQ6VXNlcjU5MjEwOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5921097?v=4","gravatar_id":"","url":"https://api.github.com/users/mortendahl","html_url":"https://github.com/mortendahl","followers_url":"https://api.github.com/users/mortendahl/followers","following_url":"https://api.github.com/users/mortendahl/following{/other_user}","gists_url":"https://api.github.com/users/mortendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/mortendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortendahl/subscriptions","organizations_url":"https://api.github.com/users/mortendahl/orgs","repos_url":"https://api.github.com/users/mortendahl/repos","events_url":"https://api.github.com/users/mortendahl/events{/privacy}","received_events_url":"https://api.github.com/users/mortendahl/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-08-07T11:55:56Z","updated_at":"2018-08-07T11:55:56Z","html_url":"https://github.com/mortendahl/tf-encrypted/pull/8#discussion_r208201705","pull_request_url":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls/8","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls/comments/208201705"},"html":{"href":"https://github.com/mortendahl/tf-encrypted/pull/8#discussion_r208201705"},"pull_request":{"href":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls/8"}},"in_reply_to_id":207353851},"pull_request":{"url":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls/8","id":205084492,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDg0NDky","html_url":"https://github.com/mortendahl/tf-encrypted/pull/8","diff_url":"https://github.com/mortendahl/tf-encrypted/pull/8.diff","patch_url":"https://github.com/mortendahl/tf-encrypted/pull/8.patch","issue_url":"https://api.github.com/repos/mortendahl/tf-encrypted/issues/8","number":8,"state":"open","locked":false,"title":"Conv2d","user":{"login":"koenvanderveen","id":7250009,"node_id":"MDQ6VXNlcjcyNTAwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/7250009?v=4","gravatar_id":"","url":"https://api.github.com/users/koenvanderveen","html_url":"https://github.com/koenvanderveen","followers_url":"https://api.github.com/users/koenvanderveen/followers","following_url":"https://api.github.com/users/koenvanderveen/following{/other_user}","gists_url":"https://api.github.com/users/koenvanderveen/gists{/gist_id}","starred_url":"https://api.github.com/users/koenvanderveen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koenvanderveen/subscriptions","organizations_url":"https://api.github.com/users/koenvanderveen/orgs","repos_url":"https://api.github.com/users/koenvanderveen/repos","events_url":"https://api.github.com/users/koenvanderveen/events{/privacy}","received_events_url":"https://api.github.com/users/koenvanderveen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-31T11:44:02Z","updated_at":"2018-08-07T11:55:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f4875214d65f10c6af4bb80ccd458c42270b576","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls/8/commits","review_comments_url":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls/8/comments","review_comment_url":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mortendahl/tf-encrypted/issues/8/comments","statuses_url":"https://api.github.com/repos/mortendahl/tf-encrypted/statuses/4265d0e486cf34cd036eebcc2f48b30856c3856b","head":{"label":"mortendahl:conv2d","ref":"conv2d","sha":"4265d0e486cf34cd036eebcc2f48b30856c3856b","user":{"login":"mortendahl","id":5921097,"node_id":"MDQ6VXNlcjU5MjEwOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5921097?v=4","gravatar_id":"","url":"https://api.github.com/users/mortendahl","html_url":"https://github.com/mortendahl","followers_url":"https://api.github.com/users/mortendahl/followers","following_url":"https://api.github.com/users/mortendahl/following{/other_user}","gists_url":"https://api.github.com/users/mortendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/mortendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortendahl/subscriptions","organizations_url":"https://api.github.com/users/mortendahl/orgs","repos_url":"https://api.github.com/users/mortendahl/repos","events_url":"https://api.github.com/users/mortendahl/events{/privacy}","received_events_url":"https://api.github.com/users/mortendahl/received_events","type":"User","site_admin":false},"repo":{"id":126222784,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyMjI3ODQ=","name":"tf-encrypted","full_name":"mortendahl/tf-encrypted","owner":{"login":"mortendahl","id":5921097,"node_id":"MDQ6VXNlcjU5MjEwOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5921097?v=4","gravatar_id":"","url":"https://api.github.com/users/mortendahl","html_url":"https://github.com/mortendahl","followers_url":"https://api.github.com/users/mortendahl/followers","following_url":"https://api.github.com/users/mortendahl/following{/other_user}","gists_url":"https://api.github.com/users/mortendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/mortendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortendahl/subscriptions","organizations_url":"https://api.github.com/users/mortendahl/orgs","repos_url":"https://api.github.com/users/mortendahl/repos","events_url":"https://api.github.com/users/mortendahl/events{/privacy}","received_events_url":"https://api.github.com/users/mortendahl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mortendahl/tf-encrypted","description":null,"fork":false,"url":"https://api.github.com/repos/mortendahl/tf-encrypted","forks_url":"https://api.github.com/repos/mortendahl/tf-encrypted/forks","keys_url":"https://api.github.com/repos/mortendahl/tf-encrypted/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mortendahl/tf-encrypted/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mortendahl/tf-encrypted/teams","hooks_url":"https://api.github.com/repos/mortendahl/tf-encrypted/hooks","issue_events_url":"https://api.github.com/repos/mortendahl/tf-encrypted/issues/events{/number}","events_url":"https://api.github.com/repos/mortendahl/tf-encrypted/events","assignees_url":"https://api.github.com/repos/mortendahl/tf-encrypted/assignees{/user}","branches_url":"https://api.github.com/repos/mortendahl/tf-encrypted/branches{/branch}","tags_url":"https://api.github.com/repos/mortendahl/tf-encrypted/tags","blobs_url":"https://api.github.com/repos/mortendahl/tf-encrypted/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mortendahl/tf-encrypted/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mortendahl/tf-encrypted/git/refs{/sha}","trees_url":"https://api.github.com/repos/mortendahl/tf-encrypted/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mortendahl/tf-encrypted/statuses/{sha}","languages_url":"https://api.github.com/repos/mortendahl/tf-encrypted/languages","stargazers_url":"https://api.github.com/repos/mortendahl/tf-encrypted/stargazers","contributors_url":"https://api.github.com/repos/mortendahl/tf-encrypted/contributors","subscribers_url":"https://api.github.com/repos/mortendahl/tf-encrypted/subscribers","subscription_url":"https://api.github.com/repos/mortendahl/tf-encrypted/subscription","commits_url":"https://api.github.com/repos/mortendahl/tf-encrypted/commits{/sha}","git_commits_url":"https://api.github.com/repos/mortendahl/tf-encrypted/git/commits{/sha}","comments_url":"https://api.github.com/repos/mortendahl/tf-encrypted/comments{/number}","issue_comment_url":"https://api.github.com/repos/mortendahl/tf-encrypted/issues/comments{/number}","contents_url":"https://api.github.com/repos/mortendahl/tf-encrypted/contents/{+path}","compare_url":"https://api.github.com/repos/mortendahl/tf-encrypted/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mortendahl/tf-encrypted/merges","archive_url":"https://api.github.com/repos/mortendahl/tf-encrypted/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mortendahl/tf-encrypted/downloads","issues_url":"https://api.github.com/repos/mortendahl/tf-encrypted/issues{/number}","pulls_url":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls{/number}","milestones_url":"https://api.github.com/repos/mortendahl/tf-encrypted/milestones{/number}","notifications_url":"https://api.github.com/repos/mortendahl/tf-encrypted/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mortendahl/tf-encrypted/labels{/name}","releases_url":"https://api.github.com/repos/mortendahl/tf-encrypted/releases{/id}","deployments_url":"https://api.github.com/repos/mortendahl/tf-encrypted/deployments","created_at":"2018-03-21T18:22:13Z","updated_at":"2018-07-26T12:32:16Z","pushed_at":"2018-08-07T11:55:09Z","git_url":"git://github.com/mortendahl/tf-encrypted.git","ssh_url":"git@github.com:mortendahl/tf-encrypted.git","clone_url":"https://github.com/mortendahl/tf-encrypted.git","svn_url":"https://github.com/mortendahl/tf-encrypted","homepage":null,"size":39,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":2,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"mortendahl:master","ref":"master","sha":"1f218c944cd6ce96e73072cabce76d4a4fde42d6","user":{"login":"mortendahl","id":5921097,"node_id":"MDQ6VXNlcjU5MjEwOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5921097?v=4","gravatar_id":"","url":"https://api.github.com/users/mortendahl","html_url":"https://github.com/mortendahl","followers_url":"https://api.github.com/users/mortendahl/followers","following_url":"https://api.github.com/users/mortendahl/following{/other_user}","gists_url":"https://api.github.com/users/mortendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/mortendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortendahl/subscriptions","organizations_url":"https://api.github.com/users/mortendahl/orgs","repos_url":"https://api.github.com/users/mortendahl/repos","events_url":"https://api.github.com/users/mortendahl/events{/privacy}","received_events_url":"https://api.github.com/users/mortendahl/received_events","type":"User","site_admin":false},"repo":{"id":126222784,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyMjI3ODQ=","name":"tf-encrypted","full_name":"mortendahl/tf-encrypted","owner":{"login":"mortendahl","id":5921097,"node_id":"MDQ6VXNlcjU5MjEwOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5921097?v=4","gravatar_id":"","url":"https://api.github.com/users/mortendahl","html_url":"https://github.com/mortendahl","followers_url":"https://api.github.com/users/mortendahl/followers","following_url":"https://api.github.com/users/mortendahl/following{/other_user}","gists_url":"https://api.github.com/users/mortendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/mortendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortendahl/subscriptions","organizations_url":"https://api.github.com/users/mortendahl/orgs","repos_url":"https://api.github.com/users/mortendahl/repos","events_url":"https://api.github.com/users/mortendahl/events{/privacy}","received_events_url":"https://api.github.com/users/mortendahl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mortendahl/tf-encrypted","description":null,"fork":false,"url":"https://api.github.com/repos/mortendahl/tf-encrypted","forks_url":"https://api.github.com/repos/mortendahl/tf-encrypted/forks","keys_url":"https://api.github.com/repos/mortendahl/tf-encrypted/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mortendahl/tf-encrypted/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mortendahl/tf-encrypted/teams","hooks_url":"https://api.github.com/repos/mortendahl/tf-encrypted/hooks","issue_events_url":"https://api.github.com/repos/mortendahl/tf-encrypted/issues/events{/number}","events_url":"https://api.github.com/repos/mortendahl/tf-encrypted/events","assignees_url":"https://api.github.com/repos/mortendahl/tf-encrypted/assignees{/user}","branches_url":"https://api.github.com/repos/mortendahl/tf-encrypted/branches{/branch}","tags_url":"https://api.github.com/repos/mortendahl/tf-encrypted/tags","blobs_url":"https://api.github.com/repos/mortendahl/tf-encrypted/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mortendahl/tf-encrypted/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mortendahl/tf-encrypted/git/refs{/sha}","trees_url":"https://api.github.com/repos/mortendahl/tf-encrypted/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mortendahl/tf-encrypted/statuses/{sha}","languages_url":"https://api.github.com/repos/mortendahl/tf-encrypted/languages","stargazers_url":"https://api.github.com/repos/mortendahl/tf-encrypted/stargazers","contributors_url":"https://api.github.com/repos/mortendahl/tf-encrypted/contributors","subscribers_url":"https://api.github.com/repos/mortendahl/tf-encrypted/subscribers","subscription_url":"https://api.github.com/repos/mortendahl/tf-encrypted/subscription","commits_url":"https://api.github.com/repos/mortendahl/tf-encrypted/commits{/sha}","git_commits_url":"https://api.github.com/repos/mortendahl/tf-encrypted/git/commits{/sha}","comments_url":"https://api.github.com/repos/mortendahl/tf-encrypted/comments{/number}","issue_comment_url":"https://api.github.com/repos/mortendahl/tf-encrypted/issues/comments{/number}","contents_url":"https://api.github.com/repos/mortendahl/tf-encrypted/contents/{+path}","compare_url":"https://api.github.com/repos/mortendahl/tf-encrypted/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mortendahl/tf-encrypted/merges","archive_url":"https://api.github.com/repos/mortendahl/tf-encrypted/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mortendahl/tf-encrypted/downloads","issues_url":"https://api.github.com/repos/mortendahl/tf-encrypted/issues{/number}","pulls_url":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls{/number}","milestones_url":"https://api.github.com/repos/mortendahl/tf-encrypted/milestones{/number}","notifications_url":"https://api.github.com/repos/mortendahl/tf-encrypted/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mortendahl/tf-encrypted/labels{/name}","releases_url":"https://api.github.com/repos/mortendahl/tf-encrypted/releases{/id}","deployments_url":"https://api.github.com/repos/mortendahl/tf-encrypted/deployments","created_at":"2018-03-21T18:22:13Z","updated_at":"2018-07-26T12:32:16Z","pushed_at":"2018-08-07T11:55:09Z","git_url":"git://github.com/mortendahl/tf-encrypted.git","ssh_url":"git@github.com:mortendahl/tf-encrypted.git","clone_url":"https://github.com/mortendahl/tf-encrypted.git","svn_url":"https://github.com/mortendahl/tf-encrypted","homepage":null,"size":39,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":2,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls/8"},"html":{"href":"https://github.com/mortendahl/tf-encrypted/pull/8"},"issue":{"href":"https://api.github.com/repos/mortendahl/tf-encrypted/issues/8"},"comments":{"href":"https://api.github.com/repos/mortendahl/tf-encrypted/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mortendahl/tf-encrypted/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/mortendahl/tf-encrypted/statuses/4265d0e486cf34cd036eebcc2f48b30856c3856b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mortendahl"}}