{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/californium/pulls/comments/180077063","pull_request_review_id":110433063,"id":180077063,"diff_hunk":"@@ -1270,7 +1283,44 @@ public OptionSet removeObserve() {\n \tpublic static boolean isValidObserveOption(final int value) {\n \t\treturn value >= 0 && value <= MAX_OBSERVE_NO;\n \t}\n-\n+\t\n+\t/**\n+\t * Sets the Code value.\n+\t * Returns the current OptionSet object for a fluent API.\n+\t * @param value the code\n+\t * @return this OptionSet\n+\t */\n+\tpublic OptionSet setCode(final int value){\n+\t\tthis.code = value;\n+\t\treturn this;\n+\t}\n+\t\n+\t/**\n+\t * Returns the uint value of the Code option.\n+\t * @return the Code or null if not present.\n+\t */\n+\tpublic Integer getCode(){\n+\t\treturn this.code;\n+\t}\n+\t\n+\t/**\n+\t * Checks if the Code option is present.\n+\t * @return true if Code is present, otherwise false.\n+\t */\n+\tpublic boolean hasCode(){\n+\t\treturn this.code != null;\n+\t}\n+\t\n+\t/**\n+\t * Removes the Code option.\n+\t * Returns the current OptionSet object for a fluent API.\n+\t * @return this OptionSet.\n+\t */\n+\tpublic OptionSet removeCode(){\n+\t\tthis.code = null;\n+\t\treturn this;\n+\t}\n+\t","path":"californium-core/src/main/java/org/eclipse/californium/core/coap/OptionSet.java","position":86,"original_position":86,"commit_id":"d104c79267fda44528b9f3b43174b30d07540591","original_commit_id":"d104c79267fda44528b9f3b43174b30d07540591","user":{"login":"T0bbe","id":1225360,"avatar_url":"https://avatars0.githubusercontent.com/u/1225360?v=4","gravatar_id":"","url":"https://api.github.com/users/T0bbe","html_url":"https://github.com/T0bbe","followers_url":"https://api.github.com/users/T0bbe/followers","following_url":"https://api.github.com/users/T0bbe/following{/other_user}","gists_url":"https://api.github.com/users/T0bbe/gists{/gist_id}","starred_url":"https://api.github.com/users/T0bbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T0bbe/subscriptions","organizations_url":"https://api.github.com/users/T0bbe/orgs","repos_url":"https://api.github.com/users/T0bbe/repos","events_url":"https://api.github.com/users/T0bbe/events{/privacy}","received_events_url":"https://api.github.com/users/T0bbe/received_events","type":"User","site_admin":false},"body":"Exactly, just for convenience. Suggestions: add object-sec as a new option and handle CoaP Code as an Other-option.\r\n\r\nNone option?","created_at":"2018-04-09T12:27:25Z","updated_at":"2018-04-09T12:27:25Z","html_url":"https://github.com/eclipse/californium/pull/603#discussion_r180077063","pull_request_url":"https://api.github.com/repos/eclipse/californium/pulls/603","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/eclipse/californium/pulls/comments/180077063"},"html":{"href":"https://github.com/eclipse/californium/pull/603#discussion_r180077063"},"pull_request":{"href":"https://api.github.com/repos/eclipse/californium/pulls/603"}},"in_reply_to_id":180027860},"pull_request":{"url":"https://api.github.com/repos/eclipse/californium/pulls/603","id":179920993,"html_url":"https://github.com/eclipse/californium/pull/603","diff_url":"https://github.com/eclipse/californium/pull/603.diff","patch_url":"https://github.com/eclipse/californium/pull/603.patch","issue_url":"https://api.github.com/repos/eclipse/californium/issues/603","number":603,"state":"open","locked":false,"title":"Integration hooks for OSCORE","user":{"login":"T0bbe","id":1225360,"avatar_url":"https://avatars0.githubusercontent.com/u/1225360?v=4","gravatar_id":"","url":"https://api.github.com/users/T0bbe","html_url":"https://github.com/T0bbe","followers_url":"https://api.github.com/users/T0bbe/followers","following_url":"https://api.github.com/users/T0bbe/following{/other_user}","gists_url":"https://api.github.com/users/T0bbe/gists{/gist_id}","starred_url":"https://api.github.com/users/T0bbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T0bbe/subscriptions","organizations_url":"https://api.github.com/users/T0bbe/orgs","repos_url":"https://api.github.com/users/T0bbe/repos","events_url":"https://api.github.com/users/T0bbe/events{/privacy}","received_events_url":"https://api.github.com/users/T0bbe/received_events","type":"User","site_admin":false},"body":"Integration hooks for OSCORE. Mostly visibility changes. OSCORE number is set to 9 which it most likely will be set to once the draft process is finished.\r\n\r\nSigned-off-by: Tobias Andersson <tobias.andersson@ri.se>","created_at":"2018-04-06T11:21:03Z","updated_at":"2018-04-09T12:27:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47bc1d460a08eb9cfcd1e165f83520351df108e3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":603554127,"url":"https://api.github.com/repos/eclipse/californium/labels/waiting%20for%20feedback","name":"waiting for feedback","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/californium/pulls/603/commits","review_comments_url":"https://api.github.com/repos/eclipse/californium/pulls/603/comments","review_comment_url":"https://api.github.com/repos/eclipse/californium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/californium/issues/603/comments","statuses_url":"https://api.github.com/repos/eclipse/californium/statuses/d104c79267fda44528b9f3b43174b30d07540591","head":{"label":"T0bbe:oscore_hooks","ref":"oscore_hooks","sha":"d104c79267fda44528b9f3b43174b30d07540591","user":{"login":"T0bbe","id":1225360,"avatar_url":"https://avatars0.githubusercontent.com/u/1225360?v=4","gravatar_id":"","url":"https://api.github.com/users/T0bbe","html_url":"https://github.com/T0bbe","followers_url":"https://api.github.com/users/T0bbe/followers","following_url":"https://api.github.com/users/T0bbe/following{/other_user}","gists_url":"https://api.github.com/users/T0bbe/gists{/gist_id}","starred_url":"https://api.github.com/users/T0bbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T0bbe/subscriptions","organizations_url":"https://api.github.com/users/T0bbe/orgs","repos_url":"https://api.github.com/users/T0bbe/repos","events_url":"https://api.github.com/users/T0bbe/events{/privacy}","received_events_url":"https://api.github.com/users/T0bbe/received_events","type":"User","site_admin":false},"repo":{"id":128070054,"name":"californium","full_name":"T0bbe/californium","owner":{"login":"T0bbe","id":1225360,"avatar_url":"https://avatars0.githubusercontent.com/u/1225360?v=4","gravatar_id":"","url":"https://api.github.com/users/T0bbe","html_url":"https://github.com/T0bbe","followers_url":"https://api.github.com/users/T0bbe/followers","following_url":"https://api.github.com/users/T0bbe/following{/other_user}","gists_url":"https://api.github.com/users/T0bbe/gists{/gist_id}","starred_url":"https://api.github.com/users/T0bbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T0bbe/subscriptions","organizations_url":"https://api.github.com/users/T0bbe/orgs","repos_url":"https://api.github.com/users/T0bbe/repos","events_url":"https://api.github.com/users/T0bbe/events{/privacy}","received_events_url":"https://api.github.com/users/T0bbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/T0bbe/californium","description":null,"fork":true,"url":"https://api.github.com/repos/T0bbe/californium","forks_url":"https://api.github.com/repos/T0bbe/californium/forks","keys_url":"https://api.github.com/repos/T0bbe/californium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/T0bbe/californium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/T0bbe/californium/teams","hooks_url":"https://api.github.com/repos/T0bbe/californium/hooks","issue_events_url":"https://api.github.com/repos/T0bbe/californium/issues/events{/number}","events_url":"https://api.github.com/repos/T0bbe/californium/events","assignees_url":"https://api.github.com/repos/T0bbe/californium/assignees{/user}","branches_url":"https://api.github.com/repos/T0bbe/californium/branches{/branch}","tags_url":"https://api.github.com/repos/T0bbe/californium/tags","blobs_url":"https://api.github.com/repos/T0bbe/californium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/T0bbe/californium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/T0bbe/californium/git/refs{/sha}","trees_url":"https://api.github.com/repos/T0bbe/californium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/T0bbe/californium/statuses/{sha}","languages_url":"https://api.github.com/repos/T0bbe/californium/languages","stargazers_url":"https://api.github.com/repos/T0bbe/californium/stargazers","contributors_url":"https://api.github.com/repos/T0bbe/californium/contributors","subscribers_url":"https://api.github.com/repos/T0bbe/californium/subscribers","subscription_url":"https://api.github.com/repos/T0bbe/californium/subscription","commits_url":"https://api.github.com/repos/T0bbe/californium/commits{/sha}","git_commits_url":"https://api.github.com/repos/T0bbe/californium/git/commits{/sha}","comments_url":"https://api.github.com/repos/T0bbe/californium/comments{/number}","issue_comment_url":"https://api.github.com/repos/T0bbe/californium/issues/comments{/number}","contents_url":"https://api.github.com/repos/T0bbe/californium/contents/{+path}","compare_url":"https://api.github.com/repos/T0bbe/californium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/T0bbe/californium/merges","archive_url":"https://api.github.com/repos/T0bbe/californium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/T0bbe/californium/downloads","issues_url":"https://api.github.com/repos/T0bbe/californium/issues{/number}","pulls_url":"https://api.github.com/repos/T0bbe/californium/pulls{/number}","milestones_url":"https://api.github.com/repos/T0bbe/californium/milestones{/number}","notifications_url":"https://api.github.com/repos/T0bbe/californium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/T0bbe/californium/labels{/name}","releases_url":"https://api.github.com/repos/T0bbe/californium/releases{/id}","deployments_url":"https://api.github.com/repos/T0bbe/californium/deployments","created_at":"2018-04-04T13:58:39Z","updated_at":"2018-04-04T13:58:43Z","pushed_at":"2018-04-06T08:02:09Z","git_url":"git://github.com/T0bbe/californium.git","ssh_url":"git@github.com:T0bbe/californium.git","clone_url":"https://github.com/T0bbe/californium.git","svn_url":"https://github.com/T0bbe/californium","homepage":null,"size":6658,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:2.0.x","ref":"2.0.x","sha":"25548e29afb011e4bf1257b0bb856a985b8a9179","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":43075480,"name":"californium","full_name":"eclipse/californium","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/californium","description":null,"fork":false,"url":"https://api.github.com/repos/eclipse/californium","forks_url":"https://api.github.com/repos/eclipse/californium/forks","keys_url":"https://api.github.com/repos/eclipse/californium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/californium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/californium/teams","hooks_url":"https://api.github.com/repos/eclipse/californium/hooks","issue_events_url":"https://api.github.com/repos/eclipse/californium/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/californium/events","assignees_url":"https://api.github.com/repos/eclipse/californium/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/californium/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/californium/tags","blobs_url":"https://api.github.com/repos/eclipse/californium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/californium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/californium/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/californium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/californium/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/californium/languages","stargazers_url":"https://api.github.com/repos/eclipse/californium/stargazers","contributors_url":"https://api.github.com/repos/eclipse/californium/contributors","subscribers_url":"https://api.github.com/repos/eclipse/californium/subscribers","subscription_url":"https://api.github.com/repos/eclipse/californium/subscription","commits_url":"https://api.github.com/repos/eclipse/californium/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/californium/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/californium/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/californium/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/californium/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/californium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/californium/merges","archive_url":"https://api.github.com/repos/eclipse/californium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/californium/downloads","issues_url":"https://api.github.com/repos/eclipse/californium/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/californium/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/californium/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/californium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/californium/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/californium/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/californium/deployments","created_at":"2015-09-24T15:27:15Z","updated_at":"2018-04-07T11:45:54Z","pushed_at":"2018-04-09T08:42:08Z","git_url":"git://github.com/eclipse/californium.git","ssh_url":"git@github.com:eclipse/californium.git","clone_url":"https://github.com/eclipse/californium.git","svn_url":"https://github.com/eclipse/californium","homepage":null,"size":6647,"stargazers_count":208,"watchers_count":208,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":173,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":173,"open_issues":32,"watchers":208,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/californium/pulls/603"},"html":{"href":"https://github.com/eclipse/californium/pull/603"},"issue":{"href":"https://api.github.com/repos/eclipse/californium/issues/603"},"comments":{"href":"https://api.github.com/repos/eclipse/californium/issues/603/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/californium/pulls/603/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/californium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/californium/pulls/603/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/californium/statuses/d104c79267fda44528b9f3b43174b30d07540591"}},"author_association":"NONE"}}
{"actor":{"display_login":"T0bbe"}}