{"action":"created","comment":{"url":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls/comments/207032305","pull_request_review_id":142564124,"id":207032305,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzAzMjMwNQ==","diff_hunk":"@@ -0,0 +1,25 @@\n+FROM node:8-alpine\n+\n+MAINTAINER Pablo Guerino\n+\n+VOLUME /work\n+WORKDIR /work\n+\n+ENV HOME \"/tmp\"\n+ENV PACKAGES \"g++ git python2 make\"\n+\n+ADD package.json /\n+\n+RUN mkdir /fake-home && \\\n+    chmod 777 /fake-home & \\\n+    apk add --no-cache $PACKAGES && \\\n+    cd / && \\\n+    npm config set python /usr/bin/python && \\\n+    npm install && \\\n+    npm install -g gulp && \\\n+    apk del --no-cache --purge $PACKAGES","path":"project-based/Dockerfile","position":null,"original_position":20,"commit_id":"3f52d79f5f68d21dfa4ae731b522397dd3c85b08","original_commit_id":"c575b26ceef59e4349963ca523377926b20459ed","user":{"login":"greteltrost","id":3032067,"node_id":"MDQ6VXNlcjMwMzIwNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/3032067?v=4","gravatar_id":"","url":"https://api.github.com/users/greteltrost","html_url":"https://github.com/greteltrost","followers_url":"https://api.github.com/users/greteltrost/followers","following_url":"https://api.github.com/users/greteltrost/following{/other_user}","gists_url":"https://api.github.com/users/greteltrost/gists{/gist_id}","starred_url":"https://api.github.com/users/greteltrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greteltrost/subscriptions","organizations_url":"https://api.github.com/users/greteltrost/orgs","repos_url":"https://api.github.com/users/greteltrost/repos","events_url":"https://api.github.com/users/greteltrost/events{/privacy}","received_events_url":"https://api.github.com/users/greteltrost/received_events","type":"User","site_admin":false},"body":"Updated","created_at":"2018-08-01T21:09:15Z","updated_at":"2018-08-01T21:09:15Z","html_url":"https://github.com/skilld-labs/docker-frontend/pull/24#discussion_r207032305","pull_request_url":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls/24","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls/comments/207032305"},"html":{"href":"https://github.com/skilld-labs/docker-frontend/pull/24#discussion_r207032305"},"pull_request":{"href":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls/24"}},"in_reply_to_id":206627002},"pull_request":{"url":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls/24","id":170539040,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcwNTM5MDQw","html_url":"https://github.com/skilld-labs/docker-frontend/pull/24","diff_url":"https://github.com/skilld-labs/docker-frontend/pull/24.diff","patch_url":"https://github.com/skilld-labs/docker-frontend/pull/24.patch","issue_url":"https://api.github.com/repos/skilld-labs/docker-frontend/issues/24","number":24,"state":"open","locked":false,"title":"Docker image for project-based approach","user":{"login":"pabloguerino","id":1230085,"node_id":"MDQ6VXNlcjEyMzAwODU=","avatar_url":"https://avatars2.githubusercontent.com/u/1230085?v=4","gravatar_id":"","url":"https://api.github.com/users/pabloguerino","html_url":"https://github.com/pabloguerino","followers_url":"https://api.github.com/users/pabloguerino/followers","following_url":"https://api.github.com/users/pabloguerino/following{/other_user}","gists_url":"https://api.github.com/users/pabloguerino/gists{/gist_id}","starred_url":"https://api.github.com/users/pabloguerino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabloguerino/subscriptions","organizations_url":"https://api.github.com/users/pabloguerino/orgs","repos_url":"https://api.github.com/users/pabloguerino/repos","events_url":"https://api.github.com/users/pabloguerino/events{/privacy}","received_events_url":"https://api.github.com/users/pabloguerino/received_events","type":"User","site_admin":false},"body":"### Usage (Without Makefile)\r\n\r\n```\r\ndocker run --rm -t -u 1000:1000 -v $(pwd):/work abc/xyz \r\n```\r\n\r\n### Steps to build a new image\r\n\r\n_Note: this is just a quick guide to get started using this new image_\r\n\r\n- Login to gitlab so we can use gitlab registry `make login` or `docker login ...`\r\n- Use the same `package.json` as the one located inside the project repo \r\n- You can set a project name in the `Makefile`\r\n- Build the container with `make build` \r\n- Push it to gitlab with `make push`\r\n- Update the `.env` file from your project to use this new image\r\n\r\n### Why this image instead of the other ones?\r\n\r\n- Based on node.js 9.x\r\n- Easier to mantain: doesn't require packages to be hardcoded in the Dockerfile, we only mantain one package.json\r\n- Alternative way for caching (npm packages), we don't use global npm packages or links anymore\r\n- Backwards compatible","created_at":"2018-02-21T17:34:57Z","updated_at":"2018-08-01T21:09:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a082f57b601d1e919ae37aaabdd27c19a5397759","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls/24/commits","review_comments_url":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls/24/comments","review_comment_url":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skilld-labs/docker-frontend/issues/24/comments","statuses_url":"https://api.github.com/repos/skilld-labs/docker-frontend/statuses/3f52d79f5f68d21dfa4ae731b522397dd3c85b08","head":{"label":"pabloguerino:image-per-project","ref":"image-per-project","sha":"3f52d79f5f68d21dfa4ae731b522397dd3c85b08","user":{"login":"pabloguerino","id":1230085,"node_id":"MDQ6VXNlcjEyMzAwODU=","avatar_url":"https://avatars2.githubusercontent.com/u/1230085?v=4","gravatar_id":"","url":"https://api.github.com/users/pabloguerino","html_url":"https://github.com/pabloguerino","followers_url":"https://api.github.com/users/pabloguerino/followers","following_url":"https://api.github.com/users/pabloguerino/following{/other_user}","gists_url":"https://api.github.com/users/pabloguerino/gists{/gist_id}","starred_url":"https://api.github.com/users/pabloguerino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabloguerino/subscriptions","organizations_url":"https://api.github.com/users/pabloguerino/orgs","repos_url":"https://api.github.com/users/pabloguerino/repos","events_url":"https://api.github.com/users/pabloguerino/events{/privacy}","received_events_url":"https://api.github.com/users/pabloguerino/received_events","type":"User","site_admin":false},"repo":{"id":59247678,"node_id":"MDEwOlJlcG9zaXRvcnk1OTI0NzY3OA==","name":"docker-frontend","full_name":"pabloguerino/docker-frontend","owner":{"login":"pabloguerino","id":1230085,"node_id":"MDQ6VXNlcjEyMzAwODU=","avatar_url":"https://avatars2.githubusercontent.com/u/1230085?v=4","gravatar_id":"","url":"https://api.github.com/users/pabloguerino","html_url":"https://github.com/pabloguerino","followers_url":"https://api.github.com/users/pabloguerino/followers","following_url":"https://api.github.com/users/pabloguerino/following{/other_user}","gists_url":"https://api.github.com/users/pabloguerino/gists{/gist_id}","starred_url":"https://api.github.com/users/pabloguerino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabloguerino/subscriptions","organizations_url":"https://api.github.com/users/pabloguerino/orgs","repos_url":"https://api.github.com/users/pabloguerino/repos","events_url":"https://api.github.com/users/pabloguerino/events{/privacy}","received_events_url":"https://api.github.com/users/pabloguerino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pabloguerino/docker-frontend","description":"Docker container for frontent build","fork":true,"url":"https://api.github.com/repos/pabloguerino/docker-frontend","forks_url":"https://api.github.com/repos/pabloguerino/docker-frontend/forks","keys_url":"https://api.github.com/repos/pabloguerino/docker-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pabloguerino/docker-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pabloguerino/docker-frontend/teams","hooks_url":"https://api.github.com/repos/pabloguerino/docker-frontend/hooks","issue_events_url":"https://api.github.com/repos/pabloguerino/docker-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/pabloguerino/docker-frontend/events","assignees_url":"https://api.github.com/repos/pabloguerino/docker-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/pabloguerino/docker-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/pabloguerino/docker-frontend/tags","blobs_url":"https://api.github.com/repos/pabloguerino/docker-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pabloguerino/docker-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pabloguerino/docker-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/pabloguerino/docker-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pabloguerino/docker-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/pabloguerino/docker-frontend/languages","stargazers_url":"https://api.github.com/repos/pabloguerino/docker-frontend/stargazers","contributors_url":"https://api.github.com/repos/pabloguerino/docker-frontend/contributors","subscribers_url":"https://api.github.com/repos/pabloguerino/docker-frontend/subscribers","subscription_url":"https://api.github.com/repos/pabloguerino/docker-frontend/subscription","commits_url":"https://api.github.com/repos/pabloguerino/docker-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/pabloguerino/docker-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/pabloguerino/docker-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/pabloguerino/docker-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/pabloguerino/docker-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/pabloguerino/docker-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pabloguerino/docker-frontend/merges","archive_url":"https://api.github.com/repos/pabloguerino/docker-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pabloguerino/docker-frontend/downloads","issues_url":"https://api.github.com/repos/pabloguerino/docker-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/pabloguerino/docker-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/pabloguerino/docker-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/pabloguerino/docker-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pabloguerino/docker-frontend/labels{/name}","releases_url":"https://api.github.com/repos/pabloguerino/docker-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/pabloguerino/docker-frontend/deployments","created_at":"2016-05-19T22:35:23Z","updated_at":"2017-01-31T20:21:03Z","pushed_at":"2018-08-01T21:06:26Z","git_url":"git://github.com/pabloguerino/docker-frontend.git","ssh_url":"git@github.com:pabloguerino/docker-frontend.git","clone_url":"https://github.com/pabloguerino/docker-frontend.git","svn_url":"https://github.com/pabloguerino/docker-frontend","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skilld-labs:master","ref":"master","sha":"0c564926b99123b5c95aa086515bc717b440cad6","user":{"login":"skilld-labs","id":13232614,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjMyNjE0","avatar_url":"https://avatars0.githubusercontent.com/u/13232614?v=4","gravatar_id":"","url":"https://api.github.com/users/skilld-labs","html_url":"https://github.com/skilld-labs","followers_url":"https://api.github.com/users/skilld-labs/followers","following_url":"https://api.github.com/users/skilld-labs/following{/other_user}","gists_url":"https://api.github.com/users/skilld-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/skilld-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skilld-labs/subscriptions","organizations_url":"https://api.github.com/users/skilld-labs/orgs","repos_url":"https://api.github.com/users/skilld-labs/repos","events_url":"https://api.github.com/users/skilld-labs/events{/privacy}","received_events_url":"https://api.github.com/users/skilld-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":54150257,"node_id":"MDEwOlJlcG9zaXRvcnk1NDE1MDI1Nw==","name":"docker-frontend","full_name":"skilld-labs/docker-frontend","owner":{"login":"skilld-labs","id":13232614,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjMyNjE0","avatar_url":"https://avatars0.githubusercontent.com/u/13232614?v=4","gravatar_id":"","url":"https://api.github.com/users/skilld-labs","html_url":"https://github.com/skilld-labs","followers_url":"https://api.github.com/users/skilld-labs/followers","following_url":"https://api.github.com/users/skilld-labs/following{/other_user}","gists_url":"https://api.github.com/users/skilld-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/skilld-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skilld-labs/subscriptions","organizations_url":"https://api.github.com/users/skilld-labs/orgs","repos_url":"https://api.github.com/users/skilld-labs/repos","events_url":"https://api.github.com/users/skilld-labs/events{/privacy}","received_events_url":"https://api.github.com/users/skilld-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skilld-labs/docker-frontend","description":"Docker container for frontent build","fork":false,"url":"https://api.github.com/repos/skilld-labs/docker-frontend","forks_url":"https://api.github.com/repos/skilld-labs/docker-frontend/forks","keys_url":"https://api.github.com/repos/skilld-labs/docker-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skilld-labs/docker-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skilld-labs/docker-frontend/teams","hooks_url":"https://api.github.com/repos/skilld-labs/docker-frontend/hooks","issue_events_url":"https://api.github.com/repos/skilld-labs/docker-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/skilld-labs/docker-frontend/events","assignees_url":"https://api.github.com/repos/skilld-labs/docker-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/skilld-labs/docker-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/skilld-labs/docker-frontend/tags","blobs_url":"https://api.github.com/repos/skilld-labs/docker-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skilld-labs/docker-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skilld-labs/docker-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/skilld-labs/docker-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skilld-labs/docker-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/skilld-labs/docker-frontend/languages","stargazers_url":"https://api.github.com/repos/skilld-labs/docker-frontend/stargazers","contributors_url":"https://api.github.com/repos/skilld-labs/docker-frontend/contributors","subscribers_url":"https://api.github.com/repos/skilld-labs/docker-frontend/subscribers","subscription_url":"https://api.github.com/repos/skilld-labs/docker-frontend/subscription","commits_url":"https://api.github.com/repos/skilld-labs/docker-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/skilld-labs/docker-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/skilld-labs/docker-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/skilld-labs/docker-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/skilld-labs/docker-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/skilld-labs/docker-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skilld-labs/docker-frontend/merges","archive_url":"https://api.github.com/repos/skilld-labs/docker-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skilld-labs/docker-frontend/downloads","issues_url":"https://api.github.com/repos/skilld-labs/docker-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/skilld-labs/docker-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/skilld-labs/docker-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skilld-labs/docker-frontend/labels{/name}","releases_url":"https://api.github.com/repos/skilld-labs/docker-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/skilld-labs/docker-frontend/deployments","created_at":"2016-03-17T20:46:20Z","updated_at":"2018-07-06T07:34:34Z","pushed_at":"2018-08-01T21:06:26Z","git_url":"git://github.com/skilld-labs/docker-frontend.git","ssh_url":"git@github.com:skilld-labs/docker-frontend.git","clone_url":"https://github.com/skilld-labs/docker-frontend.git","svn_url":"https://github.com/skilld-labs/docker-frontend","homepage":null,"size":35,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":8,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls/24"},"html":{"href":"https://github.com/skilld-labs/docker-frontend/pull/24"},"issue":{"href":"https://api.github.com/repos/skilld-labs/docker-frontend/issues/24"},"comments":{"href":"https://api.github.com/repos/skilld-labs/docker-frontend/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skilld-labs/docker-frontend/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/skilld-labs/docker-frontend/statuses/3f52d79f5f68d21dfa4ae731b522397dd3c85b08"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"greteltrost"}}