{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/203497570","pull_request_review_id":138398642,"id":203497570,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQ5NzU3MA==","diff_hunk":"@@ -934,6 +935,52 @@ static void decodeShapeArrayLegacy(const SILTensorOpInfo &tfopInfo,\n   }\n }\n \n+// This helper function decodes a shape attribute into its values.\n+static void decodeShapeAttr(SymbolicValue attr,\n+                            SmallVectorImpl<int64_t> &result) {\n+  attr = attr.lookThroughSingleElementAggregates();\n+  CanType eltType;\n+  for (auto elt : attr.getArrayValue(eltType)) {\n+    elt = elt.lookThroughSingleElementAggregates();\n+    result.push_back(elt.getIntegerValue().getLimitedValue());\n+    }","path":"lib/SILOptimizer/Mandatory/TFLowerGraph.cpp","position":49,"original_position":49,"commit_id":"426b5d7214f3abecb058c26e3604ea12d96e4c0d","original_commit_id":"426b5d7214f3abecb058c26e3604ea12d96e4c0d","user":{"login":"rxwei","id":856507,"node_id":"MDQ6VXNlcjg1NjUwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/856507?v=4","gravatar_id":"","url":"https://api.github.com/users/rxwei","html_url":"https://github.com/rxwei","followers_url":"https://api.github.com/users/rxwei/followers","following_url":"https://api.github.com/users/rxwei/following{/other_user}","gists_url":"https://api.github.com/users/rxwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rxwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxwei/subscriptions","organizations_url":"https://api.github.com/users/rxwei/orgs","repos_url":"https://api.github.com/users/rxwei/repos","events_url":"https://api.github.com/users/rxwei/events{/privacy}","received_events_url":"https://api.github.com/users/rxwei/received_events","type":"User","site_admin":false},"body":"Wrong indentation","created_at":"2018-07-18T19:14:11Z","updated_at":"2018-07-18T19:16:57Z","html_url":"https://github.com/apple/swift/pull/18038#discussion_r203497570","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/18038","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/203497570"},"html":{"href":"https://github.com/apple/swift/pull/18038#discussion_r203497570"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/18038"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/18038","id":202149420,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTQ5NDIw","html_url":"https://github.com/apple/swift/pull/18038","diff_url":"https://github.com/apple/swift/pull/18038.diff","patch_url":"https://github.com/apple/swift/pull/18038.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/18038","number":18038,"state":"open","locked":false,"title":"Migrated shape array, sends recvs and device partitioning related code to graph op inst and strict deabstraction.","user":{"login":"mhong","id":969799,"node_id":"MDQ6VXNlcjk2OTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/969799?v=4","gravatar_id":"","url":"https://api.github.com/users/mhong","html_url":"https://github.com/mhong","followers_url":"https://api.github.com/users/mhong/followers","following_url":"https://api.github.com/users/mhong/following{/other_user}","gists_url":"https://api.github.com/users/mhong/gists{/gist_id}","starred_url":"https://api.github.com/users/mhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhong/subscriptions","organizations_url":"https://api.github.com/users/mhong/orgs","repos_url":"https://api.github.com/users/mhong/repos","events_url":"https://api.github.com/users/mhong/events{/privacy}","received_events_url":"https://api.github.com/users/mhong/received_events","type":"User","site_admin":false},"body":"Again, simplified a lot of code!\r\n\r\nTurned on strict DA for control flow, device placement and sends/recvs tests.\r\n\r\nSummary of behavior-altering changes:\r\n1. When targeting TPU, added a scalar shape for each promoted scalar, to reduce the needs for swift users to manually add such shapes.\r\n\r\n2. Fixed a bug in handling configureGPU or configureTPU – the deabstraction pass turns it into a graph op inst, which gets deleted by performance pipeline, so that when TFPartition.cpp again gets config via getForFunction(), it would not find any, and thus assume the graph is targeting CPU, even if the swift function has `TensorFlow.enableTPU()`.\r\n\r\nThe fix is to mark GraphOperationInst to be possibly side effecting.\r\n\r\n3. Added sanity check in deabstraction code on a shape (must be an array of ints) or shape array attr (array of array of ints).\r\n\r\nRan into invalid SILLocation in some of the graph_op insts generated from deabstraction pass -- See `TODO: fix the wrong diagnostic location` in `sends_recvs.swift`. Filed https://bugs.swift.org/browse/SR-8309 to fix it separately.","created_at":"2018-07-18T06:23:54Z","updated_at":"2018-07-18T19:16:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03788eca2f285763fd138681b91e11d40b9c2345","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bgogul","id":6721579,"node_id":"MDQ6VXNlcjY3MjE1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6721579?v=4","gravatar_id":"","url":"https://api.github.com/users/bgogul","html_url":"https://github.com/bgogul","followers_url":"https://api.github.com/users/bgogul/followers","following_url":"https://api.github.com/users/bgogul/following{/other_user}","gists_url":"https://api.github.com/users/bgogul/gists{/gist_id}","starred_url":"https://api.github.com/users/bgogul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgogul/subscriptions","organizations_url":"https://api.github.com/users/bgogul/orgs","repos_url":"https://api.github.com/users/bgogul/repos","events_url":"https://api.github.com/users/bgogul/events{/privacy}","received_events_url":"https://api.github.com/users/bgogul/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/18038/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/18038/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/18038/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/426b5d7214f3abecb058c26e3604ea12d96e4c0d","head":{"label":"mhong:shape_array_graph_op","ref":"shape_array_graph_op","sha":"426b5d7214f3abecb058c26e3604ea12d96e4c0d","user":{"login":"mhong","id":969799,"node_id":"MDQ6VXNlcjk2OTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/969799?v=4","gravatar_id":"","url":"https://api.github.com/users/mhong","html_url":"https://github.com/mhong","followers_url":"https://api.github.com/users/mhong/followers","following_url":"https://api.github.com/users/mhong/following{/other_user}","gists_url":"https://api.github.com/users/mhong/gists{/gist_id}","starred_url":"https://api.github.com/users/mhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhong/subscriptions","organizations_url":"https://api.github.com/users/mhong/orgs","repos_url":"https://api.github.com/users/mhong/repos","events_url":"https://api.github.com/users/mhong/events{/privacy}","received_events_url":"https://api.github.com/users/mhong/received_events","type":"User","site_admin":false},"repo":{"id":119768422,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk3Njg0MjI=","name":"swift","full_name":"mhong/swift","owner":{"login":"mhong","id":969799,"node_id":"MDQ6VXNlcjk2OTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/969799?v=4","gravatar_id":"","url":"https://api.github.com/users/mhong","html_url":"https://github.com/mhong","followers_url":"https://api.github.com/users/mhong/followers","following_url":"https://api.github.com/users/mhong/following{/other_user}","gists_url":"https://api.github.com/users/mhong/gists{/gist_id}","starred_url":"https://api.github.com/users/mhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhong/subscriptions","organizations_url":"https://api.github.com/users/mhong/orgs","repos_url":"https://api.github.com/users/mhong/repos","events_url":"https://api.github.com/users/mhong/events{/privacy}","received_events_url":"https://api.github.com/users/mhong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhong/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/mhong/swift","forks_url":"https://api.github.com/repos/mhong/swift/forks","keys_url":"https://api.github.com/repos/mhong/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhong/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhong/swift/teams","hooks_url":"https://api.github.com/repos/mhong/swift/hooks","issue_events_url":"https://api.github.com/repos/mhong/swift/issues/events{/number}","events_url":"https://api.github.com/repos/mhong/swift/events","assignees_url":"https://api.github.com/repos/mhong/swift/assignees{/user}","branches_url":"https://api.github.com/repos/mhong/swift/branches{/branch}","tags_url":"https://api.github.com/repos/mhong/swift/tags","blobs_url":"https://api.github.com/repos/mhong/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhong/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhong/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhong/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhong/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/mhong/swift/languages","stargazers_url":"https://api.github.com/repos/mhong/swift/stargazers","contributors_url":"https://api.github.com/repos/mhong/swift/contributors","subscribers_url":"https://api.github.com/repos/mhong/swift/subscribers","subscription_url":"https://api.github.com/repos/mhong/swift/subscription","commits_url":"https://api.github.com/repos/mhong/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhong/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhong/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhong/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhong/swift/contents/{+path}","compare_url":"https://api.github.com/repos/mhong/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhong/swift/merges","archive_url":"https://api.github.com/repos/mhong/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhong/swift/downloads","issues_url":"https://api.github.com/repos/mhong/swift/issues{/number}","pulls_url":"https://api.github.com/repos/mhong/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/mhong/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/mhong/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhong/swift/labels{/name}","releases_url":"https://api.github.com/repos/mhong/swift/releases{/id}","deployments_url":"https://api.github.com/repos/mhong/swift/deployments","created_at":"2018-02-01T01:57:03Z","updated_at":"2018-02-01T01:57:33Z","pushed_at":"2018-07-18T19:03:56Z","git_url":"git://github.com/mhong/swift.git","ssh_url":"git@github.com:mhong/swift.git","clone_url":"https://github.com/mhong/swift.git","svn_url":"https://github.com/mhong/swift","homepage":"https://swift.org/","size":302024,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:tensorflow","ref":"tensorflow","sha":"558f765641aedbccede2cf9929ca000e290efec5","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-07-18T18:47:15Z","pushed_at":"2018-07-18T19:15:46Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":312379,"stargazers_count":44575,"watchers_count":44575,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7034,"mirror_url":null,"archived":false,"open_issues_count":369,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7034,"open_issues":369,"watchers":44575,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/18038"},"html":{"href":"https://github.com/apple/swift/pull/18038"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/18038"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/18038/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/18038/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/18038/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/426b5d7214f3abecb058c26e3604ea12d96e4c0d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rxwei"}}