{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/234163832","pull_request_review_id":175747948,"id":234163832,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDE2MzgzMg==","diff_hunk":"@@ -391,21 +394,36 @@ def service_unavailable_predicate(service_name):\n     return response.status_code == 500\n \n \n-def wait_for_service_endpoint(service_name, timeout_sec=120):\n-    \"\"\"Checks the service url if available it returns true, on expiration\n-    it returns false\"\"\"\n+def wait_for_service_endpoint(service_name, timeout_sec=120, path=\"\"):\n+    \"\"\"\n+    Checks the service url. Waits for exhibitor to start up (up to 20 minutes) and then checks the url on all masters.\n+\n+    if available it returns true,\n+    on expiration throws an exception\n+    \"\"\"\n+\n+    def master_service_status_code(url):\n+        logger.info('Querying %s', url)\n+        auth = DCOSAcsAuth(dcos_acs_token())\n+\n+        response = requests.get(\n+            url=url,\n+            timeout=5,\n+            auth=auth,\n+            verify=verify_ssl())\n+\n+        return response.status_code\n \n-    master_count = len(get_all_masters())\n-    return time_wait(lambda: service_available_predicate(service_name),\n-                     timeout_seconds=timeout_sec,\n-                     required_consecutive_success_count=master_count)\n+    schema = 'https' if ee_version() == 'strict' or ee_version() == 'permissive' else 'http'\n+    logger.info('Waiting for service /service/{}/{} to become available on all masters'.format(service_name, path))\n \n+    for ip in dcos_masters_public_ips():\n+        url = \"{}://{}/service/{}/{}\".format(schema, ip, service_name, path)\n+        assert_that(lambda: master_service_status_code(url), eventually(equal_to(200), max_attempts=timeout_sec/5))\n \n-def wait_for_service_endpoint_removal(service_name, timeout_sec=120):\n-    \"\"\"Checks the service url if it is removed it returns true, on expiration\n-    it returns false\"\"\"\n \n-    return time_wait(lambda: service_unavailable_predicate(service_name), timeout_seconds=timeout_sec)\n+def wait_for_service_endpoint_removal(service_name):","path":"tests/shakedown/shakedown/dcos/service.py","position":81,"original_position":81,"commit_id":"2c51ffb8396a2353f8070ae58c6769cda7da004b","original_commit_id":"2c51ffb8396a2353f8070ae58c6769cda7da004b","user":{"login":"zen-dog","id":7558454,"node_id":"MDQ6VXNlcjc1NTg0NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7558454?v=4","gravatar_id":"","url":"https://api.github.com/users/zen-dog","html_url":"https://github.com/zen-dog","followers_url":"https://api.github.com/users/zen-dog/followers","following_url":"https://api.github.com/users/zen-dog/following{/other_user}","gists_url":"https://api.github.com/users/zen-dog/gists{/gist_id}","starred_url":"https://api.github.com/users/zen-dog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zen-dog/subscriptions","organizations_url":"https://api.github.com/users/zen-dog/orgs","repos_url":"https://api.github.com/users/zen-dog/repos","events_url":"https://api.github.com/users/zen-dog/events{/privacy}","received_events_url":"https://api.github.com/users/zen-dog/received_events","type":"User","site_admin":false},"body":"Again with timeouts...","created_at":"2018-11-16T10:51:26Z","updated_at":"2018-11-16T10:52:33Z","html_url":"https://github.com/mesosphere/marathon/pull/6644#discussion_r234163832","pull_request_url":"https://api.github.com/repos/mesosphere/marathon/pulls/6644","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/234163832"},"html":{"href":"https://github.com/mesosphere/marathon/pull/6644#discussion_r234163832"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/6644"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/6644","id":227637634,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NjM3NjM0","html_url":"https://github.com/mesosphere/marathon/pull/6644","diff_url":"https://github.com/mesosphere/marathon/pull/6644.diff","patch_url":"https://github.com/mesosphere/marathon/pull/6644.patch","issue_url":"https://api.github.com/repos/mesosphere/marathon/issues/6644","number":6644,"state":"open","locked":false,"title":" Remove spinner in favour of eventually/retrying. ","user":{"login":"jeschkies","id":2418440,"node_id":"MDQ6VXNlcjI0MTg0NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2418440?v=4","gravatar_id":"","url":"https://api.github.com/users/jeschkies","html_url":"https://github.com/jeschkies","followers_url":"https://api.github.com/users/jeschkies/followers","following_url":"https://api.github.com/users/jeschkies/following{/other_user}","gists_url":"https://api.github.com/users/jeschkies/gists{/gist_id}","starred_url":"https://api.github.com/users/jeschkies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeschkies/subscriptions","organizations_url":"https://api.github.com/users/jeschkies/orgs","repos_url":"https://api.github.com/users/jeschkies/repos","events_url":"https://api.github.com/users/jeschkies/events{/privacy}","received_events_url":"https://api.github.com/users/jeschkies/received_events","type":"User","site_admin":false},"body":"Summary:\r\n`assert_that(lambda: ..., eventually(...))` provides better error output. This diffs migrates all spinner calls to the new pattern.\r\n\r\nDepends on #6643.\r\n\r\nJIRA issues: MARATHON-8387","created_at":"2018-11-01T14:29:35Z","updated_at":"2018-11-16T10:52:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcd7e6bd7abbbb295022db686d3718de3e9c4ec7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kensipe","id":27497,"node_id":"MDQ6VXNlcjI3NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/27497?v=4","gravatar_id":"","url":"https://api.github.com/users/kensipe","html_url":"https://github.com/kensipe","followers_url":"https://api.github.com/users/kensipe/followers","following_url":"https://api.github.com/users/kensipe/following{/other_user}","gists_url":"https://api.github.com/users/kensipe/gists{/gist_id}","starred_url":"https://api.github.com/users/kensipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kensipe/subscriptions","organizations_url":"https://api.github.com/users/kensipe/orgs","repos_url":"https://api.github.com/users/kensipe/repos","events_url":"https://api.github.com/users/kensipe/events{/privacy}","received_events_url":"https://api.github.com/users/kensipe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/marathon/pulls/6644/commits","review_comments_url":"https://api.github.com/repos/mesosphere/marathon/pulls/6644/comments","review_comment_url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/marathon/issues/6644/comments","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/2c51ffb8396a2353f8070ae58c6769cda7da004b","head":{"label":"mesosphere:karsten/remove-spinner","ref":"karsten/remove-spinner","sha":"2c51ffb8396a2353f8070ae58c6769cda7da004b","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk0MTQwOQ==","name":"marathon","full_name":"mesosphere/marathon","private":false,"owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/marathon/deployments","created_at":"2013-06-25T14:56:34Z","updated_at":"2018-11-16T10:52:11Z","pushed_at":"2018-11-16T10:52:03Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"git@github.com:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":38743,"stargazers_count":3751,"watchers_count":3751,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":862,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":862,"open_issues":15,"watchers":3751,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"81517df895e15b9e75f47622b773ac34762f5f78","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk0MTQwOQ==","name":"marathon","full_name":"mesosphere/marathon","private":false,"owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/marathon/deployments","created_at":"2013-06-25T14:56:34Z","updated_at":"2018-11-16T10:52:11Z","pushed_at":"2018-11-16T10:52:03Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"git@github.com:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":38743,"stargazers_count":3751,"watchers_count":3751,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":862,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":862,"open_issues":15,"watchers":3751,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/6644"},"html":{"href":"https://github.com/mesosphere/marathon/pull/6644"},"issue":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/6644"},"comments":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/6644/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/6644/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/6644/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/marathon/statuses/2c51ffb8396a2353f8070ae58c6769cda7da004b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"zen-dog"}}