{"action":"created","comment":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments/219957318","pull_request_review_id":158255631,"id":219957318,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTk1NzMxOA==","diff_hunk":"@@ -16,8 +16,12 @@ Errors while building static HTML files generally happen for two reasons.\n     sub-directories) are exporting either a React component or string. Gatsby\n     treats any JS file listed under the pages dir as a page component, so it must\n     have a default export that's a component or string.\n+    \n+3.  You mix up `import` and `require` calls in the same file. This might lead to \n+    \"WebpackError: Invariant Violation: Minified React error #130\" since Webpack 4 \n+    is stricter than v3. The solution is to only use `import`.\n \n-3.  Some other reason :-) #1 is the most common reason building static files\n+4.  Some other reason :-) #1 is the most common reason building static files","path":"docs/docs/debugging-html-builds.md","position":10,"original_position":10,"commit_id":"36c695a09dc5006e2c65e5f60e650c15195b2a12","original_commit_id":"36c695a09dc5006e2c65e5f60e650c15195b2a12","user":{"login":"DSchau","id":3924690,"node_id":"MDQ6VXNlcjM5MjQ2OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3924690?v=4","gravatar_id":"","url":"https://api.github.com/users/DSchau","html_url":"https://github.com/DSchau","followers_url":"https://api.github.com/users/DSchau/followers","following_url":"https://api.github.com/users/DSchau/following{/other_user}","gists_url":"https://api.github.com/users/DSchau/gists{/gist_id}","starred_url":"https://api.github.com/users/DSchau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSchau/subscriptions","organizations_url":"https://api.github.com/users/DSchau/orgs","repos_url":"https://api.github.com/users/DSchau/repos","events_url":"https://api.github.com/users/DSchau/events{/privacy}","received_events_url":"https://api.github.com/users/DSchau/received_events","type":"User","site_admin":false},"body":"May as well just call these all `1.` so Markdown handles it for us 🙃 ","created_at":"2018-09-24T19:19:54Z","updated_at":"2018-09-24T19:19:54Z","html_url":"https://github.com/gatsbyjs/gatsby/pull/8493#discussion_r219957318","pull_request_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8493","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments/219957318"},"html":{"href":"https://github.com/gatsbyjs/gatsby/pull/8493#discussion_r219957318"},"pull_request":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8493"}}},"pull_request":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8493","id":217626064,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjI2MDY0","html_url":"https://github.com/gatsbyjs/gatsby/pull/8493","diff_url":"https://github.com/gatsbyjs/gatsby/pull/8493.diff","patch_url":"https://github.com/gatsbyjs/gatsby/pull/8493.patch","issue_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/8493","number":8493,"state":"open","locked":false,"title":"debugging build: error due to import/require mix","user":{"login":"jakubholynet","id":624958,"node_id":"MDQ6VXNlcjYyNDk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/624958?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubholynet","html_url":"https://github.com/jakubholynet","followers_url":"https://api.github.com/users/jakubholynet/followers","following_url":"https://api.github.com/users/jakubholynet/following{/other_user}","gists_url":"https://api.github.com/users/jakubholynet/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubholynet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubholynet/subscriptions","organizations_url":"https://api.github.com/users/jakubholynet/orgs","repos_url":"https://api.github.com/users/jakubholynet/repos","events_url":"https://api.github.com/users/jakubholynet/events{/privacy}","received_events_url":"https://api.github.com/users/jakubholynet/received_events","type":"User","site_admin":false},"body":"Mention that build may fail with\r\n\r\n```\r\nerror Building static HTML for pages failed\r\n\r\nSee our docs page on debugging HTML builds for help https://goo.gl/yL9lND\r\n\r\n   8 | \telse\r\n   9 | \t\troot[\"lib\"] = factory(root[\"@reach/router\"], root[\"core-js/modules/es6.array.sort\"], root[\"fs\"], root[\"lodash\"], root[\"path\"], root[\"react\"], root[\"react-dom/server\"], root[\"react-helmet\"]);\r\n> 10 | })(this, function(__WEBPACK_EXTERNAL_MODULE__reach_router__, __WEBPACK_EXTERNAL_MODULE_core_js_modules_es6_array_sort__, __WEBPACK_EXTERNAL_MODULE_fs__, __WEBPACK_EXTERNAL_MODULE_lodash__, __WEBPACK_EXTERNAL_MODULE_path__, __WEBPACK_EXTERNAL_MODULE_react__, __WEBPACK_EXTERNAL_MODULE_react_dom_server__, __WEBPACK_EXTERNAL_MODULE_react_helmet__) {\r\n     |  ^\r\n  11 | return\r\n\r\n\r\n  WebpackError: Invariant Violation: Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invari  ant=130&args[]=undefined&args[]= for the full message or use the non-minified dev environment for full errors and addi  tional helpful warnings.\r\n```\r\n\r\nwhen we mix `import` and `require` in the same (page) file in Gatsby 2, which has upgraded to Webpack 4, which is stricter about this.\r\n\r\n<!--\r\n  Q. Which branch should I use for my pull request?\r\n  A. Use `master` branch (probably).\r\n\r\n  Q. Which branch if my change is a bug fix for Gatsby v1?\r\n  A. In this case, you should use the `v1` branch\r\n\r\n  Q. Which branch if I'm still not sure?\r\n  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)\r\n\r\n  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.\r\n\r\n  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/\r\n-->\r\n","created_at":"2018-09-24T11:31:42Z","updated_at":"2018-09-24T19:19:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"746a61e57007f235164596a35314b055f083d368","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8493/commits","review_comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8493/comments","review_comment_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/8493/comments","statuses_url":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/36c695a09dc5006e2c65e5f60e650c15195b2a12","head":{"label":"jakubholynet:patch-3","ref":"patch-3","sha":"36c695a09dc5006e2c65e5f60e650c15195b2a12","user":{"login":"jakubholynet","id":624958,"node_id":"MDQ6VXNlcjYyNDk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/624958?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubholynet","html_url":"https://github.com/jakubholynet","followers_url":"https://api.github.com/users/jakubholynet/followers","following_url":"https://api.github.com/users/jakubholynet/following{/other_user}","gists_url":"https://api.github.com/users/jakubholynet/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubholynet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubholynet/subscriptions","organizations_url":"https://api.github.com/users/jakubholynet/orgs","repos_url":"https://api.github.com/users/jakubholynet/repos","events_url":"https://api.github.com/users/jakubholynet/events{/privacy}","received_events_url":"https://api.github.com/users/jakubholynet/received_events","type":"User","site_admin":false},"repo":{"id":150091087,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAwOTEwODc=","name":"gatsby","full_name":"jakubholynet/gatsby","private":false,"owner":{"login":"jakubholynet","id":624958,"node_id":"MDQ6VXNlcjYyNDk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/624958?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubholynet","html_url":"https://github.com/jakubholynet","followers_url":"https://api.github.com/users/jakubholynet/followers","following_url":"https://api.github.com/users/jakubholynet/following{/other_user}","gists_url":"https://api.github.com/users/jakubholynet/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubholynet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubholynet/subscriptions","organizations_url":"https://api.github.com/users/jakubholynet/orgs","repos_url":"https://api.github.com/users/jakubholynet/repos","events_url":"https://api.github.com/users/jakubholynet/events{/privacy}","received_events_url":"https://api.github.com/users/jakubholynet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jakubholynet/gatsby","description":"⚛️📄🚀 Blazing fast site generator for React","fork":true,"url":"https://api.github.com/repos/jakubholynet/gatsby","forks_url":"https://api.github.com/repos/jakubholynet/gatsby/forks","keys_url":"https://api.github.com/repos/jakubholynet/gatsby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakubholynet/gatsby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakubholynet/gatsby/teams","hooks_url":"https://api.github.com/repos/jakubholynet/gatsby/hooks","issue_events_url":"https://api.github.com/repos/jakubholynet/gatsby/issues/events{/number}","events_url":"https://api.github.com/repos/jakubholynet/gatsby/events","assignees_url":"https://api.github.com/repos/jakubholynet/gatsby/assignees{/user}","branches_url":"https://api.github.com/repos/jakubholynet/gatsby/branches{/branch}","tags_url":"https://api.github.com/repos/jakubholynet/gatsby/tags","blobs_url":"https://api.github.com/repos/jakubholynet/gatsby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakubholynet/gatsby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakubholynet/gatsby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakubholynet/gatsby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakubholynet/gatsby/statuses/{sha}","languages_url":"https://api.github.com/repos/jakubholynet/gatsby/languages","stargazers_url":"https://api.github.com/repos/jakubholynet/gatsby/stargazers","contributors_url":"https://api.github.com/repos/jakubholynet/gatsby/contributors","subscribers_url":"https://api.github.com/repos/jakubholynet/gatsby/subscribers","subscription_url":"https://api.github.com/repos/jakubholynet/gatsby/subscription","commits_url":"https://api.github.com/repos/jakubholynet/gatsby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakubholynet/gatsby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakubholynet/gatsby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakubholynet/gatsby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakubholynet/gatsby/contents/{+path}","compare_url":"https://api.github.com/repos/jakubholynet/gatsby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakubholynet/gatsby/merges","archive_url":"https://api.github.com/repos/jakubholynet/gatsby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakubholynet/gatsby/downloads","issues_url":"https://api.github.com/repos/jakubholynet/gatsby/issues{/number}","pulls_url":"https://api.github.com/repos/jakubholynet/gatsby/pulls{/number}","milestones_url":"https://api.github.com/repos/jakubholynet/gatsby/milestones{/number}","notifications_url":"https://api.github.com/repos/jakubholynet/gatsby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakubholynet/gatsby/labels{/name}","releases_url":"https://api.github.com/repos/jakubholynet/gatsby/releases{/id}","deployments_url":"https://api.github.com/repos/jakubholynet/gatsby/deployments","created_at":"2018-09-24T11:15:12Z","updated_at":"2018-09-24T11:15:32Z","pushed_at":"2018-09-24T11:31:31Z","git_url":"git://github.com/jakubholynet/gatsby.git","ssh_url":"git@github.com:jakubholynet/gatsby.git","clone_url":"https://github.com/jakubholynet/gatsby.git","svn_url":"https://github.com/jakubholynet/gatsby","homepage":"https://www.gatsbyjs.org","size":428178,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gatsbyjs:master","ref":"master","sha":"efe95a4eb4326e4b116c54346ced7412cc7be467","user":{"login":"gatsbyjs","id":12551863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/12551863?v=4","gravatar_id":"","url":"https://api.github.com/users/gatsbyjs","html_url":"https://github.com/gatsbyjs","followers_url":"https://api.github.com/users/gatsbyjs/followers","following_url":"https://api.github.com/users/gatsbyjs/following{/other_user}","gists_url":"https://api.github.com/users/gatsbyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gatsbyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatsbyjs/subscriptions","organizations_url":"https://api.github.com/users/gatsbyjs/orgs","repos_url":"https://api.github.com/users/gatsbyjs/repos","events_url":"https://api.github.com/users/gatsbyjs/events{/privacy}","received_events_url":"https://api.github.com/users/gatsbyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":36040894,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA0MDg5NA==","name":"gatsby","full_name":"gatsbyjs/gatsby","private":false,"owner":{"login":"gatsbyjs","id":12551863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/12551863?v=4","gravatar_id":"","url":"https://api.github.com/users/gatsbyjs","html_url":"https://github.com/gatsbyjs","followers_url":"https://api.github.com/users/gatsbyjs/followers","following_url":"https://api.github.com/users/gatsbyjs/following{/other_user}","gists_url":"https://api.github.com/users/gatsbyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gatsbyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatsbyjs/subscriptions","organizations_url":"https://api.github.com/users/gatsbyjs/orgs","repos_url":"https://api.github.com/users/gatsbyjs/repos","events_url":"https://api.github.com/users/gatsbyjs/events{/privacy}","received_events_url":"https://api.github.com/users/gatsbyjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gatsbyjs/gatsby","description":"⚛️📄🚀 Blazing fast site generator for React","fork":false,"url":"https://api.github.com/repos/gatsbyjs/gatsby","forks_url":"https://api.github.com/repos/gatsbyjs/gatsby/forks","keys_url":"https://api.github.com/repos/gatsbyjs/gatsby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gatsbyjs/gatsby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gatsbyjs/gatsby/teams","hooks_url":"https://api.github.com/repos/gatsbyjs/gatsby/hooks","issue_events_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/events{/number}","events_url":"https://api.github.com/repos/gatsbyjs/gatsby/events","assignees_url":"https://api.github.com/repos/gatsbyjs/gatsby/assignees{/user}","branches_url":"https://api.github.com/repos/gatsbyjs/gatsby/branches{/branch}","tags_url":"https://api.github.com/repos/gatsbyjs/gatsby/tags","blobs_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/refs{/sha}","trees_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/{sha}","languages_url":"https://api.github.com/repos/gatsbyjs/gatsby/languages","stargazers_url":"https://api.github.com/repos/gatsbyjs/gatsby/stargazers","contributors_url":"https://api.github.com/repos/gatsbyjs/gatsby/contributors","subscribers_url":"https://api.github.com/repos/gatsbyjs/gatsby/subscribers","subscription_url":"https://api.github.com/repos/gatsbyjs/gatsby/subscription","commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/commits{/sha}","git_commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/commits{/sha}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/comments{/number}","issue_comment_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/comments{/number}","contents_url":"https://api.github.com/repos/gatsbyjs/gatsby/contents/{+path}","compare_url":"https://api.github.com/repos/gatsbyjs/gatsby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gatsbyjs/gatsby/merges","archive_url":"https://api.github.com/repos/gatsbyjs/gatsby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gatsbyjs/gatsby/downloads","issues_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues{/number}","pulls_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls{/number}","milestones_url":"https://api.github.com/repos/gatsbyjs/gatsby/milestones{/number}","notifications_url":"https://api.github.com/repos/gatsbyjs/gatsby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gatsbyjs/gatsby/labels{/name}","releases_url":"https://api.github.com/repos/gatsbyjs/gatsby/releases{/id}","deployments_url":"https://api.github.com/repos/gatsbyjs/gatsby/deployments","created_at":"2015-05-21T22:43:05Z","updated_at":"2018-09-24T18:07:21Z","pushed_at":"2018-09-24T19:10:25Z","git_url":"git://github.com/gatsbyjs/gatsby.git","ssh_url":"git@github.com:gatsbyjs/gatsby.git","clone_url":"https://github.com/gatsbyjs/gatsby.git","svn_url":"https://github.com/gatsbyjs/gatsby","homepage":"https://www.gatsbyjs.org","size":428271,"stargazers_count":25924,"watchers_count":25924,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2947,"mirror_url":null,"archived":false,"open_issues_count":693,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2947,"open_issues":693,"watchers":25924,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8493"},"html":{"href":"https://github.com/gatsbyjs/gatsby/pull/8493"},"issue":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/issues/8493"},"comments":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/issues/8493/comments"},"review_comments":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8493/comments"},"review_comment":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/8493/commits"},"statuses":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/36c695a09dc5006e2c65e5f60e650c15195b2a12"}},"author_association":"NONE"}}
{"actor":{"display_login":"DSchau"}}