{"action":"created","issue":{"url":"https://api.github.com/repos/vladest/googlemaps/issues/25","repository_url":"https://api.github.com/repos/vladest/googlemaps","labels_url":"https://api.github.com/repos/vladest/googlemaps/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/vladest/googlemaps/issues/25/comments","events_url":"https://api.github.com/repos/vladest/googlemaps/issues/25/events","html_url":"https://github.com/vladest/googlemaps/pull/25","id":327947326,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjE0Mzk4","number":25,"title":"Enable downloading tiles for High DPI displays","user":{"login":"mfbernardes","id":30494,"node_id":"MDQ6VXNlcjMwNDk0","avatar_url":"https://avatars0.githubusercontent.com/u/30494?v=4","gravatar_id":"","url":"https://api.github.com/users/mfbernardes","html_url":"https://github.com/mfbernardes","followers_url":"https://api.github.com/users/mfbernardes/followers","following_url":"https://api.github.com/users/mfbernardes/following{/other_user}","gists_url":"https://api.github.com/users/mfbernardes/gists{/gist_id}","starred_url":"https://api.github.com/users/mfbernardes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfbernardes/subscriptions","organizations_url":"https://api.github.com/users/mfbernardes/orgs","repos_url":"https://api.github.com/users/mfbernardes/repos","events_url":"https://api.github.com/users/mfbernardes/events{/privacy}","received_events_url":"https://api.github.com/users/mfbernardes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-31T00:23:27Z","updated_at":"2018-05-31T12:15:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/vladest/googlemaps/pulls/25","html_url":"https://github.com/vladest/googlemaps/pull/25","diff_url":"https://github.com/vladest/googlemaps/pull/25.diff","patch_url":"https://github.com/vladest/googlemaps/pull/25.patch"},"body":"Signed-off-by: Murillo Bernardes <mfbernardes@gmail.com>\r\n\r\nAdd support to maps api scale parameter, as documented in https://developers.google.com/maps/documentation/maps-static/intro#scale_values.\r\n\r\nExample of new vs current.\r\n\r\nCurrent | High DPI\r\n------------ | -------------\r\n![qtgmaps-current](https://user-images.githubusercontent.com/30494/40754085-a8a46816-6477-11e8-8f1c-11c8b4463507.PNG) | ![qtgmaps-highdpi](https://user-images.githubusercontent.com/30494/40754086-a8c4acfc-6477-11e8-9088-ecfec1bbc2ad.PNG)\r\n\r\n@dirkhh "},"comment":{"url":"https://api.github.com/repos/vladest/googlemaps/issues/comments/393510992","html_url":"https://github.com/vladest/googlemaps/pull/25#issuecomment-393510992","issue_url":"https://api.github.com/repos/vladest/googlemaps/issues/25","id":393510992,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzUxMDk5Mg==","user":{"login":"neolit123","id":331852,"node_id":"MDQ6VXNlcjMzMTg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T12:15:17Z","updated_at":"2018-05-31T12:15:17Z","author_association":"CONTRIBUTOR","body":"> I certainly appreciate the idea of having hidpi tiles - but of course that comes at a price, especially (again, talking about our specific use case) when you are at a dive site with low quality internet (a stunningly frequent thing, really). Which makes me wonder how we'd decide which ones to use? If the parameter is set and the tiles take too long to load (some timeout?) then fall back to the lower resolution tiles?\r\n\r\nupdating the HQ tiles dynamically on runtime based on the internet connection is doable, but there is another problem, which i forgot about and cannot confirm at 100% for the HQ tiles, yet but i'm pretty sure it's the case.\r\n\r\nfor the language support of tiles we did the following in Subsurface - the user can change the language, but ideally Subsurface has to be restarted and we then clear the cache. because the cache becomes a mixture of old language and new language.\r\n\r\nthis is due to the cache file names being the same no matter what params are added (language, HQ tiles, etc).\r\n\r\nthe same mix would happen with the HQ / LQ tiles and therefore we cannot do it dynamically. it has to be done and then Subsurface needs to restart and the cache has to be cleared.\r\n\r\n> I'm trying to look at this bigger picture and not end up with a situation where the user experience ends up being worse on modern devices (which are all high dpi)...\r\nOf course, I haven't tried this, I haven't looked at the amount of data that is downloaded. This change will cause us to download tiles that should be about 4x in size, correct?\r\n\r\n4x is a good estimate.\r\nfrom what i've tested on the mobile app with the LQ tiles, i think if we enable HQ tiles by default it would not perform well.\r\n\r\ni think we should do HQ tiles only on the desktop if hardcoded.\r\n...or make it optional on mobile / desktop, but on both versions the switch would need a restart and clearing the cache.\r\n"}}
{"actor":{"display_login":"neolit123"}}