{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3504","repository_url":"https://api.github.com/repos/apache/incubator-openwhisk","labels_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3504/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3504/comments","events_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3504/events","html_url":"https://github.com/apache/incubator-openwhisk/pull/3504","id":309976971,"number":3504,"title":"use alpine-java base image (alpine 3.7 + oracle 8u162b12_server-jre)","user":{"login":"tysonnorris","id":1638396,"avatar_url":"https://avatars1.githubusercontent.com/u/1638396?v=4","gravatar_id":"","url":"https://api.github.com/users/tysonnorris","html_url":"https://github.com/tysonnorris","followers_url":"https://api.github.com/users/tysonnorris/followers","following_url":"https://api.github.com/users/tysonnorris/following{/other_user}","gists_url":"https://api.github.com/users/tysonnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/tysonnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysonnorris/subscriptions","organizations_url":"https://api.github.com/users/tysonnorris/orgs","repos_url":"https://api.github.com/users/tysonnorris/repos","events_url":"https://api.github.com/users/tysonnorris/events{/privacy}","received_events_url":"https://api.github.com/users/tysonnorris/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-03-30T05:12:14Z","updated_at":"2018-04-27T22:47:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3504","html_url":"https://github.com/apache/incubator-openwhisk/pull/3504","diff_url":"https://github.com/apache/incubator-openwhisk/pull/3504.diff","patch_url":"https://github.com/apache/incubator-openwhisk/pull/3504.patch"},"body":"<!--- Provide a concise summary of your changes in the Title -->\r\nuse a prebuilt alpine+oracle java image\r\n\r\n## Description\r\n<!--- Provide a detailed description of your changes. -->\r\n<!--- Include details of what problem you are solving and how your changes are tested. -->\r\nAs briefly discussed in https://github.com/apache/incubator-openwhisk/pull/3063#pullrequestreview-90904845, why not use a pre-baked image with the oracle java bits already setup, since the Dockerfile is somewhat complicated for alpine + oracle java.\r\n\r\nI currently chose the 8u162b12_server-jre variant, and not the 8u162b12_jdk variant - from what I've read most jdk runtime tools are there, but I don't have an exhaustive list of differences. Open to change to jdk if needed, but if not, would rather avoid the extra space and use the smallest possible base image.\r\n\r\nsed + curl are installed, since they are required for init scripts in use already. curl is used by alpine-java, but removed after use; sed is available without update, but not compatible with our sed usage in transformEnvironment.sh. \r\n\r\n\r\n## Related issue and scope\r\n<!--- Please include a link to a related issue if there is one. -->\r\n- [ ] I opened an issue to propose and discuss this change (#????)\r\n\r\n## My changes affect the following components\r\n<!--- Select below all system components are affected by your change. -->\r\n<!--- Enter an `x` in all applicable boxes. -->\r\n- [ ] API\r\n- [x] Controller\r\n- [ ] Message Bus (e.g., Kafka)\r\n- [ ] Loadbalancer\r\n- [x] Invoker\r\n- [ ] Intrinsic actions (e.g., sequences, conductors)\r\n- [ ] Data stores (e.g., CouchDB)\r\n- [ ] Tests\r\n- [ ] Deployment\r\n- [ ] CLI\r\n- [ ] General tooling\r\n- [ ] Documentation\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (generally a non-breaking change which closes an issue).\r\n- [x] Enhancement or new feature (adds new functionality).\r\n- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).\r\n\r\n## Checklist:\r\n<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->\r\n\r\n- [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).\r\n- [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).\r\n- [ ] I added tests to cover my changes.\r\n- [ ] My changes require further changes to the documentation.\r\n- [ ] I updated the documentation where necessary.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/comments/385112773","html_url":"https://github.com/apache/incubator-openwhisk/pull/3504#issuecomment-385112773","issue_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3504","id":385112773,"user":{"login":"tysonnorris","id":1638396,"avatar_url":"https://avatars1.githubusercontent.com/u/1638396?v=4","gravatar_id":"","url":"https://api.github.com/users/tysonnorris","html_url":"https://github.com/tysonnorris","followers_url":"https://api.github.com/users/tysonnorris/followers","following_url":"https://api.github.com/users/tysonnorris/following{/other_user}","gists_url":"https://api.github.com/users/tysonnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/tysonnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysonnorris/subscriptions","organizations_url":"https://api.github.com/users/tysonnorris/orgs","repos_url":"https://api.github.com/users/tysonnorris/repos","events_url":"https://api.github.com/users/tysonnorris/events{/privacy}","received_events_url":"https://api.github.com/users/tysonnorris/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T22:47:21Z","updated_at":"2018-04-27T22:47:21Z","author_association":"CONTRIBUTOR","body":"@csantanapr the adoptopenjdk image you pointed to was `openjdk8-openj9` - I assume that is a j9 one? \r\n\r\nI didn't want to use the version-less tags like `openjdk:8-jdk-alpine`, and did not find one with a version e.g. `8u152-b16` + alpine, but I'm open to suggestions.\r\n\r\nClosest I found with openjdk (not j9) + jdk version + alpine is `adoptopenjdk/openjdk8:jdk8u152-b16-alpine`."}}
{"actor":{"display_login":"tysonnorris"}}