{"action":"created","issue":{"url":"https://api.github.com/repos/ericsink/SQLitePCL.raw/issues/235","repository_url":"https://api.github.com/repos/ericsink/SQLitePCL.raw","labels_url":"https://api.github.com/repos/ericsink/SQLitePCL.raw/issues/235/labels{/name}","comments_url":"https://api.github.com/repos/ericsink/SQLitePCL.raw/issues/235/comments","events_url":"https://api.github.com/repos/ericsink/SQLitePCL.raw/issues/235/events","html_url":"https://github.com/ericsink/SQLitePCL.raw/issues/235","id":370797188,"node_id":"MDU6SXNzdWUzNzA3OTcxODg=","number":235,"title":"Static linking issue with bundle_zetetic under Xamarin.iOS","user":{"login":"sjlombardo","id":10047,"node_id":"MDQ6VXNlcjEwMDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/10047?v=4","gravatar_id":"","url":"https://api.github.com/users/sjlombardo","html_url":"https://github.com/sjlombardo","followers_url":"https://api.github.com/users/sjlombardo/followers","following_url":"https://api.github.com/users/sjlombardo/following{/other_user}","gists_url":"https://api.github.com/users/sjlombardo/gists{/gist_id}","starred_url":"https://api.github.com/users/sjlombardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjlombardo/subscriptions","organizations_url":"https://api.github.com/users/sjlombardo/orgs","repos_url":"https://api.github.com/users/sjlombardo/repos","events_url":"https://api.github.com/users/sjlombardo/events{/privacy}","received_events_url":"https://api.github.com/users/sjlombardo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-10-16T20:59:12Z","updated_at":"2018-12-21T21:42:33Z","closed_at":"2018-12-19T15:32:47Z","author_association":"NONE","body":"Hello @ericsink, we're in the midst of finalizing a major update for SQLCipher and we'd like to fully support bundle_zetetic as part of the release. However, we're running into a problem with the Xamarin.iOS linker. It is removing our embedded library, because it thinks it is unused. I believe this is the same problem you ran into previously with #99.  \r\n\r\nWe think the right approach to fix this would be to use the same technique used in ios_unified.static, i.e. by creating an explicit dependency via `embedded.Init()` so that the linker will do the right thing. However, the Batteries_V2.Init() that is brought in via batteries_zetetic doesn't include that call on iOS, because EMBEDDED_INIT is not defined. \r\n\r\nOur initial though was that adding `cfg.defines.Add(\"EMBEDDED_INIT\");` to `create_internal_batteries_zetetic()` in [gen_build.cs on line 1108](https://github.com/ericsink/SQLitePCL.raw/blob/master/gen_build.cs#L1108) would fix that. Then we could simply implement an `embedded.Init()` within our native library package that would complete the dependency chain and cause the Xamarin.iOS linker to do the right thing.\r\n\r\nDo you think this would be a good approach to resolve the problem, or would you have any other suggestion for a better way to go about this?\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ericsink/SQLitePCL.raw/issues/comments/449505468","html_url":"https://github.com/ericsink/SQLitePCL.raw/issues/235#issuecomment-449505468","issue_url":"https://api.github.com/repos/ericsink/SQLitePCL.raw/issues/235","id":449505468,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTUwNTQ2OA==","user":{"login":"sjlombardo","id":10047,"node_id":"MDQ6VXNlcjEwMDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/10047?v=4","gravatar_id":"","url":"https://api.github.com/users/sjlombardo","html_url":"https://github.com/sjlombardo","followers_url":"https://api.github.com/users/sjlombardo/followers","following_url":"https://api.github.com/users/sjlombardo/following{/other_user}","gists_url":"https://api.github.com/users/sjlombardo/gists{/gist_id}","starred_url":"https://api.github.com/users/sjlombardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjlombardo/subscriptions","organizations_url":"https://api.github.com/users/sjlombardo/orgs","repos_url":"https://api.github.com/users/sjlombardo/repos","events_url":"https://api.github.com/users/sjlombardo/events{/privacy}","received_events_url":"https://api.github.com/users/sjlombardo/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T21:42:33Z","updated_at":"2018-12-21T21:42:33Z","author_association":"NONE","body":"Hi @ericsink - we just tested this out and it's looking good. Thanks for resolving this!"}}
{"actor":{"display_login":"sjlombardo"}}