{"action":"closed","issue":{"url":"https://api.github.com/repos/mlp2018/fraud_detection/issues/24","repository_url":"https://api.github.com/repos/mlp2018/fraud_detection","labels_url":"https://api.github.com/repos/mlp2018/fraud_detection/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/mlp2018/fraud_detection/issues/24/comments","events_url":"https://api.github.com/repos/mlp2018/fraud_detection/issues/24/events","html_url":"https://github.com/mlp2018/fraud_detection/issues/24","id":320252217,"number":24,"title":"Import predictor variables from preprocessing.py","user":{"login":"johannadevos","id":20280513,"avatar_url":"https://avatars0.githubusercontent.com/u/20280513?v=4","gravatar_id":"","url":"https://api.github.com/users/johannadevos","html_url":"https://github.com/johannadevos","followers_url":"https://api.github.com/users/johannadevos/followers","following_url":"https://api.github.com/users/johannadevos/following{/other_user}","gists_url":"https://api.github.com/users/johannadevos/gists{/gist_id}","starred_url":"https://api.github.com/users/johannadevos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannadevos/subscriptions","organizations_url":"https://api.github.com/users/johannadevos/orgs","repos_url":"https://api.github.com/users/johannadevos/repos","events_url":"https://api.github.com/users/johannadevos/events{/privacy}","received_events_url":"https://api.github.com/users/johannadevos/received_events","type":"User","site_admin":false},"labels":[{"id":908437383,"url":"https://api.github.com/repos/mlp2018/fraud_detection/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"closed","locked":false,"assignee":{"login":"johannadevos","id":20280513,"avatar_url":"https://avatars0.githubusercontent.com/u/20280513?v=4","gravatar_id":"","url":"https://api.github.com/users/johannadevos","html_url":"https://github.com/johannadevos","followers_url":"https://api.github.com/users/johannadevos/followers","following_url":"https://api.github.com/users/johannadevos/following{/other_user}","gists_url":"https://api.github.com/users/johannadevos/gists{/gist_id}","starred_url":"https://api.github.com/users/johannadevos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannadevos/subscriptions","organizations_url":"https://api.github.com/users/johannadevos/orgs","repos_url":"https://api.github.com/users/johannadevos/repos","events_url":"https://api.github.com/users/johannadevos/events{/privacy}","received_events_url":"https://api.github.com/users/johannadevos/received_events","type":"User","site_admin":false},"assignees":[{"login":"johannadevos","id":20280513,"avatar_url":"https://avatars0.githubusercontent.com/u/20280513?v=4","gravatar_id":"","url":"https://api.github.com/users/johannadevos","html_url":"https://github.com/johannadevos","followers_url":"https://api.github.com/users/johannadevos/followers","following_url":"https://api.github.com/users/johannadevos/following{/other_user}","gists_url":"https://api.github.com/users/johannadevos/gists{/gist_id}","starred_url":"https://api.github.com/users/johannadevos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannadevos/subscriptions","organizations_url":"https://api.github.com/users/johannadevos/orgs","repos_url":"https://api.github.com/users/johannadevos/repos","events_url":"https://api.github.com/users/johannadevos/events{/privacy}","received_events_url":"https://api.github.com/users/johannadevos/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-05-04T12:12:52Z","updated_at":"2018-05-04T13:30:58Z","closed_at":"2018-05-04T13:30:58Z","author_association":"OWNER","body":"Currently, `lightgbm_main.py` specifies the predictors that should be used:\r\n\r\n```\r\n# Columns our predictions are based on\r\n    predictors = ['app', 'device', 'os', 'channel', 'hour', 'hour_sq', 'count_ip_day_freq_h', 'count_ip_day_hour', 'count_ip_hour_os', 'count_ip_hh_app', 'count_ip_hour_device']\r\n    categorical = ['app', 'device', 'os', 'channel', 'hour', 'hour_sq', 'count_ip_day_freq_h', 'count_ip_day_hour', 'count_ip_hour_os', 'count_ip_hh_app', 'count_ip_hour_device']\r\n   \r\n```\r\n\r\nHowever, this means that if André creates a new variable in `preprocessing.py` and wants it to be used as a predictor, lightgbm_main.py needs to be updated every time as well. Therefore, it might be a better idea if `lightgbm_main.py` would import the to-be-used predictors as a list from `preprocessing.py`."}}
{"actor":{"display_login":"johannadevos"}}