{"action":"created","issue":{"url":"https://api.github.com/repos/dundalek/closh/issues/42","repository_url":"https://api.github.com/repos/dundalek/closh","labels_url":"https://api.github.com/repos/dundalek/closh/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/dundalek/closh/issues/42/comments","events_url":"https://api.github.com/repos/dundalek/closh/issues/42/events","html_url":"https://github.com/dundalek/closh/issues/42","id":284798081,"number":42,"title":"Reconsider closh and lumo distribution","user":{"login":"dundalek","id":755611,"avatar_url":"https://avatars2.githubusercontent.com/u/755611?v=4","gravatar_id":"","url":"https://api.github.com/users/dundalek","html_url":"https://github.com/dundalek","followers_url":"https://api.github.com/users/dundalek/followers","following_url":"https://api.github.com/users/dundalek/following{/other_user}","gists_url":"https://api.github.com/users/dundalek/gists{/gist_id}","starred_url":"https://api.github.com/users/dundalek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dundalek/subscriptions","organizations_url":"https://api.github.com/users/dundalek/orgs","repos_url":"https://api.github.com/users/dundalek/repos","events_url":"https://api.github.com/users/dundalek/events{/privacy}","received_events_url":"https://api.github.com/users/dundalek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-12-27T21:21:12Z","updated_at":"2018-02-22T19:41:09Z","closed_at":null,"author_association":"OWNER","body":"As I am working on the signal handling I've been running into an issue that lumo installed via npm does not start directly but inside a js script running in node which spawns the lumo child process. Therefore pressing ctrl+c interrupts the parent process and pipe to the lumo process gets closed and closh errors out and exits.\r\n\r\nTo solve the issue we could do native exec to replace the process (using something like [kexec](https://github.com/jprichardson/node-kexec), but it does not work on windows). Or run run the script directly with the lumo binary without the node wrapper.\r\n\r\nThere are couple of ways we could go:\r\n1) Keep using npm, but make the shell script that would use exec to run closh on lumo.\r\n2) Stop using npm to install, distribute lumo with closh and run directly.\r\n3) It might worth to try compile closh into a single binary using the lumo's build process and distribute a single executable.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dundalek/closh/issues/comments/367796697","html_url":"https://github.com/dundalek/closh/issues/42#issuecomment-367796697","issue_url":"https://api.github.com/repos/dundalek/closh/issues/42","id":367796697,"user":{"login":"hlolli","id":6074754,"avatar_url":"https://avatars2.githubusercontent.com/u/6074754?v=4","gravatar_id":"","url":"https://api.github.com/users/hlolli","html_url":"https://github.com/hlolli","followers_url":"https://api.github.com/users/hlolli/followers","following_url":"https://api.github.com/users/hlolli/following{/other_user}","gists_url":"https://api.github.com/users/hlolli/gists{/gist_id}","starred_url":"https://api.github.com/users/hlolli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlolli/subscriptions","organizations_url":"https://api.github.com/users/hlolli/orgs","repos_url":"https://api.github.com/users/hlolli/repos","events_url":"https://api.github.com/users/hlolli/events{/privacy}","received_events_url":"https://api.github.com/users/hlolli/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T19:41:09Z","updated_at":"2018-02-22T19:41:09Z","author_association":"NONE","body":"@dundalek I never understood why you need the nexe master, as far as I see, they changed to typescript and much of their api is totally different since Anton branched his fork, not to mention changes Anton did himself on the fork.\r\n\r\nTo make this kind of patching easier in the future, I plan to implement overrides as you can do in shadow-cljs, this should be easy to implement (basically telling pkg-lumo to replace a specific .js file from node_modules in pre-compilation in the nexe script)."}}
{"actor":{"display_login":"hlolli"}}