{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/brentsimmons/Ballard/pulls/1","id":237163211,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTYzMjEx","html_url":"https://github.com/brentsimmons/Ballard/pull/1","diff_url":"https://github.com/brentsimmons/Ballard/pull/1.diff","patch_url":"https://github.com/brentsimmons/Ballard/pull/1.patch","issue_url":"https://api.github.com/repos/brentsimmons/Ballard/issues/1","number":1,"state":"open","locked":false,"title":"Simplify tokenizer code, eliminate redundant do/catch blocks","user":{"login":"ole","id":5010,"node_id":"MDQ6VXNlcjUwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5010?v=4","gravatar_id":"","url":"https://api.github.com/users/ole","html_url":"https://github.com/ole","followers_url":"https://api.github.com/users/ole/followers","following_url":"https://api.github.com/users/ole/following{/other_user}","gists_url":"https://api.github.com/users/ole/gists{/gist_id}","starred_url":"https://api.github.com/users/ole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ole/subscriptions","organizations_url":"https://api.github.com/users/ole/orgs","repos_url":"https://api.github.com/users/ole/repos","events_url":"https://api.github.com/users/ole/events{/privacy}","received_events_url":"https://api.github.com/users/ole/received_events","type":"User","site_admin":false},"body":"Hi @brentsimmons. I followed the link to the Tokenizer code from [your blog post](http://inessential.com/2018/11/21/rainier_diary_10_ballards_tokenizer) and quickly looked through it. I hope you don't mind these suggestions.\r\n\r\nMy changes are just stylistic and shouldn't change the semantics of the code at all, so feel free to ignore what you don't like. I do think the elimination of the explicit `do`/`catch` blocks makes a lot of sense, though. There's no need to catch an error only to rethrow it to the caller.\r\n\r\nI created a new file for the one test I added because that seemed to be the best option for following your style. It didn't really fit into any of the other files.","created_at":"2018-12-09T22:50:13Z","updated_at":"2018-12-09T22:50:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brentsimmons/Ballard/pulls/1/commits","review_comments_url":"https://api.github.com/repos/brentsimmons/Ballard/pulls/1/comments","review_comment_url":"https://api.github.com/repos/brentsimmons/Ballard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brentsimmons/Ballard/issues/1/comments","statuses_url":"https://api.github.com/repos/brentsimmons/Ballard/statuses/9b67ca86ee6ebe79614f8d93c8c0daca0df379c6","head":{"label":"ole:tokenizer-code-review","ref":"tokenizer-code-review","sha":"9b67ca86ee6ebe79614f8d93c8c0daca0df379c6","user":{"login":"ole","id":5010,"node_id":"MDQ6VXNlcjUwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5010?v=4","gravatar_id":"","url":"https://api.github.com/users/ole","html_url":"https://github.com/ole","followers_url":"https://api.github.com/users/ole/followers","following_url":"https://api.github.com/users/ole/following{/other_user}","gists_url":"https://api.github.com/users/ole/gists{/gist_id}","starred_url":"https://api.github.com/users/ole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ole/subscriptions","organizations_url":"https://api.github.com/users/ole/orgs","repos_url":"https://api.github.com/users/ole/repos","events_url":"https://api.github.com/users/ole/events{/privacy}","received_events_url":"https://api.github.com/users/ole/received_events","type":"User","site_admin":false},"repo":{"id":161088465,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEwODg0NjU=","name":"Ballard","full_name":"ole/Ballard","private":false,"owner":{"login":"ole","id":5010,"node_id":"MDQ6VXNlcjUwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5010?v=4","gravatar_id":"","url":"https://api.github.com/users/ole","html_url":"https://github.com/ole","followers_url":"https://api.github.com/users/ole/followers","following_url":"https://api.github.com/users/ole/following{/other_user}","gists_url":"https://api.github.com/users/ole/gists{/gist_id}","starred_url":"https://api.github.com/users/ole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ole/subscriptions","organizations_url":"https://api.github.com/users/ole/orgs","repos_url":"https://api.github.com/users/ole/repos","events_url":"https://api.github.com/users/ole/events{/privacy}","received_events_url":"https://api.github.com/users/ole/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ole/Ballard","description":"Language and runtime for Rainier, a scripting system for Mac.","fork":true,"url":"https://api.github.com/repos/ole/Ballard","forks_url":"https://api.github.com/repos/ole/Ballard/forks","keys_url":"https://api.github.com/repos/ole/Ballard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ole/Ballard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ole/Ballard/teams","hooks_url":"https://api.github.com/repos/ole/Ballard/hooks","issue_events_url":"https://api.github.com/repos/ole/Ballard/issues/events{/number}","events_url":"https://api.github.com/repos/ole/Ballard/events","assignees_url":"https://api.github.com/repos/ole/Ballard/assignees{/user}","branches_url":"https://api.github.com/repos/ole/Ballard/branches{/branch}","tags_url":"https://api.github.com/repos/ole/Ballard/tags","blobs_url":"https://api.github.com/repos/ole/Ballard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ole/Ballard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ole/Ballard/git/refs{/sha}","trees_url":"https://api.github.com/repos/ole/Ballard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ole/Ballard/statuses/{sha}","languages_url":"https://api.github.com/repos/ole/Ballard/languages","stargazers_url":"https://api.github.com/repos/ole/Ballard/stargazers","contributors_url":"https://api.github.com/repos/ole/Ballard/contributors","subscribers_url":"https://api.github.com/repos/ole/Ballard/subscribers","subscription_url":"https://api.github.com/repos/ole/Ballard/subscription","commits_url":"https://api.github.com/repos/ole/Ballard/commits{/sha}","git_commits_url":"https://api.github.com/repos/ole/Ballard/git/commits{/sha}","comments_url":"https://api.github.com/repos/ole/Ballard/comments{/number}","issue_comment_url":"https://api.github.com/repos/ole/Ballard/issues/comments{/number}","contents_url":"https://api.github.com/repos/ole/Ballard/contents/{+path}","compare_url":"https://api.github.com/repos/ole/Ballard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ole/Ballard/merges","archive_url":"https://api.github.com/repos/ole/Ballard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ole/Ballard/downloads","issues_url":"https://api.github.com/repos/ole/Ballard/issues{/number}","pulls_url":"https://api.github.com/repos/ole/Ballard/pulls{/number}","milestones_url":"https://api.github.com/repos/ole/Ballard/milestones{/number}","notifications_url":"https://api.github.com/repos/ole/Ballard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ole/Ballard/labels{/name}","releases_url":"https://api.github.com/repos/ole/Ballard/releases{/id}","deployments_url":"https://api.github.com/repos/ole/Ballard/deployments","created_at":"2018-12-09T22:44:25Z","updated_at":"2018-12-09T22:44:28Z","pushed_at":"2018-12-09T22:45:58Z","git_url":"git://github.com/ole/Ballard.git","ssh_url":"git@github.com:ole/Ballard.git","clone_url":"https://github.com/ole/Ballard.git","svn_url":"https://github.com/ole/Ballard","homepage":null,"size":87,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brentsimmons:master","ref":"master","sha":"fa5b21ab308a68340af4f378ec7dffb578f1284d","user":{"login":"brentsimmons","id":1297121,"node_id":"MDQ6VXNlcjEyOTcxMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1297121?v=4","gravatar_id":"","url":"https://api.github.com/users/brentsimmons","html_url":"https://github.com/brentsimmons","followers_url":"https://api.github.com/users/brentsimmons/followers","following_url":"https://api.github.com/users/brentsimmons/following{/other_user}","gists_url":"https://api.github.com/users/brentsimmons/gists{/gist_id}","starred_url":"https://api.github.com/users/brentsimmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentsimmons/subscriptions","organizations_url":"https://api.github.com/users/brentsimmons/orgs","repos_url":"https://api.github.com/users/brentsimmons/repos","events_url":"https://api.github.com/users/brentsimmons/events{/privacy}","received_events_url":"https://api.github.com/users/brentsimmons/received_events","type":"User","site_admin":false},"repo":{"id":157277689,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyNzc2ODk=","name":"Ballard","full_name":"brentsimmons/Ballard","private":false,"owner":{"login":"brentsimmons","id":1297121,"node_id":"MDQ6VXNlcjEyOTcxMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1297121?v=4","gravatar_id":"","url":"https://api.github.com/users/brentsimmons","html_url":"https://github.com/brentsimmons","followers_url":"https://api.github.com/users/brentsimmons/followers","following_url":"https://api.github.com/users/brentsimmons/following{/other_user}","gists_url":"https://api.github.com/users/brentsimmons/gists{/gist_id}","starred_url":"https://api.github.com/users/brentsimmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentsimmons/subscriptions","organizations_url":"https://api.github.com/users/brentsimmons/orgs","repos_url":"https://api.github.com/users/brentsimmons/repos","events_url":"https://api.github.com/users/brentsimmons/events{/privacy}","received_events_url":"https://api.github.com/users/brentsimmons/received_events","type":"User","site_admin":false},"html_url":"https://github.com/brentsimmons/Ballard","description":"Language and runtime for Rainier, a scripting system for Mac.","fork":false,"url":"https://api.github.com/repos/brentsimmons/Ballard","forks_url":"https://api.github.com/repos/brentsimmons/Ballard/forks","keys_url":"https://api.github.com/repos/brentsimmons/Ballard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brentsimmons/Ballard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brentsimmons/Ballard/teams","hooks_url":"https://api.github.com/repos/brentsimmons/Ballard/hooks","issue_events_url":"https://api.github.com/repos/brentsimmons/Ballard/issues/events{/number}","events_url":"https://api.github.com/repos/brentsimmons/Ballard/events","assignees_url":"https://api.github.com/repos/brentsimmons/Ballard/assignees{/user}","branches_url":"https://api.github.com/repos/brentsimmons/Ballard/branches{/branch}","tags_url":"https://api.github.com/repos/brentsimmons/Ballard/tags","blobs_url":"https://api.github.com/repos/brentsimmons/Ballard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brentsimmons/Ballard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brentsimmons/Ballard/git/refs{/sha}","trees_url":"https://api.github.com/repos/brentsimmons/Ballard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brentsimmons/Ballard/statuses/{sha}","languages_url":"https://api.github.com/repos/brentsimmons/Ballard/languages","stargazers_url":"https://api.github.com/repos/brentsimmons/Ballard/stargazers","contributors_url":"https://api.github.com/repos/brentsimmons/Ballard/contributors","subscribers_url":"https://api.github.com/repos/brentsimmons/Ballard/subscribers","subscription_url":"https://api.github.com/repos/brentsimmons/Ballard/subscription","commits_url":"https://api.github.com/repos/brentsimmons/Ballard/commits{/sha}","git_commits_url":"https://api.github.com/repos/brentsimmons/Ballard/git/commits{/sha}","comments_url":"https://api.github.com/repos/brentsimmons/Ballard/comments{/number}","issue_comment_url":"https://api.github.com/repos/brentsimmons/Ballard/issues/comments{/number}","contents_url":"https://api.github.com/repos/brentsimmons/Ballard/contents/{+path}","compare_url":"https://api.github.com/repos/brentsimmons/Ballard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brentsimmons/Ballard/merges","archive_url":"https://api.github.com/repos/brentsimmons/Ballard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brentsimmons/Ballard/downloads","issues_url":"https://api.github.com/repos/brentsimmons/Ballard/issues{/number}","pulls_url":"https://api.github.com/repos/brentsimmons/Ballard/pulls{/number}","milestones_url":"https://api.github.com/repos/brentsimmons/Ballard/milestones{/number}","notifications_url":"https://api.github.com/repos/brentsimmons/Ballard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brentsimmons/Ballard/labels{/name}","releases_url":"https://api.github.com/repos/brentsimmons/Ballard/releases{/id}","deployments_url":"https://api.github.com/repos/brentsimmons/Ballard/deployments","created_at":"2018-11-12T21:14:12Z","updated_at":"2018-11-26T06:54:26Z","pushed_at":"2018-11-21T06:33:12Z","git_url":"git://github.com/brentsimmons/Ballard.git","ssh_url":"git@github.com:brentsimmons/Ballard.git","clone_url":"https://github.com/brentsimmons/Ballard.git","svn_url":"https://github.com/brentsimmons/Ballard","homepage":null,"size":87,"stargazers_count":6,"watchers_count":6,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brentsimmons/Ballard/pulls/1"},"html":{"href":"https://github.com/brentsimmons/Ballard/pull/1"},"issue":{"href":"https://api.github.com/repos/brentsimmons/Ballard/issues/1"},"comments":{"href":"https://api.github.com/repos/brentsimmons/Ballard/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/brentsimmons/Ballard/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/brentsimmons/Ballard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brentsimmons/Ballard/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/brentsimmons/Ballard/statuses/9b67ca86ee6ebe79614f8d93c8c0daca0df379c6"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":56,"deletions":51,"changed_files":3}}
{"actor":{"display_login":"ole"}}