{"action":"created","issue":{"url":"https://api.github.com/repos/ccpgames/ccpwgl/issues/254","repository_url":"https://api.github.com/repos/ccpgames/ccpwgl","labels_url":"https://api.github.com/repos/ccpgames/ccpwgl/issues/254/labels{/name}","comments_url":"https://api.github.com/repos/ccpgames/ccpwgl/issues/254/comments","events_url":"https://api.github.com/repos/ccpgames/ccpwgl/issues/254/events","html_url":"https://github.com/ccpgames/ccpwgl/pull/254","id":300027784,"number":254,"title":"Updated files in eve folder, minor changes to others","user":{"login":"cppctamber","id":7591350,"avatar_url":"https://avatars3.githubusercontent.com/u/7591350?v=4","gravatar_id":"","url":"https://api.github.com/users/cppctamber","html_url":"https://github.com/cppctamber","followers_url":"https://api.github.com/users/cppctamber/followers","following_url":"https://api.github.com/users/cppctamber/following{/other_user}","gists_url":"https://api.github.com/users/cppctamber/gists{/gist_id}","starred_url":"https://api.github.com/users/cppctamber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppctamber/subscriptions","organizations_url":"https://api.github.com/users/cppctamber/orgs","repos_url":"https://api.github.com/users/cppctamber/repos","events_url":"https://api.github.com/users/cppctamber/events{/privacy}","received_events_url":"https://api.github.com/users/cppctamber/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-25T13:52:47Z","updated_at":"2018-02-25T13:54:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ccpgames/ccpwgl/pulls/254","html_url":"https://github.com/ccpgames/ccpwgl/pull/254","diff_url":"https://github.com/ccpgames/ccpwgl/pull/254.diff","patch_url":"https://github.com/ccpgames/ccpwgl/pull/254.patch"},"body":"src/eve\r\n---\r\n- Created new folders, and put relevant files in them\r\n- Created `EveObject`, `EveChild`, `EveItem`, `EveSet` and `EveSetItem` base classes\r\n- Converted `child`, `effect` and `object` folder files to classes/es6 and fixed linting\r\n- Converted `EveSpaceScene` to es6\r\n- Skipped converting `EveSOF` as my version is vastly different\r\n- Skipped `item` folder as `EveBoosterSetItem` failed testing\r\n- Moved `EveMissileWarhead` into the `EveMissile` folder\r\n- Fixed minor error in `EveMissile`\r\n- Added unique ids to objects. Defaults to using object ids, but UUIDs can be enabled with `store.Register({ uuid: true })`\r\n- Cleaned up perObjectData per line declarations in constructors (See below changes)\r\n\r\nsrc/core\r\n---\r\n- `Tw2VariableStore` has new properties and the instantiation has been renamed to `store`\r\n- Refactored all uses of `variableStore._variables[name]` to `store.GetVariable(name)`\r\n- Refactored variable registration methods to use a single method `RegisterVariable` which can handle all three variations and a new one `(name, value, Type)`\r\n- `Tw2VariableStore` now stores Types, and all Parameters/ Types are registered through the `Tw2VariableStore.RegisterType` method (name, Constructor). Custom Types should also use this method.\r\n- Types can be retrieved/ created by 'value' or 'type' as a string or 'Type' as a Constructor\r\n- Added 'is' static method to parameters to help identify values that are valid inputs for them\r\n- All global variables are now defined in one place in the main 'index.js' file\r\n- Variables can now only be defined once, if you try to register it again the original will be returned\r\n- Created `data` folder, and put all per object data methods in it and converted them to classes\r\n- `EveBasicPerObjectData` is now also known as `Tw2BasicPerObjectData` and extends from `Tw2PerObjectData` although I'm not sure why there isn't just one of them with VS, PS and FFE data?\r\n- `Tw2PerObjectData`, `Tw2RawData` and `EveBasicPerObjectData` can now take an object for declarations as an argument, rather than having to type out each declaration line by line\r\n- `Tw2VertexElement` can now take declarations as an argument (an array of arrays, or an array of objects) so that you don't have to type out each declaration line by line\r\n- Renamed `Tw2VertexElement` enums and put them into an object\r\n\r\nsrc/particle\r\n---\r\n- Added object ids to base classes\r\n\r\nsrc/curves\r\n---\r\n- Added object ids to base classes\r\n\r\nsrc/math\r\n---\r\n- Added ccpwgl_int compatible mat4 lookAt method `mat4.lookAtGL`\r\n- Added ccpwgl_int compatible mat4 perspective methods `mat4.perspectiveGL`\r\n- Added `vec3.project` and `vec3.unproject`\r\n- Moved `EveCurveSetLineItem` methods to vec3 library\r\n- Added some basic mat4 helper methods\r\n- Added `util` file which contains methods the library uses elsewhere multiple times (haven't removed the duplicated yet)\r\n- Added two ID generation methods (`util.generateUUID` by three.js and `util.generateObjectID`) for use in intersection tests, serialization and searches\r\n- Added `util.generateID` method which uses `util.generateObjectID` by default, but can be changed to the uuid with `store.Register({ uuid: true })`\r\n- probably some other stuff(tm)"},"comment":{"url":"https://api.github.com/repos/ccpgames/ccpwgl/issues/comments/368311207","html_url":"https://github.com/ccpgames/ccpwgl/pull/254#issuecomment-368311207","issue_url":"https://api.github.com/repos/ccpgames/ccpwgl/issues/254","id":368311207,"user":{"login":"cppctamber","id":7591350,"avatar_url":"https://avatars3.githubusercontent.com/u/7591350?v=4","gravatar_id":"","url":"https://api.github.com/users/cppctamber","html_url":"https://github.com/cppctamber","followers_url":"https://api.github.com/users/cppctamber/followers","following_url":"https://api.github.com/users/cppctamber/following{/other_user}","gists_url":"https://api.github.com/users/cppctamber/gists{/gist_id}","starred_url":"https://api.github.com/users/cppctamber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppctamber/subscriptions","organizations_url":"https://api.github.com/users/cppctamber/orgs","repos_url":"https://api.github.com/users/cppctamber/repos","events_url":"https://api.github.com/users/cppctamber/events{/privacy}","received_events_url":"https://api.github.com/users/cppctamber/received_events","type":"User","site_admin":false},"created_at":"2018-02-25T13:54:52Z","updated_at":"2018-02-25T13:54:52Z","author_association":"CONTRIBUTOR","body":"I've already converted the `/core/` folder but have to confirm source of errors in my refactored `eve/item/` folder before I can push it."}}
{"actor":{"display_login":"cppctamber"}}