{"action":"created","comment":{"url":"https://api.github.com/repos/juanvallejo/kubernetes/pulls/comments/171955527","pull_request_review_id":100904335,"id":171955527,"diff_hunk":"@@ -0,0 +1,99 @@\n+/*\n+Copyright 2018 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package printers\n+\n+import (\n+\t\"fmt\"\n+\n+\t\"github.com/spf13/cobra\"\n+)\n+\n+// TemplatePrintFlags provides default flags necessary for template printing.\n+// Given the following flag values, a printer can be requested that knows\n+// how to handle printing based on these values.\n+type TemplatePrintFlags struct {\n+\t// indicates if it is OK to ignore missing keys for rendering\n+\t// an output template.\n+\tAllowMissingKeys *bool\n+\tTemplateArgument *string\n+}\n+\n+func (f *TemplatePrintFlags) Validate() error {\n+\tif f.TemplateArgument == nil || len(*f.TemplateArgument) == 0 {\n+\t\treturn fmt.Errorf(\"missing --template value\")\n+\t}\n+\treturn nil\n+}\n+\n+func (f *TemplatePrintFlags) ToPrinter(outputFormat string) (ResourcePrinter, error) {","path":"pkg/printers/template_flags.go","position":42,"original_position":42,"commit_id":"27d0a49b26e6477ad7cd294cde48c6d043127a90","original_commit_id":"27d0a49b26e6477ad7cd294cde48c6d043127a90","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"expected this to be `ResourcePrinter, bool, error`","created_at":"2018-03-02T20:32:16Z","updated_at":"2018-03-02T20:32:16Z","html_url":"https://github.com/juanvallejo/kubernetes/pull/2#discussion_r171955527","pull_request_url":"https://api.github.com/repos/juanvallejo/kubernetes/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/juanvallejo/kubernetes/pulls/comments/171955527"},"html":{"href":"https://github.com/juanvallejo/kubernetes/pull/2#discussion_r171955527"},"pull_request":{"href":"https://api.github.com/repos/juanvallejo/kubernetes/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/juanvallejo/kubernetes/pulls/2","id":172576360,"html_url":"https://github.com/juanvallejo/kubernetes/pull/2","diff_url":"https://github.com/juanvallejo/kubernetes/pull/2.diff","patch_url":"https://github.com/juanvallejo/kubernetes/pull/2.patch","issue_url":"https://api.github.com/repos/juanvallejo/kubernetes/issues/2","number":2,"state":"open","locked":false,"title":"wire template printer flags","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"body":"Followup to https://github.com/juanvallejo/kubernetes/pull/1\r\n\r\ncc @deads2k @soltysh","created_at":"2018-03-02T18:49:36Z","updated_at":"2018-03-02T20:32:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bd89d72116d3f45206440889ff9d39513e78c09","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juanvallejo/kubernetes/pulls/2/commits","review_comments_url":"https://api.github.com/repos/juanvallejo/kubernetes/pulls/2/comments","review_comment_url":"https://api.github.com/repos/juanvallejo/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juanvallejo/kubernetes/issues/2/comments","statuses_url":"https://api.github.com/repos/juanvallejo/kubernetes/statuses/27d0a49b26e6477ad7cd294cde48c6d043127a90","head":{"label":"juanvallejo:jvallejo/cli-printers-1-round-2","ref":"jvallejo/cli-printers-1-round-2","sha":"27d0a49b26e6477ad7cd294cde48c6d043127a90","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"repo":{"id":59512855,"name":"kubernetes","full_name":"juanvallejo/kubernetes","owner":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juanvallejo/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/juanvallejo/kubernetes","forks_url":"https://api.github.com/repos/juanvallejo/kubernetes/forks","keys_url":"https://api.github.com/repos/juanvallejo/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juanvallejo/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juanvallejo/kubernetes/teams","hooks_url":"https://api.github.com/repos/juanvallejo/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/juanvallejo/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/juanvallejo/kubernetes/events","assignees_url":"https://api.github.com/repos/juanvallejo/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/juanvallejo/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/juanvallejo/kubernetes/tags","blobs_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juanvallejo/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/juanvallejo/kubernetes/languages","stargazers_url":"https://api.github.com/repos/juanvallejo/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/juanvallejo/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/juanvallejo/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/juanvallejo/kubernetes/subscription","commits_url":"https://api.github.com/repos/juanvallejo/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/juanvallejo/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/juanvallejo/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/juanvallejo/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/juanvallejo/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juanvallejo/kubernetes/merges","archive_url":"https://api.github.com/repos/juanvallejo/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juanvallejo/kubernetes/downloads","issues_url":"https://api.github.com/repos/juanvallejo/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/juanvallejo/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/juanvallejo/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/juanvallejo/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juanvallejo/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/juanvallejo/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/juanvallejo/kubernetes/deployments","created_at":"2016-05-23T19:36:17Z","updated_at":"2016-05-23T19:36:32Z","pushed_at":"2018-03-02T20:18:14Z","git_url":"git://github.com/juanvallejo/kubernetes.git","ssh_url":"git@github.com:juanvallejo/kubernetes.git","clone_url":"https://github.com/juanvallejo/kubernetes.git","svn_url":"https://github.com/juanvallejo/kubernetes","homepage":"http://kubernetes.io","size":530080,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"juanvallejo:master","ref":"master","sha":"07240b7166d83bed49d783e0ecdfa7ee7e62cfca","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"repo":{"id":59512855,"name":"kubernetes","full_name":"juanvallejo/kubernetes","owner":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juanvallejo/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/juanvallejo/kubernetes","forks_url":"https://api.github.com/repos/juanvallejo/kubernetes/forks","keys_url":"https://api.github.com/repos/juanvallejo/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juanvallejo/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juanvallejo/kubernetes/teams","hooks_url":"https://api.github.com/repos/juanvallejo/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/juanvallejo/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/juanvallejo/kubernetes/events","assignees_url":"https://api.github.com/repos/juanvallejo/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/juanvallejo/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/juanvallejo/kubernetes/tags","blobs_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juanvallejo/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/juanvallejo/kubernetes/languages","stargazers_url":"https://api.github.com/repos/juanvallejo/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/juanvallejo/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/juanvallejo/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/juanvallejo/kubernetes/subscription","commits_url":"https://api.github.com/repos/juanvallejo/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/juanvallejo/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/juanvallejo/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/juanvallejo/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/juanvallejo/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juanvallejo/kubernetes/merges","archive_url":"https://api.github.com/repos/juanvallejo/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juanvallejo/kubernetes/downloads","issues_url":"https://api.github.com/repos/juanvallejo/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/juanvallejo/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/juanvallejo/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/juanvallejo/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juanvallejo/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/juanvallejo/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/juanvallejo/kubernetes/deployments","created_at":"2016-05-23T19:36:17Z","updated_at":"2016-05-23T19:36:32Z","pushed_at":"2018-03-02T20:18:14Z","git_url":"git://github.com/juanvallejo/kubernetes.git","ssh_url":"git@github.com:juanvallejo/kubernetes.git","clone_url":"https://github.com/juanvallejo/kubernetes.git","svn_url":"https://github.com/juanvallejo/kubernetes","homepage":"http://kubernetes.io","size":530080,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juanvallejo/kubernetes/pulls/2"},"html":{"href":"https://github.com/juanvallejo/kubernetes/pull/2"},"issue":{"href":"https://api.github.com/repos/juanvallejo/kubernetes/issues/2"},"comments":{"href":"https://api.github.com/repos/juanvallejo/kubernetes/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/juanvallejo/kubernetes/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/juanvallejo/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juanvallejo/kubernetes/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/juanvallejo/kubernetes/statuses/27d0a49b26e6477ad7cd294cde48c6d043127a90"}},"author_association":"OWNER"}}
{"actor":{"display_login":"deads2k"}}