{"action":"created","comment":{"url":"https://api.github.com/repos/dtcooper/python-fitparse/pulls/comments/184045112","pull_request_review_id":115159281,"id":184045112,"diff_hunk":"@@ -32,36 +39,38 @@ def _scrub_method_name(self, method_name):\n             method_name: Method name to scrub.\n \n         Returns:\n-            Scrubbed method name.\n+            Scrubbed method (bounded).\n         \"\"\"\n-        if method_name not in self._scrubbed_method_names:\n-            self._scrubbed_method_names[method_name] = (\n-                scrub_method_name(method_name))\n+        method = self._method_cache.get(method_name, False)\n+        if method is not False:\n+            return method\n+\n+        scrubbed_method_name = scrub_method_name(method_name)\n+        try:","path":"fitparse/processors.py","position":64,"original_position":64,"commit_id":"51cd2452e7d799ca0a2eb6637a879ccdd70b8598","original_commit_id":"51cd2452e7d799ca0a2eb6637a879ccdd70b8598","user":{"login":"xmedeko","id":1101801,"avatar_url":"https://avatars0.githubusercontent.com/u/1101801?v=4","gravatar_id":"","url":"https://api.github.com/users/xmedeko","html_url":"https://github.com/xmedeko","followers_url":"https://api.github.com/users/xmedeko/followers","following_url":"https://api.github.com/users/xmedeko/following{/other_user}","gists_url":"https://api.github.com/users/xmedeko/gists{/gist_id}","starred_url":"https://api.github.com/users/xmedeko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmedeko/subscriptions","organizations_url":"https://api.github.com/users/xmedeko/orgs","repos_url":"https://api.github.com/users/xmedeko/repos","events_url":"https://api.github.com/users/xmedeko/events{/privacy}","received_events_url":"https://api.github.com/users/xmedeko/received_events","type":"User","site_admin":false},"body":"`getattr` is slow for large FITs (e.g. 10 hours records). It's the purpose of this commit to avoid it and speed the processors.","created_at":"2018-04-25T12:48:31Z","updated_at":"2018-04-25T12:48:31Z","html_url":"https://github.com/dtcooper/python-fitparse/pull/57#discussion_r184045112","pull_request_url":"https://api.github.com/repos/dtcooper/python-fitparse/pulls/57","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dtcooper/python-fitparse/pulls/comments/184045112"},"html":{"href":"https://github.com/dtcooper/python-fitparse/pull/57#discussion_r184045112"},"pull_request":{"href":"https://api.github.com/repos/dtcooper/python-fitparse/pulls/57"}},"in_reply_to_id":184037423},"pull_request":{"url":"https://api.github.com/repos/dtcooper/python-fitparse/pulls/57","id":173441180,"html_url":"https://github.com/dtcooper/python-fitparse/pull/57","diff_url":"https://github.com/dtcooper/python-fitparse/pull/57.diff","patch_url":"https://github.com/dtcooper/python-fitparse/pull/57.patch","issue_url":"https://api.github.com/repos/dtcooper/python-fitparse/issues/57","number":57,"state":"open","locked":false,"title":"Remove RecordBase to speedup processing","user":{"login":"xmedeko","id":1101801,"avatar_url":"https://avatars0.githubusercontent.com/u/1101801?v=4","gravatar_id":"","url":"https://api.github.com/users/xmedeko","html_url":"https://github.com/xmedeko","followers_url":"https://api.github.com/users/xmedeko/followers","following_url":"https://api.github.com/users/xmedeko/following{/other_user}","gists_url":"https://api.github.com/users/xmedeko/gists{/gist_id}","starred_url":"https://api.github.com/users/xmedeko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmedeko/subscriptions","organizations_url":"https://api.github.com/users/xmedeko/orgs","repos_url":"https://api.github.com/users/xmedeko/repos","events_url":"https://api.github.com/users/xmedeko/events{/privacy}","received_events_url":"https://api.github.com/users/xmedeko/received_events","type":"User","site_admin":false},"body":"Fix #55 \r\nThe second commit limits the data processor `getattr`.","created_at":"2018-03-07T12:44:46Z","updated_at":"2018-04-25T12:48:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2c85dd60e70da172f6eae3a8dad3576e9ca855a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dtcooper/python-fitparse/pulls/57/commits","review_comments_url":"https://api.github.com/repos/dtcooper/python-fitparse/pulls/57/comments","review_comment_url":"https://api.github.com/repos/dtcooper/python-fitparse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dtcooper/python-fitparse/issues/57/comments","statuses_url":"https://api.github.com/repos/dtcooper/python-fitparse/statuses/51cd2452e7d799ca0a2eb6637a879ccdd70b8598","head":{"label":"xmedeko:recordbase","ref":"recordbase","sha":"51cd2452e7d799ca0a2eb6637a879ccdd70b8598","user":{"login":"xmedeko","id":1101801,"avatar_url":"https://avatars0.githubusercontent.com/u/1101801?v=4","gravatar_id":"","url":"https://api.github.com/users/xmedeko","html_url":"https://github.com/xmedeko","followers_url":"https://api.github.com/users/xmedeko/followers","following_url":"https://api.github.com/users/xmedeko/following{/other_user}","gists_url":"https://api.github.com/users/xmedeko/gists{/gist_id}","starred_url":"https://api.github.com/users/xmedeko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmedeko/subscriptions","organizations_url":"https://api.github.com/users/xmedeko/orgs","repos_url":"https://api.github.com/users/xmedeko/repos","events_url":"https://api.github.com/users/xmedeko/events{/privacy}","received_events_url":"https://api.github.com/users/xmedeko/received_events","type":"User","site_admin":false},"repo":{"id":122191338,"name":"python-fitparse","full_name":"xmedeko/python-fitparse","owner":{"login":"xmedeko","id":1101801,"avatar_url":"https://avatars0.githubusercontent.com/u/1101801?v=4","gravatar_id":"","url":"https://api.github.com/users/xmedeko","html_url":"https://github.com/xmedeko","followers_url":"https://api.github.com/users/xmedeko/followers","following_url":"https://api.github.com/users/xmedeko/following{/other_user}","gists_url":"https://api.github.com/users/xmedeko/gists{/gist_id}","starred_url":"https://api.github.com/users/xmedeko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmedeko/subscriptions","organizations_url":"https://api.github.com/users/xmedeko/orgs","repos_url":"https://api.github.com/users/xmedeko/repos","events_url":"https://api.github.com/users/xmedeko/events{/privacy}","received_events_url":"https://api.github.com/users/xmedeko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xmedeko/python-fitparse","description":"Python library to parse ANT/Garmin .FIT files","fork":true,"url":"https://api.github.com/repos/xmedeko/python-fitparse","forks_url":"https://api.github.com/repos/xmedeko/python-fitparse/forks","keys_url":"https://api.github.com/repos/xmedeko/python-fitparse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xmedeko/python-fitparse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xmedeko/python-fitparse/teams","hooks_url":"https://api.github.com/repos/xmedeko/python-fitparse/hooks","issue_events_url":"https://api.github.com/repos/xmedeko/python-fitparse/issues/events{/number}","events_url":"https://api.github.com/repos/xmedeko/python-fitparse/events","assignees_url":"https://api.github.com/repos/xmedeko/python-fitparse/assignees{/user}","branches_url":"https://api.github.com/repos/xmedeko/python-fitparse/branches{/branch}","tags_url":"https://api.github.com/repos/xmedeko/python-fitparse/tags","blobs_url":"https://api.github.com/repos/xmedeko/python-fitparse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xmedeko/python-fitparse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xmedeko/python-fitparse/git/refs{/sha}","trees_url":"https://api.github.com/repos/xmedeko/python-fitparse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xmedeko/python-fitparse/statuses/{sha}","languages_url":"https://api.github.com/repos/xmedeko/python-fitparse/languages","stargazers_url":"https://api.github.com/repos/xmedeko/python-fitparse/stargazers","contributors_url":"https://api.github.com/repos/xmedeko/python-fitparse/contributors","subscribers_url":"https://api.github.com/repos/xmedeko/python-fitparse/subscribers","subscription_url":"https://api.github.com/repos/xmedeko/python-fitparse/subscription","commits_url":"https://api.github.com/repos/xmedeko/python-fitparse/commits{/sha}","git_commits_url":"https://api.github.com/repos/xmedeko/python-fitparse/git/commits{/sha}","comments_url":"https://api.github.com/repos/xmedeko/python-fitparse/comments{/number}","issue_comment_url":"https://api.github.com/repos/xmedeko/python-fitparse/issues/comments{/number}","contents_url":"https://api.github.com/repos/xmedeko/python-fitparse/contents/{+path}","compare_url":"https://api.github.com/repos/xmedeko/python-fitparse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xmedeko/python-fitparse/merges","archive_url":"https://api.github.com/repos/xmedeko/python-fitparse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xmedeko/python-fitparse/downloads","issues_url":"https://api.github.com/repos/xmedeko/python-fitparse/issues{/number}","pulls_url":"https://api.github.com/repos/xmedeko/python-fitparse/pulls{/number}","milestones_url":"https://api.github.com/repos/xmedeko/python-fitparse/milestones{/number}","notifications_url":"https://api.github.com/repos/xmedeko/python-fitparse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xmedeko/python-fitparse/labels{/name}","releases_url":"https://api.github.com/repos/xmedeko/python-fitparse/releases{/id}","deployments_url":"https://api.github.com/repos/xmedeko/python-fitparse/deployments","created_at":"2018-02-20T11:47:28Z","updated_at":"2018-04-12T20:19:43Z","pushed_at":"2018-04-25T07:16:10Z","git_url":"git://github.com/xmedeko/python-fitparse.git","ssh_url":"git@github.com:xmedeko/python-fitparse.git","clone_url":"https://github.com/xmedeko/python-fitparse.git","svn_url":"https://github.com/xmedeko/python-fitparse","homepage":"","size":3487,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dtcooper:master","ref":"master","sha":"bef76231a1c8dddfafc23070b43684e7d0c6e916","user":{"login":"dtcooper","id":873944,"avatar_url":"https://avatars0.githubusercontent.com/u/873944?v=4","gravatar_id":"","url":"https://api.github.com/users/dtcooper","html_url":"https://github.com/dtcooper","followers_url":"https://api.github.com/users/dtcooper/followers","following_url":"https://api.github.com/users/dtcooper/following{/other_user}","gists_url":"https://api.github.com/users/dtcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/dtcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtcooper/subscriptions","organizations_url":"https://api.github.com/users/dtcooper/orgs","repos_url":"https://api.github.com/users/dtcooper/repos","events_url":"https://api.github.com/users/dtcooper/events{/privacy}","received_events_url":"https://api.github.com/users/dtcooper/received_events","type":"User","site_admin":false},"repo":{"id":2177204,"name":"python-fitparse","full_name":"dtcooper/python-fitparse","owner":{"login":"dtcooper","id":873944,"avatar_url":"https://avatars0.githubusercontent.com/u/873944?v=4","gravatar_id":"","url":"https://api.github.com/users/dtcooper","html_url":"https://github.com/dtcooper","followers_url":"https://api.github.com/users/dtcooper/followers","following_url":"https://api.github.com/users/dtcooper/following{/other_user}","gists_url":"https://api.github.com/users/dtcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/dtcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtcooper/subscriptions","organizations_url":"https://api.github.com/users/dtcooper/orgs","repos_url":"https://api.github.com/users/dtcooper/repos","events_url":"https://api.github.com/users/dtcooper/events{/privacy}","received_events_url":"https://api.github.com/users/dtcooper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtcooper/python-fitparse","description":"Python library to parse ANT/Garmin .FIT files","fork":false,"url":"https://api.github.com/repos/dtcooper/python-fitparse","forks_url":"https://api.github.com/repos/dtcooper/python-fitparse/forks","keys_url":"https://api.github.com/repos/dtcooper/python-fitparse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtcooper/python-fitparse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtcooper/python-fitparse/teams","hooks_url":"https://api.github.com/repos/dtcooper/python-fitparse/hooks","issue_events_url":"https://api.github.com/repos/dtcooper/python-fitparse/issues/events{/number}","events_url":"https://api.github.com/repos/dtcooper/python-fitparse/events","assignees_url":"https://api.github.com/repos/dtcooper/python-fitparse/assignees{/user}","branches_url":"https://api.github.com/repos/dtcooper/python-fitparse/branches{/branch}","tags_url":"https://api.github.com/repos/dtcooper/python-fitparse/tags","blobs_url":"https://api.github.com/repos/dtcooper/python-fitparse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtcooper/python-fitparse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtcooper/python-fitparse/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtcooper/python-fitparse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtcooper/python-fitparse/statuses/{sha}","languages_url":"https://api.github.com/repos/dtcooper/python-fitparse/languages","stargazers_url":"https://api.github.com/repos/dtcooper/python-fitparse/stargazers","contributors_url":"https://api.github.com/repos/dtcooper/python-fitparse/contributors","subscribers_url":"https://api.github.com/repos/dtcooper/python-fitparse/subscribers","subscription_url":"https://api.github.com/repos/dtcooper/python-fitparse/subscription","commits_url":"https://api.github.com/repos/dtcooper/python-fitparse/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtcooper/python-fitparse/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtcooper/python-fitparse/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtcooper/python-fitparse/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtcooper/python-fitparse/contents/{+path}","compare_url":"https://api.github.com/repos/dtcooper/python-fitparse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtcooper/python-fitparse/merges","archive_url":"https://api.github.com/repos/dtcooper/python-fitparse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtcooper/python-fitparse/downloads","issues_url":"https://api.github.com/repos/dtcooper/python-fitparse/issues{/number}","pulls_url":"https://api.github.com/repos/dtcooper/python-fitparse/pulls{/number}","milestones_url":"https://api.github.com/repos/dtcooper/python-fitparse/milestones{/number}","notifications_url":"https://api.github.com/repos/dtcooper/python-fitparse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtcooper/python-fitparse/labels{/name}","releases_url":"https://api.github.com/repos/dtcooper/python-fitparse/releases{/id}","deployments_url":"https://api.github.com/repos/dtcooper/python-fitparse/deployments","created_at":"2011-08-09T02:57:46Z","updated_at":"2018-04-25T12:45:13Z","pushed_at":"2018-04-25T12:45:11Z","git_url":"git://github.com/dtcooper/python-fitparse.git","ssh_url":"git@github.com:dtcooper/python-fitparse.git","clone_url":"https://github.com/dtcooper/python-fitparse.git","svn_url":"https://github.com/dtcooper/python-fitparse","homepage":"http://pythonhosted.org/fitparse/","size":3459,"stargazers_count":204,"watchers_count":204,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":98,"open_issues":13,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dtcooper/python-fitparse/pulls/57"},"html":{"href":"https://github.com/dtcooper/python-fitparse/pull/57"},"issue":{"href":"https://api.github.com/repos/dtcooper/python-fitparse/issues/57"},"comments":{"href":"https://api.github.com/repos/dtcooper/python-fitparse/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/dtcooper/python-fitparse/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/dtcooper/python-fitparse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dtcooper/python-fitparse/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/dtcooper/python-fitparse/statuses/51cd2452e7d799ca0a2eb6637a879ccdd70b8598"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"xmedeko"}}