{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments/209645941","pull_request_review_id":145698634,"id":209645941,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTY0NTk0MQ==","diff_hunk":"@@ -12,30 +12,41 @@ import org.eclipse.xtext.common.types.descriptions.EObjectDescriptionBasedStubGe\n import org.eclipse.xtext.naming.QualifiedName\n import org.eclipse.xtext.resource.IResourceDescriptions\n import org.eclipse.emf.ecore.resource.Resource\n+import org.eclipse.xtext.naming.IQualifiedNameConverter\n \n @FinalFieldsConstructor class IndexAwareNameEnvironment implements INameEnvironment {\n \n     val Resource resource\n \tval ClassLoader classLoader\n \tval IResourceDescriptions resourceDescriptions\n \tval EObjectDescriptionBasedStubGenerator stubGenerator\n+\tval ClassFileCache classFileCache\n+\tval IQualifiedNameConverter qualifiedNameConverter\n \n-\tMap<QualifiedName, NameEnvironmentAnswer> cache = newHashMap()\n+\tMap<String, NameEnvironmentAnswer> cache = newHashMap()\n     \n \toverride cleanup() {\n \t\tcache.clear\n \t}\n \n \toverride findType(char[][] compoundTypeName) {\n \t\tval className = QualifiedName.create(compoundTypeName.map[String.valueOf(it)])\n-\t\treturn findType(className)\n+\t\treturn findType(className.toString)","path":"org.eclipse.xtext.java/src/org/eclipse/xtext/java/resource/IndexAwareNameEnvironment.xtend","position":25,"original_position":25,"commit_id":"01f5ef691fba848498d8681840f0635706b4d4e3","original_commit_id":"01f5ef691fba848498d8681840f0635706b4d4e3","user":{"login":"cdietrich","id":238736,"node_id":"MDQ6VXNlcjIzODczNg==","avatar_url":"https://avatars2.githubusercontent.com/u/238736?v=4","gravatar_id":"","url":"https://api.github.com/users/cdietrich","html_url":"https://github.com/cdietrich","followers_url":"https://api.github.com/users/cdietrich/followers","following_url":"https://api.github.com/users/cdietrich/following{/other_user}","gists_url":"https://api.github.com/users/cdietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/cdietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdietrich/subscriptions","organizations_url":"https://api.github.com/users/cdietrich/orgs","repos_url":"https://api.github.com/users/cdietrich/repos","events_url":"https://api.github.com/users/cdietrich/events{/privacy}","received_events_url":"https://api.github.com/users/cdietrich/received_events","type":"User","site_admin":false},"body":"list.join(\".\") ?","created_at":"2018-08-13T15:08:21Z","updated_at":"2018-08-13T15:08:21Z","html_url":"https://github.com/eclipse/xtext-extras/pull/286#discussion_r209645941","pull_request_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/286","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments/209645941"},"html":{"href":"https://github.com/eclipse/xtext-extras/pull/286#discussion_r209645941"},"pull_request":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/286"}},"in_reply_to_id":209643819},"pull_request":{"url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/286","id":207962933,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3OTYyOTMz","html_url":"https://github.com/eclipse/xtext-extras/pull/286","diff_url":"https://github.com/eclipse/xtext-extras/pull/286.diff","patch_url":"https://github.com/eclipse/xtext-extras/pull/286.patch","issue_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/286","number":286,"state":"open","locked":false,"title":"Cd issue261 c","user":{"login":"cdietrich","id":238736,"node_id":"MDQ6VXNlcjIzODczNg==","avatar_url":"https://avatars2.githubusercontent.com/u/238736?v=4","gravatar_id":"","url":"https://api.github.com/users/cdietrich","html_url":"https://github.com/cdietrich","followers_url":"https://api.github.com/users/cdietrich/followers","following_url":"https://api.github.com/users/cdietrich/following{/other_user}","gists_url":"https://api.github.com/users/cdietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/cdietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdietrich/subscriptions","organizations_url":"https://api.github.com/users/cdietrich/orgs","repos_url":"https://api.github.com/users/cdietrich/repos","events_url":"https://api.github.com/users/cdietrich/events{/privacy}","received_events_url":"https://api.github.com/users/cdietrich/received_events","type":"User","site_admin":false},"body":"@szarnekow here a variant with concurrent hashmap, null object and strings instead of fqn.\r\nam not sure if i like it","created_at":"2018-08-13T12:34:34Z","updated_at":"2018-08-13T15:08:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb9eaadc753ed301e93fc4a84ec4200b76712ee2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/286/commits","review_comments_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/286/comments","review_comment_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/286/comments","statuses_url":"https://api.github.com/repos/eclipse/xtext-extras/statuses/01f5ef691fba848498d8681840f0635706b4d4e3","head":{"label":"eclipse:cd_issue261_c","ref":"cd_issue261_c","sha":"01f5ef691fba848498d8681840f0635706b4d4e3","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":60115647,"node_id":"MDEwOlJlcG9zaXRvcnk2MDExNTY0Nw==","name":"xtext-extras","full_name":"eclipse/xtext-extras","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/xtext-extras","description":"xtext-extras","fork":false,"url":"https://api.github.com/repos/eclipse/xtext-extras","forks_url":"https://api.github.com/repos/eclipse/xtext-extras/forks","keys_url":"https://api.github.com/repos/eclipse/xtext-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/xtext-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/xtext-extras/teams","hooks_url":"https://api.github.com/repos/eclipse/xtext-extras/hooks","issue_events_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/xtext-extras/events","assignees_url":"https://api.github.com/repos/eclipse/xtext-extras/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/xtext-extras/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/xtext-extras/tags","blobs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/xtext-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/xtext-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/xtext-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/xtext-extras/languages","stargazers_url":"https://api.github.com/repos/eclipse/xtext-extras/stargazers","contributors_url":"https://api.github.com/repos/eclipse/xtext-extras/contributors","subscribers_url":"https://api.github.com/repos/eclipse/xtext-extras/subscribers","subscription_url":"https://api.github.com/repos/eclipse/xtext-extras/subscription","commits_url":"https://api.github.com/repos/eclipse/xtext-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/xtext-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/xtext-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/xtext-extras/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/xtext-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/xtext-extras/merges","archive_url":"https://api.github.com/repos/eclipse/xtext-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/xtext-extras/downloads","issues_url":"https://api.github.com/repos/eclipse/xtext-extras/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/xtext-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/xtext-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/xtext-extras/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/xtext-extras/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/xtext-extras/deployments","created_at":"2016-05-31T19:00:27Z","updated_at":"2018-07-26T13:14:49Z","pushed_at":"2018-08-13T12:34:34Z","git_url":"git://github.com/eclipse/xtext-extras.git","ssh_url":"git@github.com:eclipse/xtext-extras.git","clone_url":"https://github.com/eclipse/xtext-extras.git","svn_url":"https://github.com/eclipse/xtext-extras","homepage":null,"size":22761,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":20,"open_issues":32,"watchers":8,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"2fd2d323629d2397bbf650c2fbf3e804c6e14f11","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":60115647,"node_id":"MDEwOlJlcG9zaXRvcnk2MDExNTY0Nw==","name":"xtext-extras","full_name":"eclipse/xtext-extras","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/xtext-extras","description":"xtext-extras","fork":false,"url":"https://api.github.com/repos/eclipse/xtext-extras","forks_url":"https://api.github.com/repos/eclipse/xtext-extras/forks","keys_url":"https://api.github.com/repos/eclipse/xtext-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/xtext-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/xtext-extras/teams","hooks_url":"https://api.github.com/repos/eclipse/xtext-extras/hooks","issue_events_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/xtext-extras/events","assignees_url":"https://api.github.com/repos/eclipse/xtext-extras/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/xtext-extras/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/xtext-extras/tags","blobs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/xtext-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/xtext-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/xtext-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/xtext-extras/languages","stargazers_url":"https://api.github.com/repos/eclipse/xtext-extras/stargazers","contributors_url":"https://api.github.com/repos/eclipse/xtext-extras/contributors","subscribers_url":"https://api.github.com/repos/eclipse/xtext-extras/subscribers","subscription_url":"https://api.github.com/repos/eclipse/xtext-extras/subscription","commits_url":"https://api.github.com/repos/eclipse/xtext-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/xtext-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/xtext-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/xtext-extras/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/xtext-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/xtext-extras/merges","archive_url":"https://api.github.com/repos/eclipse/xtext-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/xtext-extras/downloads","issues_url":"https://api.github.com/repos/eclipse/xtext-extras/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/xtext-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/xtext-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/xtext-extras/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/xtext-extras/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/xtext-extras/deployments","created_at":"2016-05-31T19:00:27Z","updated_at":"2018-07-26T13:14:49Z","pushed_at":"2018-08-13T12:34:34Z","git_url":"git://github.com/eclipse/xtext-extras.git","ssh_url":"git@github.com:eclipse/xtext-extras.git","clone_url":"https://github.com/eclipse/xtext-extras.git","svn_url":"https://github.com/eclipse/xtext-extras","homepage":null,"size":22761,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":20,"open_issues":32,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/286"},"html":{"href":"https://github.com/eclipse/xtext-extras/pull/286"},"issue":{"href":"https://api.github.com/repos/eclipse/xtext-extras/issues/286"},"comments":{"href":"https://api.github.com/repos/eclipse/xtext-extras/issues/286/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/286/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/286/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/xtext-extras/statuses/01f5ef691fba848498d8681840f0635706b4d4e3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cdietrich"}}