{"action":"closed","number":670,"pull_request":{"url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/pulls/670","id":214144925,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTQ0OTI1","html_url":"https://github.com/JuliaNLSolvers/Optim.jl/pull/670","diff_url":"https://github.com/JuliaNLSolvers/Optim.jl/pull/670.diff","patch_url":"https://github.com/JuliaNLSolvers/Optim.jl/pull/670.patch","issue_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues/670","number":670,"state":"closed","locked":false,"title":"Use NaNMath to prevent NaNs in CG","user":{"login":"anriseth","id":5601805,"node_id":"MDQ6VXNlcjU2MDE4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5601805?v=4","gravatar_id":"","url":"https://api.github.com/users/anriseth","html_url":"https://github.com/anriseth","followers_url":"https://api.github.com/users/anriseth/followers","following_url":"https://api.github.com/users/anriseth/following{/other_user}","gists_url":"https://api.github.com/users/anriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/anriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anriseth/subscriptions","organizations_url":"https://api.github.com/users/anriseth/orgs","repos_url":"https://api.github.com/users/anriseth/repos","events_url":"https://api.github.com/users/anriseth/events{/privacy}","received_events_url":"https://api.github.com/users/anriseth/received_events","type":"User","site_admin":false},"body":"Fix #669 \r\n\r\nThere's a question as to whether we should restart CG when we hit a NaN-situation instead of the current approach that takes the truncation value `eta_k` instead. I can't find any discussion of this in the CG papers as they conveniently consider nice functions or Wolfe-condition steps.","created_at":"2018-09-09T13:17:30Z","updated_at":"2018-09-21T13:02:01Z","closed_at":"2018-09-21T13:02:01Z","merged_at":null,"merge_commit_sha":"ea9fbc27c34236264498f7ac803de5ad77984d28","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/pulls/670/commits","review_comments_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/pulls/670/comments","review_comment_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues/670/comments","statuses_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/statuses/14b678359fcc5c584d7181d2fefc934eadba0423","head":{"label":"anriseth:cgnan","ref":"cgnan","sha":"14b678359fcc5c584d7181d2fefc934eadba0423","user":{"login":"anriseth","id":5601805,"node_id":"MDQ6VXNlcjU2MDE4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5601805?v=4","gravatar_id":"","url":"https://api.github.com/users/anriseth","html_url":"https://github.com/anriseth","followers_url":"https://api.github.com/users/anriseth/followers","following_url":"https://api.github.com/users/anriseth/following{/other_user}","gists_url":"https://api.github.com/users/anriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/anriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anriseth/subscriptions","organizations_url":"https://api.github.com/users/anriseth/orgs","repos_url":"https://api.github.com/users/anriseth/repos","events_url":"https://api.github.com/users/anriseth/events{/privacy}","received_events_url":"https://api.github.com/users/anriseth/received_events","type":"User","site_admin":false},"repo":{"id":58089597,"node_id":"MDEwOlJlcG9zaXRvcnk1ODA4OTU5Nw==","name":"Optim.jl","full_name":"anriseth/Optim.jl","private":false,"owner":{"login":"anriseth","id":5601805,"node_id":"MDQ6VXNlcjU2MDE4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5601805?v=4","gravatar_id":"","url":"https://api.github.com/users/anriseth","html_url":"https://github.com/anriseth","followers_url":"https://api.github.com/users/anriseth/followers","following_url":"https://api.github.com/users/anriseth/following{/other_user}","gists_url":"https://api.github.com/users/anriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/anriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anriseth/subscriptions","organizations_url":"https://api.github.com/users/anriseth/orgs","repos_url":"https://api.github.com/users/anriseth/repos","events_url":"https://api.github.com/users/anriseth/events{/privacy}","received_events_url":"https://api.github.com/users/anriseth/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anriseth/Optim.jl","description":"Optimization functions for Julia","fork":true,"url":"https://api.github.com/repos/anriseth/Optim.jl","forks_url":"https://api.github.com/repos/anriseth/Optim.jl/forks","keys_url":"https://api.github.com/repos/anriseth/Optim.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anriseth/Optim.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anriseth/Optim.jl/teams","hooks_url":"https://api.github.com/repos/anriseth/Optim.jl/hooks","issue_events_url":"https://api.github.com/repos/anriseth/Optim.jl/issues/events{/number}","events_url":"https://api.github.com/repos/anriseth/Optim.jl/events","assignees_url":"https://api.github.com/repos/anriseth/Optim.jl/assignees{/user}","branches_url":"https://api.github.com/repos/anriseth/Optim.jl/branches{/branch}","tags_url":"https://api.github.com/repos/anriseth/Optim.jl/tags","blobs_url":"https://api.github.com/repos/anriseth/Optim.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anriseth/Optim.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anriseth/Optim.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/anriseth/Optim.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anriseth/Optim.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/anriseth/Optim.jl/languages","stargazers_url":"https://api.github.com/repos/anriseth/Optim.jl/stargazers","contributors_url":"https://api.github.com/repos/anriseth/Optim.jl/contributors","subscribers_url":"https://api.github.com/repos/anriseth/Optim.jl/subscribers","subscription_url":"https://api.github.com/repos/anriseth/Optim.jl/subscription","commits_url":"https://api.github.com/repos/anriseth/Optim.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/anriseth/Optim.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/anriseth/Optim.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/anriseth/Optim.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/anriseth/Optim.jl/contents/{+path}","compare_url":"https://api.github.com/repos/anriseth/Optim.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anriseth/Optim.jl/merges","archive_url":"https://api.github.com/repos/anriseth/Optim.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anriseth/Optim.jl/downloads","issues_url":"https://api.github.com/repos/anriseth/Optim.jl/issues{/number}","pulls_url":"https://api.github.com/repos/anriseth/Optim.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/anriseth/Optim.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/anriseth/Optim.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anriseth/Optim.jl/labels{/name}","releases_url":"https://api.github.com/repos/anriseth/Optim.jl/releases{/id}","deployments_url":"https://api.github.com/repos/anriseth/Optim.jl/deployments","created_at":"2016-05-04T23:10:13Z","updated_at":"2016-05-04T23:10:14Z","pushed_at":"2018-09-20T10:46:54Z","git_url":"git://github.com/anriseth/Optim.jl.git","ssh_url":"git@github.com:anriseth/Optim.jl.git","clone_url":"https://github.com/anriseth/Optim.jl.git","svn_url":"https://github.com/anriseth/Optim.jl","homepage":"","size":1686,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaNLSolvers:master","ref":"master","sha":"926acfc1132340b33c0142025134571ce37bfa9a","user":{"login":"JuliaNLSolvers","id":25707270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NzA3Mjcw","avatar_url":"https://avatars0.githubusercontent.com/u/25707270?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaNLSolvers","html_url":"https://github.com/JuliaNLSolvers","followers_url":"https://api.github.com/users/JuliaNLSolvers/followers","following_url":"https://api.github.com/users/JuliaNLSolvers/following{/other_user}","gists_url":"https://api.github.com/users/JuliaNLSolvers/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaNLSolvers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaNLSolvers/subscriptions","organizations_url":"https://api.github.com/users/JuliaNLSolvers/orgs","repos_url":"https://api.github.com/users/JuliaNLSolvers/repos","events_url":"https://api.github.com/users/JuliaNLSolvers/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaNLSolvers/received_events","type":"Organization","site_admin":false},"repo":{"id":3933868,"node_id":"MDEwOlJlcG9zaXRvcnkzOTMzODY4","name":"Optim.jl","full_name":"JuliaNLSolvers/Optim.jl","private":false,"owner":{"login":"JuliaNLSolvers","id":25707270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NzA3Mjcw","avatar_url":"https://avatars0.githubusercontent.com/u/25707270?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaNLSolvers","html_url":"https://github.com/JuliaNLSolvers","followers_url":"https://api.github.com/users/JuliaNLSolvers/followers","following_url":"https://api.github.com/users/JuliaNLSolvers/following{/other_user}","gists_url":"https://api.github.com/users/JuliaNLSolvers/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaNLSolvers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaNLSolvers/subscriptions","organizations_url":"https://api.github.com/users/JuliaNLSolvers/orgs","repos_url":"https://api.github.com/users/JuliaNLSolvers/repos","events_url":"https://api.github.com/users/JuliaNLSolvers/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaNLSolvers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaNLSolvers/Optim.jl","description":"Optimization functions for Julia","fork":false,"url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl","forks_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/forks","keys_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/teams","hooks_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/events","assignees_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/tags","blobs_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/subscription","commits_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/merges","archive_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/downloads","issues_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/deployments","created_at":"2012-04-04T22:19:35Z","updated_at":"2018-09-21T13:01:53Z","pushed_at":"2018-09-21T13:01:50Z","git_url":"git://github.com/JuliaNLSolvers/Optim.jl.git","ssh_url":"git@github.com:JuliaNLSolvers/Optim.jl.git","clone_url":"https://github.com/JuliaNLSolvers/Optim.jl.git","svn_url":"https://github.com/JuliaNLSolvers/Optim.jl","homepage":"","size":3961,"stargazers_count":336,"watchers_count":336,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":109,"open_issues":69,"watchers":336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/pulls/670"},"html":{"href":"https://github.com/JuliaNLSolvers/Optim.jl/pull/670"},"issue":{"href":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues/670"},"comments":{"href":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/issues/670/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/pulls/670/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/pulls/670/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaNLSolvers/Optim.jl/statuses/14b678359fcc5c584d7181d2fefc934eadba0423"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":23,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"pkofod"}}