{"action":"created","issue":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1345","repository_url":"https://api.github.com/repos/KratosMultiphysics/Kratos","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1345/labels{/name}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1345/comments","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1345/events","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/1345","id":289965862,"number":1345,"title":"[ContactStructuralMechanicsApplication] Some updates","user":{"login":"loumalouomega","id":19991680,"avatar_url":"https://avatars2.githubusercontent.com/u/19991680?v=4","gravatar_id":"","url":"https://api.github.com/users/loumalouomega","html_url":"https://github.com/loumalouomega","followers_url":"https://api.github.com/users/loumalouomega/followers","following_url":"https://api.github.com/users/loumalouomega/following{/other_user}","gists_url":"https://api.github.com/users/loumalouomega/gists{/gist_id}","starred_url":"https://api.github.com/users/loumalouomega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loumalouomega/subscriptions","organizations_url":"https://api.github.com/users/loumalouomega/orgs","repos_url":"https://api.github.com/users/loumalouomega/repos","events_url":"https://api.github.com/users/loumalouomega/events{/privacy}","received_events_url":"https://api.github.com/users/loumalouomega/received_events","type":"User","site_admin":false},"labels":[{"id":539268248,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/applications","name":"applications","color":"d4c5f9","default":false},{"id":538625941,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/cleanup","name":"cleanup","color":"0052cc","default":false},{"id":752495538,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/documentation","name":"documentation","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-01-19T12:51:02Z","updated_at":"2018-02-06T18:45:31Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/1345","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/1345","diff_url":"https://github.com/KratosMultiphysics/Kratos/pull/1345.diff","patch_url":"https://github.com/KratosMultiphysics/Kratos/pull/1345.patch"},"body":"To avoid having a large PR in the future I do this PR with some recent modifications\n\nRegarding #1341 there is any way to convert standard LaTeX to Jupyter, I found how to transform Jupyter to LaTeX but not the contrary."},"comment":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments/363523803","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/1345#issuecomment-363523803","issue_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1345","id":363523803,"user":{"login":"loumalouomega","id":19991680,"avatar_url":"https://avatars2.githubusercontent.com/u/19991680?v=4","gravatar_id":"","url":"https://api.github.com/users/loumalouomega","html_url":"https://github.com/loumalouomega","followers_url":"https://api.github.com/users/loumalouomega/followers","following_url":"https://api.github.com/users/loumalouomega/following{/other_user}","gists_url":"https://api.github.com/users/loumalouomega/gists{/gist_id}","starred_url":"https://api.github.com/users/loumalouomega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loumalouomega/subscriptions","organizations_url":"https://api.github.com/users/loumalouomega/orgs","repos_url":"https://api.github.com/users/loumalouomega/repos","events_url":"https://api.github.com/users/loumalouomega/events{/privacy}","received_events_url":"https://api.github.com/users/loumalouomega/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T18:45:31Z","updated_at":"2018-02-06T18:45:31Z","author_association":"MEMBER","body":"It's  different, that's why is called custom\n\nEl 6 feb. 2018 7:32 p. m., \"Riccardo Rossi\" <notifications@github.com>\nescribió:\n\n> *@RiccardoRossi* commented on this pull request.\n> ------------------------------\n>\n> In applications/ContactStructuralMechanicsApplication/custom_strategies/\n> custom_convergencecriterias/base_mortar_criteria.h\n> <https://github.com/KratosMultiphysics/Kratos/pull/1345#discussion_r166349532>\n> :\n>\n> > @@ -88,7 +88,7 @@ class BaseMortarConvergenceCriteria\n>      BaseMortarConvergenceCriteria(const bool IODebug = false)\n>          : ConvergenceCriteria< TSparseSpace, TDenseSpace >(),\n>            mIODebug(IODebug),\n> -          mGidIO(\"POST_LINEAR_ITER\", GiD_PostBinary, SingleFile, WriteUndeformed,  WriteElementsOnly)\n> +          mGidIO(\"POST_LINEAR_ITER\", GiD_PostBinary, SingleFile, WriteUndeformed,  WriteConditions)\n>\n> at least default it to null... and handle the case in which this is not\n> provided\n> ------------------------------\n>\n> In applications/ContactStructuralMechanicsApplication/custom_utilities/\n> process_factory_utility.h\n> <https://github.com/KratosMultiphysics/Kratos/pull/1345#discussion_r166349764>\n> :\n>\n> > @@ -56,9 +56,9 @@ class ProcessFactoryUtility\n>      /// Counted pointer of ProcessFactoryUtility\n>      KRATOS_CLASS_POINTER_DEFINITION( ProcessFactoryUtility );\n>\n> -    typedef typename boost::python::object ObjectType;\n> +    typedef boost::python::object ObjectType;\n>\n> can i ask you why you took out the typename? did u try if it compiles in\n> windows without?\n> ------------------------------\n>\n> In applications/ContactStructuralMechanicsAppl\n> ication/custom_utilities/tree_contact_search.cpp\n> <https://github.com/KratosMultiphysics/Kratos/pull/1345#discussion_r166350556>\n> :\n>\n> > @@ -501,14 +523,14 @@ inline void TreeContactSearch<TDim, TNumNodes>::InitializeAcceleration()\n>              auto it_node = nodes_array.begin() + i;\n>              const array_1d<double, 3>& nodal_volume_acceleration = it_node->FastGetSolutionStepValue(VOLUME_ACCELERATION);\n>              if (norm_2(volume_acceleration) > 0.0) {\n> -                if (!it_node->IsFixed(ACCELERATION_X)) it_node->FastGetSolutionStepValue(ACCELERATION_X) = volume_acceleration[0];\n> -                if (!it_node->IsFixed(ACCELERATION_Y)) it_node->FastGetSolutionStepValue(ACCELERATION_Y) = volume_acceleration[1];\n> -                if (!it_node->IsFixed(ACCELERATION_Z)) it_node->FastGetSolutionStepValue(ACCELERATION_Z) = volume_acceleration[2];\n> +                if (!it_node->IsFixed(ACCELERATION_X)) it_node->FastGetSolutionStepValue(ACCELERATION_X, 1) = volume_acceleration[0];\n>\n> this is inefficient since you access once to the array per each component.\n>\n> do something like\n>\n> array_1d<double, 3>& old_acc = it_node->FastGetSolutionStepValue(ACCELERATION);\n> if(...)\n>       old_acc[0] = ...\n> if(...)\n>       old_acc[1] = ...\n>\n> ------------------------------\n>\n> In applications/ContactStructuralMechanicsApplication/symbolic_generation/\n> mesh_tying_mortar_condition/custom_sympy_fe_utilities.py\n> <https://github.com/KratosMultiphysics/Kratos/pull/1345#discussion_r166351012>\n> :\n>\n> > @@ -1,492 +0,0 @@\n> -from sympy import *\n>\n> remove it. You should be using the one in the core. What are the\n> differences?\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/KratosMultiphysics/Kratos/pull/1345#pullrequestreview-94397931>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ATEMgM5gqr5t1pU0srOtsulH9Di0wkULks5tSHfIgaJpZM4Rkbsq>\n> .\n>\n"}}
{"actor":{"display_login":"loumalouomega"}}