{"action":"created","comment":{"url":"https://api.github.com/repos/snyk/snyk/pulls/comments/244578634","pull_request_review_id":188489160,"id":244578634,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU3ODYzNA==","diff_hunk":"@@ -288,58 +287,108 @@ function displayResult(res, options) {\n     ['metadata.severityValue', 'metadata.name'],\n     ['asc', 'desc']\n   );\n-  var groupedVulnInfoOutput = sortedGroupedVulns.map(function (vuln) {\n-    var vulnID = vuln.list[0].id;\n-    var uniquePackages = _.uniq(\n-      vuln.list.map(function (i) {\n-        if (i.from[1]) {\n-          return i.from && i.from[1];\n-        }\n-        return i.from;\n-      }))\n-      .join(', ');\n-\n-    var vulnOutput = {\n-      issueHeading: createSeverityBasedIssueHeading(\n-        vuln.metadata.severity,\n-        vuln.metadata.type,\n-        vuln.metadata.name\n-      ),\n-      introducedThrough: '  Introduced through: ' + uniquePackages,\n-      description: '  Description: ' + vuln.title,\n-      info: '  Info: ' + chalk.underline(config.ROOT + '/vuln/' + vulnID),\n-      fromPaths: options.showVulnPaths\n-        ? createTruncatedVulnsPathsText(vuln.list) : '',\n-      extraInfo: vuln.note ? chalk.bold('\\n  Note: ' + vuln.note) : '',\n-      remediationInfo: vuln.metadata.type !== 'license'\n-        ? createRemediationText(vuln, packageManager)\n-        : '',\n-      fixedIn: options.docker ? createFixedInText(vuln) : '',\n-    };\n-    return (\n-      vulnOutput.issueHeading + '\\n' +\n-      vulnOutput.description + '\\n' +\n-      vulnOutput.info + '\\n' +\n-      vulnOutput.introducedThrough + '\\n' +\n-      vulnOutput.fromPaths +\n-      // Optional - not always there\n-      vulnOutput.remediationInfo +\n-      vulnOutput.fixedIn +\n-      vulnOutput.extraInfo\n-    );\n+  var nonBinariesSortedGroupedVulns = sortedGroupedVulns.filter(function (vuln) {","path":"src/cli/commands/test.js","position":67,"original_position":67,"commit_id":"1a4e92e288f955a04406be955cc21fcb692ceafb","original_commit_id":"b989f626d8f4c048bacf599ead6fcb4bf61e3bfb","user":{"login":"karniwl","id":42895464,"node_id":"MDQ6VXNlcjQyODk1NDY0","avatar_url":"https://avatars3.githubusercontent.com/u/42895464?v=4","gravatar_id":"","url":"https://api.github.com/users/karniwl","html_url":"https://github.com/karniwl","followers_url":"https://api.github.com/users/karniwl/followers","following_url":"https://api.github.com/users/karniwl/following{/other_user}","gists_url":"https://api.github.com/users/karniwl/gists{/gist_id}","starred_url":"https://api.github.com/users/karniwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karniwl/subscriptions","organizations_url":"https://api.github.com/users/karniwl/orgs","repos_url":"https://api.github.com/users/karniwl/repos","events_url":"https://api.github.com/users/karniwl/events{/privacy}","received_events_url":"https://api.github.com/users/karniwl/received_events","type":"User","site_admin":false},"body":"that's the name I first gave and it caused a bug that wasted too much time because that's a variable name we already declared and changing it deletes all binaries vulns from it and then when filtering by `upstream` package manager we get an empty result...\r\nI can change the order of the lines but that's too error-prone imo, I'll think of another solution but you're welcome to offer one as well.","created_at":"2018-12-31T11:58:27Z","updated_at":"2018-12-31T11:58:27Z","html_url":"https://github.com/snyk/snyk/pull/317#discussion_r244578634","pull_request_url":"https://api.github.com/repos/snyk/snyk/pulls/317","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/snyk/snyk/pulls/comments/244578634"},"html":{"href":"https://github.com/snyk/snyk/pull/317#discussion_r244578634"},"pull_request":{"href":"https://api.github.com/repos/snyk/snyk/pulls/317"}},"in_reply_to_id":244576229},"pull_request":{"url":"https://api.github.com/repos/snyk/snyk/pulls/317","id":241490421,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDkwNDIx","html_url":"https://github.com/snyk/snyk/pull/317","diff_url":"https://github.com/snyk/snyk/pull/317.diff","patch_url":"https://github.com/snyk/snyk/pull/317.patch","issue_url":"https://api.github.com/repos/snyk/snyk/issues/317","number":317,"state":"open","locked":false,"title":"feat: fixed in key in binaries output","user":{"login":"karniwl","id":42895464,"node_id":"MDQ6VXNlcjQyODk1NDY0","avatar_url":"https://avatars3.githubusercontent.com/u/42895464?v=4","gravatar_id":"","url":"https://api.github.com/users/karniwl","html_url":"https://github.com/karniwl","followers_url":"https://api.github.com/users/karniwl/followers","following_url":"https://api.github.com/users/karniwl/following{/other_user}","gists_url":"https://api.github.com/users/karniwl/gists{/gist_id}","starred_url":"https://api.github.com/users/karniwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karniwl/subscriptions","organizations_url":"https://api.github.com/users/karniwl/orgs","repos_url":"https://api.github.com/users/karniwl/repos","events_url":"https://api.github.com/users/karniwl/events{/privacy}","received_events_url":"https://api.github.com/users/karniwl/received_events","type":"User","site_admin":false},"body":"- [x] Ready for review\r\n- [x] Follows [CONTRIBUTING](https://github.com/snyk/snyk/blob/master/.github/CONTRIBUTING.md) rules\r\n- [ ] Reviewed by Snyk internal team\r\n\r\n#### What does this PR do?\r\nAdds a `Fixed in` version key in binaries/output, using npm semver rules.\r\nRefactors formatting issues logic.\r\n\r\n\r\n#### How should this be manually tested?\r\nRun `snyk test --docker node:5.10.1` for example to see the fixed versions of found vulnerabilities.\r\n\r\n\r\n#### Screenshots\r\n\r\n![image](https://user-images.githubusercontent.com/42895464/50559701-4d54a780-0d02-11e9-9924-9e38d0a0184b.png)\r\n\r\n","created_at":"2018-12-30T13:09:10Z","updated_at":"2018-12-31T11:58:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54fc7b410e86bf67b083a767df6bb54844a69425","assignee":{"login":"karniwl","id":42895464,"node_id":"MDQ6VXNlcjQyODk1NDY0","avatar_url":"https://avatars3.githubusercontent.com/u/42895464?v=4","gravatar_id":"","url":"https://api.github.com/users/karniwl","html_url":"https://github.com/karniwl","followers_url":"https://api.github.com/users/karniwl/followers","following_url":"https://api.github.com/users/karniwl/following{/other_user}","gists_url":"https://api.github.com/users/karniwl/gists{/gist_id}","starred_url":"https://api.github.com/users/karniwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karniwl/subscriptions","organizations_url":"https://api.github.com/users/karniwl/orgs","repos_url":"https://api.github.com/users/karniwl/repos","events_url":"https://api.github.com/users/karniwl/events{/privacy}","received_events_url":"https://api.github.com/users/karniwl/received_events","type":"User","site_admin":false},"assignees":[{"login":"karniwl","id":42895464,"node_id":"MDQ6VXNlcjQyODk1NDY0","avatar_url":"https://avatars3.githubusercontent.com/u/42895464?v=4","gravatar_id":"","url":"https://api.github.com/users/karniwl","html_url":"https://github.com/karniwl","followers_url":"https://api.github.com/users/karniwl/followers","following_url":"https://api.github.com/users/karniwl/following{/other_user}","gists_url":"https://api.github.com/users/karniwl/gists{/gist_id}","starred_url":"https://api.github.com/users/karniwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karniwl/subscriptions","organizations_url":"https://api.github.com/users/karniwl/orgs","repos_url":"https://api.github.com/users/karniwl/repos","events_url":"https://api.github.com/users/karniwl/events{/privacy}","received_events_url":"https://api.github.com/users/karniwl/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"darmalovan","id":5316748,"node_id":"MDQ6VXNlcjUzMTY3NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/5316748?v=4","gravatar_id":"","url":"https://api.github.com/users/darmalovan","html_url":"https://github.com/darmalovan","followers_url":"https://api.github.com/users/darmalovan/followers","following_url":"https://api.github.com/users/darmalovan/following{/other_user}","gists_url":"https://api.github.com/users/darmalovan/gists{/gist_id}","starred_url":"https://api.github.com/users/darmalovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darmalovan/subscriptions","organizations_url":"https://api.github.com/users/darmalovan/orgs","repos_url":"https://api.github.com/users/darmalovan/repos","events_url":"https://api.github.com/users/darmalovan/events{/privacy}","received_events_url":"https://api.github.com/users/darmalovan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snyk/snyk/pulls/317/commits","review_comments_url":"https://api.github.com/repos/snyk/snyk/pulls/317/comments","review_comment_url":"https://api.github.com/repos/snyk/snyk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snyk/snyk/issues/317/comments","statuses_url":"https://api.github.com/repos/snyk/snyk/statuses/1a4e92e288f955a04406be955cc21fcb692ceafb","head":{"label":"snyk:feat/support-docker-binaries","ref":"feat/support-docker-binaries","sha":"1a4e92e288f955a04406be955cc21fcb692ceafb","user":{"login":"snyk","id":12959162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTU5MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/12959162?v=4","gravatar_id":"","url":"https://api.github.com/users/snyk","html_url":"https://github.com/snyk","followers_url":"https://api.github.com/users/snyk/followers","following_url":"https://api.github.com/users/snyk/following{/other_user}","gists_url":"https://api.github.com/users/snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snyk/subscriptions","organizations_url":"https://api.github.com/users/snyk/orgs","repos_url":"https://api.github.com/users/snyk/repos","events_url":"https://api.github.com/users/snyk/events{/privacy}","received_events_url":"https://api.github.com/users/snyk/received_events","type":"Organization","site_admin":false},"repo":{"id":45247496,"node_id":"MDEwOlJlcG9zaXRvcnk0NTI0NzQ5Ng==","name":"snyk","full_name":"snyk/snyk","private":false,"owner":{"login":"snyk","id":12959162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTU5MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/12959162?v=4","gravatar_id":"","url":"https://api.github.com/users/snyk","html_url":"https://github.com/snyk","followers_url":"https://api.github.com/users/snyk/followers","following_url":"https://api.github.com/users/snyk/following{/other_user}","gists_url":"https://api.github.com/users/snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snyk/subscriptions","organizations_url":"https://api.github.com/users/snyk/orgs","repos_url":"https://api.github.com/users/snyk/repos","events_url":"https://api.github.com/users/snyk/events{/privacy}","received_events_url":"https://api.github.com/users/snyk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snyk/snyk","description":"CLI and build-time tool to find & fix known vulnerabilities in open-source dependencies","fork":false,"url":"https://api.github.com/repos/snyk/snyk","forks_url":"https://api.github.com/repos/snyk/snyk/forks","keys_url":"https://api.github.com/repos/snyk/snyk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snyk/snyk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snyk/snyk/teams","hooks_url":"https://api.github.com/repos/snyk/snyk/hooks","issue_events_url":"https://api.github.com/repos/snyk/snyk/issues/events{/number}","events_url":"https://api.github.com/repos/snyk/snyk/events","assignees_url":"https://api.github.com/repos/snyk/snyk/assignees{/user}","branches_url":"https://api.github.com/repos/snyk/snyk/branches{/branch}","tags_url":"https://api.github.com/repos/snyk/snyk/tags","blobs_url":"https://api.github.com/repos/snyk/snyk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snyk/snyk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snyk/snyk/git/refs{/sha}","trees_url":"https://api.github.com/repos/snyk/snyk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snyk/snyk/statuses/{sha}","languages_url":"https://api.github.com/repos/snyk/snyk/languages","stargazers_url":"https://api.github.com/repos/snyk/snyk/stargazers","contributors_url":"https://api.github.com/repos/snyk/snyk/contributors","subscribers_url":"https://api.github.com/repos/snyk/snyk/subscribers","subscription_url":"https://api.github.com/repos/snyk/snyk/subscription","commits_url":"https://api.github.com/repos/snyk/snyk/commits{/sha}","git_commits_url":"https://api.github.com/repos/snyk/snyk/git/commits{/sha}","comments_url":"https://api.github.com/repos/snyk/snyk/comments{/number}","issue_comment_url":"https://api.github.com/repos/snyk/snyk/issues/comments{/number}","contents_url":"https://api.github.com/repos/snyk/snyk/contents/{+path}","compare_url":"https://api.github.com/repos/snyk/snyk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snyk/snyk/merges","archive_url":"https://api.github.com/repos/snyk/snyk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snyk/snyk/downloads","issues_url":"https://api.github.com/repos/snyk/snyk/issues{/number}","pulls_url":"https://api.github.com/repos/snyk/snyk/pulls{/number}","milestones_url":"https://api.github.com/repos/snyk/snyk/milestones{/number}","notifications_url":"https://api.github.com/repos/snyk/snyk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snyk/snyk/labels{/name}","releases_url":"https://api.github.com/repos/snyk/snyk/releases{/id}","deployments_url":"https://api.github.com/repos/snyk/snyk/deployments","created_at":"2015-10-30T11:36:00Z","updated_at":"2018-12-31T07:14:14Z","pushed_at":"2018-12-31T11:39:32Z","git_url":"git://github.com/snyk/snyk.git","ssh_url":"git@github.com:snyk/snyk.git","clone_url":"https://github.com/snyk/snyk.git","svn_url":"https://github.com/snyk/snyk","homepage":"https://snyk.io","size":9892,"stargazers_count":1361,"watchers_count":1361,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":107,"open_issues":73,"watchers":1361,"default_branch":"master"}},"base":{"label":"snyk:master","ref":"master","sha":"ee43b4a59716d43a41764ce08cb0a758737c8b1b","user":{"login":"snyk","id":12959162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTU5MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/12959162?v=4","gravatar_id":"","url":"https://api.github.com/users/snyk","html_url":"https://github.com/snyk","followers_url":"https://api.github.com/users/snyk/followers","following_url":"https://api.github.com/users/snyk/following{/other_user}","gists_url":"https://api.github.com/users/snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snyk/subscriptions","organizations_url":"https://api.github.com/users/snyk/orgs","repos_url":"https://api.github.com/users/snyk/repos","events_url":"https://api.github.com/users/snyk/events{/privacy}","received_events_url":"https://api.github.com/users/snyk/received_events","type":"Organization","site_admin":false},"repo":{"id":45247496,"node_id":"MDEwOlJlcG9zaXRvcnk0NTI0NzQ5Ng==","name":"snyk","full_name":"snyk/snyk","private":false,"owner":{"login":"snyk","id":12959162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTU5MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/12959162?v=4","gravatar_id":"","url":"https://api.github.com/users/snyk","html_url":"https://github.com/snyk","followers_url":"https://api.github.com/users/snyk/followers","following_url":"https://api.github.com/users/snyk/following{/other_user}","gists_url":"https://api.github.com/users/snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snyk/subscriptions","organizations_url":"https://api.github.com/users/snyk/orgs","repos_url":"https://api.github.com/users/snyk/repos","events_url":"https://api.github.com/users/snyk/events{/privacy}","received_events_url":"https://api.github.com/users/snyk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snyk/snyk","description":"CLI and build-time tool to find & fix known vulnerabilities in open-source dependencies","fork":false,"url":"https://api.github.com/repos/snyk/snyk","forks_url":"https://api.github.com/repos/snyk/snyk/forks","keys_url":"https://api.github.com/repos/snyk/snyk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snyk/snyk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snyk/snyk/teams","hooks_url":"https://api.github.com/repos/snyk/snyk/hooks","issue_events_url":"https://api.github.com/repos/snyk/snyk/issues/events{/number}","events_url":"https://api.github.com/repos/snyk/snyk/events","assignees_url":"https://api.github.com/repos/snyk/snyk/assignees{/user}","branches_url":"https://api.github.com/repos/snyk/snyk/branches{/branch}","tags_url":"https://api.github.com/repos/snyk/snyk/tags","blobs_url":"https://api.github.com/repos/snyk/snyk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snyk/snyk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snyk/snyk/git/refs{/sha}","trees_url":"https://api.github.com/repos/snyk/snyk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snyk/snyk/statuses/{sha}","languages_url":"https://api.github.com/repos/snyk/snyk/languages","stargazers_url":"https://api.github.com/repos/snyk/snyk/stargazers","contributors_url":"https://api.github.com/repos/snyk/snyk/contributors","subscribers_url":"https://api.github.com/repos/snyk/snyk/subscribers","subscription_url":"https://api.github.com/repos/snyk/snyk/subscription","commits_url":"https://api.github.com/repos/snyk/snyk/commits{/sha}","git_commits_url":"https://api.github.com/repos/snyk/snyk/git/commits{/sha}","comments_url":"https://api.github.com/repos/snyk/snyk/comments{/number}","issue_comment_url":"https://api.github.com/repos/snyk/snyk/issues/comments{/number}","contents_url":"https://api.github.com/repos/snyk/snyk/contents/{+path}","compare_url":"https://api.github.com/repos/snyk/snyk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snyk/snyk/merges","archive_url":"https://api.github.com/repos/snyk/snyk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snyk/snyk/downloads","issues_url":"https://api.github.com/repos/snyk/snyk/issues{/number}","pulls_url":"https://api.github.com/repos/snyk/snyk/pulls{/number}","milestones_url":"https://api.github.com/repos/snyk/snyk/milestones{/number}","notifications_url":"https://api.github.com/repos/snyk/snyk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snyk/snyk/labels{/name}","releases_url":"https://api.github.com/repos/snyk/snyk/releases{/id}","deployments_url":"https://api.github.com/repos/snyk/snyk/deployments","created_at":"2015-10-30T11:36:00Z","updated_at":"2018-12-31T07:14:14Z","pushed_at":"2018-12-31T11:39:32Z","git_url":"git://github.com/snyk/snyk.git","ssh_url":"git@github.com:snyk/snyk.git","clone_url":"https://github.com/snyk/snyk.git","svn_url":"https://github.com/snyk/snyk","homepage":"https://snyk.io","size":9892,"stargazers_count":1361,"watchers_count":1361,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":107,"open_issues":73,"watchers":1361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snyk/snyk/pulls/317"},"html":{"href":"https://github.com/snyk/snyk/pull/317"},"issue":{"href":"https://api.github.com/repos/snyk/snyk/issues/317"},"comments":{"href":"https://api.github.com/repos/snyk/snyk/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/snyk/snyk/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/snyk/snyk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snyk/snyk/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/snyk/snyk/statuses/1a4e92e288f955a04406be955cc21fcb692ceafb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"karniwl"}}