{"action":"closed","number":2513,"pull_request":{"url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2513","id":181706063,"html_url":"https://github.com/elixir-ecto/ecto/pull/2513","diff_url":"https://github.com/elixir-ecto/ecto/pull/2513.diff","patch_url":"https://github.com/elixir-ecto/ecto/pull/2513.patch","issue_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/2513","number":2513,"state":"closed","locked":false,"title":"Multi.error skips transaction and directly returns error","user":{"login":"hlhr","id":9610942,"avatar_url":"https://avatars3.githubusercontent.com/u/9610942?v=4","gravatar_id":"","url":"https://api.github.com/users/hlhr","html_url":"https://github.com/hlhr","followers_url":"https://api.github.com/users/hlhr/followers","following_url":"https://api.github.com/users/hlhr/following{/other_user}","gists_url":"https://api.github.com/users/hlhr/gists{/gist_id}","starred_url":"https://api.github.com/users/hlhr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlhr/subscriptions","organizations_url":"https://api.github.com/users/hlhr/orgs","repos_url":"https://api.github.com/users/hlhr/repos","events_url":"https://api.github.com/users/hlhr/events{/privacy}","received_events_url":"https://api.github.com/users/hlhr/received_events","type":"User","site_admin":false},"body":"Implementation of issue #2507 \r\n\r\nIf a error operation is part of the multi operations no transaction will get started and the error gets returned. The tests got changed to reflect the new behaviour.\r\nI only changed the docs for `Multi.error`, the documentation for `Repo.transaction` could get changed too but I think that's not necessary.\r\n\r\nJust give me a feedback if additional changes have to be made e.g. in the documentation.","created_at":"2018-04-15T15:56:34Z","updated_at":"2018-04-15T21:01:06Z","closed_at":"2018-04-15T21:01:05Z","merged_at":"2018-04-15T21:01:05Z","merge_commit_sha":"d6892bec818327aa23c48bf10c315fff8cf14e5b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2513/commits","review_comments_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2513/comments","review_comment_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/2513/comments","statuses_url":"https://api.github.com/repos/elixir-ecto/ecto/statuses/88e9ca4dbe917265d82555b365d7e4d743a93c13","head":{"label":"hlhr:master","ref":"master","sha":"88e9ca4dbe917265d82555b365d7e4d743a93c13","user":{"login":"hlhr","id":9610942,"avatar_url":"https://avatars3.githubusercontent.com/u/9610942?v=4","gravatar_id":"","url":"https://api.github.com/users/hlhr","html_url":"https://github.com/hlhr","followers_url":"https://api.github.com/users/hlhr/followers","following_url":"https://api.github.com/users/hlhr/following{/other_user}","gists_url":"https://api.github.com/users/hlhr/gists{/gist_id}","starred_url":"https://api.github.com/users/hlhr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlhr/subscriptions","organizations_url":"https://api.github.com/users/hlhr/orgs","repos_url":"https://api.github.com/users/hlhr/repos","events_url":"https://api.github.com/users/hlhr/events{/privacy}","received_events_url":"https://api.github.com/users/hlhr/received_events","type":"User","site_admin":false},"repo":{"id":129566484,"name":"ecto","full_name":"hlhr/ecto","owner":{"login":"hlhr","id":9610942,"avatar_url":"https://avatars3.githubusercontent.com/u/9610942?v=4","gravatar_id":"","url":"https://api.github.com/users/hlhr","html_url":"https://github.com/hlhr","followers_url":"https://api.github.com/users/hlhr/followers","following_url":"https://api.github.com/users/hlhr/following{/other_user}","gists_url":"https://api.github.com/users/hlhr/gists{/gist_id}","starred_url":"https://api.github.com/users/hlhr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlhr/subscriptions","organizations_url":"https://api.github.com/users/hlhr/orgs","repos_url":"https://api.github.com/users/hlhr/repos","events_url":"https://api.github.com/users/hlhr/events{/privacy}","received_events_url":"https://api.github.com/users/hlhr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hlhr/ecto","description":"A database wrapper and language integrated query for Elixir","fork":true,"url":"https://api.github.com/repos/hlhr/ecto","forks_url":"https://api.github.com/repos/hlhr/ecto/forks","keys_url":"https://api.github.com/repos/hlhr/ecto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hlhr/ecto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hlhr/ecto/teams","hooks_url":"https://api.github.com/repos/hlhr/ecto/hooks","issue_events_url":"https://api.github.com/repos/hlhr/ecto/issues/events{/number}","events_url":"https://api.github.com/repos/hlhr/ecto/events","assignees_url":"https://api.github.com/repos/hlhr/ecto/assignees{/user}","branches_url":"https://api.github.com/repos/hlhr/ecto/branches{/branch}","tags_url":"https://api.github.com/repos/hlhr/ecto/tags","blobs_url":"https://api.github.com/repos/hlhr/ecto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hlhr/ecto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hlhr/ecto/git/refs{/sha}","trees_url":"https://api.github.com/repos/hlhr/ecto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hlhr/ecto/statuses/{sha}","languages_url":"https://api.github.com/repos/hlhr/ecto/languages","stargazers_url":"https://api.github.com/repos/hlhr/ecto/stargazers","contributors_url":"https://api.github.com/repos/hlhr/ecto/contributors","subscribers_url":"https://api.github.com/repos/hlhr/ecto/subscribers","subscription_url":"https://api.github.com/repos/hlhr/ecto/subscription","commits_url":"https://api.github.com/repos/hlhr/ecto/commits{/sha}","git_commits_url":"https://api.github.com/repos/hlhr/ecto/git/commits{/sha}","comments_url":"https://api.github.com/repos/hlhr/ecto/comments{/number}","issue_comment_url":"https://api.github.com/repos/hlhr/ecto/issues/comments{/number}","contents_url":"https://api.github.com/repos/hlhr/ecto/contents/{+path}","compare_url":"https://api.github.com/repos/hlhr/ecto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hlhr/ecto/merges","archive_url":"https://api.github.com/repos/hlhr/ecto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hlhr/ecto/downloads","issues_url":"https://api.github.com/repos/hlhr/ecto/issues{/number}","pulls_url":"https://api.github.com/repos/hlhr/ecto/pulls{/number}","milestones_url":"https://api.github.com/repos/hlhr/ecto/milestones{/number}","notifications_url":"https://api.github.com/repos/hlhr/ecto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hlhr/ecto/labels{/name}","releases_url":"https://api.github.com/repos/hlhr/ecto/releases{/id}","deployments_url":"https://api.github.com/repos/hlhr/ecto/deployments","created_at":"2018-04-15T01:11:27Z","updated_at":"2018-04-15T15:46:41Z","pushed_at":"2018-04-15T15:46:39Z","git_url":"git://github.com/hlhr/ecto.git","ssh_url":"git@github.com:hlhr/ecto.git","clone_url":"https://github.com/hlhr/ecto.git","svn_url":"https://github.com/hlhr/ecto","homepage":"https://hexdocs.pm/ecto","size":10652,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-ecto:master","ref":"master","sha":"c77a3c4f144c5aeff2635faf00b7b25392c51c4d","user":{"login":"elixir-ecto","id":19973437,"avatar_url":"https://avatars3.githubusercontent.com/u/19973437?v=4","gravatar_id":"","url":"https://api.github.com/users/elixir-ecto","html_url":"https://github.com/elixir-ecto","followers_url":"https://api.github.com/users/elixir-ecto/followers","following_url":"https://api.github.com/users/elixir-ecto/following{/other_user}","gists_url":"https://api.github.com/users/elixir-ecto/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-ecto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-ecto/subscriptions","organizations_url":"https://api.github.com/users/elixir-ecto/orgs","repos_url":"https://api.github.com/users/elixir-ecto/repos","events_url":"https://api.github.com/users/elixir-ecto/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-ecto/received_events","type":"Organization","site_admin":false},"repo":{"id":10649374,"name":"ecto","full_name":"elixir-ecto/ecto","owner":{"login":"elixir-ecto","id":19973437,"avatar_url":"https://avatars3.githubusercontent.com/u/19973437?v=4","gravatar_id":"","url":"https://api.github.com/users/elixir-ecto","html_url":"https://github.com/elixir-ecto","followers_url":"https://api.github.com/users/elixir-ecto/followers","following_url":"https://api.github.com/users/elixir-ecto/following{/other_user}","gists_url":"https://api.github.com/users/elixir-ecto/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-ecto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-ecto/subscriptions","organizations_url":"https://api.github.com/users/elixir-ecto/orgs","repos_url":"https://api.github.com/users/elixir-ecto/repos","events_url":"https://api.github.com/users/elixir-ecto/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-ecto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-ecto/ecto","description":"A database wrapper and language integrated query for Elixir","fork":false,"url":"https://api.github.com/repos/elixir-ecto/ecto","forks_url":"https://api.github.com/repos/elixir-ecto/ecto/forks","keys_url":"https://api.github.com/repos/elixir-ecto/ecto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-ecto/ecto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-ecto/ecto/teams","hooks_url":"https://api.github.com/repos/elixir-ecto/ecto/hooks","issue_events_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-ecto/ecto/events","assignees_url":"https://api.github.com/repos/elixir-ecto/ecto/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-ecto/ecto/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-ecto/ecto/tags","blobs_url":"https://api.github.com/repos/elixir-ecto/ecto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-ecto/ecto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-ecto/ecto/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-ecto/ecto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-ecto/ecto/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-ecto/ecto/languages","stargazers_url":"https://api.github.com/repos/elixir-ecto/ecto/stargazers","contributors_url":"https://api.github.com/repos/elixir-ecto/ecto/contributors","subscribers_url":"https://api.github.com/repos/elixir-ecto/ecto/subscribers","subscription_url":"https://api.github.com/repos/elixir-ecto/ecto/subscription","commits_url":"https://api.github.com/repos/elixir-ecto/ecto/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-ecto/ecto/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-ecto/ecto/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-ecto/ecto/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-ecto/ecto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-ecto/ecto/merges","archive_url":"https://api.github.com/repos/elixir-ecto/ecto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-ecto/ecto/downloads","issues_url":"https://api.github.com/repos/elixir-ecto/ecto/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-ecto/ecto/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-ecto/ecto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-ecto/ecto/labels{/name}","releases_url":"https://api.github.com/repos/elixir-ecto/ecto/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-ecto/ecto/deployments","created_at":"2013-06-12T18:42:06Z","updated_at":"2018-04-14T21:53:53Z","pushed_at":"2018-04-15T21:01:05Z","git_url":"git://github.com/elixir-ecto/ecto.git","ssh_url":"git@github.com:elixir-ecto/ecto.git","clone_url":"https://github.com/elixir-ecto/ecto.git","svn_url":"https://github.com/elixir-ecto/ecto","homepage":"https://hexdocs.pm/ecto","size":10577,"stargazers_count":3435,"watchers_count":3435,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":826,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":826,"open_issues":25,"watchers":3435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2513"},"html":{"href":"https://github.com/elixir-ecto/ecto/pull/2513"},"issue":{"href":"https://api.github.com/repos/elixir-ecto/ecto/issues/2513"},"comments":{"href":"https://api.github.com/repos/elixir-ecto/ecto/issues/2513/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2513/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/2513/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-ecto/ecto/statuses/88e9ca4dbe917265d82555b365d7e4d743a93c13"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"josevalim","id":9582,"avatar_url":"https://avatars0.githubusercontent.com/u/9582?v=4","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"josevalim"}}