{"action":"created","issue":{"url":"https://api.github.com/repos/line/armeria/issues/1296","repository_url":"https://api.github.com/repos/line/armeria","labels_url":"https://api.github.com/repos/line/armeria/issues/1296/labels{/name}","comments_url":"https://api.github.com/repos/line/armeria/issues/1296/comments","events_url":"https://api.github.com/repos/line/armeria/issues/1296/events","html_url":"https://github.com/line/armeria/pull/1296","id":342294832,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjI2OTQ3","number":1296,"title":"Make Armeria Retrofit subscriber not buffer response","user":{"login":"kojilin","id":863983,"node_id":"MDQ6VXNlcjg2Mzk4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/863983?v=4","gravatar_id":"","url":"https://api.github.com/users/kojilin","html_url":"https://github.com/kojilin","followers_url":"https://api.github.com/users/kojilin/followers","following_url":"https://api.github.com/users/kojilin/following{/other_user}","gists_url":"https://api.github.com/users/kojilin/gists{/gist_id}","starred_url":"https://api.github.com/users/kojilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kojilin/subscriptions","organizations_url":"https://api.github.com/users/kojilin/orgs","repos_url":"https://api.github.com/users/kojilin/repos","events_url":"https://api.github.com/users/kojilin/events{/privacy}","received_events_url":"https://api.github.com/users/kojilin/received_events","type":"User","site_admin":false},"labels":[{"id":287189528,"node_id":"MDU6TGFiZWwyODcxODk1Mjg=","url":"https://api.github.com/repos/line/armeria/labels/improvement","name":"improvement","color":"207de5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-18T11:50:08Z","updated_at":"2018-07-30T06:20:39Z","closed_at":"2018-07-30T06:20:32Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/line/armeria/pulls/1296","html_url":"https://github.com/line/armeria/pull/1296","diff_url":"https://github.com/line/armeria/pull/1296.diff","patch_url":"https://github.com/line/armeria/pull/1296.patch"},"body":"Current implementation will buffer all data and call callback when complete.\r\nSo it's not suitable for downloading large files.\r\n\r\nThis PR will make subscriber requests data one by one from response.　And\r\nbecause `SourceBuffer#read` and `Subscriber#onNext` are using same thread, we need to\r\nusing CommonPools to run `SourceBuffer#read` to avoiding deadlock."},"comment":{"url":"https://api.github.com/repos/line/armeria/issues/comments/408758827","html_url":"https://github.com/line/armeria/pull/1296#issuecomment-408758827","issue_url":"https://api.github.com/repos/line/armeria/issues/1296","id":408758827,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODc1ODgyNw==","user":{"login":"trustin","id":173918,"node_id":"MDQ6VXNlcjE3MzkxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T06:20:39Z","updated_at":"2018-07-30T06:20:39Z","author_association":"MEMBER","body":"Thanks, @kojilin !"}}
{"actor":{"display_login":"trustin"}}