{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/225769037","pull_request_review_id":165439142,"id":225769037,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTc2OTAzNw==","diff_hunk":"@@ -105,6 +107,25 @@ void __dead2 sunxi_power_down(void)\n \t\tsunxi_turn_off_soc(SUNXI_SOC_A64);\n \t\t/* Turn off the pin controller now. */\n \t\tmmio_write_32(SUNXI_CCU_BASE + 0x68, 0);\n+\t\tbreak;\n+\tcase REF_DESIGN_H5:\n+\t\tsunxi_turn_off_soc(SUNXI_SOC_H5);\n+\n+\t\t/*\n+\t\t * Switch PL pins to power off the board:\n+\t\t * - PL5 (VCC_IO) -> high\n+\t\t * - PL8 (PWR-STB = CPU power supply) -> low\n+\t\t * - PL9 (PWR-DRAM) ->low\n+\t\t * - PL10 (power LED) -> low\n+\t\t * Note: Clearing PL8 will reset the board, so keep it up.\n+\t\t */\n+\t\tsunxi_set_gpio_out('L', 5, 1);\n+\t\tsunxi_set_gpio_out('L', 9, 0);\n+\t\tsunxi_set_gpio_out('L', 10, 0);\n+\n+\t\t/* turn off pin controller now. */","path":"plat/allwinner/sun50i_a64/sunxi_power.c","position":323,"original_position":38,"commit_id":"1d2aab92c7e896106bd10733cdf2082d9c2505a4","original_commit_id":"4b2f600e5445f9ef51c6eab1f6b87837f3532a74","user":{"login":"smaeul","id":5846453,"node_id":"MDQ6VXNlcjU4NDY0NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5846453?v=4","gravatar_id":"","url":"https://api.github.com/users/smaeul","html_url":"https://github.com/smaeul","followers_url":"https://api.github.com/users/smaeul/followers","following_url":"https://api.github.com/users/smaeul/following{/other_user}","gists_url":"https://api.github.com/users/smaeul/gists{/gist_id}","starred_url":"https://api.github.com/users/smaeul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaeul/subscriptions","organizations_url":"https://api.github.com/users/smaeul/orgs","repos_url":"https://api.github.com/users/smaeul/repos","events_url":"https://api.github.com/users/smaeul/events{/privacy}","received_events_url":"https://api.github.com/users/smaeul/received_events","type":"User","site_admin":false},"body":"turn -> Turn","created_at":"2018-10-17T03:10:23Z","updated_at":"2018-10-17T03:48:36Z","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1633#discussion_r225769037","pull_request_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1633","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/225769037"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1633#discussion_r225769037"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1633"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1633","id":223178494,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMTc4NDk0","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1633","diff_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1633.diff","patch_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1633.patch","issue_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1633","number":1633,"state":"open","locked":false,"title":"Allwinner fixes and PMIC support ","user":{"login":"Andre-ARM","id":26114347,"node_id":"MDQ6VXNlcjI2MTE0MzQ3","avatar_url":"https://avatars0.githubusercontent.com/u/26114347?v=4","gravatar_id":"","url":"https://api.github.com/users/Andre-ARM","html_url":"https://github.com/Andre-ARM","followers_url":"https://api.github.com/users/Andre-ARM/followers","following_url":"https://api.github.com/users/Andre-ARM/following{/other_user}","gists_url":"https://api.github.com/users/Andre-ARM/gists{/gist_id}","starred_url":"https://api.github.com/users/Andre-ARM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andre-ARM/subscriptions","organizations_url":"https://api.github.com/users/Andre-ARM/orgs","repos_url":"https://api.github.com/users/Andre-ARM/repos","events_url":"https://api.github.com/users/Andre-ARM/events{/privacy}","received_events_url":"https://api.github.com/users/Andre-ARM/received_events","type":"User","site_admin":false},"body":"I understand this is quite a series, but most of the patches depend on each other, so not sure that splitting it up is too useful. The patches are arranged to be bisectable (both for compilation and functionality), so earlier patches can always be merged as soon as they are ready.\r\n\r\nThis updates the Allwinner port to do some cleanups and minor improvements, also adding PMIC and proper SYSTEM_OFF and CPU_OFF support to bring it eventually on par (and beyond) the existing \"legacy\" ATF port, by:\r\n- Unifying the platform specific Makefiles.\r\n- Reducing the memory footprint to make room for feature enhancements.\r\n- Adding generic code to reduce power consumption on SYSTEM_OFF without a PMIC.\r\n- Flipping GPIOs on H5 reference design boards to turn off regulators on SYSTEM_OFF.\r\n- Adding support for the RSB bus and the AXP803 PMIC for boards using the A64 SoC (for SYSTEM_OFF).\r\n- Find U-Boot's DTB copy in memory and use that to enable and fix up essential power rails on the AXP803 PMIC.\r\n- Introduce some means to execute code on the management processor and use that to properly turn off cores on CPU_OFF requests.\r\n\r\nI tested this (booting Linux, hotplugging random cores 1000 times, powering off) on: Pine64, BananaPiM64, Emlid Neutis N5, OrangePi PC2, PineH64. Please have a test with your setup and report any issues!","created_at":"2018-10-16T09:34:00Z","updated_at":"2018-10-17T03:48:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e88b87d682155ef014f23df85966be9cf13be7a2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1633/commits","review_comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1633/comments","review_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1633/comments","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/1d2aab92c7e896106bd10733cdf2082d9c2505a4","head":{"label":"Andre-ARM:allwinner/pmic","ref":"allwinner/pmic","sha":"1d2aab92c7e896106bd10733cdf2082d9c2505a4","user":{"login":"Andre-ARM","id":26114347,"node_id":"MDQ6VXNlcjI2MTE0MzQ3","avatar_url":"https://avatars0.githubusercontent.com/u/26114347?v=4","gravatar_id":"","url":"https://api.github.com/users/Andre-ARM","html_url":"https://github.com/Andre-ARM","followers_url":"https://api.github.com/users/Andre-ARM/followers","following_url":"https://api.github.com/users/Andre-ARM/following{/other_user}","gists_url":"https://api.github.com/users/Andre-ARM/gists{/gist_id}","starred_url":"https://api.github.com/users/Andre-ARM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andre-ARM/subscriptions","organizations_url":"https://api.github.com/users/Andre-ARM/orgs","repos_url":"https://api.github.com/users/Andre-ARM/repos","events_url":"https://api.github.com/users/Andre-ARM/events{/privacy}","received_events_url":"https://api.github.com/users/Andre-ARM/received_events","type":"User","site_admin":false},"repo":{"id":83552589,"node_id":"MDEwOlJlcG9zaXRvcnk4MzU1MjU4OQ==","name":"arm-trusted-firmware","full_name":"Andre-ARM/arm-trusted-firmware","private":false,"owner":{"login":"Andre-ARM","id":26114347,"node_id":"MDQ6VXNlcjI2MTE0MzQ3","avatar_url":"https://avatars0.githubusercontent.com/u/26114347?v=4","gravatar_id":"","url":"https://api.github.com/users/Andre-ARM","html_url":"https://github.com/Andre-ARM","followers_url":"https://api.github.com/users/Andre-ARM/followers","following_url":"https://api.github.com/users/Andre-ARM/following{/other_user}","gists_url":"https://api.github.com/users/Andre-ARM/gists{/gist_id}","starred_url":"https://api.github.com/users/Andre-ARM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andre-ARM/subscriptions","organizations_url":"https://api.github.com/users/Andre-ARM/orgs","repos_url":"https://api.github.com/users/Andre-ARM/repos","events_url":"https://api.github.com/users/Andre-ARM/events{/privacy}","received_events_url":"https://api.github.com/users/Andre-ARM/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Andre-ARM/arm-trusted-firmware","description":"ARM Trusted Firmware","fork":true,"url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware","forks_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/Andre-ARM/arm-trusted-firmware/deployments","created_at":"2017-03-01T12:34:13Z","updated_at":"2018-10-07T23:16:17Z","pushed_at":"2018-10-16T09:09:27Z","git_url":"git://github.com/Andre-ARM/arm-trusted-firmware.git","ssh_url":"git@github.com:Andre-ARM/arm-trusted-firmware.git","clone_url":"https://github.com/Andre-ARM/arm-trusted-firmware.git","svn_url":"https://github.com/Andre-ARM/arm-trusted-firmware","homepage":null,"size":15551,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:master","ref":"master","sha":"0a09313ec780d2f66efcda3eb2a5d1632719bd81","user":{"login":"ARM-software","id":5690313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":13740589,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0MDU4OQ==","name":"arm-trusted-firmware","full_name":"ARM-software/arm-trusted-firmware","private":false,"owner":{"login":"ARM-software","id":5690313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARM-software/arm-trusted-firmware","description":"Trusted Firmware-A","fork":false,"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/deployments","created_at":"2013-10-21T11:39:00Z","updated_at":"2018-10-16T15:02:52Z","pushed_at":"2018-10-16T15:17:26Z","git_url":"git://github.com/ARM-software/arm-trusted-firmware.git","ssh_url":"git@github.com:ARM-software/arm-trusted-firmware.git","clone_url":"https://github.com/ARM-software/arm-trusted-firmware.git","svn_url":"https://github.com/ARM-software/arm-trusted-firmware","homepage":"","size":15505,"stargazers_count":667,"watchers_count":667,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":571,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":571,"open_issues":15,"watchers":667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1633"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1633"},"issue":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1633"},"comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1633/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1633/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1633/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/1d2aab92c7e896106bd10733cdf2082d9c2505a4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"smaeul"}}