{"action":"created","issue":{"url":"https://api.github.com/repos/cqframework/clinical_quality_language/issues/308","repository_url":"https://api.github.com/repos/cqframework/clinical_quality_language","labels_url":"https://api.github.com/repos/cqframework/clinical_quality_language/issues/308/labels{/name}","comments_url":"https://api.github.com/repos/cqframework/clinical_quality_language/issues/308/comments","events_url":"https://api.github.com/repos/cqframework/clinical_quality_language/issues/308/events","html_url":"https://github.com/cqframework/clinical_quality_language/pull/308","id":304565763,"number":308,"title":"Fix 195 ucum validation","user":{"login":"brynrhodes","id":6983498,"avatar_url":"https://avatars3.githubusercontent.com/u/6983498?v=4","gravatar_id":"","url":"https://api.github.com/users/brynrhodes","html_url":"https://github.com/brynrhodes","followers_url":"https://api.github.com/users/brynrhodes/followers","following_url":"https://api.github.com/users/brynrhodes/following{/other_user}","gists_url":"https://api.github.com/users/brynrhodes/gists{/gist_id}","starred_url":"https://api.github.com/users/brynrhodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brynrhodes/subscriptions","organizations_url":"https://api.github.com/users/brynrhodes/orgs","repos_url":"https://api.github.com/users/brynrhodes/repos","events_url":"https://api.github.com/users/brynrhodes/events{/privacy}","received_events_url":"https://api.github.com/users/brynrhodes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-12T22:38:05Z","updated_at":"2018-03-13T15:10:29Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cqframework/clinical_quality_language/pulls/308","html_url":"https://github.com/cqframework/clinical_quality_language/pull/308","diff_url":"https://github.com/cqframework/clinical_quality_language/pull/308.diff","patch_url":"https://github.com/cqframework/clinical_quality_language/pull/308.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/cqframework/clinical_quality_language/issues/comments/372699566","html_url":"https://github.com/cqframework/clinical_quality_language/pull/308#issuecomment-372699566","issue_url":"https://api.github.com/repos/cqframework/clinical_quality_language/issues/308","id":372699566,"user":{"login":"cmoesel","id":2278253,"avatar_url":"https://avatars1.githubusercontent.com/u/2278253?v=4","gravatar_id":"","url":"https://api.github.com/users/cmoesel","html_url":"https://github.com/cmoesel","followers_url":"https://api.github.com/users/cmoesel/followers","following_url":"https://api.github.com/users/cmoesel/following{/other_user}","gists_url":"https://api.github.com/users/cmoesel/gists{/gist_id}","starred_url":"https://api.github.com/users/cmoesel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmoesel/subscriptions","organizations_url":"https://api.github.com/users/cmoesel/orgs","repos_url":"https://api.github.com/users/cmoesel/repos","events_url":"https://api.github.com/users/cmoesel/events{/privacy}","received_events_url":"https://api.github.com/users/cmoesel/received_events","type":"User","site_admin":false},"created_at":"2018-03-13T15:10:29Z","updated_at":"2018-03-13T15:10:29Z","author_association":"OWNER","body":"Haven't tried it, but in general it looks sound.  I'd consider adding some tests for the combinatorial or other special representations, such as fractional units (e.g., `mg/dL`), squared units (e.g., `mm2`), \"per\" units (e.g., `/mg`), multiplicative units (e.g., `10*3`), etc.\r\n\r\nAlso, I think we've indicated that _no units_ should be treated like `1`.  What happens if you try to validate a unit that is `null` or empty string?  I don't see any special case code for that."}}
{"actor":{"display_login":"cmoesel"}}