{"action":"created","comment":{"url":"https://api.github.com/repos/Metaswitch/sprout/pulls/comments/167553763","pull_request_review_id":95753357,"id":167553763,"diff_hunk":"@@ -663,6 +699,24 @@ TEST_F(GetSubscriptionsTest, TwoSubscriptions)\n   EXPECT_TRUE(document[\"subscriptions\"].HasMember(\"789\"));\n }\n \n+// Test getting an IMPU when the local store is down.\n+TEST_F(GetSubscriptionsTest, LocalStoreDown)","path":"src/ut/handlers_test.cpp","position":147,"original_position":147,"commit_id":"375ef3f7d893e500a3aebe47d7870beee87ce1ee","original_commit_id":"375ef3f7d893e500a3aebe47d7870beee87ce1ee","user":{"login":"sathiyan-sivathas","id":20167729,"avatar_url":"https://avatars2.githubusercontent.com/u/20167729?v=4","gravatar_id":"","url":"https://api.github.com/users/sathiyan-sivathas","html_url":"https://github.com/sathiyan-sivathas","followers_url":"https://api.github.com/users/sathiyan-sivathas/followers","following_url":"https://api.github.com/users/sathiyan-sivathas/following{/other_user}","gists_url":"https://api.github.com/users/sathiyan-sivathas/gists{/gist_id}","starred_url":"https://api.github.com/users/sathiyan-sivathas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathiyan-sivathas/subscriptions","organizations_url":"https://api.github.com/users/sathiyan-sivathas/orgs","repos_url":"https://api.github.com/users/sathiyan-sivathas/repos","events_url":"https://api.github.com/users/sathiyan-sivathas/events{/privacy}","received_events_url":"https://api.github.com/users/sathiyan-sivathas/received_events","type":"User","site_admin":false},"body":"This test doesn't talk to the local store anymore. Can you rename it so something about SM returning an error e.g. `SubscriberManagerFails.`","created_at":"2018-02-12T13:25:01Z","updated_at":"2018-02-12T13:42:42Z","html_url":"https://github.com/Metaswitch/sprout/pull/2125#discussion_r167553763","pull_request_url":"https://api.github.com/repos/Metaswitch/sprout/pulls/2125","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/comments/167553763"},"html":{"href":"https://github.com/Metaswitch/sprout/pull/2125#discussion_r167553763"},"pull_request":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/2125"}}},"pull_request":{"url":"https://api.github.com/repos/Metaswitch/sprout/pulls/2125","id":166355324,"html_url":"https://github.com/Metaswitch/sprout/pull/2125","diff_url":"https://github.com/Metaswitch/sprout/pull/2125.diff","patch_url":"https://github.com/Metaswitch/sprout/pull/2125.patch","issue_url":"https://api.github.com/repos/Metaswitch/sprout/issues/2125","number":2125,"state":"open","locked":false,"title":"Handlers markup","user":{"login":"Ying-metaswitch","id":25749179,"avatar_url":"https://avatars2.githubusercontent.com/u/25749179?v=4","gravatar_id":"","url":"https://api.github.com/users/Ying-metaswitch","html_url":"https://github.com/Ying-metaswitch","followers_url":"https://api.github.com/users/Ying-metaswitch/followers","following_url":"https://api.github.com/users/Ying-metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Ying-metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Ying-metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ying-metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Ying-metaswitch/orgs","repos_url":"https://api.github.com/users/Ying-metaswitch/repos","events_url":"https://api.github.com/users/Ying-metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Ying-metaswitch/received_events","type":"User","site_admin":false},"body":"Hey Sathiyan thanks for reviewing the handlers. This PR is for the markups.\r\n\r\n1. All the UT that shouldn't be deleted have been put back\r\n2. `extract_impu` becomes a helper function;\r\n    all comments in header file has been updated;\r\n    `MockWithSM` inherits from `BaseTest` instead of `SipTest`;\r\n    SM clients clear map of pointers in Bindings\r\n3. Other markups as instructed\r\n\r\nMemory leak in send_notifys and possible leak in SM UT, which don't seem to be mine.","created_at":"2018-01-31T19:34:45Z","updated_at":"2018-02-12T13:42:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d38749b51701dffce73afff665fb6fcc778ed2b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/sprout/pulls/2125/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/sprout/pulls/2125/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/sprout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/sprout/issues/2125/comments","statuses_url":"https://api.github.com/repos/Metaswitch/sprout/statuses/375ef3f7d893e500a3aebe47d7870beee87ce1ee","head":{"label":"Metaswitch:handlers_markup","ref":"handlers_markup","sha":"375ef3f7d893e500a3aebe47d7870beee87ce1ee","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9887542,"name":"sprout","full_name":"Metaswitch/sprout","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/sprout","description":"sprout and bono, the Clearwater SIP router and edge proxy","fork":false,"url":"https://api.github.com/repos/Metaswitch/sprout","forks_url":"https://api.github.com/repos/Metaswitch/sprout/forks","keys_url":"https://api.github.com/repos/Metaswitch/sprout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/sprout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/sprout/teams","hooks_url":"https://api.github.com/repos/Metaswitch/sprout/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/sprout/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/sprout/events","assignees_url":"https://api.github.com/repos/Metaswitch/sprout/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/sprout/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/sprout/tags","blobs_url":"https://api.github.com/repos/Metaswitch/sprout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/sprout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/sprout/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/sprout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/sprout/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/sprout/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/sprout/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/sprout/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/sprout/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/sprout/subscription","commits_url":"https://api.github.com/repos/Metaswitch/sprout/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/sprout/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/sprout/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/sprout/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/sprout/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/sprout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/sprout/merges","archive_url":"https://api.github.com/repos/Metaswitch/sprout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/sprout/downloads","issues_url":"https://api.github.com/repos/Metaswitch/sprout/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/sprout/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/sprout/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/sprout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/sprout/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/sprout/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/sprout/deployments","created_at":"2013-05-06T13:37:07Z","updated_at":"2018-01-30T14:20:11Z","pushed_at":"2018-02-12T12:05:56Z","git_url":"git://github.com/Metaswitch/sprout.git","ssh_url":"git@github.com:Metaswitch/sprout.git","clone_url":"https://github.com/Metaswitch/sprout.git","svn_url":"https://github.com/Metaswitch/sprout","homepage":null,"size":33780,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":30,"open_issues":177,"watchers":25,"default_branch":"dev"}},"base":{"label":"Metaswitch:sdm-refactor-integration","ref":"sdm-refactor-integration","sha":"2b4f536ee04040dddc98261d37e8e238e2a87087","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9887542,"name":"sprout","full_name":"Metaswitch/sprout","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/sprout","description":"sprout and bono, the Clearwater SIP router and edge proxy","fork":false,"url":"https://api.github.com/repos/Metaswitch/sprout","forks_url":"https://api.github.com/repos/Metaswitch/sprout/forks","keys_url":"https://api.github.com/repos/Metaswitch/sprout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/sprout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/sprout/teams","hooks_url":"https://api.github.com/repos/Metaswitch/sprout/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/sprout/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/sprout/events","assignees_url":"https://api.github.com/repos/Metaswitch/sprout/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/sprout/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/sprout/tags","blobs_url":"https://api.github.com/repos/Metaswitch/sprout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/sprout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/sprout/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/sprout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/sprout/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/sprout/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/sprout/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/sprout/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/sprout/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/sprout/subscription","commits_url":"https://api.github.com/repos/Metaswitch/sprout/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/sprout/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/sprout/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/sprout/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/sprout/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/sprout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/sprout/merges","archive_url":"https://api.github.com/repos/Metaswitch/sprout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/sprout/downloads","issues_url":"https://api.github.com/repos/Metaswitch/sprout/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/sprout/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/sprout/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/sprout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/sprout/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/sprout/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/sprout/deployments","created_at":"2013-05-06T13:37:07Z","updated_at":"2018-01-30T14:20:11Z","pushed_at":"2018-02-12T12:05:56Z","git_url":"git://github.com/Metaswitch/sprout.git","ssh_url":"git@github.com:Metaswitch/sprout.git","clone_url":"https://github.com/Metaswitch/sprout.git","svn_url":"https://github.com/Metaswitch/sprout","homepage":null,"size":33780,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":30,"open_issues":177,"watchers":25,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/2125"},"html":{"href":"https://github.com/Metaswitch/sprout/pull/2125"},"issue":{"href":"https://api.github.com/repos/Metaswitch/sprout/issues/2125"},"comments":{"href":"https://api.github.com/repos/Metaswitch/sprout/issues/2125/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/2125/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/2125/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/sprout/statuses/375ef3f7d893e500a3aebe47d7870beee87ce1ee"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sathiyan-sivathas"}}