{"action":"closed","number":8913,"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/8913","id":241764721,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNzY0NzIx","html_url":"https://github.com/pingcap/tidb/pull/8913","diff_url":"https://github.com/pingcap/tidb/pull/8913.diff","patch_url":"https://github.com/pingcap/tidb/pull/8913.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/8913","number":8913,"state":"closed","locked":false,"title":"docs: add comments about why update statement using writable columns.","user":{"login":"winkyao","id":6949944,"node_id":"MDQ6VXNlcjY5NDk5NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6949944?v=4","gravatar_id":"","url":"https://api.github.com/users/winkyao","html_url":"https://github.com/winkyao","followers_url":"https://api.github.com/users/winkyao/followers","following_url":"https://api.github.com/users/winkyao/following{/other_user}","gists_url":"https://api.github.com/users/winkyao/gists{/gist_id}","starred_url":"https://api.github.com/users/winkyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winkyao/subscriptions","organizations_url":"https://api.github.com/users/winkyao/orgs","repos_url":"https://api.github.com/users/winkyao/repos","events_url":"https://api.github.com/users/winkyao/events{/privacy}","received_events_url":"https://api.github.com/users/winkyao/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n### What problem does this PR solve? <!--add issue link with summary if exists-->\r\n\r\nExplain why the update statement using the writable columns.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pingcap/tidb/8913)\n<!-- Reviewable:end -->\n","created_at":"2019-01-02T14:49:56Z","updated_at":"2019-01-03T06:55:15Z","closed_at":"2019-01-03T06:55:15Z","merged_at":"2019-01-03T06:55:15Z","merge_commit_sha":"235d04c5e9d90408b5f198c18abd52d6f02ff333","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":660746213,"node_id":"MDU6TGFiZWw2NjA3NDYyMTM=","url":"https://api.github.com/repos/pingcap/tidb/labels/component/docs","name":"component/docs","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/8913/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/8913/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/8913/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/8527236bb410fb2ee99c2dc18ac521cf87cd7dad","head":{"label":"winkyao:add_some_comments","ref":"add_some_comments","sha":"8527236bb410fb2ee99c2dc18ac521cf87cd7dad","user":{"login":"winkyao","id":6949944,"node_id":"MDQ6VXNlcjY5NDk5NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6949944?v=4","gravatar_id":"","url":"https://api.github.com/users/winkyao","html_url":"https://github.com/winkyao","followers_url":"https://api.github.com/users/winkyao/followers","following_url":"https://api.github.com/users/winkyao/following{/other_user}","gists_url":"https://api.github.com/users/winkyao/gists{/gist_id}","starred_url":"https://api.github.com/users/winkyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winkyao/subscriptions","organizations_url":"https://api.github.com/users/winkyao/orgs","repos_url":"https://api.github.com/users/winkyao/repos","events_url":"https://api.github.com/users/winkyao/events{/privacy}","received_events_url":"https://api.github.com/users/winkyao/received_events","type":"User","site_admin":false},"repo":{"id":107374778,"node_id":"MDEwOlJlcG9zaXRvcnkxMDczNzQ3Nzg=","name":"tidb","full_name":"winkyao/tidb","private":false,"owner":{"login":"winkyao","id":6949944,"node_id":"MDQ6VXNlcjY5NDk5NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6949944?v=4","gravatar_id":"","url":"https://api.github.com/users/winkyao","html_url":"https://github.com/winkyao","followers_url":"https://api.github.com/users/winkyao/followers","following_url":"https://api.github.com/users/winkyao/following{/other_user}","gists_url":"https://api.github.com/users/winkyao/gists{/gist_id}","starred_url":"https://api.github.com/users/winkyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winkyao/subscriptions","organizations_url":"https://api.github.com/users/winkyao/orgs","repos_url":"https://api.github.com/users/winkyao/repos","events_url":"https://api.github.com/users/winkyao/events{/privacy}","received_events_url":"https://api.github.com/users/winkyao/received_events","type":"User","site_admin":false},"html_url":"https://github.com/winkyao/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/winkyao/tidb","forks_url":"https://api.github.com/repos/winkyao/tidb/forks","keys_url":"https://api.github.com/repos/winkyao/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/winkyao/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/winkyao/tidb/teams","hooks_url":"https://api.github.com/repos/winkyao/tidb/hooks","issue_events_url":"https://api.github.com/repos/winkyao/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/winkyao/tidb/events","assignees_url":"https://api.github.com/repos/winkyao/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/winkyao/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/winkyao/tidb/tags","blobs_url":"https://api.github.com/repos/winkyao/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/winkyao/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/winkyao/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/winkyao/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/winkyao/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/winkyao/tidb/languages","stargazers_url":"https://api.github.com/repos/winkyao/tidb/stargazers","contributors_url":"https://api.github.com/repos/winkyao/tidb/contributors","subscribers_url":"https://api.github.com/repos/winkyao/tidb/subscribers","subscription_url":"https://api.github.com/repos/winkyao/tidb/subscription","commits_url":"https://api.github.com/repos/winkyao/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/winkyao/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/winkyao/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/winkyao/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/winkyao/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/winkyao/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/winkyao/tidb/merges","archive_url":"https://api.github.com/repos/winkyao/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/winkyao/tidb/downloads","issues_url":"https://api.github.com/repos/winkyao/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/winkyao/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/winkyao/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/winkyao/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/winkyao/tidb/labels{/name}","releases_url":"https://api.github.com/repos/winkyao/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/winkyao/tidb/deployments","created_at":"2017-10-18T07:41:20Z","updated_at":"2018-07-23T15:44:51Z","pushed_at":"2019-01-03T06:17:30Z","git_url":"git://github.com/winkyao/tidb.git","ssh_url":"git@github.com:winkyao/tidb.git","clone_url":"https://github.com/winkyao/tidb.git","svn_url":"https://github.com/winkyao/tidb","homepage":"https://pingcap.com","size":67770,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"32cfaf1dcc74fe627d67facebc92150b84b3deaf","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2019-01-03T05:50:28Z","pushed_at":"2019-01-03T06:55:15Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":124028,"stargazers_count":16697,"watchers_count":16697,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2395,"mirror_url":null,"archived":false,"open_issues_count":645,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2395,"open_issues":645,"watchers":16697,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/8913"},"html":{"href":"https://github.com/pingcap/tidb/pull/8913"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/8913"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/8913/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/8913/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/8913/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/8527236bb410fb2ee99c2dc18ac521cf87cd7dad"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"winkyao","id":6949944,"node_id":"MDQ6VXNlcjY5NDk5NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6949944?v=4","gravatar_id":"","url":"https://api.github.com/users/winkyao","html_url":"https://github.com/winkyao","followers_url":"https://api.github.com/users/winkyao/followers","following_url":"https://api.github.com/users/winkyao/following{/other_user}","gists_url":"https://api.github.com/users/winkyao/gists{/gist_id}","starred_url":"https://api.github.com/users/winkyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winkyao/subscriptions","organizations_url":"https://api.github.com/users/winkyao/orgs","repos_url":"https://api.github.com/users/winkyao/repos","events_url":"https://api.github.com/users/winkyao/events{/privacy}","received_events_url":"https://api.github.com/users/winkyao/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":7,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"winkyao"}}