{"action":"closed","number":26329,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26329","id":224471156,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDcxMTU2","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26329","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26329.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26329.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26329","number":26329,"state":"closed","locked":false,"title":"Even if an input event has been filtered, it should still set the dialog cursor","user":{"login":"FeepingCreature","id":540727,"node_id":"MDQ6VXNlcjU0MDcyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/540727?v=4","gravatar_id":"","url":"https://api.github.com/users/FeepingCreature","html_url":"https://github.com/FeepingCreature","followers_url":"https://api.github.com/users/FeepingCreature/followers","following_url":"https://api.github.com/users/FeepingCreature/following{/other_user}","gists_url":"https://api.github.com/users/FeepingCreature/gists{/gist_id}","starred_url":"https://api.github.com/users/FeepingCreature/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FeepingCreature/subscriptions","organizations_url":"https://api.github.com/users/FeepingCreature/orgs","repos_url":"https://api.github.com/users/FeepingCreature/repos","events_url":"https://api.github.com/users/FeepingCreature/events{/privacy}","received_events_url":"https://api.github.com/users/FeepingCreature/received_events","type":"User","site_admin":false},"body":"<!--\r\n### How to use\r\nLeave the headings unless they don't apply to your PR, replace commented out text ( surrounded with <!-- and -​-> ) with text describing your PR.\r\n-->\r\n\r\n#### Summary\r\n```SUMMARY: Interface \"Even when only capital inputs are allowed, using lowercase inputs should still set the dialog cursor.\"```\r\n<!--\r\nA one-line description of your change that will be extracted and added to the project changelog at https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/changelog.txt\r\nThe format is: ```SUMMARY: Category \"description\"```  \r\nThe categories to choose from are: Features, Content, Interface, Mods, Balance, Bugfixes, Performance, Infrastructure, Build, I18N  \r\nExample: ```SUMMARY: Content \"Adds new mutation category 'Mouse'\"```\r\nSee the Changelog Guidelines at https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/CHANGELOG_GUIDELINES.md for explanations of the categories.\r\n-->\r\n\r\n#### Purpose of change\r\nWhen pressing y/n in a dialog where lowercase inputs are disabled, the inputs should still set the dialog cursor to the respective choice.\r\n<!--\r\nIf there's an existing issue describing the problem this PR addresses or the feature it adds, please link it like: ```#1234```  \r\nIf it *fully* resolves an issue, link it like: ```Fixes #1234```  \r\nEven if the issue describes the problem, please provide a few-sentence summary here.  \r\nExample: ```Fixes #1234 - XL mutants cannot wear arm/leg splints due to missing OVERSIZE flag.```  \r\nIf there is no related issue, please describe the issue you are addressing, including how to trigger a bug if this is a bugfix.\r\n-->\r\n\r\n#### Describe the solution\r\n<!--\r\nHow does the feature work, or how does this fix a bug?  \r\nThe easier you make your solution to understand, the faster it can get merged.\r\n-->\r\n\r\n#### Describe alternatives you've considered\r\n<!--\r\nA clear and concise description of any alternative solutions or features you've considered.\r\n-->\r\n\r\n#### Additional context\r\nIt's _really_ hard to get used to, to see \"(Y)es (N)o\" and y/n does _nothing_. The point of not immediately proceeding with y/n is to require the player to confirm the action; this does that, but also gives the player a visible and useful reaction to their lowercase keypress.\r\n<!--\r\nAdd any other context (such as mock-ups, proof of concepts or screenshots) about the feature or bugfix here. \r\n-->\r\n","created_at":"2018-10-20T12:10:11Z","updated_at":"2018-10-21T15:45:23Z","closed_at":"2018-10-21T15:45:23Z","merged_at":"2018-10-21T15:45:22Z","merge_commit_sha":"5cf860b86f7502ebe90b0454e244fd902227816c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26329/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26329/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26329/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/7a7bec0d08a72d42616ed52efcc19a97fa04ca1f","head":{"label":"FeepingCreature:feature/set-position-from-input-even-if-filtered","ref":"feature/set-position-from-input-even-if-filtered","sha":"7a7bec0d08a72d42616ed52efcc19a97fa04ca1f","user":{"login":"FeepingCreature","id":540727,"node_id":"MDQ6VXNlcjU0MDcyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/540727?v=4","gravatar_id":"","url":"https://api.github.com/users/FeepingCreature","html_url":"https://github.com/FeepingCreature","followers_url":"https://api.github.com/users/FeepingCreature/followers","following_url":"https://api.github.com/users/FeepingCreature/following{/other_user}","gists_url":"https://api.github.com/users/FeepingCreature/gists{/gist_id}","starred_url":"https://api.github.com/users/FeepingCreature/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FeepingCreature/subscriptions","organizations_url":"https://api.github.com/users/FeepingCreature/orgs","repos_url":"https://api.github.com/users/FeepingCreature/repos","events_url":"https://api.github.com/users/FeepingCreature/events{/privacy}","received_events_url":"https://api.github.com/users/FeepingCreature/received_events","type":"User","site_admin":false},"repo":{"id":153853012,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM4NTMwMTI=","name":"Cataclysm-DDA","full_name":"FeepingCreature/Cataclysm-DDA","private":false,"owner":{"login":"FeepingCreature","id":540727,"node_id":"MDQ6VXNlcjU0MDcyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/540727?v=4","gravatar_id":"","url":"https://api.github.com/users/FeepingCreature","html_url":"https://github.com/FeepingCreature","followers_url":"https://api.github.com/users/FeepingCreature/followers","following_url":"https://api.github.com/users/FeepingCreature/following{/other_user}","gists_url":"https://api.github.com/users/FeepingCreature/gists{/gist_id}","starred_url":"https://api.github.com/users/FeepingCreature/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FeepingCreature/subscriptions","organizations_url":"https://api.github.com/users/FeepingCreature/orgs","repos_url":"https://api.github.com/users/FeepingCreature/repos","events_url":"https://api.github.com/users/FeepingCreature/events{/privacy}","received_events_url":"https://api.github.com/users/FeepingCreature/received_events","type":"User","site_admin":false},"html_url":"https://github.com/FeepingCreature/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":true,"url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA","forks_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/FeepingCreature/Cataclysm-DDA/deployments","created_at":"2018-10-19T23:46:43Z","updated_at":"2018-10-19T23:46:58Z","pushed_at":"2018-10-21T15:21:40Z","git_url":"git://github.com/FeepingCreature/Cataclysm-DDA.git","ssh_url":"git@github.com:FeepingCreature/Cataclysm-DDA.git","clone_url":"https://github.com/FeepingCreature/Cataclysm-DDA.git","svn_url":"https://github.com/FeepingCreature/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1355216,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"72b502ce960d4b58596953349fcfd21f1a710836","user":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"node_id":"MDEwOlJlcG9zaXRvcnk1OTczODU1","name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","private":false,"owner":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2018-10-21T15:43:10Z","pushed_at":"2018-10-21T15:45:22Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1355731,"stargazers_count":2195,"watchers_count":2195,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1465,"mirror_url":null,"archived":false,"open_issues_count":1051,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1465,"open_issues":1051,"watchers":2195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26329"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26329"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26329"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26329/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26329/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26329/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/7a7bec0d08a72d42616ed52efcc19a97fa04ca1f"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ZhilkinSerg","id":16213433,"node_id":"MDQ6VXNlcjE2MjEzNDMz","avatar_url":"https://avatars0.githubusercontent.com/u/16213433?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhilkinSerg","html_url":"https://github.com/ZhilkinSerg","followers_url":"https://api.github.com/users/ZhilkinSerg/followers","following_url":"https://api.github.com/users/ZhilkinSerg/following{/other_user}","gists_url":"https://api.github.com/users/ZhilkinSerg/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhilkinSerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhilkinSerg/subscriptions","organizations_url":"https://api.github.com/users/ZhilkinSerg/orgs","repos_url":"https://api.github.com/users/ZhilkinSerg/repos","events_url":"https://api.github.com/users/ZhilkinSerg/events{/privacy}","received_events_url":"https://api.github.com/users/ZhilkinSerg/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"ZhilkinSerg"}}