{"action":"created","issue":{"url":"https://api.github.com/repos/Khan/aphrodite/issues/22","repository_url":"https://api.github.com/repos/Khan/aphrodite","labels_url":"https://api.github.com/repos/Khan/aphrodite/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/Khan/aphrodite/issues/22/comments","events_url":"https://api.github.com/repos/Khan/aphrodite/issues/22/events","html_url":"https://github.com/Khan/aphrodite/pull/22","id":134573688,"node_id":"MDExOlB1bGxSZXF1ZXN0NTk3OTQzNjI=","number":22,"title":"remove need for `StyleSheet.create`","user":{"login":"montemishkin","id":12076775,"node_id":"MDQ6VXNlcjEyMDc2Nzc1","avatar_url":"https://avatars2.githubusercontent.com/u/12076775?v=4","gravatar_id":"","url":"https://api.github.com/users/montemishkin","html_url":"https://github.com/montemishkin","followers_url":"https://api.github.com/users/montemishkin/followers","following_url":"https://api.github.com/users/montemishkin/following{/other_user}","gists_url":"https://api.github.com/users/montemishkin/gists{/gist_id}","starred_url":"https://api.github.com/users/montemishkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montemishkin/subscriptions","organizations_url":"https://api.github.com/users/montemishkin/orgs","repos_url":"https://api.github.com/users/montemishkin/repos","events_url":"https://api.github.com/users/montemishkin/events{/privacy}","received_events_url":"https://api.github.com/users/montemishkin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-02-18T12:54:17Z","updated_at":"2018-06-28T03:50:43Z","closed_at":"2016-02-18T22:01:44Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Khan/aphrodite/pulls/22","html_url":"https://github.com/Khan/aphrodite/pull/22","diff_url":"https://github.com/Khan/aphrodite/pull/22.diff","patch_url":"https://github.com/Khan/aphrodite/pull/22.patch"},"body":"It seems to me that the `StyleSheet.create` api is unnecessary.  \n\nRemoving it would (among other things) simplify the api, and minimize the hassle for users considering moving over from libraries like [radium](https://github.com/FormidableLabs/radium) for example, where there are no calls to `StyleSheet.create` as far as the library user is concerned.\n\nSo far, this PR only contains the rather small changes to `src/index.js` needed to make things work without the call to `StyleSheet.create`.  \n\nI'm happy to fix up the (currently failing) test suite etc., but figured I would run the idea by you all before getting too far ahead.  After all, perhaps I'm missing some bigger picture, and `StyleSheet.create` is actually a good thing.\n\nBut it seems like it's totally not needed.\n\nOne thing to note is that these changes make it more difficult to track down the generated CSS class from your JS styles object (since the generated class name is no longer prefixed by the JS styles object key).\n"},"comment":{"url":"https://api.github.com/repos/Khan/aphrodite/issues/comments/400902428","html_url":"https://github.com/Khan/aphrodite/pull/22#issuecomment-400902428","issue_url":"https://api.github.com/repos/Khan/aphrodite/issues/22","id":400902428,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDkwMjQyOA==","user":{"login":"rxb","id":451050,"node_id":"MDQ6VXNlcjQ1MTA1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/451050?v=4","gravatar_id":"","url":"https://api.github.com/users/rxb","html_url":"https://github.com/rxb","followers_url":"https://api.github.com/users/rxb/followers","following_url":"https://api.github.com/users/rxb/following{/other_user}","gists_url":"https://api.github.com/users/rxb/gists{/gist_id}","starred_url":"https://api.github.com/users/rxb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxb/subscriptions","organizations_url":"https://api.github.com/users/rxb/orgs","repos_url":"https://api.github.com/users/rxb/repos","events_url":"https://api.github.com/users/rxb/events{/privacy}","received_events_url":"https://api.github.com/users/rxb/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T03:50:43Z","updated_at":"2018-06-28T03:50:43Z","author_association":"NONE","body":"Sorry for the noise, but just wanted to say thanks for choosing this approach. It made Aphrodite exactly the choice I needed. 🙌"}}
{"actor":{"display_login":"rxb"}}