{"action":"created","issue":{"url":"https://api.github.com/repos/Vaelek/node-google-shared-locations/issues/1","repository_url":"https://api.github.com/repos/Vaelek/node-google-shared-locations","labels_url":"https://api.github.com/repos/Vaelek/node-google-shared-locations/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/Vaelek/node-google-shared-locations/issues/1/comments","events_url":"https://api.github.com/repos/Vaelek/node-google-shared-locations/issues/1/events","html_url":"https://github.com/Vaelek/node-google-shared-locations/issues/1","id":379651315,"node_id":"MDU6SXNzdWUzNzk2NTEzMTU=","number":1,"title":"Fork (possible for version 2)","user":{"login":"atiris","id":10474618,"node_id":"MDQ6VXNlcjEwNDc0NjE4","avatar_url":"https://avatars0.githubusercontent.com/u/10474618?v=4","gravatar_id":"","url":"https://api.github.com/users/atiris","html_url":"https://github.com/atiris","followers_url":"https://api.github.com/users/atiris/followers","following_url":"https://api.github.com/users/atiris/following{/other_user}","gists_url":"https://api.github.com/users/atiris/gists{/gist_id}","starred_url":"https://api.github.com/users/atiris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atiris/subscriptions","organizations_url":"https://api.github.com/users/atiris/orgs","repos_url":"https://api.github.com/users/atiris/repos","events_url":"https://api.github.com/users/atiris/events{/privacy}","received_events_url":"https://api.github.com/users/atiris/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-12T07:23:18Z","updated_at":"2018-11-19T13:19:00Z","closed_at":null,"author_association":"NONE","body":"Hi, I created fork with updated multiple parts of [your code](<https://github.com/Vaelek/node-google-shared-locations>) and this one: [ioBroker.google-sharedlocations](<https://github.com/t4qjXH8N/ioBroker.google-sharedlocations/blob/master/main.js>).\r\n\r\nYou can [find it here](<https://github.com/atiris/node-google-shared-locations>). There might still be further changes.\r\n\r\nThere is many changes, unfortunately, I did not share them by individual committees. I just thought about using local ones first, but later I thought it might be useful for the whole library. In short, I did the following adjustments:\r\n\r\n- full async\r\n- some basic test (it would be good to add more)\r\n- testing script (like demo which users can call without having to write their own code)\r\n- added code for 2FA (only by mobile confirmation on android phone)\r\n- after successful login it is not possible to extract user password\r\n- output clean up (there is no reason to return duplicates)\r\n- extended output\r\n  - now with main user location (user id 0, some parts need to be set, maybe it is possible to detect, I don't know yet)\r\n  - phone battery status in output\r\n- better errors\r\n\r\nWould you accept these changes as a merge request? If not, I will set up my own fork repository. But I think these edits could also be version 2 of your current code. \r\n\r\nThanks for reply.\r\nJozef"},"comment":{"url":"https://api.github.com/repos/Vaelek/node-google-shared-locations/issues/comments/439889702","html_url":"https://github.com/Vaelek/node-google-shared-locations/issues/1#issuecomment-439889702","issue_url":"https://api.github.com/repos/Vaelek/node-google-shared-locations/issues/1","id":439889702,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTg4OTcwMg==","user":{"login":"atiris","id":10474618,"node_id":"MDQ6VXNlcjEwNDc0NjE4","avatar_url":"https://avatars0.githubusercontent.com/u/10474618?v=4","gravatar_id":"","url":"https://api.github.com/users/atiris","html_url":"https://github.com/atiris","followers_url":"https://api.github.com/users/atiris/followers","following_url":"https://api.github.com/users/atiris/following{/other_user}","gists_url":"https://api.github.com/users/atiris/gists{/gist_id}","starred_url":"https://api.github.com/users/atiris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atiris/subscriptions","organizations_url":"https://api.github.com/users/atiris/orgs","repos_url":"https://api.github.com/users/atiris/repos","events_url":"https://api.github.com/users/atiris/events{/privacy}","received_events_url":"https://api.github.com/users/atiris/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T13:19:00Z","updated_at":"2018-11-19T13:19:00Z","author_association":"NONE","body":"Because there is no development version here, I entered PR for the master. Please check if it's okay."}}
{"actor":{"display_login":"atiris"}}