{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/218999799","pull_request_review_id":157065842,"id":218999799,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODk5OTc5OQ==","diff_hunk":"@@ -151,3 +152,31 @@ SPECTRE_TEST_CASE(\"Unit.Utilities.StdArrayHelpers.map_array\",\n         return x;\n       }) == std::array<int, 1>{{4}});\n }\n+\n+namespace {\n+DEFINE_ARRAY_BINOP(int, int, int, operator+, std::plus<>())\n+DEFINE_ARRAY_BINOP(double, double, double, f, std::multiplies<>())\n+\n+DEFINE_ARRAY_INPLACE_BINOP(int, int, operator+=, std::plus<>())\n+DEFINE_ARRAY_INPLACE_BINOP(double, double, g, std::multiplies<>())\n+\n+SPECTRE_TEST_CASE(\"Unit.Utilities.StdArrayHelpers.define_array_binop\",\n+                  \"[Utilities][Unit]\") {\n+  CHECK(std::array<int, 2>{{1, 2}} + std::array<int, 2>{{2, 3}} ==\n+        std::array<int, 2>{{3, 5}});\n+  CHECK(\n+      f(std::array<double, 2>{{1.0, 2.0}}, std::array<double, 2>{{2.0, 3.0}}) ==\n+      std::array<double, 2>{{2.0, 6.0}});\n+}\n+\n+SPECTRE_TEST_CASE(\"Unit.Utilities.StdArrayHelpers.define_array_inplace_binop\",","path":"tests/Unit/Utilities/Test_StdArrayHelpers.cpp","position":29,"original_position":29,"commit_id":"a50d3638d6d79a6a7a28aca1bb0d49676a06067a","original_commit_id":"a50d3638d6d79a6a7a28aca1bb0d49676a06067a","user":{"login":"nilsdeppe","id":13531030,"node_id":"MDQ6VXNlcjEzNTMxMDMw","avatar_url":"https://avatars3.githubusercontent.com/u/13531030?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsdeppe","html_url":"https://github.com/nilsdeppe","followers_url":"https://api.github.com/users/nilsdeppe/followers","following_url":"https://api.github.com/users/nilsdeppe/following{/other_user}","gists_url":"https://api.github.com/users/nilsdeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsdeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsdeppe/subscriptions","organizations_url":"https://api.github.com/users/nilsdeppe/orgs","repos_url":"https://api.github.com/users/nilsdeppe/repos","events_url":"https://api.github.com/users/nilsdeppe/events{/privacy}","received_events_url":"https://api.github.com/users/nilsdeppe/received_events","type":"User","site_admin":false},"body":"Oh, sorry I missed this. Could you combine the TEST_CASEs into one? There's a decent overhead (1.2ish seconds) on supercomputers to start tests and having fewer cases will speed things up. ","created_at":"2018-09-19T23:57:10Z","updated_at":"2018-09-19T23:57:10Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/938#discussion_r218999799","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/938","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/218999799"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/938#discussion_r218999799"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/938"}}},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/938","id":215329596,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MzI5NTk2","html_url":"https://github.com/sxs-collaboration/spectre/pull/938","diff_url":"https://github.com/sxs-collaboration/spectre/pull/938.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/938.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/938","number":938,"state":"open","locked":false,"title":"Defined macros for easily defining operators on arrays","user":{"login":"moxcodes","id":32072858,"node_id":"MDQ6VXNlcjMyMDcyODU4","avatar_url":"https://avatars0.githubusercontent.com/u/32072858?v=4","gravatar_id":"","url":"https://api.github.com/users/moxcodes","html_url":"https://github.com/moxcodes","followers_url":"https://api.github.com/users/moxcodes/followers","following_url":"https://api.github.com/users/moxcodes/following{/other_user}","gists_url":"https://api.github.com/users/moxcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/moxcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxcodes/subscriptions","organizations_url":"https://api.github.com/users/moxcodes/orgs","repos_url":"https://api.github.com/users/moxcodes/repos","events_url":"https://api.github.com/users/moxcodes/events{/privacy}","received_events_url":"https://api.github.com/users/moxcodes/received_events","type":"User","site_admin":false},"body":"Added the two macros to StdArrayHelpers.hpp,\r\n`DEFINE_ARRAY_BINOP` and `DEFINE_ARRAY_INPLACE_BINOP` to\r\nconveniently define operators on arrays of arbitrary\r\nstorage types.\r\n\r\nThese macros are used in DataVector templatization [PR935](https://github.com/sxs-collaboration/spectre/pull/935)\r\n\r\n## Proposed changes\r\n\r\n<!--\r\nAt a high level, describe what this PR does.\r\n-->\r\n\r\n### Types of changes:\r\n\r\n- [ ] New feature\r\n\r\n### Component:\r\n\r\n- [ ] Code\r\n\r\n### Code review checklist\r\n\r\n- [ ] The PR passes all checks, including unit tests, `clang-tidy` and `IWYU`. For\r\n  instructions on how to perform the CI checks locally refer to the [Dev guide\r\n  on the Travis CI](https://spectre-code.org/travis_guide.html).\r\n- [ ] The code is documented and the documentation renders correctly. Run `make doc`\r\n  to generate the documentation locally into `BUILD_DIR/docs/html`. Then open\r\n  `index.html`.\r\n- [ ] The code follows the stylistic and code quality guidelines listed in the\r\n  [code review guide](https://spectre-code.org/code_review_guide.html).\r\n\r\n### Further comments\r\n\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by\r\nexplaining why you chose the solution you did and what alternatives you\r\nconsidered, etc...\r\n-->\r\n","created_at":"2018-09-13T15:47:29Z","updated_at":"2018-09-19T23:57:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1aeac3d3191bdfd9f4a552aad110ac0de1791ad8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/938/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/938/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/938/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/a50d3638d6d79a6a7a28aca1bb0d49676a06067a","head":{"label":"moxcodes:macroarrayops","ref":"macroarrayops","sha":"a50d3638d6d79a6a7a28aca1bb0d49676a06067a","user":{"login":"moxcodes","id":32072858,"node_id":"MDQ6VXNlcjMyMDcyODU4","avatar_url":"https://avatars0.githubusercontent.com/u/32072858?v=4","gravatar_id":"","url":"https://api.github.com/users/moxcodes","html_url":"https://github.com/moxcodes","followers_url":"https://api.github.com/users/moxcodes/followers","following_url":"https://api.github.com/users/moxcodes/following{/other_user}","gists_url":"https://api.github.com/users/moxcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/moxcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxcodes/subscriptions","organizations_url":"https://api.github.com/users/moxcodes/orgs","repos_url":"https://api.github.com/users/moxcodes/repos","events_url":"https://api.github.com/users/moxcodes/events{/privacy}","received_events_url":"https://api.github.com/users/moxcodes/received_events","type":"User","site_admin":false},"repo":{"id":147872565,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4NzI1NjU=","name":"spectre","full_name":"moxcodes/spectre","private":false,"owner":{"login":"moxcodes","id":32072858,"node_id":"MDQ6VXNlcjMyMDcyODU4","avatar_url":"https://avatars0.githubusercontent.com/u/32072858?v=4","gravatar_id":"","url":"https://api.github.com/users/moxcodes","html_url":"https://github.com/moxcodes","followers_url":"https://api.github.com/users/moxcodes/followers","following_url":"https://api.github.com/users/moxcodes/following{/other_user}","gists_url":"https://api.github.com/users/moxcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/moxcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxcodes/subscriptions","organizations_url":"https://api.github.com/users/moxcodes/orgs","repos_url":"https://api.github.com/users/moxcodes/repos","events_url":"https://api.github.com/users/moxcodes/events{/privacy}","received_events_url":"https://api.github.com/users/moxcodes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/moxcodes/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":true,"url":"https://api.github.com/repos/moxcodes/spectre","forks_url":"https://api.github.com/repos/moxcodes/spectre/forks","keys_url":"https://api.github.com/repos/moxcodes/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moxcodes/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moxcodes/spectre/teams","hooks_url":"https://api.github.com/repos/moxcodes/spectre/hooks","issue_events_url":"https://api.github.com/repos/moxcodes/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/moxcodes/spectre/events","assignees_url":"https://api.github.com/repos/moxcodes/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/moxcodes/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/moxcodes/spectre/tags","blobs_url":"https://api.github.com/repos/moxcodes/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moxcodes/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moxcodes/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/moxcodes/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moxcodes/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/moxcodes/spectre/languages","stargazers_url":"https://api.github.com/repos/moxcodes/spectre/stargazers","contributors_url":"https://api.github.com/repos/moxcodes/spectre/contributors","subscribers_url":"https://api.github.com/repos/moxcodes/spectre/subscribers","subscription_url":"https://api.github.com/repos/moxcodes/spectre/subscription","commits_url":"https://api.github.com/repos/moxcodes/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/moxcodes/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/moxcodes/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/moxcodes/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/moxcodes/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/moxcodes/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moxcodes/spectre/merges","archive_url":"https://api.github.com/repos/moxcodes/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moxcodes/spectre/downloads","issues_url":"https://api.github.com/repos/moxcodes/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/moxcodes/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/moxcodes/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/moxcodes/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moxcodes/spectre/labels{/name}","releases_url":"https://api.github.com/repos/moxcodes/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/moxcodes/spectre/deployments","created_at":"2018-09-07T20:39:07Z","updated_at":"2018-09-19T23:48:15Z","pushed_at":"2018-09-19T23:50:20Z","git_url":"git://github.com/moxcodes/spectre.git","ssh_url":"git@github.com:moxcodes/spectre.git","clone_url":"https://github.com/moxcodes/spectre.git","svn_url":"https://github.com/moxcodes/spectre","homepage":"","size":10538,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"ae2eaaa3469c61d60e1adb19f66799b6d23f5dc7","user":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3MDUxMA==","name":"spectre","full_name":"sxs-collaboration/spectre","private":false,"owner":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2018-09-19T22:34:25Z","pushed_at":"2018-09-19T23:50:22Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"","size":10736,"stargazers_count":27,"watchers_count":27,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":134,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":29,"open_issues":134,"watchers":27,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/938"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/938"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/938"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/938/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/938/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/938/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/a50d3638d6d79a6a7a28aca1bb0d49676a06067a"}},"author_association":"NONE"}}
{"actor":{"display_login":"nilsdeppe"}}