{"action":"created","issue":{"url":"https://api.github.com/repos/pf4j/pf4j/issues/273","repository_url":"https://api.github.com/repos/pf4j/pf4j","labels_url":"https://api.github.com/repos/pf4j/pf4j/issues/273/labels{/name}","comments_url":"https://api.github.com/repos/pf4j/pf4j/issues/273/comments","events_url":"https://api.github.com/repos/pf4j/pf4j/issues/273/events","html_url":"https://github.com/pf4j/pf4j/pull/273","id":396130479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyNDE4NTIw","number":273,"title":"ServiceProviderExtensionFinder should scan the whole classpath","user":{"login":"pinhead84","id":7954406,"node_id":"MDQ6VXNlcjc5NTQ0MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/7954406?v=4","gravatar_id":"","url":"https://api.github.com/users/pinhead84","html_url":"https://github.com/pinhead84","followers_url":"https://api.github.com/users/pinhead84/followers","following_url":"https://api.github.com/users/pinhead84/following{/other_user}","gists_url":"https://api.github.com/users/pinhead84/gists{/gist_id}","starred_url":"https://api.github.com/users/pinhead84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinhead84/subscriptions","organizations_url":"https://api.github.com/users/pinhead84/orgs","repos_url":"https://api.github.com/users/pinhead84/repos","events_url":"https://api.github.com/users/pinhead84/events{/privacy}","received_events_url":"https://api.github.com/users/pinhead84/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-01-05T03:54:22Z","updated_at":"2019-01-05T12:31:10Z","closed_at":"2019-01-05T12:30:57Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pf4j/pf4j/pulls/273","html_url":"https://github.com/pf4j/pf4j/pull/273","diff_url":"https://github.com/pf4j/pf4j/pull/273.diff","patch_url":"https://github.com/pf4j/pf4j/pull/273.patch"},"body":"This pull request fixes issue #272.\r\n\r\nSimilar to the implementation in [`LegacyExtensionFinder#readClasspathStorages()`](https://github.com/pf4j/pf4j/blob/39219b3ba4a8bc7c13e6ede8d7157518e266bba1/pf4j/src/main/java/org/pf4j/LegacyExtensionFinder.java#L49-L66) the `ServiceProviderExtensionFinder` should also iterate over all available `META-INF/services` directories (see [this commit](https://github.com/pf4j/pf4j/pull/273/commits/0f715f09e871d1920b891f53cded2c9562198d9c)).\r\n\r\nBesides this I made a little change to `LegacyExtensionFinder#readClasspathStorages()` in order to have a more consistent logging (see [this commit](https://github.com/pf4j/pf4j/pull/273/commits/d1500cd4c466cd9e16ae8710c6e6f82012edaffb))."},"comment":{"url":"https://api.github.com/repos/pf4j/pf4j/issues/comments/451651782","html_url":"https://github.com/pf4j/pf4j/pull/273#issuecomment-451651782","issue_url":"https://api.github.com/repos/pf4j/pf4j/issues/273","id":451651782,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTY1MTc4Mg==","user":{"login":"decebals","id":1248311,"node_id":"MDQ6VXNlcjEyNDgzMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1248311?v=4","gravatar_id":"","url":"https://api.github.com/users/decebals","html_url":"https://github.com/decebals","followers_url":"https://api.github.com/users/decebals/followers","following_url":"https://api.github.com/users/decebals/following{/other_user}","gists_url":"https://api.github.com/users/decebals/gists{/gist_id}","starred_url":"https://api.github.com/users/decebals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decebals/subscriptions","organizations_url":"https://api.github.com/users/decebals/orgs","repos_url":"https://api.github.com/users/decebals/repos","events_url":"https://api.github.com/users/decebals/events{/privacy}","received_events_url":"https://api.github.com/users/decebals/received_events","type":"User","site_admin":false},"created_at":"2019-01-05T12:31:10Z","updated_at":"2019-01-05T12:31:10Z","author_association":"MEMBER","body":"Thanks!"}}
{"actor":{"display_login":"decebals"}}