{"action":"opened","number":451,"pull_request":{"url":"https://api.github.com/repos/istio-releases/daily-release/pulls/451","id":173894790,"html_url":"https://github.com/istio-releases/daily-release/pull/451","diff_url":"https://github.com/istio-releases/daily-release/pull/451.diff","patch_url":"https://github.com/istio-releases/daily-release/pull/451.patch","issue_url":"https://api.github.com/repos/istio-releases/daily-release/issues/451","number":451,"state":"open","locked":false,"title":"Call make to trigger tests","user":{"login":"chxchx","id":11745975,"avatar_url":"https://avatars1.githubusercontent.com/u/11745975?v=4","gravatar_id":"","url":"https://api.github.com/users/chxchx","html_url":"https://github.com/chxchx","followers_url":"https://api.github.com/users/chxchx/followers","following_url":"https://api.github.com/users/chxchx/following{/other_user}","gists_url":"https://api.github.com/users/chxchx/gists{/gist_id}","starred_url":"https://api.github.com/users/chxchx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chxchx/subscriptions","organizations_url":"https://api.github.com/users/chxchx/orgs","repos_url":"https://api.github.com/users/chxchx/repos","events_url":"https://api.github.com/users/chxchx/events{/privacy}","received_events_url":"https://api.github.com/users/chxchx/received_events","type":"User","site_admin":false},"body":"After adding junit report to daily release jobs, we see similar issue encountered before such as failures masked by go-junit-report since its exit status is zero. We generate the junit report and handle issue as such in the makefile so the best approach is to call make to trigger the test. I changed EXTRA_E2E_ARGS to be configurable so we still have full control on the flags we use for the release.\r\n\r\nAlso ensure that we finish all the tests without stopping early on nonzero status.","created_at":"2018-03-09T01:11:36Z","updated_at":"2018-03-09T01:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio-releases/daily-release/pulls/451/commits","review_comments_url":"https://api.github.com/repos/istio-releases/daily-release/pulls/451/comments","review_comment_url":"https://api.github.com/repos/istio-releases/daily-release/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio-releases/daily-release/issues/451/comments","statuses_url":"https://api.github.com/repos/istio-releases/daily-release/statuses/24d0de178e2869990388aa20d12930f928b8dcc4","head":{"label":"istio-releases:fixjunit","ref":"fixjunit","sha":"24d0de178e2869990388aa20d12930f928b8dcc4","user":{"login":"istio-releases","id":29259397,"avatar_url":"https://avatars2.githubusercontent.com/u/29259397?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-releases","html_url":"https://github.com/istio-releases","followers_url":"https://api.github.com/users/istio-releases/followers","following_url":"https://api.github.com/users/istio-releases/following{/other_user}","gists_url":"https://api.github.com/users/istio-releases/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-releases/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-releases/subscriptions","organizations_url":"https://api.github.com/users/istio-releases/orgs","repos_url":"https://api.github.com/users/istio-releases/repos","events_url":"https://api.github.com/users/istio-releases/events{/privacy}","received_events_url":"https://api.github.com/users/istio-releases/received_events","type":"Organization","site_admin":false},"repo":{"id":110592722,"name":"daily-release","full_name":"istio-releases/daily-release","owner":{"login":"istio-releases","id":29259397,"avatar_url":"https://avatars2.githubusercontent.com/u/29259397?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-releases","html_url":"https://github.com/istio-releases","followers_url":"https://api.github.com/users/istio-releases/followers","following_url":"https://api.github.com/users/istio-releases/following{/other_user}","gists_url":"https://api.github.com/users/istio-releases/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-releases/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-releases/subscriptions","organizations_url":"https://api.github.com/users/istio-releases/orgs","repos_url":"https://api.github.com/users/istio-releases/repos","events_url":"https://api.github.com/users/istio-releases/events{/privacy}","received_events_url":"https://api.github.com/users/istio-releases/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio-releases/daily-release","description":null,"fork":false,"url":"https://api.github.com/repos/istio-releases/daily-release","forks_url":"https://api.github.com/repos/istio-releases/daily-release/forks","keys_url":"https://api.github.com/repos/istio-releases/daily-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio-releases/daily-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio-releases/daily-release/teams","hooks_url":"https://api.github.com/repos/istio-releases/daily-release/hooks","issue_events_url":"https://api.github.com/repos/istio-releases/daily-release/issues/events{/number}","events_url":"https://api.github.com/repos/istio-releases/daily-release/events","assignees_url":"https://api.github.com/repos/istio-releases/daily-release/assignees{/user}","branches_url":"https://api.github.com/repos/istio-releases/daily-release/branches{/branch}","tags_url":"https://api.github.com/repos/istio-releases/daily-release/tags","blobs_url":"https://api.github.com/repos/istio-releases/daily-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio-releases/daily-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio-releases/daily-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio-releases/daily-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio-releases/daily-release/statuses/{sha}","languages_url":"https://api.github.com/repos/istio-releases/daily-release/languages","stargazers_url":"https://api.github.com/repos/istio-releases/daily-release/stargazers","contributors_url":"https://api.github.com/repos/istio-releases/daily-release/contributors","subscribers_url":"https://api.github.com/repos/istio-releases/daily-release/subscribers","subscription_url":"https://api.github.com/repos/istio-releases/daily-release/subscription","commits_url":"https://api.github.com/repos/istio-releases/daily-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio-releases/daily-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio-releases/daily-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio-releases/daily-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio-releases/daily-release/contents/{+path}","compare_url":"https://api.github.com/repos/istio-releases/daily-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio-releases/daily-release/merges","archive_url":"https://api.github.com/repos/istio-releases/daily-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio-releases/daily-release/downloads","issues_url":"https://api.github.com/repos/istio-releases/daily-release/issues{/number}","pulls_url":"https://api.github.com/repos/istio-releases/daily-release/pulls{/number}","milestones_url":"https://api.github.com/repos/istio-releases/daily-release/milestones{/number}","notifications_url":"https://api.github.com/repos/istio-releases/daily-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio-releases/daily-release/labels{/name}","releases_url":"https://api.github.com/repos/istio-releases/daily-release/releases{/id}","deployments_url":"https://api.github.com/repos/istio-releases/daily-release/deployments","created_at":"2017-11-13T19:34:55Z","updated_at":"2018-02-22T14:17:14Z","pushed_at":"2018-03-09T01:11:00Z","git_url":"git://github.com/istio-releases/daily-release.git","ssh_url":"git@github.com:istio-releases/daily-release.git","clone_url":"https://github.com/istio-releases/daily-release.git","svn_url":"https://github.com/istio-releases/daily-release","homepage":null,"size":147,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":8,"watchers":1,"default_branch":"master"}},"base":{"label":"istio-releases:master","ref":"master","sha":"da0fd685ed2668f8d93bf477bc27a6aee2105020","user":{"login":"istio-releases","id":29259397,"avatar_url":"https://avatars2.githubusercontent.com/u/29259397?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-releases","html_url":"https://github.com/istio-releases","followers_url":"https://api.github.com/users/istio-releases/followers","following_url":"https://api.github.com/users/istio-releases/following{/other_user}","gists_url":"https://api.github.com/users/istio-releases/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-releases/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-releases/subscriptions","organizations_url":"https://api.github.com/users/istio-releases/orgs","repos_url":"https://api.github.com/users/istio-releases/repos","events_url":"https://api.github.com/users/istio-releases/events{/privacy}","received_events_url":"https://api.github.com/users/istio-releases/received_events","type":"Organization","site_admin":false},"repo":{"id":110592722,"name":"daily-release","full_name":"istio-releases/daily-release","owner":{"login":"istio-releases","id":29259397,"avatar_url":"https://avatars2.githubusercontent.com/u/29259397?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-releases","html_url":"https://github.com/istio-releases","followers_url":"https://api.github.com/users/istio-releases/followers","following_url":"https://api.github.com/users/istio-releases/following{/other_user}","gists_url":"https://api.github.com/users/istio-releases/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-releases/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-releases/subscriptions","organizations_url":"https://api.github.com/users/istio-releases/orgs","repos_url":"https://api.github.com/users/istio-releases/repos","events_url":"https://api.github.com/users/istio-releases/events{/privacy}","received_events_url":"https://api.github.com/users/istio-releases/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio-releases/daily-release","description":null,"fork":false,"url":"https://api.github.com/repos/istio-releases/daily-release","forks_url":"https://api.github.com/repos/istio-releases/daily-release/forks","keys_url":"https://api.github.com/repos/istio-releases/daily-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio-releases/daily-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio-releases/daily-release/teams","hooks_url":"https://api.github.com/repos/istio-releases/daily-release/hooks","issue_events_url":"https://api.github.com/repos/istio-releases/daily-release/issues/events{/number}","events_url":"https://api.github.com/repos/istio-releases/daily-release/events","assignees_url":"https://api.github.com/repos/istio-releases/daily-release/assignees{/user}","branches_url":"https://api.github.com/repos/istio-releases/daily-release/branches{/branch}","tags_url":"https://api.github.com/repos/istio-releases/daily-release/tags","blobs_url":"https://api.github.com/repos/istio-releases/daily-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio-releases/daily-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio-releases/daily-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio-releases/daily-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio-releases/daily-release/statuses/{sha}","languages_url":"https://api.github.com/repos/istio-releases/daily-release/languages","stargazers_url":"https://api.github.com/repos/istio-releases/daily-release/stargazers","contributors_url":"https://api.github.com/repos/istio-releases/daily-release/contributors","subscribers_url":"https://api.github.com/repos/istio-releases/daily-release/subscribers","subscription_url":"https://api.github.com/repos/istio-releases/daily-release/subscription","commits_url":"https://api.github.com/repos/istio-releases/daily-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio-releases/daily-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio-releases/daily-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio-releases/daily-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio-releases/daily-release/contents/{+path}","compare_url":"https://api.github.com/repos/istio-releases/daily-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio-releases/daily-release/merges","archive_url":"https://api.github.com/repos/istio-releases/daily-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio-releases/daily-release/downloads","issues_url":"https://api.github.com/repos/istio-releases/daily-release/issues{/number}","pulls_url":"https://api.github.com/repos/istio-releases/daily-release/pulls{/number}","milestones_url":"https://api.github.com/repos/istio-releases/daily-release/milestones{/number}","notifications_url":"https://api.github.com/repos/istio-releases/daily-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio-releases/daily-release/labels{/name}","releases_url":"https://api.github.com/repos/istio-releases/daily-release/releases{/id}","deployments_url":"https://api.github.com/repos/istio-releases/daily-release/deployments","created_at":"2017-11-13T19:34:55Z","updated_at":"2018-02-22T14:17:14Z","pushed_at":"2018-03-09T01:11:00Z","git_url":"git://github.com/istio-releases/daily-release.git","ssh_url":"git@github.com:istio-releases/daily-release.git","clone_url":"https://github.com/istio-releases/daily-release.git","svn_url":"https://github.com/istio-releases/daily-release","homepage":null,"size":147,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio-releases/daily-release/pulls/451"},"html":{"href":"https://github.com/istio-releases/daily-release/pull/451"},"issue":{"href":"https://api.github.com/repos/istio-releases/daily-release/issues/451"},"comments":{"href":"https://api.github.com/repos/istio-releases/daily-release/issues/451/comments"},"review_comments":{"href":"https://api.github.com/repos/istio-releases/daily-release/pulls/451/comments"},"review_comment":{"href":"https://api.github.com/repos/istio-releases/daily-release/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio-releases/daily-release/pulls/451/commits"},"statuses":{"href":"https://api.github.com/repos/istio-releases/daily-release/statuses/24d0de178e2869990388aa20d12930f928b8dcc4"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"chxchx"}}