{"action":"created","comment":{"url":"https://api.github.com/repos/bvaughn/react-virtualized/pulls/comments/186256502","pull_request_review_id":117808190,"id":186256502,"diff_hunk":"@@ -66,7 +69,7 @@ function onScrollWindow(event) {\n \n export function registerScrollListener(\n   component: WindowScroller,\n-  element: Element,\n+  element: any,","path":"source/WindowScroller/utils/onScroll.js","position":75,"original_position":75,"commit_id":"5843e07d74a6effddc7af7bfeb43b040b5c78224","original_commit_id":"5843e07d74a6effddc7af7bfeb43b040b5c78224","user":{"login":"wuweiweiwu","id":35270620,"avatar_url":"https://avatars3.githubusercontent.com/u/35270620?v=4","gravatar_id":"","url":"https://api.github.com/users/wuweiweiwu","html_url":"https://github.com/wuweiweiwu","followers_url":"https://api.github.com/users/wuweiweiwu/followers","following_url":"https://api.github.com/users/wuweiweiwu/following{/other_user}","gists_url":"https://api.github.com/users/wuweiweiwu/gists{/gist_id}","starred_url":"https://api.github.com/users/wuweiweiwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuweiweiwu/subscriptions","organizations_url":"https://api.github.com/users/wuweiweiwu/orgs","repos_url":"https://api.github.com/users/wuweiweiwu/repos","events_url":"https://api.github.com/users/wuweiweiwu/events{/privacy}","received_events_url":"https://api.github.com/users/wuweiweiwu/received_events","type":"User","site_admin":false},"body":"no `any`","created_at":"2018-05-05T08:31:25Z","updated_at":"2018-05-05T08:32:06Z","html_url":"https://github.com/bvaughn/react-virtualized/pull/1093#discussion_r186256502","pull_request_url":"https://api.github.com/repos/bvaughn/react-virtualized/pulls/1093","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/bvaughn/react-virtualized/pulls/comments/186256502"},"html":{"href":"https://github.com/bvaughn/react-virtualized/pull/1093#discussion_r186256502"},"pull_request":{"href":"https://api.github.com/repos/bvaughn/react-virtualized/pulls/1093"}}},"pull_request":{"url":"https://api.github.com/repos/bvaughn/react-virtualized/pulls/1093","id":185055156,"html_url":"https://github.com/bvaughn/react-virtualized/pull/1093","diff_url":"https://github.com/bvaughn/react-virtualized/pull/1093.diff","patch_url":"https://github.com/bvaughn/react-virtualized/pull/1093.patch","issue_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/1093","number":1093,"state":"open","locked":false,"title":"Support iframes with WindowScroller","user":{"login":"mkralla11","id":2223901,"avatar_url":"https://avatars1.githubusercontent.com/u/2223901?v=4","gravatar_id":"","url":"https://api.github.com/users/mkralla11","html_url":"https://github.com/mkralla11","followers_url":"https://api.github.com/users/mkralla11/followers","following_url":"https://api.github.com/users/mkralla11/following{/other_user}","gists_url":"https://api.github.com/users/mkralla11/gists{/gist_id}","starred_url":"https://api.github.com/users/mkralla11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkralla11/subscriptions","organizations_url":"https://api.github.com/users/mkralla11/orgs","repos_url":"https://api.github.com/users/mkralla11/repos","events_url":"https://api.github.com/users/mkralla11/events{/privacy}","received_events_url":"https://api.github.com/users/mkralla11/received_events","type":"User","site_admin":false},"body":"The WindowScroller should also be functional for use with iframes. Things to note:\r\n\r\n- [x] given a scrollElement of contentWindow provided by an iframe, container.document.documentElement, and element.document is used in place of the applicable document, respectively. \r\n- [x] Linter is 👍 \r\n- [ ] The needed changes cause tests to fail, and I have not found the appropriate fixes to address them. Any help would be thoroughly appreciated.\r\n- [ ] I satisfied the flow checker in a very naive way for a few cases, using `any` instead of the appropriate type because I couldn't find the correct types in the flow docs for documentElement and contentWindow (I apologize for this, I'm not a flow expert by any means).\r\n- Finally, I had to create a closure [here](https://github.com/bvaughn/react-virtualized/compare/master...mkralla11:iframe?expand=1#diff-781ced233be16fea033614f03e3054f2R25) to allow the document to be available for the given scope due to the way this module has been implemented already (not a huge issue, but I want to make sure it was known.)\r\n\r\n\r\nsolves issue https://github.com/bvaughn/react-virtualized/issues/1088\r\n\r\n\r\n","created_at":"2018-04-30T20:24:59Z","updated_at":"2018-05-05T08:32:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a79ac20947684fed23911e1d40298a6826f556a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bvaughn/react-virtualized/pulls/1093/commits","review_comments_url":"https://api.github.com/repos/bvaughn/react-virtualized/pulls/1093/comments","review_comment_url":"https://api.github.com/repos/bvaughn/react-virtualized/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/1093/comments","statuses_url":"https://api.github.com/repos/bvaughn/react-virtualized/statuses/5843e07d74a6effddc7af7bfeb43b040b5c78224","head":{"label":"mkralla11:iframe","ref":"iframe","sha":"5843e07d74a6effddc7af7bfeb43b040b5c78224","user":{"login":"mkralla11","id":2223901,"avatar_url":"https://avatars1.githubusercontent.com/u/2223901?v=4","gravatar_id":"","url":"https://api.github.com/users/mkralla11","html_url":"https://github.com/mkralla11","followers_url":"https://api.github.com/users/mkralla11/followers","following_url":"https://api.github.com/users/mkralla11/following{/other_user}","gists_url":"https://api.github.com/users/mkralla11/gists{/gist_id}","starred_url":"https://api.github.com/users/mkralla11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkralla11/subscriptions","organizations_url":"https://api.github.com/users/mkralla11/orgs","repos_url":"https://api.github.com/users/mkralla11/repos","events_url":"https://api.github.com/users/mkralla11/events{/privacy}","received_events_url":"https://api.github.com/users/mkralla11/received_events","type":"User","site_admin":false},"repo":{"id":131640984,"name":"react-virtualized","full_name":"mkralla11/react-virtualized","owner":{"login":"mkralla11","id":2223901,"avatar_url":"https://avatars1.githubusercontent.com/u/2223901?v=4","gravatar_id":"","url":"https://api.github.com/users/mkralla11","html_url":"https://github.com/mkralla11","followers_url":"https://api.github.com/users/mkralla11/followers","following_url":"https://api.github.com/users/mkralla11/following{/other_user}","gists_url":"https://api.github.com/users/mkralla11/gists{/gist_id}","starred_url":"https://api.github.com/users/mkralla11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkralla11/subscriptions","organizations_url":"https://api.github.com/users/mkralla11/orgs","repos_url":"https://api.github.com/users/mkralla11/repos","events_url":"https://api.github.com/users/mkralla11/events{/privacy}","received_events_url":"https://api.github.com/users/mkralla11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkralla11/react-virtualized","description":"React components for efficiently rendering large lists and tabular data","fork":true,"url":"https://api.github.com/repos/mkralla11/react-virtualized","forks_url":"https://api.github.com/repos/mkralla11/react-virtualized/forks","keys_url":"https://api.github.com/repos/mkralla11/react-virtualized/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkralla11/react-virtualized/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkralla11/react-virtualized/teams","hooks_url":"https://api.github.com/repos/mkralla11/react-virtualized/hooks","issue_events_url":"https://api.github.com/repos/mkralla11/react-virtualized/issues/events{/number}","events_url":"https://api.github.com/repos/mkralla11/react-virtualized/events","assignees_url":"https://api.github.com/repos/mkralla11/react-virtualized/assignees{/user}","branches_url":"https://api.github.com/repos/mkralla11/react-virtualized/branches{/branch}","tags_url":"https://api.github.com/repos/mkralla11/react-virtualized/tags","blobs_url":"https://api.github.com/repos/mkralla11/react-virtualized/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkralla11/react-virtualized/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkralla11/react-virtualized/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkralla11/react-virtualized/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkralla11/react-virtualized/statuses/{sha}","languages_url":"https://api.github.com/repos/mkralla11/react-virtualized/languages","stargazers_url":"https://api.github.com/repos/mkralla11/react-virtualized/stargazers","contributors_url":"https://api.github.com/repos/mkralla11/react-virtualized/contributors","subscribers_url":"https://api.github.com/repos/mkralla11/react-virtualized/subscribers","subscription_url":"https://api.github.com/repos/mkralla11/react-virtualized/subscription","commits_url":"https://api.github.com/repos/mkralla11/react-virtualized/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkralla11/react-virtualized/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkralla11/react-virtualized/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkralla11/react-virtualized/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkralla11/react-virtualized/contents/{+path}","compare_url":"https://api.github.com/repos/mkralla11/react-virtualized/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkralla11/react-virtualized/merges","archive_url":"https://api.github.com/repos/mkralla11/react-virtualized/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkralla11/react-virtualized/downloads","issues_url":"https://api.github.com/repos/mkralla11/react-virtualized/issues{/number}","pulls_url":"https://api.github.com/repos/mkralla11/react-virtualized/pulls{/number}","milestones_url":"https://api.github.com/repos/mkralla11/react-virtualized/milestones{/number}","notifications_url":"https://api.github.com/repos/mkralla11/react-virtualized/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkralla11/react-virtualized/labels{/name}","releases_url":"https://api.github.com/repos/mkralla11/react-virtualized/releases{/id}","deployments_url":"https://api.github.com/repos/mkralla11/react-virtualized/deployments","created_at":"2018-04-30T20:03:48Z","updated_at":"2018-04-30T20:03:53Z","pushed_at":"2018-04-30T20:06:36Z","git_url":"git://github.com/mkralla11/react-virtualized.git","ssh_url":"git@github.com:mkralla11/react-virtualized.git","clone_url":"https://github.com/mkralla11/react-virtualized.git","svn_url":"https://github.com/mkralla11/react-virtualized","homepage":"http://www.reactvirtualized.com","size":44080,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bvaughn:master","ref":"master","sha":"2a7a82813f34bcce3f6d52036c5a96d538041687","user":{"login":"bvaughn","id":29597,"avatar_url":"https://avatars0.githubusercontent.com/u/29597?v=4","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"repo":{"id":45431898,"name":"react-virtualized","full_name":"bvaughn/react-virtualized","owner":{"login":"bvaughn","id":29597,"avatar_url":"https://avatars0.githubusercontent.com/u/29597?v=4","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bvaughn/react-virtualized","description":"React components for efficiently rendering large lists and tabular data","fork":false,"url":"https://api.github.com/repos/bvaughn/react-virtualized","forks_url":"https://api.github.com/repos/bvaughn/react-virtualized/forks","keys_url":"https://api.github.com/repos/bvaughn/react-virtualized/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bvaughn/react-virtualized/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bvaughn/react-virtualized/teams","hooks_url":"https://api.github.com/repos/bvaughn/react-virtualized/hooks","issue_events_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/events{/number}","events_url":"https://api.github.com/repos/bvaughn/react-virtualized/events","assignees_url":"https://api.github.com/repos/bvaughn/react-virtualized/assignees{/user}","branches_url":"https://api.github.com/repos/bvaughn/react-virtualized/branches{/branch}","tags_url":"https://api.github.com/repos/bvaughn/react-virtualized/tags","blobs_url":"https://api.github.com/repos/bvaughn/react-virtualized/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bvaughn/react-virtualized/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bvaughn/react-virtualized/git/refs{/sha}","trees_url":"https://api.github.com/repos/bvaughn/react-virtualized/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bvaughn/react-virtualized/statuses/{sha}","languages_url":"https://api.github.com/repos/bvaughn/react-virtualized/languages","stargazers_url":"https://api.github.com/repos/bvaughn/react-virtualized/stargazers","contributors_url":"https://api.github.com/repos/bvaughn/react-virtualized/contributors","subscribers_url":"https://api.github.com/repos/bvaughn/react-virtualized/subscribers","subscription_url":"https://api.github.com/repos/bvaughn/react-virtualized/subscription","commits_url":"https://api.github.com/repos/bvaughn/react-virtualized/commits{/sha}","git_commits_url":"https://api.github.com/repos/bvaughn/react-virtualized/git/commits{/sha}","comments_url":"https://api.github.com/repos/bvaughn/react-virtualized/comments{/number}","issue_comment_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues/comments{/number}","contents_url":"https://api.github.com/repos/bvaughn/react-virtualized/contents/{+path}","compare_url":"https://api.github.com/repos/bvaughn/react-virtualized/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bvaughn/react-virtualized/merges","archive_url":"https://api.github.com/repos/bvaughn/react-virtualized/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bvaughn/react-virtualized/downloads","issues_url":"https://api.github.com/repos/bvaughn/react-virtualized/issues{/number}","pulls_url":"https://api.github.com/repos/bvaughn/react-virtualized/pulls{/number}","milestones_url":"https://api.github.com/repos/bvaughn/react-virtualized/milestones{/number}","notifications_url":"https://api.github.com/repos/bvaughn/react-virtualized/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bvaughn/react-virtualized/labels{/name}","releases_url":"https://api.github.com/repos/bvaughn/react-virtualized/releases{/id}","deployments_url":"https://api.github.com/repos/bvaughn/react-virtualized/deployments","created_at":"2015-11-03T00:48:07Z","updated_at":"2018-05-05T08:12:24Z","pushed_at":"2018-04-30T20:25:00Z","git_url":"git://github.com/bvaughn/react-virtualized.git","ssh_url":"git@github.com:bvaughn/react-virtualized.git","clone_url":"https://github.com/bvaughn/react-virtualized.git","svn_url":"https://github.com/bvaughn/react-virtualized","homepage":"http://www.reactvirtualized.com","size":44078,"stargazers_count":10334,"watchers_count":10334,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1149,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1149,"open_issues":71,"watchers":10334,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bvaughn/react-virtualized/pulls/1093"},"html":{"href":"https://github.com/bvaughn/react-virtualized/pull/1093"},"issue":{"href":"https://api.github.com/repos/bvaughn/react-virtualized/issues/1093"},"comments":{"href":"https://api.github.com/repos/bvaughn/react-virtualized/issues/1093/comments"},"review_comments":{"href":"https://api.github.com/repos/bvaughn/react-virtualized/pulls/1093/comments"},"review_comment":{"href":"https://api.github.com/repos/bvaughn/react-virtualized/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bvaughn/react-virtualized/pulls/1093/commits"},"statuses":{"href":"https://api.github.com/repos/bvaughn/react-virtualized/statuses/5843e07d74a6effddc7af7bfeb43b040b5c78224"}},"author_association":"NONE"}}
{"actor":{"display_login":"wuweiweiwu"}}