{"action":"created","issue":{"url":"https://api.github.com/repos/TheBusyBiscuit/Slimefun4/issues/659","repository_url":"https://api.github.com/repos/TheBusyBiscuit/Slimefun4","labels_url":"https://api.github.com/repos/TheBusyBiscuit/Slimefun4/issues/659/labels{/name}","comments_url":"https://api.github.com/repos/TheBusyBiscuit/Slimefun4/issues/659/comments","events_url":"https://api.github.com/repos/TheBusyBiscuit/Slimefun4/issues/659/events","html_url":"https://github.com/TheBusyBiscuit/Slimefun4/pull/659","id":316425527,"number":659,"title":"Anvil / Broken Spawner patch, Further Fix for keep-inv flags, Soulbound Backpack Recipe fix","user":{"login":"mrcoffee1026","id":3322491,"avatar_url":"https://avatars1.githubusercontent.com/u/3322491?v=4","gravatar_id":"","url":"https://api.github.com/users/mrcoffee1026","html_url":"https://github.com/mrcoffee1026","followers_url":"https://api.github.com/users/mrcoffee1026/followers","following_url":"https://api.github.com/users/mrcoffee1026/following{/other_user}","gists_url":"https://api.github.com/users/mrcoffee1026/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcoffee1026/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcoffee1026/subscriptions","organizations_url":"https://api.github.com/users/mrcoffee1026/orgs","repos_url":"https://api.github.com/users/mrcoffee1026/repos","events_url":"https://api.github.com/users/mrcoffee1026/events{/privacy}","received_events_url":"https://api.github.com/users/mrcoffee1026/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-04-20T22:08:21Z","updated_at":"2018-04-24T09:27:07Z","closed_at":"2018-04-24T09:24:30Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/TheBusyBiscuit/Slimefun4/pulls/659","html_url":"https://github.com/TheBusyBiscuit/Slimefun4/pull/659","diff_url":"https://github.com/TheBusyBiscuit/Slimefun4/pull/659.diff","patch_url":"https://github.com/TheBusyBiscuit/Slimefun4/pull/659.patch"},"body":"I tried making changes to the old pull request but FAILED.  I couldn't seem to get my fork updated to the last changes without making a huge mess out of my fork to the point it was illegible.  Anyway, here are these files with the changes requested. \r\n\r\nI removed the changes from ItemListener.java.  The isDisabled function calls isItem (I believe also getByItem under other circumstances... where if lore does not match exactly, the item will not be classified as a SlimeFun item.  However, the item should still be classified as a SlimeFun item whether or not lore is identical.  Enchants, IDs and the like are virtually guaranteed to vary from item to item, that doesn't make them any less of a SlimeFun item.\r\n\r\nAs requested, brought in \"the rest\" of the fix for the Soulbound recipe fix into the Magic Workbench.  I really wanted this to make id-less backpacks in the end but... copying the old logic required... copying all of it.  I found it did not actually 'delete' the ID, simply recycled this ID for the new pack, changing the size in the text file to match the one just crafted.  It might be possible to have the thing look up the ID in the text file and simple delete the whole entry, but I'm not as familiar with text file manipulation with Java so decided to leave it as is.  I'm not entirely confident, but this particular approach might have the added benefit of keeping the contents of the backpack used in the recipe in the newly created backpack, but I haven't checked to be sure.\r\n\r\nI couldn't alter the SoulBound code with \"breaks\" as asked as that would actually stop items in the inventory from being checked once a match had been found, and they'd still need to all be checked to keep things from duplicating... but I think I get your meaning, if so... my use of return here should alleviate any efficiency concerns.\r\n\r\nCloses #633 (and #529 again since it wasn't fully resolved), #282, #435 (this last shouldn't have been closed what was previously reported was not this problem, and this problem persists)."},"comment":{"url":"https://api.github.com/repos/TheBusyBiscuit/Slimefun4/issues/comments/383865869","html_url":"https://github.com/TheBusyBiscuit/Slimefun4/pull/659#issuecomment-383865869","issue_url":"https://api.github.com/repos/TheBusyBiscuit/Slimefun4/issues/659","id":383865869,"user":{"login":"TheBusyBiscuit","id":3967898,"avatar_url":"https://avatars1.githubusercontent.com/u/3967898?v=4","gravatar_id":"","url":"https://api.github.com/users/TheBusyBiscuit","html_url":"https://github.com/TheBusyBiscuit","followers_url":"https://api.github.com/users/TheBusyBiscuit/followers","following_url":"https://api.github.com/users/TheBusyBiscuit/following{/other_user}","gists_url":"https://api.github.com/users/TheBusyBiscuit/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBusyBiscuit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBusyBiscuit/subscriptions","organizations_url":"https://api.github.com/users/TheBusyBiscuit/orgs","repos_url":"https://api.github.com/users/TheBusyBiscuit/repos","events_url":"https://api.github.com/users/TheBusyBiscuit/events{/privacy}","received_events_url":"https://api.github.com/users/TheBusyBiscuit/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T09:27:07Z","updated_at":"2018-04-24T09:27:07Z","author_association":"OWNER","body":"By the way, successfully compiled:\r\nhttps://thebusybiscuit.github.io/builds/TheBusyBiscuit/Slimefun4/master/#34"}}
{"actor":{"display_login":"TheBusyBiscuit"}}