{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/comments/179502667","pull_request_review_id":109759106,"id":179502667,"diff_hunk":"@@ -153,3 +153,24 @@ Setting up your local environment and database to run the functional tests again\n   - Building your app locally will create a local image of it and give it the `:latest` tag.\n   - Docker Compose will now use your local copy including your new stuff.\n   - Then start the local container environment as described above.\n+\n+## Principles to follow when writing functional tests\n+\n+### Email addresses\n+\n+When using \"dummy\" email addresses in functional tests, try to stick to emails using one of the following domains:","path":"README.md","position":9,"original_position":9,"commit_id":"e00f2b3ce90bb5433896e7ce47e58cd9b0d57353","original_commit_id":"535167d8dcbf3020195375f8f0fea993fff8b3cf","user":{"login":"samuelhwilliams","id":2920760,"avatar_url":"https://avatars1.githubusercontent.com/u/2920760?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelhwilliams","html_url":"https://github.com/samuelhwilliams","followers_url":"https://api.github.com/users/samuelhwilliams/followers","following_url":"https://api.github.com/users/samuelhwilliams/following{/other_user}","gists_url":"https://api.github.com/users/samuelhwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelhwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelhwilliams/subscriptions","organizations_url":"https://api.github.com/users/samuelhwilliams/orgs","repos_url":"https://api.github.com/users/samuelhwilliams/repos","events_url":"https://api.github.com/users/samuelhwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/samuelhwilliams/received_events","type":"User","site_admin":false},"body":"I think @katstevens is right. It's good to be specific in our documentation. If we discover a new and justified thing that breaks the rules, then we can always update the docs. ;)","created_at":"2018-04-05T15:26:26Z","updated_at":"2018-04-05T15:26:26Z","html_url":"https://github.com/alphagov/digitalmarketplace-functional-tests/pull/506#discussion_r179502667","pull_request_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/506","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/comments/179502667"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-functional-tests/pull/506#discussion_r179502667"},"pull_request":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/506"}},"in_reply_to_id":179385442},"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/506","id":179458301,"html_url":"https://github.com/alphagov/digitalmarketplace-functional-tests/pull/506","diff_url":"https://github.com/alphagov/digitalmarketplace-functional-tests/pull/506.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-functional-tests/pull/506.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/506","number":506,"state":"open","locked":false,"title":"standardize email addresses used across functional tests","user":{"login":"risicle","id":807447,"avatar_url":"https://avatars3.githubusercontent.com/u/807447?v=4","gravatar_id":"","url":"https://api.github.com/users/risicle","html_url":"https://github.com/risicle","followers_url":"https://api.github.com/users/risicle/followers","following_url":"https://api.github.com/users/risicle/following{/other_user}","gists_url":"https://api.github.com/users/risicle/gists{/gist_id}","starred_url":"https://api.github.com/users/risicle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/risicle/subscriptions","organizations_url":"https://api.github.com/users/risicle/orgs","repos_url":"https://api.github.com/users/risicle/repos","events_url":"https://api.github.com/users/risicle/events{/privacy}","received_events_url":"https://api.github.com/users/risicle/received_events","type":"User","site_admin":false},"body":"include section in README.md listing and explaining the vetted domains\r\n\r\nTrello https://trello.com/c/YQB2HkiD/225-functional-tests-send-emails-to-invalid-email-addresses","created_at":"2018-04-04T17:21:12Z","updated_at":"2018-04-05T15:26:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdd6db2dd64d8ff717001b1e949ea319d07e16eb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"samuelhwilliams","id":2920760,"avatar_url":"https://avatars1.githubusercontent.com/u/2920760?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelhwilliams","html_url":"https://github.com/samuelhwilliams","followers_url":"https://api.github.com/users/samuelhwilliams/followers","following_url":"https://api.github.com/users/samuelhwilliams/following{/other_user}","gists_url":"https://api.github.com/users/samuelhwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelhwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelhwilliams/subscriptions","organizations_url":"https://api.github.com/users/samuelhwilliams/orgs","repos_url":"https://api.github.com/users/samuelhwilliams/repos","events_url":"https://api.github.com/users/samuelhwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/samuelhwilliams/received_events","type":"User","site_admin":false},{"login":"benvand","id":3469840,"avatar_url":"https://avatars0.githubusercontent.com/u/3469840?v=4","gravatar_id":"","url":"https://api.github.com/users/benvand","html_url":"https://github.com/benvand","followers_url":"https://api.github.com/users/benvand/followers","following_url":"https://api.github.com/users/benvand/following{/other_user}","gists_url":"https://api.github.com/users/benvand/gists{/gist_id}","starred_url":"https://api.github.com/users/benvand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benvand/subscriptions","organizations_url":"https://api.github.com/users/benvand/orgs","repos_url":"https://api.github.com/users/benvand/repos","events_url":"https://api.github.com/users/benvand/events{/privacy}","received_events_url":"https://api.github.com/users/benvand/received_events","type":"User","site_admin":false},{"login":"idavidmcdonald","id":7228605,"avatar_url":"https://avatars0.githubusercontent.com/u/7228605?v=4","gravatar_id":"","url":"https://api.github.com/users/idavidmcdonald","html_url":"https://github.com/idavidmcdonald","followers_url":"https://api.github.com/users/idavidmcdonald/followers","following_url":"https://api.github.com/users/idavidmcdonald/following{/other_user}","gists_url":"https://api.github.com/users/idavidmcdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/idavidmcdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idavidmcdonald/subscriptions","organizations_url":"https://api.github.com/users/idavidmcdonald/orgs","repos_url":"https://api.github.com/users/idavidmcdonald/repos","events_url":"https://api.github.com/users/idavidmcdonald/events{/privacy}","received_events_url":"https://api.github.com/users/idavidmcdonald/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/506/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/506/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/506/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/statuses/e00f2b3ce90bb5433896e7ce47e58cd9b0d57353","head":{"label":"alphagov:ris-standardize-email-domains","ref":"ris-standardize-email-domains","sha":"e00f2b3ce90bb5433896e7ce47e58cd9b0d57353","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31654958,"name":"digitalmarketplace-functional-tests","full_name":"alphagov/digitalmarketplace-functional-tests","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-functional-tests","description":"BDD tests for the digital marketplace suite of applications.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/deployments","created_at":"2015-03-04T12:04:09Z","updated_at":"2018-04-04T15:53:51Z","pushed_at":"2018-04-05T09:13:12Z","git_url":"git://github.com/alphagov/digitalmarketplace-functional-tests.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-functional-tests.git","clone_url":"https://github.com/alphagov/digitalmarketplace-functional-tests.git","svn_url":"https://github.com/alphagov/digitalmarketplace-functional-tests","homepage":null,"size":11781,"stargazers_count":5,"watchers_count":5,"language":"Gherkin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"0b6ea92c6e6843d2165607439ff54278fd8c7ebd","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31654958,"name":"digitalmarketplace-functional-tests","full_name":"alphagov/digitalmarketplace-functional-tests","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-functional-tests","description":"BDD tests for the digital marketplace suite of applications.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/deployments","created_at":"2015-03-04T12:04:09Z","updated_at":"2018-04-04T15:53:51Z","pushed_at":"2018-04-05T09:13:12Z","git_url":"git://github.com/alphagov/digitalmarketplace-functional-tests.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-functional-tests.git","clone_url":"https://github.com/alphagov/digitalmarketplace-functional-tests.git","svn_url":"https://github.com/alphagov/digitalmarketplace-functional-tests","homepage":null,"size":11781,"stargazers_count":5,"watchers_count":5,"language":"Gherkin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/506"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-functional-tests/pull/506"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/506"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/506/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/506/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/506/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/statuses/e00f2b3ce90bb5433896e7ce47e58cd9b0d57353"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"samuelhwilliams"}}