{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/JsonPatch/pulls/comments/186594215","pull_request_review_id":118202466,"id":186594215,"diff_hunk":"@@ -0,0 +1,39 @@\n+﻿using System;\n+using System.Collections;\n+using System.Collections.Generic;\n+using System.Text;\n+using Microsoft.AspNetCore.JsonPatch.Internal;\n+using Newtonsoft.Json.Serialization;\n+\n+namespace Microsoft.AspNetCore.JsonPatch.Adapters\n+{\n+    /// <summary>\n+    /// The default AdapterFactory to be used for resolving <see cref=\"IAdapter\"/>.\n+    /// </summary>\n+    public class AdapterFactory : IAdapterFactory","path":"src/Microsoft.AspNetCore.JsonPatch/Adapters/AdapterFactory.cs","position":13,"original_position":13,"commit_id":"50609c3626e3f07c3d173c9b9c6b437dcfb5a218","original_commit_id":"50609c3626e3f07c3d173c9b9c6b437dcfb5a218","user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars1.githubusercontent.com/u/1430011?v=4","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"I was asking to try and reason about whether or not they are the came concern. The current adapter factory implementation is only thing in the system that interacts with contracts current (I think).\r\n\r\nIf we were implementing this system fresh (without JSON.NET) we would put the details about how to traverse different types on our equivalent of `JsonContract`.\r\n\r\nI don't have any major concerns or strong feedback about what you and @HappyNomad have been discussing, I think both proposals are pretty reasonable. We don't have the luxury of designing something new here because it has to fit into the existing APIs.","created_at":"2018-05-08T01:13:39Z","updated_at":"2018-05-08T01:13:39Z","html_url":"https://github.com/aspnet/JsonPatch/pull/132#discussion_r186594215","pull_request_url":"https://api.github.com/repos/aspnet/JsonPatch/pulls/132","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/JsonPatch/pulls/comments/186594215"},"html":{"href":"https://github.com/aspnet/JsonPatch/pull/132#discussion_r186594215"},"pull_request":{"href":"https://api.github.com/repos/aspnet/JsonPatch/pulls/132"}},"in_reply_to_id":186196310},"pull_request":{"url":"https://api.github.com/repos/aspnet/JsonPatch/pulls/132","id":173277675,"html_url":"https://github.com/aspnet/JsonPatch/pull/132","diff_url":"https://github.com/aspnet/JsonPatch/pull/132.diff","patch_url":"https://github.com/aspnet/JsonPatch/pull/132.patch","issue_url":"https://api.github.com/repos/aspnet/JsonPatch/issues/132","number":132,"state":"open","locked":false,"title":"Updated to support Adapter Extension","user":{"login":"jmudavid","id":3802454,"avatar_url":"https://avatars3.githubusercontent.com/u/3802454?v=4","gravatar_id":"","url":"https://api.github.com/users/jmudavid","html_url":"https://github.com/jmudavid","followers_url":"https://api.github.com/users/jmudavid/followers","following_url":"https://api.github.com/users/jmudavid/following{/other_user}","gists_url":"https://api.github.com/users/jmudavid/gists{/gist_id}","starred_url":"https://api.github.com/users/jmudavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmudavid/subscriptions","organizations_url":"https://api.github.com/users/jmudavid/orgs","repos_url":"https://api.github.com/users/jmudavid/repos","events_url":"https://api.github.com/users/jmudavid/events{/privacy}","received_events_url":"https://api.github.com/users/jmudavid/received_events","type":"User","site_admin":false},"body":"- Added IAdapterFactory and base implementation\r\n- Updated built in adapters to support inheritance\r\n\r\n@HappyNomad, @Eilon, Here is the new PR with the initial factory model implementation for your review.  Let me know what you think,  Thanks!","created_at":"2018-03-06T20:51:53Z","updated_at":"2018-05-08T01:13:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd44410599432d7f1e8047212c40d8cf403c9e5e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/JsonPatch/pulls/132/commits","review_comments_url":"https://api.github.com/repos/aspnet/JsonPatch/pulls/132/comments","review_comment_url":"https://api.github.com/repos/aspnet/JsonPatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/JsonPatch/issues/132/comments","statuses_url":"https://api.github.com/repos/aspnet/JsonPatch/statuses/50609c3626e3f07c3d173c9b9c6b437dcfb5a218","head":{"label":"ancile:b-factory-approach","ref":"b-factory-approach","sha":"50609c3626e3f07c3d173c9b9c6b437dcfb5a218","user":{"login":"ancile","id":1812439,"avatar_url":"https://avatars1.githubusercontent.com/u/1812439?v=4","gravatar_id":"","url":"https://api.github.com/users/ancile","html_url":"https://github.com/ancile","followers_url":"https://api.github.com/users/ancile/followers","following_url":"https://api.github.com/users/ancile/following{/other_user}","gists_url":"https://api.github.com/users/ancile/gists{/gist_id}","starred_url":"https://api.github.com/users/ancile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancile/subscriptions","organizations_url":"https://api.github.com/users/ancile/orgs","repos_url":"https://api.github.com/users/ancile/repos","events_url":"https://api.github.com/users/ancile/events{/privacy}","received_events_url":"https://api.github.com/users/ancile/received_events","type":"Organization","site_admin":false},"repo":{"id":118283056,"name":"JsonPatch","full_name":"ancile/JsonPatch","owner":{"login":"ancile","id":1812439,"avatar_url":"https://avatars1.githubusercontent.com/u/1812439?v=4","gravatar_id":"","url":"https://api.github.com/users/ancile","html_url":"https://github.com/ancile","followers_url":"https://api.github.com/users/ancile/followers","following_url":"https://api.github.com/users/ancile/following{/other_user}","gists_url":"https://api.github.com/users/ancile/gists{/gist_id}","starred_url":"https://api.github.com/users/ancile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancile/subscriptions","organizations_url":"https://api.github.com/users/ancile/orgs","repos_url":"https://api.github.com/users/ancile/repos","events_url":"https://api.github.com/users/ancile/events{/privacy}","received_events_url":"https://api.github.com/users/ancile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ancile/JsonPatch","description":"JSON PATCH library","fork":true,"url":"https://api.github.com/repos/ancile/JsonPatch","forks_url":"https://api.github.com/repos/ancile/JsonPatch/forks","keys_url":"https://api.github.com/repos/ancile/JsonPatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ancile/JsonPatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ancile/JsonPatch/teams","hooks_url":"https://api.github.com/repos/ancile/JsonPatch/hooks","issue_events_url":"https://api.github.com/repos/ancile/JsonPatch/issues/events{/number}","events_url":"https://api.github.com/repos/ancile/JsonPatch/events","assignees_url":"https://api.github.com/repos/ancile/JsonPatch/assignees{/user}","branches_url":"https://api.github.com/repos/ancile/JsonPatch/branches{/branch}","tags_url":"https://api.github.com/repos/ancile/JsonPatch/tags","blobs_url":"https://api.github.com/repos/ancile/JsonPatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ancile/JsonPatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ancile/JsonPatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/ancile/JsonPatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ancile/JsonPatch/statuses/{sha}","languages_url":"https://api.github.com/repos/ancile/JsonPatch/languages","stargazers_url":"https://api.github.com/repos/ancile/JsonPatch/stargazers","contributors_url":"https://api.github.com/repos/ancile/JsonPatch/contributors","subscribers_url":"https://api.github.com/repos/ancile/JsonPatch/subscribers","subscription_url":"https://api.github.com/repos/ancile/JsonPatch/subscription","commits_url":"https://api.github.com/repos/ancile/JsonPatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/ancile/JsonPatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/ancile/JsonPatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/ancile/JsonPatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/ancile/JsonPatch/contents/{+path}","compare_url":"https://api.github.com/repos/ancile/JsonPatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ancile/JsonPatch/merges","archive_url":"https://api.github.com/repos/ancile/JsonPatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ancile/JsonPatch/downloads","issues_url":"https://api.github.com/repos/ancile/JsonPatch/issues{/number}","pulls_url":"https://api.github.com/repos/ancile/JsonPatch/pulls{/number}","milestones_url":"https://api.github.com/repos/ancile/JsonPatch/milestones{/number}","notifications_url":"https://api.github.com/repos/ancile/JsonPatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ancile/JsonPatch/labels{/name}","releases_url":"https://api.github.com/repos/ancile/JsonPatch/releases{/id}","deployments_url":"https://api.github.com/repos/ancile/JsonPatch/deployments","created_at":"2018-01-20T21:42:05Z","updated_at":"2018-01-20T21:42:07Z","pushed_at":"2018-03-13T18:33:31Z","git_url":"git://github.com/ancile/JsonPatch.git","ssh_url":"git@github.com:ancile/JsonPatch.git","clone_url":"https://github.com/ancile/JsonPatch.git","svn_url":"https://github.com/ancile/JsonPatch","homepage":null,"size":507,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"93817a51930e4734b6fa22025afbdc7df48abeae","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42667889,"name":"JsonPatch","full_name":"aspnet/JsonPatch","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/JsonPatch","description":"JSON PATCH library","fork":false,"url":"https://api.github.com/repos/aspnet/JsonPatch","forks_url":"https://api.github.com/repos/aspnet/JsonPatch/forks","keys_url":"https://api.github.com/repos/aspnet/JsonPatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/JsonPatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/JsonPatch/teams","hooks_url":"https://api.github.com/repos/aspnet/JsonPatch/hooks","issue_events_url":"https://api.github.com/repos/aspnet/JsonPatch/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/JsonPatch/events","assignees_url":"https://api.github.com/repos/aspnet/JsonPatch/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/JsonPatch/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/JsonPatch/tags","blobs_url":"https://api.github.com/repos/aspnet/JsonPatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/JsonPatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/JsonPatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/JsonPatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/JsonPatch/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/JsonPatch/languages","stargazers_url":"https://api.github.com/repos/aspnet/JsonPatch/stargazers","contributors_url":"https://api.github.com/repos/aspnet/JsonPatch/contributors","subscribers_url":"https://api.github.com/repos/aspnet/JsonPatch/subscribers","subscription_url":"https://api.github.com/repos/aspnet/JsonPatch/subscription","commits_url":"https://api.github.com/repos/aspnet/JsonPatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/JsonPatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/JsonPatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/JsonPatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/JsonPatch/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/JsonPatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/JsonPatch/merges","archive_url":"https://api.github.com/repos/aspnet/JsonPatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/JsonPatch/downloads","issues_url":"https://api.github.com/repos/aspnet/JsonPatch/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/JsonPatch/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/JsonPatch/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/JsonPatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/JsonPatch/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/JsonPatch/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/JsonPatch/deployments","created_at":"2015-09-17T16:32:18Z","updated_at":"2018-05-07T23:31:03Z","pushed_at":"2018-05-07T23:31:03Z","git_url":"git://github.com/aspnet/JsonPatch.git","ssh_url":"git@github.com:aspnet/JsonPatch.git","clone_url":"https://github.com/aspnet/JsonPatch.git","svn_url":"https://github.com/aspnet/JsonPatch","homepage":null,"size":437,"stargazers_count":70,"watchers_count":70,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":28,"open_issues":2,"watchers":70,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/JsonPatch/pulls/132"},"html":{"href":"https://github.com/aspnet/JsonPatch/pull/132"},"issue":{"href":"https://api.github.com/repos/aspnet/JsonPatch/issues/132"},"comments":{"href":"https://api.github.com/repos/aspnet/JsonPatch/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/JsonPatch/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/JsonPatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/JsonPatch/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/JsonPatch/statuses/50609c3626e3f07c3d173c9b9c6b437dcfb5a218"}},"author_association":"NONE"}}
{"actor":{"display_login":"rynowak"}}