{"action":"created","comment":{"url":"https://api.github.com/repos/monero-project/monero/pulls/comments/221410088","pull_request_review_id":160059925,"id":221410088,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQxMDA4OA==","diff_hunk":"@@ -3552,6 +3553,9 @@ bool Blockchain::handle_block_to_main_chain(const block& bl, const crypto::hash&\n   get_difficulty_for_next_block(); // just to cache it\n   invalidate_block_template_cache();\n \n+  if (m_block_notify)","path":"src/cryptonote_core/blockchain.cpp","position":12,"original_position":12,"commit_id":"da34601b9e1ab57d7270ace95b1dccba015ae02b","original_commit_id":"da43b0300c2b045972a37012084762f945c1f5c0","user":{"login":"xiphon","id":26060097,"node_id":"MDQ6VXNlcjI2MDYwMDk3","avatar_url":"https://avatars2.githubusercontent.com/u/26060097?v=4","gravatar_id":"","url":"https://api.github.com/users/xiphon","html_url":"https://github.com/xiphon","followers_url":"https://api.github.com/users/xiphon/followers","following_url":"https://api.github.com/users/xiphon/following{/other_user}","gists_url":"https://api.github.com/users/xiphon/gists{/gist_id}","starred_url":"https://api.github.com/users/xiphon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiphon/subscriptions","organizations_url":"https://api.github.com/users/xiphon/orgs","repos_url":"https://api.github.com/users/xiphon/repos","events_url":"https://api.github.com/users/xiphon/events{/privacy}","received_events_url":"https://api.github.com/users/xiphon/received_events","type":"User","site_admin":false},"body":"Haha, don't be so full of butthurt. Shit happens.\r\n\r\nSure, i will point to any problem i will identify in the code.\r\nThat is what is called code review, FYI.","created_at":"2018-09-29T01:15:31Z","updated_at":"2018-09-29T01:15:31Z","html_url":"https://github.com/monero-project/monero/pull/4333#discussion_r221410088","pull_request_url":"https://api.github.com/repos/monero-project/monero/pulls/4333","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero/pulls/comments/221410088"},"html":{"href":"https://github.com/monero-project/monero/pull/4333#discussion_r221410088"},"pull_request":{"href":"https://api.github.com/repos/monero-project/monero/pulls/4333"}},"in_reply_to_id":221380603},"pull_request":{"url":"https://api.github.com/repos/monero-project/monero/pulls/4333","id":212765142,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzY1MTQy","html_url":"https://github.com/monero-project/monero/pull/4333","diff_url":"https://github.com/monero-project/monero/pull/4333.diff","patch_url":"https://github.com/monero-project/monero/pull/4333.patch","issue_url":"https://api.github.com/repos/monero-project/monero/issues/4333","number":4333,"state":"open","locked":false,"title":"add --block-notify to monerod and --tx-notify to monero-wallet-{cli,rpc}","user":{"login":"moneromooo-monero","id":8851073,"node_id":"MDQ6VXNlcjg4NTEwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/8851073?v=4","gravatar_id":"","url":"https://api.github.com/users/moneromooo-monero","html_url":"https://github.com/moneromooo-monero","followers_url":"https://api.github.com/users/moneromooo-monero/followers","following_url":"https://api.github.com/users/moneromooo-monero/following{/other_user}","gists_url":"https://api.github.com/users/moneromooo-monero/gists{/gist_id}","starred_url":"https://api.github.com/users/moneromooo-monero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneromooo-monero/subscriptions","organizations_url":"https://api.github.com/users/moneromooo-monero/orgs","repos_url":"https://api.github.com/users/moneromooo-monero/repos","events_url":"https://api.github.com/users/moneromooo-monero/events{/privacy}","received_events_url":"https://api.github.com/users/moneromooo-monero/received_events","type":"User","site_admin":false},"body":"Those take a command line of the form \"A [B]\", with A being the\r\nname (and optional path, if not in the caller's CWD, but fully\r\nqualified path is recommended, avoids possible security issues)\r\nto a program, and optional arguments. Any occurence of the two\r\ncharacter string \"%s\" will be replaced by the hash of the block\r\nor transaction which triggered the notification.\r\n\r\nblock-notify is called when a new block is added onto the chain.\r\n\r\ntx-notify is called when a new transaction happens with the\r\nwallet as source and/or destination.\r\n\r\nIt is the notification program's responsibility to determine what\r\nto do in those cases.\r\n\r\nNote that this is asynchronous, so it is very possible that:\r\n- the notification programs will be run out of order\r\n- several events happen before the notification for the first one\r\n\r\nA Windows port would be nice if someone wants to make one.","created_at":"2018-09-03T14:28:26Z","updated_at":"2018-09-29T01:15:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf66e6c23cba30422e78e5e0ce90ea68e5a14c36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/monero-project/monero/pulls/4333/commits","review_comments_url":"https://api.github.com/repos/monero-project/monero/pulls/4333/comments","review_comment_url":"https://api.github.com/repos/monero-project/monero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/monero-project/monero/issues/4333/comments","statuses_url":"https://api.github.com/repos/monero-project/monero/statuses/da34601b9e1ab57d7270ace95b1dccba015ae02b","head":{"label":"moneromooo-monero:notify","ref":"notify","sha":"da34601b9e1ab57d7270ace95b1dccba015ae02b","user":{"login":"moneromooo-monero","id":8851073,"node_id":"MDQ6VXNlcjg4NTEwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/8851073?v=4","gravatar_id":"","url":"https://api.github.com/users/moneromooo-monero","html_url":"https://github.com/moneromooo-monero","followers_url":"https://api.github.com/users/moneromooo-monero/followers","following_url":"https://api.github.com/users/moneromooo-monero/following{/other_user}","gists_url":"https://api.github.com/users/moneromooo-monero/gists{/gist_id}","starred_url":"https://api.github.com/users/moneromooo-monero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneromooo-monero/subscriptions","organizations_url":"https://api.github.com/users/moneromooo-monero/orgs","repos_url":"https://api.github.com/users/moneromooo-monero/repos","events_url":"https://api.github.com/users/moneromooo-monero/events{/privacy}","received_events_url":"https://api.github.com/users/moneromooo-monero/received_events","type":"User","site_admin":false},"repo":{"id":24294045,"node_id":"MDEwOlJlcG9zaXRvcnkyNDI5NDA0NQ==","name":"bitmonero","full_name":"moneromooo-monero/bitmonero","private":false,"owner":{"login":"moneromooo-monero","id":8851073,"node_id":"MDQ6VXNlcjg4NTEwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/8851073?v=4","gravatar_id":"","url":"https://api.github.com/users/moneromooo-monero","html_url":"https://github.com/moneromooo-monero","followers_url":"https://api.github.com/users/moneromooo-monero/followers","following_url":"https://api.github.com/users/moneromooo-monero/following{/other_user}","gists_url":"https://api.github.com/users/moneromooo-monero/gists{/gist_id}","starred_url":"https://api.github.com/users/moneromooo-monero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneromooo-monero/subscriptions","organizations_url":"https://api.github.com/users/moneromooo-monero/orgs","repos_url":"https://api.github.com/users/moneromooo-monero/repos","events_url":"https://api.github.com/users/moneromooo-monero/events{/privacy}","received_events_url":"https://api.github.com/users/moneromooo-monero/received_events","type":"User","site_admin":false},"html_url":"https://github.com/moneromooo-monero/bitmonero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":true,"url":"https://api.github.com/repos/moneromooo-monero/bitmonero","forks_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/forks","keys_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/teams","hooks_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/hooks","issue_events_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/issues/events{/number}","events_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/events","assignees_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/assignees{/user}","branches_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/branches{/branch}","tags_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/tags","blobs_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/statuses/{sha}","languages_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/languages","stargazers_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/stargazers","contributors_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/contributors","subscribers_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/subscribers","subscription_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/subscription","commits_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/contents/{+path}","compare_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/merges","archive_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/downloads","issues_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/issues{/number}","pulls_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/pulls{/number}","milestones_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/milestones{/number}","notifications_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/labels{/name}","releases_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/releases{/id}","deployments_url":"https://api.github.com/repos/moneromooo-monero/bitmonero/deployments","created_at":"2014-09-21T15:04:04Z","updated_at":"2018-09-13T05:45:36Z","pushed_at":"2018-09-28T21:43:36Z","git_url":"git://github.com/moneromooo-monero/bitmonero.git","ssh_url":"git@github.com:moneromooo-monero/bitmonero.git","clone_url":"https://github.com/moneromooo-monero/bitmonero.git","svn_url":"https://github.com/moneromooo-monero/bitmonero","homepage":"https://getmonero.org","size":149740,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":0,"watchers":17,"default_branch":"master"}},"base":{"label":"monero-project:master","ref":"master","sha":"8bf5a00564ad0e86b4698008418e28036013ef9f","user":{"login":"monero-project","id":7450663,"node_id":"MDQ6VXNlcjc0NTA2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/7450663?v=4","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"repo":{"id":19316619,"node_id":"MDEwOlJlcG9zaXRvcnkxOTMxNjYxOQ==","name":"monero","full_name":"monero-project/monero","private":false,"owner":{"login":"monero-project","id":7450663,"node_id":"MDQ6VXNlcjc0NTA2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/7450663?v=4","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"html_url":"https://github.com/monero-project/monero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":false,"url":"https://api.github.com/repos/monero-project/monero","forks_url":"https://api.github.com/repos/monero-project/monero/forks","keys_url":"https://api.github.com/repos/monero-project/monero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monero-project/monero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monero-project/monero/teams","hooks_url":"https://api.github.com/repos/monero-project/monero/hooks","issue_events_url":"https://api.github.com/repos/monero-project/monero/issues/events{/number}","events_url":"https://api.github.com/repos/monero-project/monero/events","assignees_url":"https://api.github.com/repos/monero-project/monero/assignees{/user}","branches_url":"https://api.github.com/repos/monero-project/monero/branches{/branch}","tags_url":"https://api.github.com/repos/monero-project/monero/tags","blobs_url":"https://api.github.com/repos/monero-project/monero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monero-project/monero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monero-project/monero/git/refs{/sha}","trees_url":"https://api.github.com/repos/monero-project/monero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monero-project/monero/statuses/{sha}","languages_url":"https://api.github.com/repos/monero-project/monero/languages","stargazers_url":"https://api.github.com/repos/monero-project/monero/stargazers","contributors_url":"https://api.github.com/repos/monero-project/monero/contributors","subscribers_url":"https://api.github.com/repos/monero-project/monero/subscribers","subscription_url":"https://api.github.com/repos/monero-project/monero/subscription","commits_url":"https://api.github.com/repos/monero-project/monero/commits{/sha}","git_commits_url":"https://api.github.com/repos/monero-project/monero/git/commits{/sha}","comments_url":"https://api.github.com/repos/monero-project/monero/comments{/number}","issue_comment_url":"https://api.github.com/repos/monero-project/monero/issues/comments{/number}","contents_url":"https://api.github.com/repos/monero-project/monero/contents/{+path}","compare_url":"https://api.github.com/repos/monero-project/monero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monero-project/monero/merges","archive_url":"https://api.github.com/repos/monero-project/monero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monero-project/monero/downloads","issues_url":"https://api.github.com/repos/monero-project/monero/issues{/number}","pulls_url":"https://api.github.com/repos/monero-project/monero/pulls{/number}","milestones_url":"https://api.github.com/repos/monero-project/monero/milestones{/number}","notifications_url":"https://api.github.com/repos/monero-project/monero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monero-project/monero/labels{/name}","releases_url":"https://api.github.com/repos/monero-project/monero/releases{/id}","deployments_url":"https://api.github.com/repos/monero-project/monero/deployments","created_at":"2014-04-30T14:38:28Z","updated_at":"2018-09-28T19:16:23Z","pushed_at":"2018-09-28T21:43:38Z","git_url":"git://github.com/monero-project/monero.git","ssh_url":"git@github.com:monero-project/monero.git","clone_url":"https://github.com/monero-project/monero.git","svn_url":"https://github.com/monero-project/monero","homepage":"https://getmonero.org","size":144414,"stargazers_count":3291,"watchers_count":3291,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1689,"mirror_url":null,"archived":false,"open_issues_count":269,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1689,"open_issues":269,"watchers":3291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero/pulls/4333"},"html":{"href":"https://github.com/monero-project/monero/pull/4333"},"issue":{"href":"https://api.github.com/repos/monero-project/monero/issues/4333"},"comments":{"href":"https://api.github.com/repos/monero-project/monero/issues/4333/comments"},"review_comments":{"href":"https://api.github.com/repos/monero-project/monero/pulls/4333/comments"},"review_comment":{"href":"https://api.github.com/repos/monero-project/monero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/monero-project/monero/pulls/4333/commits"},"statuses":{"href":"https://api.github.com/repos/monero-project/monero/statuses/da34601b9e1ab57d7270ace95b1dccba015ae02b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xiphon"}}