{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/177359511","pull_request_review_id":107212379,"id":177359511,"diff_hunk":"@@ -33,14 +33,14 @@ case \"$ID\" in\n \t\textra_opts=\"--libexecdir=/usr/lib/snapd\"\n \t\t;;\n \tubuntu)\n-\t\tcase \"$VERSION_ID\" in\n-\t\t\t16.04)\n-\t\t\t\textra_opts=\"--libexecdir=/usr/lib/snapd --enable-nvidia-multiarch --enable-static-libcap --enable-static-libapparmor --enable-static-libseccomp\"\n-\t\t\t\t;;\n-\t\t\t*)\n-\t\t\t\textra_opts=\"--libexecdir=/usr/lib/snapd --enable-nvidia-multiarch --enable-static-libcap\"\n-\t\t\t\t;;\n-\t\tesac\n+\t\textra_opts=\"--libexecdir=/usr/lib/snapd --enable-nvidia-multiarch --enable-static-libcap --enable-static-libapparmor --enable-static-libseccomp\"\n+\t\tdpkg_architecture=$(which dpkg-architecture 2>/dev/null)\n+\t\tif [ -n \"$dpkg_architecture\" ]; then","path":"cmd/autogen.sh","position":14,"original_position":14,"commit_id":"30cd75a8d65c763a17686a605222a58b8119ce34","original_commit_id":"30cd75a8d65c763a17686a605222a58b8119ce34","user":{"login":"zyga","id":784262,"avatar_url":"https://avatars0.githubusercontent.com/u/784262?v=4","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"body":"Is this test necessary? What's the point of checking if this is empty?","created_at":"2018-03-27T09:21:07Z","updated_at":"2018-03-27T09:21:07Z","html_url":"https://github.com/snapcore/snapd/pull/4908#discussion_r177359511","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/4908","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/177359511"},"html":{"href":"https://github.com/snapcore/snapd/pull/4908#discussion_r177359511"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4908"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/4908","id":176818729,"html_url":"https://github.com/snapcore/snapd/pull/4908","diff_url":"https://github.com/snapcore/snapd/pull/4908.diff","patch_url":"https://github.com/snapcore/snapd/pull/4908.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/4908","number":4908,"state":"open","locked":false,"title":"[RFC] cmd/snap-confine: attempt to detect if multiarch host uses arch triplets","user":{"login":"bboozzoo","id":41870,"avatar_url":"https://avatars3.githubusercontent.com/u/41870?v=4","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"body":"18.04 is broken wrt. nvidia support because it's using `/usr/lib/<arch-triplet>` instead of `/usr/lib/nvidia`. Autodetect if snap-confine is running on such host and attempt to do the right thing.\r\n\r\nNote, this does not seem to resolve the problem. With the change I can observe libglvnd attempt to load nvidia libs, but I'm hitting the same problem as in https://forum.snapcraft.io/t/nvidia-acceleration-on-chrome-and-firefox/4532 i.e. glxinfo segfaults.\r\n","created_at":"2018-03-22T15:35:08Z","updated_at":"2018-03-27T09:21:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2abd305c465e27f9a592cf4cfaf92e278368ea8c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/4908/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/4908/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/4908/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/30cd75a8d65c763a17686a605222a58b8119ce34","head":{"label":"bboozzoo:bboozzoo/nvidia-glob-prefix-ubuntu-triplet","ref":"bboozzoo/nvidia-glob-prefix-ubuntu-triplet","sha":"30cd75a8d65c763a17686a605222a58b8119ce34","user":{"login":"bboozzoo","id":41870,"avatar_url":"https://avatars3.githubusercontent.com/u/41870?v=4","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"repo":{"id":109232638,"name":"snapd","full_name":"bboozzoo/snapd","owner":{"login":"bboozzoo","id":41870,"avatar_url":"https://avatars3.githubusercontent.com/u/41870?v=4","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bboozzoo/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":true,"url":"https://api.github.com/repos/bboozzoo/snapd","forks_url":"https://api.github.com/repos/bboozzoo/snapd/forks","keys_url":"https://api.github.com/repos/bboozzoo/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bboozzoo/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bboozzoo/snapd/teams","hooks_url":"https://api.github.com/repos/bboozzoo/snapd/hooks","issue_events_url":"https://api.github.com/repos/bboozzoo/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/bboozzoo/snapd/events","assignees_url":"https://api.github.com/repos/bboozzoo/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/bboozzoo/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/bboozzoo/snapd/tags","blobs_url":"https://api.github.com/repos/bboozzoo/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bboozzoo/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bboozzoo/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bboozzoo/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bboozzoo/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/bboozzoo/snapd/languages","stargazers_url":"https://api.github.com/repos/bboozzoo/snapd/stargazers","contributors_url":"https://api.github.com/repos/bboozzoo/snapd/contributors","subscribers_url":"https://api.github.com/repos/bboozzoo/snapd/subscribers","subscription_url":"https://api.github.com/repos/bboozzoo/snapd/subscription","commits_url":"https://api.github.com/repos/bboozzoo/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bboozzoo/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bboozzoo/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bboozzoo/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/bboozzoo/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/bboozzoo/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bboozzoo/snapd/merges","archive_url":"https://api.github.com/repos/bboozzoo/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bboozzoo/snapd/downloads","issues_url":"https://api.github.com/repos/bboozzoo/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/bboozzoo/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/bboozzoo/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/bboozzoo/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bboozzoo/snapd/labels{/name}","releases_url":"https://api.github.com/repos/bboozzoo/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/bboozzoo/snapd/deployments","created_at":"2017-11-02T07:37:26Z","updated_at":"2017-11-02T07:37:33Z","pushed_at":"2018-03-27T08:22:44Z","git_url":"git://github.com/bboozzoo/snapd.git","ssh_url":"git@github.com:bboozzoo/snapd.git","clone_url":"https://github.com/bboozzoo/snapd.git","svn_url":"https://github.com/bboozzoo/snapd","homepage":"","size":61457,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"061b23f963d02dd1a361a65baf15323f80592193","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"name":"snapd","full_name":"snapcore/snapd","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2018-03-26T20:08:25Z","pushed_at":"2018-03-27T09:20:59Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":61321,"stargazers_count":908,"watchers_count":908,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":228,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":228,"open_issues":54,"watchers":908,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4908"},"html":{"href":"https://github.com/snapcore/snapd/pull/4908"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/4908"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/4908/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4908/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4908/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/30cd75a8d65c763a17686a605222a58b8119ce34"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zyga"}}