{"action":"opened","number":192,"pull_request":{"url":"https://api.github.com/repos/Nickersoft/push.js/pulls/192","id":224784769,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Nzg0NzY5","html_url":"https://github.com/Nickersoft/push.js/pull/192","diff_url":"https://github.com/Nickersoft/push.js/pull/192.diff","patch_url":"https://github.com/Nickersoft/push.js/pull/192.patch","issue_url":"https://api.github.com/repos/Nickersoft/push.js/issues/192","number":192,"state":"open","locked":false,"title":"Handle deprecated requestPermission APi in Safari 12+","user":{"login":"andjosh","id":2358584,"node_id":"MDQ6VXNlcjIzNTg1ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2358584?v=4","gravatar_id":"","url":"https://api.github.com/users/andjosh","html_url":"https://github.com/andjosh","followers_url":"https://api.github.com/users/andjosh/followers","following_url":"https://api.github.com/users/andjosh/following{/other_user}","gists_url":"https://api.github.com/users/andjosh/gists{/gist_id}","starred_url":"https://api.github.com/users/andjosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andjosh/subscriptions","organizations_url":"https://api.github.com/users/andjosh/orgs","repos_url":"https://api.github.com/users/andjosh/repos","events_url":"https://api.github.com/users/andjosh/events{/privacy}","received_events_url":"https://api.github.com/users/andjosh/received_events","type":"User","site_admin":false},"body":"The assumption was that Safari would not remove the webkit prefix\r\nwithout also conforming to the promise-based requestPermission API. They\r\ndropped the prefix and did not update to Promises. This checks the\r\nreturn value of the requestPermission call and treats it as a Promise\r\nwhen possible. Otherwise, it always passes the callback version for the\r\nold API.\r\n\r\nRef: https://developer.mozilla.org/en-US/docs/Web/API/Notification/requestPermission\r\n\r\nRef: https://developer.apple.com/library/archive/documentation/NetworkingInternet/Conceptual/NotificationProgrammingGuideForWebsites/LocalNotifications/LocalNotifications.html#//apple_ref/doc/uid/TP40012932-SW1\r\n\r\nFixes #117 and #124, tested in modern Safari, Chrome, FF, IE. \r\n\r\nRe-open of #190 with fewer edits.","created_at":"2018-10-22T19:20:51Z","updated_at":"2018-10-22T19:20:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Nickersoft/push.js/pulls/192/commits","review_comments_url":"https://api.github.com/repos/Nickersoft/push.js/pulls/192/comments","review_comment_url":"https://api.github.com/repos/Nickersoft/push.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nickersoft/push.js/issues/192/comments","statuses_url":"https://api.github.com/repos/Nickersoft/push.js/statuses/00def1e62bc65927d722bdbaa57488d16249b07e","head":{"label":"officeluv:bugfix-deprecated-requestpermission-safari-12","ref":"bugfix-deprecated-requestpermission-safari-12","sha":"00def1e62bc65927d722bdbaa57488d16249b07e","user":{"login":"officeluv","id":20519999,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTE5OTk5","avatar_url":"https://avatars1.githubusercontent.com/u/20519999?v=4","gravatar_id":"","url":"https://api.github.com/users/officeluv","html_url":"https://github.com/officeluv","followers_url":"https://api.github.com/users/officeluv/followers","following_url":"https://api.github.com/users/officeluv/following{/other_user}","gists_url":"https://api.github.com/users/officeluv/gists{/gist_id}","starred_url":"https://api.github.com/users/officeluv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/officeluv/subscriptions","organizations_url":"https://api.github.com/users/officeluv/orgs","repos_url":"https://api.github.com/users/officeluv/repos","events_url":"https://api.github.com/users/officeluv/events{/privacy}","received_events_url":"https://api.github.com/users/officeluv/received_events","type":"Organization","site_admin":false},"repo":{"id":153474917,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM0NzQ5MTc=","name":"push.js","full_name":"officeluv/push.js","private":false,"owner":{"login":"officeluv","id":20519999,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTE5OTk5","avatar_url":"https://avatars1.githubusercontent.com/u/20519999?v=4","gravatar_id":"","url":"https://api.github.com/users/officeluv","html_url":"https://github.com/officeluv","followers_url":"https://api.github.com/users/officeluv/followers","following_url":"https://api.github.com/users/officeluv/following{/other_user}","gists_url":"https://api.github.com/users/officeluv/gists{/gist_id}","starred_url":"https://api.github.com/users/officeluv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/officeluv/subscriptions","organizations_url":"https://api.github.com/users/officeluv/orgs","repos_url":"https://api.github.com/users/officeluv/repos","events_url":"https://api.github.com/users/officeluv/events{/privacy}","received_events_url":"https://api.github.com/users/officeluv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/officeluv/push.js","description":"The world's most versatile desktop notifications framework :earth_americas:","fork":true,"url":"https://api.github.com/repos/officeluv/push.js","forks_url":"https://api.github.com/repos/officeluv/push.js/forks","keys_url":"https://api.github.com/repos/officeluv/push.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/officeluv/push.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/officeluv/push.js/teams","hooks_url":"https://api.github.com/repos/officeluv/push.js/hooks","issue_events_url":"https://api.github.com/repos/officeluv/push.js/issues/events{/number}","events_url":"https://api.github.com/repos/officeluv/push.js/events","assignees_url":"https://api.github.com/repos/officeluv/push.js/assignees{/user}","branches_url":"https://api.github.com/repos/officeluv/push.js/branches{/branch}","tags_url":"https://api.github.com/repos/officeluv/push.js/tags","blobs_url":"https://api.github.com/repos/officeluv/push.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/officeluv/push.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/officeluv/push.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/officeluv/push.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/officeluv/push.js/statuses/{sha}","languages_url":"https://api.github.com/repos/officeluv/push.js/languages","stargazers_url":"https://api.github.com/repos/officeluv/push.js/stargazers","contributors_url":"https://api.github.com/repos/officeluv/push.js/contributors","subscribers_url":"https://api.github.com/repos/officeluv/push.js/subscribers","subscription_url":"https://api.github.com/repos/officeluv/push.js/subscription","commits_url":"https://api.github.com/repos/officeluv/push.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/officeluv/push.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/officeluv/push.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/officeluv/push.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/officeluv/push.js/contents/{+path}","compare_url":"https://api.github.com/repos/officeluv/push.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/officeluv/push.js/merges","archive_url":"https://api.github.com/repos/officeluv/push.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/officeluv/push.js/downloads","issues_url":"https://api.github.com/repos/officeluv/push.js/issues{/number}","pulls_url":"https://api.github.com/repos/officeluv/push.js/pulls{/number}","milestones_url":"https://api.github.com/repos/officeluv/push.js/milestones{/number}","notifications_url":"https://api.github.com/repos/officeluv/push.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/officeluv/push.js/labels{/name}","releases_url":"https://api.github.com/repos/officeluv/push.js/releases{/id}","deployments_url":"https://api.github.com/repos/officeluv/push.js/deployments","created_at":"2018-10-17T14:52:24Z","updated_at":"2018-10-17T15:37:12Z","pushed_at":"2018-10-22T19:19:31Z","git_url":"git://github.com/officeluv/push.js.git","ssh_url":"git@github.com:officeluv/push.js.git","clone_url":"https://github.com/officeluv/push.js.git","svn_url":"https://github.com/officeluv/push.js","homepage":"https://pushjs.org","size":2603,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Nickersoft:master","ref":"master","sha":"8ebfdadd659ca8c3ee8b0d4fa7ff97010607f401","user":{"login":"Nickersoft","id":2104129,"node_id":"MDQ6VXNlcjIxMDQxMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2104129?v=4","gravatar_id":"","url":"https://api.github.com/users/Nickersoft","html_url":"https://github.com/Nickersoft","followers_url":"https://api.github.com/users/Nickersoft/followers","following_url":"https://api.github.com/users/Nickersoft/following{/other_user}","gists_url":"https://api.github.com/users/Nickersoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Nickersoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nickersoft/subscriptions","organizations_url":"https://api.github.com/users/Nickersoft/orgs","repos_url":"https://api.github.com/users/Nickersoft/repos","events_url":"https://api.github.com/users/Nickersoft/events{/privacy}","received_events_url":"https://api.github.com/users/Nickersoft/received_events","type":"User","site_admin":false},"repo":{"id":39357088,"node_id":"MDEwOlJlcG9zaXRvcnkzOTM1NzA4OA==","name":"push.js","full_name":"Nickersoft/push.js","private":false,"owner":{"login":"Nickersoft","id":2104129,"node_id":"MDQ6VXNlcjIxMDQxMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2104129?v=4","gravatar_id":"","url":"https://api.github.com/users/Nickersoft","html_url":"https://github.com/Nickersoft","followers_url":"https://api.github.com/users/Nickersoft/followers","following_url":"https://api.github.com/users/Nickersoft/following{/other_user}","gists_url":"https://api.github.com/users/Nickersoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Nickersoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nickersoft/subscriptions","organizations_url":"https://api.github.com/users/Nickersoft/orgs","repos_url":"https://api.github.com/users/Nickersoft/repos","events_url":"https://api.github.com/users/Nickersoft/events{/privacy}","received_events_url":"https://api.github.com/users/Nickersoft/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Nickersoft/push.js","description":"The world's most versatile desktop notifications framework :earth_americas:","fork":false,"url":"https://api.github.com/repos/Nickersoft/push.js","forks_url":"https://api.github.com/repos/Nickersoft/push.js/forks","keys_url":"https://api.github.com/repos/Nickersoft/push.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nickersoft/push.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nickersoft/push.js/teams","hooks_url":"https://api.github.com/repos/Nickersoft/push.js/hooks","issue_events_url":"https://api.github.com/repos/Nickersoft/push.js/issues/events{/number}","events_url":"https://api.github.com/repos/Nickersoft/push.js/events","assignees_url":"https://api.github.com/repos/Nickersoft/push.js/assignees{/user}","branches_url":"https://api.github.com/repos/Nickersoft/push.js/branches{/branch}","tags_url":"https://api.github.com/repos/Nickersoft/push.js/tags","blobs_url":"https://api.github.com/repos/Nickersoft/push.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nickersoft/push.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nickersoft/push.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nickersoft/push.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nickersoft/push.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Nickersoft/push.js/languages","stargazers_url":"https://api.github.com/repos/Nickersoft/push.js/stargazers","contributors_url":"https://api.github.com/repos/Nickersoft/push.js/contributors","subscribers_url":"https://api.github.com/repos/Nickersoft/push.js/subscribers","subscription_url":"https://api.github.com/repos/Nickersoft/push.js/subscription","commits_url":"https://api.github.com/repos/Nickersoft/push.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nickersoft/push.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nickersoft/push.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nickersoft/push.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nickersoft/push.js/contents/{+path}","compare_url":"https://api.github.com/repos/Nickersoft/push.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nickersoft/push.js/merges","archive_url":"https://api.github.com/repos/Nickersoft/push.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nickersoft/push.js/downloads","issues_url":"https://api.github.com/repos/Nickersoft/push.js/issues{/number}","pulls_url":"https://api.github.com/repos/Nickersoft/push.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Nickersoft/push.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Nickersoft/push.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nickersoft/push.js/labels{/name}","releases_url":"https://api.github.com/repos/Nickersoft/push.js/releases{/id}","deployments_url":"https://api.github.com/repos/Nickersoft/push.js/deployments","created_at":"2015-07-20T01:46:04Z","updated_at":"2018-10-22T11:51:45Z","pushed_at":"2018-10-22T17:20:01Z","git_url":"git://github.com/Nickersoft/push.js.git","ssh_url":"git@github.com:Nickersoft/push.js.git","clone_url":"https://github.com/Nickersoft/push.js.git","svn_url":"https://github.com/Nickersoft/push.js","homepage":"https://pushjs.org","size":2650,"stargazers_count":7643,"watchers_count":7643,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":442,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":442,"open_issues":20,"watchers":7643,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nickersoft/push.js/pulls/192"},"html":{"href":"https://github.com/Nickersoft/push.js/pull/192"},"issue":{"href":"https://api.github.com/repos/Nickersoft/push.js/issues/192"},"comments":{"href":"https://api.github.com/repos/Nickersoft/push.js/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/Nickersoft/push.js/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/Nickersoft/push.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nickersoft/push.js/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/Nickersoft/push.js/statuses/00def1e62bc65927d722bdbaa57488d16249b07e"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":22,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"andjosh"}}