{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20116","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20116/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20116/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20116/events","html_url":"https://github.com/nodejs/node/pull/20116","id":315324752,"number":20116,"title":"test: check that modules backed by read-only files can load (win32)","user":{"login":"billti","id":993909,"avatar_url":"https://avatars3.githubusercontent.com/u/993909?v=4","gravatar_id":"","url":"https://api.github.com/users/billti","html_url":"https://github.com/billti","followers_url":"https://api.github.com/users/billti/followers","following_url":"https://api.github.com/users/billti/following{/other_user}","gists_url":"https://api.github.com/users/billti/gists{/gist_id}","starred_url":"https://api.github.com/users/billti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billti/subscriptions","organizations_url":"https://api.github.com/users/billti/orgs","repos_url":"https://api.github.com/users/billti/repos","events_url":"https://api.github.com/users/billti/events{/privacy}","received_events_url":"https://api.github.com/users/billti/received_events","type":"User","site_admin":false},"labels":[{"id":362054330,"url":"https://api.github.com/repos/nodejs/node/labels/blocked","name":"blocked","color":"b60205","default":false},{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false},{"id":904071494,"url":"https://api.github.com/repos/nodejs/node/labels/v10.x","name":"v10.x","color":"4213c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-04-18T04:14:28Z","updated_at":"2018-04-18T17:14:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20116","html_url":"https://github.com/nodejs/node/pull/20116","diff_url":"https://github.com/nodejs/node/pull/20116.diff","patch_url":"https://github.com/nodejs/node/pull/20116.patch"},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\nThis is the test-case for the issue at https://github.com/nodejs/node/issues/20112 . This fails with the issue present, and passes with the fix applied. \r\n\r\nNote: Even before any changes, `vcbuild test` gave a ton of failures for me, so not sure if that is my machine or something more fundamental. This test behaves as expected though.\r\n\r\nCC @vsemozhetbyt, @cjihrig, @richardlau "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/382461729","html_url":"https://github.com/nodejs/node/pull/20116#issuecomment-382461729","issue_url":"https://api.github.com/repos/nodejs/node/issues/20116","id":382461729,"user":{"login":"Trott","id":718899,"avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T17:14:53Z","updated_at":"2018-04-18T17:14:53Z","author_association":"OWNER","body":"`vcbuild lint` will flag a bunch of stuff on this file (or at least should) like needing a `'use strict';` and requiring the test `common` module. But I think those will be easy fixes. "}}
{"actor":{"display_login":"Trott"}}