{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kops/issues/4941","repository_url":"https://api.github.com/repos/kubernetes/kops","labels_url":"https://api.github.com/repos/kubernetes/kops/issues/4941/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/4941/comments","events_url":"https://api.github.com/repos/kubernetes/kops/issues/4941/events","html_url":"https://github.com/kubernetes/kops/pull/4941","id":312354039,"number":4941,"title":"Fail when unable to mount etcd volumes","user":{"login":"johanneswuerbach","id":864578,"avatar_url":"https://avatars1.githubusercontent.com/u/864578?v=4","gravatar_id":"","url":"https://api.github.com/users/johanneswuerbach","html_url":"https://github.com/johanneswuerbach","followers_url":"https://api.github.com/users/johanneswuerbach/followers","following_url":"https://api.github.com/users/johanneswuerbach/following{/other_user}","gists_url":"https://api.github.com/users/johanneswuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneswuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneswuerbach/subscriptions","organizations_url":"https://api.github.com/users/johanneswuerbach/orgs","repos_url":"https://api.github.com/users/johanneswuerbach/repos","events_url":"https://api.github.com/users/johanneswuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/johanneswuerbach/received_events","type":"User","site_admin":false},"labels":[{"id":485059302,"url":"https://api.github.com/repos/kubernetes/kops/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676572687,"url":"https://api.github.com/repos/kubernetes/kops/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-08T23:51:26Z","updated_at":"2018-04-09T20:50:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/4941","html_url":"https://github.com/kubernetes/kops/pull/4941","diff_url":"https://github.com/kubernetes/kops/pull/4941.diff","patch_url":"https://github.com/kubernetes/kops/pull/4941.patch"},"body":"When the old master instance took some time to terminate the EBS volumes aren't mountable yet. Fail hard to ensure etcd and the kubelet are not starting before the volume is mounted.\r\n\r\nPotentially fixes https://github.com/kubernetes/kops/issues/4128"},"comment":{"url":"https://api.github.com/repos/kubernetes/kops/issues/comments/379889728","html_url":"https://github.com/kubernetes/kops/pull/4941#issuecomment-379889728","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/4941","id":379889728,"user":{"login":"johanneswuerbach","id":864578,"avatar_url":"https://avatars1.githubusercontent.com/u/864578?v=4","gravatar_id":"","url":"https://api.github.com/users/johanneswuerbach","html_url":"https://github.com/johanneswuerbach","followers_url":"https://api.github.com/users/johanneswuerbach/followers","following_url":"https://api.github.com/users/johanneswuerbach/following{/other_user}","gists_url":"https://api.github.com/users/johanneswuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneswuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneswuerbach/subscriptions","organizations_url":"https://api.github.com/users/johanneswuerbach/orgs","repos_url":"https://api.github.com/users/johanneswuerbach/repos","events_url":"https://api.github.com/users/johanneswuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/johanneswuerbach/received_events","type":"User","site_admin":false},"created_at":"2018-04-09T20:50:21Z","updated_at":"2018-04-09T20:50:21Z","author_association":"CONTRIBUTOR","body":"@justinsb following the code further I see how this works now and you are right.\r\n\r\nIn our cluster we had some cases when during a cluster rolling an old master server took a really long time to terminate, the replacement master booted already and the cluster was somehow marked as healthy without actually being able to unmount and remount the etcd EBS volumes from the old master to new master as they were still in-use.\r\n\r\nThe rolling proceeded afterwards and another master was killed causing an etcd quorum loss. Sadly I wasn't able to debug this further, but you are saying that shouldn't happen, correct?"}}
{"actor":{"display_login":"johanneswuerbach"}}