{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/173126851","pull_request_review_id":102260898,"id":173126851,"diff_hunk":"@@ -338,14 +333,9 @@ private KafkaStreams buildStreams(\n         StreamsConfig.CACHE_MAX_BYTES_BUFFERING_CONFIG,\n         ksqlConfig.get(StreamsConfig.CACHE_MAX_BYTES_BUFFERING_CONFIG)\n     );\n-    if (ksqlConfig.get(KsqlConfig.KSQL_TIMESTAMP_COLUMN_INDEX) != null) {","path":"ksql-engine/src/main/java/io/confluent/ksql/physical/PhysicalPlanBuilder.java","position":109,"original_position":109,"commit_id":"bbfa4cc1792d653aee4994ed62ef014099d9ebec","original_commit_id":"b3ee8ee1c0a4ee8588aaebe003619fed5557ca3b","user":{"login":"dguy","id":54829,"avatar_url":"https://avatars2.githubusercontent.com/u/54829?v=4","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},"body":"@hjafarpour - in KStreams the timestamp of a stream/stream join will come from the side that triggered the join.","created_at":"2018-03-08T11:00:41Z","updated_at":"2018-03-08T11:00:41Z","html_url":"https://github.com/confluentinc/ksql/pull/756#discussion_r173126851","pull_request_url":"https://api.github.com/repos/confluentinc/ksql/pulls/756","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/173126851"},"html":{"href":"https://github.com/confluentinc/ksql/pull/756#discussion_r173126851"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/756"}},"in_reply_to_id":171106343},"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/756","id":170253007,"html_url":"https://github.com/confluentinc/ksql/pull/756","diff_url":"https://github.com/confluentinc/ksql/pull/756.diff","patch_url":"https://github.com/confluentinc/ksql/pull/756.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/756","number":756,"state":"open","locked":false,"title":"Add the ability to extract the record timestamp from a string field #646","user":{"login":"dguy","id":54829,"avatar_url":"https://avatars2.githubusercontent.com/u/54829?v=4","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},"body":"updated the `with()` syntax to be able to specify a timestamp_formate, i.e.,  `timestamp_format='yyyy-MM-dd`\r\nFixed tests that didn't work correctly, i.e., specifying `ROWTIME` as the `timestamp` can't work as `ROWTIME` is added AFTER the timestamp has been extracted.\r\n\r\nFixes #646 ","created_at":"2018-02-20T17:06:58Z","updated_at":"2018-03-08T11:00:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"491f6efdb7b51aeed07697d707ed4069de99f180","assignee":null,"assignees":[],"requested_reviewers":[{"login":"apurvam","id":830220,"avatar_url":"https://avatars0.githubusercontent.com/u/830220?v=4","gravatar_id":"","url":"https://api.github.com/users/apurvam","html_url":"https://github.com/apurvam","followers_url":"https://api.github.com/users/apurvam/followers","following_url":"https://api.github.com/users/apurvam/following{/other_user}","gists_url":"https://api.github.com/users/apurvam/gists{/gist_id}","starred_url":"https://api.github.com/users/apurvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apurvam/subscriptions","organizations_url":"https://api.github.com/users/apurvam/orgs","repos_url":"https://api.github.com/users/apurvam/repos","events_url":"https://api.github.com/users/apurvam/events{/privacy}","received_events_url":"https://api.github.com/users/apurvam/received_events","type":"User","site_admin":false},{"login":"bluemonk3y","id":10532006,"avatar_url":"https://avatars3.githubusercontent.com/u/10532006?v=4","gravatar_id":"","url":"https://api.github.com/users/bluemonk3y","html_url":"https://github.com/bluemonk3y","followers_url":"https://api.github.com/users/bluemonk3y/followers","following_url":"https://api.github.com/users/bluemonk3y/following{/other_user}","gists_url":"https://api.github.com/users/bluemonk3y/gists{/gist_id}","starred_url":"https://api.github.com/users/bluemonk3y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluemonk3y/subscriptions","organizations_url":"https://api.github.com/users/bluemonk3y/orgs","repos_url":"https://api.github.com/users/bluemonk3y/repos","events_url":"https://api.github.com/users/bluemonk3y/events{/privacy}","received_events_url":"https://api.github.com/users/bluemonk3y/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/756/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/756/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/756/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/bbfa4cc1792d653aee4994ed62ef014099d9ebec","head":{"label":"dguy:ksql-646","ref":"ksql-646","sha":"bbfa4cc1792d653aee4994ed62ef014099d9ebec","user":{"login":"dguy","id":54829,"avatar_url":"https://avatars2.githubusercontent.com/u/54829?v=4","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},"repo":{"id":105937514,"name":"ksql","full_name":"dguy/ksql","owner":{"login":"dguy","id":54829,"avatar_url":"https://avatars2.githubusercontent.com/u/54829?v=4","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dguy/ksql","description":"KSQL - a Streaming SQL Engine for Apache Kafka ","fork":true,"url":"https://api.github.com/repos/dguy/ksql","forks_url":"https://api.github.com/repos/dguy/ksql/forks","keys_url":"https://api.github.com/repos/dguy/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dguy/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dguy/ksql/teams","hooks_url":"https://api.github.com/repos/dguy/ksql/hooks","issue_events_url":"https://api.github.com/repos/dguy/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/dguy/ksql/events","assignees_url":"https://api.github.com/repos/dguy/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/dguy/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/dguy/ksql/tags","blobs_url":"https://api.github.com/repos/dguy/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dguy/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dguy/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/dguy/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dguy/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/dguy/ksql/languages","stargazers_url":"https://api.github.com/repos/dguy/ksql/stargazers","contributors_url":"https://api.github.com/repos/dguy/ksql/contributors","subscribers_url":"https://api.github.com/repos/dguy/ksql/subscribers","subscription_url":"https://api.github.com/repos/dguy/ksql/subscription","commits_url":"https://api.github.com/repos/dguy/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/dguy/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/dguy/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/dguy/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/dguy/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/dguy/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dguy/ksql/merges","archive_url":"https://api.github.com/repos/dguy/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dguy/ksql/downloads","issues_url":"https://api.github.com/repos/dguy/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/dguy/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/dguy/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/dguy/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dguy/ksql/labels{/name}","releases_url":"https://api.github.com/repos/dguy/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/dguy/ksql/deployments","created_at":"2017-10-05T20:33:32Z","updated_at":"2017-10-05T20:33:35Z","pushed_at":"2018-03-08T09:29:43Z","git_url":"git://github.com/dguy/ksql.git","ssh_url":"git@github.com:dguy/ksql.git","clone_url":"https://github.com/dguy/ksql.git","svn_url":"https://github.com/dguy/ksql","homepage":"","size":6153,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.1.x"}},"base":{"label":"confluentinc:4.1.x","ref":"4.1.x","sha":"38448c754b4fc625903e1ebc02c0619e9982d927","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"name":"ksql","full_name":"confluentinc/ksql","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2018-03-08T02:50:00Z","pushed_at":"2018-03-08T10:56:17Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"git@github.com:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":6476,"stargazers_count":1428,"watchers_count":1428,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":257,"mirror_url":null,"archived":false,"open_issues_count":174,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":257,"open_issues":174,"watchers":1428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/756"},"html":{"href":"https://github.com/confluentinc/ksql/pull/756"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/756"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/756/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/756/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/756/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/bbfa4cc1792d653aee4994ed62ef014099d9ebec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dguy"}}