{"action":"created","comment":{"url":"https://api.github.com/repos/redhat-developer/odo/pulls/comments/230715060","pull_request_review_id":171510900,"id":230715060,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDcxNTA2MA==","diff_hunk":"@@ -45,12 +45,18 @@ var versionCmd = &cobra.Command{\n \t\t// Lets fetch the info about the server\n \t\tserverInfo, err := util.GetOcClient().GetServerVersion()\n \t\tutil.CheckError(err, \"\")\n+\n+\t\t// make sure we only include openshift info if we actually have it\n+\t\topenshiftStr := \"\"\n+\t\tif len(serverInfo.OpenShiftVersion) > 0 {","path":"cmd/version.go","position":7,"original_position":7,"commit_id":"4067a145471f5fd47107199a10ff0c1d42483078","original_commit_id":"4067a145471f5fd47107199a10ff0c1d42483078","user":{"login":"mik-dass","id":14028106,"node_id":"MDQ6VXNlcjE0MDI4MTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14028106?v=4","gravatar_id":"","url":"https://api.github.com/users/mik-dass","html_url":"https://github.com/mik-dass","followers_url":"https://api.github.com/users/mik-dass/followers","following_url":"https://api.github.com/users/mik-dass/following{/other_user}","gists_url":"https://api.github.com/users/mik-dass/gists{/gist_id}","starred_url":"https://api.github.com/users/mik-dass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mik-dass/subscriptions","organizations_url":"https://api.github.com/users/mik-dass/orgs","repos_url":"https://api.github.com/users/mik-dass/repos","events_url":"https://api.github.com/users/mik-dass/events{/privacy}","received_events_url":"https://api.github.com/users/mik-dass/received_events","type":"User","site_admin":false},"body":"ok :+1: ","created_at":"2018-11-05T11:20:12Z","updated_at":"2018-11-05T11:20:12Z","html_url":"https://github.com/redhat-developer/odo/pull/920#discussion_r230715060","pull_request_url":"https://api.github.com/repos/redhat-developer/odo/pulls/920","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/comments/230715060"},"html":{"href":"https://github.com/redhat-developer/odo/pull/920#discussion_r230715060"},"pull_request":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/920"}},"in_reply_to_id":230711165},"pull_request":{"url":"https://api.github.com/repos/redhat-developer/odo/pulls/920","id":227931304,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTMxMzA0","html_url":"https://github.com/redhat-developer/odo/pull/920","diff_url":"https://github.com/redhat-developer/odo/pull/920.diff","patch_url":"https://github.com/redhat-developer/odo/pull/920.patch","issue_url":"https://api.github.com/repos/redhat-developer/odo/issues/920","number":920,"state":"open","locked":false,"title":"Change version command to tolerate missing possible /version/openshift","user":{"login":"geoand","id":4374975,"node_id":"MDQ6VXNlcjQzNzQ5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"body":"What is the purpose of this change? What does it change?\r\n\r\nChange version command to tolerate missing possible /version/openshift\r\n\r\nThis is done because a cluster created with \"oc cluster up\" can in some\r\ncases (as is the case for OKD 3.11) the endpoint is missing completely\r\nand we don't want the tool to fail in such cases (following the example\r\nset by oc)\r\n\r\nWas the change discussed in an issue?\r\n#872\r\n\r\nHow to test changes?\r\n\r\nLaunch Minishift using OKD 3.11.\r\nDoing `odo version` should now yield all the expected output, except the `Openshift:....` line (which is the same behavior you'll see with `oc version` as well).\r\nWhen applying `odo version` against a proper Openshift cluster, or even one launched by Minishift that uses OKD 3.10, the `Openshift: ....` should be present","created_at":"2018-11-02T13:08:04Z","updated_at":"2018-11-05T11:20:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67b8bf3e859f82ed54419ebcad2a99b4b500da38","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-developer/odo/pulls/920/commits","review_comments_url":"https://api.github.com/repos/redhat-developer/odo/pulls/920/comments","review_comment_url":"https://api.github.com/repos/redhat-developer/odo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-developer/odo/issues/920/comments","statuses_url":"https://api.github.com/repos/redhat-developer/odo/statuses/4067a145471f5fd47107199a10ff0c1d42483078","head":{"label":"geoand:#872","ref":"#872","sha":"4067a145471f5fd47107199a10ff0c1d42483078","user":{"login":"geoand","id":4374975,"node_id":"MDQ6VXNlcjQzNzQ5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"repo":{"id":150595565,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA1OTU1NjU=","name":"odo","full_name":"geoand/odo","private":false,"owner":{"login":"geoand","id":4374975,"node_id":"MDQ6VXNlcjQzNzQ5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"html_url":"https://github.com/geoand/odo","description":"OpenShift Command line for Developers","fork":true,"url":"https://api.github.com/repos/geoand/odo","forks_url":"https://api.github.com/repos/geoand/odo/forks","keys_url":"https://api.github.com/repos/geoand/odo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoand/odo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoand/odo/teams","hooks_url":"https://api.github.com/repos/geoand/odo/hooks","issue_events_url":"https://api.github.com/repos/geoand/odo/issues/events{/number}","events_url":"https://api.github.com/repos/geoand/odo/events","assignees_url":"https://api.github.com/repos/geoand/odo/assignees{/user}","branches_url":"https://api.github.com/repos/geoand/odo/branches{/branch}","tags_url":"https://api.github.com/repos/geoand/odo/tags","blobs_url":"https://api.github.com/repos/geoand/odo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoand/odo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoand/odo/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoand/odo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoand/odo/statuses/{sha}","languages_url":"https://api.github.com/repos/geoand/odo/languages","stargazers_url":"https://api.github.com/repos/geoand/odo/stargazers","contributors_url":"https://api.github.com/repos/geoand/odo/contributors","subscribers_url":"https://api.github.com/repos/geoand/odo/subscribers","subscription_url":"https://api.github.com/repos/geoand/odo/subscription","commits_url":"https://api.github.com/repos/geoand/odo/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoand/odo/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoand/odo/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoand/odo/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoand/odo/contents/{+path}","compare_url":"https://api.github.com/repos/geoand/odo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoand/odo/merges","archive_url":"https://api.github.com/repos/geoand/odo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoand/odo/downloads","issues_url":"https://api.github.com/repos/geoand/odo/issues{/number}","pulls_url":"https://api.github.com/repos/geoand/odo/pulls{/number}","milestones_url":"https://api.github.com/repos/geoand/odo/milestones{/number}","notifications_url":"https://api.github.com/repos/geoand/odo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoand/odo/labels{/name}","releases_url":"https://api.github.com/repos/geoand/odo/releases{/id}","deployments_url":"https://api.github.com/repos/geoand/odo/deployments","created_at":"2018-09-27T13:58:37Z","updated_at":"2018-10-18T06:53:38Z","pushed_at":"2018-11-05T05:49:58Z","git_url":"git://github.com/geoand/odo.git","ssh_url":"git@github.com:geoand/odo.git","clone_url":"https://github.com/geoand/odo.git","svn_url":"https://github.com/geoand/odo","homepage":"","size":92750,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redhat-developer:master","ref":"master","sha":"da250f3c6841297c9c1b88cf03e5cb5cbd469f04","user":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"repo":{"id":118630356,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2MzAzNTY=","name":"odo","full_name":"redhat-developer/odo","private":false,"owner":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/redhat-developer/odo","description":"OpenShift Command line for Developers","fork":false,"url":"https://api.github.com/repos/redhat-developer/odo","forks_url":"https://api.github.com/repos/redhat-developer/odo/forks","keys_url":"https://api.github.com/repos/redhat-developer/odo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-developer/odo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-developer/odo/teams","hooks_url":"https://api.github.com/repos/redhat-developer/odo/hooks","issue_events_url":"https://api.github.com/repos/redhat-developer/odo/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-developer/odo/events","assignees_url":"https://api.github.com/repos/redhat-developer/odo/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-developer/odo/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-developer/odo/tags","blobs_url":"https://api.github.com/repos/redhat-developer/odo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-developer/odo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-developer/odo/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-developer/odo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-developer/odo/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-developer/odo/languages","stargazers_url":"https://api.github.com/repos/redhat-developer/odo/stargazers","contributors_url":"https://api.github.com/repos/redhat-developer/odo/contributors","subscribers_url":"https://api.github.com/repos/redhat-developer/odo/subscribers","subscription_url":"https://api.github.com/repos/redhat-developer/odo/subscription","commits_url":"https://api.github.com/repos/redhat-developer/odo/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-developer/odo/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-developer/odo/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-developer/odo/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-developer/odo/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-developer/odo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-developer/odo/merges","archive_url":"https://api.github.com/repos/redhat-developer/odo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-developer/odo/downloads","issues_url":"https://api.github.com/repos/redhat-developer/odo/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-developer/odo/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-developer/odo/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-developer/odo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-developer/odo/labels{/name}","releases_url":"https://api.github.com/repos/redhat-developer/odo/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-developer/odo/deployments","created_at":"2018-01-23T15:36:17Z","updated_at":"2018-11-05T06:42:00Z","pushed_at":"2018-11-05T10:49:04Z","git_url":"git://github.com/redhat-developer/odo.git","ssh_url":"git@github.com:redhat-developer/odo.git","clone_url":"https://github.com/redhat-developer/odo.git","svn_url":"https://github.com/redhat-developer/odo","homepage":"","size":92703,"stargazers_count":264,"watchers_count":264,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":150,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":54,"open_issues":150,"watchers":264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/920"},"html":{"href":"https://github.com/redhat-developer/odo/pull/920"},"issue":{"href":"https://api.github.com/repos/redhat-developer/odo/issues/920"},"comments":{"href":"https://api.github.com/repos/redhat-developer/odo/issues/920/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/920/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/920/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-developer/odo/statuses/4067a145471f5fd47107199a10ff0c1d42483078"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mik-dass"}}