{"action":"created","issue":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/5884","repository_url":"https://api.github.com/repos/shuyangzhou/liferay-portal","labels_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/5884/labels{/name}","comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/5884/comments","events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/5884/events","html_url":"https://github.com/shuyangzhou/liferay-portal/pull/5884","id":308202670,"number":5884,"title":"LPS-79121 Remove spring AOP in workflow-spring.xml","user":{"login":"tinatian","id":860623,"avatar_url":"https://avatars0.githubusercontent.com/u/860623?v=4","gravatar_id":"","url":"https://api.github.com/users/tinatian","html_url":"https://github.com/tinatian","followers_url":"https://api.github.com/users/tinatian/followers","following_url":"https://api.github.com/users/tinatian/following{/other_user}","gists_url":"https://api.github.com/users/tinatian/gists{/gist_id}","starred_url":"https://api.github.com/users/tinatian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinatian/subscriptions","organizations_url":"https://api.github.com/users/tinatian/orgs","repos_url":"https://api.github.com/users/tinatian/repos","events_url":"https://api.github.com/users/tinatian/events{/privacy}","received_events_url":"https://api.github.com/users/tinatian/received_events","type":"User","site_admin":false},"labels":[{"id":868566587,"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/labels/ci:test%20-%20failure","name":"ci:test - failure","color":"fccdcc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-03-23T23:05:17Z","updated_at":"2018-03-24T13:59:00Z","closed_at":"2018-03-24T03:08:34Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/5884","html_url":"https://github.com/shuyangzhou/liferay-portal/pull/5884","diff_url":"https://github.com/shuyangzhou/liferay-portal/pull/5884.diff","patch_url":"https://github.com/shuyangzhou/liferay-portal/pull/5884.patch"},"body":"Hi Shuyang,\r\n\r\nThis pull is to remove aop config in workflow-spring.xml. I tested it locally, it works. Let's wait for CI result to see if it breaks any logic.\r\n\r\n\r\nThanks.\r\nTina."},"comment":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/comments/375891307","html_url":"https://github.com/shuyangzhou/liferay-portal/pull/5884#issuecomment-375891307","issue_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/5884","id":375891307,"user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars2.githubusercontent.com/u/173369?v=4","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"created_at":"2018-03-24T13:59:00Z","updated_at":"2018-03-24T13:59:00Z","author_association":"OWNER","body":"@tinatina it is the :\r\n```\r\n\t<bean class=\"com.liferay.portal.spring.aop.DynamicProxyCreator$Register\">\r\n\t\t<constructor-arg>\r\n\t\t\t<bean class=\"com.liferay.portal.messaging.proxy.MessagingProxyBeanMatcher\">\r\n\t\t\t\t<property name=\"beanClass\" value=\"com.liferay.portal.kernel.messaging.proxy.BaseProxyBean\" />\r\n\t\t\t\t<property name=\"beanNamePattern\" value=\"com.liferay.portal.workflow.*ProxyBean\" />\r\n\t\t\t</bean>\r\n\t\t</constructor-arg>\r\n\t\t<constructor-arg>\r\n\t\t\t<bean class=\"com.liferay.portal.kernel.messaging.proxy.MessagingProxyInvocationHandler\" factory-method=\"getInvocationHandlerFactory\" />\r\n\t\t</constructor-arg>\r\n\t</bean>\r\n```\r\nsection causing the issue, let's convert that one into regular wrappers first. Make sure that works fine, then redo this, and make sure to read the commits from my the other pull to add in the changes I did."}}
{"actor":{"display_login":"shuyangzhou"}}