{"action":"created","comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/228322337","pull_request_review_id":168571255,"id":228322337,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODMyMjMzNw==","diff_hunk":"@@ -0,0 +1,807 @@\n+//================= Hercules Script =======================================\n+//=       _   _                     _\n+//=      | | | |                   | |\n+//=      | |_| | ___ _ __ ___ _   _| | ___  ___\n+//=      |  _  |/ _ \\ '__/ __| | | | |/ _ \\/ __|\n+//=      | | | |  __/ | | (__| |_| | |  __/\\__ \\\n+//=      \\_| |_/\\___|_|  \\___|\\__,_|_|\\___||___/\n+//================= License ===============================================\n+//= This file is part of Hercules.\n+//= http://herc.ws - http://github.com/HerculesWS/Hercules\n+//=\n+//= Copyright (C) Hercules Dev Team\n+//= Copyright (C) Kisuka\n+//=\n+//= Hercules is free software: you can redistribute it and/or modify\n+//= it under the terms of the GNU General Public License as published by\n+//= the Free Software Foundation, either version 3 of the License, or\n+//= (at your option) any later version.\n+//=\n+//= This program is distributed in the hope that it will be useful,\n+//= but WITHOUT ANY WARRANTY; without even the implied warranty of\n+//= MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+//= GNU General Public License for more details.\n+//=\n+//= You should have received a copy of the GNU General Public License\n+//= along with this program.  If not, see <http://www.gnu.org/licenses/>.\n+//=========================================================================\n+//= April Fools Day Event (2010)\n+//================= Description ===========================================\n+//= Help Romeo lie to everyone.\n+//================= Current Version =======================================\n+//= 1.0\n+//=========================================================================\n+\n+// - Nosy Little Girl (Quest Start)\n+// -----------------------------------------------------------\n+prontera,146,98,6\tscript\tNosy Little Girl#prt\t4_F_LGTGIRL,{\n+\tif  (evt_2010_fools < 129) {","path":"npc/events/aprilfools_2010.txt","position":38,"original_position":38,"commit_id":"214ded75c7a634918236ccfbe75b3685b4b80e51","original_commit_id":"29c2ee58f6f9e5ae9c85558156a262b5c12c5aa4","user":{"login":"Asheraf","id":14294215,"node_id":"MDQ6VXNlcjE0Mjk0MjE1","avatar_url":"https://avatars1.githubusercontent.com/u/14294215?v=4","gravatar_id":"","url":"https://api.github.com/users/Asheraf","html_url":"https://github.com/Asheraf","followers_url":"https://api.github.com/users/Asheraf/followers","following_url":"https://api.github.com/users/Asheraf/following{/other_user}","gists_url":"https://api.github.com/users/Asheraf/gists{/gist_id}","starred_url":"https://api.github.com/users/Asheraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asheraf/subscriptions","organizations_url":"https://api.github.com/users/Asheraf/orgs","repos_url":"https://api.github.com/users/Asheraf/repos","events_url":"https://api.github.com/users/Asheraf/events{/privacy}","received_events_url":"https://api.github.com/users/Asheraf/received_events","type":"User","site_admin":false},"body":"this has double space after the `if`","created_at":"2018-10-25T20:26:08Z","updated_at":"2018-10-25T20:35:04Z","html_url":"https://github.com/HerculesWS/Hercules/pull/2303#discussion_r228322337","pull_request_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2303","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/228322337"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/2303#discussion_r228322337"},"pull_request":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2303"}}},"pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2303","id":224581216,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTgxMjE2","html_url":"https://github.com/HerculesWS/Hercules/pull/2303","diff_url":"https://github.com/HerculesWS/Hercules/pull/2303.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/2303.patch","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2303","number":2303,"state":"open","locked":false,"title":"Added some missing events.","user":{"login":"kisuka","id":934924,"node_id":"MDQ6VXNlcjkzNDkyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/934924?v=4","gravatar_id":"","url":"https://api.github.com/users/kisuka","html_url":"https://github.com/kisuka","followers_url":"https://api.github.com/users/kisuka/followers","following_url":"https://api.github.com/users/kisuka/following{/other_user}","gists_url":"https://api.github.com/users/kisuka/gists{/gist_id}","starred_url":"https://api.github.com/users/kisuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kisuka/subscriptions","organizations_url":"https://api.github.com/users/kisuka/orgs","repos_url":"https://api.github.com/users/kisuka/repos","events_url":"https://api.github.com/users/kisuka/events{/privacy}","received_events_url":"https://api.github.com/users/kisuka/received_events","type":"User","site_admin":false},"body":"[//]: # (**********************************)\r\n[//]: # (** Fill in the following fields **)\r\n[//]: # (**********************************)\r\n\r\n[//]: # (Note: Lines beginning with syntax such as this one, are comments and will not be visible in your report!)\r\n\r\n### Pull Request Prelude\r\n\r\n[//]: # (Thank you for working on improving Hercules!)\r\n\r\n[//]: # (Please complete these steps and check the following boxes by putting an `x` inside the brackets _before_ filing your Pull Request.)\r\n\r\n- [x] I have followed [proper Hercules code styling][code].\r\n- [x] I have read and understood the [contribution guidelines][cont] before making this PR.\r\n- [x] I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.\r\n\r\n### Changes Proposed\r\n\r\n[//]: # (Describe at length, the changes that this pull request makes.)\r\n\r\n**Affected Branches:** \r\n\r\n- (Master)\r\n\r\n**Issues addressed:**\r\n\r\nSurprisingly I'm not completely done contributing to this project. :p\r\n\r\nI took some time this last week or so to go through some of the missing event scripts as well as fix some stuff up.\r\n\r\nThis Pull Requests does the following:\r\n\r\n* Adds 2006 Xmas event script.\r\n* Adds 2007 Xmas event script.\r\n* Adds 2009 Xmas event script.\r\n* Adds 2010 Xmas event script.\r\n* Adds 2010 Valetine's Day event script.\r\n* Adds 2010 April Fool's Day event script.\r\n* Properly dates the existing Xmas, Whiteday, and Valetine's Day scripts.\r\n\r\nThe dates for the 2004 scripts were confirmed by looking through jAthena files and comparing the quest's contents with event posts from jRO, iRO, and kRO.\r\n\r\nI'll be back with more scripts later.\r\n\r\n### Known Issues and TODO List\r\n\r\n[//]: # (Insert checklist here)\r\n[//]: # (Syntax: - [ ] Checkbox)\r\n\r\n[//]: # (**NOTE** Enable the setting \"[√] Allow edits from maintainers.\" when creating your pull request if you have not already enabled it.)\r\n\r\n[cont]: https://github.com/HerculesWS/Hercules/blob/master/CONTRIBUTING.md\r\n[code]: https://github.com/HerculesWS/Hercules/wiki/Coding-Style\r\n","created_at":"2018-10-22T02:52:53Z","updated_at":"2018-10-25T20:35:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8160ef5a52f3589901fde1b3e777194bad99be64","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dastgirp","id":2889931,"node_id":"MDQ6VXNlcjI4ODk5MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/2889931?v=4","gravatar_id":"","url":"https://api.github.com/users/dastgirp","html_url":"https://github.com/dastgirp","followers_url":"https://api.github.com/users/dastgirp/followers","following_url":"https://api.github.com/users/dastgirp/following{/other_user}","gists_url":"https://api.github.com/users/dastgirp/gists{/gist_id}","starred_url":"https://api.github.com/users/dastgirp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dastgirp/subscriptions","organizations_url":"https://api.github.com/users/dastgirp/orgs","repos_url":"https://api.github.com/users/dastgirp/repos","events_url":"https://api.github.com/users/dastgirp/events{/privacy}","received_events_url":"https://api.github.com/users/dastgirp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2303/commits","review_comments_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2303/comments","review_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2303/comments","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/214ded75c7a634918236ccfbe75b3685b4b80e51","head":{"label":"kisuka:missing-events","ref":"missing-events","sha":"214ded75c7a634918236ccfbe75b3685b4b80e51","user":{"login":"kisuka","id":934924,"node_id":"MDQ6VXNlcjkzNDkyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/934924?v=4","gravatar_id":"","url":"https://api.github.com/users/kisuka","html_url":"https://github.com/kisuka","followers_url":"https://api.github.com/users/kisuka/followers","following_url":"https://api.github.com/users/kisuka/following{/other_user}","gists_url":"https://api.github.com/users/kisuka/gists{/gist_id}","starred_url":"https://api.github.com/users/kisuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kisuka/subscriptions","organizations_url":"https://api.github.com/users/kisuka/orgs","repos_url":"https://api.github.com/users/kisuka/repos","events_url":"https://api.github.com/users/kisuka/events{/privacy}","received_events_url":"https://api.github.com/users/kisuka/received_events","type":"User","site_admin":false},"repo":{"id":105978034,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU5NzgwMzQ=","name":"Hercules","full_name":"kisuka/Hercules","private":false,"owner":{"login":"kisuka","id":934924,"node_id":"MDQ6VXNlcjkzNDkyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/934924?v=4","gravatar_id":"","url":"https://api.github.com/users/kisuka","html_url":"https://github.com/kisuka","followers_url":"https://api.github.com/users/kisuka/followers","following_url":"https://api.github.com/users/kisuka/following{/other_user}","gists_url":"https://api.github.com/users/kisuka/gists{/gist_id}","starred_url":"https://api.github.com/users/kisuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kisuka/subscriptions","organizations_url":"https://api.github.com/users/kisuka/orgs","repos_url":"https://api.github.com/users/kisuka/repos","events_url":"https://api.github.com/users/kisuka/events{/privacy}","received_events_url":"https://api.github.com/users/kisuka/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kisuka/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":true,"url":"https://api.github.com/repos/kisuka/Hercules","forks_url":"https://api.github.com/repos/kisuka/Hercules/forks","keys_url":"https://api.github.com/repos/kisuka/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kisuka/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kisuka/Hercules/teams","hooks_url":"https://api.github.com/repos/kisuka/Hercules/hooks","issue_events_url":"https://api.github.com/repos/kisuka/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/kisuka/Hercules/events","assignees_url":"https://api.github.com/repos/kisuka/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/kisuka/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/kisuka/Hercules/tags","blobs_url":"https://api.github.com/repos/kisuka/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kisuka/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kisuka/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/kisuka/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kisuka/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/kisuka/Hercules/languages","stargazers_url":"https://api.github.com/repos/kisuka/Hercules/stargazers","contributors_url":"https://api.github.com/repos/kisuka/Hercules/contributors","subscribers_url":"https://api.github.com/repos/kisuka/Hercules/subscribers","subscription_url":"https://api.github.com/repos/kisuka/Hercules/subscription","commits_url":"https://api.github.com/repos/kisuka/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/kisuka/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/kisuka/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/kisuka/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/kisuka/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/kisuka/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kisuka/Hercules/merges","archive_url":"https://api.github.com/repos/kisuka/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kisuka/Hercules/downloads","issues_url":"https://api.github.com/repos/kisuka/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/kisuka/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/kisuka/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/kisuka/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kisuka/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/kisuka/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/kisuka/Hercules/deployments","created_at":"2017-10-06T07:26:50Z","updated_at":"2018-10-22T02:43:14Z","pushed_at":"2018-10-25T18:37:25Z","git_url":"git://github.com/kisuka/Hercules.git","ssh_url":"git@github.com:kisuka/Hercules.git","clone_url":"https://github.com/kisuka/Hercules.git","svn_url":"https://github.com/kisuka/Hercules","homepage":"http://herc.ws","size":177177,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HerculesWS:master","ref":"master","sha":"4b01ca6dcd84ed49b27039eb872c7e89eaf169b6","user":{"login":"HerculesWS","id":3220669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjA2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"repo":{"id":7551429,"node_id":"MDEwOlJlcG9zaXRvcnk3NTUxNDI5","name":"Hercules","full_name":"HerculesWS/Hercules","private":false,"owner":{"login":"HerculesWS","id":3220669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjA2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HerculesWS/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":false,"url":"https://api.github.com/repos/HerculesWS/Hercules","forks_url":"https://api.github.com/repos/HerculesWS/Hercules/forks","keys_url":"https://api.github.com/repos/HerculesWS/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HerculesWS/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HerculesWS/Hercules/teams","hooks_url":"https://api.github.com/repos/HerculesWS/Hercules/hooks","issue_events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/HerculesWS/Hercules/events","assignees_url":"https://api.github.com/repos/HerculesWS/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/HerculesWS/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/HerculesWS/Hercules/tags","blobs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HerculesWS/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/HerculesWS/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/HerculesWS/Hercules/languages","stargazers_url":"https://api.github.com/repos/HerculesWS/Hercules/stargazers","contributors_url":"https://api.github.com/repos/HerculesWS/Hercules/contributors","subscribers_url":"https://api.github.com/repos/HerculesWS/Hercules/subscribers","subscription_url":"https://api.github.com/repos/HerculesWS/Hercules/subscription","commits_url":"https://api.github.com/repos/HerculesWS/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/HerculesWS/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/HerculesWS/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/HerculesWS/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HerculesWS/Hercules/merges","archive_url":"https://api.github.com/repos/HerculesWS/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HerculesWS/Hercules/downloads","issues_url":"https://api.github.com/repos/HerculesWS/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/HerculesWS/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/HerculesWS/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/HerculesWS/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/HerculesWS/Hercules/deployments","created_at":"2013-01-11T00:29:38Z","updated_at":"2018-10-25T16:43:42Z","pushed_at":"2018-10-25T18:37:35Z","git_url":"git://github.com/HerculesWS/Hercules.git","ssh_url":"git@github.com:HerculesWS/Hercules.git","clone_url":"https://github.com/HerculesWS/Hercules.git","svn_url":"https://github.com/HerculesWS/Hercules","homepage":"http://herc.ws","size":196134,"stargazers_count":475,"watchers_count":475,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":577,"mirror_url":null,"archived":false,"open_issues_count":468,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":577,"open_issues":468,"watchers":475,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2303"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/2303"},"issue":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/2303"},"comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/2303/comments"},"review_comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2303/comments"},"review_comment":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2303/commits"},"statuses":{"href":"https://api.github.com/repos/HerculesWS/Hercules/statuses/214ded75c7a634918236ccfbe75b3685b4b80e51"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Asheraf"}}