{"action":"opened","issue":{"url":"https://api.github.com/repos/schartmanna/prj-rev-bwfs-dasmoto/issues/1","repository_url":"https://api.github.com/repos/schartmanna/prj-rev-bwfs-dasmoto","labels_url":"https://api.github.com/repos/schartmanna/prj-rev-bwfs-dasmoto/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/schartmanna/prj-rev-bwfs-dasmoto/issues/1/comments","events_url":"https://api.github.com/repos/schartmanna/prj-rev-bwfs-dasmoto/issues/1/events","html_url":"https://github.com/schartmanna/prj-rev-bwfs-dasmoto/issues/1","id":372183666,"node_id":"MDU6SXNzdWUzNzIxODM2NjY=","number":1,"title":"Summary","user":{"login":"mml1","id":4342217,"node_id":"MDQ6VXNlcjQzNDIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4342217?v=4","gravatar_id":"","url":"https://api.github.com/users/mml1","html_url":"https://github.com/mml1","followers_url":"https://api.github.com/users/mml1/followers","following_url":"https://api.github.com/users/mml1/following{/other_user}","gists_url":"https://api.github.com/users/mml1/gists{/gist_id}","starred_url":"https://api.github.com/users/mml1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mml1/subscriptions","organizations_url":"https://api.github.com/users/mml1/orgs","repos_url":"https://api.github.com/users/mml1/repos","events_url":"https://api.github.com/users/mml1/events{/privacy}","received_events_url":"https://api.github.com/users/mml1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-20T07:28:28Z","updated_at":"2018-10-20T07:28:28Z","closed_at":null,"author_association":"NONE","body":"### Criteria 1: HTML and CSS Linking  \r\n* _Score Level:_ 4\r\n* _Comment(s):_ \r\nFantastic work using relative links to link the CSS file with the HTML file. Furthermore, awesome job using relative paths for your images.\r\n \r\n### Criteria 2: Implementation of Design Specification and Content\r\n* _Score Level:_ 4\r\n* _Comment(s):_ \r\nYour page visually matches the design specification(spec).\r\n\r\n### Criteria 3: HTML Elements and Content\r\n* _Score Level:_ 2\r\n* _Comment(s):_ \r\nWhen you code from a design spec, look at the content and see if you can divide the page into sections. Use div elements to be those \"sections\".\r\n For example:\r\n```\r\n<div class=\"item\">\r\n  <h2 id=\"brushes\" class=\"bold\">Brushes</h2>\r\n  <img src=\"./resources/images/hacksaw.jpg\" />\r\n  <h3>Hacksaw Brushes</h3>\r\n  <p>Made of the highest quality oak, Hacksaw brushes are known for their weight and ability to hold paint in large amounts. Available in different sizes. <strong>Starting at $3.00 / brush.</strong></p>\r\n</div>\r\n\r\n<div class=\"item\" >\r\n  <h2 id=\"frames\" class=\"bold\">Frames</h2>\r\n  <img src=\"./resources/images/frames.jpg\" />\r\n  <h3>Art Frames (assorted)</h3>\r\n  <p>Assorted frames made of different material, including MDF, birchwood, and PDE. Select frames can be sanded and painted according to your needs. <strong>Starting at $2.00 / frame.</strong></p>\r\n\r\n</div>\r\n```\r\n\r\nAlso, be careful with your indentations. Check out: https://github.com/schartmanna/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L11\r\n\r\nOne more tip, add alt tags to your images. Alt tags will help users who use screen readers to navigate your site.\r\n\r\n### Criteria 4: CSS Selectors and Syntax\r\n* _Score Level:_ 4\r\n* _Comment(s):_ \r\nGood job for correctly using ids and classes.  \r\n\r\n### Overall Score: 14/16\r\nGreat start! I can see you have a handle on the fundamentals. In terms of improvement, focus on using divs. As for a future challenge, I suggest looking at rem/em, flexbox, and git commits. Rem/em and flexbox will help with learning about responsive design, while git commits will help you learn about version control. Git commits can be a bit complicated, so do not fret if you do not get it the first time. \r\n\r\nOverall, excellent work 👍 "}}
{"actor":{"display_login":"mml1"}}