{"action":"created","issue":{"url":"https://api.github.com/repos/bootstrap-ruby/bootstrap_form/issues/442","repository_url":"https://api.github.com/repos/bootstrap-ruby/bootstrap_form","labels_url":"https://api.github.com/repos/bootstrap-ruby/bootstrap_form/issues/442/labels{/name}","comments_url":"https://api.github.com/repos/bootstrap-ruby/bootstrap_form/issues/442/comments","events_url":"https://api.github.com/repos/bootstrap-ruby/bootstrap_form/issues/442/events","html_url":"https://github.com/bootstrap-ruby/bootstrap_form/pull/442","id":300481754,"number":442,"title":"Fixing input validation messaging.","user":{"login":"parkeryoung","id":1413866,"avatar_url":"https://avatars3.githubusercontent.com/u/1413866?v=4","gravatar_id":"","url":"https://api.github.com/users/parkeryoung","html_url":"https://github.com/parkeryoung","followers_url":"https://api.github.com/users/parkeryoung/followers","following_url":"https://api.github.com/users/parkeryoung/following{/other_user}","gists_url":"https://api.github.com/users/parkeryoung/gists{/gist_id}","starred_url":"https://api.github.com/users/parkeryoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkeryoung/subscriptions","organizations_url":"https://api.github.com/users/parkeryoung/orgs","repos_url":"https://api.github.com/users/parkeryoung/repos","events_url":"https://api.github.com/users/parkeryoung/events{/privacy}","received_events_url":"https://api.github.com/users/parkeryoung/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-27T03:32:29Z","updated_at":"2018-02-27T15:51:34Z","closed_at":"2018-02-27T14:16:40Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bootstrap-ruby/bootstrap_form/pulls/442","html_url":"https://github.com/bootstrap-ruby/bootstrap_form/pull/442","diff_url":"https://github.com/bootstrap-ruby/bootstrap_form/pull/442.diff","patch_url":"https://github.com/bootstrap-ruby/bootstrap_form/pull/442.patch"},"body":"In bootstrap 4 the classes for the input validations have changed. The\r\n`form-group` div is now expected to have the `has-danger` class. The\r\nmessage text is now supposed to have a `form-control-feedback` class\r\nas opposed to an `invalid-feedback` class.\r\n\r\nI removed the `icon` option as it doesn't seem to be supported by bootstrap anymore.\r\n\r\nThere are some parts I'm uncertain of, namely the places in the tests where it doesn't seem like the `form-control-feedback` is rendered.  I'm not sure if we are supposed to put the `has-danger` class on the div in these instances.\r\n\r\nThis also includes an update to the README to reflect this change.\r\n\r\nIf there is anything that needs to be changed, let me know."},"comment":{"url":"https://api.github.com/repos/bootstrap-ruby/bootstrap_form/issues/comments/368924734","html_url":"https://github.com/bootstrap-ruby/bootstrap_form/pull/442#issuecomment-368924734","issue_url":"https://api.github.com/repos/bootstrap-ruby/bootstrap_form/issues/442","id":368924734,"user":{"login":"lcreid","id":1613872,"avatar_url":"https://avatars3.githubusercontent.com/u/1613872?v=4","gravatar_id":"","url":"https://api.github.com/users/lcreid","html_url":"https://github.com/lcreid","followers_url":"https://api.github.com/users/lcreid/followers","following_url":"https://api.github.com/users/lcreid/following{/other_user}","gists_url":"https://api.github.com/users/lcreid/gists{/gist_id}","starred_url":"https://api.github.com/users/lcreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcreid/subscriptions","organizations_url":"https://api.github.com/users/lcreid/orgs","repos_url":"https://api.github.com/users/lcreid/repos","events_url":"https://api.github.com/users/lcreid/events{/privacy}","received_events_url":"https://api.github.com/users/lcreid/received_events","type":"User","site_admin":false},"created_at":"2018-02-27T15:51:34Z","updated_at":"2018-02-27T15:51:34Z","author_association":"COLLABORATOR","body":"No worries. There were so many changes through the different betas of Bootstrap 4 that we've all experienced what you did. If you're interested in contributing, check the issues list. If an issue has an obvious answer and no one is working on it, add a comment briefly describing how you plan to solve it, then have a go. There aren't any issues like that on the list right now, but I suspect we'll have a few in a week or so.\r\n\r\nThanks again for your willingness to help!"}}
{"actor":{"display_login":"lcreid"}}