{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/comments/180153384","pull_request_review_id":110524672,"id":180153384,"diff_hunk":"@@ -1,43 +0,0 @@\n-<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n-<project xmlns=\"http://maven.apache.org/POM/4.0.0\"\n-         xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n-         xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n-    <parent>\n-        <artifactId>spring-cloud-gcp</artifactId>\n-        <groupId>org.springframework.cloud</groupId>\n-        <version>1.0.0.BUILD-SNAPSHOT</version>\n-    </parent>\n-    <modelVersion>4.0.0</modelVersion>\n-\n-    <artifactId>spring-cloud-gcp-logging</artifactId>\n-    <name>Spring Cloud GCP Stackdriver Logging Module</name>\n-    <description>Spring Cloud GCP Stackdriver Logging Module</description>\n-\n-    <dependencies>\n-        <dependency>\n-            <groupId>org.springframework</groupId>\n-            <artifactId>spring-webmvc</artifactId>\n-        </dependency>\n-        <dependency>\n-            <groupId>javax.servlet</groupId>\n-            <artifactId>javax.servlet-api</artifactId>\n-            <scope>provided</scope>\n-        </dependency>\n-        <dependency>\n-            <groupId>com.google.cloud</groupId>\n-            <artifactId>google-cloud-logging-logback</artifactId>","path":"spring-cloud-gcp-logging/pom.xml","position":28,"original_position":28,"commit_id":"3aef1482cef510792e222f6eec71d55f9a8fa287","original_commit_id":"3aef1482cef510792e222f6eec71d55f9a8fa287","user":{"login":"joaoandremartins","id":3290856,"avatar_url":"https://avatars0.githubusercontent.com/u/3290856?v=4","gravatar_id":"","url":"https://api.github.com/users/joaoandremartins","html_url":"https://github.com/joaoandremartins","followers_url":"https://api.github.com/users/joaoandremartins/followers","following_url":"https://api.github.com/users/joaoandremartins/following{/other_user}","gists_url":"https://api.github.com/users/joaoandremartins/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoandremartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoandremartins/subscriptions","organizations_url":"https://api.github.com/users/joaoandremartins/orgs","repos_url":"https://api.github.com/users/joaoandremartins/repos","events_url":"https://api.github.com/users/joaoandremartins/events{/privacy}","received_events_url":"https://api.github.com/users/joaoandremartins/received_events","type":"User","site_admin":false},"body":"It's there.","created_at":"2018-04-09T16:27:41Z","updated_at":"2018-04-09T16:27:41Z","html_url":"https://github.com/spring-cloud/spring-cloud-gcp/pull/346#discussion_r180153384","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/346","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/comments/180153384"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-gcp/pull/346#discussion_r180153384"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/346"}},"in_reply_to_id":180150085},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/346","id":165200575,"html_url":"https://github.com/spring-cloud/spring-cloud-gcp/pull/346","diff_url":"https://github.com/spring-cloud/spring-cloud-gcp/pull/346.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-gcp/pull/346.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/346","number":346,"state":"closed","locked":false,"title":"Merges the Trace and Logging module with autoconfigure","user":{"login":"joaoandremartins","id":3290856,"avatar_url":"https://avatars0.githubusercontent.com/u/3290856?v=4","gravatar_id":"","url":"https://api.github.com/users/joaoandremartins","html_url":"https://github.com/joaoandremartins","followers_url":"https://api.github.com/users/joaoandremartins/followers","following_url":"https://api.github.com/users/joaoandremartins/following{/other_user}","gists_url":"https://api.github.com/users/joaoandremartins/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoandremartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoandremartins/subscriptions","organizations_url":"https://api.github.com/users/joaoandremartins/orgs","repos_url":"https://api.github.com/users/joaoandremartins/repos","events_url":"https://api.github.com/users/joaoandremartins/events{/privacy}","received_events_url":"https://api.github.com/users/joaoandremartins/received_events","type":"User","site_admin":false},"body":"- Adds Logging README under the reference document in Spring Cloud Sleuth,\r\n- Changes name of `StackdriverJsonLayoutLoggerTests` so it's not affected by changes to the `org.springframework.cloud.gcp` logger,\r\n- Changes `StackdriverTraceReporterTests` to use `ApplicationContextRunner` for tests","created_at":"2018-01-25T18:59:23Z","updated_at":"2018-04-09T16:27:41Z","closed_at":"2018-04-05T18:57:25Z","merged_at":"2018-04-05T18:57:25Z","merge_commit_sha":"3fdff1963d74c20f104a26175058d9d83bd4efb9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"balopat","id":635073,"avatar_url":"https://avatars1.githubusercontent.com/u/635073?v=4","gravatar_id":"","url":"https://api.github.com/users/balopat","html_url":"https://github.com/balopat","followers_url":"https://api.github.com/users/balopat/followers","following_url":"https://api.github.com/users/balopat/following{/other_user}","gists_url":"https://api.github.com/users/balopat/gists{/gist_id}","starred_url":"https://api.github.com/users/balopat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balopat/subscriptions","organizations_url":"https://api.github.com/users/balopat/orgs","repos_url":"https://api.github.com/users/balopat/repos","events_url":"https://api.github.com/users/balopat/events{/privacy}","received_events_url":"https://api.github.com/users/balopat/received_events","type":"User","site_admin":false},{"login":"ChengyuanZhao","id":29288945,"avatar_url":"https://avatars3.githubusercontent.com/u/29288945?v=4","gravatar_id":"","url":"https://api.github.com/users/ChengyuanZhao","html_url":"https://github.com/ChengyuanZhao","followers_url":"https://api.github.com/users/ChengyuanZhao/followers","following_url":"https://api.github.com/users/ChengyuanZhao/following{/other_user}","gists_url":"https://api.github.com/users/ChengyuanZhao/gists{/gist_id}","starred_url":"https://api.github.com/users/ChengyuanZhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChengyuanZhao/subscriptions","organizations_url":"https://api.github.com/users/ChengyuanZhao/orgs","repos_url":"https://api.github.com/users/ChengyuanZhao/repos","events_url":"https://api.github.com/users/ChengyuanZhao/events{/privacy}","received_events_url":"https://api.github.com/users/ChengyuanZhao/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/346/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/346/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/346/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/statuses/3aef1482cef510792e222f6eec71d55f9a8fa287","head":{"label":"spring-cloud:consolidate-trace-logging","ref":"consolidate-trace-logging","sha":"3aef1482cef510792e222f6eec71d55f9a8fa287","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":86105877,"name":"spring-cloud-gcp","full_name":"spring-cloud/spring-cloud-gcp","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-gcp","description":"Integration for Google Cloud Platform APIs with Spring","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/deployments","created_at":"2017-03-24T19:58:20Z","updated_at":"2018-04-09T16:26:38Z","pushed_at":"2018-04-09T16:26:36Z","git_url":"git://github.com/spring-cloud/spring-cloud-gcp.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-gcp.git","clone_url":"https://github.com/spring-cloud/spring-cloud-gcp.git","svn_url":"https://github.com/spring-cloud/spring-cloud-gcp","homepage":null,"size":2328,"stargazers_count":94,"watchers_count":94,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":38,"open_issues":52,"watchers":94,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"ea4a945a156bd861ef039c6537f5b8ad2dbc4f1f","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":86105877,"name":"spring-cloud-gcp","full_name":"spring-cloud/spring-cloud-gcp","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-gcp","description":"Integration for Google Cloud Platform APIs with Spring","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/deployments","created_at":"2017-03-24T19:58:20Z","updated_at":"2018-04-09T16:26:38Z","pushed_at":"2018-04-09T16:26:36Z","git_url":"git://github.com/spring-cloud/spring-cloud-gcp.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-gcp.git","clone_url":"https://github.com/spring-cloud/spring-cloud-gcp.git","svn_url":"https://github.com/spring-cloud/spring-cloud-gcp","homepage":null,"size":2328,"stargazers_count":94,"watchers_count":94,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":38,"open_issues":52,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/346"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-gcp/pull/346"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/346"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/statuses/3aef1482cef510792e222f6eec71d55f9a8fa287"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"joaoandremartins"}}