{"action":"created","issue":{"url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues/1653","repository_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs","labels_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues/1653/labels{/name}","comments_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues/1653/comments","events_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues/1653/events","html_url":"https://github.com/PowerPointLabs/PowerPointLabs/pull/1653","id":308453867,"number":1653,"title":"#1640 Positions Lab Bug (Distribute)","user":{"login":"junkiattan","id":16800272,"avatar_url":"https://avatars1.githubusercontent.com/u/16800272?v=4","gravatar_id":"","url":"https://api.github.com/users/junkiattan","html_url":"https://github.com/junkiattan","followers_url":"https://api.github.com/users/junkiattan/followers","following_url":"https://api.github.com/users/junkiattan/following{/other_user}","gists_url":"https://api.github.com/users/junkiattan/gists{/gist_id}","starred_url":"https://api.github.com/users/junkiattan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junkiattan/subscriptions","organizations_url":"https://api.github.com/users/junkiattan/orgs","repos_url":"https://api.github.com/users/junkiattan/repos","events_url":"https://api.github.com/users/junkiattan/events{/privacy}","received_events_url":"https://api.github.com/users/junkiattan/received_events","type":"User","site_admin":false},"labels":[{"id":532525135,"url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/labels/ok-2013","name":"ok-2013","color":"0e8a16","default":false},{"id":532525178,"url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/labels/ok-2016","name":"ok-2016","color":"0e8a16","default":false},{"id":308974729,"url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/labels/s.ToReview","name":"s.ToReview","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":{"login":"junkiattan","id":16800272,"avatar_url":"https://avatars1.githubusercontent.com/u/16800272?v=4","gravatar_id":"","url":"https://api.github.com/users/junkiattan","html_url":"https://github.com/junkiattan","followers_url":"https://api.github.com/users/junkiattan/followers","following_url":"https://api.github.com/users/junkiattan/following{/other_user}","gists_url":"https://api.github.com/users/junkiattan/gists{/gist_id}","starred_url":"https://api.github.com/users/junkiattan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junkiattan/subscriptions","organizations_url":"https://api.github.com/users/junkiattan/orgs","repos_url":"https://api.github.com/users/junkiattan/repos","events_url":"https://api.github.com/users/junkiattan/events{/privacy}","received_events_url":"https://api.github.com/users/junkiattan/received_events","type":"User","site_admin":false},"assignees":[{"login":"junkiattan","id":16800272,"avatar_url":"https://avatars1.githubusercontent.com/u/16800272?v=4","gravatar_id":"","url":"https://api.github.com/users/junkiattan","html_url":"https://github.com/junkiattan","followers_url":"https://api.github.com/users/junkiattan/followers","following_url":"https://api.github.com/users/junkiattan/following{/other_user}","gists_url":"https://api.github.com/users/junkiattan/gists{/gist_id}","starred_url":"https://api.github.com/users/junkiattan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junkiattan/subscriptions","organizations_url":"https://api.github.com/users/junkiattan/orgs","repos_url":"https://api.github.com/users/junkiattan/repos","events_url":"https://api.github.com/users/junkiattan/events{/privacy}","received_events_url":"https://api.github.com/users/junkiattan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-03-26T07:01:14Z","updated_at":"2018-04-02T02:45:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/1653","html_url":"https://github.com/PowerPointLabs/PowerPointLabs/pull/1653","diff_url":"https://github.com/PowerPointLabs/PowerPointLabs/pull/1653.diff","patch_url":"https://github.com/PowerPointLabs/PowerPointLabs/pull/1653.patch"},"body":"#1640 \r\n\r\nCurrent fix for distribute functions:\r\n\r\n- Distribute center, horizontal and vertical now works for both types of images. \r\n\r\n- However Distribute radial and grid does not work, even after manual copy/paste of the images. This means for radial/grid, we cannot use copy/paste or the solution used to solve for distribute center, horizontal and vertical.\r\n\r\nFurthermore, it has to be considered that all the methods work well for most images, hence we should minimize changes to the code that can affect this core functionality.\r\n\r\nThe basic workaround for radial/grid is to return an error message that indicates to the user some form of corrupted images.\r\n\r\nMethods tried:\r\n1. Corruption correction - failed because of the same error that caused the bug (i.e. `simulatedShapes.Delete()`)\r\n1. Manually copy/paste and then using `ClipboardUtil` methods to replicate that in code - failed because it does not work for the Distribute Radial/Grid\r\n1. Default powerpoint methods like `Shapes.Duplicate()` - failed for Distribute Radial /Grid as desired outcome of image arrangement is not achieved\r\n"},"comment":{"url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues/comments/377841390","html_url":"https://github.com/PowerPointLabs/PowerPointLabs/pull/1653#issuecomment-377841390","issue_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues/1653","id":377841390,"user":{"login":"leeyh20","id":7023320,"avatar_url":"https://avatars3.githubusercontent.com/u/7023320?v=4","gravatar_id":"","url":"https://api.github.com/users/leeyh20","html_url":"https://github.com/leeyh20","followers_url":"https://api.github.com/users/leeyh20/followers","following_url":"https://api.github.com/users/leeyh20/following{/other_user}","gists_url":"https://api.github.com/users/leeyh20/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyh20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyh20/subscriptions","organizations_url":"https://api.github.com/users/leeyh20/orgs","repos_url":"https://api.github.com/users/leeyh20/repos","events_url":"https://api.github.com/users/leeyh20/events{/privacy}","received_events_url":"https://api.github.com/users/leeyh20/received_events","type":"User","site_admin":false},"created_at":"2018-04-02T02:45:35Z","updated_at":"2018-04-02T02:45:35Z","author_association":"CONTRIBUTOR","body":"In PPT 2010, after showing the error that these shapes are corrupted, the shapes are still being duplicated\r\n![image](https://user-images.githubusercontent.com/7023320/38180966-cfa940f0-3662-11e8-80e9-ed33ef090f54.png)\r\n\r\nIf I select only three shapes and press Radial, it will say \"Please select four shapes\" error and then still show the \"these shapes are corrupted\" error. Is this intended? Should we just show one error?"}}
{"actor":{"display_login":"leeyh20"}}