{"action":"closed","number":180,"pull_request":{"url":"https://api.github.com/repos/devCrossNet/vue-starter/pulls/180","id":199917424,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTE3NDI0","html_url":"https://github.com/devCrossNet/vue-starter/pull/180","diff_url":"https://github.com/devCrossNet/vue-starter/pull/180.diff","patch_url":"https://github.com/devCrossNet/vue-starter/pull/180.patch","issue_url":"https://api.github.com/repos/devCrossNet/vue-starter/issues/180","number":180,"state":"closed","locked":false,"title":" feat: replace font-awesome with SVG's","user":{"login":"devCrossNet","id":1667598,"node_id":"MDQ6VXNlcjE2Njc1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1667598?v=4","gravatar_id":"","url":"https://api.github.com/users/devCrossNet","html_url":"https://github.com/devCrossNet","followers_url":"https://api.github.com/users/devCrossNet/followers","following_url":"https://api.github.com/users/devCrossNet/following{/other_user}","gists_url":"https://api.github.com/users/devCrossNet/gists{/gist_id}","starred_url":"https://api.github.com/users/devCrossNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devCrossNet/subscriptions","organizations_url":"https://api.github.com/users/devCrossNet/orgs","repos_url":"https://api.github.com/users/devCrossNet/repos","events_url":"https://api.github.com/users/devCrossNet/events{/privacy}","received_events_url":"https://api.github.com/users/devCrossNet/received_events","type":"User","site_admin":false},"body":"<!--\r\nThere are two main goals in this document, depending on the nature of your PR:\r\n\r\n- description: please tell us about your PR\r\n- checklist: please review the checklist\r\n\r\nTo help to quickly understand the nature of your pull request,\r\nplease create a description that incorporates the following elements:\r\n-->\r\n\r\n### What is accomplished by your PR?\r\nThis PR will replace font-awesome with icon-components\r\n\r\n### Is there something controversial in your PR?\r\n- the `i` tag has to be styled now via width, height and will instead of font-size and color\r\n- I restyled the tab component to get rid of the icon, the initial design was too special and is never used by any other project \r\n\r\n\r\n### Link to the Issue\r\n#177 \r\n\r\n# Checklist\r\n\r\n### New Feature / Bug Fix\r\n\r\n- [x] Run unit tests to ensure all existing tests are still passing\r\n- [x] Add new passing unit tests to cover the code introduced by your PR\r\n- [x] Add new documentation for the code introduced by your PR\r\n\r\n\r\n<!--\r\nThanks for contributing!\r\n-->\r\n","created_at":"2018-07-07T23:13:29Z","updated_at":"2018-07-14T14:42:50Z","closed_at":"2018-07-14T14:42:50Z","merged_at":"2018-07-14T14:42:50Z","merge_commit_sha":"9dde29b9e67d0db71c8825fb28373bfbff6172e1","assignee":{"login":"devCrossNet","id":1667598,"node_id":"MDQ6VXNlcjE2Njc1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1667598?v=4","gravatar_id":"","url":"https://api.github.com/users/devCrossNet","html_url":"https://github.com/devCrossNet","followers_url":"https://api.github.com/users/devCrossNet/followers","following_url":"https://api.github.com/users/devCrossNet/following{/other_user}","gists_url":"https://api.github.com/users/devCrossNet/gists{/gist_id}","starred_url":"https://api.github.com/users/devCrossNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devCrossNet/subscriptions","organizations_url":"https://api.github.com/users/devCrossNet/orgs","repos_url":"https://api.github.com/users/devCrossNet/repos","events_url":"https://api.github.com/users/devCrossNet/events{/privacy}","received_events_url":"https://api.github.com/users/devCrossNet/received_events","type":"User","site_admin":false},"assignees":[{"login":"devCrossNet","id":1667598,"node_id":"MDQ6VXNlcjE2Njc1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1667598?v=4","gravatar_id":"","url":"https://api.github.com/users/devCrossNet","html_url":"https://github.com/devCrossNet","followers_url":"https://api.github.com/users/devCrossNet/followers","following_url":"https://api.github.com/users/devCrossNet/following{/other_user}","gists_url":"https://api.github.com/users/devCrossNet/gists{/gist_id}","starred_url":"https://api.github.com/users/devCrossNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devCrossNet/subscriptions","organizations_url":"https://api.github.com/users/devCrossNet/orgs","repos_url":"https://api.github.com/users/devCrossNet/repos","events_url":"https://api.github.com/users/devCrossNet/events{/privacy}","received_events_url":"https://api.github.com/users/devCrossNet/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/devCrossNet/vue-starter/milestones/4","html_url":"https://github.com/devCrossNet/vue-starter/milestone/4","labels_url":"https://api.github.com/repos/devCrossNet/vue-starter/milestones/4/labels","id":3472621,"node_id":"MDk6TWlsZXN0b25lMzQ3MjYyMQ==","number":4,"title":"v1.2.0","description":"","creator":{"login":"devCrossNet","id":1667598,"node_id":"MDQ6VXNlcjE2Njc1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1667598?v=4","gravatar_id":"","url":"https://api.github.com/users/devCrossNet","html_url":"https://github.com/devCrossNet","followers_url":"https://api.github.com/users/devCrossNet/followers","following_url":"https://api.github.com/users/devCrossNet/following{/other_user}","gists_url":"https://api.github.com/users/devCrossNet/gists{/gist_id}","starred_url":"https://api.github.com/users/devCrossNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devCrossNet/subscriptions","organizations_url":"https://api.github.com/users/devCrossNet/orgs","repos_url":"https://api.github.com/users/devCrossNet/repos","events_url":"https://api.github.com/users/devCrossNet/events{/privacy}","received_events_url":"https://api.github.com/users/devCrossNet/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":4,"state":"open","created_at":"2018-07-04T09:50:06Z","updated_at":"2018-07-14T14:42:50Z","due_on":"2018-07-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/devCrossNet/vue-starter/pulls/180/commits","review_comments_url":"https://api.github.com/repos/devCrossNet/vue-starter/pulls/180/comments","review_comment_url":"https://api.github.com/repos/devCrossNet/vue-starter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devCrossNet/vue-starter/issues/180/comments","statuses_url":"https://api.github.com/repos/devCrossNet/vue-starter/statuses/fd4880f89f694aee9cc7b44bd978cafb30af3108","head":{"label":"devCrossNet:feat/icons","ref":"feat/icons","sha":"fd4880f89f694aee9cc7b44bd978cafb30af3108","user":{"login":"devCrossNet","id":1667598,"node_id":"MDQ6VXNlcjE2Njc1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1667598?v=4","gravatar_id":"","url":"https://api.github.com/users/devCrossNet","html_url":"https://github.com/devCrossNet","followers_url":"https://api.github.com/users/devCrossNet/followers","following_url":"https://api.github.com/users/devCrossNet/following{/other_user}","gists_url":"https://api.github.com/users/devCrossNet/gists{/gist_id}","starred_url":"https://api.github.com/users/devCrossNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devCrossNet/subscriptions","organizations_url":"https://api.github.com/users/devCrossNet/orgs","repos_url":"https://api.github.com/users/devCrossNet/repos","events_url":"https://api.github.com/users/devCrossNet/events{/privacy}","received_events_url":"https://api.github.com/users/devCrossNet/received_events","type":"User","site_admin":false},"repo":{"id":111245305,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyNDUzMDU=","name":"vue-starter","full_name":"devCrossNet/vue-starter","owner":{"login":"devCrossNet","id":1667598,"node_id":"MDQ6VXNlcjE2Njc1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1667598?v=4","gravatar_id":"","url":"https://api.github.com/users/devCrossNet","html_url":"https://github.com/devCrossNet","followers_url":"https://api.github.com/users/devCrossNet/followers","following_url":"https://api.github.com/users/devCrossNet/following{/other_user}","gists_url":"https://api.github.com/users/devCrossNet/gists{/gist_id}","starred_url":"https://api.github.com/users/devCrossNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devCrossNet/subscriptions","organizations_url":"https://api.github.com/users/devCrossNet/orgs","repos_url":"https://api.github.com/users/devCrossNet/repos","events_url":"https://api.github.com/users/devCrossNet/events{/privacy}","received_events_url":"https://api.github.com/users/devCrossNet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devCrossNet/vue-starter","description":"A flexible, scalable, opinionated boilerplate for production-ready PWAs with focus on performance, development speed, and best practices","fork":false,"url":"https://api.github.com/repos/devCrossNet/vue-starter","forks_url":"https://api.github.com/repos/devCrossNet/vue-starter/forks","keys_url":"https://api.github.com/repos/devCrossNet/vue-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devCrossNet/vue-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devCrossNet/vue-starter/teams","hooks_url":"https://api.github.com/repos/devCrossNet/vue-starter/hooks","issue_events_url":"https://api.github.com/repos/devCrossNet/vue-starter/issues/events{/number}","events_url":"https://api.github.com/repos/devCrossNet/vue-starter/events","assignees_url":"https://api.github.com/repos/devCrossNet/vue-starter/assignees{/user}","branches_url":"https://api.github.com/repos/devCrossNet/vue-starter/branches{/branch}","tags_url":"https://api.github.com/repos/devCrossNet/vue-starter/tags","blobs_url":"https://api.github.com/repos/devCrossNet/vue-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devCrossNet/vue-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devCrossNet/vue-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/devCrossNet/vue-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devCrossNet/vue-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/devCrossNet/vue-starter/languages","stargazers_url":"https://api.github.com/repos/devCrossNet/vue-starter/stargazers","contributors_url":"https://api.github.com/repos/devCrossNet/vue-starter/contributors","subscribers_url":"https://api.github.com/repos/devCrossNet/vue-starter/subscribers","subscription_url":"https://api.github.com/repos/devCrossNet/vue-starter/subscription","commits_url":"https://api.github.com/repos/devCrossNet/vue-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/devCrossNet/vue-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/devCrossNet/vue-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/devCrossNet/vue-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/devCrossNet/vue-starter/contents/{+path}","compare_url":"https://api.github.com/repos/devCrossNet/vue-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devCrossNet/vue-starter/merges","archive_url":"https://api.github.com/repos/devCrossNet/vue-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devCrossNet/vue-starter/downloads","issues_url":"https://api.github.com/repos/devCrossNet/vue-starter/issues{/number}","pulls_url":"https://api.github.com/repos/devCrossNet/vue-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/devCrossNet/vue-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/devCrossNet/vue-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devCrossNet/vue-starter/labels{/name}","releases_url":"https://api.github.com/repos/devCrossNet/vue-starter/releases{/id}","deployments_url":"https://api.github.com/repos/devCrossNet/vue-starter/deployments","created_at":"2017-11-18T22:42:36Z","updated_at":"2018-07-14T14:38:08Z","pushed_at":"2018-07-14T14:42:50Z","git_url":"git://github.com/devCrossNet/vue-starter.git","ssh_url":"git@github.com:devCrossNet/vue-starter.git","clone_url":"https://github.com/devCrossNet/vue-starter.git","svn_url":"https://github.com/devCrossNet/vue-starter","homepage":"https://vue-starter.herokuapp.com/","size":2670,"stargazers_count":654,"watchers_count":654,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":82,"open_issues":13,"watchers":654,"default_branch":"master"}},"base":{"label":"devCrossNet:next","ref":"next","sha":"0577b6b9ce8ec837f07ed3221dce483f2d40b47c","user":{"login":"devCrossNet","id":1667598,"node_id":"MDQ6VXNlcjE2Njc1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1667598?v=4","gravatar_id":"","url":"https://api.github.com/users/devCrossNet","html_url":"https://github.com/devCrossNet","followers_url":"https://api.github.com/users/devCrossNet/followers","following_url":"https://api.github.com/users/devCrossNet/following{/other_user}","gists_url":"https://api.github.com/users/devCrossNet/gists{/gist_id}","starred_url":"https://api.github.com/users/devCrossNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devCrossNet/subscriptions","organizations_url":"https://api.github.com/users/devCrossNet/orgs","repos_url":"https://api.github.com/users/devCrossNet/repos","events_url":"https://api.github.com/users/devCrossNet/events{/privacy}","received_events_url":"https://api.github.com/users/devCrossNet/received_events","type":"User","site_admin":false},"repo":{"id":111245305,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyNDUzMDU=","name":"vue-starter","full_name":"devCrossNet/vue-starter","owner":{"login":"devCrossNet","id":1667598,"node_id":"MDQ6VXNlcjE2Njc1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1667598?v=4","gravatar_id":"","url":"https://api.github.com/users/devCrossNet","html_url":"https://github.com/devCrossNet","followers_url":"https://api.github.com/users/devCrossNet/followers","following_url":"https://api.github.com/users/devCrossNet/following{/other_user}","gists_url":"https://api.github.com/users/devCrossNet/gists{/gist_id}","starred_url":"https://api.github.com/users/devCrossNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devCrossNet/subscriptions","organizations_url":"https://api.github.com/users/devCrossNet/orgs","repos_url":"https://api.github.com/users/devCrossNet/repos","events_url":"https://api.github.com/users/devCrossNet/events{/privacy}","received_events_url":"https://api.github.com/users/devCrossNet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devCrossNet/vue-starter","description":"A flexible, scalable, opinionated boilerplate for production-ready PWAs with focus on performance, development speed, and best practices","fork":false,"url":"https://api.github.com/repos/devCrossNet/vue-starter","forks_url":"https://api.github.com/repos/devCrossNet/vue-starter/forks","keys_url":"https://api.github.com/repos/devCrossNet/vue-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devCrossNet/vue-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devCrossNet/vue-starter/teams","hooks_url":"https://api.github.com/repos/devCrossNet/vue-starter/hooks","issue_events_url":"https://api.github.com/repos/devCrossNet/vue-starter/issues/events{/number}","events_url":"https://api.github.com/repos/devCrossNet/vue-starter/events","assignees_url":"https://api.github.com/repos/devCrossNet/vue-starter/assignees{/user}","branches_url":"https://api.github.com/repos/devCrossNet/vue-starter/branches{/branch}","tags_url":"https://api.github.com/repos/devCrossNet/vue-starter/tags","blobs_url":"https://api.github.com/repos/devCrossNet/vue-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devCrossNet/vue-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devCrossNet/vue-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/devCrossNet/vue-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devCrossNet/vue-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/devCrossNet/vue-starter/languages","stargazers_url":"https://api.github.com/repos/devCrossNet/vue-starter/stargazers","contributors_url":"https://api.github.com/repos/devCrossNet/vue-starter/contributors","subscribers_url":"https://api.github.com/repos/devCrossNet/vue-starter/subscribers","subscription_url":"https://api.github.com/repos/devCrossNet/vue-starter/subscription","commits_url":"https://api.github.com/repos/devCrossNet/vue-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/devCrossNet/vue-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/devCrossNet/vue-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/devCrossNet/vue-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/devCrossNet/vue-starter/contents/{+path}","compare_url":"https://api.github.com/repos/devCrossNet/vue-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devCrossNet/vue-starter/merges","archive_url":"https://api.github.com/repos/devCrossNet/vue-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devCrossNet/vue-starter/downloads","issues_url":"https://api.github.com/repos/devCrossNet/vue-starter/issues{/number}","pulls_url":"https://api.github.com/repos/devCrossNet/vue-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/devCrossNet/vue-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/devCrossNet/vue-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devCrossNet/vue-starter/labels{/name}","releases_url":"https://api.github.com/repos/devCrossNet/vue-starter/releases{/id}","deployments_url":"https://api.github.com/repos/devCrossNet/vue-starter/deployments","created_at":"2017-11-18T22:42:36Z","updated_at":"2018-07-14T14:38:08Z","pushed_at":"2018-07-14T14:42:50Z","git_url":"git://github.com/devCrossNet/vue-starter.git","ssh_url":"git@github.com:devCrossNet/vue-starter.git","clone_url":"https://github.com/devCrossNet/vue-starter.git","svn_url":"https://github.com/devCrossNet/vue-starter","homepage":"https://vue-starter.herokuapp.com/","size":2670,"stargazers_count":654,"watchers_count":654,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":82,"open_issues":13,"watchers":654,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devCrossNet/vue-starter/pulls/180"},"html":{"href":"https://github.com/devCrossNet/vue-starter/pull/180"},"issue":{"href":"https://api.github.com/repos/devCrossNet/vue-starter/issues/180"},"comments":{"href":"https://api.github.com/repos/devCrossNet/vue-starter/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/devCrossNet/vue-starter/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/devCrossNet/vue-starter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devCrossNet/vue-starter/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/devCrossNet/vue-starter/statuses/fd4880f89f694aee9cc7b44bd978cafb30af3108"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"devCrossNet","id":1667598,"node_id":"MDQ6VXNlcjE2Njc1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1667598?v=4","gravatar_id":"","url":"https://api.github.com/users/devCrossNet","html_url":"https://github.com/devCrossNet","followers_url":"https://api.github.com/users/devCrossNet/followers","following_url":"https://api.github.com/users/devCrossNet/following{/other_user}","gists_url":"https://api.github.com/users/devCrossNet/gists{/gist_id}","starred_url":"https://api.github.com/users/devCrossNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devCrossNet/subscriptions","organizations_url":"https://api.github.com/users/devCrossNet/orgs","repos_url":"https://api.github.com/users/devCrossNet/repos","events_url":"https://api.github.com/users/devCrossNet/events{/privacy}","received_events_url":"https://api.github.com/users/devCrossNet/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":541,"deletions":161,"changed_files":42}}
{"actor":{"display_login":"devCrossNet"}}