{"action":"created","comment":{"url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/comments/200043599","pull_request_review_id":134278870,"id":200043599,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDA0MzU5OQ==","diff_hunk":"@@ -88,15 +53,11 @@ def get_dnsmasq():\n       include_package_data=INCLUDE_PACKAGE_DATA, version=VERSION, entry_points=ENTRY_POINTS,\n       install_requires=INSTALL_REQUIRES, classifiers=CLASSIFIERS, url=URL, cmdclass=CMDCLASS)\n \n-get_dnsmasq()\n-\n-print()\n-print(\"                     _  __ _       _     _     _               \")\n-print(\"                    (_)/ _(_)     | |   (_)   | |              \")\n-print(\"  ((.))    __      ___| |_ _ _ __ | |__  _ ___| |__   ___ _ __ \")\n-print(r\"    |      \\ \\ /\\ / / |  _| | '_ \\| '_ \\| / __| '_ \\ / _ \\ '__|\")\n-print(r\"   /_\\      \\ V  V /| | | | | |_) | | | | \\__ \\ | | |  __/ |   \")\n-print(r\"  /___\\      \\_/\\_/ |_|_| |_| .__/|_| |_|_|___/_| |_|\\___|_|   \")\n-print(r\" /     \\                    | |                                \")\n-print(\"                            |_|                                \")\n-print(\"                                                               \")","path":"setup.py","position":66,"original_position":66,"commit_id":"f9ae5abd87e1b6d7d966a2a1874249a7b0d082b6","original_commit_id":"f9ae5abd87e1b6d7d966a2a1874249a7b0d082b6","user":{"login":"sophron","id":554314,"node_id":"MDQ6VXNlcjU1NDMxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/554314?v=4","gravatar_id":"","url":"https://api.github.com/users/sophron","html_url":"https://github.com/sophron","followers_url":"https://api.github.com/users/sophron/followers","following_url":"https://api.github.com/users/sophron/following{/other_user}","gists_url":"https://api.github.com/users/sophron/gists{/gist_id}","starred_url":"https://api.github.com/users/sophron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sophron/subscriptions","organizations_url":"https://api.github.com/users/sophron/orgs","repos_url":"https://api.github.com/users/sophron/repos","events_url":"https://api.github.com/users/sophron/events{/privacy}","received_events_url":"https://api.github.com/users/sophron/received_events","type":"User","site_admin":false},"body":"Why did you remove the ASCII art?","created_at":"2018-07-04T08:16:44Z","updated_at":"2018-07-04T08:16:44Z","html_url":"https://github.com/wifiphisher/wifiphisher/pull/960#discussion_r200043599","pull_request_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/960","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/comments/200043599"},"html":{"href":"https://github.com/wifiphisher/wifiphisher/pull/960#discussion_r200043599"},"pull_request":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/960"}}},"pull_request":{"url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/960","id":198480197,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDgwMTk3","html_url":"https://github.com/wifiphisher/wifiphisher/pull/960","diff_url":"https://github.com/wifiphisher/wifiphisher/pull/960.diff","patch_url":"https://github.com/wifiphisher/wifiphisher/pull/960.patch","issue_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/960","number":960,"state":"open","locked":false,"title":"chore:move dependency check from setup file","user":{"login":"blackHatMonkey","id":25112506,"node_id":"MDQ6VXNlcjI1MTEyNTA2","avatar_url":"https://avatars2.githubusercontent.com/u/25112506?v=4","gravatar_id":"","url":"https://api.github.com/users/blackHatMonkey","html_url":"https://github.com/blackHatMonkey","followers_url":"https://api.github.com/users/blackHatMonkey/followers","following_url":"https://api.github.com/users/blackHatMonkey/following{/other_user}","gists_url":"https://api.github.com/users/blackHatMonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/blackHatMonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackHatMonkey/subscriptions","organizations_url":"https://api.github.com/users/blackHatMonkey/orgs","repos_url":"https://api.github.com/users/blackHatMonkey/repos","events_url":"https://api.github.com/users/blackHatMonkey/events{/privacy}","received_events_url":"https://api.github.com/users/blackHatMonkey/received_events","type":"User","site_admin":false},"body":"Move the dependency checks from the setup.py file to it's own module so building the project becomes easier. This is due to the fact of waiting on stdin in case exteranl dependency was not installed. The checks now happen at run time.\r\n\r\nseealso #933","created_at":"2018-06-30T14:55:35Z","updated_at":"2018-07-04T08:16:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"794237808a72eb86a89bc2060f93dab3dde37c66","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anakin1028","id":6182530,"node_id":"MDQ6VXNlcjYxODI1MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6182530?v=4","gravatar_id":"","url":"https://api.github.com/users/anakin1028","html_url":"https://github.com/anakin1028","followers_url":"https://api.github.com/users/anakin1028/followers","following_url":"https://api.github.com/users/anakin1028/following{/other_user}","gists_url":"https://api.github.com/users/anakin1028/gists{/gist_id}","starred_url":"https://api.github.com/users/anakin1028/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anakin1028/subscriptions","organizations_url":"https://api.github.com/users/anakin1028/orgs","repos_url":"https://api.github.com/users/anakin1028/repos","events_url":"https://api.github.com/users/anakin1028/events{/privacy}","received_events_url":"https://api.github.com/users/anakin1028/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/960/commits","review_comments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/960/comments","review_comment_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/960/comments","statuses_url":"https://api.github.com/repos/wifiphisher/wifiphisher/statuses/f9ae5abd87e1b6d7d966a2a1874249a7b0d082b6","head":{"label":"wifiphisher:dependency_fix","ref":"dependency_fix","sha":"f9ae5abd87e1b6d7d966a2a1874249a7b0d082b6","user":{"login":"wifiphisher","id":25661467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxNDY3","avatar_url":"https://avatars0.githubusercontent.com/u/25661467?v=4","gravatar_id":"","url":"https://api.github.com/users/wifiphisher","html_url":"https://github.com/wifiphisher","followers_url":"https://api.github.com/users/wifiphisher/followers","following_url":"https://api.github.com/users/wifiphisher/following{/other_user}","gists_url":"https://api.github.com/users/wifiphisher/gists{/gist_id}","starred_url":"https://api.github.com/users/wifiphisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifiphisher/subscriptions","organizations_url":"https://api.github.com/users/wifiphisher/orgs","repos_url":"https://api.github.com/users/wifiphisher/repos","events_url":"https://api.github.com/users/wifiphisher/events{/privacy}","received_events_url":"https://api.github.com/users/wifiphisher/received_events","type":"Organization","site_admin":false},"repo":{"id":24499174,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQ5OTE3NA==","name":"wifiphisher","full_name":"wifiphisher/wifiphisher","owner":{"login":"wifiphisher","id":25661467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxNDY3","avatar_url":"https://avatars0.githubusercontent.com/u/25661467?v=4","gravatar_id":"","url":"https://api.github.com/users/wifiphisher","html_url":"https://github.com/wifiphisher","followers_url":"https://api.github.com/users/wifiphisher/followers","following_url":"https://api.github.com/users/wifiphisher/following{/other_user}","gists_url":"https://api.github.com/users/wifiphisher/gists{/gist_id}","starred_url":"https://api.github.com/users/wifiphisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifiphisher/subscriptions","organizations_url":"https://api.github.com/users/wifiphisher/orgs","repos_url":"https://api.github.com/users/wifiphisher/repos","events_url":"https://api.github.com/users/wifiphisher/events{/privacy}","received_events_url":"https://api.github.com/users/wifiphisher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wifiphisher/wifiphisher","description":"The Rogue Access Point Framework","fork":false,"url":"https://api.github.com/repos/wifiphisher/wifiphisher","forks_url":"https://api.github.com/repos/wifiphisher/wifiphisher/forks","keys_url":"https://api.github.com/repos/wifiphisher/wifiphisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wifiphisher/wifiphisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wifiphisher/wifiphisher/teams","hooks_url":"https://api.github.com/repos/wifiphisher/wifiphisher/hooks","issue_events_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/events{/number}","events_url":"https://api.github.com/repos/wifiphisher/wifiphisher/events","assignees_url":"https://api.github.com/repos/wifiphisher/wifiphisher/assignees{/user}","branches_url":"https://api.github.com/repos/wifiphisher/wifiphisher/branches{/branch}","tags_url":"https://api.github.com/repos/wifiphisher/wifiphisher/tags","blobs_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wifiphisher/wifiphisher/statuses/{sha}","languages_url":"https://api.github.com/repos/wifiphisher/wifiphisher/languages","stargazers_url":"https://api.github.com/repos/wifiphisher/wifiphisher/stargazers","contributors_url":"https://api.github.com/repos/wifiphisher/wifiphisher/contributors","subscribers_url":"https://api.github.com/repos/wifiphisher/wifiphisher/subscribers","subscription_url":"https://api.github.com/repos/wifiphisher/wifiphisher/subscription","commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/wifiphisher/wifiphisher/contents/{+path}","compare_url":"https://api.github.com/repos/wifiphisher/wifiphisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wifiphisher/wifiphisher/merges","archive_url":"https://api.github.com/repos/wifiphisher/wifiphisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wifiphisher/wifiphisher/downloads","issues_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues{/number}","pulls_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls{/number}","milestones_url":"https://api.github.com/repos/wifiphisher/wifiphisher/milestones{/number}","notifications_url":"https://api.github.com/repos/wifiphisher/wifiphisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wifiphisher/wifiphisher/labels{/name}","releases_url":"https://api.github.com/repos/wifiphisher/wifiphisher/releases{/id}","deployments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/deployments","created_at":"2014-09-26T12:47:28Z","updated_at":"2018-07-02T15:03:18Z","pushed_at":"2018-07-03T18:11:16Z","git_url":"git://github.com/wifiphisher/wifiphisher.git","ssh_url":"git@github.com:wifiphisher/wifiphisher.git","clone_url":"https://github.com/wifiphisher/wifiphisher.git","svn_url":"https://github.com/wifiphisher/wifiphisher","homepage":"https://wifiphisher.org","size":11085,"stargazers_count":6494,"watchers_count":6494,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1508,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1508,"open_issues":92,"watchers":6494,"default_branch":"master"}},"base":{"label":"wifiphisher:master","ref":"master","sha":"5ae21ab93e0dce85dd4bf76e68cc3b996aa33dea","user":{"login":"wifiphisher","id":25661467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxNDY3","avatar_url":"https://avatars0.githubusercontent.com/u/25661467?v=4","gravatar_id":"","url":"https://api.github.com/users/wifiphisher","html_url":"https://github.com/wifiphisher","followers_url":"https://api.github.com/users/wifiphisher/followers","following_url":"https://api.github.com/users/wifiphisher/following{/other_user}","gists_url":"https://api.github.com/users/wifiphisher/gists{/gist_id}","starred_url":"https://api.github.com/users/wifiphisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifiphisher/subscriptions","organizations_url":"https://api.github.com/users/wifiphisher/orgs","repos_url":"https://api.github.com/users/wifiphisher/repos","events_url":"https://api.github.com/users/wifiphisher/events{/privacy}","received_events_url":"https://api.github.com/users/wifiphisher/received_events","type":"Organization","site_admin":false},"repo":{"id":24499174,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQ5OTE3NA==","name":"wifiphisher","full_name":"wifiphisher/wifiphisher","owner":{"login":"wifiphisher","id":25661467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxNDY3","avatar_url":"https://avatars0.githubusercontent.com/u/25661467?v=4","gravatar_id":"","url":"https://api.github.com/users/wifiphisher","html_url":"https://github.com/wifiphisher","followers_url":"https://api.github.com/users/wifiphisher/followers","following_url":"https://api.github.com/users/wifiphisher/following{/other_user}","gists_url":"https://api.github.com/users/wifiphisher/gists{/gist_id}","starred_url":"https://api.github.com/users/wifiphisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifiphisher/subscriptions","organizations_url":"https://api.github.com/users/wifiphisher/orgs","repos_url":"https://api.github.com/users/wifiphisher/repos","events_url":"https://api.github.com/users/wifiphisher/events{/privacy}","received_events_url":"https://api.github.com/users/wifiphisher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wifiphisher/wifiphisher","description":"The Rogue Access Point Framework","fork":false,"url":"https://api.github.com/repos/wifiphisher/wifiphisher","forks_url":"https://api.github.com/repos/wifiphisher/wifiphisher/forks","keys_url":"https://api.github.com/repos/wifiphisher/wifiphisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wifiphisher/wifiphisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wifiphisher/wifiphisher/teams","hooks_url":"https://api.github.com/repos/wifiphisher/wifiphisher/hooks","issue_events_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/events{/number}","events_url":"https://api.github.com/repos/wifiphisher/wifiphisher/events","assignees_url":"https://api.github.com/repos/wifiphisher/wifiphisher/assignees{/user}","branches_url":"https://api.github.com/repos/wifiphisher/wifiphisher/branches{/branch}","tags_url":"https://api.github.com/repos/wifiphisher/wifiphisher/tags","blobs_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wifiphisher/wifiphisher/statuses/{sha}","languages_url":"https://api.github.com/repos/wifiphisher/wifiphisher/languages","stargazers_url":"https://api.github.com/repos/wifiphisher/wifiphisher/stargazers","contributors_url":"https://api.github.com/repos/wifiphisher/wifiphisher/contributors","subscribers_url":"https://api.github.com/repos/wifiphisher/wifiphisher/subscribers","subscription_url":"https://api.github.com/repos/wifiphisher/wifiphisher/subscription","commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/wifiphisher/wifiphisher/contents/{+path}","compare_url":"https://api.github.com/repos/wifiphisher/wifiphisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wifiphisher/wifiphisher/merges","archive_url":"https://api.github.com/repos/wifiphisher/wifiphisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wifiphisher/wifiphisher/downloads","issues_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues{/number}","pulls_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls{/number}","milestones_url":"https://api.github.com/repos/wifiphisher/wifiphisher/milestones{/number}","notifications_url":"https://api.github.com/repos/wifiphisher/wifiphisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wifiphisher/wifiphisher/labels{/name}","releases_url":"https://api.github.com/repos/wifiphisher/wifiphisher/releases{/id}","deployments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/deployments","created_at":"2014-09-26T12:47:28Z","updated_at":"2018-07-02T15:03:18Z","pushed_at":"2018-07-03T18:11:16Z","git_url":"git://github.com/wifiphisher/wifiphisher.git","ssh_url":"git@github.com:wifiphisher/wifiphisher.git","clone_url":"https://github.com/wifiphisher/wifiphisher.git","svn_url":"https://github.com/wifiphisher/wifiphisher","homepage":"https://wifiphisher.org","size":11085,"stargazers_count":6494,"watchers_count":6494,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1508,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1508,"open_issues":92,"watchers":6494,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/960"},"html":{"href":"https://github.com/wifiphisher/wifiphisher/pull/960"},"issue":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/960"},"comments":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/960/comments"},"review_comments":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/960/comments"},"review_comment":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/960/commits"},"statuses":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/statuses/f9ae5abd87e1b6d7d966a2a1874249a7b0d082b6"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sophron"}}