{"action":"created","comment":{"url":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls/comments/199326772","pull_request_review_id":133430574,"id":199326772,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTMyNjc3Mg==","diff_hunk":"@@ -190,6 +192,8 @@ public function getCartDataJs($checkoutType = 'multi-page')\n                     $boltHelper->applyShippingRate($sessionQuote, $shippingMethod);\n                 }\n \n+            } else {\n+                return '';","path":"app/code/community/Bolt/Boltpay/Block/Checkout/Boltpay.php","position":21,"original_position":21,"commit_id":"0b0aac30ff23a7d5f690a0db19a35ce084167035","original_commit_id":"0b0aac30ff23a7d5f690a0db19a35ce084167035","user":{"login":"mccottry","id":973856,"node_id":"MDQ6VXNlcjk3Mzg1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/973856?v=4","gravatar_id":"","url":"https://api.github.com/users/mccottry","html_url":"https://github.com/mccottry","followers_url":"https://api.github.com/users/mccottry/followers","following_url":"https://api.github.com/users/mccottry/following{/other_user}","gists_url":"https://api.github.com/users/mccottry/gists{/gist_id}","starred_url":"https://api.github.com/users/mccottry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccottry/subscriptions","organizations_url":"https://api.github.com/users/mccottry/orgs","repos_url":"https://api.github.com/users/mccottry/repos","events_url":"https://api.github.com/users/mccottry/events{/privacy}","received_events_url":"https://api.github.com/users/mccottry/received_events","type":"User","site_admin":false},"body":"@YevhenShBolt This is based from your change and without this, it is throwing an error.  I am very unfamiliar with the \"Add Bolt Button Everywhere\", so can you give a better explanation of what the problem is when using that new feature?  Otherwise, can you make the change that you are suggesting as a Pull Request to this branch?\r\n\r\nFrom what I understand, you want to return a javascript alert.  My concern is that having a javascript alert pop up on the shopping cart page the already says *Shopping Cart is Empty* will be perceived as an intrusive Bolt introduced problem to most merchants.\r\n\r\nMy proposal is to make the *Add Bolt Button Everywhere* conform to receiving an empty string, as the point of `getCartDataJs` is to return an executable javascript string. and, if the quote is empty, we shouldn't be generating any cart JS.  If the quote is empty, then either it does not call \r\n`getCartDataJs`, or if it calls this method, and it receives an empty string, then the Bolt Button should not be rendered.\r\n\r\nI assume the *Add Bolt Button Everywhere* button is the mini-cart and not an \"Instant Buy\" type button.","created_at":"2018-06-30T16:43:47Z","updated_at":"2018-06-30T16:43:47Z","html_url":"https://github.com/BoltApp/bolt-magento1/pull/104#discussion_r199326772","pull_request_url":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls/104","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls/comments/199326772"},"html":{"href":"https://github.com/BoltApp/bolt-magento1/pull/104#discussion_r199326772"},"pull_request":{"href":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls/104"}},"in_reply_to_id":199176856},"pull_request":{"url":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls/104","id":198189377,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTg5Mzc3","html_url":"https://github.com/BoltApp/bolt-magento1/pull/104","diff_url":"https://github.com/BoltApp/bolt-magento1/pull/104.diff","patch_url":"https://github.com/BoltApp/bolt-magento1/pull/104.patch","issue_url":"https://api.github.com/repos/BoltApp/bolt-magento1/issues/104","number":104,"state":"open","locked":false,"title":"Off by penny fix","user":{"login":"mccottry","id":973856,"node_id":"MDQ6VXNlcjk3Mzg1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/973856?v=4","gravatar_id":"","url":"https://api.github.com/users/mccottry","html_url":"https://github.com/mccottry","followers_url":"https://api.github.com/users/mccottry/followers","following_url":"https://api.github.com/users/mccottry/following{/other_user}","gists_url":"https://api.github.com/users/mccottry/gists{/gist_id}","starred_url":"https://api.github.com/users/mccottry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccottry/subscriptions","organizations_url":"https://api.github.com/users/mccottry/orgs","repos_url":"https://api.github.com/users/mccottry/repos","events_url":"https://api.github.com/users/mccottry/events{/privacy}","received_events_url":"https://api.github.com/users/mccottry/received_events","type":"User","site_admin":false},"body":"Also includes \r\n- merge of `develop`  to `on-hold-logic` corrections\r\n- $isEmptyQuote fix","created_at":"2018-06-29T00:50:16Z","updated_at":"2018-06-30T16:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbaa7f7e955bc16ce72c19f5c54828d292911685","assignee":null,"assignees":[],"requested_reviewers":[{"login":"daisy1754","id":980077,"node_id":"MDQ6VXNlcjk4MDA3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/980077?v=4","gravatar_id":"","url":"https://api.github.com/users/daisy1754","html_url":"https://github.com/daisy1754","followers_url":"https://api.github.com/users/daisy1754/followers","following_url":"https://api.github.com/users/daisy1754/following{/other_user}","gists_url":"https://api.github.com/users/daisy1754/gists{/gist_id}","starred_url":"https://api.github.com/users/daisy1754/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daisy1754/subscriptions","organizations_url":"https://api.github.com/users/daisy1754/orgs","repos_url":"https://api.github.com/users/daisy1754/repos","events_url":"https://api.github.com/users/daisy1754/events{/privacy}","received_events_url":"https://api.github.com/users/daisy1754/received_events","type":"User","site_admin":false},{"login":"johnmccombs1","id":2002287,"node_id":"MDQ6VXNlcjIwMDIyODc=","avatar_url":"https://avatars3.githubusercontent.com/u/2002287?v=4","gravatar_id":"","url":"https://api.github.com/users/johnmccombs1","html_url":"https://github.com/johnmccombs1","followers_url":"https://api.github.com/users/johnmccombs1/followers","following_url":"https://api.github.com/users/johnmccombs1/following{/other_user}","gists_url":"https://api.github.com/users/johnmccombs1/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmccombs1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmccombs1/subscriptions","organizations_url":"https://api.github.com/users/johnmccombs1/orgs","repos_url":"https://api.github.com/users/johnmccombs1/repos","events_url":"https://api.github.com/users/johnmccombs1/events{/privacy}","received_events_url":"https://api.github.com/users/johnmccombs1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls/104/commits","review_comments_url":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls/104/comments","review_comment_url":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BoltApp/bolt-magento1/issues/104/comments","statuses_url":"https://api.github.com/repos/BoltApp/bolt-magento1/statuses/0b0aac30ff23a7d5f690a0db19a35ce084167035","head":{"label":"BoltApp:off-by-penny-fix","ref":"off-by-penny-fix","sha":"0b0aac30ff23a7d5f690a0db19a35ce084167035","user":{"login":"BoltApp","id":8142070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxNDIwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/8142070?v=4","gravatar_id":"","url":"https://api.github.com/users/BoltApp","html_url":"https://github.com/BoltApp","followers_url":"https://api.github.com/users/BoltApp/followers","following_url":"https://api.github.com/users/BoltApp/following{/other_user}","gists_url":"https://api.github.com/users/BoltApp/gists{/gist_id}","starred_url":"https://api.github.com/users/BoltApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoltApp/subscriptions","organizations_url":"https://api.github.com/users/BoltApp/orgs","repos_url":"https://api.github.com/users/BoltApp/repos","events_url":"https://api.github.com/users/BoltApp/events{/privacy}","received_events_url":"https://api.github.com/users/BoltApp/received_events","type":"Organization","site_admin":false},"repo":{"id":125256996,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyNTY5OTY=","name":"bolt-magento1","full_name":"BoltApp/bolt-magento1","owner":{"login":"BoltApp","id":8142070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxNDIwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/8142070?v=4","gravatar_id":"","url":"https://api.github.com/users/BoltApp","html_url":"https://github.com/BoltApp","followers_url":"https://api.github.com/users/BoltApp/followers","following_url":"https://api.github.com/users/BoltApp/following{/other_user}","gists_url":"https://api.github.com/users/BoltApp/gists{/gist_id}","starred_url":"https://api.github.com/users/BoltApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoltApp/subscriptions","organizations_url":"https://api.github.com/users/BoltApp/orgs","repos_url":"https://api.github.com/users/BoltApp/repos","events_url":"https://api.github.com/users/BoltApp/events{/privacy}","received_events_url":"https://api.github.com/users/BoltApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BoltApp/bolt-magento1","description":"Bolt plugin for magento1","fork":false,"url":"https://api.github.com/repos/BoltApp/bolt-magento1","forks_url":"https://api.github.com/repos/BoltApp/bolt-magento1/forks","keys_url":"https://api.github.com/repos/BoltApp/bolt-magento1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BoltApp/bolt-magento1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BoltApp/bolt-magento1/teams","hooks_url":"https://api.github.com/repos/BoltApp/bolt-magento1/hooks","issue_events_url":"https://api.github.com/repos/BoltApp/bolt-magento1/issues/events{/number}","events_url":"https://api.github.com/repos/BoltApp/bolt-magento1/events","assignees_url":"https://api.github.com/repos/BoltApp/bolt-magento1/assignees{/user}","branches_url":"https://api.github.com/repos/BoltApp/bolt-magento1/branches{/branch}","tags_url":"https://api.github.com/repos/BoltApp/bolt-magento1/tags","blobs_url":"https://api.github.com/repos/BoltApp/bolt-magento1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BoltApp/bolt-magento1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BoltApp/bolt-magento1/git/refs{/sha}","trees_url":"https://api.github.com/repos/BoltApp/bolt-magento1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BoltApp/bolt-magento1/statuses/{sha}","languages_url":"https://api.github.com/repos/BoltApp/bolt-magento1/languages","stargazers_url":"https://api.github.com/repos/BoltApp/bolt-magento1/stargazers","contributors_url":"https://api.github.com/repos/BoltApp/bolt-magento1/contributors","subscribers_url":"https://api.github.com/repos/BoltApp/bolt-magento1/subscribers","subscription_url":"https://api.github.com/repos/BoltApp/bolt-magento1/subscription","commits_url":"https://api.github.com/repos/BoltApp/bolt-magento1/commits{/sha}","git_commits_url":"https://api.github.com/repos/BoltApp/bolt-magento1/git/commits{/sha}","comments_url":"https://api.github.com/repos/BoltApp/bolt-magento1/comments{/number}","issue_comment_url":"https://api.github.com/repos/BoltApp/bolt-magento1/issues/comments{/number}","contents_url":"https://api.github.com/repos/BoltApp/bolt-magento1/contents/{+path}","compare_url":"https://api.github.com/repos/BoltApp/bolt-magento1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BoltApp/bolt-magento1/merges","archive_url":"https://api.github.com/repos/BoltApp/bolt-magento1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BoltApp/bolt-magento1/downloads","issues_url":"https://api.github.com/repos/BoltApp/bolt-magento1/issues{/number}","pulls_url":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls{/number}","milestones_url":"https://api.github.com/repos/BoltApp/bolt-magento1/milestones{/number}","notifications_url":"https://api.github.com/repos/BoltApp/bolt-magento1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BoltApp/bolt-magento1/labels{/name}","releases_url":"https://api.github.com/repos/BoltApp/bolt-magento1/releases{/id}","deployments_url":"https://api.github.com/repos/BoltApp/bolt-magento1/deployments","created_at":"2018-03-14T18:30:30Z","updated_at":"2018-06-28T20:32:37Z","pushed_at":"2018-06-29T13:21:46Z","git_url":"git://github.com/BoltApp/bolt-magento1.git","ssh_url":"git@github.com:BoltApp/bolt-magento1.git","clone_url":"https://github.com/BoltApp/bolt-magento1.git","svn_url":"https://github.com/BoltApp/bolt-magento1","homepage":null,"size":2179,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"osl-3.0","name":"Open Software License 3.0","spdx_id":"OSL-3.0","url":"https://api.github.com/licenses/osl-3.0","node_id":"MDc6TGljZW5zZTE2"},"forks":1,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"BoltApp:on-hold-logic","ref":"on-hold-logic","sha":"26952f32de238fc1adfbb379ec8d43e1351ee852","user":{"login":"BoltApp","id":8142070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxNDIwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/8142070?v=4","gravatar_id":"","url":"https://api.github.com/users/BoltApp","html_url":"https://github.com/BoltApp","followers_url":"https://api.github.com/users/BoltApp/followers","following_url":"https://api.github.com/users/BoltApp/following{/other_user}","gists_url":"https://api.github.com/users/BoltApp/gists{/gist_id}","starred_url":"https://api.github.com/users/BoltApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoltApp/subscriptions","organizations_url":"https://api.github.com/users/BoltApp/orgs","repos_url":"https://api.github.com/users/BoltApp/repos","events_url":"https://api.github.com/users/BoltApp/events{/privacy}","received_events_url":"https://api.github.com/users/BoltApp/received_events","type":"Organization","site_admin":false},"repo":{"id":125256996,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyNTY5OTY=","name":"bolt-magento1","full_name":"BoltApp/bolt-magento1","owner":{"login":"BoltApp","id":8142070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxNDIwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/8142070?v=4","gravatar_id":"","url":"https://api.github.com/users/BoltApp","html_url":"https://github.com/BoltApp","followers_url":"https://api.github.com/users/BoltApp/followers","following_url":"https://api.github.com/users/BoltApp/following{/other_user}","gists_url":"https://api.github.com/users/BoltApp/gists{/gist_id}","starred_url":"https://api.github.com/users/BoltApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoltApp/subscriptions","organizations_url":"https://api.github.com/users/BoltApp/orgs","repos_url":"https://api.github.com/users/BoltApp/repos","events_url":"https://api.github.com/users/BoltApp/events{/privacy}","received_events_url":"https://api.github.com/users/BoltApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BoltApp/bolt-magento1","description":"Bolt plugin for magento1","fork":false,"url":"https://api.github.com/repos/BoltApp/bolt-magento1","forks_url":"https://api.github.com/repos/BoltApp/bolt-magento1/forks","keys_url":"https://api.github.com/repos/BoltApp/bolt-magento1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BoltApp/bolt-magento1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BoltApp/bolt-magento1/teams","hooks_url":"https://api.github.com/repos/BoltApp/bolt-magento1/hooks","issue_events_url":"https://api.github.com/repos/BoltApp/bolt-magento1/issues/events{/number}","events_url":"https://api.github.com/repos/BoltApp/bolt-magento1/events","assignees_url":"https://api.github.com/repos/BoltApp/bolt-magento1/assignees{/user}","branches_url":"https://api.github.com/repos/BoltApp/bolt-magento1/branches{/branch}","tags_url":"https://api.github.com/repos/BoltApp/bolt-magento1/tags","blobs_url":"https://api.github.com/repos/BoltApp/bolt-magento1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BoltApp/bolt-magento1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BoltApp/bolt-magento1/git/refs{/sha}","trees_url":"https://api.github.com/repos/BoltApp/bolt-magento1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BoltApp/bolt-magento1/statuses/{sha}","languages_url":"https://api.github.com/repos/BoltApp/bolt-magento1/languages","stargazers_url":"https://api.github.com/repos/BoltApp/bolt-magento1/stargazers","contributors_url":"https://api.github.com/repos/BoltApp/bolt-magento1/contributors","subscribers_url":"https://api.github.com/repos/BoltApp/bolt-magento1/subscribers","subscription_url":"https://api.github.com/repos/BoltApp/bolt-magento1/subscription","commits_url":"https://api.github.com/repos/BoltApp/bolt-magento1/commits{/sha}","git_commits_url":"https://api.github.com/repos/BoltApp/bolt-magento1/git/commits{/sha}","comments_url":"https://api.github.com/repos/BoltApp/bolt-magento1/comments{/number}","issue_comment_url":"https://api.github.com/repos/BoltApp/bolt-magento1/issues/comments{/number}","contents_url":"https://api.github.com/repos/BoltApp/bolt-magento1/contents/{+path}","compare_url":"https://api.github.com/repos/BoltApp/bolt-magento1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BoltApp/bolt-magento1/merges","archive_url":"https://api.github.com/repos/BoltApp/bolt-magento1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BoltApp/bolt-magento1/downloads","issues_url":"https://api.github.com/repos/BoltApp/bolt-magento1/issues{/number}","pulls_url":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls{/number}","milestones_url":"https://api.github.com/repos/BoltApp/bolt-magento1/milestones{/number}","notifications_url":"https://api.github.com/repos/BoltApp/bolt-magento1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BoltApp/bolt-magento1/labels{/name}","releases_url":"https://api.github.com/repos/BoltApp/bolt-magento1/releases{/id}","deployments_url":"https://api.github.com/repos/BoltApp/bolt-magento1/deployments","created_at":"2018-03-14T18:30:30Z","updated_at":"2018-06-28T20:32:37Z","pushed_at":"2018-06-29T13:21:46Z","git_url":"git://github.com/BoltApp/bolt-magento1.git","ssh_url":"git@github.com:BoltApp/bolt-magento1.git","clone_url":"https://github.com/BoltApp/bolt-magento1.git","svn_url":"https://github.com/BoltApp/bolt-magento1","homepage":null,"size":2179,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"osl-3.0","name":"Open Software License 3.0","spdx_id":"OSL-3.0","url":"https://api.github.com/licenses/osl-3.0","node_id":"MDc6TGljZW5zZTE2"},"forks":1,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls/104"},"html":{"href":"https://github.com/BoltApp/bolt-magento1/pull/104"},"issue":{"href":"https://api.github.com/repos/BoltApp/bolt-magento1/issues/104"},"comments":{"href":"https://api.github.com/repos/BoltApp/bolt-magento1/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BoltApp/bolt-magento1/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/BoltApp/bolt-magento1/statuses/0b0aac30ff23a7d5f690a0db19a35ce084167035"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mccottry"}}