{"push_id":2541236354,"size":2,"distinct_size":2,"ref":"refs/heads/mpilman/cmake","head":"091bc5eda975fd6e8f59ba8852993883f6da61fa","before":"3ecdf76cb4742d8a4e65e02656eae6460cb66744","commits":[{"sha":"10faffd8ff09020fcbb0ee34cd31809006cf0135","author":{"name":"Markus Pilman","email":"d7b4077aabaa62650347f4b23f3ddafba5c00e35@snowflake.net"},"message":"Several small compilation fixes for new versions of gcc\n\nThere are several missing includes for cmath in the code, I added those.\n\nNext, Coro returns a reference to a stack variable and this causes a\nwarning. As this is probably ok for Coro, I disabled the warning in\nthat file for GCC. I want to have this warning in the build system as\nit is generally a very useful warning to have.\n\nAnother change is that major and minor are deprecated for a while now.\nI replaced those with gnu_dev_major and gnu_dev_minor.\n\nErrorOr currently implements operators ==, !=, and <. These do not\ncompile because Error does not implement ==. This compiles on older\nversions of gcc and clang because ErrorOr<T>::operator== is not used\nanywhere. It is still wrong though and newer gcc versions complain.\nI simply removed these methods.\n\nThe most interesting fix is that TraceEvent::~TraceEvent is currently\nthrowing exceptions. This is illegal behavior in C++11 and a idea in\nolder versions of C++. For now I simply removed the throw, but this\nmight need some more thought.","distinct":true,"url":"https://api.github.com/repos/snowflakedb/foundationdb/commits/10faffd8ff09020fcbb0ee34cd31809006cf0135"},{"sha":"091bc5eda975fd6e8f59ba8852993883f6da61fa","author":{"name":"Markus Pilman","email":"d7b4077aabaa62650347f4b23f3ddafba5c00e35@snowflake.net"},"message":"Some more improvements to the build and preparations for packaging","distinct":true,"url":"https://api.github.com/repos/snowflakedb/foundationdb/commits/091bc5eda975fd6e8f59ba8852993883f6da61fa"}]}
{"actor":{"display_login":"mpilman"}}