{"action":"created","comment":{"url":"https://api.github.com/repos/redbadger/pride-london-app/pulls/comments/195656291","pull_request_review_id":129068952,"id":195656291,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTY1NjI5MQ==","diff_hunk":"@@ -24,6 +24,13 @@ const parse = (date: string) => LuxonDateTime.fromISO(date, { setZone: true });\n export const toFormat = (date: string, format: string) =>\n   parse(date).toFormat(format);\n \n+export const toLondonFormat = (date: string, format: string) =>\n+  // Note setZone transforms the timezone and time but retains\n+  // the epoch time. Essentially it keeps the same value\n+  parse(date)\n+    .setZone(\"utc+1\")","path":"src/lib/date.js","position":8,"original_position":8,"commit_id":"f2ec66107e73fc4883fdf411c9fe5662094bb0ea","original_commit_id":"f2ec66107e73fc4883fdf411c9fe5662094bb0ea","user":{"login":"frigus02","id":3579251,"node_id":"MDQ6VXNlcjM1NzkyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3579251?v=4","gravatar_id":"","url":"https://api.github.com/users/frigus02","html_url":"https://github.com/frigus02","followers_url":"https://api.github.com/users/frigus02/followers","following_url":"https://api.github.com/users/frigus02/following{/other_user}","gists_url":"https://api.github.com/users/frigus02/gists{/gist_id}","starred_url":"https://api.github.com/users/frigus02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frigus02/subscriptions","organizations_url":"https://api.github.com/users/frigus02/orgs","repos_url":"https://api.github.com/users/frigus02/repos","events_url":"https://api.github.com/users/frigus02/events{/privacy}","received_events_url":"https://api.github.com/users/frigus02/received_events","type":"User","site_admin":false},"body":"Okay, we need to check if this is supported on Android and iOS. Appearently IANA time zone names are implemented using built-in JavaScript Intl APIs:\r\n\r\nhttps://moment.github.io/luxon/docs/manual/zones.html#iana-support","created_at":"2018-06-15T07:50:16Z","updated_at":"2018-06-15T07:50:16Z","html_url":"https://github.com/redbadger/pride-london-app/pull/438#discussion_r195656291","pull_request_url":"https://api.github.com/repos/redbadger/pride-london-app/pulls/438","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/redbadger/pride-london-app/pulls/comments/195656291"},"html":{"href":"https://github.com/redbadger/pride-london-app/pull/438#discussion_r195656291"},"pull_request":{"href":"https://api.github.com/repos/redbadger/pride-london-app/pulls/438"}},"in_reply_to_id":195655361},"pull_request":{"url":"https://api.github.com/repos/redbadger/pride-london-app/pulls/438","id":194589094,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTg5MDk0","html_url":"https://github.com/redbadger/pride-london-app/pull/438","diff_url":"https://github.com/redbadger/pride-london-app/pull/438.diff","patch_url":"https://github.com/redbadger/pride-london-app/pull/438.patch","issue_url":"https://api.github.com/repos/redbadger/pride-london-app/issues/438","number":438,"state":"open","locked":false,"title":"Fix Events Listing: Filtering can break the events list","user":{"login":"RGBboy","id":1566539,"node_id":"MDQ6VXNlcjE1NjY1Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1566539?v=4","gravatar_id":"","url":"https://api.github.com/users/RGBboy","html_url":"https://github.com/RGBboy","followers_url":"https://api.github.com/users/RGBboy/followers","following_url":"https://api.github.com/users/RGBboy/following{/other_user}","gists_url":"https://api.github.com/users/RGBboy/gists{/gist_id}","starred_url":"https://api.github.com/users/RGBboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RGBboy/subscriptions","organizations_url":"https://api.github.com/users/RGBboy/orgs","repos_url":"https://api.github.com/users/RGBboy/repos","events_url":"https://api.github.com/users/RGBboy/events{/privacy}","received_events_url":"https://api.github.com/users/RGBboy/received_events","type":"User","site_admin":false},"body":"Fixes #436.\r\n\r\nSo it turns out we were not respecting timezones when creating the ids for the event list groups. This along with some of our test data having obscure timezones would cause repeated keys being used. In turn this causes React to go weird. This PR updates user facing times to always be coerced to the local timezone (while still preserving the actual time, i.e. time from epoch). While this means users would see different times depending on their timezone settings, they would see the correct time relevant to their device clock. Happy to be challenged on this.\r\n\r\n## Pre-merge check-list\r\n\r\n* [ ] Tester approved\r\n\r\n## Tester check-list\r\n\r\n* [ ] Tested on multiple devices / OS versions (Test on the physical device(s) you have access to, otherwise use BrowserStack):\r\n\r\n  * [x] Galaxy S8 (Android 7.0/8.0)\r\n  * [ ] Galaxy S7 (Android 6.0)\r\n  * [ ] iPhone X (iOS 11.x)\r\n  * [ ] iPhone 8 (11.x)\r\n  * [x] iPhone 7 (iOS 10.x)","created_at":"2018-06-13T13:37:06Z","updated_at":"2018-06-15T07:50:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0eed7695ecd0bde2442480ae2cf8d4629c955767","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":888890580,"node_id":"MDU6TGFiZWw4ODg4OTA1ODA=","url":"https://api.github.com/repos/redbadger/pride-london-app/labels/qa%20approved","name":"qa approved","color":"bfd4f2","default":false},{"id":819298344,"node_id":"MDU6TGFiZWw4MTkyOTgzNDQ=","url":"https://api.github.com/repos/redbadger/pride-london-app/labels/ready%20for%20review","name":"ready for review","color":"1bd653","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/redbadger/pride-london-app/pulls/438/commits","review_comments_url":"https://api.github.com/repos/redbadger/pride-london-app/pulls/438/comments","review_comment_url":"https://api.github.com/repos/redbadger/pride-london-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redbadger/pride-london-app/issues/438/comments","statuses_url":"https://api.github.com/repos/redbadger/pride-london-app/statuses/f2ec66107e73fc4883fdf411c9fe5662094bb0ea","head":{"label":"redbadger:gh-436-fix-borked-event-list","ref":"gh-436-fix-borked-event-list","sha":"f2ec66107e73fc4883fdf411c9fe5662094bb0ea","user":{"login":"redbadger","id":265650,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTY1MA==","avatar_url":"https://avatars1.githubusercontent.com/u/265650?v=4","gravatar_id":"","url":"https://api.github.com/users/redbadger","html_url":"https://github.com/redbadger","followers_url":"https://api.github.com/users/redbadger/followers","following_url":"https://api.github.com/users/redbadger/following{/other_user}","gists_url":"https://api.github.com/users/redbadger/gists{/gist_id}","starred_url":"https://api.github.com/users/redbadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbadger/subscriptions","organizations_url":"https://api.github.com/users/redbadger/orgs","repos_url":"https://api.github.com/users/redbadger/repos","events_url":"https://api.github.com/users/redbadger/events{/privacy}","received_events_url":"https://api.github.com/users/redbadger/received_events","type":"Organization","site_admin":false},"repo":{"id":115105984,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUxMDU5ODQ=","name":"pride-london-app","full_name":"redbadger/pride-london-app","owner":{"login":"redbadger","id":265650,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTY1MA==","avatar_url":"https://avatars1.githubusercontent.com/u/265650?v=4","gravatar_id":"","url":"https://api.github.com/users/redbadger","html_url":"https://github.com/redbadger","followers_url":"https://api.github.com/users/redbadger/followers","following_url":"https://api.github.com/users/redbadger/following{/other_user}","gists_url":"https://api.github.com/users/redbadger/gists{/gist_id}","starred_url":"https://api.github.com/users/redbadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbadger/subscriptions","organizations_url":"https://api.github.com/users/redbadger/orgs","repos_url":"https://api.github.com/users/redbadger/repos","events_url":"https://api.github.com/users/redbadger/events{/privacy}","received_events_url":"https://api.github.com/users/redbadger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redbadger/pride-london-app","description":"Pride in London mobile app","fork":false,"url":"https://api.github.com/repos/redbadger/pride-london-app","forks_url":"https://api.github.com/repos/redbadger/pride-london-app/forks","keys_url":"https://api.github.com/repos/redbadger/pride-london-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redbadger/pride-london-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redbadger/pride-london-app/teams","hooks_url":"https://api.github.com/repos/redbadger/pride-london-app/hooks","issue_events_url":"https://api.github.com/repos/redbadger/pride-london-app/issues/events{/number}","events_url":"https://api.github.com/repos/redbadger/pride-london-app/events","assignees_url":"https://api.github.com/repos/redbadger/pride-london-app/assignees{/user}","branches_url":"https://api.github.com/repos/redbadger/pride-london-app/branches{/branch}","tags_url":"https://api.github.com/repos/redbadger/pride-london-app/tags","blobs_url":"https://api.github.com/repos/redbadger/pride-london-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redbadger/pride-london-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redbadger/pride-london-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/redbadger/pride-london-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redbadger/pride-london-app/statuses/{sha}","languages_url":"https://api.github.com/repos/redbadger/pride-london-app/languages","stargazers_url":"https://api.github.com/repos/redbadger/pride-london-app/stargazers","contributors_url":"https://api.github.com/repos/redbadger/pride-london-app/contributors","subscribers_url":"https://api.github.com/repos/redbadger/pride-london-app/subscribers","subscription_url":"https://api.github.com/repos/redbadger/pride-london-app/subscription","commits_url":"https://api.github.com/repos/redbadger/pride-london-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/redbadger/pride-london-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/redbadger/pride-london-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/redbadger/pride-london-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/redbadger/pride-london-app/contents/{+path}","compare_url":"https://api.github.com/repos/redbadger/pride-london-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redbadger/pride-london-app/merges","archive_url":"https://api.github.com/repos/redbadger/pride-london-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redbadger/pride-london-app/downloads","issues_url":"https://api.github.com/repos/redbadger/pride-london-app/issues{/number}","pulls_url":"https://api.github.com/repos/redbadger/pride-london-app/pulls{/number}","milestones_url":"https://api.github.com/repos/redbadger/pride-london-app/milestones{/number}","notifications_url":"https://api.github.com/repos/redbadger/pride-london-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redbadger/pride-london-app/labels{/name}","releases_url":"https://api.github.com/repos/redbadger/pride-london-app/releases{/id}","deployments_url":"https://api.github.com/repos/redbadger/pride-london-app/deployments","created_at":"2017-12-22T10:40:26Z","updated_at":"2018-06-13T16:21:49Z","pushed_at":"2018-06-14T17:31:12Z","git_url":"git://github.com/redbadger/pride-london-app.git","ssh_url":"git@github.com:redbadger/pride-london-app.git","clone_url":"https://github.com/redbadger/pride-london-app.git","svn_url":"https://github.com/redbadger/pride-london-app","homepage":"","size":139253,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":76,"watchers":26,"default_branch":"master"}},"base":{"label":"redbadger:master","ref":"master","sha":"b473e1cfd0cd902935c81fe1bd2f04385589cdcb","user":{"login":"redbadger","id":265650,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTY1MA==","avatar_url":"https://avatars1.githubusercontent.com/u/265650?v=4","gravatar_id":"","url":"https://api.github.com/users/redbadger","html_url":"https://github.com/redbadger","followers_url":"https://api.github.com/users/redbadger/followers","following_url":"https://api.github.com/users/redbadger/following{/other_user}","gists_url":"https://api.github.com/users/redbadger/gists{/gist_id}","starred_url":"https://api.github.com/users/redbadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbadger/subscriptions","organizations_url":"https://api.github.com/users/redbadger/orgs","repos_url":"https://api.github.com/users/redbadger/repos","events_url":"https://api.github.com/users/redbadger/events{/privacy}","received_events_url":"https://api.github.com/users/redbadger/received_events","type":"Organization","site_admin":false},"repo":{"id":115105984,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUxMDU5ODQ=","name":"pride-london-app","full_name":"redbadger/pride-london-app","owner":{"login":"redbadger","id":265650,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTY1MA==","avatar_url":"https://avatars1.githubusercontent.com/u/265650?v=4","gravatar_id":"","url":"https://api.github.com/users/redbadger","html_url":"https://github.com/redbadger","followers_url":"https://api.github.com/users/redbadger/followers","following_url":"https://api.github.com/users/redbadger/following{/other_user}","gists_url":"https://api.github.com/users/redbadger/gists{/gist_id}","starred_url":"https://api.github.com/users/redbadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbadger/subscriptions","organizations_url":"https://api.github.com/users/redbadger/orgs","repos_url":"https://api.github.com/users/redbadger/repos","events_url":"https://api.github.com/users/redbadger/events{/privacy}","received_events_url":"https://api.github.com/users/redbadger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redbadger/pride-london-app","description":"Pride in London mobile app","fork":false,"url":"https://api.github.com/repos/redbadger/pride-london-app","forks_url":"https://api.github.com/repos/redbadger/pride-london-app/forks","keys_url":"https://api.github.com/repos/redbadger/pride-london-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redbadger/pride-london-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redbadger/pride-london-app/teams","hooks_url":"https://api.github.com/repos/redbadger/pride-london-app/hooks","issue_events_url":"https://api.github.com/repos/redbadger/pride-london-app/issues/events{/number}","events_url":"https://api.github.com/repos/redbadger/pride-london-app/events","assignees_url":"https://api.github.com/repos/redbadger/pride-london-app/assignees{/user}","branches_url":"https://api.github.com/repos/redbadger/pride-london-app/branches{/branch}","tags_url":"https://api.github.com/repos/redbadger/pride-london-app/tags","blobs_url":"https://api.github.com/repos/redbadger/pride-london-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redbadger/pride-london-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redbadger/pride-london-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/redbadger/pride-london-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redbadger/pride-london-app/statuses/{sha}","languages_url":"https://api.github.com/repos/redbadger/pride-london-app/languages","stargazers_url":"https://api.github.com/repos/redbadger/pride-london-app/stargazers","contributors_url":"https://api.github.com/repos/redbadger/pride-london-app/contributors","subscribers_url":"https://api.github.com/repos/redbadger/pride-london-app/subscribers","subscription_url":"https://api.github.com/repos/redbadger/pride-london-app/subscription","commits_url":"https://api.github.com/repos/redbadger/pride-london-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/redbadger/pride-london-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/redbadger/pride-london-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/redbadger/pride-london-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/redbadger/pride-london-app/contents/{+path}","compare_url":"https://api.github.com/repos/redbadger/pride-london-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redbadger/pride-london-app/merges","archive_url":"https://api.github.com/repos/redbadger/pride-london-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redbadger/pride-london-app/downloads","issues_url":"https://api.github.com/repos/redbadger/pride-london-app/issues{/number}","pulls_url":"https://api.github.com/repos/redbadger/pride-london-app/pulls{/number}","milestones_url":"https://api.github.com/repos/redbadger/pride-london-app/milestones{/number}","notifications_url":"https://api.github.com/repos/redbadger/pride-london-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redbadger/pride-london-app/labels{/name}","releases_url":"https://api.github.com/repos/redbadger/pride-london-app/releases{/id}","deployments_url":"https://api.github.com/repos/redbadger/pride-london-app/deployments","created_at":"2017-12-22T10:40:26Z","updated_at":"2018-06-13T16:21:49Z","pushed_at":"2018-06-14T17:31:12Z","git_url":"git://github.com/redbadger/pride-london-app.git","ssh_url":"git@github.com:redbadger/pride-london-app.git","clone_url":"https://github.com/redbadger/pride-london-app.git","svn_url":"https://github.com/redbadger/pride-london-app","homepage":"","size":139253,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":76,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redbadger/pride-london-app/pulls/438"},"html":{"href":"https://github.com/redbadger/pride-london-app/pull/438"},"issue":{"href":"https://api.github.com/repos/redbadger/pride-london-app/issues/438"},"comments":{"href":"https://api.github.com/repos/redbadger/pride-london-app/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/redbadger/pride-london-app/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/redbadger/pride-london-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redbadger/pride-london-app/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/redbadger/pride-london-app/statuses/f2ec66107e73fc4883fdf411c9fe5662094bb0ea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"frigus02"}}