{"action":"created","comment":{"url":"https://api.github.com/repos/StackStorm/st2-packages/pulls/comments/196893298","pull_request_review_id":130529444,"id":196893298,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Njg5MzI5OA==","diff_hunk":"@@ -185,11 +185,9 @@ configure_st2_cli_config() {\n     sudo mkdir -p ${ROOT_USER_CLI_CONFIG_DIRECTORY}\n   fi\n \n-  sudo sh -c \"cat <<EOT > ${ROOT_USER_CLI_CONFIG_PATH}\n-[credentials]\n-username = ${USERNAME}\n-password = ${PASSWORD}\n-EOT\"\n+  sudo sh -c st2 login --config ${ROOT_USER_CLI_CONFIG_PATH} \\","path":"scripts/includes/common.sh","position":9,"original_position":9,"commit_id":"c16ba5497abbbe4b2501d16ce9bf9a34a1df68c7","original_commit_id":"c16ba5497abbbe4b2501d16ce9bf9a34a1df68c7","user":{"login":"armab","id":1533818,"node_id":"MDQ6VXNlcjE1MzM4MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1533818?v=4","gravatar_id":"","url":"https://api.github.com/users/armab","html_url":"https://github.com/armab","followers_url":"https://api.github.com/users/armab/followers","following_url":"https://api.github.com/users/armab/following{/other_user}","gists_url":"https://api.github.com/users/armab/gists{/gist_id}","starred_url":"https://api.github.com/users/armab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armab/subscriptions","organizations_url":"https://api.github.com/users/armab/orgs","repos_url":"https://api.github.com/users/armab/repos","events_url":"https://api.github.com/users/armab/events{/privacy}","received_events_url":"https://api.github.com/users/armab/received_events","type":"User","site_admin":false},"body":"Thanks for explaining that.\r\n\r\nTo ensure st2 login config is created for both `user` and `root`, would it be enough to run\r\n1) `st2 login -w` (for user)\r\n2) `sudo st2 login -w` (for root)\r\n\r\nCan st2 login handle that correctly?\r\n---\r\nAdditionally, there is no such `--config` option for `st2 login` command.\r\nWe shouldn't hardcode the dirs in every installer. It's a st2 responsibility to decide on config dirs.\r\n","created_at":"2018-06-20T18:17:19Z","updated_at":"2018-06-20T18:17:19Z","html_url":"https://github.com/StackStorm/st2-packages/pull/563#discussion_r196893298","pull_request_url":"https://api.github.com/repos/StackStorm/st2-packages/pulls/563","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/StackStorm/st2-packages/pulls/comments/196893298"},"html":{"href":"https://github.com/StackStorm/st2-packages/pull/563#discussion_r196893298"},"pull_request":{"href":"https://api.github.com/repos/StackStorm/st2-packages/pulls/563"}},"in_reply_to_id":196882898},"pull_request":{"url":"https://api.github.com/repos/StackStorm/st2-packages/pulls/563","id":195047101,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDQ3MTAx","html_url":"https://github.com/StackStorm/st2-packages/pull/563","diff_url":"https://github.com/StackStorm/st2-packages/pull/563.diff","patch_url":"https://github.com/StackStorm/st2-packages/pull/563.patch","issue_url":"https://api.github.com/repos/StackStorm/st2-packages/issues/563","number":563,"state":"open","locked":false,"title":"Fix configuration directory and file permissions","user":{"login":"blag","id":597113,"node_id":"MDQ6VXNlcjU5NzExMw==","avatar_url":"https://avatars0.githubusercontent.com/u/597113?v=4","gravatar_id":"","url":"https://api.github.com/users/blag","html_url":"https://github.com/blag","followers_url":"https://api.github.com/users/blag/followers","following_url":"https://api.github.com/users/blag/following{/other_user}","gists_url":"https://api.github.com/users/blag/gists{/gist_id}","starred_url":"https://api.github.com/users/blag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blag/subscriptions","organizations_url":"https://api.github.com/users/blag/orgs","repos_url":"https://api.github.com/users/blag/repos","events_url":"https://api.github.com/users/blag/events{/privacy}","received_events_url":"https://api.github.com/users/blag/received_events","type":"User","site_admin":false},"body":"Companion PR to [st2#4173](https://github.com/StackStorm/st2/pull/4173).\r\n\r\nFixes configuration directory permissions to `2770` and the configuration file permissions to `660`.\r\n\r\nFixes #558.","created_at":"2018-06-14T23:52:53Z","updated_at":"2018-06-20T18:17:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dbac92229c2e5635172de8dcba026329436327f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":705501069,"node_id":"MDU6TGFiZWw3MDU1MDEwNjk=","url":"https://api.github.com/repos/StackStorm/st2-packages/labels/bash%20installer","name":"bash installer","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/StackStorm/st2-packages/pulls/563/commits","review_comments_url":"https://api.github.com/repos/StackStorm/st2-packages/pulls/563/comments","review_comment_url":"https://api.github.com/repos/StackStorm/st2-packages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StackStorm/st2-packages/issues/563/comments","statuses_url":"https://api.github.com/repos/StackStorm/st2-packages/statuses/c16ba5497abbbe4b2501d16ce9bf9a34a1df68c7","head":{"label":"StackStorm:fix-config-permissions","ref":"fix-config-permissions","sha":"c16ba5497abbbe4b2501d16ce9bf9a34a1df68c7","user":{"login":"StackStorm","id":4969009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4969009?v=4","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"repo":{"id":38112294,"node_id":"MDEwOlJlcG9zaXRvcnkzODExMjI5NA==","name":"st2-packages","full_name":"StackStorm/st2-packages","owner":{"login":"StackStorm","id":4969009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4969009?v=4","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackStorm/st2-packages","description":"StackStorm deb/rpm packages (automated docker build pipeline)","fork":false,"url":"https://api.github.com/repos/StackStorm/st2-packages","forks_url":"https://api.github.com/repos/StackStorm/st2-packages/forks","keys_url":"https://api.github.com/repos/StackStorm/st2-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackStorm/st2-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackStorm/st2-packages/teams","hooks_url":"https://api.github.com/repos/StackStorm/st2-packages/hooks","issue_events_url":"https://api.github.com/repos/StackStorm/st2-packages/issues/events{/number}","events_url":"https://api.github.com/repos/StackStorm/st2-packages/events","assignees_url":"https://api.github.com/repos/StackStorm/st2-packages/assignees{/user}","branches_url":"https://api.github.com/repos/StackStorm/st2-packages/branches{/branch}","tags_url":"https://api.github.com/repos/StackStorm/st2-packages/tags","blobs_url":"https://api.github.com/repos/StackStorm/st2-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackStorm/st2-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackStorm/st2-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackStorm/st2-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackStorm/st2-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/StackStorm/st2-packages/languages","stargazers_url":"https://api.github.com/repos/StackStorm/st2-packages/stargazers","contributors_url":"https://api.github.com/repos/StackStorm/st2-packages/contributors","subscribers_url":"https://api.github.com/repos/StackStorm/st2-packages/subscribers","subscription_url":"https://api.github.com/repos/StackStorm/st2-packages/subscription","commits_url":"https://api.github.com/repos/StackStorm/st2-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackStorm/st2-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackStorm/st2-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackStorm/st2-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackStorm/st2-packages/contents/{+path}","compare_url":"https://api.github.com/repos/StackStorm/st2-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackStorm/st2-packages/merges","archive_url":"https://api.github.com/repos/StackStorm/st2-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackStorm/st2-packages/downloads","issues_url":"https://api.github.com/repos/StackStorm/st2-packages/issues{/number}","pulls_url":"https://api.github.com/repos/StackStorm/st2-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/StackStorm/st2-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/StackStorm/st2-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackStorm/st2-packages/labels{/name}","releases_url":"https://api.github.com/repos/StackStorm/st2-packages/releases{/id}","deployments_url":"https://api.github.com/repos/StackStorm/st2-packages/deployments","created_at":"2015-06-26T13:20:51Z","updated_at":"2018-06-01T15:08:06Z","pushed_at":"2018-06-20T16:27:01Z","git_url":"git://github.com/StackStorm/st2-packages.git","ssh_url":"git@github.com:StackStorm/st2-packages.git","clone_url":"https://github.com/StackStorm/st2-packages.git","svn_url":"https://github.com/StackStorm/st2-packages","homepage":"https://stackstorm.com/","size":1605,"stargazers_count":11,"watchers_count":11,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":44,"license":null,"forks":39,"open_issues":44,"watchers":11,"default_branch":"master"}},"base":{"label":"StackStorm:master","ref":"master","sha":"40d278a8a25e09e2602c3e981d2a2c5fc77747ac","user":{"login":"StackStorm","id":4969009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4969009?v=4","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"repo":{"id":38112294,"node_id":"MDEwOlJlcG9zaXRvcnkzODExMjI5NA==","name":"st2-packages","full_name":"StackStorm/st2-packages","owner":{"login":"StackStorm","id":4969009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4969009?v=4","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackStorm/st2-packages","description":"StackStorm deb/rpm packages (automated docker build pipeline)","fork":false,"url":"https://api.github.com/repos/StackStorm/st2-packages","forks_url":"https://api.github.com/repos/StackStorm/st2-packages/forks","keys_url":"https://api.github.com/repos/StackStorm/st2-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackStorm/st2-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackStorm/st2-packages/teams","hooks_url":"https://api.github.com/repos/StackStorm/st2-packages/hooks","issue_events_url":"https://api.github.com/repos/StackStorm/st2-packages/issues/events{/number}","events_url":"https://api.github.com/repos/StackStorm/st2-packages/events","assignees_url":"https://api.github.com/repos/StackStorm/st2-packages/assignees{/user}","branches_url":"https://api.github.com/repos/StackStorm/st2-packages/branches{/branch}","tags_url":"https://api.github.com/repos/StackStorm/st2-packages/tags","blobs_url":"https://api.github.com/repos/StackStorm/st2-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackStorm/st2-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackStorm/st2-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackStorm/st2-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackStorm/st2-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/StackStorm/st2-packages/languages","stargazers_url":"https://api.github.com/repos/StackStorm/st2-packages/stargazers","contributors_url":"https://api.github.com/repos/StackStorm/st2-packages/contributors","subscribers_url":"https://api.github.com/repos/StackStorm/st2-packages/subscribers","subscription_url":"https://api.github.com/repos/StackStorm/st2-packages/subscription","commits_url":"https://api.github.com/repos/StackStorm/st2-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackStorm/st2-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackStorm/st2-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackStorm/st2-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackStorm/st2-packages/contents/{+path}","compare_url":"https://api.github.com/repos/StackStorm/st2-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackStorm/st2-packages/merges","archive_url":"https://api.github.com/repos/StackStorm/st2-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackStorm/st2-packages/downloads","issues_url":"https://api.github.com/repos/StackStorm/st2-packages/issues{/number}","pulls_url":"https://api.github.com/repos/StackStorm/st2-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/StackStorm/st2-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/StackStorm/st2-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackStorm/st2-packages/labels{/name}","releases_url":"https://api.github.com/repos/StackStorm/st2-packages/releases{/id}","deployments_url":"https://api.github.com/repos/StackStorm/st2-packages/deployments","created_at":"2015-06-26T13:20:51Z","updated_at":"2018-06-01T15:08:06Z","pushed_at":"2018-06-20T16:27:01Z","git_url":"git://github.com/StackStorm/st2-packages.git","ssh_url":"git@github.com:StackStorm/st2-packages.git","clone_url":"https://github.com/StackStorm/st2-packages.git","svn_url":"https://github.com/StackStorm/st2-packages","homepage":"https://stackstorm.com/","size":1605,"stargazers_count":11,"watchers_count":11,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":44,"license":null,"forks":39,"open_issues":44,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StackStorm/st2-packages/pulls/563"},"html":{"href":"https://github.com/StackStorm/st2-packages/pull/563"},"issue":{"href":"https://api.github.com/repos/StackStorm/st2-packages/issues/563"},"comments":{"href":"https://api.github.com/repos/StackStorm/st2-packages/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/StackStorm/st2-packages/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/StackStorm/st2-packages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StackStorm/st2-packages/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/StackStorm/st2-packages/statuses/c16ba5497abbbe4b2501d16ce9bf9a34a1df68c7"}},"author_association":"NONE"}}
{"actor":{"display_login":"armab"}}