{"action":"created","comment":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/comments/202448568","pull_request_review_id":137159130,"id":202448568,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQ0ODU2OA==","diff_hunk":"@@ -42,7 +42,10 @@ CFLAGS += -mno-red-zone\n CFLAGS += -static -nostdinc -nostdlib -fno-common","path":"hypervisor/Makefile","position":null,"original_position":1,"commit_id":"1186f253f5f3ecb84a9197bc7da54fe8f0151291","original_commit_id":"a0f2c012710fe6fde9024b5cc89d12b9f638fd81","user":{"login":"ZideChen0","id":37550952,"node_id":"MDQ6VXNlcjM3NTUwOTUy","avatar_url":"https://avatars0.githubusercontent.com/u/37550952?v=4","gravatar_id":"","url":"https://api.github.com/users/ZideChen0","html_url":"https://github.com/ZideChen0","followers_url":"https://api.github.com/users/ZideChen0/followers","following_url":"https://api.github.com/users/ZideChen0/following{/other_user}","gists_url":"https://api.github.com/users/ZideChen0/gists{/gist_id}","starred_url":"https://api.github.com/users/ZideChen0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZideChen0/subscriptions","organizations_url":"https://api.github.com/users/ZideChen0/orgs","repos_url":"https://api.github.com/users/ZideChen0/repos","events_url":"https://api.github.com/users/ZideChen0/events{/privacy}","received_events_url":"https://api.github.com/users/ZideChen0/received_events","type":"User","site_admin":false},"body":"Hi Junjie,\r\n\r\nYou are right. It's safer to wrap \"CFLAGS += -static\" with CONFIG_RELOC. Thanks for pointing it out.\r\n\r\nThanks,\r\nZide","created_at":"2018-07-13T19:17:35Z","updated_at":"2018-07-13T19:17:36Z","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/687#discussion_r202448568","pull_request_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/687","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/comments/202448568"},"html":{"href":"https://github.com/projectacrn/acrn-hypervisor/pull/687#discussion_r202448568"},"pull_request":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/687"}},"in_reply_to_id":202224385},"pull_request":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/687","id":201067059,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDY3MDU5","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/687","diff_url":"https://github.com/projectacrn/acrn-hypervisor/pull/687.diff","patch_url":"https://github.com/projectacrn/acrn-hypervisor/pull/687.patch","issue_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/687","number":687,"state":"open","locked":false,"title":"hv: further fix to configurable relocatoin","user":{"login":"ZideChen0","id":37550952,"node_id":"MDQ6VXNlcjM3NTUwOTUy","avatar_url":"https://avatars0.githubusercontent.com/u/37550952?v=4","gravatar_id":"","url":"https://api.github.com/users/ZideChen0","html_url":"https://github.com/ZideChen0","followers_url":"https://api.github.com/users/ZideChen0/followers","following_url":"https://api.github.com/users/ZideChen0/following{/other_user}","gists_url":"https://api.github.com/users/ZideChen0/gists{/gist_id}","starred_url":"https://api.github.com/users/ZideChen0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZideChen0/subscriptions","organizations_url":"https://api.github.com/users/ZideChen0/orgs","repos_url":"https://api.github.com/users/ZideChen0/repos","events_url":"https://api.github.com/users/ZideChen0/events{/privacy}","received_events_url":"https://api.github.com/users/ZideChen0/received_events","type":"User","site_admin":false},"body":"commit ia23549aa915e7dc2c (\"build: make relocation-related code\r\nconfigurable\") adds CONFIG_RELOC to make relocation configurable\r\n\r\nThis patch corrects the behavior when CONFIG_RELOC is disabled\r\n- Don't use \"CFLAGS += -fpie\" and put back \"LDFLAGS += -static\"\r\n- __emalloc(): forced to allocate exactly the asked address, which is\r\n  CONFIG_RAM_START","created_at":"2018-07-12T17:05:37Z","updated_at":"2018-07-13T19:17:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84a7545c7d40740f7803a0c551e803a2be71026a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anthonyzxu","id":17092385,"node_id":"MDQ6VXNlcjE3MDkyMzg1","avatar_url":"https://avatars2.githubusercontent.com/u/17092385?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonyzxu","html_url":"https://github.com/anthonyzxu","followers_url":"https://api.github.com/users/anthonyzxu/followers","following_url":"https://api.github.com/users/anthonyzxu/following{/other_user}","gists_url":"https://api.github.com/users/anthonyzxu/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyzxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyzxu/subscriptions","organizations_url":"https://api.github.com/users/anthonyzxu/orgs","repos_url":"https://api.github.com/users/anthonyzxu/repos","events_url":"https://api.github.com/users/anthonyzxu/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyzxu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/687/commits","review_comments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/687/comments","review_comment_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/687/comments","statuses_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/statuses/1186f253f5f3ecb84a9197bc7da54fe8f0151291","head":{"label":"ZideChen0:reloc","ref":"reloc","sha":"1186f253f5f3ecb84a9197bc7da54fe8f0151291","user":{"login":"ZideChen0","id":37550952,"node_id":"MDQ6VXNlcjM3NTUwOTUy","avatar_url":"https://avatars0.githubusercontent.com/u/37550952?v=4","gravatar_id":"","url":"https://api.github.com/users/ZideChen0","html_url":"https://github.com/ZideChen0","followers_url":"https://api.github.com/users/ZideChen0/followers","following_url":"https://api.github.com/users/ZideChen0/following{/other_user}","gists_url":"https://api.github.com/users/ZideChen0/gists{/gist_id}","starred_url":"https://api.github.com/users/ZideChen0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZideChen0/subscriptions","organizations_url":"https://api.github.com/users/ZideChen0/orgs","repos_url":"https://api.github.com/users/ZideChen0/repos","events_url":"https://api.github.com/users/ZideChen0/events{/privacy}","received_events_url":"https://api.github.com/users/ZideChen0/received_events","type":"User","site_admin":false},"repo":{"id":130270419,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAyNzA0MTk=","name":"acrn-hypervisor","full_name":"ZideChen0/acrn-hypervisor","owner":{"login":"ZideChen0","id":37550952,"node_id":"MDQ6VXNlcjM3NTUwOTUy","avatar_url":"https://avatars0.githubusercontent.com/u/37550952?v=4","gravatar_id":"","url":"https://api.github.com/users/ZideChen0","html_url":"https://github.com/ZideChen0","followers_url":"https://api.github.com/users/ZideChen0/followers","following_url":"https://api.github.com/users/ZideChen0/following{/other_user}","gists_url":"https://api.github.com/users/ZideChen0/gists{/gist_id}","starred_url":"https://api.github.com/users/ZideChen0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZideChen0/subscriptions","organizations_url":"https://api.github.com/users/ZideChen0/orgs","repos_url":"https://api.github.com/users/ZideChen0/repos","events_url":"https://api.github.com/users/ZideChen0/events{/privacy}","received_events_url":"https://api.github.com/users/ZideChen0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZideChen0/acrn-hypervisor","description":"Project ACRN hypervisor ","fork":true,"url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor","forks_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/forks","keys_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/teams","hooks_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/hooks","issue_events_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/issues/events{/number}","events_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/events","assignees_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/assignees{/user}","branches_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/branches{/branch}","tags_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/tags","blobs_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/statuses/{sha}","languages_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/languages","stargazers_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/stargazers","contributors_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/contributors","subscribers_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/subscribers","subscription_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/subscription","commits_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/contents/{+path}","compare_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/merges","archive_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/downloads","issues_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/issues{/number}","pulls_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/pulls{/number}","milestones_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/milestones{/number}","notifications_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/labels{/name}","releases_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/releases{/id}","deployments_url":"https://api.github.com/repos/ZideChen0/acrn-hypervisor/deployments","created_at":"2018-04-19T20:41:55Z","updated_at":"2018-06-07T05:04:15Z","pushed_at":"2018-07-13T19:14:40Z","git_url":"git://github.com/ZideChen0/acrn-hypervisor.git","ssh_url":"git@github.com:ZideChen0/acrn-hypervisor.git","clone_url":"https://github.com/ZideChen0/acrn-hypervisor.git","svn_url":"https://github.com/ZideChen0/acrn-hypervisor","homepage":"","size":11657,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectacrn:master","ref":"master","sha":"c808972926a4430bcd2606f17633d99165335c4b","user":{"login":"projectacrn","id":36865262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODY1MjYy","avatar_url":"https://avatars1.githubusercontent.com/u/36865262?v=4","gravatar_id":"","url":"https://api.github.com/users/projectacrn","html_url":"https://github.com/projectacrn","followers_url":"https://api.github.com/users/projectacrn/followers","following_url":"https://api.github.com/users/projectacrn/following{/other_user}","gists_url":"https://api.github.com/users/projectacrn/gists{/gist_id}","starred_url":"https://api.github.com/users/projectacrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectacrn/subscriptions","organizations_url":"https://api.github.com/users/projectacrn/orgs","repos_url":"https://api.github.com/users/projectacrn/repos","events_url":"https://api.github.com/users/projectacrn/events{/privacy}","received_events_url":"https://api.github.com/users/projectacrn/received_events","type":"Organization","site_admin":false},"repo":{"id":123983554,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5ODM1NTQ=","name":"acrn-hypervisor","full_name":"projectacrn/acrn-hypervisor","owner":{"login":"projectacrn","id":36865262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODY1MjYy","avatar_url":"https://avatars1.githubusercontent.com/u/36865262?v=4","gravatar_id":"","url":"https://api.github.com/users/projectacrn","html_url":"https://github.com/projectacrn","followers_url":"https://api.github.com/users/projectacrn/followers","following_url":"https://api.github.com/users/projectacrn/following{/other_user}","gists_url":"https://api.github.com/users/projectacrn/gists{/gist_id}","starred_url":"https://api.github.com/users/projectacrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectacrn/subscriptions","organizations_url":"https://api.github.com/users/projectacrn/orgs","repos_url":"https://api.github.com/users/projectacrn/repos","events_url":"https://api.github.com/users/projectacrn/events{/privacy}","received_events_url":"https://api.github.com/users/projectacrn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectacrn/acrn-hypervisor","description":"Project ACRN hypervisor ","fork":false,"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor","forks_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/forks","keys_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/teams","hooks_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/hooks","issue_events_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/events{/number}","events_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/events","assignees_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/assignees{/user}","branches_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/branches{/branch}","tags_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/tags","blobs_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/statuses/{sha}","languages_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/languages","stargazers_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/stargazers","contributors_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/contributors","subscribers_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/subscribers","subscription_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/subscription","commits_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/contents/{+path}","compare_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/merges","archive_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/downloads","issues_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues{/number}","pulls_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls{/number}","milestones_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/milestones{/number}","notifications_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/labels{/name}","releases_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/releases{/id}","deployments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/deployments","created_at":"2018-03-05T21:52:25Z","updated_at":"2018-07-13T08:20:22Z","pushed_at":"2018-07-13T19:14:42Z","git_url":"git://github.com/projectacrn/acrn-hypervisor.git","ssh_url":"git@github.com:projectacrn/acrn-hypervisor.git","clone_url":"https://github.com/projectacrn/acrn-hypervisor.git","svn_url":"https://github.com/projectacrn/acrn-hypervisor","homepage":"","size":11858,"stargazers_count":202,"watchers_count":202,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":137,"open_issues":40,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/687"},"html":{"href":"https://github.com/projectacrn/acrn-hypervisor/pull/687"},"issue":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/687"},"comments":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/687/comments"},"review_comments":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/687/comments"},"review_comment":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/687/commits"},"statuses":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/statuses/1186f253f5f3ecb84a9197bc7da54fe8f0151291"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ZideChen0"}}