{"action":"created","issue":{"url":"https://api.github.com/repos/xjamundx/eslint-plugin-promise/issues/85","repository_url":"https://api.github.com/repos/xjamundx/eslint-plugin-promise","labels_url":"https://api.github.com/repos/xjamundx/eslint-plugin-promise/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/xjamundx/eslint-plugin-promise/issues/85/comments","events_url":"https://api.github.com/repos/xjamundx/eslint-plugin-promise/issues/85/events","html_url":"https://github.com/xjamundx/eslint-plugin-promise/pull/85","id":294846440,"number":85,"title":"feat(rule): add valid-params rule","user":{"login":"macklinu","id":2344137,"avatar_url":"https://avatars1.githubusercontent.com/u/2344137?v=4","gravatar_id":"","url":"https://api.github.com/users/macklinu","html_url":"https://github.com/macklinu","followers_url":"https://api.github.com/users/macklinu/followers","following_url":"https://api.github.com/users/macklinu/following{/other_user}","gists_url":"https://api.github.com/users/macklinu/gists{/gist_id}","starred_url":"https://api.github.com/users/macklinu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macklinu/subscriptions","organizations_url":"https://api.github.com/users/macklinu/orgs","repos_url":"https://api.github.com/users/macklinu/repos","events_url":"https://api.github.com/users/macklinu/events{/privacy}","received_events_url":"https://api.github.com/users/macklinu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-06T17:29:22Z","updated_at":"2018-02-07T17:50:05Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/xjamundx/eslint-plugin-promise/pulls/85","html_url":"https://github.com/xjamundx/eslint-plugin-promise/pull/85","diff_url":"https://github.com/xjamundx/eslint-plugin-promise/pull/85.diff","patch_url":"https://github.com/xjamundx/eslint-plugin-promise/pull/85.patch"},"body":"Resolves #47 \r\n\r\nAs of now this rule simply checks how many arguments were supplied to the various `Promise` functions. If the length of arguments is invalid, it will report that as a lint violation. See the tests for examples.\r\n\r\nThere are a couple of other issues (#3, #60) that I could see being rolled into this `valid-params` rule. What are your thoughts on that? I think those could be separate PRs, but some feedback on those ideas being included in this rule / any rule would be great. 👍 "},"comment":{"url":"https://api.github.com/repos/xjamundx/eslint-plugin-promise/issues/comments/363852306","html_url":"https://github.com/xjamundx/eslint-plugin-promise/pull/85#issuecomment-363852306","issue_url":"https://api.github.com/repos/xjamundx/eslint-plugin-promise/issues/85","id":363852306,"user":{"login":"xjamundx","id":246143,"avatar_url":"https://avatars3.githubusercontent.com/u/246143?v=4","gravatar_id":"","url":"https://api.github.com/users/xjamundx","html_url":"https://github.com/xjamundx","followers_url":"https://api.github.com/users/xjamundx/followers","following_url":"https://api.github.com/users/xjamundx/following{/other_user}","gists_url":"https://api.github.com/users/xjamundx/gists{/gist_id}","starred_url":"https://api.github.com/users/xjamundx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjamundx/subscriptions","organizations_url":"https://api.github.com/users/xjamundx/orgs","repos_url":"https://api.github.com/users/xjamundx/repos","events_url":"https://api.github.com/users/xjamundx/events{/privacy}","received_events_url":"https://api.github.com/users/xjamundx/received_events","type":"User","site_admin":false},"created_at":"2018-02-07T17:50:05Z","updated_at":"2018-02-07T17:50:05Z","author_association":"OWNER","body":"Sure @macklinu I'll grant you NPM access after a bit. Try to go through the existing issues. You can do whatever you want. And please add your name to the README as a contribute or maintainer. I only have about an hour a month to spend on stuff like this at the moment and have mostly moved on to using typed JS to solve my static analysis needs for JS"}}
{"actor":{"display_login":"xjamundx"}}