{"action":"created","comment":{"url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/comments/231848926","pull_request_review_id":172907666,"id":231848926,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTg0ODkyNg==","diff_hunk":"@@ -0,0 +1,19 @@\n+// Images and lightbox\n+// ----------------------------------------------------------------------------\n+\n+.easyadmin-thumbnail img:hover {\n+  cursor: zoom-in;\n+}\n+.easyadmin-lightbox {\n+  display: none;\n+}\n+.easyadmin-lightbox img {\n+  max-width: 100%;\n+}\n+\n+.featherlight .easyadmin-lightbox {\n+  display: block;\n+}\n+.featherlight .easyadmin-lightbox:hover {","path":"assets/css/easyadmin-theme/images.scss","position":17,"original_position":17,"commit_id":"47323ecfadff855f57aa9349677abd3fb3a84871","original_commit_id":"47323ecfadff855f57aa9349677abd3fb3a84871","user":{"login":"sanis","id":3956177,"node_id":"MDQ6VXNlcjM5NTYxNzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3956177?v=4","gravatar_id":"","url":"https://api.github.com/users/sanis","html_url":"https://github.com/sanis","followers_url":"https://api.github.com/users/sanis/followers","following_url":"https://api.github.com/users/sanis/following{/other_user}","gists_url":"https://api.github.com/users/sanis/gists{/gist_id}","starred_url":"https://api.github.com/users/sanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanis/subscriptions","organizations_url":"https://api.github.com/users/sanis/orgs","repos_url":"https://api.github.com/users/sanis/repos","events_url":"https://api.github.com/users/sanis/events{/privacy}","received_events_url":"https://api.github.com/users/sanis/received_events","type":"User","site_admin":false},"body":"Wouldn't it be much fun to use Sass and nest inside?\r\n\r\n```\r\n.easyadmin-thumbnail img:hover {\r\n  cursor: zoom-in;\r\n}\r\n\r\n.easyadmin-lightbox {\r\n  display: none;\r\n  \r\n  img {\r\n    max-width: 100%;\r\n  }\r\n}\r\n\r\n.easyadmin-lightbox \r\n .featherlight {\r\n   .easyadmin-lightbox {\r\n     display: block;\r\n     \r\n     &:hover {\r\n       cursor: zoom-out;\r\n     }\r\n   }\r\n }\r\n```","created_at":"2018-11-08T11:13:19Z","updated_at":"2018-11-08T11:13:20Z","html_url":"https://github.com/EasyCorp/EasyAdminBundle/pull/2415#discussion_r231848926","pull_request_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2415","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/comments/231848926"},"html":{"href":"https://github.com/EasyCorp/EasyAdminBundle/pull/2415#discussion_r231848926"},"pull_request":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2415"}}},"pull_request":{"url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2415","id":229323978,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MzIzOTc4","html_url":"https://github.com/EasyCorp/EasyAdminBundle/pull/2415","diff_url":"https://github.com/EasyCorp/EasyAdminBundle/pull/2415.diff","patch_url":"https://github.com/EasyCorp/EasyAdminBundle/pull/2415.patch","issue_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/2415","number":2415,"state":"open","locked":false,"title":"Added a new theme for EasyAdmin 2.x","user":{"login":"javiereguiluz","id":73419,"node_id":"MDQ6VXNlcjczNDE5","avatar_url":"https://avatars3.githubusercontent.com/u/73419?v=4","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"body":"**This is the last big change before Symfony 2.0 release**. It's a complete redesign that:\r\n\r\n* It's based on Stripe's backend\r\n* It uses Webpack via Webpack Encore\r\n* It can be customized using CSS variables\r\n\r\n## Screenshots\r\n\r\n![product-listing](https://user-images.githubusercontent.com/73419/48194288-e55e9200-e34c-11e8-86ff-1b4ae4ab395e.png)\r\n\r\n![simple-form](https://user-images.githubusercontent.com/73419/48194299-e7c0ec00-e34c-11e8-8bc0-dfa3d369f76f.png)\r\n\r\n![complex-form](https://user-images.githubusercontent.com/73419/48194304-eb547300-e34c-11e8-8237-1ffddce85e21.png)\r\n\r\n## In detail\r\n\r\n### Based on Stripe's backend\r\n\r\nIn my opinion, Stripe has the best designed backend (https://dashboard.stripe.com). I used it as a strong inspiration for the new design. However, even if both look very similar, I changed everything: typography, colors (they are similar, but not exactly the same), the overall layout, the disposition of some elements, the behavior of the page (we don't have a sticky sidebar), etc.\r\n\r\nAlso, this new design is **not responsive** on purpose. This may be controversial for some of you ... but let's face it: this tool is used to create backends and real backends are very complex. It's not worth it to adapt them completely for the tiny smartphone screens. You can still use a backend on your smartphone; it's just that the design doesn't change for your device.\r\n\r\n### Integrated with Webpack Encore\r\n\r\nFirst, you don't have to do anything, install anything or run any command to have the new design. The bundle includes the compiled assets, so nothing changes for end-users.\r\n\r\nThe main change is that those advanced users that want to customize a lot of things, now can integrate the sources of our assets into their apps. Also, this allows us to manage front-end dependencies much more easily.\r\n\r\n### Customized using CSS variables\r\n\r\nIn the past we used a rudimentary design customization process: a chunk of CSS was injected in the header of all pages. That CSS was generated using a Twig template and some config variables. All that is gone for good.\r\n\r\nThe new design uses a ton of CSS variables, so you can create a simple CSS file, override a few CSS variables and have a completely customized backend.\r\n\r\n### Simplified design\r\n\r\nThe new design keeps all Twig blocks and most CSS id/class, so it will only break if you did massive customizations in your backends. We still use the AdminLTE template, but we now include fewer parts of it. The resulting CSS and JS files are much smaller (around 50% smaller) and the backend has better performance.\r\n","created_at":"2018-11-08T10:54:29Z","updated_at":"2018-11-08T11:13:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2415/commits","review_comments_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2415/comments","review_comment_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/2415/comments","statuses_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/statuses/47323ecfadff855f57aa9349677abd3fb3a84871","head":{"label":"EasyCorp:new_theme","ref":"new_theme","sha":"47323ecfadff855f57aa9349677abd3fb3a84871","user":{"login":"EasyCorp","id":14944619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTQ0NjE5","avatar_url":"https://avatars3.githubusercontent.com/u/14944619?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyCorp","html_url":"https://github.com/EasyCorp","followers_url":"https://api.github.com/users/EasyCorp/followers","following_url":"https://api.github.com/users/EasyCorp/following{/other_user}","gists_url":"https://api.github.com/users/EasyCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyCorp/subscriptions","organizations_url":"https://api.github.com/users/EasyCorp/orgs","repos_url":"https://api.github.com/users/EasyCorp/repos","events_url":"https://api.github.com/users/EasyCorp/events{/privacy}","received_events_url":"https://api.github.com/users/EasyCorp/received_events","type":"Organization","site_admin":false},"repo":{"id":29126334,"node_id":"MDEwOlJlcG9zaXRvcnkyOTEyNjMzNA==","name":"EasyAdminBundle","full_name":"EasyCorp/EasyAdminBundle","private":false,"owner":{"login":"EasyCorp","id":14944619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTQ0NjE5","avatar_url":"https://avatars3.githubusercontent.com/u/14944619?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyCorp","html_url":"https://github.com/EasyCorp","followers_url":"https://api.github.com/users/EasyCorp/followers","following_url":"https://api.github.com/users/EasyCorp/following{/other_user}","gists_url":"https://api.github.com/users/EasyCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyCorp/subscriptions","organizations_url":"https://api.github.com/users/EasyCorp/orgs","repos_url":"https://api.github.com/users/EasyCorp/repos","events_url":"https://api.github.com/users/EasyCorp/events{/privacy}","received_events_url":"https://api.github.com/users/EasyCorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EasyCorp/EasyAdminBundle","description":"The new (and simple) admin generator for Symfony applications.","fork":false,"url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle","forks_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/forks","keys_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/teams","hooks_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/events","assignees_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/tags","blobs_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/languages","stargazers_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/subscription","commits_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/merges","archive_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/downloads","issues_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/deployments","created_at":"2015-01-12T08:43:02Z","updated_at":"2018-11-08T09:33:07Z","pushed_at":"2018-11-08T10:54:29Z","git_url":"git://github.com/EasyCorp/EasyAdminBundle.git","ssh_url":"git@github.com:EasyCorp/EasyAdminBundle.git","clone_url":"https://github.com/EasyCorp/EasyAdminBundle.git","svn_url":"https://github.com/EasyCorp/EasyAdminBundle","homepage":"","size":11972,"stargazers_count":2265,"watchers_count":2265,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":473,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":473,"open_issues":32,"watchers":2265,"default_branch":"master"}},"base":{"label":"EasyCorp:master","ref":"master","sha":"28e1540b605ecac56296fc9653bd465773c1725e","user":{"login":"EasyCorp","id":14944619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTQ0NjE5","avatar_url":"https://avatars3.githubusercontent.com/u/14944619?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyCorp","html_url":"https://github.com/EasyCorp","followers_url":"https://api.github.com/users/EasyCorp/followers","following_url":"https://api.github.com/users/EasyCorp/following{/other_user}","gists_url":"https://api.github.com/users/EasyCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyCorp/subscriptions","organizations_url":"https://api.github.com/users/EasyCorp/orgs","repos_url":"https://api.github.com/users/EasyCorp/repos","events_url":"https://api.github.com/users/EasyCorp/events{/privacy}","received_events_url":"https://api.github.com/users/EasyCorp/received_events","type":"Organization","site_admin":false},"repo":{"id":29126334,"node_id":"MDEwOlJlcG9zaXRvcnkyOTEyNjMzNA==","name":"EasyAdminBundle","full_name":"EasyCorp/EasyAdminBundle","private":false,"owner":{"login":"EasyCorp","id":14944619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTQ0NjE5","avatar_url":"https://avatars3.githubusercontent.com/u/14944619?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyCorp","html_url":"https://github.com/EasyCorp","followers_url":"https://api.github.com/users/EasyCorp/followers","following_url":"https://api.github.com/users/EasyCorp/following{/other_user}","gists_url":"https://api.github.com/users/EasyCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyCorp/subscriptions","organizations_url":"https://api.github.com/users/EasyCorp/orgs","repos_url":"https://api.github.com/users/EasyCorp/repos","events_url":"https://api.github.com/users/EasyCorp/events{/privacy}","received_events_url":"https://api.github.com/users/EasyCorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EasyCorp/EasyAdminBundle","description":"The new (and simple) admin generator for Symfony applications.","fork":false,"url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle","forks_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/forks","keys_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/teams","hooks_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/events","assignees_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/tags","blobs_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/languages","stargazers_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/subscription","commits_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/merges","archive_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/downloads","issues_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/deployments","created_at":"2015-01-12T08:43:02Z","updated_at":"2018-11-08T09:33:07Z","pushed_at":"2018-11-08T10:54:29Z","git_url":"git://github.com/EasyCorp/EasyAdminBundle.git","ssh_url":"git@github.com:EasyCorp/EasyAdminBundle.git","clone_url":"https://github.com/EasyCorp/EasyAdminBundle.git","svn_url":"https://github.com/EasyCorp/EasyAdminBundle","homepage":"","size":11972,"stargazers_count":2265,"watchers_count":2265,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":473,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":473,"open_issues":32,"watchers":2265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2415"},"html":{"href":"https://github.com/EasyCorp/EasyAdminBundle/pull/2415"},"issue":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/2415"},"comments":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/2415/comments"},"review_comments":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2415/comments"},"review_comment":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2415/commits"},"statuses":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/statuses/47323ecfadff855f57aa9349677abd3fb3a84871"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sanis"}}