{"action":"closed","issue":{"url":"https://api.github.com/repos/angular/angular/issues/25389","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/25389/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/25389/comments","events_url":"https://api.github.com/repos/angular/angular/issues/25389/events","html_url":"https://github.com/angular/angular/issues/25389","id":348770325,"node_id":"MDU6SXNzdWUzNDg3NzAzMjU=","number":25389,"title":"[IVY] TestBed missing features","user":{"login":"vicb","id":248818,"node_id":"MDQ6VXNlcjI0ODgxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/248818?v=4","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"labels":[{"id":799860804,"node_id":"MDU6TGFiZWw3OTk4NjA4MDQ=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20ivy","name":"comp: ivy","color":"c5def5","default":false},{"id":130606845,"node_id":"MDU6TGFiZWwxMzA2MDY4NDU=","url":"https://api.github.com/repos/angular/angular/labels/type:%20feature","name":"type: feature","color":"EEEEEE","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/88","html_url":"https://github.com/angular/angular/milestone/88","labels_url":"https://api.github.com/repos/angular/angular/milestones/88/labels","id":3374724,"node_id":"MDk6TWlsZXN0b25lMzM3NDcyNA==","number":88,"title":"Ivy (not in use)","description":"This milestone is no longer in use as we are tracking Ivy related work elsewhere.","creator":{"login":"jasonaden","id":516168,"node_id":"MDQ6VXNlcjUxNjE2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/516168?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonaden","html_url":"https://github.com/jasonaden","followers_url":"https://api.github.com/users/jasonaden/followers","following_url":"https://api.github.com/users/jasonaden/following{/other_user}","gists_url":"https://api.github.com/users/jasonaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonaden/subscriptions","organizations_url":"https://api.github.com/users/jasonaden/orgs","repos_url":"https://api.github.com/users/jasonaden/repos","events_url":"https://api.github.com/users/jasonaden/events{/privacy}","received_events_url":"https://api.github.com/users/jasonaden/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":30,"state":"open","created_at":"2018-05-24T23:01:11Z","updated_at":"2018-12-21T13:44:11Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-08-08T15:12:03Z","updated_at":"2018-12-21T13:44:11Z","closed_at":"2018-12-21T13:44:10Z","author_association":"CONTRIBUTOR","body":"- Some things are still to be implemented for the `Render3DebugContext`:\r\n  - [x] destroying the Debug Nodes when a view is destroyed (`destroyLView`)\r\n  - [x] merge `module_testbed.ts` and `module.ts` - they have a lot of common code\r\n  - [x] do not duplicate the `MetadataOverrider` but use the version in the browser dynamic platform\r\n  - [ ] see `TODO`s in the code\r\n\r\nAs of today `TestBed` tests are not executed in IVY mode - because the TestBed does not support IVY prior to this PR. However we can not enable all TestBed tests for IVY because a lot of them are failing because of:\r\n- features that are yet to be implemented in IVY,\r\n- (unexpected) breaking changes in IVY\r\n\r\nBecause the number of failing test when compiled against IVY is huge we need to implement a strategy that would catch regression in the number of passing tests but would not error on all failing tests. That way we can make sure more tests pass over time but we do not fail for all remaining failing tests.\r\n\r\nReference ie `<element #ref>` or `<ng-template #ref>` are not yet supported - note that template references are not yet supported in IVY.\r\n\r\n### How to test (ie `NgForSpec`)\r\n\r\n- Edit the NgFor spec and change the main `describe` to `fdescribe`\r\n- execute `bazel test //packages/common/test/...  --define=compile=jit`\r\n\r\n### Implement new features / fix existing ones in the `TestBedRender3`\r\n\r\nYou might need to update the `TestBed` own code to fix issues.  Chances are that you need to update the `DebugContext` to add missing functionalities / fix current version in `packages/core/src/render3/debug.ts`\r\n\r\nTo test your changes:\r\n\r\n- change the `describe` to `fdescribe` in `packages/core/test/test_bed_spec.ts`,\r\n- execute `bazel test //packages/core/test/...  --define=compile=jit`\r\n\r\n### related PRs\r\n\r\nhttps://github.com/angular/angular/pull/25369\r\n"}}
{"actor":{"display_login":"pkozlowski-opensource"}}