{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/228665508","pull_request_review_id":169000132,"id":228665508,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODY2NTUwOA==","diff_hunk":"@@ -507,6 +507,9 @@ class TimeBasedAdvancement extends AdvancementConfig {\n     /** @private @const {number} */\n     this.delayMs_ = delayMs;\n \n+    /** @private {?number} */\n+    this.remainingDelayMs_ = null;\n+\n     /** @private {?number} */\n     this.startTimeMs_ = null;","path":"extensions/amp-story/1.0/page-advancement.js","position":21,"original_position":21,"commit_id":"2b67890776dc75572a673a1a06fc9067cca93bfd","original_commit_id":"2b67890776dc75572a673a1a06fc9067cca93bfd","user":{"login":"newmuis","id":1651960,"node_id":"MDQ6VXNlcjE2NTE5NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1651960?v=4","gravatar_id":"","url":"https://api.github.com/users/newmuis","html_url":"https://github.com/newmuis","followers_url":"https://api.github.com/users/newmuis/followers","following_url":"https://api.github.com/users/newmuis/following{/other_user}","gists_url":"https://api.github.com/users/newmuis/gists{/gist_id}","starred_url":"https://api.github.com/users/newmuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newmuis/subscriptions","organizations_url":"https://api.github.com/users/newmuis/orgs","repos_url":"https://api.github.com/users/newmuis/repos","events_url":"https://api.github.com/users/newmuis/events{/privacy}","received_events_url":"https://api.github.com/users/newmuis/received_events","type":"User","site_admin":false},"body":"Sorry, I'm not actually sure I even understand why this is important (although I am pretty sure I wrote this).  Isn't `delayMs` sufficient?","created_at":"2018-10-26T21:05:42Z","updated_at":"2018-10-26T21:06:11Z","html_url":"https://github.com/ampproject/amphtml/pull/19002#discussion_r228665508","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/19002","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/228665508"},"html":{"href":"https://github.com/ampproject/amphtml/pull/19002#discussion_r228665508"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/19002"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/19002","id":226225048,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjI1MDQ4","html_url":"https://github.com/ampproject/amphtml/pull/19002","diff_url":"https://github.com/ampproject/amphtml/pull/19002.diff","patch_url":"https://github.com/ampproject/amphtml/pull/19002.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/19002","number":19002,"state":"open","locked":false,"title":"Allow resuming a TimeAdvancement after being paused.","user":{"login":"gmajoulet","id":1492044,"node_id":"MDQ6VXNlcjE0OTIwNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1492044?v=4","gravatar_id":"","url":"https://api.github.com/users/gmajoulet","html_url":"https://github.com/gmajoulet","followers_url":"https://api.github.com/users/gmajoulet/followers","following_url":"https://api.github.com/users/gmajoulet/following{/other_user}","gists_url":"https://api.github.com/users/gmajoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/gmajoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmajoulet/subscriptions","organizations_url":"https://api.github.com/users/gmajoulet/orgs","repos_url":"https://api.github.com/users/gmajoulet/repos","events_url":"https://api.github.com/users/gmajoulet/events{/privacy}","received_events_url":"https://api.github.com/users/gmajoulet/received_events","type":"User","site_admin":false},"body":"Allow resuming a TimeAdvancement after being paused.\r\n\r\nFixes #18990 ","created_at":"2018-10-26T21:01:09Z","updated_at":"2018-10-26T21:06:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e5439a843e11b5bc47c7c551bd27121f93b3b3e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Enriqe","id":5449100,"node_id":"MDQ6VXNlcjU0NDkxMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5449100?v=4","gravatar_id":"","url":"https://api.github.com/users/Enriqe","html_url":"https://github.com/Enriqe","followers_url":"https://api.github.com/users/Enriqe/followers","following_url":"https://api.github.com/users/Enriqe/following{/other_user}","gists_url":"https://api.github.com/users/Enriqe/gists{/gist_id}","starred_url":"https://api.github.com/users/Enriqe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Enriqe/subscriptions","organizations_url":"https://api.github.com/users/Enriqe/orgs","repos_url":"https://api.github.com/users/Enriqe/repos","events_url":"https://api.github.com/users/Enriqe/events{/privacy}","received_events_url":"https://api.github.com/users/Enriqe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/19002/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/19002/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/19002/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/2b67890776dc75572a673a1a06fc9067cca93bfd","head":{"label":"gmajoulet:pause_time_advancement","ref":"pause_time_advancement","sha":"2b67890776dc75572a673a1a06fc9067cca93bfd","user":{"login":"gmajoulet","id":1492044,"node_id":"MDQ6VXNlcjE0OTIwNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1492044?v=4","gravatar_id":"","url":"https://api.github.com/users/gmajoulet","html_url":"https://github.com/gmajoulet","followers_url":"https://api.github.com/users/gmajoulet/followers","following_url":"https://api.github.com/users/gmajoulet/following{/other_user}","gists_url":"https://api.github.com/users/gmajoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/gmajoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmajoulet/subscriptions","organizations_url":"https://api.github.com/users/gmajoulet/orgs","repos_url":"https://api.github.com/users/gmajoulet/repos","events_url":"https://api.github.com/users/gmajoulet/events{/privacy}","received_events_url":"https://api.github.com/users/gmajoulet/received_events","type":"User","site_admin":false},"repo":{"id":116157484,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNTc0ODQ=","name":"amphtml","full_name":"gmajoulet/amphtml","private":false,"owner":{"login":"gmajoulet","id":1492044,"node_id":"MDQ6VXNlcjE0OTIwNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1492044?v=4","gravatar_id":"","url":"https://api.github.com/users/gmajoulet","html_url":"https://github.com/gmajoulet","followers_url":"https://api.github.com/users/gmajoulet/followers","following_url":"https://api.github.com/users/gmajoulet/following{/other_user}","gists_url":"https://api.github.com/users/gmajoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/gmajoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmajoulet/subscriptions","organizations_url":"https://api.github.com/users/gmajoulet/orgs","repos_url":"https://api.github.com/users/gmajoulet/repos","events_url":"https://api.github.com/users/gmajoulet/events{/privacy}","received_events_url":"https://api.github.com/users/gmajoulet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gmajoulet/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/gmajoulet/amphtml","forks_url":"https://api.github.com/repos/gmajoulet/amphtml/forks","keys_url":"https://api.github.com/repos/gmajoulet/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmajoulet/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmajoulet/amphtml/teams","hooks_url":"https://api.github.com/repos/gmajoulet/amphtml/hooks","issue_events_url":"https://api.github.com/repos/gmajoulet/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/gmajoulet/amphtml/events","assignees_url":"https://api.github.com/repos/gmajoulet/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/gmajoulet/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/gmajoulet/amphtml/tags","blobs_url":"https://api.github.com/repos/gmajoulet/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmajoulet/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmajoulet/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmajoulet/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmajoulet/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/gmajoulet/amphtml/languages","stargazers_url":"https://api.github.com/repos/gmajoulet/amphtml/stargazers","contributors_url":"https://api.github.com/repos/gmajoulet/amphtml/contributors","subscribers_url":"https://api.github.com/repos/gmajoulet/amphtml/subscribers","subscription_url":"https://api.github.com/repos/gmajoulet/amphtml/subscription","commits_url":"https://api.github.com/repos/gmajoulet/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmajoulet/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmajoulet/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmajoulet/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmajoulet/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/gmajoulet/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmajoulet/amphtml/merges","archive_url":"https://api.github.com/repos/gmajoulet/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmajoulet/amphtml/downloads","issues_url":"https://api.github.com/repos/gmajoulet/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/gmajoulet/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/gmajoulet/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/gmajoulet/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmajoulet/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/gmajoulet/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/gmajoulet/amphtml/deployments","created_at":"2018-01-03T16:19:49Z","updated_at":"2018-10-24T15:24:51Z","pushed_at":"2018-10-26T20:59:29Z","git_url":"git://github.com/gmajoulet/amphtml.git","ssh_url":"git@github.com:gmajoulet/amphtml.git","clone_url":"https://github.com/gmajoulet/amphtml.git","svn_url":"https://github.com/gmajoulet/amphtml","homepage":"https://www.ampproject.org","size":533001,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"e2e85170b1aaa7cf6327b64cf25eea7d9dc11378","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","private":false,"owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-10-26T19:46:04Z","pushed_at":"2018-10-26T21:03:44Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":532460,"stargazers_count":12109,"watchers_count":12109,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2661,"mirror_url":null,"archived":false,"open_issues_count":1520,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2661,"open_issues":1520,"watchers":12109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/19002"},"html":{"href":"https://github.com/ampproject/amphtml/pull/19002"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/19002"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/19002/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/19002/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/19002/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/2b67890776dc75572a673a1a06fc9067cca93bfd"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"newmuis"}}