{"action":"created","comment":{"url":"https://api.github.com/repos/open-source-economics/taxdata/pulls/comments/201426717","pull_request_review_id":135927452,"id":201426717,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQyNjcxNw==","diff_hunk":"@@ -78,8 +83,8 @@ def increment_year(self, tol=0.01):\n             setattr(self, '{}_benefits'.format(benefit), benefits)\n \n     @staticmethod\n-    def _extrapolate(WT, I, benefits, prob, target,\n-                     benefit_name, benefit_year, tol=0.01, J=15):\n+    def _extrapolate(WT, III, benefits, prob, target,\n+                     benefit_name, benefit_year, tol, JJJ=15):","path":"cps_stage4/extrapolation.py","position":48,"original_position":48,"commit_id":"406e0cbcc82eef4cae7c83dac6f839b5f84f4194","original_commit_id":"406e0cbcc82eef4cae7c83dac6f839b5f84f4194","user":{"login":"hdoupe","id":9206065,"node_id":"MDQ6VXNlcjkyMDYwNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9206065?v=4","gravatar_id":"","url":"https://api.github.com/users/hdoupe","html_url":"https://github.com/hdoupe","followers_url":"https://api.github.com/users/hdoupe/followers","following_url":"https://api.github.com/users/hdoupe/following{/other_user}","gists_url":"https://api.github.com/users/hdoupe/gists{/gist_id}","starred_url":"https://api.github.com/users/hdoupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdoupe/subscriptions","organizations_url":"https://api.github.com/users/hdoupe/orgs","repos_url":"https://api.github.com/users/hdoupe/repos","events_url":"https://api.github.com/users/hdoupe/events{/privacy}","received_events_url":"https://api.github.com/users/hdoupe/received_events","type":"User","site_admin":false},"body":"My understanding is that `J=15` means that there are at a maximum 15 members in each unit. That means that the maximum width of the participation indicator matrix is 15. ","created_at":"2018-07-10T17:21:00Z","updated_at":"2018-07-10T17:21:00Z","html_url":"https://github.com/open-source-economics/taxdata/pull/242#discussion_r201426717","pull_request_url":"https://api.github.com/repos/open-source-economics/taxdata/pulls/242","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/taxdata/pulls/comments/201426717"},"html":{"href":"https://github.com/open-source-economics/taxdata/pull/242#discussion_r201426717"},"pull_request":{"href":"https://api.github.com/repos/open-source-economics/taxdata/pulls/242"}},"in_reply_to_id":200496347},"pull_request":{"url":"https://api.github.com/repos/open-source-economics/taxdata/pulls/242","id":199577575,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTc3NTc1","html_url":"https://github.com/open-source-economics/taxdata/pull/242","diff_url":"https://github.com/open-source-economics/taxdata/pull/242.diff","patch_url":"https://github.com/open-source-economics/taxdata/pull/242.patch","issue_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/242","number":242,"state":"open","locked":false,"title":"Revise cps_stage4/extrapolation.py script","user":{"login":"martinholmer","id":12170745,"node_id":"MDQ6VXNlcjEyMTcwNzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"body":"This pull request makes changes that allow the `extrapolation.py` script to run to completion and to pass the taxdata repo's code-style test.  The first commit in this PR increases the relative tolerance (for an acceptable extrapolation) from 0.01 to 0.05, which allows the script to run to completion.  The second commit eliminates several pycodestyle (nee PEP8) [warnings](https://github.com/open-source-economics/taxdata/issues/232#issuecomment-399711170) such as line too long, too many spaces, and ambiguous variable name.  The changes in the second commit in this PR produce exactly the same `cps_benefits.csv.gz` file as the first commit produced, confirming that the changes in the second commit are purely cosmetic.\r\n\r\nHowever, the contents of the new `cps_benefits.csv.gz` file produced with this code are substantially different from the contents of the `cps_benefits.csv.gz` file on the taxdata master branch (which is currently being used in Tax-Calculator).  The next step is to determine if this new `cps_benefits.csv.gz` file has sensible content.  We plan to do that by using it (and other more current taxdata made files) in the kind of \"test\" described in taxdata issue #241.\r\n\r\n@hdoupe and @andersonfrailey, I'd appreciate it if you could review these changes.\r\n\r\nAlso, @hdoupe, I need your direction on how to handle the pandas warning described at the bottom of [this 232 comment](https://github.com/open-source-economics/taxdata/issues/232#issuecomment-399711170).","created_at":"2018-07-05T20:22:07Z","updated_at":"2018-07-10T17:21:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cca31c33d8f3c876580ece8d55db6e3fbfefa92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":839272183,"node_id":"MDU6TGFiZWw4MzkyNzIxODM=","url":"https://api.github.com/repos/open-source-economics/taxdata/labels/ready","name":"ready","color":"5ce843","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/open-source-economics/taxdata/pulls/242/commits","review_comments_url":"https://api.github.com/repos/open-source-economics/taxdata/pulls/242/comments","review_comment_url":"https://api.github.com/repos/open-source-economics/taxdata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/242/comments","statuses_url":"https://api.github.com/repos/open-source-economics/taxdata/statuses/406e0cbcc82eef4cae7c83dac6f839b5f84f4194","head":{"label":"martinholmer:revise-extrapolation","ref":"revise-extrapolation","sha":"406e0cbcc82eef4cae7c83dac6f839b5f84f4194","user":{"login":"martinholmer","id":12170745,"node_id":"MDQ6VXNlcjEyMTcwNzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"repo":{"id":48387309,"node_id":"MDEwOlJlcG9zaXRvcnk0ODM4NzMwOQ==","name":"taxdata","full_name":"martinholmer/taxdata","owner":{"login":"martinholmer","id":12170745,"node_id":"MDQ6VXNlcjEyMTcwNzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinholmer/taxdata","description":null,"fork":true,"url":"https://api.github.com/repos/martinholmer/taxdata","forks_url":"https://api.github.com/repos/martinholmer/taxdata/forks","keys_url":"https://api.github.com/repos/martinholmer/taxdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinholmer/taxdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinholmer/taxdata/teams","hooks_url":"https://api.github.com/repos/martinholmer/taxdata/hooks","issue_events_url":"https://api.github.com/repos/martinholmer/taxdata/issues/events{/number}","events_url":"https://api.github.com/repos/martinholmer/taxdata/events","assignees_url":"https://api.github.com/repos/martinholmer/taxdata/assignees{/user}","branches_url":"https://api.github.com/repos/martinholmer/taxdata/branches{/branch}","tags_url":"https://api.github.com/repos/martinholmer/taxdata/tags","blobs_url":"https://api.github.com/repos/martinholmer/taxdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinholmer/taxdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinholmer/taxdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinholmer/taxdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinholmer/taxdata/statuses/{sha}","languages_url":"https://api.github.com/repos/martinholmer/taxdata/languages","stargazers_url":"https://api.github.com/repos/martinholmer/taxdata/stargazers","contributors_url":"https://api.github.com/repos/martinholmer/taxdata/contributors","subscribers_url":"https://api.github.com/repos/martinholmer/taxdata/subscribers","subscription_url":"https://api.github.com/repos/martinholmer/taxdata/subscription","commits_url":"https://api.github.com/repos/martinholmer/taxdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinholmer/taxdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinholmer/taxdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinholmer/taxdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinholmer/taxdata/contents/{+path}","compare_url":"https://api.github.com/repos/martinholmer/taxdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinholmer/taxdata/merges","archive_url":"https://api.github.com/repos/martinholmer/taxdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinholmer/taxdata/downloads","issues_url":"https://api.github.com/repos/martinholmer/taxdata/issues{/number}","pulls_url":"https://api.github.com/repos/martinholmer/taxdata/pulls{/number}","milestones_url":"https://api.github.com/repos/martinholmer/taxdata/milestones{/number}","notifications_url":"https://api.github.com/repos/martinholmer/taxdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinholmer/taxdata/labels{/name}","releases_url":"https://api.github.com/repos/martinholmer/taxdata/releases{/id}","deployments_url":"https://api.github.com/repos/martinholmer/taxdata/deployments","created_at":"2015-12-21T18:25:11Z","updated_at":"2018-07-05T14:14:10Z","pushed_at":"2018-07-05T19:58:44Z","git_url":"git://github.com/martinholmer/taxdata.git","ssh_url":"git@github.com:martinholmer/taxdata.git","clone_url":"https://github.com/martinholmer/taxdata.git","svn_url":"https://github.com/martinholmer/taxdata","homepage":null,"size":2335454,"stargazers_count":0,"watchers_count":0,"language":"SAS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-source-economics:master","ref":"master","sha":"acd74171c2b99167ac471da19d5d454227f2191e","user":{"login":"open-source-economics","id":15148101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTQ4MTAx","avatar_url":"https://avatars2.githubusercontent.com/u/15148101?v=4","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"repo":{"id":38842143,"node_id":"MDEwOlJlcG9zaXRvcnkzODg0MjE0Mw==","name":"taxdata","full_name":"open-source-economics/taxdata","owner":{"login":"open-source-economics","id":15148101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTQ4MTAx","avatar_url":"https://avatars2.githubusercontent.com/u/15148101?v=4","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-source-economics/taxdata","description":null,"fork":false,"url":"https://api.github.com/repos/open-source-economics/taxdata","forks_url":"https://api.github.com/repos/open-source-economics/taxdata/forks","keys_url":"https://api.github.com/repos/open-source-economics/taxdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-source-economics/taxdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-source-economics/taxdata/teams","hooks_url":"https://api.github.com/repos/open-source-economics/taxdata/hooks","issue_events_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/events{/number}","events_url":"https://api.github.com/repos/open-source-economics/taxdata/events","assignees_url":"https://api.github.com/repos/open-source-economics/taxdata/assignees{/user}","branches_url":"https://api.github.com/repos/open-source-economics/taxdata/branches{/branch}","tags_url":"https://api.github.com/repos/open-source-economics/taxdata/tags","blobs_url":"https://api.github.com/repos/open-source-economics/taxdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-source-economics/taxdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-source-economics/taxdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-source-economics/taxdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-source-economics/taxdata/statuses/{sha}","languages_url":"https://api.github.com/repos/open-source-economics/taxdata/languages","stargazers_url":"https://api.github.com/repos/open-source-economics/taxdata/stargazers","contributors_url":"https://api.github.com/repos/open-source-economics/taxdata/contributors","subscribers_url":"https://api.github.com/repos/open-source-economics/taxdata/subscribers","subscription_url":"https://api.github.com/repos/open-source-economics/taxdata/subscription","commits_url":"https://api.github.com/repos/open-source-economics/taxdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-source-economics/taxdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-source-economics/taxdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-source-economics/taxdata/contents/{+path}","compare_url":"https://api.github.com/repos/open-source-economics/taxdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-source-economics/taxdata/merges","archive_url":"https://api.github.com/repos/open-source-economics/taxdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-source-economics/taxdata/downloads","issues_url":"https://api.github.com/repos/open-source-economics/taxdata/issues{/number}","pulls_url":"https://api.github.com/repos/open-source-economics/taxdata/pulls{/number}","milestones_url":"https://api.github.com/repos/open-source-economics/taxdata/milestones{/number}","notifications_url":"https://api.github.com/repos/open-source-economics/taxdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-source-economics/taxdata/labels{/name}","releases_url":"https://api.github.com/repos/open-source-economics/taxdata/releases{/id}","deployments_url":"https://api.github.com/repos/open-source-economics/taxdata/deployments","created_at":"2015-07-09T19:56:06Z","updated_at":"2018-07-05T14:12:57Z","pushed_at":"2018-07-05T20:22:08Z","git_url":"git://github.com/open-source-economics/taxdata.git","ssh_url":"git@github.com:open-source-economics/taxdata.git","clone_url":"https://github.com/open-source-economics/taxdata.git","svn_url":"https://github.com/open-source-economics/taxdata","homepage":null,"size":2335380,"stargazers_count":7,"watchers_count":7,"language":"SAS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16,"open_issues":28,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/taxdata/pulls/242"},"html":{"href":"https://github.com/open-source-economics/taxdata/pull/242"},"issue":{"href":"https://api.github.com/repos/open-source-economics/taxdata/issues/242"},"comments":{"href":"https://api.github.com/repos/open-source-economics/taxdata/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/open-source-economics/taxdata/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/open-source-economics/taxdata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-source-economics/taxdata/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/open-source-economics/taxdata/statuses/406e0cbcc82eef4cae7c83dac6f839b5f84f4194"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hdoupe"}}