{"action":"created","issue":{"url":"https://api.github.com/repos/devtools-html/debugger.html/issues/6227","repository_url":"https://api.github.com/repos/devtools-html/debugger.html","labels_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/6227/labels{/name}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/6227/comments","events_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/6227/events","html_url":"https://github.com/devtools-html/debugger.html/pull/6227","id":320390413,"number":6227,"title":"Makes addTab only dependent on url","user":{"login":"lukaszsobek","id":23530054,"avatar_url":"https://avatars0.githubusercontent.com/u/23530054?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszsobek","html_url":"https://github.com/lukaszsobek","followers_url":"https://api.github.com/users/lukaszsobek/followers","following_url":"https://api.github.com/users/lukaszsobek/following{/other_user}","gists_url":"https://api.github.com/users/lukaszsobek/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszsobek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszsobek/subscriptions","organizations_url":"https://api.github.com/users/lukaszsobek/orgs","repos_url":"https://api.github.com/users/lukaszsobek/repos","events_url":"https://api.github.com/users/lukaszsobek/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszsobek/received_events","type":"User","site_admin":false},"labels":[{"id":731965110,"url":"https://api.github.com/repos/devtools-html/debugger.html/labels/pr-wip","name":"pr-wip","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-04T18:58:11Z","updated_at":"2018-05-05T06:31:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/6227","html_url":"https://github.com/devtools-html/debugger.html/pull/6227","diff_url":"https://github.com/devtools-html/debugger.html/pull/6227.diff","patch_url":"https://github.com/devtools-html/debugger.html/pull/6227.patch"},"body":"`addTab` and `ADD_TAB` only use the source url, so in order to clear up some things further down the line it would be really useful to decouple `addTab` from needing the whole source object."},"comment":{"url":"https://api.github.com/repos/devtools-html/debugger.html/issues/comments/386783689","html_url":"https://github.com/devtools-html/debugger.html/pull/6227#issuecomment-386783689","issue_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/6227","id":386783689,"user":{"login":"lukaszsobek","id":23530054,"avatar_url":"https://avatars0.githubusercontent.com/u/23530054?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszsobek","html_url":"https://github.com/lukaszsobek","followers_url":"https://api.github.com/users/lukaszsobek/followers","following_url":"https://api.github.com/users/lukaszsobek/following{/other_user}","gists_url":"https://api.github.com/users/lukaszsobek/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszsobek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszsobek/subscriptions","organizations_url":"https://api.github.com/users/lukaszsobek/orgs","repos_url":"https://api.github.com/users/lukaszsobek/repos","events_url":"https://api.github.com/users/lukaszsobek/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszsobek/received_events","type":"User","site_admin":false},"created_at":"2018-05-05T06:31:12Z","updated_at":"2018-05-05T06:31:12Z","author_association":"CONTRIBUTOR","body":"@jasonLaster sounds like a plan. But even if we decide to do it differently there will probably be 2 properties at max to pass which we could get off of the source before passing it to addTab.\r\n\r\nWhatever direction is chosen decoupling addTab (and a few others) from needing full objects will enable us to remove another couple of toJS() calls for performance gains without impeding the flexibility of the application."}}
{"actor":{"display_login":"lukaszsobek"}}