{"action":"created","comment":{"url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls/comments/178471231","pull_request_review_id":108531460,"id":178471231,"diff_hunk":"@@ -309,7 +318,36 @@ int trg_client_populate_with_settings(TrgClient * tc)\n \n gchar *trg_client_get_password(TrgClient * tc)\n {\n+#ifdef HAVE_LIBSECRET\n+    GError *error = NULL;\n+\n+    gchar *hostname = trg_prefs_get_string(tc->priv->prefs, TRG_PREFS_KEY_HOSTNAME, TRG_PREFS_PROFILE);\n+    gint64 port = trg_prefs_get_int(tc->priv->prefs, TRG_PREFS_KEY_PORT, TRG_PREFS_PROFILE);\n+    gchar *rpc_url_path = trg_prefs_get_string(tc->priv->prefs, TRG_PREFS_KEY_RPC_URL_PATH, TRG_PREFS_PROFILE);\n+    gboolean ssl = trg_prefs_get_bool(tc->priv->prefs, TRG_PREFS_KEY_SSL, TRG_PREFS_PROFILE);\n+    gchar *username = trg_prefs_get_string(tc->priv->prefs, TRG_PREFS_KEY_USERNAME, TRG_PREFS_PROFILE);\n+\n+    gchar *password = secret_password_lookup_sync (TRG_SECRET_SCHEMA, NULL, &error,","path":"src/trg-client.c","position":70,"original_position":70,"commit_id":"74a1579fcdb7819c014f08ffa5e22891cac57293","original_commit_id":"74a1579fcdb7819c014f08ffa5e22891cac57293","user":{"login":"TingPing","id":798838,"avatar_url":"https://avatars0.githubusercontent.com/u/798838?v=4","gravatar_id":"","url":"https://api.github.com/users/TingPing","html_url":"https://github.com/TingPing","followers_url":"https://api.github.com/users/TingPing/followers","following_url":"https://api.github.com/users/TingPing/following{/other_user}","gists_url":"https://api.github.com/users/TingPing/gists{/gist_id}","starred_url":"https://api.github.com/users/TingPing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TingPing/subscriptions","organizations_url":"https://api.github.com/users/TingPing/orgs","repos_url":"https://api.github.com/users/TingPing/repos","events_url":"https://api.github.com/users/TingPing/events{/privacy}","received_events_url":"https://api.github.com/users/TingPing/received_events","type":"User","site_admin":false},"body":"Blocking IO on the main thread.","created_at":"2018-04-01T23:10:48Z","updated_at":"2018-04-01T23:10:48Z","html_url":"https://github.com/transmission-remote-gtk/transmission-remote-gtk/pull/65#discussion_r178471231","pull_request_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls/65","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls/comments/178471231"},"html":{"href":"https://github.com/transmission-remote-gtk/transmission-remote-gtk/pull/65#discussion_r178471231"},"pull_request":{"href":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls/65","id":178751268,"html_url":"https://github.com/transmission-remote-gtk/transmission-remote-gtk/pull/65","diff_url":"https://github.com/transmission-remote-gtk/transmission-remote-gtk/pull/65.diff","patch_url":"https://github.com/transmission-remote-gtk/transmission-remote-gtk/pull/65.patch","issue_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/issues/65","number":65,"state":"open","locked":false,"title":"libsecret - store passwords in key chain.","user":{"login":"snaunton","id":17605850,"avatar_url":"https://avatars3.githubusercontent.com/u/17605850?v=4","gravatar_id":"","url":"https://api.github.com/users/snaunton","html_url":"https://github.com/snaunton","followers_url":"https://api.github.com/users/snaunton/followers","following_url":"https://api.github.com/users/snaunton/following{/other_user}","gists_url":"https://api.github.com/users/snaunton/gists{/gist_id}","starred_url":"https://api.github.com/users/snaunton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snaunton/subscriptions","organizations_url":"https://api.github.com/users/snaunton/orgs","repos_url":"https://api.github.com/users/snaunton/repos","events_url":"https://api.github.com/users/snaunton/events{/privacy}","received_events_url":"https://api.github.com/users/snaunton/received_events","type":"User","site_admin":false},"body":"#31 \r\n\r\nStore passwords in keychain, using libsecret, rather than in plaintext.\r\n\r\n@TingPing - I understand your points from #31 re sandboxing/disk encryption, but, lots of people still use distros with libsecret and --without-libsecret removes support if you want to build without it.","created_at":"2018-04-01T22:43:47Z","updated_at":"2018-04-01T23:10:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7f6251adf3692e2243baf2c0868f3c4bee64b9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls/65/commits","review_comments_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls/65/comments","review_comment_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/issues/65/comments","statuses_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/statuses/74a1579fcdb7819c014f08ffa5e22891cac57293","head":{"label":"snaunton:libsecret_enhancement","ref":"libsecret_enhancement","sha":"74a1579fcdb7819c014f08ffa5e22891cac57293","user":{"login":"snaunton","id":17605850,"avatar_url":"https://avatars3.githubusercontent.com/u/17605850?v=4","gravatar_id":"","url":"https://api.github.com/users/snaunton","html_url":"https://github.com/snaunton","followers_url":"https://api.github.com/users/snaunton/followers","following_url":"https://api.github.com/users/snaunton/following{/other_user}","gists_url":"https://api.github.com/users/snaunton/gists{/gist_id}","starred_url":"https://api.github.com/users/snaunton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snaunton/subscriptions","organizations_url":"https://api.github.com/users/snaunton/orgs","repos_url":"https://api.github.com/users/snaunton/repos","events_url":"https://api.github.com/users/snaunton/events{/privacy}","received_events_url":"https://api.github.com/users/snaunton/received_events","type":"User","site_admin":false},"repo":{"id":127675974,"name":"transmission-remote-gtk","full_name":"snaunton/transmission-remote-gtk","owner":{"login":"snaunton","id":17605850,"avatar_url":"https://avatars3.githubusercontent.com/u/17605850?v=4","gravatar_id":"","url":"https://api.github.com/users/snaunton","html_url":"https://github.com/snaunton","followers_url":"https://api.github.com/users/snaunton/followers","following_url":"https://api.github.com/users/snaunton/following{/other_user}","gists_url":"https://api.github.com/users/snaunton/gists{/gist_id}","starred_url":"https://api.github.com/users/snaunton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snaunton/subscriptions","organizations_url":"https://api.github.com/users/snaunton/orgs","repos_url":"https://api.github.com/users/snaunton/repos","events_url":"https://api.github.com/users/snaunton/events{/privacy}","received_events_url":"https://api.github.com/users/snaunton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snaunton/transmission-remote-gtk","description":"A native GTK remote interface to the Transmission BitTorrent client written in C","fork":true,"url":"https://api.github.com/repos/snaunton/transmission-remote-gtk","forks_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/forks","keys_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/teams","hooks_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/hooks","issue_events_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/issues/events{/number}","events_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/events","assignees_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/assignees{/user}","branches_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/branches{/branch}","tags_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/tags","blobs_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/git/refs{/sha}","trees_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/statuses/{sha}","languages_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/languages","stargazers_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/stargazers","contributors_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/contributors","subscribers_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/subscribers","subscription_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/subscription","commits_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/commits{/sha}","git_commits_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/git/commits{/sha}","comments_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/comments{/number}","issue_comment_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/issues/comments{/number}","contents_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/contents/{+path}","compare_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/merges","archive_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/downloads","issues_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/issues{/number}","pulls_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/pulls{/number}","milestones_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/milestones{/number}","notifications_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/labels{/name}","releases_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/releases{/id}","deployments_url":"https://api.github.com/repos/snaunton/transmission-remote-gtk/deployments","created_at":"2018-04-01T22:20:49Z","updated_at":"2018-04-01T22:20:51Z","pushed_at":"2018-04-01T22:26:20Z","git_url":"git://github.com/snaunton/transmission-remote-gtk.git","ssh_url":"git@github.com:snaunton/transmission-remote-gtk.git","clone_url":"https://github.com/snaunton/transmission-remote-gtk.git","svn_url":"https://github.com/snaunton/transmission-remote-gtk","homepage":"","size":3395,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"transmission-remote-gtk:master","ref":"master","sha":"dd01b099b7f1807999a08b09bbe06ed2d65aeadd","user":{"login":"transmission-remote-gtk","id":16673400,"avatar_url":"https://avatars2.githubusercontent.com/u/16673400?v=4","gravatar_id":"","url":"https://api.github.com/users/transmission-remote-gtk","html_url":"https://github.com/transmission-remote-gtk","followers_url":"https://api.github.com/users/transmission-remote-gtk/followers","following_url":"https://api.github.com/users/transmission-remote-gtk/following{/other_user}","gists_url":"https://api.github.com/users/transmission-remote-gtk/gists{/gist_id}","starred_url":"https://api.github.com/users/transmission-remote-gtk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transmission-remote-gtk/subscriptions","organizations_url":"https://api.github.com/users/transmission-remote-gtk/orgs","repos_url":"https://api.github.com/users/transmission-remote-gtk/repos","events_url":"https://api.github.com/users/transmission-remote-gtk/events{/privacy}","received_events_url":"https://api.github.com/users/transmission-remote-gtk/received_events","type":"Organization","site_admin":false},"repo":{"id":4024165,"name":"transmission-remote-gtk","full_name":"transmission-remote-gtk/transmission-remote-gtk","owner":{"login":"transmission-remote-gtk","id":16673400,"avatar_url":"https://avatars2.githubusercontent.com/u/16673400?v=4","gravatar_id":"","url":"https://api.github.com/users/transmission-remote-gtk","html_url":"https://github.com/transmission-remote-gtk","followers_url":"https://api.github.com/users/transmission-remote-gtk/followers","following_url":"https://api.github.com/users/transmission-remote-gtk/following{/other_user}","gists_url":"https://api.github.com/users/transmission-remote-gtk/gists{/gist_id}","starred_url":"https://api.github.com/users/transmission-remote-gtk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transmission-remote-gtk/subscriptions","organizations_url":"https://api.github.com/users/transmission-remote-gtk/orgs","repos_url":"https://api.github.com/users/transmission-remote-gtk/repos","events_url":"https://api.github.com/users/transmission-remote-gtk/events{/privacy}","received_events_url":"https://api.github.com/users/transmission-remote-gtk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/transmission-remote-gtk/transmission-remote-gtk","description":"A native GTK remote interface to the Transmission BitTorrent client written in C","fork":false,"url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk","forks_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/forks","keys_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/teams","hooks_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/hooks","issue_events_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/issues/events{/number}","events_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/events","assignees_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/assignees{/user}","branches_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/branches{/branch}","tags_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/tags","blobs_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/git/refs{/sha}","trees_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/statuses/{sha}","languages_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/languages","stargazers_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/stargazers","contributors_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/contributors","subscribers_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/subscribers","subscription_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/subscription","commits_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/commits{/sha}","git_commits_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/git/commits{/sha}","comments_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/comments{/number}","issue_comment_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/issues/comments{/number}","contents_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/contents/{+path}","compare_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/merges","archive_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/downloads","issues_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/issues{/number}","pulls_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls{/number}","milestones_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/milestones{/number}","notifications_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/labels{/name}","releases_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/releases{/id}","deployments_url":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/deployments","created_at":"2012-04-14T10:56:36Z","updated_at":"2018-02-05T16:21:30Z","pushed_at":"2018-04-01T22:43:48Z","git_url":"git://github.com/transmission-remote-gtk/transmission-remote-gtk.git","ssh_url":"git@github.com:transmission-remote-gtk/transmission-remote-gtk.git","clone_url":"https://github.com/transmission-remote-gtk/transmission-remote-gtk.git","svn_url":"https://github.com/transmission-remote-gtk/transmission-remote-gtk","homepage":"","size":3395,"stargazers_count":55,"watchers_count":55,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":23,"open_issues":27,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls/65"},"html":{"href":"https://github.com/transmission-remote-gtk/transmission-remote-gtk/pull/65"},"issue":{"href":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/issues/65"},"comments":{"href":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/transmission-remote-gtk/transmission-remote-gtk/statuses/74a1579fcdb7819c014f08ffa5e22891cac57293"}},"author_association":"NONE"}}
{"actor":{"display_login":"TingPing"}}