{"action":"created","issue":{"url":"https://api.github.com/repos/jamesmfriedman/rmwc/issues/328","repository_url":"https://api.github.com/repos/jamesmfriedman/rmwc","labels_url":"https://api.github.com/repos/jamesmfriedman/rmwc/issues/328/labels{/name}","comments_url":"https://api.github.com/repos/jamesmfriedman/rmwc/issues/328/comments","events_url":"https://api.github.com/repos/jamesmfriedman/rmwc/issues/328/events","html_url":"https://github.com/jamesmfriedman/rmwc/issues/328","id":365065735,"node_id":"MDU6SXNzdWUzNjUwNjU3MzU=","number":328,"title":"FAB Icon Offset after FAB exited goes from true to false if Dialog is closed","user":{"login":"llapresi","id":17561339,"node_id":"MDQ6VXNlcjE3NTYxMzM5","avatar_url":"https://avatars2.githubusercontent.com/u/17561339?v=4","gravatar_id":"","url":"https://api.github.com/users/llapresi","html_url":"https://github.com/llapresi","followers_url":"https://api.github.com/users/llapresi/followers","following_url":"https://api.github.com/users/llapresi/following{/other_user}","gists_url":"https://api.github.com/users/llapresi/gists{/gist_id}","starred_url":"https://api.github.com/users/llapresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llapresi/subscriptions","organizations_url":"https://api.github.com/users/llapresi/orgs","repos_url":"https://api.github.com/users/llapresi/repos","events_url":"https://api.github.com/users/llapresi/events{/privacy}","received_events_url":"https://api.github.com/users/llapresi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-28T22:52:00Z","updated_at":"2018-09-28T23:04:28Z","closed_at":null,"author_association":"NONE","body":"RMWC ver. 2.2.3\r\n[CodeSandbox Link that re-creates issue in in Chrome](https://codesandbox.io/s/n7kjz9ryll)\r\n\r\nThis is a pretty odd and specific issue but it wasn't happening to me before I updated from 1.8.3 to 2.2.3. I'm filing this as an RMWC bug because I believe it's a scripting issues which should mean the issue is with RMWC and not the MWC JavaScript itself, but I'm not sure.\r\n\r\nThe CodeSandbox link re-produces an issue where if you press the FAB to bring up the dialog and then press either Dialog's Accept or Cancel buttons, or the Button embedded in the Dialog body, the FAB's icon will have shifted position within the circular FAB shape. This does not happen if you click outside of the dialog to dismiss it, where the icon remains in the correct place.\r\n\r\nI initially believe that this happened because of some kind of conflict with how Button ripples work because when using the inspector it seems the FAB icon was being offset due to the ripple element. After testing it with the Button in the Dialog body that has ripples disable, however, I'm not sure of this because the same issue seems to be occurring despite not causing any kind of \"ripple conflict\" as I theorized."},"comment":{"url":"https://api.github.com/repos/jamesmfriedman/rmwc/issues/comments/425589732","html_url":"https://github.com/jamesmfriedman/rmwc/issues/328#issuecomment-425589732","issue_url":"https://api.github.com/repos/jamesmfriedman/rmwc/issues/328","id":425589732,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTU4OTczMg==","user":{"login":"llapresi","id":17561339,"node_id":"MDQ6VXNlcjE3NTYxMzM5","avatar_url":"https://avatars2.githubusercontent.com/u/17561339?v=4","gravatar_id":"","url":"https://api.github.com/users/llapresi","html_url":"https://github.com/llapresi","followers_url":"https://api.github.com/users/llapresi/followers","following_url":"https://api.github.com/users/llapresi/following{/other_user}","gists_url":"https://api.github.com/users/llapresi/gists{/gist_id}","starred_url":"https://api.github.com/users/llapresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llapresi/subscriptions","organizations_url":"https://api.github.com/users/llapresi/orgs","repos_url":"https://api.github.com/users/llapresi/repos","events_url":"https://api.github.com/users/llapresi/events{/privacy}","received_events_url":"https://api.github.com/users/llapresi/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T23:04:28Z","updated_at":"2018-09-28T23:04:28Z","author_association":"NONE","body":"I did some more testing and I think the main issue is with the .mdc-fab::before and .mdc-fab::after made in mdc-fab.\r\n\r\nIt seems that when the dialog is closed by the button, they're aligned to the bottom right corner of the FAB instead of being centered. If you toggle the width or height properties on and off, the issue fixes itself and the icon is once again property centered within the FAB.\r\n\r\n![offset-before](https://user-images.githubusercontent.com/17561339/46237257-4dcf5200-c351-11e8-840e-e51dfddf5d7d.png)\r\n"}}
{"actor":{"display_login":"llapresi"}}