{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls/comments/223666925","pull_request_review_id":162846269,"id":223666925,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzY2NjkyNQ==","diff_hunk":"@@ -112,22 +98,14 @@ public void onExplanationNeeded(List<String> permissionsToExplain) {\n     Toast.makeText(this, R.string.user_location_permission_explanation, Toast.LENGTH_LONG).show();\n   }\n \n-  @Override\n-  public void onResume() {\n-    super.onResume();\n-    if (!PermissionsManager.areLocationPermissionsGranted(this)) {\n-      getLifecycle().removeObserver(locationLayerPlugin);\n-    }\n-  }\n-\n   @Override\n   public void onPermissionResult(boolean granted) {\n     if (granted) {\n-      enableLocationPlugin();\n+      enableLocationComponent();\n     } else {\n       Toast.makeText(this, R.string.user_location_permission_not_granted, Toast.LENGTH_LONG).show();\n       finish();\n     }\n   }\n }\n-// #-end-code-snippet: location-plugin-fragment-activity full-java\n\\ No newline at end of file\n+// #-end-code-snippet: location-component-fragment-activity full-java","path":"MapboxAndroidDemo/src/main/java/com/mapbox/mapboxandroiddemo/examples/plugins/LocationComponentFragmentActivity.java","position":102,"original_position":102,"commit_id":"c6226e29fdf4358d165e9bb195c03d294e5e5157","original_commit_id":"c6226e29fdf4358d165e9bb195c03d294e5e5157","user":{"login":"LukasPaczos","id":16925074,"node_id":"MDQ6VXNlcjE2OTI1MDc0","avatar_url":"https://avatars0.githubusercontent.com/u/16925074?v=4","gravatar_id":"","url":"https://api.github.com/users/LukasPaczos","html_url":"https://github.com/LukasPaczos","followers_url":"https://api.github.com/users/LukasPaczos/followers","following_url":"https://api.github.com/users/LukasPaczos/following{/other_user}","gists_url":"https://api.github.com/users/LukasPaczos/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasPaczos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasPaczos/subscriptions","organizations_url":"https://api.github.com/users/LukasPaczos/orgs","repos_url":"https://api.github.com/users/LukasPaczos/repos","events_url":"https://api.github.com/users/LukasPaczos/events{/privacy}","received_events_url":"https://api.github.com/users/LukasPaczos/received_events","type":"User","site_admin":false},"body":"same as above","created_at":"2018-10-09T11:49:49Z","updated_at":"2018-10-09T11:49:57Z","html_url":"https://github.com/mapbox/mapbox-android-demo/pull/878#discussion_r223666925","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls/878","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls/comments/223666925"},"html":{"href":"https://github.com/mapbox/mapbox-android-demo/pull/878#discussion_r223666925"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls/878"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls/878","id":221407938,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNDA3OTM4","html_url":"https://github.com/mapbox/mapbox-android-demo/pull/878","diff_url":"https://github.com/mapbox/mapbox-android-demo/pull/878.diff","patch_url":"https://github.com/mapbox/mapbox-android-demo/pull/878.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/issues/878","number":878,"state":"open","locked":false,"title":"Reimplement location examples using component","user":{"login":"LukasPaczos","id":16925074,"node_id":"MDQ6VXNlcjE2OTI1MDc0","avatar_url":"https://avatars0.githubusercontent.com/u/16925074?v=4","gravatar_id":"","url":"https://api.github.com/users/LukasPaczos","html_url":"https://github.com/LukasPaczos","followers_url":"https://api.github.com/users/LukasPaczos/followers","following_url":"https://api.github.com/users/LukasPaczos/following{/other_user}","gists_url":"https://api.github.com/users/LukasPaczos/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasPaczos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasPaczos/subscriptions","organizations_url":"https://api.github.com/users/LukasPaczos/orgs","repos_url":"https://api.github.com/users/LukasPaczos/repos","events_url":"https://api.github.com/users/LukasPaczos/events{/privacy}","received_events_url":"https://api.github.com/users/LukasPaczos/received_events","type":"User","site_admin":false},"body":"Reimplements all location examples with `LocationComponent` and removes `LocationLayerPlugin` dependency.","created_at":"2018-10-09T11:48:12Z","updated_at":"2018-10-09T11:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c7f2316af1095ad0d9a455c59b603a023955e9c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"langsmith","id":4394910,"node_id":"MDQ6VXNlcjQzOTQ5MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/4394910?v=4","gravatar_id":"","url":"https://api.github.com/users/langsmith","html_url":"https://github.com/langsmith","followers_url":"https://api.github.com/users/langsmith/followers","following_url":"https://api.github.com/users/langsmith/following{/other_user}","gists_url":"https://api.github.com/users/langsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/langsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/langsmith/subscriptions","organizations_url":"https://api.github.com/users/langsmith/orgs","repos_url":"https://api.github.com/users/langsmith/repos","events_url":"https://api.github.com/users/langsmith/events{/privacy}","received_events_url":"https://api.github.com/users/langsmith/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":79806457,"node_id":"MDU6TGFiZWw3OTgwNjQ1Nw==","url":"https://api.github.com/repos/mapbox/mapbox-android-demo/labels/enhancement%20:heavy_plus_sign:","name":"enhancement :heavy_plus_sign:","color":"11b4da","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls/878/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls/878/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/issues/878/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/statuses/c6226e29fdf4358d165e9bb195c03d294e5e5157","head":{"label":"mapbox:lp-reimplement-location-using-component","ref":"lp-reimplement-location-using-component","sha":"c6226e29fdf4358d165e9bb195c03d294e5e5157","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16709229,"node_id":"MDEwOlJlcG9zaXRvcnkxNjcwOTIyOQ==","name":"mapbox-android-demo","full_name":"mapbox/mapbox-android-demo","private":false,"owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapbox/mapbox-android-demo","description":"Demo app for Mapbox Android SDK on Google Play","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-android-demo","forks_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/deployments","created_at":"2014-02-10T21:01:59Z","updated_at":"2018-10-09T05:42:37Z","pushed_at":"2018-10-09T11:48:13Z","git_url":"git://github.com/mapbox/mapbox-android-demo.git","ssh_url":"git@github.com:mapbox/mapbox-android-demo.git","clone_url":"https://github.com/mapbox/mapbox-android-demo.git","svn_url":"https://github.com/mapbox/mapbox-android-demo","homepage":"https://play.google.com/store/apps/details?id=com.mapbox.mapboxandroiddemo","size":117905,"stargazers_count":366,"watchers_count":366,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":239,"open_issues":67,"watchers":366,"default_branch":"master"}},"base":{"label":"mapbox:ls-test-maps-6.6.0","ref":"ls-test-maps-6.6.0","sha":"ab73e0be55b631f896e58cc722113fbf9162c477","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16709229,"node_id":"MDEwOlJlcG9zaXRvcnkxNjcwOTIyOQ==","name":"mapbox-android-demo","full_name":"mapbox/mapbox-android-demo","private":false,"owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapbox/mapbox-android-demo","description":"Demo app for Mapbox Android SDK on Google Play","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-android-demo","forks_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-android-demo/deployments","created_at":"2014-02-10T21:01:59Z","updated_at":"2018-10-09T05:42:37Z","pushed_at":"2018-10-09T11:48:13Z","git_url":"git://github.com/mapbox/mapbox-android-demo.git","ssh_url":"git@github.com:mapbox/mapbox-android-demo.git","clone_url":"https://github.com/mapbox/mapbox-android-demo.git","svn_url":"https://github.com/mapbox/mapbox-android-demo","homepage":"https://play.google.com/store/apps/details?id=com.mapbox.mapboxandroiddemo","size":117905,"stargazers_count":366,"watchers_count":366,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":239,"open_issues":67,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls/878"},"html":{"href":"https://github.com/mapbox/mapbox-android-demo/pull/878"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-android-demo/issues/878"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-android-demo/issues/878/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls/878/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-android-demo/pulls/878/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-android-demo/statuses/c6226e29fdf4358d165e9bb195c03d294e5e5157"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"LukasPaczos"}}