{"action":"created","issue":{"url":"https://api.github.com/repos/omadahealth/LolliPin/issues/157","repository_url":"https://api.github.com/repos/omadahealth/LolliPin","labels_url":"https://api.github.com/repos/omadahealth/LolliPin/issues/157/labels{/name}","comments_url":"https://api.github.com/repos/omadahealth/LolliPin/issues/157/comments","events_url":"https://api.github.com/repos/omadahealth/LolliPin/issues/157/events","html_url":"https://github.com/omadahealth/LolliPin/pull/157","id":264136679,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQ1NjI1NDUx","number":157,"title":"Fix for PIN lock bypass when app is killed or repeatedly paused","user":{"login":"alexkeramidas","id":4745693,"node_id":"MDQ6VXNlcjQ3NDU2OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4745693?v=4","gravatar_id":"","url":"https://api.github.com/users/alexkeramidas","html_url":"https://github.com/alexkeramidas","followers_url":"https://api.github.com/users/alexkeramidas/followers","following_url":"https://api.github.com/users/alexkeramidas/following{/other_user}","gists_url":"https://api.github.com/users/alexkeramidas/gists{/gist_id}","starred_url":"https://api.github.com/users/alexkeramidas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexkeramidas/subscriptions","organizations_url":"https://api.github.com/users/alexkeramidas/orgs","repos_url":"https://api.github.com/users/alexkeramidas/repos","events_url":"https://api.github.com/users/alexkeramidas/events{/privacy}","received_events_url":"https://api.github.com/users/alexkeramidas/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-10-10T08:15:47Z","updated_at":"2018-10-08T15:17:28Z","closed_at":"2017-10-31T17:11:56Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/omadahealth/LolliPin/pulls/157","html_url":"https://github.com/omadahealth/LolliPin/pull/157","diff_url":"https://github.com/omadahealth/LolliPin/pull/157.diff","patch_url":"https://github.com/omadahealth/LolliPin/pull/157.patch"},"body":"Several issues reported that the PIN lock can be bypassed, which was related to the `onlyBackgroundTimeout` setting. The root cause was the logic deciding when the user was last active. This PR fixes these issues. \r\n\r\nThe issues could be reproduced in the demo app when setting `onlyBackgroundTimeOut` to true:\r\n\r\n- Launch the app\r\n- Set the expiry to N seconds (or use the default 10 seconds)\r\n- Kill the app\r\n- Wait N + 1 seconds\r\n- Launch the app\r\n\r\nOr (not 100% reproducible on all devices)\r\n\r\n- Launch the app\r\n- Set the expiry to N seconds (or use the default 10 seconds)\r\n- Send to background via home button \r\n- Wait N + 1 seconds\r\n- Launch the app\r\n- Send to background via home button \r\n- Launch the app\r\n\r\nThis PR keeps the previous functionality and additionally enhances the behavior when onlyBackground is set to true.\r\n\r\nIssues addressed:\r\n\r\n[#130](https://github.com/omadahealth/LolliPin/issues/130)\r\n[#153](https://github.com/omadahealth/LolliPin/issues/153)\r\n[#131](https://github.com/omadahealth/LolliPin/issues/131)\r\n[#99](https://github.com/omadahealth/LolliPin/issues/99)"},"comment":{"url":"https://api.github.com/repos/omadahealth/LolliPin/issues/comments/427874636","html_url":"https://github.com/omadahealth/LolliPin/pull/157#issuecomment-427874636","issue_url":"https://api.github.com/repos/omadahealth/LolliPin/issues/157","id":427874636,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzg3NDYzNg==","user":{"login":"alexkeramidas","id":4745693,"node_id":"MDQ6VXNlcjQ3NDU2OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4745693?v=4","gravatar_id":"","url":"https://api.github.com/users/alexkeramidas","html_url":"https://github.com/alexkeramidas","followers_url":"https://api.github.com/users/alexkeramidas/followers","following_url":"https://api.github.com/users/alexkeramidas/following{/other_user}","gists_url":"https://api.github.com/users/alexkeramidas/gists{/gist_id}","starred_url":"https://api.github.com/users/alexkeramidas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexkeramidas/subscriptions","organizations_url":"https://api.github.com/users/alexkeramidas/orgs","repos_url":"https://api.github.com/users/alexkeramidas/repos","events_url":"https://api.github.com/users/alexkeramidas/events{/privacy}","received_events_url":"https://api.github.com/users/alexkeramidas/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T15:17:28Z","updated_at":"2018-10-08T15:17:28Z","author_association":"CONTRIBUTOR","body":"Hey, sorry to hear that.\r\nThis is interesting since we also use that on our application. Let me see if I can help you.\r\nI will need some small quick info. What timeout do you use in your application?"}}
{"actor":{"display_login":"alexkeramidas"}}