{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues/132","repository_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet","labels_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues/132/comments","events_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues/132/events","html_url":"https://github.com/Microsoft/service-fabric-services-and-actors-dotnet/issues/132","id":338579015,"node_id":"MDU6SXNzdWUzMzg1NzkwMTU=","number":132,"title":"Build error if AssemblyName is changed","user":{"login":"aaubry","id":630495,"node_id":"MDQ6VXNlcjYzMDQ5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/630495?v=4","gravatar_id":"","url":"https://api.github.com/users/aaubry","html_url":"https://github.com/aaubry","followers_url":"https://api.github.com/users/aaubry/followers","following_url":"https://api.github.com/users/aaubry/following{/other_user}","gists_url":"https://api.github.com/users/aaubry/gists{/gist_id}","starred_url":"https://api.github.com/users/aaubry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaubry/subscriptions","organizations_url":"https://api.github.com/users/aaubry/orgs","repos_url":"https://api.github.com/users/aaubry/repos","events_url":"https://api.github.com/users/aaubry/events{/privacy}","received_events_url":"https://api.github.com/users/aaubry/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-05T13:38:49Z","updated_at":"2018-08-23T11:36:59Z","closed_at":"2018-07-10T19:28:59Z","author_association":"CONTRIBUTOR","body":"When I change the assembly name of my actor project, the build fails with the following error:\r\n```\r\nC:\\src> dotnet msbuild\r\n\r\nMicrosoft (R) Build Engine version 15.7.179.6572 for .NET Core\r\nCopyright (C) Microsoft Corporation. All rights reserved.\r\n\r\n  MyActor.Interfaces -> C:\\src\\MyActor.Interfaces\\bin\\Debug\\netcoreapp2.0\\win7-x64\\MyProject.MyActor.Interfaces.dll\r\n  MyActor -> C:\\src\\MyActor\\bin\\Debug\\netcoreapp2.0\\win7-x64\\MyProject.MyActor.dll\r\nC:\\Users\\user\\.nuget\\packages\\microsoft.servicefabric.actors\\3.1.283\\build\\netcoreapp2.0\\Microsoft.ServiceFabric.Actors.targets(16,5): error MSB3030: Could not copy the file \"C:\\src\\MyActor\\bin\\Debug\\netcoreapp2.0\\win7-x64\\\\MyActor.runtimeconfig.dev.json\" because it was not found. [C:\\src\\MyActor\\MyActor.csproj]\r\n```\r\n\r\nThis is because [`Microsoft.ServiceFabric.Actors.targets` uses the `MSBuildProjectName` property](https://github.com/Microsoft/service-fabric-services-and-actors-dotnet/blob/b19956611ca2022c64551ccca54c50277e18422a/src/netstandard/FabActUtil/Microsoft.ServiceFabric.Actors.targets#L16) to calculate the name of that file, instead of using the `AssemblyName` one:\r\n\r\n```xml\r\n    <Copy SourceFiles=\"$(TargetDir)\\$(MSBuildProjectName).runtimeconfig.dev.json\" DestinationFiles=\"$(FabActUtilWorkingDir)\\FabActUtil.runtimeconfig.dev.json\" SkipUnchangedFiles=\"true\" />\r\n    <Copy SourceFiles=\"$(TargetDir)\\$(MSBuildProjectName).deps.json\" DestinationFiles=\"$(FabActUtilWorkingDir)\\FabActUtil.deps.json\" SkipUnchangedFiles=\"true\" />\r\n```\r\n\r\nI believe that simply changing to use `$(AssemblyName)` instead would fix the problem. I have tested locally and it seems to work, but there may be hidden side-effects that I am not aware of. I will submit a pull request with this change.\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues/comments/415384211","html_url":"https://github.com/Microsoft/service-fabric-services-and-actors-dotnet/issues/132#issuecomment-415384211","issue_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues/132","id":415384211,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTM4NDIxMQ==","user":{"login":"dan-zetea","id":42642191,"node_id":"MDQ6VXNlcjQyNjQyMTkx","avatar_url":"https://avatars0.githubusercontent.com/u/42642191?v=4","gravatar_id":"","url":"https://api.github.com/users/dan-zetea","html_url":"https://github.com/dan-zetea","followers_url":"https://api.github.com/users/dan-zetea/followers","following_url":"https://api.github.com/users/dan-zetea/following{/other_user}","gists_url":"https://api.github.com/users/dan-zetea/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-zetea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-zetea/subscriptions","organizations_url":"https://api.github.com/users/dan-zetea/orgs","repos_url":"https://api.github.com/users/dan-zetea/repos","events_url":"https://api.github.com/users/dan-zetea/events{/privacy}","received_events_url":"https://api.github.com/users/dan-zetea/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T11:36:59Z","updated_at":"2018-08-23T11:36:59Z","author_association":"NONE","body":"Do you have any info regarding which version of SF will contain this fix?"}}
{"actor":{"display_login":"dan-zetea"}}