{"action":"created","comment":{"url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments/237290775","pull_request_review_id":179553680,"id":237290775,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzI5MDc3NQ==","diff_hunk":"@@ -57,6 +58,7 @@ const renderInstant = (config: ZeroExInstantConfig, selector: string) => {\n     injectedDiv.setAttribute('class', INJECTED_DIV_CLASS);\n     appendTo.appendChild(injectedDiv);\n     const closeInstant = () => {\n+        analytics.trackInstantClosed();","path":"packages/instant/src/index.umd.ts","position":12,"original_position":12,"commit_id":"856f4b473b54ecb3dc707ea334890397c98606bf","original_commit_id":"856f4b473b54ecb3dc707ea334890397c98606bf","user":{"login":"steveklebanoff","id":210914,"node_id":"MDQ6VXNlcjIxMDkxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/210914?v=4","gravatar_id":"","url":"https://api.github.com/users/steveklebanoff","html_url":"https://github.com/steveklebanoff","followers_url":"https://api.github.com/users/steveklebanoff/followers","following_url":"https://api.github.com/users/steveklebanoff/following{/other_user}","gists_url":"https://api.github.com/users/steveklebanoff/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklebanoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklebanoff/subscriptions","organizations_url":"https://api.github.com/users/steveklebanoff/orgs","repos_url":"https://api.github.com/users/steveklebanoff/repos","events_url":"https://api.github.com/users/steveklebanoff/events{/privacy}","received_events_url":"https://api.github.com/users/steveklebanoff/received_events","type":"User","site_admin":false},"body":"So this is what I did:\r\n\r\n```diff\r\ndiff --git a/packages/instant/public/index.html b/packages/instant/public/index.html\r\nindex df39994ef..01e3e49d8 100644\r\n--- a/packages/instant/public/index.html\r\n+++ b/packages/instant/public/index.html\r\n@@ -174,7 +174,7 @@\r\n                     availableAssetDatas: availableAssetDatasString ? JSON.parse(availableAssetDatasString) : undefined,\r\n                     defaultSelectedAssetData: queryParams.getQueryParamValue('defaultSelectedAssetData'),\r\n                     affiliateInfo: affiliateInfoOverride,\r\n-                    shouldDisablePushToHistory: !!queryParams.getQueryParamValue('shouldDisablePushToHistory'),\r\n+                    shouldDisablePushToHistory: false,\r\n                 };\r\n                 return renderOptionsOverrides;\r\n             };\r\ndiff --git a/packages/instant/src/index.umd.ts b/packages/instant/src/index.umd.ts\r\nindex 667daf441..da57b4e3c 100644\r\n--- a/packages/instant/src/index.umd.ts\r\n+++ b/packages/instant/src/index.umd.ts\r\n@@ -50,6 +50,7 @@ const validateInstantRenderConfig = (config: ZeroExInstantConfig, selector: stri\r\n\r\n // Render instant and return a callback that allows you to remove it from the DOM.\r\n const renderInstant = (config: ZeroExInstantConfig, selector: string) => {\r\n+    console.log('shouldDisablePushToHistory', config.shouldDisablePushToHistory);\r\n     const appendToIfExists = document.querySelector(selector);\r\n     assert.assert(!_.isNull(appendToIfExists), `Could not find div with selector: ${selector}`);\r\n     const appendTo = appendToIfExists as Element;\r\n@@ -58,6 +59,7 @@ const renderInstant = (config: ZeroExInstantConfig, selector: string) => {\r\n     injectedDiv.setAttribute('class', INJECTED_DIV_CLASS);\r\n     appendTo.appendChild(injectedDiv);\r\n     const closeInstant = () => {\r\n+        console.log('*track closed*');\r\n         analytics.trackInstantClosed();\r\n         if (!_.isUndefined(config.onClose)) {\r\n             config.onClose();\r\n```\r\n\r\nI loaded the new public/index.html, closed via clicking the \"X\", and saw the following in the console:\r\n```\r\nshouldDisablePushToHistory false\r\n*track closed*\r\n```\r\n\r\nSo, in my understanding: this works.  But it sounds like there may be another piece to this I'm missing?","created_at":"2018-11-28T22:42:19Z","updated_at":"2018-11-28T22:42:20Z","html_url":"https://github.com/0xProject/0x-monorepo/pull/1342#discussion_r237290775","pull_request_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1342","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments/237290775"},"html":{"href":"https://github.com/0xProject/0x-monorepo/pull/1342#discussion_r237290775"},"pull_request":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1342"}},"in_reply_to_id":236949998},"pull_request":{"url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1342","id":234079298,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDc5Mjk4","html_url":"https://github.com/0xProject/0x-monorepo/pull/1342","diff_url":"https://github.com/0xProject/0x-monorepo/pull/1342.diff","patch_url":"https://github.com/0xProject/0x-monorepo/pull/1342.patch","issue_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/1342","number":1342,"state":"open","locked":false,"title":"[instant] Close and View Transaction analytics events","user":{"login":"steveklebanoff","id":210914,"node_id":"MDQ6VXNlcjIxMDkxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/210914?v=4","gravatar_id":"","url":"https://api.github.com/users/steveklebanoff","html_url":"https://github.com/steveklebanoff","followers_url":"https://api.github.com/users/steveklebanoff/followers","following_url":"https://api.github.com/users/steveklebanoff/following{/other_user}","gists_url":"https://api.github.com/users/steveklebanoff/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklebanoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklebanoff/subscriptions","organizations_url":"https://api.github.com/users/steveklebanoff/orgs","repos_url":"https://api.github.com/users/steveklebanoff/repos","events_url":"https://api.github.com/users/steveklebanoff/events{/privacy}","received_events_url":"https://api.github.com/users/steveklebanoff/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nAnalytics events for closing Instant and viewing txn\r\n\r\n## Testing instructions\r\n\r\n<!--- Please describe how reviewers can test your changes -->\r\n\r\n## Types of changes\r\n\r\n<!--- What types of changes does your code introduce? Uncomment all the bullets that apply: -->\r\n\r\n<!-- * Bug fix (non-breaking change which fixes an issue) -->\r\n\r\n<!-- * New feature (non-breaking change which adds functionality) -->\r\n\r\n<!-- * Breaking change (fix or feature that would cause existing functionality to change) -->\r\n\r\n## Checklist:\r\n\r\n<!--- The following points should be used to indicate the progress of your PR.  Put an `x` in all the boxes that apply right now, and come back over time and check them off as you make progress.  If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n*   [ ] Prefix PR title with `[WIP]` if necessary.\r\n*   [ ] Add tests to cover changes as needed.\r\n*   [ ] Update documentation as needed.\r\n*   [ ] Add new entries to the relevant CHANGELOG.jsons.\r\n","created_at":"2018-11-27T22:15:32Z","updated_at":"2018-11-28T22:42:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc9b1378bfdd994996cb826c7765e9d3e3e095bf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fragosti","id":3066135,"node_id":"MDQ6VXNlcjMwNjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3066135?v=4","gravatar_id":"","url":"https://api.github.com/users/fragosti","html_url":"https://github.com/fragosti","followers_url":"https://api.github.com/users/fragosti/followers","following_url":"https://api.github.com/users/fragosti/following{/other_user}","gists_url":"https://api.github.com/users/fragosti/gists{/gist_id}","starred_url":"https://api.github.com/users/fragosti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragosti/subscriptions","organizations_url":"https://api.github.com/users/fragosti/orgs","repos_url":"https://api.github.com/users/fragosti/repos","events_url":"https://api.github.com/users/fragosti/events{/privacy}","received_events_url":"https://api.github.com/users/fragosti/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1077385218,"node_id":"MDU6TGFiZWwxMDc3Mzg1MjE4","url":"https://api.github.com/repos/0xProject/0x-monorepo/labels/instant","name":"instant","color":"512D80","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1342/commits","review_comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1342/comments","review_comment_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/1342/comments","statuses_url":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/856f4b473b54ecb3dc707ea334890397c98606bf","head":{"label":"0xProject:feature/instant/misc-close-analytics","ref":"feature/instant/misc-close-analytics","sha":"856f4b473b54ecb3dc707ea334890397c98606bf","user":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"node_id":"MDEwOlJlcG9zaXRvcnk5MjE4MTM3MQ==","name":"0x-monorepo","full_name":"0xProject/0x-monorepo","private":false,"owner":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/0xProject/0x-monorepo","description":"0x protocol monorepo - includes our smart contracts and many developer tools","fork":false,"url":"https://api.github.com/repos/0xProject/0x-monorepo","forks_url":"https://api.github.com/repos/0xProject/0x-monorepo/forks","keys_url":"https://api.github.com/repos/0xProject/0x-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x-monorepo/teams","hooks_url":"https://api.github.com/repos/0xProject/0x-monorepo/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x-monorepo/events","assignees_url":"https://api.github.com/repos/0xProject/0x-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/tags","blobs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x-monorepo/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x-monorepo/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x-monorepo/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscription","commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x-monorepo/merges","archive_url":"https://api.github.com/repos/0xProject/0x-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x-monorepo/downloads","issues_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x-monorepo/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2018-11-28T22:33:14Z","pushed_at":"2018-11-28T22:33:08Z","git_url":"git://github.com/0xProject/0x-monorepo.git","ssh_url":"git@github.com:0xProject/0x-monorepo.git","clone_url":"https://github.com/0xProject/0x-monorepo.git","svn_url":"https://github.com/0xProject/0x-monorepo","homepage":"","size":64716,"stargazers_count":895,"watchers_count":895,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":252,"open_issues":47,"watchers":895,"default_branch":"development"}},"base":{"label":"0xProject:development","ref":"development","sha":"47a87e57f1cfa82375c87829320f30049217d657","user":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"node_id":"MDEwOlJlcG9zaXRvcnk5MjE4MTM3MQ==","name":"0x-monorepo","full_name":"0xProject/0x-monorepo","private":false,"owner":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/0xProject/0x-monorepo","description":"0x protocol monorepo - includes our smart contracts and many developer tools","fork":false,"url":"https://api.github.com/repos/0xProject/0x-monorepo","forks_url":"https://api.github.com/repos/0xProject/0x-monorepo/forks","keys_url":"https://api.github.com/repos/0xProject/0x-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x-monorepo/teams","hooks_url":"https://api.github.com/repos/0xProject/0x-monorepo/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x-monorepo/events","assignees_url":"https://api.github.com/repos/0xProject/0x-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/tags","blobs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x-monorepo/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x-monorepo/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x-monorepo/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscription","commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x-monorepo/merges","archive_url":"https://api.github.com/repos/0xProject/0x-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x-monorepo/downloads","issues_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x-monorepo/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2018-11-28T22:33:14Z","pushed_at":"2018-11-28T22:33:08Z","git_url":"git://github.com/0xProject/0x-monorepo.git","ssh_url":"git@github.com:0xProject/0x-monorepo.git","clone_url":"https://github.com/0xProject/0x-monorepo.git","svn_url":"https://github.com/0xProject/0x-monorepo","homepage":"","size":64716,"stargazers_count":895,"watchers_count":895,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":252,"open_issues":47,"watchers":895,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1342"},"html":{"href":"https://github.com/0xProject/0x-monorepo/pull/1342"},"issue":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/issues/1342"},"comments":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/issues/1342/comments"},"review_comments":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1342/comments"},"review_comment":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1342/commits"},"statuses":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/856f4b473b54ecb3dc707ea334890397c98606bf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"steveklebanoff"}}