{"action":"created","issue":{"url":"https://api.github.com/repos/rsksmart/rskj/issues/731","repository_url":"https://api.github.com/repos/rsksmart/rskj","labels_url":"https://api.github.com/repos/rsksmart/rskj/issues/731/labels{/name}","comments_url":"https://api.github.com/repos/rsksmart/rskj/issues/731/comments","events_url":"https://api.github.com/repos/rsksmart/rskj/issues/731/events","html_url":"https://github.com/rsksmart/rskj/pull/731","id":391199487,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NzkwODM2","number":731,"title":"Cleanup on wire protocol process status ","user":{"login":"lsebrie","id":6642445,"node_id":"MDQ6VXNlcjY2NDI0NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/6642445?v=4","gravatar_id":"","url":"https://api.github.com/users/lsebrie","html_url":"https://github.com/lsebrie","followers_url":"https://api.github.com/users/lsebrie/followers","following_url":"https://api.github.com/users/lsebrie/following{/other_user}","gists_url":"https://api.github.com/users/lsebrie/gists{/gist_id}","starred_url":"https://api.github.com/users/lsebrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsebrie/subscriptions","organizations_url":"https://api.github.com/users/lsebrie/orgs","repos_url":"https://api.github.com/users/lsebrie/repos","events_url":"https://api.github.com/users/lsebrie/events{/privacy}","received_events_url":"https://api.github.com/users/lsebrie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-14T17:27:06Z","updated_at":"2018-12-14T17:33:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rsksmart/rskj/pulls/731","html_url":"https://github.com/rsksmart/rskj/pull/731","diff_url":"https://github.com/rsksmart/rskj/pull/731.diff","patch_url":"https://github.com/rsksmart/rskj/pull/731.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/rsksmart/rskj/issues/comments/447396051","html_url":"https://github.com/rsksmart/rskj/pull/731#issuecomment-447396051","issue_url":"https://api.github.com/repos/rsksmart/rskj/issues/731","id":447396051,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzM5NjA1MQ==","user":{"login":"rskops","id":27817831,"node_id":"MDQ6VXNlcjI3ODE3ODMx","avatar_url":"https://avatars3.githubusercontent.com/u/27817831?v=4","gravatar_id":"","url":"https://api.github.com/users/rskops","html_url":"https://github.com/rskops","followers_url":"https://api.github.com/users/rskops/followers","following_url":"https://api.github.com/users/rskops/following{/other_user}","gists_url":"https://api.github.com/users/rskops/gists{/gist_id}","starred_url":"https://api.github.com/users/rskops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rskops/subscriptions","organizations_url":"https://api.github.com/users/rskops/orgs","repos_url":"https://api.github.com/users/rskops/repos","events_url":"https://api.github.com/users/rskops/events{/privacy}","received_events_url":"https://api.github.com/users/rskops/received_events","type":"User","site_admin":false},"created_at":"2018-12-14T17:33:27Z","updated_at":"2018-12-14T17:33:27Z","author_association":"NONE","body":"SonarQube analysis reported 5 issues\n\n1. ![CRITICAL][CRITICAL] [RskWireProtocol.java#L49](https://github.com/rsksmart/rskj/blob/0caa1ba8146d0a9cd1dcb9c9b2836c6a262f915b/rskj-core/src/main/java/co/rsk/net/eth/RskWireProtocol.java#L49): Unused import - java.math.BigInteger. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://jenkins.rsklabs.io/sonar/coding_rules#rule_key=checkstyle%3Acom.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck)\n1. ![MAJOR][MAJOR] [RskWireProtocol.java#L163](https://github.com/rsksmart/rskj/blob/0caa1ba8146d0a9cd1dcb9c9b2836c6a262f915b/rskj-core/src/main/java/co/rsk/net/eth/RskWireProtocol.java#L163): Method co.rsk.net.eth.RskWireProtocol.processStatus(StatusMessage, ChannelHandlerContext) appears to call the same method on the same object redundantly [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://jenkins.rsklabs.io/sonar/coding_rules#rule_key=fb-contrib%3APRMC_POSSIBLY_REDUNDANT_METHOD_CALLS)\n1. ![MAJOR][MAJOR] [RskWireProtocol.java#L174](https://github.com/rsksmart/rskj/blob/0caa1ba8146d0a9cd1dcb9c9b2836c6a262f915b/rskj-core/src/main/java/co/rsk/net/eth/RskWireProtocol.java#L174): Method co.rsk.net.eth.RskWireProtocol.processStatus(StatusMessage, ChannelHandlerContext) appears to call the same method on the same object redundantly [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://jenkins.rsklabs.io/sonar/coding_rules#rule_key=fb-contrib%3APRMC_POSSIBLY_REDUNDANT_METHOD_CALLS)\n1. ![MAJOR][MAJOR] [RskWireProtocol.java#L185](https://github.com/rsksmart/rskj/blob/0caa1ba8146d0a9cd1dcb9c9b2836c6a262f915b/rskj-core/src/main/java/co/rsk/net/eth/RskWireProtocol.java#L185): Method co.rsk.net.eth.RskWireProtocol.processStatus(StatusMessage, ChannelHandlerContext) appears to call the same method on the same object redundantly [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://jenkins.rsklabs.io/sonar/coding_rules#rule_key=fb-contrib%3APRMC_POSSIBLY_REDUNDANT_METHOD_CALLS)\n1. ![MINOR][MINOR] [RskWireProtocol.java#L246](https://github.com/rsksmart/rskj/blob/0caa1ba8146d0a9cd1dcb9c9b2836c6a262f915b/rskj-core/src/main/java/co/rsk/net/eth/RskWireProtocol.java#L246): Rename \"genesis\" which hides the field declared at line 81. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://jenkins.rsklabs.io/sonar/coding_rules#rule_key=squid%3AHiddenFieldCheck)\n\n[CRITICAL]: https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL'\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"rskops"}}