{"action":"closed","issue":{"url":"https://api.github.com/repos/EmicoEcommerce/Magento2Tweakwise/issues/34","repository_url":"https://api.github.com/repos/EmicoEcommerce/Magento2Tweakwise","labels_url":"https://api.github.com/repos/EmicoEcommerce/Magento2Tweakwise/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/EmicoEcommerce/Magento2Tweakwise/issues/34/comments","events_url":"https://api.github.com/repos/EmicoEcommerce/Magento2Tweakwise/issues/34/events","html_url":"https://github.com/EmicoEcommerce/Magento2Tweakwise/issues/34","id":293523754,"number":34,"title":"Wrong message is shown on the search result page when no products are found","user":{"login":"joost-florijn-kega","id":16535591,"avatar_url":"https://avatars2.githubusercontent.com/u/16535591?v=4","gravatar_id":"","url":"https://api.github.com/users/joost-florijn-kega","html_url":"https://github.com/joost-florijn-kega","followers_url":"https://api.github.com/users/joost-florijn-kega/followers","following_url":"https://api.github.com/users/joost-florijn-kega/following{/other_user}","gists_url":"https://api.github.com/users/joost-florijn-kega/gists{/gist_id}","starred_url":"https://api.github.com/users/joost-florijn-kega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joost-florijn-kega/subscriptions","organizations_url":"https://api.github.com/users/joost-florijn-kega/orgs","repos_url":"https://api.github.com/users/joost-florijn-kega/repos","events_url":"https://api.github.com/users/joost-florijn-kega/events{/privacy}","received_events_url":"https://api.github.com/users/joost-florijn-kega/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-01T13:08:38Z","updated_at":"2018-02-01T15:59:20Z","closed_at":"2018-02-01T15:59:20Z","author_association":"CONTRIBUTOR","body":"Issue Brief\r\n--\r\nWhen you search on a search term that results in no products are found the wrong message is shown.\r\n\r\nEnvironment\r\n--\r\n* PHP Version: (5.6|7.0|7.1)\r\n* Magento Version: 2.1.9\r\n* Tweakwise Version: 1.0.9\r\n* Tweakwise Export Version: 1.1.2\r\n* Magento Deploy Mode: production|development\r\n\r\nSteps to reproduce\r\n--\r\n1. Install Magento from `develop` branch.\r\n2. Search on a term that you now results in zero products.\r\n\r\nActual result\r\n--\r\n1. The message 'We can't find products matching the selection.' is shown.\r\n\r\nExpected result\r\n--\r\nList the expected results as a bullet list of expectations\r\n- [ ] The following message should be shown: 'Your search returned no results.'\r\n\r\nThe reason why the wrong message is shown is because the result block of Magento checks if there are any results with the function 'getSize()':\r\nhttps://github.com/magento/magento2/blob/2.1/app/code/Magento/CatalogSearch/Block/Result.php#L203\r\n\r\nThe function getSize uses the getSelectCountSql function to check how many products are found (https://github.com/magento/magento2/blob/2.1/lib/internal/Magento/Framework/Data/Collection/AbstractDb.php#L217). The product collection hasn't been filtered yet because that happens on load."}}
{"actor":{"display_login":"Fgruntjes"}}