{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/comments/218876341","pull_request_review_id":156913296,"id":218876341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODg3NjM0MQ==","diff_hunk":"@@ -54,8 +53,14 @@ export class PythonProjectCreator extends ScriptProjectCreatorBase {\n         if (!await validateFuncCoreToolsInstalled(true /* forcePrompt */, funcCoreRequired)) {\n             throw new UserCancelledError();\n         }\n-        await this.validatePythonVersion();\n-        await this.createVirtualEnviornment();\n+        if (await fse.pathExists(path.join(this.functionAppPath, funcEnvName))) {\n+            const input: MessageItem = await ext.ui.showWarningMessage(localize('funcEnvExists', 'Python Virtual Environment already exists.  Overwrite?', funcEnvName), { modal: true }, DialogResponses.yes, DialogResponses.no, DialogResponses.cancel);","path":"src/commands/createNewProject/PythonProjectCreator.ts","position":26,"original_position":26,"commit_id":"3490eb5b4749eb4f38779738f07d11b288e0d3bb","original_commit_id":"3490eb5b4749eb4f38779738f07d11b288e0d3bb","user":{"login":"StephenWeatherford","id":6913354,"node_id":"MDQ6VXNlcjY5MTMzNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6913354?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenWeatherford","html_url":"https://github.com/StephenWeatherford","followers_url":"https://api.github.com/users/StephenWeatherford/followers","following_url":"https://api.github.com/users/StephenWeatherford/following{/other_user}","gists_url":"https://api.github.com/users/StephenWeatherford/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenWeatherford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenWeatherford/subscriptions","organizations_url":"https://api.github.com/users/StephenWeatherford/orgs","repos_url":"https://api.github.com/users/StephenWeatherford/repos","events_url":"https://api.github.com/users/StephenWeatherford/events{/privacy}","received_events_url":"https://api.github.com/users/StephenWeatherford/received_events","type":"User","site_admin":false},"body":"Missing {0} or whatever for funcEnvName arg?","created_at":"2018-09-19T16:34:08Z","updated_at":"2018-09-19T16:34:08Z","html_url":"https://github.com/Microsoft/vscode-azurefunctions/pull/612#discussion_r218876341","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/612","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/comments/218876341"},"html":{"href":"https://github.com/Microsoft/vscode-azurefunctions/pull/612#discussion_r218876341"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/612"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/612","id":216468883,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDY4ODgz","html_url":"https://github.com/Microsoft/vscode-azurefunctions/pull/612","diff_url":"https://github.com/Microsoft/vscode-azurefunctions/pull/612.diff","patch_url":"https://github.com/Microsoft/vscode-azurefunctions/pull/612.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/612","number":612,"state":"open","locked":false,"title":"Prompt user to re-create Python venv if it doesn't exist","user":{"login":"EricJizbaMSFT","id":11282622,"node_id":"MDQ6VXNlcjExMjgyNjIy","avatar_url":"https://avatars2.githubusercontent.com/u/11282622?v=4","gravatar_id":"","url":"https://api.github.com/users/EricJizbaMSFT","html_url":"https://github.com/EricJizbaMSFT","followers_url":"https://api.github.com/users/EricJizbaMSFT/followers","following_url":"https://api.github.com/users/EricJizbaMSFT/following{/other_user}","gists_url":"https://api.github.com/users/EricJizbaMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/EricJizbaMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricJizbaMSFT/subscriptions","organizations_url":"https://api.github.com/users/EricJizbaMSFT/orgs","repos_url":"https://api.github.com/users/EricJizbaMSFT/repos","events_url":"https://api.github.com/users/EricJizbaMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/EricJizbaMSFT/received_events","type":"User","site_admin":false},"body":"If a user pushes their project to GitHub and someone else clones it, the venv won't exist on that fresh machine. Thus, we need to prompt to re-create it.\r\n\r\nFixes https://github.com/Microsoft/vscode-azurefunctions/issues/544","created_at":"2018-09-18T23:02:45Z","updated_at":"2018-09-19T16:34:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c9ab5a27573dea5bcb41caaa52d1e7f2f21b954","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/612/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/612/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/612/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/statuses/3490eb5b4749eb4f38779738f07d11b288e0d3bb","head":{"label":"Microsoft:ej/venv","ref":"ej/venv","sha":"3490eb5b4749eb4f38779738f07d11b288e0d3bb","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104400765,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ0MDA3NjU=","name":"vscode-azurefunctions","full_name":"Microsoft/vscode-azurefunctions","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/vscode-azurefunctions","description":"Azure Functions extension for VS Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions","forks_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/deployments","created_at":"2017-09-21T21:28:44Z","updated_at":"2018-09-19T15:47:01Z","pushed_at":"2018-09-19T16:22:29Z","git_url":"git://github.com/Microsoft/vscode-azurefunctions.git","ssh_url":"git@github.com:Microsoft/vscode-azurefunctions.git","clone_url":"https://github.com/Microsoft/vscode-azurefunctions.git","svn_url":"https://github.com/Microsoft/vscode-azurefunctions","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions","size":17437,"stargazers_count":69,"watchers_count":69,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":59,"watchers":69,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"f79a341b59921d6b3500b12bb5f7fc6003547f52","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":104400765,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ0MDA3NjU=","name":"vscode-azurefunctions","full_name":"Microsoft/vscode-azurefunctions","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/vscode-azurefunctions","description":"Azure Functions extension for VS Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions","forks_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/deployments","created_at":"2017-09-21T21:28:44Z","updated_at":"2018-09-19T15:47:01Z","pushed_at":"2018-09-19T16:22:29Z","git_url":"git://github.com/Microsoft/vscode-azurefunctions.git","ssh_url":"git@github.com:Microsoft/vscode-azurefunctions.git","clone_url":"https://github.com/Microsoft/vscode-azurefunctions.git","svn_url":"https://github.com/Microsoft/vscode-azurefunctions","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions","size":17437,"stargazers_count":69,"watchers_count":69,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":59,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/612"},"html":{"href":"https://github.com/Microsoft/vscode-azurefunctions/pull/612"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/612"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/issues/612/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/612/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/pulls/612/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-azurefunctions/statuses/3490eb5b4749eb4f38779738f07d11b288e0d3bb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"StephenWeatherford"}}