{"action":"created","comment":{"url":"https://api.github.com/repos/Killeroo/PowerPing/pulls/comments/236086316","pull_request_review_id":178093524,"id":236086316,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA4NjMxNg==","diff_hunk":"@@ -491,6 +510,12 @@ private PingResults SendICMP(PingAttributes attrs)\n             return Results;\n         }\n \n+        private static ushort GenerateSessionId()","path":"src/PowerPing/Ping.cs","position":128,"original_position":128,"commit_id":"d5143c656b7dc44c458fe535d8f2a62abb2cb613","original_commit_id":"d5143c656b7dc44c458fe535d8f2a62abb2cb613","user":{"login":"Killeroo","id":9999745,"node_id":"MDQ6VXNlcjk5OTk3NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/9999745?v=4","gravatar_id":"","url":"https://api.github.com/users/Killeroo","html_url":"https://github.com/Killeroo","followers_url":"https://api.github.com/users/Killeroo/followers","following_url":"https://api.github.com/users/Killeroo/following{/other_user}","gists_url":"https://api.github.com/users/Killeroo/gists{/gist_id}","starred_url":"https://api.github.com/users/Killeroo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Killeroo/subscriptions","organizations_url":"https://api.github.com/users/Killeroo/orgs","repos_url":"https://api.github.com/users/Killeroo/repos","events_url":"https://api.github.com/users/Killeroo/events{/privacy}","received_events_url":"https://api.github.com/users/Killeroo/received_events","type":"User","site_admin":false},"body":"Makes sense to move this function to Helper.cs, just because thats where most helpful functions live.","created_at":"2018-11-25T19:23:21Z","updated_at":"2018-11-25T19:34:55Z","html_url":"https://github.com/Killeroo/PowerPing/pull/100#discussion_r236086316","pull_request_url":"https://api.github.com/repos/Killeroo/PowerPing/pulls/100","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Killeroo/PowerPing/pulls/comments/236086316"},"html":{"href":"https://github.com/Killeroo/PowerPing/pull/100#discussion_r236086316"},"pull_request":{"href":"https://api.github.com/repos/Killeroo/PowerPing/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/Killeroo/PowerPing/pulls/100","id":233099430,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDk5NDMw","html_url":"https://github.com/Killeroo/PowerPing/pull/100","diff_url":"https://github.com/Killeroo/PowerPing/pull/100.diff","patch_url":"https://github.com/Killeroo/PowerPing/pull/100.patch","issue_url":"https://api.github.com/repos/Killeroo/PowerPing/issues/100","number":100,"state":"open","locked":false,"title":"Validate response packet to make sure it's the one we're expecting","user":{"login":"jdpurcell","id":6741660,"node_id":"MDQ6VXNlcjY3NDE2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6741660?v=4","gravatar_id":"","url":"https://api.github.com/users/jdpurcell","html_url":"https://github.com/jdpurcell","followers_url":"https://api.github.com/users/jdpurcell/followers","following_url":"https://api.github.com/users/jdpurcell/following{/other_user}","gists_url":"https://api.github.com/users/jdpurcell/gists{/gist_id}","starred_url":"https://api.github.com/users/jdpurcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdpurcell/subscriptions","organizations_url":"https://api.github.com/users/jdpurcell/orgs","repos_url":"https://api.github.com/users/jdpurcell/repos","events_url":"https://api.github.com/users/jdpurcell/events{/privacy}","received_events_url":"https://api.github.com/users/jdpurcell/received_events","type":"User","site_admin":false},"body":"Attempted fix for #57. I noticed RFC 792 purposes the 4 bytes after an echo message's checksum for an identifier + sequence number, so I used that pattern.\r\n\r\nI also fixed an issue where the displayed message had extra characters at the beginning sometimes.\r\n\r\nFeel free to close this if you have a better idea or don't like my coding style or whatever 😄 - I just wanted to offer this as an idea.","created_at":"2018-11-23T03:17:24Z","updated_at":"2018-11-25T19:34:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b299189e8a1dd328b77db4d7ab850034be86d949","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Killeroo/PowerPing/pulls/100/commits","review_comments_url":"https://api.github.com/repos/Killeroo/PowerPing/pulls/100/comments","review_comment_url":"https://api.github.com/repos/Killeroo/PowerPing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Killeroo/PowerPing/issues/100/comments","statuses_url":"https://api.github.com/repos/Killeroo/PowerPing/statuses/d5143c656b7dc44c458fe535d8f2a62abb2cb613","head":{"label":"jdpurcell:pr2","ref":"pr2","sha":"d5143c656b7dc44c458fe535d8f2a62abb2cb613","user":{"login":"jdpurcell","id":6741660,"node_id":"MDQ6VXNlcjY3NDE2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6741660?v=4","gravatar_id":"","url":"https://api.github.com/users/jdpurcell","html_url":"https://github.com/jdpurcell","followers_url":"https://api.github.com/users/jdpurcell/followers","following_url":"https://api.github.com/users/jdpurcell/following{/other_user}","gists_url":"https://api.github.com/users/jdpurcell/gists{/gist_id}","starred_url":"https://api.github.com/users/jdpurcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdpurcell/subscriptions","organizations_url":"https://api.github.com/users/jdpurcell/orgs","repos_url":"https://api.github.com/users/jdpurcell/repos","events_url":"https://api.github.com/users/jdpurcell/events{/privacy}","received_events_url":"https://api.github.com/users/jdpurcell/received_events","type":"User","site_admin":false},"repo":{"id":103758846,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM3NTg4NDY=","name":"PowerPing","full_name":"jdpurcell/PowerPing","private":false,"owner":{"login":"jdpurcell","id":6741660,"node_id":"MDQ6VXNlcjY3NDE2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6741660?v=4","gravatar_id":"","url":"https://api.github.com/users/jdpurcell","html_url":"https://github.com/jdpurcell","followers_url":"https://api.github.com/users/jdpurcell/followers","following_url":"https://api.github.com/users/jdpurcell/following{/other_user}","gists_url":"https://api.github.com/users/jdpurcell/gists{/gist_id}","starred_url":"https://api.github.com/users/jdpurcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdpurcell/subscriptions","organizations_url":"https://api.github.com/users/jdpurcell/orgs","repos_url":"https://api.github.com/users/jdpurcell/repos","events_url":"https://api.github.com/users/jdpurcell/events{/privacy}","received_events_url":"https://api.github.com/users/jdpurcell/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jdpurcell/PowerPing","description":"Advanced command-line ping tool","fork":true,"url":"https://api.github.com/repos/jdpurcell/PowerPing","forks_url":"https://api.github.com/repos/jdpurcell/PowerPing/forks","keys_url":"https://api.github.com/repos/jdpurcell/PowerPing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdpurcell/PowerPing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdpurcell/PowerPing/teams","hooks_url":"https://api.github.com/repos/jdpurcell/PowerPing/hooks","issue_events_url":"https://api.github.com/repos/jdpurcell/PowerPing/issues/events{/number}","events_url":"https://api.github.com/repos/jdpurcell/PowerPing/events","assignees_url":"https://api.github.com/repos/jdpurcell/PowerPing/assignees{/user}","branches_url":"https://api.github.com/repos/jdpurcell/PowerPing/branches{/branch}","tags_url":"https://api.github.com/repos/jdpurcell/PowerPing/tags","blobs_url":"https://api.github.com/repos/jdpurcell/PowerPing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdpurcell/PowerPing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdpurcell/PowerPing/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdpurcell/PowerPing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdpurcell/PowerPing/statuses/{sha}","languages_url":"https://api.github.com/repos/jdpurcell/PowerPing/languages","stargazers_url":"https://api.github.com/repos/jdpurcell/PowerPing/stargazers","contributors_url":"https://api.github.com/repos/jdpurcell/PowerPing/contributors","subscribers_url":"https://api.github.com/repos/jdpurcell/PowerPing/subscribers","subscription_url":"https://api.github.com/repos/jdpurcell/PowerPing/subscription","commits_url":"https://api.github.com/repos/jdpurcell/PowerPing/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdpurcell/PowerPing/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdpurcell/PowerPing/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdpurcell/PowerPing/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdpurcell/PowerPing/contents/{+path}","compare_url":"https://api.github.com/repos/jdpurcell/PowerPing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdpurcell/PowerPing/merges","archive_url":"https://api.github.com/repos/jdpurcell/PowerPing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdpurcell/PowerPing/downloads","issues_url":"https://api.github.com/repos/jdpurcell/PowerPing/issues{/number}","pulls_url":"https://api.github.com/repos/jdpurcell/PowerPing/pulls{/number}","milestones_url":"https://api.github.com/repos/jdpurcell/PowerPing/milestones{/number}","notifications_url":"https://api.github.com/repos/jdpurcell/PowerPing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdpurcell/PowerPing/labels{/name}","releases_url":"https://api.github.com/repos/jdpurcell/PowerPing/releases{/id}","deployments_url":"https://api.github.com/repos/jdpurcell/PowerPing/deployments","created_at":"2017-09-16T14:37:17Z","updated_at":"2018-11-25T17:54:48Z","pushed_at":"2018-11-25T18:43:15Z","git_url":"git://github.com/jdpurcell/PowerPing.git","ssh_url":"git@github.com:jdpurcell/PowerPing.git","clone_url":"https://github.com/jdpurcell/PowerPing.git","svn_url":"https://github.com/jdpurcell/PowerPing","homepage":"","size":1671,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Killeroo:master","ref":"master","sha":"21c5ef38e56cad09aae926e8890442820d3b8dde","user":{"login":"Killeroo","id":9999745,"node_id":"MDQ6VXNlcjk5OTk3NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/9999745?v=4","gravatar_id":"","url":"https://api.github.com/users/Killeroo","html_url":"https://github.com/Killeroo","followers_url":"https://api.github.com/users/Killeroo/followers","following_url":"https://api.github.com/users/Killeroo/following{/other_user}","gists_url":"https://api.github.com/users/Killeroo/gists{/gist_id}","starred_url":"https://api.github.com/users/Killeroo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Killeroo/subscriptions","organizations_url":"https://api.github.com/users/Killeroo/orgs","repos_url":"https://api.github.com/users/Killeroo/repos","events_url":"https://api.github.com/users/Killeroo/events{/privacy}","received_events_url":"https://api.github.com/users/Killeroo/received_events","type":"User","site_admin":false},"repo":{"id":73220433,"node_id":"MDEwOlJlcG9zaXRvcnk3MzIyMDQzMw==","name":"PowerPing","full_name":"Killeroo/PowerPing","private":false,"owner":{"login":"Killeroo","id":9999745,"node_id":"MDQ6VXNlcjk5OTk3NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/9999745?v=4","gravatar_id":"","url":"https://api.github.com/users/Killeroo","html_url":"https://github.com/Killeroo","followers_url":"https://api.github.com/users/Killeroo/followers","following_url":"https://api.github.com/users/Killeroo/following{/other_user}","gists_url":"https://api.github.com/users/Killeroo/gists{/gist_id}","starred_url":"https://api.github.com/users/Killeroo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Killeroo/subscriptions","organizations_url":"https://api.github.com/users/Killeroo/orgs","repos_url":"https://api.github.com/users/Killeroo/repos","events_url":"https://api.github.com/users/Killeroo/events{/privacy}","received_events_url":"https://api.github.com/users/Killeroo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Killeroo/PowerPing","description":"Advanced command-line ping tool","fork":false,"url":"https://api.github.com/repos/Killeroo/PowerPing","forks_url":"https://api.github.com/repos/Killeroo/PowerPing/forks","keys_url":"https://api.github.com/repos/Killeroo/PowerPing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Killeroo/PowerPing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Killeroo/PowerPing/teams","hooks_url":"https://api.github.com/repos/Killeroo/PowerPing/hooks","issue_events_url":"https://api.github.com/repos/Killeroo/PowerPing/issues/events{/number}","events_url":"https://api.github.com/repos/Killeroo/PowerPing/events","assignees_url":"https://api.github.com/repos/Killeroo/PowerPing/assignees{/user}","branches_url":"https://api.github.com/repos/Killeroo/PowerPing/branches{/branch}","tags_url":"https://api.github.com/repos/Killeroo/PowerPing/tags","blobs_url":"https://api.github.com/repos/Killeroo/PowerPing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Killeroo/PowerPing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Killeroo/PowerPing/git/refs{/sha}","trees_url":"https://api.github.com/repos/Killeroo/PowerPing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Killeroo/PowerPing/statuses/{sha}","languages_url":"https://api.github.com/repos/Killeroo/PowerPing/languages","stargazers_url":"https://api.github.com/repos/Killeroo/PowerPing/stargazers","contributors_url":"https://api.github.com/repos/Killeroo/PowerPing/contributors","subscribers_url":"https://api.github.com/repos/Killeroo/PowerPing/subscribers","subscription_url":"https://api.github.com/repos/Killeroo/PowerPing/subscription","commits_url":"https://api.github.com/repos/Killeroo/PowerPing/commits{/sha}","git_commits_url":"https://api.github.com/repos/Killeroo/PowerPing/git/commits{/sha}","comments_url":"https://api.github.com/repos/Killeroo/PowerPing/comments{/number}","issue_comment_url":"https://api.github.com/repos/Killeroo/PowerPing/issues/comments{/number}","contents_url":"https://api.github.com/repos/Killeroo/PowerPing/contents/{+path}","compare_url":"https://api.github.com/repos/Killeroo/PowerPing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Killeroo/PowerPing/merges","archive_url":"https://api.github.com/repos/Killeroo/PowerPing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Killeroo/PowerPing/downloads","issues_url":"https://api.github.com/repos/Killeroo/PowerPing/issues{/number}","pulls_url":"https://api.github.com/repos/Killeroo/PowerPing/pulls{/number}","milestones_url":"https://api.github.com/repos/Killeroo/PowerPing/milestones{/number}","notifications_url":"https://api.github.com/repos/Killeroo/PowerPing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Killeroo/PowerPing/labels{/name}","releases_url":"https://api.github.com/repos/Killeroo/PowerPing/releases{/id}","deployments_url":"https://api.github.com/repos/Killeroo/PowerPing/deployments","created_at":"2016-11-08T19:35:59Z","updated_at":"2018-11-25T12:25:37Z","pushed_at":"2018-11-25T18:12:43Z","git_url":"git://github.com/Killeroo/PowerPing.git","ssh_url":"git@github.com:Killeroo/PowerPing.git","clone_url":"https://github.com/Killeroo/PowerPing.git","svn_url":"https://github.com/Killeroo/PowerPing","homepage":"","size":1658,"stargazers_count":18,"watchers_count":18,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":17,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Killeroo/PowerPing/pulls/100"},"html":{"href":"https://github.com/Killeroo/PowerPing/pull/100"},"issue":{"href":"https://api.github.com/repos/Killeroo/PowerPing/issues/100"},"comments":{"href":"https://api.github.com/repos/Killeroo/PowerPing/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/Killeroo/PowerPing/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/Killeroo/PowerPing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Killeroo/PowerPing/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/Killeroo/PowerPing/statuses/d5143c656b7dc44c458fe535d8f2a62abb2cb613"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Killeroo"}}