{"action":"created","comment":{"url":"https://api.github.com/repos/slide-rs/shred/pulls/comments/169393553","pull_request_review_id":97912450,"id":169393553,"diff_hunk":"@@ -39,7 +39,7 @@ impl<'a> System<'a> for PrintSystem {\n         println!(\"{:?}\", &*b);\n \n         *b = ResB; // We can mutate ResB here\n-        // because it's `FetchMut`.\n+                   // because it's `FetchMut`.","path":"examples/async.rs","position":18,"original_position":18,"commit_id":"7e94e4af808a86859d098b73d27e946d518097dd","original_commit_id":"7e94e4af808a86859d098b73d27e946d518097dd","user":{"login":"kvark","id":107301,"avatar_url":"https://avatars1.githubusercontent.com/u/107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"body":"indentation","created_at":"2018-02-20T17:17:49Z","updated_at":"2018-02-20T17:31:23Z","html_url":"https://github.com/slide-rs/shred/pull/77#discussion_r169393553","pull_request_url":"https://api.github.com/repos/slide-rs/shred/pulls/77","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/slide-rs/shred/pulls/comments/169393553"},"html":{"href":"https://github.com/slide-rs/shred/pull/77#discussion_r169393553"},"pull_request":{"href":"https://api.github.com/repos/slide-rs/shred/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/slide-rs/shred/pulls/77","id":169787665,"html_url":"https://github.com/slide-rs/shred/pull/77","diff_url":"https://github.com/slide-rs/shred/pull/77.diff","patch_url":"https://github.com/slide-rs/shred/pull/77.patch","issue_url":"https://api.github.com/repos/slide-rs/shred/issues/77","number":77,"state":"open","locked":false,"title":"Solve the \"resource not found\" problem","user":{"login":"torkleyy","id":23152057,"avatar_url":"https://avatars1.githubusercontent.com/u/23152057?v=4","gravatar_id":"","url":"https://api.github.com/users/torkleyy","html_url":"https://github.com/torkleyy","followers_url":"https://api.github.com/users/torkleyy/followers","following_url":"https://api.github.com/users/torkleyy/following{/other_user}","gists_url":"https://api.github.com/users/torkleyy/gists{/gist_id}","starred_url":"https://api.github.com/users/torkleyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkleyy/subscriptions","organizations_url":"https://api.github.com/users/torkleyy/orgs","repos_url":"https://api.github.com/users/torkleyy/repos","events_url":"https://api.github.com/users/torkleyy/events{/privacy}","received_events_url":"https://api.github.com/users/torkleyy/received_events","type":"User","site_admin":false},"body":"In the past, many users had difficulties with panics just saying \"No resource with the given id\". This is neither beginner friendly, nor a good way to handle the error.\r\n\r\nThe default behavior has been changed to adding the missing resource automatically. For this, a `Default` implementation needs to be in place.\r\n\r\nIn case a resource does not have a `Default` implementation, it's recommended that one uses `Option<Fetch>` and checks whether the resource exists or not. If the system cannot work without the resource, it should simply `return`.\r\n\r\nIn case the resource is absolutely required and the user is sure it exists, they can use `FetchExpect`. It is pretty much like `Fetch` was before, but now the panic message has been improved and there's a `nightly` feature that also prints the type name of the missing resource.\r\n\r\nThe overall goal is to make `shred` more robust, easier to debug and beginner-friendly.","created_at":"2018-02-17T15:23:55Z","updated_at":"2018-02-20T17:31:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85308d9b939bbe89be2daf5ef15f7a58f0389105","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":594622958,"url":"https://api.github.com/repos/slide-rs/shred/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/slide-rs/shred/pulls/77/commits","review_comments_url":"https://api.github.com/repos/slide-rs/shred/pulls/77/comments","review_comment_url":"https://api.github.com/repos/slide-rs/shred/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slide-rs/shred/issues/77/comments","statuses_url":"https://api.github.com/repos/slide-rs/shred/statuses/7e94e4af808a86859d098b73d27e946d518097dd","head":{"label":"torkleyy:nopanic","ref":"nopanic","sha":"7e94e4af808a86859d098b73d27e946d518097dd","user":{"login":"torkleyy","id":23152057,"avatar_url":"https://avatars1.githubusercontent.com/u/23152057?v=4","gravatar_id":"","url":"https://api.github.com/users/torkleyy","html_url":"https://github.com/torkleyy","followers_url":"https://api.github.com/users/torkleyy/followers","following_url":"https://api.github.com/users/torkleyy/following{/other_user}","gists_url":"https://api.github.com/users/torkleyy/gists{/gist_id}","starred_url":"https://api.github.com/users/torkleyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkleyy/subscriptions","organizations_url":"https://api.github.com/users/torkleyy/orgs","repos_url":"https://api.github.com/users/torkleyy/repos","events_url":"https://api.github.com/users/torkleyy/events{/privacy}","received_events_url":"https://api.github.com/users/torkleyy/received_events","type":"User","site_admin":false},"repo":{"id":93198621,"name":"shred","full_name":"torkleyy/shred","owner":{"login":"torkleyy","id":23152057,"avatar_url":"https://avatars1.githubusercontent.com/u/23152057?v=4","gravatar_id":"","url":"https://api.github.com/users/torkleyy","html_url":"https://github.com/torkleyy","followers_url":"https://api.github.com/users/torkleyy/followers","following_url":"https://api.github.com/users/torkleyy/following{/other_user}","gists_url":"https://api.github.com/users/torkleyy/gists{/gist_id}","starred_url":"https://api.github.com/users/torkleyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkleyy/subscriptions","organizations_url":"https://api.github.com/users/torkleyy/orgs","repos_url":"https://api.github.com/users/torkleyy/repos","events_url":"https://api.github.com/users/torkleyy/events{/privacy}","received_events_url":"https://api.github.com/users/torkleyy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/torkleyy/shred","description":"Shared resource dispatcher","fork":true,"url":"https://api.github.com/repos/torkleyy/shred","forks_url":"https://api.github.com/repos/torkleyy/shred/forks","keys_url":"https://api.github.com/repos/torkleyy/shred/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torkleyy/shred/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torkleyy/shred/teams","hooks_url":"https://api.github.com/repos/torkleyy/shred/hooks","issue_events_url":"https://api.github.com/repos/torkleyy/shred/issues/events{/number}","events_url":"https://api.github.com/repos/torkleyy/shred/events","assignees_url":"https://api.github.com/repos/torkleyy/shred/assignees{/user}","branches_url":"https://api.github.com/repos/torkleyy/shred/branches{/branch}","tags_url":"https://api.github.com/repos/torkleyy/shred/tags","blobs_url":"https://api.github.com/repos/torkleyy/shred/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torkleyy/shred/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torkleyy/shred/git/refs{/sha}","trees_url":"https://api.github.com/repos/torkleyy/shred/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torkleyy/shred/statuses/{sha}","languages_url":"https://api.github.com/repos/torkleyy/shred/languages","stargazers_url":"https://api.github.com/repos/torkleyy/shred/stargazers","contributors_url":"https://api.github.com/repos/torkleyy/shred/contributors","subscribers_url":"https://api.github.com/repos/torkleyy/shred/subscribers","subscription_url":"https://api.github.com/repos/torkleyy/shred/subscription","commits_url":"https://api.github.com/repos/torkleyy/shred/commits{/sha}","git_commits_url":"https://api.github.com/repos/torkleyy/shred/git/commits{/sha}","comments_url":"https://api.github.com/repos/torkleyy/shred/comments{/number}","issue_comment_url":"https://api.github.com/repos/torkleyy/shred/issues/comments{/number}","contents_url":"https://api.github.com/repos/torkleyy/shred/contents/{+path}","compare_url":"https://api.github.com/repos/torkleyy/shred/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torkleyy/shred/merges","archive_url":"https://api.github.com/repos/torkleyy/shred/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torkleyy/shred/downloads","issues_url":"https://api.github.com/repos/torkleyy/shred/issues{/number}","pulls_url":"https://api.github.com/repos/torkleyy/shred/pulls{/number}","milestones_url":"https://api.github.com/repos/torkleyy/shred/milestones{/number}","notifications_url":"https://api.github.com/repos/torkleyy/shred/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torkleyy/shred/labels{/name}","releases_url":"https://api.github.com/repos/torkleyy/shred/releases{/id}","deployments_url":"https://api.github.com/repos/torkleyy/shred/deployments","created_at":"2017-06-02T19:44:12Z","updated_at":"2017-06-02T19:44:14Z","pushed_at":"2018-02-18T13:05:57Z","git_url":"git://github.com/torkleyy/shred.git","ssh_url":"git@github.com:torkleyy/shred.git","clone_url":"https://github.com/torkleyy/shred.git","svn_url":"https://github.com/torkleyy/shred","homepage":"","size":194,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slide-rs:master","ref":"master","sha":"e014fda97de395bb338f35ef4824de2517e6da7c","user":{"login":"slide-rs","id":12649318,"avatar_url":"https://avatars3.githubusercontent.com/u/12649318?v=4","gravatar_id":"","url":"https://api.github.com/users/slide-rs","html_url":"https://github.com/slide-rs","followers_url":"https://api.github.com/users/slide-rs/followers","following_url":"https://api.github.com/users/slide-rs/following{/other_user}","gists_url":"https://api.github.com/users/slide-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/slide-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slide-rs/subscriptions","organizations_url":"https://api.github.com/users/slide-rs/orgs","repos_url":"https://api.github.com/users/slide-rs/repos","events_url":"https://api.github.com/users/slide-rs/events{/privacy}","received_events_url":"https://api.github.com/users/slide-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":89796787,"name":"shred","full_name":"slide-rs/shred","owner":{"login":"slide-rs","id":12649318,"avatar_url":"https://avatars3.githubusercontent.com/u/12649318?v=4","gravatar_id":"","url":"https://api.github.com/users/slide-rs","html_url":"https://github.com/slide-rs","followers_url":"https://api.github.com/users/slide-rs/followers","following_url":"https://api.github.com/users/slide-rs/following{/other_user}","gists_url":"https://api.github.com/users/slide-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/slide-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slide-rs/subscriptions","organizations_url":"https://api.github.com/users/slide-rs/orgs","repos_url":"https://api.github.com/users/slide-rs/repos","events_url":"https://api.github.com/users/slide-rs/events{/privacy}","received_events_url":"https://api.github.com/users/slide-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slide-rs/shred","description":"Shared resource dispatcher","fork":false,"url":"https://api.github.com/repos/slide-rs/shred","forks_url":"https://api.github.com/repos/slide-rs/shred/forks","keys_url":"https://api.github.com/repos/slide-rs/shred/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slide-rs/shred/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slide-rs/shred/teams","hooks_url":"https://api.github.com/repos/slide-rs/shred/hooks","issue_events_url":"https://api.github.com/repos/slide-rs/shred/issues/events{/number}","events_url":"https://api.github.com/repos/slide-rs/shred/events","assignees_url":"https://api.github.com/repos/slide-rs/shred/assignees{/user}","branches_url":"https://api.github.com/repos/slide-rs/shred/branches{/branch}","tags_url":"https://api.github.com/repos/slide-rs/shred/tags","blobs_url":"https://api.github.com/repos/slide-rs/shred/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slide-rs/shred/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slide-rs/shred/git/refs{/sha}","trees_url":"https://api.github.com/repos/slide-rs/shred/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slide-rs/shred/statuses/{sha}","languages_url":"https://api.github.com/repos/slide-rs/shred/languages","stargazers_url":"https://api.github.com/repos/slide-rs/shred/stargazers","contributors_url":"https://api.github.com/repos/slide-rs/shred/contributors","subscribers_url":"https://api.github.com/repos/slide-rs/shred/subscribers","subscription_url":"https://api.github.com/repos/slide-rs/shred/subscription","commits_url":"https://api.github.com/repos/slide-rs/shred/commits{/sha}","git_commits_url":"https://api.github.com/repos/slide-rs/shred/git/commits{/sha}","comments_url":"https://api.github.com/repos/slide-rs/shred/comments{/number}","issue_comment_url":"https://api.github.com/repos/slide-rs/shred/issues/comments{/number}","contents_url":"https://api.github.com/repos/slide-rs/shred/contents/{+path}","compare_url":"https://api.github.com/repos/slide-rs/shred/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slide-rs/shred/merges","archive_url":"https://api.github.com/repos/slide-rs/shred/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slide-rs/shred/downloads","issues_url":"https://api.github.com/repos/slide-rs/shred/issues{/number}","pulls_url":"https://api.github.com/repos/slide-rs/shred/pulls{/number}","milestones_url":"https://api.github.com/repos/slide-rs/shred/milestones{/number}","notifications_url":"https://api.github.com/repos/slide-rs/shred/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slide-rs/shred/labels{/name}","releases_url":"https://api.github.com/repos/slide-rs/shred/releases{/id}","deployments_url":"https://api.github.com/repos/slide-rs/shred/deployments","created_at":"2017-04-29T16:11:02Z","updated_at":"2018-02-16T21:31:26Z","pushed_at":"2018-02-18T13:05:58Z","git_url":"git://github.com/slide-rs/shred.git","ssh_url":"git@github.com:slide-rs/shred.git","clone_url":"https://github.com/slide-rs/shred.git","svn_url":"https://github.com/slide-rs/shred","homepage":"","size":172,"stargazers_count":41,"watchers_count":41,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11,"open_issues":1,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slide-rs/shred/pulls/77"},"html":{"href":"https://github.com/slide-rs/shred/pull/77"},"issue":{"href":"https://api.github.com/repos/slide-rs/shred/issues/77"},"comments":{"href":"https://api.github.com/repos/slide-rs/shred/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/slide-rs/shred/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/slide-rs/shred/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slide-rs/shred/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/slide-rs/shred/statuses/7e94e4af808a86859d098b73d27e946d518097dd"}},"author_association":"OWNER"}}
{"actor":{"display_login":"kvark"}}