{"action":"created","issue":{"url":"https://api.github.com/repos/pereorga/minimalist-web-notepad/issues/27","repository_url":"https://api.github.com/repos/pereorga/minimalist-web-notepad","labels_url":"https://api.github.com/repos/pereorga/minimalist-web-notepad/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/pereorga/minimalist-web-notepad/issues/27/comments","events_url":"https://api.github.com/repos/pereorga/minimalist-web-notepad/issues/27/events","html_url":"https://github.com/pereorga/minimalist-web-notepad/pull/27","id":339152828,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTAwOTkw","number":27,"title":"Slightly improved comments","user":{"login":"qex","id":7080702,"node_id":"MDQ6VXNlcjcwODA3MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/7080702?v=4","gravatar_id":"","url":"https://api.github.com/users/qex","html_url":"https://github.com/qex","followers_url":"https://api.github.com/users/qex/followers","following_url":"https://api.github.com/users/qex/following{/other_user}","gists_url":"https://api.github.com/users/qex/gists{/gist_id}","starred_url":"https://api.github.com/users/qex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qex/subscriptions","organizations_url":"https://api.github.com/users/qex/orgs","repos_url":"https://api.github.com/users/qex/repos","events_url":"https://api.github.com/users/qex/events{/privacy}","received_events_url":"https://api.github.com/users/qex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-07T15:10:46Z","updated_at":"2018-07-07T17:52:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pereorga/minimalist-web-notepad/pulls/27","html_url":"https://github.com/pereorga/minimalist-web-notepad/pull/27","diff_url":"https://github.com/pereorga/minimalist-web-notepad/pull/27.diff","patch_url":"https://github.com/pereorga/minimalist-web-notepad/pull/27.patch"},"body":"I'm kinda like these comment, should we add them back?"},"comment":{"url":"https://api.github.com/repos/pereorga/minimalist-web-notepad/issues/comments/403232658","html_url":"https://github.com/pereorga/minimalist-web-notepad/pull/27#issuecomment-403232658","issue_url":"https://api.github.com/repos/pereorga/minimalist-web-notepad/issues/27","id":403232658,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzIzMjY1OA==","user":{"login":"pereorga","id":919779,"node_id":"MDQ6VXNlcjkxOTc3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/919779?v=4","gravatar_id":"","url":"https://api.github.com/users/pereorga","html_url":"https://github.com/pereorga","followers_url":"https://api.github.com/users/pereorga/followers","following_url":"https://api.github.com/users/pereorga/following{/other_user}","gists_url":"https://api.github.com/users/pereorga/gists{/gist_id}","starred_url":"https://api.github.com/users/pereorga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pereorga/subscriptions","organizations_url":"https://api.github.com/users/pereorga/orgs","repos_url":"https://api.github.com/users/pereorga/repos","events_url":"https://api.github.com/users/pereorga/events{/privacy}","received_events_url":"https://api.github.com/users/pereorga/received_events","type":"User","site_admin":false},"created_at":"2018-07-07T17:52:13Z","updated_at":"2018-07-07T17:52:13Z","author_association":"OWNER","body":"I thought it was ok to leave it without that comment, the code already speaks here. But could be merged too, both options would be OK IMO.\r\n\r\nRegarding the isset() micro-optimization, I don't think it's worth it. I like micro-optimizations when they make the code cleaner, or when they are inside code that runs often (i.e. thousands of times per second).\r\n\r\nIf if it was about readability, that could better that the current one, but more verbose:\r\n\r\n```\r\nif (str_len($_POST['t']) > 0) {\r\n...\r\n```\r\n\r\nI think it's ok how it is done now, but that's again subjective.\r\n\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"pereorga"}}