{"action":"created","comment":{"url":"https://api.github.com/repos/mesg-foundation/core/pulls/comments/237431587","pull_request_review_id":179725251,"id":237431587,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzQzMTU4Nw==","diff_hunk":"@@ -157,9 +157,23 @@ message ListenResultRequest {\n message ResultData {\n   string executionID = 1;             // The unique identifier of the execution.\n   string taskKey = 2;                 // The key of the executed task.\n-  string outputKey = 3;               // The output's key from the returned task.\n-  string outputData = 4;              // The output's data from the returned task, encoded in JSON.\n   repeated string executionTags = 5;  // The list of tags associated with the execution\n+  oneof result {\n+    Output output = 6;   // output is filled when there is matching task execution that completed successfully.\n+    Error error = 7;     // error is filled when there is a matching task execution that cannot be completed. \n+  }\n+\n+  message Output {\n+    string key = 3;   // The output's key from the returned task.\n+    string data = 4;  // The output's data from the returned task, encoded in JSON.\n+  }\n+  \n+  message Error {\n+    string message = 1;","path":"protobuf/coreapi/api.proto","position":18,"original_position":18,"commit_id":"57f0dfc635e0d7f2d9e6ead1ccf4bfdc9ec62fbc","original_commit_id":"57f0dfc635e0d7f2d9e6ead1ccf4bfdc9ec62fbc","user":{"login":"NicolasMahe","id":5823445,"node_id":"MDQ6VXNlcjU4MjM0NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5823445?v=4","gravatar_id":"","url":"https://api.github.com/users/NicolasMahe","html_url":"https://github.com/NicolasMahe","followers_url":"https://api.github.com/users/NicolasMahe/followers","following_url":"https://api.github.com/users/NicolasMahe/following{/other_user}","gists_url":"https://api.github.com/users/NicolasMahe/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasMahe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasMahe/subscriptions","organizations_url":"https://api.github.com/users/NicolasMahe/orgs","repos_url":"https://api.github.com/users/NicolasMahe/repos","events_url":"https://api.github.com/users/NicolasMahe/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasMahe/received_events","type":"User","site_admin":false},"body":"are you sure that using number '1' is ok? isn't override `executionID`?\r\nBut I'm not sure how grpc 'message' works.","created_at":"2018-11-29T10:34:25Z","updated_at":"2018-11-29T10:35:33Z","html_url":"https://github.com/mesg-foundation/core/pull/596#discussion_r237431587","pull_request_url":"https://api.github.com/repos/mesg-foundation/core/pulls/596","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mesg-foundation/core/pulls/comments/237431587"},"html":{"href":"https://github.com/mesg-foundation/core/pull/596#discussion_r237431587"},"pull_request":{"href":"https://api.github.com/repos/mesg-foundation/core/pulls/596"}}},"pull_request":{"url":"https://api.github.com/repos/mesg-foundation/core/pulls/596","id":234193428,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MTkzNDI4","html_url":"https://github.com/mesg-foundation/core/pull/596","diff_url":"https://github.com/mesg-foundation/core/pull/596.diff","patch_url":"https://github.com/mesg-foundation/core/pull/596.patch","issue_url":"https://api.github.com/repos/mesg-foundation/core/issues/596","number":596,"state":"open","locked":false,"title":"possibility to have errors in result data","user":{"login":"ilgooz","id":6023117,"node_id":"MDQ6VXNlcjYwMjMxMTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6023117?v=4","gravatar_id":"","url":"https://api.github.com/users/ilgooz","html_url":"https://github.com/ilgooz","followers_url":"https://api.github.com/users/ilgooz/followers","following_url":"https://api.github.com/users/ilgooz/following{/other_user}","gists_url":"https://api.github.com/users/ilgooz/gists{/gist_id}","starred_url":"https://api.github.com/users/ilgooz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilgooz/subscriptions","organizations_url":"https://api.github.com/users/ilgooz/orgs","repos_url":"https://api.github.com/users/ilgooz/repos","events_url":"https://api.github.com/users/ilgooz/events{/privacy}","received_events_url":"https://api.github.com/users/ilgooz/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-28T08:53:35Z","updated_at":"2018-11-29T10:35:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5efd81f15a6a119add4a3df44fba33ef433c5587","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesg-foundation/core/pulls/596/commits","review_comments_url":"https://api.github.com/repos/mesg-foundation/core/pulls/596/comments","review_comment_url":"https://api.github.com/repos/mesg-foundation/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesg-foundation/core/issues/596/comments","statuses_url":"https://api.github.com/repos/mesg-foundation/core/statuses/57f0dfc635e0d7f2d9e6ead1ccf4bfdc9ec62fbc","head":{"label":"mesg-foundation:feature/resultdata-with-error","ref":"feature/resultdata-with-error","sha":"57f0dfc635e0d7f2d9e6ead1ccf4bfdc9ec62fbc","user":{"login":"mesg-foundation","id":34158802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTU4ODAy","avatar_url":"https://avatars1.githubusercontent.com/u/34158802?v=4","gravatar_id":"","url":"https://api.github.com/users/mesg-foundation","html_url":"https://github.com/mesg-foundation","followers_url":"https://api.github.com/users/mesg-foundation/followers","following_url":"https://api.github.com/users/mesg-foundation/following{/other_user}","gists_url":"https://api.github.com/users/mesg-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/mesg-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesg-foundation/subscriptions","organizations_url":"https://api.github.com/users/mesg-foundation/orgs","repos_url":"https://api.github.com/users/mesg-foundation/repos","events_url":"https://api.github.com/users/mesg-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/mesg-foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":121732267,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3MzIyNjc=","name":"core","full_name":"mesg-foundation/core","private":false,"owner":{"login":"mesg-foundation","id":34158802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTU4ODAy","avatar_url":"https://avatars1.githubusercontent.com/u/34158802?v=4","gravatar_id":"","url":"https://api.github.com/users/mesg-foundation","html_url":"https://github.com/mesg-foundation","followers_url":"https://api.github.com/users/mesg-foundation/followers","following_url":"https://api.github.com/users/mesg-foundation/following{/other_user}","gists_url":"https://api.github.com/users/mesg-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/mesg-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesg-foundation/subscriptions","organizations_url":"https://api.github.com/users/mesg-foundation/orgs","repos_url":"https://api.github.com/users/mesg-foundation/repos","events_url":"https://api.github.com/users/mesg-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/mesg-foundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesg-foundation/core","description":"MESG is an open-source decentralized infrastructure which makes all technologies, including blockchains, interoperable. It’s a building platform for developers.","fork":false,"url":"https://api.github.com/repos/mesg-foundation/core","forks_url":"https://api.github.com/repos/mesg-foundation/core/forks","keys_url":"https://api.github.com/repos/mesg-foundation/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesg-foundation/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesg-foundation/core/teams","hooks_url":"https://api.github.com/repos/mesg-foundation/core/hooks","issue_events_url":"https://api.github.com/repos/mesg-foundation/core/issues/events{/number}","events_url":"https://api.github.com/repos/mesg-foundation/core/events","assignees_url":"https://api.github.com/repos/mesg-foundation/core/assignees{/user}","branches_url":"https://api.github.com/repos/mesg-foundation/core/branches{/branch}","tags_url":"https://api.github.com/repos/mesg-foundation/core/tags","blobs_url":"https://api.github.com/repos/mesg-foundation/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesg-foundation/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesg-foundation/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesg-foundation/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesg-foundation/core/statuses/{sha}","languages_url":"https://api.github.com/repos/mesg-foundation/core/languages","stargazers_url":"https://api.github.com/repos/mesg-foundation/core/stargazers","contributors_url":"https://api.github.com/repos/mesg-foundation/core/contributors","subscribers_url":"https://api.github.com/repos/mesg-foundation/core/subscribers","subscription_url":"https://api.github.com/repos/mesg-foundation/core/subscription","commits_url":"https://api.github.com/repos/mesg-foundation/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesg-foundation/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesg-foundation/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesg-foundation/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesg-foundation/core/contents/{+path}","compare_url":"https://api.github.com/repos/mesg-foundation/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesg-foundation/core/merges","archive_url":"https://api.github.com/repos/mesg-foundation/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesg-foundation/core/downloads","issues_url":"https://api.github.com/repos/mesg-foundation/core/issues{/number}","pulls_url":"https://api.github.com/repos/mesg-foundation/core/pulls{/number}","milestones_url":"https://api.github.com/repos/mesg-foundation/core/milestones{/number}","notifications_url":"https://api.github.com/repos/mesg-foundation/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesg-foundation/core/labels{/name}","releases_url":"https://api.github.com/repos/mesg-foundation/core/releases{/id}","deployments_url":"https://api.github.com/repos/mesg-foundation/core/deployments","created_at":"2018-02-16T09:13:42Z","updated_at":"2018-11-29T10:22:30Z","pushed_at":"2018-11-29T10:33:34Z","git_url":"git://github.com/mesg-foundation/core.git","ssh_url":"git@github.com:mesg-foundation/core.git","clone_url":"https://github.com/mesg-foundation/core.git","svn_url":"https://github.com/mesg-foundation/core","homepage":"https://mesg.com/","size":22356,"stargazers_count":41,"watchers_count":41,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":65,"watchers":41,"default_branch":"dev"}},"base":{"label":"mesg-foundation:dev","ref":"dev","sha":"fcea30b78145f1b27a3979555418560745a8186f","user":{"login":"mesg-foundation","id":34158802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTU4ODAy","avatar_url":"https://avatars1.githubusercontent.com/u/34158802?v=4","gravatar_id":"","url":"https://api.github.com/users/mesg-foundation","html_url":"https://github.com/mesg-foundation","followers_url":"https://api.github.com/users/mesg-foundation/followers","following_url":"https://api.github.com/users/mesg-foundation/following{/other_user}","gists_url":"https://api.github.com/users/mesg-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/mesg-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesg-foundation/subscriptions","organizations_url":"https://api.github.com/users/mesg-foundation/orgs","repos_url":"https://api.github.com/users/mesg-foundation/repos","events_url":"https://api.github.com/users/mesg-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/mesg-foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":121732267,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3MzIyNjc=","name":"core","full_name":"mesg-foundation/core","private":false,"owner":{"login":"mesg-foundation","id":34158802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTU4ODAy","avatar_url":"https://avatars1.githubusercontent.com/u/34158802?v=4","gravatar_id":"","url":"https://api.github.com/users/mesg-foundation","html_url":"https://github.com/mesg-foundation","followers_url":"https://api.github.com/users/mesg-foundation/followers","following_url":"https://api.github.com/users/mesg-foundation/following{/other_user}","gists_url":"https://api.github.com/users/mesg-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/mesg-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesg-foundation/subscriptions","organizations_url":"https://api.github.com/users/mesg-foundation/orgs","repos_url":"https://api.github.com/users/mesg-foundation/repos","events_url":"https://api.github.com/users/mesg-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/mesg-foundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesg-foundation/core","description":"MESG is an open-source decentralized infrastructure which makes all technologies, including blockchains, interoperable. It’s a building platform for developers.","fork":false,"url":"https://api.github.com/repos/mesg-foundation/core","forks_url":"https://api.github.com/repos/mesg-foundation/core/forks","keys_url":"https://api.github.com/repos/mesg-foundation/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesg-foundation/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesg-foundation/core/teams","hooks_url":"https://api.github.com/repos/mesg-foundation/core/hooks","issue_events_url":"https://api.github.com/repos/mesg-foundation/core/issues/events{/number}","events_url":"https://api.github.com/repos/mesg-foundation/core/events","assignees_url":"https://api.github.com/repos/mesg-foundation/core/assignees{/user}","branches_url":"https://api.github.com/repos/mesg-foundation/core/branches{/branch}","tags_url":"https://api.github.com/repos/mesg-foundation/core/tags","blobs_url":"https://api.github.com/repos/mesg-foundation/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesg-foundation/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesg-foundation/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesg-foundation/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesg-foundation/core/statuses/{sha}","languages_url":"https://api.github.com/repos/mesg-foundation/core/languages","stargazers_url":"https://api.github.com/repos/mesg-foundation/core/stargazers","contributors_url":"https://api.github.com/repos/mesg-foundation/core/contributors","subscribers_url":"https://api.github.com/repos/mesg-foundation/core/subscribers","subscription_url":"https://api.github.com/repos/mesg-foundation/core/subscription","commits_url":"https://api.github.com/repos/mesg-foundation/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesg-foundation/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesg-foundation/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesg-foundation/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesg-foundation/core/contents/{+path}","compare_url":"https://api.github.com/repos/mesg-foundation/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesg-foundation/core/merges","archive_url":"https://api.github.com/repos/mesg-foundation/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesg-foundation/core/downloads","issues_url":"https://api.github.com/repos/mesg-foundation/core/issues{/number}","pulls_url":"https://api.github.com/repos/mesg-foundation/core/pulls{/number}","milestones_url":"https://api.github.com/repos/mesg-foundation/core/milestones{/number}","notifications_url":"https://api.github.com/repos/mesg-foundation/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesg-foundation/core/labels{/name}","releases_url":"https://api.github.com/repos/mesg-foundation/core/releases{/id}","deployments_url":"https://api.github.com/repos/mesg-foundation/core/deployments","created_at":"2018-02-16T09:13:42Z","updated_at":"2018-11-29T10:22:30Z","pushed_at":"2018-11-29T10:33:34Z","git_url":"git://github.com/mesg-foundation/core.git","ssh_url":"git@github.com:mesg-foundation/core.git","clone_url":"https://github.com/mesg-foundation/core.git","svn_url":"https://github.com/mesg-foundation/core","homepage":"https://mesg.com/","size":22356,"stargazers_count":41,"watchers_count":41,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":65,"watchers":41,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mesg-foundation/core/pulls/596"},"html":{"href":"https://github.com/mesg-foundation/core/pull/596"},"issue":{"href":"https://api.github.com/repos/mesg-foundation/core/issues/596"},"comments":{"href":"https://api.github.com/repos/mesg-foundation/core/issues/596/comments"},"review_comments":{"href":"https://api.github.com/repos/mesg-foundation/core/pulls/596/comments"},"review_comment":{"href":"https://api.github.com/repos/mesg-foundation/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesg-foundation/core/pulls/596/commits"},"statuses":{"href":"https://api.github.com/repos/mesg-foundation/core/statuses/57f0dfc635e0d7f2d9e6ead1ccf4bfdc9ec62fbc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"NicolasMahe"}}