{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/491","repository_url":"https://api.github.com/repos/alphagov/govuk-frontend","labels_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/491/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/491/comments","events_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/491/events","html_url":"https://github.com/alphagov/govuk-frontend/pull/491","id":293498614,"number":491,"title":"WIP: Define size of inputs etc in pixels rather than em","user":{"login":"hannalaakso","id":5007934,"avatar_url":"https://avatars1.githubusercontent.com/u/5007934?v=4","gravatar_id":"","url":"https://api.github.com/users/hannalaakso","html_url":"https://github.com/hannalaakso","followers_url":"https://api.github.com/users/hannalaakso/followers","following_url":"https://api.github.com/users/hannalaakso/following{/other_user}","gists_url":"https://api.github.com/users/hannalaakso/gists{/gist_id}","starred_url":"https://api.github.com/users/hannalaakso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannalaakso/subscriptions","organizations_url":"https://api.github.com/users/hannalaakso/orgs","repos_url":"https://api.github.com/users/hannalaakso/repos","events_url":"https://api.github.com/users/hannalaakso/events{/privacy}","received_events_url":"https://api.github.com/users/hannalaakso/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-01T11:39:51Z","updated_at":"2018-02-01T12:20:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-frontend/pulls/491","html_url":"https://github.com/alphagov/govuk-frontend/pull/491","diff_url":"https://github.com/alphagov/govuk-frontend/pull/491.diff","patch_url":"https://github.com/alphagov/govuk-frontend/pull/491.patch"},"body":"This PR removes the calls to the `em` function from Frontend, so that all measurements\r\nare defined in pixels. \r\n\r\nThe `em` conversions were originally added in an attempt\r\nto make form elements line up. However, they cause problems when you try to use\r\nFrontend in an application that defines font sizes, especially when those font\r\nsizes are nested.\r\n\r\nThis also removes the em() call from `govuk-c-details` as the above problems\r\napply to this component too. For now, `govuk-c-table` still calls `em` - I'll\r\nfind out from Anika if there's any particular reason tables in Elements used\r\nthem.\r\n\r\nNote: I will review the visuals with @dashouse, there might be things we need to adjust now."},"comment":{"url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/comments/362249874","html_url":"https://github.com/alphagov/govuk-frontend/pull/491#issuecomment-362249874","issue_url":"https://api.github.com/repos/alphagov/govuk-frontend/issues/491","id":362249874,"user":{"login":"nickcolley","id":2445413,"avatar_url":"https://avatars2.githubusercontent.com/u/2445413?v=4","gravatar_id":"","url":"https://api.github.com/users/nickcolley","html_url":"https://github.com/nickcolley","followers_url":"https://api.github.com/users/nickcolley/followers","following_url":"https://api.github.com/users/nickcolley/following{/other_user}","gists_url":"https://api.github.com/users/nickcolley/gists{/gist_id}","starred_url":"https://api.github.com/users/nickcolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickcolley/subscriptions","organizations_url":"https://api.github.com/users/nickcolley/orgs","repos_url":"https://api.github.com/users/nickcolley/repos","events_url":"https://api.github.com/users/nickcolley/events{/privacy}","received_events_url":"https://api.github.com/users/nickcolley/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T12:20:56Z","updated_at":"2018-02-01T12:20:56Z","author_association":"CONTRIBUTOR","body":"![before-and-after](https://user-images.githubusercontent.com/2445413/35678195-58b2dd90-074a-11e8-907c-581c21340818.gif)\r\n"}}
{"actor":{"display_login":"nickcolley"}}