{"action":"created","comment":{"url":"https://api.github.com/repos/GENIVI/AudioManager/pulls/comments/168274878","pull_request_review_id":96615954,"id":168274878,"diff_hunk":"@@ -36,21 +36,47 @@ namespace am\n static CAmCommonAPIWrapper* pSingleCommonAPIInstance = NULL;\n \n \n+bool timeoutToTimespec(const int64_t & localTimeout, timespec & pollTimeout)\n+{    \n+    if(CommonAPI::TIMEOUT_INFINITE == localTimeout)//dispatch never\n+    {\n+        return false;\n+    }\n+    else\n+    {\n+        if(CommonAPI::TIMEOUT_NONE==localTimeout)//dispatch immediately","path":"AudioManagerUtilities/src/CAmCommonAPIWrapper.cpp","position":12,"original_position":12,"commit_id":"b6753f2666811af437c8711dd06509e4c7ca3f33","original_commit_id":"b6753f2666811af437c8711dd06509e4c7ca3f33","user":{"login":"gunnarx","id":7410653,"avatar_url":"https://avatars0.githubusercontent.com/u/7410653?v=4","gravatar_id":"","url":"https://api.github.com/users/gunnarx","html_url":"https://github.com/gunnarx","followers_url":"https://api.github.com/users/gunnarx/followers","following_url":"https://api.github.com/users/gunnarx/following{/other_user}","gists_url":"https://api.github.com/users/gunnarx/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarx/subscriptions","organizations_url":"https://api.github.com/users/gunnarx/orgs","repos_url":"https://api.github.com/users/gunnarx/repos","events_url":"https://api.github.com/users/gunnarx/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarx/received_events","type":"User","site_admin":false},"body":"Yes.  More than one occurrence pointed out by Jens here, and I am adding a few comments.  So since it doesn't come naturally (to the writer of the code), would you perhaps suggest to them to use  a code formatter?  (See discussion under #24, which gives pointers and there is indeed a code style already defined).","created_at":"2018-02-14T18:55:54Z","updated_at":"2018-02-14T18:55:54Z","html_url":"https://github.com/GENIVI/AudioManager/pull/26#discussion_r168274878","pull_request_url":"https://api.github.com/repos/GENIVI/AudioManager/pulls/26","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/GENIVI/AudioManager/pulls/comments/168274878"},"html":{"href":"https://github.com/GENIVI/AudioManager/pull/26#discussion_r168274878"},"pull_request":{"href":"https://api.github.com/repos/GENIVI/AudioManager/pulls/26"}},"in_reply_to_id":168187650},"pull_request":{"url":"https://api.github.com/repos/GENIVI/AudioManager/pulls/26","id":168825732,"html_url":"https://github.com/GENIVI/AudioManager/pull/26","diff_url":"https://github.com/GENIVI/AudioManager/pull/26.diff","patch_url":"https://github.com/GENIVI/AudioManager/pull/26.patch","issue_url":"https://api.github.com/repos/GENIVI/AudioManager/issues/26","number":26,"state":"open","locked":false,"title":"Utility updates capi fixes","user":{"login":"GeniviAMmaintainer","id":22153921,"avatar_url":"https://avatars0.githubusercontent.com/u/22153921?v=4","gravatar_id":"","url":"https://api.github.com/users/GeniviAMmaintainer","html_url":"https://github.com/GeniviAMmaintainer","followers_url":"https://api.github.com/users/GeniviAMmaintainer/followers","following_url":"https://api.github.com/users/GeniviAMmaintainer/following{/other_user}","gists_url":"https://api.github.com/users/GeniviAMmaintainer/gists{/gist_id}","starred_url":"https://api.github.com/users/GeniviAMmaintainer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeniviAMmaintainer/subscriptions","organizations_url":"https://api.github.com/users/GeniviAMmaintainer/orgs","repos_url":"https://api.github.com/users/GeniviAMmaintainer/repos","events_url":"https://api.github.com/users/GeniviAMmaintainer/events{/privacy}","received_events_url":"https://api.github.com/users/GeniviAMmaintainer/received_events","type":"User","site_admin":false},"body":"Remaining fixes from utility updates. Will close other pull request","created_at":"2018-02-13T11:58:08Z","updated_at":"2018-02-14T18:55:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abf67637f56da0c9eb24bc2af27706456ce7d991","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GENIVI/AudioManager/pulls/26/commits","review_comments_url":"https://api.github.com/repos/GENIVI/AudioManager/pulls/26/comments","review_comment_url":"https://api.github.com/repos/GENIVI/AudioManager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GENIVI/AudioManager/issues/26/comments","statuses_url":"https://api.github.com/repos/GENIVI/AudioManager/statuses/b6753f2666811af437c8711dd06509e4c7ca3f33","head":{"label":"GENIVI:utilityUpdates_CAPI_fixes","ref":"utilityUpdates_CAPI_fixes","sha":"b6753f2666811af437c8711dd06509e4c7ca3f33","user":{"login":"GENIVI","id":9118647,"avatar_url":"https://avatars2.githubusercontent.com/u/9118647?v=4","gravatar_id":"","url":"https://api.github.com/users/GENIVI","html_url":"https://github.com/GENIVI","followers_url":"https://api.github.com/users/GENIVI/followers","following_url":"https://api.github.com/users/GENIVI/following{/other_user}","gists_url":"https://api.github.com/users/GENIVI/gists{/gist_id}","starred_url":"https://api.github.com/users/GENIVI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GENIVI/subscriptions","organizations_url":"https://api.github.com/users/GENIVI/orgs","repos_url":"https://api.github.com/users/GENIVI/repos","events_url":"https://api.github.com/users/GENIVI/events{/privacy}","received_events_url":"https://api.github.com/users/GENIVI/received_events","type":"Organization","site_admin":false},"repo":{"id":68028683,"name":"AudioManager","full_name":"GENIVI/AudioManager","owner":{"login":"GENIVI","id":9118647,"avatar_url":"https://avatars2.githubusercontent.com/u/9118647?v=4","gravatar_id":"","url":"https://api.github.com/users/GENIVI","html_url":"https://github.com/GENIVI","followers_url":"https://api.github.com/users/GENIVI/followers","following_url":"https://api.github.com/users/GENIVI/following{/other_user}","gists_url":"https://api.github.com/users/GENIVI/gists{/gist_id}","starred_url":"https://api.github.com/users/GENIVI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GENIVI/subscriptions","organizations_url":"https://api.github.com/users/GENIVI/orgs","repos_url":"https://api.github.com/users/GENIVI/repos","events_url":"https://api.github.com/users/GENIVI/events{/privacy}","received_events_url":"https://api.github.com/users/GENIVI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GENIVI/AudioManager","description":"The GENIVI Audiomanager","fork":false,"url":"https://api.github.com/repos/GENIVI/AudioManager","forks_url":"https://api.github.com/repos/GENIVI/AudioManager/forks","keys_url":"https://api.github.com/repos/GENIVI/AudioManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GENIVI/AudioManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GENIVI/AudioManager/teams","hooks_url":"https://api.github.com/repos/GENIVI/AudioManager/hooks","issue_events_url":"https://api.github.com/repos/GENIVI/AudioManager/issues/events{/number}","events_url":"https://api.github.com/repos/GENIVI/AudioManager/events","assignees_url":"https://api.github.com/repos/GENIVI/AudioManager/assignees{/user}","branches_url":"https://api.github.com/repos/GENIVI/AudioManager/branches{/branch}","tags_url":"https://api.github.com/repos/GENIVI/AudioManager/tags","blobs_url":"https://api.github.com/repos/GENIVI/AudioManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GENIVI/AudioManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GENIVI/AudioManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/GENIVI/AudioManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GENIVI/AudioManager/statuses/{sha}","languages_url":"https://api.github.com/repos/GENIVI/AudioManager/languages","stargazers_url":"https://api.github.com/repos/GENIVI/AudioManager/stargazers","contributors_url":"https://api.github.com/repos/GENIVI/AudioManager/contributors","subscribers_url":"https://api.github.com/repos/GENIVI/AudioManager/subscribers","subscription_url":"https://api.github.com/repos/GENIVI/AudioManager/subscription","commits_url":"https://api.github.com/repos/GENIVI/AudioManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/GENIVI/AudioManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/GENIVI/AudioManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/GENIVI/AudioManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/GENIVI/AudioManager/contents/{+path}","compare_url":"https://api.github.com/repos/GENIVI/AudioManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GENIVI/AudioManager/merges","archive_url":"https://api.github.com/repos/GENIVI/AudioManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GENIVI/AudioManager/downloads","issues_url":"https://api.github.com/repos/GENIVI/AudioManager/issues{/number}","pulls_url":"https://api.github.com/repos/GENIVI/AudioManager/pulls{/number}","milestones_url":"https://api.github.com/repos/GENIVI/AudioManager/milestones{/number}","notifications_url":"https://api.github.com/repos/GENIVI/AudioManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GENIVI/AudioManager/labels{/name}","releases_url":"https://api.github.com/repos/GENIVI/AudioManager/releases{/id}","deployments_url":"https://api.github.com/repos/GENIVI/AudioManager/deployments","created_at":"2016-09-12T16:51:54Z","updated_at":"2018-02-04T09:06:05Z","pushed_at":"2018-02-13T11:58:09Z","git_url":"git://github.com/GENIVI/AudioManager.git","ssh_url":"git@github.com:GENIVI/AudioManager.git","clone_url":"https://github.com/GENIVI/AudioManager.git","svn_url":"https://github.com/GENIVI/AudioManager","homepage":"https://genivi.github.io/AudioManager","size":37802,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7,"open_issues":6,"watchers":5,"default_branch":"master"}},"base":{"label":"GENIVI:master","ref":"master","sha":"bcaeed20bbbb4375ae925d507821d2bef64e737b","user":{"login":"GENIVI","id":9118647,"avatar_url":"https://avatars2.githubusercontent.com/u/9118647?v=4","gravatar_id":"","url":"https://api.github.com/users/GENIVI","html_url":"https://github.com/GENIVI","followers_url":"https://api.github.com/users/GENIVI/followers","following_url":"https://api.github.com/users/GENIVI/following{/other_user}","gists_url":"https://api.github.com/users/GENIVI/gists{/gist_id}","starred_url":"https://api.github.com/users/GENIVI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GENIVI/subscriptions","organizations_url":"https://api.github.com/users/GENIVI/orgs","repos_url":"https://api.github.com/users/GENIVI/repos","events_url":"https://api.github.com/users/GENIVI/events{/privacy}","received_events_url":"https://api.github.com/users/GENIVI/received_events","type":"Organization","site_admin":false},"repo":{"id":68028683,"name":"AudioManager","full_name":"GENIVI/AudioManager","owner":{"login":"GENIVI","id":9118647,"avatar_url":"https://avatars2.githubusercontent.com/u/9118647?v=4","gravatar_id":"","url":"https://api.github.com/users/GENIVI","html_url":"https://github.com/GENIVI","followers_url":"https://api.github.com/users/GENIVI/followers","following_url":"https://api.github.com/users/GENIVI/following{/other_user}","gists_url":"https://api.github.com/users/GENIVI/gists{/gist_id}","starred_url":"https://api.github.com/users/GENIVI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GENIVI/subscriptions","organizations_url":"https://api.github.com/users/GENIVI/orgs","repos_url":"https://api.github.com/users/GENIVI/repos","events_url":"https://api.github.com/users/GENIVI/events{/privacy}","received_events_url":"https://api.github.com/users/GENIVI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GENIVI/AudioManager","description":"The GENIVI Audiomanager","fork":false,"url":"https://api.github.com/repos/GENIVI/AudioManager","forks_url":"https://api.github.com/repos/GENIVI/AudioManager/forks","keys_url":"https://api.github.com/repos/GENIVI/AudioManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GENIVI/AudioManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GENIVI/AudioManager/teams","hooks_url":"https://api.github.com/repos/GENIVI/AudioManager/hooks","issue_events_url":"https://api.github.com/repos/GENIVI/AudioManager/issues/events{/number}","events_url":"https://api.github.com/repos/GENIVI/AudioManager/events","assignees_url":"https://api.github.com/repos/GENIVI/AudioManager/assignees{/user}","branches_url":"https://api.github.com/repos/GENIVI/AudioManager/branches{/branch}","tags_url":"https://api.github.com/repos/GENIVI/AudioManager/tags","blobs_url":"https://api.github.com/repos/GENIVI/AudioManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GENIVI/AudioManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GENIVI/AudioManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/GENIVI/AudioManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GENIVI/AudioManager/statuses/{sha}","languages_url":"https://api.github.com/repos/GENIVI/AudioManager/languages","stargazers_url":"https://api.github.com/repos/GENIVI/AudioManager/stargazers","contributors_url":"https://api.github.com/repos/GENIVI/AudioManager/contributors","subscribers_url":"https://api.github.com/repos/GENIVI/AudioManager/subscribers","subscription_url":"https://api.github.com/repos/GENIVI/AudioManager/subscription","commits_url":"https://api.github.com/repos/GENIVI/AudioManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/GENIVI/AudioManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/GENIVI/AudioManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/GENIVI/AudioManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/GENIVI/AudioManager/contents/{+path}","compare_url":"https://api.github.com/repos/GENIVI/AudioManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GENIVI/AudioManager/merges","archive_url":"https://api.github.com/repos/GENIVI/AudioManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GENIVI/AudioManager/downloads","issues_url":"https://api.github.com/repos/GENIVI/AudioManager/issues{/number}","pulls_url":"https://api.github.com/repos/GENIVI/AudioManager/pulls{/number}","milestones_url":"https://api.github.com/repos/GENIVI/AudioManager/milestones{/number}","notifications_url":"https://api.github.com/repos/GENIVI/AudioManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GENIVI/AudioManager/labels{/name}","releases_url":"https://api.github.com/repos/GENIVI/AudioManager/releases{/id}","deployments_url":"https://api.github.com/repos/GENIVI/AudioManager/deployments","created_at":"2016-09-12T16:51:54Z","updated_at":"2018-02-04T09:06:05Z","pushed_at":"2018-02-13T11:58:09Z","git_url":"git://github.com/GENIVI/AudioManager.git","ssh_url":"git@github.com:GENIVI/AudioManager.git","clone_url":"https://github.com/GENIVI/AudioManager.git","svn_url":"https://github.com/GENIVI/AudioManager","homepage":"https://genivi.github.io/AudioManager","size":37802,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GENIVI/AudioManager/pulls/26"},"html":{"href":"https://github.com/GENIVI/AudioManager/pull/26"},"issue":{"href":"https://api.github.com/repos/GENIVI/AudioManager/issues/26"},"comments":{"href":"https://api.github.com/repos/GENIVI/AudioManager/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/GENIVI/AudioManager/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/GENIVI/AudioManager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GENIVI/AudioManager/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/GENIVI/AudioManager/statuses/b6753f2666811af437c8711dd06509e4c7ca3f33"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gunnarx"}}