{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64097","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64097/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64097/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64097/events","html_url":"https://github.com/kubernetes/kubernetes/pull/64097","id":324934180,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MzkzMTkw","number":64097,"title":"HPA metrics specificity improvements","user":{"login":"damemi","id":1839101,"node_id":"MDQ6VXNlcjE4MzkxMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1839101?v=4","gravatar_id":"","url":"https://api.github.com/users/damemi","html_url":"https://github.com/damemi","followers_url":"https://api.github.com/users/damemi/followers","following_url":"https://api.github.com/users/damemi/following{/other_user}","gists_url":"https://api.github.com/users/damemi/gists{/gist_id}","starred_url":"https://api.github.com/users/damemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damemi/subscriptions","organizations_url":"https://api.github.com/users/damemi/orgs","repos_url":"https://api.github.com/users/damemi/repos","events_url":"https://api.github.com/users/damemi/events{/privacy}","received_events_url":"https://api.github.com/users/damemi/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"node_id":"MDU6TGFiZWwyNjEwMDUzNjA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":261005424,"node_id":"MDU6TGFiZWwyNjEwMDU0MjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/new-api","name":"kind/new-api","color":"c7def8","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"DirectXMan12","id":119737,"node_id":"MDQ6VXNlcjExOTczNw==","avatar_url":"https://avatars1.githubusercontent.com/u/119737?v=4","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"assignees":[{"login":"DirectXMan12","id":119737,"node_id":"MDQ6VXNlcjExOTczNw==","avatar_url":"https://avatars1.githubusercontent.com/u/119737?v=4","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},{"login":"lavalamp","id":647318,"node_id":"MDQ6VXNlcjY0NzMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2018-05-21T14:21:32Z","updated_at":"2018-07-03T16:06:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64097","html_url":"https://github.com/kubernetes/kubernetes/pull/64097","diff_url":"https://github.com/kubernetes/kubernetes/pull/64097.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/64097.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nImproves available specificity for HPA metrics by adding metric selector fields for metrics of Pods and Objects. \r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nImplements this KEP: https://github.com/kubernetes/community/pull/2055\r\n\r\n**Special notes for your reviewer**:\r\nNeed to add/update tests?\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nIntroduces autoscaling/v2beta2 and custom_metrics/v1beta2, which implement metric selectors for Object and Pods metrics, as well as allowing AverageValue targets on Objects, similar to External metrics.\r\n```\r\n\r\n/assign @DirectXMan12 \r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/402209771","html_url":"https://github.com/kubernetes/kubernetes/pull/64097#issuecomment-402209771","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64097","id":402209771,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjIwOTc3MQ==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T16:06:12Z","updated_at":"2018-07-03T16:06:12Z","author_association":"COLLABORATOR","body":"@damemi: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-cross | 01feb550c82cd3c6fff3effb6d80319d387abd7e | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64097/pull-kubernetes-cross/8514/) | `/test pull-kubernetes-cross`\npull-kubernetes-kubemark-e2e-gce-big | 01feb550c82cd3c6fff3effb6d80319d387abd7e | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64097/pull-kubernetes-kubemark-e2e-gce-big/13183/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\npull-kubernetes-e2e-gce-100-performance | 01feb550c82cd3c6fff3effb6d80319d387abd7e | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64097/pull-kubernetes-e2e-gce-100-performance/11932/) | `/test pull-kubernetes-e2e-gce-100-performance`\npull-kubernetes-verify | 01feb550c82cd3c6fff3effb6d80319d387abd7e | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64097/pull-kubernetes-verify/97462/) | `/test pull-kubernetes-verify`\npull-kubernetes-bazel-test | e4400309690b9892bcfa85cf6d85d63f1273cf1f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64097/pull-kubernetes-bazel-test/51476/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-kops-aws | e4400309690b9892bcfa85cf6d85d63f1273cf1f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64097/pull-kubernetes-e2e-kops-aws/95797/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-e2e-gce | e4400309690b9892bcfa85cf6d85d63f1273cf1f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64097/pull-kubernetes-e2e-gce/43121/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-gce-device-plugin-gpu | e4400309690b9892bcfa85cf6d85d63f1273cf1f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64097/pull-kubernetes-e2e-gce-device-plugin-gpu/38717/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-typecheck | e4400309690b9892bcfa85cf6d85d63f1273cf1f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64097/pull-kubernetes-typecheck/16050/) | `/test pull-kubernetes-typecheck`\npull-kubernetes-bazel-build | e4400309690b9892bcfa85cf6d85d63f1273cf1f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64097/pull-kubernetes-bazel-build/49001/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-integration | e4400309690b9892bcfa85cf6d85d63f1273cf1f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64097/pull-kubernetes-integration/18145/) | `/test pull-kubernetes-integration`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/64097). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/damemi). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}