{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/226058206","pull_request_review_id":165790235,"id":226058206,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjA1ODIwNg==","diff_hunk":"@@ -1064,30 +1064,29 @@ int ParseSoaReply(Environment* env,\n   /* Can't use ares_parse_soa_reply() here which can only parse single record */\n   unsigned int ancount = cares_get_16bit(buf + 6);\n   unsigned char* ptr = buf + NS_HFIXEDSZ;\n-  char* name;\n-  char* rr_name;\n+  int rr_type, rr_len;","path":"src/cares_wrap.cc","position":6,"original_position":6,"commit_id":"f0e34f3f70587274a88ac7515d34b6acbad67553","original_commit_id":"f0e34f3f70587274a88ac7515d34b6acbad67553","user":{"login":"cjihrig","id":2512748,"node_id":"MDQ6VXNlcjI1MTI3NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2512748?v=4","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"body":"Yes. It looks related to merge conflicts or something (I'm pretty sure I removed that line recently).","created_at":"2018-10-17T19:06:12Z","updated_at":"2018-10-17T19:06:12Z","html_url":"https://github.com/nodejs/node/pull/23628#discussion_r226058206","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/23628","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/226058206"},"html":{"href":"https://github.com/nodejs/node/pull/23628#discussion_r226058206"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/23628"}},"in_reply_to_id":224976495},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/23628","id":222596349,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTk2MzQ5","html_url":"https://github.com/nodejs/node/pull/23628","diff_url":"https://github.com/nodejs/node/pull/23628.diff","patch_url":"https://github.com/nodejs/node/pull/23628.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/23628","number":23628,"state":"open","locked":false,"title":"Improved memory management code in ParseSoaReply()","user":{"login":"uttampawar","id":8977402,"node_id":"MDQ6VXNlcjg5Nzc0MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8977402?v=4","gravatar_id":"","url":"https://api.github.com/users/uttampawar","html_url":"https://github.com/uttampawar","followers_url":"https://api.github.com/users/uttampawar/followers","following_url":"https://api.github.com/users/uttampawar/following{/other_user}","gists_url":"https://api.github.com/users/uttampawar/gists{/gist_id}","starred_url":"https://api.github.com/users/uttampawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uttampawar/subscriptions","organizations_url":"https://api.github.com/users/uttampawar/orgs","repos_url":"https://api.github.com/users/uttampawar/repos","events_url":"https://api.github.com/users/uttampawar/events{/privacy}","received_events_url":"https://api.github.com/users/uttampawar/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\nTest results:\r\n$ python tools/test.py -I 'parallel/test-dns*'\r\n [00:00|% 100|+  12|-   0]: Done\r\n\r\n$ make test\r\n[06:23|% 100|+ 2429|-   2]: Done\r\nFailed tests are not due to this change.\r\n\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\nThis change was to improve memory management by use of MallocedBuffer instead of malloc()/free() calls. I further removed use of structure \"ares_soa_reply\" by using just local variables which removed 2 additional malloc/free calls via ares_expand_name().\r\n\r\n","created_at":"2018-10-12T21:56:51Z","updated_at":"2018-10-17T19:06:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca25437454bdd08ec839ed762f4378740c6f0b33","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":370637902,"node_id":"MDU6TGFiZWwzNzA2Mzc5MDI=","url":"https://api.github.com/repos/nodejs/node/labels/cares","name":"cares","color":"ededed","default":false},{"id":492471325,"node_id":"MDU6TGFiZWw0OTI0NzEzMjU=","url":"https://api.github.com/repos/nodejs/node/labels/code-and-learn","name":"code-and-learn","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/23628/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/23628/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/23628/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/f0e34f3f70587274a88ac7515d34b6acbad67553","head":{"label":"uttampawar:malloced-buffer-cares","ref":"malloced-buffer-cares","sha":"f0e34f3f70587274a88ac7515d34b6acbad67553","user":{"login":"uttampawar","id":8977402,"node_id":"MDQ6VXNlcjg5Nzc0MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8977402?v=4","gravatar_id":"","url":"https://api.github.com/users/uttampawar","html_url":"https://github.com/uttampawar","followers_url":"https://api.github.com/users/uttampawar/followers","following_url":"https://api.github.com/users/uttampawar/following{/other_user}","gists_url":"https://api.github.com/users/uttampawar/gists{/gist_id}","starred_url":"https://api.github.com/users/uttampawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uttampawar/subscriptions","organizations_url":"https://api.github.com/users/uttampawar/orgs","repos_url":"https://api.github.com/users/uttampawar/repos","events_url":"https://api.github.com/users/uttampawar/events{/privacy}","received_events_url":"https://api.github.com/users/uttampawar/received_events","type":"User","site_admin":false},"repo":{"id":75308755,"node_id":"MDEwOlJlcG9zaXRvcnk3NTMwODc1NQ==","name":"node","full_name":"uttampawar/node","private":false,"owner":{"login":"uttampawar","id":8977402,"node_id":"MDQ6VXNlcjg5Nzc0MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8977402?v=4","gravatar_id":"","url":"https://api.github.com/users/uttampawar","html_url":"https://github.com/uttampawar","followers_url":"https://api.github.com/users/uttampawar/followers","following_url":"https://api.github.com/users/uttampawar/following{/other_user}","gists_url":"https://api.github.com/users/uttampawar/gists{/gist_id}","starred_url":"https://api.github.com/users/uttampawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uttampawar/subscriptions","organizations_url":"https://api.github.com/users/uttampawar/orgs","repos_url":"https://api.github.com/users/uttampawar/repos","events_url":"https://api.github.com/users/uttampawar/events{/privacy}","received_events_url":"https://api.github.com/users/uttampawar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/uttampawar/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/uttampawar/node","forks_url":"https://api.github.com/repos/uttampawar/node/forks","keys_url":"https://api.github.com/repos/uttampawar/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uttampawar/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uttampawar/node/teams","hooks_url":"https://api.github.com/repos/uttampawar/node/hooks","issue_events_url":"https://api.github.com/repos/uttampawar/node/issues/events{/number}","events_url":"https://api.github.com/repos/uttampawar/node/events","assignees_url":"https://api.github.com/repos/uttampawar/node/assignees{/user}","branches_url":"https://api.github.com/repos/uttampawar/node/branches{/branch}","tags_url":"https://api.github.com/repos/uttampawar/node/tags","blobs_url":"https://api.github.com/repos/uttampawar/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uttampawar/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uttampawar/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/uttampawar/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uttampawar/node/statuses/{sha}","languages_url":"https://api.github.com/repos/uttampawar/node/languages","stargazers_url":"https://api.github.com/repos/uttampawar/node/stargazers","contributors_url":"https://api.github.com/repos/uttampawar/node/contributors","subscribers_url":"https://api.github.com/repos/uttampawar/node/subscribers","subscription_url":"https://api.github.com/repos/uttampawar/node/subscription","commits_url":"https://api.github.com/repos/uttampawar/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/uttampawar/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/uttampawar/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/uttampawar/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/uttampawar/node/contents/{+path}","compare_url":"https://api.github.com/repos/uttampawar/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uttampawar/node/merges","archive_url":"https://api.github.com/repos/uttampawar/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uttampawar/node/downloads","issues_url":"https://api.github.com/repos/uttampawar/node/issues{/number}","pulls_url":"https://api.github.com/repos/uttampawar/node/pulls{/number}","milestones_url":"https://api.github.com/repos/uttampawar/node/milestones{/number}","notifications_url":"https://api.github.com/repos/uttampawar/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uttampawar/node/labels{/name}","releases_url":"https://api.github.com/repos/uttampawar/node/releases{/id}","deployments_url":"https://api.github.com/repos/uttampawar/node/deployments","created_at":"2016-12-01T16:00:39Z","updated_at":"2018-10-16T17:08:45Z","pushed_at":"2018-10-16T17:08:27Z","git_url":"git://github.com/uttampawar/node.git","ssh_url":"git@github.com:uttampawar/node.git","clone_url":"https://github.com/uttampawar/node.git","svn_url":"https://github.com/uttampawar/node","homepage":"https://nodejs.org","size":389670,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"9ed4646df05b9593075bb0cd0b3ab420bae482a5","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-10-17T18:48:14Z","pushed_at":"2018-10-17T18:56:43Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":424657,"stargazers_count":54449,"watchers_count":54449,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11807,"mirror_url":null,"archived":false,"open_issues_count":950,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11807,"open_issues":950,"watchers":54449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/23628"},"html":{"href":"https://github.com/nodejs/node/pull/23628"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/23628"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/23628/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/23628/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/23628/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/f0e34f3f70587274a88ac7515d34b6acbad67553"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cjihrig"}}