{"action":"created","issue":{"url":"https://api.github.com/repos/Juanpe/SkeletonView/issues/98","repository_url":"https://api.github.com/repos/Juanpe/SkeletonView","labels_url":"https://api.github.com/repos/Juanpe/SkeletonView/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/Juanpe/SkeletonView/issues/98/comments","events_url":"https://api.github.com/repos/Juanpe/SkeletonView/issues/98/events","html_url":"https://github.com/Juanpe/SkeletonView/issues/98","id":360450268,"node_id":"MDU6SXNzdWUzNjA0NTAyNjg=","number":98,"title":"SkeletonView not being removed from all UITableViewCell's","user":{"login":"Garrett-Benoit","id":17788960,"node_id":"MDQ6VXNlcjE3Nzg4OTYw","avatar_url":"https://avatars2.githubusercontent.com/u/17788960?v=4","gravatar_id":"","url":"https://api.github.com/users/Garrett-Benoit","html_url":"https://github.com/Garrett-Benoit","followers_url":"https://api.github.com/users/Garrett-Benoit/followers","following_url":"https://api.github.com/users/Garrett-Benoit/following{/other_user}","gists_url":"https://api.github.com/users/Garrett-Benoit/gists{/gist_id}","starred_url":"https://api.github.com/users/Garrett-Benoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Garrett-Benoit/subscriptions","organizations_url":"https://api.github.com/users/Garrett-Benoit/orgs","repos_url":"https://api.github.com/users/Garrett-Benoit/repos","events_url":"https://api.github.com/users/Garrett-Benoit/events{/privacy}","received_events_url":"https://api.github.com/users/Garrett-Benoit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-14T20:49:30Z","updated_at":"2018-12-06T16:10:19Z","closed_at":null,"author_association":"NONE","body":"⚠️ Please fill out this template when filing an issue.\r\n\r\n#### 🙏🏼 *Please check if it already exists other issue related with yours.*\r\n\r\n### What did you do?\r\n\r\nWhen SkeletonView is being removed from a TableView and there is only one cell in the table everything appears fine, however when more cells are added and the table is reloaded, the SkeletonView still appears on the additional cells.\r\n\r\n### What did you expect to happen?\r\n\r\nWhen tableView.hideSkeleton() is ran, the SkeletonView is removed from all visible cells.\r\n\r\n### What happened instead?\r\n\r\nWhen there were 2 SkeletonView cells visible, and my TableView contained data for 2 or more cells to be displayed, when the SkeletonView was removed and the TableView reloaded -- everything worked fine.\r\n\r\nWhen there were 2 SkeletonView cells visible, and my TableView only contained data for 1 cell, when the SkeletonView was removed and the TableView reloaded -- everything appeared to have worked fine, however when I add additional data to the TableView to display more than 1 cell, the SkeletonView on the additional cells is still visible.\r\n\r\nWhat the SkeletonView looks like:\r\n![simulator screen shot - iphone 8 - 2018-09-14 at 15 34 38](https://user-images.githubusercontent.com/17788960/45573971-f5b62d00-b833-11e8-8ff8-028baf94a107.png)\r\n\r\nWhat the TableView with 1 cell looks like:\r\n![simulator screen shot - iphone 8 - 2018-09-14 at 15 34 43](https://user-images.githubusercontent.com/17788960/45573988-fea6fe80-b833-11e8-9658-26d82cdae202.png)\r\n\r\nWhat the TableView that has 4 more cells added and reloaded looks like:\r\n![simulator screen shot - iphone 8 - 2018-09-14 at 15 35 01](https://user-images.githubusercontent.com/17788960/45573993-01a1ef00-b834-11e8-96b5-da117f7aa565.png)\r\n\r\nScrolled down a bit to show the entire cell from image 3:\r\n![simulator screen shot - iphone 8 - 2018-09-14 at 15 35 14](https://user-images.githubusercontent.com/17788960/45573997-04044900-b834-11e8-8acf-d9ee787f620e.png)\r\n\r\n### Steps to reproduce the behavior\r\n\r\n1.) Remove SkeletonView with a TableView containing 1 cell\r\n2.) Add additional cells to the TableView\r\n3.) Reload the TableView\r\n\r\n### SkeletonView Environment\r\n\r\nSkeletonView: v1.4\r\nXcode: v9.4.1\r\nSwift: v4.1.2"},"comment":{"url":"https://api.github.com/repos/Juanpe/SkeletonView/issues/comments/444926853","html_url":"https://github.com/Juanpe/SkeletonView/issues/98#issuecomment-444926853","issue_url":"https://api.github.com/repos/Juanpe/SkeletonView/issues/98","id":444926853,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDkyNjg1Mw==","user":{"login":"jeremypiednoel","id":3902298,"node_id":"MDQ6VXNlcjM5MDIyOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3902298?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremypiednoel","html_url":"https://github.com/jeremypiednoel","followers_url":"https://api.github.com/users/jeremypiednoel/followers","following_url":"https://api.github.com/users/jeremypiednoel/following{/other_user}","gists_url":"https://api.github.com/users/jeremypiednoel/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremypiednoel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremypiednoel/subscriptions","organizations_url":"https://api.github.com/users/jeremypiednoel/orgs","repos_url":"https://api.github.com/users/jeremypiednoel/repos","events_url":"https://api.github.com/users/jeremypiednoel/events{/privacy}","received_events_url":"https://api.github.com/users/jeremypiednoel/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T16:10:19Z","updated_at":"2018-12-06T16:10:19Z","author_association":"NONE","body":"@osbash thanks for the solution.\r\nI added this test before \r\n\r\n```swift\r\n    override func tableView(_ tableView: UITableView, willDisplay cell: UITableViewCell, forRowAt indexPath: IndexPath) {\r\n        if cell.isSkeletonActive {\r\n            cell.hideSkeleton()\r\n        }\r\n    }\r\n```"}}
{"actor":{"display_login":"jeremypiednoel"}}