{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/comments/209403262","pull_request_review_id":145420891,"id":209403262,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQwMzI2Mg==","diff_hunk":"@@ -4,36 +4,39 @@\n module Puppetserver\n   module Utils\n     # Utilities for doing HTTPS against the CA that wraps Net::HTTP constructs\n-    module HttpUtilities\n+    class HttpUtilities","path":"lib/puppetserver/utils/http_utilities.rb","position":5,"original_position":5,"commit_id":"42f9ba62946b794eb012b5bd363724eaad6d4a00","original_commit_id":"42f9ba62946b794eb012b5bd363724eaad6d4a00","user":{"login":"Magisus","id":839145,"node_id":"MDQ6VXNlcjgzOTE0NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/839145?v=4","gravatar_id":"","url":"https://api.github.com/users/Magisus","html_url":"https://github.com/Magisus","followers_url":"https://api.github.com/users/Magisus/followers","following_url":"https://api.github.com/users/Magisus/following{/other_user}","gists_url":"https://api.github.com/users/Magisus/gists{/gist_id}","starred_url":"https://api.github.com/users/Magisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magisus/subscriptions","organizations_url":"https://api.github.com/users/Magisus/orgs","repos_url":"https://api.github.com/users/Magisus/repos","events_url":"https://api.github.com/users/Magisus/events{/privacy}","received_events_url":"https://api.github.com/users/Magisus/received_events","type":"User","site_admin":false},"body":"I think we should give this a different name if it's going to be an actual class that gets instantiated. Something like `HttpClient`?","created_at":"2018-08-10T23:04:47Z","updated_at":"2018-08-10T23:10:44Z","html_url":"https://github.com/puppetlabs/puppetserver-ca-cli/pull/13#discussion_r209403262","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/13","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/comments/209403262"},"html":{"href":"https://github.com/puppetlabs/puppetserver-ca-cli/pull/13#discussion_r209403262"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/13","id":207738827,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzM4ODI3","html_url":"https://github.com/puppetlabs/puppetserver-ca-cli/pull/13","diff_url":"https://github.com/puppetlabs/puppetserver-ca-cli/pull/13.diff","patch_url":"https://github.com/puppetlabs/puppetserver-ca-cli/pull/13.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues/13","number":13,"state":"open","locked":false,"title":"(SERVER-2275) Refactor code to make an HTTP client","user":{"login":"amysahli","id":36681391,"node_id":"MDQ6VXNlcjM2NjgxMzkx","avatar_url":"https://avatars3.githubusercontent.com/u/36681391?v=4","gravatar_id":"","url":"https://api.github.com/users/amysahli","html_url":"https://github.com/amysahli","followers_url":"https://api.github.com/users/amysahli/followers","following_url":"https://api.github.com/users/amysahli/following{/other_user}","gists_url":"https://api.github.com/users/amysahli/gists{/gist_id}","starred_url":"https://api.github.com/users/amysahli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amysahli/subscriptions","organizations_url":"https://api.github.com/users/amysahli/orgs","repos_url":"https://api.github.com/users/amysahli/repos","events_url":"https://api.github.com/users/amysahli/events{/privacy}","received_events_url":"https://api.github.com/users/amysahli/received_events","type":"User","site_admin":false},"body":"Refactor to create an actual HTTP client object that\r\ninitializes SSL state once and stores it, allowing\r\nmultiple connections to be made from it.","created_at":"2018-08-10T22:50:47Z","updated_at":"2018-08-10T23:10:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fa82ef1c77625d128d11f049ef50f056c963ab5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"justinstoller","id":241423,"node_id":"MDQ6VXNlcjI0MTQyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/241423?v=4","gravatar_id":"","url":"https://api.github.com/users/justinstoller","html_url":"https://github.com/justinstoller","followers_url":"https://api.github.com/users/justinstoller/followers","following_url":"https://api.github.com/users/justinstoller/following{/other_user}","gists_url":"https://api.github.com/users/justinstoller/gists{/gist_id}","starred_url":"https://api.github.com/users/justinstoller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinstoller/subscriptions","organizations_url":"https://api.github.com/users/justinstoller/orgs","repos_url":"https://api.github.com/users/justinstoller/repos","events_url":"https://api.github.com/users/justinstoller/events{/privacy}","received_events_url":"https://api.github.com/users/justinstoller/received_events","type":"User","site_admin":false},{"login":"lazartea","id":22064526,"node_id":"MDQ6VXNlcjIyMDY0NTI2","avatar_url":"https://avatars2.githubusercontent.com/u/22064526?v=4","gravatar_id":"","url":"https://api.github.com/users/lazartea","html_url":"https://github.com/lazartea","followers_url":"https://api.github.com/users/lazartea/followers","following_url":"https://api.github.com/users/lazartea/following{/other_user}","gists_url":"https://api.github.com/users/lazartea/gists{/gist_id}","starred_url":"https://api.github.com/users/lazartea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lazartea/subscriptions","organizations_url":"https://api.github.com/users/lazartea/orgs","repos_url":"https://api.github.com/users/lazartea/repos","events_url":"https://api.github.com/users/lazartea/events{/privacy}","received_events_url":"https://api.github.com/users/lazartea/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/13/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/13/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues/13/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/statuses/42f9ba62946b794eb012b5bd363724eaad6d4a00","head":{"label":"amysahli:SERVER-2275","ref":"SERVER-2275","sha":"42f9ba62946b794eb012b5bd363724eaad6d4a00","user":{"login":"amysahli","id":36681391,"node_id":"MDQ6VXNlcjM2NjgxMzkx","avatar_url":"https://avatars3.githubusercontent.com/u/36681391?v=4","gravatar_id":"","url":"https://api.github.com/users/amysahli","html_url":"https://github.com/amysahli","followers_url":"https://api.github.com/users/amysahli/followers","following_url":"https://api.github.com/users/amysahli/following{/other_user}","gists_url":"https://api.github.com/users/amysahli/gists{/gist_id}","starred_url":"https://api.github.com/users/amysahli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amysahli/subscriptions","organizations_url":"https://api.github.com/users/amysahli/orgs","repos_url":"https://api.github.com/users/amysahli/repos","events_url":"https://api.github.com/users/amysahli/events{/privacy}","received_events_url":"https://api.github.com/users/amysahli/received_events","type":"User","site_admin":false},"repo":{"id":142214898,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIyMTQ4OTg=","name":"puppetserver-ca-cli","full_name":"amysahli/puppetserver-ca-cli","owner":{"login":"amysahli","id":36681391,"node_id":"MDQ6VXNlcjM2NjgxMzkx","avatar_url":"https://avatars3.githubusercontent.com/u/36681391?v=4","gravatar_id":"","url":"https://api.github.com/users/amysahli","html_url":"https://github.com/amysahli","followers_url":"https://api.github.com/users/amysahli/followers","following_url":"https://api.github.com/users/amysahli/following{/other_user}","gists_url":"https://api.github.com/users/amysahli/gists{/gist_id}","starred_url":"https://api.github.com/users/amysahli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amysahli/subscriptions","organizations_url":"https://api.github.com/users/amysahli/orgs","repos_url":"https://api.github.com/users/amysahli/repos","events_url":"https://api.github.com/users/amysahli/events{/privacy}","received_events_url":"https://api.github.com/users/amysahli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amysahli/puppetserver-ca-cli","description":"A simple Ruby CLI tool to interact with the Puppet Server's included Certificate Authority","fork":true,"url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli","forks_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/forks","keys_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/teams","hooks_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/hooks","issue_events_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/issues/events{/number}","events_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/events","assignees_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/assignees{/user}","branches_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/branches{/branch}","tags_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/tags","blobs_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/languages","stargazers_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/stargazers","contributors_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/contributors","subscribers_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/subscribers","subscription_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/subscription","commits_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/contents/{+path}","compare_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/merges","archive_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/downloads","issues_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/issues{/number}","pulls_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/labels{/name}","releases_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/releases{/id}","deployments_url":"https://api.github.com/repos/amysahli/puppetserver-ca-cli/deployments","created_at":"2018-07-24T21:30:08Z","updated_at":"2018-07-24T21:30:10Z","pushed_at":"2018-08-10T23:03:38Z","git_url":"git://github.com/amysahli/puppetserver-ca-cli.git","ssh_url":"git@github.com:amysahli/puppetserver-ca-cli.git","clone_url":"https://github.com/amysahli/puppetserver-ca-cli.git","svn_url":"https://github.com/amysahli/puppetserver-ca-cli","homepage":null,"size":117,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"3c265ba445f1ad989b337f8aa4c372d48fa4b66b","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":135350068,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNTAwNjg=","name":"puppetserver-ca-cli","full_name":"puppetlabs/puppetserver-ca-cli","owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetserver-ca-cli","description":"A simple Ruby CLI tool to interact with the Puppet Server's included Certificate Authority","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli","forks_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/deployments","created_at":"2018-05-29T20:35:19Z","updated_at":"2018-08-10T21:40:11Z","pushed_at":"2018-08-10T23:03:39Z","git_url":"git://github.com/puppetlabs/puppetserver-ca-cli.git","ssh_url":"git@github.com:puppetlabs/puppetserver-ca-cli.git","clone_url":"https://github.com/puppetlabs/puppetserver-ca-cli.git","svn_url":"https://github.com/puppetlabs/puppetserver-ca-cli","homepage":null,"size":118,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/13"},"html":{"href":"https://github.com/puppetlabs/puppetserver-ca-cli/pull/13"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues/13"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/statuses/42f9ba62946b794eb012b5bd363724eaad6d4a00"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Magisus"}}