{"action":"created","comment":{"url":"https://api.github.com/repos/apache/apex-core/pulls/comments/195852247","pull_request_review_id":129305498,"id":195852247,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTg1MjI0Nw==","diff_hunk":"@@ -860,41 +862,45 @@ private void teardown()\n       }\n       torndown = true;\n \n-      /*\n-       * if the publisher unregistered, all the downstream guys are going to be unregistered anyways\n-       * in our world. So it makes sense to kick them out proactively. Otherwise these clients since\n-       * are not being written to, just stick around till the next publisher shows up and eat into\n-       * the data it's publishing for the new subscribers.\n-       */\n-\n-      /**\n-       * since the publisher server died, the queue which it was using would stop pumping the data unless\n-       * a new publisher comes up with the same name. We leave it to the stream to decide when to bring up a new node\n-       * with the same identifier as the one which just died.\n-       */\n-      if (publisherChannels.containsValue(this)) {\n-        final Iterator<Entry<String, AbstractLengthPrependerClient>> i = publisherChannels.entrySet().iterator();\n-        while (i.hasNext()) {\n-          if (i.next().getValue() == this) {\n-            i.remove();\n-            break;\n+      serverHelperExecutor.submit(() ->\n+      {\n+        /*\n+         * if the publisher unregistered, all the downstream guys are going to be unregistered anyways\n+         * in our world. So it makes sense to kick them out proactively. Otherwise these clients since\n+         * are not being written to, just stick around till the next publisher shows up and eat into\n+         * the data it's publishing for the new subscribers.\n+         */\n+\n+        /**\n+         * since the publisher server died, the queue which it was using would stop pumping the data unless\n+         * a new publisher comes up with the same name. We leave it to the stream to decide when to bring up a new node\n+         * with the same identifier as the one which just died.\n+         */\n+        if (publisherChannels.containsValue(this)) {","path":"bufferserver/src/main/java/com/datatorrent/bufferserver/server/Server.java","position":48,"original_position":48,"commit_id":"c8f939181c0deef8252bcc06c49f4f15040c2846","original_commit_id":"c8f939181c0deef8252bcc06c49f4f15040c2846","user":{"login":"PramodSSImmaneni","id":4418235,"node_id":"MDQ6VXNlcjQ0MTgyMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4418235?v=4","gravatar_id":"","url":"https://api.github.com/users/PramodSSImmaneni","html_url":"https://github.com/PramodSSImmaneni","followers_url":"https://api.github.com/users/PramodSSImmaneni/followers","following_url":"https://api.github.com/users/PramodSSImmaneni/following{/other_user}","gists_url":"https://api.github.com/users/PramodSSImmaneni/gists{/gist_id}","starred_url":"https://api.github.com/users/PramodSSImmaneni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PramodSSImmaneni/subscriptions","organizations_url":"https://api.github.com/users/PramodSSImmaneni/orgs","repos_url":"https://api.github.com/users/PramodSSImmaneni/repos","events_url":"https://api.github.com/users/PramodSSImmaneni/events{/privacy}","received_events_url":"https://api.github.com/users/PramodSSImmaneni/received_events","type":"User","site_admin":false},"body":"You mean one new object right ;)? It's just that creating a values view just for removing something feels wrong.","created_at":"2018-06-15T20:21:45Z","updated_at":"2018-06-15T20:21:45Z","html_url":"https://github.com/apache/apex-core/pull/595#discussion_r195852247","pull_request_url":"https://api.github.com/repos/apache/apex-core/pulls/595","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/apex-core/pulls/comments/195852247"},"html":{"href":"https://github.com/apache/apex-core/pull/595#discussion_r195852247"},"pull_request":{"href":"https://api.github.com/repos/apache/apex-core/pulls/595"}},"in_reply_to_id":195831314},"pull_request":{"url":"https://api.github.com/repos/apache/apex-core/pulls/595","id":182712562,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgyNzEyNTYy","html_url":"https://github.com/apache/apex-core/pull/595","diff_url":"https://github.com/apache/apex-core/pull/595.diff","patch_url":"https://github.com/apache/apex-core/pull/595.patch","issue_url":"https://api.github.com/repos/apache/apex-core/issues/595","number":595,"state":"open","locked":false,"title":"APEXCORE-810 Fixing race condition between publisher and subscriber teardowns","user":{"login":"PramodSSImmaneni","id":4418235,"node_id":"MDQ6VXNlcjQ0MTgyMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4418235?v=4","gravatar_id":"","url":"https://api.github.com/users/PramodSSImmaneni","html_url":"https://github.com/PramodSSImmaneni","followers_url":"https://api.github.com/users/PramodSSImmaneni/followers","following_url":"https://api.github.com/users/PramodSSImmaneni/following{/other_user}","gists_url":"https://api.github.com/users/PramodSSImmaneni/gists{/gist_id}","starred_url":"https://api.github.com/users/PramodSSImmaneni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PramodSSImmaneni/subscriptions","organizations_url":"https://api.github.com/users/PramodSSImmaneni/orgs","repos_url":"https://api.github.com/users/PramodSSImmaneni/repos","events_url":"https://api.github.com/users/PramodSSImmaneni/events{/privacy}","received_events_url":"https://api.github.com/users/PramodSSImmaneni/received_events","type":"User","site_admin":false},"body":"@vrozov please see","created_at":"2018-04-19T09:13:47Z","updated_at":"2018-06-15T20:21:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d3e9cdd4d8458fd2a19809175ac1ac31fdaeb80","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/apex-core/pulls/595/commits","review_comments_url":"https://api.github.com/repos/apache/apex-core/pulls/595/comments","review_comment_url":"https://api.github.com/repos/apache/apex-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/apex-core/issues/595/comments","statuses_url":"https://api.github.com/repos/apache/apex-core/statuses/c8f939181c0deef8252bcc06c49f4f15040c2846","head":{"label":"PramodSSImmaneni:APEXCORE-810","ref":"APEXCORE-810","sha":"c8f939181c0deef8252bcc06c49f4f15040c2846","user":{"login":"PramodSSImmaneni","id":4418235,"node_id":"MDQ6VXNlcjQ0MTgyMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4418235?v=4","gravatar_id":"","url":"https://api.github.com/users/PramodSSImmaneni","html_url":"https://github.com/PramodSSImmaneni","followers_url":"https://api.github.com/users/PramodSSImmaneni/followers","following_url":"https://api.github.com/users/PramodSSImmaneni/following{/other_user}","gists_url":"https://api.github.com/users/PramodSSImmaneni/gists{/gist_id}","starred_url":"https://api.github.com/users/PramodSSImmaneni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PramodSSImmaneni/subscriptions","organizations_url":"https://api.github.com/users/PramodSSImmaneni/orgs","repos_url":"https://api.github.com/users/PramodSSImmaneni/repos","events_url":"https://api.github.com/users/PramodSSImmaneni/events{/privacy}","received_events_url":"https://api.github.com/users/PramodSSImmaneni/received_events","type":"User","site_admin":false},"repo":{"id":41446712,"node_id":"MDEwOlJlcG9zaXRvcnk0MTQ0NjcxMg==","name":"apex-core","full_name":"PramodSSImmaneni/apex-core","owner":{"login":"PramodSSImmaneni","id":4418235,"node_id":"MDQ6VXNlcjQ0MTgyMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4418235?v=4","gravatar_id":"","url":"https://api.github.com/users/PramodSSImmaneni","html_url":"https://github.com/PramodSSImmaneni","followers_url":"https://api.github.com/users/PramodSSImmaneni/followers","following_url":"https://api.github.com/users/PramodSSImmaneni/following{/other_user}","gists_url":"https://api.github.com/users/PramodSSImmaneni/gists{/gist_id}","starred_url":"https://api.github.com/users/PramodSSImmaneni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PramodSSImmaneni/subscriptions","organizations_url":"https://api.github.com/users/PramodSSImmaneni/orgs","repos_url":"https://api.github.com/users/PramodSSImmaneni/repos","events_url":"https://api.github.com/users/PramodSSImmaneni/events{/privacy}","received_events_url":"https://api.github.com/users/PramodSSImmaneni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PramodSSImmaneni/apex-core","description":"Mirror of Apache Apex core (Incubating)","fork":true,"url":"https://api.github.com/repos/PramodSSImmaneni/apex-core","forks_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/forks","keys_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/teams","hooks_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/hooks","issue_events_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/events","assignees_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/tags","blobs_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/languages","stargazers_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/stargazers","contributors_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/contributors","subscribers_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/subscribers","subscription_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/subscription","commits_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/merges","archive_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/downloads","issues_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/labels{/name}","releases_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/releases{/id}","deployments_url":"https://api.github.com/repos/PramodSSImmaneni/apex-core/deployments","created_at":"2015-08-26T19:53:26Z","updated_at":"2017-04-27T02:29:01Z","pushed_at":"2018-06-15T18:17:45Z","git_url":"git://github.com/PramodSSImmaneni/apex-core.git","ssh_url":"git@github.com:PramodSSImmaneni/apex-core.git","clone_url":"https://github.com/PramodSSImmaneni/apex-core.git","svn_url":"https://github.com/PramodSSImmaneni/apex-core","homepage":null,"size":14595,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1f5425dc5ac1d3452a3b37db0e4c61485af9c6e1","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":41348333,"node_id":"MDEwOlJlcG9zaXRvcnk0MTM0ODMzMw==","name":"apex-core","full_name":"apache/apex-core","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/apex-core","description":"Mirror of Apache Apex core","fork":false,"url":"https://api.github.com/repos/apache/apex-core","forks_url":"https://api.github.com/repos/apache/apex-core/forks","keys_url":"https://api.github.com/repos/apache/apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/apex-core/teams","hooks_url":"https://api.github.com/repos/apache/apex-core/hooks","issue_events_url":"https://api.github.com/repos/apache/apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/apache/apex-core/events","assignees_url":"https://api.github.com/repos/apache/apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/apache/apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/apache/apex-core/tags","blobs_url":"https://api.github.com/repos/apache/apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/apex-core/languages","stargazers_url":"https://api.github.com/repos/apache/apex-core/stargazers","contributors_url":"https://api.github.com/repos/apache/apex-core/contributors","subscribers_url":"https://api.github.com/repos/apache/apex-core/subscribers","subscription_url":"https://api.github.com/repos/apache/apex-core/subscription","commits_url":"https://api.github.com/repos/apache/apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/apache/apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/apex-core/merges","archive_url":"https://api.github.com/repos/apache/apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/apex-core/downloads","issues_url":"https://api.github.com/repos/apache/apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/apache/apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/apex-core/labels{/name}","releases_url":"https://api.github.com/repos/apache/apex-core/releases{/id}","deployments_url":"https://api.github.com/repos/apache/apex-core/deployments","created_at":"2015-08-25T07:00:05Z","updated_at":"2018-05-23T05:09:39Z","pushed_at":"2018-06-15T18:17:47Z","git_url":"git://github.com/apache/apex-core.git","ssh_url":"git@github.com:apache/apex-core.git","clone_url":"https://github.com/apache/apex-core.git","svn_url":"https://github.com/apache/apex-core","homepage":"","size":14725,"stargazers_count":290,"watchers_count":290,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":166,"open_issues":2,"watchers":290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/apex-core/pulls/595"},"html":{"href":"https://github.com/apache/apex-core/pull/595"},"issue":{"href":"https://api.github.com/repos/apache/apex-core/issues/595"},"comments":{"href":"https://api.github.com/repos/apache/apex-core/issues/595/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/apex-core/pulls/595/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/apex-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/apex-core/pulls/595/commits"},"statuses":{"href":"https://api.github.com/repos/apache/apex-core/statuses/c8f939181c0deef8252bcc06c49f4f15040c2846"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PramodSSImmaneni"}}