{"action":"created","issue":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/22329","repository_url":"https://api.github.com/repos/pandas-dev/pandas","labels_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22329/labels{/name}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22329/comments","events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22329/events","html_url":"https://github.com/pandas-dev/pandas/pull/22329","id":350251506,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTQ3Nzcx","number":22329,"title":"de-duplicate index validation code","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"labels":[{"id":211029535,"node_id":"MDU6TGFiZWwyMTEwMjk1MzU=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Clean","name":"Clean","color":"207de5","default":false},{"id":2822098,"node_id":"MDU6TGFiZWwyODIyMDk4","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Indexing","name":"Indexing","color":"0b02e1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-08-14T01:43:07Z","updated_at":"2018-08-14T21:11:25Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22329","html_url":"https://github.com/pandas-dev/pandas/pull/22329","diff_url":"https://github.com/pandas-dev/pandas/pull/22329.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/22329.patch"},"body":"There are currently 3 nearly-identical versions of this code.  I'm pretty sure the strictest one is the most-correct, so that is made into the only one."},"comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments/413017534","html_url":"https://github.com/pandas-dev/pandas/pull/22329#issuecomment-413017534","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22329","id":413017534,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzAxNzUzNA==","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T21:11:25Z","updated_at":"2018-08-14T21:11:25Z","author_association":"MEMBER","body":"Indistinguishable:\r\n\r\nMaster:\r\n```\r\nIn [2]: idx = pd.Int64Index(range(10**6))\r\n\r\nIn [3]: ser = pd.Series(idx, index=idx)\r\n\r\nIn [4]: %timeit idx.get_value(ser, 1000)\r\n10000 loops, best of 3: 26.6 µs per loop\r\n\r\nIn [5]: %timeit idx.get_value(ser, 1000)\r\n10000 loops, best of 3: 26.7 µs per loop\r\n\r\n```\r\n\r\nPR:\r\n```\r\nIn [2]: idx = pd.Int64Index(range(10**6))\r\n\r\nIn [3]: ser = pd.Series(idx, index=idx)\r\n\r\nIn [4]: %timeit idx.get_value(ser, 1000)\r\n10000 loops, best of 3: 26.8 µs per loop\r\n\r\nIn [5]: %timeit idx.get_value(ser, 1000)\r\n10000 loops, best of 3: 25.6 µs per loop\r\n```"}}
{"actor":{"display_login":"jbrockmendel"}}