{"action":"created","comment":{"url":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls/comments/239014349","pull_request_review_id":181692149,"id":239014349,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTAxNDM0OQ==","diff_hunk":"@@ -49,47 +54,41 @@ struct TaskIOFileInfo {\n class JPetTaskIO: public JPetTask\n {\n public:\n-\n   JPetTaskIO(const char* name = \"\", const char* in_file_type = \"\", const char* out_file_type = \"\");\n+  virtual ~JPetTaskIO();\n   virtual bool init(const JPetParams& inOptions) override;\n   virtual bool run(const JPetDataInterface& inData) override;\n   virtual bool terminate(JPetParams& outOptions) override;\n-  virtual ~JPetTaskIO();\n   virtual void addSubTask(std::unique_ptr<JPetTaskInterface> subTask) override;\n-  /// @brief Currently this method passes \"stopIteration_bool\" option from subTask to fParams if present.\n-  virtual JPetParams mergeWithExtraParams(const JPetParams& originalParams, const JPetParams& extraParams) const ;\n-\n+  void displayProgressBar(std::string taskName, int currentEventNumber, int numberOfEvents) const;\n+  virtual JPetParams mergeWithExtraParams(\n+    const JPetParams& originalParams, const JPetParams& extraParams\n+  ) const ;\n   void setParams(const JPetParams& opts);\n   JPetParams getParams() const;\n-  void displayProgressBar(int currentEventNumber, int numberOfEvents) const;\n-\n   bool isOutput() const;\n   bool isInput() const;\n \n protected:\n-  /// @return (isOK, inputFile, outputFileFullPath, isResetOutputPath) based on provided options. If isOK is set to false, that means that an error has occured.\n-  virtual std::tuple<bool, std::string, std::string, bool> setInputAndOutputFile(const jpet_options_tools::OptsStrAny options) const;\n+  virtual std::tuple<bool, std::string, std::string, bool> setInputAndOutputFile(","path":"Core/JPetTaskIO/JPetTaskIO.h","position":66,"original_position":66,"commit_id":"8df59570b93dbfb968d265c26adcabf11908aec6","original_commit_id":"8df59570b93dbfb968d265c26adcabf11908aec6","user":{"login":"wkrzemien","id":11519095,"node_id":"MDQ6VXNlcjExNTE5MDk1","avatar_url":"https://avatars3.githubusercontent.com/u/11519095?v=4","gravatar_id":"","url":"https://api.github.com/users/wkrzemien","html_url":"https://github.com/wkrzemien","followers_url":"https://api.github.com/users/wkrzemien/followers","following_url":"https://api.github.com/users/wkrzemien/following{/other_user}","gists_url":"https://api.github.com/users/wkrzemien/gists{/gist_id}","starred_url":"https://api.github.com/users/wkrzemien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkrzemien/subscriptions","organizations_url":"https://api.github.com/users/wkrzemien/orgs","repos_url":"https://api.github.com/users/wkrzemien/repos","events_url":"https://api.github.com/users/wkrzemien/events{/privacy}","received_events_url":"https://api.github.com/users/wkrzemien/received_events","type":"User","site_admin":false},"body":"why the doxygen comments are removed?","created_at":"2018-12-05T10:44:08Z","updated_at":"2018-12-05T10:44:08Z","html_url":"https://github.com/JPETTomography/j-pet-framework/pull/195#discussion_r239014349","pull_request_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls/195","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls/comments/239014349"},"html":{"href":"https://github.com/JPETTomography/j-pet-framework/pull/195#discussion_r239014349"},"pull_request":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls/195","id":226336728,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzM2NzI4","html_url":"https://github.com/JPETTomography/j-pet-framework/pull/195","diff_url":"https://github.com/JPETTomography/j-pet-framework/pull/195.diff","patch_url":"https://github.com/JPETTomography/j-pet-framework/pull/195.patch","issue_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/issues/195","number":195,"state":"open","locked":false,"title":"Progress bar with current task name","user":{"login":"kkacprzak","id":4140375,"node_id":"MDQ6VXNlcjQxNDAzNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4140375?v=4","gravatar_id":"","url":"https://api.github.com/users/kkacprzak","html_url":"https://github.com/kkacprzak","followers_url":"https://api.github.com/users/kkacprzak/followers","following_url":"https://api.github.com/users/kkacprzak/following{/other_user}","gists_url":"https://api.github.com/users/kkacprzak/gists{/gist_id}","starred_url":"https://api.github.com/users/kkacprzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkacprzak/subscriptions","organizations_url":"https://api.github.com/users/kkacprzak/orgs","repos_url":"https://api.github.com/users/kkacprzak/repos","events_url":"https://api.github.com/users/kkacprzak/events{/privacy}","received_events_url":"https://api.github.com/users/kkacprzak/received_events","type":"User","site_admin":false},"body":"This is a low-priority PR with adding a name of the task to progress bar, so it not only displays done percentage. It is useful when there are more than one task in chain, so current module name is visible.","created_at":"2018-10-28T01:42:52Z","updated_at":"2018-12-05T10:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1751d60a0f000ada53ae0a0c501265c22c3b55b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls/195/commits","review_comments_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls/195/comments","review_comment_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/issues/195/comments","statuses_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/statuses/8df59570b93dbfb968d265c26adcabf11908aec6","head":{"label":"kkacprzak:barTaskName","ref":"barTaskName","sha":"8df59570b93dbfb968d265c26adcabf11908aec6","user":{"login":"kkacprzak","id":4140375,"node_id":"MDQ6VXNlcjQxNDAzNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4140375?v=4","gravatar_id":"","url":"https://api.github.com/users/kkacprzak","html_url":"https://github.com/kkacprzak","followers_url":"https://api.github.com/users/kkacprzak/followers","following_url":"https://api.github.com/users/kkacprzak/following{/other_user}","gists_url":"https://api.github.com/users/kkacprzak/gists{/gist_id}","starred_url":"https://api.github.com/users/kkacprzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkacprzak/subscriptions","organizations_url":"https://api.github.com/users/kkacprzak/orgs","repos_url":"https://api.github.com/users/kkacprzak/repos","events_url":"https://api.github.com/users/kkacprzak/events{/privacy}","received_events_url":"https://api.github.com/users/kkacprzak/received_events","type":"User","site_admin":false},"repo":{"id":119265051,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkyNjUwNTE=","name":"j-pet-framework","full_name":"kkacprzak/j-pet-framework","private":false,"owner":{"login":"kkacprzak","id":4140375,"node_id":"MDQ6VXNlcjQxNDAzNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4140375?v=4","gravatar_id":"","url":"https://api.github.com/users/kkacprzak","html_url":"https://github.com/kkacprzak","followers_url":"https://api.github.com/users/kkacprzak/followers","following_url":"https://api.github.com/users/kkacprzak/following{/other_user}","gists_url":"https://api.github.com/users/kkacprzak/gists{/gist_id}","starred_url":"https://api.github.com/users/kkacprzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkacprzak/subscriptions","organizations_url":"https://api.github.com/users/kkacprzak/orgs","repos_url":"https://api.github.com/users/kkacprzak/repos","events_url":"https://api.github.com/users/kkacprzak/events{/privacy}","received_events_url":"https://api.github.com/users/kkacprzak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kkacprzak/j-pet-framework","description":"J-PET Analysis Framework","fork":true,"url":"https://api.github.com/repos/kkacprzak/j-pet-framework","forks_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/forks","keys_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/teams","hooks_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/hooks","issue_events_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/issues/events{/number}","events_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/events","assignees_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/assignees{/user}","branches_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/branches{/branch}","tags_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/tags","blobs_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/languages","stargazers_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/stargazers","contributors_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/contributors","subscribers_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/subscribers","subscription_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/subscription","commits_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/contents/{+path}","compare_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/merges","archive_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/downloads","issues_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/issues{/number}","pulls_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/labels{/name}","releases_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/releases{/id}","deployments_url":"https://api.github.com/repos/kkacprzak/j-pet-framework/deployments","created_at":"2018-01-28T14:20:54Z","updated_at":"2018-07-16T15:54:12Z","pushed_at":"2018-10-28T01:24:33Z","git_url":"git://github.com/kkacprzak/j-pet-framework.git","ssh_url":"git@github.com:kkacprzak/j-pet-framework.git","clone_url":"https://github.com/kkacprzak/j-pet-framework.git","svn_url":"https://github.com/kkacprzak/j-pet-framework","homepage":null,"size":5600,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JPETTomography:develop","ref":"develop","sha":"863228839d3b96dac47389d84a26551cfb24472d","user":{"login":"JPETTomography","id":19532701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzAx","avatar_url":"https://avatars0.githubusercontent.com/u/19532701?v=4","gravatar_id":"","url":"https://api.github.com/users/JPETTomography","html_url":"https://github.com/JPETTomography","followers_url":"https://api.github.com/users/JPETTomography/followers","following_url":"https://api.github.com/users/JPETTomography/following{/other_user}","gists_url":"https://api.github.com/users/JPETTomography/gists{/gist_id}","starred_url":"https://api.github.com/users/JPETTomography/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JPETTomography/subscriptions","organizations_url":"https://api.github.com/users/JPETTomography/orgs","repos_url":"https://api.github.com/users/JPETTomography/repos","events_url":"https://api.github.com/users/JPETTomography/events{/privacy}","received_events_url":"https://api.github.com/users/JPETTomography/received_events","type":"Organization","site_admin":false},"repo":{"id":61390073,"node_id":"MDEwOlJlcG9zaXRvcnk2MTM5MDA3Mw==","name":"j-pet-framework","full_name":"JPETTomography/j-pet-framework","private":false,"owner":{"login":"JPETTomography","id":19532701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzAx","avatar_url":"https://avatars0.githubusercontent.com/u/19532701?v=4","gravatar_id":"","url":"https://api.github.com/users/JPETTomography","html_url":"https://github.com/JPETTomography","followers_url":"https://api.github.com/users/JPETTomography/followers","following_url":"https://api.github.com/users/JPETTomography/following{/other_user}","gists_url":"https://api.github.com/users/JPETTomography/gists{/gist_id}","starred_url":"https://api.github.com/users/JPETTomography/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JPETTomography/subscriptions","organizations_url":"https://api.github.com/users/JPETTomography/orgs","repos_url":"https://api.github.com/users/JPETTomography/repos","events_url":"https://api.github.com/users/JPETTomography/events{/privacy}","received_events_url":"https://api.github.com/users/JPETTomography/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JPETTomography/j-pet-framework","description":"J-PET Analysis Framework","fork":false,"url":"https://api.github.com/repos/JPETTomography/j-pet-framework","forks_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/forks","keys_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/teams","hooks_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/hooks","issue_events_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/issues/events{/number}","events_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/events","assignees_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/assignees{/user}","branches_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/branches{/branch}","tags_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/tags","blobs_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/languages","stargazers_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/stargazers","contributors_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/contributors","subscribers_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/subscribers","subscription_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/subscription","commits_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/contents/{+path}","compare_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/merges","archive_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/downloads","issues_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/issues{/number}","pulls_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/labels{/name}","releases_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/releases{/id}","deployments_url":"https://api.github.com/repos/JPETTomography/j-pet-framework/deployments","created_at":"2016-06-17T17:17:42Z","updated_at":"2018-05-02T16:32:46Z","pushed_at":"2018-12-05T10:14:49Z","git_url":"git://github.com/JPETTomography/j-pet-framework.git","ssh_url":"git@github.com:JPETTomography/j-pet-framework.git","clone_url":"https://github.com/JPETTomography/j-pet-framework.git","svn_url":"https://github.com/JPETTomography/j-pet-framework","homepage":null,"size":5605,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":7,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls/195"},"html":{"href":"https://github.com/JPETTomography/j-pet-framework/pull/195"},"issue":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework/issues/195"},"comments":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework/statuses/8df59570b93dbfb968d265c26adcabf11908aec6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wkrzemien"}}