{"action":"created","comment":{"url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/comments/202034162","pull_request_review_id":136646147,"id":202034162,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjAzNDE2Mg==","diff_hunk":"@@ -384,6 +384,77 @@ def test_driver_records_metadata(self):\n         }\n         assertDriverMetadataRecorded(self, expected_driver_metadata)\n \n+    def test_system_records_no_metadata(self):\n+        prob = Problem(model=SellarDerivatives())\n+\n+        recorder = SqliteRecorder(\"cases.sql\")\n+        prob.model.add_recorder(recorder)\n+        prob.model.recording_options['record_model_metadata'] = False\n+        prob.model.recording_options['record_metadata'] = False\n+\n+        prob.setup()\n+        prob.run_model()\n+        prob.cleanup()\n+\n+        cr = CaseReader(\"cases.sql\")\n+        self.assertEqual(len(cr.system_metadata.keys()), 0)\n+\n+    def test_system_record_model_metadata(self):\n+        # first check to see if recorded recursively, which is the default\n+        prob = Problem(model=SellarDerivatives())\n+        prob.setup()\n+\n+        recorder = SqliteRecorder(\"cases.sql\")\n+        prob.model.add_recorder(recorder)\n+\n+        prob.run_model()\n+        prob.cleanup()\n+\n+        cr = CaseReader(\"cases.sql\")\n+        self.assertEqual(set(cr.system_metadata.keys()),\n+                         set(['root', 'px', 'pz', 'd1', 'd2', 'obj_cmp', 'con_cmp1', 'con_cmp2']))","path":"openmdao/recorders/tests/test_sqlite_recorder.py","position":32,"original_position":32,"commit_id":"9afeb507f587f4a5b1f829fceec01ae7030809e1","original_commit_id":"9afeb507f587f4a5b1f829fceec01ae7030809e1","user":{"login":"Kenneth-T-Moore","id":867917,"node_id":"MDQ6VXNlcjg2NzkxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/867917?v=4","gravatar_id":"","url":"https://api.github.com/users/Kenneth-T-Moore","html_url":"https://github.com/Kenneth-T-Moore","followers_url":"https://api.github.com/users/Kenneth-T-Moore/followers","following_url":"https://api.github.com/users/Kenneth-T-Moore/following{/other_user}","gists_url":"https://api.github.com/users/Kenneth-T-Moore/gists{/gist_id}","starred_url":"https://api.github.com/users/Kenneth-T-Moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kenneth-T-Moore/subscriptions","organizations_url":"https://api.github.com/users/Kenneth-T-Moore/orgs","repos_url":"https://api.github.com/users/Kenneth-T-Moore/repos","events_url":"https://api.github.com/users/Kenneth-T-Moore/events{/privacy}","received_events_url":"https://api.github.com/users/Kenneth-T-Moore/received_events","type":"User","site_admin":false},"body":"To be safe on all these tests, maybe you want to check the values too?","created_at":"2018-07-12T13:30:04Z","updated_at":"2018-07-12T13:30:24Z","html_url":"https://github.com/OpenMDAO/OpenMDAO/pull/697#discussion_r202034162","pull_request_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/697","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/comments/202034162"},"html":{"href":"https://github.com/OpenMDAO/OpenMDAO/pull/697#discussion_r202034162"},"pull_request":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/697"}}},"pull_request":{"url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/697","id":200985963,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwOTg1OTYz","html_url":"https://github.com/OpenMDAO/OpenMDAO/pull/697","diff_url":"https://github.com/OpenMDAO/OpenMDAO/pull/697.diff","patch_url":"https://github.com/OpenMDAO/OpenMDAO/pull/697.patch","issue_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/697","number":697,"state":"open","locked":false,"title":"P158161973 model metadata optionally should be recorded","user":{"login":"hschilling","id":867557,"node_id":"MDQ6VXNlcjg2NzU1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/867557?v=4","gravatar_id":"","url":"https://api.github.com/users/hschilling","html_url":"https://github.com/hschilling","followers_url":"https://api.github.com/users/hschilling/followers","following_url":"https://api.github.com/users/hschilling/following{/other_user}","gists_url":"https://api.github.com/users/hschilling/gists{/gist_id}","starred_url":"https://api.github.com/users/hschilling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hschilling/subscriptions","organizations_url":"https://api.github.com/users/hschilling/orgs","repos_url":"https://api.github.com/users/hschilling/repos","events_url":"https://api.github.com/users/hschilling/events{/privacy}","received_events_url":"https://api.github.com/users/hschilling/received_events","type":"User","site_admin":false},"body":"Original story was:\r\n\r\nIf a recorder is attached to a system object, the metadata for that system and all systems below it should be recorded by default. If the recorder is attached to the driver or root, it should record the metadata for all systems by default.\r\n\r\nFollowed up by this simplification from Justin:\r\n\r\n1) if you record any system meta-data you record it all (regardless of where its saved to) (edited)\r\n2) i think the option should just be called `record_model_metadata` for both systems and driver. The docs can make it clear that this means ALL metadata from all groups/components will be saved\r\n\r\nAlso fixed the fact that `record_metadata` option on System was never used. Added test for that.","created_at":"2018-07-12T12:33:02Z","updated_at":"2018-07-12T13:30:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7e63ec9db67cbf8d235122d23713673f7738e0a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/697/commits","review_comments_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/697/comments","review_comment_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/697/comments","statuses_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/statuses/9afeb507f587f4a5b1f829fceec01ae7030809e1","head":{"label":"hschilling:P158161973-metadata-record-recurse","ref":"P158161973-metadata-record-recurse","sha":"9afeb507f587f4a5b1f829fceec01ae7030809e1","user":{"login":"hschilling","id":867557,"node_id":"MDQ6VXNlcjg2NzU1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/867557?v=4","gravatar_id":"","url":"https://api.github.com/users/hschilling","html_url":"https://github.com/hschilling","followers_url":"https://api.github.com/users/hschilling/followers","following_url":"https://api.github.com/users/hschilling/following{/other_user}","gists_url":"https://api.github.com/users/hschilling/gists{/gist_id}","starred_url":"https://api.github.com/users/hschilling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hschilling/subscriptions","organizations_url":"https://api.github.com/users/hschilling/orgs","repos_url":"https://api.github.com/users/hschilling/repos","events_url":"https://api.github.com/users/hschilling/events{/privacy}","received_events_url":"https://api.github.com/users/hschilling/received_events","type":"User","site_admin":false},"repo":{"id":97748224,"node_id":"MDEwOlJlcG9zaXRvcnk5Nzc0ODIyNA==","name":"OpenMDAO","full_name":"hschilling/OpenMDAO","owner":{"login":"hschilling","id":867557,"node_id":"MDQ6VXNlcjg2NzU1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/867557?v=4","gravatar_id":"","url":"https://api.github.com/users/hschilling","html_url":"https://github.com/hschilling","followers_url":"https://api.github.com/users/hschilling/followers","following_url":"https://api.github.com/users/hschilling/following{/other_user}","gists_url":"https://api.github.com/users/hschilling/gists{/gist_id}","starred_url":"https://api.github.com/users/hschilling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hschilling/subscriptions","organizations_url":"https://api.github.com/users/hschilling/orgs","repos_url":"https://api.github.com/users/hschilling/repos","events_url":"https://api.github.com/users/hschilling/events{/privacy}","received_events_url":"https://api.github.com/users/hschilling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hschilling/OpenMDAO","description":null,"fork":true,"url":"https://api.github.com/repos/hschilling/OpenMDAO","forks_url":"https://api.github.com/repos/hschilling/OpenMDAO/forks","keys_url":"https://api.github.com/repos/hschilling/OpenMDAO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hschilling/OpenMDAO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hschilling/OpenMDAO/teams","hooks_url":"https://api.github.com/repos/hschilling/OpenMDAO/hooks","issue_events_url":"https://api.github.com/repos/hschilling/OpenMDAO/issues/events{/number}","events_url":"https://api.github.com/repos/hschilling/OpenMDAO/events","assignees_url":"https://api.github.com/repos/hschilling/OpenMDAO/assignees{/user}","branches_url":"https://api.github.com/repos/hschilling/OpenMDAO/branches{/branch}","tags_url":"https://api.github.com/repos/hschilling/OpenMDAO/tags","blobs_url":"https://api.github.com/repos/hschilling/OpenMDAO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hschilling/OpenMDAO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hschilling/OpenMDAO/git/refs{/sha}","trees_url":"https://api.github.com/repos/hschilling/OpenMDAO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hschilling/OpenMDAO/statuses/{sha}","languages_url":"https://api.github.com/repos/hschilling/OpenMDAO/languages","stargazers_url":"https://api.github.com/repos/hschilling/OpenMDAO/stargazers","contributors_url":"https://api.github.com/repos/hschilling/OpenMDAO/contributors","subscribers_url":"https://api.github.com/repos/hschilling/OpenMDAO/subscribers","subscription_url":"https://api.github.com/repos/hschilling/OpenMDAO/subscription","commits_url":"https://api.github.com/repos/hschilling/OpenMDAO/commits{/sha}","git_commits_url":"https://api.github.com/repos/hschilling/OpenMDAO/git/commits{/sha}","comments_url":"https://api.github.com/repos/hschilling/OpenMDAO/comments{/number}","issue_comment_url":"https://api.github.com/repos/hschilling/OpenMDAO/issues/comments{/number}","contents_url":"https://api.github.com/repos/hschilling/OpenMDAO/contents/{+path}","compare_url":"https://api.github.com/repos/hschilling/OpenMDAO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hschilling/OpenMDAO/merges","archive_url":"https://api.github.com/repos/hschilling/OpenMDAO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hschilling/OpenMDAO/downloads","issues_url":"https://api.github.com/repos/hschilling/OpenMDAO/issues{/number}","pulls_url":"https://api.github.com/repos/hschilling/OpenMDAO/pulls{/number}","milestones_url":"https://api.github.com/repos/hschilling/OpenMDAO/milestones{/number}","notifications_url":"https://api.github.com/repos/hschilling/OpenMDAO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hschilling/OpenMDAO/labels{/name}","releases_url":"https://api.github.com/repos/hschilling/OpenMDAO/releases{/id}","deployments_url":"https://api.github.com/repos/hschilling/OpenMDAO/deployments","created_at":"2017-07-19T18:22:33Z","updated_at":"2017-10-30T18:17:25Z","pushed_at":"2018-07-12T12:13:54Z","git_url":"git://github.com/hschilling/OpenMDAO.git","ssh_url":"git@github.com:hschilling/OpenMDAO.git","clone_url":"https://github.com/hschilling/OpenMDAO.git","svn_url":"https://github.com/hschilling/OpenMDAO","homepage":null,"size":13766,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenMDAO:master","ref":"master","sha":"38254231ce95a05ed24c94def9c94009073b42d9","user":{"login":"OpenMDAO","id":861615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MTYxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/861615?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMDAO","html_url":"https://github.com/OpenMDAO","followers_url":"https://api.github.com/users/OpenMDAO/followers","following_url":"https://api.github.com/users/OpenMDAO/following{/other_user}","gists_url":"https://api.github.com/users/OpenMDAO/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMDAO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMDAO/subscriptions","organizations_url":"https://api.github.com/users/OpenMDAO/orgs","repos_url":"https://api.github.com/users/OpenMDAO/repos","events_url":"https://api.github.com/users/OpenMDAO/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMDAO/received_events","type":"Organization","site_admin":false},"repo":{"id":66572302,"node_id":"MDEwOlJlcG9zaXRvcnk2NjU3MjMwMg==","name":"OpenMDAO","full_name":"OpenMDAO/OpenMDAO","owner":{"login":"OpenMDAO","id":861615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MTYxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/861615?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMDAO","html_url":"https://github.com/OpenMDAO","followers_url":"https://api.github.com/users/OpenMDAO/followers","following_url":"https://api.github.com/users/OpenMDAO/following{/other_user}","gists_url":"https://api.github.com/users/OpenMDAO/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMDAO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMDAO/subscriptions","organizations_url":"https://api.github.com/users/OpenMDAO/orgs","repos_url":"https://api.github.com/users/OpenMDAO/repos","events_url":"https://api.github.com/users/OpenMDAO/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMDAO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMDAO/OpenMDAO","description":"OpenMDAO 2.0 repository. ","fork":false,"url":"https://api.github.com/repos/OpenMDAO/OpenMDAO","forks_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/forks","keys_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/teams","hooks_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/hooks","issue_events_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/events","assignees_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/tags","blobs_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/languages","stargazers_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/stargazers","contributors_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/contributors","subscribers_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/subscribers","subscription_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/subscription","commits_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/merges","archive_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/downloads","issues_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/labels{/name}","releases_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/deployments","created_at":"2016-08-25T15:53:25Z","updated_at":"2018-07-11T19:46:31Z","pushed_at":"2018-07-12T12:33:03Z","git_url":"git://github.com/OpenMDAO/OpenMDAO.git","ssh_url":"git@github.com:OpenMDAO/OpenMDAO.git","clone_url":"https://github.com/OpenMDAO/OpenMDAO.git","svn_url":"https://github.com/OpenMDAO/OpenMDAO","homepage":"http://openmdao.org","size":13650,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":38,"open_issues":10,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/697"},"html":{"href":"https://github.com/OpenMDAO/OpenMDAO/pull/697"},"issue":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/697"},"comments":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/697/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/697/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/697/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/statuses/9afeb507f587f4a5b1f829fceec01ae7030809e1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Kenneth-T-Moore"}}