{"action":"created","comment":{"url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/comments/183361801","pull_request_review_id":114343149,"id":183361801,"diff_hunk":"@@ -4,74 +4,131 @@\n from __future__ import unicode_literals\n \n import logging\n+import typing\n \n-import numpy as np\n+from inspect import signature","path":"rasa_core/policies/policy.py","position":7,"original_position":7,"commit_id":"dfcaa12ad5b08fd7df26dcb6b419fe237fd25648","original_commit_id":"afa0885885a7a51dac78698bb4011368066c16d1","user":{"login":"akelad","id":32450038,"avatar_url":"https://avatars3.githubusercontent.com/u/32450038?v=4","gravatar_id":"","url":"https://api.github.com/users/akelad","html_url":"https://github.com/akelad","followers_url":"https://api.github.com/users/akelad/followers","following_url":"https://api.github.com/users/akelad/following{/other_user}","gists_url":"https://api.github.com/users/akelad/gists{/gist_id}","starred_url":"https://api.github.com/users/akelad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akelad/subscriptions","organizations_url":"https://api.github.com/users/akelad/orgs","repos_url":"https://api.github.com/users/akelad/repos","events_url":"https://api.github.com/users/akelad/events{/privacy}","received_events_url":"https://api.github.com/users/akelad/received_events","type":"User","site_admin":false},"body":"i've fixed it with using `valid_keys = getargspec(func).args` instead, as far as i know it does the same thing , it just returns a list instead of a dict","created_at":"2018-04-23T11:32:04Z","updated_at":"2018-04-23T11:32:04Z","html_url":"https://github.com/RasaHQ/rasa_core/pull/301#discussion_r183361801","pull_request_url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/301","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/comments/183361801"},"html":{"href":"https://github.com/RasaHQ/rasa_core/pull/301#discussion_r183361801"},"pull_request":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/301"}},"in_reply_to_id":183353918},"pull_request":{"url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/301","id":176774318,"html_url":"https://github.com/RasaHQ/rasa_core/pull/301","diff_url":"https://github.com/RasaHQ/rasa_core/pull/301.diff","patch_url":"https://github.com/RasaHQ/rasa_core/pull/301.patch","issue_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues/301","number":301,"state":"open","locked":false,"title":"Simpler generator","user":{"login":"amn41","id":5114084,"avatar_url":"https://avatars3.githubusercontent.com/u/5114084?v=4","gravatar_id":"","url":"https://api.github.com/users/amn41","html_url":"https://github.com/amn41","followers_url":"https://api.github.com/users/amn41/followers","following_url":"https://api.github.com/users/amn41/following{/other_user}","gists_url":"https://api.github.com/users/amn41/gists{/gist_id}","starred_url":"https://api.github.com/users/amn41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amn41/subscriptions","organizations_url":"https://api.github.com/users/amn41/orgs","repos_url":"https://api.github.com/users/amn41/repos","events_url":"https://api.github.com/users/amn41/events{/privacy}","received_events_url":"https://api.github.com/users/amn41/received_events","type":"User","site_admin":false},"body":"**Proposed changes**:\r\n- keras policy now fits entire dialogue sequences simultaneously or slices of history to a single action, depending on the Featurizer provided\r\n- let the `Featurizer` class do the featurization\r\n- `generate()` just returns a list of finished trackers\r\n- `max_history` now an attribute of the featurizer\r\n- separate method for featurizing labels in Featurizer class\r\n\r\nTODO:\r\n- implement rest of `TrainingData` methods (or drop them)\r\n- possibly compose `Featurizer` from both an `InputFeaturizer` and `LabelFeaturizer` to allow mixing and matching\r\n- add backwards compatible mode for sklearn & other policies\r\n\r\n- fixes #286\r\n\r\n**Status (please check what you already did)**:\r\n- [x] made PR ready for code review\r\n- [ ] added some tests for the functionality\r\n- [ ] updated the documentation\r\n- [ ] updated the changelog\r\n","created_at":"2018-03-22T13:15:32Z","updated_at":"2018-04-23T11:32:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"533279bae55600766a178e056183d095f0f20a5b","assignee":{"login":"Ghostvv","id":4136956,"avatar_url":"https://avatars1.githubusercontent.com/u/4136956?v=4","gravatar_id":"","url":"https://api.github.com/users/Ghostvv","html_url":"https://github.com/Ghostvv","followers_url":"https://api.github.com/users/Ghostvv/followers","following_url":"https://api.github.com/users/Ghostvv/following{/other_user}","gists_url":"https://api.github.com/users/Ghostvv/gists{/gist_id}","starred_url":"https://api.github.com/users/Ghostvv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ghostvv/subscriptions","organizations_url":"https://api.github.com/users/Ghostvv/orgs","repos_url":"https://api.github.com/users/Ghostvv/repos","events_url":"https://api.github.com/users/Ghostvv/events{/privacy}","received_events_url":"https://api.github.com/users/Ghostvv/received_events","type":"User","site_admin":false},"assignees":[{"login":"Ghostvv","id":4136956,"avatar_url":"https://avatars1.githubusercontent.com/u/4136956?v=4","gravatar_id":"","url":"https://api.github.com/users/Ghostvv","html_url":"https://github.com/Ghostvv","followers_url":"https://api.github.com/users/Ghostvv/followers","following_url":"https://api.github.com/users/Ghostvv/following{/other_user}","gists_url":"https://api.github.com/users/Ghostvv/gists{/gist_id}","starred_url":"https://api.github.com/users/Ghostvv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ghostvv/subscriptions","organizations_url":"https://api.github.com/users/Ghostvv/orgs","repos_url":"https://api.github.com/users/Ghostvv/repos","events_url":"https://api.github.com/users/Ghostvv/events{/privacy}","received_events_url":"https://api.github.com/users/Ghostvv/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/301/commits","review_comments_url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/301/comments","review_comment_url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues/301/comments","statuses_url":"https://api.github.com/repos/RasaHQ/rasa_core/statuses/dfcaa12ad5b08fd7df26dcb6b419fe237fd25648","head":{"label":"RasaHQ:simpler_generator","ref":"simpler_generator","sha":"dfcaa12ad5b08fd7df26dcb6b419fe237fd25648","user":{"login":"RasaHQ","id":21214473,"avatar_url":"https://avatars0.githubusercontent.com/u/21214473?v=4","gravatar_id":"","url":"https://api.github.com/users/RasaHQ","html_url":"https://github.com/RasaHQ","followers_url":"https://api.github.com/users/RasaHQ/followers","following_url":"https://api.github.com/users/RasaHQ/following{/other_user}","gists_url":"https://api.github.com/users/RasaHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/RasaHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RasaHQ/subscriptions","organizations_url":"https://api.github.com/users/RasaHQ/orgs","repos_url":"https://api.github.com/users/RasaHQ/repos","events_url":"https://api.github.com/users/RasaHQ/events{/privacy}","received_events_url":"https://api.github.com/users/RasaHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":103934044,"name":"rasa_core","full_name":"RasaHQ/rasa_core","owner":{"login":"RasaHQ","id":21214473,"avatar_url":"https://avatars0.githubusercontent.com/u/21214473?v=4","gravatar_id":"","url":"https://api.github.com/users/RasaHQ","html_url":"https://github.com/RasaHQ","followers_url":"https://api.github.com/users/RasaHQ/followers","following_url":"https://api.github.com/users/RasaHQ/following{/other_user}","gists_url":"https://api.github.com/users/RasaHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/RasaHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RasaHQ/subscriptions","organizations_url":"https://api.github.com/users/RasaHQ/orgs","repos_url":"https://api.github.com/users/RasaHQ/repos","events_url":"https://api.github.com/users/RasaHQ/events{/privacy}","received_events_url":"https://api.github.com/users/RasaHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RasaHQ/rasa_core","description":"machine learning based dialogue engine for conversational software","fork":false,"url":"https://api.github.com/repos/RasaHQ/rasa_core","forks_url":"https://api.github.com/repos/RasaHQ/rasa_core/forks","keys_url":"https://api.github.com/repos/RasaHQ/rasa_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RasaHQ/rasa_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RasaHQ/rasa_core/teams","hooks_url":"https://api.github.com/repos/RasaHQ/rasa_core/hooks","issue_events_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues/events{/number}","events_url":"https://api.github.com/repos/RasaHQ/rasa_core/events","assignees_url":"https://api.github.com/repos/RasaHQ/rasa_core/assignees{/user}","branches_url":"https://api.github.com/repos/RasaHQ/rasa_core/branches{/branch}","tags_url":"https://api.github.com/repos/RasaHQ/rasa_core/tags","blobs_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RasaHQ/rasa_core/statuses/{sha}","languages_url":"https://api.github.com/repos/RasaHQ/rasa_core/languages","stargazers_url":"https://api.github.com/repos/RasaHQ/rasa_core/stargazers","contributors_url":"https://api.github.com/repos/RasaHQ/rasa_core/contributors","subscribers_url":"https://api.github.com/repos/RasaHQ/rasa_core/subscribers","subscription_url":"https://api.github.com/repos/RasaHQ/rasa_core/subscription","commits_url":"https://api.github.com/repos/RasaHQ/rasa_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RasaHQ/rasa_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RasaHQ/rasa_core/contents/{+path}","compare_url":"https://api.github.com/repos/RasaHQ/rasa_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RasaHQ/rasa_core/merges","archive_url":"https://api.github.com/repos/RasaHQ/rasa_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RasaHQ/rasa_core/downloads","issues_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues{/number}","pulls_url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls{/number}","milestones_url":"https://api.github.com/repos/RasaHQ/rasa_core/milestones{/number}","notifications_url":"https://api.github.com/repos/RasaHQ/rasa_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RasaHQ/rasa_core/labels{/name}","releases_url":"https://api.github.com/repos/RasaHQ/rasa_core/releases{/id}","deployments_url":"https://api.github.com/repos/RasaHQ/rasa_core/deployments","created_at":"2017-09-18T12:07:12Z","updated_at":"2018-04-23T10:42:25Z","pushed_at":"2018-04-23T11:30:45Z","git_url":"git://github.com/RasaHQ/rasa_core.git","ssh_url":"git@github.com:RasaHQ/rasa_core.git","clone_url":"https://github.com/RasaHQ/rasa_core.git","svn_url":"https://github.com/RasaHQ/rasa_core","homepage":"https://core.rasa.com","size":18561,"stargazers_count":678,"watchers_count":678,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":332,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":332,"open_issues":101,"watchers":678,"default_branch":"master"}},"base":{"label":"RasaHQ:master","ref":"master","sha":"811d42b1d29c40a42d7dee345572ce73330b8360","user":{"login":"RasaHQ","id":21214473,"avatar_url":"https://avatars0.githubusercontent.com/u/21214473?v=4","gravatar_id":"","url":"https://api.github.com/users/RasaHQ","html_url":"https://github.com/RasaHQ","followers_url":"https://api.github.com/users/RasaHQ/followers","following_url":"https://api.github.com/users/RasaHQ/following{/other_user}","gists_url":"https://api.github.com/users/RasaHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/RasaHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RasaHQ/subscriptions","organizations_url":"https://api.github.com/users/RasaHQ/orgs","repos_url":"https://api.github.com/users/RasaHQ/repos","events_url":"https://api.github.com/users/RasaHQ/events{/privacy}","received_events_url":"https://api.github.com/users/RasaHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":103934044,"name":"rasa_core","full_name":"RasaHQ/rasa_core","owner":{"login":"RasaHQ","id":21214473,"avatar_url":"https://avatars0.githubusercontent.com/u/21214473?v=4","gravatar_id":"","url":"https://api.github.com/users/RasaHQ","html_url":"https://github.com/RasaHQ","followers_url":"https://api.github.com/users/RasaHQ/followers","following_url":"https://api.github.com/users/RasaHQ/following{/other_user}","gists_url":"https://api.github.com/users/RasaHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/RasaHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RasaHQ/subscriptions","organizations_url":"https://api.github.com/users/RasaHQ/orgs","repos_url":"https://api.github.com/users/RasaHQ/repos","events_url":"https://api.github.com/users/RasaHQ/events{/privacy}","received_events_url":"https://api.github.com/users/RasaHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RasaHQ/rasa_core","description":"machine learning based dialogue engine for conversational software","fork":false,"url":"https://api.github.com/repos/RasaHQ/rasa_core","forks_url":"https://api.github.com/repos/RasaHQ/rasa_core/forks","keys_url":"https://api.github.com/repos/RasaHQ/rasa_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RasaHQ/rasa_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RasaHQ/rasa_core/teams","hooks_url":"https://api.github.com/repos/RasaHQ/rasa_core/hooks","issue_events_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues/events{/number}","events_url":"https://api.github.com/repos/RasaHQ/rasa_core/events","assignees_url":"https://api.github.com/repos/RasaHQ/rasa_core/assignees{/user}","branches_url":"https://api.github.com/repos/RasaHQ/rasa_core/branches{/branch}","tags_url":"https://api.github.com/repos/RasaHQ/rasa_core/tags","blobs_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RasaHQ/rasa_core/statuses/{sha}","languages_url":"https://api.github.com/repos/RasaHQ/rasa_core/languages","stargazers_url":"https://api.github.com/repos/RasaHQ/rasa_core/stargazers","contributors_url":"https://api.github.com/repos/RasaHQ/rasa_core/contributors","subscribers_url":"https://api.github.com/repos/RasaHQ/rasa_core/subscribers","subscription_url":"https://api.github.com/repos/RasaHQ/rasa_core/subscription","commits_url":"https://api.github.com/repos/RasaHQ/rasa_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RasaHQ/rasa_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RasaHQ/rasa_core/contents/{+path}","compare_url":"https://api.github.com/repos/RasaHQ/rasa_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RasaHQ/rasa_core/merges","archive_url":"https://api.github.com/repos/RasaHQ/rasa_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RasaHQ/rasa_core/downloads","issues_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues{/number}","pulls_url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls{/number}","milestones_url":"https://api.github.com/repos/RasaHQ/rasa_core/milestones{/number}","notifications_url":"https://api.github.com/repos/RasaHQ/rasa_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RasaHQ/rasa_core/labels{/name}","releases_url":"https://api.github.com/repos/RasaHQ/rasa_core/releases{/id}","deployments_url":"https://api.github.com/repos/RasaHQ/rasa_core/deployments","created_at":"2017-09-18T12:07:12Z","updated_at":"2018-04-23T10:42:25Z","pushed_at":"2018-04-23T11:30:45Z","git_url":"git://github.com/RasaHQ/rasa_core.git","ssh_url":"git@github.com:RasaHQ/rasa_core.git","clone_url":"https://github.com/RasaHQ/rasa_core.git","svn_url":"https://github.com/RasaHQ/rasa_core","homepage":"https://core.rasa.com","size":18561,"stargazers_count":678,"watchers_count":678,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":332,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":332,"open_issues":101,"watchers":678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/301"},"html":{"href":"https://github.com/RasaHQ/rasa_core/pull/301"},"issue":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/issues/301"},"comments":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/statuses/dfcaa12ad5b08fd7df26dcb6b419fe237fd25648"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"akelad"}}