{"action":"created","issue":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/14044","repository_url":"https://api.github.com/repos/brave/browser-laptop","labels_url":"https://api.github.com/repos/brave/browser-laptop/issues/14044/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/14044/comments","events_url":"https://api.github.com/repos/brave/browser-laptop/issues/14044/events","html_url":"https://github.com/brave/browser-laptop/issues/14044","id":320890812,"number":14044,"title":"command/ctrl + clicking on websites with certificate issues will result in a \"The site can't be reached\" page","user":{"login":"kjozwiak","id":2602313,"avatar_url":"https://avatars0.githubusercontent.com/u/2602313?v=4","gravatar_id":"","url":"https://api.github.com/users/kjozwiak","html_url":"https://github.com/kjozwiak","followers_url":"https://api.github.com/users/kjozwiak/followers","following_url":"https://api.github.com/users/kjozwiak/following{/other_user}","gists_url":"https://api.github.com/users/kjozwiak/gists{/gist_id}","starred_url":"https://api.github.com/users/kjozwiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjozwiak/subscriptions","organizations_url":"https://api.github.com/users/kjozwiak/orgs","repos_url":"https://api.github.com/users/kjozwiak/repos","events_url":"https://api.github.com/users/kjozwiak/events{/privacy}","received_events_url":"https://api.github.com/users/kjozwiak/received_events","type":"User","site_admin":false},"labels":[{"id":887002343,"url":"https://api.github.com/repos/brave/browser-laptop/labels/0.22.x-single-webview","name":"0.22.x-single-webview","color":"f9d0c4","default":false},{"id":714300836,"url":"https://api.github.com/repos/brave/browser-laptop/labels/PR/pending-review","name":"PR/pending-review","color":"006b75","default":false},{"id":420081901,"url":"https://api.github.com/repos/brave/browser-laptop/labels/QA/test-plan-specified","name":"QA/test-plan-specified","color":"1d76db","default":false},{"id":291742587,"url":"https://api.github.com/repos/brave/browser-laptop/labels/bug","name":"bug","color":"fc2929","default":true},{"id":444993897,"url":"https://api.github.com/repos/brave/browser-laptop/labels/regression","name":"regression","color":"660000","default":false},{"id":479894674,"url":"https://api.github.com/repos/brave/browser-laptop/labels/release-notes/exclude","name":"release-notes/exclude","color":"808080","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/109","html_url":"https://github.com/brave/browser-laptop/milestone/109","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/109/labels","id":3246523,"number":109,"title":"0.22.x Release 3 (Beta channel)","description":"Single-webview","creator":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars3.githubusercontent.com/u/4733304?v=4","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":121,"state":"open","created_at":"2018-04-05T23:58:53Z","updated_at":"2018-05-08T03:28:16Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-05-07T17:39:10Z","updated_at":"2018-05-08T04:45:26Z","closed_at":null,"author_association":"MEMBER","body":"<!--\r\nHave you searched for similar issues? We have received a lot of feedback and bug reports that we have closed as duplicates. Before submitting this issue, please visit our community site for common ones: https://community.brave.com/c/common-issues\r\n-->\r\n\r\n### Description\r\n<!--\r\n[Description of the issue]\r\n-->\r\n\r\nWhen opening some of the certificate errors from badssl.com via `command/ctrl` + `click`, you'll receive `The site can't be reached` error. However, when you refresh, the correct page loads. This works as expected under `0.22.669`\r\n\r\n### Steps to Reproduce\r\n<!--\r\nPlease add a series of steps to reproduce the problem. See https://stackoverflow.com/help/mcve for in depth information on how to create a minimal, complete, and verifiable example.\r\n-->\r\n\r\n  1. launch `0.22.702` e4a853d9990c62328a8a4320fec21f58c9cdc0c1 \r\n  2. load https://badssl.com/\r\n  3. using `command/ctrl` + `click`, open the `expired` & `wrong.host` page\r\n  4. switch over to the opened tabs and notice that the page didn't load correctly\r\n\r\n**Actual result:**\r\n<!--\r\nPlease add screenshots if needed.\r\n-->\r\n\r\n![ssl](https://user-images.githubusercontent.com/2602313/39715377-1091e104-51fb-11e8-8d82-85f84fe96928.gif)\r\n\r\n**Expected result:**\r\n\r\nWhen opening any of the certificate issue websites via `command/ctrl` + `click`, it should load the correct page without initially loading `The site can't be reached`.\r\n\r\n**Reproduces how often:**\r\n<!--\r\nWhat percentage of the time does it reproduce?\r\n-->\r\n\r\n100% reproducible when using the above STR.\r\n\r\n\r\n### Brave Version\r\n\r\n**about:brave info:**\r\n<!--\r\nPlease open about:brave, copy the version information, and paste it.\r\n-->\r\n\r\n```\r\nBrave: 0.22.702 \r\nV8: 6.6.346.26 \r\nrev: e4a853d9990c62328a8a4320fec21f58c9cdc0c1 \r\nMuon: 6.0.7 \r\nOS Release: 17.4.0 \r\nUpdate Channel: Beta \r\nOS Architecture: x64 \r\nOS Platform: macOS \r\nNode.js: 7.9.0 \r\nBrave Sync: v1.4.2 \r\nlibchromiumcontent: 66.0.3359.139\r\n```\r\n\r\n**Reproducible on current live release:**\r\n<!--\r\nIs this a problem with the live build? It matters for triage reasons.\r\n-->\r\n\r\nNo, currently not reproducible under `0.22.669` which is the latest released version.\r\n\r\n### Additional Information\r\n<!--\r\nAny additional information, related issues, extra QA steps, configuration or data that might be necessary to reproduce the issue.\r\n-->\r\n\r\n* Win 10 x64 - Reproduced by @srirambv \r\n* macOS x64 - Reproduced by @LaurenWags \r\n\r\nCCing @diracdeltas "},"comment":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/comments/387282836","html_url":"https://github.com/brave/browser-laptop/issues/14044#issuecomment-387282836","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/14044","id":387282836,"user":{"login":"petemill","id":741836,"avatar_url":"https://avatars1.githubusercontent.com/u/741836?v=4","gravatar_id":"","url":"https://api.github.com/users/petemill","html_url":"https://github.com/petemill","followers_url":"https://api.github.com/users/petemill/followers","following_url":"https://api.github.com/users/petemill/following{/other_user}","gists_url":"https://api.github.com/users/petemill/gists{/gist_id}","starred_url":"https://api.github.com/users/petemill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petemill/subscriptions","organizations_url":"https://api.github.com/users/petemill/orgs","repos_url":"https://api.github.com/users/petemill/repos","events_url":"https://api.github.com/users/petemill/events{/privacy}","received_events_url":"https://api.github.com/users/petemill/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T04:45:26Z","updated_at":"2018-05-08T04:45:26Z","author_association":"MEMBER","body":"I believe this is occuring because background tabs don't neccessarily have a window webContents when they begin to load. Therefore, we cannot get to the window to send the custom IPC message that we are sending on certificate error.\r\nI have refactored this to work via redux actions in 2d5df77d97853d2a5fd4fad1d261304ccb13c5f1"}}
{"actor":{"display_login":"petemill"}}