{"action":"created","comment":{"url":"https://api.github.com/repos/vast-io/vast/pulls/comments/232994883","pull_request_review_id":174309883,"id":232994883,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjk5NDg4Mw==","diff_hunk":"@@ -0,0 +1,97 @@\n+## Configure data.hpp\n+\n+# Bro logs.\n+set(test_data \"#ifndef TEST_DATA\\n#define TEST_DATA\")\n+set(test_data \"${test_data}\\n\\nnamespace bro {\\n\")\n+file(GLOB logs RELATIVE \"${CMAKE_CURRENT_SOURCE_DIR}\" artefacts/logs/bro/*)\n+foreach (log ${logs})\n+  get_filename_component(log_basename ${log} NAME_WE)\n+  set (this \"constexpr auto ${log_basename} = VAST_TEST_PATH\\\"${log}\\\";\")\n+  set (test_data \"${test_data}\\n${this}\")\n+endforeach ()\n+set(test_data \"${test_data}\\n\\n} // namespace bro\")\n+\n+# Bgpdump logs.\n+set(test_data \"${test_data}\\n\\nnamespace bgpdump {\\n\")\n+file(GLOB logs RELATIVE \"${CMAKE_CURRENT_SOURCE_DIR}\" artefacts/logs/bgpdump/*.txt)\n+foreach (log ${logs})\n+  get_filename_component(log_basename ${log} NAME_WE)\n+  set (this \"constexpr auto ${log_basename} = VAST_TEST_PATH\\\"${log}\\\";\")\n+  set (test_data \"${test_data}\\n${this}\")\n+endforeach ()\n+set(test_data \"${test_data}\\n\\n} // namespace bgpdump\")\n+\n+# MRT logs.\n+set(test_data \"${test_data}\\n\\nnamespace mrt {\\n\")\n+file(GLOB logs RELATIVE \"${CMAKE_CURRENT_SOURCE_DIR}\" artefacts/logs/mrt/*)\n+foreach (log ${logs})\n+  get_filename_component(log_basename ${log} NAME_WE)\n+  set (this \"constexpr auto ${log_basename} = VAST_TEST_PATH\\\"${log}\\\";\")\n+  set (test_data \"${test_data}\\n${this}\")\n+endforeach ()\n+set(test_data \"${test_data}\\n\\n} // namespace mrt\")\n+\n+# PCAP traces.\n+set(test_data \"${test_data}\\n\\nnamespace traces {\\n\")\n+file(GLOB traces RELATIVE \"${CMAKE_CURRENT_SOURCE_DIR}\" artefacts/traces/*.pcap)\n+foreach (trace ${traces})\n+  get_filename_component(trace_basename ${trace} NAME_WE)\n+  set(this \"constexpr auto ${trace_basename} = VAST_TEST_PATH\\\"${trace}\\\";\")\n+  set(test_data \"${test_data}\\n${this}\")\n+endforeach ()\n+set(test_data \"${test_data}\\n\\n} // namespace traces\")\n+set(test_data \"${test_data}\\n\\n#endif\")\n+\n+configure_file(vast/test/data.hpp.in ${CMAKE_CURRENT_BINARY_DIR}/vast/test/data.hpp)","path":"libvast_test/CMakeLists.txt","position":45,"original_position":45,"commit_id":"a196bb831e797e533176eda755158c73895f73ae","original_commit_id":"a196bb831e797e533176eda755158c73895f73ae","user":{"login":"tobim","id":858790,"node_id":"MDQ6VXNlcjg1ODc5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/858790?v=4","gravatar_id":"","url":"https://api.github.com/users/tobim","html_url":"https://github.com/tobim","followers_url":"https://api.github.com/users/tobim/followers","following_url":"https://api.github.com/users/tobim/following{/other_user}","gists_url":"https://api.github.com/users/tobim/gists{/gist_id}","starred_url":"https://api.github.com/users/tobim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobim/subscriptions","organizations_url":"https://api.github.com/users/tobim/orgs","repos_url":"https://api.github.com/users/tobim/repos","events_url":"https://api.github.com/users/tobim/events{/privacy}","received_events_url":"https://api.github.com/users/tobim/received_events","type":"User","site_admin":false},"body":"dito","created_at":"2018-11-13T11:13:41Z","updated_at":"2018-11-13T11:13:41Z","html_url":"https://github.com/vast-io/vast/pull/302#discussion_r232994883","pull_request_url":"https://api.github.com/repos/vast-io/vast/pulls/302","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vast-io/vast/pulls/comments/232994883"},"html":{"href":"https://github.com/vast-io/vast/pull/302#discussion_r232994883"},"pull_request":{"href":"https://api.github.com/repos/vast-io/vast/pulls/302"}},"in_reply_to_id":232982775},"pull_request":{"url":"https://api.github.com/repos/vast-io/vast/pulls/302","id":229444905,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDQ0OTA1","html_url":"https://github.com/vast-io/vast/pull/302","diff_url":"https://github.com/vast-io/vast/pull/302.diff","patch_url":"https://github.com/vast-io/vast/pull/302.patch","issue_url":"https://api.github.com/repos/vast-io/vast/issues/302","number":302,"state":"open","locked":false,"title":"Move test scaffold to new libvast_test library","user":{"login":"tobim","id":858790,"node_id":"MDQ6VXNlcjg1ODc5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/858790?v=4","gravatar_id":"","url":"https://api.github.com/users/tobim","html_url":"https://github.com/tobim","followers_url":"https://api.github.com/users/tobim/followers","following_url":"https://api.github.com/users/tobim/following{/other_user}","gists_url":"https://api.github.com/users/tobim/gists{/gist_id}","starred_url":"https://api.github.com/users/tobim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobim/subscriptions","organizations_url":"https://api.github.com/users/tobim/orgs","repos_url":"https://api.github.com/users/tobim/repos","events_url":"https://api.github.com/users/tobim/events{/privacy}","received_events_url":"https://api.github.com/users/tobim/received_events","type":"User","site_admin":false},"body":"This allows the usage of the test fixtures from other projects.\r\n\r\nWarning: This commit requires a clean build directory to compile/work!\r\n\r\nTodo:\r\n- [x] install artefacts, generate install interface `data.hpp`","created_at":"2018-11-08T17:15:08Z","updated_at":"2018-11-13T11:13:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d51c0fd985e28b675bc7f365cce160582a84a2a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":10663081,"node_id":"MDU6TGFiZWwxMDY2MzA4MQ==","url":"https://api.github.com/repos/vast-io/vast/labels/task","name":"task","color":"02d7e1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vast-io/vast/pulls/302/commits","review_comments_url":"https://api.github.com/repos/vast-io/vast/pulls/302/comments","review_comment_url":"https://api.github.com/repos/vast-io/vast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vast-io/vast/issues/302/comments","statuses_url":"https://api.github.com/repos/vast-io/vast/statuses/a196bb831e797e533176eda755158c73895f73ae","head":{"label":"vast-io:story/ch4003","ref":"story/ch4003","sha":"a196bb831e797e533176eda755158c73895f73ae","user":{"login":"vast-io","id":18351410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzUxNDEw","avatar_url":"https://avatars2.githubusercontent.com/u/18351410?v=4","gravatar_id":"","url":"https://api.github.com/users/vast-io","html_url":"https://github.com/vast-io","followers_url":"https://api.github.com/users/vast-io/followers","following_url":"https://api.github.com/users/vast-io/following{/other_user}","gists_url":"https://api.github.com/users/vast-io/gists{/gist_id}","starred_url":"https://api.github.com/users/vast-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vast-io/subscriptions","organizations_url":"https://api.github.com/users/vast-io/orgs","repos_url":"https://api.github.com/users/vast-io/repos","events_url":"https://api.github.com/users/vast-io/events{/privacy}","received_events_url":"https://api.github.com/users/vast-io/received_events","type":"Organization","site_admin":false},"repo":{"id":932314,"node_id":"MDEwOlJlcG9zaXRvcnk5MzIzMTQ=","name":"vast","full_name":"vast-io/vast","private":false,"owner":{"login":"vast-io","id":18351410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzUxNDEw","avatar_url":"https://avatars2.githubusercontent.com/u/18351410?v=4","gravatar_id":"","url":"https://api.github.com/users/vast-io","html_url":"https://github.com/vast-io","followers_url":"https://api.github.com/users/vast-io/followers","following_url":"https://api.github.com/users/vast-io/following{/other_user}","gists_url":"https://api.github.com/users/vast-io/gists{/gist_id}","starred_url":"https://api.github.com/users/vast-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vast-io/subscriptions","organizations_url":"https://api.github.com/users/vast-io/orgs","repos_url":"https://api.github.com/users/vast-io/repos","events_url":"https://api.github.com/users/vast-io/events{/privacy}","received_events_url":"https://api.github.com/users/vast-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vast-io/vast","description":":crystal_ball: Visibility Across Space and Time","fork":false,"url":"https://api.github.com/repos/vast-io/vast","forks_url":"https://api.github.com/repos/vast-io/vast/forks","keys_url":"https://api.github.com/repos/vast-io/vast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vast-io/vast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vast-io/vast/teams","hooks_url":"https://api.github.com/repos/vast-io/vast/hooks","issue_events_url":"https://api.github.com/repos/vast-io/vast/issues/events{/number}","events_url":"https://api.github.com/repos/vast-io/vast/events","assignees_url":"https://api.github.com/repos/vast-io/vast/assignees{/user}","branches_url":"https://api.github.com/repos/vast-io/vast/branches{/branch}","tags_url":"https://api.github.com/repos/vast-io/vast/tags","blobs_url":"https://api.github.com/repos/vast-io/vast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vast-io/vast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vast-io/vast/git/refs{/sha}","trees_url":"https://api.github.com/repos/vast-io/vast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vast-io/vast/statuses/{sha}","languages_url":"https://api.github.com/repos/vast-io/vast/languages","stargazers_url":"https://api.github.com/repos/vast-io/vast/stargazers","contributors_url":"https://api.github.com/repos/vast-io/vast/contributors","subscribers_url":"https://api.github.com/repos/vast-io/vast/subscribers","subscription_url":"https://api.github.com/repos/vast-io/vast/subscription","commits_url":"https://api.github.com/repos/vast-io/vast/commits{/sha}","git_commits_url":"https://api.github.com/repos/vast-io/vast/git/commits{/sha}","comments_url":"https://api.github.com/repos/vast-io/vast/comments{/number}","issue_comment_url":"https://api.github.com/repos/vast-io/vast/issues/comments{/number}","contents_url":"https://api.github.com/repos/vast-io/vast/contents/{+path}","compare_url":"https://api.github.com/repos/vast-io/vast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vast-io/vast/merges","archive_url":"https://api.github.com/repos/vast-io/vast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vast-io/vast/downloads","issues_url":"https://api.github.com/repos/vast-io/vast/issues{/number}","pulls_url":"https://api.github.com/repos/vast-io/vast/pulls{/number}","milestones_url":"https://api.github.com/repos/vast-io/vast/milestones{/number}","notifications_url":"https://api.github.com/repos/vast-io/vast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vast-io/vast/labels{/name}","releases_url":"https://api.github.com/repos/vast-io/vast/releases{/id}","deployments_url":"https://api.github.com/repos/vast-io/vast/deployments","created_at":"2010-09-23T01:19:19Z","updated_at":"2018-11-13T10:22:32Z","pushed_at":"2018-11-13T10:22:31Z","git_url":"git://github.com/vast-io/vast.git","ssh_url":"git@github.com:vast-io/vast.git","clone_url":"https://github.com/vast-io/vast.git","svn_url":"https://github.com/vast-io/vast","homepage":"http://vast.io","size":12103,"stargazers_count":95,"watchers_count":95,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":27,"open_issues":4,"watchers":95,"default_branch":"master"}},"base":{"label":"vast-io:master","ref":"master","sha":"974225c0e63f29acdfb637ce9adec7577b03aeee","user":{"login":"vast-io","id":18351410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzUxNDEw","avatar_url":"https://avatars2.githubusercontent.com/u/18351410?v=4","gravatar_id":"","url":"https://api.github.com/users/vast-io","html_url":"https://github.com/vast-io","followers_url":"https://api.github.com/users/vast-io/followers","following_url":"https://api.github.com/users/vast-io/following{/other_user}","gists_url":"https://api.github.com/users/vast-io/gists{/gist_id}","starred_url":"https://api.github.com/users/vast-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vast-io/subscriptions","organizations_url":"https://api.github.com/users/vast-io/orgs","repos_url":"https://api.github.com/users/vast-io/repos","events_url":"https://api.github.com/users/vast-io/events{/privacy}","received_events_url":"https://api.github.com/users/vast-io/received_events","type":"Organization","site_admin":false},"repo":{"id":932314,"node_id":"MDEwOlJlcG9zaXRvcnk5MzIzMTQ=","name":"vast","full_name":"vast-io/vast","private":false,"owner":{"login":"vast-io","id":18351410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzUxNDEw","avatar_url":"https://avatars2.githubusercontent.com/u/18351410?v=4","gravatar_id":"","url":"https://api.github.com/users/vast-io","html_url":"https://github.com/vast-io","followers_url":"https://api.github.com/users/vast-io/followers","following_url":"https://api.github.com/users/vast-io/following{/other_user}","gists_url":"https://api.github.com/users/vast-io/gists{/gist_id}","starred_url":"https://api.github.com/users/vast-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vast-io/subscriptions","organizations_url":"https://api.github.com/users/vast-io/orgs","repos_url":"https://api.github.com/users/vast-io/repos","events_url":"https://api.github.com/users/vast-io/events{/privacy}","received_events_url":"https://api.github.com/users/vast-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vast-io/vast","description":":crystal_ball: Visibility Across Space and Time","fork":false,"url":"https://api.github.com/repos/vast-io/vast","forks_url":"https://api.github.com/repos/vast-io/vast/forks","keys_url":"https://api.github.com/repos/vast-io/vast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vast-io/vast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vast-io/vast/teams","hooks_url":"https://api.github.com/repos/vast-io/vast/hooks","issue_events_url":"https://api.github.com/repos/vast-io/vast/issues/events{/number}","events_url":"https://api.github.com/repos/vast-io/vast/events","assignees_url":"https://api.github.com/repos/vast-io/vast/assignees{/user}","branches_url":"https://api.github.com/repos/vast-io/vast/branches{/branch}","tags_url":"https://api.github.com/repos/vast-io/vast/tags","blobs_url":"https://api.github.com/repos/vast-io/vast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vast-io/vast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vast-io/vast/git/refs{/sha}","trees_url":"https://api.github.com/repos/vast-io/vast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vast-io/vast/statuses/{sha}","languages_url":"https://api.github.com/repos/vast-io/vast/languages","stargazers_url":"https://api.github.com/repos/vast-io/vast/stargazers","contributors_url":"https://api.github.com/repos/vast-io/vast/contributors","subscribers_url":"https://api.github.com/repos/vast-io/vast/subscribers","subscription_url":"https://api.github.com/repos/vast-io/vast/subscription","commits_url":"https://api.github.com/repos/vast-io/vast/commits{/sha}","git_commits_url":"https://api.github.com/repos/vast-io/vast/git/commits{/sha}","comments_url":"https://api.github.com/repos/vast-io/vast/comments{/number}","issue_comment_url":"https://api.github.com/repos/vast-io/vast/issues/comments{/number}","contents_url":"https://api.github.com/repos/vast-io/vast/contents/{+path}","compare_url":"https://api.github.com/repos/vast-io/vast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vast-io/vast/merges","archive_url":"https://api.github.com/repos/vast-io/vast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vast-io/vast/downloads","issues_url":"https://api.github.com/repos/vast-io/vast/issues{/number}","pulls_url":"https://api.github.com/repos/vast-io/vast/pulls{/number}","milestones_url":"https://api.github.com/repos/vast-io/vast/milestones{/number}","notifications_url":"https://api.github.com/repos/vast-io/vast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vast-io/vast/labels{/name}","releases_url":"https://api.github.com/repos/vast-io/vast/releases{/id}","deployments_url":"https://api.github.com/repos/vast-io/vast/deployments","created_at":"2010-09-23T01:19:19Z","updated_at":"2018-11-13T10:22:32Z","pushed_at":"2018-11-13T10:22:31Z","git_url":"git://github.com/vast-io/vast.git","ssh_url":"git@github.com:vast-io/vast.git","clone_url":"https://github.com/vast-io/vast.git","svn_url":"https://github.com/vast-io/vast","homepage":"http://vast.io","size":12103,"stargazers_count":95,"watchers_count":95,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":27,"open_issues":4,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vast-io/vast/pulls/302"},"html":{"href":"https://github.com/vast-io/vast/pull/302"},"issue":{"href":"https://api.github.com/repos/vast-io/vast/issues/302"},"comments":{"href":"https://api.github.com/repos/vast-io/vast/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/vast-io/vast/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/vast-io/vast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vast-io/vast/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/vast-io/vast/statuses/a196bb831e797e533176eda755158c73895f73ae"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tobim"}}