{"action":"created","comment":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/comments/187962436","pull_request_review_id":119826566,"id":187962436,"diff_hunk":"@@ -49,14 +59,15 @@ export class MasterProcess extends EventEmitter {\n             throw new Error(message);\n         }\n         this.serverWorker = serverWorker;\n+        this.isRestarting = false;","path":"packages/core/src/node/cluster/master-process.ts","position":39,"original_position":39,"commit_id":"2f5c1f851617b0d4c0281a3a38f40f1fa770314c","original_commit_id":"2f5c1f851617b0d4c0281a3a38f40f1fa770314c","user":{"login":"marechal-p","id":14182238,"avatar_url":"https://avatars0.githubusercontent.com/u/14182238?v=4","gravatar_id":"","url":"https://api.github.com/users/marechal-p","html_url":"https://github.com/marechal-p","followers_url":"https://api.github.com/users/marechal-p/followers","following_url":"https://api.github.com/users/marechal-p/following{/other_user}","gists_url":"https://api.github.com/users/marechal-p/gists{/gist_id}","starred_url":"https://api.github.com/users/marechal-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marechal-p/subscriptions","organizations_url":"https://api.github.com/users/marechal-p/orgs","repos_url":"https://api.github.com/users/marechal-p/repos","events_url":"https://api.github.com/users/marechal-p/events{/privacy}","received_events_url":"https://api.github.com/users/marechal-p/received_events","type":"User","site_admin":false},"body":"Sorry, I don't get your idea...","created_at":"2018-05-14T13:58:05Z","updated_at":"2018-05-14T13:59:10Z","html_url":"https://github.com/theia-ide/theia/pull/1893#discussion_r187962436","pull_request_url":"https://api.github.com/repos/theia-ide/theia/pulls/1893","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments/187962436"},"html":{"href":"https://github.com/theia-ide/theia/pull/1893#discussion_r187962436"},"pull_request":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/1893"}},"in_reply_to_id":187829764},"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/1893","id":187573068,"html_url":"https://github.com/theia-ide/theia/pull/1893","diff_url":"https://github.com/theia-ide/theia/pull/1893.diff","patch_url":"https://github.com/theia-ide/theia/pull/1893.patch","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/1893","number":1893,"state":"open","locked":false,"title":"[backend/generator] Try to close each process gracefully","user":{"login":"marechal-p","id":14182238,"avatar_url":"https://avatars0.githubusercontent.com/u/14182238?v=4","gravatar_id":"","url":"https://api.github.com/users/marechal-p","html_url":"https://github.com/marechal-p","followers_url":"https://api.github.com/users/marechal-p/followers","following_url":"https://api.github.com/users/marechal-p/following{/other_user}","gists_url":"https://api.github.com/users/marechal-p/gists{/gist_id}","starred_url":"https://api.github.com/users/marechal-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marechal-p/subscriptions","organizations_url":"https://api.github.com/users/marechal-p/orgs","repos_url":"https://api.github.com/users/marechal-p/repos","events_url":"https://api.github.com/users/marechal-p/events{/privacy}","received_events_url":"https://api.github.com/users/marechal-p/received_events","type":"User","site_admin":false},"body":"When the backend closes, processes spawned when running in cluster mode don't always close properly, making the terminal where Theia was started hang.\r\nCause can be unfulfilled promises keeping the event-loop alive.\r\n\r\nSolution was to make sure that in case an error happens, it is detected and call `process.exit()`.\r\n\r\nThis also implied looking for scenarios where the server worker was shutting down without it being scheduled (e.g: we are not trying to restart and the worker dies).\r\n\r\nFixes #1883\r\n\r\nSigned-off-by: Paul Maréchal <paul.marechal@ericsson.com>","created_at":"2018-05-11T21:22:43Z","updated_at":"2018-05-14T13:59:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eafd1c8e9ce636ae1326dccb47bf8b5645fa2e5a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kittaakos","id":1405703,"avatar_url":"https://avatars3.githubusercontent.com/u/1405703?v=4","gravatar_id":"","url":"https://api.github.com/users/kittaakos","html_url":"https://github.com/kittaakos","followers_url":"https://api.github.com/users/kittaakos/followers","following_url":"https://api.github.com/users/kittaakos/following{/other_user}","gists_url":"https://api.github.com/users/kittaakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kittaakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittaakos/subscriptions","organizations_url":"https://api.github.com/users/kittaakos/orgs","repos_url":"https://api.github.com/users/kittaakos/repos","events_url":"https://api.github.com/users/kittaakos/events{/privacy}","received_events_url":"https://api.github.com/users/kittaakos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia/pulls/1893/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia/pulls/1893/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/1893/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/2f5c1f851617b0d4c0281a3a38f40f1fa770314c","head":{"label":"marechal-p:mp/issue-1883","ref":"mp/issue-1883","sha":"2f5c1f851617b0d4c0281a3a38f40f1fa770314c","user":{"login":"marechal-p","id":14182238,"avatar_url":"https://avatars0.githubusercontent.com/u/14182238?v=4","gravatar_id":"","url":"https://api.github.com/users/marechal-p","html_url":"https://github.com/marechal-p","followers_url":"https://api.github.com/users/marechal-p/followers","following_url":"https://api.github.com/users/marechal-p/following{/other_user}","gists_url":"https://api.github.com/users/marechal-p/gists{/gist_id}","starred_url":"https://api.github.com/users/marechal-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marechal-p/subscriptions","organizations_url":"https://api.github.com/users/marechal-p/orgs","repos_url":"https://api.github.com/users/marechal-p/repos","events_url":"https://api.github.com/users/marechal-p/events{/privacy}","received_events_url":"https://api.github.com/users/marechal-p/received_events","type":"User","site_admin":false},"repo":{"id":122448941,"name":"theia","full_name":"marechal-p/theia","owner":{"login":"marechal-p","id":14182238,"avatar_url":"https://avatars0.githubusercontent.com/u/14182238?v=4","gravatar_id":"","url":"https://api.github.com/users/marechal-p","html_url":"https://github.com/marechal-p","followers_url":"https://api.github.com/users/marechal-p/followers","following_url":"https://api.github.com/users/marechal-p/following{/other_user}","gists_url":"https://api.github.com/users/marechal-p/gists{/gist_id}","starred_url":"https://api.github.com/users/marechal-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marechal-p/subscriptions","organizations_url":"https://api.github.com/users/marechal-p/orgs","repos_url":"https://api.github.com/users/marechal-p/repos","events_url":"https://api.github.com/users/marechal-p/events{/privacy}","received_events_url":"https://api.github.com/users/marechal-p/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marechal-p/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":true,"url":"https://api.github.com/repos/marechal-p/theia","forks_url":"https://api.github.com/repos/marechal-p/theia/forks","keys_url":"https://api.github.com/repos/marechal-p/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marechal-p/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marechal-p/theia/teams","hooks_url":"https://api.github.com/repos/marechal-p/theia/hooks","issue_events_url":"https://api.github.com/repos/marechal-p/theia/issues/events{/number}","events_url":"https://api.github.com/repos/marechal-p/theia/events","assignees_url":"https://api.github.com/repos/marechal-p/theia/assignees{/user}","branches_url":"https://api.github.com/repos/marechal-p/theia/branches{/branch}","tags_url":"https://api.github.com/repos/marechal-p/theia/tags","blobs_url":"https://api.github.com/repos/marechal-p/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marechal-p/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marechal-p/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/marechal-p/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marechal-p/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/marechal-p/theia/languages","stargazers_url":"https://api.github.com/repos/marechal-p/theia/stargazers","contributors_url":"https://api.github.com/repos/marechal-p/theia/contributors","subscribers_url":"https://api.github.com/repos/marechal-p/theia/subscribers","subscription_url":"https://api.github.com/repos/marechal-p/theia/subscription","commits_url":"https://api.github.com/repos/marechal-p/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/marechal-p/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/marechal-p/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/marechal-p/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/marechal-p/theia/contents/{+path}","compare_url":"https://api.github.com/repos/marechal-p/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marechal-p/theia/merges","archive_url":"https://api.github.com/repos/marechal-p/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marechal-p/theia/downloads","issues_url":"https://api.github.com/repos/marechal-p/theia/issues{/number}","pulls_url":"https://api.github.com/repos/marechal-p/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/marechal-p/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/marechal-p/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marechal-p/theia/labels{/name}","releases_url":"https://api.github.com/repos/marechal-p/theia/releases{/id}","deployments_url":"https://api.github.com/repos/marechal-p/theia/deployments","created_at":"2018-02-22T08:10:35Z","updated_at":"2018-02-22T08:10:39Z","pushed_at":"2018-05-11T20:50:05Z","git_url":"git://github.com/marechal-p/theia.git","ssh_url":"git@github.com:marechal-p/theia.git","clone_url":"https://github.com/marechal-p/theia.git","svn_url":"https://github.com/marechal-p/theia","homepage":"","size":105679,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"2751e6aa57fd9dfbb86c0b01fd7f770295cfb8fc","user":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"name":"theia","full_name":"theia-ide/theia","owner":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-05-14T06:32:54Z","pushed_at":"2018-05-14T13:32:45Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":120488,"stargazers_count":731,"watchers_count":731,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":396,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":128,"open_issues":396,"watchers":731,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/1893"},"html":{"href":"https://github.com/theia-ide/theia/pull/1893"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia/issues/1893"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia/issues/1893/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/1893/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/1893/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia/statuses/2f5c1f851617b0d4c0281a3a38f40f1fa770314c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"marechal-p"}}