{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/32757","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/32757/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/32757/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/32757/events","html_url":"https://github.com/elastic/elasticsearch/pull/32757","id":349266980,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDI1MDYz","number":32757,"title":"Make x-pack core pull transport-nio","user":{"login":"tbrooks8","id":862472,"node_id":"MDQ6VXNlcjg2MjQ3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/862472?v=4","gravatar_id":"","url":"https://api.github.com/users/tbrooks8","html_url":"https://github.com/tbrooks8","followers_url":"https://api.github.com/users/tbrooks8/followers","following_url":"https://api.github.com/users/tbrooks8/following{/other_user}","gists_url":"https://api.github.com/users/tbrooks8/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrooks8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrooks8/subscriptions","organizations_url":"https://api.github.com/users/tbrooks8/orgs","repos_url":"https://api.github.com/users/tbrooks8/repos","events_url":"https://api.github.com/users/tbrooks8/events{/privacy}","received_events_url":"https://api.github.com/users/tbrooks8/received_events","type":"User","site_admin":false},"labels":[{"id":912838655,"node_id":"MDU6TGFiZWw5MTI4Mzg2NTU=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Security/Network","name":":Security/Network","color":"0e8a16","default":false},{"id":73544,"node_id":"MDU6TGFiZWw3MzU0NA==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Enon-issue","name":">non-issue","color":"cfcfcf","default":false},{"id":94283388,"node_id":"MDU6TGFiZWw5NDI4MzM4OA==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-09T19:53:35Z","updated_at":"2018-08-10T06:47:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/32757","html_url":"https://github.com/elastic/elasticsearch/pull/32757","diff_url":"https://github.com/elastic/elasticsearch/pull/32757.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/32757.patch"},"body":"The security nio transports depend on transport-nio. This commit\r\nmodifies x-pack core to include the transport-nio jar into the x-pack\r\ncore module."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/411991785","html_url":"https://github.com/elastic/elasticsearch/pull/32757#issuecomment-411991785","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/32757","id":411991785,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTk5MTc4NQ==","user":{"login":"atorok","id":2565652,"node_id":"MDQ6VXNlcjI1NjU2NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2565652?v=4","gravatar_id":"","url":"https://api.github.com/users/atorok","html_url":"https://github.com/atorok","followers_url":"https://api.github.com/users/atorok/followers","following_url":"https://api.github.com/users/atorok/following{/other_user}","gists_url":"https://api.github.com/users/atorok/gists{/gist_id}","starred_url":"https://api.github.com/users/atorok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atorok/subscriptions","organizations_url":"https://api.github.com/users/atorok/orgs","repos_url":"https://api.github.com/users/atorok/repos","events_url":"https://api.github.com/users/atorok/events{/privacy}","received_events_url":"https://api.github.com/users/atorok/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T06:47:45Z","updated_at":"2018-08-10T06:47:45Z","author_association":"CONTRIBUTOR","body":"For clarity, the exclude is required to avoid jar hell\r\n```\r\n|    Caused by: java.lang.IllegalStateException: jar hell!\r\n|    class: META-INF.versions.9.org.elasticsearch.core.internal.io.Streams\r\n|    jar1: /home/alpar/work/elastic/elasticsearch/x-pack/plugin/build/cluster/integTestCluster node0/elasticsearch-7.0.0-alpha1-SNAPSHOT/modules/x-pack-core/elasticsearch-core-7.0.0-alpha1-SNAPSHOT.jar\r\n|    jar2: /home/alpar/work/elastic/elasticsearch/x-pack/plugin/build/cluster/integTestCluster node0/elasticsearch-7.0.0-alpha1-SNAPSHOT/lib/elasticsearch-core-7.0.0-alpha1-SNAPSHOT.jar\r\n```\r\n\r\n`:plugins:transport-nio` pulls in `libs:nio` via the runtime configruation, which pulls `:libs:core` according tot [his scan](https://scans.gradle.com/s/vmmgpr3q72uzc/dependencies?focusedDependencyView=dependents&toggled=W1sxXSxbMSwwXSxbMl0sWzIsMF0sWzNdLFs0XSxbNV0sWzZdLFs3XSxbNSwwXSxbNiwwXSxbNywwXSxbMF1d).\r\n\r\n`transport-netty4` does not have dependencies to any other libs, like `transport-nio` depends on `:libs:core` thus it won't have this problem. \r\n\r\nThe problem is that `:plugins:transport-nio` has a _compile_ dependency on `:libs:core`, but this one is already a dependency of the server, so will be provided when the plugin loads, thus it should be a `compileOnly` dependency. As a consequence of this,  project that depend on `:plugins:transport-nio`, like `:x-pack:plugins:security` will have to have a `compileOnly` dependency on `:libs:nio` or any other transitive dependency of the former for that matter as `compileOnly` doesn't carry transitive dependencies. \r\n\r\n@rjernst\r\nAs a side note, while investigating this (and others in the past) I'm constantly puzzled and confused about indirection like this  `org.elasticsearch:elasticsearch-nio:7.0.0-alpha1-SNAPSHOT`. I'm wondering if this is just me ? Why was it done like this ? Should we clean up and always use project dependencies to refer to projects. The example plugins are the only place where I think this makes sense, but we could do that locally. \r\n  \r\n@tbrooks8 I made the changes mentioned above in atorok@4dd5ea3d18e"}}
{"actor":{"display_login":"atorok"}}