{"action":"created","issue":{"url":"https://api.github.com/repos/magento-research/pwa-studio/issues/633","repository_url":"https://api.github.com/repos/magento-research/pwa-studio","labels_url":"https://api.github.com/repos/magento-research/pwa-studio/issues/633/labels{/name}","comments_url":"https://api.github.com/repos/magento-research/pwa-studio/issues/633/comments","events_url":"https://api.github.com/repos/magento-research/pwa-studio/issues/633/events","html_url":"https://github.com/magento-research/pwa-studio/issues/633","id":389335106,"node_id":"MDU6SXNzdWUzODkzMzUxMDY=","number":633,"title":"[Bug]: Main menu. DOM append in wrong sequence for user","user":{"login":"vitalics","id":8816260,"node_id":"MDQ6VXNlcjg4MTYyNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/8816260?v=4","gravatar_id":"","url":"https://api.github.com/users/vitalics","html_url":"https://github.com/vitalics","followers_url":"https://api.github.com/users/vitalics/followers","following_url":"https://api.github.com/users/vitalics/following{/other_user}","gists_url":"https://api.github.com/users/vitalics/gists{/gist_id}","starred_url":"https://api.github.com/users/vitalics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitalics/subscriptions","organizations_url":"https://api.github.com/users/vitalics/orgs","repos_url":"https://api.github.com/users/vitalics/repos","events_url":"https://api.github.com/users/vitalics/events{/privacy}","received_events_url":"https://api.github.com/users/vitalics/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-10T14:48:44Z","updated_at":"2018-12-11T07:01:14Z","closed_at":null,"author_association":"NONE","body":"<!-- (REQUIRED) What is the nature of this issue? -->\r\n\r\n## This issue is for the following packages:\r\n\r\n- [x] `venia-concept`\r\n- [ ] `pwa-buildpack`\r\n- [ ] `peregrine`\r\n- [ ] `pwa-devdocs`\r\n- [ ] `upward-js`\r\n- [ ] `upward-spec`\r\n\r\n## This issue is a:\r\n\r\n- [x] Bug\r\n- [ ] Feature suggestion\r\n- [ ] Documentation issue\r\n- [ ] Other (Please Specify)\r\n\r\n### Environment\r\n\r\n| Question                    |    Answer     |\r\n| --------------------------- | :-----------: |\r\n| Magento version             | <!--Answer--> |\r\n| Operating System + version  | <!--Answer--> |\r\n| node.js version (`node -v`) | <!--Answer--> |\r\n| npm version (`npm -v`)      | <!--Answer--> |\r\n\r\n## Description\r\nReact render DOM for user in a wrong sequence: \r\n![image](https://user-images.githubusercontent.com/8816260/49739320-acdf0a80-fca2-11e8-9169-f0e8f3b5cbc0.png)\r\nDOM. First element is Avatar with this image \r\n![image](https://user-images.githubusercontent.com/8816260/49739484-0ba48400-fca3-11e8-9ac6-dd50af2f9745.png). Next is User name and at last, render arrow \r\n![image](https://user-images.githubusercontent.com/8816260/49739538-2e369d00-fca3-11e8-94b0-1c835d0c7a6f.png)\r\nDOM:\r\n![image](https://user-images.githubusercontent.com/8816260/49739450-f9c2e100-fca2-11e8-8879-41610dbc62a8.png)\r\n\r\n<!-- (REQUIRED) Describe the issue with as much detail as possible -->\r\n\r\n## Expected result:\r\nExpected a render user Image, user name and arrow, as provided on mockups:\r\n![image](https://user-images.githubusercontent.com/8816260/49739770-c03ea580-fca3-11e8-9c9c-919bcf584dcf.png)\r\n\r\n<!-- (REQUIRED) When this issue is resolved, what is the expected result/behavior? -->\r\n\r\n## Possible solutions:\r\nchange render sequence\r\nchange styles for `navigation-userChip` class name:\r\n``` css\r\n.navigation-userChip-1dw{\r\n    flex: 0 0 100%;\r\n    display: flex;\r\n    justify-content: space-around; /** or set space-between */\r\n   /** remove styles:\r\n   display: grid,  \r\n   grid-template-columns: min-content 1fr min-content;\r\n   grid-template-rows: 3.5rem; \r\n   */\r\n}\r\n```\r\n<!-- (OPTIONAL) What would a solution for this issue look like? -->\r\n\r\n<!--\r\nThank you for taking the time to report this issue!\r\nGitHub Issues should only be created for problems/topics related to this project's codebase.\r\n\r\nBefore submitting this issue, please make sure you are complying with our Code of Conduct:\r\nhttps://github.com/magento-research/pwa-studio/blob/develop/.github/CODE_OF_CONDUCT.md\r\n\r\nIssues that do not comply with our Code of Conduct or do not contain enough information may be closed at the maintainers' discretion.\r\n\r\nFeel free to remove this section before creating this issue.\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/magento-research/pwa-studio/issues/comments/446094122","html_url":"https://github.com/magento-research/pwa-studio/issues/633#issuecomment-446094122","issue_url":"https://api.github.com/repos/magento-research/pwa-studio/issues/633","id":446094122,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjA5NDEyMg==","user":{"login":"codeAdrian","id":11479290,"node_id":"MDQ6VXNlcjExNDc5Mjkw","avatar_url":"https://avatars2.githubusercontent.com/u/11479290?v=4","gravatar_id":"","url":"https://api.github.com/users/codeAdrian","html_url":"https://github.com/codeAdrian","followers_url":"https://api.github.com/users/codeAdrian/followers","following_url":"https://api.github.com/users/codeAdrian/following{/other_user}","gists_url":"https://api.github.com/users/codeAdrian/gists{/gist_id}","starred_url":"https://api.github.com/users/codeAdrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeAdrian/subscriptions","organizations_url":"https://api.github.com/users/codeAdrian/orgs","repos_url":"https://api.github.com/users/codeAdrian/repos","events_url":"https://api.github.com/users/codeAdrian/events{/privacy}","received_events_url":"https://api.github.com/users/codeAdrian/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T07:01:14Z","updated_at":"2018-12-11T07:01:14Z","author_association":"CONTRIBUTOR","body":"Hello. I believe that this issue was related to the checkout layout being broken. The fix for it was pulled into release. Please check again and let us know if it persists. I have tried to reproduce this issue with fix applied and everything was looking good."}}
{"actor":{"display_login":"codeAdrian"}}