{"action":"created","issue":{"url":"https://api.github.com/repos/dials/dials/issues/667","repository_url":"https://api.github.com/repos/dials/dials","labels_url":"https://api.github.com/repos/dials/dials/issues/667/labels{/name}","comments_url":"https://api.github.com/repos/dials/dials/issues/667/comments","events_url":"https://api.github.com/repos/dials/dials/issues/667/events","html_url":"https://github.com/dials/dials/issues/667","id":386245316,"node_id":"MDU6SXNzdWUzODYyNDUzMTY=","number":667,"title":"dials.find_spots reports spots on 2 images for a single image","user":{"login":"dagewa","id":11502083,"node_id":"MDQ6VXNlcjExNTAyMDgz","avatar_url":"https://avatars3.githubusercontent.com/u/11502083?v=4","gravatar_id":"","url":"https://api.github.com/users/dagewa","html_url":"https://github.com/dagewa","followers_url":"https://api.github.com/users/dagewa/followers","following_url":"https://api.github.com/users/dagewa/following{/other_user}","gists_url":"https://api.github.com/users/dagewa/gists{/gist_id}","starred_url":"https://api.github.com/users/dagewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagewa/subscriptions","organizations_url":"https://api.github.com/users/dagewa/orgs","repos_url":"https://api.github.com/users/dagewa/repos","events_url":"https://api.github.com/users/dagewa/events{/privacy}","received_events_url":"https://api.github.com/users/dagewa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"graeme-winter","id":1241716,"node_id":"MDQ6VXNlcjEyNDE3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1241716?v=4","gravatar_id":"","url":"https://api.github.com/users/graeme-winter","html_url":"https://github.com/graeme-winter","followers_url":"https://api.github.com/users/graeme-winter/followers","following_url":"https://api.github.com/users/graeme-winter/following{/other_user}","gists_url":"https://api.github.com/users/graeme-winter/gists{/gist_id}","starred_url":"https://api.github.com/users/graeme-winter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graeme-winter/subscriptions","organizations_url":"https://api.github.com/users/graeme-winter/orgs","repos_url":"https://api.github.com/users/graeme-winter/repos","events_url":"https://api.github.com/users/graeme-winter/events{/privacy}","received_events_url":"https://api.github.com/users/graeme-winter/received_events","type":"User","site_admin":false},"assignees":[{"login":"graeme-winter","id":1241716,"node_id":"MDQ6VXNlcjEyNDE3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1241716?v=4","gravatar_id":"","url":"https://api.github.com/users/graeme-winter","html_url":"https://github.com/graeme-winter","followers_url":"https://api.github.com/users/graeme-winter/followers","following_url":"https://api.github.com/users/graeme-winter/following{/other_user}","gists_url":"https://api.github.com/users/graeme-winter/gists{/gist_id}","starred_url":"https://api.github.com/users/graeme-winter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graeme-winter/subscriptions","organizations_url":"https://api.github.com/users/graeme-winter/orgs","repos_url":"https://api.github.com/users/graeme-winter/repos","events_url":"https://api.github.com/users/graeme-winter/events{/privacy}","received_events_url":"https://api.github.com/users/graeme-winter/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-11-30T15:56:16Z","updated_at":"2018-11-30T16:55:52Z","closed_at":null,"author_association":"MEMBER","body":"This might be format specific, in that it doesn't appear to be an issue for BAG training cbfs. However, it does appear to affect at least some (all?) SMV format images:\r\n\r\n`dials.find_spots $DIALS_REGRESSION/ESRF_ID231/q315r_7_001.img`\r\n\r\n```\r\nFound 33663 strong pixels on image 1\r\n\r\nExtracted 5156 spots\r\nRemoved 3443 spots with size < 6 pixels\r\nRemoved 13 spots with size > 100 pixels\r\nCalculated 1700 spot centroids\r\nCalculated 1700 spot intensities\r\nFiltered 1367 of 1700 spots by peak-centroid distance\r\n\r\nHistogram of per-image spot count for imageset 0:\r\n1367 spots found on 2 images (max 684 / bin)\r\n```\r\n\r\nNote\r\n> Found 33663 strong pixels on image **1**\r\n\r\nbut\r\n> 1367 spots found on **2** images (max 684 / bin)"},"comment":{"url":"https://api.github.com/repos/dials/dials/issues/comments/443267559","html_url":"https://github.com/dials/dials/issues/667#issuecomment-443267559","issue_url":"https://api.github.com/repos/dials/dials/issues/667","id":443267559,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzI2NzU1OQ==","user":{"login":"dagewa","id":11502083,"node_id":"MDQ6VXNlcjExNTAyMDgz","avatar_url":"https://avatars3.githubusercontent.com/u/11502083?v=4","gravatar_id":"","url":"https://api.github.com/users/dagewa","html_url":"https://github.com/dagewa","followers_url":"https://api.github.com/users/dagewa/followers","following_url":"https://api.github.com/users/dagewa/following{/other_user}","gists_url":"https://api.github.com/users/dagewa/gists{/gist_id}","starred_url":"https://api.github.com/users/dagewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagewa/subscriptions","organizations_url":"https://api.github.com/users/dagewa/orgs","repos_url":"https://api.github.com/users/dagewa/repos","events_url":"https://api.github.com/users/dagewa/events{/privacy}","received_events_url":"https://api.github.com/users/dagewa/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T16:55:52Z","updated_at":"2018-11-30T16:55:52Z","author_association":"MEMBER","body":"Rounding to, say, 5 decimal places fixes this case\r\n\r\n```diff\r\n-  xmin = int(round(min_z + 1e-16))\r\n-  xmax = int(round(max_z))\r\n+  xmin = int(round(min_z + 1e-16, 5))\r\n+  xmax = int(round(max_z, 5))\r\n```\r\nBut it seems surprising that `dials.find_spots` gives differences of > 1e-7 in the z values for a single image.\r\n"}}
{"actor":{"display_login":"dagewa"}}