{"action":"created","comment":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments/233878600","pull_request_review_id":175393677,"id":233878600,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzg3ODYwMA==","diff_hunk":"@@ -0,0 +1,22 @@\n+import { GlobalAction } from './GlobalActions';\n+import { GrafanaAction } from './GrafanaActions';\n+import { GraphAction } from './GraphActions';\n+import { GraphDataAction } from './GraphDataActions';\n+import { GraphFilterAction } from './GraphFilterActions';\n+import { HelpDropdownAction } from './HelpDropdownActions';\n+import { LoginAction } from './LoginActions';\n+import { MessageCenterAction } from './MessageCenterActions';\n+import { NamespaceAction } from './NamespaceAction';\n+import { UserSettingsAction } from './UserSettingsActions';\n+\n+export type KialiAppAction =","path":"src/actions/KialiAppAction.ts","position":12,"original_position":12,"commit_id":"63e62a94fbec7b6415d96906267b07de34ccc8ed","original_commit_id":"63e62a94fbec7b6415d96906267b07de34ccc8ed","user":{"login":"israel-hdez","id":23639005,"node_id":"MDQ6VXNlcjIzNjM5MDA1","avatar_url":"https://avatars3.githubusercontent.com/u/23639005?v=4","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"body":"Yes, but it's useful, since this helps to enable type checking in the reducers :)","created_at":"2018-11-15T15:05:43Z","updated_at":"2018-11-15T15:05:43Z","html_url":"https://github.com/kiali/kiali-ui/pull/827#discussion_r233878600","pull_request_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/827","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments/233878600"},"html":{"href":"https://github.com/kiali/kiali-ui/pull/827#discussion_r233878600"},"pull_request":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/827"}},"in_reply_to_id":233691934},"pull_request":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/827","id":231038836,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDM4ODM2","html_url":"https://github.com/kiali/kiali-ui/pull/827","diff_url":"https://github.com/kiali/kiali-ui/pull/827.diff","patch_url":"https://github.com/kiali/kiali-ui/pull/827.patch","issue_url":"https://api.github.com/repos/kiali/kiali-ui/issues/827","number":827,"state":"open","locked":false,"title":"KIALI-1941 Upgrade typesafe-actions package","user":{"login":"israel-hdez","id":23639005,"node_id":"MDQ6VXNlcjIzNjM5MDA1","avatar_url":"https://avatars3.githubusercontent.com/u/23639005?v=4","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"body":"Redux actions and reducers should now be strongly typed.\r\nContainer components are not using the strong types yet. That will be accomplished under KIALI-1918.\r\n\r\nhttps://issues.jboss.org/browse/KIALI-1941","created_at":"2018-11-15T01:27:02Z","updated_at":"2018-11-15T15:05:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbb371636291917e883e24814525c538d4f67443","assignee":null,"assignees":[],"requested_reviewers":[{"login":"josejulio","id":3845764,"node_id":"MDQ6VXNlcjM4NDU3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3845764?v=4","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/827/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/827/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/issues/827/comments","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/63e62a94fbec7b6415d96906267b07de34ccc8ed","head":{"label":"israel-hdez:kiali-1941","ref":"kiali-1941","sha":"63e62a94fbec7b6415d96906267b07de34ccc8ed","user":{"login":"israel-hdez","id":23639005,"node_id":"MDQ6VXNlcjIzNjM5MDA1","avatar_url":"https://avatars3.githubusercontent.com/u/23639005?v=4","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"repo":{"id":122654796,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NTQ3OTY=","name":"swsui","full_name":"israel-hdez/swsui","private":false,"owner":{"login":"israel-hdez","id":23639005,"node_id":"MDQ6VXNlcjIzNjM5MDA1","avatar_url":"https://avatars3.githubusercontent.com/u/23639005?v=4","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"html_url":"https://github.com/israel-hdez/swsui","description":null,"fork":true,"url":"https://api.github.com/repos/israel-hdez/swsui","forks_url":"https://api.github.com/repos/israel-hdez/swsui/forks","keys_url":"https://api.github.com/repos/israel-hdez/swsui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/israel-hdez/swsui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/israel-hdez/swsui/teams","hooks_url":"https://api.github.com/repos/israel-hdez/swsui/hooks","issue_events_url":"https://api.github.com/repos/israel-hdez/swsui/issues/events{/number}","events_url":"https://api.github.com/repos/israel-hdez/swsui/events","assignees_url":"https://api.github.com/repos/israel-hdez/swsui/assignees{/user}","branches_url":"https://api.github.com/repos/israel-hdez/swsui/branches{/branch}","tags_url":"https://api.github.com/repos/israel-hdez/swsui/tags","blobs_url":"https://api.github.com/repos/israel-hdez/swsui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/israel-hdez/swsui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/israel-hdez/swsui/git/refs{/sha}","trees_url":"https://api.github.com/repos/israel-hdez/swsui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/israel-hdez/swsui/statuses/{sha}","languages_url":"https://api.github.com/repos/israel-hdez/swsui/languages","stargazers_url":"https://api.github.com/repos/israel-hdez/swsui/stargazers","contributors_url":"https://api.github.com/repos/israel-hdez/swsui/contributors","subscribers_url":"https://api.github.com/repos/israel-hdez/swsui/subscribers","subscription_url":"https://api.github.com/repos/israel-hdez/swsui/subscription","commits_url":"https://api.github.com/repos/israel-hdez/swsui/commits{/sha}","git_commits_url":"https://api.github.com/repos/israel-hdez/swsui/git/commits{/sha}","comments_url":"https://api.github.com/repos/israel-hdez/swsui/comments{/number}","issue_comment_url":"https://api.github.com/repos/israel-hdez/swsui/issues/comments{/number}","contents_url":"https://api.github.com/repos/israel-hdez/swsui/contents/{+path}","compare_url":"https://api.github.com/repos/israel-hdez/swsui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/israel-hdez/swsui/merges","archive_url":"https://api.github.com/repos/israel-hdez/swsui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/israel-hdez/swsui/downloads","issues_url":"https://api.github.com/repos/israel-hdez/swsui/issues{/number}","pulls_url":"https://api.github.com/repos/israel-hdez/swsui/pulls{/number}","milestones_url":"https://api.github.com/repos/israel-hdez/swsui/milestones{/number}","notifications_url":"https://api.github.com/repos/israel-hdez/swsui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/israel-hdez/swsui/labels{/name}","releases_url":"https://api.github.com/repos/israel-hdez/swsui/releases{/id}","deployments_url":"https://api.github.com/repos/israel-hdez/swsui/deployments","created_at":"2018-02-23T17:56:09Z","updated_at":"2018-11-13T16:00:55Z","pushed_at":"2018-11-15T01:26:25Z","git_url":"git://github.com/israel-hdez/swsui.git","ssh_url":"git@github.com:israel-hdez/swsui.git","clone_url":"https://github.com/israel-hdez/swsui.git","svn_url":"https://github.com/israel-hdez/swsui","homepage":null,"size":3825,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"5f64ae062b3cb06f42cd1661f7afc615f2d9546a","user":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120308264,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAzMDgyNjQ=","name":"kiali-ui","full_name":"kiali/kiali-ui","private":false,"owner":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiali/kiali-ui","description":"Frontend part of Kiali (use github.com/kiali/kiali to report issues)","fork":false,"url":"https://api.github.com/repos/kiali/kiali-ui","forks_url":"https://api.github.com/repos/kiali/kiali-ui/forks","keys_url":"https://api.github.com/repos/kiali/kiali-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali-ui/teams","hooks_url":"https://api.github.com/repos/kiali/kiali-ui/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali-ui/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali-ui/events","assignees_url":"https://api.github.com/repos/kiali/kiali-ui/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali-ui/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali-ui/tags","blobs_url":"https://api.github.com/repos/kiali/kiali-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali-ui/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali-ui/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali-ui/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali-ui/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali-ui/subscription","commits_url":"https://api.github.com/repos/kiali/kiali-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali-ui/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali-ui/merges","archive_url":"https://api.github.com/repos/kiali/kiali-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali-ui/downloads","issues_url":"https://api.github.com/repos/kiali/kiali-ui/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali-ui/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali-ui/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali-ui/deployments","created_at":"2018-02-05T13:27:15Z","updated_at":"2018-11-14T20:34:34Z","pushed_at":"2018-11-15T07:34:09Z","git_url":"git://github.com/kiali/kiali-ui.git","ssh_url":"git@github.com:kiali/kiali-ui.git","clone_url":"https://github.com/kiali/kiali-ui.git","svn_url":"https://github.com/kiali/kiali-ui","homepage":"https://www.kiali.io","size":3801,"stargazers_count":43,"watchers_count":43,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":17,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/827"},"html":{"href":"https://github.com/kiali/kiali-ui/pull/827"},"issue":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/827"},"comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/827/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/827/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/827/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali-ui/statuses/63e62a94fbec7b6415d96906267b07de34ccc8ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"israel-hdez"}}