{"action":"created","issue":{"url":"https://api.github.com/repos/mdlayher/netlink/issues/110","repository_url":"https://api.github.com/repos/mdlayher/netlink","labels_url":"https://api.github.com/repos/mdlayher/netlink/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/mdlayher/netlink/issues/110/comments","events_url":"https://api.github.com/repos/mdlayher/netlink/issues/110/events","html_url":"https://github.com/mdlayher/netlink/pull/110","id":358403584,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTYwMTI5","number":110,"title":"Network namespace support for Conn","user":{"login":"ti-mo","id":3214460,"node_id":"MDQ6VXNlcjMyMTQ0NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3214460?v=4","gravatar_id":"","url":"https://api.github.com/users/ti-mo","html_url":"https://github.com/ti-mo","followers_url":"https://api.github.com/users/ti-mo/followers","following_url":"https://api.github.com/users/ti-mo/following{/other_user}","gists_url":"https://api.github.com/users/ti-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/ti-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ti-mo/subscriptions","organizations_url":"https://api.github.com/users/ti-mo/orgs","repos_url":"https://api.github.com/users/ti-mo/repos","events_url":"https://api.github.com/users/ti-mo/events{/privacy}","received_events_url":"https://api.github.com/users/ti-mo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-09T19:17:29Z","updated_at":"2018-09-10T15:45:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mdlayher/netlink/pulls/110","html_url":"https://github.com/mdlayher/netlink/pull/110","diff_url":"https://github.com/mdlayher/netlink/pull/110.diff","patch_url":"https://github.com/mdlayher/netlink/pull/110.patch"},"body":"Bit of a work in progress, but I've been using this over the weekend to build a test suite around, and it works great (so far). There's some (well-founded) FUD going around about netns+goroutines, but this doesn't apply here.\r\n\r\nWe lock a 'leaf' goroutine with a narrow scope to an OS thread, there is no code path that can create goroutines from the locked thread. (these will end up in the 'main' namespace)\r\n\r\nnetns_linux.go is adapted from https://github.com/vishvananda/netns, should I attribute? I use this library to set up namespaces in my tests, too.\r\n\r\nLet me know what you think, and let's discuss a way to integration test this.\r\n\r\nFixes #107."},"comment":{"url":"https://api.github.com/repos/mdlayher/netlink/issues/comments/419960825","html_url":"https://github.com/mdlayher/netlink/pull/110#issuecomment-419960825","issue_url":"https://api.github.com/repos/mdlayher/netlink/issues/110","id":419960825,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTk2MDgyNQ==","user":{"login":"mdlayher","id":1926905,"node_id":"MDQ6VXNlcjE5MjY5MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1926905?v=4","gravatar_id":"","url":"https://api.github.com/users/mdlayher","html_url":"https://github.com/mdlayher","followers_url":"https://api.github.com/users/mdlayher/followers","following_url":"https://api.github.com/users/mdlayher/following{/other_user}","gists_url":"https://api.github.com/users/mdlayher/gists{/gist_id}","starred_url":"https://api.github.com/users/mdlayher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdlayher/subscriptions","organizations_url":"https://api.github.com/users/mdlayher/orgs","repos_url":"https://api.github.com/users/mdlayher/repos","events_url":"https://api.github.com/users/mdlayher/events{/privacy}","received_events_url":"https://api.github.com/users/mdlayher/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T15:45:23Z","updated_at":"2018-09-10T15:45:23Z","author_association":"OWNER","body":"> netns_linux.go is adapted from https://github.com/vishvananda/netns, should I attribute?\r\n\r\nHaven't looked at this yet, but this strikes me as potentially bad news.  This package is MIT but that one is Apache 2.0.  I am not a lawyer and cannot speak to the compatibility of the two, but I would really prefer an independent implementation of the primitives we need to avoid any potential legal ramifications."}}
{"actor":{"display_login":"mdlayher"}}