{"action":"created","issue":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2146","repository_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2146/labels{/name}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2146/comments","events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2146/events","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/issues/2146","id":294831807,"number":2146,"title":"Modals (or others) with component as content does not trigger ngOnChanges","user":{"login":"MickL","id":5103210,"avatar_url":"https://avatars0.githubusercontent.com/u/5103210?v=4","gravatar_id":"","url":"https://api.github.com/users/MickL","html_url":"https://github.com/MickL","followers_url":"https://api.github.com/users/MickL/followers","following_url":"https://api.github.com/users/MickL/following{/other_user}","gists_url":"https://api.github.com/users/MickL/gists{/gist_id}","starred_url":"https://api.github.com/users/MickL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MickL/subscriptions","organizations_url":"https://api.github.com/users/MickL/orgs","repos_url":"https://api.github.com/users/MickL/repos","events_url":"https://api.github.com/users/MickL/events{/privacy}","received_events_url":"https://api.github.com/users/MickL/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-06T16:48:31Z","updated_at":"2018-02-27T10:28:45Z","closed_at":null,"author_association":"NONE","body":"This is really nice:\r\n\r\n```\r\nconst modalRef = this.modalService.open(NgbdModalContent);\r\nmodalRef.componentInstance.name = 'World';\r\n```\r\n\r\nAnyway this does not trigger `ngOnChanges()` when we set the input \"name\" but this lifecycle-hook are a crucial feature of Angular components.\r\n\r\nPlease consider this as a feature request. Also i am looking for a workaround to trigger ngOnChanges manually."},"comment":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/comments/368823367","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/issues/2146#issuecomment-368823367","issue_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2146","id":368823367,"user":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars3.githubusercontent.com/u/973550?v=4","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"created_at":"2018-02-27T10:28:45Z","updated_at":"2018-02-27T10:28:45Z","author_association":"COLLABORATOR","body":"Unfortunately this is how Angular works with any dynamically created component. We can't do much about it here, in this project, it is not specific to ng-bootstrap."}}
{"actor":{"display_login":"pkozlowski-opensource"}}