{"action":"created","comment":{"url":"https://api.github.com/repos/kiegroup/jbpm/pulls/comments/243554398","pull_request_review_id":187356681,"id":243554398,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzU1NDM5OA==","diff_hunk":"@@ -126,7 +130,24 @@ public void onNodeAdded(Node node) {\n             } else {\n                 processDescriptor.getReusableSubProcesses().add(processId);\n             }\n+        } else if (node instanceof TimerNode) {\n+            TimerNode timerNode = (TimerNode) node;\n+            processDescriptor.getTimers().add(new TimerDesc(timerNode.getTimer().getId(), timerNode.getId(), (String) timerNode.getMetaData().get(\"UniqueId\"), timerNode.getName()));\n+        } else if (node instanceof StartNode) {\n+            StartNode startNode = (StartNode) node;\n+            processDescriptor.getTimers().add(new TimerDesc(startNode.getTimer().getId(), startNode.getId(), (String) startNode.getMetaData().get(\"UniqueId\"), startNode.getName()));","path":"jbpm-services/jbpm-kie-services/src/main/java/org/jbpm/kie/services/impl/xml/ServicesProcessDataEventListener.java","position":30,"original_position":30,"commit_id":"243f4fdad06d93e45f5d7e84d2d9a4e68706c8bc","original_commit_id":"243f4fdad06d93e45f5d7e84d2d9a4e68706c8bc","user":{"login":"nmirasch","id":2443754,"node_id":"MDQ6VXNlcjI0NDM3NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2443754?v=4","gravatar_id":"","url":"https://api.github.com/users/nmirasch","html_url":"https://github.com/nmirasch","followers_url":"https://api.github.com/users/nmirasch/followers","following_url":"https://api.github.com/users/nmirasch/following{/other_user}","gists_url":"https://api.github.com/users/nmirasch/gists{/gist_id}","starred_url":"https://api.github.com/users/nmirasch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmirasch/subscriptions","organizations_url":"https://api.github.com/users/nmirasch/orgs","repos_url":"https://api.github.com/users/nmirasch/repos","events_url":"https://api.github.com/users/nmirasch/events{/privacy}","received_events_url":"https://api.github.com/users/nmirasch/received_events","type":"User","site_admin":false},"body":"Do we have to check if starNode.getTimer() could be null here?","created_at":"2018-12-21T11:11:43Z","updated_at":"2018-12-21T11:11:43Z","html_url":"https://github.com/kiegroup/jbpm/pull/1402#discussion_r243554398","pull_request_url":"https://api.github.com/repos/kiegroup/jbpm/pulls/1402","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiegroup/jbpm/pulls/comments/243554398"},"html":{"href":"https://github.com/kiegroup/jbpm/pull/1402#discussion_r243554398"},"pull_request":{"href":"https://api.github.com/repos/kiegroup/jbpm/pulls/1402"}}},"pull_request":{"url":"https://api.github.com/repos/kiegroup/jbpm/pulls/1402","id":240030317,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMDMwMzE3","html_url":"https://github.com/kiegroup/jbpm/pull/1402","diff_url":"https://github.com/kiegroup/jbpm/pull/1402.diff","patch_url":"https://github.com/kiegroup/jbpm/pull/1402.patch","issue_url":"https://api.github.com/repos/kiegroup/jbpm/issues/1402","number":1402,"state":"open","locked":false,"title":"JBPM-7632 - Enhance process definition data including timers and nodes","user":{"login":"cristianonicolai","id":570894,"node_id":"MDQ6VXNlcjU3MDg5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/570894?v=4","gravatar_id":"","url":"https://api.github.com/users/cristianonicolai","html_url":"https://github.com/cristianonicolai","followers_url":"https://api.github.com/users/cristianonicolai/followers","following_url":"https://api.github.com/users/cristianonicolai/following{/other_user}","gists_url":"https://api.github.com/users/cristianonicolai/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianonicolai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianonicolai/subscriptions","organizations_url":"https://api.github.com/users/cristianonicolai/orgs","repos_url":"https://api.github.com/users/cristianonicolai/repos","events_url":"https://api.github.com/users/cristianonicolai/events{/privacy}","received_events_url":"https://api.github.com/users/cristianonicolai/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-20T02:03:15Z","updated_at":"2018-12-21T11:11:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"304f43b239a185ab0f4a00834cb9d47d7749fc01","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MarianMacik","id":6797884,"node_id":"MDQ6VXNlcjY3OTc4ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6797884?v=4","gravatar_id":"","url":"https://api.github.com/users/MarianMacik","html_url":"https://github.com/MarianMacik","followers_url":"https://api.github.com/users/MarianMacik/followers","following_url":"https://api.github.com/users/MarianMacik/following{/other_user}","gists_url":"https://api.github.com/users/MarianMacik/gists{/gist_id}","starred_url":"https://api.github.com/users/MarianMacik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarianMacik/subscriptions","organizations_url":"https://api.github.com/users/MarianMacik/orgs","repos_url":"https://api.github.com/users/MarianMacik/repos","events_url":"https://api.github.com/users/MarianMacik/events{/privacy}","received_events_url":"https://api.github.com/users/MarianMacik/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiegroup/jbpm/pulls/1402/commits","review_comments_url":"https://api.github.com/repos/kiegroup/jbpm/pulls/1402/comments","review_comment_url":"https://api.github.com/repos/kiegroup/jbpm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiegroup/jbpm/issues/1402/comments","statuses_url":"https://api.github.com/repos/kiegroup/jbpm/statuses/243f4fdad06d93e45f5d7e84d2d9a4e68706c8bc","head":{"label":"cristianonicolai:JBPM-7632","ref":"JBPM-7632","sha":"243f4fdad06d93e45f5d7e84d2d9a4e68706c8bc","user":{"login":"cristianonicolai","id":570894,"node_id":"MDQ6VXNlcjU3MDg5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/570894?v=4","gravatar_id":"","url":"https://api.github.com/users/cristianonicolai","html_url":"https://github.com/cristianonicolai","followers_url":"https://api.github.com/users/cristianonicolai/followers","following_url":"https://api.github.com/users/cristianonicolai/following{/other_user}","gists_url":"https://api.github.com/users/cristianonicolai/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianonicolai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianonicolai/subscriptions","organizations_url":"https://api.github.com/users/cristianonicolai/orgs","repos_url":"https://api.github.com/users/cristianonicolai/repos","events_url":"https://api.github.com/users/cristianonicolai/events{/privacy}","received_events_url":"https://api.github.com/users/cristianonicolai/received_events","type":"User","site_admin":false},"repo":{"id":5666135,"node_id":"MDEwOlJlcG9zaXRvcnk1NjY2MTM1","name":"jbpm","full_name":"cristianonicolai/jbpm","private":false,"owner":{"login":"cristianonicolai","id":570894,"node_id":"MDQ6VXNlcjU3MDg5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/570894?v=4","gravatar_id":"","url":"https://api.github.com/users/cristianonicolai","html_url":"https://github.com/cristianonicolai","followers_url":"https://api.github.com/users/cristianonicolai/followers","following_url":"https://api.github.com/users/cristianonicolai/following{/other_user}","gists_url":"https://api.github.com/users/cristianonicolai/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianonicolai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianonicolai/subscriptions","organizations_url":"https://api.github.com/users/cristianonicolai/orgs","repos_url":"https://api.github.com/users/cristianonicolai/repos","events_url":"https://api.github.com/users/cristianonicolai/events{/privacy}","received_events_url":"https://api.github.com/users/cristianonicolai/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cristianonicolai/jbpm","description":"a Business Process Management (BPM) Suite","fork":true,"url":"https://api.github.com/repos/cristianonicolai/jbpm","forks_url":"https://api.github.com/repos/cristianonicolai/jbpm/forks","keys_url":"https://api.github.com/repos/cristianonicolai/jbpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cristianonicolai/jbpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cristianonicolai/jbpm/teams","hooks_url":"https://api.github.com/repos/cristianonicolai/jbpm/hooks","issue_events_url":"https://api.github.com/repos/cristianonicolai/jbpm/issues/events{/number}","events_url":"https://api.github.com/repos/cristianonicolai/jbpm/events","assignees_url":"https://api.github.com/repos/cristianonicolai/jbpm/assignees{/user}","branches_url":"https://api.github.com/repos/cristianonicolai/jbpm/branches{/branch}","tags_url":"https://api.github.com/repos/cristianonicolai/jbpm/tags","blobs_url":"https://api.github.com/repos/cristianonicolai/jbpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cristianonicolai/jbpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cristianonicolai/jbpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cristianonicolai/jbpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cristianonicolai/jbpm/statuses/{sha}","languages_url":"https://api.github.com/repos/cristianonicolai/jbpm/languages","stargazers_url":"https://api.github.com/repos/cristianonicolai/jbpm/stargazers","contributors_url":"https://api.github.com/repos/cristianonicolai/jbpm/contributors","subscribers_url":"https://api.github.com/repos/cristianonicolai/jbpm/subscribers","subscription_url":"https://api.github.com/repos/cristianonicolai/jbpm/subscription","commits_url":"https://api.github.com/repos/cristianonicolai/jbpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cristianonicolai/jbpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cristianonicolai/jbpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cristianonicolai/jbpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cristianonicolai/jbpm/contents/{+path}","compare_url":"https://api.github.com/repos/cristianonicolai/jbpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cristianonicolai/jbpm/merges","archive_url":"https://api.github.com/repos/cristianonicolai/jbpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cristianonicolai/jbpm/downloads","issues_url":"https://api.github.com/repos/cristianonicolai/jbpm/issues{/number}","pulls_url":"https://api.github.com/repos/cristianonicolai/jbpm/pulls{/number}","milestones_url":"https://api.github.com/repos/cristianonicolai/jbpm/milestones{/number}","notifications_url":"https://api.github.com/repos/cristianonicolai/jbpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cristianonicolai/jbpm/labels{/name}","releases_url":"https://api.github.com/repos/cristianonicolai/jbpm/releases{/id}","deployments_url":"https://api.github.com/repos/cristianonicolai/jbpm/deployments","created_at":"2012-09-04T01:41:32Z","updated_at":"2013-01-12T02:22:40Z","pushed_at":"2018-12-20T11:56:36Z","git_url":"git://github.com/cristianonicolai/jbpm.git","ssh_url":"git@github.com:cristianonicolai/jbpm.git","clone_url":"https://github.com/cristianonicolai/jbpm.git","svn_url":"https://github.com/cristianonicolai/jbpm","homepage":"http://www.jboss.org/jbpm","size":45750,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiegroup:master","ref":"master","sha":"b69370c313f3bcfa6f6264112aa2923a5f70027f","user":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"repo":{"id":930571,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA1NzE=","name":"jbpm","full_name":"kiegroup/jbpm","private":false,"owner":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiegroup/jbpm","description":"a Business Process Management (BPM) Suite","fork":false,"url":"https://api.github.com/repos/kiegroup/jbpm","forks_url":"https://api.github.com/repos/kiegroup/jbpm/forks","keys_url":"https://api.github.com/repos/kiegroup/jbpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiegroup/jbpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiegroup/jbpm/teams","hooks_url":"https://api.github.com/repos/kiegroup/jbpm/hooks","issue_events_url":"https://api.github.com/repos/kiegroup/jbpm/issues/events{/number}","events_url":"https://api.github.com/repos/kiegroup/jbpm/events","assignees_url":"https://api.github.com/repos/kiegroup/jbpm/assignees{/user}","branches_url":"https://api.github.com/repos/kiegroup/jbpm/branches{/branch}","tags_url":"https://api.github.com/repos/kiegroup/jbpm/tags","blobs_url":"https://api.github.com/repos/kiegroup/jbpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiegroup/jbpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiegroup/jbpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiegroup/jbpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiegroup/jbpm/statuses/{sha}","languages_url":"https://api.github.com/repos/kiegroup/jbpm/languages","stargazers_url":"https://api.github.com/repos/kiegroup/jbpm/stargazers","contributors_url":"https://api.github.com/repos/kiegroup/jbpm/contributors","subscribers_url":"https://api.github.com/repos/kiegroup/jbpm/subscribers","subscription_url":"https://api.github.com/repos/kiegroup/jbpm/subscription","commits_url":"https://api.github.com/repos/kiegroup/jbpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiegroup/jbpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiegroup/jbpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiegroup/jbpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiegroup/jbpm/contents/{+path}","compare_url":"https://api.github.com/repos/kiegroup/jbpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiegroup/jbpm/merges","archive_url":"https://api.github.com/repos/kiegroup/jbpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiegroup/jbpm/downloads","issues_url":"https://api.github.com/repos/kiegroup/jbpm/issues{/number}","pulls_url":"https://api.github.com/repos/kiegroup/jbpm/pulls{/number}","milestones_url":"https://api.github.com/repos/kiegroup/jbpm/milestones{/number}","notifications_url":"https://api.github.com/repos/kiegroup/jbpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiegroup/jbpm/labels{/name}","releases_url":"https://api.github.com/repos/kiegroup/jbpm/releases{/id}","deployments_url":"https://api.github.com/repos/kiegroup/jbpm/deployments","created_at":"2010-09-22T13:19:52Z","updated_at":"2018-12-19T17:50:54Z","pushed_at":"2018-12-20T11:56:37Z","git_url":"git://github.com/kiegroup/jbpm.git","ssh_url":"git@github.com:kiegroup/jbpm.git","clone_url":"https://github.com/kiegroup/jbpm.git","svn_url":"https://github.com/kiegroup/jbpm","homepage":"http://www.jbpm.org","size":327421,"stargazers_count":860,"watchers_count":860,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":917,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":917,"open_issues":10,"watchers":860,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiegroup/jbpm/pulls/1402"},"html":{"href":"https://github.com/kiegroup/jbpm/pull/1402"},"issue":{"href":"https://api.github.com/repos/kiegroup/jbpm/issues/1402"},"comments":{"href":"https://api.github.com/repos/kiegroup/jbpm/issues/1402/comments"},"review_comments":{"href":"https://api.github.com/repos/kiegroup/jbpm/pulls/1402/comments"},"review_comment":{"href":"https://api.github.com/repos/kiegroup/jbpm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiegroup/jbpm/pulls/1402/commits"},"statuses":{"href":"https://api.github.com/repos/kiegroup/jbpm/statuses/243f4fdad06d93e45f5d7e84d2d9a4e68706c8bc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nmirasch"}}