{"action":"created","comment":{"url":"https://api.github.com/repos/omisego/elixir-omg/pulls/comments/219151230","pull_request_review_id":157254644,"id":219151230,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTE1MTIzMA==","diff_hunk":"@@ -11,46 +11,60 @@\n # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n # See the License for the specific language governing permissions and\n # limitations under the License.\n-defmodule OMG.API.RootchainCoordinator.Core do\n+defmodule OMG.API.RootChainCoordinator.Core do\n   @moduledoc \"\"\"\n-  Synchronizes services on rootchain height.\n+  Synchronizes services on root chain height.\n   Each synchronized service must have a unique name.\n   Service reports its height by calling 'check_in'.\n   After all the services are checked in, coordinator returns currently synchronized height.\n   In case a service fails, it is checked out and coordinator does not resume until the missing service checks_in again.\n-  After all the services checked in with the same height, coordinator returns the next rootchain height when calling `check_in`.\n-  Coordinator periodically updates rootchain height.\n+  After all the services checked in with the same height, coordinator returns the next root chain height when calling `check_in`.\n+  Coordinator periodically updates root chain height.\n   \"\"\"\n \n-  alias OMG.API.RootchainCoordinator.Service\n+  alias OMG.API.RootChainCoordinator.Service\n \n   @empty MapSet.new()\n \n-  defstruct allowed_services: @empty, rootchain_height: 0, services: %{}\n+  defstruct allowed_services: @empty, root_chain_height: 0, services: %{}\n \n   @type t() :: %__MODULE__{\n           allowed_services: MapSet.t(),\n-          rootchain_height: non_neg_integer(),\n+          root_chain_height: non_neg_integer(),\n           services: map()\n         }\n \n   @doc \"\"\"\n   Initializes core.\n   `allowed_services` - set of names of services that are being synchronized\n-  `rootchain_height` - current rootchain height\n+  `root_chain_height` - current root chain height\n   \"\"\"\n   @spec init(MapSet.t(), non_neg_integer()) :: t()\n-  def init(allowed_services, rootchain_height) do\n-    %__MODULE__{allowed_services: allowed_services, rootchain_height: rootchain_height}\n+  def init(allowed_services, root_chain_height) do\n+    %__MODULE__{allowed_services: allowed_services, root_chain_height: root_chain_height}\n   end\n \n   @doc \"\"\"\n   Updates Ethereum height on which a service is synchronized.\n+  Returns list of pids of services to synchronize on next Ethereum height.\n+  List is not empty only when service that checks in is the last synchronizing on a given hight.","path":"apps/omg_api/lib/root_chain_coordinator/core.ex","position":50,"original_position":50,"commit_id":"f475e65b332987b50484286a362af36e86f0cbc1","original_commit_id":"f475e65b332987b50484286a362af36e86f0cbc1","user":{"login":"pgebal","id":23142088,"node_id":"MDQ6VXNlcjIzMTQyMDg4","avatar_url":"https://avatars1.githubusercontent.com/u/23142088?v=4","gravatar_id":"","url":"https://api.github.com/users/pgebal","html_url":"https://github.com/pgebal","followers_url":"https://api.github.com/users/pgebal/followers","following_url":"https://api.github.com/users/pgebal/following{/other_user}","gists_url":"https://api.github.com/users/pgebal/gists{/gist_id}","starred_url":"https://api.github.com/users/pgebal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgebal/subscriptions","organizations_url":"https://api.github.com/users/pgebal/orgs","repos_url":"https://api.github.com/users/pgebal/repos","events_url":"https://api.github.com/users/pgebal/events{/privacy}","received_events_url":"https://api.github.com/users/pgebal/received_events","type":"User","site_admin":false},"body":"Agree on typo. The second part: the comment is right. That list is not empty only for the last service. Let's talk about that in person.","created_at":"2018-09-20T12:54:35Z","updated_at":"2018-09-20T12:54:35Z","html_url":"https://github.com/omisego/elixir-omg/pull/177#discussion_r219151230","pull_request_url":"https://api.github.com/repos/omisego/elixir-omg/pulls/177","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/comments/219151230"},"html":{"href":"https://github.com/omisego/elixir-omg/pull/177#discussion_r219151230"},"pull_request":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/177"}},"in_reply_to_id":219129369},"pull_request":{"url":"https://api.github.com/repos/omisego/elixir-omg/pulls/177","id":215923344,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTIzMzQ0","html_url":"https://github.com/omisego/elixir-omg/pull/177","diff_url":"https://github.com/omisego/elixir-omg/pull/177.diff","patch_url":"https://github.com/omisego/elixir-omg/pull/177.patch","issue_url":"https://api.github.com/repos/omisego/elixir-omg/issues/177","number":177,"state":"open","locked":false,"title":"OMG-234 Wallet provider quickly synces up with long child chain of almost empty blocks","user":{"login":"pgebal","id":23142088,"node_id":"MDQ6VXNlcjIzMTQyMDg4","avatar_url":"https://avatars1.githubusercontent.com/u/23142088?v=4","gravatar_id":"","url":"https://api.github.com/users/pgebal","html_url":"https://github.com/pgebal","followers_url":"https://api.github.com/users/pgebal/followers","following_url":"https://api.github.com/users/pgebal/following{/other_user}","gists_url":"https://api.github.com/users/pgebal/gists{/gist_id}","starred_url":"https://api.github.com/users/pgebal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgebal/subscriptions","organizations_url":"https://api.github.com/users/pgebal/orgs","repos_url":"https://api.github.com/users/pgebal/repos","events_url":"https://api.github.com/users/pgebal/events{/privacy}","received_events_url":"https://api.github.com/users/pgebal/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-17T09:42:29Z","updated_at":"2018-09-20T12:54:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51b339ba400daf4ef8231fb6e0003a4e02b09371","assignee":{"login":"paulperegud","id":247162,"node_id":"MDQ6VXNlcjI0NzE2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/247162?v=4","gravatar_id":"","url":"https://api.github.com/users/paulperegud","html_url":"https://github.com/paulperegud","followers_url":"https://api.github.com/users/paulperegud/followers","following_url":"https://api.github.com/users/paulperegud/following{/other_user}","gists_url":"https://api.github.com/users/paulperegud/gists{/gist_id}","starred_url":"https://api.github.com/users/paulperegud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulperegud/subscriptions","organizations_url":"https://api.github.com/users/paulperegud/orgs","repos_url":"https://api.github.com/users/paulperegud/repos","events_url":"https://api.github.com/users/paulperegud/events{/privacy}","received_events_url":"https://api.github.com/users/paulperegud/received_events","type":"User","site_admin":false},"assignees":[{"login":"paulperegud","id":247162,"node_id":"MDQ6VXNlcjI0NzE2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/247162?v=4","gravatar_id":"","url":"https://api.github.com/users/paulperegud","html_url":"https://github.com/paulperegud","followers_url":"https://api.github.com/users/paulperegud/followers","following_url":"https://api.github.com/users/paulperegud/following{/other_user}","gists_url":"https://api.github.com/users/paulperegud/gists{/gist_id}","starred_url":"https://api.github.com/users/paulperegud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulperegud/subscriptions","organizations_url":"https://api.github.com/users/paulperegud/orgs","repos_url":"https://api.github.com/users/paulperegud/repos","events_url":"https://api.github.com/users/paulperegud/events{/privacy}","received_events_url":"https://api.github.com/users/paulperegud/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/omisego/elixir-omg/pulls/177/commits","review_comments_url":"https://api.github.com/repos/omisego/elixir-omg/pulls/177/comments","review_comment_url":"https://api.github.com/repos/omisego/elixir-omg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omisego/elixir-omg/issues/177/comments","statuses_url":"https://api.github.com/repos/omisego/elixir-omg/statuses/f475e65b332987b50484286a362af36e86f0cbc1","head":{"label":"omisego:feature/OMG-234_wallet_provider_quickly_synces_up_with_long_child_chain_of_almost_empty_blocks","ref":"feature/OMG-234_wallet_provider_quickly_synces_up_with_long_child_chain_of_almost_empty_blocks","sha":"f475e65b332987b50484286a362af36e86f0cbc1","user":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"repo":{"id":123528600,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1Mjg2MDA=","name":"elixir-omg","full_name":"omisego/elixir-omg","private":false,"owner":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/omisego/elixir-omg","description":null,"fork":false,"url":"https://api.github.com/repos/omisego/elixir-omg","forks_url":"https://api.github.com/repos/omisego/elixir-omg/forks","keys_url":"https://api.github.com/repos/omisego/elixir-omg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omisego/elixir-omg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omisego/elixir-omg/teams","hooks_url":"https://api.github.com/repos/omisego/elixir-omg/hooks","issue_events_url":"https://api.github.com/repos/omisego/elixir-omg/issues/events{/number}","events_url":"https://api.github.com/repos/omisego/elixir-omg/events","assignees_url":"https://api.github.com/repos/omisego/elixir-omg/assignees{/user}","branches_url":"https://api.github.com/repos/omisego/elixir-omg/branches{/branch}","tags_url":"https://api.github.com/repos/omisego/elixir-omg/tags","blobs_url":"https://api.github.com/repos/omisego/elixir-omg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omisego/elixir-omg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omisego/elixir-omg/git/refs{/sha}","trees_url":"https://api.github.com/repos/omisego/elixir-omg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omisego/elixir-omg/statuses/{sha}","languages_url":"https://api.github.com/repos/omisego/elixir-omg/languages","stargazers_url":"https://api.github.com/repos/omisego/elixir-omg/stargazers","contributors_url":"https://api.github.com/repos/omisego/elixir-omg/contributors","subscribers_url":"https://api.github.com/repos/omisego/elixir-omg/subscribers","subscription_url":"https://api.github.com/repos/omisego/elixir-omg/subscription","commits_url":"https://api.github.com/repos/omisego/elixir-omg/commits{/sha}","git_commits_url":"https://api.github.com/repos/omisego/elixir-omg/git/commits{/sha}","comments_url":"https://api.github.com/repos/omisego/elixir-omg/comments{/number}","issue_comment_url":"https://api.github.com/repos/omisego/elixir-omg/issues/comments{/number}","contents_url":"https://api.github.com/repos/omisego/elixir-omg/contents/{+path}","compare_url":"https://api.github.com/repos/omisego/elixir-omg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omisego/elixir-omg/merges","archive_url":"https://api.github.com/repos/omisego/elixir-omg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omisego/elixir-omg/downloads","issues_url":"https://api.github.com/repos/omisego/elixir-omg/issues{/number}","pulls_url":"https://api.github.com/repos/omisego/elixir-omg/pulls{/number}","milestones_url":"https://api.github.com/repos/omisego/elixir-omg/milestones{/number}","notifications_url":"https://api.github.com/repos/omisego/elixir-omg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omisego/elixir-omg/labels{/name}","releases_url":"https://api.github.com/repos/omisego/elixir-omg/releases{/id}","deployments_url":"https://api.github.com/repos/omisego/elixir-omg/deployments","created_at":"2018-03-02T04:05:24Z","updated_at":"2018-09-20T09:20:35Z","pushed_at":"2018-09-20T12:46:12Z","git_url":"git://github.com/omisego/elixir-omg.git","ssh_url":"git@github.com:omisego/elixir-omg.git","clone_url":"https://github.com/omisego/elixir-omg.git","svn_url":"https://github.com/omisego/elixir-omg","homepage":null,"size":3024,"stargazers_count":72,"watchers_count":72,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":7,"watchers":72,"default_branch":"develop"}},"base":{"label":"omisego:develop","ref":"develop","sha":"68bd5ed2b3f3e3e7272db4355c0edc21c6137b51","user":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"repo":{"id":123528600,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1Mjg2MDA=","name":"elixir-omg","full_name":"omisego/elixir-omg","private":false,"owner":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/omisego/elixir-omg","description":null,"fork":false,"url":"https://api.github.com/repos/omisego/elixir-omg","forks_url":"https://api.github.com/repos/omisego/elixir-omg/forks","keys_url":"https://api.github.com/repos/omisego/elixir-omg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omisego/elixir-omg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omisego/elixir-omg/teams","hooks_url":"https://api.github.com/repos/omisego/elixir-omg/hooks","issue_events_url":"https://api.github.com/repos/omisego/elixir-omg/issues/events{/number}","events_url":"https://api.github.com/repos/omisego/elixir-omg/events","assignees_url":"https://api.github.com/repos/omisego/elixir-omg/assignees{/user}","branches_url":"https://api.github.com/repos/omisego/elixir-omg/branches{/branch}","tags_url":"https://api.github.com/repos/omisego/elixir-omg/tags","blobs_url":"https://api.github.com/repos/omisego/elixir-omg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omisego/elixir-omg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omisego/elixir-omg/git/refs{/sha}","trees_url":"https://api.github.com/repos/omisego/elixir-omg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omisego/elixir-omg/statuses/{sha}","languages_url":"https://api.github.com/repos/omisego/elixir-omg/languages","stargazers_url":"https://api.github.com/repos/omisego/elixir-omg/stargazers","contributors_url":"https://api.github.com/repos/omisego/elixir-omg/contributors","subscribers_url":"https://api.github.com/repos/omisego/elixir-omg/subscribers","subscription_url":"https://api.github.com/repos/omisego/elixir-omg/subscription","commits_url":"https://api.github.com/repos/omisego/elixir-omg/commits{/sha}","git_commits_url":"https://api.github.com/repos/omisego/elixir-omg/git/commits{/sha}","comments_url":"https://api.github.com/repos/omisego/elixir-omg/comments{/number}","issue_comment_url":"https://api.github.com/repos/omisego/elixir-omg/issues/comments{/number}","contents_url":"https://api.github.com/repos/omisego/elixir-omg/contents/{+path}","compare_url":"https://api.github.com/repos/omisego/elixir-omg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omisego/elixir-omg/merges","archive_url":"https://api.github.com/repos/omisego/elixir-omg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omisego/elixir-omg/downloads","issues_url":"https://api.github.com/repos/omisego/elixir-omg/issues{/number}","pulls_url":"https://api.github.com/repos/omisego/elixir-omg/pulls{/number}","milestones_url":"https://api.github.com/repos/omisego/elixir-omg/milestones{/number}","notifications_url":"https://api.github.com/repos/omisego/elixir-omg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omisego/elixir-omg/labels{/name}","releases_url":"https://api.github.com/repos/omisego/elixir-omg/releases{/id}","deployments_url":"https://api.github.com/repos/omisego/elixir-omg/deployments","created_at":"2018-03-02T04:05:24Z","updated_at":"2018-09-20T09:20:35Z","pushed_at":"2018-09-20T12:46:12Z","git_url":"git://github.com/omisego/elixir-omg.git","ssh_url":"git@github.com:omisego/elixir-omg.git","clone_url":"https://github.com/omisego/elixir-omg.git","svn_url":"https://github.com/omisego/elixir-omg","homepage":null,"size":3024,"stargazers_count":72,"watchers_count":72,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":7,"watchers":72,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/177"},"html":{"href":"https://github.com/omisego/elixir-omg/pull/177"},"issue":{"href":"https://api.github.com/repos/omisego/elixir-omg/issues/177"},"comments":{"href":"https://api.github.com/repos/omisego/elixir-omg/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/omisego/elixir-omg/statuses/f475e65b332987b50484286a362af36e86f0cbc1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pgebal"}}