{"action":"closed","number":1263,"pull_request":{"url":"https://api.github.com/repos/getquill/quill/pulls/1263","id":237226607,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MjI2NjA3","html_url":"https://github.com/getquill/quill/pull/1263","diff_url":"https://github.com/getquill/quill/pull/1263.diff","patch_url":"https://github.com/getquill/quill/pull/1263.patch","issue_url":"https://api.github.com/repos/getquill/quill/issues/1263","number":1263,"state":"closed","locked":false,"title":"Create a streaming module for Monix over JDBC - combined approach","user":{"login":"deusaquilus","id":1369480,"node_id":"MDQ6VXNlcjEzNjk0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1369480?v=4","gravatar_id":"","url":"https://api.github.com/users/deusaquilus","html_url":"https://github.com/deusaquilus","followers_url":"https://api.github.com/users/deusaquilus/followers","following_url":"https://api.github.com/users/deusaquilus/following{/other_user}","gists_url":"https://api.github.com/users/deusaquilus/gists{/gist_id}","starred_url":"https://api.github.com/users/deusaquilus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deusaquilus/subscriptions","organizations_url":"https://api.github.com/users/deusaquilus/orgs","repos_url":"https://api.github.com/users/deusaquilus/repos","events_url":"https://api.github.com/users/deusaquilus/events{/privacy}","received_events_url":"https://api.github.com/users/deusaquilus/received_events","type":"User","site_admin":false},"body":"Fixes #1228\r\n\r\nA PR for this issue has already been submitted by @cemelo which is likely much more complete than this work, but I decided to post what I have, just for sake of discussion. This is based on @oleg-py's great work on quill-monix [here](https://github.com/oleg-py/quill-monix).\r\n\r\nLet's compare and contrast this with @cemelo's great work and figure out what to do.\r\n\r\n- [ ] Unit test all changes\r\n- [ ] Update `README.md` if applicable\r\n- [x] Add `[WIP]` to the pull request title if it's work in progress\r\n- [ ] [Squash commits](https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one) that aren't meaningful changes\r\n- [ ] Run `sbt scalariformFormat test:scalariformFormat` to make sure that the source files are formatted\r\n\r\n@getquill/maintainers\r\n","created_at":"2018-12-10T07:53:25Z","updated_at":"2018-12-23T04:36:41Z","closed_at":"2018-12-23T04:36:41Z","merged_at":"2018-12-23T04:36:40Z","merge_commit_sha":"2092f8d22f950464cd88329c7591a0a6074196f4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mentegy","id":5845992,"node_id":"MDQ6VXNlcjU4NDU5OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5845992?v=4","gravatar_id":"","url":"https://api.github.com/users/mentegy","html_url":"https://github.com/mentegy","followers_url":"https://api.github.com/users/mentegy/followers","following_url":"https://api.github.com/users/mentegy/following{/other_user}","gists_url":"https://api.github.com/users/mentegy/gists{/gist_id}","starred_url":"https://api.github.com/users/mentegy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mentegy/subscriptions","organizations_url":"https://api.github.com/users/mentegy/orgs","repos_url":"https://api.github.com/users/mentegy/repos","events_url":"https://api.github.com/users/mentegy/events{/privacy}","received_events_url":"https://api.github.com/users/mentegy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/getquill/quill/pulls/1263/commits","review_comments_url":"https://api.github.com/repos/getquill/quill/pulls/1263/comments","review_comment_url":"https://api.github.com/repos/getquill/quill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getquill/quill/issues/1263/comments","statuses_url":"https://api.github.com/repos/getquill/quill/statuses/b1b331e41a1a433cff26bea78b8b304d0a2073e7","head":{"label":"deusaquilus2:monix-test","ref":"monix-test","sha":"b1b331e41a1a433cff26bea78b8b304d0a2073e7","user":{"login":"deusaquilus2","id":44422716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NDIyNzE2","avatar_url":"https://avatars3.githubusercontent.com/u/44422716?v=4","gravatar_id":"","url":"https://api.github.com/users/deusaquilus2","html_url":"https://github.com/deusaquilus2","followers_url":"https://api.github.com/users/deusaquilus2/followers","following_url":"https://api.github.com/users/deusaquilus2/following{/other_user}","gists_url":"https://api.github.com/users/deusaquilus2/gists{/gist_id}","starred_url":"https://api.github.com/users/deusaquilus2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deusaquilus2/subscriptions","organizations_url":"https://api.github.com/users/deusaquilus2/orgs","repos_url":"https://api.github.com/users/deusaquilus2/repos","events_url":"https://api.github.com/users/deusaquilus2/events{/privacy}","received_events_url":"https://api.github.com/users/deusaquilus2/received_events","type":"Organization","site_admin":false},"repo":{"id":154433542,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ0MzM1NDI=","name":"quill","full_name":"deusaquilus2/quill","private":false,"owner":{"login":"deusaquilus2","id":44422716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NDIyNzE2","avatar_url":"https://avatars3.githubusercontent.com/u/44422716?v=4","gravatar_id":"","url":"https://api.github.com/users/deusaquilus2","html_url":"https://github.com/deusaquilus2","followers_url":"https://api.github.com/users/deusaquilus2/followers","following_url":"https://api.github.com/users/deusaquilus2/following{/other_user}","gists_url":"https://api.github.com/users/deusaquilus2/gists{/gist_id}","starred_url":"https://api.github.com/users/deusaquilus2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deusaquilus2/subscriptions","organizations_url":"https://api.github.com/users/deusaquilus2/orgs","repos_url":"https://api.github.com/users/deusaquilus2/repos","events_url":"https://api.github.com/users/deusaquilus2/events{/privacy}","received_events_url":"https://api.github.com/users/deusaquilus2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/deusaquilus2/quill","description":"Compile-time Language Integrated Queries for Scala","fork":true,"url":"https://api.github.com/repos/deusaquilus2/quill","forks_url":"https://api.github.com/repos/deusaquilus2/quill/forks","keys_url":"https://api.github.com/repos/deusaquilus2/quill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deusaquilus2/quill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deusaquilus2/quill/teams","hooks_url":"https://api.github.com/repos/deusaquilus2/quill/hooks","issue_events_url":"https://api.github.com/repos/deusaquilus2/quill/issues/events{/number}","events_url":"https://api.github.com/repos/deusaquilus2/quill/events","assignees_url":"https://api.github.com/repos/deusaquilus2/quill/assignees{/user}","branches_url":"https://api.github.com/repos/deusaquilus2/quill/branches{/branch}","tags_url":"https://api.github.com/repos/deusaquilus2/quill/tags","blobs_url":"https://api.github.com/repos/deusaquilus2/quill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deusaquilus2/quill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deusaquilus2/quill/git/refs{/sha}","trees_url":"https://api.github.com/repos/deusaquilus2/quill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deusaquilus2/quill/statuses/{sha}","languages_url":"https://api.github.com/repos/deusaquilus2/quill/languages","stargazers_url":"https://api.github.com/repos/deusaquilus2/quill/stargazers","contributors_url":"https://api.github.com/repos/deusaquilus2/quill/contributors","subscribers_url":"https://api.github.com/repos/deusaquilus2/quill/subscribers","subscription_url":"https://api.github.com/repos/deusaquilus2/quill/subscription","commits_url":"https://api.github.com/repos/deusaquilus2/quill/commits{/sha}","git_commits_url":"https://api.github.com/repos/deusaquilus2/quill/git/commits{/sha}","comments_url":"https://api.github.com/repos/deusaquilus2/quill/comments{/number}","issue_comment_url":"https://api.github.com/repos/deusaquilus2/quill/issues/comments{/number}","contents_url":"https://api.github.com/repos/deusaquilus2/quill/contents/{+path}","compare_url":"https://api.github.com/repos/deusaquilus2/quill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deusaquilus2/quill/merges","archive_url":"https://api.github.com/repos/deusaquilus2/quill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deusaquilus2/quill/downloads","issues_url":"https://api.github.com/repos/deusaquilus2/quill/issues{/number}","pulls_url":"https://api.github.com/repos/deusaquilus2/quill/pulls{/number}","milestones_url":"https://api.github.com/repos/deusaquilus2/quill/milestones{/number}","notifications_url":"https://api.github.com/repos/deusaquilus2/quill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deusaquilus2/quill/labels{/name}","releases_url":"https://api.github.com/repos/deusaquilus2/quill/releases{/id}","deployments_url":"https://api.github.com/repos/deusaquilus2/quill/deployments","created_at":"2018-10-24T03:31:36Z","updated_at":"2018-12-09T12:28:17Z","pushed_at":"2018-12-23T03:54:08Z","git_url":"git://github.com/deusaquilus2/quill.git","ssh_url":"git@github.com:deusaquilus2/quill.git","clone_url":"https://github.com/deusaquilus2/quill.git","svn_url":"https://github.com/deusaquilus2/quill","homepage":"http://getquill.io","size":7060,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"getquill:master","ref":"master","sha":"ed1f9a65a55613c1ab5cd3e17e84000649b20548","user":{"login":"getquill","id":13422948,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIyOTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/13422948?v=4","gravatar_id":"","url":"https://api.github.com/users/getquill","html_url":"https://github.com/getquill","followers_url":"https://api.github.com/users/getquill/followers","following_url":"https://api.github.com/users/getquill/following{/other_user}","gists_url":"https://api.github.com/users/getquill/gists{/gist_id}","starred_url":"https://api.github.com/users/getquill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getquill/subscriptions","organizations_url":"https://api.github.com/users/getquill/orgs","repos_url":"https://api.github.com/users/getquill/repos","events_url":"https://api.github.com/users/getquill/events{/privacy}","received_events_url":"https://api.github.com/users/getquill/received_events","type":"Organization","site_admin":false},"repo":{"id":39411044,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQxMTA0NA==","name":"quill","full_name":"getquill/quill","private":false,"owner":{"login":"getquill","id":13422948,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIyOTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/13422948?v=4","gravatar_id":"","url":"https://api.github.com/users/getquill","html_url":"https://github.com/getquill","followers_url":"https://api.github.com/users/getquill/followers","following_url":"https://api.github.com/users/getquill/following{/other_user}","gists_url":"https://api.github.com/users/getquill/gists{/gist_id}","starred_url":"https://api.github.com/users/getquill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getquill/subscriptions","organizations_url":"https://api.github.com/users/getquill/orgs","repos_url":"https://api.github.com/users/getquill/repos","events_url":"https://api.github.com/users/getquill/events{/privacy}","received_events_url":"https://api.github.com/users/getquill/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/getquill/quill","description":"Compile-time Language Integrated Queries for Scala","fork":false,"url":"https://api.github.com/repos/getquill/quill","forks_url":"https://api.github.com/repos/getquill/quill/forks","keys_url":"https://api.github.com/repos/getquill/quill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getquill/quill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getquill/quill/teams","hooks_url":"https://api.github.com/repos/getquill/quill/hooks","issue_events_url":"https://api.github.com/repos/getquill/quill/issues/events{/number}","events_url":"https://api.github.com/repos/getquill/quill/events","assignees_url":"https://api.github.com/repos/getquill/quill/assignees{/user}","branches_url":"https://api.github.com/repos/getquill/quill/branches{/branch}","tags_url":"https://api.github.com/repos/getquill/quill/tags","blobs_url":"https://api.github.com/repos/getquill/quill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getquill/quill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getquill/quill/git/refs{/sha}","trees_url":"https://api.github.com/repos/getquill/quill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getquill/quill/statuses/{sha}","languages_url":"https://api.github.com/repos/getquill/quill/languages","stargazers_url":"https://api.github.com/repos/getquill/quill/stargazers","contributors_url":"https://api.github.com/repos/getquill/quill/contributors","subscribers_url":"https://api.github.com/repos/getquill/quill/subscribers","subscription_url":"https://api.github.com/repos/getquill/quill/subscription","commits_url":"https://api.github.com/repos/getquill/quill/commits{/sha}","git_commits_url":"https://api.github.com/repos/getquill/quill/git/commits{/sha}","comments_url":"https://api.github.com/repos/getquill/quill/comments{/number}","issue_comment_url":"https://api.github.com/repos/getquill/quill/issues/comments{/number}","contents_url":"https://api.github.com/repos/getquill/quill/contents/{+path}","compare_url":"https://api.github.com/repos/getquill/quill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getquill/quill/merges","archive_url":"https://api.github.com/repos/getquill/quill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getquill/quill/downloads","issues_url":"https://api.github.com/repos/getquill/quill/issues{/number}","pulls_url":"https://api.github.com/repos/getquill/quill/pulls{/number}","milestones_url":"https://api.github.com/repos/getquill/quill/milestones{/number}","notifications_url":"https://api.github.com/repos/getquill/quill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getquill/quill/labels{/name}","releases_url":"https://api.github.com/repos/getquill/quill/releases{/id}","deployments_url":"https://api.github.com/repos/getquill/quill/deployments","created_at":"2015-07-20T22:15:04Z","updated_at":"2018-12-23T03:12:15Z","pushed_at":"2018-12-23T04:36:40Z","git_url":"git://github.com/getquill/quill.git","ssh_url":"git@github.com:getquill/quill.git","clone_url":"https://github.com/getquill/quill.git","svn_url":"https://github.com/getquill/quill","homepage":"http://getquill.io","size":7034,"stargazers_count":1338,"watchers_count":1338,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":195,"open_issues":127,"watchers":1338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getquill/quill/pulls/1263"},"html":{"href":"https://github.com/getquill/quill/pull/1263"},"issue":{"href":"https://api.github.com/repos/getquill/quill/issues/1263"},"comments":{"href":"https://api.github.com/repos/getquill/quill/issues/1263/comments"},"review_comments":{"href":"https://api.github.com/repos/getquill/quill/pulls/1263/comments"},"review_comment":{"href":"https://api.github.com/repos/getquill/quill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getquill/quill/pulls/1263/commits"},"statuses":{"href":"https://api.github.com/repos/getquill/quill/statuses/b1b331e41a1a433cff26bea78b8b304d0a2073e7"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"deusaquilus","id":1369480,"node_id":"MDQ6VXNlcjEzNjk0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1369480?v=4","gravatar_id":"","url":"https://api.github.com/users/deusaquilus","html_url":"https://github.com/deusaquilus","followers_url":"https://api.github.com/users/deusaquilus/followers","following_url":"https://api.github.com/users/deusaquilus/following{/other_user}","gists_url":"https://api.github.com/users/deusaquilus/gists{/gist_id}","starred_url":"https://api.github.com/users/deusaquilus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deusaquilus/subscriptions","organizations_url":"https://api.github.com/users/deusaquilus/orgs","repos_url":"https://api.github.com/users/deusaquilus/repos","events_url":"https://api.github.com/users/deusaquilus/events{/privacy}","received_events_url":"https://api.github.com/users/deusaquilus/received_events","type":"User","site_admin":false},"comments":1,"review_comments":30,"maintainer_can_modify":false,"commits":1,"additions":2495,"deletions":179,"changed_files":57}}
{"actor":{"display_login":"deusaquilus"}}