{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62297","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62297/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62297/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62297/events","html_url":"https://github.com/kubernetes/kubernetes/pull/62297","id":312712380,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgwNDQ2MDE1","number":62297,"title":"Refactoring GCE Disk APIs to use generated client","user":{"login":"verult","id":1689416,"node_id":"MDQ6VXNlcjE2ODk0MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1689416?v=4","gravatar_id":"","url":"https://api.github.com/users/verult","html_url":"https://github.com/verult","followers_url":"https://api.github.com/users/verult/followers","following_url":"https://api.github.com/users/verult/following{/other_user}","gists_url":"https://api.github.com/users/verult/gists{/gist_id}","starred_url":"https://api.github.com/users/verult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verult/subscriptions","organizations_url":"https://api.github.com/users/verult/orgs","repos_url":"https://api.github.com/users/verult/repos","events_url":"https://api.github.com/users/verult/events{/privacy}","received_events_url":"https://api.github.com/users/verult/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146073,"node_id":"MDU6TGFiZWwxMDUxNDYwNzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/enhancement","name":"kind/enhancement","color":"c7def8","default":false},{"id":711852570,"node_id":"MDU6TGFiZWw3MTE4NTI1NzA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/milestone/incomplete-labels","name":"milestone/incomplete-labels","color":"ededed","default":false},{"id":114528223,"node_id":"MDU6TGFiZWwxMTQ1MjgyMjM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false},{"id":611767149,"node_id":"MDU6TGFiZWw2MTE3NjcxNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/status/approved-for-milestone","name":"status/approved-for-milestone","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"assignees":[{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38","html_url":"https://github.com/kubernetes/kubernetes/milestone/38","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38/labels","id":2848396,"node_id":"MDk6TWlsZXN0b25lMjg0ODM5Ng==","number":38,"title":"v1.11","description":null,"creator":{"login":"mtaufen","id":903617,"node_id":"MDQ6VXNlcjkwMzYxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"open_issues":66,"closed_issues":213,"state":"open","created_at":"2017-10-18T17:24:38Z","updated_at":"2018-06-01T22:27:22Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2018-04-09T22:37:15Z","updated_at":"2018-06-02T00:03:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62297","html_url":"https://github.com/kubernetes/kubernetes/pull/62297","diff_url":"https://github.com/kubernetes/kubernetes/pull/62297.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/62297.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**: Improves maintainability and testing of GCE disks code.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #62296\r\n\r\nNote that `gen.go` and `gen_test.go` are generated files.\r\n\r\nI'm planning to do a more extensive refactor that takes advantage of the generated cloud provider mocks, but that'll be in a separate PR and will be a larger change.\r\n\r\n/cc @davidz627\r\n/assign @saad-ali \r\n/release-note-none\r\n/sig storage"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/394039016","html_url":"https://github.com/kubernetes/kubernetes/pull/62297#issuecomment-394039016","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62297","id":394039016,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDAzOTAxNg==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-06-02T00:03:53Z","updated_at":"2018-06-02T00:03:53Z","author_association":"COLLABORATOR","body":"@verult: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-kops-aws | bb3c198f142e5421c7685cb58616d8809f604a5f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/62297/pull-kubernetes-e2e-kops-aws/92116/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-node-e2e | bb3c198f142e5421c7685cb58616d8809f604a5f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/62297/pull-kubernetes-node-e2e/91966/) | `/test pull-kubernetes-node-e2e`\npull-kubernetes-integration | bb3c198f142e5421c7685cb58616d8809f604a5f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/62297/pull-kubernetes-integration/14542/) | `/test pull-kubernetes-integration`\npull-kubernetes-kubemark-e2e-gce | bb3c198f142e5421c7685cb58616d8809f604a5f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/62297/pull-kubernetes-kubemark-e2e-gce/93615/) | `/test pull-kubernetes-kubemark-e2e-gce`\npull-kubernetes-typecheck | bb3c198f142e5421c7685cb58616d8809f604a5f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/62297/pull-kubernetes-typecheck/12715/) | `/test pull-kubernetes-typecheck`\npull-kubernetes-e2e-gce-100-performance | bb3c198f142e5421c7685cb58616d8809f604a5f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/62297/pull-kubernetes-e2e-gce-100-performance/8871/) | `/test pull-kubernetes-e2e-gce-100-performance`\npull-kubernetes-verify | bb3c198f142e5421c7685cb58616d8809f604a5f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/62297/pull-kubernetes-verify/93906/) | `/test pull-kubernetes-verify`\npull-kubernetes-bazel-build | c05e8458dd588318f681e1ba9110f4a16eeee84b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/62297/pull-kubernetes-bazel-build/45538/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-bazel-test | c05e8458dd588318f681e1ba9110f4a16eeee84b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/62297/pull-kubernetes-bazel-test/47862/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-gce | c05e8458dd588318f681e1ba9110f4a16eeee84b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/62297/pull-kubernetes-e2e-gce/39124/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-gce-device-plugin-gpu | c05e8458dd588318f681e1ba9110f4a16eeee84b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/62297/pull-kubernetes-e2e-gce-device-plugin-gpu/35195/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/62297). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/verult). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}