{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/50390","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/50390/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/50390/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/50390/events","html_url":"https://github.com/ansible/ansible/pull/50390","id":394837979,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDcxNDE5","number":50390,"title":"pfsense module","user":{"login":"opoplawski","id":814662,"node_id":"MDQ6VXNlcjgxNDY2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/814662?v=4","gravatar_id":"","url":"https://api.github.com/users/opoplawski","html_url":"https://github.com/opoplawski","followers_url":"https://api.github.com/users/opoplawski/followers","following_url":"https://api.github.com/users/opoplawski/following{/other_user}","gists_url":"https://api.github.com/users/opoplawski/gists{/gist_id}","starred_url":"https://api.github.com/users/opoplawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opoplawski/subscriptions","organizations_url":"https://api.github.com/users/opoplawski/orgs","repos_url":"https://api.github.com/users/opoplawski/repos","events_url":"https://api.github.com/users/opoplawski/events{/privacy}","received_events_url":"https://api.github.com/users/opoplawski/received_events","type":"User","site_admin":false},"labels":[{"id":1043397454,"node_id":"MDU6TGFiZWwxMDQzMzk3NDU0","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.8","name":"affects_2.8","color":"ededed","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":61436281,"node_id":"MDU6TGFiZWw2MTQzNjI4MQ==","url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":503572087,"node_id":"MDU6TGFiZWw1MDM1NzIwODc=","url":"https://api.github.com/repos/ansible/ansible/labels/needs_triage","name":"needs_triage","color":"0e8a16","default":false},{"id":473225334,"node_id":"MDU6TGFiZWw0NzMyMjUzMzQ=","url":"https://api.github.com/repos/ansible/ansible/labels/new_module","name":"new_module","color":"c2e0c6","default":false},{"id":153577825,"node_id":"MDU6TGFiZWwxNTM1Nzc4MjU=","url":"https://api.github.com/repos/ansible/ansible/labels/new_plugin","name":"new_plugin","color":"bfe5bf","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":636352796,"node_id":"MDU6TGFiZWw2MzYzNTI3OTY=","url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-30T01:23:38Z","updated_at":"2018-12-30T02:13:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/50390","html_url":"https://github.com/ansible/ansible/pull/50390","diff_url":"https://github.com/ansible/ansible/pull/50390.diff","patch_url":"https://github.com/ansible/ansible/pull/50390.patch"},"body":"##### SUMMARY\r\n\r\nThis is initial work on a pfsense module with various tasks to allow configuring of pfSense boxes.  This is in the very initial stages and we are looking for feedback on the design and implementation.\r\n\r\n##### ISSUE TYPE\r\n- New Module Pull Request\r\n\r\n##### COMPONENT NAME\r\npfsense\r\n\r\n##### ADDITIONAL INFORMATION\r\n\r\npfsense stores its configuration in an XML config file: /cf/conf/config.xml.  Normally configuration is done via a PHP web interface.  This module manipulates the config.xml file directly, then runs some php commands to get the pfsense code to reload the XML config file and apply any needed changes.\r\n\r\nWe are also developing this module here: https://github.com/opoplawski/ansible-pfsense\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/450534439","html_url":"https://github.com/ansible/ansible/pull/50390#issuecomment-450534439","issue_url":"https://api.github.com/repos/ansible/ansible/issues/50390","id":450534439,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDUzNDQzOQ==","user":{"login":"opoplawski","id":814662,"node_id":"MDQ6VXNlcjgxNDY2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/814662?v=4","gravatar_id":"","url":"https://api.github.com/users/opoplawski","html_url":"https://github.com/opoplawski","followers_url":"https://api.github.com/users/opoplawski/followers","following_url":"https://api.github.com/users/opoplawski/following{/other_user}","gists_url":"https://api.github.com/users/opoplawski/gists{/gist_id}","starred_url":"https://api.github.com/users/opoplawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opoplawski/subscriptions","organizations_url":"https://api.github.com/users/opoplawski/orgs","repos_url":"https://api.github.com/users/opoplawski/repos","events_url":"https://api.github.com/users/opoplawski/events{/privacy}","received_events_url":"https://api.github.com/users/opoplawski/received_events","type":"User","site_admin":false},"created_at":"2018-12-30T02:13:19Z","updated_at":"2018-12-30T02:13:19Z","author_association":"CONTRIBUTOR","body":"I will rework this as a single initial module request, but perhaps a couple of questions could be decided here first (in addition to the ipaddress question above):\r\n- Does this belong in the network module namespace?\r\n- Should the multiple module_utils files be combined into a singe file or is it okay as is?\r\n- Is the approach taken with the pfsense_aggregate module reasonable?  Because aliases and rules are so connected (e.g. changing an alias name will require changing the alias name reference in the rules as well) it seems necessary - but the arguments currently seem unconventional. "}}
{"actor":{"display_login":"opoplawski"}}