{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/242873260","pull_request_review_id":186489518,"id":242873260,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjg3MzI2MA==","diff_hunk":"@@ -55,29 +55,33 @@ public RollershutterValue(@Nullable String upString, @Nullable String downString\n     @Override\n     public void update(Command command) throws IllegalArgumentException {\n         if (command instanceof UpDownType) {\n-            PercentType newState = ((UpDownType) command).as(PercentType.class);\n-            if (newState == null) { // Never happens\n-                return;\n-            }\n-            state = newState;\n+            throw new IllegalStateException(\"Cannot call update() with UpDownType\");","path":"extensions/binding/org.eclipse.smarthome.binding.mqtt.generic/src/main/java/org/eclipse/smarthome/binding/mqtt/generic/internal/values/RollershutterValue.java","position":9,"original_position":9,"commit_id":"f46136480e831533c9a80c65f297f159cbdea8da","original_commit_id":"f46136480e831533c9a80c65f297f159cbdea8da","user":{"login":"kaikreuzer","id":3244965,"node_id":"MDQ6VXNlcjMyNDQ5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3244965?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"body":"Yes, the commands UP/DOWN mean that it should move to UP (=0) or DOWN (=100) position.\r\n\r\n> also updates the state to 0% and 100% \r\n\r\nThe binding itself should indeed not update the state, but by default the \"autoupdate\" feature of the framework does it - if it sees an UP event, it will do a state auto-update to 0%.\r\n\r\nNote that since https://github.com/eclipse/smarthome/pull/5011, the binding can define an auto-update policy, so you can actually configure channels in a way that the framework suppresses the auto-update behavior. This is probably what should usually be done for rollershutters as the state is reached much later than the command has been received, so the state update should better come from the physical device.","created_at":"2018-12-19T10:55:29Z","updated_at":"2018-12-19T10:55:30Z","html_url":"https://github.com/eclipse/smarthome/pull/6695#discussion_r242873260","pull_request_url":"https://api.github.com/repos/eclipse/smarthome/pulls/6695","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/242873260"},"html":{"href":"https://github.com/eclipse/smarthome/pull/6695#discussion_r242873260"},"pull_request":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/6695"}},"in_reply_to_id":242587183},"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/6695","id":239448748,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NDQ4NzQ4","html_url":"https://github.com/eclipse/smarthome/pull/6695","diff_url":"https://github.com/eclipse/smarthome/pull/6695.diff","patch_url":"https://github.com/eclipse/smarthome/pull/6695.patch","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/6695","number":6695,"state":"open","locked":false,"title":"MQTT: Rollershutter channel. Proper STOP command support.","user":{"login":"davidgraeff","id":66436,"node_id":"MDQ6VXNlcjY2NDM2","avatar_url":"https://avatars2.githubusercontent.com/u/66436?v=4","gravatar_id":"","url":"https://api.github.com/users/davidgraeff","html_url":"https://github.com/davidgraeff","followers_url":"https://api.github.com/users/davidgraeff/followers","following_url":"https://api.github.com/users/davidgraeff/following{/other_user}","gists_url":"https://api.github.com/users/davidgraeff/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgraeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgraeff/subscriptions","organizations_url":"https://api.github.com/users/davidgraeff/orgs","repos_url":"https://api.github.com/users/davidgraeff/repos","events_url":"https://api.github.com/users/davidgraeff/events{/privacy}","received_events_url":"https://api.github.com/users/davidgraeff/received_events","type":"User","site_admin":false},"body":"The Rollershutter channel stores its value as percentage.\r\nUP/DOWN/STOP commands received via MQTT do not change that state.\r\n\r\nInstead of trying to handle those commands, they are now\r\nposted to the framework.\r\n\r\nSigned-off-by: David Gräff <david.graeff@web.de>","created_at":"2018-12-18T11:08:42Z","updated_at":"2018-12-19T10:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c5a96aa0f49fb44dce59db055ae9c15065273a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":921540941,"node_id":"MDU6TGFiZWw5MjE1NDA5NDE=","url":"https://api.github.com/repos/eclipse/smarthome/labels/Binding-MQTT","name":"Binding-MQTT","color":"048a8e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/smarthome/pulls/6695/commits","review_comments_url":"https://api.github.com/repos/eclipse/smarthome/pulls/6695/comments","review_comment_url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/6695/comments","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/f46136480e831533c9a80c65f297f159cbdea8da","head":{"label":"davidgraeff:mqttrollershutter","ref":"mqttrollershutter","sha":"f46136480e831533c9a80c65f297f159cbdea8da","user":{"login":"davidgraeff","id":66436,"node_id":"MDQ6VXNlcjY2NDM2","avatar_url":"https://avatars2.githubusercontent.com/u/66436?v=4","gravatar_id":"","url":"https://api.github.com/users/davidgraeff","html_url":"https://github.com/davidgraeff","followers_url":"https://api.github.com/users/davidgraeff/followers","following_url":"https://api.github.com/users/davidgraeff/following{/other_user}","gists_url":"https://api.github.com/users/davidgraeff/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgraeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgraeff/subscriptions","organizations_url":"https://api.github.com/users/davidgraeff/orgs","repos_url":"https://api.github.com/users/davidgraeff/repos","events_url":"https://api.github.com/users/davidgraeff/events{/privacy}","received_events_url":"https://api.github.com/users/davidgraeff/received_events","type":"User","site_admin":false},"repo":{"id":94952984,"node_id":"MDEwOlJlcG9zaXRvcnk5NDk1Mjk4NA==","name":"smarthome","full_name":"davidgraeff/smarthome","private":false,"owner":{"login":"davidgraeff","id":66436,"node_id":"MDQ6VXNlcjY2NDM2","avatar_url":"https://avatars2.githubusercontent.com/u/66436?v=4","gravatar_id":"","url":"https://api.github.com/users/davidgraeff","html_url":"https://github.com/davidgraeff","followers_url":"https://api.github.com/users/davidgraeff/followers","following_url":"https://api.github.com/users/davidgraeff/following{/other_user}","gists_url":"https://api.github.com/users/davidgraeff/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgraeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgraeff/subscriptions","organizations_url":"https://api.github.com/users/davidgraeff/orgs","repos_url":"https://api.github.com/users/davidgraeff/repos","events_url":"https://api.github.com/users/davidgraeff/events{/privacy}","received_events_url":"https://api.github.com/users/davidgraeff/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davidgraeff/smarthome","description":"Eclipse SmartHome™ project","fork":true,"url":"https://api.github.com/repos/davidgraeff/smarthome","forks_url":"https://api.github.com/repos/davidgraeff/smarthome/forks","keys_url":"https://api.github.com/repos/davidgraeff/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidgraeff/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidgraeff/smarthome/teams","hooks_url":"https://api.github.com/repos/davidgraeff/smarthome/hooks","issue_events_url":"https://api.github.com/repos/davidgraeff/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/davidgraeff/smarthome/events","assignees_url":"https://api.github.com/repos/davidgraeff/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/davidgraeff/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/davidgraeff/smarthome/tags","blobs_url":"https://api.github.com/repos/davidgraeff/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidgraeff/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidgraeff/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidgraeff/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidgraeff/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/davidgraeff/smarthome/languages","stargazers_url":"https://api.github.com/repos/davidgraeff/smarthome/stargazers","contributors_url":"https://api.github.com/repos/davidgraeff/smarthome/contributors","subscribers_url":"https://api.github.com/repos/davidgraeff/smarthome/subscribers","subscription_url":"https://api.github.com/repos/davidgraeff/smarthome/subscription","commits_url":"https://api.github.com/repos/davidgraeff/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidgraeff/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidgraeff/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidgraeff/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidgraeff/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/davidgraeff/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidgraeff/smarthome/merges","archive_url":"https://api.github.com/repos/davidgraeff/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidgraeff/smarthome/downloads","issues_url":"https://api.github.com/repos/davidgraeff/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/davidgraeff/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/davidgraeff/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/davidgraeff/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidgraeff/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/davidgraeff/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/davidgraeff/smarthome/deployments","created_at":"2017-06-21T02:07:59Z","updated_at":"2018-12-17T09:28:13Z","pushed_at":"2018-12-18T11:09:07Z","git_url":"git://github.com/davidgraeff/smarthome.git","ssh_url":"git@github.com:davidgraeff/smarthome.git","clone_url":"https://github.com/davidgraeff/smarthome.git","svn_url":"https://github.com/davidgraeff/smarthome","homepage":"https://www.eclipse.org/smarthome/","size":63912,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"d965793fafb908e8e6e66c385da859672940ed09","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15778981,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3ODk4MQ==","name":"smarthome","full_name":"eclipse/smarthome","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/smarthome","description":"Eclipse SmartHome™ project","fork":false,"url":"https://api.github.com/repos/eclipse/smarthome","forks_url":"https://api.github.com/repos/eclipse/smarthome/forks","keys_url":"https://api.github.com/repos/eclipse/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/smarthome/teams","hooks_url":"https://api.github.com/repos/eclipse/smarthome/hooks","issue_events_url":"https://api.github.com/repos/eclipse/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/smarthome/events","assignees_url":"https://api.github.com/repos/eclipse/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/smarthome/tags","blobs_url":"https://api.github.com/repos/eclipse/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/smarthome/languages","stargazers_url":"https://api.github.com/repos/eclipse/smarthome/stargazers","contributors_url":"https://api.github.com/repos/eclipse/smarthome/contributors","subscribers_url":"https://api.github.com/repos/eclipse/smarthome/subscribers","subscription_url":"https://api.github.com/repos/eclipse/smarthome/subscription","commits_url":"https://api.github.com/repos/eclipse/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/smarthome/merges","archive_url":"https://api.github.com/repos/eclipse/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/smarthome/downloads","issues_url":"https://api.github.com/repos/eclipse/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/smarthome/deployments","created_at":"2014-01-09T20:47:19Z","updated_at":"2018-12-18T17:39:22Z","pushed_at":"2018-12-18T16:01:09Z","git_url":"git://github.com/eclipse/smarthome.git","ssh_url":"git@github.com:eclipse/smarthome.git","clone_url":"https://github.com/eclipse/smarthome.git","svn_url":"https://github.com/eclipse/smarthome","homepage":"https://www.eclipse.org/smarthome/","size":65300,"stargazers_count":786,"watchers_count":786,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":784,"mirror_url":null,"archived":false,"open_issues_count":472,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":784,"open_issues":472,"watchers":786,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/6695"},"html":{"href":"https://github.com/eclipse/smarthome/pull/6695"},"issue":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/6695"},"comments":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/6695/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/6695/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/6695/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/smarthome/statuses/f46136480e831533c9a80c65f297f159cbdea8da"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kaikreuzer"}}