{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/7626","repository_url":"https://api.github.com/repos/minetest/minetest","labels_url":"https://api.github.com/repos/minetest/minetest/issues/7626/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/7626/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/7626/events","html_url":"https://github.com/minetest/minetest/pull/7626","id":348129517,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTUzNDYz","number":7626,"title":"Entity lighting fix","user":{"login":"hecktest","id":42101236,"node_id":"MDQ6VXNlcjQyMTAxMjM2","avatar_url":"https://avatars1.githubusercontent.com/u/42101236?v=4","gravatar_id":"","url":"https://api.github.com/users/hecktest","html_url":"https://github.com/hecktest","followers_url":"https://api.github.com/users/hecktest/followers","following_url":"https://api.github.com/users/hecktest/following{/other_user}","gists_url":"https://api.github.com/users/hecktest/gists{/gist_id}","starred_url":"https://api.github.com/users/hecktest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hecktest/subscriptions","organizations_url":"https://api.github.com/users/hecktest/orgs","repos_url":"https://api.github.com/users/hecktest/repos","events_url":"https://api.github.com/users/hecktest/events{/privacy}","received_events_url":"https://api.github.com/users/hecktest/received_events","type":"User","site_admin":false},"labels":[{"id":73369003,"node_id":"MDU6TGFiZWw3MzM2OTAwMw==","url":"https://api.github.com/repos/minetest/minetest/labels/@%20Client%20/%20Audiovisuals","name":"@ Client / Audiovisuals","color":"0e8a16","default":false},{"id":73368983,"node_id":"MDU6TGFiZWw3MzM2ODk4Mw==","url":"https://api.github.com/repos/minetest/minetest/labels/@%20Script%20API","name":"@ Script API","color":"0e8a16","default":false},{"id":372290178,"node_id":"MDU6TGFiZWwzNzIyOTAxNzg=","url":"https://api.github.com/repos/minetest/minetest/labels/Bugfix","name":"Bugfix","color":"c5def5","default":false},{"id":471238548,"node_id":"MDU6TGFiZWw0NzEyMzg1NDg=","url":"https://api.github.com/repos/minetest/minetest/labels/Feature","name":"Feature","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-07T00:59:56Z","updated_at":"2018-08-08T15:07:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/7626","html_url":"https://github.com/minetest/minetest/pull/7626","diff_url":"https://github.com/minetest/minetest/pull/7626.diff","patch_url":"https://github.com/minetest/minetest/pull/7626.patch"},"body":"This fixes the bug where entities would turn black if they had the origin at the feet, and were out of sunlight.\r\nTo make the fix more robust, a `light_anchor` property was created, replacing the hardcoded offset. The offset is applied in the entity's local space.\r\nIn order to easily transform said point to the entity's space, a typedef and a helper function for getting the scene node's matrix were added, since I couldn't find anything like that already in.\r\nThe default offset is +0.5 Y, which should work for almost any entity."},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/411439794","html_url":"https://github.com/minetest/minetest/pull/7626#issuecomment-411439794","issue_url":"https://api.github.com/repos/minetest/minetest/issues/7626","id":411439794,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTQzOTc5NA==","user":{"login":"lhofhansl","id":446130,"node_id":"MDQ6VXNlcjQ0NjEzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/446130?v=4","gravatar_id":"","url":"https://api.github.com/users/lhofhansl","html_url":"https://github.com/lhofhansl","followers_url":"https://api.github.com/users/lhofhansl/followers","following_url":"https://api.github.com/users/lhofhansl/following{/other_user}","gists_url":"https://api.github.com/users/lhofhansl/gists{/gist_id}","starred_url":"https://api.github.com/users/lhofhansl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhofhansl/subscriptions","organizations_url":"https://api.github.com/users/lhofhansl/orgs","repos_url":"https://api.github.com/users/lhofhansl/repos","events_url":"https://api.github.com/users/lhofhansl/events{/privacy}","received_events_url":"https://api.github.com/users/lhofhansl/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T15:07:39Z","updated_at":"2018-08-08T15:07:39Z","author_association":"CONTRIBUTOR","body":"This is a good idea. I can't judge the merits of the complexity vs. a simpler solution, though.\r\n\r\nI assume there are no performance concerns since this is done fairly infrequently...?\r\n"}}
{"actor":{"display_login":"lhofhansl"}}