{"push_id":2793869983,"size":33,"distinct_size":8,"ref":"refs/heads/reply-api-endpoints","head":"b7b43d745abf23ab85c24f645f295a7c9b181488","before":"86fdb7d455c34be7a4a07e2181661e10cfff5939","commits":[{"sha":"48a89bc3d9624ca3ef4f342009fd9eae87fb77a6","author":{"name":"Kevin O'Gorman","email":"c0bdfe80dd5754ef6dbce01bfedd95357fcc5597@freedom.press"},"message":"added instructions on using libvirt Vagrant provider in Ubuntu and Debian Stretch","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/48a89bc3d9624ca3ef4f342009fd9eae87fb77a6"},{"sha":"2dea0bcb7cc1bb617d766723995171c93e82528a","author":{"name":"Kevin O'Gorman","email":"c0bdfe80dd5754ef6dbce01bfedd95357fcc5597@freedom.press"},"message":"updated to reflect PR feedback","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/2dea0bcb7cc1bb617d766723995171c93e82528a"},{"sha":"b83f5c85c0d05fb58b22268998c30103e31c0165","author":{"name":"mickael e","email":"eb3c105ad8cd86bfd95733d7f85e279af00eb940@freedom.press"},"message":"Bump cryptography to 2.3 for admin workstation\n\nVersions of cryptography prior to 2.3 have a flaw in the implementation of AES-GCM (https://nvd.nist.gov/vuln/detail/CVE-2018-10903). While ansible/paramiko does not make use of AES-GCM let's still update the dependency.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/b83f5c85c0d05fb58b22268998c30103e31c0165"},{"sha":"9ff43908988b24b4aeef57988a5f8a288f44492d","author":{"name":"Kushal Das","email":"43bfbb322dc68f859cd7f240ffa89fc18432796d@freedom.press"},"message":"Maps docker ports only to localhost\n\nWe now map the development container ports only to the localhost.\nOtherwise we are in risk of exposing the container to the external\nnetwork. Fixes: #3686","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/9ff43908988b24b4aeef57988a5f8a288f44492d"},{"sha":"cd94f48d5f53fc61189a4736db2d39941ed76688","author":{"name":"mickael e","email":"6f2cbf549e88389ad64b44136b8b90e8d25782e2@users.noreply.github.com"},"message":"Merge pull request #3693 from kushaldas/localhost_portmapping\n\nMaps docker ports only to localhost","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/cd94f48d5f53fc61189a4736db2d39941ed76688"},{"sha":"87bacc1b52730612e35758f04681ea276924ce6a","author":{"name":"redshiftzero","email":"ce2e028af11e2044175219057c86bc1f3d51e88d@freedom.press"},"message":"Merge pull request #3679 from freedomofpress/bump-cryptography-admin\n\nBump pyca/cryptography to 2.3 for admin workstation","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/87bacc1b52730612e35758f04681ea276924ce6a"},{"sha":"aab0235c0145a5cd1a51178c974627a783af73c7","author":{"name":"Conor Schaefer","email":"92053a0ea29d3a95c7f6d0021e7464a2159ae789@freedom.press"},"message":"Removes mention of shared vagrant directories\n\nWe don't use Vagrant shared directories anywhere. They're disabled in\nstaging and prod. For the Dev VM, we did previously use shared\ndirectories, but the Dev VM has been removed in favor of the\ncontainerized dev env.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/aab0235c0145a5cd1a51178c974627a783af73c7"},{"sha":"cefcf986562409d875ceb1a9a622137962f38062","author":{"name":"Conor Schaefer","email":"92053a0ea29d3a95c7f6d0021e7464a2159ae789@freedom.press"},"message":"Defers Vagrant installation to dev setup docs\n\nWe don't need to re-recommend installation of Vagrant, a simple reminder\nand cross-link will suffice. Let's keep the docs dry.\n\nAdjusts the `ref`s to point appropriately. Also fixes a small typo in\nthe staging vars filename, which I noticed while editing.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/cefcf986562409d875ceb1a9a622137962f38062"},{"sha":"18a3ca5541dc3c47cd7ca02cd89155768ea130d5","author":{"name":"Conor Schaefer","email":"92053a0ea29d3a95c7f6d0021e7464a2159ae789@freedom.press"},"message":"Removes trailing whitespace in code docs\n\nThe libvirt install instructions had lots of trailing whitespace.\nRemoving those in this commit and nothing more.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/18a3ca5541dc3c47cd7ca02cd89155768ea130d5"},{"sha":"28458652789d14eaa87c9bdabdaa67630c8730db","author":{"name":"Conor Schaefer","email":"92053a0ea29d3a95c7f6d0021e7464a2159ae789@freedom.press"},"message":"Consolidates libvirt setup instructions\n\nThere was a bit of duplication between Ubuntu 16.04 and Debian 9 setup\ninstructions. Reorganized the libvirt docs a bit to isolate the\ndifferences, the group the similarities in the same flow.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/28458652789d14eaa87c9bdabdaa67630c8730db"},{"sha":"39c0a26dc12ddd89801410e28ee3177dcfc80e72","author":{"name":"Conor Schaefer","email":"a415e3f47c7d10c02b370153bdddfa30448f693e@users.noreply.github.com"},"message":"Merge pull request #3670 from zenmonkeykstop/docs-libvirt-setup\n\nadded instructions on using libvirt Vagrant provider in Ubuntu & Debian","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/39c0a26dc12ddd89801410e28ee3177dcfc80e72"},{"sha":"2b4486f2ea36bfa2cb95bb5179bb0289bead18fa","author":{"name":"redshiftzero","email":"ce2e028af11e2044175219057c86bc1f3d51e88d@freedom.press"},"message":"Docs: Update journalist guide for new reply behavior","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/2b4486f2ea36bfa2cb95bb5179bb0289bead18fa"},{"sha":"472b8db389becde40fc7c71347f1c2a5a4547784","author":{"name":"Conor Schaefer","email":"92053a0ea29d3a95c7f6d0021e7464a2159ae789@freedom.press"},"message":"Moves testinfra staging tests into molecule/\n\nUsing a shared test directory, outside of a single scenario, so that the\nsame staging config tests can be referenced by multiple scenarios (we\nalready have virtualbox, libvirt, and AWS staging scenarios).\n\nThis is a straightforward move operation, with two exceptions:\n\n  * updates some of the hardcoded relative paths in the OSSEC tests\n  * removes unused (always-skipped) ansible vars tests\n\nOther than that, couldn't be simpler.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/472b8db389becde40fc7c71347f1c2a5a4547784"},{"sha":"b09b912d5d70228bc1a849b2a06fe9d0bef07074","author":{"name":"Conor Schaefer","email":"92053a0ea29d3a95c7f6d0021e7464a2159ae789@freedom.press"},"message":"Updates testinfra dir path in libvirt Molecule config\n\nUses a shared directory that's accessible by all other Molecule\nscenarios.\n\nUsing the 'converge' playbook override, rather than the symlink, because\nthe \"ossec\" role was not running otherwise. I cannot explain why;\ntimeboxed the solution, and this is more straightforward anyway.\n\nParallelizes the testinfra test invocation. Made possible since we're\nrunning against both hosts concurrently now, so the combined test run\ngoes from 10m to 3.5m.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/b09b912d5d70228bc1a849b2a06fe9d0bef07074"},{"sha":"3e2e7feda8f9812a567719b6ba54e7e600c6fa61","author":{"name":"Conor Schaefer","email":"92053a0ea29d3a95c7f6d0021e7464a2159ae789@freedom.press"},"message":"Implements host targeting in testinfra tests\n\nUsing the `testinfra_hosts` pragma for multihost testing, taken straight\nout of the testinfra docs [0]. Rather than run the test suites\nsequentially against app and mon, we can run them at the same time, and\ntrust pytest to run correct per-hosts tests, based on the targeting.\n\nAccordingly, removes occurrences of the SECUREDROP_TESTINFRA_TARGET_HOST\nenv var throughout the tests, since we're no longer depending on that\nenv var for the tests to work.\n\n[0] http://testinfra.readthedocs.io/en/latest/invocation.html#test-multiples-hosts","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/3e2e7feda8f9812a567719b6ba54e7e600c6fa61"},{"sha":"0c59163e1a2691688a3206dc83f56370154ea7a2","author":{"name":"Conor Schaefer","email":"92053a0ea29d3a95c7f6d0021e7464a2159ae789@freedom.press"},"message":"Concatenates testinfra staging vars\n\nWe're eliminating use of the TESTINFRA_TARGET_HOST env var for importing\nvars. The vast majority of staging vars were intended as overrides\nvis-a-vis prod; not between app and mon. We're not currently testing\nprod, so that's an unnecessary optimization.\n\nThe staging.yml file is concatenated from the {app,mon}-staging.yml\nfiles, with a few exceptions:\n\n  * removed unused iptables ruleset (Jinja2 templates are used)\n  * removed mention of SSH tor service (untested in mon-staging)","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/0c59163e1a2691688a3206dc83f56370154ea7a2"},{"sha":"bc0ea08769e7b29612bbb639b55f30bf820a1d92","author":{"name":"Conor Schaefer","email":"92053a0ea29d3a95c7f6d0021e7464a2159ae789@freedom.press"},"message":"Renames testinfra files for uniqueness\n\nPytest expects the collected test files to be uniquely named, in terms\nof basename. We didn't encounter this before because we were running the\nconfig tests sequentially, against each host, so the collection was not\naggregated. When trying to run against a combined hostgroup, the\nfollowing error is shown:\n\n    ==================================== ERRORS ====================================\n    ____________ ERROR collecting testinfra/staging/mon/test_network.py ____________\n    import file mismatch:\n    imported module 'test_network' has this __file__ attribute:\n      /home/conor/freedomofpress/securedrop/molecule/testinfra/staging/app/test_network.py\n    which is not the same as the test file we want to collect:\n      /home/conor/freedomofpress/securedrop/molecule/testinfra/staging/mon/test_network.py\n    HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules\n    =============================== warnings summary ===============================\n\nRenaming the test files for unique basenames resolves, and is also more explicit.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/bc0ea08769e7b29612bbb639b55f30bf820a1d92"},{"sha":"2f83d056fdacf87a447f4f215e8e99a8060ff1b1","author":{"name":"Conor Schaefer","email":"92053a0ea29d3a95c7f6d0021e7464a2159ae789@freedom.press"},"message":"Skips all OSSEC functional tests\n\nThese tests were failing rather regularly during local development on\nthe testinfra reorg. After investigation, turns out they were being\ninadvertently skipped in CI, so I was debugging tests that never worked\nreliably.\n\nOpened a separate issue to fix those tests, skipping for now to keep\nmoving.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/2f83d056fdacf87a447f4f215e8e99a8060ff1b1"},{"sha":"4ae97c3436886c2f04923ee63e5979beabc1b655","author":{"name":"redshiftzero","email":"ce2e028af11e2044175219057c86bc1f3d51e88d@freedom.press"},"message":"Merge pull request #3690 from freedomofpress/reply-refactor-convo-history\n\nPreserve conversation history only for journalists","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/4ae97c3436886c2f04923ee63e5979beabc1b655"},{"sha":"09a485722dda2712764cc77c44469e14b2dc619b","author":{"name":"Conor Schaefer","email":"92053a0ea29d3a95c7f6d0021e7464a2159ae789@freedom.press"},"message":"Uses Molecule verify step for AWS scenario\n\nBegins the process of overriding the env vars for staging.\nIncludes a small change to the tor-apt test, for Python2 compatibility\n(otherwise the test can't be run locally).\n\nMore work required on balancing the side-effect logic. We'll still need\nside-effect to run the app tests, we can run the verify step after\nside-effect.\n\nIncludes some flake8 linting, since via Molecule, we're now linting the\nentire testinfra directory.\n\nUpdates JUnit test file handling\n\nThe paths to the helper scripts changed a bit, so updating them here. We\nhad some skipped logic in the side-effect which has no been removed, so\nwe don't have to maintain it any longer.\n\nMoved the junit logic out of the side-effect since the testinfra tests\nare run after the side-effect (and therefore the XML file wouldn't have\nexisted yet).","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop/commits/09a485722dda2712764cc77c44469e14b2dc619b"}]}
{"actor":{"display_login":"redshiftzero"}}