{"action":"created","comment":{"url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/comments/230378093","pull_request_review_id":171106279,"id":230378093,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDM3ODA5Mw==","diff_hunk":"@@ -574,6 +574,33 @@ describe(\"app\", function() {\n             });\n         });\n \n+        describe(\"when on state_mobile_no and number has no subscription\", function() {\n+            it(\"should go to state_consent\", function() {\n+                return tester\n+                .setup(function(api) {\n+                    api.http.fixtures.add(fixtures_IdentityStoreDynamic.identity_search({\n+                        'msisdn': '+27820001001'\n+                    }));\n+                    api.http.fixtures.add(fixtures_StageBasedMessagingDynamic.active_subscriptions());\n+                })\n+                .setup.user.answer('operator', {'id': 'operator-id'})\n+                .setup.user.answer('operator_msisdn', '+27820001002')\n+                .setup.user.state('state_mobile_no')\n+                .input('0820001001')\n+                .check.interaction({\n+                    state: \"state_consent\",\n+                    reply: [\n+                            'We need to collect, store & use her info. She ' +\n+                            'may get messages on public holidays & weekends. ' +\n+                            'Does she consent?',\n+                            '1. Yes',\n+                            '2. No'\n+                    ].join('\\n')\n+                })\n+                .run();\n+            });\n+        });","path":"test/ussd_clinic.test.js","position":29,"original_position":29,"commit_id":"a91512400f2303fa854fb54de96e9055e49f1a79","original_commit_id":"a91512400f2303fa854fb54de96e9055e49f1a79","user":{"login":"rudigiesler","id":8234653,"node_id":"MDQ6VXNlcjgyMzQ2NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/8234653?v=4","gravatar_id":"","url":"https://api.github.com/users/rudigiesler","html_url":"https://github.com/rudigiesler","followers_url":"https://api.github.com/users/rudigiesler/followers","following_url":"https://api.github.com/users/rudigiesler/following{/other_user}","gists_url":"https://api.github.com/users/rudigiesler/gists{/gist_id}","starred_url":"https://api.github.com/users/rudigiesler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudigiesler/subscriptions","organizations_url":"https://api.github.com/users/rudigiesler/orgs","repos_url":"https://api.github.com/users/rudigiesler/repos","events_url":"https://api.github.com/users/rudigiesler/events{/privacy}","received_events_url":"https://api.github.com/users/rudigiesler/received_events","type":"User","site_admin":false},"body":"I don't think that this test will trigger the bug. We need to test that the output of `state_already_subscribed` shows the entered number, not the current handset's number.\r\n\r\nWe can probably modify one of the existing tests to have a different `setup.user.addr` to what's configured in `registrant_msisdn`, and ensure that the response includes `registrant_msisdn`","created_at":"2018-11-02T13:46:28Z","updated_at":"2018-11-02T13:49:32Z","html_url":"https://github.com/praekeltfoundation/ndoh-jsbox/pull/201#discussion_r230378093","pull_request_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/201","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/comments/230378093"},"html":{"href":"https://github.com/praekeltfoundation/ndoh-jsbox/pull/201#discussion_r230378093"},"pull_request":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/201","id":227938823,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTM4ODIz","html_url":"https://github.com/praekeltfoundation/ndoh-jsbox/pull/201","diff_url":"https://github.com/praekeltfoundation/ndoh-jsbox/pull/201.diff","patch_url":"https://github.com/praekeltfoundation/ndoh-jsbox/pull/201.patch","issue_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/201","number":201,"state":"open","locked":false,"title":"Feature/momza 1075 fix clinic ussd already registered number","user":{"login":"OMosimege","id":28597626,"node_id":"MDQ6VXNlcjI4NTk3NjI2","avatar_url":"https://avatars1.githubusercontent.com/u/28597626?v=4","gravatar_id":"","url":"https://api.github.com/users/OMosimege","html_url":"https://github.com/OMosimege","followers_url":"https://api.github.com/users/OMosimege/followers","following_url":"https://api.github.com/users/OMosimege/following{/other_user}","gists_url":"https://api.github.com/users/OMosimege/gists{/gist_id}","starred_url":"https://api.github.com/users/OMosimege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OMosimege/subscriptions","organizations_url":"https://api.github.com/users/OMosimege/orgs","repos_url":"https://api.github.com/users/OMosimege/repos","events_url":"https://api.github.com/users/OMosimege/events{/privacy}","received_events_url":"https://api.github.com/users/OMosimege/received_events","type":"User","site_admin":false},"body":"Fix for clinic USSD line, if the number entered already has an active momconnect subscription, then it shows an error message. But that error message shows the number that is dialling the line, not the number that was checked for an active subscription\r\n\r\nInitially, it was using the operator msisdn to check the subscription, and not the registrant msisdn (which in most cases is different from the operator msisdn)","created_at":"2018-11-02T13:37:13Z","updated_at":"2018-11-02T13:49:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86289ff816e166b57b6df68b3a9fca48ba6cfed0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/201/commits","review_comments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/201/comments","review_comment_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/201/comments","statuses_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/statuses/a91512400f2303fa854fb54de96e9055e49f1a79","head":{"label":"praekeltfoundation:feature/MOMZA-1075-Fix-Clinic-USSD-already-registered-number","ref":"feature/MOMZA-1075-Fix-Clinic-USSD-already-registered-number","sha":"a91512400f2303fa854fb54de96e9055e49f1a79","user":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":61732866,"node_id":"MDEwOlJlcG9zaXRvcnk2MTczMjg2Ng==","name":"ndoh-jsbox","full_name":"praekeltfoundation/ndoh-jsbox","private":false,"owner":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/praekeltfoundation/ndoh-jsbox","description":null,"fork":false,"url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox","forks_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/forks","keys_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/teams","hooks_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/hooks","issue_events_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/events{/number}","events_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/events","assignees_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/assignees{/user}","branches_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/branches{/branch}","tags_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/tags","blobs_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/statuses/{sha}","languages_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/languages","stargazers_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/stargazers","contributors_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/contributors","subscribers_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/subscribers","subscription_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/subscription","commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/contents/{+path}","compare_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/merges","archive_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/downloads","issues_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues{/number}","pulls_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls{/number}","milestones_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/milestones{/number}","notifications_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/labels{/name}","releases_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/releases{/id}","deployments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/deployments","created_at":"2016-06-22T16:05:38Z","updated_at":"2018-10-30T15:04:23Z","pushed_at":"2018-11-02T13:37:14Z","git_url":"git://github.com/praekeltfoundation/ndoh-jsbox.git","ssh_url":"git@github.com:praekeltfoundation/ndoh-jsbox.git","clone_url":"https://github.com/praekeltfoundation/ndoh-jsbox.git","svn_url":"https://github.com/praekeltfoundation/ndoh-jsbox","homepage":null,"size":2242,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"praekeltfoundation:develop","ref":"develop","sha":"78c6e1d299c3492f2e0ff5e3f7a6a1d10a28f51c","user":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":61732866,"node_id":"MDEwOlJlcG9zaXRvcnk2MTczMjg2Ng==","name":"ndoh-jsbox","full_name":"praekeltfoundation/ndoh-jsbox","private":false,"owner":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/praekeltfoundation/ndoh-jsbox","description":null,"fork":false,"url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox","forks_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/forks","keys_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/teams","hooks_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/hooks","issue_events_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/events{/number}","events_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/events","assignees_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/assignees{/user}","branches_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/branches{/branch}","tags_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/tags","blobs_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/statuses/{sha}","languages_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/languages","stargazers_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/stargazers","contributors_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/contributors","subscribers_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/subscribers","subscription_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/subscription","commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/contents/{+path}","compare_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/merges","archive_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/downloads","issues_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues{/number}","pulls_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls{/number}","milestones_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/milestones{/number}","notifications_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/labels{/name}","releases_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/releases{/id}","deployments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/deployments","created_at":"2016-06-22T16:05:38Z","updated_at":"2018-10-30T15:04:23Z","pushed_at":"2018-11-02T13:37:14Z","git_url":"git://github.com/praekeltfoundation/ndoh-jsbox.git","ssh_url":"git@github.com:praekeltfoundation/ndoh-jsbox.git","clone_url":"https://github.com/praekeltfoundation/ndoh-jsbox.git","svn_url":"https://github.com/praekeltfoundation/ndoh-jsbox","homepage":null,"size":2242,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/201"},"html":{"href":"https://github.com/praekeltfoundation/ndoh-jsbox/pull/201"},"issue":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/201"},"comments":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/statuses/a91512400f2303fa854fb54de96e9055e49f1a79"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rudigiesler"}}