{"action":"created","issue":{"url":"https://api.github.com/repos/ros-infrastructure/rosdep/issues/638","repository_url":"https://api.github.com/repos/ros-infrastructure/rosdep","labels_url":"https://api.github.com/repos/ros-infrastructure/rosdep/issues/638/labels{/name}","comments_url":"https://api.github.com/repos/ros-infrastructure/rosdep/issues/638/comments","events_url":"https://api.github.com/repos/ros-infrastructure/rosdep/issues/638/events","html_url":"https://github.com/ros-infrastructure/rosdep/pull/638","id":375214710,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzEyMTMz","number":638,"title":"Make DNF install best-effort like YUM","user":{"login":"cottsay","id":1144588,"node_id":"MDQ6VXNlcjExNDQ1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1144588?v=4","gravatar_id":"","url":"https://api.github.com/users/cottsay","html_url":"https://github.com/cottsay","followers_url":"https://api.github.com/users/cottsay/followers","following_url":"https://api.github.com/users/cottsay/following{/other_user}","gists_url":"https://api.github.com/users/cottsay/gists{/gist_id}","starred_url":"https://api.github.com/users/cottsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cottsay/subscriptions","organizations_url":"https://api.github.com/users/cottsay/orgs","repos_url":"https://api.github.com/users/cottsay/repos","events_url":"https://api.github.com/users/cottsay/events{/privacy}","received_events_url":"https://api.github.com/users/cottsay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-29T21:01:07Z","updated_at":"2018-11-02T15:50:52Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ros-infrastructure/rosdep/pulls/638","html_url":"https://github.com/ros-infrastructure/rosdep/pull/638","diff_url":"https://github.com/ros-infrastructure/rosdep/pull/638.diff","patch_url":"https://github.com/ros-infrastructure/rosdep/pull/638.patch"},"body":"When the `DnfInstaller` was added, I believed that DNF's default behavior was best-effort, and this was the reason that the YUM option `--skip-broken` didn't work. It turns out that this is only the case for updates, and that the `install` verb still needs to be told to be best-effort.\r\n\r\nAt some point `--skip-broken` was added to DNF as an alias for `--setopt=strict=0`. Since older DNF versions don't support `--skip-broken`, we should use `--setopt=strict=0` directly to achieve the expected behavior here.\r\n\r\nWhen a broken package install is attempted, DNF will return 0 and rosdep will detect the missing package as \"was supposed to be installed but was not,\" prompting further inspection of the DNF console output."},"comment":{"url":"https://api.github.com/repos/ros-infrastructure/rosdep/issues/comments/435424894","html_url":"https://github.com/ros-infrastructure/rosdep/pull/638#issuecomment-435424894","issue_url":"https://api.github.com/repos/ros-infrastructure/rosdep/issues/638","id":435424894,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTQyNDg5NA==","user":{"login":"cottsay","id":1144588,"node_id":"MDQ6VXNlcjExNDQ1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1144588?v=4","gravatar_id":"","url":"https://api.github.com/users/cottsay","html_url":"https://github.com/cottsay","followers_url":"https://api.github.com/users/cottsay/followers","following_url":"https://api.github.com/users/cottsay/following{/other_user}","gists_url":"https://api.github.com/users/cottsay/gists{/gist_id}","starred_url":"https://api.github.com/users/cottsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cottsay/subscriptions","organizations_url":"https://api.github.com/users/cottsay/orgs","repos_url":"https://api.github.com/users/cottsay/repos","events_url":"https://api.github.com/users/cottsay/events{/privacy}","received_events_url":"https://api.github.com/users/cottsay/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T15:50:52Z","updated_at":"2018-11-02T15:50:52Z","author_association":"MEMBER","body":"Looks good now, @nuclearsandwich. Thanks!"}}
{"actor":{"display_login":"cottsay"}}