{"action":"created","comment":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/comments/188542718","pull_request_review_id":120539906,"id":188542718,"diff_hunk":"@@ -252,17 +255,47 @@ def configure_autofs_common(fstore, statestore, options):\n                      autofs.service_name, str(e))\n \n def uninstall(fstore, statestore):\n+    RESTORE_FILES=[\n+       paths.SYSCONFIG_AUTOFS,\n+       paths.NSSWITCH_CONF,\n+       paths.AUTOFS_LDAP_AUTH_CONF,\n+       paths.SYSCONFIG_NFS,\n+       paths.IDMAPD_CONF,\n+    ]\n+    STATES=['autofs', 'rpcidmapd', 'rpcgssd']\n+\n+    # automount only touches /etc/nsswitch.conf if the LDAP is\n+    # used. Don't restore it otherwise.\n+    sssd = None\n+\n+    if statestore.has_state('authselect'):","path":"client/ipa-client-automount","position":null,"original_position":36,"commit_id":"8ae5937a2c58435907ac81e5621f4a76986204ac","original_commit_id":"eba68d86731db49ef58065d235d35c7bbd94987d","user":{"login":"Tiboris","id":14825963,"avatar_url":"https://avatars1.githubusercontent.com/u/14825963?v=4","gravatar_id":"","url":"https://api.github.com/users/Tiboris","html_url":"https://github.com/Tiboris","followers_url":"https://api.github.com/users/Tiboris/followers","following_url":"https://api.github.com/users/Tiboris/following{/other_user}","gists_url":"https://api.github.com/users/Tiboris/gists{/gist_id}","starred_url":"https://api.github.com/users/Tiboris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tiboris/subscriptions","organizations_url":"https://api.github.com/users/Tiboris/orgs","repos_url":"https://api.github.com/users/Tiboris/repos","events_url":"https://api.github.com/users/Tiboris/events{/privacy}","received_events_url":"https://api.github.com/users/Tiboris/received_events","type":"User","site_admin":false},"body":"Understand :) ","created_at":"2018-05-16T08:32:10Z","updated_at":"2018-05-16T08:32:10Z","html_url":"https://github.com/freeipa/freeipa/pull/1889#discussion_r188542718","pull_request_url":"https://api.github.com/repos/freeipa/freeipa/pulls/1889","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/comments/188542718"},"html":{"href":"https://github.com/freeipa/freeipa/pull/1889#discussion_r188542718"},"pull_request":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/1889"}},"in_reply_to_id":187966865},"pull_request":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/1889","id":185068043,"html_url":"https://github.com/freeipa/freeipa/pull/1889","diff_url":"https://github.com/freeipa/freeipa/pull/1889.diff","patch_url":"https://github.com/freeipa/freeipa/pull/1889.patch","issue_url":"https://api.github.com/repos/freeipa/freeipa/issues/1889","number":1889,"state":"open","locked":false,"title":"Return unique error when automount is already or not configured","user":{"login":"rcritten","id":5193315,"avatar_url":"https://avatars3.githubusercontent.com/u/5193315?v=4","gravatar_id":"","url":"https://api.github.com/users/rcritten","html_url":"https://github.com/rcritten","followers_url":"https://api.github.com/users/rcritten/followers","following_url":"https://api.github.com/users/rcritten/following{/other_user}","gists_url":"https://api.github.com/users/rcritten/gists{/gist_id}","starred_url":"https://api.github.com/users/rcritten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcritten/subscriptions","organizations_url":"https://api.github.com/users/rcritten/orgs","repos_url":"https://api.github.com/users/rcritten/repos","events_url":"https://api.github.com/users/rcritten/events{/privacy}","received_events_url":"https://api.github.com/users/rcritten/received_events","type":"User","site_admin":false},"body":"Use identical return codes as ipa-client-install when uninstalling\r\nipa-client-automount and it is not configured, or when calling\r\nit again to return that is ias already configured.\r\n\r\nhttps://pagure.io/freeipa/issue/7396\r\n\r\nSigned-off-by: Rob Crittenden <rcritten@redhat.com>","created_at":"2018-04-30T21:21:14Z","updated_at":"2018-05-16T08:32:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e97a8aaf1155be4b153e95fb13952ebfde608ec","assignee":{"login":"Tiboris","id":14825963,"avatar_url":"https://avatars1.githubusercontent.com/u/14825963?v=4","gravatar_id":"","url":"https://api.github.com/users/Tiboris","html_url":"https://github.com/Tiboris","followers_url":"https://api.github.com/users/Tiboris/followers","following_url":"https://api.github.com/users/Tiboris/following{/other_user}","gists_url":"https://api.github.com/users/Tiboris/gists{/gist_id}","starred_url":"https://api.github.com/users/Tiboris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tiboris/subscriptions","organizations_url":"https://api.github.com/users/Tiboris/orgs","repos_url":"https://api.github.com/users/Tiboris/repos","events_url":"https://api.github.com/users/Tiboris/events{/privacy}","received_events_url":"https://api.github.com/users/Tiboris/received_events","type":"User","site_admin":false},"assignees":[{"login":"Tiboris","id":14825963,"avatar_url":"https://avatars1.githubusercontent.com/u/14825963?v=4","gravatar_id":"","url":"https://api.github.com/users/Tiboris","html_url":"https://github.com/Tiboris","followers_url":"https://api.github.com/users/Tiboris/followers","following_url":"https://api.github.com/users/Tiboris/following{/other_user}","gists_url":"https://api.github.com/users/Tiboris/gists{/gist_id}","starred_url":"https://api.github.com/users/Tiboris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tiboris/subscriptions","organizations_url":"https://api.github.com/users/Tiboris/orgs","repos_url":"https://api.github.com/users/Tiboris/repos","events_url":"https://api.github.com/users/Tiboris/events{/privacy}","received_events_url":"https://api.github.com/users/Tiboris/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/freeipa/freeipa/pulls/1889/commits","review_comments_url":"https://api.github.com/repos/freeipa/freeipa/pulls/1889/comments","review_comment_url":"https://api.github.com/repos/freeipa/freeipa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeipa/freeipa/issues/1889/comments","statuses_url":"https://api.github.com/repos/freeipa/freeipa/statuses/8ae5937a2c58435907ac81e5621f4a76986204ac","head":{"label":"rcritten:automount","ref":"automount","sha":"8ae5937a2c58435907ac81e5621f4a76986204ac","user":{"login":"rcritten","id":5193315,"avatar_url":"https://avatars3.githubusercontent.com/u/5193315?v=4","gravatar_id":"","url":"https://api.github.com/users/rcritten","html_url":"https://github.com/rcritten","followers_url":"https://api.github.com/users/rcritten/followers","following_url":"https://api.github.com/users/rcritten/following{/other_user}","gists_url":"https://api.github.com/users/rcritten/gists{/gist_id}","starred_url":"https://api.github.com/users/rcritten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcritten/subscriptions","organizations_url":"https://api.github.com/users/rcritten/orgs","repos_url":"https://api.github.com/users/rcritten/repos","events_url":"https://api.github.com/users/rcritten/events{/privacy}","received_events_url":"https://api.github.com/users/rcritten/received_events","type":"User","site_admin":false},"repo":{"id":90297541,"name":"freeipa","full_name":"rcritten/freeipa","owner":{"login":"rcritten","id":5193315,"avatar_url":"https://avatars3.githubusercontent.com/u/5193315?v=4","gravatar_id":"","url":"https://api.github.com/users/rcritten","html_url":"https://github.com/rcritten","followers_url":"https://api.github.com/users/rcritten/followers","following_url":"https://api.github.com/users/rcritten/following{/other_user}","gists_url":"https://api.github.com/users/rcritten/gists{/gist_id}","starred_url":"https://api.github.com/users/rcritten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcritten/subscriptions","organizations_url":"https://api.github.com/users/rcritten/orgs","repos_url":"https://api.github.com/users/rcritten/repos","events_url":"https://api.github.com/users/rcritten/events{/privacy}","received_events_url":"https://api.github.com/users/rcritten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rcritten/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":true,"url":"https://api.github.com/repos/rcritten/freeipa","forks_url":"https://api.github.com/repos/rcritten/freeipa/forks","keys_url":"https://api.github.com/repos/rcritten/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcritten/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcritten/freeipa/teams","hooks_url":"https://api.github.com/repos/rcritten/freeipa/hooks","issue_events_url":"https://api.github.com/repos/rcritten/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/rcritten/freeipa/events","assignees_url":"https://api.github.com/repos/rcritten/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/rcritten/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/rcritten/freeipa/tags","blobs_url":"https://api.github.com/repos/rcritten/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcritten/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcritten/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcritten/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcritten/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/rcritten/freeipa/languages","stargazers_url":"https://api.github.com/repos/rcritten/freeipa/stargazers","contributors_url":"https://api.github.com/repos/rcritten/freeipa/contributors","subscribers_url":"https://api.github.com/repos/rcritten/freeipa/subscribers","subscription_url":"https://api.github.com/repos/rcritten/freeipa/subscription","commits_url":"https://api.github.com/repos/rcritten/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcritten/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcritten/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcritten/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcritten/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/rcritten/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcritten/freeipa/merges","archive_url":"https://api.github.com/repos/rcritten/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcritten/freeipa/downloads","issues_url":"https://api.github.com/repos/rcritten/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/rcritten/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/rcritten/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/rcritten/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcritten/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/rcritten/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/rcritten/freeipa/deployments","created_at":"2017-05-04T18:41:39Z","updated_at":"2018-04-20T13:56:16Z","pushed_at":"2018-05-14T20:32:20Z","git_url":"git://github.com/rcritten/freeipa.git","ssh_url":"git@github.com:rcritten/freeipa.git","clone_url":"https://github.com/rcritten/freeipa.git","svn_url":"https://github.com/rcritten/freeipa","homepage":"http://www.freeipa.org","size":48689,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeipa:master","ref":"master","sha":"23c23a3cc17288b1fdacc73cca316fd427bcc517","user":{"login":"freeipa","id":10979201,"avatar_url":"https://avatars2.githubusercontent.com/u/10979201?v=4","gravatar_id":"","url":"https://api.github.com/users/freeipa","html_url":"https://github.com/freeipa","followers_url":"https://api.github.com/users/freeipa/followers","following_url":"https://api.github.com/users/freeipa/following{/other_user}","gists_url":"https://api.github.com/users/freeipa/gists{/gist_id}","starred_url":"https://api.github.com/users/freeipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeipa/subscriptions","organizations_url":"https://api.github.com/users/freeipa/orgs","repos_url":"https://api.github.com/users/freeipa/repos","events_url":"https://api.github.com/users/freeipa/events{/privacy}","received_events_url":"https://api.github.com/users/freeipa/received_events","type":"Organization","site_admin":false},"repo":{"id":4340318,"name":"freeipa","full_name":"freeipa/freeipa","owner":{"login":"freeipa","id":10979201,"avatar_url":"https://avatars2.githubusercontent.com/u/10979201?v=4","gravatar_id":"","url":"https://api.github.com/users/freeipa","html_url":"https://github.com/freeipa","followers_url":"https://api.github.com/users/freeipa/followers","following_url":"https://api.github.com/users/freeipa/following{/other_user}","gists_url":"https://api.github.com/users/freeipa/gists{/gist_id}","starred_url":"https://api.github.com/users/freeipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeipa/subscriptions","organizations_url":"https://api.github.com/users/freeipa/orgs","repos_url":"https://api.github.com/users/freeipa/repos","events_url":"https://api.github.com/users/freeipa/events{/privacy}","received_events_url":"https://api.github.com/users/freeipa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeipa/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":false,"url":"https://api.github.com/repos/freeipa/freeipa","forks_url":"https://api.github.com/repos/freeipa/freeipa/forks","keys_url":"https://api.github.com/repos/freeipa/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeipa/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeipa/freeipa/teams","hooks_url":"https://api.github.com/repos/freeipa/freeipa/hooks","issue_events_url":"https://api.github.com/repos/freeipa/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/freeipa/freeipa/events","assignees_url":"https://api.github.com/repos/freeipa/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/freeipa/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/freeipa/freeipa/tags","blobs_url":"https://api.github.com/repos/freeipa/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeipa/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeipa/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeipa/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeipa/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/freeipa/freeipa/languages","stargazers_url":"https://api.github.com/repos/freeipa/freeipa/stargazers","contributors_url":"https://api.github.com/repos/freeipa/freeipa/contributors","subscribers_url":"https://api.github.com/repos/freeipa/freeipa/subscribers","subscription_url":"https://api.github.com/repos/freeipa/freeipa/subscription","commits_url":"https://api.github.com/repos/freeipa/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeipa/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeipa/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeipa/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeipa/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/freeipa/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeipa/freeipa/merges","archive_url":"https://api.github.com/repos/freeipa/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeipa/freeipa/downloads","issues_url":"https://api.github.com/repos/freeipa/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/freeipa/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/freeipa/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/freeipa/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeipa/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/freeipa/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/freeipa/freeipa/deployments","created_at":"2012-05-15T20:34:40Z","updated_at":"2018-05-15T19:35:59Z","pushed_at":"2018-05-16T08:29:17Z","git_url":"git://github.com/freeipa/freeipa.git","ssh_url":"git@github.com:freeipa/freeipa.git","clone_url":"https://github.com/freeipa/freeipa.git","svn_url":"https://github.com/freeipa/freeipa","homepage":"http://www.freeipa.org","size":48561,"stargazers_count":192,"watchers_count":192,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":137,"open_issues":33,"watchers":192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/1889"},"html":{"href":"https://github.com/freeipa/freeipa/pull/1889"},"issue":{"href":"https://api.github.com/repos/freeipa/freeipa/issues/1889"},"comments":{"href":"https://api.github.com/repos/freeipa/freeipa/issues/1889/comments"},"review_comments":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/1889/comments"},"review_comment":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/1889/commits"},"statuses":{"href":"https://api.github.com/repos/freeipa/freeipa/statuses/8ae5937a2c58435907ac81e5621f4a76986204ac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Tiboris"}}