{"action":"created","issue":{"url":"https://api.github.com/repos/openssl/openssl/issues/6868","repository_url":"https://api.github.com/repos/openssl/openssl","labels_url":"https://api.github.com/repos/openssl/openssl/issues/6868/labels{/name}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/6868/comments","events_url":"https://api.github.com/repos/openssl/openssl/issues/6868/events","html_url":"https://github.com/openssl/openssl/pull/6868","id":347816709,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzE2Nzcw","number":6868,"title":"Check ameth->pem_str before strlen","user":{"login":"scw00","id":12470347,"node_id":"MDQ6VXNlcjEyNDcwMzQ3","avatar_url":"https://avatars2.githubusercontent.com/u/12470347?v=4","gravatar_id":"","url":"https://api.github.com/users/scw00","html_url":"https://github.com/scw00","followers_url":"https://api.github.com/users/scw00/followers","following_url":"https://api.github.com/users/scw00/following{/other_user}","gists_url":"https://api.github.com/users/scw00/gists{/gist_id}","starred_url":"https://api.github.com/users/scw00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scw00/subscriptions","organizations_url":"https://api.github.com/users/scw00/orgs","repos_url":"https://api.github.com/users/scw00/repos","events_url":"https://api.github.com/users/scw00/events{/privacy}","received_events_url":"https://api.github.com/users/scw00/received_events","type":"User","site_admin":false},"labels":[{"id":431503371,"node_id":"MDU6TGFiZWw0MzE1MDMzNzE=","url":"https://api.github.com/repos/openssl/openssl/labels/need-cla","name":"need-cla","color":"E11D21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-08-06T07:54:46Z","updated_at":"2018-08-07T02:43:00Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/6868","html_url":"https://github.com/openssl/openssl/pull/6868","diff_url":"https://github.com/openssl/openssl/pull/6868.diff","patch_url":"https://github.com/openssl/openssl/pull/6868.patch"},"body":"<!--\r\nThank you for your pull request. Please review these requirements:\r\n\r\nContributors guide: https://github.com/openssl/openssl/blob/master/CONTRIBUTING\r\n\r\nOther than that, provide a description above this comment if there isn't one already\r\n\r\nIf this fixes a github issue, make sure to have a line saying 'Fixes #XXXX' (without quotes) in the commit message.\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n- [ ] documentation is added or updated\r\n- [ ] tests are added or updated\r\n\r\nGot a crash:\r\n\r\n```\r\nProgram received signal SIGSEGV, Segmentation fault.\r\nstrlen () at ../sysdeps/x86_64/strlen.S:106\r\n106\t../sysdeps/x86_64/strlen.S: No such file or directory.\r\n(gdb) bt full\r\n#0  strlen () at ../sysdeps/x86_64/strlen.S:106\r\nNo locals.\r\n#1  0x000000000048320d in __interceptor_strlen.part.31 ()\r\nNo symbol table info available.\r\n#2  0x00007ffff769ae1b in EVP_PKEY_asn1_find_str (pe=0x7fffffff1cc8, str=0x7ffff7bb18de \"gost-mac\", len=8) at crypto/asn1/ameth_lib.c:132\r\n        i = 6\r\n        ameth = 0x7ffff7af8f68 <dsa_asn1_meths+840>\r\n#3  0x00007ffff7b5e385 in get_optional_pkey_id (pkey_name=0x7ffff7bb18de \"gost-mac\") at ssl/ssl_ciph.c:337\r\n        ameth = 0x7ffff7bb18a0\r\n        tmpeng = 0x0\r\n        pkey_id = 0\r\n#4  0x00007ffff7b5e61c in ssl_load_ciphers () at ssl/ssl_ciph.c:420\r\n        i = 12\r\n        t = 0x7ffff7bb1580 <ssl_cipher_table_kx>\r\n#5  0x00007ffff7b639b1 in ossl_init_ssl_base () at ssl/ssl_init.c:102\r\nNo locals.\r\n#6  0x00007ffff7b637bf in ossl_init_ssl_base_ossl_ () at ssl/ssl_init.c:24\r\nNo locals.\r\n#7  0x00007ffff6b57a99 in __pthread_once_slow (once_control=0x7ffff7dd6798 <ssl_base>, init_routine=0x7ffff7b637b6 <ossl_init_ssl_base_ossl_>) at pthread_once.c:116\r\n        _buffer = {__routine = 0x7ffff6b57ae0 <clear_once_control>, __arg = 0x7ffff7dd6798 <ssl_base>, __canceltype = 65792, __prev = 0x0}\r\n        val = 0\r\n        newval = <optimized out>\r\n#8  0x00007ffff7823a7b in CRYPTO_THREAD_run_once (once=0x7ffff7dd6798 <ssl_base>, init=0x7ffff7b637b6 <ossl_init_ssl_base_ossl_>) at crypto/threads_pthread.c:113\r\nNo locals.\r\n#9  0x00007ffff7b63af1 in OPENSSL_init_ssl (opts=2097152, settings=0x0) at ssl/ssl_init.c:206\r\n        stoperrset = 0\r\n#10 0x00007ffff7b6a5db in SSL_CTX_new (meth=0x7ffff7dcfa80 <TLS_method_data.22184>) at ssl/ssl_lib.c:2889\r\n\r\n```\r\n\r\n`dsa_asn1_meths[0-3]` does not have pem_str.\r\n\r\nPlease feel free to close it if this bug has been fixed.  "},"comment":{"url":"https://api.github.com/repos/openssl/openssl/issues/comments/410914942","html_url":"https://github.com/openssl/openssl/pull/6868#issuecomment-410914942","issue_url":"https://api.github.com/repos/openssl/openssl/issues/6868","id":410914942,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDkxNDk0Mg==","user":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T02:43:00Z","updated_at":"2018-08-07T02:43:00Z","author_association":"MEMBER","body":"I'd like to know a bit about the circumstances.  Was an engine used?  Or oh, you're talking about a custom version...  could it be that this customization involves an added `EVP_PKEY_ASN1_METHOD`?  I can imagine that a badly coded structure with no `pem_str` and no `ASN1_PKEY_ALIAS` flag would cause this crash.  If there is such badly coded structure within the mainstream OpenSSL code, we sure would like to know...  if there is such badly coded structure in your customization, then the error is on you."}}
{"actor":{"display_login":"levitte"}}