{"action":"opened","number":18861,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/18861","id":169873836,"html_url":"https://github.com/nodejs/node/pull/18861","diff_url":"https://github.com/nodejs/node/pull/18861.diff","patch_url":"https://github.com/nodejs/node/pull/18861.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/18861","number":18861,"state":"open","locked":false,"title":"test: http2 stream.respond() error checks","user":{"login":"trivikr","id":16024985,"avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"body":"This code change adds tests for the following errors in `respond(headers, options)`:\r\nhttps://github.com/nodejs/node/blob/472cde603ef60aafcff00a4d09743758dfd0d928/lib/internal/http2/core.js#L2125-L2128\r\nhttps://github.com/nodejs/node/blob/472cde603ef60aafcff00a4d09743758dfd0d928/lib/internal/http2/core.js#L2147-L2151\r\n\r\n##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\nhttp2\r\n","created_at":"2018-02-19T03:51:56Z","updated_at":"2018-02-19T03:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/18861/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/18861/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/18861/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/ebb5f100aa82486fd0c5484cdad5230346fc269f","head":{"label":"trivikr:test-http2-respond-errors","ref":"test-http2-respond-errors","sha":"ebb5f100aa82486fd0c5484cdad5230346fc269f","user":{"login":"trivikr","id":16024985,"avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"repo":{"id":104234761,"name":"node","full_name":"trivikr/node","owner":{"login":"trivikr","id":16024985,"avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trivikr/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/trivikr/node","forks_url":"https://api.github.com/repos/trivikr/node/forks","keys_url":"https://api.github.com/repos/trivikr/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trivikr/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trivikr/node/teams","hooks_url":"https://api.github.com/repos/trivikr/node/hooks","issue_events_url":"https://api.github.com/repos/trivikr/node/issues/events{/number}","events_url":"https://api.github.com/repos/trivikr/node/events","assignees_url":"https://api.github.com/repos/trivikr/node/assignees{/user}","branches_url":"https://api.github.com/repos/trivikr/node/branches{/branch}","tags_url":"https://api.github.com/repos/trivikr/node/tags","blobs_url":"https://api.github.com/repos/trivikr/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trivikr/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trivikr/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/trivikr/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trivikr/node/statuses/{sha}","languages_url":"https://api.github.com/repos/trivikr/node/languages","stargazers_url":"https://api.github.com/repos/trivikr/node/stargazers","contributors_url":"https://api.github.com/repos/trivikr/node/contributors","subscribers_url":"https://api.github.com/repos/trivikr/node/subscribers","subscription_url":"https://api.github.com/repos/trivikr/node/subscription","commits_url":"https://api.github.com/repos/trivikr/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/trivikr/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/trivikr/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/trivikr/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/trivikr/node/contents/{+path}","compare_url":"https://api.github.com/repos/trivikr/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trivikr/node/merges","archive_url":"https://api.github.com/repos/trivikr/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trivikr/node/downloads","issues_url":"https://api.github.com/repos/trivikr/node/issues{/number}","pulls_url":"https://api.github.com/repos/trivikr/node/pulls{/number}","milestones_url":"https://api.github.com/repos/trivikr/node/milestones{/number}","notifications_url":"https://api.github.com/repos/trivikr/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trivikr/node/labels{/name}","releases_url":"https://api.github.com/repos/trivikr/node/releases{/id}","deployments_url":"https://api.github.com/repos/trivikr/node/deployments","created_at":"2017-09-20T15:38:29Z","updated_at":"2017-09-20T15:39:05Z","pushed_at":"2018-02-19T03:49:02Z","git_url":"git://github.com/trivikr/node.git","ssh_url":"git@github.com:trivikr/node.git","clone_url":"https://github.com/trivikr/node.git","svn_url":"https://github.com/trivikr/node","homepage":"https://nodejs.org","size":339938,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"472cde603ef60aafcff00a4d09743758dfd0d928","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-02-19T03:37:51Z","pushed_at":"2018-02-19T03:39:34Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":348757,"stargazers_count":45574,"watchers_count":45574,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9562,"mirror_url":null,"archived":false,"open_issues_count":786,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9562,"open_issues":786,"watchers":45574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/18861"},"html":{"href":"https://github.com/nodejs/node/pull/18861"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/18861"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/18861/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/18861/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/18861/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/ebb5f100aa82486fd0c5484cdad5230346fc269f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":160,"deletions":81,"changed_files":2}}
{"actor":{"display_login":"trivikr"}}