{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/210900549","pull_request_review_id":147214477,"id":210900549,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDkwMDU0OQ==","diff_hunk":"@@ -72,7 +109,42 @@ string MetadataTagProcessorImpl::ValidateAndFormat_maxspeed(string const & v) co\n   if (!ftypes::IsSpeedCamChecker::Instance()(m_params.m_types))\n     return string();\n \n-  return v;\n+  auto const & it = kHumanSpeedToNumber.find(v);","path":"generator/osm2meta.cpp","position":63,"original_position":63,"commit_id":"90ccc1a1c7371c3290489752ac91d36bba117518","original_commit_id":"90ccc1a1c7371c3290489752ac91d36bba117518","user":{"login":"gmoryes","id":17534533,"node_id":"MDQ6VXNlcjE3NTM0NTMz","avatar_url":"https://avatars2.githubusercontent.com/u/17534533?v=4","gravatar_id":"","url":"https://api.github.com/users/gmoryes","html_url":"https://github.com/gmoryes","followers_url":"https://api.github.com/users/gmoryes/followers","following_url":"https://api.github.com/users/gmoryes/following{/other_user}","gists_url":"https://api.github.com/users/gmoryes/gists{/gist_id}","starred_url":"https://api.github.com/users/gmoryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmoryes/subscriptions","organizations_url":"https://api.github.com/users/gmoryes/orgs","repos_url":"https://api.github.com/users/gmoryes/repos","events_url":"https://api.github.com/users/gmoryes/events{/privacy}","received_events_url":"https://api.github.com/users/gmoryes/received_events","type":"User","site_admin":false},"body":"remove ref\r\ndone","created_at":"2018-08-17T12:58:28Z","updated_at":"2018-08-17T12:58:28Z","html_url":"https://github.com/mapsme/omim/pull/9271#discussion_r210900549","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/9271","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/210900549"},"html":{"href":"https://github.com/mapsme/omim/pull/9271#discussion_r210900549"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9271"}},"in_reply_to_id":210893613},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/9271","id":207248721,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjQ4NzIx","html_url":"https://github.com/mapsme/omim/pull/9271","diff_url":"https://github.com/mapsme/omim/pull/9271.diff","patch_url":"https://github.com/mapsme/omim/pull/9271.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/9271","number":9271,"state":"open","locked":false,"title":"[routing] add new section, part2","user":{"login":"gmoryes","id":17534533,"node_id":"MDQ6VXNlcjE3NTM0NTMz","avatar_url":"https://avatars2.githubusercontent.com/u/17534533?v=4","gravatar_id":"","url":"https://api.github.com/users/gmoryes","html_url":"https://github.com/gmoryes","followers_url":"https://api.github.com/users/gmoryes/followers","following_url":"https://api.github.com/users/gmoryes/following{/other_user}","gists_url":"https://api.github.com/users/gmoryes/gists{/gist_id}","starred_url":"https://api.github.com/users/gmoryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmoryes/subscriptions","organizations_url":"https://api.github.com/users/gmoryes/orgs","repos_url":"https://api.github.com/users/gmoryes/repos","events_url":"https://api.github.com/users/gmoryes/events{/privacy}","received_events_url":"https://api.github.com/users/gmoryes/received_events","type":"User","site_admin":false},"body":"Код все также добавляет секцию. \r\nДобавил дельта кодирование.\r\n@mpimenov предложил соединять камеры на одной фиче. Я собрал статистику по следующим регионам:\r\n```\r\naustria-latest.osm.log\r\nbelgium-latest.osm.log\r\ncalifornia-latest.osm.log\r\ncanada-latest.osm.log\r\ncentro-latest.log\r\nchina-latest.osm.log\r\nflorida-latest.osm.log\r\ngermany-latest.log\r\ngreat-britain-latest.osm.log\r\ngreece-latest.osm.log\r\nisole-latest.log\r\njapan-latest.osm.log\r\nkentucky-latest.osm.log\r\nmassachusetts-latest.osm.log\r\nnepal-latest.osm.log\r\nnew-york-latest.osm.log\r\nnord-est-latest.osm.log\r\nnord-ovest-latest.log\r\nnorth-carolina-latest.osm.log\r\nnorthwestern-fed-district-latest.osm.log\r\noklahoma-latest.osm.log\r\nromania-latest.osm.log\r\nrussia-latest.osm.log\r\nsiberian-fed-district-latest.osm.pbf.log\r\nsweden-latest.log\r\ntexas-latest.osm.log\r\nturkey-latest.osm.log\r\nural-fed-district-latest.osm.pbf.log\r\nvolga-fed-district-latest.osm.pbf.log\r\n```\r\n\r\nПолучились такие данные:\r\n```\r\n1 => 13571\r\n2 => 1484\r\n3 => 133\r\n4 => 43\r\n5 => 6\r\n6 => 6\r\n7 => 4\r\n8 => 1\r\n9 => 0\r\n10 => 0\r\n```\r\nГде `4 => 43` означает: кол-во фичей, на которых стоят `4` камеры, равно: `43`.\r\nТаким образом, мы сэкономим на каждой фиче, которая повторяется 2 раза - 4 байта, 3 раза - 8 байт итд, но при этом придется добавить для каждой фичи VarInt (сколько камер на данной фичи), который скорее всего будет размером в 1 байт.\r\n\r\nТогда, если `экономия от схлопывания, посчитанная по логике выше` - `сумма всех фичей * 1 байт` > 0, то это имеет смысл делать. \r\n\r\nНо получилось так:\r\n`экономия от схлопывания фичей, посчитанная по логике выше` =  7856\r\n`сумма всех фичей * 1 байт` = 15248\r\n\r\nКто что думает по этому поводу?\r\n","created_at":"2018-08-09T09:09:53Z","updated_at":"2018-08-17T12:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d4f2e89b53690b1bf2364fd000e82d10538528d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vmihaylenko","id":6297856,"node_id":"MDQ6VXNlcjYyOTc4NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6297856?v=4","gravatar_id":"","url":"https://api.github.com/users/vmihaylenko","html_url":"https://github.com/vmihaylenko","followers_url":"https://api.github.com/users/vmihaylenko/followers","following_url":"https://api.github.com/users/vmihaylenko/following{/other_user}","gists_url":"https://api.github.com/users/vmihaylenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vmihaylenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmihaylenko/subscriptions","organizations_url":"https://api.github.com/users/vmihaylenko/orgs","repos_url":"https://api.github.com/users/vmihaylenko/repos","events_url":"https://api.github.com/users/vmihaylenko/events{/privacy}","received_events_url":"https://api.github.com/users/vmihaylenko/received_events","type":"User","site_admin":false},{"login":"mpimenov","id":10366009,"node_id":"MDQ6VXNlcjEwMzY2MDA5","avatar_url":"https://avatars0.githubusercontent.com/u/10366009?v=4","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/9271/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/9271/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/9271/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/90ccc1a1c7371c3290489752ac91d36bba117518","head":{"label":"gmoryes:MAPSME-8120.speed_cam","ref":"MAPSME-8120.speed_cam","sha":"90ccc1a1c7371c3290489752ac91d36bba117518","user":{"login":"gmoryes","id":17534533,"node_id":"MDQ6VXNlcjE3NTM0NTMz","avatar_url":"https://avatars2.githubusercontent.com/u/17534533?v=4","gravatar_id":"","url":"https://api.github.com/users/gmoryes","html_url":"https://github.com/gmoryes","followers_url":"https://api.github.com/users/gmoryes/followers","following_url":"https://api.github.com/users/gmoryes/following{/other_user}","gists_url":"https://api.github.com/users/gmoryes/gists{/gist_id}","starred_url":"https://api.github.com/users/gmoryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmoryes/subscriptions","organizations_url":"https://api.github.com/users/gmoryes/orgs","repos_url":"https://api.github.com/users/gmoryes/repos","events_url":"https://api.github.com/users/gmoryes/events{/privacy}","received_events_url":"https://api.github.com/users/gmoryes/received_events","type":"User","site_admin":false},"repo":{"id":141252817,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyNTI4MTc=","name":"omim","full_name":"gmoryes/omim","owner":{"login":"gmoryes","id":17534533,"node_id":"MDQ6VXNlcjE3NTM0NTMz","avatar_url":"https://avatars2.githubusercontent.com/u/17534533?v=4","gravatar_id":"","url":"https://api.github.com/users/gmoryes","html_url":"https://github.com/gmoryes","followers_url":"https://api.github.com/users/gmoryes/followers","following_url":"https://api.github.com/users/gmoryes/following{/other_user}","gists_url":"https://api.github.com/users/gmoryes/gists{/gist_id}","starred_url":"https://api.github.com/users/gmoryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmoryes/subscriptions","organizations_url":"https://api.github.com/users/gmoryes/orgs","repos_url":"https://api.github.com/users/gmoryes/repos","events_url":"https://api.github.com/users/gmoryes/events{/privacy}","received_events_url":"https://api.github.com/users/gmoryes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmoryes/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":true,"url":"https://api.github.com/repos/gmoryes/omim","forks_url":"https://api.github.com/repos/gmoryes/omim/forks","keys_url":"https://api.github.com/repos/gmoryes/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmoryes/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmoryes/omim/teams","hooks_url":"https://api.github.com/repos/gmoryes/omim/hooks","issue_events_url":"https://api.github.com/repos/gmoryes/omim/issues/events{/number}","events_url":"https://api.github.com/repos/gmoryes/omim/events","assignees_url":"https://api.github.com/repos/gmoryes/omim/assignees{/user}","branches_url":"https://api.github.com/repos/gmoryes/omim/branches{/branch}","tags_url":"https://api.github.com/repos/gmoryes/omim/tags","blobs_url":"https://api.github.com/repos/gmoryes/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmoryes/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmoryes/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmoryes/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmoryes/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/gmoryes/omim/languages","stargazers_url":"https://api.github.com/repos/gmoryes/omim/stargazers","contributors_url":"https://api.github.com/repos/gmoryes/omim/contributors","subscribers_url":"https://api.github.com/repos/gmoryes/omim/subscribers","subscription_url":"https://api.github.com/repos/gmoryes/omim/subscription","commits_url":"https://api.github.com/repos/gmoryes/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmoryes/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmoryes/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmoryes/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmoryes/omim/contents/{+path}","compare_url":"https://api.github.com/repos/gmoryes/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmoryes/omim/merges","archive_url":"https://api.github.com/repos/gmoryes/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmoryes/omim/downloads","issues_url":"https://api.github.com/repos/gmoryes/omim/issues{/number}","pulls_url":"https://api.github.com/repos/gmoryes/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/gmoryes/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/gmoryes/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmoryes/omim/labels{/name}","releases_url":"https://api.github.com/repos/gmoryes/omim/releases{/id}","deployments_url":"https://api.github.com/repos/gmoryes/omim/deployments","created_at":"2018-07-17T07:57:11Z","updated_at":"2018-08-16T17:49:48Z","pushed_at":"2018-08-16T18:32:13Z","git_url":"git://github.com/gmoryes/omim.git","ssh_url":"git@github.com:gmoryes/omim.git","clone_url":"https://github.com/gmoryes/omim.git","svn_url":"https://github.com/gmoryes/omim","homepage":"","size":4038665,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"11d12df2618b1902416afc6ff11a3e102d853dd7","user":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc5ODAzMw==","name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2018-08-17T12:26:22Z","pushed_at":"2018-08-17T12:26:12Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":4044884,"stargazers_count":2744,"watchers_count":2744,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":596,"mirror_url":null,"archived":false,"open_issues_count":721,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":596,"open_issues":721,"watchers":2744,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9271"},"html":{"href":"https://github.com/mapsme/omim/pull/9271"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/9271"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/9271/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9271/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9271/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/90ccc1a1c7371c3290489752ac91d36bba117518"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gmoryes"}}