{"action":"created","comment":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/comments/219914905","pull_request_review_id":158203488,"id":219914905,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTkxNDkwNQ==","diff_hunk":"@@ -602,6 +653,29 @@\n           \"type\": \"boolean\",\n           \"default\": false,\n           \"description\": \"Specifies whether notifications should be shown if OmniSharp encounters warnings or errors loading a project. Note that these warnings/errors are always emitted to the OmniSharp log\"\n+        },\n+        \"omnisharp.preview\": {\n+          \"type\": \"boolean\",\n+          \"default\": false,\n+          \"description\": \"Specifies whether to enable OmniSharp preview features.\"\n+        },\n+        \"razor.languageServer.path\": {","path":"package.json","position":84,"original_position":84,"commit_id":"f98b3203692596cb09b1f19d3ab7280685bfa243","original_commit_id":"f98b3203692596cb09b1f19d3ab7280685bfa243","user":{"login":"NTaylorMullen","id":2008729,"node_id":"MDQ6VXNlcjIwMDg3Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/2008729?v=4","gravatar_id":"","url":"https://api.github.com/users/NTaylorMullen","html_url":"https://github.com/NTaylorMullen","followers_url":"https://api.github.com/users/NTaylorMullen/followers","following_url":"https://api.github.com/users/NTaylorMullen/following{/other_user}","gists_url":"https://api.github.com/users/NTaylorMullen/gists{/gist_id}","starred_url":"https://api.github.com/users/NTaylorMullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTaylorMullen/subscriptions","organizations_url":"https://api.github.com/users/NTaylorMullen/orgs","repos_url":"https://api.github.com/users/NTaylorMullen/repos","events_url":"https://api.github.com/users/NTaylorMullen/events{/privacy}","received_events_url":"https://api.github.com/users/NTaylorMullen/received_events","type":"User","site_admin":false},"body":"Since this is really pointing to the directory we should consider changing this to `razor.languageServer.directory`","created_at":"2018-09-24T17:07:27Z","updated_at":"2018-09-24T17:07:28Z","html_url":"https://github.com/OmniSharp/omnisharp-vscode/pull/2554#discussion_r219914905","pull_request_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/2554","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/comments/219914905"},"html":{"href":"https://github.com/OmniSharp/omnisharp-vscode/pull/2554#discussion_r219914905"},"pull_request":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/2554"}}},"pull_request":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/2554","id":217610975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjEwOTc1","html_url":"https://github.com/OmniSharp/omnisharp-vscode/pull/2554","diff_url":"https://github.com/OmniSharp/omnisharp-vscode/pull/2554.diff","patch_url":"https://github.com/OmniSharp/omnisharp-vscode/pull/2554.patch","issue_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues/2554","number":2554,"state":"open","locked":false,"title":"Add preview Razor support","user":{"login":"SteveSandersonMS","id":1101362,"node_id":"MDQ6VXNlcjExMDEzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1101362?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveSandersonMS","html_url":"https://github.com/SteveSandersonMS","followers_url":"https://api.github.com/users/SteveSandersonMS/followers","following_url":"https://api.github.com/users/SteveSandersonMS/following{/other_user}","gists_url":"https://api.github.com/users/SteveSandersonMS/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveSandersonMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveSandersonMS/subscriptions","organizations_url":"https://api.github.com/users/SteveSandersonMS/orgs","repos_url":"https://api.github.com/users/SteveSandersonMS/repos","events_url":"https://api.github.com/users/SteveSandersonMS/events{/privacy}","received_events_url":"https://api.github.com/users/SteveSandersonMS/received_events","type":"User","site_admin":false},"body":"As discussed previously, this adds Razor support behind a new `omnisharp.preview` options flag.\r\n\r\nIt works by downloading a platform-specific Razor Language Server executable (equivalent to the OmniSharp-Roslyn language server) and then running some VSCode-side logic that knows how to launch and interact with it.\r\n","created_at":"2018-09-24T10:24:32Z","updated_at":"2018-09-24T17:07:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1ca7043b43b06cdf9dec19e1d1d90f353668513","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/2554/commits","review_comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/2554/comments","review_comment_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues/2554/comments","statuses_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/statuses/f98b3203692596cb09b1f19d3ab7280685bfa243","head":{"label":"SteveSandersonMS:stevesa/initial-razor-support","ref":"stevesa/initial-razor-support","sha":"f98b3203692596cb09b1f19d3ab7280685bfa243","user":{"login":"SteveSandersonMS","id":1101362,"node_id":"MDQ6VXNlcjExMDEzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1101362?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveSandersonMS","html_url":"https://github.com/SteveSandersonMS","followers_url":"https://api.github.com/users/SteveSandersonMS/followers","following_url":"https://api.github.com/users/SteveSandersonMS/following{/other_user}","gists_url":"https://api.github.com/users/SteveSandersonMS/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveSandersonMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveSandersonMS/subscriptions","organizations_url":"https://api.github.com/users/SteveSandersonMS/orgs","repos_url":"https://api.github.com/users/SteveSandersonMS/repos","events_url":"https://api.github.com/users/SteveSandersonMS/events{/privacy}","received_events_url":"https://api.github.com/users/SteveSandersonMS/received_events","type":"User","site_admin":false},"repo":{"id":150085549,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAwODU1NDk=","name":"omnisharp-vscode","full_name":"SteveSandersonMS/omnisharp-vscode","private":false,"owner":{"login":"SteveSandersonMS","id":1101362,"node_id":"MDQ6VXNlcjExMDEzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1101362?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveSandersonMS","html_url":"https://github.com/SteveSandersonMS","followers_url":"https://api.github.com/users/SteveSandersonMS/followers","following_url":"https://api.github.com/users/SteveSandersonMS/following{/other_user}","gists_url":"https://api.github.com/users/SteveSandersonMS/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveSandersonMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveSandersonMS/subscriptions","organizations_url":"https://api.github.com/users/SteveSandersonMS/orgs","repos_url":"https://api.github.com/users/SteveSandersonMS/repos","events_url":"https://api.github.com/users/SteveSandersonMS/events{/privacy}","received_events_url":"https://api.github.com/users/SteveSandersonMS/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SteveSandersonMS/omnisharp-vscode","description":"Official C# support for Visual Studio Code (powered by OmniSharp)","fork":true,"url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode","forks_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/forks","keys_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/teams","hooks_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/hooks","issue_events_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/issues/events{/number}","events_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/events","assignees_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/assignees{/user}","branches_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/branches{/branch}","tags_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/tags","blobs_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/languages","stargazers_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/stargazers","contributors_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/contributors","subscribers_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/subscribers","subscription_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/subscription","commits_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/contents/{+path}","compare_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/merges","archive_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/downloads","issues_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/issues{/number}","pulls_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/labels{/name}","releases_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/releases{/id}","deployments_url":"https://api.github.com/repos/SteveSandersonMS/omnisharp-vscode/deployments","created_at":"2018-09-24T10:20:17Z","updated_at":"2018-09-24T10:20:20Z","pushed_at":"2018-09-24T10:21:18Z","git_url":"git://github.com/SteveSandersonMS/omnisharp-vscode.git","ssh_url":"git@github.com:SteveSandersonMS/omnisharp-vscode.git","clone_url":"https://github.com/SteveSandersonMS/omnisharp-vscode.git","svn_url":"https://github.com/SteveSandersonMS/omnisharp-vscode","homepage":"","size":3356,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OmniSharp:master","ref":"master","sha":"0d711ff5369daad1e2ad266daf68cbdf7f46945d","user":{"login":"OmniSharp","id":9420663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0MjA2NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/9420663?v=4","gravatar_id":"","url":"https://api.github.com/users/OmniSharp","html_url":"https://github.com/OmniSharp","followers_url":"https://api.github.com/users/OmniSharp/followers","following_url":"https://api.github.com/users/OmniSharp/following{/other_user}","gists_url":"https://api.github.com/users/OmniSharp/gists{/gist_id}","starred_url":"https://api.github.com/users/OmniSharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmniSharp/subscriptions","organizations_url":"https://api.github.com/users/OmniSharp/orgs","repos_url":"https://api.github.com/users/OmniSharp/repos","events_url":"https://api.github.com/users/OmniSharp/events{/privacy}","received_events_url":"https://api.github.com/users/OmniSharp/received_events","type":"Organization","site_admin":false},"repo":{"id":47341961,"node_id":"MDEwOlJlcG9zaXRvcnk0NzM0MTk2MQ==","name":"omnisharp-vscode","full_name":"OmniSharp/omnisharp-vscode","private":false,"owner":{"login":"OmniSharp","id":9420663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0MjA2NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/9420663?v=4","gravatar_id":"","url":"https://api.github.com/users/OmniSharp","html_url":"https://github.com/OmniSharp","followers_url":"https://api.github.com/users/OmniSharp/followers","following_url":"https://api.github.com/users/OmniSharp/following{/other_user}","gists_url":"https://api.github.com/users/OmniSharp/gists{/gist_id}","starred_url":"https://api.github.com/users/OmniSharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmniSharp/subscriptions","organizations_url":"https://api.github.com/users/OmniSharp/orgs","repos_url":"https://api.github.com/users/OmniSharp/repos","events_url":"https://api.github.com/users/OmniSharp/events{/privacy}","received_events_url":"https://api.github.com/users/OmniSharp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OmniSharp/omnisharp-vscode","description":"Official C# support for Visual Studio Code (powered by OmniSharp)","fork":false,"url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode","forks_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/forks","keys_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/teams","hooks_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/hooks","issue_events_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues/events{/number}","events_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/events","assignees_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/assignees{/user}","branches_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/branches{/branch}","tags_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/tags","blobs_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/languages","stargazers_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/stargazers","contributors_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/contributors","subscribers_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/subscribers","subscription_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/subscription","commits_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/contents/{+path}","compare_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/merges","archive_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/downloads","issues_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues{/number}","pulls_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/labels{/name}","releases_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/releases{/id}","deployments_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/deployments","created_at":"2015-12-03T15:45:21Z","updated_at":"2018-09-24T17:00:05Z","pushed_at":"2018-09-24T10:24:33Z","git_url":"git://github.com/OmniSharp/omnisharp-vscode.git","ssh_url":"git@github.com:OmniSharp/omnisharp-vscode.git","clone_url":"https://github.com/OmniSharp/omnisharp-vscode.git","svn_url":"https://github.com/OmniSharp/omnisharp-vscode","homepage":"","size":3346,"stargazers_count":895,"watchers_count":895,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":251,"mirror_url":null,"archived":false,"open_issues_count":354,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":251,"open_issues":354,"watchers":895,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/2554"},"html":{"href":"https://github.com/OmniSharp/omnisharp-vscode/pull/2554"},"issue":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues/2554"},"comments":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues/2554/comments"},"review_comments":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/2554/comments"},"review_comment":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/2554/commits"},"statuses":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/statuses/f98b3203692596cb09b1f19d3ab7280685bfa243"}},"author_association":"NONE"}}
{"actor":{"display_login":"NTaylorMullen"}}