{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/comments/217488908","pull_request_review_id":155212865,"id":217488908,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzQ4ODkwOA==","diff_hunk":"@@ -1,6 +1,24 @@\n-FROM alpine:3.6\n+#FROM alpine:3.6","path":"tmp/build/Dockerfile","position":2,"original_position":2,"commit_id":"c21895d2a860cae4d869971d2c9ec75ee5e6898c","original_commit_id":"c21895d2a860cae4d869971d2c9ec75ee5e6898c","user":{"login":"bparees","id":4974046,"node_id":"MDQ6VXNlcjQ5NzQwNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"we should be basically ignoring this file at this point.  The one that matters is the Dockerfile in the root of the repo.\r\n","created_at":"2018-09-13T18:29:22Z","updated_at":"2018-09-13T18:45:10Z","html_url":"https://github.com/openshift/cluster-samples-operator/pull/5#discussion_r217488908","pull_request_url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/comments/217488908"},"html":{"href":"https://github.com/openshift/cluster-samples-operator/pull/5#discussion_r217488908"},"pull_request":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/5","id":211562227,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTYyMjI3","html_url":"https://github.com/openshift/cluster-samples-operator/pull/5","diff_url":"https://github.com/openshift/cluster-samples-operator/pull/5.diff","patch_url":"https://github.com/openshift/cluster-samples-operator/pull/5.patch","issue_url":"https://api.github.com/repos/openshift/cluster-samples-operator/issues/5","number":5,"state":"open","locked":false,"title":"Operator innards 1","user":{"login":"gabemontero","id":3594868,"node_id":"MDQ6VXNlcjM1OTQ4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"@openshift/sig-developer-experience ptal\r\n\r\nbroke changes out into 3 commits  ... hopefully the commit text sufficiently explains the rationale; in particular, I suspect the `operator-sdk build` could be generated by the repo build longer term, but I to confirm the state of api.ci and inclusion of the `operator-sdk` binary\r\n\r\nShort term at least, the docker.io/gmontero/ose-cluster-samples-operator:v0.0.1 image should be accessible to anyone who want to try this out along with the various yaml in the deploy subdir.\r\n\r\nalso, I'm still adding unit tests, but decided at this point it would be good to continue that in parallel with implementation review and iteration\r\n\r\n","created_at":"2018-08-28T21:22:27Z","updated_at":"2018-09-13T18:45:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f43b11ee702a6cdc6676b9beccd5d831d64a82e3","assignee":{"login":"bparees","id":4974046,"node_id":"MDQ6VXNlcjQ5NzQwNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"assignees":[{"login":"bparees","id":4974046,"node_id":"MDQ6VXNlcjQ5NzQwNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1027940881,"node_id":"MDU6TGFiZWwxMDI3OTQwODgx","url":"https://api.github.com/repos/openshift/cluster-samples-operator/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1027939195,"node_id":"MDU6TGFiZWwxMDI3OTM5MTk1","url":"https://api.github.com/repos/openshift/cluster-samples-operator/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/5/commits","review_comments_url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/5/comments","review_comment_url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/cluster-samples-operator/issues/5/comments","statuses_url":"https://api.github.com/repos/openshift/cluster-samples-operator/statuses/c21895d2a860cae4d869971d2c9ec75ee5e6898c","head":{"label":"gabemontero:operator-innards-1","ref":"operator-innards-1","sha":"c21895d2a860cae4d869971d2c9ec75ee5e6898c","user":{"login":"gabemontero","id":3594868,"node_id":"MDQ6VXNlcjM1OTQ4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"repo":{"id":145433942,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0MzM5NDI=","name":"cluster-samples-operator","full_name":"gabemontero/cluster-samples-operator","owner":{"login":"gabemontero","id":3594868,"node_id":"MDQ6VXNlcjM1OTQ4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabemontero/cluster-samples-operator","description":"The samples operator installs+maintains the sample templates+imagestreams on a cluster","fork":true,"url":"https://api.github.com/repos/gabemontero/cluster-samples-operator","forks_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/forks","keys_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/teams","hooks_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/hooks","issue_events_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/issues/events{/number}","events_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/events","assignees_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/assignees{/user}","branches_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/branches{/branch}","tags_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/tags","blobs_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/languages","stargazers_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/stargazers","contributors_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/contributors","subscribers_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/subscribers","subscription_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/subscription","commits_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/contents/{+path}","compare_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/merges","archive_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/downloads","issues_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/issues{/number}","pulls_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/labels{/name}","releases_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/releases{/id}","deployments_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/deployments","created_at":"2018-08-20T15:12:46Z","updated_at":"2018-09-13T18:10:22Z","pushed_at":"2018-09-13T18:10:20Z","git_url":"git://github.com/gabemontero/cluster-samples-operator.git","ssh_url":"git@github.com:gabemontero/cluster-samples-operator.git","clone_url":"https://github.com/gabemontero/cluster-samples-operator.git","svn_url":"https://github.com/gabemontero/cluster-samples-operator","homepage":null,"size":21557,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"4290ddd3fb695141eb33e0ae2aa795fea0e709ab","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":145157415,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxNTc0MTU=","name":"cluster-samples-operator","full_name":"openshift/cluster-samples-operator","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/cluster-samples-operator","description":"The samples operator installs+maintains the sample templates+imagestreams on a cluster","fork":false,"url":"https://api.github.com/repos/openshift/cluster-samples-operator","forks_url":"https://api.github.com/repos/openshift/cluster-samples-operator/forks","keys_url":"https://api.github.com/repos/openshift/cluster-samples-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-samples-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-samples-operator/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-samples-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-samples-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-samples-operator/events","assignees_url":"https://api.github.com/repos/openshift/cluster-samples-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-samples-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-samples-operator/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-samples-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-samples-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-samples-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-samples-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-samples-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-samples-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-samples-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-samples-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-samples-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-samples-operator/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-samples-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-samples-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-samples-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-samples-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-samples-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-samples-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-samples-operator/merges","archive_url":"https://api.github.com/repos/openshift/cluster-samples-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-samples-operator/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-samples-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-samples-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-samples-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-samples-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-samples-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-samples-operator/deployments","created_at":"2018-08-17T19:10:15Z","updated_at":"2018-09-12T00:10:46Z","pushed_at":"2018-09-12T22:02:27Z","git_url":"git://github.com/openshift/cluster-samples-operator.git","ssh_url":"git@github.com:openshift/cluster-samples-operator.git","clone_url":"https://github.com/openshift/cluster-samples-operator.git","svn_url":"https://github.com/openshift/cluster-samples-operator","homepage":null,"size":21532,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/5"},"html":{"href":"https://github.com/openshift/cluster-samples-operator/pull/5"},"issue":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/issues/5"},"comments":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/statuses/c21895d2a860cae4d869971d2c9ec75ee5e6898c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bparees"}}