{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/4845","repository_url":"https://api.github.com/repos/facebook/rocksdb","labels_url":"https://api.github.com/repos/facebook/rocksdb/issues/4845/labels{/name}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/4845/comments","events_url":"https://api.github.com/repos/facebook/rocksdb/issues/4845/events","html_url":"https://github.com/facebook/rocksdb/pull/4845","id":396011750,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMzI5NDg3","number":4845,"title":"Do not support parallel memtable write if write group leader not allow write batching","user":{"login":"DorianZheng","id":8065637,"node_id":"MDQ6VXNlcjgwNjU2Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/8065637?v=4","gravatar_id":"","url":"https://api.github.com/users/DorianZheng","html_url":"https://github.com/DorianZheng","followers_url":"https://api.github.com/users/DorianZheng/followers","following_url":"https://api.github.com/users/DorianZheng/following{/other_user}","gists_url":"https://api.github.com/users/DorianZheng/gists{/gist_id}","starred_url":"https://api.github.com/users/DorianZheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DorianZheng/subscriptions","organizations_url":"https://api.github.com/users/DorianZheng/orgs","repos_url":"https://api.github.com/users/DorianZheng/repos","events_url":"https://api.github.com/users/DorianZheng/events{/privacy}","received_events_url":"https://api.github.com/users/DorianZheng/received_events","type":"User","site_admin":false},"labels":[{"id":196859108,"node_id":"MDU6TGFiZWwxOTY4NTkxMDg=","url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-01-04T17:49:46Z","updated_at":"2019-01-04T17:59:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/4845","html_url":"https://github.com/facebook/rocksdb/pull/4845","diff_url":"https://github.com/facebook/rocksdb/pull/4845.diff","patch_url":"https://github.com/facebook/rocksdb/pull/4845.patch"},"body":"BlobDB GC use writer callback to check if it needs to write back the key. If BlobDB GC needs to write back a key `A` (aka `GC_A`), the callback will ensure that this writer will become the leader of the write group, and if there is another writer in this write group contains the same key `A` (aka `USER_A`), then parallel memtable write may cover  `USER_A` with `GC_A`. So I think we should not support parallel memtable write if the leader's callback is not allow write batching. But I'm not sure how this will affect `OptimisticTransaction` because it use write callback too."},"comment":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/comments/451519686","html_url":"https://github.com/facebook/rocksdb/pull/4845#issuecomment-451519686","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/4845","id":451519686,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTUxOTY4Ng==","user":{"login":"facebook-github-bot","id":6422482,"node_id":"MDQ6VXNlcjY0MjI0ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/6422482?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T17:59:09Z","updated_at":"2019-01-04T17:59:09Z","author_association":"NONE","body":"Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!"}}
{"actor":{"display_login":"facebook-github-bot"}}