{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/pulls/1","id":171206390,"html_url":"https://github.com/sebastiaanluca/php-pipe-operator/pull/1","diff_url":"https://github.com/sebastiaanluca/php-pipe-operator/pull/1.diff","patch_url":"https://github.com/sebastiaanluca/php-pipe-operator/pull/1.patch","issue_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/issues/1","number":1,"state":"open","locked":false,"title":"Change the '$$' identifier to a constant","user":{"login":"ImLiam","id":4326337,"avatar_url":"https://avatars0.githubusercontent.com/u/4326337?v=4","gravatar_id":"","url":"https://api.github.com/users/ImLiam","html_url":"https://github.com/ImLiam","followers_url":"https://api.github.com/users/ImLiam/followers","following_url":"https://api.github.com/users/ImLiam/following{/other_user}","gists_url":"https://api.github.com/users/ImLiam/gists{/gist_id}","starred_url":"https://api.github.com/users/ImLiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImLiam/subscriptions","organizations_url":"https://api.github.com/users/ImLiam/orgs","repos_url":"https://api.github.com/users/ImLiam/repos","events_url":"https://api.github.com/users/ImLiam/events{/privacy}","received_events_url":"https://api.github.com/users/ImLiam/received_events","type":"User","site_admin":false},"body":"## PR Type\r\n\r\nWhat kind of pull request is this? Put an `x` in all the boxes that apply:\r\n\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Extend feature (non-breaking change which extends existing functionality)\r\n- [ ] Change feature (non-breaking change which either changes or refactors existing functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## What does it change?\r\n\r\nProposes a constant that is named appropriately so that any developer reading it in use can tell what it represents, and it uses an ID generated by uniqid() so as to not conflict with user input.\r\n\r\n## Why this PR?\r\n\r\nThe '$$' identifier has a few problems, and replacing it with a constant is an attempt to alleviate those:\r\n\r\n- '$$' is not a language construct like the RFC proposes, so people looking into the code will not be familiar with it and what it represents\r\n- When processing user input, '$$' could be a perfectly valid string and is now something that the developer must explicitly check for\r\n\r\n## How has this been tested?\r\n\r\nExisting tests have been modified to account for this change.\r\n","created_at":"2018-02-25T01:09:23Z","updated_at":"2018-02-25T01:09:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/pulls/1/commits","review_comments_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/pulls/1/comments","review_comment_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/issues/1/comments","statuses_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/statuses/c239c9b8326e82293c6dad7d039f227f94466354","head":{"label":"ImLiam:master","ref":"master","sha":"c239c9b8326e82293c6dad7d039f227f94466354","user":{"login":"ImLiam","id":4326337,"avatar_url":"https://avatars0.githubusercontent.com/u/4326337?v=4","gravatar_id":"","url":"https://api.github.com/users/ImLiam","html_url":"https://github.com/ImLiam","followers_url":"https://api.github.com/users/ImLiam/followers","following_url":"https://api.github.com/users/ImLiam/following{/other_user}","gists_url":"https://api.github.com/users/ImLiam/gists{/gist_id}","starred_url":"https://api.github.com/users/ImLiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImLiam/subscriptions","organizations_url":"https://api.github.com/users/ImLiam/orgs","repos_url":"https://api.github.com/users/ImLiam/repos","events_url":"https://api.github.com/users/ImLiam/events{/privacy}","received_events_url":"https://api.github.com/users/ImLiam/received_events","type":"User","site_admin":false},"repo":{"id":122794119,"name":"php-pipe-operator","full_name":"ImLiam/php-pipe-operator","owner":{"login":"ImLiam","id":4326337,"avatar_url":"https://avatars0.githubusercontent.com/u/4326337?v=4","gravatar_id":"","url":"https://api.github.com/users/ImLiam","html_url":"https://github.com/ImLiam","followers_url":"https://api.github.com/users/ImLiam/followers","following_url":"https://api.github.com/users/ImLiam/following{/other_user}","gists_url":"https://api.github.com/users/ImLiam/gists{/gist_id}","starred_url":"https://api.github.com/users/ImLiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImLiam/subscriptions","organizations_url":"https://api.github.com/users/ImLiam/orgs","repos_url":"https://api.github.com/users/ImLiam/repos","events_url":"https://api.github.com/users/ImLiam/events{/privacy}","received_events_url":"https://api.github.com/users/ImLiam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ImLiam/php-pipe-operator","description":"A (hopefully) temporary solution to implement the pipe operator in PHP.","fork":true,"url":"https://api.github.com/repos/ImLiam/php-pipe-operator","forks_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/forks","keys_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/teams","hooks_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/hooks","issue_events_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/issues/events{/number}","events_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/events","assignees_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/assignees{/user}","branches_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/branches{/branch}","tags_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/tags","blobs_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/languages","stargazers_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/stargazers","contributors_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/contributors","subscribers_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/subscribers","subscription_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/subscription","commits_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/contents/{+path}","compare_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/merges","archive_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/downloads","issues_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/issues{/number}","pulls_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/labels{/name}","releases_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/releases{/id}","deployments_url":"https://api.github.com/repos/ImLiam/php-pipe-operator/deployments","created_at":"2018-02-25T01:01:40Z","updated_at":"2018-02-25T01:01:42Z","pushed_at":"2018-02-25T01:05:37Z","git_url":"git://github.com/ImLiam/php-pipe-operator.git","ssh_url":"git@github.com:ImLiam/php-pipe-operator.git","clone_url":"https://github.com/ImLiam/php-pipe-operator.git","svn_url":"https://github.com/ImLiam/php-pipe-operator","homepage":"https://www.sebastiaanluca.com","size":28,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sebastiaanluca:master","ref":"master","sha":"12e33d85dd9541d6781935f605fbc37c4a2f8dd8","user":{"login":"sebastiaanluca","id":711940,"avatar_url":"https://avatars2.githubusercontent.com/u/711940?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastiaanluca","html_url":"https://github.com/sebastiaanluca","followers_url":"https://api.github.com/users/sebastiaanluca/followers","following_url":"https://api.github.com/users/sebastiaanluca/following{/other_user}","gists_url":"https://api.github.com/users/sebastiaanluca/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastiaanluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastiaanluca/subscriptions","organizations_url":"https://api.github.com/users/sebastiaanluca/orgs","repos_url":"https://api.github.com/users/sebastiaanluca/repos","events_url":"https://api.github.com/users/sebastiaanluca/events{/privacy}","received_events_url":"https://api.github.com/users/sebastiaanluca/received_events","type":"User","site_admin":false},"repo":{"id":122551399,"name":"php-pipe-operator","full_name":"sebastiaanluca/php-pipe-operator","owner":{"login":"sebastiaanluca","id":711940,"avatar_url":"https://avatars2.githubusercontent.com/u/711940?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastiaanluca","html_url":"https://github.com/sebastiaanluca","followers_url":"https://api.github.com/users/sebastiaanluca/followers","following_url":"https://api.github.com/users/sebastiaanluca/following{/other_user}","gists_url":"https://api.github.com/users/sebastiaanluca/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastiaanluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastiaanluca/subscriptions","organizations_url":"https://api.github.com/users/sebastiaanluca/orgs","repos_url":"https://api.github.com/users/sebastiaanluca/repos","events_url":"https://api.github.com/users/sebastiaanluca/events{/privacy}","received_events_url":"https://api.github.com/users/sebastiaanluca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebastiaanluca/php-pipe-operator","description":"A (hopefully) temporary solution to implement the pipe operator in PHP.","fork":false,"url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator","forks_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/forks","keys_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/teams","hooks_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/hooks","issue_events_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/issues/events{/number}","events_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/events","assignees_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/assignees{/user}","branches_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/branches{/branch}","tags_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/tags","blobs_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/languages","stargazers_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/stargazers","contributors_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/contributors","subscribers_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/subscribers","subscription_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/subscription","commits_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/contents/{+path}","compare_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/merges","archive_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/downloads","issues_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/issues{/number}","pulls_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/labels{/name}","releases_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/releases{/id}","deployments_url":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/deployments","created_at":"2018-02-23T00:14:13Z","updated_at":"2018-02-25T00:52:51Z","pushed_at":"2018-02-24T13:32:01Z","git_url":"git://github.com/sebastiaanluca/php-pipe-operator.git","ssh_url":"git@github.com:sebastiaanluca/php-pipe-operator.git","clone_url":"https://github.com/sebastiaanluca/php-pipe-operator.git","svn_url":"https://github.com/sebastiaanluca/php-pipe-operator","homepage":"https://www.sebastiaanluca.com","size":28,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/pulls/1"},"html":{"href":"https://github.com/sebastiaanluca/php-pipe-operator/pull/1"},"issue":{"href":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/issues/1"},"comments":{"href":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/sebastiaanluca/php-pipe-operator/statuses/c239c9b8326e82293c6dad7d039f227f94466354"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":30,"deletions":77,"changed_files":7}}
{"actor":{"display_login":"ImLiam"}}