{"action":"created","comment":{"url":"https://api.github.com/repos/reactos/reactos/pulls/comments/234895864","pull_request_review_id":176633854,"id":234895864,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDg5NTg2NA==","diff_hunk":"@@ -446,13 +446,47 @@ CreateSemaphoreW(IN LPSECURITY_ATTRIBUTES lpSemaphoreAttributes  OPTIONAL,\n                  IN LONG lMaximumCount,\n                  IN LPCWSTR lpName  OPTIONAL)\n {\n-    CreateNtObjectFromWin32Api(Semaphore, Semaphore, SEMAPHORE,\n+    CreateNtObjectFromWin32Api(Semaphore, Semaphore, SEMAPHORE_ALL_ACCESS,\n                                lpSemaphoreAttributes,\n                                lpName,\n                                lInitialCount,\n                                lMaximumCount);\n }\n \n+HANDLE\n+WINAPI\n+DECLSPEC_HOTPATCH\n+CreateSemaphoreExW(IN LPSECURITY_ATTRIBUTES lpSemaphoreAttributes  OPTIONAL,\n+                 IN LONG lInitialCount,\n+                 IN LONG lMaximumCount,\n+                 IN LPCWSTR lpName  OPTIONAL,\n+                 IN DWORD dwFlags OPTIONAL,\n+                 IN DWORD dwDesiredAccess OPTIONAL)\n+{\n+    CreateNtObjectFromWin32Api(Semaphore, Semaphore, dwDesiredAccess,\n+                               lpSemaphoreAttributes,\n+                               lpName,\n+                               lInitialCount,\n+                               lMaximumCount);\n+}\n+\n+HANDLE\n+WINAPI\n+DECLSPEC_HOTPATCH\n+CreateSemaphoreExA(IN LPSECURITY_ATTRIBUTES lpSemaphoreAttributes OPTIONAL,\n+                 IN LONG lInitialCount,\n+                 IN LONG lMaximumCount,\n+                 IN LPCSTR lpName  OPTIONAL,\n+                 IN DWORD dwFlags OPTIONAL,\n+                 IN DWORD dwDesiredAccess OPTIONAL)\n+ConvertAnsiToUnicodePrologue\n+    if (!lpName)\n+        return CreateSemaphoreExW(lpSemaphoreAttributes, lInitialCount, lMaximumCount, NULL, dwFlags, dwDesiredAccess);\n+ConvertAnsiToUnicodeBody(lpName)\n+    if (NT_SUCCESS(Status))\n+        return CreateSemaphoreExW(lpSemaphoreAttributes, lInitialCount, lMaximumCount, UnicodeCache->Buffer, dwFlags, dwDesiredAccess);","path":"dll/win32/kernel32/client/synch.c","position":null,"original_position":52,"commit_id":"f1bd2aec2ef414a9dee3891db7ca8bb0fdf3be85","original_commit_id":"5a8c9b0ba1e5d7c1b83e14641d6c57f50fec0133","user":{"login":"Getequ","id":12053509,"node_id":"MDQ6VXNlcjEyMDUzNTA5","avatar_url":"https://avatars0.githubusercontent.com/u/12053509?v=4","gravatar_id":"","url":"https://api.github.com/users/Getequ","html_url":"https://github.com/Getequ","followers_url":"https://api.github.com/users/Getequ/followers","following_url":"https://api.github.com/users/Getequ/following{/other_user}","gists_url":"https://api.github.com/users/Getequ/gists{/gist_id}","starred_url":"https://api.github.com/users/Getequ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Getequ/subscriptions","organizations_url":"https://api.github.com/users/Getequ/orgs","repos_url":"https://api.github.com/users/Getequ/repos","events_url":"https://api.github.com/users/Getequ/events{/privacy}","received_events_url":"https://api.github.com/users/Getequ/received_events","type":"User","site_admin":false},"body":"@HBelusca fixed all three","created_at":"2018-11-20T07:44:05Z","updated_at":"2018-11-20T07:44:06Z","html_url":"https://github.com/reactos/reactos/pull/1046#discussion_r234895864","pull_request_url":"https://api.github.com/repos/reactos/reactos/pulls/1046","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments/234895864"},"html":{"href":"https://github.com/reactos/reactos/pull/1046#discussion_r234895864"},"pull_request":{"href":"https://api.github.com/repos/reactos/reactos/pulls/1046"}},"in_reply_to_id":234456050},"pull_request":{"url":"https://api.github.com/repos/reactos/reactos/pulls/1046","id":231799712,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzk5NzEy","html_url":"https://github.com/reactos/reactos/pull/1046","diff_url":"https://github.com/reactos/reactos/pull/1046.diff","patch_url":"https://github.com/reactos/reactos/pull/1046.patch","issue_url":"https://api.github.com/repos/reactos/reactos/issues/1046","number":1046,"state":"open","locked":false,"title":"[KERNEL32] implement CreateSemaphoreExW/A and adjust macroses for it","user":{"login":"Getequ","id":12053509,"node_id":"MDQ6VXNlcjEyMDUzNTA5","avatar_url":"https://avatars0.githubusercontent.com/u/12053509?v=4","gravatar_id":"","url":"https://api.github.com/users/Getequ","html_url":"https://github.com/Getequ","followers_url":"https://api.github.com/users/Getequ/followers","following_url":"https://api.github.com/users/Getequ/following{/other_user}","gists_url":"https://api.github.com/users/Getequ/gists{/gist_id}","starred_url":"https://api.github.com/users/Getequ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Getequ/subscriptions","organizations_url":"https://api.github.com/users/Getequ/orgs","repos_url":"https://api.github.com/users/Getequ/repos","events_url":"https://api.github.com/users/Getequ/events{/privacy}","received_events_url":"https://api.github.com/users/Getequ/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2018-11-18T16:52:04Z","updated_at":"2018-11-20T07:44:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f790f3554fb44857d5b508c18def8e052fda5fe0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactos/reactos/pulls/1046/commits","review_comments_url":"https://api.github.com/repos/reactos/reactos/pulls/1046/comments","review_comment_url":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactos/reactos/issues/1046/comments","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/f1bd2aec2ef414a9dee3891db7ca8bb0fdf3be85","head":{"label":"Getequ:sync","ref":"sync","sha":"f1bd2aec2ef414a9dee3891db7ca8bb0fdf3be85","user":{"login":"Getequ","id":12053509,"node_id":"MDQ6VXNlcjEyMDUzNTA5","avatar_url":"https://avatars0.githubusercontent.com/u/12053509?v=4","gravatar_id":"","url":"https://api.github.com/users/Getequ","html_url":"https://github.com/Getequ","followers_url":"https://api.github.com/users/Getequ/followers","following_url":"https://api.github.com/users/Getequ/following{/other_user}","gists_url":"https://api.github.com/users/Getequ/gists{/gist_id}","starred_url":"https://api.github.com/users/Getequ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Getequ/subscriptions","organizations_url":"https://api.github.com/users/Getequ/orgs","repos_url":"https://api.github.com/users/Getequ/repos","events_url":"https://api.github.com/users/Getequ/events{/privacy}","received_events_url":"https://api.github.com/users/Getequ/received_events","type":"User","site_admin":false},"repo":{"id":116133617,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxMzM2MTc=","name":"reactos","full_name":"Getequ/reactos","private":false,"owner":{"login":"Getequ","id":12053509,"node_id":"MDQ6VXNlcjEyMDUzNTA5","avatar_url":"https://avatars0.githubusercontent.com/u/12053509?v=4","gravatar_id":"","url":"https://api.github.com/users/Getequ","html_url":"https://github.com/Getequ","followers_url":"https://api.github.com/users/Getequ/followers","following_url":"https://api.github.com/users/Getequ/following{/other_user}","gists_url":"https://api.github.com/users/Getequ/gists{/gist_id}","starred_url":"https://api.github.com/users/Getequ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Getequ/subscriptions","organizations_url":"https://api.github.com/users/Getequ/orgs","repos_url":"https://api.github.com/users/Getequ/repos","events_url":"https://api.github.com/users/Getequ/events{/privacy}","received_events_url":"https://api.github.com/users/Getequ/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Getequ/reactos","description":"A free Windows-compatible Operating System","fork":true,"url":"https://api.github.com/repos/Getequ/reactos","forks_url":"https://api.github.com/repos/Getequ/reactos/forks","keys_url":"https://api.github.com/repos/Getequ/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Getequ/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Getequ/reactos/teams","hooks_url":"https://api.github.com/repos/Getequ/reactos/hooks","issue_events_url":"https://api.github.com/repos/Getequ/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/Getequ/reactos/events","assignees_url":"https://api.github.com/repos/Getequ/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/Getequ/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/Getequ/reactos/tags","blobs_url":"https://api.github.com/repos/Getequ/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Getequ/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Getequ/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Getequ/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Getequ/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/Getequ/reactos/languages","stargazers_url":"https://api.github.com/repos/Getequ/reactos/stargazers","contributors_url":"https://api.github.com/repos/Getequ/reactos/contributors","subscribers_url":"https://api.github.com/repos/Getequ/reactos/subscribers","subscription_url":"https://api.github.com/repos/Getequ/reactos/subscription","commits_url":"https://api.github.com/repos/Getequ/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Getequ/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Getequ/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Getequ/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Getequ/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/Getequ/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Getequ/reactos/merges","archive_url":"https://api.github.com/repos/Getequ/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Getequ/reactos/downloads","issues_url":"https://api.github.com/repos/Getequ/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/Getequ/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/Getequ/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/Getequ/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Getequ/reactos/labels{/name}","releases_url":"https://api.github.com/repos/Getequ/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/Getequ/reactos/deployments","created_at":"2018-01-03T12:18:37Z","updated_at":"2018-01-03T12:19:51Z","pushed_at":"2018-11-19T14:59:43Z","git_url":"git://github.com/Getequ/reactos.git","ssh_url":"git@github.com:Getequ/reactos.git","clone_url":"https://github.com/Getequ/reactos.git","svn_url":"https://github.com/Getequ/reactos","homepage":null,"size":462746,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactos:master","ref":"master","sha":"154ed3706252d4c1e0ca4f738668cd8dcbd2b0dd","user":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"repo":{"id":105627846,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2Mjc4NDY=","name":"reactos","full_name":"reactos/reactos","private":false,"owner":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactos/reactos","description":"A free Windows-compatible Operating System","fork":false,"url":"https://api.github.com/repos/reactos/reactos","forks_url":"https://api.github.com/repos/reactos/reactos/forks","keys_url":"https://api.github.com/repos/reactos/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactos/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactos/reactos/teams","hooks_url":"https://api.github.com/repos/reactos/reactos/hooks","issue_events_url":"https://api.github.com/repos/reactos/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/reactos/reactos/events","assignees_url":"https://api.github.com/repos/reactos/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/reactos/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/reactos/reactos/tags","blobs_url":"https://api.github.com/repos/reactos/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactos/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactos/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactos/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/reactos/reactos/languages","stargazers_url":"https://api.github.com/repos/reactos/reactos/stargazers","contributors_url":"https://api.github.com/repos/reactos/reactos/contributors","subscribers_url":"https://api.github.com/repos/reactos/reactos/subscribers","subscription_url":"https://api.github.com/repos/reactos/reactos/subscription","commits_url":"https://api.github.com/repos/reactos/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactos/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactos/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactos/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactos/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/reactos/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactos/reactos/merges","archive_url":"https://api.github.com/repos/reactos/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactos/reactos/downloads","issues_url":"https://api.github.com/repos/reactos/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/reactos/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/reactos/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/reactos/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactos/reactos/labels{/name}","releases_url":"https://api.github.com/repos/reactos/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/reactos/reactos/deployments","created_at":"2017-10-03T08:04:52Z","updated_at":"2018-11-20T07:37:29Z","pushed_at":"2018-11-19T18:55:31Z","git_url":"git://github.com/reactos/reactos.git","ssh_url":"git@github.com:reactos/reactos.git","clone_url":"https://github.com/reactos/reactos.git","svn_url":"https://github.com/reactos/reactos","homepage":null,"size":462811,"stargazers_count":5454,"watchers_count":5454,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":469,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":469,"open_issues":77,"watchers":5454,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/1046"},"html":{"href":"https://github.com/reactos/reactos/pull/1046"},"issue":{"href":"https://api.github.com/repos/reactos/reactos/issues/1046"},"comments":{"href":"https://api.github.com/repos/reactos/reactos/issues/1046/comments"},"review_comments":{"href":"https://api.github.com/repos/reactos/reactos/pulls/1046/comments"},"review_comment":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactos/reactos/pulls/1046/commits"},"statuses":{"href":"https://api.github.com/repos/reactos/reactos/statuses/f1bd2aec2ef414a9dee3891db7ca8bb0fdf3be85"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Getequ"}}