{"action":"created","comment":{"url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/comments/197317930","pull_request_review_id":131040990,"id":197317930,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzMxNzkzMA==","diff_hunk":"@@ -1320,6 +1354,28 @@ void CThinBlockData::ClearThinBlockData(CNode *pnode, uint256 hash)\n     ClearThinBlockData(pnode);\n     ClearThinBlockInFlight(pnode, hash);\n }\n+\n+void CThinBlockData::ClearThinBlockStats()\n+{\n+    nOriginalSize.Clear();","path":"src/thinblock.cpp","position":null,"original_position":55,"commit_id":"11e0b9af77901bfd14adb788b84969b19e7c4eed","original_commit_id":"f6edfdfa6cb29f5519cbaa0168abaf6d8977f2c4","user":{"login":"bissias","id":1005112,"node_id":"MDQ6VXNlcjEwMDUxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1005112?v=4","gravatar_id":"","url":"https://api.github.com/users/bissias","html_url":"https://github.com/bissias","followers_url":"https://api.github.com/users/bissias/followers","following_url":"https://api.github.com/users/bissias/following{/other_user}","gists_url":"https://api.github.com/users/bissias/gists{/gist_id}","starred_url":"https://api.github.com/users/bissias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bissias/subscriptions","organizations_url":"https://api.github.com/users/bissias/orgs","repos_url":"https://api.github.com/users/bissias/repos","events_url":"https://api.github.com/users/bissias/events{/privacy}","received_events_url":"https://api.github.com/users/bissias/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-06-22T01:14:32Z","updated_at":"2018-06-22T01:14:32Z","html_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/973#discussion_r197317930","pull_request_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/973","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/comments/197317930"},"html":{"href":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/973#discussion_r197317930"},"pull_request":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/973"}},"in_reply_to_id":197313784},"pull_request":{"url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/973","id":169631873,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY5NjMxODcz","html_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/973","diff_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/973.diff","patch_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/973.patch","issue_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/973","number":973,"state":"open","locked":false,"title":"graphene: first draft","user":{"login":"bissias","id":1005112,"node_id":"MDQ6VXNlcjEwMDUxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1005112?v=4","gravatar_id":"","url":"https://api.github.com/users/bissias","html_url":"https://github.com/bissias","followers_url":"https://api.github.com/users/bissias/followers","following_url":"https://api.github.com/users/bissias/following{/other_user}","gists_url":"https://api.github.com/users/bissias/gists{/gist_id}","starred_url":"https://api.github.com/users/bissias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bissias/subscriptions","organizations_url":"https://api.github.com/users/bissias/orgs","repos_url":"https://api.github.com/users/bissias/repos","events_url":"https://api.github.com/users/bissias/events{/privacy}","received_events_url":"https://api.github.com/users/bissias/received_events","type":"User","site_admin":false},"body":"This commit provides a functional implementation of graphene blocks. All unit tests pass and the QA test grapheneblocks.py also passes. From log output it is evident that graphene blocks are requested, created, serialized, deserialized, and reconstructed. However there is still work to be done. My general approach has been to largely replicate the workflow of xthin blocks. Thus I have replicated large portions of the xthin code. It's not clear that this is preferable to sharing code between the two block types. There also remains the question of transaction ordering for graphene blocks. If it is possible to commit a canonical ordering before graphene, then we will want to change this patch accordingly.\r\n\r\nThe code will also require further optimization (primarily block size optimization) before being deployed to production. My aim is to initiate a review for the basic workflow now and continue to work on optimization while graphene is running on the testnet. The following optimization tasks remain.\r\n\r\n* Update Bloom filter constants for optimal symdiff\r\n* Employ numerical symdiff calculation for greater accuracy\r\n* Use smaller dirty hashes for IBLT\r\n* Consider options for compressing transaction ordering: smaller hashes or perhaps a different data structure\r\n","created_at":"2018-02-16T14:05:15Z","updated_at":"2018-06-22T01:14:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0392b8a2d816bca75195c3374b0d0a70f27a047d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":932358142,"node_id":"MDU6TGFiZWw5MzIzNTgxNDI=","url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/labels/P2P","name":"P2P","color":"b9f733","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/973/commits","review_comments_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/973/comments","review_comment_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/973/comments","statuses_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/statuses/11e0b9af77901bfd14adb788b84969b19e7c4eed","head":{"label":"bissias:graphene","ref":"graphene","sha":"11e0b9af77901bfd14adb788b84969b19e7c4eed","user":{"login":"bissias","id":1005112,"node_id":"MDQ6VXNlcjEwMDUxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1005112?v=4","gravatar_id":"","url":"https://api.github.com/users/bissias","html_url":"https://github.com/bissias","followers_url":"https://api.github.com/users/bissias/followers","following_url":"https://api.github.com/users/bissias/following{/other_user}","gists_url":"https://api.github.com/users/bissias/gists{/gist_id}","starred_url":"https://api.github.com/users/bissias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bissias/subscriptions","organizations_url":"https://api.github.com/users/bissias/orgs","repos_url":"https://api.github.com/users/bissias/repos","events_url":"https://api.github.com/users/bissias/events{/privacy}","received_events_url":"https://api.github.com/users/bissias/received_events","type":"User","site_admin":false},"repo":{"id":111242924,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyNDI5MjQ=","name":"BitcoinUnlimited","full_name":"bissias/BitcoinUnlimited","owner":{"login":"bissias","id":1005112,"node_id":"MDQ6VXNlcjEwMDUxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1005112?v=4","gravatar_id":"","url":"https://api.github.com/users/bissias","html_url":"https://github.com/bissias","followers_url":"https://api.github.com/users/bissias/followers","following_url":"https://api.github.com/users/bissias/following{/other_user}","gists_url":"https://api.github.com/users/bissias/gists{/gist_id}","starred_url":"https://api.github.com/users/bissias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bissias/subscriptions","organizations_url":"https://api.github.com/users/bissias/orgs","repos_url":"https://api.github.com/users/bissias/repos","events_url":"https://api.github.com/users/bissias/events{/privacy}","received_events_url":"https://api.github.com/users/bissias/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bissias/BitcoinUnlimited","description":"Bitcoin Unlimited (Graphene)","fork":true,"url":"https://api.github.com/repos/bissias/BitcoinUnlimited","forks_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/forks","keys_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/teams","hooks_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/hooks","issue_events_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/issues/events{/number}","events_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/events","assignees_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/assignees{/user}","branches_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/branches{/branch}","tags_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/tags","blobs_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/git/refs{/sha}","trees_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/statuses/{sha}","languages_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/languages","stargazers_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/stargazers","contributors_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/contributors","subscribers_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/subscribers","subscription_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/subscription","commits_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/commits{/sha}","git_commits_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/git/commits{/sha}","comments_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/comments{/number}","issue_comment_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/issues/comments{/number}","contents_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/contents/{+path}","compare_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/merges","archive_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/downloads","issues_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/issues{/number}","pulls_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/pulls{/number}","milestones_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/milestones{/number}","notifications_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/labels{/name}","releases_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/releases{/id}","deployments_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/deployments","created_at":"2017-11-18T22:02:51Z","updated_at":"2018-05-01T03:35:53Z","pushed_at":"2018-06-22T00:48:25Z","git_url":"git://github.com/bissias/BitcoinUnlimited.git","ssh_url":"git@github.com:bissias/BitcoinUnlimited.git","clone_url":"https://github.com/bissias/BitcoinUnlimited.git","svn_url":"https://github.com/bissias/BitcoinUnlimited","homepage":"http://www.bitcoinunlimited.info/download.html","size":93880,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"BitcoinCash"}},"base":{"label":"BitcoinUnlimited:dev","ref":"dev","sha":"ce1eea65b0459248307dbcad4215802b671650e4","user":{"login":"BitcoinUnlimited","id":14125627,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTI1NjI3","avatar_url":"https://avatars0.githubusercontent.com/u/14125627?v=4","gravatar_id":"","url":"https://api.github.com/users/BitcoinUnlimited","html_url":"https://github.com/BitcoinUnlimited","followers_url":"https://api.github.com/users/BitcoinUnlimited/followers","following_url":"https://api.github.com/users/BitcoinUnlimited/following{/other_user}","gists_url":"https://api.github.com/users/BitcoinUnlimited/gists{/gist_id}","starred_url":"https://api.github.com/users/BitcoinUnlimited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitcoinUnlimited/subscriptions","organizations_url":"https://api.github.com/users/BitcoinUnlimited/orgs","repos_url":"https://api.github.com/users/BitcoinUnlimited/repos","events_url":"https://api.github.com/users/BitcoinUnlimited/events{/privacy}","received_events_url":"https://api.github.com/users/BitcoinUnlimited/received_events","type":"Organization","site_admin":false},"repo":{"id":18613259,"node_id":"MDEwOlJlcG9zaXRvcnkxODYxMzI1OQ==","name":"BitcoinUnlimited","full_name":"BitcoinUnlimited/BitcoinUnlimited","owner":{"login":"BitcoinUnlimited","id":14125627,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTI1NjI3","avatar_url":"https://avatars0.githubusercontent.com/u/14125627?v=4","gravatar_id":"","url":"https://api.github.com/users/BitcoinUnlimited","html_url":"https://github.com/BitcoinUnlimited","followers_url":"https://api.github.com/users/BitcoinUnlimited/followers","following_url":"https://api.github.com/users/BitcoinUnlimited/following{/other_user}","gists_url":"https://api.github.com/users/BitcoinUnlimited/gists{/gist_id}","starred_url":"https://api.github.com/users/BitcoinUnlimited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitcoinUnlimited/subscriptions","organizations_url":"https://api.github.com/users/BitcoinUnlimited/orgs","repos_url":"https://api.github.com/users/BitcoinUnlimited/repos","events_url":"https://api.github.com/users/BitcoinUnlimited/events{/privacy}","received_events_url":"https://api.github.com/users/BitcoinUnlimited/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited","description":"Bitcoin Unlimited integration/staging tree","fork":false,"url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited","forks_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/forks","keys_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/teams","hooks_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/hooks","issue_events_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/events{/number}","events_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/events","assignees_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/assignees{/user}","branches_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/branches{/branch}","tags_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/tags","blobs_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/git/refs{/sha}","trees_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/statuses/{sha}","languages_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/languages","stargazers_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/stargazers","contributors_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/contributors","subscribers_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/subscribers","subscription_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/subscription","commits_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/commits{/sha}","git_commits_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/git/commits{/sha}","comments_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/comments{/number}","issue_comment_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/comments{/number}","contents_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/contents/{+path}","compare_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/merges","archive_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/downloads","issues_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues{/number}","pulls_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls{/number}","milestones_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/milestones{/number}","notifications_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/labels{/name}","releases_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/releases{/id}","deployments_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/deployments","created_at":"2014-04-09T21:03:00Z","updated_at":"2018-06-20T19:51:15Z","pushed_at":"2018-06-22T00:48:28Z","git_url":"git://github.com/BitcoinUnlimited/BitcoinUnlimited.git","ssh_url":"git@github.com:BitcoinUnlimited/BitcoinUnlimited.git","clone_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited.git","svn_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited","homepage":"http://www.bitcoinunlimited.info/download.html","size":67330,"stargazers_count":346,"watchers_count":346,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":147,"open_issues":70,"watchers":346,"default_branch":"release"}},"_links":{"self":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/973"},"html":{"href":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/973"},"issue":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/973"},"comments":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/973/comments"},"review_comments":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/973/comments"},"review_comment":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/973/commits"},"statuses":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/statuses/11e0b9af77901bfd14adb788b84969b19e7c4eed"}},"author_association":"NONE"}}
{"actor":{"display_login":"bissias"}}