{"action":"created","comment":{"url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls/comments/171345359","pull_request_review_id":100181662,"id":171345359,"diff_hunk":"@@ -132,7 +141,11 @@ public final class DefaultControlsViewController: ContentControlsViewController\n             afterFadeAnimationActions.append(block)\n         }\n \n-        if uiProps.animationsEnabled {\n+        var controlsAnimationEnabled: Bool {\n+            return uiProps.animationsEnabled && hasAppeared && !isTransitioning","path":"PlayerControls/sources/DefaultControlsViewController.swift","position":28,"original_position":28,"commit_id":"3327ec91ca62b0a0bb7389c8883416f081c63317","original_commit_id":"3327ec91ca62b0a0bb7389c8883416f081c63317","user":{"login":"AndriiMoskvin","id":16276892,"avatar_url":"https://avatars0.githubusercontent.com/u/16276892?v=4","gravatar_id":"","url":"https://api.github.com/users/AndriiMoskvin","html_url":"https://github.com/AndriiMoskvin","followers_url":"https://api.github.com/users/AndriiMoskvin/followers","following_url":"https://api.github.com/users/AndriiMoskvin/following{/other_user}","gists_url":"https://api.github.com/users/AndriiMoskvin/gists{/gist_id}","starred_url":"https://api.github.com/users/AndriiMoskvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndriiMoskvin/subscriptions","organizations_url":"https://api.github.com/users/AndriiMoskvin/orgs","repos_url":"https://api.github.com/users/AndriiMoskvin/repos","events_url":"https://api.github.com/users/AndriiMoskvin/events{/privacy}","received_events_url":"https://api.github.com/users/AndriiMoskvin/received_events","type":"User","site_admin":false},"body":"Not sure that I understand\r\n> each one rewrites controlsAnimationEnabled","created_at":"2018-02-28T18:46:07Z","updated_at":"2018-02-28T18:46:07Z","html_url":"https://github.com/aol-public/OneMobileSDK-controls-ios/pull/97#discussion_r171345359","pull_request_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls/97","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls/comments/171345359"},"html":{"href":"https://github.com/aol-public/OneMobileSDK-controls-ios/pull/97#discussion_r171345359"},"pull_request":{"href":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls/97"}},"in_reply_to_id":171215765},"pull_request":{"url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls/97","id":171428390,"html_url":"https://github.com/aol-public/OneMobileSDK-controls-ios/pull/97","diff_url":"https://github.com/aol-public/OneMobileSDK-controls-ios/pull/97.diff","patch_url":"https://github.com/aol-public/OneMobileSDK-controls-ios/pull/97.patch","issue_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/issues/97","number":97,"state":"open","locked":false,"title":"Removed controls animation during transitions","user":{"login":"RomanTysiachnik","id":31652265,"avatar_url":"https://avatars1.githubusercontent.com/u/31652265?v=4","gravatar_id":"","url":"https://api.github.com/users/RomanTysiachnik","html_url":"https://github.com/RomanTysiachnik","followers_url":"https://api.github.com/users/RomanTysiachnik/followers","following_url":"https://api.github.com/users/RomanTysiachnik/following{/other_user}","gists_url":"https://api.github.com/users/RomanTysiachnik/gists{/gist_id}","starred_url":"https://api.github.com/users/RomanTysiachnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomanTysiachnik/subscriptions","organizations_url":"https://api.github.com/users/RomanTysiachnik/orgs","repos_url":"https://api.github.com/users/RomanTysiachnik/repos","events_url":"https://api.github.com/users/RomanTysiachnik/events{/privacy}","received_events_url":"https://api.github.com/users/RomanTysiachnik/received_events","type":"User","site_admin":false},"body":"## Removed controls animation during transitions\r\nI've added a new flag - controlsAnimationEnabled that now will depend on:\r\n- `uiProps` value;\r\n- `isAppeared` - if the view has appeared ;\r\n- `isTransition` - if current changes in layout are not triggered by transition.\r\n\r\n**Broken:**\r\n![broken](https://user-images.githubusercontent.com/31652265/36682441-be7fdb68-1b23-11e8-86f0-0820ef7973cd.gif)\r\n\r\n**Fixed:**\r\n![fixed](https://user-images.githubusercontent.com/31652265/36682439-be594264-1b23-11e8-8c73-65021624ed23.gif)","created_at":"2018-02-26T16:42:33Z","updated_at":"2018-02-28T18:46:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f02e348888acaf77c369f0c98bf96432e471ab4","assignee":{"login":"RomanTysiachnik","id":31652265,"avatar_url":"https://avatars1.githubusercontent.com/u/31652265?v=4","gravatar_id":"","url":"https://api.github.com/users/RomanTysiachnik","html_url":"https://github.com/RomanTysiachnik","followers_url":"https://api.github.com/users/RomanTysiachnik/followers","following_url":"https://api.github.com/users/RomanTysiachnik/following{/other_user}","gists_url":"https://api.github.com/users/RomanTysiachnik/gists{/gist_id}","starred_url":"https://api.github.com/users/RomanTysiachnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomanTysiachnik/subscriptions","organizations_url":"https://api.github.com/users/RomanTysiachnik/orgs","repos_url":"https://api.github.com/users/RomanTysiachnik/repos","events_url":"https://api.github.com/users/RomanTysiachnik/events{/privacy}","received_events_url":"https://api.github.com/users/RomanTysiachnik/received_events","type":"User","site_admin":false},"assignees":[{"login":"RomanTysiachnik","id":31652265,"avatar_url":"https://avatars1.githubusercontent.com/u/31652265?v=4","gravatar_id":"","url":"https://api.github.com/users/RomanTysiachnik","html_url":"https://github.com/RomanTysiachnik","followers_url":"https://api.github.com/users/RomanTysiachnik/followers","following_url":"https://api.github.com/users/RomanTysiachnik/following{/other_user}","gists_url":"https://api.github.com/users/RomanTysiachnik/gists{/gist_id}","starred_url":"https://api.github.com/users/RomanTysiachnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomanTysiachnik/subscriptions","organizations_url":"https://api.github.com/users/RomanTysiachnik/orgs","repos_url":"https://api.github.com/users/RomanTysiachnik/repos","events_url":"https://api.github.com/users/RomanTysiachnik/events{/privacy}","received_events_url":"https://api.github.com/users/RomanTysiachnik/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls/97/commits","review_comments_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls/97/comments","review_comment_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/issues/97/comments","statuses_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/statuses/3327ec91ca62b0a0bb7389c8883416f081c63317","head":{"label":"aol-public:OMSDK-700/removed-animation-during-transitions","ref":"OMSDK-700/removed-animation-during-transitions","sha":"3327ec91ca62b0a0bb7389c8883416f081c63317","user":{"login":"aol-public","id":26207847,"avatar_url":"https://avatars1.githubusercontent.com/u/26207847?v=4","gravatar_id":"","url":"https://api.github.com/users/aol-public","html_url":"https://github.com/aol-public","followers_url":"https://api.github.com/users/aol-public/followers","following_url":"https://api.github.com/users/aol-public/following{/other_user}","gists_url":"https://api.github.com/users/aol-public/gists{/gist_id}","starred_url":"https://api.github.com/users/aol-public/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aol-public/subscriptions","organizations_url":"https://api.github.com/users/aol-public/orgs","repos_url":"https://api.github.com/users/aol-public/repos","events_url":"https://api.github.com/users/aol-public/events{/privacy}","received_events_url":"https://api.github.com/users/aol-public/received_events","type":"Organization","site_admin":false},"repo":{"id":83088998,"name":"OneMobileSDK-controls-ios","full_name":"aol-public/OneMobileSDK-controls-ios","owner":{"login":"aol-public","id":26207847,"avatar_url":"https://avatars1.githubusercontent.com/u/26207847?v=4","gravatar_id":"","url":"https://api.github.com/users/aol-public","html_url":"https://github.com/aol-public","followers_url":"https://api.github.com/users/aol-public/followers","following_url":"https://api.github.com/users/aol-public/following{/other_user}","gists_url":"https://api.github.com/users/aol-public/gists{/gist_id}","starred_url":"https://api.github.com/users/aol-public/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aol-public/subscriptions","organizations_url":"https://api.github.com/users/aol-public/orgs","repos_url":"https://api.github.com/users/aol-public/repos","events_url":"https://api.github.com/users/aol-public/events{/privacy}","received_events_url":"https://api.github.com/users/aol-public/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aol-public/OneMobileSDK-controls-ios","description":"Public iOS implementation of the OneMobileSDK default custom controls interface... demonstrating how customers can implement their own custom video player controls.","fork":false,"url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios","forks_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/forks","keys_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/teams","hooks_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/hooks","issue_events_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/issues/events{/number}","events_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/events","assignees_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/assignees{/user}","branches_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/branches{/branch}","tags_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/tags","blobs_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/languages","stargazers_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/stargazers","contributors_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/contributors","subscribers_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/subscribers","subscription_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/subscription","commits_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/contents/{+path}","compare_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/merges","archive_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/downloads","issues_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/issues{/number}","pulls_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/labels{/name}","releases_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/releases{/id}","deployments_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/deployments","created_at":"2017-02-24T22:41:50Z","updated_at":"2018-02-01T10:32:35Z","pushed_at":"2018-02-28T18:36:19Z","git_url":"git://github.com/aol-public/OneMobileSDK-controls-ios.git","ssh_url":"git@github.com:aol-public/OneMobileSDK-controls-ios.git","clone_url":"https://github.com/aol-public/OneMobileSDK-controls-ios.git","svn_url":"https://github.com/aol-public/OneMobileSDK-controls-ios","homepage":null,"size":19482,"stargazers_count":20,"watchers_count":20,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":4,"watchers":20,"default_branch":"master"}},"base":{"label":"aol-public:master","ref":"master","sha":"3e8d54f285e33af190f6277d1ecb84bf41fe2d5a","user":{"login":"aol-public","id":26207847,"avatar_url":"https://avatars1.githubusercontent.com/u/26207847?v=4","gravatar_id":"","url":"https://api.github.com/users/aol-public","html_url":"https://github.com/aol-public","followers_url":"https://api.github.com/users/aol-public/followers","following_url":"https://api.github.com/users/aol-public/following{/other_user}","gists_url":"https://api.github.com/users/aol-public/gists{/gist_id}","starred_url":"https://api.github.com/users/aol-public/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aol-public/subscriptions","organizations_url":"https://api.github.com/users/aol-public/orgs","repos_url":"https://api.github.com/users/aol-public/repos","events_url":"https://api.github.com/users/aol-public/events{/privacy}","received_events_url":"https://api.github.com/users/aol-public/received_events","type":"Organization","site_admin":false},"repo":{"id":83088998,"name":"OneMobileSDK-controls-ios","full_name":"aol-public/OneMobileSDK-controls-ios","owner":{"login":"aol-public","id":26207847,"avatar_url":"https://avatars1.githubusercontent.com/u/26207847?v=4","gravatar_id":"","url":"https://api.github.com/users/aol-public","html_url":"https://github.com/aol-public","followers_url":"https://api.github.com/users/aol-public/followers","following_url":"https://api.github.com/users/aol-public/following{/other_user}","gists_url":"https://api.github.com/users/aol-public/gists{/gist_id}","starred_url":"https://api.github.com/users/aol-public/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aol-public/subscriptions","organizations_url":"https://api.github.com/users/aol-public/orgs","repos_url":"https://api.github.com/users/aol-public/repos","events_url":"https://api.github.com/users/aol-public/events{/privacy}","received_events_url":"https://api.github.com/users/aol-public/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aol-public/OneMobileSDK-controls-ios","description":"Public iOS implementation of the OneMobileSDK default custom controls interface... demonstrating how customers can implement their own custom video player controls.","fork":false,"url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios","forks_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/forks","keys_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/teams","hooks_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/hooks","issue_events_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/issues/events{/number}","events_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/events","assignees_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/assignees{/user}","branches_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/branches{/branch}","tags_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/tags","blobs_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/languages","stargazers_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/stargazers","contributors_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/contributors","subscribers_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/subscribers","subscription_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/subscription","commits_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/contents/{+path}","compare_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/merges","archive_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/downloads","issues_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/issues{/number}","pulls_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/labels{/name}","releases_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/releases{/id}","deployments_url":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/deployments","created_at":"2017-02-24T22:41:50Z","updated_at":"2018-02-01T10:32:35Z","pushed_at":"2018-02-28T18:36:19Z","git_url":"git://github.com/aol-public/OneMobileSDK-controls-ios.git","ssh_url":"git@github.com:aol-public/OneMobileSDK-controls-ios.git","clone_url":"https://github.com/aol-public/OneMobileSDK-controls-ios.git","svn_url":"https://github.com/aol-public/OneMobileSDK-controls-ios","homepage":null,"size":19482,"stargazers_count":20,"watchers_count":20,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":4,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls/97"},"html":{"href":"https://github.com/aol-public/OneMobileSDK-controls-ios/pull/97"},"issue":{"href":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/issues/97"},"comments":{"href":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/aol-public/OneMobileSDK-controls-ios/statuses/3327ec91ca62b0a0bb7389c8883416f081c63317"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AndriiMoskvin"}}