{"action":"created","comment":{"url":"https://api.github.com/repos/minbrowser/min/pulls/comments/178396170","pull_request_review_id":108454751,"id":178396170,"diff_hunk":"@@ -79,4 +80,10 @@ db.open().then(function () {\n \n Dexie.Promise.on('error', function (error) {\n   console.warn('database error occured', error)\n+\n+  if (!dbAlertShown) {\n+    window.alert('Make sure no other Min instance is running and then restart Electron.')","path":"js/util/database.js","position":14,"original_position":14,"commit_id":"b4a4871eedb857f7bb2859c5c179308ee5400a09","original_commit_id":"b4a4871eedb857f7bb2859c5c179308ee5400a09","user":{"login":"PalmerAL","id":10314059,"avatar_url":"https://avatars3.githubusercontent.com/u/10314059?v=4","gravatar_id":"","url":"https://api.github.com/users/PalmerAL","html_url":"https://github.com/PalmerAL","followers_url":"https://api.github.com/users/PalmerAL/followers","following_url":"https://api.github.com/users/PalmerAL/following{/other_user}","gists_url":"https://api.github.com/users/PalmerAL/gists{/gist_id}","starred_url":"https://api.github.com/users/PalmerAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PalmerAL/subscriptions","organizations_url":"https://api.github.com/users/PalmerAL/orgs","repos_url":"https://api.github.com/users/PalmerAL/repos","events_url":"https://api.github.com/users/PalmerAL/events{/privacy}","received_events_url":"https://api.github.com/users/PalmerAL/received_events","type":"User","site_admin":false},"body":"This needs an ```if (window && window.alert)``` around it, since this error could also occur from within a worker that doesn't have a ```window``` object.\r\n\r\nAlso, could you move the string to the translation file so that it can be translated into other languages? To do that, you would add a line to the ```localization/languages/en-US.json``` file, and then replace the string here with ```l(whatever the string name is)```.","created_at":"2018-03-30T22:22:56Z","updated_at":"2018-03-30T22:27:59Z","html_url":"https://github.com/minbrowser/min/pull/528#discussion_r178396170","pull_request_url":"https://api.github.com/repos/minbrowser/min/pulls/528","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/minbrowser/min/pulls/comments/178396170"},"html":{"href":"https://github.com/minbrowser/min/pull/528#discussion_r178396170"},"pull_request":{"href":"https://api.github.com/repos/minbrowser/min/pulls/528"}}},"pull_request":{"url":"https://api.github.com/repos/minbrowser/min/pulls/528","id":178644777,"html_url":"https://github.com/minbrowser/min/pull/528","diff_url":"https://github.com/minbrowser/min/pull/528.diff","patch_url":"https://github.com/minbrowser/min/pull/528.patch","issue_url":"https://api.github.com/repos/minbrowser/min/issues/528","number":528,"state":"open","locked":false,"title":"Add alert for multiple running instances of Min","user":{"login":"revolter","id":5748627,"avatar_url":"https://avatars0.githubusercontent.com/u/5748627?v=4","gravatar_id":"","url":"https://api.github.com/users/revolter","html_url":"https://github.com/revolter","followers_url":"https://api.github.com/users/revolter/followers","following_url":"https://api.github.com/users/revolter/following{/other_user}","gists_url":"https://api.github.com/users/revolter/gists{/gist_id}","starred_url":"https://api.github.com/users/revolter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revolter/subscriptions","organizations_url":"https://api.github.com/users/revolter/orgs","repos_url":"https://api.github.com/users/revolter/repos","events_url":"https://api.github.com/users/revolter/events{/privacy}","received_events_url":"https://api.github.com/users/revolter/received_events","type":"User","site_admin":false},"body":"Let me know if this makes sense or if there's a better way.\r\n\r\nThe problem would be that it doesn't show up directly on start, but most probably before a db related issue like incomplete preferences screen or unable to connect to an URL:\r\n\r\n![screen shot 2018-03-31 at 01 14 01](https://user-images.githubusercontent.com/5748627/38155520-ce3b96f2-3480-11e8-89d4-d53cf07b8530.png)\r\n\r\nFixes #526","created_at":"2018-03-30T22:14:12Z","updated_at":"2018-03-30T22:27:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05197883a963d6a31cd7554e759ad381d2b8b75f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minbrowser/min/pulls/528/commits","review_comments_url":"https://api.github.com/repos/minbrowser/min/pulls/528/comments","review_comment_url":"https://api.github.com/repos/minbrowser/min/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minbrowser/min/issues/528/comments","statuses_url":"https://api.github.com/repos/minbrowser/min/statuses/b4a4871eedb857f7bb2859c5c179308ee5400a09","head":{"label":"revolter:hotfix/multiple-instances-alert","ref":"hotfix/multiple-instances-alert","sha":"b4a4871eedb857f7bb2859c5c179308ee5400a09","user":{"login":"revolter","id":5748627,"avatar_url":"https://avatars0.githubusercontent.com/u/5748627?v=4","gravatar_id":"","url":"https://api.github.com/users/revolter","html_url":"https://github.com/revolter","followers_url":"https://api.github.com/users/revolter/followers","following_url":"https://api.github.com/users/revolter/following{/other_user}","gists_url":"https://api.github.com/users/revolter/gists{/gist_id}","starred_url":"https://api.github.com/users/revolter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revolter/subscriptions","organizations_url":"https://api.github.com/users/revolter/orgs","repos_url":"https://api.github.com/users/revolter/repos","events_url":"https://api.github.com/users/revolter/events{/privacy}","received_events_url":"https://api.github.com/users/revolter/received_events","type":"User","site_admin":false},"repo":{"id":127459872,"name":"min","full_name":"revolter/min","owner":{"login":"revolter","id":5748627,"avatar_url":"https://avatars0.githubusercontent.com/u/5748627?v=4","gravatar_id":"","url":"https://api.github.com/users/revolter","html_url":"https://github.com/revolter","followers_url":"https://api.github.com/users/revolter/followers","following_url":"https://api.github.com/users/revolter/following{/other_user}","gists_url":"https://api.github.com/users/revolter/gists{/gist_id}","starred_url":"https://api.github.com/users/revolter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revolter/subscriptions","organizations_url":"https://api.github.com/users/revolter/orgs","repos_url":"https://api.github.com/users/revolter/repos","events_url":"https://api.github.com/users/revolter/events{/privacy}","received_events_url":"https://api.github.com/users/revolter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/revolter/min","description":"A smarter, faster web browser","fork":true,"url":"https://api.github.com/repos/revolter/min","forks_url":"https://api.github.com/repos/revolter/min/forks","keys_url":"https://api.github.com/repos/revolter/min/keys{/key_id}","collaborators_url":"https://api.github.com/repos/revolter/min/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/revolter/min/teams","hooks_url":"https://api.github.com/repos/revolter/min/hooks","issue_events_url":"https://api.github.com/repos/revolter/min/issues/events{/number}","events_url":"https://api.github.com/repos/revolter/min/events","assignees_url":"https://api.github.com/repos/revolter/min/assignees{/user}","branches_url":"https://api.github.com/repos/revolter/min/branches{/branch}","tags_url":"https://api.github.com/repos/revolter/min/tags","blobs_url":"https://api.github.com/repos/revolter/min/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/revolter/min/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/revolter/min/git/refs{/sha}","trees_url":"https://api.github.com/repos/revolter/min/git/trees{/sha}","statuses_url":"https://api.github.com/repos/revolter/min/statuses/{sha}","languages_url":"https://api.github.com/repos/revolter/min/languages","stargazers_url":"https://api.github.com/repos/revolter/min/stargazers","contributors_url":"https://api.github.com/repos/revolter/min/contributors","subscribers_url":"https://api.github.com/repos/revolter/min/subscribers","subscription_url":"https://api.github.com/repos/revolter/min/subscription","commits_url":"https://api.github.com/repos/revolter/min/commits{/sha}","git_commits_url":"https://api.github.com/repos/revolter/min/git/commits{/sha}","comments_url":"https://api.github.com/repos/revolter/min/comments{/number}","issue_comment_url":"https://api.github.com/repos/revolter/min/issues/comments{/number}","contents_url":"https://api.github.com/repos/revolter/min/contents/{+path}","compare_url":"https://api.github.com/repos/revolter/min/compare/{base}...{head}","merges_url":"https://api.github.com/repos/revolter/min/merges","archive_url":"https://api.github.com/repos/revolter/min/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/revolter/min/downloads","issues_url":"https://api.github.com/repos/revolter/min/issues{/number}","pulls_url":"https://api.github.com/repos/revolter/min/pulls{/number}","milestones_url":"https://api.github.com/repos/revolter/min/milestones{/number}","notifications_url":"https://api.github.com/repos/revolter/min/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/revolter/min/labels{/name}","releases_url":"https://api.github.com/repos/revolter/min/releases{/id}","deployments_url":"https://api.github.com/repos/revolter/min/deployments","created_at":"2018-03-30T18:23:16Z","updated_at":"2018-03-30T18:23:19Z","pushed_at":"2018-03-30T22:22:23Z","git_url":"git://github.com/revolter/min.git","ssh_url":"git@github.com:revolter/min.git","clone_url":"https://github.com/revolter/min.git","svn_url":"https://github.com/revolter/min","homepage":"https://minbrowser.github.io/min","size":146573,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minbrowser:master","ref":"master","sha":"4f6ccbcf99a9c07cf6cd7512536aaf18e0840fb2","user":{"login":"minbrowser","id":19240931,"avatar_url":"https://avatars2.githubusercontent.com/u/19240931?v=4","gravatar_id":"","url":"https://api.github.com/users/minbrowser","html_url":"https://github.com/minbrowser","followers_url":"https://api.github.com/users/minbrowser/followers","following_url":"https://api.github.com/users/minbrowser/following{/other_user}","gists_url":"https://api.github.com/users/minbrowser/gists{/gist_id}","starred_url":"https://api.github.com/users/minbrowser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minbrowser/subscriptions","organizations_url":"https://api.github.com/users/minbrowser/orgs","repos_url":"https://api.github.com/users/minbrowser/repos","events_url":"https://api.github.com/users/minbrowser/events{/privacy}","received_events_url":"https://api.github.com/users/minbrowser/received_events","type":"Organization","site_admin":false},"repo":{"id":45319761,"name":"min","full_name":"minbrowser/min","owner":{"login":"minbrowser","id":19240931,"avatar_url":"https://avatars2.githubusercontent.com/u/19240931?v=4","gravatar_id":"","url":"https://api.github.com/users/minbrowser","html_url":"https://github.com/minbrowser","followers_url":"https://api.github.com/users/minbrowser/followers","following_url":"https://api.github.com/users/minbrowser/following{/other_user}","gists_url":"https://api.github.com/users/minbrowser/gists{/gist_id}","starred_url":"https://api.github.com/users/minbrowser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minbrowser/subscriptions","organizations_url":"https://api.github.com/users/minbrowser/orgs","repos_url":"https://api.github.com/users/minbrowser/repos","events_url":"https://api.github.com/users/minbrowser/events{/privacy}","received_events_url":"https://api.github.com/users/minbrowser/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minbrowser/min","description":"A smarter, faster web browser","fork":false,"url":"https://api.github.com/repos/minbrowser/min","forks_url":"https://api.github.com/repos/minbrowser/min/forks","keys_url":"https://api.github.com/repos/minbrowser/min/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minbrowser/min/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minbrowser/min/teams","hooks_url":"https://api.github.com/repos/minbrowser/min/hooks","issue_events_url":"https://api.github.com/repos/minbrowser/min/issues/events{/number}","events_url":"https://api.github.com/repos/minbrowser/min/events","assignees_url":"https://api.github.com/repos/minbrowser/min/assignees{/user}","branches_url":"https://api.github.com/repos/minbrowser/min/branches{/branch}","tags_url":"https://api.github.com/repos/minbrowser/min/tags","blobs_url":"https://api.github.com/repos/minbrowser/min/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minbrowser/min/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minbrowser/min/git/refs{/sha}","trees_url":"https://api.github.com/repos/minbrowser/min/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minbrowser/min/statuses/{sha}","languages_url":"https://api.github.com/repos/minbrowser/min/languages","stargazers_url":"https://api.github.com/repos/minbrowser/min/stargazers","contributors_url":"https://api.github.com/repos/minbrowser/min/contributors","subscribers_url":"https://api.github.com/repos/minbrowser/min/subscribers","subscription_url":"https://api.github.com/repos/minbrowser/min/subscription","commits_url":"https://api.github.com/repos/minbrowser/min/commits{/sha}","git_commits_url":"https://api.github.com/repos/minbrowser/min/git/commits{/sha}","comments_url":"https://api.github.com/repos/minbrowser/min/comments{/number}","issue_comment_url":"https://api.github.com/repos/minbrowser/min/issues/comments{/number}","contents_url":"https://api.github.com/repos/minbrowser/min/contents/{+path}","compare_url":"https://api.github.com/repos/minbrowser/min/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minbrowser/min/merges","archive_url":"https://api.github.com/repos/minbrowser/min/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minbrowser/min/downloads","issues_url":"https://api.github.com/repos/minbrowser/min/issues{/number}","pulls_url":"https://api.github.com/repos/minbrowser/min/pulls{/number}","milestones_url":"https://api.github.com/repos/minbrowser/min/milestones{/number}","notifications_url":"https://api.github.com/repos/minbrowser/min/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minbrowser/min/labels{/name}","releases_url":"https://api.github.com/repos/minbrowser/min/releases{/id}","deployments_url":"https://api.github.com/repos/minbrowser/min/deployments","created_at":"2015-10-31T21:59:49Z","updated_at":"2018-03-30T22:07:35Z","pushed_at":"2018-03-30T22:23:13Z","git_url":"git://github.com/minbrowser/min.git","ssh_url":"git@github.com:minbrowser/min.git","clone_url":"https://github.com/minbrowser/min.git","svn_url":"https://github.com/minbrowser/min","homepage":"https://minbrowser.github.io/min","size":146573,"stargazers_count":2411,"watchers_count":2411,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":210,"mirror_url":null,"archived":false,"open_issues_count":236,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":210,"open_issues":236,"watchers":2411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minbrowser/min/pulls/528"},"html":{"href":"https://github.com/minbrowser/min/pull/528"},"issue":{"href":"https://api.github.com/repos/minbrowser/min/issues/528"},"comments":{"href":"https://api.github.com/repos/minbrowser/min/issues/528/comments"},"review_comments":{"href":"https://api.github.com/repos/minbrowser/min/pulls/528/comments"},"review_comment":{"href":"https://api.github.com/repos/minbrowser/min/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minbrowser/min/pulls/528/commits"},"statuses":{"href":"https://api.github.com/repos/minbrowser/min/statuses/b4a4871eedb857f7bb2859c5c179308ee5400a09"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PalmerAL"}}