{"action":"created","comment":{"url":"https://api.github.com/repos/Vita3K/Vita3K/pulls/comments/191233848","pull_request_review_id":123766278,"id":191233848,"diff_hunk":"@@ -486,15 +491,15 @@ std::string get_fragment_glsl(SceGxmShaderPatcher &shader_patcher, const SceGxmP\n     if (source.empty()) {\n         LOG_ERROR(\"Missing fragment shader {}\", hash_text.data());\n         source = generate_fragment_glsl(fragment_program);\n-        dump_missing_shader(hash_text.data(), \"frag\", fragment_program, source.c_str());\n+        dump_missing_shader(hash_text.data(), \"frag\", fragment_program, source.c_str(), base_path, game_title);\n     }\n \n     shader_patcher.fragment_glsl_cache.emplace(hash_bytes, source);\n \n     return source;\n }\n \n-std::string get_vertex_glsl(SceGxmShaderPatcher &shader_patcher, const SceGxmProgram &vertex_program, const char *base_path) {\n+std::string get_vertex_glsl(SceGxmShaderPatcher &shader_patcher, const SceGxmProgram &vertex_program, std::string game_title, const char *base_path) {","path":"src/emulator/gxm/src/gxm.cpp","position":66,"original_position":66,"commit_id":"f1e9f29aa634e5082e9c72e3feb0adf2ea4155b6","original_commit_id":"f1e9f29aa634e5082e9c72e3feb0adf2ea4155b6","user":{"login":"petmac","id":481142,"avatar_url":"https://avatars1.githubusercontent.com/u/481142?v=4","gravatar_id":"","url":"https://api.github.com/users/petmac","html_url":"https://github.com/petmac","followers_url":"https://api.github.com/users/petmac/followers","following_url":"https://api.github.com/users/petmac/following{/other_user}","gists_url":"https://api.github.com/users/petmac/gists{/gist_id}","starred_url":"https://api.github.com/users/petmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petmac/subscriptions","organizations_url":"https://api.github.com/users/petmac/orgs","repos_url":"https://api.github.com/users/petmac/repos","events_url":"https://api.github.com/users/petmac/events{/privacy}","received_events_url":"https://api.github.com/users/petmac/received_events","type":"User","site_admin":false},"body":"This should probably take another argument -- the pref path.","created_at":"2018-05-28T15:32:53Z","updated_at":"2018-05-28T15:33:51Z","html_url":"https://github.com/Vita3K/Vita3K/pull/254#discussion_r191233848","pull_request_url":"https://api.github.com/repos/Vita3K/Vita3K/pulls/254","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Vita3K/Vita3K/pulls/comments/191233848"},"html":{"href":"https://github.com/Vita3K/Vita3K/pull/254#discussion_r191233848"},"pull_request":{"href":"https://api.github.com/repos/Vita3K/Vita3K/pulls/254"}}},"pull_request":{"url":"https://api.github.com/repos/Vita3K/Vita3K/pulls/254","id":188289201,"html_url":"https://github.com/Vita3K/Vita3K/pull/254","diff_url":"https://github.com/Vita3K/Vita3K/pull/254.diff","patch_url":"https://github.com/Vita3K/Vita3K/pull/254.patch","issue_url":"https://api.github.com/repos/Vita3K/Vita3K/issues/254","number":254,"state":"open","locked":false,"title":"Dump shaders in a separate directory","user":{"login":"GusAndrianos","id":17255848,"avatar_url":"https://avatars2.githubusercontent.com/u/17255848?v=4","gravatar_id":"","url":"https://api.github.com/users/GusAndrianos","html_url":"https://github.com/GusAndrianos","followers_url":"https://api.github.com/users/GusAndrianos/followers","following_url":"https://api.github.com/users/GusAndrianos/following{/other_user}","gists_url":"https://api.github.com/users/GusAndrianos/gists{/gist_id}","starred_url":"https://api.github.com/users/GusAndrianos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GusAndrianos/subscriptions","organizations_url":"https://api.github.com/users/GusAndrianos/orgs","repos_url":"https://api.github.com/users/GusAndrianos/repos","events_url":"https://api.github.com/users/GusAndrianos/events{/privacy}","received_events_url":"https://api.github.com/users/GusAndrianos/received_events","type":"User","site_admin":false},"body":"Resolves #228 ","created_at":"2018-05-16T00:19:30Z","updated_at":"2018-05-28T15:33:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a0da91ec4174dc3a8e15c9c17adde6835948e42","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Vita3K/Vita3K/pulls/254/commits","review_comments_url":"https://api.github.com/repos/Vita3K/Vita3K/pulls/254/comments","review_comment_url":"https://api.github.com/repos/Vita3K/Vita3K/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vita3K/Vita3K/issues/254/comments","statuses_url":"https://api.github.com/repos/Vita3K/Vita3K/statuses/f1e9f29aa634e5082e9c72e3feb0adf2ea4155b6","head":{"label":"GusAndrianos:fixShadersDump","ref":"fixShadersDump","sha":"f1e9f29aa634e5082e9c72e3feb0adf2ea4155b6","user":{"login":"GusAndrianos","id":17255848,"avatar_url":"https://avatars2.githubusercontent.com/u/17255848?v=4","gravatar_id":"","url":"https://api.github.com/users/GusAndrianos","html_url":"https://github.com/GusAndrianos","followers_url":"https://api.github.com/users/GusAndrianos/followers","following_url":"https://api.github.com/users/GusAndrianos/following{/other_user}","gists_url":"https://api.github.com/users/GusAndrianos/gists{/gist_id}","starred_url":"https://api.github.com/users/GusAndrianos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GusAndrianos/subscriptions","organizations_url":"https://api.github.com/users/GusAndrianos/orgs","repos_url":"https://api.github.com/users/GusAndrianos/repos","events_url":"https://api.github.com/users/GusAndrianos/events{/privacy}","received_events_url":"https://api.github.com/users/GusAndrianos/received_events","type":"User","site_admin":false},"repo":{"id":133091374,"name":"Vita3K","full_name":"GusAndrianos/Vita3K","owner":{"login":"GusAndrianos","id":17255848,"avatar_url":"https://avatars2.githubusercontent.com/u/17255848?v=4","gravatar_id":"","url":"https://api.github.com/users/GusAndrianos","html_url":"https://github.com/GusAndrianos","followers_url":"https://api.github.com/users/GusAndrianos/followers","following_url":"https://api.github.com/users/GusAndrianos/following{/other_user}","gists_url":"https://api.github.com/users/GusAndrianos/gists{/gist_id}","starred_url":"https://api.github.com/users/GusAndrianos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GusAndrianos/subscriptions","organizations_url":"https://api.github.com/users/GusAndrianos/orgs","repos_url":"https://api.github.com/users/GusAndrianos/repos","events_url":"https://api.github.com/users/GusAndrianos/events{/privacy}","received_events_url":"https://api.github.com/users/GusAndrianos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GusAndrianos/Vita3K","description":"Experimental PlayStation Vita emulator","fork":true,"url":"https://api.github.com/repos/GusAndrianos/Vita3K","forks_url":"https://api.github.com/repos/GusAndrianos/Vita3K/forks","keys_url":"https://api.github.com/repos/GusAndrianos/Vita3K/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GusAndrianos/Vita3K/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GusAndrianos/Vita3K/teams","hooks_url":"https://api.github.com/repos/GusAndrianos/Vita3K/hooks","issue_events_url":"https://api.github.com/repos/GusAndrianos/Vita3K/issues/events{/number}","events_url":"https://api.github.com/repos/GusAndrianos/Vita3K/events","assignees_url":"https://api.github.com/repos/GusAndrianos/Vita3K/assignees{/user}","branches_url":"https://api.github.com/repos/GusAndrianos/Vita3K/branches{/branch}","tags_url":"https://api.github.com/repos/GusAndrianos/Vita3K/tags","blobs_url":"https://api.github.com/repos/GusAndrianos/Vita3K/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GusAndrianos/Vita3K/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GusAndrianos/Vita3K/git/refs{/sha}","trees_url":"https://api.github.com/repos/GusAndrianos/Vita3K/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GusAndrianos/Vita3K/statuses/{sha}","languages_url":"https://api.github.com/repos/GusAndrianos/Vita3K/languages","stargazers_url":"https://api.github.com/repos/GusAndrianos/Vita3K/stargazers","contributors_url":"https://api.github.com/repos/GusAndrianos/Vita3K/contributors","subscribers_url":"https://api.github.com/repos/GusAndrianos/Vita3K/subscribers","subscription_url":"https://api.github.com/repos/GusAndrianos/Vita3K/subscription","commits_url":"https://api.github.com/repos/GusAndrianos/Vita3K/commits{/sha}","git_commits_url":"https://api.github.com/repos/GusAndrianos/Vita3K/git/commits{/sha}","comments_url":"https://api.github.com/repos/GusAndrianos/Vita3K/comments{/number}","issue_comment_url":"https://api.github.com/repos/GusAndrianos/Vita3K/issues/comments{/number}","contents_url":"https://api.github.com/repos/GusAndrianos/Vita3K/contents/{+path}","compare_url":"https://api.github.com/repos/GusAndrianos/Vita3K/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GusAndrianos/Vita3K/merges","archive_url":"https://api.github.com/repos/GusAndrianos/Vita3K/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GusAndrianos/Vita3K/downloads","issues_url":"https://api.github.com/repos/GusAndrianos/Vita3K/issues{/number}","pulls_url":"https://api.github.com/repos/GusAndrianos/Vita3K/pulls{/number}","milestones_url":"https://api.github.com/repos/GusAndrianos/Vita3K/milestones{/number}","notifications_url":"https://api.github.com/repos/GusAndrianos/Vita3K/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GusAndrianos/Vita3K/labels{/name}","releases_url":"https://api.github.com/repos/GusAndrianos/Vita3K/releases{/id}","deployments_url":"https://api.github.com/repos/GusAndrianos/Vita3K/deployments","created_at":"2018-05-11T21:43:51Z","updated_at":"2018-05-11T21:43:53Z","pushed_at":"2018-05-23T02:28:08Z","git_url":"git://github.com/GusAndrianos/Vita3K.git","ssh_url":"git@github.com:GusAndrianos/Vita3K.git","clone_url":"https://github.com/GusAndrianos/Vita3K.git","svn_url":"https://github.com/GusAndrianos/Vita3K","homepage":"https://Vita3K.github.io/","size":57688,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Vita3K:master","ref":"master","sha":"233b01d17800f5a5f26208146f4e54bcd49e9725","user":{"login":"Vita3K","id":34121543,"avatar_url":"https://avatars1.githubusercontent.com/u/34121543?v=4","gravatar_id":"","url":"https://api.github.com/users/Vita3K","html_url":"https://github.com/Vita3K","followers_url":"https://api.github.com/users/Vita3K/followers","following_url":"https://api.github.com/users/Vita3K/following{/other_user}","gists_url":"https://api.github.com/users/Vita3K/gists{/gist_id}","starred_url":"https://api.github.com/users/Vita3K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vita3K/subscriptions","organizations_url":"https://api.github.com/users/Vita3K/orgs","repos_url":"https://api.github.com/users/Vita3K/repos","events_url":"https://api.github.com/users/Vita3K/events{/privacy}","received_events_url":"https://api.github.com/users/Vita3K/received_events","type":"Organization","site_admin":false},"repo":{"id":119111364,"name":"Vita3K","full_name":"Vita3K/Vita3K","owner":{"login":"Vita3K","id":34121543,"avatar_url":"https://avatars1.githubusercontent.com/u/34121543?v=4","gravatar_id":"","url":"https://api.github.com/users/Vita3K","html_url":"https://github.com/Vita3K","followers_url":"https://api.github.com/users/Vita3K/followers","following_url":"https://api.github.com/users/Vita3K/following{/other_user}","gists_url":"https://api.github.com/users/Vita3K/gists{/gist_id}","starred_url":"https://api.github.com/users/Vita3K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vita3K/subscriptions","organizations_url":"https://api.github.com/users/Vita3K/orgs","repos_url":"https://api.github.com/users/Vita3K/repos","events_url":"https://api.github.com/users/Vita3K/events{/privacy}","received_events_url":"https://api.github.com/users/Vita3K/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vita3K/Vita3K","description":"Experimental PlayStation Vita emulator","fork":false,"url":"https://api.github.com/repos/Vita3K/Vita3K","forks_url":"https://api.github.com/repos/Vita3K/Vita3K/forks","keys_url":"https://api.github.com/repos/Vita3K/Vita3K/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vita3K/Vita3K/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vita3K/Vita3K/teams","hooks_url":"https://api.github.com/repos/Vita3K/Vita3K/hooks","issue_events_url":"https://api.github.com/repos/Vita3K/Vita3K/issues/events{/number}","events_url":"https://api.github.com/repos/Vita3K/Vita3K/events","assignees_url":"https://api.github.com/repos/Vita3K/Vita3K/assignees{/user}","branches_url":"https://api.github.com/repos/Vita3K/Vita3K/branches{/branch}","tags_url":"https://api.github.com/repos/Vita3K/Vita3K/tags","blobs_url":"https://api.github.com/repos/Vita3K/Vita3K/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vita3K/Vita3K/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vita3K/Vita3K/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vita3K/Vita3K/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vita3K/Vita3K/statuses/{sha}","languages_url":"https://api.github.com/repos/Vita3K/Vita3K/languages","stargazers_url":"https://api.github.com/repos/Vita3K/Vita3K/stargazers","contributors_url":"https://api.github.com/repos/Vita3K/Vita3K/contributors","subscribers_url":"https://api.github.com/repos/Vita3K/Vita3K/subscribers","subscription_url":"https://api.github.com/repos/Vita3K/Vita3K/subscription","commits_url":"https://api.github.com/repos/Vita3K/Vita3K/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vita3K/Vita3K/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vita3K/Vita3K/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vita3K/Vita3K/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vita3K/Vita3K/contents/{+path}","compare_url":"https://api.github.com/repos/Vita3K/Vita3K/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vita3K/Vita3K/merges","archive_url":"https://api.github.com/repos/Vita3K/Vita3K/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vita3K/Vita3K/downloads","issues_url":"https://api.github.com/repos/Vita3K/Vita3K/issues{/number}","pulls_url":"https://api.github.com/repos/Vita3K/Vita3K/pulls{/number}","milestones_url":"https://api.github.com/repos/Vita3K/Vita3K/milestones{/number}","notifications_url":"https://api.github.com/repos/Vita3K/Vita3K/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vita3K/Vita3K/labels{/name}","releases_url":"https://api.github.com/repos/Vita3K/Vita3K/releases{/id}","deployments_url":"https://api.github.com/repos/Vita3K/Vita3K/deployments","created_at":"2018-01-26T22:45:05Z","updated_at":"2018-05-28T09:26:36Z","pushed_at":"2018-05-28T12:14:01Z","git_url":"git://github.com/Vita3K/Vita3K.git","ssh_url":"git@github.com:Vita3K/Vita3K.git","clone_url":"https://github.com/Vita3K/Vita3K.git","svn_url":"https://github.com/Vita3K/Vita3K","homepage":"https://Vita3K.github.io/","size":57714,"stargazers_count":500,"watchers_count":500,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":57,"open_issues":49,"watchers":500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vita3K/Vita3K/pulls/254"},"html":{"href":"https://github.com/Vita3K/Vita3K/pull/254"},"issue":{"href":"https://api.github.com/repos/Vita3K/Vita3K/issues/254"},"comments":{"href":"https://api.github.com/repos/Vita3K/Vita3K/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/Vita3K/Vita3K/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/Vita3K/Vita3K/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vita3K/Vita3K/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/Vita3K/Vita3K/statuses/f1e9f29aa634e5082e9c72e3feb0adf2ea4155b6"}},"author_association":"NONE"}}
{"actor":{"display_login":"petmac"}}