{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/web3.js/issues/2125","repository_url":"https://api.github.com/repos/ethereum/web3.js","labels_url":"https://api.github.com/repos/ethereum/web3.js/issues/2125/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/web3.js/issues/2125/comments","events_url":"https://api.github.com/repos/ethereum/web3.js/issues/2125/events","html_url":"https://github.com/ethereum/web3.js/pull/2125","id":391300147,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODU5Mjg1","number":2125,"title":"Web3 bzz types","user":{"login":"joshstevens19","id":18472422,"node_id":"MDQ6VXNlcjE4NDcyNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/18472422?v=4","gravatar_id":"","url":"https://api.github.com/users/joshstevens19","html_url":"https://github.com/joshstevens19","followers_url":"https://api.github.com/users/joshstevens19/followers","following_url":"https://api.github.com/users/joshstevens19/following{/other_user}","gists_url":"https://api.github.com/users/joshstevens19/gists{/gist_id}","starred_url":"https://api.github.com/users/joshstevens19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshstevens19/subscriptions","organizations_url":"https://api.github.com/users/joshstevens19/orgs","repos_url":"https://api.github.com/users/joshstevens19/repos","events_url":"https://api.github.com/users/joshstevens19/events{/privacy}","received_events_url":"https://api.github.com/users/joshstevens19/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-14T22:26:11Z","updated_at":"2018-12-17T07:45:02Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ethereum/web3.js/pulls/2125","html_url":"https://github.com/ethereum/web3.js/pull/2125","diff_url":"https://github.com/ethereum/web3.js/pull/2125.diff","patch_url":"https://github.com/ethereum/web3.js/pull/2125.patch"},"body":"web3-bzz types - as they have no dependencies on shared web3-core + web3-provider i have kept them loosely typed. \r\n\r\nThis should really have a dependency on `web3-providers` if we could put that dependency on we could strongly type most of this without repeating typings? I think it should also inherit `AbstractWeb3Module` as well on the Bzz class. \r\n\r\nThis is why i decided to keep it loosely typed, if we can have a discussion on the above to bring these dependencies in then that would be great.\r\n\r\n👍 "},"comment":{"url":"https://api.github.com/repos/ethereum/web3.js/issues/comments/447751046","html_url":"https://github.com/ethereum/web3.js/pull/2125#issuecomment-447751046","issue_url":"https://api.github.com/repos/ethereum/web3.js/issues/2125","id":447751046,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzc1MTA0Ng==","user":{"login":"nivida","id":1699173,"node_id":"MDQ6VXNlcjE2OTkxNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1699173?v=4","gravatar_id":"","url":"https://api.github.com/users/nivida","html_url":"https://github.com/nivida","followers_url":"https://api.github.com/users/nivida/followers","following_url":"https://api.github.com/users/nivida/following{/other_user}","gists_url":"https://api.github.com/users/nivida/gists{/gist_id}","starred_url":"https://api.github.com/users/nivida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nivida/subscriptions","organizations_url":"https://api.github.com/users/nivida/orgs","repos_url":"https://api.github.com/users/nivida/repos","events_url":"https://api.github.com/users/nivida/events{/privacy}","received_events_url":"https://api.github.com/users/nivida/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T07:45:02Z","updated_at":"2018-12-17T07:45:02Z","author_association":"COLLABORATOR","body":"@justelad Yes, what's your username in the EF discord?"}}
{"actor":{"display_login":"nivida"}}