{"action":"created","comment":{"url":"https://api.github.com/repos/jsreport/jsreport-express/pulls/comments/197818182","pull_request_review_id":131634671,"id":197818182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzgxODE4Mg==","diff_hunk":"@@ -159,15 +162,20 @@ var configureExpressApp = function (app, reporter, definition) {\n     next()\r\n   })\r\n \r\n-  reporter.emit('before-express-configure', app)\r\n+  reporter.emit('before-express-configure', baseApp)\r\n \r\n-  routes(app, reporter)\r\n+  routes(baseApp, reporter)\r\n \r\n-  reporter.emit('express-configure', app)\r\n+  reporter.emit('express-configure', baseApp)\r\n \r\n   const handleErrorMiddleware = handleError(reporter)\r\n \r\n-  app.use((err, req, res, next) => handleErrorMiddleware(req, res, err))\r\n+  baseApp.use((err, req, res, next) => handleErrorMiddleware(req, res, err))\r\n+\r\n+  if (reporter.options.subPath) {\r\n+    app.use(reporter.options.subPath, baseApp)\r\n+    reporter.express.app = app\r","path":"lib/reporter.express.js","position":69,"original_position":69,"commit_id":"2328949be4bb2e1fcbb0e8b72d306e31c2b4f92e","original_commit_id":"2328949be4bb2e1fcbb0e8b72d306e31c2b4f92e","user":{"login":"bjrmatos","id":4262050,"node_id":"MDQ6VXNlcjQyNjIwNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4262050?v=4","gravatar_id":"","url":"https://api.github.com/users/bjrmatos","html_url":"https://github.com/bjrmatos","followers_url":"https://api.github.com/users/bjrmatos/followers","following_url":"https://api.github.com/users/bjrmatos/following{/other_user}","gists_url":"https://api.github.com/users/bjrmatos/gists{/gist_id}","starred_url":"https://api.github.com/users/bjrmatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjrmatos/subscriptions","organizations_url":"https://api.github.com/users/bjrmatos/orgs","repos_url":"https://api.github.com/users/bjrmatos/repos","events_url":"https://api.github.com/users/bjrmatos/events{/privacy}","received_events_url":"https://api.github.com/users/bjrmatos/received_events","type":"User","site_admin":false},"body":"finally, as i say in original review, we don't like that `reporter.express.app` is changed to different things. so this line should be removed, we think that with `baseApp` is enough and it should be the only thing exposed (both in events and in reporter.express.app)","created_at":"2018-06-25T14:30:10Z","updated_at":"2018-06-25T14:30:43Z","html_url":"https://github.com/jsreport/jsreport-express/pull/9#discussion_r197818182","pull_request_url":"https://api.github.com/repos/jsreport/jsreport-express/pulls/9","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/jsreport/jsreport-express/pulls/comments/197818182"},"html":{"href":"https://github.com/jsreport/jsreport-express/pull/9#discussion_r197818182"},"pull_request":{"href":"https://api.github.com/repos/jsreport/jsreport-express/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/jsreport/jsreport-express/pulls/9","id":194878515,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODc4NTE1","html_url":"https://github.com/jsreport/jsreport-express/pull/9","diff_url":"https://github.com/jsreport/jsreport-express/pull/9.diff","patch_url":"https://github.com/jsreport/jsreport-express/pull/9.patch","issue_url":"https://api.github.com/repos/jsreport/jsreport-express/issues/9","number":9,"state":"open","locked":false,"title":"subPath config for express base uri","user":{"login":"sguesdon","id":6231084,"node_id":"MDQ6VXNlcjYyMzEwODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6231084?v=4","gravatar_id":"","url":"https://api.github.com/users/sguesdon","html_url":"https://github.com/sguesdon","followers_url":"https://api.github.com/users/sguesdon/followers","following_url":"https://api.github.com/users/sguesdon/following{/other_user}","gists_url":"https://api.github.com/users/sguesdon/gists{/gist_id}","starred_url":"https://api.github.com/users/sguesdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguesdon/subscriptions","organizations_url":"https://api.github.com/users/sguesdon/orgs","repos_url":"https://api.github.com/users/sguesdon/repos","events_url":"https://api.github.com/users/sguesdon/events{/privacy}","received_events_url":"https://api.github.com/users/sguesdon/received_events","type":"User","site_admin":false},"body":"it close #8 issue\r\n","created_at":"2018-06-14T12:35:49Z","updated_at":"2018-06-25T14:30:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cc0a0e817a74c41bf7f2071c3702592a17a5c1f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jsreport/jsreport-express/pulls/9/commits","review_comments_url":"https://api.github.com/repos/jsreport/jsreport-express/pulls/9/comments","review_comment_url":"https://api.github.com/repos/jsreport/jsreport-express/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsreport/jsreport-express/issues/9/comments","statuses_url":"https://api.github.com/repos/jsreport/jsreport-express/statuses/2328949be4bb2e1fcbb0e8b72d306e31c2b4f92e","head":{"label":"NRCO:master","ref":"master","sha":"2328949be4bb2e1fcbb0e8b72d306e31c2b4f92e","user":{"login":"NRCO","id":28102922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTAyOTIy","avatar_url":"https://avatars1.githubusercontent.com/u/28102922?v=4","gravatar_id":"","url":"https://api.github.com/users/NRCO","html_url":"https://github.com/NRCO","followers_url":"https://api.github.com/users/NRCO/followers","following_url":"https://api.github.com/users/NRCO/following{/other_user}","gists_url":"https://api.github.com/users/NRCO/gists{/gist_id}","starred_url":"https://api.github.com/users/NRCO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NRCO/subscriptions","organizations_url":"https://api.github.com/users/NRCO/orgs","repos_url":"https://api.github.com/users/NRCO/repos","events_url":"https://api.github.com/users/NRCO/events{/privacy}","received_events_url":"https://api.github.com/users/NRCO/received_events","type":"Organization","site_admin":false},"repo":{"id":137136964,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMzY5NjQ=","name":"jsreport-express","full_name":"NRCO/jsreport-express","owner":{"login":"NRCO","id":28102922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTAyOTIy","avatar_url":"https://avatars1.githubusercontent.com/u/28102922?v=4","gravatar_id":"","url":"https://api.github.com/users/NRCO","html_url":"https://github.com/NRCO","followers_url":"https://api.github.com/users/NRCO/followers","following_url":"https://api.github.com/users/NRCO/following{/other_user}","gists_url":"https://api.github.com/users/NRCO/gists{/gist_id}","starred_url":"https://api.github.com/users/NRCO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NRCO/subscriptions","organizations_url":"https://api.github.com/users/NRCO/orgs","repos_url":"https://api.github.com/users/NRCO/repos","events_url":"https://api.github.com/users/NRCO/events{/privacy}","received_events_url":"https://api.github.com/users/NRCO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NRCO/jsreport-express","description":"jsreport extension adding API and studio","fork":true,"url":"https://api.github.com/repos/NRCO/jsreport-express","forks_url":"https://api.github.com/repos/NRCO/jsreport-express/forks","keys_url":"https://api.github.com/repos/NRCO/jsreport-express/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NRCO/jsreport-express/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NRCO/jsreport-express/teams","hooks_url":"https://api.github.com/repos/NRCO/jsreport-express/hooks","issue_events_url":"https://api.github.com/repos/NRCO/jsreport-express/issues/events{/number}","events_url":"https://api.github.com/repos/NRCO/jsreport-express/events","assignees_url":"https://api.github.com/repos/NRCO/jsreport-express/assignees{/user}","branches_url":"https://api.github.com/repos/NRCO/jsreport-express/branches{/branch}","tags_url":"https://api.github.com/repos/NRCO/jsreport-express/tags","blobs_url":"https://api.github.com/repos/NRCO/jsreport-express/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NRCO/jsreport-express/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NRCO/jsreport-express/git/refs{/sha}","trees_url":"https://api.github.com/repos/NRCO/jsreport-express/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NRCO/jsreport-express/statuses/{sha}","languages_url":"https://api.github.com/repos/NRCO/jsreport-express/languages","stargazers_url":"https://api.github.com/repos/NRCO/jsreport-express/stargazers","contributors_url":"https://api.github.com/repos/NRCO/jsreport-express/contributors","subscribers_url":"https://api.github.com/repos/NRCO/jsreport-express/subscribers","subscription_url":"https://api.github.com/repos/NRCO/jsreport-express/subscription","commits_url":"https://api.github.com/repos/NRCO/jsreport-express/commits{/sha}","git_commits_url":"https://api.github.com/repos/NRCO/jsreport-express/git/commits{/sha}","comments_url":"https://api.github.com/repos/NRCO/jsreport-express/comments{/number}","issue_comment_url":"https://api.github.com/repos/NRCO/jsreport-express/issues/comments{/number}","contents_url":"https://api.github.com/repos/NRCO/jsreport-express/contents/{+path}","compare_url":"https://api.github.com/repos/NRCO/jsreport-express/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NRCO/jsreport-express/merges","archive_url":"https://api.github.com/repos/NRCO/jsreport-express/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NRCO/jsreport-express/downloads","issues_url":"https://api.github.com/repos/NRCO/jsreport-express/issues{/number}","pulls_url":"https://api.github.com/repos/NRCO/jsreport-express/pulls{/number}","milestones_url":"https://api.github.com/repos/NRCO/jsreport-express/milestones{/number}","notifications_url":"https://api.github.com/repos/NRCO/jsreport-express/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NRCO/jsreport-express/labels{/name}","releases_url":"https://api.github.com/repos/NRCO/jsreport-express/releases{/id}","deployments_url":"https://api.github.com/repos/NRCO/jsreport-express/deployments","created_at":"2018-06-12T23:08:01Z","updated_at":"2018-06-25T08:25:03Z","pushed_at":"2018-06-25T08:25:02Z","git_url":"git://github.com/NRCO/jsreport-express.git","ssh_url":"git@github.com:NRCO/jsreport-express.git","clone_url":"https://github.com/NRCO/jsreport-express.git","svn_url":"https://github.com/NRCO/jsreport-express","homepage":"https://jsreport.net/learn/api","size":4283,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jsreport:master","ref":"master","sha":"59014913bfa0c9512975593cf201177f57d6dbf6","user":{"login":"jsreport","id":3989182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODkxODI=","avatar_url":"https://avatars2.githubusercontent.com/u/3989182?v=4","gravatar_id":"","url":"https://api.github.com/users/jsreport","html_url":"https://github.com/jsreport","followers_url":"https://api.github.com/users/jsreport/followers","following_url":"https://api.github.com/users/jsreport/following{/other_user}","gists_url":"https://api.github.com/users/jsreport/gists{/gist_id}","starred_url":"https://api.github.com/users/jsreport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsreport/subscriptions","organizations_url":"https://api.github.com/users/jsreport/orgs","repos_url":"https://api.github.com/users/jsreport/repos","events_url":"https://api.github.com/users/jsreport/events{/privacy}","received_events_url":"https://api.github.com/users/jsreport/received_events","type":"Organization","site_admin":false},"repo":{"id":45617981,"node_id":"MDEwOlJlcG9zaXRvcnk0NTYxNzk4MQ==","name":"jsreport-express","full_name":"jsreport/jsreport-express","owner":{"login":"jsreport","id":3989182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODkxODI=","avatar_url":"https://avatars2.githubusercontent.com/u/3989182?v=4","gravatar_id":"","url":"https://api.github.com/users/jsreport","html_url":"https://github.com/jsreport","followers_url":"https://api.github.com/users/jsreport/followers","following_url":"https://api.github.com/users/jsreport/following{/other_user}","gists_url":"https://api.github.com/users/jsreport/gists{/gist_id}","starred_url":"https://api.github.com/users/jsreport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsreport/subscriptions","organizations_url":"https://api.github.com/users/jsreport/orgs","repos_url":"https://api.github.com/users/jsreport/repos","events_url":"https://api.github.com/users/jsreport/events{/privacy}","received_events_url":"https://api.github.com/users/jsreport/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsreport/jsreport-express","description":"jsreport extension adding API and studio","fork":false,"url":"https://api.github.com/repos/jsreport/jsreport-express","forks_url":"https://api.github.com/repos/jsreport/jsreport-express/forks","keys_url":"https://api.github.com/repos/jsreport/jsreport-express/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsreport/jsreport-express/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsreport/jsreport-express/teams","hooks_url":"https://api.github.com/repos/jsreport/jsreport-express/hooks","issue_events_url":"https://api.github.com/repos/jsreport/jsreport-express/issues/events{/number}","events_url":"https://api.github.com/repos/jsreport/jsreport-express/events","assignees_url":"https://api.github.com/repos/jsreport/jsreport-express/assignees{/user}","branches_url":"https://api.github.com/repos/jsreport/jsreport-express/branches{/branch}","tags_url":"https://api.github.com/repos/jsreport/jsreport-express/tags","blobs_url":"https://api.github.com/repos/jsreport/jsreport-express/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsreport/jsreport-express/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsreport/jsreport-express/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsreport/jsreport-express/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsreport/jsreport-express/statuses/{sha}","languages_url":"https://api.github.com/repos/jsreport/jsreport-express/languages","stargazers_url":"https://api.github.com/repos/jsreport/jsreport-express/stargazers","contributors_url":"https://api.github.com/repos/jsreport/jsreport-express/contributors","subscribers_url":"https://api.github.com/repos/jsreport/jsreport-express/subscribers","subscription_url":"https://api.github.com/repos/jsreport/jsreport-express/subscription","commits_url":"https://api.github.com/repos/jsreport/jsreport-express/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsreport/jsreport-express/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsreport/jsreport-express/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsreport/jsreport-express/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsreport/jsreport-express/contents/{+path}","compare_url":"https://api.github.com/repos/jsreport/jsreport-express/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsreport/jsreport-express/merges","archive_url":"https://api.github.com/repos/jsreport/jsreport-express/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsreport/jsreport-express/downloads","issues_url":"https://api.github.com/repos/jsreport/jsreport-express/issues{/number}","pulls_url":"https://api.github.com/repos/jsreport/jsreport-express/pulls{/number}","milestones_url":"https://api.github.com/repos/jsreport/jsreport-express/milestones{/number}","notifications_url":"https://api.github.com/repos/jsreport/jsreport-express/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsreport/jsreport-express/labels{/name}","releases_url":"https://api.github.com/repos/jsreport/jsreport-express/releases{/id}","deployments_url":"https://api.github.com/repos/jsreport/jsreport-express/deployments","created_at":"2015-11-05T14:54:11Z","updated_at":"2018-06-19T09:17:22Z","pushed_at":"2018-06-25T08:25:03Z","git_url":"git://github.com/jsreport/jsreport-express.git","ssh_url":"git@github.com:jsreport/jsreport-express.git","clone_url":"https://github.com/jsreport/jsreport-express.git","svn_url":"https://github.com/jsreport/jsreport-express","homepage":"https://jsreport.net/learn/api","size":4239,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":2,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsreport/jsreport-express/pulls/9"},"html":{"href":"https://github.com/jsreport/jsreport-express/pull/9"},"issue":{"href":"https://api.github.com/repos/jsreport/jsreport-express/issues/9"},"comments":{"href":"https://api.github.com/repos/jsreport/jsreport-express/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/jsreport/jsreport-express/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/jsreport/jsreport-express/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsreport/jsreport-express/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/jsreport/jsreport-express/statuses/2328949be4bb2e1fcbb0e8b72d306e31c2b4f92e"}},"author_association":"NONE"}}
{"actor":{"display_login":"bjrmatos"}}