{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/209322555","pull_request_review_id":145320503,"id":209322555,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTMyMjU1NQ==","diff_hunk":"@@ -223,4 +224,16 @@ class TestNSDateComponents: XCTestCase {\n         XCTAssertEqual(components.hour, 12)\n         XCTAssertEqual(copy.hour, 14)\n     }\n+\n+    func test_dateDifferenceComponents() {\n+        let date1 = Date(timeIntervalSince1970: 0)\n+\n+        // 1971-06-21\n+        let date2 = Date(timeIntervalSince1970:  46310400)\n+        let difference = Calendar.current.dateComponents([.month, .year, .day], from: date1, to: date2)","path":"TestFoundation/TestCalendar.swift","position":18,"original_position":18,"commit_id":"2c06ffd2bd6cf1650b7500f0e006cbdcd5c04f96","original_commit_id":"2c06ffd2bd6cf1650b7500f0e006cbdcd5c04f96","user":{"login":"itaiferber","id":33716,"node_id":"MDQ6VXNlcjMzNzE2","avatar_url":"https://avatars3.githubusercontent.com/u/33716?v=4","gravatar_id":"","url":"https://api.github.com/users/itaiferber","html_url":"https://github.com/itaiferber","followers_url":"https://api.github.com/users/itaiferber/followers","following_url":"https://api.github.com/users/itaiferber/following{/other_user}","gists_url":"https://api.github.com/users/itaiferber/gists{/gist_id}","starred_url":"https://api.github.com/users/itaiferber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itaiferber/subscriptions","organizations_url":"https://api.github.com/users/itaiferber/orgs","repos_url":"https://api.github.com/users/itaiferber/repos","events_url":"https://api.github.com/users/itaiferber/events{/privacy}","received_events_url":"https://api.github.com/users/itaiferber/received_events","type":"User","site_admin":false},"body":"On Darwin we actually almost always add \"is leap month\" to `DateComponents` in output, if that's what you're referring to. (Leap months are also applicable in the Hebrew calendar, and otherwise.)","created_at":"2018-08-10T16:54:59Z","updated_at":"2018-08-10T16:54:59Z","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1658#discussion_r209322555","pull_request_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1658","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/209322555"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/1658#discussion_r209322555"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1658"}},"in_reply_to_id":209322247},"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1658","id":207652949,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjUyOTQ5","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1658","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/1658.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/1658.patch","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1658","number":1658,"state":"open","locked":false,"title":"SR-7011: Fatal Error when Using Calendar.current.dateComponents(_:from:to:)","user":{"login":"spevans","id":1093011,"node_id":"MDQ6VXNlcjEwOTMwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1093011?v=4","gravatar_id":"","url":"https://api.github.com/users/spevans","html_url":"https://github.com/spevans","followers_url":"https://api.github.com/users/spevans/followers","following_url":"https://api.github.com/users/spevans/following{/other_user}","gists_url":"https://api.github.com/users/spevans/gists{/gist_id}","starred_url":"https://api.github.com/users/spevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spevans/subscriptions","organizations_url":"https://api.github.com/users/spevans/orgs","repos_url":"https://api.github.com/users/spevans/repos","events_url":"https://api.github.com/users/spevans/events{/privacy}","received_events_url":"https://api.github.com/users/spevans/received_events","type":"User","site_admin":false},"body":"- _CFCalendarGetComponentDifferenceV() doesn't support a component\r\n  character of 'l' (leap year) as it make no sense for the difference\r\n  between two dates.\r\n\r\n- Dont add 'l' to the component string or parse the result into the\r\n  .isLeapMonth property when called from\r\n  NSCalendar.components(_:from:to:options)","created_at":"2018-08-10T15:50:09Z","updated_at":"2018-08-10T16:54:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"817f9a9ab599e4507d732c54ceb7b27410d01bb8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"itaiferber","id":33716,"node_id":"MDQ6VXNlcjMzNzE2","avatar_url":"https://avatars3.githubusercontent.com/u/33716?v=4","gravatar_id":"","url":"https://api.github.com/users/itaiferber","html_url":"https://github.com/itaiferber","followers_url":"https://api.github.com/users/itaiferber/followers","following_url":"https://api.github.com/users/itaiferber/following{/other_user}","gists_url":"https://api.github.com/users/itaiferber/gists{/gist_id}","starred_url":"https://api.github.com/users/itaiferber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itaiferber/subscriptions","organizations_url":"https://api.github.com/users/itaiferber/orgs","repos_url":"https://api.github.com/users/itaiferber/repos","events_url":"https://api.github.com/users/itaiferber/events{/privacy}","received_events_url":"https://api.github.com/users/itaiferber/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1658/commits","review_comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1658/comments","review_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1658/comments","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/2c06ffd2bd6cf1650b7500f0e006cbdcd5c04f96","head":{"label":"spevans:pr_sr_7011","ref":"pr_sr_7011","sha":"2c06ffd2bd6cf1650b7500f0e006cbdcd5c04f96","user":{"login":"spevans","id":1093011,"node_id":"MDQ6VXNlcjEwOTMwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1093011?v=4","gravatar_id":"","url":"https://api.github.com/users/spevans","html_url":"https://github.com/spevans","followers_url":"https://api.github.com/users/spevans/followers","following_url":"https://api.github.com/users/spevans/following{/other_user}","gists_url":"https://api.github.com/users/spevans/gists{/gist_id}","starred_url":"https://api.github.com/users/spevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spevans/subscriptions","organizations_url":"https://api.github.com/users/spevans/orgs","repos_url":"https://api.github.com/users/spevans/repos","events_url":"https://api.github.com/users/spevans/events{/privacy}","received_events_url":"https://api.github.com/users/spevans/received_events","type":"User","site_admin":false},"repo":{"id":64701801,"node_id":"MDEwOlJlcG9zaXRvcnk2NDcwMTgwMQ==","name":"swift-corelibs-foundation","full_name":"spevans/swift-corelibs-foundation","owner":{"login":"spevans","id":1093011,"node_id":"MDQ6VXNlcjEwOTMwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1093011?v=4","gravatar_id":"","url":"https://api.github.com/users/spevans","html_url":"https://github.com/spevans","followers_url":"https://api.github.com/users/spevans/followers","following_url":"https://api.github.com/users/spevans/following{/other_user}","gists_url":"https://api.github.com/users/spevans/gists{/gist_id}","starred_url":"https://api.github.com/users/spevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spevans/subscriptions","organizations_url":"https://api.github.com/users/spevans/orgs","repos_url":"https://api.github.com/users/spevans/repos","events_url":"https://api.github.com/users/spevans/events{/privacy}","received_events_url":"https://api.github.com/users/spevans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spevans/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":true,"url":"https://api.github.com/repos/spevans/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/deployments","created_at":"2016-08-01T21:09:21Z","updated_at":"2017-09-06T13:14:21Z","pushed_at":"2018-08-10T15:49:46Z","git_url":"git://github.com/spevans/swift-corelibs-foundation.git","ssh_url":"git@github.com:spevans/swift-corelibs-foundation.git","clone_url":"https://github.com/spevans/swift-corelibs-foundation.git","svn_url":"https://github.com/spevans/swift-corelibs-foundation","homepage":"swift.org","size":13016,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"a2b40951e8365da696d5105fd57a19c1f1c220ef","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":45863890,"node_id":"MDEwOlJlcG9zaXRvcnk0NTg2Mzg5MA==","name":"swift-corelibs-foundation","full_name":"apple/swift-corelibs-foundation","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":false,"url":"https://api.github.com/repos/apple/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/deployments","created_at":"2015-11-09T20:12:23Z","updated_at":"2018-08-09T02:40:05Z","pushed_at":"2018-08-10T15:50:10Z","git_url":"git://github.com/apple/swift-corelibs-foundation.git","ssh_url":"git@github.com:apple/swift-corelibs-foundation.git","clone_url":"https://github.com/apple/swift-corelibs-foundation.git","svn_url":"https://github.com/apple/swift-corelibs-foundation","homepage":"swift.org","size":13349,"stargazers_count":3056,"watchers_count":3056,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":735,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":735,"open_issues":37,"watchers":3056,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1658"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/1658"},"issue":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1658"},"comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1658/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1658/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1658/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/2c06ffd2bd6cf1650b7500f0e006cbdcd5c04f96"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"itaiferber"}}