{"action":"created","issue":{"url":"https://api.github.com/repos/bitfinexcom/bitfinex-api-node/issues/388","repository_url":"https://api.github.com/repos/bitfinexcom/bitfinex-api-node","labels_url":"https://api.github.com/repos/bitfinexcom/bitfinex-api-node/issues/388/labels{/name}","comments_url":"https://api.github.com/repos/bitfinexcom/bitfinex-api-node/issues/388/comments","events_url":"https://api.github.com/repos/bitfinexcom/bitfinex-api-node/issues/388/events","html_url":"https://github.com/bitfinexcom/bitfinex-api-node/pull/388","id":356443357,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzAyNTY3","number":388,"title":"fix event onTrades not fired","user":{"login":"Alexandre-io","id":8135542,"node_id":"MDQ6VXNlcjgxMzU1NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/8135542?v=4","gravatar_id":"","url":"https://api.github.com/users/Alexandre-io","html_url":"https://github.com/Alexandre-io","followers_url":"https://api.github.com/users/Alexandre-io/followers","following_url":"https://api.github.com/users/Alexandre-io/following{/other_user}","gists_url":"https://api.github.com/users/Alexandre-io/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexandre-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexandre-io/subscriptions","organizations_url":"https://api.github.com/users/Alexandre-io/orgs","repos_url":"https://api.github.com/users/Alexandre-io/repos","events_url":"https://api.github.com/users/Alexandre-io/events{/privacy}","received_events_url":"https://api.github.com/users/Alexandre-io/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-09-03T10:16:41Z","updated_at":"2018-09-05T11:26:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bitfinexcom/bitfinex-api-node/pulls/388","html_url":"https://github.com/bitfinexcom/bitfinex-api-node/pull/388","diff_url":"https://github.com/bitfinexcom/bitfinex-api-node/pull/388.diff","patch_url":"https://github.com/bitfinexcom/bitfinex-api-node/pull/388.patch"},"body":"Since commit 46af2116fbc46a7aea4f51d053369ca620bee1ef, the `onTrades` function is no longer called."},"comment":{"url":"https://api.github.com/repos/bitfinexcom/bitfinex-api-node/issues/comments/418696396","html_url":"https://github.com/bitfinexcom/bitfinex-api-node/pull/388#issuecomment-418696396","issue_url":"https://api.github.com/repos/bitfinexcom/bitfinex-api-node/issues/388","id":418696396,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODY5NjM5Ng==","user":{"login":"TehCrucible","id":4597068,"node_id":"MDQ6VXNlcjQ1OTcwNjg=","avatar_url":"https://avatars3.githubusercontent.com/u/4597068?v=4","gravatar_id":"","url":"https://api.github.com/users/TehCrucible","html_url":"https://github.com/TehCrucible","followers_url":"https://api.github.com/users/TehCrucible/followers","following_url":"https://api.github.com/users/TehCrucible/following{/other_user}","gists_url":"https://api.github.com/users/TehCrucible/gists{/gist_id}","starred_url":"https://api.github.com/users/TehCrucible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TehCrucible/subscriptions","organizations_url":"https://api.github.com/users/TehCrucible/orgs","repos_url":"https://api.github.com/users/TehCrucible/repos","events_url":"https://api.github.com/users/TehCrucible/events{/privacy}","received_events_url":"https://api.github.com/users/TehCrucible/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T11:26:32Z","updated_at":"2018-09-05T11:26:32Z","author_association":"NONE","body":"Perhaps we're misunderstanding the intention?  I was under the impression that the methods `onTradeEntry` and `onTradeUpdate` were designed to listen for authenticated user trades? And that the `onTrades` method was for public, or \"all\" trades in a market?\r\n\r\nHowever your current master branch will process the initial public trades snapshot through `onTrades` and then all subsequent public and/or authenticated trades through the `onTradeEntry` and `onTradeUpdate` methods - as indicated by your output above.\r\n\r\nI would have assumed the better method would be to use `onTrades` for snapshot and all subsequent market trades and leave `onTradeUpdate` and `onTradeEntry` for authenticated user trades.  At least, that's the impression I got from the docs?\r\n\r\nHow things currently work, I would be forced to sort between my trades and market trades myself by filtering the output of `onTradeEntry` and `onTradeUpdate`."}}
{"actor":{"display_login":"TehCrucible"}}