{"action":"created","comment":{"url":"https://api.github.com/repos/dotkom/Nibble2/pulls/comments/216162368","pull_request_review_id":153586307,"id":216162368,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjE2MjM2OA==","diff_hunk":"@@ -63,40 +75,18 @@ export class LoginView extends React.Component {\n \n   disableKeyLogger() {\n     this.currentRfid = '';\n-    $(document).off(\"keypress\");\n+    document.removeEventListener('keypress', (...a) => this.handleKeyPress(...a));","path":"app/src/components/views/login.jsx","position":38,"original_position":38,"commit_id":"4bc3bb80578ca90a4141095d60ad55ca5c2f66ca","original_commit_id":"4bc3bb80578ca90a4141095d60ad55ca5c2f66ca","user":{"login":"FredrikAugust","id":7691547,"node_id":"MDQ6VXNlcjc2OTE1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7691547?v=4","gravatar_id":"","url":"https://api.github.com/users/FredrikAugust","html_url":"https://github.com/FredrikAugust","followers_url":"https://api.github.com/users/FredrikAugust/followers","following_url":"https://api.github.com/users/FredrikAugust/following{/other_user}","gists_url":"https://api.github.com/users/FredrikAugust/gists{/gist_id}","starred_url":"https://api.github.com/users/FredrikAugust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredrikAugust/subscriptions","organizations_url":"https://api.github.com/users/FredrikAugust/orgs","repos_url":"https://api.github.com/users/FredrikAugust/repos","events_url":"https://api.github.com/users/FredrikAugust/events{/privacy}","received_events_url":"https://api.github.com/users/FredrikAugust/received_events","type":"User","site_admin":false},"body":"Good point. Will extract 'em now and fixy-fixy.","created_at":"2018-09-09T16:45:06Z","updated_at":"2018-09-09T16:45:06Z","html_url":"https://github.com/dotkom/Nibble2/pull/69#discussion_r216162368","pull_request_url":"https://api.github.com/repos/dotkom/Nibble2/pulls/69","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotkom/Nibble2/pulls/comments/216162368"},"html":{"href":"https://github.com/dotkom/Nibble2/pull/69#discussion_r216162368"},"pull_request":{"href":"https://api.github.com/repos/dotkom/Nibble2/pulls/69"}},"in_reply_to_id":216161733},"pull_request":{"url":"https://api.github.com/repos/dotkom/Nibble2/pulls/69","id":214141795,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTQxNzk1","html_url":"https://github.com/dotkom/Nibble2/pull/69","diff_url":"https://github.com/dotkom/Nibble2/pull/69.diff","patch_url":"https://github.com/dotkom/Nibble2/pull/69.patch","issue_url":"https://api.github.com/repos/dotkom/Nibble2/issues/69","number":69,"state":"open","locked":false,"title":"Cleanup code in views","user":{"login":"FredrikAugust","id":7691547,"node_id":"MDQ6VXNlcjc2OTE1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7691547?v=4","gravatar_id":"","url":"https://api.github.com/users/FredrikAugust","html_url":"https://github.com/FredrikAugust","followers_url":"https://api.github.com/users/FredrikAugust/followers","following_url":"https://api.github.com/users/FredrikAugust/following{/other_user}","gists_url":"https://api.github.com/users/FredrikAugust/gists{/gist_id}","starred_url":"https://api.github.com/users/FredrikAugust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredrikAugust/subscriptions","organizations_url":"https://api.github.com/users/FredrikAugust/orgs","repos_url":"https://api.github.com/users/FredrikAugust/repos","events_url":"https://api.github.com/users/FredrikAugust/events{/privacy}","received_events_url":"https://api.github.com/users/FredrikAugust/received_events","type":"User","site_admin":false},"body":"Mainly just following eslint's complaints, but also ensuring consistent formatting. The `for..of` -> `.forEach/.map/.reduce` is due to (according to eslint) `for..of` requiring more resources to achieve the same as the array methods do (and there's not really any complexity added by changing).","created_at":"2018-09-09T11:56:20Z","updated_at":"2018-09-09T16:45:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bd27e49250146841f33632e141d999917f0b4a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotkom/Nibble2/pulls/69/commits","review_comments_url":"https://api.github.com/repos/dotkom/Nibble2/pulls/69/comments","review_comment_url":"https://api.github.com/repos/dotkom/Nibble2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotkom/Nibble2/issues/69/comments","statuses_url":"https://api.github.com/repos/dotkom/Nibble2/statuses/4bc3bb80578ca90a4141095d60ad55ca5c2f66ca","head":{"label":"FredrikAugust:cleanup","ref":"cleanup","sha":"4bc3bb80578ca90a4141095d60ad55ca5c2f66ca","user":{"login":"FredrikAugust","id":7691547,"node_id":"MDQ6VXNlcjc2OTE1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7691547?v=4","gravatar_id":"","url":"https://api.github.com/users/FredrikAugust","html_url":"https://github.com/FredrikAugust","followers_url":"https://api.github.com/users/FredrikAugust/followers","following_url":"https://api.github.com/users/FredrikAugust/following{/other_user}","gists_url":"https://api.github.com/users/FredrikAugust/gists{/gist_id}","starred_url":"https://api.github.com/users/FredrikAugust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredrikAugust/subscriptions","organizations_url":"https://api.github.com/users/FredrikAugust/orgs","repos_url":"https://api.github.com/users/FredrikAugust/repos","events_url":"https://api.github.com/users/FredrikAugust/events{/privacy}","received_events_url":"https://api.github.com/users/FredrikAugust/received_events","type":"User","site_admin":false},"repo":{"id":145585384,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU1ODUzODQ=","name":"Nibble2","full_name":"FredrikAugust/Nibble2","owner":{"login":"FredrikAugust","id":7691547,"node_id":"MDQ6VXNlcjc2OTE1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7691547?v=4","gravatar_id":"","url":"https://api.github.com/users/FredrikAugust","html_url":"https://github.com/FredrikAugust","followers_url":"https://api.github.com/users/FredrikAugust/followers","following_url":"https://api.github.com/users/FredrikAugust/following{/other_user}","gists_url":"https://api.github.com/users/FredrikAugust/gists{/gist_id}","starred_url":"https://api.github.com/users/FredrikAugust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredrikAugust/subscriptions","organizations_url":"https://api.github.com/users/FredrikAugust/orgs","repos_url":"https://api.github.com/users/FredrikAugust/repos","events_url":"https://api.github.com/users/FredrikAugust/events{/privacy}","received_events_url":"https://api.github.com/users/FredrikAugust/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FredrikAugust/Nibble2","description":"App for buying food and drinks.","fork":true,"url":"https://api.github.com/repos/FredrikAugust/Nibble2","forks_url":"https://api.github.com/repos/FredrikAugust/Nibble2/forks","keys_url":"https://api.github.com/repos/FredrikAugust/Nibble2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FredrikAugust/Nibble2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FredrikAugust/Nibble2/teams","hooks_url":"https://api.github.com/repos/FredrikAugust/Nibble2/hooks","issue_events_url":"https://api.github.com/repos/FredrikAugust/Nibble2/issues/events{/number}","events_url":"https://api.github.com/repos/FredrikAugust/Nibble2/events","assignees_url":"https://api.github.com/repos/FredrikAugust/Nibble2/assignees{/user}","branches_url":"https://api.github.com/repos/FredrikAugust/Nibble2/branches{/branch}","tags_url":"https://api.github.com/repos/FredrikAugust/Nibble2/tags","blobs_url":"https://api.github.com/repos/FredrikAugust/Nibble2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FredrikAugust/Nibble2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FredrikAugust/Nibble2/git/refs{/sha}","trees_url":"https://api.github.com/repos/FredrikAugust/Nibble2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FredrikAugust/Nibble2/statuses/{sha}","languages_url":"https://api.github.com/repos/FredrikAugust/Nibble2/languages","stargazers_url":"https://api.github.com/repos/FredrikAugust/Nibble2/stargazers","contributors_url":"https://api.github.com/repos/FredrikAugust/Nibble2/contributors","subscribers_url":"https://api.github.com/repos/FredrikAugust/Nibble2/subscribers","subscription_url":"https://api.github.com/repos/FredrikAugust/Nibble2/subscription","commits_url":"https://api.github.com/repos/FredrikAugust/Nibble2/commits{/sha}","git_commits_url":"https://api.github.com/repos/FredrikAugust/Nibble2/git/commits{/sha}","comments_url":"https://api.github.com/repos/FredrikAugust/Nibble2/comments{/number}","issue_comment_url":"https://api.github.com/repos/FredrikAugust/Nibble2/issues/comments{/number}","contents_url":"https://api.github.com/repos/FredrikAugust/Nibble2/contents/{+path}","compare_url":"https://api.github.com/repos/FredrikAugust/Nibble2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FredrikAugust/Nibble2/merges","archive_url":"https://api.github.com/repos/FredrikAugust/Nibble2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FredrikAugust/Nibble2/downloads","issues_url":"https://api.github.com/repos/FredrikAugust/Nibble2/issues{/number}","pulls_url":"https://api.github.com/repos/FredrikAugust/Nibble2/pulls{/number}","milestones_url":"https://api.github.com/repos/FredrikAugust/Nibble2/milestones{/number}","notifications_url":"https://api.github.com/repos/FredrikAugust/Nibble2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FredrikAugust/Nibble2/labels{/name}","releases_url":"https://api.github.com/repos/FredrikAugust/Nibble2/releases{/id}","deployments_url":"https://api.github.com/repos/FredrikAugust/Nibble2/deployments","created_at":"2018-08-21T15:43:40Z","updated_at":"2018-09-09T12:11:10Z","pushed_at":"2018-09-09T14:31:35Z","git_url":"git://github.com/FredrikAugust/Nibble2.git","ssh_url":"git@github.com:FredrikAugust/Nibble2.git","clone_url":"https://github.com/FredrikAugust/Nibble2.git","svn_url":"https://github.com/FredrikAugust/Nibble2","homepage":"","size":8728,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotkom:master","ref":"master","sha":"21b1a3ecfd3b0810ed9557deabf2d297df80c88d","user":{"login":"dotkom","id":693951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5Mzk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/693951?v=4","gravatar_id":"","url":"https://api.github.com/users/dotkom","html_url":"https://github.com/dotkom","followers_url":"https://api.github.com/users/dotkom/followers","following_url":"https://api.github.com/users/dotkom/following{/other_user}","gists_url":"https://api.github.com/users/dotkom/gists{/gist_id}","starred_url":"https://api.github.com/users/dotkom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotkom/subscriptions","organizations_url":"https://api.github.com/users/dotkom/orgs","repos_url":"https://api.github.com/users/dotkom/repos","events_url":"https://api.github.com/users/dotkom/events{/privacy}","received_events_url":"https://api.github.com/users/dotkom/received_events","type":"Organization","site_admin":false},"repo":{"id":80052887,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA1Mjg4Nw==","name":"Nibble2","full_name":"dotkom/Nibble2","owner":{"login":"dotkom","id":693951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5Mzk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/693951?v=4","gravatar_id":"","url":"https://api.github.com/users/dotkom","html_url":"https://github.com/dotkom","followers_url":"https://api.github.com/users/dotkom/followers","following_url":"https://api.github.com/users/dotkom/following{/other_user}","gists_url":"https://api.github.com/users/dotkom/gists{/gist_id}","starred_url":"https://api.github.com/users/dotkom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotkom/subscriptions","organizations_url":"https://api.github.com/users/dotkom/orgs","repos_url":"https://api.github.com/users/dotkom/repos","events_url":"https://api.github.com/users/dotkom/events{/privacy}","received_events_url":"https://api.github.com/users/dotkom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotkom/Nibble2","description":"App for buying food and drinks at the office","fork":false,"url":"https://api.github.com/repos/dotkom/Nibble2","forks_url":"https://api.github.com/repos/dotkom/Nibble2/forks","keys_url":"https://api.github.com/repos/dotkom/Nibble2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotkom/Nibble2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotkom/Nibble2/teams","hooks_url":"https://api.github.com/repos/dotkom/Nibble2/hooks","issue_events_url":"https://api.github.com/repos/dotkom/Nibble2/issues/events{/number}","events_url":"https://api.github.com/repos/dotkom/Nibble2/events","assignees_url":"https://api.github.com/repos/dotkom/Nibble2/assignees{/user}","branches_url":"https://api.github.com/repos/dotkom/Nibble2/branches{/branch}","tags_url":"https://api.github.com/repos/dotkom/Nibble2/tags","blobs_url":"https://api.github.com/repos/dotkom/Nibble2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotkom/Nibble2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotkom/Nibble2/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotkom/Nibble2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotkom/Nibble2/statuses/{sha}","languages_url":"https://api.github.com/repos/dotkom/Nibble2/languages","stargazers_url":"https://api.github.com/repos/dotkom/Nibble2/stargazers","contributors_url":"https://api.github.com/repos/dotkom/Nibble2/contributors","subscribers_url":"https://api.github.com/repos/dotkom/Nibble2/subscribers","subscription_url":"https://api.github.com/repos/dotkom/Nibble2/subscription","commits_url":"https://api.github.com/repos/dotkom/Nibble2/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotkom/Nibble2/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotkom/Nibble2/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotkom/Nibble2/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotkom/Nibble2/contents/{+path}","compare_url":"https://api.github.com/repos/dotkom/Nibble2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotkom/Nibble2/merges","archive_url":"https://api.github.com/repos/dotkom/Nibble2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotkom/Nibble2/downloads","issues_url":"https://api.github.com/repos/dotkom/Nibble2/issues{/number}","pulls_url":"https://api.github.com/repos/dotkom/Nibble2/pulls{/number}","milestones_url":"https://api.github.com/repos/dotkom/Nibble2/milestones{/number}","notifications_url":"https://api.github.com/repos/dotkom/Nibble2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotkom/Nibble2/labels{/name}","releases_url":"https://api.github.com/repos/dotkom/Nibble2/releases{/id}","deployments_url":"https://api.github.com/repos/dotkom/Nibble2/deployments","created_at":"2017-01-25T20:06:54Z","updated_at":"2018-09-09T11:04:06Z","pushed_at":"2018-09-09T14:31:36Z","git_url":"git://github.com/dotkom/Nibble2.git","ssh_url":"git@github.com:dotkom/Nibble2.git","clone_url":"https://github.com/dotkom/Nibble2.git","svn_url":"https://github.com/dotkom/Nibble2","homepage":"","size":8709,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotkom/Nibble2/pulls/69"},"html":{"href":"https://github.com/dotkom/Nibble2/pull/69"},"issue":{"href":"https://api.github.com/repos/dotkom/Nibble2/issues/69"},"comments":{"href":"https://api.github.com/repos/dotkom/Nibble2/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/dotkom/Nibble2/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/dotkom/Nibble2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotkom/Nibble2/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/dotkom/Nibble2/statuses/4bc3bb80578ca90a4141095d60ad55ca5c2f66ca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"FredrikAugust"}}