{"action":"created","issue":{"url":"https://api.github.com/repos/pcb2gcode/pcb2gcode/issues/237","repository_url":"https://api.github.com/repos/pcb2gcode/pcb2gcode","labels_url":"https://api.github.com/repos/pcb2gcode/pcb2gcode/issues/237/labels{/name}","comments_url":"https://api.github.com/repos/pcb2gcode/pcb2gcode/issues/237/comments","events_url":"https://api.github.com/repos/pcb2gcode/pcb2gcode/issues/237/events","html_url":"https://github.com/pcb2gcode/pcb2gcode/issues/237","id":391793688,"node_id":"MDU6SXNzdWUzOTE3OTM2ODg=","number":237,"title":"when outline cutting, do not mill around pcb","user":{"login":"AlexeyGusev","id":3841261,"node_id":"MDQ6VXNlcjM4NDEyNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/3841261?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexeyGusev","html_url":"https://github.com/AlexeyGusev","followers_url":"https://api.github.com/users/AlexeyGusev/followers","following_url":"https://api.github.com/users/AlexeyGusev/following{/other_user}","gists_url":"https://api.github.com/users/AlexeyGusev/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexeyGusev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexeyGusev/subscriptions","organizations_url":"https://api.github.com/users/AlexeyGusev/orgs","repos_url":"https://api.github.com/users/AlexeyGusev/repos","events_url":"https://api.github.com/users/AlexeyGusev/events{/privacy}","received_events_url":"https://api.github.com/users/AlexeyGusev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-17T16:35:28Z","updated_at":"2018-12-20T17:52:33Z","closed_at":null,"author_association":"NONE","body":"```\r\n$ pcb2gcode --version\r\n1.3.2\r\nGit commit: v1.3.2-491-g9af2eac\r\nBoost: 106200\r\nGerbv: 2.6.1\r\n```\r\n\r\nWhen --outline is given, pcb is about to be cut out from FR4. This makes milling around the often present ground plane useless, because CNC will cut along (or in close proximity of) the milled track around ground polygon. This effect is especially pronounced if high extra-passes parameter is used (exaggerated for clarity on this pcb, but might still be needed if you want thick isolation inside pcb in certain places):\r\n\r\n![2018-12-17 18-23-27](https://user-images.githubusercontent.com/3841261/50100397-17ef8a80-0229-11e9-9e91-c708ad6c1c48.png)\r\n\r\nGenerated outline:\r\n\r\n![2018-12-17 18-24-03](https://user-images.githubusercontent.com/3841261/50100520-5dac5300-0229-11e9-969f-5e7317cbdfa6.png)\r\n\r\nIt should be easy to detect and apply the no-mill rule on the outmost milling route, even if it doesn't fit into the cutting track.\r\n\r\nI propose implementing this feature with `mill-around=false` or similar parameter, since this feature might not always be wanted.\r\n"},"comment":{"url":"https://api.github.com/repos/pcb2gcode/pcb2gcode/issues/comments/449082092","html_url":"https://github.com/pcb2gcode/pcb2gcode/issues/237#issuecomment-449082092","issue_url":"https://api.github.com/repos/pcb2gcode/pcb2gcode/issues/237","id":449082092,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTA4MjA5Mg==","user":{"login":"eyal0","id":109809,"node_id":"MDQ6VXNlcjEwOTgwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/109809?v=4","gravatar_id":"","url":"https://api.github.com/users/eyal0","html_url":"https://github.com/eyal0","followers_url":"https://api.github.com/users/eyal0/followers","following_url":"https://api.github.com/users/eyal0/following{/other_user}","gists_url":"https://api.github.com/users/eyal0/gists{/gist_id}","starred_url":"https://api.github.com/users/eyal0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyal0/subscriptions","organizations_url":"https://api.github.com/users/eyal0/orgs","repos_url":"https://api.github.com/users/eyal0/repos","events_url":"https://api.github.com/users/eyal0/events{/privacy}","received_events_url":"https://api.github.com/users/eyal0/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T17:52:32Z","updated_at":"2018-12-20T17:52:32Z","author_association":"CONTRIBUTOR","body":"Okay, I understand my confusion now.  I was thinking about `voronoi` mode.  With voronoi, the edge cuts are used as the outer boundary and if the edge cuts don't exist, the bounding rectangle is used.  So let's put voronoi aside and only look at `voronoi=false`.\r\n\r\nFor your first example, the blue and yellow one, the mill around isn't needed because there is only a single net between the edge cuts and the ground plane.\r\n\r\nBut in your second example, it isn't obvious.\r\n\r\n![image](https://user-images.githubusercontent.com/109809/50300934-e60e3c00-0453-11e9-8cb6-a680ef10bd29.png)\r\n\r\nGreen traces 1 and 2 are obviously both part of the ground plane.  I know that, of course, and I know that it doesn't matter if those two are connected.  But pcb2gcode doesn't know that those are two actually the same net and don't need to be isolated.  So it might be hard to fix that in software.\r\n\r\nOne solution is for you to not do that pour.  pcb2gcode does isolation milling, so it's going to leave all that copper in place whether or not you put that pour in kicad.  So maybe you can just draw your traces without the pour and it'll do the right thing.  Can you try that?\r\n\r\nEspecially check that the thermal relief isn't ruined.\r\n\r\nThanks!"}}
{"actor":{"display_login":"eyal0"}}