{"action":"created","issue":{"url":"https://api.github.com/repos/simplabs/qunit-dom/issues/91","repository_url":"https://api.github.com/repos/simplabs/qunit-dom","labels_url":"https://api.github.com/repos/simplabs/qunit-dom/issues/91/labels{/name}","comments_url":"https://api.github.com/repos/simplabs/qunit-dom/issues/91/comments","events_url":"https://api.github.com/repos/simplabs/qunit-dom/issues/91/events","html_url":"https://github.com/simplabs/qunit-dom/pull/91","id":327832562,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTI5ODEz","number":91,"title":"Fixing is-visible/is-not-visible assertions to correctly account for missing elements","user":{"login":"scalvert","id":180990,"node_id":"MDQ6VXNlcjE4MDk5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/180990?v=4","gravatar_id":"","url":"https://api.github.com/users/scalvert","html_url":"https://github.com/scalvert","followers_url":"https://api.github.com/users/scalvert/followers","following_url":"https://api.github.com/users/scalvert/following{/other_user}","gists_url":"https://api.github.com/users/scalvert/gists{/gist_id}","starred_url":"https://api.github.com/users/scalvert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalvert/subscriptions","organizations_url":"https://api.github.com/users/scalvert/orgs","repos_url":"https://api.github.com/users/scalvert/repos","events_url":"https://api.github.com/users/scalvert/events{/privacy}","received_events_url":"https://api.github.com/users/scalvert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-30T17:42:58Z","updated_at":"2018-05-30T18:02:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/simplabs/qunit-dom/pulls/91","html_url":"https://github.com/simplabs/qunit-dom/pull/91","diff_url":"https://github.com/simplabs/qunit-dom/pull/91.diff","patch_url":"https://github.com/simplabs/qunit-dom/pull/91.patch"},"body":"This PR is attempting to do two main things:\r\n\r\n1. Fixing the logic in `is-visible`/`is-not-visible` to account for when elements are missing in the DOM\r\n    - these assertions would trigger the `Element <el> exists` assertion that was triggered when an element was not found in the DOM, regardless of correctness\r\n    - `is-visible` should *pass* in the case where the element _exists_ *and* is visible\r\n    - `is-visible` should *fail* in the case where the element _doesn't exist_ *or* is not visible\r\n    - `is-not-visible` should *pass* in the case where the element _doesn't exist_ *or* is not visible\r\n    - `is-not-visible` should *fail* in the case where the element _exists_ *and* is visible\r\n1. Updating the assertion message when an element is not present but is expected to be so\r\n    - the *old* assertion was `Element <el|unknown> exists`, which was mildly confusing\r\n    - the *new* assertion message is `Element <el|unknown> should exist`.\r\n\r\nThis PR in part addresses #84. "},"comment":{"url":"https://api.github.com/repos/simplabs/qunit-dom/issues/comments/393260047","html_url":"https://github.com/simplabs/qunit-dom/pull/91#issuecomment-393260047","issue_url":"https://api.github.com/repos/simplabs/qunit-dom/issues/91","id":393260047,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzI2MDA0Nw==","user":{"login":"scalvert","id":180990,"node_id":"MDQ6VXNlcjE4MDk5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/180990?v=4","gravatar_id":"","url":"https://api.github.com/users/scalvert","html_url":"https://github.com/scalvert","followers_url":"https://api.github.com/users/scalvert/followers","following_url":"https://api.github.com/users/scalvert/following{/other_user}","gists_url":"https://api.github.com/users/scalvert/gists{/gist_id}","starred_url":"https://api.github.com/users/scalvert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalvert/subscriptions","organizations_url":"https://api.github.com/users/scalvert/orgs","repos_url":"https://api.github.com/users/scalvert/repos","events_url":"https://api.github.com/users/scalvert/events{/privacy}","received_events_url":"https://api.github.com/users/scalvert/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T18:02:29Z","updated_at":"2018-05-30T18:02:29Z","author_association":"CONTRIBUTOR","body":"@rwjblue added the comment to cross-reference the tests in their various locations."}}
{"actor":{"display_login":"scalvert"}}