{"action":"created","comment":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/183825407","pull_request_review_id":114898096,"id":183825407,"diff_hunk":"@@ -915,14 +915,6 @@ public void testDeleteHierarchy() {\n         assertDeleted(id + \"/foo\");\n     }\n \n-    @Test\n-    public void testDeleteBinary() throws IOException {\n-        final String id = getRandomUniqueId();","path":"fcrepo-http-api/src/test/java/org/fcrepo/integration/http/api/FedoraLdpIT.java","position":6,"original_position":6,"commit_id":"03f50e0cca30bfbf62a93fc7e78ef01081171a84","original_commit_id":"03f50e0cca30bfbf62a93fc7e78ef01081171a84","user":{"login":"bbpennel","id":969810,"avatar_url":"https://avatars2.githubusercontent.com/u/969810?v=4","gravatar_id":"","url":"https://api.github.com/users/bbpennel","html_url":"https://github.com/bbpennel","followers_url":"https://api.github.com/users/bbpennel/followers","following_url":"https://api.github.com/users/bbpennel/following{/other_user}","gists_url":"https://api.github.com/users/bbpennel/gists{/gist_id}","starred_url":"https://api.github.com/users/bbpennel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbpennel/subscriptions","organizations_url":"https://api.github.com/users/bbpennel/orgs","repos_url":"https://api.github.com/users/bbpennel/repos","events_url":"https://api.github.com/users/bbpennel/events{/privacy}","received_events_url":"https://api.github.com/users/bbpennel/received_events","type":"User","site_admin":false},"body":"Even before my change, this test was a duplicate of:\r\nhttps://github.com/bbpennel/fcrepo4/blob/03f50e0cca30bfbf62a93fc7e78ef01081171a84/fcrepo-http-api/src/test/java/org/fcrepo/integration/http/api/FedoraLdpIT.java#L2004-L2010\r\n(Names and content value are only differences) When I was debugging these tests I opted to delete the duplicate rather than potentially fix both (although no fixes ended up being needed to the tests).","created_at":"2018-04-24T17:54:53Z","updated_at":"2018-04-24T17:54:53Z","html_url":"https://github.com/fcrepo4/fcrepo4/pull/1335#discussion_r183825407","pull_request_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1335","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/183825407"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/1335#discussion_r183825407"},"pull_request":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1335"}},"in_reply_to_id":183754895},"pull_request":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1335","id":183537334,"html_url":"https://github.com/fcrepo4/fcrepo4/pull/1335","diff_url":"https://github.com/fcrepo4/fcrepo4/pull/1335.diff","patch_url":"https://github.com/fcrepo4/fcrepo4/pull/1335.patch","issue_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1335","number":1335,"state":"open","locked":false,"title":"Fcrepo 2757 - Split description and binary","user":{"login":"bbpennel","id":969810,"avatar_url":"https://avatars2.githubusercontent.com/u/969810?v=4","gravatar_id":"","url":"https://api.github.com/users/bbpennel","html_url":"https://github.com/bbpennel","followers_url":"https://api.github.com/users/bbpennel/followers","following_url":"https://api.github.com/users/bbpennel/following{/other_user}","gists_url":"https://api.github.com/users/bbpennel/gists{/gist_id}","starred_url":"https://api.github.com/users/bbpennel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbpennel/subscriptions","organizations_url":"https://api.github.com/users/bbpennel/orgs","repos_url":"https://api.github.com/users/bbpennel/repos","events_url":"https://api.github.com/users/bbpennel/events{/privacy}","received_events_url":"https://api.github.com/users/bbpennel/received_events","type":"User","site_admin":false},"body":"**JIRA Ticket**: https://jira.duraspace.org/browse/FCREPO-2757\r\n\r\n# What does this Pull Request do?\r\nRestructures how binaries are stored to separate description and fedora binary into separate classes, based on the following outline:\r\nhttps://drive.google.com/file/d/1AEXRliMcBJUR1WFC6Z7cHKE4SEM4ykH5/view?usp=sharing\r\n\r\n# What's new?\r\n* FedoraBinary is now the class retrieved at the path `/binary` instead of NonRdfSourceDescription\r\n* NonRdfSourceDescription now refers to `/binary/fedora:description` and contains the description of the binary\r\n* Binaries and descriptions now return their own caching headers instead of each others.\r\n* Subject of triples from NonRdfSourceDescription nodes are translated to the uri of the binary\r\n* Updates converters to resolve to new paths for binaries, simplifies logic.\r\n* Introduces leafNode nodetype, which is a non-abstract hierarchyNode without children\r\n\r\n\r\n# How should this be tested?\r\n\r\nChanges are tested by existing FedoraLdpIT and FedoraVersioningIT.  Otherwise, they can be tested with regular binary interactions:\r\n```\r\ncurl -i -XPOST -H \"Slug:test_binary\" -H \"Content-Type: text/plain\" --data-binary \"binarycontent\" \"http://localhost:8080/\" -H \"Content-Disposition: attachment; filename=\\\"file.txt\\\"\"\r\n\r\ncurl -iv \"http://localhost:8080/test_binary\"\r\n# Content-Type: text/plain\r\n# Content-Disposition: file.txt\r\n# link<describedby>: http://localhost:8080/test_binary/fcr:metadata\r\n# binarycontent\r\n\r\ncurl -iv \"http://localhost:8080/test_binary/fcr:metadata\"\r\n# link<describes>: http://localhost:8080/test_binary\r\n# <rdf including filename, size, mimemtype>\r\n\r\n```","created_at":"2018-04-23T19:43:33Z","updated_at":"2018-04-24T17:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2c06246d69f3d654bf9bf5bcee8529661707256","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1335/commits","review_comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1335/comments","review_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1335/comments","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/03f50e0cca30bfbf62a93fc7e78ef01081171a84","head":{"label":"bbpennel:fcrepo-2757","ref":"fcrepo-2757","sha":"03f50e0cca30bfbf62a93fc7e78ef01081171a84","user":{"login":"bbpennel","id":969810,"avatar_url":"https://avatars2.githubusercontent.com/u/969810?v=4","gravatar_id":"","url":"https://api.github.com/users/bbpennel","html_url":"https://github.com/bbpennel","followers_url":"https://api.github.com/users/bbpennel/followers","following_url":"https://api.github.com/users/bbpennel/following{/other_user}","gists_url":"https://api.github.com/users/bbpennel/gists{/gist_id}","starred_url":"https://api.github.com/users/bbpennel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbpennel/subscriptions","organizations_url":"https://api.github.com/users/bbpennel/orgs","repos_url":"https://api.github.com/users/bbpennel/repos","events_url":"https://api.github.com/users/bbpennel/events{/privacy}","received_events_url":"https://api.github.com/users/bbpennel/received_events","type":"User","site_admin":false},"repo":{"id":16698564,"name":"fcrepo4","full_name":"bbpennel/fcrepo4","owner":{"login":"bbpennel","id":969810,"avatar_url":"https://avatars2.githubusercontent.com/u/969810?v=4","gravatar_id":"","url":"https://api.github.com/users/bbpennel","html_url":"https://github.com/bbpennel","followers_url":"https://api.github.com/users/bbpennel/followers","following_url":"https://api.github.com/users/bbpennel/following{/other_user}","gists_url":"https://api.github.com/users/bbpennel/gists{/gist_id}","starred_url":"https://api.github.com/users/bbpennel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbpennel/subscriptions","organizations_url":"https://api.github.com/users/bbpennel/orgs","repos_url":"https://api.github.com/users/bbpennel/repos","events_url":"https://api.github.com/users/bbpennel/events{/privacy}","received_events_url":"https://api.github.com/users/bbpennel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbpennel/fcrepo4","description":"Fedora 4: \"Changing everything, two weeks at a time\"","fork":true,"url":"https://api.github.com/repos/bbpennel/fcrepo4","forks_url":"https://api.github.com/repos/bbpennel/fcrepo4/forks","keys_url":"https://api.github.com/repos/bbpennel/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbpennel/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbpennel/fcrepo4/teams","hooks_url":"https://api.github.com/repos/bbpennel/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/bbpennel/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/bbpennel/fcrepo4/events","assignees_url":"https://api.github.com/repos/bbpennel/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/bbpennel/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/bbpennel/fcrepo4/tags","blobs_url":"https://api.github.com/repos/bbpennel/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbpennel/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbpennel/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbpennel/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbpennel/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/bbpennel/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/bbpennel/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/bbpennel/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/bbpennel/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/bbpennel/fcrepo4/subscription","commits_url":"https://api.github.com/repos/bbpennel/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbpennel/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbpennel/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbpennel/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbpennel/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/bbpennel/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbpennel/fcrepo4/merges","archive_url":"https://api.github.com/repos/bbpennel/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbpennel/fcrepo4/downloads","issues_url":"https://api.github.com/repos/bbpennel/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/bbpennel/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/bbpennel/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/bbpennel/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbpennel/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/bbpennel/fcrepo4/releases{/id}","deployments_url":"https://api.github.com/repos/bbpennel/fcrepo4/deployments","created_at":"2014-02-10T14:57:09Z","updated_at":"2014-05-15T13:42:03Z","pushed_at":"2018-04-24T13:04:40Z","git_url":"git://github.com/bbpennel/fcrepo4.git","ssh_url":"git@github.com:bbpennel/fcrepo4.git","clone_url":"https://github.com/bbpennel/fcrepo4.git","svn_url":"https://github.com/bbpennel/fcrepo4","homepage":"http://futures.github.com/fcrepo4/","size":47544,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fcrepo4:master","ref":"master","sha":"4dd03a784b7dbf030369f2db95305603889eb31d","user":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars2.githubusercontent.com/u/3057565?v=4","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"repo":{"id":7992797,"name":"fcrepo4","full_name":"fcrepo4/fcrepo4","owner":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars2.githubusercontent.com/u/3057565?v=4","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fcrepo4/fcrepo4","description":"Fedora 4","fork":false,"url":"https://api.github.com/repos/fcrepo4/fcrepo4","forks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/forks","keys_url":"https://api.github.com/repos/fcrepo4/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcrepo4/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcrepo4/fcrepo4/teams","hooks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/events","assignees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/fcrepo4/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/tags","blobs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/fcrepo4/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscription","commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/fcrepo4/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcrepo4/fcrepo4/merges","archive_url":"https://api.github.com/repos/fcrepo4/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcrepo4/fcrepo4/downloads","issues_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/fcrepo4/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/fcrepo4/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcrepo4/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/fcrepo4/fcrepo4/releases{/id}","deployments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/deployments","created_at":"2013-02-03T16:18:55Z","updated_at":"2018-04-24T14:44:26Z","pushed_at":"2018-04-24T17:06:05Z","git_url":"git://github.com/fcrepo4/fcrepo4.git","ssh_url":"git@github.com:fcrepo4/fcrepo4.git","clone_url":"https://github.com/fcrepo4/fcrepo4.git","svn_url":"https://github.com/fcrepo4/fcrepo4","homepage":"https://wiki.duraspace.org/display/FF/Fedora+Repository+Home","size":101363,"stargazers_count":98,"watchers_count":98,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":102,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":102,"open_issues":15,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1335"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/1335"},"issue":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1335"},"comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1335/comments"},"review_comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1335/comments"},"review_comment":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1335/commits"},"statuses":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/03f50e0cca30bfbf62a93fc7e78ef01081171a84"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bbpennel"}}