{"action":"created","comment":{"url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls/comments/206664915","pull_request_review_id":142110203,"id":206664915,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjY2NDkxNQ==","diff_hunk":"@@ -0,0 +1,12 @@\n+package nl.wderoode.model;","path":"src/main/java/nl/wderoode/model/BobBusStop.java","position":1,"original_position":1,"commit_id":"fc90ac181b3a8b3d2e3c0148d6f763ceff9255be","original_commit_id":"fc90ac181b3a8b3d2e3c0148d6f763ceff9255be","user":{"login":"bendh","id":5381915,"node_id":"MDQ6VXNlcjUzODE5MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5381915?v=4","gravatar_id":"","url":"https://api.github.com/users/bendh","html_url":"https://github.com/bendh","followers_url":"https://api.github.com/users/bendh/followers","following_url":"https://api.github.com/users/bendh/following{/other_user}","gists_url":"https://api.github.com/users/bendh/gists{/gist_id}","starred_url":"https://api.github.com/users/bendh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendh/subscriptions","organizations_url":"https://api.github.com/users/bendh/orgs","repos_url":"https://api.github.com/users/bendh/repos","events_url":"https://api.github.com/users/bendh/events{/privacy}","received_events_url":"https://api.github.com/users/bendh/received_events","type":"User","site_admin":false},"body":"Je model is gebasseerd op een hierachy van Stop. Ze voegen op dit moment niets toe, is dat later wel de bedoeling? Als het niet de bedoeling is zou ik Stop niet abstract maken en een property toevoegen aan Stop bv genaamd type. Dit zou dan een enum zijn TRAM,BUS enz... Als je er meteen een set van maakt kun je meteen het probleem oplossen van haltes met meerdere types ;<)","created_at":"2018-07-31T20:02:55Z","updated_at":"2018-07-31T20:03:43Z","html_url":"https://github.com/wesleyderoode/metrolijn-graph/pull/1#discussion_r206664915","pull_request_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls/comments/206664915"},"html":{"href":"https://github.com/wesleyderoode/metrolijn-graph/pull/1#discussion_r206664915"},"pull_request":{"href":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls/1","id":205215025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjE1MDI1","html_url":"https://github.com/wesleyderoode/metrolijn-graph/pull/1","diff_url":"https://github.com/wesleyderoode/metrolijn-graph/pull/1.diff","patch_url":"https://github.com/wesleyderoode/metrolijn-graph/pull/1.patch","issue_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/issues/1","number":1,"state":"open","locked":false,"title":"baseline","user":{"login":"bendh","id":5381915,"node_id":"MDQ6VXNlcjUzODE5MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5381915?v=4","gravatar_id":"","url":"https://api.github.com/users/bendh","html_url":"https://github.com/bendh","followers_url":"https://api.github.com/users/bendh/followers","following_url":"https://api.github.com/users/bendh/following{/other_user}","gists_url":"https://api.github.com/users/bendh/gists{/gist_id}","starred_url":"https://api.github.com/users/bendh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendh/subscriptions","organizations_url":"https://api.github.com/users/bendh/orgs","repos_url":"https://api.github.com/users/bendh/repos","events_url":"https://api.github.com/users/bendh/events{/privacy}","received_events_url":"https://api.github.com/users/bendh/received_events","type":"User","site_admin":false},"body":"Ik heb deze branch voor je gemaakt zodat ik commentaren beter kan doen. Ik heb het op de mail even toegelicht. Als je na deze pull request (dit is al jouw code die in master stond) hier verder in ontwikkeld kun je een pull request aanmaken van development naar master. \r\n\r\ngrt Ben\r\n\r\nAlgemene review punten:\r\n- Voeg een .gitignore bestand toe waarbij de volgende mappen in vermeld zijn:\r\n.idea (dit zijn IDE bestanden die lokaal verschillen)\r\ntarget (Dit zijn de gecompiled files)\r\n*.iml (dit is ook een IDE bestand)\r\nDoor de .gitignore bestand toe te voegen zullen bestanden en mappen die erin vermeld staan niet meer in versiebeheer meegenomen worden\r\n","created_at":"2018-07-31T19:17:59Z","updated_at":"2018-07-31T20:03:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b521fa028ede70c2b6e1f4216c176daa9d66e32","assignee":{"login":"bendh","id":5381915,"node_id":"MDQ6VXNlcjUzODE5MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5381915?v=4","gravatar_id":"","url":"https://api.github.com/users/bendh","html_url":"https://github.com/bendh","followers_url":"https://api.github.com/users/bendh/followers","following_url":"https://api.github.com/users/bendh/following{/other_user}","gists_url":"https://api.github.com/users/bendh/gists{/gist_id}","starred_url":"https://api.github.com/users/bendh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendh/subscriptions","organizations_url":"https://api.github.com/users/bendh/orgs","repos_url":"https://api.github.com/users/bendh/repos","events_url":"https://api.github.com/users/bendh/events{/privacy}","received_events_url":"https://api.github.com/users/bendh/received_events","type":"User","site_admin":false},"assignees":[{"login":"bendh","id":5381915,"node_id":"MDQ6VXNlcjUzODE5MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5381915?v=4","gravatar_id":"","url":"https://api.github.com/users/bendh","html_url":"https://github.com/bendh","followers_url":"https://api.github.com/users/bendh/followers","following_url":"https://api.github.com/users/bendh/following{/other_user}","gists_url":"https://api.github.com/users/bendh/gists{/gist_id}","starred_url":"https://api.github.com/users/bendh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendh/subscriptions","organizations_url":"https://api.github.com/users/bendh/orgs","repos_url":"https://api.github.com/users/bendh/repos","events_url":"https://api.github.com/users/bendh/events{/privacy}","received_events_url":"https://api.github.com/users/bendh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls/1/commits","review_comments_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls/1/comments","review_comment_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/issues/1/comments","statuses_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/statuses/fc90ac181b3a8b3d2e3c0148d6f763ceff9255be","head":{"label":"wesleyderoode:master","ref":"master","sha":"fc90ac181b3a8b3d2e3c0148d6f763ceff9255be","user":{"login":"wesleyderoode","id":34897934,"node_id":"MDQ6VXNlcjM0ODk3OTM0","avatar_url":"https://avatars1.githubusercontent.com/u/34897934?v=4","gravatar_id":"","url":"https://api.github.com/users/wesleyderoode","html_url":"https://github.com/wesleyderoode","followers_url":"https://api.github.com/users/wesleyderoode/followers","following_url":"https://api.github.com/users/wesleyderoode/following{/other_user}","gists_url":"https://api.github.com/users/wesleyderoode/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleyderoode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleyderoode/subscriptions","organizations_url":"https://api.github.com/users/wesleyderoode/orgs","repos_url":"https://api.github.com/users/wesleyderoode/repos","events_url":"https://api.github.com/users/wesleyderoode/events{/privacy}","received_events_url":"https://api.github.com/users/wesleyderoode/received_events","type":"User","site_admin":false},"repo":{"id":143004037,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwMDQwMzc=","name":"metrolijn-graph","full_name":"wesleyderoode/metrolijn-graph","owner":{"login":"wesleyderoode","id":34897934,"node_id":"MDQ6VXNlcjM0ODk3OTM0","avatar_url":"https://avatars1.githubusercontent.com/u/34897934?v=4","gravatar_id":"","url":"https://api.github.com/users/wesleyderoode","html_url":"https://github.com/wesleyderoode","followers_url":"https://api.github.com/users/wesleyderoode/followers","following_url":"https://api.github.com/users/wesleyderoode/following{/other_user}","gists_url":"https://api.github.com/users/wesleyderoode/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleyderoode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleyderoode/subscriptions","organizations_url":"https://api.github.com/users/wesleyderoode/orgs","repos_url":"https://api.github.com/users/wesleyderoode/repos","events_url":"https://api.github.com/users/wesleyderoode/events{/privacy}","received_events_url":"https://api.github.com/users/wesleyderoode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wesleyderoode/metrolijn-graph","description":"Simple Java project including a Neo4j storage implementation for learning purposes","fork":false,"url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph","forks_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/forks","keys_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/teams","hooks_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/hooks","issue_events_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/issues/events{/number}","events_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/events","assignees_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/assignees{/user}","branches_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/branches{/branch}","tags_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/tags","blobs_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/statuses/{sha}","languages_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/languages","stargazers_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/stargazers","contributors_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/contributors","subscribers_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/subscribers","subscription_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/subscription","commits_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/contents/{+path}","compare_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/merges","archive_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/downloads","issues_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/issues{/number}","pulls_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls{/number}","milestones_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/milestones{/number}","notifications_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/labels{/name}","releases_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/releases{/id}","deployments_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/deployments","created_at":"2018-07-31T11:16:33Z","updated_at":"2018-07-31T18:35:55Z","pushed_at":"2018-07-31T19:18:00Z","git_url":"git://github.com/wesleyderoode/metrolijn-graph.git","ssh_url":"git@github.com:wesleyderoode/metrolijn-graph.git","clone_url":"https://github.com/wesleyderoode/metrolijn-graph.git","svn_url":"https://github.com/wesleyderoode/metrolijn-graph","homepage":null,"size":57,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"wesleyderoode:development","ref":"development","sha":"962e6745ff6ae4bcf1f42aa8e47e2bdb1e0045a7","user":{"login":"wesleyderoode","id":34897934,"node_id":"MDQ6VXNlcjM0ODk3OTM0","avatar_url":"https://avatars1.githubusercontent.com/u/34897934?v=4","gravatar_id":"","url":"https://api.github.com/users/wesleyderoode","html_url":"https://github.com/wesleyderoode","followers_url":"https://api.github.com/users/wesleyderoode/followers","following_url":"https://api.github.com/users/wesleyderoode/following{/other_user}","gists_url":"https://api.github.com/users/wesleyderoode/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleyderoode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleyderoode/subscriptions","organizations_url":"https://api.github.com/users/wesleyderoode/orgs","repos_url":"https://api.github.com/users/wesleyderoode/repos","events_url":"https://api.github.com/users/wesleyderoode/events{/privacy}","received_events_url":"https://api.github.com/users/wesleyderoode/received_events","type":"User","site_admin":false},"repo":{"id":143004037,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwMDQwMzc=","name":"metrolijn-graph","full_name":"wesleyderoode/metrolijn-graph","owner":{"login":"wesleyderoode","id":34897934,"node_id":"MDQ6VXNlcjM0ODk3OTM0","avatar_url":"https://avatars1.githubusercontent.com/u/34897934?v=4","gravatar_id":"","url":"https://api.github.com/users/wesleyderoode","html_url":"https://github.com/wesleyderoode","followers_url":"https://api.github.com/users/wesleyderoode/followers","following_url":"https://api.github.com/users/wesleyderoode/following{/other_user}","gists_url":"https://api.github.com/users/wesleyderoode/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleyderoode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleyderoode/subscriptions","organizations_url":"https://api.github.com/users/wesleyderoode/orgs","repos_url":"https://api.github.com/users/wesleyderoode/repos","events_url":"https://api.github.com/users/wesleyderoode/events{/privacy}","received_events_url":"https://api.github.com/users/wesleyderoode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wesleyderoode/metrolijn-graph","description":"Simple Java project including a Neo4j storage implementation for learning purposes","fork":false,"url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph","forks_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/forks","keys_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/teams","hooks_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/hooks","issue_events_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/issues/events{/number}","events_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/events","assignees_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/assignees{/user}","branches_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/branches{/branch}","tags_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/tags","blobs_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/statuses/{sha}","languages_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/languages","stargazers_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/stargazers","contributors_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/contributors","subscribers_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/subscribers","subscription_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/subscription","commits_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/contents/{+path}","compare_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/merges","archive_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/downloads","issues_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/issues{/number}","pulls_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls{/number}","milestones_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/milestones{/number}","notifications_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/labels{/name}","releases_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/releases{/id}","deployments_url":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/deployments","created_at":"2018-07-31T11:16:33Z","updated_at":"2018-07-31T18:35:55Z","pushed_at":"2018-07-31T19:18:00Z","git_url":"git://github.com/wesleyderoode/metrolijn-graph.git","ssh_url":"git@github.com:wesleyderoode/metrolijn-graph.git","clone_url":"https://github.com/wesleyderoode/metrolijn-graph.git","svn_url":"https://github.com/wesleyderoode/metrolijn-graph","homepage":null,"size":57,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls/1"},"html":{"href":"https://github.com/wesleyderoode/metrolijn-graph/pull/1"},"issue":{"href":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/issues/1"},"comments":{"href":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/wesleyderoode/metrolijn-graph/statuses/fc90ac181b3a8b3d2e3c0148d6f763ceff9255be"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bendh"}}