{"action":"created","comment":{"url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls/comments/232477508","pull_request_review_id":173687882,"id":232477508,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQ3NzUwOA==","diff_hunk":"@@ -109,7 +110,15 @@ docker run --rm -it --workdir /code -v \"$PWD\":/code wasm-imagemagick-build-tools\n \r\n #windows cmd\r\n #docker run --rm -it --workdir /code -v %CD%:/code wasm-imagemagick-build-tools bash ./build.sh\r\n-\r\n ```\r\n \r\n-Produces `magick.js` & `magick.wasm` in the current folder. Along with `magickApi.js` that is all the files needed on the webserver.\r","path":"Readme.md","position":15,"original_position":15,"commit_id":"4c8fb781556e76cac26516f5cab06e3c105f360f","original_commit_id":"df1941e36733562812ed2fc31a58f0a5514265fc","user":{"login":"KnicKnic","id":35521284,"node_id":"MDQ6VXNlcjM1NTIxMjg0","avatar_url":"https://avatars2.githubusercontent.com/u/35521284?v=4","gravatar_id":"","url":"https://api.github.com/users/KnicKnic","html_url":"https://github.com/KnicKnic","followers_url":"https://api.github.com/users/KnicKnic/followers","following_url":"https://api.github.com/users/KnicKnic/following{/other_user}","gists_url":"https://api.github.com/users/KnicKnic/gists{/gist_id}","starred_url":"https://api.github.com/users/KnicKnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnicKnic/subscriptions","organizations_url":"https://api.github.com/users/KnicKnic/orgs","repos_url":"https://api.github.com/users/KnicKnic/repos","events_url":"https://api.github.com/users/KnicKnic/events{/privacy}","received_events_url":"https://api.github.com/users/KnicKnic/received_events","type":"User","site_admin":false},"body":"Also I think your tests will fail till you use npm install here\r\nhttps://github.com/KnicKnic/WASM-ImageMagick/blob/ccecb8bfb9e531f0ee3c3932e97c6a94bdba14e0/azure-pipelines.yml#L14-L15","created_at":"2018-11-11T07:56:06Z","updated_at":"2018-11-11T07:56:06Z","html_url":"https://github.com/KnicKnic/WASM-ImageMagick/pull/24#discussion_r232477508","pull_request_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls/24","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls/comments/232477508"},"html":{"href":"https://github.com/KnicKnic/WASM-ImageMagick/pull/24#discussion_r232477508"},"pull_request":{"href":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls/24"}},"in_reply_to_id":232476865},"pull_request":{"url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls/24","id":229930833,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTMwODMz","html_url":"https://github.com/KnicKnic/WASM-ImageMagick/pull/24","diff_url":"https://github.com/KnicKnic/WASM-ImageMagick/pull/24.diff","patch_url":"https://github.com/KnicKnic/WASM-ImageMagick/pull/24.patch","issue_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/issues/24","number":24,"state":"open","locked":false,"title":"Browser test","user":{"login":"cancerberoSgx","id":112746,"node_id":"MDQ6VXNlcjExMjc0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/112746?v=4","gravatar_id":"","url":"https://api.github.com/users/cancerberoSgx","html_url":"https://github.com/cancerberoSgx","followers_url":"https://api.github.com/users/cancerberoSgx/followers","following_url":"https://api.github.com/users/cancerberoSgx/following{/other_user}","gists_url":"https://api.github.com/users/cancerberoSgx/gists{/gist_id}","starred_url":"https://api.github.com/users/cancerberoSgx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cancerberoSgx/subscriptions","organizations_url":"https://api.github.com/users/cancerberoSgx/orgs","repos_url":"https://api.github.com/users/cancerberoSgx/repos","events_url":"https://api.github.com/users/cancerberoSgx/events{/privacy}","received_events_url":"https://api.github.com/users/cancerberoSgx/received_events","type":"User","site_admin":false},"body":" * WIP - created this pull request so we can discuss this (big) changes.\r\n * move magickApi.js to src/magickApi.ts\r\n * ./spec contain jasmine unit tests that run in the browser thanks to gulp-jasmine-browser. \r\n   * Currently running with chrome (puppeteer) but it also support gecko (slimerjs) and webkit (phantomjs)\r\n   * `npm run test-browser` will run browser headless in terminal\r\n   * `npm run test-browser-server`will run tests in a server so yor can open chrome at http://localhost:8888 to debug them\r\n   * TODO: use watch/browsersync to agile development\r\n* ./src/util/file.ts contains utilities to easy MagickInputFile creation and transformation between input files and output files, blobs, arrays, strings, etc\r\n* ./src/util/image.ts contains utilities related to images. Right now has compare() and extractInfo() that help me in the tests\r\n * please ignore src/imageHome and src/execute -  those features (and other) will probably have to be added in another branch / project ","created_at":"2018-11-11T04:36:59Z","updated_at":"2018-11-11T07:56:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ac3352c8ca480050e1aa9bb84876b2eac07b3fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":991373277,"node_id":"MDU6TGFiZWw5OTEzNzMyNzc=","url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls/24/commits","review_comments_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls/24/comments","review_comment_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/issues/24/comments","statuses_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/statuses/4c8fb781556e76cac26516f5cab06e3c105f360f","head":{"label":"KnicKnic:browser-test","ref":"browser-test","sha":"4c8fb781556e76cac26516f5cab06e3c105f360f","user":{"login":"KnicKnic","id":35521284,"node_id":"MDQ6VXNlcjM1NTIxMjg0","avatar_url":"https://avatars2.githubusercontent.com/u/35521284?v=4","gravatar_id":"","url":"https://api.github.com/users/KnicKnic","html_url":"https://github.com/KnicKnic","followers_url":"https://api.github.com/users/KnicKnic/followers","following_url":"https://api.github.com/users/KnicKnic/following{/other_user}","gists_url":"https://api.github.com/users/KnicKnic/gists{/gist_id}","starred_url":"https://api.github.com/users/KnicKnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnicKnic/subscriptions","organizations_url":"https://api.github.com/users/KnicKnic/orgs","repos_url":"https://api.github.com/users/KnicKnic/repos","events_url":"https://api.github.com/users/KnicKnic/events{/privacy}","received_events_url":"https://api.github.com/users/KnicKnic/received_events","type":"User","site_admin":false},"repo":{"id":140663613,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2NjM2MTM=","name":"WASM-ImageMagick","full_name":"KnicKnic/WASM-ImageMagick","private":false,"owner":{"login":"KnicKnic","id":35521284,"node_id":"MDQ6VXNlcjM1NTIxMjg0","avatar_url":"https://avatars2.githubusercontent.com/u/35521284?v=4","gravatar_id":"","url":"https://api.github.com/users/KnicKnic","html_url":"https://github.com/KnicKnic","followers_url":"https://api.github.com/users/KnicKnic/followers","following_url":"https://api.github.com/users/KnicKnic/following{/other_user}","gists_url":"https://api.github.com/users/KnicKnic/gists{/gist_id}","starred_url":"https://api.github.com/users/KnicKnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnicKnic/subscriptions","organizations_url":"https://api.github.com/users/KnicKnic/orgs","repos_url":"https://api.github.com/users/KnicKnic/repos","events_url":"https://api.github.com/users/KnicKnic/events{/privacy}","received_events_url":"https://api.github.com/users/KnicKnic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KnicKnic/WASM-ImageMagick","description":"Webassembly compilation of https://github.com/ImageMagick/ImageMagick & samples","fork":false,"url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick","forks_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/forks","keys_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/teams","hooks_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/hooks","issue_events_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/issues/events{/number}","events_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/events","assignees_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/assignees{/user}","branches_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/branches{/branch}","tags_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/tags","blobs_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/git/refs{/sha}","trees_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/statuses/{sha}","languages_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/languages","stargazers_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/stargazers","contributors_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/contributors","subscribers_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/subscribers","subscription_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/subscription","commits_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/commits{/sha}","git_commits_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/git/commits{/sha}","comments_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/comments{/number}","issue_comment_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/issues/comments{/number}","contents_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/contents/{+path}","compare_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/merges","archive_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/downloads","issues_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/issues{/number}","pulls_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls{/number}","milestones_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/milestones{/number}","notifications_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/labels{/name}","releases_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/releases{/id}","deployments_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/deployments","created_at":"2018-07-12T05:07:50Z","updated_at":"2018-10-27T02:09:12Z","pushed_at":"2018-11-11T07:37:19Z","git_url":"git://github.com/KnicKnic/WASM-ImageMagick.git","ssh_url":"git@github.com:KnicKnic/WASM-ImageMagick.git","clone_url":"https://github.com/KnicKnic/WASM-ImageMagick.git","svn_url":"https://github.com/KnicKnic/WASM-ImageMagick","homepage":"","size":443,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":7,"watchers":20,"default_branch":"master"}},"base":{"label":"KnicKnic:master","ref":"master","sha":"ccecb8bfb9e531f0ee3c3932e97c6a94bdba14e0","user":{"login":"KnicKnic","id":35521284,"node_id":"MDQ6VXNlcjM1NTIxMjg0","avatar_url":"https://avatars2.githubusercontent.com/u/35521284?v=4","gravatar_id":"","url":"https://api.github.com/users/KnicKnic","html_url":"https://github.com/KnicKnic","followers_url":"https://api.github.com/users/KnicKnic/followers","following_url":"https://api.github.com/users/KnicKnic/following{/other_user}","gists_url":"https://api.github.com/users/KnicKnic/gists{/gist_id}","starred_url":"https://api.github.com/users/KnicKnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnicKnic/subscriptions","organizations_url":"https://api.github.com/users/KnicKnic/orgs","repos_url":"https://api.github.com/users/KnicKnic/repos","events_url":"https://api.github.com/users/KnicKnic/events{/privacy}","received_events_url":"https://api.github.com/users/KnicKnic/received_events","type":"User","site_admin":false},"repo":{"id":140663613,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2NjM2MTM=","name":"WASM-ImageMagick","full_name":"KnicKnic/WASM-ImageMagick","private":false,"owner":{"login":"KnicKnic","id":35521284,"node_id":"MDQ6VXNlcjM1NTIxMjg0","avatar_url":"https://avatars2.githubusercontent.com/u/35521284?v=4","gravatar_id":"","url":"https://api.github.com/users/KnicKnic","html_url":"https://github.com/KnicKnic","followers_url":"https://api.github.com/users/KnicKnic/followers","following_url":"https://api.github.com/users/KnicKnic/following{/other_user}","gists_url":"https://api.github.com/users/KnicKnic/gists{/gist_id}","starred_url":"https://api.github.com/users/KnicKnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnicKnic/subscriptions","organizations_url":"https://api.github.com/users/KnicKnic/orgs","repos_url":"https://api.github.com/users/KnicKnic/repos","events_url":"https://api.github.com/users/KnicKnic/events{/privacy}","received_events_url":"https://api.github.com/users/KnicKnic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KnicKnic/WASM-ImageMagick","description":"Webassembly compilation of https://github.com/ImageMagick/ImageMagick & samples","fork":false,"url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick","forks_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/forks","keys_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/teams","hooks_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/hooks","issue_events_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/issues/events{/number}","events_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/events","assignees_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/assignees{/user}","branches_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/branches{/branch}","tags_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/tags","blobs_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/git/refs{/sha}","trees_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/statuses/{sha}","languages_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/languages","stargazers_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/stargazers","contributors_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/contributors","subscribers_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/subscribers","subscription_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/subscription","commits_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/commits{/sha}","git_commits_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/git/commits{/sha}","comments_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/comments{/number}","issue_comment_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/issues/comments{/number}","contents_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/contents/{+path}","compare_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/merges","archive_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/downloads","issues_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/issues{/number}","pulls_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls{/number}","milestones_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/milestones{/number}","notifications_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/labels{/name}","releases_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/releases{/id}","deployments_url":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/deployments","created_at":"2018-07-12T05:07:50Z","updated_at":"2018-10-27T02:09:12Z","pushed_at":"2018-11-11T07:37:19Z","git_url":"git://github.com/KnicKnic/WASM-ImageMagick.git","ssh_url":"git@github.com:KnicKnic/WASM-ImageMagick.git","clone_url":"https://github.com/KnicKnic/WASM-ImageMagick.git","svn_url":"https://github.com/KnicKnic/WASM-ImageMagick","homepage":"","size":443,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":7,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls/24"},"html":{"href":"https://github.com/KnicKnic/WASM-ImageMagick/pull/24"},"issue":{"href":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/issues/24"},"comments":{"href":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/KnicKnic/WASM-ImageMagick/statuses/4c8fb781556e76cac26516f5cab06e3c105f360f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"KnicKnic"}}