{"action":"created","issue":{"url":"https://api.github.com/repos/ray-project/ray/issues/2853","repository_url":"https://api.github.com/repos/ray-project/ray","labels_url":"https://api.github.com/repos/ray-project/ray/issues/2853/labels{/name}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/2853/comments","events_url":"https://api.github.com/repos/ray-project/ray/issues/2853/events","html_url":"https://github.com/ray-project/ray/pull/2853","id":358451019,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTg3NDE1","number":2853,"title":"update ray cmake build process","user":{"login":"chuxi","id":5573798,"node_id":"MDQ6VXNlcjU1NzM3OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5573798?v=4","gravatar_id":"","url":"https://api.github.com/users/chuxi","html_url":"https://github.com/chuxi","followers_url":"https://api.github.com/users/chuxi/followers","following_url":"https://api.github.com/users/chuxi/following{/other_user}","gists_url":"https://api.github.com/users/chuxi/gists{/gist_id}","starred_url":"https://api.github.com/users/chuxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuxi/subscriptions","organizations_url":"https://api.github.com/users/chuxi/orgs","repos_url":"https://api.github.com/users/chuxi/repos","events_url":"https://api.github.com/users/chuxi/events{/privacy}","received_events_url":"https://api.github.com/users/chuxi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-10T03:08:23Z","updated_at":"2018-09-10T08:00:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/2853","html_url":"https://github.com/ray-project/ray/pull/2853","diff_url":"https://github.com/ray-project/ray/pull/2853.diff","patch_url":"https://github.com/ray-project/ray/pull/2853.patch"},"body":"## What do these changes do?\r\n\r\n1. use cmake to build ray project instead of build.sh script.\r\n2. remove the src/common/cmake/Common.cmake file, which added a lot of useless produces in cmake.\r\n\r\ncmake supports build (add thirdparty dependency) concurrently, which improves the build performance. And for IDE, it has better integration with cmake.\r\n\r\nBesides, I find in the ray old core version (local_scheduler, plasma manager, plasma store), it has some test cases with process.kill(). However, it triggers the process failed by running tasks, which is very unreasonable... But, now the raylet version skips local schedulers alive tests. :(\r\n\r\n\r\n## Related issue number\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ray-project/ray/issues/comments/419822938","html_url":"https://github.com/ray-project/ray/pull/2853#issuecomment-419822938","issue_url":"https://api.github.com/repos/ray-project/ray/issues/2853","id":419822938,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTgyMjkzOA==","user":{"login":"AmplabJenkins","id":4031291,"node_id":"MDQ6VXNlcjQwMzEyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4031291?v=4","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T08:00:20Z","updated_at":"2018-09-10T08:00:20Z","author_association":"COLLABORATOR","body":"Test FAILed.\nRefer to this link for build results (access rights to CI server needed): \nhttps://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8127/\nTest FAILed."}}
{"actor":{"display_login":"AmplabJenkins"}}