{"action":"created","issue":{"url":"https://api.github.com/repos/kamkanna/pwp-capstones/issues/1","repository_url":"https://api.github.com/repos/kamkanna/pwp-capstones","labels_url":"https://api.github.com/repos/kamkanna/pwp-capstones/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/kamkanna/pwp-capstones/issues/1/comments","events_url":"https://api.github.com/repos/kamkanna/pwp-capstones/issues/1/events","html_url":"https://github.com/kamkanna/pwp-capstones/issues/1","id":340524371,"node_id":"MDU6SXNzdWUzNDA1MjQzNzE=","number":1,"title":"Murder Mystery Capstone Summary & Rubric Score","user":{"login":"karl-project-review","id":37846313,"node_id":"MDQ6VXNlcjM3ODQ2MzEz","avatar_url":"https://avatars0.githubusercontent.com/u/37846313?v=4","gravatar_id":"","url":"https://api.github.com/users/karl-project-review","html_url":"https://github.com/karl-project-review","followers_url":"https://api.github.com/users/karl-project-review/followers","following_url":"https://api.github.com/users/karl-project-review/following{/other_user}","gists_url":"https://api.github.com/users/karl-project-review/gists{/gist_id}","starred_url":"https://api.github.com/users/karl-project-review/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karl-project-review/subscriptions","organizations_url":"https://api.github.com/users/karl-project-review/orgs","repos_url":"https://api.github.com/users/karl-project-review/repos","events_url":"https://api.github.com/users/karl-project-review/events{/privacy}","received_events_url":"https://api.github.com/users/karl-project-review/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-12T07:44:02Z","updated_at":"2018-07-18T19:35:03Z","closed_at":null,"author_association":"NONE","body":"## Rubric Score\r\n### Criteria 1: Valid Python Code\r\n* _Score Level:_ 4/4 (Exceeds Expectations)\r\n* _Comment(s):_ All of the code used valid syntax.\r\n### Criteria 2: Implementation of Project Requirements\r\n* _Score Level:_ 4/4 (Exceeds Expectations)\r\n* _Comment(s):_ You implemented all of the necessary functions and the TextSample class. Well done!\r\n### Criteria 3: Software Architecture\r\n* _Score Level:_ 4/4 (Exceeds Expectations)\r\n* _Comment(s):_ The code was divided up into functions appropriately. \r\n### Criteria 4: Uses Python Language Features\r\n* _Score Level:_ 4/4 (Exceeds Expectations)\r\n* _Comment(s):_ You consistently used Python language features where appropriate. Good job!\r\n### Criteria 5: Produces Accurate Output\r\n* _Score Level:_ 2/4 (Approaches Expectations)\r\n* _Comment(s):_ There were problems with several of the functions, resulting in the similarity scores being off. First, in the get_average_sentence_length function, sentence_length is set equal to the list of lengths of sentences in sentences_in_text, when it should be the list of lengths of sentences in sentence_splitted (as each sentence in sentences_in_text is in string form, len is returning the number of characters instead of the number of words, which is why the average sentence lengths being returned are so high). Also, in the for block where the sentence_splitted variable is created, we should remove the extra white space around each sentence and check for empty sentences, as these throw off the count. For example, this code should do the trick:\r\n```python\r\n    for sentence in sentences_in_text:\r\n        sentence = sentence.strip()\r\n        if(sentence != ''):\r\n            sentence_splitted.append(sentence.split(\" \"))\r\n```\r\nNext, there is a problem with using the word frequency table as input for the ngram_creator function. So see this, consider the following sentence: \"Is this an example or is it not?\"\r\nIn frequency table form, this should be something like this:\r\n{is: 2, this: 1, an: 1, example: 1, or: 1, it: 1, not: 1}\r\nNote that this table gives no indication that one of the two occurrences of 'is' came before 'it'. Thus, 'is it' will not be added to the ngram, so our results will be off. Instead, we need to use the prepared_text variable as input to the ngram_creator, and modify this function to account for that change in input.\r\nThird, in the frequency_comparison function, there is an issue with this block of code:\r\n```python\r\n            if table1[key] >= table2[key]:\r\n                appearances += table1[key]\r\n                mutual_appearances += table2[key]\r\n            appearances += table2[key]\r\n            mutual_appearances += table1[key]\r\n```\r\nThe last two lines of this should be inside an else block. Otherwise, for words that appear more in table1 than in table2, we wind up adding the sum of table1[key] and table2[key] to both appearances and mutual_appearances. \r\n\r\n### Overall Score: 18/20 (Meets Expectations)\r\nGood work on this! I especially liked that there were signs you ran tests on your code (ie the commented out lines of test cases), as this is an important part of programming. I would encourage you to expand your testing methods to include checking what is happening in individual blocks of code inside your functions using print statements, as this can help catch issues in more complicated functions. Also, I would encourage you to go back and fix the issues mentioned under Criteria 5, as this should be good practice. Again, nice work!"},"comment":{"url":"https://api.github.com/repos/kamkanna/pwp-capstones/issues/comments/406048692","html_url":"https://github.com/kamkanna/pwp-capstones/issues/1#issuecomment-406048692","issue_url":"https://api.github.com/repos/kamkanna/pwp-capstones/issues/1","id":406048692,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjA0ODY5Mg==","user":{"login":"kamkanna","id":39006060,"node_id":"MDQ6VXNlcjM5MDA2MDYw","avatar_url":"https://avatars3.githubusercontent.com/u/39006060?v=4","gravatar_id":"","url":"https://api.github.com/users/kamkanna","html_url":"https://github.com/kamkanna","followers_url":"https://api.github.com/users/kamkanna/followers","following_url":"https://api.github.com/users/kamkanna/following{/other_user}","gists_url":"https://api.github.com/users/kamkanna/gists{/gist_id}","starred_url":"https://api.github.com/users/kamkanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamkanna/subscriptions","organizations_url":"https://api.github.com/users/kamkanna/orgs","repos_url":"https://api.github.com/users/kamkanna/repos","events_url":"https://api.github.com/users/kamkanna/events{/privacy}","received_events_url":"https://api.github.com/users/kamkanna/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T19:35:03Z","updated_at":"2018-07-18T19:35:03Z","author_association":"OWNER","body":"Hi Karl,\r\n\r\nThank you for the feedback.  \r\nYes, you are right about round() function. Should I add it and update the script or I have passed the final project?\r\nThank you. "}}
{"actor":{"display_login":"kamkanna"}}