{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues/896","repository_url":"https://api.github.com/repos/GoogleContainerTools/skaffold","labels_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues/896/labels{/name}","comments_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues/896/comments","events_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues/896/events","html_url":"https://github.com/GoogleContainerTools/skaffold/pull/896","id":350187578,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDk4ODYz","number":896,"title":"Global skaffold config","user":{"login":"nkubala","id":5531168,"node_id":"MDQ6VXNlcjU1MzExNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5531168?v=4","gravatar_id":"","url":"https://api.github.com/users/nkubala","html_url":"https://github.com/nkubala","followers_url":"https://api.github.com/users/nkubala/followers","following_url":"https://api.github.com/users/nkubala/following{/other_user}","gists_url":"https://api.github.com/users/nkubala/gists{/gist_id}","starred_url":"https://api.github.com/users/nkubala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkubala/subscriptions","organizations_url":"https://api.github.com/users/nkubala/orgs","repos_url":"https://api.github.com/users/nkubala/repos","events_url":"https://api.github.com/users/nkubala/events{/privacy}","received_events_url":"https://api.github.com/users/nkubala/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"balopat","id":635073,"node_id":"MDQ6VXNlcjYzNTA3Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/635073?v=4","gravatar_id":"","url":"https://api.github.com/users/balopat","html_url":"https://github.com/balopat","followers_url":"https://api.github.com/users/balopat/followers","following_url":"https://api.github.com/users/balopat/following{/other_user}","gists_url":"https://api.github.com/users/balopat/gists{/gist_id}","starred_url":"https://api.github.com/users/balopat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balopat/subscriptions","organizations_url":"https://api.github.com/users/balopat/orgs","repos_url":"https://api.github.com/users/balopat/repos","events_url":"https://api.github.com/users/balopat/events{/privacy}","received_events_url":"https://api.github.com/users/balopat/received_events","type":"User","site_admin":false},"assignees":[{"login":"balopat","id":635073,"node_id":"MDQ6VXNlcjYzNTA3Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/635073?v=4","gravatar_id":"","url":"https://api.github.com/users/balopat","html_url":"https://github.com/balopat","followers_url":"https://api.github.com/users/balopat/followers","following_url":"https://api.github.com/users/balopat/following{/other_user}","gists_url":"https://api.github.com/users/balopat/gists{/gist_id}","starred_url":"https://api.github.com/users/balopat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balopat/subscriptions","organizations_url":"https://api.github.com/users/balopat/orgs","repos_url":"https://api.github.com/users/balopat/repos","events_url":"https://api.github.com/users/balopat/events{/privacy}","received_events_url":"https://api.github.com/users/balopat/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-08-13T20:46:07Z","updated_at":"2018-08-27T18:30:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/GoogleContainerTools/skaffold/pulls/896","html_url":"https://github.com/GoogleContainerTools/skaffold/pull/896","diff_url":"https://github.com/GoogleContainerTools/skaffold/pull/896.diff","patch_url":"https://github.com/GoogleContainerTools/skaffold/pull/896.patch"},"body":"This is a second variant on #886. Main differences:\r\n\r\n* changes the structure of the config to have a top-level \"global\" section, followed by any number of context-specific config entries, inspired by @balopat. Example:\r\n```\r\nglobal: \r\n  default-repo: gcr.io/myrepo1/\r\nkubecontexts:\r\n   - kubectx: minikube\r\n         default_repo: gcr.io/myrepo2/\r\n   - kubectx: my_dev_gke\r\n         default_repo: gcr.io/myrepo2/\r\n```\r\nSetting global values in the config is done through the `--global` flag, i.e. `skaffold config set default-repo my-global-repo --global`.\r\n* disallows setting config values for multiple contexts at a time\r\n* instead of specifying `--kubecontext all` to show all config values, a `--all` flag is added to the `list` command. `skaffold config list --all`\r\n\r\nOpening this PR to show what this implementation would look like."},"comment":{"url":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues/comments/416322814","html_url":"https://github.com/GoogleContainerTools/skaffold/pull/896#issuecomment-416322814","issue_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues/896","id":416322814,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjMyMjgxNA==","user":{"login":"nkubala","id":5531168,"node_id":"MDQ6VXNlcjU1MzExNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5531168?v=4","gravatar_id":"","url":"https://api.github.com/users/nkubala","html_url":"https://github.com/nkubala","followers_url":"https://api.github.com/users/nkubala/followers","following_url":"https://api.github.com/users/nkubala/following{/other_user}","gists_url":"https://api.github.com/users/nkubala/gists{/gist_id}","starred_url":"https://api.github.com/users/nkubala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkubala/subscriptions","organizations_url":"https://api.github.com/users/nkubala/orgs","repos_url":"https://api.github.com/users/nkubala/repos","events_url":"https://api.github.com/users/nkubala/events{/privacy}","received_events_url":"https://api.github.com/users/nkubala/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T18:30:39Z","updated_at":"2018-08-27T18:30:39Z","author_association":"MEMBER","body":"@balopat \r\n> * if the folder is not created it throws errors in all the subcommands\r\n\r\nFolder now gets autocreated along with config file if it doesn't exist\r\n> * no list for possible configs - would be helpful instead of just providing a \"this is not a default config\"\r\n\r\nMost other config management CLIs don't do this (kubectl, gcloud, etc.) since it requires introspecting about the config struct at runtime. I could add this but I think it's probably better to just document it somewhere and use that as a reference.\r\n> * no feedback around which context I set the value for - it would be great to have the feedback when I set the config regarding what I changed as it can be surprising\r\n\r\nUpdated config value with context is now logged to the user"}}
{"actor":{"display_login":"nkubala"}}