{"action":"created","comment":{"url":"https://api.github.com/repos/commaai/openpilot/pulls/comments/216207140","pull_request_review_id":153634878,"id":216207140,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjIwNzE0MA==","diff_hunk":"@@ -133,12 +130,18 @@ def update(self, sendcan, enabled, CS, frame, actuators, \\\n       if (frame % 4) == 0:\n         idx = (frame / 4) % 4\n \n-        at_full_stop = enabled and CS.standstill\n-        near_stop = enabled and (CS.v_ego < P.NEAR_STOP_BRAKE_PHASE)\n+        car_stopping = apply_gas < P.ZERO_GAS","path":"selfdrive/car/gm/carcontroller.py","position":75,"original_position":75,"commit_id":"97f971404b25cb1569b70359f9c71a2fd0e3dd4b","original_commit_id":"97f971404b25cb1569b70359f9c71a2fd0e3dd4b","user":{"login":"vntarasov","id":12737456,"node_id":"MDQ6VXNlcjEyNzM3NDU2","avatar_url":"https://avatars3.githubusercontent.com/u/12737456?v=4","gravatar_id":"","url":"https://api.github.com/users/vntarasov","html_url":"https://github.com/vntarasov","followers_url":"https://api.github.com/users/vntarasov/followers","following_url":"https://api.github.com/users/vntarasov/following{/other_user}","gists_url":"https://api.github.com/users/vntarasov/gists{/gist_id}","starred_url":"https://api.github.com/users/vntarasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vntarasov/subscriptions","organizations_url":"https://api.github.com/users/vntarasov/orgs","repos_url":"https://api.github.com/users/vntarasov/repos","events_url":"https://api.github.com/users/vntarasov/events{/privacy}","received_events_url":"https://api.github.com/users/vntarasov/received_events","type":"User","site_admin":false},"body":"Another problem is that GM interface doesn't know if car is moving forward or backwards.","created_at":"2018-09-10T06:11:45Z","updated_at":"2018-09-10T06:11:46Z","html_url":"https://github.com/commaai/openpilot/pull/356#discussion_r216207140","pull_request_url":"https://api.github.com/repos/commaai/openpilot/pulls/356","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/commaai/openpilot/pulls/comments/216207140"},"html":{"href":"https://github.com/commaai/openpilot/pull/356#discussion_r216207140"},"pull_request":{"href":"https://api.github.com/repos/commaai/openpilot/pulls/356"}},"in_reply_to_id":216171757},"pull_request":{"url":"https://api.github.com/repos/commaai/openpilot/pulls/356","id":214071865,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDcxODY1","html_url":"https://github.com/commaai/openpilot/pull/356","diff_url":"https://github.com/commaai/openpilot/pull/356.diff","patch_url":"https://github.com/commaai/openpilot/pull/356.patch","issue_url":"https://api.github.com/repos/commaai/openpilot/issues/356","number":356,"state":"closed","locked":false,"title":"GM: Auto-resume from stop-and-go","user":{"login":"vntarasov","id":12737456,"node_id":"MDQ6VXNlcjEyNzM3NDU2","avatar_url":"https://avatars3.githubusercontent.com/u/12737456?v=4","gravatar_id":"","url":"https://api.github.com/users/vntarasov","html_url":"https://github.com/vntarasov","followers_url":"https://api.github.com/users/vntarasov/followers","following_url":"https://api.github.com/users/vntarasov/following{/other_user}","gists_url":"https://api.github.com/users/vntarasov/gists{/gist_id}","starred_url":"https://api.github.com/users/vntarasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vntarasov/subscriptions","organizations_url":"https://api.github.com/users/vntarasov/orgs","repos_url":"https://api.github.com/users/vntarasov/repos","events_url":"https://api.github.com/users/vntarasov/events{/privacy}","received_events_url":"https://api.github.com/users/vntarasov/received_events","type":"User","site_admin":false},"body":"Through resetting ACC (stopping sending ACC commands until it gets out of standstill) mode and immediately resuming. No need to press resume button anymore!\r\n\r\nPiggybacking on @Jamezz's work on smoother braking from https://github.com/commaai/openpilot/pull/326.","created_at":"2018-09-08T02:08:12Z","updated_at":"2018-09-10T06:11:46Z","closed_at":"2018-09-09T23:03:43Z","merged_at":null,"merge_commit_sha":"f53263b8d4ae2fdd7d153b1610a4d80ad81df1f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/commaai/openpilot/pulls/356/commits","review_comments_url":"https://api.github.com/repos/commaai/openpilot/pulls/356/comments","review_comment_url":"https://api.github.com/repos/commaai/openpilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/commaai/openpilot/issues/356/comments","statuses_url":"https://api.github.com/repos/commaai/openpilot/statuses/97f971404b25cb1569b70359f9c71a2fd0e3dd4b","head":{"label":"vntarasov:gm-auto-resume","ref":"gm-auto-resume","sha":"97f971404b25cb1569b70359f9c71a2fd0e3dd4b","user":{"login":"vntarasov","id":12737456,"node_id":"MDQ6VXNlcjEyNzM3NDU2","avatar_url":"https://avatars3.githubusercontent.com/u/12737456?v=4","gravatar_id":"","url":"https://api.github.com/users/vntarasov","html_url":"https://github.com/vntarasov","followers_url":"https://api.github.com/users/vntarasov/followers","following_url":"https://api.github.com/users/vntarasov/following{/other_user}","gists_url":"https://api.github.com/users/vntarasov/gists{/gist_id}","starred_url":"https://api.github.com/users/vntarasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vntarasov/subscriptions","organizations_url":"https://api.github.com/users/vntarasov/orgs","repos_url":"https://api.github.com/users/vntarasov/repos","events_url":"https://api.github.com/users/vntarasov/events{/privacy}","received_events_url":"https://api.github.com/users/vntarasov/received_events","type":"User","site_admin":false},"repo":{"id":90696371,"node_id":"MDEwOlJlcG9zaXRvcnk5MDY5NjM3MQ==","name":"openpilot","full_name":"vntarasov/openpilot","owner":{"login":"vntarasov","id":12737456,"node_id":"MDQ6VXNlcjEyNzM3NDU2","avatar_url":"https://avatars3.githubusercontent.com/u/12737456?v=4","gravatar_id":"","url":"https://api.github.com/users/vntarasov","html_url":"https://github.com/vntarasov","followers_url":"https://api.github.com/users/vntarasov/followers","following_url":"https://api.github.com/users/vntarasov/following{/other_user}","gists_url":"https://api.github.com/users/vntarasov/gists{/gist_id}","starred_url":"https://api.github.com/users/vntarasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vntarasov/subscriptions","organizations_url":"https://api.github.com/users/vntarasov/orgs","repos_url":"https://api.github.com/users/vntarasov/repos","events_url":"https://api.github.com/users/vntarasov/events{/privacy}","received_events_url":"https://api.github.com/users/vntarasov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vntarasov/openpilot","description":"open source driving agent","fork":true,"url":"https://api.github.com/repos/vntarasov/openpilot","forks_url":"https://api.github.com/repos/vntarasov/openpilot/forks","keys_url":"https://api.github.com/repos/vntarasov/openpilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vntarasov/openpilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vntarasov/openpilot/teams","hooks_url":"https://api.github.com/repos/vntarasov/openpilot/hooks","issue_events_url":"https://api.github.com/repos/vntarasov/openpilot/issues/events{/number}","events_url":"https://api.github.com/repos/vntarasov/openpilot/events","assignees_url":"https://api.github.com/repos/vntarasov/openpilot/assignees{/user}","branches_url":"https://api.github.com/repos/vntarasov/openpilot/branches{/branch}","tags_url":"https://api.github.com/repos/vntarasov/openpilot/tags","blobs_url":"https://api.github.com/repos/vntarasov/openpilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vntarasov/openpilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vntarasov/openpilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/vntarasov/openpilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vntarasov/openpilot/statuses/{sha}","languages_url":"https://api.github.com/repos/vntarasov/openpilot/languages","stargazers_url":"https://api.github.com/repos/vntarasov/openpilot/stargazers","contributors_url":"https://api.github.com/repos/vntarasov/openpilot/contributors","subscribers_url":"https://api.github.com/repos/vntarasov/openpilot/subscribers","subscription_url":"https://api.github.com/repos/vntarasov/openpilot/subscription","commits_url":"https://api.github.com/repos/vntarasov/openpilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/vntarasov/openpilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/vntarasov/openpilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/vntarasov/openpilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/vntarasov/openpilot/contents/{+path}","compare_url":"https://api.github.com/repos/vntarasov/openpilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vntarasov/openpilot/merges","archive_url":"https://api.github.com/repos/vntarasov/openpilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vntarasov/openpilot/downloads","issues_url":"https://api.github.com/repos/vntarasov/openpilot/issues{/number}","pulls_url":"https://api.github.com/repos/vntarasov/openpilot/pulls{/number}","milestones_url":"https://api.github.com/repos/vntarasov/openpilot/milestones{/number}","notifications_url":"https://api.github.com/repos/vntarasov/openpilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vntarasov/openpilot/labels{/name}","releases_url":"https://api.github.com/repos/vntarasov/openpilot/releases{/id}","deployments_url":"https://api.github.com/repos/vntarasov/openpilot/deployments","created_at":"2017-05-09T03:02:35Z","updated_at":"2018-09-07T03:28:11Z","pushed_at":"2018-09-08T18:41:15Z","git_url":"git://github.com/vntarasov/openpilot.git","ssh_url":"git@github.com:vntarasov/openpilot.git","clone_url":"https://github.com/vntarasov/openpilot.git","svn_url":"https://github.com/vntarasov/openpilot","homepage":"","size":334993,"stargazers_count":9,"watchers_count":9,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":0,"watchers":9,"default_branch":"volt"}},"base":{"label":"commaai:devel","ref":"devel","sha":"d2b8c4f0cb937fe12ffa65f491f93a2a44636aad","user":{"login":"commaai","id":16128714,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTI4NzE0","avatar_url":"https://avatars2.githubusercontent.com/u/16128714?v=4","gravatar_id":"","url":"https://api.github.com/users/commaai","html_url":"https://github.com/commaai","followers_url":"https://api.github.com/users/commaai/followers","following_url":"https://api.github.com/users/commaai/following{/other_user}","gists_url":"https://api.github.com/users/commaai/gists{/gist_id}","starred_url":"https://api.github.com/users/commaai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commaai/subscriptions","organizations_url":"https://api.github.com/users/commaai/orgs","repos_url":"https://api.github.com/users/commaai/repos","events_url":"https://api.github.com/users/commaai/events{/privacy}","received_events_url":"https://api.github.com/users/commaai/received_events","type":"Organization","site_admin":false},"repo":{"id":74627617,"node_id":"MDEwOlJlcG9zaXRvcnk3NDYyNzYxNw==","name":"openpilot","full_name":"commaai/openpilot","owner":{"login":"commaai","id":16128714,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTI4NzE0","avatar_url":"https://avatars2.githubusercontent.com/u/16128714?v=4","gravatar_id":"","url":"https://api.github.com/users/commaai","html_url":"https://github.com/commaai","followers_url":"https://api.github.com/users/commaai/followers","following_url":"https://api.github.com/users/commaai/following{/other_user}","gists_url":"https://api.github.com/users/commaai/gists{/gist_id}","starred_url":"https://api.github.com/users/commaai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commaai/subscriptions","organizations_url":"https://api.github.com/users/commaai/orgs","repos_url":"https://api.github.com/users/commaai/repos","events_url":"https://api.github.com/users/commaai/events{/privacy}","received_events_url":"https://api.github.com/users/commaai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/commaai/openpilot","description":"open source driving agent","fork":false,"url":"https://api.github.com/repos/commaai/openpilot","forks_url":"https://api.github.com/repos/commaai/openpilot/forks","keys_url":"https://api.github.com/repos/commaai/openpilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commaai/openpilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commaai/openpilot/teams","hooks_url":"https://api.github.com/repos/commaai/openpilot/hooks","issue_events_url":"https://api.github.com/repos/commaai/openpilot/issues/events{/number}","events_url":"https://api.github.com/repos/commaai/openpilot/events","assignees_url":"https://api.github.com/repos/commaai/openpilot/assignees{/user}","branches_url":"https://api.github.com/repos/commaai/openpilot/branches{/branch}","tags_url":"https://api.github.com/repos/commaai/openpilot/tags","blobs_url":"https://api.github.com/repos/commaai/openpilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commaai/openpilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commaai/openpilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/commaai/openpilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commaai/openpilot/statuses/{sha}","languages_url":"https://api.github.com/repos/commaai/openpilot/languages","stargazers_url":"https://api.github.com/repos/commaai/openpilot/stargazers","contributors_url":"https://api.github.com/repos/commaai/openpilot/contributors","subscribers_url":"https://api.github.com/repos/commaai/openpilot/subscribers","subscription_url":"https://api.github.com/repos/commaai/openpilot/subscription","commits_url":"https://api.github.com/repos/commaai/openpilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/commaai/openpilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/commaai/openpilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/commaai/openpilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/commaai/openpilot/contents/{+path}","compare_url":"https://api.github.com/repos/commaai/openpilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commaai/openpilot/merges","archive_url":"https://api.github.com/repos/commaai/openpilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commaai/openpilot/downloads","issues_url":"https://api.github.com/repos/commaai/openpilot/issues{/number}","pulls_url":"https://api.github.com/repos/commaai/openpilot/pulls{/number}","milestones_url":"https://api.github.com/repos/commaai/openpilot/milestones{/number}","notifications_url":"https://api.github.com/repos/commaai/openpilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commaai/openpilot/labels{/name}","releases_url":"https://api.github.com/repos/commaai/openpilot/releases{/id}","deployments_url":"https://api.github.com/repos/commaai/openpilot/deployments","created_at":"2016-11-24T01:33:30Z","updated_at":"2018-09-10T01:57:55Z","pushed_at":"2018-09-10T05:25:59Z","git_url":"git://github.com/commaai/openpilot.git","ssh_url":"git@github.com:commaai/openpilot.git","clone_url":"https://github.com/commaai/openpilot.git","svn_url":"https://github.com/commaai/openpilot","homepage":"","size":341739,"stargazers_count":8271,"watchers_count":8271,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2007,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2007,"open_issues":85,"watchers":8271,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/commaai/openpilot/pulls/356"},"html":{"href":"https://github.com/commaai/openpilot/pull/356"},"issue":{"href":"https://api.github.com/repos/commaai/openpilot/issues/356"},"comments":{"href":"https://api.github.com/repos/commaai/openpilot/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/commaai/openpilot/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/commaai/openpilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/commaai/openpilot/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/commaai/openpilot/statuses/97f971404b25cb1569b70359f9c71a2fd0e3dd4b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vntarasov"}}