{"action":"created","comment":{"url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments/217982366","pull_request_review_id":155810800,"id":217982366,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzk4MjM2Ng==","diff_hunk":"@@ -114,7 +119,26 @@ private String exportHTML(XWikiContext context) throws XWikiException, IOExcepti\n             name = context.getDoc().getFullName();\n         }\n \n-        Collection<DocumentReference> pageList = resolvePagesToExport(request.getParameterValues(\"pages\"), context);\n+        String[] checkedPages = request.getParameterValues(\"pages\");\n+        String[] uncheckedPages = null;\n+        String checkedPagesRequestValue = request.get(\"checked-pages\");\n+        String uncheckedPagesRequestValue = request.get(\"unchecked-pages\");\n+        String otherPagesRequestValue = request.get(\"other-pages\");\n+\n+        boolean otherPages = false;\n+        if (!StringUtils.isEmpty(otherPagesRequestValue)) {","path":"xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/ExportAction.java","position":38,"original_position":38,"commit_id":"1c9d65f39223f9479928892e9f437a3babde226f","original_commit_id":"a2f328342f4a81893d0c82264670907a89be269e","user":{"login":"mflorea","id":652632,"node_id":"MDQ6VXNlcjY1MjYzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/652632?v=4","gravatar_id":"","url":"https://api.github.com/users/mflorea","html_url":"https://github.com/mflorea","followers_url":"https://api.github.com/users/mflorea/followers","following_url":"https://api.github.com/users/mflorea/following{/other_user}","gists_url":"https://api.github.com/users/mflorea/gists{/gist_id}","starred_url":"https://api.github.com/users/mflorea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mflorea/subscriptions","organizations_url":"https://api.github.com/users/mflorea/orgs","repos_url":"https://api.github.com/users/mflorea/repos","events_url":"https://api.github.com/users/mflorea/events{/privacy}","received_events_url":"https://api.github.com/users/mflorea/received_events","type":"User","site_admin":false},"body":"Yes, you can assign directly ``Boolean.valueOf()``.","created_at":"2018-09-17T08:26:29Z","updated_at":"2018-09-17T08:57:16Z","html_url":"https://github.com/xwiki/xwiki-platform/pull/855#discussion_r217982366","pull_request_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/855","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments/217982366"},"html":{"href":"https://github.com/xwiki/xwiki-platform/pull/855#discussion_r217982366"},"pull_request":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/855"}},"in_reply_to_id":217746191},"pull_request":{"url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/855","id":215599623,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTk5NjIz","html_url":"https://github.com/xwiki/xwiki-platform/pull/855","diff_url":"https://github.com/xwiki/xwiki-platform/pull/855.diff","patch_url":"https://github.com/xwiki/xwiki-platform/pull/855.patch","issue_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues/855","number":855,"state":"open","locked":false,"title":"XWIKI-15444: Fix export UI","user":{"login":"surli","id":1478232,"node_id":"MDQ6VXNlcjE0NzgyMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1478232?v=4","gravatar_id":"","url":"https://api.github.com/users/surli","html_url":"https://github.com/surli","followers_url":"https://api.github.com/users/surli/followers","following_url":"https://api.github.com/users/surli/following{/other_user}","gists_url":"https://api.github.com/users/surli/gists{/gist_id}","starred_url":"https://api.github.com/users/surli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surli/subscriptions","organizations_url":"https://api.github.com/users/surli/orgs","repos_url":"https://api.github.com/users/surli/repos","events_url":"https://api.github.com/users/surli/events{/privacy}","received_events_url":"https://api.github.com/users/surli/received_events","type":"User","site_admin":false},"body":"## Scope of the PR\r\n\r\nThis PR aims at fixing issue XWIKI-15444, specifically 3 different issues have been listed:\r\n 1. The export is not working when \"Other pages\" pagination node is selected,\r\n 2. The export is not working when lot of pages are selected,\r\n 3. The export does not take into account the hidden pages\r\n\r\nThis PR targets issues 1 and 2. \r\n\r\n## Design\r\n\r\nThe main design of the PR is to add new hidden fields to retrieve the complete list of selected / deselected pages, as well as the state of the \"other pages\" pagination node. \r\n\r\nThe `ExportAction` continues to fully support the get request as it was done before, but it also supports post requests with information given in those new fields: then a strategy can be applied based on the state of \"Other pages\" pagination mode.\r\nMoreover, using an input field for the list of selected pages allow to put far more data, than it was when putting this list in the URL.\r\n\r\n## Work to do\r\n\r\nThe tests still needs to be updated to reflect the changes bring there. However I tested it manually and it already fully fix the 2 issues mentioned above. \r\n\r\nI post this PR before it's complete for the review on the design.","created_at":"2018-09-14T13:46:23Z","updated_at":"2018-09-17T08:57:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e75a5927fa0028b2bd41798344e6824b811b776","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/855/commits","review_comments_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/855/comments","review_comment_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues/855/comments","statuses_url":"https://api.github.com/repos/xwiki/xwiki-platform/statuses/1c9d65f39223f9479928892e9f437a3babde226f","head":{"label":"surli:XWIKI-15444","ref":"XWIKI-15444","sha":"1c9d65f39223f9479928892e9f437a3babde226f","user":{"login":"surli","id":1478232,"node_id":"MDQ6VXNlcjE0NzgyMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1478232?v=4","gravatar_id":"","url":"https://api.github.com/users/surli","html_url":"https://github.com/surli","followers_url":"https://api.github.com/users/surli/followers","following_url":"https://api.github.com/users/surli/following{/other_user}","gists_url":"https://api.github.com/users/surli/gists{/gist_id}","starred_url":"https://api.github.com/users/surli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surli/subscriptions","organizations_url":"https://api.github.com/users/surli/orgs","repos_url":"https://api.github.com/users/surli/repos","events_url":"https://api.github.com/users/surli/events{/privacy}","received_events_url":"https://api.github.com/users/surli/received_events","type":"User","site_admin":false},"repo":{"id":142174930,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxNzQ5MzA=","name":"xwiki-platform","full_name":"surli/xwiki-platform","private":false,"owner":{"login":"surli","id":1478232,"node_id":"MDQ6VXNlcjE0NzgyMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1478232?v=4","gravatar_id":"","url":"https://api.github.com/users/surli","html_url":"https://github.com/surli","followers_url":"https://api.github.com/users/surli/followers","following_url":"https://api.github.com/users/surli/following{/other_user}","gists_url":"https://api.github.com/users/surli/gists{/gist_id}","starred_url":"https://api.github.com/users/surli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surli/subscriptions","organizations_url":"https://api.github.com/users/surli/orgs","repos_url":"https://api.github.com/users/surli/repos","events_url":"https://api.github.com/users/surli/events{/privacy}","received_events_url":"https://api.github.com/users/surli/received_events","type":"User","site_admin":false},"html_url":"https://github.com/surli/xwiki-platform","description":"The XWiki platform","fork":true,"url":"https://api.github.com/repos/surli/xwiki-platform","forks_url":"https://api.github.com/repos/surli/xwiki-platform/forks","keys_url":"https://api.github.com/repos/surli/xwiki-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/surli/xwiki-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/surli/xwiki-platform/teams","hooks_url":"https://api.github.com/repos/surli/xwiki-platform/hooks","issue_events_url":"https://api.github.com/repos/surli/xwiki-platform/issues/events{/number}","events_url":"https://api.github.com/repos/surli/xwiki-platform/events","assignees_url":"https://api.github.com/repos/surli/xwiki-platform/assignees{/user}","branches_url":"https://api.github.com/repos/surli/xwiki-platform/branches{/branch}","tags_url":"https://api.github.com/repos/surli/xwiki-platform/tags","blobs_url":"https://api.github.com/repos/surli/xwiki-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/surli/xwiki-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/surli/xwiki-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/surli/xwiki-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/surli/xwiki-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/surli/xwiki-platform/languages","stargazers_url":"https://api.github.com/repos/surli/xwiki-platform/stargazers","contributors_url":"https://api.github.com/repos/surli/xwiki-platform/contributors","subscribers_url":"https://api.github.com/repos/surli/xwiki-platform/subscribers","subscription_url":"https://api.github.com/repos/surli/xwiki-platform/subscription","commits_url":"https://api.github.com/repos/surli/xwiki-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/surli/xwiki-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/surli/xwiki-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/surli/xwiki-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/surli/xwiki-platform/contents/{+path}","compare_url":"https://api.github.com/repos/surli/xwiki-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/surli/xwiki-platform/merges","archive_url":"https://api.github.com/repos/surli/xwiki-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/surli/xwiki-platform/downloads","issues_url":"https://api.github.com/repos/surli/xwiki-platform/issues{/number}","pulls_url":"https://api.github.com/repos/surli/xwiki-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/surli/xwiki-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/surli/xwiki-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/surli/xwiki-platform/labels{/name}","releases_url":"https://api.github.com/repos/surli/xwiki-platform/releases{/id}","deployments_url":"https://api.github.com/repos/surli/xwiki-platform/deployments","created_at":"2018-07-24T15:03:25Z","updated_at":"2018-07-24T15:03:55Z","pushed_at":"2018-09-14T15:55:43Z","git_url":"git://github.com/surli/xwiki-platform.git","ssh_url":"git@github.com:surli/xwiki-platform.git","clone_url":"https://github.com/surli/xwiki-platform.git","svn_url":"https://github.com/surli/xwiki-platform","homepage":"http://platform.xwiki.org/","size":329644,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xwiki:master","ref":"master","sha":"5e91bd32bdadf3289c1ac4254844c783ba4bd758","user":{"login":"xwiki","id":488445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4ODQ0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/488445?v=4","gravatar_id":"","url":"https://api.github.com/users/xwiki","html_url":"https://github.com/xwiki","followers_url":"https://api.github.com/users/xwiki/followers","following_url":"https://api.github.com/users/xwiki/following{/other_user}","gists_url":"https://api.github.com/users/xwiki/gists{/gist_id}","starred_url":"https://api.github.com/users/xwiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwiki/subscriptions","organizations_url":"https://api.github.com/users/xwiki/orgs","repos_url":"https://api.github.com/users/xwiki/repos","events_url":"https://api.github.com/users/xwiki/events{/privacy}","received_events_url":"https://api.github.com/users/xwiki/received_events","type":"Organization","site_admin":false},"repo":{"id":1463490,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzNDkw","name":"xwiki-platform","full_name":"xwiki/xwiki-platform","private":false,"owner":{"login":"xwiki","id":488445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4ODQ0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/488445?v=4","gravatar_id":"","url":"https://api.github.com/users/xwiki","html_url":"https://github.com/xwiki","followers_url":"https://api.github.com/users/xwiki/followers","following_url":"https://api.github.com/users/xwiki/following{/other_user}","gists_url":"https://api.github.com/users/xwiki/gists{/gist_id}","starred_url":"https://api.github.com/users/xwiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwiki/subscriptions","organizations_url":"https://api.github.com/users/xwiki/orgs","repos_url":"https://api.github.com/users/xwiki/repos","events_url":"https://api.github.com/users/xwiki/events{/privacy}","received_events_url":"https://api.github.com/users/xwiki/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xwiki/xwiki-platform","description":"The XWiki platform","fork":false,"url":"https://api.github.com/repos/xwiki/xwiki-platform","forks_url":"https://api.github.com/repos/xwiki/xwiki-platform/forks","keys_url":"https://api.github.com/repos/xwiki/xwiki-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwiki/xwiki-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwiki/xwiki-platform/teams","hooks_url":"https://api.github.com/repos/xwiki/xwiki-platform/hooks","issue_events_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues/events{/number}","events_url":"https://api.github.com/repos/xwiki/xwiki-platform/events","assignees_url":"https://api.github.com/repos/xwiki/xwiki-platform/assignees{/user}","branches_url":"https://api.github.com/repos/xwiki/xwiki-platform/branches{/branch}","tags_url":"https://api.github.com/repos/xwiki/xwiki-platform/tags","blobs_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwiki/xwiki-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/xwiki/xwiki-platform/languages","stargazers_url":"https://api.github.com/repos/xwiki/xwiki-platform/stargazers","contributors_url":"https://api.github.com/repos/xwiki/xwiki-platform/contributors","subscribers_url":"https://api.github.com/repos/xwiki/xwiki-platform/subscribers","subscription_url":"https://api.github.com/repos/xwiki/xwiki-platform/subscription","commits_url":"https://api.github.com/repos/xwiki/xwiki-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwiki/xwiki-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwiki/xwiki-platform/contents/{+path}","compare_url":"https://api.github.com/repos/xwiki/xwiki-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwiki/xwiki-platform/merges","archive_url":"https://api.github.com/repos/xwiki/xwiki-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwiki/xwiki-platform/downloads","issues_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues{/number}","pulls_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/xwiki/xwiki-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/xwiki/xwiki-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwiki/xwiki-platform/labels{/name}","releases_url":"https://api.github.com/repos/xwiki/xwiki-platform/releases{/id}","deployments_url":"https://api.github.com/repos/xwiki/xwiki-platform/deployments","created_at":"2011-03-10T13:26:41Z","updated_at":"2018-09-17T08:16:22Z","pushed_at":"2018-09-17T08:16:14Z","git_url":"git://github.com/xwiki/xwiki-platform.git","ssh_url":"git@github.com:xwiki/xwiki-platform.git","clone_url":"https://github.com/xwiki/xwiki-platform.git","svn_url":"https://github.com/xwiki/xwiki-platform","homepage":"http://platform.xwiki.org/","size":330087,"stargazers_count":339,"watchers_count":339,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":276,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":276,"open_issues":41,"watchers":339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/855"},"html":{"href":"https://github.com/xwiki/xwiki-platform/pull/855"},"issue":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/issues/855"},"comments":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/issues/855/comments"},"review_comments":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/855/comments"},"review_comment":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/855/commits"},"statuses":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/statuses/1c9d65f39223f9479928892e9f437a3babde226f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mflorea"}}