{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/200836243","pull_request_review_id":135228627,"id":200836243,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDgzNjI0Mw==","diff_hunk":"@@ -47,15 +48,23 @@ var logout = function() {\n // that this will fail if the user already has a username.\n var _completeSignup = function(username) {\n   browser.get('/signup?return_url=http%3A%2F%2Flocalhost%3A9001%2F');\n-  element(by.css('.protractor-test-username-input')).sendKeys(username);\n-  element(by.css('.protractor-test-agree-to-terms-checkbox')).click();\n-  element(by.css('.protractor-test-register-user')).click();\n+  general.waitForLoadingMessage();\n+  var usernameInput = element(by.css('.protractor-test-username-input'));\n+  var agreeToTermsCheckbox = element(\n+    by.css('.protractor-test-agree-to-terms-checkbox'));\n+  var registerUser = element(by.css('.protractor-test-register-user'));\n+  browser.wait(until.visibilityOf(usernameInput), 5000);\n+  usernameInput.sendKeys(username);\n+  agreeToTermsCheckbox.click();\n+  registerUser.click();\n+  general.waitForLoadingMessage();\n };\n \n var createUser = function(email, username) {\n-  login(email);\n-  _completeSignup(username);\n-  general.waitForSystem();\n+  createAndLoginUser(email, username);\n+  // Transitioning to non - Angular login page. Need to completely wait out","path":"core/tests/protractor_utils/users.js","position":35,"original_position":35,"commit_id":"6e638bb98f783995a850835466419befedb2d3e0","original_commit_id":"6e638bb98f783995a850835466419befedb2d3e0","user":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"body":"Fixed!","created_at":"2018-07-08T10:31:00Z","updated_at":"2018-07-08T10:31:00Z","html_url":"https://github.com/oppia/oppia/pull/5139#discussion_r200836243","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/5139","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/200836243"},"html":{"href":"https://github.com/oppia/oppia/pull/5139#discussion_r200836243"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5139"}},"in_reply_to_id":200830045},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5139","id":196798471,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2Nzk4NDcx","html_url":"https://github.com/oppia/oppia/pull/5139","diff_url":"https://github.com/oppia/oppia/pull/5139.diff","patch_url":"https://github.com/oppia/oppia/pull/5139.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5139","number":5139,"state":"closed","locked":false,"title":"Fix part of #3954: Exploration Editor Page Object","user":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"body":"<!--\r\n  - Thanks for submitting code to Oppia! Please fill out the following as part of\r\n  - your pull request so we can review your code more easily.\r\n  -->\r\n\r\n## Explanation\r\n<!--\r\n  - Explain what your PR does. If this PR fixes an existing bug, please include \r\n  - \"Fixes #bugnum:\" in the explanation so that GitHub can auto-close the issue \r\n  - when this PR is merged.\r\n  -->\r\n#3954 This PR refactors `editor.js` in various e2e test suite into its own ExplorationEditorPage.\r\n- [x] editorAndPlayer.js\r\n- [x] editorFeatures.js\r\n- [x] embedding.js\r\n- [x] extensions.js\r\n- [x] learnerDashboard.js\r\n- [x] stateEditor.js\r\n- [x] userJourney.js\r\n- [x] workflow.js\r\n- [x] general.js\r\n## Checklist\r\n- [x] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes.\r\n- [x] The PR explanation includes the words \"Fixes #bugnum: ...\".\r\n- [x] The linter/Karma presubmit checks have passed.\r\n  - These should run automatically, but if not, you can manually trigger them locally using `python scripts/pre_commit_linter.py` and `bash scripts/run_frontend_tests.sh`.\r\n- [x] The PR is made from a branch that's **not** called \"develop\".\r\n- [x] The PR follows the [style guide](https://github.com/oppia/oppia/wiki/Coding-style-guide).\r\n- [ ] The PR is assigned to an appropriate reviewer.\r\n  - If you're a new contributor, please ask on [Gitter](https://gitter.im/oppia/oppia-chat) for someone to assign a reviewer.\r\n  - If you're not sure who the appropriate reviewer is, please assign to the issue's \"owner\" -- see the \"talk-to\" label on the issue.\r\n","created_at":"2018-06-22T17:26:11Z","updated_at":"2018-07-08T10:31:00Z","closed_at":"2018-07-08T05:56:31Z","merged_at":"2018-07-08T05:56:31Z","merge_commit_sha":"36949e2f4e3d5690ff9f4ded0163410af7cb018d","assignee":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"assignees":[{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"BenHenning","id":12983742,"node_id":"MDQ6VXNlcjEyOTgzNzQy","avatar_url":"https://avatars3.githubusercontent.com/u/12983742?v=4","gravatar_id":"","url":"https://api.github.com/users/BenHenning","html_url":"https://github.com/BenHenning","followers_url":"https://api.github.com/users/BenHenning/followers","following_url":"https://api.github.com/users/BenHenning/following{/other_user}","gists_url":"https://api.github.com/users/BenHenning/gists{/gist_id}","starred_url":"https://api.github.com/users/BenHenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenHenning/subscriptions","organizations_url":"https://api.github.com/users/BenHenning/orgs","repos_url":"https://api.github.com/users/BenHenning/repos","events_url":"https://api.github.com/users/BenHenning/events{/privacy}","received_events_url":"https://api.github.com/users/BenHenning/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/5139/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/5139/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5139/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/6e638bb98f783995a850835466419befedb2d3e0","head":{"label":"hoangviet1993:ExplorationEditorPage","ref":"ExplorationEditorPage","sha":"6e638bb98f783995a850835466419befedb2d3e0","user":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"repo":{"id":136071092,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwNzEwOTI=","name":"oppia","full_name":"hoangviet1993/oppia","owner":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoangviet1993/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/hoangviet1993/oppia","forks_url":"https://api.github.com/repos/hoangviet1993/oppia/forks","keys_url":"https://api.github.com/repos/hoangviet1993/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoangviet1993/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoangviet1993/oppia/teams","hooks_url":"https://api.github.com/repos/hoangviet1993/oppia/hooks","issue_events_url":"https://api.github.com/repos/hoangviet1993/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/hoangviet1993/oppia/events","assignees_url":"https://api.github.com/repos/hoangviet1993/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/hoangviet1993/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/hoangviet1993/oppia/tags","blobs_url":"https://api.github.com/repos/hoangviet1993/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoangviet1993/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoangviet1993/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoangviet1993/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoangviet1993/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/hoangviet1993/oppia/languages","stargazers_url":"https://api.github.com/repos/hoangviet1993/oppia/stargazers","contributors_url":"https://api.github.com/repos/hoangviet1993/oppia/contributors","subscribers_url":"https://api.github.com/repos/hoangviet1993/oppia/subscribers","subscription_url":"https://api.github.com/repos/hoangviet1993/oppia/subscription","commits_url":"https://api.github.com/repos/hoangviet1993/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoangviet1993/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoangviet1993/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoangviet1993/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoangviet1993/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/hoangviet1993/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoangviet1993/oppia/merges","archive_url":"https://api.github.com/repos/hoangviet1993/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoangviet1993/oppia/downloads","issues_url":"https://api.github.com/repos/hoangviet1993/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/hoangviet1993/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/hoangviet1993/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/hoangviet1993/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoangviet1993/oppia/labels{/name}","releases_url":"https://api.github.com/repos/hoangviet1993/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/hoangviet1993/oppia/deployments","created_at":"2018-06-04T19:09:54Z","updated_at":"2018-07-06T15:40:40Z","pushed_at":"2018-07-07T19:21:28Z","git_url":"git://github.com/hoangviet1993/oppia.git","ssh_url":"git@github.com:hoangviet1993/oppia.git","clone_url":"https://github.com/hoangviet1993/oppia.git","svn_url":"https://github.com/hoangviet1993/oppia","homepage":"https://www.oppia.org","size":105193,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"82d9dde80026918926e518063c396684f0739fcf","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"node_id":"MDEwOlJlcG9zaXRvcnk0MDY4NzU2Mw==","name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-07-08T06:07:14Z","pushed_at":"2018-07-08T08:17:20Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":105024,"stargazers_count":682,"watchers_count":682,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":652,"mirror_url":null,"archived":false,"open_issues_count":331,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":652,"open_issues":331,"watchers":682,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5139"},"html":{"href":"https://github.com/oppia/oppia/pull/5139"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/5139"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/5139/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5139/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5139/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/6e638bb98f783995a850835466419befedb2d3e0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hoangviet1993"}}