{"action":"opened","issue":{"url":"https://api.github.com/repos/robincornett/genesis-accessible/issues/33","repository_url":"https://api.github.com/repos/robincornett/genesis-accessible","labels_url":"https://api.github.com/repos/robincornett/genesis-accessible/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/robincornett/genesis-accessible/issues/33/comments","events_url":"https://api.github.com/repos/robincornett/genesis-accessible/issues/33/events","html_url":"https://github.com/robincornett/genesis-accessible/issues/33","id":363469687,"node_id":"MDU6SXNzdWUzNjM0Njk2ODc=","number":33,"title":"Add PHPCS support","user":{"login":"GaryJones","id":88371,"node_id":"MDQ6VXNlcjg4Mzcx","avatar_url":"https://avatars2.githubusercontent.com/u/88371?v=4","gravatar_id":"","url":"https://api.github.com/users/GaryJones","html_url":"https://github.com/GaryJones","followers_url":"https://api.github.com/users/GaryJones/followers","following_url":"https://api.github.com/users/GaryJones/following{/other_user}","gists_url":"https://api.github.com/users/GaryJones/gists{/gist_id}","starred_url":"https://api.github.com/users/GaryJones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaryJones/subscriptions","organizations_url":"https://api.github.com/users/GaryJones/orgs","repos_url":"https://api.github.com/users/GaryJones/repos","events_url":"https://api.github.com/users/GaryJones/events{/privacy}","received_events_url":"https://api.github.com/users/GaryJones/received_events","type":"User","site_admin":false},"labels":[{"id":83998364,"node_id":"MDU6TGFiZWw4Mzk5ODM2NA==","url":"https://api.github.com/repos/robincornett/genesis-accessible/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"GaryJones","id":88371,"node_id":"MDQ6VXNlcjg4Mzcx","avatar_url":"https://avatars2.githubusercontent.com/u/88371?v=4","gravatar_id":"","url":"https://api.github.com/users/GaryJones","html_url":"https://github.com/GaryJones","followers_url":"https://api.github.com/users/GaryJones/followers","following_url":"https://api.github.com/users/GaryJones/following{/other_user}","gists_url":"https://api.github.com/users/GaryJones/gists{/gist_id}","starred_url":"https://api.github.com/users/GaryJones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaryJones/subscriptions","organizations_url":"https://api.github.com/users/GaryJones/orgs","repos_url":"https://api.github.com/users/GaryJones/repos","events_url":"https://api.github.com/users/GaryJones/events{/privacy}","received_events_url":"https://api.github.com/users/GaryJones/received_events","type":"User","site_admin":false},"assignees":[{"login":"GaryJones","id":88371,"node_id":"MDQ6VXNlcjg4Mzcx","avatar_url":"https://avatars2.githubusercontent.com/u/88371?v=4","gravatar_id":"","url":"https://api.github.com/users/GaryJones","html_url":"https://github.com/GaryJones","followers_url":"https://api.github.com/users/GaryJones/followers","following_url":"https://api.github.com/users/GaryJones/following{/other_user}","gists_url":"https://api.github.com/users/GaryJones/gists{/gist_id}","starred_url":"https://api.github.com/users/GaryJones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaryJones/subscriptions","organizations_url":"https://api.github.com/users/GaryJones/orgs","repos_url":"https://api.github.com/users/GaryJones/repos","events_url":"https://api.github.com/users/GaryJones/events{/privacy}","received_events_url":"https://api.github.com/users/GaryJones/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-09-25T08:43:45Z","updated_at":"2018-09-25T08:43:45Z","closed_at":null,"author_association":"COLLABORATOR","body":"Adding PHPCS support locally, I see the following in reports:\r\n\r\n<details>\r\n\r\n<summary>Summary Report</summary>\r\n\r\n```\r\nPHP CODE SNIFFER VIOLATION SOURCE SUMMARY\r\n---------------------------------------------------------------------------\r\n    SOURCE                                                            COUNT\r\n---------------------------------------------------------------------------\r\n[x] Generic.Commenting.DocComment.SpacingBeforeTags                   22\r\n[x] WordPress.WhiteSpace.ControlStructureSpacing.BlankLineAfterStart  18\r\n[ ] Squiz.Commenting.InlineComment.InvalidEndChar                     17\r\n[ ] WordPress.Security.EscapeOutput.UnsafePrintingFunction            11\r\n[ ] Squiz.Commenting.FunctionComment.MissingParamName                 10\r\n[ ] Squiz.Commenting.FunctionComment.MissingParamTag                  10\r\n[x] PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket      9\r\n[ ] Squiz.Commenting.FileComment.MissingPackageTag                    9\r\n[ ] WordPress.Security.EscapeOutput.OutputNotEscaped                  9\r\n[ ] Generic.Commenting.DocComment.ShortNotCapital                     8\r\n[x] Generic.Commenting.DocComment.SpacingAfter                        8\r\n[x] WordPress.WhiteSpace.ControlStructureSpacing.BlankLineBeforeEnd   8\r\n[x] PEAR.Functions.FunctionCallSignature.CloseBracketLine             6\r\n[x] Squiz.Commenting.InlineComment.NoSpaceBefore                      6\r\n[x] PEAR.Functions.FunctionCallSignature.MultipleArguments            5\r\n[ ] Squiz.Commenting.FileComment.Missing                              4\r\n[ ] WordPress.PHP.StrictComparisons.LooseComparison                   4\r\n[ ] WordPress.WP.AlternativeFunctions.strip_tags_strip_tags           4\r\n[ ] Squiz.Commenting.FunctionComment.MissingParamComment              2\r\n[ ] WordPress.Files.FileName.InvalidClassFileName                     2\r\n[ ] WordPress.PHP.StrictInArray.MissingTrueStrict                     2\r\n[x] Squiz.Commenting.BlockComment.NoNewLine                           1\r\n[ ] Squiz.Commenting.ClassComment.SpacingAfter                        1\r\n[ ] Squiz.Commenting.FileComment.DuplicateAuthorTag                   1\r\n[ ] Squiz.Commenting.FileComment.SpacingAfterComment                  1\r\n[ ] Squiz.Commenting.FileComment.WrongStyle                           1\r\n[ ] Squiz.Commenting.FunctionComment.Missing                          1\r\n[x] Squiz.Commenting.FunctionComment.SpacingAfterParamType            1\r\n[x] Squiz.Commenting.InlineComment.SpacingAfter                       1\r\n[ ] Squiz.PHP.CommentedOutCode.Found                                  1\r\n[x] Squiz.PHP.EmbeddedPhp.ContentBeforeOpen                           1\r\n[ ] WordPress.Security.NonceVerification.NoNonceVerification          1\r\n[ ] WordPress.WP.I18n.MissingTranslatorsComment                       1\r\n---------------------------------------------------------------------------\r\nA TOTAL OF 186 SNIFF VIOLATIONS WERE FOUND IN 33 SOURCES\r\n---------------------------------------------------------------------------\r\nPHPCBF CAN FIX THE 12 MARKED SOURCES AUTOMATICALLY (86 VIOLATIONS IN TOTAL)\r\n---------------------------------------------------------------------------\r\n\r\nTime: 740ms; Memory: 10Mb\r\n```\r\n</details>\r\n\r\n<details>\r\n<summary>Gitblame Report</summary>\r\n\r\n```\r\nPHP CODE SNIFFER GIT BLAME SUMMARY\r\n-------------------------------------------------------------------------------------------------------\r\nAUTHOR   SOURCE                                                            (Author %) (Overall %) COUNT\r\n-------------------------------------------------------------------------------------------------------\r\nUnknown                                                                       (90.12)     (90.86)   169\r\n         [x] Generic.Commenting.DocComment.SpacingBeforeTags                                         20\r\n         [x] WordPress.WhiteSpace.ControlStructureSpacing.BlankLineAfterStart                        17\r\n         [ ] WordPress.Security.EscapeOutput.UnsafePrintingFunction                                  11\r\n         [ ] Squiz.Commenting.FunctionComment.MissingParamName                                       10\r\n         [ ] Squiz.Commenting.FunctionComment.MissingParamTag                                        10\r\n         [ ] Squiz.Commenting.InlineComment.InvalidEndChar                                           10\r\n         [ ] Squiz.Commenting.FileComment.MissingPackageTag                                           9\r\n         [ ] WordPress.Security.EscapeOutput.OutputNotEscaped                                         9\r\n         [x] WordPress.WhiteSpace.ControlStructureSpacing.BlankLineBeforeEnd                          8\r\n         [x] PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket                             8\r\n         [x] Generic.Commenting.DocComment.SpacingAfter                                               8\r\n         [ ] Generic.Commenting.DocComment.ShortNotCapital                                            8\r\n         [x] PEAR.Functions.FunctionCallSignature.CloseBracketLine                                    6\r\n         [x] Squiz.Commenting.InlineComment.NoSpaceBefore                                             5\r\n         [x] PEAR.Functions.FunctionCallSignature.MultipleArguments                                   5\r\n         [ ] WordPress.PHP.StrictComparisons.LooseComparison                                          4\r\n         [ ] WordPress.WP.AlternativeFunctions.strip_tags_strip_tags                                  4\r\n         [ ] Squiz.Commenting.FileComment.Missing                                                     4\r\n         [ ] WordPress.PHP.StrictInArray.MissingTrueStrict                                            2\r\n         [ ] WordPress.Files.FileName.InvalidClassFileName                                            2\r\n         [ ] Squiz.Commenting.FunctionComment.MissingParamComment                                     2\r\n         [x] Squiz.PHP.EmbeddedPhp.ContentBeforeOpen                                                  1\r\n         [x] Squiz.Commenting.InlineComment.SpacingAfter                                              1\r\n         [x] Squiz.Commenting.FunctionComment.SpacingAfterParamType                                   1\r\n         [ ] Squiz.Commenting.FileComment.SpacingAfterComment                                         1\r\n         [ ] WordPress.WP.I18n.MissingTranslatorsComment                                              1\r\n         [ ] Squiz.Commenting.FunctionComment.Missing                                                 1\r\n         [ ] Squiz.Commenting.ClassComment.SpacingAfter                                               1\r\nRobin Cornett                                                                 (17.14)      (7.53)    14\r\n         [ ] Squiz.Commenting.InlineComment.InvalidEndChar                                            7\r\n         [x] PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket                             1\r\n         [x] WordPress.WhiteSpace.ControlStructureSpacing.BlankLineAfterStart                         1\r\n         [x] Generic.Commenting.DocComment.SpacingBeforeTags                                          1\r\n         [x] Squiz.Commenting.InlineComment.NoSpaceBefore                                             1\r\n         [ ] WordPress.Security.NonceVerification.NoNonceVerification                                 1\r\n         [ ] Squiz.PHP.CommentedOutCode.Found                                                         1\r\n         [ ] Squiz.Commenting.FileComment.DuplicateAuthorTag                                          1\r\nRian Rietveld                                                                  (2.04)      (1.61)     3\r\n         [x] Generic.Commenting.DocComment.SpacingBeforeTags                                          1\r\n         [x] Squiz.Commenting.BlockComment.NoNewLine                                                  1\r\n         [ ] Squiz.Commenting.FileComment.WrongStyle                                                  1\r\n-------------------------------------------------------------------------------------------------------\r\nA TOTAL OF 186 SNIFF VIOLATIONS WERE COMMITTED BY 3 AUTHORS\r\n-------------------------------------------------------------------------------------------------------\r\nPHPCBF CAN FIX THE 17 MARKED SOURCES AUTOMATICALLY (86 VIOLATIONS IN TOTAL)\r\n-------------------------------------------------------------------------------------------------------\r\n\r\nTime: 776ms; Memory: 10Mb\r\n```\r\n</details>\r\n\r\n  \r\nAdding PHPCS in as a development dependency will allow these violations to more easily be addressed."}}
{"actor":{"display_login":"GaryJones"}}