{"action":"created","comment":{"url":"https://api.github.com/repos/rubyforgood/diaper/pulls/comments/175126014","pull_request_review_id":104610234,"id":175126014,"diff_hunk":"@@ -1,41 +1,40 @@\n RSpec.feature \"Transfer management\", type: :feature do\n-before do\n-  sign_in(@user)\n-end\n-let!(:url_prefix) { \"/#{@organization.to_param}\" }\n-\n-scenario \"User can transfer an inventory from a storage location to another\" do\n-  from_storage_location = create(:storage_location, :with_items, name: \"From me\", organization: @organization)\n-  to_storage_location = create(:storage_location, :with_items, name: \"To me\", organization: @organization)\n-  visit url_prefix + \"/transfers\"\n-  click_link \"New Transfer\"\n-  select from_storage_location.name, from: \"From storage location\"\n-  select to_storage_location.name, from: \"To storage location\"\n-  fill_in \"Comment\", with: \"something\"\n-  select from_storage_location.items.first.name, from: \"transfer_line_items_attributes_0_item_id\"\n-  fill_in \"transfer_line_items_attributes_0_quantity\", with: \"10\"\n-  click_button \"Create Transfer\"\n-\n-  expect(page).to have_content(\"Transfer was successfully created\")\n-end\n-\n-scenario \"User can filter the #index by storage location both from and to\" do\n-  from_storage_location = create(:storage_location, name: \"here\", organization: @organization)\n-  to_storage_location = create(:storage_location, name: \"there\", organization: @organization)\n-  transfer = create(:transfer, organization: @organization, from: from_storage_location, to: to_storage_location)\n-  transfer2 = create(:transfer, organization: @organization, from: to_storage_location, to: from_storage_location)\n-\n-  visit url_prefix + \"/transfers\"\n-  select to_storage_location.name, from: \"filters_to_location\"\n-  click_button \"Filter\"\n-\n-  expect(page).to have_css(\"table tr\", count: 2)\n-\n-  visit url_prefix + \"/transfers\"\n-  select from_storage_location.name, from: \"filters_from_location\"\n-  click_button \"Filter\"\n-\n-  expect(page).to have_css(\"table tr\", count: 2)\n-end\n-\n+  before do\n+    sign_in(@user)\n+  end\n+  let!(:url_prefix) { \"/#{@organization.to_param}\" }\n+\n+  scenario \"User can transfer an inventory from a storage location to another\" do","path":"spec/features/transfer_spec.rb","position":46,"original_position":46,"commit_id":"ae9b83e5c48aaeed2341f0a7773f567bc85aa30e","original_commit_id":"ae9b83e5c48aaeed2341f0a7773f567bc85aa30e","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line is too long. [81/80]","created_at":"2018-03-16T15:26:57Z","updated_at":"2018-03-16T15:26:58Z","html_url":"https://github.com/rubyforgood/diaper/pull/292#discussion_r175126014","pull_request_url":"https://api.github.com/repos/rubyforgood/diaper/pulls/292","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rubyforgood/diaper/pulls/comments/175126014"},"html":{"href":"https://github.com/rubyforgood/diaper/pull/292#discussion_r175126014"},"pull_request":{"href":"https://api.github.com/repos/rubyforgood/diaper/pulls/292"}}},"pull_request":{"url":"https://api.github.com/repos/rubyforgood/diaper/pulls/292","id":174973577,"html_url":"https://github.com/rubyforgood/diaper/pull/292","diff_url":"https://github.com/rubyforgood/diaper/pull/292.diff","patch_url":"https://github.com/rubyforgood/diaper/pull/292.patch","issue_url":"https://api.github.com/repos/rubyforgood/diaper/issues/292","number":292,"state":"open","locked":false,"title":"Linting (continued)","user":{"login":"dacur","id":4250366,"avatar_url":"https://avatars3.githubusercontent.com/u/4250366?v=4","gravatar_id":"","url":"https://api.github.com/users/dacur","html_url":"https://github.com/dacur","followers_url":"https://api.github.com/users/dacur/followers","following_url":"https://api.github.com/users/dacur/following{/other_user}","gists_url":"https://api.github.com/users/dacur/gists{/gist_id}","starred_url":"https://api.github.com/users/dacur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dacur/subscriptions","organizations_url":"https://api.github.com/users/dacur/orgs","repos_url":"https://api.github.com/users/dacur/repos","events_url":"https://api.github.com/users/dacur/events{/privacy}","received_events_url":"https://api.github.com/users/dacur/received_events","type":"User","site_admin":false},"body":"Partially resolves #207 \r\n\r\nSee also PR #290 for more information.\r\n\r\n### Description\r\n\r\n@armahillo and I are working on linting the entire project.  This PR is a step in that direction, but does not fully complete linting.  There are approximately 300 issues left that will have to be manually fixed (or ignored using rubocop's commenting system that allows you to skip lines/files). \r\n\r\nThis is a breaking change because Travis will still fail until we are done linting the project.\r\n\r\n@armahillo I believe this also includes some new code that may or may not have been in the `rubocop` branch when you created it.  I apologize if that messes things up for what you were wanting - let me know if you want any changes made.  I ran the auto-correct command (`rubocop --auto-correct`) and then looked over every change that it made.  😄  I may have fetched master and then merged it into this branch - I had some issues getting it set up locally, so I'm not 100% sure.\r\n\r\n### Type of change\r\n\r\n* New feature (non-breaking change which adds functionality)\r\n* Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n### How Has This Been Tested?\r\n\r\nManually running rubocop locally.  All specs are still green.  Travis will most likely still fail.\r\n","created_at":"2018-03-14T14:30:37Z","updated_at":"2018-03-16T15:26:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"276df91458e7f560562ccfa3a0b5fd4587a34d51","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubyforgood/diaper/pulls/292/commits","review_comments_url":"https://api.github.com/repos/rubyforgood/diaper/pulls/292/comments","review_comment_url":"https://api.github.com/repos/rubyforgood/diaper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubyforgood/diaper/issues/292/comments","statuses_url":"https://api.github.com/repos/rubyforgood/diaper/statuses/ae9b83e5c48aaeed2341f0a7773f567bc85aa30e","head":{"label":"dacur:rubocop","ref":"rubocop","sha":"ae9b83e5c48aaeed2341f0a7773f567bc85aa30e","user":{"login":"dacur","id":4250366,"avatar_url":"https://avatars3.githubusercontent.com/u/4250366?v=4","gravatar_id":"","url":"https://api.github.com/users/dacur","html_url":"https://github.com/dacur","followers_url":"https://api.github.com/users/dacur/followers","following_url":"https://api.github.com/users/dacur/following{/other_user}","gists_url":"https://api.github.com/users/dacur/gists{/gist_id}","starred_url":"https://api.github.com/users/dacur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dacur/subscriptions","organizations_url":"https://api.github.com/users/dacur/orgs","repos_url":"https://api.github.com/users/dacur/repos","events_url":"https://api.github.com/users/dacur/events{/privacy}","received_events_url":"https://api.github.com/users/dacur/received_events","type":"User","site_admin":false},"repo":{"id":123623842,"name":"diaper","full_name":"dacur/diaper","owner":{"login":"dacur","id":4250366,"avatar_url":"https://avatars3.githubusercontent.com/u/4250366?v=4","gravatar_id":"","url":"https://api.github.com/users/dacur","html_url":"https://github.com/dacur","followers_url":"https://api.github.com/users/dacur/followers","following_url":"https://api.github.com/users/dacur/following{/other_user}","gists_url":"https://api.github.com/users/dacur/gists{/gist_id}","starred_url":"https://api.github.com/users/dacur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dacur/subscriptions","organizations_url":"https://api.github.com/users/dacur/orgs","repos_url":"https://api.github.com/users/dacur/repos","events_url":"https://api.github.com/users/dacur/events{/privacy}","received_events_url":"https://api.github.com/users/dacur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dacur/diaper","description":"Diaperbase is an inventory system for diaper banks, to aid them in tracking their inventory and providing statistics about their inventory flows.","fork":true,"url":"https://api.github.com/repos/dacur/diaper","forks_url":"https://api.github.com/repos/dacur/diaper/forks","keys_url":"https://api.github.com/repos/dacur/diaper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dacur/diaper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dacur/diaper/teams","hooks_url":"https://api.github.com/repos/dacur/diaper/hooks","issue_events_url":"https://api.github.com/repos/dacur/diaper/issues/events{/number}","events_url":"https://api.github.com/repos/dacur/diaper/events","assignees_url":"https://api.github.com/repos/dacur/diaper/assignees{/user}","branches_url":"https://api.github.com/repos/dacur/diaper/branches{/branch}","tags_url":"https://api.github.com/repos/dacur/diaper/tags","blobs_url":"https://api.github.com/repos/dacur/diaper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dacur/diaper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dacur/diaper/git/refs{/sha}","trees_url":"https://api.github.com/repos/dacur/diaper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dacur/diaper/statuses/{sha}","languages_url":"https://api.github.com/repos/dacur/diaper/languages","stargazers_url":"https://api.github.com/repos/dacur/diaper/stargazers","contributors_url":"https://api.github.com/repos/dacur/diaper/contributors","subscribers_url":"https://api.github.com/repos/dacur/diaper/subscribers","subscription_url":"https://api.github.com/repos/dacur/diaper/subscription","commits_url":"https://api.github.com/repos/dacur/diaper/commits{/sha}","git_commits_url":"https://api.github.com/repos/dacur/diaper/git/commits{/sha}","comments_url":"https://api.github.com/repos/dacur/diaper/comments{/number}","issue_comment_url":"https://api.github.com/repos/dacur/diaper/issues/comments{/number}","contents_url":"https://api.github.com/repos/dacur/diaper/contents/{+path}","compare_url":"https://api.github.com/repos/dacur/diaper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dacur/diaper/merges","archive_url":"https://api.github.com/repos/dacur/diaper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dacur/diaper/downloads","issues_url":"https://api.github.com/repos/dacur/diaper/issues{/number}","pulls_url":"https://api.github.com/repos/dacur/diaper/pulls{/number}","milestones_url":"https://api.github.com/repos/dacur/diaper/milestones{/number}","notifications_url":"https://api.github.com/repos/dacur/diaper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dacur/diaper/labels{/name}","releases_url":"https://api.github.com/repos/dacur/diaper/releases{/id}","deployments_url":"https://api.github.com/repos/dacur/diaper/deployments","created_at":"2018-03-02T19:50:42Z","updated_at":"2018-03-16T15:18:40Z","pushed_at":"2018-03-16T15:25:52Z","git_url":"git://github.com/dacur/diaper.git","ssh_url":"git@github.com:dacur/diaper.git","clone_url":"https://github.com/dacur/diaper.git","svn_url":"https://github.com/dacur/diaper","homepage":"http://diaperbase.org/","size":19815,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubyforgood:rubocop","ref":"rubocop","sha":"418c0e95669e2ea9fbdc445c7d47c559a5fff2dc","user":{"login":"rubyforgood","id":11573263,"avatar_url":"https://avatars1.githubusercontent.com/u/11573263?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyforgood","html_url":"https://github.com/rubyforgood","followers_url":"https://api.github.com/users/rubyforgood/followers","following_url":"https://api.github.com/users/rubyforgood/following{/other_user}","gists_url":"https://api.github.com/users/rubyforgood/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyforgood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyforgood/subscriptions","organizations_url":"https://api.github.com/users/rubyforgood/orgs","repos_url":"https://api.github.com/users/rubyforgood/repos","events_url":"https://api.github.com/users/rubyforgood/events{/privacy}","received_events_url":"https://api.github.com/users/rubyforgood/received_events","type":"Organization","site_admin":false},"repo":{"id":89035461,"name":"diaper","full_name":"rubyforgood/diaper","owner":{"login":"rubyforgood","id":11573263,"avatar_url":"https://avatars1.githubusercontent.com/u/11573263?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyforgood","html_url":"https://github.com/rubyforgood","followers_url":"https://api.github.com/users/rubyforgood/followers","following_url":"https://api.github.com/users/rubyforgood/following{/other_user}","gists_url":"https://api.github.com/users/rubyforgood/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyforgood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyforgood/subscriptions","organizations_url":"https://api.github.com/users/rubyforgood/orgs","repos_url":"https://api.github.com/users/rubyforgood/repos","events_url":"https://api.github.com/users/rubyforgood/events{/privacy}","received_events_url":"https://api.github.com/users/rubyforgood/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubyforgood/diaper","description":"Diaperbase is an inventory system for diaper banks, to aid them in tracking their inventory and providing statistics about their inventory flows.","fork":false,"url":"https://api.github.com/repos/rubyforgood/diaper","forks_url":"https://api.github.com/repos/rubyforgood/diaper/forks","keys_url":"https://api.github.com/repos/rubyforgood/diaper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubyforgood/diaper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubyforgood/diaper/teams","hooks_url":"https://api.github.com/repos/rubyforgood/diaper/hooks","issue_events_url":"https://api.github.com/repos/rubyforgood/diaper/issues/events{/number}","events_url":"https://api.github.com/repos/rubyforgood/diaper/events","assignees_url":"https://api.github.com/repos/rubyforgood/diaper/assignees{/user}","branches_url":"https://api.github.com/repos/rubyforgood/diaper/branches{/branch}","tags_url":"https://api.github.com/repos/rubyforgood/diaper/tags","blobs_url":"https://api.github.com/repos/rubyforgood/diaper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubyforgood/diaper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubyforgood/diaper/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubyforgood/diaper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubyforgood/diaper/statuses/{sha}","languages_url":"https://api.github.com/repos/rubyforgood/diaper/languages","stargazers_url":"https://api.github.com/repos/rubyforgood/diaper/stargazers","contributors_url":"https://api.github.com/repos/rubyforgood/diaper/contributors","subscribers_url":"https://api.github.com/repos/rubyforgood/diaper/subscribers","subscription_url":"https://api.github.com/repos/rubyforgood/diaper/subscription","commits_url":"https://api.github.com/repos/rubyforgood/diaper/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubyforgood/diaper/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubyforgood/diaper/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubyforgood/diaper/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubyforgood/diaper/contents/{+path}","compare_url":"https://api.github.com/repos/rubyforgood/diaper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubyforgood/diaper/merges","archive_url":"https://api.github.com/repos/rubyforgood/diaper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubyforgood/diaper/downloads","issues_url":"https://api.github.com/repos/rubyforgood/diaper/issues{/number}","pulls_url":"https://api.github.com/repos/rubyforgood/diaper/pulls{/number}","milestones_url":"https://api.github.com/repos/rubyforgood/diaper/milestones{/number}","notifications_url":"https://api.github.com/repos/rubyforgood/diaper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubyforgood/diaper/labels{/name}","releases_url":"https://api.github.com/repos/rubyforgood/diaper/releases{/id}","deployments_url":"https://api.github.com/repos/rubyforgood/diaper/deployments","created_at":"2017-04-22T01:11:13Z","updated_at":"2018-03-14T16:05:21Z","pushed_at":"2018-03-16T15:25:53Z","git_url":"git://github.com/rubyforgood/diaper.git","ssh_url":"git@github.com:rubyforgood/diaper.git","clone_url":"https://github.com/rubyforgood/diaper.git","svn_url":"https://github.com/rubyforgood/diaper","homepage":"http://diaperbase.org/","size":19784,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":30,"open_issues":21,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubyforgood/diaper/pulls/292"},"html":{"href":"https://github.com/rubyforgood/diaper/pull/292"},"issue":{"href":"https://api.github.com/repos/rubyforgood/diaper/issues/292"},"comments":{"href":"https://api.github.com/repos/rubyforgood/diaper/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/rubyforgood/diaper/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/rubyforgood/diaper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubyforgood/diaper/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/rubyforgood/diaper/statuses/ae9b83e5c48aaeed2341f0a7773f567bc85aa30e"}},"author_association":"NONE"}}
{"actor":{"display_login":"houndci-bot"}}