{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/comments/230911795","pull_request_review_id":171759489,"id":230911795,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDkxMTc5NQ==","diff_hunk":"@@ -18,7 +18,10 @@ def test_run_without_verify_result_fails_if_pod_was_not_created\n     mock.expects(:create_pod).raises(Kubeclient::HttpError.new(\"409\", \"Pod with same name exists\", {}))\n     task_runner.instance_variable_set(:@kubeclient, mock)\n \n-    result = task_runner.run(run_params(verify_result: false))\n+    result = false\n+    metrics = capture_statsd_calls do\n+      result = task_runner.run(run_params(verify_result: false))\n+    end","path":"test/integration-serial/serial_task_run_test.rb","position":8,"original_position":8,"commit_id":"0f7dc79bf5227395c42d0c11a567cc6bc52e7d90","original_commit_id":"5432681f462e0bb7809ca03ed29f39e9613fba04","user":{"login":"KnVerey","id":4789493,"node_id":"MDQ6VXNlcjQ3ODk0OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/4789493?v=4","gravatar_id":"","url":"https://api.github.com/users/KnVerey","html_url":"https://github.com/KnVerey","followers_url":"https://api.github.com/users/KnVerey/followers","following_url":"https://api.github.com/users/KnVerey/following{/other_user}","gists_url":"https://api.github.com/users/KnVerey/gists{/gist_id}","starred_url":"https://api.github.com/users/KnVerey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnVerey/subscriptions","organizations_url":"https://api.github.com/users/KnVerey/orgs","repos_url":"https://api.github.com/users/KnVerey/repos","events_url":"https://api.github.com/users/KnVerey/events{/privacy}","received_events_url":"https://api.github.com/users/KnVerey/received_events","type":"User","site_admin":false},"body":"I see we're doing it in the main file though, and using the namespace tag to identify metrics that were actually emitted by the test in question (since each test gets its own namespace). Can't we do that for these tests too? The fact that we're lacking coverage in the other suite isn't a good reason not to add good coverage here.","created_at":"2018-11-05T21:07:01Z","updated_at":"2018-11-05T21:07:02Z","html_url":"https://github.com/Shopify/kubernetes-deploy/pull/374#discussion_r230911795","pull_request_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/374","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/comments/230911795"},"html":{"href":"https://github.com/Shopify/kubernetes-deploy/pull/374#discussion_r230911795"},"pull_request":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/374"}},"in_reply_to_id":230904677},"pull_request":{"url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/374","id":227991248,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTkxMjQ4","html_url":"https://github.com/Shopify/kubernetes-deploy/pull/374","diff_url":"https://github.com/Shopify/kubernetes-deploy/pull/374.diff","patch_url":"https://github.com/Shopify/kubernetes-deploy/pull/374.patch","issue_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/374","number":374,"state":"open","locked":false,"title":"Add statsd to k8s-run","user":{"login":"dturn","id":12193286,"node_id":"MDQ6VXNlcjEyMTkzMjg2","avatar_url":"https://avatars0.githubusercontent.com/u/12193286?v=4","gravatar_id":"","url":"https://api.github.com/users/dturn","html_url":"https://github.com/dturn","followers_url":"https://api.github.com/users/dturn/followers","following_url":"https://api.github.com/users/dturn/following{/other_user}","gists_url":"https://api.github.com/users/dturn/gists{/gist_id}","starred_url":"https://api.github.com/users/dturn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturn/subscriptions","organizations_url":"https://api.github.com/users/dturn/orgs","repos_url":"https://api.github.com/users/dturn/repos","events_url":"https://api.github.com/users/dturn/events{/privacy}","received_events_url":"https://api.github.com/users/dturn/received_events","type":"User","site_admin":false},"body":"Add statsd calls to aid in tracking useage. ","created_at":"2018-11-02T16:26:21Z","updated_at":"2018-11-05T21:07:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"543041a38f091a2c4647fd88e59fe62cb10468b4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/374/commits","review_comments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/374/comments","review_comment_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/374/comments","statuses_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/statuses/0f7dc79bf5227395c42d0c11a567cc6bc52e7d90","head":{"label":"Shopify:statsd-k8s-run","ref":"statsd-k8s-run","sha":"0f7dc79bf5227395c42d0c11a567cc6bc52e7d90","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":79269805,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTgwNQ==","name":"kubernetes-deploy","full_name":"Shopify/kubernetes-deploy","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/kubernetes-deploy","description":"A command-line tool that helps you ship changes to a Kubernetes namespace and understand the result","fork":false,"url":"https://api.github.com/repos/Shopify/kubernetes-deploy","forks_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/forks","keys_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/teams","hooks_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/hooks","issue_events_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/events","assignees_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/tags","blobs_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/languages","stargazers_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/stargazers","contributors_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/contributors","subscribers_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/subscribers","subscription_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/subscription","commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/merges","archive_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/downloads","issues_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/deployments","created_at":"2017-01-17T20:41:23Z","updated_at":"2018-11-04T18:12:16Z","pushed_at":"2018-11-05T20:57:05Z","git_url":"git://github.com/Shopify/kubernetes-deploy.git","ssh_url":"git@github.com:Shopify/kubernetes-deploy.git","clone_url":"https://github.com/Shopify/kubernetes-deploy.git","svn_url":"https://github.com/Shopify/kubernetes-deploy","homepage":"","size":6932,"stargazers_count":586,"watchers_count":586,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":44,"watchers":586,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"41989bcb1ba003c78b9892bb1695712dc3507256","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":79269805,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTgwNQ==","name":"kubernetes-deploy","full_name":"Shopify/kubernetes-deploy","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/kubernetes-deploy","description":"A command-line tool that helps you ship changes to a Kubernetes namespace and understand the result","fork":false,"url":"https://api.github.com/repos/Shopify/kubernetes-deploy","forks_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/forks","keys_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/teams","hooks_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/hooks","issue_events_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/events","assignees_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/tags","blobs_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/languages","stargazers_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/stargazers","contributors_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/contributors","subscribers_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/subscribers","subscription_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/subscription","commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/merges","archive_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/downloads","issues_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/deployments","created_at":"2017-01-17T20:41:23Z","updated_at":"2018-11-04T18:12:16Z","pushed_at":"2018-11-05T20:57:05Z","git_url":"git://github.com/Shopify/kubernetes-deploy.git","ssh_url":"git@github.com:Shopify/kubernetes-deploy.git","clone_url":"https://github.com/Shopify/kubernetes-deploy.git","svn_url":"https://github.com/Shopify/kubernetes-deploy","homepage":"","size":6932,"stargazers_count":586,"watchers_count":586,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":44,"watchers":586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/374"},"html":{"href":"https://github.com/Shopify/kubernetes-deploy/pull/374"},"issue":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/374"},"comments":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/374/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/374/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/374/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/statuses/0f7dc79bf5227395c42d0c11a567cc6bc52e7d90"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KnVerey"}}