{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4446","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4446/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4446/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4446/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4446","id":349283482,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDM4MjE4","number":4446,"title":"Add CloudVolumeType views","user":{"login":"mansam","id":628956,"node_id":"MDQ6VXNlcjYyODk1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/628956?v=4","gravatar_id":"","url":"https://api.github.com/users/mansam","html_url":"https://github.com/mansam","followers_url":"https://api.github.com/users/mansam/followers","following_url":"https://api.github.com/users/mansam/following{/other_user}","gists_url":"https://api.github.com/users/mansam/gists{/gist_id}","starred_url":"https://api.github.com/users/mansam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mansam/subscriptions","organizations_url":"https://api.github.com/users/mansam/orgs","repos_url":"https://api.github.com/users/mansam/repos","events_url":"https://api.github.com/users/mansam/events{/privacy}","received_events_url":"https://api.github.com/users/mansam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-09T20:44:50Z","updated_at":"2018-08-17T07:42:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4446","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4446","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4446.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4446.patch"},"body":"Implements views for CloudVolumeTypes in order to satisfy https://bugzilla.redhat.com/show_bug.cgi?id=1592898\r\n\r\n![volume_types](https://user-images.githubusercontent.com/628956/43924774-746f215e-9bf3-11e8-92a6-b61d4b860939.png)\r\n![volume_types_detail](https://user-images.githubusercontent.com/628956/43924775-747c8600-9bf3-11e8-92ec-b0111ca97d35.png)\r\n![volume_types_list](https://user-images.githubusercontent.com/628956/43924776-74888e00-9bf3-11e8-9918-2f795d7a69eb.png)\r\n![volume_types_manager](https://user-images.githubusercontent.com/628956/43924777-7494df70-9bf3-11e8-9236-1599aa97e6f4.png)\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/413785088","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4446#issuecomment-413785088","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4446","id":413785088,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzc4NTA4OA==","user":{"login":"martinpovolny","id":51095,"node_id":"MDQ6VXNlcjUxMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/51095?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T07:42:28Z","updated_at":"2018-08-17T07:42:28Z","author_association":"COLLABORATOR","body":"@mansam : Cool, thx!\r\n\r\nOnly one thing, could you, please, replace the \r\n```\r\n is_expected.to render_template(:partial => \"layouts/_gtl\")\r\n```\r\n\r\ntest with one using:\r\n\r\n```\r\nexpect_any_instance_of(GtlHelper).to receive(:render_gtl).with match_gtl_options(\r\n```\r\n\r\nThat one allows testing the parameters of the GTL (should match the ones for /report_data).\r\n\r\nThere will be a style complaint about using `expect_any_instance_of` but we ignore that until we have a better way.\r\n\r\n\r\n@terezanovotna : ux/review, please?"}}
{"actor":{"display_login":"martinpovolny"}}