{"action":"created","comment":{"url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments/165305706","pull_request_review_id":93215110,"id":165305706,"diff_hunk":"@@ -96,39 +103,65 @@ public void start(Properties bootProperties,\n   public void notifyWaiting(String regionPath,\n       Set<PersistentMemberID> membersToWaitFor, Set<Integer> missingBuckets,\n       PersistentMemberID myId, String message) {\n-    if (GemFireXDUtils.TraceFabricServiceBoot) {\n-      logger.info(\"Accepting WAITING notification\" +\n-          (message != null ? \": \" + message : \"\"));\n-    }\n-    if (this.serverstatus != State.WAITING) {\n-      this.previousServerStatus = this.serverstatus;\n+    if (missingBuckets != null && missingBuckets.isEmpty() && membersToWaitFor.isEmpty()) {\n+      if (GemFireXDUtils.TraceFabricServiceBoot) {\n+        logger.info(\"Accepting WAITING notification\" +\n+            (message != null ? \": \" + message : \"\"));\n+      }\n+      // only notify the FabricDataBase.postCreateDDLReplay\n+      notifyTableWait(regionPath);\n+    } else {\n+      if (GemFireXDUtils.TraceFabricServiceBoot) {\n+        logger.info(\"Accepting WAITING notification\" +\n+            (message != null ? \": \" + message : \"\"));\n+      }\n+      if (this.serverstatus != State.WAITING) {\n+        this.previousServerStatus = this.serverstatus;\n+      }\n+      this.serverstatus = State.WAITING;\n+      notifyTableWait(regionPath);\n+      notifyWaitingInLauncher(regionPath, membersToWaitFor, missingBuckets, myId,\n+          message);\n     }\n-    this.serverstatus = State.WAITING;\n-    notifyTableWait();\n-    notifyWaitingInLauncher(regionPath, membersToWaitFor, missingBuckets, myId,\n-        message);\n   }\n \n-  public void notifyTableInitialized() {\n+  public void notifyTableInitialized(boolean initialized, String regionPath) {\n     synchronized (initializationNotification) {\n-      notified = true;\n-      initializationNotification.notifyAll();\n+      if(regionPath.equals(regionPathToWaitFor)) {\n+        notified = true;\n+        this.initializedOrWait = initialized;\n+        initializationNotification.notifyAll();\n+        regionPathToWaitFor = \"\";\n+      }\n     }\n   }\n \n-  private void notifyTableWait() {\n+  private void notifyTableWait(String regionPath) {\n     synchronized (initializationNotification) {\n-      notified = true;\n-      initializationNotification.notifyAll();\n+      if(regionPath.equals(regionPathToWaitFor)) {\n+        notified = true;\n+        this.initializedOrWait = true;\n+        initializationNotification.notifyAll();\n+        regionPathToWaitFor = \"\";\n+      }\n     }","path":"gemfirexd/core/src/main/java/com/pivotal/gemfirexd/internal/engine/fabricservice/FabricServerImpl.java","position":86,"original_position":86,"commit_id":"b8ac95bbf298b44e8e393ec066e14501b8f14a37","original_commit_id":"b8ac95bbf298b44e8e393ec066e14501b8f14a37","user":{"login":"sumwale","id":11540628,"avatar_url":"https://avatars3.githubusercontent.com/u/11540628?v=4","gravatar_id":"","url":"https://api.github.com/users/sumwale","html_url":"https://github.com/sumwale","followers_url":"https://api.github.com/users/sumwale/followers","following_url":"https://api.github.com/users/sumwale/following{/other_user}","gists_url":"https://api.github.com/users/sumwale/gists{/gist_id}","starred_url":"https://api.github.com/users/sumwale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumwale/subscriptions","organizations_url":"https://api.github.com/users/sumwale/orgs","repos_url":"https://api.github.com/users/sumwale/repos","events_url":"https://api.github.com/users/sumwale/events{/privacy}","received_events_url":"https://api.github.com/users/sumwale/received_events","type":"User","site_admin":false},"body":"Is the matching of region required because it can get multiple notifications when initializing parent table (or child?) for its children?","created_at":"2018-02-01T09:59:55Z","updated_at":"2018-02-01T10:03:17Z","html_url":"https://github.com/SnappyDataInc/snappy-store/pull/360#discussion_r165305706","pull_request_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/360","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments/165305706"},"html":{"href":"https://github.com/SnappyDataInc/snappy-store/pull/360#discussion_r165305706"},"pull_request":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/360","id":166434717,"html_url":"https://github.com/SnappyDataInc/snappy-store/pull/360","diff_url":"https://github.com/SnappyDataInc/snappy-store/pull/360.diff","patch_url":"https://github.com/SnappyDataInc/snappy-store/pull/360.patch","issue_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/360","number":360,"state":"open","locked":false,"title":"Snap 2174","user":{"login":"suranjan","id":189977,"avatar_url":"https://avatars1.githubusercontent.com/u/189977?v=4","gravatar_id":"","url":"https://api.github.com/users/suranjan","html_url":"https://github.com/suranjan","followers_url":"https://api.github.com/users/suranjan/followers","following_url":"https://api.github.com/users/suranjan/following{/other_user}","gists_url":"https://api.github.com/users/suranjan/gists{/gist_id}","starred_url":"https://api.github.com/users/suranjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suranjan/subscriptions","organizations_url":"https://api.github.com/users/suranjan/orgs","repos_url":"https://api.github.com/users/suranjan/repos","events_url":"https://api.github.com/users/suranjan/events{/privacy}","received_events_url":"https://api.github.com/users/suranjan/received_events","type":"User","site_admin":false},"body":"## Changes proposed in this pull request\r\n\r\nFixed nconsistent notificaion while waiting for offline store\r\n\r\n## Patch testing\r\n\r\n(Fill in the details about how this patch was tested)\r\n\r\n## ReleaseNotes changes\r\n\r\n(Does this change require an entry in ReleaseNotes? If yes, has it been added to it?)\r\n\r\n## Other PRs \r\n\r\n(Does this change require changes in other projects- snappydata, spark, spark-jobserver, aqp? Add the links of PR of the other subprojects that are related to this change)\r\n","created_at":"2018-02-01T03:24:09Z","updated_at":"2018-02-01T10:03:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50132075e179b2497e16d3783cf678bb9f890ca3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kneeraj","id":1151021,"avatar_url":"https://avatars3.githubusercontent.com/u/1151021?v=4","gravatar_id":"","url":"https://api.github.com/users/kneeraj","html_url":"https://github.com/kneeraj","followers_url":"https://api.github.com/users/kneeraj/followers","following_url":"https://api.github.com/users/kneeraj/following{/other_user}","gists_url":"https://api.github.com/users/kneeraj/gists{/gist_id}","starred_url":"https://api.github.com/users/kneeraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kneeraj/subscriptions","organizations_url":"https://api.github.com/users/kneeraj/orgs","repos_url":"https://api.github.com/users/kneeraj/repos","events_url":"https://api.github.com/users/kneeraj/events{/privacy}","received_events_url":"https://api.github.com/users/kneeraj/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/360/commits","review_comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/360/comments","review_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/360/comments","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/b8ac95bbf298b44e8e393ec066e14501b8f14a37","head":{"label":"SnappyDataInc:SNAP-2174","ref":"SNAP-2174","sha":"b8ac95bbf298b44e8e393ec066e14501b8f14a37","user":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48800286,"name":"snappy-store","full_name":"SnappyDataInc/snappy-store","owner":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SnappyDataInc/snappy-store","description":"SnappyStore","fork":true,"url":"https://api.github.com/repos/SnappyDataInc/snappy-store","forks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/deployments","created_at":"2015-12-30T12:44:56Z","updated_at":"2017-11-08T21:31:52Z","pushed_at":"2018-02-01T07:57:39Z","git_url":"git://github.com/SnappyDataInc/snappy-store.git","ssh_url":"git@github.com:SnappyDataInc/snappy-store.git","clone_url":"https://github.com/SnappyDataInc/snappy-store.git","svn_url":"https://github.com/SnappyDataInc/snappy-store","homepage":"","size":119636,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11,"open_issues":12,"watchers":34,"default_branch":"snappy/master"}},"base":{"label":"SnappyDataInc:snappy/master","ref":"snappy/master","sha":"0a761d7675e950a6eb7bdad7fa3bdc31bcd659fc","user":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48800286,"name":"snappy-store","full_name":"SnappyDataInc/snappy-store","owner":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SnappyDataInc/snappy-store","description":"SnappyStore","fork":true,"url":"https://api.github.com/repos/SnappyDataInc/snappy-store","forks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/deployments","created_at":"2015-12-30T12:44:56Z","updated_at":"2017-11-08T21:31:52Z","pushed_at":"2018-02-01T07:57:39Z","git_url":"git://github.com/SnappyDataInc/snappy-store.git","ssh_url":"git@github.com:SnappyDataInc/snappy-store.git","clone_url":"https://github.com/SnappyDataInc/snappy-store.git","svn_url":"https://github.com/SnappyDataInc/snappy-store","homepage":"","size":119636,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11,"open_issues":12,"watchers":34,"default_branch":"snappy/master"}},"_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/360"},"html":{"href":"https://github.com/SnappyDataInc/snappy-store/pull/360"},"issue":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/360"},"comments":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/b8ac95bbf298b44e8e393ec066e14501b8f14a37"}},"author_association":"NONE"}}
{"actor":{"display_login":"sumwale"}}