{"action":"closed","number":117,"pull_request":{"url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/pulls/117","id":178724146,"html_url":"https://github.com/CS2103JAN2018-W14-B1/main/pull/117","diff_url":"https://github.com/CS2103JAN2018-W14-B1/main/pull/117.diff","patch_url":"https://github.com/CS2103JAN2018-W14-B1/main/pull/117.patch","issue_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/issues/117","number":117,"state":"closed","locked":false,"title":"Student list2","user":{"login":"randypx","id":35571456,"avatar_url":"https://avatars1.githubusercontent.com/u/35571456?v=4","gravatar_id":"","url":"https://api.github.com/users/randypx","html_url":"https://github.com/randypx","followers_url":"https://api.github.com/users/randypx/followers","following_url":"https://api.github.com/users/randypx/following{/other_user}","gists_url":"https://api.github.com/users/randypx/gists{/gist_id}","starred_url":"https://api.github.com/users/randypx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randypx/subscriptions","organizations_url":"https://api.github.com/users/randypx/orgs","repos_url":"https://api.github.com/users/randypx/repos","events_url":"https://api.github.com/users/randypx/events{/privacy}","received_events_url":"https://api.github.com/users/randypx/received_events","type":"User","site_admin":false},"body":"Created UniqueStudentList to store students and a UniqueContactList as a combined list of UniqueStudentList and UniquePersonList which will be the list shown to the user.\r\n\r\nUniqueContactList is updated by ListChangeListeners\r\n\r\nAdd, Edit and Delete are updated to interact with UniqueStudentList\r\nList now requires arguments to specify the type of list to be shown, \"contacts\" to list all and \"students\" to list only students\r\n\r\nStorage has been updated to store students properly\r\nExisting tests has been updated to reflect changes done. Will create more tests in future\r\nfixed bugs related to toggling of list\r\nclosed #26, close #74, close #75, close #78","created_at":"2018-04-01T11:02:23Z","updated_at":"2018-04-01T11:03:18Z","closed_at":"2018-04-01T11:03:18Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"Sisyphus25","id":19634112,"avatar_url":"https://avatars3.githubusercontent.com/u/19634112?v=4","gravatar_id":"","url":"https://api.github.com/users/Sisyphus25","html_url":"https://github.com/Sisyphus25","followers_url":"https://api.github.com/users/Sisyphus25/followers","following_url":"https://api.github.com/users/Sisyphus25/following{/other_user}","gists_url":"https://api.github.com/users/Sisyphus25/gists{/gist_id}","starred_url":"https://api.github.com/users/Sisyphus25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sisyphus25/subscriptions","organizations_url":"https://api.github.com/users/Sisyphus25/orgs","repos_url":"https://api.github.com/users/Sisyphus25/repos","events_url":"https://api.github.com/users/Sisyphus25/events{/privacy}","received_events_url":"https://api.github.com/users/Sisyphus25/received_events","type":"User","site_admin":false},{"login":"LimShiMinJonathan","id":25984388,"avatar_url":"https://avatars0.githubusercontent.com/u/25984388?v=4","gravatar_id":"","url":"https://api.github.com/users/LimShiMinJonathan","html_url":"https://github.com/LimShiMinJonathan","followers_url":"https://api.github.com/users/LimShiMinJonathan/followers","following_url":"https://api.github.com/users/LimShiMinJonathan/following{/other_user}","gists_url":"https://api.github.com/users/LimShiMinJonathan/gists{/gist_id}","starred_url":"https://api.github.com/users/LimShiMinJonathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LimShiMinJonathan/subscriptions","organizations_url":"https://api.github.com/users/LimShiMinJonathan/orgs","repos_url":"https://api.github.com/users/LimShiMinJonathan/repos","events_url":"https://api.github.com/users/LimShiMinJonathan/events{/privacy}","received_events_url":"https://api.github.com/users/LimShiMinJonathan/received_events","type":"User","site_admin":false},{"login":"shanmu9898","id":28682356,"avatar_url":"https://avatars2.githubusercontent.com/u/28682356?v=4","gravatar_id":"","url":"https://api.github.com/users/shanmu9898","html_url":"https://github.com/shanmu9898","followers_url":"https://api.github.com/users/shanmu9898/followers","following_url":"https://api.github.com/users/shanmu9898/following{/other_user}","gists_url":"https://api.github.com/users/shanmu9898/gists{/gist_id}","starred_url":"https://api.github.com/users/shanmu9898/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanmu9898/subscriptions","organizations_url":"https://api.github.com/users/shanmu9898/orgs","repos_url":"https://api.github.com/users/shanmu9898/repos","events_url":"https://api.github.com/users/shanmu9898/events{/privacy}","received_events_url":"https://api.github.com/users/shanmu9898/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/milestones/9","html_url":"https://github.com/CS2103JAN2018-W14-B1/main/milestone/9","labels_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/milestones/9/labels","id":3224093,"number":9,"title":"v1.4","description":"","creator":{"login":"Sisyphus25","id":19634112,"avatar_url":"https://avatars3.githubusercontent.com/u/19634112?v=4","gravatar_id":"","url":"https://api.github.com/users/Sisyphus25","html_url":"https://github.com/Sisyphus25","followers_url":"https://api.github.com/users/Sisyphus25/followers","following_url":"https://api.github.com/users/Sisyphus25/following{/other_user}","gists_url":"https://api.github.com/users/Sisyphus25/gists{/gist_id}","starred_url":"https://api.github.com/users/Sisyphus25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sisyphus25/subscriptions","organizations_url":"https://api.github.com/users/Sisyphus25/orgs","repos_url":"https://api.github.com/users/Sisyphus25/repos","events_url":"https://api.github.com/users/Sisyphus25/events{/privacy}","received_events_url":"https://api.github.com/users/Sisyphus25/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":15,"state":"open","created_at":"2018-03-28T04:28:44Z","updated_at":"2018-04-01T11:03:18Z","due_on":"2018-04-04T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/pulls/117/commits","review_comments_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/pulls/117/comments","review_comment_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/issues/117/comments","statuses_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/statuses/8c0240ca4bf1dd26d0818adf0d2a234755b11e24","head":{"label":"randypx:student-list2","ref":"student-list2","sha":"8c0240ca4bf1dd26d0818adf0d2a234755b11e24","user":{"login":"randypx","id":35571456,"avatar_url":"https://avatars1.githubusercontent.com/u/35571456?v=4","gravatar_id":"","url":"https://api.github.com/users/randypx","html_url":"https://github.com/randypx","followers_url":"https://api.github.com/users/randypx/followers","following_url":"https://api.github.com/users/randypx/following{/other_user}","gists_url":"https://api.github.com/users/randypx/gists{/gist_id}","starred_url":"https://api.github.com/users/randypx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randypx/subscriptions","organizations_url":"https://api.github.com/users/randypx/orgs","repos_url":"https://api.github.com/users/randypx/repos","events_url":"https://api.github.com/users/randypx/events{/privacy}","received_events_url":"https://api.github.com/users/randypx/received_events","type":"User","site_admin":false},"repo":{"id":123670733,"name":"main","full_name":"randypx/main","owner":{"login":"randypx","id":35571456,"avatar_url":"https://avatars1.githubusercontent.com/u/35571456?v=4","gravatar_id":"","url":"https://api.github.com/users/randypx","html_url":"https://github.com/randypx","followers_url":"https://api.github.com/users/randypx/followers","following_url":"https://api.github.com/users/randypx/following{/other_user}","gists_url":"https://api.github.com/users/randypx/gists{/gist_id}","starred_url":"https://api.github.com/users/randypx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randypx/subscriptions","organizations_url":"https://api.github.com/users/randypx/orgs","repos_url":"https://api.github.com/users/randypx/repos","events_url":"https://api.github.com/users/randypx/events{/privacy}","received_events_url":"https://api.github.com/users/randypx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/randypx/main","description":"Address Book sample application (Level 4)","fork":true,"url":"https://api.github.com/repos/randypx/main","forks_url":"https://api.github.com/repos/randypx/main/forks","keys_url":"https://api.github.com/repos/randypx/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/randypx/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/randypx/main/teams","hooks_url":"https://api.github.com/repos/randypx/main/hooks","issue_events_url":"https://api.github.com/repos/randypx/main/issues/events{/number}","events_url":"https://api.github.com/repos/randypx/main/events","assignees_url":"https://api.github.com/repos/randypx/main/assignees{/user}","branches_url":"https://api.github.com/repos/randypx/main/branches{/branch}","tags_url":"https://api.github.com/repos/randypx/main/tags","blobs_url":"https://api.github.com/repos/randypx/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/randypx/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/randypx/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/randypx/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/randypx/main/statuses/{sha}","languages_url":"https://api.github.com/repos/randypx/main/languages","stargazers_url":"https://api.github.com/repos/randypx/main/stargazers","contributors_url":"https://api.github.com/repos/randypx/main/contributors","subscribers_url":"https://api.github.com/repos/randypx/main/subscribers","subscription_url":"https://api.github.com/repos/randypx/main/subscription","commits_url":"https://api.github.com/repos/randypx/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/randypx/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/randypx/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/randypx/main/issues/comments{/number}","contents_url":"https://api.github.com/repos/randypx/main/contents/{+path}","compare_url":"https://api.github.com/repos/randypx/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/randypx/main/merges","archive_url":"https://api.github.com/repos/randypx/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/randypx/main/downloads","issues_url":"https://api.github.com/repos/randypx/main/issues{/number}","pulls_url":"https://api.github.com/repos/randypx/main/pulls{/number}","milestones_url":"https://api.github.com/repos/randypx/main/milestones{/number}","notifications_url":"https://api.github.com/repos/randypx/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/randypx/main/labels{/name}","releases_url":"https://api.github.com/repos/randypx/main/releases{/id}","deployments_url":"https://api.github.com/repos/randypx/main/deployments","created_at":"2018-03-03T07:42:16Z","updated_at":"2018-03-21T06:25:11Z","pushed_at":"2018-04-01T11:01:32Z","git_url":"git://github.com/randypx/main.git","ssh_url":"git@github.com:randypx/main.git","clone_url":"https://github.com/randypx/main.git","svn_url":"https://github.com/randypx/main","homepage":"https://nus-cs2103-ay1718s2.github.io/addressbook-level4/","size":11036,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CS2103JAN2018-W14-B1:master","ref":"master","sha":"0fca52d81ea148d70cefe883c48bdf58ce53042b","user":{"login":"CS2103JAN2018-W14-B1","id":37007714,"avatar_url":"https://avatars1.githubusercontent.com/u/37007714?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103JAN2018-W14-B1","html_url":"https://github.com/CS2103JAN2018-W14-B1","followers_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/followers","following_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/following{/other_user}","gists_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/subscriptions","organizations_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/orgs","repos_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/repos","events_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/received_events","type":"Organization","site_admin":false},"repo":{"id":123653617,"name":"main","full_name":"CS2103JAN2018-W14-B1/main","owner":{"login":"CS2103JAN2018-W14-B1","id":37007714,"avatar_url":"https://avatars1.githubusercontent.com/u/37007714?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103JAN2018-W14-B1","html_url":"https://github.com/CS2103JAN2018-W14-B1","followers_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/followers","following_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/following{/other_user}","gists_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/subscriptions","organizations_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/orgs","repos_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/repos","events_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103JAN2018-W14-B1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CS2103JAN2018-W14-B1/main","description":"Address Book sample application (Level 4)","fork":true,"url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main","forks_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/forks","keys_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/teams","hooks_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/hooks","issue_events_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/issues/events{/number}","events_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/events","assignees_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/assignees{/user}","branches_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/branches{/branch}","tags_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/tags","blobs_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/statuses/{sha}","languages_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/languages","stargazers_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/stargazers","contributors_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/contributors","subscribers_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/subscribers","subscription_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/subscription","commits_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/issues/comments{/number}","contents_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/contents/{+path}","compare_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/merges","archive_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/downloads","issues_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/issues{/number}","pulls_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/pulls{/number}","milestones_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/milestones{/number}","notifications_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/labels{/name}","releases_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/releases{/id}","deployments_url":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/deployments","created_at":"2018-03-03T02:57:07Z","updated_at":"2018-04-01T09:05:57Z","pushed_at":"2018-04-01T11:02:24Z","git_url":"git://github.com/CS2103JAN2018-W14-B1/main.git","ssh_url":"git@github.com:CS2103JAN2018-W14-B1/main.git","clone_url":"https://github.com/CS2103JAN2018-W14-B1/main.git","svn_url":"https://github.com/CS2103JAN2018-W14-B1/main","homepage":"https://cs2103jan2018-w14-b1.github.io/main/","size":11147,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":36,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/pulls/117"},"html":{"href":"https://github.com/CS2103JAN2018-W14-B1/main/pull/117"},"issue":{"href":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/issues/117"},"comments":{"href":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/CS2103JAN2018-W14-B1/main/statuses/8c0240ca4bf1dd26d0818adf0d2a234755b11e24"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":24,"deletions":21,"changed_files":10}}
{"actor":{"display_login":"randypx"}}