{"action":"created","comment":{"url":"https://api.github.com/repos/google/keytransparency/pulls/comments/201450696","pull_request_review_id":135956255,"id":201450696,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQ1MDY5Ng==","diff_hunk":"@@ -76,125 +97,199 @@ func New(ctx context.Context, dial DialFunc, callOptions CallOptions,\n \t\ttimeout:     timeout,\n \t\tktCli:       ktCli,\n \t\tappID:       fmt.Sprintf(\"hammer_%v\", time.Now().Format(\"2006-01-02/15:04:05\")),\n-\t\tconfig:      config,\n+\t\tdomain:      domain,\n \n \t\tsigners:        []*tink.KeysetHandle{keyset},\n \t\tauthorizedKeys: authorizedKeys.Keyset(),\n \t}, nil\n }\n \n-// Run runs operationCount with up to maxWorkers over ramp duration.\n-func (h *Hammer) Run(ctx context.Context, operationCount, maxWorkers int, ramp time.Duration) {\n-\tjobs := gen(ctx, operationCount)\n-\toutputs := h.launchWorkers(ctx, jobs, maxWorkers, ramp)\n-\th.printStats(1*time.Second, outputs)\n-}\n+// Run runs a total of operationCount operations across numWorkers.\n+// The number of workers should roughly be (goal QPS / timeout seconds)\n+func (h *Hammer) Run(ctx context.Context, numWorkers int, c Config) error {\n+\tworkers, err := h.newWorkers(numWorkers)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\t/*","path":"core/client/hammer/hammer.go","position":93,"original_position":93,"commit_id":"421d3ad505a79c1f32a978d75df7aed4c3dcfea7","original_commit_id":"421d3ad505a79c1f32a978d75df7aed4c3dcfea7","user":{"login":"gdbelvin","id":198478,"node_id":"MDQ6VXNlcjE5ODQ3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"body":"Deleted it. \r\nI was experimenting with the use of multiple progress bars, but found them to be ultimately unhelpful.","created_at":"2018-07-10T18:37:02Z","updated_at":"2018-07-10T18:37:02Z","html_url":"https://github.com/google/keytransparency/pull/993#discussion_r201450696","pull_request_url":"https://api.github.com/repos/google/keytransparency/pulls/993","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/keytransparency/pulls/comments/201450696"},"html":{"href":"https://github.com/google/keytransparency/pull/993#discussion_r201450696"},"pull_request":{"href":"https://api.github.com/repos/google/keytransparency/pulls/993"}},"in_reply_to_id":201282856},"pull_request":{"url":"https://api.github.com/repos/google/keytransparency/pulls/993","id":195830362,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1ODMwMzYy","html_url":"https://github.com/google/keytransparency/pull/993","diff_url":"https://github.com/google/keytransparency/pull/993.diff","patch_url":"https://github.com/google/keytransparency/pull/993.patch","issue_url":"https://api.github.com/repos/google/keytransparency/issues/993","number":993,"state":"open","locked":false,"title":"Generic load test","user":{"login":"gdbelvin","id":198478,"node_id":"MDQ6VXNlcjE5ODQ3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"body":"To test multiple operation types, this PR refactors the hammer library a bit to measure arbitrary operations.  \r\n\r\n The new components:\r\n- Calculating stats on a stream of results.\r\n- Measuring the latency of a stream of requests mapped to a collection of workers. \r\n- Better speed control of the generated stream of requests.  (time.Ticker doesn't go faster than 10QPS)\r\n- New operation types for \r\n   - Batch Write\r\n   - Parallel Write \r\n   - Parallel Read\r\n   - Parallel Audit History","created_at":"2018-06-19T13:36:58Z","updated_at":"2018-07-10T18:37:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b536a895beb2f6824ec82e102e862af11745eb91","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/keytransparency/pulls/993/commits","review_comments_url":"https://api.github.com/repos/google/keytransparency/pulls/993/comments","review_comment_url":"https://api.github.com/repos/google/keytransparency/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/keytransparency/issues/993/comments","statuses_url":"https://api.github.com/repos/google/keytransparency/statuses/421d3ad505a79c1f32a978d75df7aed4c3dcfea7","head":{"label":"gdbelvin:f/widehammer","ref":"f/widehammer","sha":"421d3ad505a79c1f32a978d75df7aed4c3dcfea7","user":{"login":"gdbelvin","id":198478,"node_id":"MDQ6VXNlcjE5ODQ3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"repo":{"id":79116210,"node_id":"MDEwOlJlcG9zaXRvcnk3OTExNjIxMA==","name":"keytransparency","full_name":"gdbelvin/keytransparency","owner":{"login":"gdbelvin","id":198478,"node_id":"MDQ6VXNlcjE5ODQ3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdbelvin/keytransparency","description":"A transparent and secure way to look up public keys.","fork":true,"url":"https://api.github.com/repos/gdbelvin/keytransparency","forks_url":"https://api.github.com/repos/gdbelvin/keytransparency/forks","keys_url":"https://api.github.com/repos/gdbelvin/keytransparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdbelvin/keytransparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdbelvin/keytransparency/teams","hooks_url":"https://api.github.com/repos/gdbelvin/keytransparency/hooks","issue_events_url":"https://api.github.com/repos/gdbelvin/keytransparency/issues/events{/number}","events_url":"https://api.github.com/repos/gdbelvin/keytransparency/events","assignees_url":"https://api.github.com/repos/gdbelvin/keytransparency/assignees{/user}","branches_url":"https://api.github.com/repos/gdbelvin/keytransparency/branches{/branch}","tags_url":"https://api.github.com/repos/gdbelvin/keytransparency/tags","blobs_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdbelvin/keytransparency/statuses/{sha}","languages_url":"https://api.github.com/repos/gdbelvin/keytransparency/languages","stargazers_url":"https://api.github.com/repos/gdbelvin/keytransparency/stargazers","contributors_url":"https://api.github.com/repos/gdbelvin/keytransparency/contributors","subscribers_url":"https://api.github.com/repos/gdbelvin/keytransparency/subscribers","subscription_url":"https://api.github.com/repos/gdbelvin/keytransparency/subscription","commits_url":"https://api.github.com/repos/gdbelvin/keytransparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdbelvin/keytransparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdbelvin/keytransparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdbelvin/keytransparency/contents/{+path}","compare_url":"https://api.github.com/repos/gdbelvin/keytransparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdbelvin/keytransparency/merges","archive_url":"https://api.github.com/repos/gdbelvin/keytransparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdbelvin/keytransparency/downloads","issues_url":"https://api.github.com/repos/gdbelvin/keytransparency/issues{/number}","pulls_url":"https://api.github.com/repos/gdbelvin/keytransparency/pulls{/number}","milestones_url":"https://api.github.com/repos/gdbelvin/keytransparency/milestones{/number}","notifications_url":"https://api.github.com/repos/gdbelvin/keytransparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdbelvin/keytransparency/labels{/name}","releases_url":"https://api.github.com/repos/gdbelvin/keytransparency/releases{/id}","deployments_url":"https://api.github.com/repos/gdbelvin/keytransparency/deployments","created_at":"2017-01-16T12:28:44Z","updated_at":"2018-07-06T15:55:40Z","pushed_at":"2018-07-09T20:16:51Z","git_url":"git://github.com/gdbelvin/keytransparency.git","ssh_url":"git@github.com:gdbelvin/keytransparency.git","clone_url":"https://github.com/gdbelvin/keytransparency.git","svn_url":"https://github.com/gdbelvin/keytransparency","homepage":"https://security.googleblog.com/2017/01/security-through-transparency.html","size":25026,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"d34d8f28435b3e54019e7c5cf14e6d1125e6000a","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":37165115,"node_id":"MDEwOlJlcG9zaXRvcnkzNzE2NTExNQ==","name":"keytransparency","full_name":"google/keytransparency","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/keytransparency","description":"A transparent and secure way to look up public keys.","fork":false,"url":"https://api.github.com/repos/google/keytransparency","forks_url":"https://api.github.com/repos/google/keytransparency/forks","keys_url":"https://api.github.com/repos/google/keytransparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/keytransparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/keytransparency/teams","hooks_url":"https://api.github.com/repos/google/keytransparency/hooks","issue_events_url":"https://api.github.com/repos/google/keytransparency/issues/events{/number}","events_url":"https://api.github.com/repos/google/keytransparency/events","assignees_url":"https://api.github.com/repos/google/keytransparency/assignees{/user}","branches_url":"https://api.github.com/repos/google/keytransparency/branches{/branch}","tags_url":"https://api.github.com/repos/google/keytransparency/tags","blobs_url":"https://api.github.com/repos/google/keytransparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/keytransparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/keytransparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/keytransparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/keytransparency/statuses/{sha}","languages_url":"https://api.github.com/repos/google/keytransparency/languages","stargazers_url":"https://api.github.com/repos/google/keytransparency/stargazers","contributors_url":"https://api.github.com/repos/google/keytransparency/contributors","subscribers_url":"https://api.github.com/repos/google/keytransparency/subscribers","subscription_url":"https://api.github.com/repos/google/keytransparency/subscription","commits_url":"https://api.github.com/repos/google/keytransparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/keytransparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/keytransparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/keytransparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/keytransparency/contents/{+path}","compare_url":"https://api.github.com/repos/google/keytransparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/keytransparency/merges","archive_url":"https://api.github.com/repos/google/keytransparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/keytransparency/downloads","issues_url":"https://api.github.com/repos/google/keytransparency/issues{/number}","pulls_url":"https://api.github.com/repos/google/keytransparency/pulls{/number}","milestones_url":"https://api.github.com/repos/google/keytransparency/milestones{/number}","notifications_url":"https://api.github.com/repos/google/keytransparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/keytransparency/labels{/name}","releases_url":"https://api.github.com/repos/google/keytransparency/releases{/id}","deployments_url":"https://api.github.com/repos/google/keytransparency/deployments","created_at":"2015-06-09T23:55:20Z","updated_at":"2018-07-10T18:34:18Z","pushed_at":"2018-07-09T20:16:53Z","git_url":"git://github.com/google/keytransparency.git","ssh_url":"git@github.com:google/keytransparency.git","clone_url":"https://github.com/google/keytransparency.git","svn_url":"https://github.com/google/keytransparency","homepage":"https://security.googleblog.com/2017/01/security-through-transparency.html","size":23443,"stargazers_count":1278,"watchers_count":1278,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":100,"open_issues":52,"watchers":1278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/keytransparency/pulls/993"},"html":{"href":"https://github.com/google/keytransparency/pull/993"},"issue":{"href":"https://api.github.com/repos/google/keytransparency/issues/993"},"comments":{"href":"https://api.github.com/repos/google/keytransparency/issues/993/comments"},"review_comments":{"href":"https://api.github.com/repos/google/keytransparency/pulls/993/comments"},"review_comment":{"href":"https://api.github.com/repos/google/keytransparency/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/keytransparency/pulls/993/commits"},"statuses":{"href":"https://api.github.com/repos/google/keytransparency/statuses/421d3ad505a79c1f32a978d75df7aed4c3dcfea7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gdbelvin"}}