{"action":"created","issue":{"url":"https://api.github.com/repos/librenms/librenms/issues/7323","repository_url":"https://api.github.com/repos/librenms/librenms","labels_url":"https://api.github.com/repos/librenms/librenms/issues/7323/labels{/name}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/7323/comments","events_url":"https://api.github.com/repos/librenms/librenms/issues/7323/events","html_url":"https://github.com/librenms/librenms/pull/7323","id":257022281,"number":7323,"title":"Support for up/down detection of ping only devices.","user":{"login":"Zmegolaz","id":2771043,"avatar_url":"https://avatars2.githubusercontent.com/u/2771043?v=4","gravatar_id":"","url":"https://api.github.com/users/Zmegolaz","html_url":"https://github.com/Zmegolaz","followers_url":"https://api.github.com/users/Zmegolaz/followers","following_url":"https://api.github.com/users/Zmegolaz/following{/other_user}","gists_url":"https://api.github.com/users/Zmegolaz/gists{/gist_id}","starred_url":"https://api.github.com/users/Zmegolaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zmegolaz/subscriptions","organizations_url":"https://api.github.com/users/Zmegolaz/orgs","repos_url":"https://api.github.com/users/Zmegolaz/repos","events_url":"https://api.github.com/users/Zmegolaz/events{/privacy}","received_events_url":"https://api.github.com/users/Zmegolaz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2017-09-12T12:17:15Z","updated_at":"2018-05-17T03:39:25Z","closed_at":"2017-10-28T03:59:26Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/7323","html_url":"https://github.com/librenms/librenms/pull/7323","diff_url":"https://github.com/librenms/librenms/pull/7323.diff","patch_url":"https://github.com/librenms/librenms/pull/7323.patch"},"body":"This allows the user to disable all SNMP checks and only ping a device. No extra service checks are needed and up/down status and alerting works as expected.\r\nI have a few points I'd like to ask your opinion about:\r\n\r\n1. Should we add a \"Disable SNMP\" button to the \"Add device\" page too? snmp-scan.py (despite the name)?\r\n2. The OS is set to \"Ping only\" and the user can specify hardware. Should it be called something else? Should the user be able to specify more details?\r\n3. The disable SNMP setting is currently saved in a separate column and the code checks that value. However we could instead only set the OS of the device and use that field to decide if SNMP checks should be performed. It's not as clear and probably not as future proof, but it'd be a column less in the database.\r\n\r\nDO NOT DELETE THIS TEXT\r\n\r\n#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n\r\n#### Testers\r\n\r\nIf you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/librenms/librenms/7323)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/librenms/librenms/issues/comments/389734776","html_url":"https://github.com/librenms/librenms/pull/7323#issuecomment-389734776","issue_url":"https://api.github.com/repos/librenms/librenms/issues/7323","id":389734776,"user":{"login":"lock[bot]","id":33595554,"avatar_url":"https://avatars1.githubusercontent.com/in/6672?v=4","gravatar_id":"","url":"https://api.github.com/users/lock%5Bbot%5D","html_url":"https://github.com/apps/lock","followers_url":"https://api.github.com/users/lock%5Bbot%5D/followers","following_url":"https://api.github.com/users/lock%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/lock%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/lock%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lock%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/lock%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/lock%5Bbot%5D/repos","events_url":"https://api.github.com/users/lock%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/lock%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-05-17T03:39:24Z","updated_at":"2018-05-17T03:39:24Z","author_association":"NONE","body":"This thread has been automatically locked since there has not been any recent activity after it was closed.\n"}}
{"actor":{"display_login":"lock"}}