{"action":"created","comment":{"url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls/comments/216415068","pull_request_review_id":153890104,"id":216415068,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQxNTA2OA==","diff_hunk":"@@ -299,11 +300,67 @@ - (void)stopLoading\n   [_webView stopLoading];\n }\n \n+- (NSString *) cookieDescription:(NSHTTPCookie *)cookie {\n+\n+    NSMutableString *cDesc = [[NSMutableString alloc] init];\n+    [cDesc appendFormat:@\"%@=%@;\",\n+     [[cookie name] stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding],\n+     [[cookie value] stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding]];\n+    if ([cookie.domain length] > 0)\n+        [cDesc appendFormat:@\"domain=%@;\", [cookie domain]];\n+    if ([cookie.path length] > 0)\n+        [cDesc appendFormat:@\"path=%@;\", [cookie path]];\n+    if (cookie.expiresDate != nil)","path":"ios/RCTWKWebView/RCTWKWebView.m","position":22,"original_position":22,"commit_id":"50a49a8f01ac4e09b69f6faf57a2e26310bd62df","original_commit_id":"50a49a8f01ac4e09b69f6faf57a2e26310bd62df","user":{"login":"ashishmusale","id":1551015,"node_id":"MDQ6VXNlcjE1NTEwMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1551015?v=4","gravatar_id":"","url":"https://api.github.com/users/ashishmusale","html_url":"https://github.com/ashishmusale","followers_url":"https://api.github.com/users/ashishmusale/followers","following_url":"https://api.github.com/users/ashishmusale/following{/other_user}","gists_url":"https://api.github.com/users/ashishmusale/gists{/gist_id}","starred_url":"https://api.github.com/users/ashishmusale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashishmusale/subscriptions","organizations_url":"https://api.github.com/users/ashishmusale/orgs","repos_url":"https://api.github.com/users/ashishmusale/repos","events_url":"https://api.github.com/users/ashishmusale/events{/privacy}","received_events_url":"https://api.github.com/users/ashishmusale/received_events","type":"User","site_admin":false},"body":"Its missing HttpOnly, secure and sessionOnly property. Is this something you would be able to add?","created_at":"2018-09-10T17:50:48Z","updated_at":"2018-09-10T17:50:48Z","html_url":"https://github.com/CRAlpha/react-native-wkwebview/pull/171#discussion_r216415068","pull_request_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls/171","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls/comments/216415068"},"html":{"href":"https://github.com/CRAlpha/react-native-wkwebview/pull/171#discussion_r216415068"},"pull_request":{"href":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls/171","id":203444860,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNDQ0ODYw","html_url":"https://github.com/CRAlpha/react-native-wkwebview/pull/171","diff_url":"https://github.com/CRAlpha/react-native-wkwebview/pull/171.diff","patch_url":"https://github.com/CRAlpha/react-native-wkwebview/pull/171.patch","issue_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/issues/171","number":171,"state":"open","locked":false,"title":"Enable wk cookie store","user":{"login":"pwallrich","id":13999931,"node_id":"MDQ6VXNlcjEzOTk5OTMx","avatar_url":"https://avatars1.githubusercontent.com/u/13999931?v=4","gravatar_id":"","url":"https://api.github.com/users/pwallrich","html_url":"https://github.com/pwallrich","followers_url":"https://api.github.com/users/pwallrich/followers","following_url":"https://api.github.com/users/pwallrich/following{/other_user}","gists_url":"https://api.github.com/users/pwallrich/gists{/gist_id}","starred_url":"https://api.github.com/users/pwallrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwallrich/subscriptions","organizations_url":"https://api.github.com/users/pwallrich/orgs","repos_url":"https://api.github.com/users/pwallrich/repos","events_url":"https://api.github.com/users/pwallrich/events{/privacy}","received_events_url":"https://api.github.com/users/pwallrich/received_events","type":"User","site_admin":false},"body":"To improve the cookie handling a new option `useWKCookieStore` is introduced. \r\nWhen using `useWKCookieStore`, the cookies from `HTTPCookieStorage` get copied to the webView’s `WKHTTPCookieStorage`. \r\nThe cookie Plugins [https://github.com/joeferraro/react-native-cookies/](https://github.com/joeferraro/react-native-cookies/) and [https://github.com/shimohq/react-native-cookie](https://github.com/shimohq/react-native-cookie) do not support `WKHTTPCookieStorage` at the moment and use `NSHTTPCookieStorage` to save the cookies.\r\nThat's why the cookies are copied from the `NSHTTPCookieStorage`.\r\nA workaround is used to initialize the `WKHTTPCookieStorage` correctly. The WebKit bug https://bugs.webkit.org/show_bug.cgi?id=185483 prevents the initialization.","created_at":"2018-07-24T08:17:35Z","updated_at":"2018-09-10T17:50:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a469c8e1eed3aa62aa20b7c8c66c3456a7e6067","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":384543999,"node_id":"MDU6TGFiZWwzODQ1NDM5OTk=","url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls/171/commits","review_comments_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls/171/comments","review_comment_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/issues/171/comments","statuses_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/statuses/50a49a8f01ac4e09b69f6faf57a2e26310bd62df","head":{"label":"inovex:enable-wk-cookie-store","ref":"enable-wk-cookie-store","sha":"50a49a8f01ac4e09b69f6faf57a2e26310bd62df","user":{"login":"inovex","id":475590,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NTU5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/475590?v=4","gravatar_id":"","url":"https://api.github.com/users/inovex","html_url":"https://github.com/inovex","followers_url":"https://api.github.com/users/inovex/followers","following_url":"https://api.github.com/users/inovex/following{/other_user}","gists_url":"https://api.github.com/users/inovex/gists{/gist_id}","starred_url":"https://api.github.com/users/inovex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inovex/subscriptions","organizations_url":"https://api.github.com/users/inovex/orgs","repos_url":"https://api.github.com/users/inovex/repos","events_url":"https://api.github.com/users/inovex/events{/privacy}","received_events_url":"https://api.github.com/users/inovex/received_events","type":"Organization","site_admin":false},"repo":{"id":141553090,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1NTMwOTA=","name":"react-native-wkwebview","full_name":"inovex/react-native-wkwebview","owner":{"login":"inovex","id":475590,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NTU5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/475590?v=4","gravatar_id":"","url":"https://api.github.com/users/inovex","html_url":"https://github.com/inovex","followers_url":"https://api.github.com/users/inovex/followers","following_url":"https://api.github.com/users/inovex/following{/other_user}","gists_url":"https://api.github.com/users/inovex/gists{/gist_id}","starred_url":"https://api.github.com/users/inovex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inovex/subscriptions","organizations_url":"https://api.github.com/users/inovex/orgs","repos_url":"https://api.github.com/users/inovex/repos","events_url":"https://api.github.com/users/inovex/events{/privacy}","received_events_url":"https://api.github.com/users/inovex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inovex/react-native-wkwebview","description":"WKWebview Component for React Native","fork":true,"url":"https://api.github.com/repos/inovex/react-native-wkwebview","forks_url":"https://api.github.com/repos/inovex/react-native-wkwebview/forks","keys_url":"https://api.github.com/repos/inovex/react-native-wkwebview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inovex/react-native-wkwebview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inovex/react-native-wkwebview/teams","hooks_url":"https://api.github.com/repos/inovex/react-native-wkwebview/hooks","issue_events_url":"https://api.github.com/repos/inovex/react-native-wkwebview/issues/events{/number}","events_url":"https://api.github.com/repos/inovex/react-native-wkwebview/events","assignees_url":"https://api.github.com/repos/inovex/react-native-wkwebview/assignees{/user}","branches_url":"https://api.github.com/repos/inovex/react-native-wkwebview/branches{/branch}","tags_url":"https://api.github.com/repos/inovex/react-native-wkwebview/tags","blobs_url":"https://api.github.com/repos/inovex/react-native-wkwebview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inovex/react-native-wkwebview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inovex/react-native-wkwebview/git/refs{/sha}","trees_url":"https://api.github.com/repos/inovex/react-native-wkwebview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inovex/react-native-wkwebview/statuses/{sha}","languages_url":"https://api.github.com/repos/inovex/react-native-wkwebview/languages","stargazers_url":"https://api.github.com/repos/inovex/react-native-wkwebview/stargazers","contributors_url":"https://api.github.com/repos/inovex/react-native-wkwebview/contributors","subscribers_url":"https://api.github.com/repos/inovex/react-native-wkwebview/subscribers","subscription_url":"https://api.github.com/repos/inovex/react-native-wkwebview/subscription","commits_url":"https://api.github.com/repos/inovex/react-native-wkwebview/commits{/sha}","git_commits_url":"https://api.github.com/repos/inovex/react-native-wkwebview/git/commits{/sha}","comments_url":"https://api.github.com/repos/inovex/react-native-wkwebview/comments{/number}","issue_comment_url":"https://api.github.com/repos/inovex/react-native-wkwebview/issues/comments{/number}","contents_url":"https://api.github.com/repos/inovex/react-native-wkwebview/contents/{+path}","compare_url":"https://api.github.com/repos/inovex/react-native-wkwebview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inovex/react-native-wkwebview/merges","archive_url":"https://api.github.com/repos/inovex/react-native-wkwebview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inovex/react-native-wkwebview/downloads","issues_url":"https://api.github.com/repos/inovex/react-native-wkwebview/issues{/number}","pulls_url":"https://api.github.com/repos/inovex/react-native-wkwebview/pulls{/number}","milestones_url":"https://api.github.com/repos/inovex/react-native-wkwebview/milestones{/number}","notifications_url":"https://api.github.com/repos/inovex/react-native-wkwebview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inovex/react-native-wkwebview/labels{/name}","releases_url":"https://api.github.com/repos/inovex/react-native-wkwebview/releases{/id}","deployments_url":"https://api.github.com/repos/inovex/react-native-wkwebview/deployments","created_at":"2018-07-19T09:05:07Z","updated_at":"2018-08-15T08:23:57Z","pushed_at":"2018-08-15T08:36:09Z","git_url":"git://github.com/inovex/react-native-wkwebview.git","ssh_url":"git@github.com:inovex/react-native-wkwebview.git","clone_url":"https://github.com/inovex/react-native-wkwebview.git","svn_url":"https://github.com/inovex/react-native-wkwebview","homepage":null,"size":342,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"CRAlpha:master","ref":"master","sha":"5cc3ebc2f80c2d7f94e1018fdaeb8fcec51bebb9","user":{"login":"CRAlpha","id":17263762,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjYzNzYy","avatar_url":"https://avatars3.githubusercontent.com/u/17263762?v=4","gravatar_id":"","url":"https://api.github.com/users/CRAlpha","html_url":"https://github.com/CRAlpha","followers_url":"https://api.github.com/users/CRAlpha/followers","following_url":"https://api.github.com/users/CRAlpha/following{/other_user}","gists_url":"https://api.github.com/users/CRAlpha/gists{/gist_id}","starred_url":"https://api.github.com/users/CRAlpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CRAlpha/subscriptions","organizations_url":"https://api.github.com/users/CRAlpha/orgs","repos_url":"https://api.github.com/users/CRAlpha/repos","events_url":"https://api.github.com/users/CRAlpha/events{/privacy}","received_events_url":"https://api.github.com/users/CRAlpha/received_events","type":"Organization","site_admin":false},"repo":{"id":59982920,"node_id":"MDEwOlJlcG9zaXRvcnk1OTk4MjkyMA==","name":"react-native-wkwebview","full_name":"CRAlpha/react-native-wkwebview","owner":{"login":"CRAlpha","id":17263762,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjYzNzYy","avatar_url":"https://avatars3.githubusercontent.com/u/17263762?v=4","gravatar_id":"","url":"https://api.github.com/users/CRAlpha","html_url":"https://github.com/CRAlpha","followers_url":"https://api.github.com/users/CRAlpha/followers","following_url":"https://api.github.com/users/CRAlpha/following{/other_user}","gists_url":"https://api.github.com/users/CRAlpha/gists{/gist_id}","starred_url":"https://api.github.com/users/CRAlpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CRAlpha/subscriptions","organizations_url":"https://api.github.com/users/CRAlpha/orgs","repos_url":"https://api.github.com/users/CRAlpha/repos","events_url":"https://api.github.com/users/CRAlpha/events{/privacy}","received_events_url":"https://api.github.com/users/CRAlpha/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CRAlpha/react-native-wkwebview","description":"WKWebview Component for React Native","fork":false,"url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview","forks_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/forks","keys_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/teams","hooks_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/hooks","issue_events_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/issues/events{/number}","events_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/events","assignees_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/assignees{/user}","branches_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/branches{/branch}","tags_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/tags","blobs_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/git/refs{/sha}","trees_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/statuses/{sha}","languages_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/languages","stargazers_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/stargazers","contributors_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/contributors","subscribers_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/subscribers","subscription_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/subscription","commits_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/commits{/sha}","git_commits_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/git/commits{/sha}","comments_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/comments{/number}","issue_comment_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/issues/comments{/number}","contents_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/contents/{+path}","compare_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/merges","archive_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/downloads","issues_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/issues{/number}","pulls_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls{/number}","milestones_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/milestones{/number}","notifications_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/labels{/name}","releases_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/releases{/id}","deployments_url":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/deployments","created_at":"2016-05-30T05:33:12Z","updated_at":"2018-09-08T08:08:47Z","pushed_at":"2018-09-05T12:42:44Z","git_url":"git://github.com/CRAlpha/react-native-wkwebview.git","ssh_url":"git@github.com:CRAlpha/react-native-wkwebview.git","clone_url":"https://github.com/CRAlpha/react-native-wkwebview.git","svn_url":"https://github.com/CRAlpha/react-native-wkwebview","homepage":null,"size":355,"stargazers_count":507,"watchers_count":507,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":228,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":228,"open_issues":55,"watchers":507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls/171"},"html":{"href":"https://github.com/CRAlpha/react-native-wkwebview/pull/171"},"issue":{"href":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/issues/171"},"comments":{"href":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/CRAlpha/react-native-wkwebview/statuses/50a49a8f01ac4e09b69f6faf57a2e26310bd62df"}},"author_association":"NONE"}}
{"actor":{"display_login":"ashishmusale"}}