{"action":"created","issue":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/3660","repository_url":"https://api.github.com/repos/vuetifyjs/vuetify","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/3660/labels{/name}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/3660/comments","events_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/3660/events","html_url":"https://github.com/vuetifyjs/vuetify/pull/3660","id":308266990,"number":3660,"title":"fix (v-tabs): disabled tab is not disabled","user":{"login":"jacekkarczmarczyk","id":15625235,"avatar_url":"https://avatars3.githubusercontent.com/u/15625235?v=4","gravatar_id":"","url":"https://api.github.com/users/jacekkarczmarczyk","html_url":"https://github.com/jacekkarczmarczyk","followers_url":"https://api.github.com/users/jacekkarczmarczyk/followers","following_url":"https://api.github.com/users/jacekkarczmarczyk/following{/other_user}","gists_url":"https://api.github.com/users/jacekkarczmarczyk/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkarczmarczyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkarczmarczyk/subscriptions","organizations_url":"https://api.github.com/users/jacekkarczmarczyk/orgs","repos_url":"https://api.github.com/users/jacekkarczmarczyk/repos","events_url":"https://api.github.com/users/jacekkarczmarczyk/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkarczmarczyk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-24T14:30:48Z","updated_at":"2018-03-24T14:36:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/3660","html_url":"https://github.com/vuetifyjs/vuetify/pull/3660","diff_url":"https://github.com/vuetifyjs/vuetify/pull/3660.diff","patch_url":"https://github.com/vuetifyjs/vuetify/pull/3660.patch"},"body":"## Description\r\nFixes wrong styling and adds `pointer-events: none` to avoid calling click handler on click\r\n\r\n## Motivation and Context\r\nfixes #3644\r\n\r\n## How Has This Been Tested?\r\nvisually\r\n\r\n## Markup:\r\n```vue\r\n<template>\r\n  <v-app>\r\n    <v-content>\r\n      <v-tabs v-model=\"tab\">\r\n        <v-tab>One</v-tab>\r\n        <v-tab disabled>Two</v-tab>\r\n        <v-tab>Three</v-tab>\r\n      </v-tabs>\r\n    </v-content>\r\n  </v-app>\r\n</template>\r\n\r\n<script>\r\n export default {\r\n   data () {\r\n      return {\r\n        tab: null\r\n      }\r\n   },\r\n }\r\n</script>\r\n```\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] The PR title is no longer than 64 characters.\r\n- [x] The PR is submitted to the correct branch (`master` for bug fixes, `dev` for new features and breaking changes).\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have created a PR in the [documentation](https://github.com/vuetifyjs/vuetifyjs.com) with the necessary changes.\r\n"},"comment":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/comments/375893822","html_url":"https://github.com/vuetifyjs/vuetify/pull/3660#issuecomment-375893822","issue_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/3660","id":375893822,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-03-24T14:36:10Z","updated_at":"2018-03-24T14:36:10Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660?src=pr&el=h1) Report\n> Merging [#3660](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660?src=pr&el=desc) into [master](https://codecov.io/gh/vuetifyjs/vuetify/commit/1b779a373e57a57bce20eb9c92a1480a6aba853a?src=pr&el=desc) will **increase** coverage by `0.03%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660/graphs/tree.svg?token=zytLhwff8c&src=pr&height=150&width=650)](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #3660      +/-   ##\n==========================================\n+ Coverage   84.53%   84.56%   +0.03%     \n==========================================\n  Files         152      152              \n  Lines        3530     3680     +150     \n  Branches     1108     1167      +59     \n==========================================\n+ Hits         2984     3112     +128     \n- Misses        412      430      +18     \n- Partials      134      138       +4\n```\n\n\n| [Impacted Files](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/mixins/data-iterable.js](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660/diff?src=pr&el=tree#diff-c3JjL21peGlucy9kYXRhLWl0ZXJhYmxlLmpz) | `73.33% <0%> (-1.47%)` | :arrow_down: |\n| [...mponents/VExpansionPanel/VExpansionPanelContent.js](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvVkV4cGFuc2lvblBhbmVsL1ZFeHBhbnNpb25QYW5lbENvbnRlbnQuanM=) | `82.75% <0%> (-0.58%)` | :arrow_down: |\n| [src/directives/ripple.js](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660/diff?src=pr&el=tree#diff-c3JjL2RpcmVjdGl2ZXMvcmlwcGxlLmpz) | `42.85% <0%> (-0.52%)` | :arrow_down: |\n| [src/mixins/bootable.js](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660/diff?src=pr&el=tree#diff-c3JjL21peGlucy9ib290YWJsZS5qcw==) | `100% <0%> (ø)` | :arrow_up: |\n| [src/components/VExpansionPanel/VExpansionPanel.js](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvVkV4cGFuc2lvblBhbmVsL1ZFeHBhbnNpb25QYW5lbC5qcw==) | `92.3% <0%> (ø)` | :arrow_up: |\n| [src/components/VToolbar/VToolbar.js](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvVlRvb2xiYXIvVlRvb2xiYXIuanM=) | `96.73% <0%> (+0.44%)` | :arrow_up: |\n| [src/mixins/overlayable.js](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660/diff?src=pr&el=tree#diff-c3JjL21peGlucy9vdmVybGF5YWJsZS5qcw==) | `39.5% <0%> (+0.75%)` | :arrow_up: |\n| [src/mixins/detachable.js](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660/diff?src=pr&el=tree#diff-c3JjL21peGlucy9kZXRhY2hhYmxlLmpz) | `73.52% <0%> (+26.16%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660?src=pr&el=footer). Last update [1b779a3...3b6e901](https://codecov.io/gh/vuetifyjs/vuetify/pull/3660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}