{"action":"created","issue":{"url":"https://api.github.com/repos/apache/thrift/issues/1524","repository_url":"https://api.github.com/repos/apache/thrift","labels_url":"https://api.github.com/repos/apache/thrift/issues/1524/labels{/name}","comments_url":"https://api.github.com/repos/apache/thrift/issues/1524/comments","events_url":"https://api.github.com/repos/apache/thrift/issues/1524/events","html_url":"https://github.com/apache/thrift/pull/1524","id":310151075,"number":1524,"title":"THRIFT-4535: XML docs; code cleanup (tabs->spaces; String->string)","user":{"login":"cwe1ss","id":4581460,"avatar_url":"https://avatars1.githubusercontent.com/u/4581460?v=4","gravatar_id":"","url":"https://api.github.com/users/cwe1ss","html_url":"https://github.com/cwe1ss","followers_url":"https://api.github.com/users/cwe1ss/followers","following_url":"https://api.github.com/users/cwe1ss/following{/other_user}","gists_url":"https://api.github.com/users/cwe1ss/gists{/gist_id}","starred_url":"https://api.github.com/users/cwe1ss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwe1ss/subscriptions","organizations_url":"https://api.github.com/users/cwe1ss/orgs","repos_url":"https://api.github.com/users/cwe1ss/repos","events_url":"https://api.github.com/users/cwe1ss/events{/privacy}","received_events_url":"https://api.github.com/users/cwe1ss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-30T19:39:49Z","updated_at":"2018-03-31T08:53:01Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/thrift/pulls/1524","html_url":"https://github.com/apache/thrift/pull/1524","diff_url":"https://github.com/apache/thrift/pull/1524.diff","patch_url":"https://github.com/apache/thrift/pull/1524.patch"},"body":"As discussed in [THRIFT-4535](https://issues.apache.org/jira/browse/THRIFT-4535) we'd like to go back to just one .NET library that supports .NET framework (including Mono) AND .NET Core. \r\n\r\nAs I had to learn about the library before doing some actual changes, I updated the files to contain proper XML comments (which can be used for IntelliSense) and I did some code cleanup. I did NOT change any code.\r\n\r\nFeel free to close this PR, if you prefer to not have such a cleanup commit.\r\n\r\n/cc @Jens-G @jeking3 \r\n\r\nPS: I'll submit actual code changes once this PR is merged or rejected."},"comment":{"url":"https://api.github.com/repos/apache/thrift/issues/comments/377677871","html_url":"https://github.com/apache/thrift/pull/1524#issuecomment-377677871","issue_url":"https://api.github.com/repos/apache/thrift/issues/1524","id":377677871,"user":{"login":"Jens-G","id":5834733,"avatar_url":"https://avatars2.githubusercontent.com/u/5834733?v=4","gravatar_id":"","url":"https://api.github.com/users/Jens-G","html_url":"https://github.com/Jens-G","followers_url":"https://api.github.com/users/Jens-G/followers","following_url":"https://api.github.com/users/Jens-G/following{/other_user}","gists_url":"https://api.github.com/users/Jens-G/gists{/gist_id}","starred_url":"https://api.github.com/users/Jens-G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jens-G/subscriptions","organizations_url":"https://api.github.com/users/Jens-G/orgs","repos_url":"https://api.github.com/users/Jens-G/repos","events_url":"https://api.github.com/users/Jens-G/events{/privacy}","received_events_url":"https://api.github.com/users/Jens-G/received_events","type":"User","site_admin":false},"created_at":"2018-03-31T08:53:01Z","updated_at":"2018-03-31T08:53:01Z","author_association":"MEMBER","body":"Disclaimer: I did not look at every line and I did not look into the AppVeyor failure. \r\n\r\nAside from one minor thing everything that I skimmed through LTGM, and my code still compiles :-) so I'm basically fine with."}}
{"actor":{"display_login":"Jens-G"}}