{"action":"created","comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/181517082","pull_request_review_id":112167997,"id":181517082,"diff_hunk":"@@ -0,0 +1,25 @@\n+// @apiVersion 0.1\n+// @name io.ksonnet.pkg.cloud-endpoints\n+// @description Provides cloud-endpoints prototypes for creating Cloud Endpoints services and DNS records.\n+// @shortDescription Cloud Endpoint domain creation.\n+// @param name string Name for the component\n+// @param secretName string Name of secret containing the json service account key.\n+// @optionalParam secretKey string cloudep-sa.json Name of the key in the secret containing the JSON service account key.\n+// @optionalParam namespace string null Namespace to use for the components. It is automatically inherited from the environment if not set.\n+\n+// TODO(https://github.com/ksonnet/ksonnet/issues/222): We have to add namespace as an explicit parameter","path":"kubeflow/core/prototypes/cloud-endpoints.jsonnet","position":10,"original_position":10,"commit_id":"e2b91728bfd2fead781f17980af4dc0c1e13bb6b","original_commit_id":"e2b91728bfd2fead781f17980af4dc0c1e13bb6b","user":{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"body":"Delete this since the issue has been resolved you are inheriting namespace below.","created_at":"2018-04-13T21:44:34Z","updated_at":"2018-04-13T21:44:34Z","html_url":"https://github.com/kubeflow/kubeflow/pull/605#discussion_r181517082","pull_request_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/605","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/181517082"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/605#discussion_r181517082"},"pull_request":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/605"}}},"pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/605","id":180019221,"html_url":"https://github.com/kubeflow/kubeflow/pull/605","diff_url":"https://github.com/kubeflow/kubeflow/pull/605.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/605.patch","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/605","number":605,"state":"open","locked":false,"title":"import of cloud-endpoints component and support in iap-ingress component","user":{"login":"danisla","id":323725,"avatar_url":"https://avatars0.githubusercontent.com/u/323725?v=4","gravatar_id":"","url":"https://api.github.com/users/danisla","html_url":"https://github.com/danisla","followers_url":"https://api.github.com/users/danisla/followers","following_url":"https://api.github.com/users/danisla/following{/other_user}","gists_url":"https://api.github.com/users/danisla/gists{/gist_id}","starred_url":"https://api.github.com/users/danisla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danisla/subscriptions","organizations_url":"https://api.github.com/users/danisla/orgs","repos_url":"https://api.github.com/users/danisla/repos","events_url":"https://api.github.com/users/danisla/events{/privacy}","received_events_url":"https://api.github.com/users/danisla/received_events","type":"User","site_admin":false},"body":"Fixes #586 \r\n\r\n- Import of cloud-endpoints CRD and controller. Depends on kube-metacontroller which is bundled with the component.\r\n- Updated iap-ingress component to create the `CloudEndpoint` resource if the FQDN matches the form of `NAME.endpoints.PROJECT.cloud.goog`\r\n- Updated the IAP doc with steps for using Cloud Endpoints.\r\n\r\n/cc @kunmingg\r\n/cc @ankushagarwal \r\n/cc @jlewi\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/605)\n<!-- Reviewable:end -->\n","created_at":"2018-04-06T18:18:20Z","updated_at":"2018-04-13T21:44:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adff8c5a84b6e9e44d7d19c58d5a62b83ef113b1","assignee":{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},{"login":"kunmingg","id":37601826,"avatar_url":"https://avatars2.githubusercontent.com/u/37601826?v=4","gravatar_id":"","url":"https://api.github.com/users/kunmingg","html_url":"https://github.com/kunmingg","followers_url":"https://api.github.com/users/kunmingg/followers","following_url":"https://api.github.com/users/kunmingg/following{/other_user}","gists_url":"https://api.github.com/users/kunmingg/gists{/gist_id}","starred_url":"https://api.github.com/users/kunmingg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunmingg/subscriptions","organizations_url":"https://api.github.com/users/kunmingg/orgs","repos_url":"https://api.github.com/users/kunmingg/repos","events_url":"https://api.github.com/users/kunmingg/events{/privacy}","received_events_url":"https://api.github.com/users/kunmingg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":852268762,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/approved","name":"approved","color":"0e8a16","default":false},{"id":853947074,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"fbca04","default":false},{"id":796399084,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/L","name":"size/L","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/605/commits","review_comments_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/605/comments","review_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/605/comments","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/e2b91728bfd2fead781f17980af4dc0c1e13bb6b","head":{"label":"danisla:import-cloud-endpoints","ref":"import-cloud-endpoints","sha":"e2b91728bfd2fead781f17980af4dc0c1e13bb6b","user":{"login":"danisla","id":323725,"avatar_url":"https://avatars0.githubusercontent.com/u/323725?v=4","gravatar_id":"","url":"https://api.github.com/users/danisla","html_url":"https://github.com/danisla","followers_url":"https://api.github.com/users/danisla/followers","following_url":"https://api.github.com/users/danisla/following{/other_user}","gists_url":"https://api.github.com/users/danisla/gists{/gist_id}","starred_url":"https://api.github.com/users/danisla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danisla/subscriptions","organizations_url":"https://api.github.com/users/danisla/orgs","repos_url":"https://api.github.com/users/danisla/repos","events_url":"https://api.github.com/users/danisla/events{/privacy}","received_events_url":"https://api.github.com/users/danisla/received_events","type":"User","site_admin":false},"repo":{"id":125569816,"name":"kubeflow","full_name":"danisla/kubeflow","owner":{"login":"danisla","id":323725,"avatar_url":"https://avatars0.githubusercontent.com/u/323725?v=4","gravatar_id":"","url":"https://api.github.com/users/danisla","html_url":"https://github.com/danisla","followers_url":"https://api.github.com/users/danisla/followers","following_url":"https://api.github.com/users/danisla/following{/other_user}","gists_url":"https://api.github.com/users/danisla/gists{/gist_id}","starred_url":"https://api.github.com/users/danisla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danisla/subscriptions","organizations_url":"https://api.github.com/users/danisla/orgs","repos_url":"https://api.github.com/users/danisla/repos","events_url":"https://api.github.com/users/danisla/events{/privacy}","received_events_url":"https://api.github.com/users/danisla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danisla/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":true,"url":"https://api.github.com/repos/danisla/kubeflow","forks_url":"https://api.github.com/repos/danisla/kubeflow/forks","keys_url":"https://api.github.com/repos/danisla/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danisla/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danisla/kubeflow/teams","hooks_url":"https://api.github.com/repos/danisla/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/danisla/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/danisla/kubeflow/events","assignees_url":"https://api.github.com/repos/danisla/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/danisla/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/danisla/kubeflow/tags","blobs_url":"https://api.github.com/repos/danisla/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danisla/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danisla/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/danisla/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danisla/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/danisla/kubeflow/languages","stargazers_url":"https://api.github.com/repos/danisla/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/danisla/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/danisla/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/danisla/kubeflow/subscription","commits_url":"https://api.github.com/repos/danisla/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/danisla/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/danisla/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/danisla/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/danisla/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/danisla/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danisla/kubeflow/merges","archive_url":"https://api.github.com/repos/danisla/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danisla/kubeflow/downloads","issues_url":"https://api.github.com/repos/danisla/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/danisla/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/danisla/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/danisla/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danisla/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/danisla/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/danisla/kubeflow/deployments","created_at":"2018-03-16T21:06:09Z","updated_at":"2018-04-03T17:01:02Z","pushed_at":"2018-04-13T20:59:40Z","git_url":"git://github.com/danisla/kubeflow.git","ssh_url":"git@github.com:danisla/kubeflow.git","clone_url":"https://github.com/danisla/kubeflow.git","svn_url":"https://github.com/danisla/kubeflow","homepage":"","size":100353,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"99fea53053f2190c0624c0ff821f941df4a71c94","user":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":112647343,"name":"kubeflow","full_name":"kubeflow/kubeflow","owner":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeflow/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubeflow/kubeflow","forks_url":"https://api.github.com/repos/kubeflow/kubeflow/forks","keys_url":"https://api.github.com/repos/kubeflow/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/kubeflow/teams","hooks_url":"https://api.github.com/repos/kubeflow/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/kubeflow/events","assignees_url":"https://api.github.com/repos/kubeflow/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/kubeflow/tags","blobs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/kubeflow/languages","stargazers_url":"https://api.github.com/repos/kubeflow/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/kubeflow/subscription","commits_url":"https://api.github.com/repos/kubeflow/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/kubeflow/merges","archive_url":"https://api.github.com/repos/kubeflow/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/kubeflow/downloads","issues_url":"https://api.github.com/repos/kubeflow/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/kubeflow/deployments","created_at":"2017-11-30T18:44:19Z","updated_at":"2018-04-13T18:07:17Z","pushed_at":"2018-04-13T20:59:47Z","git_url":"git://github.com/kubeflow/kubeflow.git","ssh_url":"git@github.com:kubeflow/kubeflow.git","clone_url":"https://github.com/kubeflow/kubeflow.git","svn_url":"https://github.com/kubeflow/kubeflow","homepage":"","size":121440,"stargazers_count":3019,"watchers_count":3019,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":354,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":354,"open_issues":180,"watchers":3019,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/605"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/605"},"issue":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/605"},"comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/605/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/605/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/605/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/kubeflow/statuses/e2b91728bfd2fead781f17980af4dc0c1e13bb6b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jlewi"}}