{"action":"reopened","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/50760","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/50760/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/50760/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/50760/events","html_url":"https://github.com/Microsoft/vscode/issues/50760","id":327583115,"node_id":"MDU6SXNzdWUzMjc1ODMxMTU=","number":50760,"title":"Bad fsPath checks on Windows","user":{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false},"labels":[{"id":256129993,"node_id":"MDU6TGFiZWwyNTYxMjk5OTM=","url":"https://api.github.com/repos/Microsoft/vscode/labels/bug","name":"bug","color":"8D6673","default":true},{"id":529237263,"node_id":"MDU6TGFiZWw1MjkyMzcyNjM=","url":"https://api.github.com/repos/Microsoft/vscode/labels/settings-editor","name":"settings-editor","color":"c5def5","default":false},{"id":291057332,"node_id":"MDU6TGFiZWwyOTEwNTczMzI=","url":"https://api.github.com/repos/Microsoft/vscode/labels/verified","name":"verified","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"assignees":[{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/67","html_url":"https://github.com/Microsoft/vscode/milestone/67","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/67/labels","id":3236860,"node_id":"MDk6TWlsZXN0b25lMzIzNjg2MA==","number":67,"title":"May 2018","description":"","creator":{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":493,"state":"open","created_at":"2018-04-03T01:16:18Z","updated_at":"2018-06-01T09:05:09Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-05-30T05:52:11Z","updated_at":"2018-06-01T09:05:09Z","closed_at":null,"author_association":"MEMBER","body":"I noticed that this test \r\nhttps://github.com/Microsoft/vscode/blob/43d168182c8df35a99c7f5ee0ef227de34f75fbd/src/vs/workbench/parts/preferences/common/preferencesContribution.ts#L82 and the same one here https://github.com/Microsoft/vscode/blob/43d168182c8df35a99c7f5ee0ef227de34f75fbd/src/vs/workbench/services/textfile/common/textFileEditorModel.ts#L783\r\n\r\ncan fail on Windows when resource.fsPath has a lower case drive letter and `appSettingsPath` has an upper case drive letter. @bpasero I think we are trying to enforce a lower case drive letter inside vscode, right? Is the environmentService wrong or should this just be a case-insensitive comparison?"}}
{"actor":{"display_login":"isidorn"}}