{"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/comments/214634316","pull_request_review_id":151730981,"id":214634316,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDYzNDMxNg==","diff_hunk":"@@ -89,48 +89,50 @@ namespace\n \n     enum ParamId\n     {\n-        ParamIdOuputMode                = 0,\n-        ParamIdProjectPath              = 1,\n-        ParamIdScaleMultiplier          = 2,\n+        ParamIdOuputMode                    = 0,\n+        ParamIdProjectPath                  = 1,\n+        ParamIdScaleMultiplier              = 2,\n         \n-        ParamIdPixelSamples             = 3,\n-        ParamIdTileSize                 = 4,\n-        ParamIdPasses                   = 5,\n-        ParamIdFilterSize               = 6,\n-        ParamIdFilterType               = 7,\n+        ParamIdPixelSamples                 = 3,\n+        ParamIdTileSize                     = 4,\n+        ParamIdPasses                       = 5,\n+        ParamIdFilterSize                   = 6,\n+        ParamIdFilterType                   = 7,\n         \n-        ParamIdEnableGI                 = 8,\n-        ParamIdGIBounces                = 9,\n-        ParamIdEnableCaustics           = 10,\n-        ParamIdEnableMaxRayIntensity    = 11,\n-        ParamIdMaxRayIntensity          = 12,\n-        ParamIdForceDefaultLightsOff    = 13,\n-        ParamIdEnableBackgroundLight    = 14,\n-        ParamIdBackgroundAlphaValue     = 15,\n-        ParamIdRoughnessClamping        = 23,\n-        ParamIdEnableDiffBounceLimit    = 25,\n-        ParamIdDiffBounceLimit          = 26,\n-        ParamIdEnableGlossBounceLimit   = 27,\n-        ParamIdGlossBounceLimit         = 28,\n-        ParamIdEnableSpecBounceLimit    = 29,\n-        ParamIdSpecBounceLimit          = 30,\n-        ParamIdEnableVolBounceLimit     = 31,\n-        ParamIdVolBounceLimit           = 32,\n-        ParamIdCPUCores                 = 16,\n-        ParamIdOpenLogMode              = 17,\n-        ParamIdLogMaterialRendering     = 18,\n-        ParamIdUseMaxProcedurals        = 19,\n-        ParamIdEnableLowPriority        = 20,\n-        ParamIdEnableRenderStamp        = 21,\n-        ParamIdRenderStampFormat        = 22,\n-        ParamIdEnableEmbree             = 24,\n-        ParamIdDirectLightSamples       = 33,\n-        ParamIdLowLightThreshold        = 34,\n-        ParamIdEnvLightSamples          = 35,\n-        ParamIdRRMinPathLength          = 36,\n-        ParamIdEnableDirectLighting     = 37,\n-        ParamIdVolumeDistanceSamples    = 38,\n-        ParamIdOptLightOutsideVolumes   = 39,\n+        ParamIdEnableGI                     = 8,\n+        ParamIdEnableCaustics               = 10,\n+        ParamIdEnableMaxRayIntensity        = 11,\n+        ParamIdMaxRayIntensity              = 12,\n+        ParamIdForceDefaultLightsOff        = 13,\n+        ParamIdEnableBackgroundLight        = 14,\n+        ParamIdBackgroundAlphaValue         = 15,\n+        ParamIdEnableRoughnessClamping      = 23,\n+        ParamIdEnableDiffuseBounceLimit     = 25,\n+        ParamIdEnableGlossyBounceLimit      = 27,\n+        ParamIdEnableSpecularBounceLimit    = 29,\n+        ParamIdEnableVolumeBounceLimit      = 31,\n+        ParamIdGlobalBounceLimit            = 9,\n+        ParamIdDiffuseBounceLimit           = 26,\n+        ParamIdGlossyBounceLimit            = 28,\n+        ParamIdSpecularBounceLimit          = 30,\n+        ParamIdVolumeBounceLimit            = 32,\n+        ParamIdDirectLightSamples           = 33,\n+        ParamIdLowLightThreshold            = 34,\n+        ParamIdEnvLightSamples              = 35,\n+        ParamIdRussianRouletteMinPathLength = 36,\n+        ParamIdEnableDirectLighting         = 37,\n+        ParamIdVolumeDistanceSamples        = 38,\n+        ParamIdOptLightOutsideVolumes       = 39,\n+\n+        ParamIdCPUCores                     = 16,\n+        ParamIdOpenLogMode                  = 17,\n+        ParamIdLogMaterialRendering         = 18,\n+        ParamIdUseMaxProcedurals            = 19,\n+        ParamIdEnableLowPriority            = 20,\n+        ParamIdEnableRenderStamp            = 21,\n+        ParamIdRenderStampFormat            = 22,\n+        ParamIdEnableEmbree                 = 24,\n+","path":"src/appleseed-max-impl/appleseedrenderer/appleseedrenderer.cpp","position":71,"original_position":87,"commit_id":"97c7b11f880b262ecaf4e0f6a22d1bb9cfbfc475","original_commit_id":"97c7b11f880b262ecaf4e0f6a22d1bb9cfbfc475","user":{"login":"dictoon","id":321290,"node_id":"MDQ6VXNlcjMyMTI5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/321290?v=4","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"body":"Remove extra blank line.","created_at":"2018-09-03T09:54:00Z","updated_at":"2018-09-03T09:54:24Z","html_url":"https://github.com/appleseedhq/appleseed-max/pull/204#discussion_r214634316","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/204","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/comments/214634316"},"html":{"href":"https://github.com/appleseedhq/appleseed-max/pull/204#discussion_r214634316"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/204"}}},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/204","id":210918297,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTE4Mjk3","html_url":"https://github.com/appleseedhq/appleseed-max/pull/204","diff_url":"https://github.com/appleseedhq/appleseed-max/pull/204.diff","patch_url":"https://github.com/appleseedhq/appleseed-max/pull/204.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/204","number":204,"state":"open","locked":false,"title":"Add various pathtracer render engine controls","user":{"login":"Mango-3","id":22252558,"node_id":"MDQ6VXNlcjIyMjUyNTU4","avatar_url":"https://avatars0.githubusercontent.com/u/22252558?v=4","gravatar_id":"","url":"https://api.github.com/users/Mango-3","html_url":"https://github.com/Mango-3","followers_url":"https://api.github.com/users/Mango-3/followers","following_url":"https://api.github.com/users/Mango-3/following{/other_user}","gists_url":"https://api.github.com/users/Mango-3/gists{/gist_id}","starred_url":"https://api.github.com/users/Mango-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mango-3/subscriptions","organizations_url":"https://api.github.com/users/Mango-3/orgs","repos_url":"https://api.github.com/users/Mango-3/repos","events_url":"https://api.github.com/users/Mango-3/events{/privacy}","received_events_url":"https://api.github.com/users/Mango-3/received_events","type":"User","site_admin":false},"body":"Add renderer controls for:\r\n\r\n- Direct Lighting on/off\r\n- Ray type bounce limits for diffuse, glossy, specular, volume\r\n- Volume Distance Samples\r\n- Russian Roulette Start Bounce\r\n- Optimize for Light Outside Volumes\r\n- Roughness Clamping\r\n- Low Light Threshold\r\n- Direct and IBL samples multiplier\r\n- Embree on/off ","created_at":"2018-08-25T19:45:20Z","updated_at":"2018-09-03T09:54:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"567da693b7249ce1ea00c3806aeb61e615c2494e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/204/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/204/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/204/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed-max/statuses/97c7b11f880b262ecaf4e0f6a22d1bb9cfbfc475","head":{"label":"Mango-3:ui_addons","ref":"ui_addons","sha":"97c7b11f880b262ecaf4e0f6a22d1bb9cfbfc475","user":{"login":"Mango-3","id":22252558,"node_id":"MDQ6VXNlcjIyMjUyNTU4","avatar_url":"https://avatars0.githubusercontent.com/u/22252558?v=4","gravatar_id":"","url":"https://api.github.com/users/Mango-3","html_url":"https://github.com/Mango-3","followers_url":"https://api.github.com/users/Mango-3/followers","following_url":"https://api.github.com/users/Mango-3/following{/other_user}","gists_url":"https://api.github.com/users/Mango-3/gists{/gist_id}","starred_url":"https://api.github.com/users/Mango-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mango-3/subscriptions","organizations_url":"https://api.github.com/users/Mango-3/orgs","repos_url":"https://api.github.com/users/Mango-3/repos","events_url":"https://api.github.com/users/Mango-3/events{/privacy}","received_events_url":"https://api.github.com/users/Mango-3/received_events","type":"User","site_admin":false},"repo":{"id":145806953,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4MDY5NTM=","name":"appleseed-max","full_name":"Mango-3/appleseed-max","owner":{"login":"Mango-3","id":22252558,"node_id":"MDQ6VXNlcjIyMjUyNTU4","avatar_url":"https://avatars0.githubusercontent.com/u/22252558?v=4","gravatar_id":"","url":"https://api.github.com/users/Mango-3","html_url":"https://github.com/Mango-3","followers_url":"https://api.github.com/users/Mango-3/followers","following_url":"https://api.github.com/users/Mango-3/following{/other_user}","gists_url":"https://api.github.com/users/Mango-3/gists{/gist_id}","starred_url":"https://api.github.com/users/Mango-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mango-3/subscriptions","organizations_url":"https://api.github.com/users/Mango-3/orgs","repos_url":"https://api.github.com/users/Mango-3/repos","events_url":"https://api.github.com/users/Mango-3/events{/privacy}","received_events_url":"https://api.github.com/users/Mango-3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mango-3/appleseed-max","description":"appleseed plugin for Autodesk® 3ds Max®","fork":true,"url":"https://api.github.com/repos/Mango-3/appleseed-max","forks_url":"https://api.github.com/repos/Mango-3/appleseed-max/forks","keys_url":"https://api.github.com/repos/Mango-3/appleseed-max/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mango-3/appleseed-max/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mango-3/appleseed-max/teams","hooks_url":"https://api.github.com/repos/Mango-3/appleseed-max/hooks","issue_events_url":"https://api.github.com/repos/Mango-3/appleseed-max/issues/events{/number}","events_url":"https://api.github.com/repos/Mango-3/appleseed-max/events","assignees_url":"https://api.github.com/repos/Mango-3/appleseed-max/assignees{/user}","branches_url":"https://api.github.com/repos/Mango-3/appleseed-max/branches{/branch}","tags_url":"https://api.github.com/repos/Mango-3/appleseed-max/tags","blobs_url":"https://api.github.com/repos/Mango-3/appleseed-max/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mango-3/appleseed-max/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mango-3/appleseed-max/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mango-3/appleseed-max/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mango-3/appleseed-max/statuses/{sha}","languages_url":"https://api.github.com/repos/Mango-3/appleseed-max/languages","stargazers_url":"https://api.github.com/repos/Mango-3/appleseed-max/stargazers","contributors_url":"https://api.github.com/repos/Mango-3/appleseed-max/contributors","subscribers_url":"https://api.github.com/repos/Mango-3/appleseed-max/subscribers","subscription_url":"https://api.github.com/repos/Mango-3/appleseed-max/subscription","commits_url":"https://api.github.com/repos/Mango-3/appleseed-max/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mango-3/appleseed-max/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mango-3/appleseed-max/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mango-3/appleseed-max/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mango-3/appleseed-max/contents/{+path}","compare_url":"https://api.github.com/repos/Mango-3/appleseed-max/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mango-3/appleseed-max/merges","archive_url":"https://api.github.com/repos/Mango-3/appleseed-max/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mango-3/appleseed-max/downloads","issues_url":"https://api.github.com/repos/Mango-3/appleseed-max/issues{/number}","pulls_url":"https://api.github.com/repos/Mango-3/appleseed-max/pulls{/number}","milestones_url":"https://api.github.com/repos/Mango-3/appleseed-max/milestones{/number}","notifications_url":"https://api.github.com/repos/Mango-3/appleseed-max/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mango-3/appleseed-max/labels{/name}","releases_url":"https://api.github.com/repos/Mango-3/appleseed-max/releases{/id}","deployments_url":"https://api.github.com/repos/Mango-3/appleseed-max/deployments","created_at":"2018-08-23T05:53:08Z","updated_at":"2018-08-23T05:53:11Z","pushed_at":"2018-08-29T18:17:44Z","git_url":"git://github.com/Mango-3/appleseed-max.git","ssh_url":"git@github.com:Mango-3/appleseed-max.git","clone_url":"https://github.com/Mango-3/appleseed-max.git","svn_url":"https://github.com/Mango-3/appleseed-max","homepage":"https://appleseedhq.net/","size":2004,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"d102a973848f2f6cac01cef725d8614dd412cad6","user":{"login":"appleseedhq","id":6373510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNzM1MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":45906123,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkwNjEyMw==","name":"appleseed-max","full_name":"appleseedhq/appleseed-max","owner":{"login":"appleseedhq","id":6373510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNzM1MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed-max","description":"appleseed plugin for Autodesk® 3ds Max®","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed-max","forks_url":"https://api.github.com/repos/appleseedhq/appleseed-max/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed-max/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed-max/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed-max/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed-max/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed-max/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed-max/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed-max/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed-max/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed-max/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed-max/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed-max/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed-max/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed-max/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed-max/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed-max/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed-max/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed-max/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed-max/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed-max/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed-max/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed-max/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed-max/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed-max/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed-max/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed-max/releases{/id}","deployments_url":"https://api.github.com/repos/appleseedhq/appleseed-max/deployments","created_at":"2015-11-10T10:57:32Z","updated_at":"2018-08-22T13:00:00Z","pushed_at":"2018-08-29T18:17:45Z","git_url":"git://github.com/appleseedhq/appleseed-max.git","ssh_url":"git@github.com:appleseedhq/appleseed-max.git","clone_url":"https://github.com/appleseedhq/appleseed-max.git","svn_url":"https://github.com/appleseedhq/appleseed-max","homepage":"https://appleseedhq.net/","size":1960,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":34,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/204"},"html":{"href":"https://github.com/appleseedhq/appleseed-max/pull/204"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/204"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/204/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/204/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/204/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/statuses/97c7b11f880b262ecaf4e0f6a22d1bb9cfbfc475"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dictoon"}}