{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-skywalking/pulls/comments/245344362","pull_request_review_id":189429243,"id":245344362,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTM0NDM2Mg==","diff_hunk":"@@ -45,14 +44,11 @@\n     public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes,\n                              MethodInterceptResult result) throws Throwable {\n         RedisConnection connection = (RedisConnection) objInst;\n+        Channel channel = connection.getChannel();\n         String peer = \"\";\n-        if (connection.getRedisClient() != null) {\n-            Field field = RedisClient.class.getDeclaredField(\"uri\");\n-            field.setAccessible(true);\n-            URI uri = (URI) field.get(connection.getRedisClient());\n-            if (uri != null) {\n-                peer = uri.getHost() + \":\" + uri.getPort();\n-            }\n+        if (channel.remoteAddress() instanceof InetSocketAddress) {","path":"apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonMethodInterceptor.java","position":49,"original_position":37,"commit_id":"2fb84c7c064e9fbf784f87d5cc7b4f12b64010e9","original_commit_id":"2fb84c7c064e9fbf784f87d5cc7b4f12b64010e9","user":{"login":"wu-sheng","id":5441976,"node_id":"MDQ6VXNlcjU0NDE5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5441976?v=4","gravatar_id":"","url":"https://api.github.com/users/wu-sheng","html_url":"https://github.com/wu-sheng","followers_url":"https://api.github.com/users/wu-sheng/followers","following_url":"https://api.github.com/users/wu-sheng/following{/other_user}","gists_url":"https://api.github.com/users/wu-sheng/gists{/gist_id}","starred_url":"https://api.github.com/users/wu-sheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wu-sheng/subscriptions","organizations_url":"https://api.github.com/users/wu-sheng/orgs","repos_url":"https://api.github.com/users/wu-sheng/repos","events_url":"https://api.github.com/users/wu-sheng/events{/privacy}","received_events_url":"https://api.github.com/users/wu-sheng/received_events","type":"User","site_admin":false},"body":"Action could set in every access. But peer don't need. Then you could avoid instanceof in every time","created_at":"2019-01-04T16:16:19Z","updated_at":"2019-01-04T16:16:19Z","html_url":"https://github.com/apache/incubator-skywalking/pull/2083#discussion_r245344362","pull_request_url":"https://api.github.com/repos/apache/incubator-skywalking/pulls/2083","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-skywalking/pulls/comments/245344362"},"html":{"href":"https://github.com/apache/incubator-skywalking/pull/2083#discussion_r245344362"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-skywalking/pulls/2083"}},"in_reply_to_id":245337623},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-skywalking/pulls/2083","id":240646955,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjQ2OTU1","html_url":"https://github.com/apache/incubator-skywalking/pull/2083","diff_url":"https://github.com/apache/incubator-skywalking/pull/2083.diff","patch_url":"https://github.com/apache/incubator-skywalking/pull/2083.patch","issue_url":"https://api.github.com/repos/apache/incubator-skywalking/issues/2083","number":2083,"state":"open","locked":false,"title":"Support redisson plugin","user":{"login":"zhaoyuguang","id":10150229,"node_id":"MDQ6VXNlcjEwMTUwMjI5","avatar_url":"https://avatars1.githubusercontent.com/u/10150229?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaoyuguang","html_url":"https://github.com/zhaoyuguang","followers_url":"https://api.github.com/users/zhaoyuguang/followers","following_url":"https://api.github.com/users/zhaoyuguang/following{/other_user}","gists_url":"https://api.github.com/users/zhaoyuguang/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaoyuguang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaoyuguang/subscriptions","organizations_url":"https://api.github.com/users/zhaoyuguang/orgs","repos_url":"https://api.github.com/users/zhaoyuguang/repos","events_url":"https://api.github.com/users/zhaoyuguang/events{/privacy}","received_events_url":"https://api.github.com/users/zhaoyuguang/received_events","type":"User","site_admin":false},"body":"- Why submit this pull request?\r\n- [ ] Bug fix\r\n- [x] New feature provided\r\n- [ ] Improve performance\r\n___\r\n### New feature or improvement\r\n- plugin support redisson.\r\n","created_at":"2018-12-22T18:04:27Z","updated_at":"2019-01-04T16:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a59e45c601e15f997a2a2965177255a0350feace","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ascrutae","id":12436447,"node_id":"MDQ6VXNlcjEyNDM2NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/12436447?v=4","gravatar_id":"","url":"https://api.github.com/users/ascrutae","html_url":"https://github.com/ascrutae","followers_url":"https://api.github.com/users/ascrutae/followers","following_url":"https://api.github.com/users/ascrutae/following{/other_user}","gists_url":"https://api.github.com/users/ascrutae/gists{/gist_id}","starred_url":"https://api.github.com/users/ascrutae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascrutae/subscriptions","organizations_url":"https://api.github.com/users/ascrutae/orgs","repos_url":"https://api.github.com/users/ascrutae/repos","events_url":"https://api.github.com/users/ascrutae/events{/privacy}","received_events_url":"https://api.github.com/users/ascrutae/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":830850387,"node_id":"MDU6TGFiZWw4MzA4NTAzODc=","url":"https://api.github.com/repos/apache/incubator-skywalking/labels/agent","name":"agent","color":"c2e0c6","default":false},{"id":845597520,"node_id":"MDU6TGFiZWw4NDU1OTc1MjA=","url":"https://api.github.com/repos/apache/incubator-skywalking/labels/enhancement","name":"enhancement","color":"c5def5","default":true},{"id":915433204,"node_id":"MDU6TGFiZWw5MTU0MzMyMDQ=","url":"https://api.github.com/repos/apache/incubator-skywalking/labels/plugin","name":"plugin","color":"5a910d","default":false}],"milestone":{"url":"https://api.github.com/repos/apache/incubator-skywalking/milestones/30","html_url":"https://github.com/apache/incubator-skywalking/milestone/30","labels_url":"https://api.github.com/repos/apache/incubator-skywalking/milestones/30/labels","id":3690139,"node_id":"MDk6TWlsZXN0b25lMzY5MDEzOQ==","number":30,"title":"6.0.0-GA","description":"","creator":{"login":"wu-sheng","id":5441976,"node_id":"MDQ6VXNlcjU0NDE5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5441976?v=4","gravatar_id":"","url":"https://api.github.com/users/wu-sheng","html_url":"https://github.com/wu-sheng","followers_url":"https://api.github.com/users/wu-sheng/followers","following_url":"https://api.github.com/users/wu-sheng/following{/other_user}","gists_url":"https://api.github.com/users/wu-sheng/gists{/gist_id}","starred_url":"https://api.github.com/users/wu-sheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wu-sheng/subscriptions","organizations_url":"https://api.github.com/users/wu-sheng/orgs","repos_url":"https://api.github.com/users/wu-sheng/repos","events_url":"https://api.github.com/users/wu-sheng/events{/privacy}","received_events_url":"https://api.github.com/users/wu-sheng/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":63,"state":"open","created_at":"2018-09-26T12:43:44Z","updated_at":"2019-01-04T14:37:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/apache/incubator-skywalking/pulls/2083/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-skywalking/pulls/2083/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-skywalking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-skywalking/issues/2083/comments","statuses_url":"https://api.github.com/repos/apache/incubator-skywalking/statuses/2fb84c7c064e9fbf784f87d5cc7b4f12b64010e9","head":{"label":"zhaoyuguang:local_plugin_redisson","ref":"local_plugin_redisson","sha":"2fb84c7c064e9fbf784f87d5cc7b4f12b64010e9","user":{"login":"zhaoyuguang","id":10150229,"node_id":"MDQ6VXNlcjEwMTUwMjI5","avatar_url":"https://avatars1.githubusercontent.com/u/10150229?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaoyuguang","html_url":"https://github.com/zhaoyuguang","followers_url":"https://api.github.com/users/zhaoyuguang/followers","following_url":"https://api.github.com/users/zhaoyuguang/following{/other_user}","gists_url":"https://api.github.com/users/zhaoyuguang/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaoyuguang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaoyuguang/subscriptions","organizations_url":"https://api.github.com/users/zhaoyuguang/orgs","repos_url":"https://api.github.com/users/zhaoyuguang/repos","events_url":"https://api.github.com/users/zhaoyuguang/events{/privacy}","received_events_url":"https://api.github.com/users/zhaoyuguang/received_events","type":"User","site_admin":false},"repo":{"id":162831242,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI4MzEyNDI=","name":"incubator-skywalking","full_name":"zhaoyuguang/incubator-skywalking","private":false,"owner":{"login":"zhaoyuguang","id":10150229,"node_id":"MDQ6VXNlcjEwMTUwMjI5","avatar_url":"https://avatars1.githubusercontent.com/u/10150229?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaoyuguang","html_url":"https://github.com/zhaoyuguang","followers_url":"https://api.github.com/users/zhaoyuguang/followers","following_url":"https://api.github.com/users/zhaoyuguang/following{/other_user}","gists_url":"https://api.github.com/users/zhaoyuguang/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaoyuguang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaoyuguang/subscriptions","organizations_url":"https://api.github.com/users/zhaoyuguang/orgs","repos_url":"https://api.github.com/users/zhaoyuguang/repos","events_url":"https://api.github.com/users/zhaoyuguang/events{/privacy}","received_events_url":"https://api.github.com/users/zhaoyuguang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zhaoyuguang/incubator-skywalking","description":"A distributed tracing system, and APM ( Application Performance Monitoring )","fork":true,"url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking","forks_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/forks","keys_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/teams","hooks_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/hooks","issue_events_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/issues/events{/number}","events_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/events","assignees_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/assignees{/user}","branches_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/branches{/branch}","tags_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/tags","blobs_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/statuses/{sha}","languages_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/languages","stargazers_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/stargazers","contributors_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/contributors","subscribers_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/subscribers","subscription_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/subscription","commits_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/contents/{+path}","compare_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/merges","archive_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/downloads","issues_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/issues{/number}","pulls_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/pulls{/number}","milestones_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/milestones{/number}","notifications_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/labels{/name}","releases_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/releases{/id}","deployments_url":"https://api.github.com/repos/zhaoyuguang/incubator-skywalking/deployments","created_at":"2018-12-22T17:43:00Z","updated_at":"2018-12-22T17:43:07Z","pushed_at":"2019-01-04T15:42:52Z","git_url":"git://github.com/zhaoyuguang/incubator-skywalking.git","ssh_url":"git@github.com:zhaoyuguang/incubator-skywalking.git","clone_url":"https://github.com/zhaoyuguang/incubator-skywalking.git","svn_url":"https://github.com/zhaoyuguang/incubator-skywalking","homepage":"https://skywalking.incubator.apache.org/","size":142124,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ee6841fc13ffb246566283184e955381ae243644","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":45721011,"node_id":"MDEwOlJlcG9zaXRvcnk0NTcyMTAxMQ==","name":"incubator-skywalking","full_name":"apache/incubator-skywalking","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-skywalking","description":"A distributed tracing system, and APM ( Application Performance Monitoring )","fork":false,"url":"https://api.github.com/repos/apache/incubator-skywalking","forks_url":"https://api.github.com/repos/apache/incubator-skywalking/forks","keys_url":"https://api.github.com/repos/apache/incubator-skywalking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-skywalking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-skywalking/teams","hooks_url":"https://api.github.com/repos/apache/incubator-skywalking/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-skywalking/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-skywalking/events","assignees_url":"https://api.github.com/repos/apache/incubator-skywalking/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-skywalking/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-skywalking/tags","blobs_url":"https://api.github.com/repos/apache/incubator-skywalking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-skywalking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-skywalking/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-skywalking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-skywalking/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-skywalking/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-skywalking/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-skywalking/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-skywalking/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-skywalking/subscription","commits_url":"https://api.github.com/repos/apache/incubator-skywalking/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-skywalking/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-skywalking/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-skywalking/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-skywalking/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-skywalking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-skywalking/merges","archive_url":"https://api.github.com/repos/apache/incubator-skywalking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-skywalking/downloads","issues_url":"https://api.github.com/repos/apache/incubator-skywalking/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-skywalking/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-skywalking/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-skywalking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-skywalking/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-skywalking/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-skywalking/deployments","created_at":"2015-11-07T03:30:36Z","updated_at":"2019-01-04T12:56:43Z","pushed_at":"2019-01-04T15:42:56Z","git_url":"git://github.com/apache/incubator-skywalking.git","ssh_url":"git@github.com:apache/incubator-skywalking.git","clone_url":"https://github.com/apache/incubator-skywalking.git","svn_url":"https://github.com/apache/incubator-skywalking","homepage":"https://skywalking.incubator.apache.org/","size":142101,"stargazers_count":5472,"watchers_count":5472,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1721,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1721,"open_issues":95,"watchers":5472,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-skywalking/pulls/2083"},"html":{"href":"https://github.com/apache/incubator-skywalking/pull/2083"},"issue":{"href":"https://api.github.com/repos/apache/incubator-skywalking/issues/2083"},"comments":{"href":"https://api.github.com/repos/apache/incubator-skywalking/issues/2083/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-skywalking/pulls/2083/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-skywalking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-skywalking/pulls/2083/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-skywalking/statuses/2fb84c7c064e9fbf784f87d5cc7b4f12b64010e9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wu-sheng"}}