{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/KlugerLab/FIt-SNE/pulls/28","id":209481763,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NDgxNzYz","html_url":"https://github.com/KlugerLab/FIt-SNE/pull/28","diff_url":"https://github.com/KlugerLab/FIt-SNE/pull/28.diff","patch_url":"https://github.com/KlugerLab/FIt-SNE/pull/28.patch","issue_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/issues/28","number":28,"state":"closed","locked":false,"title":"Tidying up computeGaussianPerplexity; Python example notebook","user":{"login":"dkobak","id":8970231,"node_id":"MDQ6VXNlcjg5NzAyMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/8970231?v=4","gravatar_id":"","url":"https://api.github.com/users/dkobak","html_url":"https://github.com/dkobak","followers_url":"https://api.github.com/users/dkobak/followers","following_url":"https://api.github.com/users/dkobak/following{/other_user}","gists_url":"https://api.github.com/users/dkobak/gists{/gist_id}","starred_url":"https://api.github.com/users/dkobak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkobak/subscriptions","organizations_url":"https://api.github.com/users/dkobak/orgs","repos_url":"https://api.github.com/users/dkobak/repos","events_url":"https://api.github.com/users/dkobak/events{/privacy}","received_events_url":"https://api.github.com/users/dkobak/received_events","type":"User","site_admin":false},"body":"I was going to combe two versions of `computeGaussianPerplexity` (Annoy and VP) into one function, but then I realized it's not easy to do because Annoy and VP use different interfaces. So I left it as is. I still think it's suboptimal because the whole code that does parallel loops etc. is duplicated, but to do it nicely I'd need to create additional functions that would interface with Annoy/VP and I don't want to bother right now.\r\n\r\nSo here I only did some very minor tidying-up of both versions of `computeGaussianPerplexity` (some clean up remained to be done after I removed the loading/saving code to `run`).\r\n\r\nAlso, I removed the obsolete lines from `computeExactGradient` as discussed in #26.\r\n\r\nAlso, I added my Python notebook to `examples/`. It shows how to run FFT t-SNE on MNIST, and also does a lot of different checks (tests FFT vs Barnes-Hut, Annoy vs VP, default vs exact, etc.). See https://github.com/dkobak/FIt-SNE/blob/comp-gauss-perpl-refactor/examples/test.ipynb","created_at":"2018-08-20T10:48:38Z","updated_at":"2018-08-22T02:50:07Z","closed_at":"2018-08-22T02:50:07Z","merged_at":"2018-08-22T02:50:07Z","merge_commit_sha":"8d522b64d30f0af36c0c9b9c8453d31591fbc6ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/pulls/28/commits","review_comments_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/pulls/28/comments","review_comment_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/issues/28/comments","statuses_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/statuses/e7aeb8f968820c106f9821b2800b2de7ac559fb5","head":{"label":"dkobak:comp-gauss-perpl-refactor","ref":"comp-gauss-perpl-refactor","sha":"e7aeb8f968820c106f9821b2800b2de7ac559fb5","user":{"login":"dkobak","id":8970231,"node_id":"MDQ6VXNlcjg5NzAyMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/8970231?v=4","gravatar_id":"","url":"https://api.github.com/users/dkobak","html_url":"https://github.com/dkobak","followers_url":"https://api.github.com/users/dkobak/followers","following_url":"https://api.github.com/users/dkobak/following{/other_user}","gists_url":"https://api.github.com/users/dkobak/gists{/gist_id}","starred_url":"https://api.github.com/users/dkobak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkobak/subscriptions","organizations_url":"https://api.github.com/users/dkobak/orgs","repos_url":"https://api.github.com/users/dkobak/repos","events_url":"https://api.github.com/users/dkobak/events{/privacy}","received_events_url":"https://api.github.com/users/dkobak/received_events","type":"User","site_admin":false},"repo":{"id":136322821,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzMjI4MjE=","name":"FIt-SNE","full_name":"dkobak/FIt-SNE","owner":{"login":"dkobak","id":8970231,"node_id":"MDQ6VXNlcjg5NzAyMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/8970231?v=4","gravatar_id":"","url":"https://api.github.com/users/dkobak","html_url":"https://github.com/dkobak","followers_url":"https://api.github.com/users/dkobak/followers","following_url":"https://api.github.com/users/dkobak/following{/other_user}","gists_url":"https://api.github.com/users/dkobak/gists{/gist_id}","starred_url":"https://api.github.com/users/dkobak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkobak/subscriptions","organizations_url":"https://api.github.com/users/dkobak/orgs","repos_url":"https://api.github.com/users/dkobak/repos","events_url":"https://api.github.com/users/dkobak/events{/privacy}","received_events_url":"https://api.github.com/users/dkobak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkobak/FIt-SNE","description":"Fast Fourier Transform-accelerated Interpolation-based  t-SNE (FIt-SNE)","fork":true,"url":"https://api.github.com/repos/dkobak/FIt-SNE","forks_url":"https://api.github.com/repos/dkobak/FIt-SNE/forks","keys_url":"https://api.github.com/repos/dkobak/FIt-SNE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkobak/FIt-SNE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkobak/FIt-SNE/teams","hooks_url":"https://api.github.com/repos/dkobak/FIt-SNE/hooks","issue_events_url":"https://api.github.com/repos/dkobak/FIt-SNE/issues/events{/number}","events_url":"https://api.github.com/repos/dkobak/FIt-SNE/events","assignees_url":"https://api.github.com/repos/dkobak/FIt-SNE/assignees{/user}","branches_url":"https://api.github.com/repos/dkobak/FIt-SNE/branches{/branch}","tags_url":"https://api.github.com/repos/dkobak/FIt-SNE/tags","blobs_url":"https://api.github.com/repos/dkobak/FIt-SNE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkobak/FIt-SNE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkobak/FIt-SNE/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkobak/FIt-SNE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkobak/FIt-SNE/statuses/{sha}","languages_url":"https://api.github.com/repos/dkobak/FIt-SNE/languages","stargazers_url":"https://api.github.com/repos/dkobak/FIt-SNE/stargazers","contributors_url":"https://api.github.com/repos/dkobak/FIt-SNE/contributors","subscribers_url":"https://api.github.com/repos/dkobak/FIt-SNE/subscribers","subscription_url":"https://api.github.com/repos/dkobak/FIt-SNE/subscription","commits_url":"https://api.github.com/repos/dkobak/FIt-SNE/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkobak/FIt-SNE/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkobak/FIt-SNE/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkobak/FIt-SNE/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkobak/FIt-SNE/contents/{+path}","compare_url":"https://api.github.com/repos/dkobak/FIt-SNE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkobak/FIt-SNE/merges","archive_url":"https://api.github.com/repos/dkobak/FIt-SNE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkobak/FIt-SNE/downloads","issues_url":"https://api.github.com/repos/dkobak/FIt-SNE/issues{/number}","pulls_url":"https://api.github.com/repos/dkobak/FIt-SNE/pulls{/number}","milestones_url":"https://api.github.com/repos/dkobak/FIt-SNE/milestones{/number}","notifications_url":"https://api.github.com/repos/dkobak/FIt-SNE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkobak/FIt-SNE/labels{/name}","releases_url":"https://api.github.com/repos/dkobak/FIt-SNE/releases{/id}","deployments_url":"https://api.github.com/repos/dkobak/FIt-SNE/deployments","created_at":"2018-06-06T12:03:35Z","updated_at":"2018-08-20T08:21:47Z","pushed_at":"2018-08-21T12:24:28Z","git_url":"git://github.com/dkobak/FIt-SNE.git","ssh_url":"git@github.com:dkobak/FIt-SNE.git","clone_url":"https://github.com/dkobak/FIt-SNE.git","svn_url":"https://github.com/dkobak/FIt-SNE","homepage":"","size":16886,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KlugerLab:master","ref":"master","sha":"baed7c662cdbe8e1f5f25b1607570704183141ed","user":{"login":"KlugerLab","id":19477652,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc3NjUy","avatar_url":"https://avatars1.githubusercontent.com/u/19477652?v=4","gravatar_id":"","url":"https://api.github.com/users/KlugerLab","html_url":"https://github.com/KlugerLab","followers_url":"https://api.github.com/users/KlugerLab/followers","following_url":"https://api.github.com/users/KlugerLab/following{/other_user}","gists_url":"https://api.github.com/users/KlugerLab/gists{/gist_id}","starred_url":"https://api.github.com/users/KlugerLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KlugerLab/subscriptions","organizations_url":"https://api.github.com/users/KlugerLab/orgs","repos_url":"https://api.github.com/users/KlugerLab/repos","events_url":"https://api.github.com/users/KlugerLab/events{/privacy}","received_events_url":"https://api.github.com/users/KlugerLab/received_events","type":"Organization","site_admin":false},"repo":{"id":115304736,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUzMDQ3MzY=","name":"FIt-SNE","full_name":"KlugerLab/FIt-SNE","owner":{"login":"KlugerLab","id":19477652,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc3NjUy","avatar_url":"https://avatars1.githubusercontent.com/u/19477652?v=4","gravatar_id":"","url":"https://api.github.com/users/KlugerLab","html_url":"https://github.com/KlugerLab","followers_url":"https://api.github.com/users/KlugerLab/followers","following_url":"https://api.github.com/users/KlugerLab/following{/other_user}","gists_url":"https://api.github.com/users/KlugerLab/gists{/gist_id}","starred_url":"https://api.github.com/users/KlugerLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KlugerLab/subscriptions","organizations_url":"https://api.github.com/users/KlugerLab/orgs","repos_url":"https://api.github.com/users/KlugerLab/repos","events_url":"https://api.github.com/users/KlugerLab/events{/privacy}","received_events_url":"https://api.github.com/users/KlugerLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KlugerLab/FIt-SNE","description":"Fast Fourier Transform-accelerated Interpolation-based  t-SNE (FIt-SNE)","fork":false,"url":"https://api.github.com/repos/KlugerLab/FIt-SNE","forks_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/forks","keys_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/teams","hooks_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/hooks","issue_events_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/issues/events{/number}","events_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/events","assignees_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/assignees{/user}","branches_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/branches{/branch}","tags_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/tags","blobs_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/git/refs{/sha}","trees_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/statuses/{sha}","languages_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/languages","stargazers_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/stargazers","contributors_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/contributors","subscribers_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/subscribers","subscription_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/subscription","commits_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/commits{/sha}","git_commits_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/git/commits{/sha}","comments_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/comments{/number}","issue_comment_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/issues/comments{/number}","contents_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/contents/{+path}","compare_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/merges","archive_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/downloads","issues_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/issues{/number}","pulls_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/pulls{/number}","milestones_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/milestones{/number}","notifications_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/labels{/name}","releases_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/releases{/id}","deployments_url":"https://api.github.com/repos/KlugerLab/FIt-SNE/deployments","created_at":"2017-12-25T03:48:38Z","updated_at":"2018-08-22T02:03:21Z","pushed_at":"2018-08-22T02:50:07Z","git_url":"git://github.com/KlugerLab/FIt-SNE.git","ssh_url":"git@github.com:KlugerLab/FIt-SNE.git","clone_url":"https://github.com/KlugerLab/FIt-SNE.git","svn_url":"https://github.com/KlugerLab/FIt-SNE","homepage":"","size":15422,"stargazers_count":160,"watchers_count":160,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":26,"open_issues":5,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KlugerLab/FIt-SNE/pulls/28"},"html":{"href":"https://github.com/KlugerLab/FIt-SNE/pull/28"},"issue":{"href":"https://api.github.com/repos/KlugerLab/FIt-SNE/issues/28"},"comments":{"href":"https://api.github.com/repos/KlugerLab/FIt-SNE/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/KlugerLab/FIt-SNE/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/KlugerLab/FIt-SNE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KlugerLab/FIt-SNE/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/KlugerLab/FIt-SNE/statuses/e7aeb8f968820c106f9821b2800b2de7ac559fb5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"linqiaozhi","id":19375944,"node_id":"MDQ6VXNlcjE5Mzc1OTQ0","avatar_url":"https://avatars1.githubusercontent.com/u/19375944?v=4","gravatar_id":"","url":"https://api.github.com/users/linqiaozhi","html_url":"https://github.com/linqiaozhi","followers_url":"https://api.github.com/users/linqiaozhi/followers","following_url":"https://api.github.com/users/linqiaozhi/following{/other_user}","gists_url":"https://api.github.com/users/linqiaozhi/gists{/gist_id}","starred_url":"https://api.github.com/users/linqiaozhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linqiaozhi/subscriptions","organizations_url":"https://api.github.com/users/linqiaozhi/orgs","repos_url":"https://api.github.com/users/linqiaozhi/repos","events_url":"https://api.github.com/users/linqiaozhi/events{/privacy}","received_events_url":"https://api.github.com/users/linqiaozhi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":6716,"deletions":116,"changed_files":2}}
{"actor":{"display_login":"linqiaozhi"}}