{"action":"opened","number":1338,"pull_request":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1338","id":226101416,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTAxNDE2","html_url":"https://github.com/boutproject/BOUT-dev/pull/1338","diff_url":"https://github.com/boutproject/BOUT-dev/pull/1338.diff","patch_url":"https://github.com/boutproject/BOUT-dev/pull/1338.patch","issue_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1338","number":1338,"state":"open","locked":false,"title":"Boutexception backtrace tidy","user":{"login":"ZedThree","id":1486942,"node_id":"MDQ6VXNlcjE0ODY5NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1486942?v=4","gravatar_id":"","url":"https://api.github.com/users/ZedThree","html_url":"https://github.com/ZedThree","followers_url":"https://api.github.com/users/ZedThree/followers","following_url":"https://api.github.com/users/ZedThree/following{/other_user}","gists_url":"https://api.github.com/users/ZedThree/gists{/gist_id}","starred_url":"https://api.github.com/users/ZedThree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZedThree/subscriptions","organizations_url":"https://api.github.com/users/ZedThree/orgs","repos_url":"https://api.github.com/users/ZedThree/repos","events_url":"https://api.github.com/users/ZedThree/events{/privacy}","received_events_url":"https://api.github.com/users/ZedThree/received_events","type":"User","site_admin":false},"body":"A couple of changes to `BoutException`:\r\n\r\n- Mixing the backtrace and the message causes problems with tests. Backtrace functionality is still present, but moved into `BoutException::getBacktrace`. `BOUTMAIN` now calls that instead of `what()` so that physics models still print a backtrace if it is available.\r\n\r\n- Clear the MsgStack in BoutException destructor: If an exception is thrown while a TRACE is active, we won't clear up the msg_stack. We also won't know how many messages to pop, so just clear everything. This should make the unit tests less confusing if something goes wrong\r\n\r\nAlso improves the error message in `SolverFactory::createSolver` which needs the first change.\r\n","created_at":"2018-10-26T13:38:17Z","updated_at":"2018-10-26T13:38:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones/10","html_url":"https://github.com/boutproject/BOUT-dev/milestone/10","labels_url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones/10/labels","id":3677478,"node_id":"MDk6TWlsZXN0b25lMzY3NzQ3OA==","number":10,"title":"BOUT-4.3","description":null,"creator":{"login":"ZedThree","id":1486942,"node_id":"MDQ6VXNlcjE0ODY5NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1486942?v=4","gravatar_id":"","url":"https://api.github.com/users/ZedThree","html_url":"https://github.com/ZedThree","followers_url":"https://api.github.com/users/ZedThree/followers","following_url":"https://api.github.com/users/ZedThree/following{/other_user}","gists_url":"https://api.github.com/users/ZedThree/gists{/gist_id}","starred_url":"https://api.github.com/users/ZedThree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZedThree/subscriptions","organizations_url":"https://api.github.com/users/ZedThree/orgs","repos_url":"https://api.github.com/users/ZedThree/repos","events_url":"https://api.github.com/users/ZedThree/events{/privacy}","received_events_url":"https://api.github.com/users/ZedThree/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":1,"state":"open","created_at":"2018-09-21T10:46:56Z","updated_at":"2018-10-26T13:38:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1338/commits","review_comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1338/comments","review_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1338/comments","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/2c26d398fb8ee4140c983ea8d712b112a8da68c2","head":{"label":"boutproject:boutexception-backtrace-tidy","ref":"boutexception-backtrace-tidy","sha":"2c26d398fb8ee4140c983ea8d712b112a8da68c2","user":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"repo":{"id":12783634,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4MzYzNA==","name":"BOUT-dev","full_name":"boutproject/BOUT-dev","private":false,"owner":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/boutproject/BOUT-dev","description":"BOUT++: Plasma fluid finite-difference simulation code in curvilinear coordinate systems","fork":false,"url":"https://api.github.com/repos/boutproject/BOUT-dev","forks_url":"https://api.github.com/repos/boutproject/BOUT-dev/forks","keys_url":"https://api.github.com/repos/boutproject/BOUT-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boutproject/BOUT-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boutproject/BOUT-dev/teams","hooks_url":"https://api.github.com/repos/boutproject/BOUT-dev/hooks","issue_events_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/events{/number}","events_url":"https://api.github.com/repos/boutproject/BOUT-dev/events","assignees_url":"https://api.github.com/repos/boutproject/BOUT-dev/assignees{/user}","branches_url":"https://api.github.com/repos/boutproject/BOUT-dev/branches{/branch}","tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/tags","blobs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/boutproject/BOUT-dev/languages","stargazers_url":"https://api.github.com/repos/boutproject/BOUT-dev/stargazers","contributors_url":"https://api.github.com/repos/boutproject/BOUT-dev/contributors","subscribers_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscribers","subscription_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscription","commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/boutproject/BOUT-dev/contents/{+path}","compare_url":"https://api.github.com/repos/boutproject/BOUT-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boutproject/BOUT-dev/merges","archive_url":"https://api.github.com/repos/boutproject/BOUT-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boutproject/BOUT-dev/downloads","issues_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues{/number}","pulls_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/boutproject/BOUT-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boutproject/BOUT-dev/labels{/name}","releases_url":"https://api.github.com/repos/boutproject/BOUT-dev/releases{/id}","deployments_url":"https://api.github.com/repos/boutproject/BOUT-dev/deployments","created_at":"2013-09-12T12:57:55Z","updated_at":"2018-10-17T08:09:23Z","pushed_at":"2018-10-26T13:34:37Z","git_url":"git://github.com/boutproject/BOUT-dev.git","ssh_url":"git@github.com:boutproject/BOUT-dev.git","clone_url":"https://github.com/boutproject/BOUT-dev.git","svn_url":"https://github.com/boutproject/BOUT-dev","homepage":"http://boutproject.github.io/","size":43437,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":163,"watchers":28,"default_branch":"master"}},"base":{"label":"boutproject:next","ref":"next","sha":"490f44a5cf1a6f7369b4dbe748d1055e9651e680","user":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"repo":{"id":12783634,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4MzYzNA==","name":"BOUT-dev","full_name":"boutproject/BOUT-dev","private":false,"owner":{"login":"boutproject","id":5280238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODAyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5280238?v=4","gravatar_id":"","url":"https://api.github.com/users/boutproject","html_url":"https://github.com/boutproject","followers_url":"https://api.github.com/users/boutproject/followers","following_url":"https://api.github.com/users/boutproject/following{/other_user}","gists_url":"https://api.github.com/users/boutproject/gists{/gist_id}","starred_url":"https://api.github.com/users/boutproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boutproject/subscriptions","organizations_url":"https://api.github.com/users/boutproject/orgs","repos_url":"https://api.github.com/users/boutproject/repos","events_url":"https://api.github.com/users/boutproject/events{/privacy}","received_events_url":"https://api.github.com/users/boutproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/boutproject/BOUT-dev","description":"BOUT++: Plasma fluid finite-difference simulation code in curvilinear coordinate systems","fork":false,"url":"https://api.github.com/repos/boutproject/BOUT-dev","forks_url":"https://api.github.com/repos/boutproject/BOUT-dev/forks","keys_url":"https://api.github.com/repos/boutproject/BOUT-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boutproject/BOUT-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boutproject/BOUT-dev/teams","hooks_url":"https://api.github.com/repos/boutproject/BOUT-dev/hooks","issue_events_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/events{/number}","events_url":"https://api.github.com/repos/boutproject/BOUT-dev/events","assignees_url":"https://api.github.com/repos/boutproject/BOUT-dev/assignees{/user}","branches_url":"https://api.github.com/repos/boutproject/BOUT-dev/branches{/branch}","tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/tags","blobs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/boutproject/BOUT-dev/languages","stargazers_url":"https://api.github.com/repos/boutproject/BOUT-dev/stargazers","contributors_url":"https://api.github.com/repos/boutproject/BOUT-dev/contributors","subscribers_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscribers","subscription_url":"https://api.github.com/repos/boutproject/BOUT-dev/subscription","commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/boutproject/BOUT-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/boutproject/BOUT-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/boutproject/BOUT-dev/contents/{+path}","compare_url":"https://api.github.com/repos/boutproject/BOUT-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boutproject/BOUT-dev/merges","archive_url":"https://api.github.com/repos/boutproject/BOUT-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boutproject/BOUT-dev/downloads","issues_url":"https://api.github.com/repos/boutproject/BOUT-dev/issues{/number}","pulls_url":"https://api.github.com/repos/boutproject/BOUT-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/boutproject/BOUT-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/boutproject/BOUT-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boutproject/BOUT-dev/labels{/name}","releases_url":"https://api.github.com/repos/boutproject/BOUT-dev/releases{/id}","deployments_url":"https://api.github.com/repos/boutproject/BOUT-dev/deployments","created_at":"2013-09-12T12:57:55Z","updated_at":"2018-10-17T08:09:23Z","pushed_at":"2018-10-26T13:34:37Z","git_url":"git://github.com/boutproject/BOUT-dev.git","ssh_url":"git@github.com:boutproject/BOUT-dev.git","clone_url":"https://github.com/boutproject/BOUT-dev.git","svn_url":"https://github.com/boutproject/BOUT-dev","homepage":"http://boutproject.github.io/","size":43437,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":163,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1338"},"html":{"href":"https://github.com/boutproject/BOUT-dev/pull/1338"},"issue":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1338"},"comments":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/issues/1338/comments"},"review_comments":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1338/comments"},"review_comment":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/pulls/1338/commits"},"statuses":{"href":"https://api.github.com/repos/boutproject/BOUT-dev/statuses/2c26d398fb8ee4140c983ea8d712b112a8da68c2"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":66,"deletions":67,"changed_files":6}}
{"actor":{"display_login":"ZedThree"}}