{"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-server/pulls/comments/238354009","pull_request_review_id":180874667,"id":238354009,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODM1NDAwOQ==","diff_hunk":"@@ -363,33 +704,81 @@ System Variables\n \n .. variable:: keyring_vault_config\n \n-  :version 5.7.20-18: Implemented\n-  :cli: ``--keyring-vault-config``\n-  :dyn: Yes\n-  :scope: Global\n-  :vartype: Text\n-  :default:\n+   :version 5.7.20-18: Implemented\n+   :cli: ``--keyring-vault-config``\n+   :dyn: Yes\n+   :scope: Global\n+   :vartype: Text\n+   :default:\n \n This variable is used to define the location of the\n :ref:`keyring_vault_plugin` configuration file.\n \n .. variable:: keyring_vault_timeout\n \n-  :version 5.7.21-20: Implemented\n-  :cli: ``--keyring-vault-timeout``\n-  :dyn: Yes\n-  :scope: Global\n-  :vartype: Numeric\n-  :default: ``15``\n+   :version 5.7.21-20: Implemented\n+   :cli: ``--keyring-vault-timeout``\n+   :dyn: Yes\n+   :scope: Global\n+   :vartype: Numeric\n+   :default: ``15``\n \n This variable allows to set the duration in seconds for the Vault server\n connection timeout. Default value is ``15``. Allowed range is from ``1``\n second to ``86400`` seconds (24 hours). The timeout can be also completely\n disabled to wait infinite amount of time by setting this variable to ``0``.\n \n-Other reading\n--------------\n+.. _data-at-rest-encryption.data-scrubbing:\n+\n+Data Scrubbing\n+================================================================================\n+\n+While data encryption ensures that the existing data are not stored in plain\n+form, the data scrubbing literally removes the data once the user decides they\n+should be deleted. Compare this behavior with how the ``DELETE`` statement works\n+which only marks the affected data as deletable - the space claimed by this data","path":"doc/source/management/data_at_rest_encryption.rst","position":null,"original_position":732,"commit_id":"d5a600ef6bf3f363417739d4163088505bac5274","original_commit_id":"ed54d6aaaf9d1a0978431d60f57bb4dbf6f04652","user":{"login":"borys-belinsky","id":29381396,"node_id":"MDQ6VXNlcjI5MzgxMzk2","avatar_url":"https://avatars2.githubusercontent.com/u/29381396?v=4","gravatar_id":"","url":"https://api.github.com/users/borys-belinsky","html_url":"https://github.com/borys-belinsky","followers_url":"https://api.github.com/users/borys-belinsky/followers","following_url":"https://api.github.com/users/borys-belinsky/following{/other_user}","gists_url":"https://api.github.com/users/borys-belinsky/gists{/gist_id}","starred_url":"https://api.github.com/users/borys-belinsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borys-belinsky/subscriptions","organizations_url":"https://api.github.com/users/borys-belinsky/orgs","repos_url":"https://api.github.com/users/borys-belinsky/repos","events_url":"https://api.github.com/users/borys-belinsky/events{/privacy}","received_events_url":"https://api.github.com/users/borys-belinsky/received_events","type":"User","site_admin":false},"body":"Text updated as suggested","created_at":"2018-12-03T17:02:40Z","updated_at":"2018-12-03T17:02:41Z","html_url":"https://github.com/percona/percona-server/pull/2675#discussion_r238354009","pull_request_url":"https://api.github.com/repos/percona/percona-server/pulls/2675","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments/238354009"},"html":{"href":"https://github.com/percona/percona-server/pull/2675#discussion_r238354009"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2675"}},"in_reply_to_id":238339609},"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/2675","id":229774776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5Nzc0Nzc2","html_url":"https://github.com/percona/percona-server/pull/2675","diff_url":"https://github.com/percona/percona-server/pull/2675.diff","patch_url":"https://github.com/percona/percona-server/pull/2675.patch","issue_url":"https://api.github.com/repos/percona/percona-server/issues/2675","number":2675,"state":"open","locked":false,"title":"Release notes for PS 5.7.23-24","user":{"login":"borys-belinsky","id":29381396,"node_id":"MDQ6VXNlcjI5MzgxMzk2","avatar_url":"https://avatars2.githubusercontent.com/u/29381396?v=4","gravatar_id":"","url":"https://api.github.com/users/borys-belinsky","html_url":"https://github.com/borys-belinsky","followers_url":"https://api.github.com/users/borys-belinsky/followers","following_url":"https://api.github.com/users/borys-belinsky/following{/other_user}","gists_url":"https://api.github.com/users/borys-belinsky/gists{/gist_id}","starred_url":"https://api.github.com/users/borys-belinsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borys-belinsky/subscriptions","organizations_url":"https://api.github.com/users/borys-belinsky/orgs","repos_url":"https://api.github.com/users/borys-belinsky/repos","events_url":"https://api.github.com/users/borys-belinsky/events{/privacy}","received_events_url":"https://api.github.com/users/borys-belinsky/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-09T18:06:13Z","updated_at":"2018-12-03T17:02:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0ab44fe61455657fb8d1ad3e581d2889909a2d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-server/pulls/2675/commits","review_comments_url":"https://api.github.com/repos/percona/percona-server/pulls/2675/comments","review_comment_url":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/2675/comments","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/d5a600ef6bf3f363417739d4163088505bac5274","head":{"label":"borys-belinsky:rn-5.7.23-24-5.7","ref":"rn-5.7.23-24-5.7","sha":"d5a600ef6bf3f363417739d4163088505bac5274","user":{"login":"borys-belinsky","id":29381396,"node_id":"MDQ6VXNlcjI5MzgxMzk2","avatar_url":"https://avatars2.githubusercontent.com/u/29381396?v=4","gravatar_id":"","url":"https://api.github.com/users/borys-belinsky","html_url":"https://github.com/borys-belinsky","followers_url":"https://api.github.com/users/borys-belinsky/followers","following_url":"https://api.github.com/users/borys-belinsky/following{/other_user}","gists_url":"https://api.github.com/users/borys-belinsky/gists{/gist_id}","starred_url":"https://api.github.com/users/borys-belinsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borys-belinsky/subscriptions","organizations_url":"https://api.github.com/users/borys-belinsky/orgs","repos_url":"https://api.github.com/users/borys-belinsky/repos","events_url":"https://api.github.com/users/borys-belinsky/events{/privacy}","received_events_url":"https://api.github.com/users/borys-belinsky/received_events","type":"User","site_admin":false},"repo":{"id":94124487,"node_id":"MDEwOlJlcG9zaXRvcnk5NDEyNDQ4Nw==","name":"percona-server","full_name":"borys-belinsky/percona-server","private":false,"owner":{"login":"borys-belinsky","id":29381396,"node_id":"MDQ6VXNlcjI5MzgxMzk2","avatar_url":"https://avatars2.githubusercontent.com/u/29381396?v=4","gravatar_id":"","url":"https://api.github.com/users/borys-belinsky","html_url":"https://github.com/borys-belinsky","followers_url":"https://api.github.com/users/borys-belinsky/followers","following_url":"https://api.github.com/users/borys-belinsky/following{/other_user}","gists_url":"https://api.github.com/users/borys-belinsky/gists{/gist_id}","starred_url":"https://api.github.com/users/borys-belinsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borys-belinsky/subscriptions","organizations_url":"https://api.github.com/users/borys-belinsky/orgs","repos_url":"https://api.github.com/users/borys-belinsky/repos","events_url":"https://api.github.com/users/borys-belinsky/events{/privacy}","received_events_url":"https://api.github.com/users/borys-belinsky/received_events","type":"User","site_admin":false},"html_url":"https://github.com/borys-belinsky/percona-server","description":"Percona Server","fork":true,"url":"https://api.github.com/repos/borys-belinsky/percona-server","forks_url":"https://api.github.com/repos/borys-belinsky/percona-server/forks","keys_url":"https://api.github.com/repos/borys-belinsky/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borys-belinsky/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borys-belinsky/percona-server/teams","hooks_url":"https://api.github.com/repos/borys-belinsky/percona-server/hooks","issue_events_url":"https://api.github.com/repos/borys-belinsky/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/borys-belinsky/percona-server/events","assignees_url":"https://api.github.com/repos/borys-belinsky/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/borys-belinsky/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/borys-belinsky/percona-server/tags","blobs_url":"https://api.github.com/repos/borys-belinsky/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borys-belinsky/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borys-belinsky/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/borys-belinsky/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borys-belinsky/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/borys-belinsky/percona-server/languages","stargazers_url":"https://api.github.com/repos/borys-belinsky/percona-server/stargazers","contributors_url":"https://api.github.com/repos/borys-belinsky/percona-server/contributors","subscribers_url":"https://api.github.com/repos/borys-belinsky/percona-server/subscribers","subscription_url":"https://api.github.com/repos/borys-belinsky/percona-server/subscription","commits_url":"https://api.github.com/repos/borys-belinsky/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/borys-belinsky/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/borys-belinsky/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/borys-belinsky/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/borys-belinsky/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/borys-belinsky/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borys-belinsky/percona-server/merges","archive_url":"https://api.github.com/repos/borys-belinsky/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borys-belinsky/percona-server/downloads","issues_url":"https://api.github.com/repos/borys-belinsky/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/borys-belinsky/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/borys-belinsky/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/borys-belinsky/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borys-belinsky/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/borys-belinsky/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/borys-belinsky/percona-server/deployments","created_at":"2017-06-12T17:50:20Z","updated_at":"2018-11-28T08:08:36Z","pushed_at":"2018-12-03T17:01:03Z","git_url":"git://github.com/borys-belinsky/percona-server.git","ssh_url":"git@github.com:borys-belinsky/percona-server.git","clone_url":"https://github.com/borys-belinsky/percona-server.git","svn_url":"https://github.com/borys-belinsky/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":1971148,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.7"}},"base":{"label":"percona:5.7","ref":"5.7","sha":"fbca17ff20f3a8696eafc45ebe84f57e7013243b","user":{"login":"percona","id":1683025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODMwMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753733,"node_id":"MDEwOlJlcG9zaXRvcnkzMDc1MzczMw==","name":"percona-server","full_name":"percona/percona-server","private":false,"owner":{"login":"percona","id":1683025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODMwMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/percona/percona-server","description":"Percona Server","fork":false,"url":"https://api.github.com/repos/percona/percona-server","forks_url":"https://api.github.com/repos/percona/percona-server/forks","keys_url":"https://api.github.com/repos/percona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-server/teams","hooks_url":"https://api.github.com/repos/percona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-server/events","assignees_url":"https://api.github.com/repos/percona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-server/tags","blobs_url":"https://api.github.com/repos/percona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-server/languages","stargazers_url":"https://api.github.com/repos/percona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-server/subscription","commits_url":"https://api.github.com/repos/percona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-server/merges","archive_url":"https://api.github.com/repos/percona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-server/downloads","issues_url":"https://api.github.com/repos/percona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-server/deployments","created_at":"2015-02-13T11:32:01Z","updated_at":"2018-12-01T06:13:36Z","pushed_at":"2018-12-03T17:01:06Z","git_url":"git://github.com/percona/percona-server.git","ssh_url":"git@github.com:percona/percona-server.git","clone_url":"https://github.com/percona/percona-server.git","svn_url":"https://github.com/percona/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":1976366,"stargazers_count":495,"watchers_count":495,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":204,"open_issues":44,"watchers":495,"default_branch":"5.7"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2675"},"html":{"href":"https://github.com/percona/percona-server/pull/2675"},"issue":{"href":"https://api.github.com/repos/percona/percona-server/issues/2675"},"comments":{"href":"https://api.github.com/repos/percona/percona-server/issues/2675/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2675/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2675/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-server/statuses/d5a600ef6bf3f363417739d4163088505bac5274"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"borys-belinsky"}}