{"action":"opened","number":12976,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12976","id":181466450,"html_url":"https://github.com/bitcoin/bitcoin/pull/12976","diff_url":"https://github.com/bitcoin/bitcoin/pull/12976.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/12976.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12976","number":12976,"state":"open","locked":false,"title":"Remove return and corruptionPossible arguments from DoS, rename to Reject","user":{"login":"Empact","id":5470,"avatar_url":"https://avatars2.githubusercontent.com/u/5470?v=4","gravatar_id":"","url":"https://api.github.com/users/Empact","html_url":"https://github.com/Empact","followers_url":"https://api.github.com/users/Empact/followers","following_url":"https://api.github.com/users/Empact/following{/other_user}","gists_url":"https://api.github.com/users/Empact/gists{/gist_id}","starred_url":"https://api.github.com/users/Empact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Empact/subscriptions","organizations_url":"https://api.github.com/users/Empact/orgs","repos_url":"https://api.github.com/users/Empact/repos","events_url":"https://api.github.com/users/Empact/events{/privacy}","received_events_url":"https://api.github.com/users/Empact/received_events","type":"User","site_admin":false},"body":"This is a reformulation of #12463 which aims to be more boring and easier to review.\r\nA significant part of the change is now a scripted-diff and the other bits work up to that.\r\n\r\nThe end result is removing Invalid, and removing 2 args from DoS.\r\nRenaming DoS to Reject is a protective measure against undetected merge conflicts, given the call flexibility of DoS.\r\n\r\n\r\n\r\n","created_at":"2018-04-13T11:55:56Z","updated_at":"2018-04-13T11:55:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12976/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12976/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12976/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/a3c9be35253f94909b83466cb7daa4b84c8761c4","head":{"label":"Empact:drop-dos-return-scripted","ref":"drop-dos-return-scripted","sha":"a3c9be35253f94909b83466cb7daa4b84c8761c4","user":{"login":"Empact","id":5470,"avatar_url":"https://avatars2.githubusercontent.com/u/5470?v=4","gravatar_id":"","url":"https://api.github.com/users/Empact","html_url":"https://github.com/Empact","followers_url":"https://api.github.com/users/Empact/followers","following_url":"https://api.github.com/users/Empact/following{/other_user}","gists_url":"https://api.github.com/users/Empact/gists{/gist_id}","starred_url":"https://api.github.com/users/Empact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Empact/subscriptions","organizations_url":"https://api.github.com/users/Empact/orgs","repos_url":"https://api.github.com/users/Empact/repos","events_url":"https://api.github.com/users/Empact/events{/privacy}","received_events_url":"https://api.github.com/users/Empact/received_events","type":"User","site_admin":false},"repo":{"id":119740507,"name":"bitcoin","full_name":"Empact/bitcoin","owner":{"login":"Empact","id":5470,"avatar_url":"https://avatars2.githubusercontent.com/u/5470?v=4","gravatar_id":"","url":"https://api.github.com/users/Empact","html_url":"https://github.com/Empact","followers_url":"https://api.github.com/users/Empact/followers","following_url":"https://api.github.com/users/Empact/following{/other_user}","gists_url":"https://api.github.com/users/Empact/gists{/gist_id}","starred_url":"https://api.github.com/users/Empact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Empact/subscriptions","organizations_url":"https://api.github.com/users/Empact/orgs","repos_url":"https://api.github.com/users/Empact/repos","events_url":"https://api.github.com/users/Empact/events{/privacy}","received_events_url":"https://api.github.com/users/Empact/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Empact/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/Empact/bitcoin","forks_url":"https://api.github.com/repos/Empact/bitcoin/forks","keys_url":"https://api.github.com/repos/Empact/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Empact/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Empact/bitcoin/teams","hooks_url":"https://api.github.com/repos/Empact/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/Empact/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/Empact/bitcoin/events","assignees_url":"https://api.github.com/repos/Empact/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/Empact/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/Empact/bitcoin/tags","blobs_url":"https://api.github.com/repos/Empact/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Empact/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Empact/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Empact/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Empact/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/Empact/bitcoin/languages","stargazers_url":"https://api.github.com/repos/Empact/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/Empact/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/Empact/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/Empact/bitcoin/subscription","commits_url":"https://api.github.com/repos/Empact/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Empact/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Empact/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Empact/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Empact/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/Empact/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Empact/bitcoin/merges","archive_url":"https://api.github.com/repos/Empact/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Empact/bitcoin/downloads","issues_url":"https://api.github.com/repos/Empact/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/Empact/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/Empact/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/Empact/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Empact/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/Empact/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/Empact/bitcoin/deployments","created_at":"2018-01-31T20:38:22Z","updated_at":"2018-01-31T20:38:39Z","pushed_at":"2018-04-13T11:54:47Z","git_url":"git://github.com/Empact/bitcoin.git","ssh_url":"git@github.com:Empact/bitcoin.git","clone_url":"https://github.com/Empact/bitcoin.git","svn_url":"https://github.com/Empact/bitcoin","homepage":"https://bitcoin.org/en/download","size":103972,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"5df84de583c900e00fef63bedaef32786f205a33","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-04-13T11:47:43Z","pushed_at":"2018-04-13T09:47:03Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":104316,"stargazers_count":30531,"watchers_count":30531,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":18309,"mirror_url":null,"archived":false,"open_issues_count":772,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":18309,"open_issues":772,"watchers":30531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12976"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/12976"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/12976"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/12976/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12976/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12976/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/a3c9be35253f94909b83466cb7daa4b84c8761c4"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":119,"deletions":113,"changed_files":3}}
{"actor":{"display_login":"Empact"}}