{"action":"opened","issue":{"url":"https://api.github.com/repos/pypa/pipenv/issues/2725","repository_url":"https://api.github.com/repos/pypa/pipenv","labels_url":"https://api.github.com/repos/pypa/pipenv/issues/2725/labels{/name}","comments_url":"https://api.github.com/repos/pypa/pipenv/issues/2725/comments","events_url":"https://api.github.com/repos/pypa/pipenv/issues/2725/events","html_url":"https://github.com/pypa/pipenv/issues/2725","id":349289484,"node_id":"MDU6SXNzdWUzNDkyODk0ODQ=","number":2725,"title":"Extras not locked for editable git packages","user":{"login":"bryanforbes","id":204106,"node_id":"MDQ6VXNlcjIwNDEwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/204106?v=4","gravatar_id":"","url":"https://api.github.com/users/bryanforbes","html_url":"https://github.com/bryanforbes","followers_url":"https://api.github.com/users/bryanforbes/followers","following_url":"https://api.github.com/users/bryanforbes/following{/other_user}","gists_url":"https://api.github.com/users/bryanforbes/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanforbes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanforbes/subscriptions","organizations_url":"https://api.github.com/users/bryanforbes/orgs","repos_url":"https://api.github.com/users/bryanforbes/repos","events_url":"https://api.github.com/users/bryanforbes/events{/privacy}","received_events_url":"https://api.github.com/users/bryanforbes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-09T21:02:08Z","updated_at":"2018-08-09T21:02:08Z","closed_at":null,"author_association":"NONE","body":"##### Issue description\r\n\r\nWhen adding editable git packages with `extras` to a `Pipfile`, the dependencies specified by the package's `extras_require` are not added to `Pipfile.lock`. Extras are added for packages coming from pypi and from the file system.\r\n\r\n##### Expected result\r\n\r\nDependencies from `extras_require` and sub-dependencies are added to `Pipfile.lock`\r\n\r\n##### Actual result\r\n\r\nDependencies from `extras_require` and sub-dependencies are not added to `Pipfile.lock`\r\n\r\n##### Steps to replicate\r\n\r\n1. `mkdir test-pipenv`\r\n2. `cd test-pipenv`\r\n3. `pipenv --python 3`\r\n```\r\nCreating a virtualenv for this project…\r\nPipfile: /Users/bryan/Projects/test-pipenv/Pipfile\r\nUsing /usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/bin/python3.7 (3.7.0) to create virtualenv…\r\n⠏Running virtualenv with interpreter /usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/bin/python3.7\r\nUsing base prefix '/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7'\r\n/usr/local/lib/python3.7/site-packages/virtualenv.py:1041: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses\r\n  import imp\r\nNew python executable in /Users/bryan/.local/share/virtualenvs/test-pipenv-pMYUstlA/bin/python3.7\r\nAlso creating executable in /Users/bryan/.local/share/virtualenvs/test-pipenv-pMYUstlA/bin/python\r\nInstalling setuptools, pip, wheel...done.\r\n\r\nVirtualenv location: /Users/bryan/.local/share/virtualenvs/test-pipenv-pMYUstlA\r\nCreating a Pipfile for this project…\r\n```\r\n4. `pipenv install -e git+https://github.com/requests/requests#egg=requests[security]`\r\n```\r\nInstalling -e git+https://github.com/requests/requests#egg=requests[security]…\r\nObtaining requests[security] from git+https://github.com/requests/requests#egg=requests[security]\r\n  Cloning https://github.com/requests/requests to /Users/bryan/.local/share/virtualenvs/test-pipenv-pMYUstlA/src/requests\r\nCollecting chardet<3.1.0,>=3.0.2 (from requests[security])\r\n  Using cached https://files.pythonhosted.org/packages/bc/a9/01ffebfb562e4274b6487b4bb1ddec7ca55ec7510b22e4c51f14098443b8/chardet-3.0.4-py2.py3-none-any.whl\r\nCollecting idna<2.8,>=2.5 (from requests[security])\r\n  Using cached https://files.pythonhosted.org/packages/4b/2a/0276479a4b3caeb8a8c1af2f8e4355746a97fab05a372e4a2c6a6b876165/idna-2.7-py2.py3-none-any.whl\r\nCollecting urllib3<1.24,>=1.21.1 (from requests[security])\r\n  Using cached https://files.pythonhosted.org/packages/bd/c9/6fdd990019071a4a32a5e7cb78a1d92c53851ef4f56f62a3486e6a7d8ffb/urllib3-1.23-py2.py3-none-any.whl\r\nCollecting certifi>=2017.4.17 (from requests[security])\r\n  Using cached https://files.pythonhosted.org/packages/7c/e6/92ad559b7192d846975fc916b65f667c7b8c3a32bea7372340bfe9a15fa5/certifi-2018.4.16-py2.py3-none-any.whl\r\nCollecting pyOpenSSL>=0.14 (from requests[security])\r\n  Using cached https://files.pythonhosted.org/packages/96/af/9d29e6bd40823061aea2e0574ccb2fcf72bfd6130ce53d32773ec375458c/pyOpenSSL-18.0.0-py2.py3-none-any.whl\r\nCollecting cryptography>=1.3.4 (from requests[security])\r\n  Using cached https://files.pythonhosted.org/packages/96/ba/15fa57d62f2c3eb907b50e7dd701181a47e3dce3fe365658f43ba677dd30/cryptography-2.3-cp34-abi3-macosx_10_6_intel.whl\r\nCollecting six>=1.5.2 (from pyOpenSSL>=0.14->requests[security])\r\n  Using cached https://files.pythonhosted.org/packages/67/4b/141a581104b1f6397bfa78ac9d43d8ad29a7ca43ea90a2d863fe3056e86a/six-1.11.0-py2.py3-none-any.whl\r\nCollecting asn1crypto>=0.21.0 (from cryptography>=1.3.4->requests[security])\r\n  Using cached https://files.pythonhosted.org/packages/ea/cd/35485615f45f30a510576f1a56d1e0a7ad7bd8ab5ed7cdc600ef7cd06222/asn1crypto-0.24.0-py2.py3-none-any.whl\r\nCollecting cffi!=1.11.3,>=1.7 (from cryptography>=1.3.4->requests[security])\r\n  Using cached https://files.pythonhosted.org/packages/0b/ba/32835c9965d8a0090723e1d0b47373365525c4bd08c807b5efdc9fecbc99/cffi-1.11.5-cp37-cp37m-macosx_10_9_x86_64.whl\r\nCollecting pycparser (from cffi!=1.11.3,>=1.7->cryptography>=1.3.4->requests[security])\r\nInstalling collected packages: chardet, idna, urllib3, certifi, asn1crypto, six, pycparser, cffi, cryptography, pyOpenSSL, requests\r\n  Running setup.py develop for requests\r\nSuccessfully installed asn1crypto-0.24.0 certifi-2018.4.16 cffi-1.11.5 chardet-3.0.4 cryptography-2.3 idna-2.7 pyOpenSSL-18.0.0 pycparser-2.18 requests six-1.11.0 urllib3-1.23\r\n\r\nAdding -e git+https://github.com/requests/requests#egg=requests[security] to Pipfile's [packages]…\r\nPipfile.lock not found, creating…\r\nLocking [dev-packages] dependencies…\r\nLocking [packages] dependencies…\r\nUpdated Pipfile.lock (2aa546)!\r\nInstalling dependencies from Pipfile.lock (2aa546)…\r\n  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 5/5 —  00:00:01\r\nTo activate this project's virtualenv, run pipenv shell.\r\nAlternatively, run a command inside the virtualenv with pipenv run.\r\n```\r\n\r\n-------------------------------------------------------------------------------\r\n\r\n<details><summary>$ pipenv --support</summary>\r\n\r\nPipenv version: `'2018.7.1.dev0'`\r\n\r\nPipenv location: `'/usr/local/lib/python3.7/site-packages/pipenv'`\r\n\r\nPython location: `'/usr/local/opt/python/bin/python3.7'`\r\n\r\nPython installations found:\r\n\r\n  - `3.7.0`: `/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/bin/python3.7`\r\n  - `3.7.0`: `/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/bin/python3.7m`\r\n  - `2.7.15`: `/usr/local/Cellar/python@2/2.7.15_1/Frameworks/Python.framework/Versions/2.7/bin/python2.7`\r\n  - `2.7.10`: `/usr/bin/python`\r\n  - `2.7.10`: `/usr/bin/pythonw`\r\n  - `2.7.10`: `/System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2.7`\r\n\r\nPEP 508 Information:\r\n\r\n```\r\n{'implementation_name': 'cpython',\r\n 'implementation_version': '3.7.0',\r\n 'os_name': 'posix',\r\n 'platform_machine': 'x86_64',\r\n 'platform_python_implementation': 'CPython',\r\n 'platform_release': '17.6.0',\r\n 'platform_system': 'Darwin',\r\n 'platform_version': 'Darwin Kernel Version 17.6.0: Tue May  8 15:22:16 PDT '\r\n                     '2018; root:xnu-4570.61.1~1/RELEASE_X86_64',\r\n 'python_full_version': '3.7.0',\r\n 'python_version': '3.7',\r\n 'sys_platform': 'darwin'}\r\n```\r\n\r\nSystem environment variables:\r\n\r\n  - `GREP_COLOR`\r\n  - `MANPATH`\r\n  - `LESS_TERMCAP_mb`\r\n  - `TERM_PROGRAM`\r\n  - `LESS_TERMCAP_md`\r\n  - `NVM_CD_FLAGS`\r\n  - `LESS_TERMCAP_me`\r\n  - `TERM`\r\n  - `SHELL`\r\n  - `TMPDIR`\r\n  - `Apple_PubSub_Socket_Render`\r\n  - `TERM_PROGRAM_VERSION`\r\n  - `TERM_SESSION_ID`\r\n  - `LESS_TERMCAP_ue`\r\n  - `USER`\r\n  - `NVM_DIR`\r\n  - `LS_COLORS`\r\n  - `GREP_COLORS`\r\n  - `SSH_AUTH_SOCK`\r\n  - `__CF_USER_TEXT_ENCODING`\r\n  - `PAGER`\r\n  - `TMUX`\r\n  - `LESS_TERMCAP_us`\r\n  - `TERMINFO_DIRS`\r\n  - `PATH`\r\n  - `PWD`\r\n  - `JENV_LOADED`\r\n  - `HOMEBREW_GITHUB_API_TOKEN`\r\n  - `EDITOR`\r\n  - `LANG`\r\n  - `ITERM_PROFILE`\r\n  - `XPC_FLAGS`\r\n  - `TMUX_PANE`\r\n  - `XPC_SERVICE_NAME`\r\n  - `SHLVL`\r\n  - `HOME`\r\n  - `COLORFGBG`\r\n  - `ITERM_SESSION_ID`\r\n  - `LOGNAME`\r\n  - `LESS`\r\n  - `VISUAL`\r\n  - `LESS_TERMCAP_so`\r\n  - `TMUX_PLUGIN_MANAGER_PATH`\r\n  - `NVM_BIN`\r\n  - `BROWSER`\r\n  - `DISPLAY`\r\n  - `SECURITYSESSIONID`\r\n  - `P4CONFIG`\r\n  - `LESS_TERMCAP_se`\r\n  - `COLORTERM`\r\n  - `OLDPWD`\r\n  - `PROMPT_EOL_MARK`\r\n  - `VIRTUAL_ENV_DISABLE_PROMPT`\r\n  - `_`\r\n  - `PYTHONDONTWRITEBYTECODE`\r\n  - `PIP_PYTHON_PATH`\r\n\r\nPipenv–specific environment variables:\r\n\r\n\r\nDebug–specific environment variables:\r\n\r\n  - `PATH`: `/Users/bryan/.jenv/shims:/Users/bryan/.jenv/bin:/Users/bryan/bin:/Users/bryan/.dotfiles/bin:/Users/bryan/Projects/pebble/PebbleSDK-current/bin:/usr/local/opt/coreutils/libexec/gnubin:/usr/local/opt/gnu-sed/libexec/gnubin:/Users/bryan/.cargo/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/MacGPG2/bin:/usr/local/share/dotnet:/opt/X11/bin:/Users/bryan/.jenv/shims:/Users/bryan/.nvm/versions/node/v8.11.1/bin`\r\n  - `SHELL`: `/usr/local/bin/zsh`\r\n  - `EDITOR`: `vi`\r\n  - `LANG`: `en_US.UTF-8`\r\n  - `PWD`: `/Users/bryan/Projects/test-pipenv`\r\n\r\n\r\n---------------------------\r\n\r\nContents of `Pipfile` ('/Users/bryan/Projects/test-pipenv/Pipfile'):\r\n\r\n```toml\r\n[[source]]\r\nurl = \"https://pypi.org/simple\"\r\nverify_ssl = true\r\nname = \"pypi\"\r\n\r\n[packages]\r\nrequests = {extras = [\"security\"], editable = true, git = \"https://github.com/requests/requests\"}\r\n\r\n[dev-packages]\r\n\r\n[requires]\r\npython_version = \"3.7\"\r\n\r\n```\r\n\r\n\r\nContents of `Pipfile.lock` ('/Users/bryan/Projects/test-pipenv/Pipfile.lock'):\r\n\r\n```json\r\n{\r\n    \"_meta\": {\r\n        \"hash\": {\r\n            \"sha256\": \"b441ec5974e2df395db9732e60296508b91b7ecd7498fdbf915620e1e52aa546\"\r\n        },\r\n        \"pipfile-spec\": 6,\r\n        \"requires\": {\r\n            \"python_version\": \"3.7\"\r\n        },\r\n        \"sources\": [\r\n            {\r\n                \"name\": \"pypi\",\r\n                \"url\": \"https://pypi.org/simple\",\r\n                \"verify_ssl\": true\r\n            }\r\n        ]\r\n    },\r\n    \"default\": {\r\n        \"certifi\": {\r\n            \"hashes\": [\r\n                \"sha256:13e698f54293db9f89122b0581843a782ad0934a4fe0172d2a980ba77fc61bb7\",\r\n                \"sha256:9fa520c1bacfb634fa7af20a76bcbd3d5fb390481724c597da32c719a7dca4b0\"\r\n            ],\r\n            \"version\": \"==2018.4.16\"\r\n        },\r\n        \"chardet\": {\r\n            \"hashes\": [\r\n                \"sha256:84ab92ed1c4d4f16916e05906b6b75a6c0fb5db821cc65e70cbd64a3e2a5eaae\",\r\n                \"sha256:fc323ffcaeaed0e0a02bf4d117757b98aed530d9ed4531e3e15460124c106691\"\r\n            ],\r\n            \"version\": \"==3.0.4\"\r\n        },\r\n        \"idna\": {\r\n            \"hashes\": [\r\n                \"sha256:156a6814fb5ac1fc6850fb002e0852d56c0c8d2531923a51032d1b70760e186e\",\r\n                \"sha256:684a38a6f903c1d71d6d5fac066b58d7768af4de2b832e426ec79c30daa94a16\"\r\n            ],\r\n            \"version\": \"==2.7\"\r\n        },\r\n        \"requests\": {\r\n            \"editable\": true,\r\n            \"extras\": [\r\n                \"security\"\r\n            ],\r\n            \"git\": \"https://github.com/requests/requests\",\r\n            \"ref\": \"c8f3add5ed31bbb82cb337435295200a3525920a\"\r\n        },\r\n        \"urllib3\": {\r\n            \"hashes\": [\r\n                \"sha256:a68ac5e15e76e7e5dd2b8f94007233e01effe3e50e8daddf69acfd81cb686baf\",\r\n                \"sha256:b5725a0bd4ba422ab0e66e89e030c806576753ea3ee08554382c14e685d117b5\"\r\n            ],\r\n            \"markers\": \"python_version != '3.3.*' and python_version >= '2.6' and python_version != '3.0.*' and python_version < '4' and python_version != '3.1.*' and python_version != '3.2.*'\",\r\n            \"version\": \"==1.23\"\r\n        }\r\n    },\r\n    \"develop\": {}\r\n}\r\n\r\n```\r\n</details>"}}
{"actor":{"display_login":"bryanforbes"}}