{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17652","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17652/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17652/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17652/events","html_url":"https://github.com/ManageIQ/manageiq/pull/17652","id":336734993,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTE3NzQ5","number":17652,"title":"[WIP] Add file splitting to evm:db tasks","user":{"login":"NickLaMuro","id":314014,"node_id":"MDQ6VXNlcjMxNDAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/314014?v=4","gravatar_id":"","url":"https://api.github.com/users/NickLaMuro","html_url":"https://github.com/NickLaMuro","followers_url":"https://api.github.com/users/NickLaMuro/followers","following_url":"https://api.github.com/users/NickLaMuro/following{/other_user}","gists_url":"https://api.github.com/users/NickLaMuro/gists{/gist_id}","starred_url":"https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickLaMuro/subscriptions","organizations_url":"https://api.github.com/users/NickLaMuro/orgs","repos_url":"https://api.github.com/users/NickLaMuro/repos","events_url":"https://api.github.com/users/NickLaMuro/events{/privacy}","received_events_url":"https://api.github.com/users/NickLaMuro/received_events","type":"User","site_admin":false},"labels":[{"id":176168677,"node_id":"MDU6TGFiZWwxNzYxNjg2Nzc=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-28T18:40:18Z","updated_at":"2018-07-18T02:01:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17652","html_url":"https://github.com/ManageIQ/manageiq/pull/17652","diff_url":"https://github.com/ManageIQ/manageiq/pull/17652.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/17652.patch"},"body":"Built off of https://github.com/ManageIQ/manageiq/pull/17549\r\n\r\nProvides support for `evm:db:dump:*` tasks (will support `evm:db:backup` as well) to have the files split into chunks automatically by passing in the `--byte-count` flag to those tasks.\r\n\r\nTODO\r\n----\r\n\r\n* [ ] Vagrantfile and test script for testings these live (in progress)\r\n* [x] Setup `:remote` tasks to use splitting with NFS and SMB end points\r\n  - (want to have test vagrant env in place for this, see above)\r\n  - This will be easy to implement, however, and it will just be adding the `additional_opts` code for the `:remote` tasks as well (see last commit)\r\n\r\nLinks\r\n-----\r\n\r\n* Prerequisites:\r\n  - `pipe` support in `AwesomeSpawn`: https://github.com/ManageIQ/awesome_spawn/pull/41\r\n  - PR to PostgresAdmin providing `:pipe` support to dump and backup:  https://github.com/ManageIQ/manageiq-gems-pending/pull/356\r\n  - File splitter ruby script:  https://github.com/ManageIQ/manageiq/pull/17549\r\n\r\nSteps for Testing/QA\r\n--------------------\r\n\r\nI currently am using the above prerequisites locally to test (probably a gist with a `Vagrantfile` plus test script).  Will provide detailed instructions soon."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/405784470","html_url":"https://github.com/ManageIQ/manageiq/pull/17652#issuecomment-405784470","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17652","id":405784470,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTc4NDQ3MA==","user":{"login":"miq-bot","id":7806257,"node_id":"MDQ6VXNlcjc4MDYyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T02:01:20Z","updated_at":"2018-07-18T02:01:20Z","author_association":"MEMBER","body":"<rubocop />Checked commits https://github.com/NickLaMuro/manageiq/compare/5a2ec6bb88090fd9bd9a897fa4ef7a0536ccaf21~...83c2d8c244425270e71bfd89f16b0e550948b2e1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n7 files checked, 4 offenses detected\n\n**lib/manageiq/util/file_splitter.rb**\n- [ ] :warning: - [Line 1](https://github.com/NickLaMuro/manageiq/blob/83c2d8c244425270e71bfd89f16b0e550948b2e1/lib/manageiq/util/file_splitter.rb#L1), Col 1 - [Lint/ScriptPermission](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Lint/ScriptPermission) - Script file file_splitter.rb doesn't have execute permission.\n- [ ] :exclamation: - [Line 96](https://github.com/NickLaMuro/manageiq/blob/83c2d8c244425270e71bfd89f16b0e550948b2e1/lib/manageiq/util/file_splitter.rb#L96), Col 9 - [Style/SafeNavigation](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/SafeNavigation) - Use safe navigation (`&.`) instead of checking if an object exists before calling the method.\n\n**lib/tasks/evm_dba.rake**\n- [ ] :exclamation: - [Line 53](https://github.com/NickLaMuro/manageiq/blob/83c2d8c244425270e71bfd89f16b0e550948b2e1/lib/tasks/evm_dba.rake#L53), Col 5 - [Style/SymbolArray](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/SymbolArray) - Use `%i` or `%I` for an array of symbols.\n- [ ] :exclamation: - [Line 59](https://github.com/NickLaMuro/manageiq/blob/83c2d8c244425270e71bfd89f16b0e550948b2e1/lib/tasks/evm_dba.rake#L59), Col 5 - [Style/SymbolArray](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/SymbolArray) - Use `%i` or `%I` for an array of symbols.\n"}}
{"actor":{"display_login":"miq-bot"}}