{"action":"created","issue":{"url":"https://api.github.com/repos/alexa-js/alexa-app/issues/314","repository_url":"https://api.github.com/repos/alexa-js/alexa-app","labels_url":"https://api.github.com/repos/alexa-js/alexa-app/issues/314/labels{/name}","comments_url":"https://api.github.com/repos/alexa-js/alexa-app/issues/314/comments","events_url":"https://api.github.com/repos/alexa-js/alexa-app/issues/314/events","html_url":"https://github.com/alexa-js/alexa-app/pull/314","id":296124242,"number":314,"title":"Fix breaking logic in request.slot()","user":{"login":"User1m","id":4316022,"avatar_url":"https://avatars1.githubusercontent.com/u/4316022?v=4","gravatar_id":"","url":"https://api.github.com/users/User1m","html_url":"https://github.com/User1m","followers_url":"https://api.github.com/users/User1m/followers","following_url":"https://api.github.com/users/User1m/following{/other_user}","gists_url":"https://api.github.com/users/User1m/gists{/gist_id}","starred_url":"https://api.github.com/users/User1m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/User1m/subscriptions","organizations_url":"https://api.github.com/users/User1m/orgs","repos_url":"https://api.github.com/users/User1m/repos","events_url":"https://api.github.com/users/User1m/events{/privacy}","received_events_url":"https://api.github.com/users/User1m/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-10T18:59:07Z","updated_at":"2018-02-18T14:28:36Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/alexa-js/alexa-app/pulls/314","html_url":"https://github.com/alexa-js/alexa-app/pull/314","diff_url":"https://github.com/alexa-js/alexa-app/pull/314.diff","patch_url":"https://github.com/alexa-js/alexa-app/pull/314.patch"},"body":"I started receiving the following Intent Requests when an empty slot is provided:\r\n```\r\n{\r\n    \"type\": \"IntentRequest\",\r\n    \"requestId\": \"amzn1.echo-api.request.ID\",\r\n    \"timestamp\": \"2018-02-10T18:35:41Z\",\r\n    \"locale\": \"en-US\",\r\n    \"intent\": {\r\n        \"name\": \"PersonIntent\",\r\n        \"confirmationStatus\": \"NONE\",\r\n        \"slots\": {\r\n            \"Name\": {\r\n                \"name\": \"Name\",\r\n                \"confirmationStatus\": \"NONE\"\r\n            }\r\n        }\r\n    }\r\n}\r\n```\r\nThis was causing my function `request.slot(SlotName, defaultValue)` to fail. Because as it stands the logic in `request.slot()` doesn't check if the `value` is `'undefined'` and so doesn't return the `'defaultValue'`. This fixes that."},"comment":{"url":"https://api.github.com/repos/alexa-js/alexa-app/issues/comments/366519954","html_url":"https://github.com/alexa-js/alexa-app/pull/314#issuecomment-366519954","issue_url":"https://api.github.com/repos/alexa-js/alexa-app/issues/314","id":366519954,"user":{"login":"kobim","id":679761,"avatar_url":"https://avatars1.githubusercontent.com/u/679761?v=4","gravatar_id":"","url":"https://api.github.com/users/kobim","html_url":"https://github.com/kobim","followers_url":"https://api.github.com/users/kobim/followers","following_url":"https://api.github.com/users/kobim/following{/other_user}","gists_url":"https://api.github.com/users/kobim/gists{/gist_id}","starred_url":"https://api.github.com/users/kobim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobim/subscriptions","organizations_url":"https://api.github.com/users/kobim/orgs","repos_url":"https://api.github.com/users/kobim/repos","events_url":"https://api.github.com/users/kobim/events{/privacy}","received_events_url":"https://api.github.com/users/kobim/received_events","type":"User","site_admin":false},"created_at":"2018-02-18T14:28:36Z","updated_at":"2018-02-18T14:28:36Z","author_association":"COLLABORATOR","body":"@dblock there's some problem with dtslint's _strict-export-declare-modifiers_ rule ([ref 1](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/22503#issuecomment-354200016), [ref 2](https://github.com/Microsoft/dtslint/issues/88)).\r\nMaybe it's worth disabling for now? (it affects [other builds as well](https://travis-ci.org/alexa-js/alexa-app/jobs/337861983))"}}
{"actor":{"display_login":"kobim"}}