{"action":"created","issue":{"url":"https://api.github.com/repos/rtfd/sphinx_rtd_theme/issues/432","repository_url":"https://api.github.com/repos/rtfd/sphinx_rtd_theme","labels_url":"https://api.github.com/repos/rtfd/sphinx_rtd_theme/issues/432/labels{/name}","comments_url":"https://api.github.com/repos/rtfd/sphinx_rtd_theme/issues/432/comments","events_url":"https://api.github.com/repos/rtfd/sphinx_rtd_theme/issues/432/events","html_url":"https://github.com/rtfd/sphinx_rtd_theme/pull/432","id":236317722,"node_id":"MDExOlB1bGxSZXF1ZXN0MTI1OTE0ODk4","number":432,"title":"Wrap table cells for a better responsive table experience + fix print","user":{"login":"benjaoming","id":374612,"node_id":"MDQ6VXNlcjM3NDYxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/374612?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/rtfd/sphinx_rtd_theme/milestones/7","html_url":"https://github.com/rtfd/sphinx_rtd_theme/milestone/7","labels_url":"https://api.github.com/repos/rtfd/sphinx_rtd_theme/milestones/7/labels","id":3408312,"node_id":"MDk6TWlsZXN0b25lMzQwODMxMg==","number":7,"title":"0.5","description":"","creator":{"login":"agjohnson","id":1140183,"node_id":"MDQ6VXNlcjExNDAxODM=","avatar_url":"https://avatars0.githubusercontent.com/u/1140183?v=4","gravatar_id":"","url":"https://api.github.com/users/agjohnson","html_url":"https://github.com/agjohnson","followers_url":"https://api.github.com/users/agjohnson/followers","following_url":"https://api.github.com/users/agjohnson/following{/other_user}","gists_url":"https://api.github.com/users/agjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/agjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agjohnson/subscriptions","organizations_url":"https://api.github.com/users/agjohnson/orgs","repos_url":"https://api.github.com/users/agjohnson/repos","events_url":"https://api.github.com/users/agjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/agjohnson/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":1,"state":"open","created_at":"2018-06-07T16:05:05Z","updated_at":"2018-09-26T20:43:43Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2017-06-15T21:20:29Z","updated_at":"2018-10-01T14:47:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rtfd/sphinx_rtd_theme/pulls/432","html_url":"https://github.com/rtfd/sphinx_rtd_theme/pull/432","diff_url":"https://github.com/rtfd/sphinx_rtd_theme/pull/432.diff","patch_url":"https://github.com/rtfd/sphinx_rtd_theme/pull/432.patch"},"body":"Fixes\r\n * #117 \r\n * https://github.com/rtfd/readthedocs.org/issues/2161\r\n\r\nAdds:\r\n\r\n * Wrapping for `<td>`s on desktop sizes\r\n * Visible overflow and wrapping on printed media\r\n\r\nDoes not wrap `<th>` on purpose, this leaves a bit of control for people who wanna force the width of certain columns.\r\n\r\nPlease observe the great amount of projects working around the issue with related commits, issues and PRs.\r\n\r\nQuotes:\r\n\r\n@kmike\r\n> Why not have relevant CSS fixed by default? Are there cases when it is desirable to truncate the information in table, be it a tablet screen or a computer screen? On tablets existing tables are even worse because horizontal scroll of individual elements is hard on touch interfaces. On macs there is no indication that table can be horizontally scrolled because scrollbars are hidden by default; they don't appear even on hover, you need to actually start scrolling to see the scrollbars.\r\n\r\n@agjohnson \r\n> This was a design decision for the theme around table wrapping, though I agree that the experience around wide tables on large displays is generally poor.\r\n\r\n**Before**\r\n\r\nI agree that this may look nicer, but that's only because the example table doesn't have a lot of text in its `<td>`s!\r\n\r\n![screenshot from 2017-06-15 22-54-02](https://user-images.githubusercontent.com/374612/27202151-b4a63226-5220-11e7-9f3c-d74caaf24092.png)\r\n\r\n**After**\r\n\r\n![screenshot from 2017-06-15 22-53-42](https://user-images.githubusercontent.com/374612/27202168-d0d5342e-5220-11e7-90f7-89ab76bf239c.png)\r\n\r\n**Printing**\r\n\r\nThere's now a higher probability that tables will print:\r\n\r\n![screenshot from 2017-06-15 23-44-06](https://user-images.githubusercontent.com/374612/27203113-9bae7554-5224-11e7-8af1-e76914331249.png)\r\n\r\n\r\n**FAQ**\r\n\r\nQ: *Why no `overflow: visible` on desktop tables?*\r\n\r\nA: Because horizontal scrolling is completely off in the theme, so the table would be cropped like this :/\r\n\r\n![screenshot from 2017-06-15 23-14-24](https://user-images.githubusercontent.com/374612/27202267-366773ec-5221-11e7-85f4-21f091af6ab1.png)\r\n"},"comment":{"url":"https://api.github.com/repos/rtfd/sphinx_rtd_theme/issues/comments/425935082","html_url":"https://github.com/rtfd/sphinx_rtd_theme/pull/432#issuecomment-425935082","issue_url":"https://api.github.com/repos/rtfd/sphinx_rtd_theme/issues/432","id":425935082,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTkzNTA4Mg==","user":{"login":"Blendify","id":15183467,"node_id":"MDQ6VXNlcjE1MTgzNDY3","avatar_url":"https://avatars2.githubusercontent.com/u/15183467?v=4","gravatar_id":"","url":"https://api.github.com/users/Blendify","html_url":"https://github.com/Blendify","followers_url":"https://api.github.com/users/Blendify/followers","following_url":"https://api.github.com/users/Blendify/following{/other_user}","gists_url":"https://api.github.com/users/Blendify/gists{/gist_id}","starred_url":"https://api.github.com/users/Blendify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blendify/subscriptions","organizations_url":"https://api.github.com/users/Blendify/orgs","repos_url":"https://api.github.com/users/Blendify/repos","events_url":"https://api.github.com/users/Blendify/events{/privacy}","received_events_url":"https://api.github.com/users/Blendify/received_events","type":"User","site_admin":false},"created_at":"2018-10-01T14:47:10Z","updated_at":"2018-10-01T14:47:10Z","author_association":"CONTRIBUTOR","body":"> @agjohnson\r\n> \r\n> > agjohnson removed the PR: ready for review label 14 days ago\r\n> \r\n> What does that mean?\r\n> \r\n> PR is rebased to latest master.\r\n\r\nThis can be ignored, it was automated. All the labels for rtfd were synced so some were removed."}}
{"actor":{"display_login":"Blendify"}}