{"action":"created","comment":{"url":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments/172493845","pull_request_review_id":101516697,"id":172493845,"diff_hunk":"@@ -186,6 +191,21 @@ def call(parameters = [:]) {\n                           dockerEnvVars: configuration.get('dockerEnvVars'),\n                           dockerOptions: configuration.get('dockerOptions')) {\n \n+                          NEO_HOME_CHECK: {\n+                              // same order like inside getNeoExecutable\n+                              String neoHome = configuration.neoHome ?: env?.NEO_HOME\n+\n+                              // In case neo home is not set, but neo toolset is simply\n+                              // in the path, we trust that everything is OK. In order to\n+                              // validate the version also in this case, we need to adjust\n+                              // toolValidate.\n+\n+                              def rc = sh script: \"which ${NEO_DEFAULT_CMD}\", returnStatus: true\n+                              if(neoHome || (!neoHome && rc != 0)) {","path":"vars/neoDeploy.groovy","position":28,"original_position":28,"commit_id":"0dbb8bef08326e232c7a2bff9acabee95764e12f","original_commit_id":"0dbb8bef08326e232c7a2bff9acabee95764e12f","user":{"login":"marcusholl","id":1853183,"avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"body":"We can discuss if we should fail here in case ```!neoHome```. With the current approach the behavior is closer to the behavior before the change. Before the change we got inside ```toolValidate```and fail inside in the same was like it is now.","created_at":"2018-03-06T11:59:29Z","updated_at":"2018-03-06T11:59:29Z","html_url":"https://github.com/SAP/jenkins-library/pull/93#discussion_r172493845","pull_request_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/93","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments/172493845"},"html":{"href":"https://github.com/SAP/jenkins-library/pull/93#discussion_r172493845"},"pull_request":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/93"}},"in_reply_to_id":171556344},"pull_request":{"url":"https://api.github.com/repos/SAP/jenkins-library/pulls/93","id":170169147,"html_url":"https://github.com/SAP/jenkins-library/pull/93","diff_url":"https://github.com/SAP/jenkins-library/pull/93.diff","patch_url":"https://github.com/SAP/jenkins-library/pull/93.patch","issue_url":"https://api.github.com/repos/SAP/jenkins-library/issues/93","number":93,"state":"open","locked":false,"title":"Validate neo home inside neoDeploy","user":{"login":"marcusholl","id":1853183,"avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-20T11:43:28Z","updated_at":"2018-03-06T11:59:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00a05422191fb3f856b6319efaaba4606ff98e0a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"CCFenner","id":26137398,"avatar_url":"https://avatars2.githubusercontent.com/u/26137398?v=4","gravatar_id":"","url":"https://api.github.com/users/CCFenner","html_url":"https://github.com/CCFenner","followers_url":"https://api.github.com/users/CCFenner/followers","following_url":"https://api.github.com/users/CCFenner/following{/other_user}","gists_url":"https://api.github.com/users/CCFenner/gists{/gist_id}","starred_url":"https://api.github.com/users/CCFenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCFenner/subscriptions","organizations_url":"https://api.github.com/users/CCFenner/orgs","repos_url":"https://api.github.com/users/CCFenner/repos","events_url":"https://api.github.com/users/CCFenner/events{/privacy}","received_events_url":"https://api.github.com/users/CCFenner/received_events","type":"User","site_admin":false},{"login":"OliverNocon","id":33484802,"avatar_url":"https://avatars2.githubusercontent.com/u/33484802?v=4","gravatar_id":"","url":"https://api.github.com/users/OliverNocon","html_url":"https://github.com/OliverNocon","followers_url":"https://api.github.com/users/OliverNocon/followers","following_url":"https://api.github.com/users/OliverNocon/following{/other_user}","gists_url":"https://api.github.com/users/OliverNocon/gists{/gist_id}","starred_url":"https://api.github.com/users/OliverNocon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OliverNocon/subscriptions","organizations_url":"https://api.github.com/users/OliverNocon/orgs","repos_url":"https://api.github.com/users/OliverNocon/repos","events_url":"https://api.github.com/users/OliverNocon/events{/privacy}","received_events_url":"https://api.github.com/users/OliverNocon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/93/commits","review_comments_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/93/comments","review_comment_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SAP/jenkins-library/issues/93/comments","statuses_url":"https://api.github.com/repos/SAP/jenkins-library/statuses/0dbb8bef08326e232c7a2bff9acabee95764e12f","head":{"label":"marcusholl:pr/neoHomeValidationInsideNeoDeploy","ref":"pr/neoHomeValidationInsideNeoDeploy","sha":"0dbb8bef08326e232c7a2bff9acabee95764e12f","user":{"login":"marcusholl","id":1853183,"avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"repo":{"id":110531482,"name":"jenkins-library","full_name":"marcusholl/jenkins-library","owner":{"login":"marcusholl","id":1853183,"avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcusholl/jenkins-library","description":"Jenkins shared library for Continuous Delivery pipelines.","fork":true,"url":"https://api.github.com/repos/marcusholl/jenkins-library","forks_url":"https://api.github.com/repos/marcusholl/jenkins-library/forks","keys_url":"https://api.github.com/repos/marcusholl/jenkins-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcusholl/jenkins-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcusholl/jenkins-library/teams","hooks_url":"https://api.github.com/repos/marcusholl/jenkins-library/hooks","issue_events_url":"https://api.github.com/repos/marcusholl/jenkins-library/issues/events{/number}","events_url":"https://api.github.com/repos/marcusholl/jenkins-library/events","assignees_url":"https://api.github.com/repos/marcusholl/jenkins-library/assignees{/user}","branches_url":"https://api.github.com/repos/marcusholl/jenkins-library/branches{/branch}","tags_url":"https://api.github.com/repos/marcusholl/jenkins-library/tags","blobs_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcusholl/jenkins-library/statuses/{sha}","languages_url":"https://api.github.com/repos/marcusholl/jenkins-library/languages","stargazers_url":"https://api.github.com/repos/marcusholl/jenkins-library/stargazers","contributors_url":"https://api.github.com/repos/marcusholl/jenkins-library/contributors","subscribers_url":"https://api.github.com/repos/marcusholl/jenkins-library/subscribers","subscription_url":"https://api.github.com/repos/marcusholl/jenkins-library/subscription","commits_url":"https://api.github.com/repos/marcusholl/jenkins-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcusholl/jenkins-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcusholl/jenkins-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcusholl/jenkins-library/contents/{+path}","compare_url":"https://api.github.com/repos/marcusholl/jenkins-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcusholl/jenkins-library/merges","archive_url":"https://api.github.com/repos/marcusholl/jenkins-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcusholl/jenkins-library/downloads","issues_url":"https://api.github.com/repos/marcusholl/jenkins-library/issues{/number}","pulls_url":"https://api.github.com/repos/marcusholl/jenkins-library/pulls{/number}","milestones_url":"https://api.github.com/repos/marcusholl/jenkins-library/milestones{/number}","notifications_url":"https://api.github.com/repos/marcusholl/jenkins-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcusholl/jenkins-library/labels{/name}","releases_url":"https://api.github.com/repos/marcusholl/jenkins-library/releases{/id}","deployments_url":"https://api.github.com/repos/marcusholl/jenkins-library/deployments","created_at":"2017-11-13T10:05:10Z","updated_at":"2017-11-13T10:05:12Z","pushed_at":"2018-03-06T10:14:38Z","git_url":"git://github.com/marcusholl/jenkins-library.git","ssh_url":"git@github.com:marcusholl/jenkins-library.git","clone_url":"https://github.com/marcusholl/jenkins-library.git","svn_url":"https://github.com/marcusholl/jenkins-library","homepage":null,"size":726,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SAP:master","ref":"master","sha":"d45720bcdad9f917b70dfc0581bbd98f66b8f3ab","user":{"login":"SAP","id":2531208,"avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":107318996,"name":"jenkins-library","full_name":"SAP/jenkins-library","owner":{"login":"SAP","id":2531208,"avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SAP/jenkins-library","description":"Jenkins shared library for Continuous Delivery pipelines.","fork":false,"url":"https://api.github.com/repos/SAP/jenkins-library","forks_url":"https://api.github.com/repos/SAP/jenkins-library/forks","keys_url":"https://api.github.com/repos/SAP/jenkins-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/jenkins-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/jenkins-library/teams","hooks_url":"https://api.github.com/repos/SAP/jenkins-library/hooks","issue_events_url":"https://api.github.com/repos/SAP/jenkins-library/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/jenkins-library/events","assignees_url":"https://api.github.com/repos/SAP/jenkins-library/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/jenkins-library/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/jenkins-library/tags","blobs_url":"https://api.github.com/repos/SAP/jenkins-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/jenkins-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/jenkins-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/jenkins-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/jenkins-library/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/jenkins-library/languages","stargazers_url":"https://api.github.com/repos/SAP/jenkins-library/stargazers","contributors_url":"https://api.github.com/repos/SAP/jenkins-library/contributors","subscribers_url":"https://api.github.com/repos/SAP/jenkins-library/subscribers","subscription_url":"https://api.github.com/repos/SAP/jenkins-library/subscription","commits_url":"https://api.github.com/repos/SAP/jenkins-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/jenkins-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/jenkins-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/jenkins-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/jenkins-library/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/jenkins-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/jenkins-library/merges","archive_url":"https://api.github.com/repos/SAP/jenkins-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/jenkins-library/downloads","issues_url":"https://api.github.com/repos/SAP/jenkins-library/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/jenkins-library/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/jenkins-library/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/jenkins-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/jenkins-library/labels{/name}","releases_url":"https://api.github.com/repos/SAP/jenkins-library/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/jenkins-library/deployments","created_at":"2017-10-17T20:14:48Z","updated_at":"2018-03-05T09:32:22Z","pushed_at":"2018-03-06T11:50:02Z","git_url":"git://github.com/SAP/jenkins-library.git","ssh_url":"git@github.com:SAP/jenkins-library.git","clone_url":"https://github.com/SAP/jenkins-library.git","svn_url":"https://github.com/SAP/jenkins-library","homepage":null,"size":1100,"stargazers_count":38,"watchers_count":38,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":24,"open_issues":27,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/93"},"html":{"href":"https://github.com/SAP/jenkins-library/pull/93"},"issue":{"href":"https://api.github.com/repos/SAP/jenkins-library/issues/93"},"comments":{"href":"https://api.github.com/repos/SAP/jenkins-library/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/SAP/jenkins-library/statuses/0dbb8bef08326e232c7a2bff9acabee95764e12f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"marcusholl"}}