{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/237675369","pull_request_review_id":180035877,"id":237675369,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzY3NTM2OQ==","diff_hunk":"@@ -2414,10 +2420,24 @@ abstract class RenderObject extends AbstractNode with DiagnosticableTreeMixin im\n     final Set<_InterestingSemanticsFragment> toBeMarkedExplicit = Set<_InterestingSemanticsFragment>();\n     final bool childrenMergeIntoParent = mergeIntoParent || config.isMergingSemanticsOfDescendants;\n \n+    // When set to true there's currently not enough information in this subtree\n+    // to compute semantics. In this case the walk needs to be aborted and no\n+    // SemanticsNodes in the subtree should be updated.\n+    // This will be true for subtrees that are currently offstage.","path":"packages/flutter/lib/src/rendering/object.dart","position":27,"original_position":27,"commit_id":"bca4455b19388809a1069dccb78eade2c2b37b8f","original_commit_id":"bca4455b19388809a1069dccb78eade2c2b37b8f","user":{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"ditto","created_at":"2018-11-29T22:00:18Z","updated_at":"2018-11-29T22:00:18Z","html_url":"https://github.com/flutter/flutter/pull/24862#discussion_r237675369","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/24862","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/237675369"},"html":{"href":"https://github.com/flutter/flutter/pull/24862#discussion_r237675369"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/24862"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/24862","id":234728819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzI4ODE5","html_url":"https://github.com/flutter/flutter/pull/24862","diff_url":"https://github.com/flutter/flutter/pull/24862.diff","patch_url":"https://github.com/flutter/flutter/pull/24862.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/24862","number":24862,"state":"open","locked":false,"title":"Fix semantics compiler for offstage children","user":{"login":"goderbauer","id":1227763,"node_id":"MDQ6VXNlcjEyMjc3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1227763?v=4","gravatar_id":"","url":"https://api.github.com/users/goderbauer","html_url":"https://github.com/goderbauer","followers_url":"https://api.github.com/users/goderbauer/followers","following_url":"https://api.github.com/users/goderbauer/following{/other_user}","gists_url":"https://api.github.com/users/goderbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/goderbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goderbauer/subscriptions","organizations_url":"https://api.github.com/users/goderbauer/orgs","repos_url":"https://api.github.com/users/goderbauer/repos","events_url":"https://api.github.com/users/goderbauer/events{/privacy}","received_events_url":"https://api.github.com/users/goderbauer/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/flutter/flutter/issues/20313.","created_at":"2018-11-29T17:45:48Z","updated_at":"2018-11-29T22:00:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49ac30f0082e921d74764410165028b8990d5cf1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/24862/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/24862/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/24862/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/bca4455b19388809a1069dccb78eade2c2b37b8f","head":{"label":"goderbauer:fixSem","ref":"fixSem","sha":"bca4455b19388809a1069dccb78eade2c2b37b8f","user":{"login":"goderbauer","id":1227763,"node_id":"MDQ6VXNlcjEyMjc3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1227763?v=4","gravatar_id":"","url":"https://api.github.com/users/goderbauer","html_url":"https://github.com/goderbauer","followers_url":"https://api.github.com/users/goderbauer/followers","following_url":"https://api.github.com/users/goderbauer/following{/other_user}","gists_url":"https://api.github.com/users/goderbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/goderbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goderbauer/subscriptions","organizations_url":"https://api.github.com/users/goderbauer/orgs","repos_url":"https://api.github.com/users/goderbauer/repos","events_url":"https://api.github.com/users/goderbauer/events{/privacy}","received_events_url":"https://api.github.com/users/goderbauer/received_events","type":"User","site_admin":false},"repo":{"id":77963655,"node_id":"MDEwOlJlcG9zaXRvcnk3Nzk2MzY1NQ==","name":"flutter","full_name":"goderbauer/flutter","private":false,"owner":{"login":"goderbauer","id":1227763,"node_id":"MDQ6VXNlcjEyMjc3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1227763?v=4","gravatar_id":"","url":"https://api.github.com/users/goderbauer","html_url":"https://github.com/goderbauer","followers_url":"https://api.github.com/users/goderbauer/followers","following_url":"https://api.github.com/users/goderbauer/following{/other_user}","gists_url":"https://api.github.com/users/goderbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/goderbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goderbauer/subscriptions","organizations_url":"https://api.github.com/users/goderbauer/orgs","repos_url":"https://api.github.com/users/goderbauer/repos","events_url":"https://api.github.com/users/goderbauer/events{/privacy}","received_events_url":"https://api.github.com/users/goderbauer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/goderbauer/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/goderbauer/flutter","forks_url":"https://api.github.com/repos/goderbauer/flutter/forks","keys_url":"https://api.github.com/repos/goderbauer/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goderbauer/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goderbauer/flutter/teams","hooks_url":"https://api.github.com/repos/goderbauer/flutter/hooks","issue_events_url":"https://api.github.com/repos/goderbauer/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/goderbauer/flutter/events","assignees_url":"https://api.github.com/repos/goderbauer/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/goderbauer/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/goderbauer/flutter/tags","blobs_url":"https://api.github.com/repos/goderbauer/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goderbauer/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goderbauer/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/goderbauer/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goderbauer/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/goderbauer/flutter/languages","stargazers_url":"https://api.github.com/repos/goderbauer/flutter/stargazers","contributors_url":"https://api.github.com/repos/goderbauer/flutter/contributors","subscribers_url":"https://api.github.com/repos/goderbauer/flutter/subscribers","subscription_url":"https://api.github.com/repos/goderbauer/flutter/subscription","commits_url":"https://api.github.com/repos/goderbauer/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/goderbauer/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/goderbauer/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/goderbauer/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/goderbauer/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/goderbauer/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goderbauer/flutter/merges","archive_url":"https://api.github.com/repos/goderbauer/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goderbauer/flutter/downloads","issues_url":"https://api.github.com/repos/goderbauer/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/goderbauer/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/goderbauer/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/goderbauer/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goderbauer/flutter/labels{/name}","releases_url":"https://api.github.com/repos/goderbauer/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/goderbauer/flutter/deployments","created_at":"2017-01-03T23:58:27Z","updated_at":"2018-05-02T21:00:43Z","pushed_at":"2018-11-29T21:35:50Z","git_url":"git://github.com/goderbauer/flutter.git","ssh_url":"git@github.com:goderbauer/flutter.git","clone_url":"https://github.com/goderbauer/flutter.git","svn_url":"https://github.com/goderbauer/flutter","homepage":"https://flutter.io","size":49510,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"72926bdff72e7915136c653c8448107ba9252e36","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-11-29T21:34:35Z","pushed_at":"2018-11-29T21:35:53Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":49541,"stargazers_count":42162,"watchers_count":42162,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4270,"mirror_url":null,"archived":false,"open_issues_count":4470,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4270,"open_issues":4470,"watchers":42162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/24862"},"html":{"href":"https://github.com/flutter/flutter/pull/24862"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/24862"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/24862/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/24862/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/24862/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/bca4455b19388809a1069dccb78eade2c2b37b8f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Hixie"}}