{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/aria-practices/pulls/comments/242872361","pull_request_review_id":186488396,"id":242872361,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjg3MjM2MQ==","diff_hunk":"@@ -30,7 +30,7 @@ module.exports = async function assertRovingTabindex (t, elementsSelector, key)\n       assert.equal(\n         await elements[el].getAttribute('tabindex'),\n         tabindex,\n-        'focus is on element ' + tabableEl + ' of elements \"' + elementsSelector +\n+        'focus is on element ' + tabableEl + ' of ' + elements.length + ' elements \"' + elementsSelector +","path":"test/util/assertRovingTabindex.js","position":5,"original_position":5,"commit_id":"ad98f19342507b6a23379567b1b730f35b8d99d7","original_commit_id":"ad98f19342507b6a23379567b1b730f35b8d99d7","user":{"login":"mcking65","id":7241781,"node_id":"MDQ6VXNlcjcyNDE3ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/7241781?v=4","gravatar_id":"","url":"https://api.github.com/users/mcking65","html_url":"https://github.com/mcking65","followers_url":"https://api.github.com/users/mcking65/followers","following_url":"https://api.github.com/users/mcking65/following{/other_user}","gists_url":"https://api.github.com/users/mcking65/gists{/gist_id}","starred_url":"https://api.github.com/users/mcking65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcking65/subscriptions","organizations_url":"https://api.github.com/users/mcking65/orgs","repos_url":"https://api.github.com/users/mcking65/repos","events_url":"https://api.github.com/users/mcking65/events{/privacy}","received_events_url":"https://api.github.com/users/mcking65/received_events","type":"User","site_admin":false},"body":"@jongund, @sh0ji, this is now different from latest from master ... I don't understand this change. Since I merged those other fixes in from Valerie, is this change helpful/needed?","created_at":"2018-12-19T10:52:45Z","updated_at":"2018-12-19T10:52:45Z","html_url":"https://github.com/w3c/aria-practices/pull/950#discussion_r242872361","pull_request_url":"https://api.github.com/repos/w3c/aria-practices/pulls/950","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/w3c/aria-practices/pulls/comments/242872361"},"html":{"href":"https://github.com/w3c/aria-practices/pull/950#discussion_r242872361"},"pull_request":{"href":"https://api.github.com/repos/w3c/aria-practices/pulls/950"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/aria-practices/pulls/950","id":236595058,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTk1MDU4","html_url":"https://github.com/w3c/aria-practices/pull/950","diff_url":"https://github.com/w3c/aria-practices/pull/950.diff","patch_url":"https://github.com/w3c/aria-practices/pull/950.patch","issue_url":"https://api.github.com/repos/w3c/aria-practices/issues/950","number":950,"state":"open","locked":false,"title":"Issue541 toolbar redesign","user":{"login":"jongund","id":1508588,"node_id":"MDQ6VXNlcjE1MDg1ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/1508588?v=4","gravatar_id":"","url":"https://api.github.com/users/jongund","html_url":"https://github.com/jongund","followers_url":"https://api.github.com/users/jongund/followers","following_url":"https://api.github.com/users/jongund/following{/other_user}","gists_url":"https://api.github.com/users/jongund/gists{/gist_id}","starred_url":"https://api.github.com/users/jongund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jongund/subscriptions","organizations_url":"https://api.github.com/users/jongund/orgs","repos_url":"https://api.github.com/users/jongund/repos","events_url":"https://api.github.com/users/jongund/events{/privacy}","received_events_url":"https://api.github.com/users/jongund/received_events","type":"User","site_admin":false},"body":"The toolbar example is ready for additional review and merging, based on comments made on the December 3rd ARIA practices meeting.   I have updated the example documentation to individually describ the buttons groups in the toolbar and why certain roles and properties are being used.  So those changes need review.\r\n\r\nThere are 2 regression tests that pass and 1 that fails for roving tabindex.   It seems to be a problem with regression test and not the example code.  ","created_at":"2018-12-06T16:37:55Z","updated_at":"2018-12-19T10:52:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54f0516d483c9f9a9a93ba901d2677d2cbd67d28","assignee":{"login":"mcking65","id":7241781,"node_id":"MDQ6VXNlcjcyNDE3ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/7241781?v=4","gravatar_id":"","url":"https://api.github.com/users/mcking65","html_url":"https://github.com/mcking65","followers_url":"https://api.github.com/users/mcking65/followers","following_url":"https://api.github.com/users/mcking65/following{/other_user}","gists_url":"https://api.github.com/users/mcking65/gists{/gist_id}","starred_url":"https://api.github.com/users/mcking65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcking65/subscriptions","organizations_url":"https://api.github.com/users/mcking65/orgs","repos_url":"https://api.github.com/users/mcking65/repos","events_url":"https://api.github.com/users/mcking65/events{/privacy}","received_events_url":"https://api.github.com/users/mcking65/received_events","type":"User","site_admin":false},"assignees":[{"login":"mcking65","id":7241781,"node_id":"MDQ6VXNlcjcyNDE3ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/7241781?v=4","gravatar_id":"","url":"https://api.github.com/users/mcking65","html_url":"https://github.com/mcking65","followers_url":"https://api.github.com/users/mcking65/followers","following_url":"https://api.github.com/users/mcking65/following{/other_user}","gists_url":"https://api.github.com/users/mcking65/gists{/gist_id}","starred_url":"https://api.github.com/users/mcking65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcking65/subscriptions","organizations_url":"https://api.github.com/users/mcking65/orgs","repos_url":"https://api.github.com/users/mcking65/repos","events_url":"https://api.github.com/users/mcking65/events{/privacy}","received_events_url":"https://api.github.com/users/mcking65/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":366736938,"node_id":"MDU6TGFiZWwzNjY3MzY5Mzg=","url":"https://api.github.com/repos/w3c/aria-practices/labels/code%20example","name":"code example","color":"006b75","default":false},{"id":354259933,"node_id":"MDU6TGFiZWwzNTQyNTk5MzM=","url":"https://api.github.com/repos/w3c/aria-practices/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/w3c/aria-practices/milestones/3","html_url":"https://github.com/w3c/aria-practices/milestone/3","labels_url":"https://api.github.com/repos/w3c/aria-practices/milestones/3/labels","id":1939922,"node_id":"MDk6TWlsZXN0b25lMTkzOTkyMg==","number":3,"title":"1.1 APG Release 3","description":"Additional ARIA 1.1 guidance that will be published approximately 12 months after ARIA becomes a proposed recommendation.","creator":{"login":"mcking65","id":7241781,"node_id":"MDQ6VXNlcjcyNDE3ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/7241781?v=4","gravatar_id":"","url":"https://api.github.com/users/mcking65","html_url":"https://github.com/mcking65","followers_url":"https://api.github.com/users/mcking65/followers","following_url":"https://api.github.com/users/mcking65/following{/other_user}","gists_url":"https://api.github.com/users/mcking65/gists{/gist_id}","starred_url":"https://api.github.com/users/mcking65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcking65/subscriptions","organizations_url":"https://api.github.com/users/mcking65/orgs","repos_url":"https://api.github.com/users/mcking65/repos","events_url":"https://api.github.com/users/mcking65/events{/privacy}","received_events_url":"https://api.github.com/users/mcking65/received_events","type":"User","site_admin":false},"open_issues":151,"closed_issues":22,"state":"open","created_at":"2016-08-12T23:23:20Z","updated_at":"2018-12-19T10:10:41Z","due_on":"2018-12-13T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/w3c/aria-practices/pulls/950/commits","review_comments_url":"https://api.github.com/repos/w3c/aria-practices/pulls/950/comments","review_comment_url":"https://api.github.com/repos/w3c/aria-practices/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/aria-practices/issues/950/comments","statuses_url":"https://api.github.com/repos/w3c/aria-practices/statuses/ad98f19342507b6a23379567b1b730f35b8d99d7","head":{"label":"w3c:issue541-toolbar-redesign","ref":"issue541-toolbar-redesign","sha":"ad98f19342507b6a23379567b1b730f35b8d99d7","user":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":55698731,"node_id":"MDEwOlJlcG9zaXRvcnk1NTY5ODczMQ==","name":"aria-practices","full_name":"w3c/aria-practices","private":false,"owner":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/w3c/aria-practices","description":"WAI-ARIA Authoring Practices, maintained by ARIA WG https://www.w3.org/WAI/ARIA/","fork":false,"url":"https://api.github.com/repos/w3c/aria-practices","forks_url":"https://api.github.com/repos/w3c/aria-practices/forks","keys_url":"https://api.github.com/repos/w3c/aria-practices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/aria-practices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/aria-practices/teams","hooks_url":"https://api.github.com/repos/w3c/aria-practices/hooks","issue_events_url":"https://api.github.com/repos/w3c/aria-practices/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/aria-practices/events","assignees_url":"https://api.github.com/repos/w3c/aria-practices/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/aria-practices/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/aria-practices/tags","blobs_url":"https://api.github.com/repos/w3c/aria-practices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/aria-practices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/aria-practices/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/aria-practices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/aria-practices/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/aria-practices/languages","stargazers_url":"https://api.github.com/repos/w3c/aria-practices/stargazers","contributors_url":"https://api.github.com/repos/w3c/aria-practices/contributors","subscribers_url":"https://api.github.com/repos/w3c/aria-practices/subscribers","subscription_url":"https://api.github.com/repos/w3c/aria-practices/subscription","commits_url":"https://api.github.com/repos/w3c/aria-practices/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/aria-practices/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/aria-practices/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/aria-practices/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/aria-practices/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/aria-practices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/aria-practices/merges","archive_url":"https://api.github.com/repos/w3c/aria-practices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/aria-practices/downloads","issues_url":"https://api.github.com/repos/w3c/aria-practices/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/aria-practices/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/aria-practices/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/aria-practices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/aria-practices/labels{/name}","releases_url":"https://api.github.com/repos/w3c/aria-practices/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/aria-practices/deployments","created_at":"2016-04-07T13:55:12Z","updated_at":"2018-12-18T20:20:05Z","pushed_at":"2018-12-19T10:17:24Z","git_url":"git://github.com/w3c/aria-practices.git","ssh_url":"git@github.com:w3c/aria-practices.git","clone_url":"https://github.com/w3c/aria-practices.git","svn_url":"https://github.com/w3c/aria-practices","homepage":"https://w3c.github.io/aria-practices/","size":13367,"stargazers_count":300,"watchers_count":300,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":236,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":72,"open_issues":236,"watchers":300,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"1a6df756896c0d54fe6fda69234f8923dadc316d","user":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":55698731,"node_id":"MDEwOlJlcG9zaXRvcnk1NTY5ODczMQ==","name":"aria-practices","full_name":"w3c/aria-practices","private":false,"owner":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/w3c/aria-practices","description":"WAI-ARIA Authoring Practices, maintained by ARIA WG https://www.w3.org/WAI/ARIA/","fork":false,"url":"https://api.github.com/repos/w3c/aria-practices","forks_url":"https://api.github.com/repos/w3c/aria-practices/forks","keys_url":"https://api.github.com/repos/w3c/aria-practices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/aria-practices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/aria-practices/teams","hooks_url":"https://api.github.com/repos/w3c/aria-practices/hooks","issue_events_url":"https://api.github.com/repos/w3c/aria-practices/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/aria-practices/events","assignees_url":"https://api.github.com/repos/w3c/aria-practices/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/aria-practices/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/aria-practices/tags","blobs_url":"https://api.github.com/repos/w3c/aria-practices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/aria-practices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/aria-practices/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/aria-practices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/aria-practices/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/aria-practices/languages","stargazers_url":"https://api.github.com/repos/w3c/aria-practices/stargazers","contributors_url":"https://api.github.com/repos/w3c/aria-practices/contributors","subscribers_url":"https://api.github.com/repos/w3c/aria-practices/subscribers","subscription_url":"https://api.github.com/repos/w3c/aria-practices/subscription","commits_url":"https://api.github.com/repos/w3c/aria-practices/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/aria-practices/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/aria-practices/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/aria-practices/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/aria-practices/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/aria-practices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/aria-practices/merges","archive_url":"https://api.github.com/repos/w3c/aria-practices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/aria-practices/downloads","issues_url":"https://api.github.com/repos/w3c/aria-practices/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/aria-practices/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/aria-practices/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/aria-practices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/aria-practices/labels{/name}","releases_url":"https://api.github.com/repos/w3c/aria-practices/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/aria-practices/deployments","created_at":"2016-04-07T13:55:12Z","updated_at":"2018-12-18T20:20:05Z","pushed_at":"2018-12-19T10:17:24Z","git_url":"git://github.com/w3c/aria-practices.git","ssh_url":"git@github.com:w3c/aria-practices.git","clone_url":"https://github.com/w3c/aria-practices.git","svn_url":"https://github.com/w3c/aria-practices","homepage":"https://w3c.github.io/aria-practices/","size":13367,"stargazers_count":300,"watchers_count":300,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":236,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":72,"open_issues":236,"watchers":300,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/aria-practices/pulls/950"},"html":{"href":"https://github.com/w3c/aria-practices/pull/950"},"issue":{"href":"https://api.github.com/repos/w3c/aria-practices/issues/950"},"comments":{"href":"https://api.github.com/repos/w3c/aria-practices/issues/950/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/aria-practices/pulls/950/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/aria-practices/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/aria-practices/pulls/950/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/aria-practices/statuses/ad98f19342507b6a23379567b1b730f35b8d99d7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mcking65"}}