{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments/179634422","pull_request_review_id":109917211,"id":179634422,"diff_hunk":"@@ -151,10 +151,26 @@ def TensorBoardWSGIApp(logdir, plugins, multiplexer, reload_interval,\n     ValueError: If something is wrong with the plugin configuration.\n   \"\"\"\n   path_to_run = parse_event_files_spec(logdir)\n+  thread_name = 'Multiplexer Reloader'","path":"tensorboard/backend/application.py","position":4,"original_position":4,"commit_id":"bfe1cca3d75ed0e8d21a7aa36d1c40df72da6713","original_commit_id":"bfe1cca3d75ed0e8d21a7aa36d1c40df72da6713","user":{"login":"nfelt","id":710113,"avatar_url":"https://avatars0.githubusercontent.com/u/710113?v=4","gravatar_id":"","url":"https://api.github.com/users/nfelt","html_url":"https://github.com/nfelt","followers_url":"https://api.github.com/users/nfelt/followers","following_url":"https://api.github.com/users/nfelt/following{/other_user}","gists_url":"https://api.github.com/users/nfelt/gists{/gist_id}","starred_url":"https://api.github.com/users/nfelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfelt/subscriptions","organizations_url":"https://api.github.com/users/nfelt/orgs","repos_url":"https://api.github.com/users/nfelt/repos","events_url":"https://api.github.com/users/nfelt/events{/privacy}","received_events_url":"https://api.github.com/users/nfelt/received_events","type":"User","site_admin":false},"body":"nit, but I think just 'Reloader' was probably enough (or even 'Reload') - this gets printed in every single log line from this thread, so probably best to keep it succinct.","created_at":"2018-04-06T00:22:26Z","updated_at":"2018-04-06T00:29:58Z","html_url":"https://github.com/tensorflow/tensorboard/pull/1105#discussion_r179634422","pull_request_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1105","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments/179634422"},"html":{"href":"https://github.com/tensorflow/tensorboard/pull/1105#discussion_r179634422"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1105"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1105","id":179828125,"html_url":"https://github.com/tensorflow/tensorboard/pull/1105","diff_url":"https://github.com/tensorflow/tensorboard/pull/1105.diff","patch_url":"https://github.com/tensorflow/tensorboard/pull/1105.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/1105","number":1105,"state":"open","locked":false,"title":"Always reload multiplexer on thread.","user":{"login":"chihuahua","id":4221553,"avatar_url":"https://avatars0.githubusercontent.com/u/4221553?v=4","gravatar_id":"","url":"https://api.github.com/users/chihuahua","html_url":"https://github.com/chihuahua","followers_url":"https://api.github.com/users/chihuahua/followers","following_url":"https://api.github.com/users/chihuahua/following{/other_user}","gists_url":"https://api.github.com/users/chihuahua/gists{/gist_id}","starred_url":"https://api.github.com/users/chihuahua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chihuahua/subscriptions","organizations_url":"https://api.github.com/users/chihuahua/orgs","repos_url":"https://api.github.com/users/chihuahua/repos","events_url":"https://api.github.com/users/chihuahua/events{/privacy}","received_events_url":"https://api.github.com/users/chihuahua/received_events","type":"User","site_admin":false},"body":"Previously, when the `reload_interval` flag was set to 0, TensorBoard\r\nwould reload the multiplexer once at the beginning of TensorBoard\r\nstartup on the main thread. Now, TensorBoard performs that reload on a\r\nseparate daemon thread. As comments note, this behavior prevents joining\r\nthreads that start while TensorBoard is reloading from blocking\r\nTensorBoard from quitting after the user hits Ctrl + C.\r\n\r\nThis PR introduces a change in behavior. When the user starts a\r\nTensorBoard with `reload_interval` set to 0 (no continuous reloading),\r\nTensorBoard server starts up before all data is read from disk.\r\nPreviously, TensorBoard would read all events files (reload\r\nmultiplexers) before starting its server.\r\n\r\nTest Plan:\r\n\r\nStart TensorBoard pointed at logs from mnist_with_summaries.py with the\r\nreload interval set to 0. Verify that TensorBoard starts up successfully\r\nand that the multiplexer only reloads once in the beginning.\r\n\r\nStart TensorBoard with the reload interval set to 5 seconds. Verify that\r\nTensorBoard starts up successfully and that the multiplexer continuously\r\nreloads with a 5-second interval in between reloads.","created_at":"2018-04-06T00:14:16Z","updated_at":"2018-04-06T00:29:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a80340d5895a4e8f8e31117a86198520e998922","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jart","id":49262,"avatar_url":"https://avatars1.githubusercontent.com/u/49262?v=4","gravatar_id":"","url":"https://api.github.com/users/jart","html_url":"https://github.com/jart","followers_url":"https://api.github.com/users/jart/followers","following_url":"https://api.github.com/users/jart/following{/other_user}","gists_url":"https://api.github.com/users/jart/gists{/gist_id}","starred_url":"https://api.github.com/users/jart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jart/subscriptions","organizations_url":"https://api.github.com/users/jart/orgs","repos_url":"https://api.github.com/users/jart/repos","events_url":"https://api.github.com/users/jart/events{/privacy}","received_events_url":"https://api.github.com/users/jart/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":628257156,"url":"https://api.github.com/repos/tensorflow/tensorboard/labels/core:backend","name":"core:backend","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1105/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1105/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/1105/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/bfe1cca3d75ed0e8d21a7aa36d1c40df72da6713","head":{"label":"chihuahua:multiplexer","ref":"multiplexer","sha":"bfe1cca3d75ed0e8d21a7aa36d1c40df72da6713","user":{"login":"chihuahua","id":4221553,"avatar_url":"https://avatars0.githubusercontent.com/u/4221553?v=4","gravatar_id":"","url":"https://api.github.com/users/chihuahua","html_url":"https://github.com/chihuahua","followers_url":"https://api.github.com/users/chihuahua/followers","following_url":"https://api.github.com/users/chihuahua/following{/other_user}","gists_url":"https://api.github.com/users/chihuahua/gists{/gist_id}","starred_url":"https://api.github.com/users/chihuahua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chihuahua/subscriptions","organizations_url":"https://api.github.com/users/chihuahua/orgs","repos_url":"https://api.github.com/users/chihuahua/repos","events_url":"https://api.github.com/users/chihuahua/events{/privacy}","received_events_url":"https://api.github.com/users/chihuahua/received_events","type":"User","site_admin":false},"repo":{"id":101942706,"name":"tensorboard","full_name":"chihuahua/tensorboard","owner":{"login":"chihuahua","id":4221553,"avatar_url":"https://avatars0.githubusercontent.com/u/4221553?v=4","gravatar_id":"","url":"https://api.github.com/users/chihuahua","html_url":"https://github.com/chihuahua","followers_url":"https://api.github.com/users/chihuahua/followers","following_url":"https://api.github.com/users/chihuahua/following{/other_user}","gists_url":"https://api.github.com/users/chihuahua/gists{/gist_id}","starred_url":"https://api.github.com/users/chihuahua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chihuahua/subscriptions","organizations_url":"https://api.github.com/users/chihuahua/orgs","repos_url":"https://api.github.com/users/chihuahua/repos","events_url":"https://api.github.com/users/chihuahua/events{/privacy}","received_events_url":"https://api.github.com/users/chihuahua/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chihuahua/tensorboard","description":"TensorFlow's Visualization Toolkit","fork":true,"url":"https://api.github.com/repos/chihuahua/tensorboard","forks_url":"https://api.github.com/repos/chihuahua/tensorboard/forks","keys_url":"https://api.github.com/repos/chihuahua/tensorboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chihuahua/tensorboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chihuahua/tensorboard/teams","hooks_url":"https://api.github.com/repos/chihuahua/tensorboard/hooks","issue_events_url":"https://api.github.com/repos/chihuahua/tensorboard/issues/events{/number}","events_url":"https://api.github.com/repos/chihuahua/tensorboard/events","assignees_url":"https://api.github.com/repos/chihuahua/tensorboard/assignees{/user}","branches_url":"https://api.github.com/repos/chihuahua/tensorboard/branches{/branch}","tags_url":"https://api.github.com/repos/chihuahua/tensorboard/tags","blobs_url":"https://api.github.com/repos/chihuahua/tensorboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chihuahua/tensorboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chihuahua/tensorboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/chihuahua/tensorboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chihuahua/tensorboard/statuses/{sha}","languages_url":"https://api.github.com/repos/chihuahua/tensorboard/languages","stargazers_url":"https://api.github.com/repos/chihuahua/tensorboard/stargazers","contributors_url":"https://api.github.com/repos/chihuahua/tensorboard/contributors","subscribers_url":"https://api.github.com/repos/chihuahua/tensorboard/subscribers","subscription_url":"https://api.github.com/repos/chihuahua/tensorboard/subscription","commits_url":"https://api.github.com/repos/chihuahua/tensorboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/chihuahua/tensorboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/chihuahua/tensorboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/chihuahua/tensorboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/chihuahua/tensorboard/contents/{+path}","compare_url":"https://api.github.com/repos/chihuahua/tensorboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chihuahua/tensorboard/merges","archive_url":"https://api.github.com/repos/chihuahua/tensorboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chihuahua/tensorboard/downloads","issues_url":"https://api.github.com/repos/chihuahua/tensorboard/issues{/number}","pulls_url":"https://api.github.com/repos/chihuahua/tensorboard/pulls{/number}","milestones_url":"https://api.github.com/repos/chihuahua/tensorboard/milestones{/number}","notifications_url":"https://api.github.com/repos/chihuahua/tensorboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chihuahua/tensorboard/labels{/name}","releases_url":"https://api.github.com/repos/chihuahua/tensorboard/releases{/id}","deployments_url":"https://api.github.com/repos/chihuahua/tensorboard/deployments","created_at":"2017-08-31T00:50:10Z","updated_at":"2018-04-04T19:50:02Z","pushed_at":"2018-04-06T00:15:35Z","git_url":"git://github.com/chihuahua/tensorboard.git","ssh_url":"git@github.com:chihuahua/tensorboard.git","clone_url":"https://github.com/chihuahua/tensorboard.git","svn_url":"https://github.com/chihuahua/tensorboard","homepage":null,"size":11925,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"8eaf24e79a2f2de7c324034e73c990af20ec5979","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":91379993,"name":"tensorboard","full_name":"tensorflow/tensorboard","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorboard","description":"TensorFlow's Visualization Toolkit","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorboard","forks_url":"https://api.github.com/repos/tensorflow/tensorboard/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorboard/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorboard/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorboard/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorboard/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorboard/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorboard/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorboard/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorboard/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorboard/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorboard/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorboard/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorboard/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorboard/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorboard/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorboard/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorboard/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorboard/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorboard/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorboard/deployments","created_at":"2017-05-15T20:08:07Z","updated_at":"2018-04-06T00:04:24Z","pushed_at":"2018-04-06T00:15:37Z","git_url":"git://github.com/tensorflow/tensorboard.git","ssh_url":"git@github.com:tensorflow/tensorboard.git","clone_url":"https://github.com/tensorflow/tensorboard.git","svn_url":"https://github.com/tensorflow/tensorboard","homepage":null,"size":11371,"stargazers_count":1494,"watchers_count":1494,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":360,"mirror_url":null,"archived":false,"open_issues_count":205,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":360,"open_issues":205,"watchers":1494,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1105"},"html":{"href":"https://github.com/tensorflow/tensorboard/pull/1105"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorboard/issues/1105"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorboard/issues/1105/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1105/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1105/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorboard/statuses/bfe1cca3d75ed0e8d21a7aa36d1c40df72da6713"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nfelt"}}