{"action":"closed","number":222,"pull_request":{"url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/222","id":206380682,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzgwNjgy","html_url":"https://github.com/OpenSTFoundation/openst-protocol/pull/222","diff_url":"https://github.com/OpenSTFoundation/openst-protocol/pull/222.diff","patch_url":"https://github.com/OpenSTFoundation/openst-protocol/pull/222.patch","issue_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/222","number":222,"state":"closed","locked":false,"title":"Setup linecoverage Solcover for OpenST-Procotol","user":{"login":"noslav","id":26611201,"node_id":"MDQ6VXNlcjI2NjExMjAx","avatar_url":"https://avatars3.githubusercontent.com/u/26611201?v=4","gravatar_id":"","url":"https://api.github.com/users/noslav","html_url":"https://github.com/noslav","followers_url":"https://api.github.com/users/noslav/followers","following_url":"https://api.github.com/users/noslav/following{/other_user}","gists_url":"https://api.github.com/users/noslav/gists{/gist_id}","starred_url":"https://api.github.com/users/noslav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noslav/subscriptions","organizations_url":"https://api.github.com/users/noslav/orgs","repos_url":"https://api.github.com/users/noslav/repos","events_url":"https://api.github.com/users/noslav/events{/privacy}","received_events_url":"https://api.github.com/users/noslav/received_events","type":"User","site_admin":false},"body":"* [Solcover](https://github.com/sc-forks/solidity-coverage) is a line coverage tool widely used by the community which uses [instrumentation](https://blog.colony.io/code-coverage-for-solidity-eecfa88668c2) to inject events into contracts with truffle to test if each line is accounted for within truffle tests or not. This PR introduces line coverage with a report generation tool [coveralls](https://coveralls.io/github/sc-forks/metacoin) for the OpenST-Protocol separate from truffle test.\r\n* Adds\r\n1. solidity-coverage ^0.5.5 as a dev dependency in package.json\r\n2.  coveralls ^3.0.2 as a dev dependency\r\n3. .solcover.js config file \r\n* Modifies \r\n1. travis.yml config file\r\n2. .ganacheRpc in tools/\r\n3. .truffle.js config file\r\n* Removes \r\n1. Hard coded contract deployment gas values needed from tests (as solcover estimates higher usage)\r\n2. One test to account for stack-too-deep error (still needs a fix) line 377 OpenSTValue.sol","created_at":"2018-08-06T12:20:01Z","updated_at":"2018-08-06T15:35:32Z","closed_at":"2018-08-06T15:35:32Z","merged_at":null,"merge_commit_sha":"370c9845e8fac36234436c1584b92205aacd60bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/222/commits","review_comments_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/222/comments","review_comment_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/222/comments","statuses_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/statuses/40016ecc832c082503ac9de8474981b32e3a2ca5","head":{"label":"OpenSTFoundation:pranay/mosa-153SolCover","ref":"pranay/mosa-153SolCover","sha":"40016ecc832c082503ac9de8474981b32e3a2ca5","user":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":108171643,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgxNzE2NDM=","name":"openst-protocol","full_name":"OpenSTFoundation/openst-protocol","owner":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSTFoundation/openst-protocol","description":"OpenST Protocol allows to stake Simple Token on Ethereum to mint branded utility tokens","fork":false,"url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol","forks_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/forks","keys_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/teams","hooks_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/hooks","issue_events_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/events","assignees_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/tags","blobs_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/languages","stargazers_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/stargazers","contributors_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/contributors","subscribers_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/subscribers","subscription_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/subscription","commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/merges","archive_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/downloads","issues_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/labels{/name}","releases_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/deployments","created_at":"2017-10-24T19:09:30Z","updated_at":"2018-08-04T15:06:35Z","pushed_at":"2018-08-06T14:50:39Z","git_url":"git://github.com/OpenSTFoundation/openst-protocol.git","ssh_url":"git@github.com:OpenSTFoundation/openst-protocol.git","clone_url":"https://github.com/OpenSTFoundation/openst-protocol.git","svn_url":"https://github.com/OpenSTFoundation/openst-protocol","homepage":"https://simpletoken.org","size":4134,"stargazers_count":66,"watchers_count":66,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":14,"watchers":66,"default_branch":"develop"}},"base":{"label":"OpenSTFoundation:develop","ref":"develop","sha":"936e6cce76827a8f29fd84b3e185c9a139c85f30","user":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":108171643,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgxNzE2NDM=","name":"openst-protocol","full_name":"OpenSTFoundation/openst-protocol","owner":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSTFoundation/openst-protocol","description":"OpenST Protocol allows to stake Simple Token on Ethereum to mint branded utility tokens","fork":false,"url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol","forks_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/forks","keys_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/teams","hooks_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/hooks","issue_events_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/events","assignees_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/tags","blobs_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/languages","stargazers_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/stargazers","contributors_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/contributors","subscribers_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/subscribers","subscription_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/subscription","commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/merges","archive_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/downloads","issues_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/labels{/name}","releases_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/deployments","created_at":"2017-10-24T19:09:30Z","updated_at":"2018-08-04T15:06:35Z","pushed_at":"2018-08-06T14:50:39Z","git_url":"git://github.com/OpenSTFoundation/openst-protocol.git","ssh_url":"git@github.com:OpenSTFoundation/openst-protocol.git","clone_url":"https://github.com/OpenSTFoundation/openst-protocol.git","svn_url":"https://github.com/OpenSTFoundation/openst-protocol","homepage":"https://simpletoken.org","size":4134,"stargazers_count":66,"watchers_count":66,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":14,"watchers":66,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/222"},"html":{"href":"https://github.com/OpenSTFoundation/openst-protocol/pull/222"},"issue":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/222"},"comments":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/statuses/40016ecc832c082503ac9de8474981b32e3a2ca5"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":38,"deletions":24,"changed_files":16}}
{"actor":{"display_login":"noslav"}}