{"action":"created","comment":{"url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/comments/216146498","pull_request_review_id":153570496,"id":216146498,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjE0NjQ5OA==","diff_hunk":"@@ -46,6 +46,10 @@ Do not disable them. If you have disabled them, go to `File` > `Settings` > `Plu\n . Click `OK` to accept the default settings\n . Open a console and run the command `gradlew processResources` (Mac/Linux: `./gradlew processResources`). It should finish with the `BUILD SUCCESSFUL` message. +\n This will generate all resources required by the application and tests.\n+. Open the `XmlAdaptedPerson` and `MainWindow` file and check for any code errors","path":"docs/DeveloperGuide.adoc","position":4,"original_position":4,"commit_id":"98f43171e83a081b68ebeda6ef40c917d49fe153","original_commit_id":"98f43171e83a081b68ebeda6ef40c917d49fe153","user":{"login":"pyokagan","id":109479,"node_id":"MDQ6VXNlcjEwOTQ3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/109479?v=4","gravatar_id":"","url":"https://api.github.com/users/pyokagan","html_url":"https://github.com/pyokagan","followers_url":"https://api.github.com/users/pyokagan/followers","following_url":"https://api.github.com/users/pyokagan/following{/other_user}","gists_url":"https://api.github.com/users/pyokagan/gists{/gist_id}","starred_url":"https://api.github.com/users/pyokagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyokagan/subscriptions","organizations_url":"https://api.github.com/users/pyokagan/orgs","repos_url":"https://api.github.com/users/pyokagan/repos","events_url":"https://api.github.com/users/pyokagan/events{/privacy}","received_events_url":"https://api.github.com/users/pyokagan/received_events","type":"User","site_admin":false},"body":"Should be:\r\n\r\n```\r\nOpen `XmlAdaptedPerson` and `MainWindow`, and check for any code errors\r\n```\r\n\r\n(Since `XmlAdaptedPerson` and `MainWindow` are names. Similar example on why the original sounds wrong: `Talk to the Bob and Jill person`.)\r\n\r\nIf you want to make it clear they are files, then can write:\r\n\r\n```\r\nOpen `XmlAdaptedPerson.java` and `MainWindow.java` and check for any code errors.\r\n```\r\n\r\nWe also have `repoURL` defined here as well, so you can use:\r\n\r\n```\r\nOpen link:{repoURL}/src/main/java/seedu/address/storage/XmlAdaptedPerson.java[`XmlAdaptedPerson.java`] and link:{repoURL}/src/main/java/seedu/address/ui/MainWindow.java[`MainWindow.java`] and check for any code errors.\r\n```\r\n","created_at":"2018-09-09T03:52:57Z","updated_at":"2018-09-09T03:53:05Z","html_url":"https://github.com/se-edu/addressbook-level4/pull/911#discussion_r216146498","pull_request_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/911","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/comments/216146498"},"html":{"href":"https://github.com/se-edu/addressbook-level4/pull/911#discussion_r216146498"},"pull_request":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/911"}}},"pull_request":{"url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/911","id":214046171,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDQ2MTcx","html_url":"https://github.com/se-edu/addressbook-level4/pull/911","diff_url":"https://github.com/se-edu/addressbook-level4/pull/911.diff","patch_url":"https://github.com/se-edu/addressbook-level4/pull/911.patch","issue_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/911","number":911,"state":"open","locked":false,"title":"DeveloperGuide: update \"Setting up\" section","user":{"login":"yamidark","id":18352498,"node_id":"MDQ6VXNlcjE4MzUyNDk4","avatar_url":"https://avatars1.githubusercontent.com/u/18352498?v=4","gravatar_id":"","url":"https://api.github.com/users/yamidark","html_url":"https://github.com/yamidark","followers_url":"https://api.github.com/users/yamidark/followers","following_url":"https://api.github.com/users/yamidark/following{/other_user}","gists_url":"https://api.github.com/users/yamidark/gists{/gist_id}","starred_url":"https://api.github.com/users/yamidark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamidark/subscriptions","organizations_url":"https://api.github.com/users/yamidark/orgs","repos_url":"https://api.github.com/users/yamidark/repos","events_url":"https://api.github.com/users/yamidark/events{/privacy}","received_events_url":"https://api.github.com/users/yamidark/received_events","type":"User","site_admin":false},"body":"```\r\nDue to an ongoing issue[1] with some of the newer versions of IntelliJ,\r\nthe IDE may report code errors for JAXB APIs, although the code can be\r\nbuild and run successfully since we have already imported the\r\ndependencies through gradle.\r\n\r\nThis may cause confusion amongst users.\r\n\r\nLet's update the \"Setting up\" section to address this issue, and how\r\nto resolve it.\r\n\r\n[1]: https://youtrack.jetbrains.com/issue/IDEA-189060\r\n```","created_at":"2018-09-07T21:40:49Z","updated_at":"2018-09-09T03:53:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89e4ad3fe1b666c72a1118eb703e57b5d347dd41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":456150466,"node_id":"MDU6TGFiZWw0NTYxNTA0NjY=","url":"https://api.github.com/repos/se-edu/addressbook-level4/labels/s.ToReview","name":"s.ToReview","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/911/commits","review_comments_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/911/comments","review_comment_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/911/comments","statuses_url":"https://api.github.com/repos/se-edu/addressbook-level4/statuses/98f43171e83a081b68ebeda6ef40c917d49fe153","head":{"label":"yamidark:update-developer-guide","ref":"update-developer-guide","sha":"98f43171e83a081b68ebeda6ef40c917d49fe153","user":{"login":"yamidark","id":18352498,"node_id":"MDQ6VXNlcjE4MzUyNDk4","avatar_url":"https://avatars1.githubusercontent.com/u/18352498?v=4","gravatar_id":"","url":"https://api.github.com/users/yamidark","html_url":"https://github.com/yamidark","followers_url":"https://api.github.com/users/yamidark/followers","following_url":"https://api.github.com/users/yamidark/following{/other_user}","gists_url":"https://api.github.com/users/yamidark/gists{/gist_id}","starred_url":"https://api.github.com/users/yamidark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamidark/subscriptions","organizations_url":"https://api.github.com/users/yamidark/orgs","repos_url":"https://api.github.com/users/yamidark/repos","events_url":"https://api.github.com/users/yamidark/events{/privacy}","received_events_url":"https://api.github.com/users/yamidark/received_events","type":"User","site_admin":false},"repo":{"id":115731630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU3MzE2MzA=","name":"addressbook-level4","full_name":"yamidark/addressbook-level4","owner":{"login":"yamidark","id":18352498,"node_id":"MDQ6VXNlcjE4MzUyNDk4","avatar_url":"https://avatars1.githubusercontent.com/u/18352498?v=4","gravatar_id":"","url":"https://api.github.com/users/yamidark","html_url":"https://github.com/yamidark","followers_url":"https://api.github.com/users/yamidark/followers","following_url":"https://api.github.com/users/yamidark/following{/other_user}","gists_url":"https://api.github.com/users/yamidark/gists{/gist_id}","starred_url":"https://api.github.com/users/yamidark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamidark/subscriptions","organizations_url":"https://api.github.com/users/yamidark/orgs","repos_url":"https://api.github.com/users/yamidark/repos","events_url":"https://api.github.com/users/yamidark/events{/privacy}","received_events_url":"https://api.github.com/users/yamidark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yamidark/addressbook-level4","description":"Address Book sample application (Level 4)","fork":true,"url":"https://api.github.com/repos/yamidark/addressbook-level4","forks_url":"https://api.github.com/repos/yamidark/addressbook-level4/forks","keys_url":"https://api.github.com/repos/yamidark/addressbook-level4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yamidark/addressbook-level4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yamidark/addressbook-level4/teams","hooks_url":"https://api.github.com/repos/yamidark/addressbook-level4/hooks","issue_events_url":"https://api.github.com/repos/yamidark/addressbook-level4/issues/events{/number}","events_url":"https://api.github.com/repos/yamidark/addressbook-level4/events","assignees_url":"https://api.github.com/repos/yamidark/addressbook-level4/assignees{/user}","branches_url":"https://api.github.com/repos/yamidark/addressbook-level4/branches{/branch}","tags_url":"https://api.github.com/repos/yamidark/addressbook-level4/tags","blobs_url":"https://api.github.com/repos/yamidark/addressbook-level4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yamidark/addressbook-level4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yamidark/addressbook-level4/git/refs{/sha}","trees_url":"https://api.github.com/repos/yamidark/addressbook-level4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yamidark/addressbook-level4/statuses/{sha}","languages_url":"https://api.github.com/repos/yamidark/addressbook-level4/languages","stargazers_url":"https://api.github.com/repos/yamidark/addressbook-level4/stargazers","contributors_url":"https://api.github.com/repos/yamidark/addressbook-level4/contributors","subscribers_url":"https://api.github.com/repos/yamidark/addressbook-level4/subscribers","subscription_url":"https://api.github.com/repos/yamidark/addressbook-level4/subscription","commits_url":"https://api.github.com/repos/yamidark/addressbook-level4/commits{/sha}","git_commits_url":"https://api.github.com/repos/yamidark/addressbook-level4/git/commits{/sha}","comments_url":"https://api.github.com/repos/yamidark/addressbook-level4/comments{/number}","issue_comment_url":"https://api.github.com/repos/yamidark/addressbook-level4/issues/comments{/number}","contents_url":"https://api.github.com/repos/yamidark/addressbook-level4/contents/{+path}","compare_url":"https://api.github.com/repos/yamidark/addressbook-level4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yamidark/addressbook-level4/merges","archive_url":"https://api.github.com/repos/yamidark/addressbook-level4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yamidark/addressbook-level4/downloads","issues_url":"https://api.github.com/repos/yamidark/addressbook-level4/issues{/number}","pulls_url":"https://api.github.com/repos/yamidark/addressbook-level4/pulls{/number}","milestones_url":"https://api.github.com/repos/yamidark/addressbook-level4/milestones{/number}","notifications_url":"https://api.github.com/repos/yamidark/addressbook-level4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yamidark/addressbook-level4/labels{/name}","releases_url":"https://api.github.com/repos/yamidark/addressbook-level4/releases{/id}","deployments_url":"https://api.github.com/repos/yamidark/addressbook-level4/deployments","created_at":"2017-12-29T15:08:24Z","updated_at":"2018-09-02T12:19:26Z","pushed_at":"2018-09-08T16:15:43Z","git_url":"git://github.com/yamidark/addressbook-level4.git","ssh_url":"git@github.com:yamidark/addressbook-level4.git","clone_url":"https://github.com/yamidark/addressbook-level4.git","svn_url":"https://github.com/yamidark/addressbook-level4","homepage":"https://se-edu.github.io/addressbook-level4","size":9365,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"se-edu:master","ref":"master","sha":"4bc8fdce4ccffdd3cb9bc8cf6a6fde86338e4db5","user":{"login":"se-edu","id":20763652,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzYzNjUy","avatar_url":"https://avatars2.githubusercontent.com/u/20763652?v=4","gravatar_id":"","url":"https://api.github.com/users/se-edu","html_url":"https://github.com/se-edu","followers_url":"https://api.github.com/users/se-edu/followers","following_url":"https://api.github.com/users/se-edu/following{/other_user}","gists_url":"https://api.github.com/users/se-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/se-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/se-edu/subscriptions","organizations_url":"https://api.github.com/users/se-edu/orgs","repos_url":"https://api.github.com/users/se-edu/repos","events_url":"https://api.github.com/users/se-edu/events{/privacy}","received_events_url":"https://api.github.com/users/se-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":65120941,"node_id":"MDEwOlJlcG9zaXRvcnk2NTEyMDk0MQ==","name":"addressbook-level4","full_name":"se-edu/addressbook-level4","owner":{"login":"se-edu","id":20763652,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzYzNjUy","avatar_url":"https://avatars2.githubusercontent.com/u/20763652?v=4","gravatar_id":"","url":"https://api.github.com/users/se-edu","html_url":"https://github.com/se-edu","followers_url":"https://api.github.com/users/se-edu/followers","following_url":"https://api.github.com/users/se-edu/following{/other_user}","gists_url":"https://api.github.com/users/se-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/se-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/se-edu/subscriptions","organizations_url":"https://api.github.com/users/se-edu/orgs","repos_url":"https://api.github.com/users/se-edu/repos","events_url":"https://api.github.com/users/se-edu/events{/privacy}","received_events_url":"https://api.github.com/users/se-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/se-edu/addressbook-level4","description":":ab::four: Address Book sample application (Level 4)","fork":false,"url":"https://api.github.com/repos/se-edu/addressbook-level4","forks_url":"https://api.github.com/repos/se-edu/addressbook-level4/forks","keys_url":"https://api.github.com/repos/se-edu/addressbook-level4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/se-edu/addressbook-level4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/se-edu/addressbook-level4/teams","hooks_url":"https://api.github.com/repos/se-edu/addressbook-level4/hooks","issue_events_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/events{/number}","events_url":"https://api.github.com/repos/se-edu/addressbook-level4/events","assignees_url":"https://api.github.com/repos/se-edu/addressbook-level4/assignees{/user}","branches_url":"https://api.github.com/repos/se-edu/addressbook-level4/branches{/branch}","tags_url":"https://api.github.com/repos/se-edu/addressbook-level4/tags","blobs_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/refs{/sha}","trees_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/se-edu/addressbook-level4/statuses/{sha}","languages_url":"https://api.github.com/repos/se-edu/addressbook-level4/languages","stargazers_url":"https://api.github.com/repos/se-edu/addressbook-level4/stargazers","contributors_url":"https://api.github.com/repos/se-edu/addressbook-level4/contributors","subscribers_url":"https://api.github.com/repos/se-edu/addressbook-level4/subscribers","subscription_url":"https://api.github.com/repos/se-edu/addressbook-level4/subscription","commits_url":"https://api.github.com/repos/se-edu/addressbook-level4/commits{/sha}","git_commits_url":"https://api.github.com/repos/se-edu/addressbook-level4/git/commits{/sha}","comments_url":"https://api.github.com/repos/se-edu/addressbook-level4/comments{/number}","issue_comment_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/comments{/number}","contents_url":"https://api.github.com/repos/se-edu/addressbook-level4/contents/{+path}","compare_url":"https://api.github.com/repos/se-edu/addressbook-level4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/se-edu/addressbook-level4/merges","archive_url":"https://api.github.com/repos/se-edu/addressbook-level4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/se-edu/addressbook-level4/downloads","issues_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues{/number}","pulls_url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls{/number}","milestones_url":"https://api.github.com/repos/se-edu/addressbook-level4/milestones{/number}","notifications_url":"https://api.github.com/repos/se-edu/addressbook-level4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/se-edu/addressbook-level4/labels{/name}","releases_url":"https://api.github.com/repos/se-edu/addressbook-level4/releases{/id}","deployments_url":"https://api.github.com/repos/se-edu/addressbook-level4/deployments","created_at":"2016-08-07T07:17:26Z","updated_at":"2018-09-08T06:52:13Z","pushed_at":"2018-09-08T17:08:57Z","git_url":"git://github.com/se-edu/addressbook-level4.git","ssh_url":"git@github.com:se-edu/addressbook-level4.git","clone_url":"https://github.com/se-edu/addressbook-level4.git","svn_url":"https://github.com/se-edu/addressbook-level4","homepage":"https://se-edu.github.io/addressbook-level4","size":22800,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1211,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1211,"open_issues":67,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/911"},"html":{"href":"https://github.com/se-edu/addressbook-level4/pull/911"},"issue":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/issues/911"},"comments":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/issues/911/comments"},"review_comments":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/911/comments"},"review_comment":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/911/commits"},"statuses":{"href":"https://api.github.com/repos/se-edu/addressbook-level4/statuses/98f43171e83a081b68ebeda6ef40c917d49fe153"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pyokagan"}}