{"action":"closed","issue":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/2954","repository_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/2954/labels{/name}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/2954/comments","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/2954/events","html_url":"https://github.com/WikiWatershed/model-my-watershed/issues/2954","id":356916816,"node_id":"MDU6SXNzdWUzNTY5MTY4MTY=","number":2954,"title":"MapShed BMPs: Subbasin Results Affected","user":{"login":"rajadain","id":1430060,"node_id":"MDQ6VXNlcjE0MzAwNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1430060?v=4","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"labels":[{"id":362098529,"node_id":"MDU6TGFiZWwzNjIwOTg1Mjk=","url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels/MapShed","name":"MapShed","color":"1d76db","default":false},{"id":753848470,"node_id":"MDU6TGFiZWw3NTM4NDg0NzA=","url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels/Sub-basin%20Modeling","name":"Sub-basin Modeling","color":"84cae0","default":false},{"id":556091444,"node_id":"MDU6TGFiZWw1NTYwOTE0NDQ=","url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels/WPF","name":"WPF","color":"1d76db","default":false},{"id":203319891,"node_id":"MDU6TGFiZWwyMDMzMTk4OTE=","url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels/tested/verified","name":"tested/verified","color":"bfe5bf","default":false}],"state":"closed","locked":false,"assignee":{"login":"rajadain","id":1430060,"node_id":"MDQ6VXNlcjE0MzAwNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1430060?v=4","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"assignees":[{"login":"rajadain","id":1430060,"node_id":"MDQ6VXNlcjE0MzAwNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1430060?v=4","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/milestones/66","html_url":"https://github.com/WikiWatershed/model-my-watershed/milestone/66","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/milestones/66/labels","id":3084548,"node_id":"MDk6TWlsZXN0b25lMzA4NDU0OA==","number":66,"title":"1.24","description":null,"creator":{"login":"arottersman","id":7633670,"node_id":"MDQ6VXNlcjc2MzM2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/7633670?v=4","gravatar_id":"","url":"https://api.github.com/users/arottersman","html_url":"https://github.com/arottersman","followers_url":"https://api.github.com/users/arottersman/followers","following_url":"https://api.github.com/users/arottersman/following{/other_user}","gists_url":"https://api.github.com/users/arottersman/gists{/gist_id}","starred_url":"https://api.github.com/users/arottersman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arottersman/subscriptions","organizations_url":"https://api.github.com/users/arottersman/orgs","repos_url":"https://api.github.com/users/arottersman/repos","events_url":"https://api.github.com/users/arottersman/events{/privacy}","received_events_url":"https://api.github.com/users/arottersman/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":56,"state":"open","created_at":"2018-02-02T18:02:29Z","updated_at":"2018-11-01T19:53:49Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-09-04T18:01:57Z","updated_at":"2018-11-01T19:53:49Z","closed_at":"2018-11-01T19:53:49Z","author_association":"MEMBER","body":"Since subbasin doesn't support \"Low-Density Open Space\", which as of #2944  represents the NLCD 21 area of land previously assigned to \"Low-Density Mixed\", the final results are different:\r\n\r\nhttps://bl.ocks.org/rajadain/7f4a63d03623e334281e6fdac74b76ec\r\n\r\n![image](https://user-images.githubusercontent.com/1430060/45048731-a6f5df80-b04a-11e8-87f1-997be434c65f.png)\r\n\r\n(where the left results are of the same HUC-10 on production, and the right on my local with #2944 applied).\r\n\r\nFrom the notes in #2944:\r\n\r\n> This new value won't show up in Subbasin because SRAT doesn't have a key for this. If they ever add support, we'll have to add that mapping here:\r\n> \r\n> https://github.com/WikiWatershed/model-my-watershed/blob/5260b2e1fd7ce6dbc77e10dc4834b246e03513ff/src/mmw/mmw/settings/gwlfe_settings.py#L623-L638\r\n> \r\n> https://github.com/WikiWatershed/model-my-watershed/blob/5260b2e1fd7ce6dbc77e10dc4834b246e03513ff/src/mmw/mmw/settings/gwlfe_settings.py#L640-L656\r\n\r\nDiscuss with various parties what is the right solution to this issue."}}
{"actor":{"display_login":"caseycesari"}}