{"action":"created","comment":{"url":"https://api.github.com/repos/moby/moby/pulls/comments/188133913","pull_request_review_id":120050994,"id":188133913,"diff_hunk":"@@ -149,6 +150,9 @@ func (s *DockerSuite) TestLogsAPIUntilFutureFollow(c *check.C) {\n }\n \n func (s *DockerSuite) TestLogsAPIUntil(c *check.C) {\n+\tif versions.LessThan(testEnv.DaemonAPIVersion(), \"1.34\") {","path":"integration-cli/docker_api_logs_test.go","position":12,"original_position":12,"commit_id":"417b74f80399a7957f61b308457c3d205501d16a","original_commit_id":"417b74f80399a7957f61b308457c3d205501d16a","user":{"login":"AntaresS","id":25592824,"avatar_url":"https://avatars3.githubusercontent.com/u/25592824?v=4","gravatar_id":"","url":"https://api.github.com/users/AntaresS","html_url":"https://github.com/AntaresS","followers_url":"https://api.github.com/users/AntaresS/followers","following_url":"https://api.github.com/users/AntaresS/following{/other_user}","gists_url":"https://api.github.com/users/AntaresS/gists{/gist_id}","starred_url":"https://api.github.com/users/AntaresS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntaresS/subscriptions","organizations_url":"https://api.github.com/users/AntaresS/orgs","repos_url":"https://api.github.com/users/AntaresS/repos","events_url":"https://api.github.com/users/AntaresS/events{/privacy}","received_events_url":"https://api.github.com/users/AntaresS/received_events","type":"User","site_admin":false},"body":"Same as the reply above 😸 ","created_at":"2018-05-15T00:09:11Z","updated_at":"2018-05-15T00:09:11Z","html_url":"https://github.com/moby/moby/pull/37003#discussion_r188133913","pull_request_url":"https://api.github.com/repos/moby/moby/pulls/37003","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/comments/188133913"},"html":{"href":"https://github.com/moby/moby/pull/37003#discussion_r188133913"},"pull_request":{"href":"https://api.github.com/repos/moby/moby/pulls/37003"}},"in_reply_to_id":187969350},"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/37003","id":186104432,"html_url":"https://github.com/moby/moby/pull/37003","diff_url":"https://github.com/moby/moby/pull/37003.diff","patch_url":"https://github.com/moby/moby/pull/37003.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/37003","number":37003,"state":"open","locked":false,"title":"Fix integration tests and integration cli to run on older versions","user":{"login":"AntaresS","id":25592824,"avatar_url":"https://avatars3.githubusercontent.com/u/25592824?v=4","gravatar_id":"","url":"https://api.github.com/users/AntaresS","html_url":"https://github.com/AntaresS","followers_url":"https://api.github.com/users/AntaresS/followers","following_url":"https://api.github.com/users/AntaresS/following{/other_user}","gists_url":"https://api.github.com/users/AntaresS/gists{/gist_id}","starred_url":"https://api.github.com/users/AntaresS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntaresS/subscriptions","organizations_url":"https://api.github.com/users/AntaresS/orgs","repos_url":"https://api.github.com/users/AntaresS/repos","events_url":"https://api.github.com/users/AntaresS/events{/privacy}","received_events_url":"https://api.github.com/users/AntaresS/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/moby/moby/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\nFix `integration` tests and `integration-cli` tests to run on older versions (e.g. 17.06-ee) with @tiborvass \r\n\r\n**- How I did it**\r\nAdd version requirements in some failed tests and skip tests that are not runnable in older versions.\r\n\r\n**- How to verify it**\r\nRun the whole test suit accross a version/platform matix. \r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\nFixing failed `integration` and `integration-cli` tests against older engine versions. \r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n","created_at":"2018-05-04T21:07:58Z","updated_at":"2018-05-15T00:09:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24ba669534710e0c6baf032b3eea1604363f5554","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":275636077,"url":"https://api.github.com/repos/moby/moby/labels/area/testing","name":"area/testing","color":"fbca04","default":false},{"id":175375407,"url":"https://api.github.com/repos/moby/moby/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/37003/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/37003/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/37003/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/417b74f80399a7957f61b308457c3d205501d16a","head":{"label":"AntaresS:fix-integration-cli-for-e2e","ref":"fix-integration-cli-for-e2e","sha":"417b74f80399a7957f61b308457c3d205501d16a","user":{"login":"AntaresS","id":25592824,"avatar_url":"https://avatars3.githubusercontent.com/u/25592824?v=4","gravatar_id":"","url":"https://api.github.com/users/AntaresS","html_url":"https://github.com/AntaresS","followers_url":"https://api.github.com/users/AntaresS/followers","following_url":"https://api.github.com/users/AntaresS/following{/other_user}","gists_url":"https://api.github.com/users/AntaresS/gists{/gist_id}","starred_url":"https://api.github.com/users/AntaresS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntaresS/subscriptions","organizations_url":"https://api.github.com/users/AntaresS/orgs","repos_url":"https://api.github.com/users/AntaresS/repos","events_url":"https://api.github.com/users/AntaresS/events{/privacy}","received_events_url":"https://api.github.com/users/AntaresS/received_events","type":"User","site_admin":false},"repo":{"id":129007098,"name":"moby","full_name":"AntaresS/moby","owner":{"login":"AntaresS","id":25592824,"avatar_url":"https://avatars3.githubusercontent.com/u/25592824?v=4","gravatar_id":"","url":"https://api.github.com/users/AntaresS","html_url":"https://github.com/AntaresS","followers_url":"https://api.github.com/users/AntaresS/followers","following_url":"https://api.github.com/users/AntaresS/following{/other_user}","gists_url":"https://api.github.com/users/AntaresS/gists{/gist_id}","starred_url":"https://api.github.com/users/AntaresS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntaresS/subscriptions","organizations_url":"https://api.github.com/users/AntaresS/orgs","repos_url":"https://api.github.com/users/AntaresS/repos","events_url":"https://api.github.com/users/AntaresS/events{/privacy}","received_events_url":"https://api.github.com/users/AntaresS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AntaresS/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":true,"url":"https://api.github.com/repos/AntaresS/moby","forks_url":"https://api.github.com/repos/AntaresS/moby/forks","keys_url":"https://api.github.com/repos/AntaresS/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AntaresS/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AntaresS/moby/teams","hooks_url":"https://api.github.com/repos/AntaresS/moby/hooks","issue_events_url":"https://api.github.com/repos/AntaresS/moby/issues/events{/number}","events_url":"https://api.github.com/repos/AntaresS/moby/events","assignees_url":"https://api.github.com/repos/AntaresS/moby/assignees{/user}","branches_url":"https://api.github.com/repos/AntaresS/moby/branches{/branch}","tags_url":"https://api.github.com/repos/AntaresS/moby/tags","blobs_url":"https://api.github.com/repos/AntaresS/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AntaresS/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AntaresS/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/AntaresS/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AntaresS/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/AntaresS/moby/languages","stargazers_url":"https://api.github.com/repos/AntaresS/moby/stargazers","contributors_url":"https://api.github.com/repos/AntaresS/moby/contributors","subscribers_url":"https://api.github.com/repos/AntaresS/moby/subscribers","subscription_url":"https://api.github.com/repos/AntaresS/moby/subscription","commits_url":"https://api.github.com/repos/AntaresS/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/AntaresS/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/AntaresS/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/AntaresS/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/AntaresS/moby/contents/{+path}","compare_url":"https://api.github.com/repos/AntaresS/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AntaresS/moby/merges","archive_url":"https://api.github.com/repos/AntaresS/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AntaresS/moby/downloads","issues_url":"https://api.github.com/repos/AntaresS/moby/issues{/number}","pulls_url":"https://api.github.com/repos/AntaresS/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/AntaresS/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/AntaresS/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AntaresS/moby/labels{/name}","releases_url":"https://api.github.com/repos/AntaresS/moby/releases{/id}","deployments_url":"https://api.github.com/repos/AntaresS/moby/deployments","created_at":"2018-04-10T23:36:59Z","updated_at":"2018-04-24T20:57:55Z","pushed_at":"2018-05-12T05:55:19Z","git_url":"git://github.com/AntaresS/moby.git","ssh_url":"git@github.com:AntaresS/moby.git","clone_url":"https://github.com/AntaresS/moby.git","svn_url":"https://github.com/AntaresS/moby","homepage":"https://mobyproject.org/","size":133944,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"38162e96552bd30e510e355cd44d801f53bac5ae","user":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"moby","full_name":"moby/moby","owner":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2018-05-14T21:50:41Z","pushed_at":"2018-05-14T22:50:47Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":133978,"stargazers_count":48886,"watchers_count":48886,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14323,"mirror_url":null,"archived":false,"open_issues_count":3187,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14323,"open_issues":3187,"watchers":48886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/37003"},"html":{"href":"https://github.com/moby/moby/pull/37003"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/37003"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/37003/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/37003/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/37003/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/417b74f80399a7957f61b308457c3d205501d16a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AntaresS"}}