{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/kvproto/pulls/comments/218010945","pull_request_review_id":155852860,"id":218010945,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODAxMDk0NQ==","diff_hunk":"@@ -54,4 +54,74 @@ service Tikv {\n     // transaction debugger commands.\n     rpc MvccGetByKey(kvrpcpb.MvccGetByKeyRequest) returns (kvrpcpb.MvccGetByKeyResponse) {}\n     rpc MvccGetByStartTs(kvrpcpb.MvccGetByStartTsRequest) returns (kvrpcpb.MvccGetByStartTsResponse) {}\n+\n+    rpc SuperBatch(stream SuperBatchRequest) returns (stream SuperBatchResponse) {}\n+}\n+\n+message SuperBatchRequest {\n+    repeated Request requests = 1;\n+    repeated uint64 request_ids = 2;","path":"proto/tikvpb.proto","position":10,"original_position":10,"commit_id":"d0a38130f70ed8015a427f3aee654ef4a0181046","original_commit_id":"17d89d6a0fcb014a4df33ef0e043c469ca5fba54","user":{"login":"hicqu","id":8407317,"node_id":"MDQ6VXNlcjg0MDczMTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8407317?v=4","gravatar_id":"","url":"https://api.github.com/users/hicqu","html_url":"https://github.com/hicqu","followers_url":"https://api.github.com/users/hicqu/followers","following_url":"https://api.github.com/users/hicqu/following{/other_user}","gists_url":"https://api.github.com/users/hicqu/gists{/gist_id}","starred_url":"https://api.github.com/users/hicqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hicqu/subscriptions","organizations_url":"https://api.github.com/users/hicqu/orgs","repos_url":"https://api.github.com/users/hicqu/repos","events_url":"https://api.github.com/users/hicqu/events{/privacy}","received_events_url":"https://api.github.com/users/hicqu/received_events","type":"User","site_admin":false},"body":"Really? I think seperating them can make the change minimum.","created_at":"2018-09-17T09:59:01Z","updated_at":"2018-09-17T09:59:01Z","html_url":"https://github.com/pingcap/kvproto/pull/294#discussion_r218010945","pull_request_url":"https://api.github.com/repos/pingcap/kvproto/pulls/294","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pingcap/kvproto/pulls/comments/218010945"},"html":{"href":"https://github.com/pingcap/kvproto/pull/294#discussion_r218010945"},"pull_request":{"href":"https://api.github.com/repos/pingcap/kvproto/pulls/294"}},"in_reply_to_id":217952763},"pull_request":{"url":"https://api.github.com/repos/pingcap/kvproto/pulls/294","id":215869542,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODY5NTQy","html_url":"https://github.com/pingcap/kvproto/pull/294","diff_url":"https://github.com/pingcap/kvproto/pull/294.diff","patch_url":"https://github.com/pingcap/kvproto/pull/294.patch","issue_url":"https://api.github.com/repos/pingcap/kvproto/issues/294","number":294,"state":"open","locked":false,"title":"Batch messages between TiKV and TiDB","user":{"login":"hicqu","id":8407317,"node_id":"MDQ6VXNlcjg0MDczMTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8407317?v=4","gravatar_id":"","url":"https://api.github.com/users/hicqu","html_url":"https://github.com/hicqu","followers_url":"https://api.github.com/users/hicqu/followers","following_url":"https://api.github.com/users/hicqu/following{/other_user}","gists_url":"https://api.github.com/users/hicqu/gists{/gist_id}","starred_url":"https://api.github.com/users/hicqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hicqu/subscriptions","organizations_url":"https://api.github.com/users/hicqu/orgs","repos_url":"https://api.github.com/users/hicqu/repos","events_url":"https://api.github.com/users/hicqu/events{/privacy}","received_events_url":"https://api.github.com/users/hicqu/received_events","type":"User","site_admin":false},"body":"Batch messages between TiDB and TiKV to cat down gRPC cpu usage and network expenses.","created_at":"2018-09-17T04:08:41Z","updated_at":"2018-09-17T09:59:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a88ef5d2c0e27531e870c51e0ae1935cb09cdd8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"BusyJay","id":1701473,"node_id":"MDQ6VXNlcjE3MDE0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1701473?v=4","gravatar_id":"","url":"https://api.github.com/users/BusyJay","html_url":"https://github.com/BusyJay","followers_url":"https://api.github.com/users/BusyJay/followers","following_url":"https://api.github.com/users/BusyJay/following{/other_user}","gists_url":"https://api.github.com/users/BusyJay/gists{/gist_id}","starred_url":"https://api.github.com/users/BusyJay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BusyJay/subscriptions","organizations_url":"https://api.github.com/users/BusyJay/orgs","repos_url":"https://api.github.com/users/BusyJay/repos","events_url":"https://api.github.com/users/BusyJay/events{/privacy}","received_events_url":"https://api.github.com/users/BusyJay/received_events","type":"User","site_admin":false},{"login":"zhangjinpeng1987","id":19700528,"node_id":"MDQ6VXNlcjE5NzAwNTI4","avatar_url":"https://avatars2.githubusercontent.com/u/19700528?v=4","gravatar_id":"","url":"https://api.github.com/users/zhangjinpeng1987","html_url":"https://github.com/zhangjinpeng1987","followers_url":"https://api.github.com/users/zhangjinpeng1987/followers","following_url":"https://api.github.com/users/zhangjinpeng1987/following{/other_user}","gists_url":"https://api.github.com/users/zhangjinpeng1987/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangjinpeng1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangjinpeng1987/subscriptions","organizations_url":"https://api.github.com/users/zhangjinpeng1987/orgs","repos_url":"https://api.github.com/users/zhangjinpeng1987/repos","events_url":"https://api.github.com/users/zhangjinpeng1987/events{/privacy}","received_events_url":"https://api.github.com/users/zhangjinpeng1987/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/kvproto/pulls/294/commits","review_comments_url":"https://api.github.com/repos/pingcap/kvproto/pulls/294/comments","review_comment_url":"https://api.github.com/repos/pingcap/kvproto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/kvproto/issues/294/comments","statuses_url":"https://api.github.com/repos/pingcap/kvproto/statuses/d0a38130f70ed8015a427f3aee654ef4a0181046","head":{"label":"pingcap:super-batch-streaming","ref":"super-batch-streaming","sha":"d0a38130f70ed8015a427f3aee654ef4a0181046","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":53628424,"node_id":"MDEwOlJlcG9zaXRvcnk1MzYyODQyNA==","name":"kvproto","full_name":"pingcap/kvproto","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/kvproto","description":"Protocol buffer files for TiKV","fork":false,"url":"https://api.github.com/repos/pingcap/kvproto","forks_url":"https://api.github.com/repos/pingcap/kvproto/forks","keys_url":"https://api.github.com/repos/pingcap/kvproto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/kvproto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/kvproto/teams","hooks_url":"https://api.github.com/repos/pingcap/kvproto/hooks","issue_events_url":"https://api.github.com/repos/pingcap/kvproto/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/kvproto/events","assignees_url":"https://api.github.com/repos/pingcap/kvproto/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/kvproto/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/kvproto/tags","blobs_url":"https://api.github.com/repos/pingcap/kvproto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/kvproto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/kvproto/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/kvproto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/kvproto/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/kvproto/languages","stargazers_url":"https://api.github.com/repos/pingcap/kvproto/stargazers","contributors_url":"https://api.github.com/repos/pingcap/kvproto/contributors","subscribers_url":"https://api.github.com/repos/pingcap/kvproto/subscribers","subscription_url":"https://api.github.com/repos/pingcap/kvproto/subscription","commits_url":"https://api.github.com/repos/pingcap/kvproto/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/kvproto/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/kvproto/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/kvproto/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/kvproto/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/kvproto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/kvproto/merges","archive_url":"https://api.github.com/repos/pingcap/kvproto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/kvproto/downloads","issues_url":"https://api.github.com/repos/pingcap/kvproto/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/kvproto/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/kvproto/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/kvproto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/kvproto/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/kvproto/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/kvproto/deployments","created_at":"2016-03-11T00:50:02Z","updated_at":"2018-09-13T23:23:59Z","pushed_at":"2018-09-17T08:15:37Z","git_url":"git://github.com/pingcap/kvproto.git","ssh_url":"git@github.com:pingcap/kvproto.git","clone_url":"https://github.com/pingcap/kvproto.git","svn_url":"https://github.com/pingcap/kvproto","homepage":null,"size":7782,"stargazers_count":50,"watchers_count":50,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":32,"open_issues":11,"watchers":50,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"529c652955d8fa74faf56f91b2f428d5779fd7d5","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":53628424,"node_id":"MDEwOlJlcG9zaXRvcnk1MzYyODQyNA==","name":"kvproto","full_name":"pingcap/kvproto","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/kvproto","description":"Protocol buffer files for TiKV","fork":false,"url":"https://api.github.com/repos/pingcap/kvproto","forks_url":"https://api.github.com/repos/pingcap/kvproto/forks","keys_url":"https://api.github.com/repos/pingcap/kvproto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/kvproto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/kvproto/teams","hooks_url":"https://api.github.com/repos/pingcap/kvproto/hooks","issue_events_url":"https://api.github.com/repos/pingcap/kvproto/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/kvproto/events","assignees_url":"https://api.github.com/repos/pingcap/kvproto/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/kvproto/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/kvproto/tags","blobs_url":"https://api.github.com/repos/pingcap/kvproto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/kvproto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/kvproto/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/kvproto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/kvproto/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/kvproto/languages","stargazers_url":"https://api.github.com/repos/pingcap/kvproto/stargazers","contributors_url":"https://api.github.com/repos/pingcap/kvproto/contributors","subscribers_url":"https://api.github.com/repos/pingcap/kvproto/subscribers","subscription_url":"https://api.github.com/repos/pingcap/kvproto/subscription","commits_url":"https://api.github.com/repos/pingcap/kvproto/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/kvproto/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/kvproto/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/kvproto/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/kvproto/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/kvproto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/kvproto/merges","archive_url":"https://api.github.com/repos/pingcap/kvproto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/kvproto/downloads","issues_url":"https://api.github.com/repos/pingcap/kvproto/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/kvproto/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/kvproto/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/kvproto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/kvproto/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/kvproto/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/kvproto/deployments","created_at":"2016-03-11T00:50:02Z","updated_at":"2018-09-13T23:23:59Z","pushed_at":"2018-09-17T08:15:37Z","git_url":"git://github.com/pingcap/kvproto.git","ssh_url":"git@github.com:pingcap/kvproto.git","clone_url":"https://github.com/pingcap/kvproto.git","svn_url":"https://github.com/pingcap/kvproto","homepage":null,"size":7782,"stargazers_count":50,"watchers_count":50,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":32,"open_issues":11,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/kvproto/pulls/294"},"html":{"href":"https://github.com/pingcap/kvproto/pull/294"},"issue":{"href":"https://api.github.com/repos/pingcap/kvproto/issues/294"},"comments":{"href":"https://api.github.com/repos/pingcap/kvproto/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/kvproto/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/kvproto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/kvproto/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/kvproto/statuses/d0a38130f70ed8015a427f3aee654ef4a0181046"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hicqu"}}