{"action":"opened","number":23,"pull_request":{"url":"https://api.github.com/repos/kkrull/gohttp/pulls/23","id":187602392,"html_url":"https://github.com/kkrull/gohttp/pull/23","diff_url":"https://github.com/kkrull/gohttp/pull/23.diff","patch_url":"https://github.com/kkrull/gohttp/pull/23.patch","issue_url":"https://api.github.com/repos/kkrull/gohttp/issues/23","number":23,"state":"open","locked":false,"title":"Partial content","user":{"login":"kkrull","id":1178927,"avatar_url":"https://avatars1.githubusercontent.com/u/1178927?v=4","gravatar_id":"","url":"https://api.github.com/users/kkrull","html_url":"https://github.com/kkrull","followers_url":"https://api.github.com/users/kkrull/followers","following_url":"https://api.github.com/users/kkrull/following{/other_user}","gists_url":"https://api.github.com/users/kkrull/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrull/subscriptions","organizations_url":"https://api.github.com/users/kkrull/orgs","repos_url":"https://api.github.com/users/kkrull/repos","events_url":"https://api.github.com/users/kkrull/events{/privacy}","received_events_url":"https://api.github.com/users/kkrull/received_events","type":"User","site_admin":false},"body":"For the `PartialContent` test in `cob_spec`.\r\n\r\n### Summary of changes\r\n\r\n- Overall: Get and Head methods on Resource implementations now take `http.RequestMessage` instead of a primitive target/path\r\n- `fs`: Implementing the standard `http.Resource` instead of the older `http.Response`\r\n- `fs`: New functionality for 206 Partial Content and 416 Range Not Satisfiable as per RFC 7233\r\n\r\n### Results\r\n\r\n```\r\nStarting Test System: slim using fitnesse.slim.SlimService.\r\n. 22:32:46 R:0    W:0    I:0    E:0    SuiteSetUp       (HttpTestSuite.SuiteSetUp)      0.003 seconds\r\nF 22:32:46 R:1    W:6    I:0    E:0    BasicAuth        (HttpTestSuite.ResponseTestSuite.BasicAuth)     0.001 seconds\r\nF 22:32:46 R:0    W:4    I:0    E:1    CookieData       (HttpTestSuite.ResponseTestSuite.CookieData)    0.000 seconds\r\nF 22:32:46 R:2    W:8    I:0    E:0    CreateReadUpdateDelete   (HttpTestSuite.ResponseTestSuite.CreateReadUpdateDelete)        0.001 seconds\r\n. 22:32:46 R:6    W:0    I:0    E:0    DirectoryLinks   (HttpTestSuite.ResponseTestSuite.DirectoryLinks)        0.001 seconds\r\n. 22:32:46 R:1    W:0    I:0    E:0    DirectoryListing (HttpTestSuite.ResponseTestSuite.DirectoryListing)      0.001 seconds\r\n. 22:32:47 R:1    W:0    I:0    E:0    FileContents     (HttpTestSuite.ResponseTestSuite.FileContents)  0.001 seconds\r\n. 22:32:47 R:3    W:0    I:0    E:0    FourEightTeen    (HttpTestSuite.ResponseTestSuite.FourEightTeen) 0.001 seconds\r\n. 22:32:47 R:1    W:0    I:0    E:0    FourOhFour       (HttpTestSuite.ResponseTestSuite.FourOhFour)    0.000 seconds\r\n. 22:32:47 R:3    W:0    I:0    E:0    ImageContent     (HttpTestSuite.ResponseTestSuite.ImageContent)  0.001 seconds\r\n. 22:32:47 R:4    W:0    I:0    E:0    MediaTypes       (HttpTestSuite.ResponseTestSuite.MediaTypes)    0.001 seconds\r\n. 22:32:47 R:6    W:0    I:0    E:0    MethodNotAllowed (HttpTestSuite.ResponseTestSuite.MethodNotAllowed)      0.001 seconds\r\n. 22:32:47 R:2    W:0    I:0    E:0    ParameterDecode  (HttpTestSuite.ResponseTestSuite.ParameterDecode)       0.000 seconds\r\n. 22:32:47 R:11   W:0    I:0    E:0    PartialContent   (HttpTestSuite.ResponseTestSuite.PartialContent)        0.001 seconds\r\nF 22:32:47 R:4    W:2    I:0    E:0    PatchWithEtag    (HttpTestSuite.ResponseTestSuite.PatchWithEtag) 0.000 seconds\r\n. 22:32:47 R:2    W:0    I:0    E:0    RedirectPath     (HttpTestSuite.ResponseTestSuite.RedirectPath)  0.001 seconds\r\n. 22:32:47 R:1    W:0    I:0    E:0    SimpleGet        (HttpTestSuite.ResponseTestSuite.SimpleGet)     0.001 seconds\r\n. 22:32:47 R:4    W:0    I:0    E:0    SimpleHead       (HttpTestSuite.ResponseTestSuite.SimpleHead)    0.001 seconds\r\n. 22:32:47 R:6    W:0    I:0    E:0    SimpleOption     (HttpTestSuite.ResponseTestSuite.SimpleOption)  0.001 seconds\r\nF 22:32:47 R:0    W:1    I:0    E:0    SimplePost       (HttpTestSuite.ResponseTestSuite.SimplePost)    0.000 seconds\r\nF 22:32:47 R:0    W:1    I:0    E:0    SimplePut        (HttpTestSuite.ResponseTestSuite.SimplePut)     0.000 seconds\r\n. 22:32:48 R:1    W:0    I:0    E:0    TimeToComplete   (HttpTestSuite.SimultaneousTestSuite.TimeToComplete)    0.000 seconds\r\n. 22:32:48 R:0    W:0    I:0    E:0    SuiteTearDown    (HttpTestSuite.SuiteTearDown)   0.000 seconds\r\n--------\r\n23 Tests,       7 Failures      4.011 seconds.\r\n0\r\nExit-Code: 6\r\n```","created_at":"2018-05-12T03:34:52Z","updated_at":"2018-05-12T03:34:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kkrull/gohttp/pulls/23/commits","review_comments_url":"https://api.github.com/repos/kkrull/gohttp/pulls/23/comments","review_comment_url":"https://api.github.com/repos/kkrull/gohttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kkrull/gohttp/issues/23/comments","statuses_url":"https://api.github.com/repos/kkrull/gohttp/statuses/f003c0233f196816c233c4241d162116faeb7b1f","head":{"label":"kkrull:partial-content","ref":"partial-content","sha":"f003c0233f196816c233c4241d162116faeb7b1f","user":{"login":"kkrull","id":1178927,"avatar_url":"https://avatars1.githubusercontent.com/u/1178927?v=4","gravatar_id":"","url":"https://api.github.com/users/kkrull","html_url":"https://github.com/kkrull","followers_url":"https://api.github.com/users/kkrull/followers","following_url":"https://api.github.com/users/kkrull/following{/other_user}","gists_url":"https://api.github.com/users/kkrull/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrull/subscriptions","organizations_url":"https://api.github.com/users/kkrull/orgs","repos_url":"https://api.github.com/users/kkrull/repos","events_url":"https://api.github.com/users/kkrull/events{/privacy}","received_events_url":"https://api.github.com/users/kkrull/received_events","type":"User","site_admin":false},"repo":{"id":125908819,"name":"gohttp","full_name":"kkrull/gohttp","owner":{"login":"kkrull","id":1178927,"avatar_url":"https://avatars1.githubusercontent.com/u/1178927?v=4","gravatar_id":"","url":"https://api.github.com/users/kkrull","html_url":"https://github.com/kkrull","followers_url":"https://api.github.com/users/kkrull/followers","following_url":"https://api.github.com/users/kkrull/following{/other_user}","gists_url":"https://api.github.com/users/kkrull/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrull/subscriptions","organizations_url":"https://api.github.com/users/kkrull/orgs","repos_url":"https://api.github.com/users/kkrull/repos","events_url":"https://api.github.com/users/kkrull/events{/privacy}","received_events_url":"https://api.github.com/users/kkrull/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkrull/gohttp","description":"HTTP server in Go","fork":false,"url":"https://api.github.com/repos/kkrull/gohttp","forks_url":"https://api.github.com/repos/kkrull/gohttp/forks","keys_url":"https://api.github.com/repos/kkrull/gohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkrull/gohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkrull/gohttp/teams","hooks_url":"https://api.github.com/repos/kkrull/gohttp/hooks","issue_events_url":"https://api.github.com/repos/kkrull/gohttp/issues/events{/number}","events_url":"https://api.github.com/repos/kkrull/gohttp/events","assignees_url":"https://api.github.com/repos/kkrull/gohttp/assignees{/user}","branches_url":"https://api.github.com/repos/kkrull/gohttp/branches{/branch}","tags_url":"https://api.github.com/repos/kkrull/gohttp/tags","blobs_url":"https://api.github.com/repos/kkrull/gohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkrull/gohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkrull/gohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkrull/gohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkrull/gohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/kkrull/gohttp/languages","stargazers_url":"https://api.github.com/repos/kkrull/gohttp/stargazers","contributors_url":"https://api.github.com/repos/kkrull/gohttp/contributors","subscribers_url":"https://api.github.com/repos/kkrull/gohttp/subscribers","subscription_url":"https://api.github.com/repos/kkrull/gohttp/subscription","commits_url":"https://api.github.com/repos/kkrull/gohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkrull/gohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkrull/gohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkrull/gohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkrull/gohttp/contents/{+path}","compare_url":"https://api.github.com/repos/kkrull/gohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkrull/gohttp/merges","archive_url":"https://api.github.com/repos/kkrull/gohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkrull/gohttp/downloads","issues_url":"https://api.github.com/repos/kkrull/gohttp/issues{/number}","pulls_url":"https://api.github.com/repos/kkrull/gohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/kkrull/gohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/kkrull/gohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkrull/gohttp/labels{/name}","releases_url":"https://api.github.com/repos/kkrull/gohttp/releases{/id}","deployments_url":"https://api.github.com/repos/kkrull/gohttp/deployments","created_at":"2018-03-19T19:21:00Z","updated_at":"2018-05-09T01:17:29Z","pushed_at":"2018-05-12T03:32:09Z","git_url":"git://github.com/kkrull/gohttp.git","ssh_url":"git@github.com:kkrull/gohttp.git","clone_url":"https://github.com/kkrull/gohttp.git","svn_url":"https://github.com/kkrull/gohttp","homepage":null,"size":406,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kkrull:master","ref":"master","sha":"4aaa61e4adb844b3526a9a98e940beba13ac1af8","user":{"login":"kkrull","id":1178927,"avatar_url":"https://avatars1.githubusercontent.com/u/1178927?v=4","gravatar_id":"","url":"https://api.github.com/users/kkrull","html_url":"https://github.com/kkrull","followers_url":"https://api.github.com/users/kkrull/followers","following_url":"https://api.github.com/users/kkrull/following{/other_user}","gists_url":"https://api.github.com/users/kkrull/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrull/subscriptions","organizations_url":"https://api.github.com/users/kkrull/orgs","repos_url":"https://api.github.com/users/kkrull/repos","events_url":"https://api.github.com/users/kkrull/events{/privacy}","received_events_url":"https://api.github.com/users/kkrull/received_events","type":"User","site_admin":false},"repo":{"id":125908819,"name":"gohttp","full_name":"kkrull/gohttp","owner":{"login":"kkrull","id":1178927,"avatar_url":"https://avatars1.githubusercontent.com/u/1178927?v=4","gravatar_id":"","url":"https://api.github.com/users/kkrull","html_url":"https://github.com/kkrull","followers_url":"https://api.github.com/users/kkrull/followers","following_url":"https://api.github.com/users/kkrull/following{/other_user}","gists_url":"https://api.github.com/users/kkrull/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrull/subscriptions","organizations_url":"https://api.github.com/users/kkrull/orgs","repos_url":"https://api.github.com/users/kkrull/repos","events_url":"https://api.github.com/users/kkrull/events{/privacy}","received_events_url":"https://api.github.com/users/kkrull/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkrull/gohttp","description":"HTTP server in Go","fork":false,"url":"https://api.github.com/repos/kkrull/gohttp","forks_url":"https://api.github.com/repos/kkrull/gohttp/forks","keys_url":"https://api.github.com/repos/kkrull/gohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkrull/gohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkrull/gohttp/teams","hooks_url":"https://api.github.com/repos/kkrull/gohttp/hooks","issue_events_url":"https://api.github.com/repos/kkrull/gohttp/issues/events{/number}","events_url":"https://api.github.com/repos/kkrull/gohttp/events","assignees_url":"https://api.github.com/repos/kkrull/gohttp/assignees{/user}","branches_url":"https://api.github.com/repos/kkrull/gohttp/branches{/branch}","tags_url":"https://api.github.com/repos/kkrull/gohttp/tags","blobs_url":"https://api.github.com/repos/kkrull/gohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkrull/gohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkrull/gohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkrull/gohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkrull/gohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/kkrull/gohttp/languages","stargazers_url":"https://api.github.com/repos/kkrull/gohttp/stargazers","contributors_url":"https://api.github.com/repos/kkrull/gohttp/contributors","subscribers_url":"https://api.github.com/repos/kkrull/gohttp/subscribers","subscription_url":"https://api.github.com/repos/kkrull/gohttp/subscription","commits_url":"https://api.github.com/repos/kkrull/gohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkrull/gohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkrull/gohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkrull/gohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkrull/gohttp/contents/{+path}","compare_url":"https://api.github.com/repos/kkrull/gohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkrull/gohttp/merges","archive_url":"https://api.github.com/repos/kkrull/gohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkrull/gohttp/downloads","issues_url":"https://api.github.com/repos/kkrull/gohttp/issues{/number}","pulls_url":"https://api.github.com/repos/kkrull/gohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/kkrull/gohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/kkrull/gohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkrull/gohttp/labels{/name}","releases_url":"https://api.github.com/repos/kkrull/gohttp/releases{/id}","deployments_url":"https://api.github.com/repos/kkrull/gohttp/deployments","created_at":"2018-03-19T19:21:00Z","updated_at":"2018-05-09T01:17:29Z","pushed_at":"2018-05-12T03:32:09Z","git_url":"git://github.com/kkrull/gohttp.git","ssh_url":"git@github.com:kkrull/gohttp.git","clone_url":"https://github.com/kkrull/gohttp.git","svn_url":"https://github.com/kkrull/gohttp","homepage":null,"size":406,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kkrull/gohttp/pulls/23"},"html":{"href":"https://github.com/kkrull/gohttp/pull/23"},"issue":{"href":"https://api.github.com/repos/kkrull/gohttp/issues/23"},"comments":{"href":"https://api.github.com/repos/kkrull/gohttp/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/kkrull/gohttp/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/kkrull/gohttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kkrull/gohttp/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/kkrull/gohttp/statuses/f003c0233f196816c233c4241d162116faeb7b1f"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":34,"additions":996,"deletions":412,"changed_files":31}}
{"actor":{"display_login":"kkrull"}}