{"action":"created","comment":{"url":"https://api.github.com/repos/opensim-org/opensim-gui/pulls/comments/210133247","pull_request_review_id":146286820,"id":210133247,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDEzMzI0Nw==","diff_hunk":"@@ -180,7 +180,7 @@ public void generateDecorations(boolean fixed, ModelDisplayHints hints, State st\n             Transform xform = new Transform();\n             \n             xform.setP(new Vec3(point[0], point[1], point[2]));\n-            appendToThis.push_back(new DecorativeArrow(new Vec3(0, 0, 0)).setBodyId(0).setColor(new Vec3(0., 1., .0)).setOpacity(0.5).setIndexOnBody(getStartIndexInFileNotIncludingTime()).setTransform(xform));            \n+            appendToThis.push_back(new DecorativeArrow(new Vec3(0, 0, 0)).setBodyId(0).setColor(color).setOpacity(0.5).setIndexOnBody(getStartIndexInFileNotIncludingTime()).setTransform(xform));            ","path":"Gui/opensim/view/src/org/opensim/view/experimentaldata/MotionObjectPointForce.java","position":5,"original_position":5,"commit_id":"b5e1ff226063944d745b34b52b3eff8879cc9cac","original_commit_id":"242dafb5c5eb91fc3f55199820aa078ea53719df","user":{"login":"aseth1","id":6494122,"node_id":"MDQ6VXNlcjY0OTQxMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/6494122?v=4","gravatar_id":"","url":"https://api.github.com/users/aseth1","html_url":"https://github.com/aseth1","followers_url":"https://api.github.com/users/aseth1/followers","following_url":"https://api.github.com/users/aseth1/following{/other_user}","gists_url":"https://api.github.com/users/aseth1/gists{/gist_id}","starred_url":"https://api.github.com/users/aseth1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseth1/subscriptions","organizations_url":"https://api.github.com/users/aseth1/orgs","repos_url":"https://api.github.com/users/aseth1/repos","events_url":"https://api.github.com/users/aseth1/events{/privacy}","received_events_url":"https://api.github.com/users/aseth1/received_events","type":"User","site_admin":false},"body":"This line of code is indecipherable. Please please describe what this is supposed to be doing? `setBodyId(0)...setIndexOnBody(getStartIndexInFileNotIncludingTime())` is very confusing. What is `getStartIndexInFileNotIncludingTime()` and why is it relevant or necessary in this context?","created_at":"2018-08-14T23:17:37Z","updated_at":"2018-08-14T23:40:11Z","html_url":"https://github.com/opensim-org/opensim-gui/pull/945#discussion_r210133247","pull_request_url":"https://api.github.com/repos/opensim-org/opensim-gui/pulls/945","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-gui/pulls/comments/210133247"},"html":{"href":"https://github.com/opensim-org/opensim-gui/pull/945#discussion_r210133247"},"pull_request":{"href":"https://api.github.com/repos/opensim-org/opensim-gui/pulls/945"}}},"pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-gui/pulls/945","id":206520735,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTIwNzM1","html_url":"https://github.com/opensim-org/opensim-gui/pull/945","diff_url":"https://github.com/opensim-org/opensim-gui/pull/945.diff","patch_url":"https://github.com/opensim-org/opensim-gui/pull/945.patch","issue_url":"https://api.github.com/repos/opensim-org/opensim-gui/issues/945","number":945,"state":"open","locked":false,"title":"Sync experimental Marker scale property with visualization","user":{"login":"aymanhab","id":3972208,"node_id":"MDQ6VXNlcjM5NzIyMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3972208?v=4","gravatar_id":"","url":"https://api.github.com/users/aymanhab","html_url":"https://github.com/aymanhab","followers_url":"https://api.github.com/users/aymanhab/followers","following_url":"https://api.github.com/users/aymanhab/following{/other_user}","gists_url":"https://api.github.com/users/aymanhab/gists{/gist_id}","starred_url":"https://api.github.com/users/aymanhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aymanhab/subscriptions","organizations_url":"https://api.github.com/users/aymanhab/orgs","repos_url":"https://api.github.com/users/aymanhab/repos","events_url":"https://api.github.com/users/aymanhab/events{/privacy}","received_events_url":"https://api.github.com/users/aymanhab/received_events","type":"User","site_admin":false},"body":"Fixes issue #643 \r\n\r\n### Brief summary of changes\r\nExperimental Marker size/color were being lost on switching current motion (or sync.) Now during initialization/switching we use size that accounts for both DefaultSize and scaleFactor\r\n\r\n### Testing I've completed\r\nLoaded multiple sets of experimental data (Markers) and was able to switch/sync motions and the size stays in sync with property\r\n\r\n### CHANGELOG.md (choose one)\r\n\r\n- no need to update because bugfix","created_at":"2018-08-06T21:24:17Z","updated_at":"2018-08-14T23:40:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f7710a1f69014bf691a8828ca5ef6eb3ff761e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opensim-org/opensim-gui/pulls/945/commits","review_comments_url":"https://api.github.com/repos/opensim-org/opensim-gui/pulls/945/comments","review_comment_url":"https://api.github.com/repos/opensim-org/opensim-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opensim-org/opensim-gui/issues/945/comments","statuses_url":"https://api.github.com/repos/opensim-org/opensim-gui/statuses/b5e1ff226063944d745b34b52b3eff8879cc9cac","head":{"label":"opensim-org:sync_experimarker_scale","ref":"sync_experimarker_scale","sha":"b5e1ff226063944d745b34b52b3eff8879cc9cac","user":{"login":"opensim-org","id":4370782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzA3ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/4370782?v=4","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":21282751,"node_id":"MDEwOlJlcG9zaXRvcnkyMTI4Mjc1MQ==","name":"opensim-gui","full_name":"opensim-org/opensim-gui","owner":{"login":"opensim-org","id":4370782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzA3ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/4370782?v=4","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-gui","description":"SimTK OpenSim graphical user interface and distribution.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-gui","forks_url":"https://api.github.com/repos/opensim-org/opensim-gui/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-gui/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-gui/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-gui/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-gui/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-gui/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-gui/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-gui/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-gui/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-gui/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-gui/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-gui/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-gui/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-gui/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-gui/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-gui/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-gui/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-gui/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-gui/releases{/id}","deployments_url":"https://api.github.com/repos/opensim-org/opensim-gui/deployments","created_at":"2014-06-27T16:58:33Z","updated_at":"2018-08-13T19:08:56Z","pushed_at":"2018-08-14T22:32:01Z","git_url":"git://github.com/opensim-org/opensim-gui.git","ssh_url":"git@github.com:opensim-org/opensim-gui.git","clone_url":"https://github.com/opensim-org/opensim-gui.git","svn_url":"https://github.com/opensim-org/opensim-gui","homepage":null,"size":329942,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":219,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":219,"watchers":8,"default_branch":"master"}},"base":{"label":"opensim-org:master","ref":"master","sha":"71c8c385873b86900d6c46aaf8595227a33b4d44","user":{"login":"opensim-org","id":4370782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzA3ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/4370782?v=4","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":21282751,"node_id":"MDEwOlJlcG9zaXRvcnkyMTI4Mjc1MQ==","name":"opensim-gui","full_name":"opensim-org/opensim-gui","owner":{"login":"opensim-org","id":4370782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzA3ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/4370782?v=4","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-gui","description":"SimTK OpenSim graphical user interface and distribution.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-gui","forks_url":"https://api.github.com/repos/opensim-org/opensim-gui/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-gui/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-gui/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-gui/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-gui/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-gui/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-gui/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-gui/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-gui/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-gui/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-gui/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-gui/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-gui/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-gui/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-gui/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-gui/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-gui/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-gui/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-gui/releases{/id}","deployments_url":"https://api.github.com/repos/opensim-org/opensim-gui/deployments","created_at":"2014-06-27T16:58:33Z","updated_at":"2018-08-13T19:08:56Z","pushed_at":"2018-08-14T22:32:01Z","git_url":"git://github.com/opensim-org/opensim-gui.git","ssh_url":"git@github.com:opensim-org/opensim-gui.git","clone_url":"https://github.com/opensim-org/opensim-gui.git","svn_url":"https://github.com/opensim-org/opensim-gui","homepage":null,"size":329942,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":219,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":219,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-gui/pulls/945"},"html":{"href":"https://github.com/opensim-org/opensim-gui/pull/945"},"issue":{"href":"https://api.github.com/repos/opensim-org/opensim-gui/issues/945"},"comments":{"href":"https://api.github.com/repos/opensim-org/opensim-gui/issues/945/comments"},"review_comments":{"href":"https://api.github.com/repos/opensim-org/opensim-gui/pulls/945/comments"},"review_comment":{"href":"https://api.github.com/repos/opensim-org/opensim-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opensim-org/opensim-gui/pulls/945/commits"},"statuses":{"href":"https://api.github.com/repos/opensim-org/opensim-gui/statuses/b5e1ff226063944d745b34b52b3eff8879cc9cac"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aseth1"}}