{"action":"created","issue":{"url":"https://api.github.com/repos/opendiffy/diffy/issues/1","repository_url":"https://api.github.com/repos/opendiffy/diffy","labels_url":"https://api.github.com/repos/opendiffy/diffy/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/opendiffy/diffy/issues/1/comments","events_url":"https://api.github.com/repos/opendiffy/diffy/issues/1/events","html_url":"https://github.com/opendiffy/diffy/issues/1","id":324564305,"node_id":"MDU6SXNzdWUzMjQ1NjQzMDU=","number":1,"title":"Is there any documentation for thrift testing","user":{"login":"hmenghouzz","id":33037346,"node_id":"MDQ6VXNlcjMzMDM3MzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/33037346?v=4","gravatar_id":"","url":"https://api.github.com/users/hmenghouzz","html_url":"https://github.com/hmenghouzz","followers_url":"https://api.github.com/users/hmenghouzz/followers","following_url":"https://api.github.com/users/hmenghouzz/following{/other_user}","gists_url":"https://api.github.com/users/hmenghouzz/gists{/gist_id}","starred_url":"https://api.github.com/users/hmenghouzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmenghouzz/subscriptions","organizations_url":"https://api.github.com/users/hmenghouzz/orgs","repos_url":"https://api.github.com/users/hmenghouzz/repos","events_url":"https://api.github.com/users/hmenghouzz/events{/privacy}","received_events_url":"https://api.github.com/users/hmenghouzz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"hmenghouzz","id":33037346,"node_id":"MDQ6VXNlcjMzMDM3MzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/33037346?v=4","gravatar_id":"","url":"https://api.github.com/users/hmenghouzz","html_url":"https://github.com/hmenghouzz","followers_url":"https://api.github.com/users/hmenghouzz/followers","following_url":"https://api.github.com/users/hmenghouzz/following{/other_user}","gists_url":"https://api.github.com/users/hmenghouzz/gists{/gist_id}","starred_url":"https://api.github.com/users/hmenghouzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmenghouzz/subscriptions","organizations_url":"https://api.github.com/users/hmenghouzz/orgs","repos_url":"https://api.github.com/users/hmenghouzz/repos","events_url":"https://api.github.com/users/hmenghouzz/events{/privacy}","received_events_url":"https://api.github.com/users/hmenghouzz/received_events","type":"User","site_admin":false},"assignees":[{"login":"hmenghouzz","id":33037346,"node_id":"MDQ6VXNlcjMzMDM3MzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/33037346?v=4","gravatar_id":"","url":"https://api.github.com/users/hmenghouzz","html_url":"https://github.com/hmenghouzz","followers_url":"https://api.github.com/users/hmenghouzz/followers","following_url":"https://api.github.com/users/hmenghouzz/following{/other_user}","gists_url":"https://api.github.com/users/hmenghouzz/gists{/gist_id}","starred_url":"https://api.github.com/users/hmenghouzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmenghouzz/subscriptions","organizations_url":"https://api.github.com/users/hmenghouzz/orgs","repos_url":"https://api.github.com/users/hmenghouzz/repos","events_url":"https://api.github.com/users/hmenghouzz/events{/privacy}","received_events_url":"https://api.github.com/users/hmenghouzz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2018-05-18T22:01:08Z","updated_at":"2018-08-20T05:37:35Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\n\r\nIs there any documentation for using diffy on Thrift comparison?\r\nI couldn't find any Thrift related examples from README.\r\nI have some thrift IDLs. I used apache thrift code generator to generate the Java files. Then used \"javac\" and \"jar\" command to combine those java class files into a single JAR archive file.\r\n\r\nTried to run diffy with this command\r\n...\r\n-service.protocol=thrift \\\r\n-allowHttpSideEffects=true \\\r\n-enableThriftMux='true' \\\r\n-thrift.jar='/path/to/thrift.jar' \\\r\n-thrift.serviceClass=$SomeServiceName\r\n\r\nThen I got such error:\r\nError in custom provider, ai.diffy.lifter.ThriftLifter$InvalidServiceException: Invalid service: ....\r\n\r\nI noticed that the filenames returned empty in this function: \r\nhttps://github.com/opendiffy/diffy/blob/master/src/main/scala/ai/diffy/proxy/ThriftDifferenceProxy.scala#L37\r\n\r\nMust the fat jar that feeds diffy be generated by Scrooge?\r\n\r\nReally appreciate your time here 😊 \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/opendiffy/diffy/issues/comments/414202243","html_url":"https://github.com/opendiffy/diffy/issues/1#issuecomment-414202243","issue_url":"https://api.github.com/repos/opendiffy/diffy/issues/1","id":414202243,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDIwMjI0Mw==","user":{"login":"puneetkhanduri","id":1631032,"node_id":"MDQ6VXNlcjE2MzEwMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1631032?v=4","gravatar_id":"","url":"https://api.github.com/users/puneetkhanduri","html_url":"https://github.com/puneetkhanduri","followers_url":"https://api.github.com/users/puneetkhanduri/followers","following_url":"https://api.github.com/users/puneetkhanduri/following{/other_user}","gists_url":"https://api.github.com/users/puneetkhanduri/gists{/gist_id}","starred_url":"https://api.github.com/users/puneetkhanduri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puneetkhanduri/subscriptions","organizations_url":"https://api.github.com/users/puneetkhanduri/orgs","repos_url":"https://api.github.com/users/puneetkhanduri/repos","events_url":"https://api.github.com/users/puneetkhanduri/events{/privacy}","received_events_url":"https://api.github.com/users/puneetkhanduri/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T05:37:35Z","updated_at":"2018-08-20T05:37:35Z","author_association":"COLLABORATOR","body":"@hmenghouzz I just noticed that you are using thrift over http - this is currently not supported. Diffy currently only supports thrift over tcp."}}
{"actor":{"display_login":"puneetkhanduri"}}