{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/bigtestjs/convergence/pulls/5","id":184610553,"html_url":"https://github.com/bigtestjs/convergence/pull/5","diff_url":"https://github.com/bigtestjs/convergence/pull/5.diff","patch_url":"https://github.com/bigtestjs/convergence/pull/5.patch","issue_url":"https://api.github.com/repos/bigtestjs/convergence/issues/5","number":5,"state":"open","locked":false,"title":"Add types for public API","user":{"login":"robbiepitts","id":671032,"avatar_url":"https://avatars1.githubusercontent.com/u/671032?v=4","gravatar_id":"","url":"https://api.github.com/users/robbiepitts","html_url":"https://github.com/robbiepitts","followers_url":"https://api.github.com/users/robbiepitts/followers","following_url":"https://api.github.com/users/robbiepitts/following{/other_user}","gists_url":"https://api.github.com/users/robbiepitts/gists{/gist_id}","starred_url":"https://api.github.com/users/robbiepitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbiepitts/subscriptions","organizations_url":"https://api.github.com/users/robbiepitts/orgs","repos_url":"https://api.github.com/users/robbiepitts/repos","events_url":"https://api.github.com/users/robbiepitts/events{/privacy}","received_events_url":"https://api.github.com/users/robbiepitts/received_events","type":"User","site_admin":false},"body":"So that BigTest can be used in TS projects. The `tsconfig.json` is for IntelliSense which aids in the creation/maintenance of the type declaration files.\r\n\r\nThis exports the `IStats` interface and `Assertion` and `SideEffect` function types from the `index.d.ts` file since those are public APIs. `SideEffect` is the type signature for the callback passed to `Convergence#do()` and I thought it was odd that `#do()`, although intended for side-effects, can perform side-effects _and_ passes on the return value in the new `Convergence` it returns—unless I misinterpreted what's going on. I would have expected it to only perform side effects and for anything returned from its callback to be swallowed. If both behaviors are desired maybe that indicates an additional method like `#map()`?","created_at":"2018-04-27T12:39:11Z","updated_at":"2018-04-27T12:39:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigtestjs/convergence/pulls/5/commits","review_comments_url":"https://api.github.com/repos/bigtestjs/convergence/pulls/5/comments","review_comment_url":"https://api.github.com/repos/bigtestjs/convergence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigtestjs/convergence/issues/5/comments","statuses_url":"https://api.github.com/repos/bigtestjs/convergence/statuses/e74548da3e2d2b992cb7014e08ea26bd0e7f1d92","head":{"label":"robbiepitts:types","ref":"types","sha":"e74548da3e2d2b992cb7014e08ea26bd0e7f1d92","user":{"login":"robbiepitts","id":671032,"avatar_url":"https://avatars1.githubusercontent.com/u/671032?v=4","gravatar_id":"","url":"https://api.github.com/users/robbiepitts","html_url":"https://github.com/robbiepitts","followers_url":"https://api.github.com/users/robbiepitts/followers","following_url":"https://api.github.com/users/robbiepitts/following{/other_user}","gists_url":"https://api.github.com/users/robbiepitts/gists{/gist_id}","starred_url":"https://api.github.com/users/robbiepitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbiepitts/subscriptions","organizations_url":"https://api.github.com/users/robbiepitts/orgs","repos_url":"https://api.github.com/users/robbiepitts/repos","events_url":"https://api.github.com/users/robbiepitts/events{/privacy}","received_events_url":"https://api.github.com/users/robbiepitts/received_events","type":"User","site_admin":false},"repo":{"id":131011212,"name":"convergence","full_name":"robbiepitts/convergence","owner":{"login":"robbiepitts","id":671032,"avatar_url":"https://avatars1.githubusercontent.com/u/671032?v=4","gravatar_id":"","url":"https://api.github.com/users/robbiepitts","html_url":"https://github.com/robbiepitts","followers_url":"https://api.github.com/users/robbiepitts/followers","following_url":"https://api.github.com/users/robbiepitts/following{/other_user}","gists_url":"https://api.github.com/users/robbiepitts/gists{/gist_id}","starred_url":"https://api.github.com/users/robbiepitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbiepitts/subscriptions","organizations_url":"https://api.github.com/users/robbiepitts/orgs","repos_url":"https://api.github.com/users/robbiepitts/repos","events_url":"https://api.github.com/users/robbiepitts/events{/privacy}","received_events_url":"https://api.github.com/users/robbiepitts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robbiepitts/convergence","description":"Convergence helpers for testing big","fork":true,"url":"https://api.github.com/repos/robbiepitts/convergence","forks_url":"https://api.github.com/repos/robbiepitts/convergence/forks","keys_url":"https://api.github.com/repos/robbiepitts/convergence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robbiepitts/convergence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robbiepitts/convergence/teams","hooks_url":"https://api.github.com/repos/robbiepitts/convergence/hooks","issue_events_url":"https://api.github.com/repos/robbiepitts/convergence/issues/events{/number}","events_url":"https://api.github.com/repos/robbiepitts/convergence/events","assignees_url":"https://api.github.com/repos/robbiepitts/convergence/assignees{/user}","branches_url":"https://api.github.com/repos/robbiepitts/convergence/branches{/branch}","tags_url":"https://api.github.com/repos/robbiepitts/convergence/tags","blobs_url":"https://api.github.com/repos/robbiepitts/convergence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robbiepitts/convergence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robbiepitts/convergence/git/refs{/sha}","trees_url":"https://api.github.com/repos/robbiepitts/convergence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robbiepitts/convergence/statuses/{sha}","languages_url":"https://api.github.com/repos/robbiepitts/convergence/languages","stargazers_url":"https://api.github.com/repos/robbiepitts/convergence/stargazers","contributors_url":"https://api.github.com/repos/robbiepitts/convergence/contributors","subscribers_url":"https://api.github.com/repos/robbiepitts/convergence/subscribers","subscription_url":"https://api.github.com/repos/robbiepitts/convergence/subscription","commits_url":"https://api.github.com/repos/robbiepitts/convergence/commits{/sha}","git_commits_url":"https://api.github.com/repos/robbiepitts/convergence/git/commits{/sha}","comments_url":"https://api.github.com/repos/robbiepitts/convergence/comments{/number}","issue_comment_url":"https://api.github.com/repos/robbiepitts/convergence/issues/comments{/number}","contents_url":"https://api.github.com/repos/robbiepitts/convergence/contents/{+path}","compare_url":"https://api.github.com/repos/robbiepitts/convergence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robbiepitts/convergence/merges","archive_url":"https://api.github.com/repos/robbiepitts/convergence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robbiepitts/convergence/downloads","issues_url":"https://api.github.com/repos/robbiepitts/convergence/issues{/number}","pulls_url":"https://api.github.com/repos/robbiepitts/convergence/pulls{/number}","milestones_url":"https://api.github.com/repos/robbiepitts/convergence/milestones{/number}","notifications_url":"https://api.github.com/repos/robbiepitts/convergence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robbiepitts/convergence/labels{/name}","releases_url":"https://api.github.com/repos/robbiepitts/convergence/releases{/id}","deployments_url":"https://api.github.com/repos/robbiepitts/convergence/deployments","created_at":"2018-04-25T13:33:08Z","updated_at":"2018-04-25T13:33:10Z","pushed_at":"2018-04-27T12:16:11Z","git_url":"git://github.com/robbiepitts/convergence.git","ssh_url":"git@github.com:robbiepitts/convergence.git","clone_url":"https://github.com/robbiepitts/convergence.git","svn_url":"https://github.com/robbiepitts/convergence","homepage":null,"size":142,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigtestjs:master","ref":"master","sha":"03ddd6d92770d97b8e42bc408d9d464fafb09087","user":{"login":"bigtestjs","id":37890552,"avatar_url":"https://avatars0.githubusercontent.com/u/37890552?v=4","gravatar_id":"","url":"https://api.github.com/users/bigtestjs","html_url":"https://github.com/bigtestjs","followers_url":"https://api.github.com/users/bigtestjs/followers","following_url":"https://api.github.com/users/bigtestjs/following{/other_user}","gists_url":"https://api.github.com/users/bigtestjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bigtestjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigtestjs/subscriptions","organizations_url":"https://api.github.com/users/bigtestjs/orgs","repos_url":"https://api.github.com/users/bigtestjs/repos","events_url":"https://api.github.com/users/bigtestjs/events{/privacy}","received_events_url":"https://api.github.com/users/bigtestjs/received_events","type":"Organization","site_admin":false},"repo":{"id":129436443,"name":"convergence","full_name":"bigtestjs/convergence","owner":{"login":"bigtestjs","id":37890552,"avatar_url":"https://avatars0.githubusercontent.com/u/37890552?v=4","gravatar_id":"","url":"https://api.github.com/users/bigtestjs","html_url":"https://github.com/bigtestjs","followers_url":"https://api.github.com/users/bigtestjs/followers","following_url":"https://api.github.com/users/bigtestjs/following{/other_user}","gists_url":"https://api.github.com/users/bigtestjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bigtestjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigtestjs/subscriptions","organizations_url":"https://api.github.com/users/bigtestjs/orgs","repos_url":"https://api.github.com/users/bigtestjs/repos","events_url":"https://api.github.com/users/bigtestjs/events{/privacy}","received_events_url":"https://api.github.com/users/bigtestjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigtestjs/convergence","description":"Convergence helpers for testing big","fork":false,"url":"https://api.github.com/repos/bigtestjs/convergence","forks_url":"https://api.github.com/repos/bigtestjs/convergence/forks","keys_url":"https://api.github.com/repos/bigtestjs/convergence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigtestjs/convergence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigtestjs/convergence/teams","hooks_url":"https://api.github.com/repos/bigtestjs/convergence/hooks","issue_events_url":"https://api.github.com/repos/bigtestjs/convergence/issues/events{/number}","events_url":"https://api.github.com/repos/bigtestjs/convergence/events","assignees_url":"https://api.github.com/repos/bigtestjs/convergence/assignees{/user}","branches_url":"https://api.github.com/repos/bigtestjs/convergence/branches{/branch}","tags_url":"https://api.github.com/repos/bigtestjs/convergence/tags","blobs_url":"https://api.github.com/repos/bigtestjs/convergence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigtestjs/convergence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigtestjs/convergence/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigtestjs/convergence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigtestjs/convergence/statuses/{sha}","languages_url":"https://api.github.com/repos/bigtestjs/convergence/languages","stargazers_url":"https://api.github.com/repos/bigtestjs/convergence/stargazers","contributors_url":"https://api.github.com/repos/bigtestjs/convergence/contributors","subscribers_url":"https://api.github.com/repos/bigtestjs/convergence/subscribers","subscription_url":"https://api.github.com/repos/bigtestjs/convergence/subscription","commits_url":"https://api.github.com/repos/bigtestjs/convergence/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigtestjs/convergence/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigtestjs/convergence/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigtestjs/convergence/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigtestjs/convergence/contents/{+path}","compare_url":"https://api.github.com/repos/bigtestjs/convergence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigtestjs/convergence/merges","archive_url":"https://api.github.com/repos/bigtestjs/convergence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigtestjs/convergence/downloads","issues_url":"https://api.github.com/repos/bigtestjs/convergence/issues{/number}","pulls_url":"https://api.github.com/repos/bigtestjs/convergence/pulls{/number}","milestones_url":"https://api.github.com/repos/bigtestjs/convergence/milestones{/number}","notifications_url":"https://api.github.com/repos/bigtestjs/convergence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigtestjs/convergence/labels{/name}","releases_url":"https://api.github.com/repos/bigtestjs/convergence/releases{/id}","deployments_url":"https://api.github.com/repos/bigtestjs/convergence/deployments","created_at":"2018-04-13T17:54:51Z","updated_at":"2018-04-25T14:30:08Z","pushed_at":"2018-04-13T17:57:58Z","git_url":"git://github.com/bigtestjs/convergence.git","ssh_url":"git@github.com:bigtestjs/convergence.git","clone_url":"https://github.com/bigtestjs/convergence.git","svn_url":"https://github.com/bigtestjs/convergence","homepage":null,"size":142,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigtestjs/convergence/pulls/5"},"html":{"href":"https://github.com/bigtestjs/convergence/pull/5"},"issue":{"href":"https://api.github.com/repos/bigtestjs/convergence/issues/5"},"comments":{"href":"https://api.github.com/repos/bigtestjs/convergence/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/bigtestjs/convergence/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/bigtestjs/convergence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigtestjs/convergence/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/bigtestjs/convergence/statuses/e74548da3e2d2b992cb7014e08ea26bd0e7f1d92"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":53,"deletions":0,"changed_files":6}}
{"actor":{"display_login":"robbiepitts"}}