{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/framework/issues/24885","repository_url":"https://api.github.com/repos/laravel/framework","labels_url":"https://api.github.com/repos/laravel/framework/issues/24885/labels{/name}","comments_url":"https://api.github.com/repos/laravel/framework/issues/24885/comments","events_url":"https://api.github.com/repos/laravel/framework/issues/24885/events","html_url":"https://github.com/laravel/framework/pull/24885","id":342430851,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzMyNDkx","number":24885,"title":"[5.6] revert #24872","user":{"login":"browner12","id":5232313,"node_id":"MDQ6VXNlcjUyMzIzMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/5232313?v=4","gravatar_id":"","url":"https://api.github.com/users/browner12","html_url":"https://github.com/browner12","followers_url":"https://api.github.com/users/browner12/followers","following_url":"https://api.github.com/users/browner12/following{/other_user}","gists_url":"https://api.github.com/users/browner12/gists{/gist_id}","starred_url":"https://api.github.com/users/browner12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/browner12/subscriptions","organizations_url":"https://api.github.com/users/browner12/orgs","repos_url":"https://api.github.com/users/browner12/repos","events_url":"https://api.github.com/users/browner12/events{/privacy}","received_events_url":"https://api.github.com/users/browner12/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-18T17:54:57Z","updated_at":"2018-07-19T14:33:28Z","closed_at":"2018-07-19T01:29:54Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/24885","html_url":"https://github.com/laravel/framework/pull/24885","diff_url":"https://github.com/laravel/framework/pull/24885.diff","patch_url":"https://github.com/laravel/framework/pull/24885.patch"},"body":"#24872 causes a BC break when the user passes an array to the function.\r\n\r\n```php\r\n$request->is(['pathA', 'pathB']);\r\n```\r\n\r\nThis code worked on previous versions, but not after the change due to the fact the method uses the splat operator which wraps the input array in an additional array.\r\n\r\nWhile I agree it should not be used this way in the future, and should be changed in 5.7, I believe it is a BC break for 5.6.  If this is accepted, I will make the PR to 5.7."},"comment":{"url":"https://api.github.com/repos/laravel/framework/issues/comments/406297703","html_url":"https://github.com/laravel/framework/pull/24885#issuecomment-406297703","issue_url":"https://api.github.com/repos/laravel/framework/issues/24885","id":406297703,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjI5NzcwMw==","user":{"login":"36864","id":7127588,"node_id":"MDQ6VXNlcjcxMjc1ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/7127588?v=4","gravatar_id":"","url":"https://api.github.com/users/36864","html_url":"https://github.com/36864","followers_url":"https://api.github.com/users/36864/followers","following_url":"https://api.github.com/users/36864/following{/other_user}","gists_url":"https://api.github.com/users/36864/gists{/gist_id}","starred_url":"https://api.github.com/users/36864/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/36864/subscriptions","organizations_url":"https://api.github.com/users/36864/orgs","repos_url":"https://api.github.com/users/36864/repos","events_url":"https://api.github.com/users/36864/events{/privacy}","received_events_url":"https://api.github.com/users/36864/received_events","type":"User","site_admin":false},"created_at":"2018-07-19T14:33:28Z","updated_at":"2018-07-19T14:33:28Z","author_association":"CONTRIBUTOR","body":"You can still pass multiple values into the function, just as a dynamic parameter instead of an array, like this:\r\n```\r\n$request->is('route_a', 'route_b', 'route_c');\r\n```"}}
{"actor":{"display_login":"36864"}}