{"action":"opened","number":175,"pull_request":{"url":"https://api.github.com/repos/dbashford/textract/pulls/175","id":224245982,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MjQ1OTgy","html_url":"https://github.com/dbashford/textract/pull/175","diff_url":"https://github.com/dbashford/textract/pull/175.diff","patch_url":"https://github.com/dbashford/textract/pull/175.patch","issue_url":"https://api.github.com/repos/dbashford/textract/issues/175","number":175,"state":"open","locked":false,"title":"Return error on unknown text file encoding","user":{"login":"Konijnendijk","id":5391162,"node_id":"MDQ6VXNlcjUzOTExNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/5391162?v=4","gravatar_id":"","url":"https://api.github.com/users/Konijnendijk","html_url":"https://github.com/Konijnendijk","followers_url":"https://api.github.com/users/Konijnendijk/followers","following_url":"https://api.github.com/users/Konijnendijk/following{/other_user}","gists_url":"https://api.github.com/users/Konijnendijk/gists{/gist_id}","starred_url":"https://api.github.com/users/Konijnendijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Konijnendijk/subscriptions","organizations_url":"https://api.github.com/users/Konijnendijk/orgs","repos_url":"https://api.github.com/users/Konijnendijk/repos","events_url":"https://api.github.com/users/Konijnendijk/events{/privacy}","received_events_url":"https://api.github.com/users/Konijnendijk/received_events","type":"User","site_admin":false},"body":"This PR fixes the case when the encoding detection library cannot detect the file encoding. It will now return an error. I added a test with an empty text file that triggers this case. \r\n\r\nLet me know if you have any questions or other remarks!\r\n\r\n","created_at":"2018-10-19T10:48:54Z","updated_at":"2018-10-19T10:48:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dbashford/textract/pulls/175/commits","review_comments_url":"https://api.github.com/repos/dbashford/textract/pulls/175/comments","review_comment_url":"https://api.github.com/repos/dbashford/textract/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dbashford/textract/issues/175/comments","statuses_url":"https://api.github.com/repos/dbashford/textract/statuses/091007357c8cec2325219ee7ee72b4c89483221a","head":{"label":"Konijnendijk:error_on_unknown_encoding","ref":"error_on_unknown_encoding","sha":"091007357c8cec2325219ee7ee72b4c89483221a","user":{"login":"Konijnendijk","id":5391162,"node_id":"MDQ6VXNlcjUzOTExNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/5391162?v=4","gravatar_id":"","url":"https://api.github.com/users/Konijnendijk","html_url":"https://github.com/Konijnendijk","followers_url":"https://api.github.com/users/Konijnendijk/followers","following_url":"https://api.github.com/users/Konijnendijk/following{/other_user}","gists_url":"https://api.github.com/users/Konijnendijk/gists{/gist_id}","starred_url":"https://api.github.com/users/Konijnendijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Konijnendijk/subscriptions","organizations_url":"https://api.github.com/users/Konijnendijk/orgs","repos_url":"https://api.github.com/users/Konijnendijk/repos","events_url":"https://api.github.com/users/Konijnendijk/events{/privacy}","received_events_url":"https://api.github.com/users/Konijnendijk/received_events","type":"User","site_admin":false},"repo":{"id":153762233,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3NjIyMzM=","name":"textract","full_name":"Konijnendijk/textract","private":false,"owner":{"login":"Konijnendijk","id":5391162,"node_id":"MDQ6VXNlcjUzOTExNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/5391162?v=4","gravatar_id":"","url":"https://api.github.com/users/Konijnendijk","html_url":"https://github.com/Konijnendijk","followers_url":"https://api.github.com/users/Konijnendijk/followers","following_url":"https://api.github.com/users/Konijnendijk/following{/other_user}","gists_url":"https://api.github.com/users/Konijnendijk/gists{/gist_id}","starred_url":"https://api.github.com/users/Konijnendijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Konijnendijk/subscriptions","organizations_url":"https://api.github.com/users/Konijnendijk/orgs","repos_url":"https://api.github.com/users/Konijnendijk/repos","events_url":"https://api.github.com/users/Konijnendijk/events{/privacy}","received_events_url":"https://api.github.com/users/Konijnendijk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Konijnendijk/textract","description":"node.js module for extracting text from html, pdf, doc, docx, xls, xlsx, csv, pptx, png, jpg, gif, rtf and more!","fork":true,"url":"https://api.github.com/repos/Konijnendijk/textract","forks_url":"https://api.github.com/repos/Konijnendijk/textract/forks","keys_url":"https://api.github.com/repos/Konijnendijk/textract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Konijnendijk/textract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Konijnendijk/textract/teams","hooks_url":"https://api.github.com/repos/Konijnendijk/textract/hooks","issue_events_url":"https://api.github.com/repos/Konijnendijk/textract/issues/events{/number}","events_url":"https://api.github.com/repos/Konijnendijk/textract/events","assignees_url":"https://api.github.com/repos/Konijnendijk/textract/assignees{/user}","branches_url":"https://api.github.com/repos/Konijnendijk/textract/branches{/branch}","tags_url":"https://api.github.com/repos/Konijnendijk/textract/tags","blobs_url":"https://api.github.com/repos/Konijnendijk/textract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Konijnendijk/textract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Konijnendijk/textract/git/refs{/sha}","trees_url":"https://api.github.com/repos/Konijnendijk/textract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Konijnendijk/textract/statuses/{sha}","languages_url":"https://api.github.com/repos/Konijnendijk/textract/languages","stargazers_url":"https://api.github.com/repos/Konijnendijk/textract/stargazers","contributors_url":"https://api.github.com/repos/Konijnendijk/textract/contributors","subscribers_url":"https://api.github.com/repos/Konijnendijk/textract/subscribers","subscription_url":"https://api.github.com/repos/Konijnendijk/textract/subscription","commits_url":"https://api.github.com/repos/Konijnendijk/textract/commits{/sha}","git_commits_url":"https://api.github.com/repos/Konijnendijk/textract/git/commits{/sha}","comments_url":"https://api.github.com/repos/Konijnendijk/textract/comments{/number}","issue_comment_url":"https://api.github.com/repos/Konijnendijk/textract/issues/comments{/number}","contents_url":"https://api.github.com/repos/Konijnendijk/textract/contents/{+path}","compare_url":"https://api.github.com/repos/Konijnendijk/textract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Konijnendijk/textract/merges","archive_url":"https://api.github.com/repos/Konijnendijk/textract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Konijnendijk/textract/downloads","issues_url":"https://api.github.com/repos/Konijnendijk/textract/issues{/number}","pulls_url":"https://api.github.com/repos/Konijnendijk/textract/pulls{/number}","milestones_url":"https://api.github.com/repos/Konijnendijk/textract/milestones{/number}","notifications_url":"https://api.github.com/repos/Konijnendijk/textract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Konijnendijk/textract/labels{/name}","releases_url":"https://api.github.com/repos/Konijnendijk/textract/releases{/id}","deployments_url":"https://api.github.com/repos/Konijnendijk/textract/deployments","created_at":"2018-10-19T09:54:59Z","updated_at":"2018-10-19T09:55:02Z","pushed_at":"2018-10-19T10:40:21Z","git_url":"git://github.com/Konijnendijk/textract.git","ssh_url":"git@github.com:Konijnendijk/textract.git","clone_url":"https://github.com/Konijnendijk/textract.git","svn_url":"https://github.com/Konijnendijk/textract","homepage":"","size":5252,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dbashford:master","ref":"master","sha":"9ad4aa6620f51522a28e67ae4aef2ee3982f1f2d","user":{"login":"dbashford","id":581127,"node_id":"MDQ6VXNlcjU4MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/581127?v=4","gravatar_id":"","url":"https://api.github.com/users/dbashford","html_url":"https://github.com/dbashford","followers_url":"https://api.github.com/users/dbashford/followers","following_url":"https://api.github.com/users/dbashford/following{/other_user}","gists_url":"https://api.github.com/users/dbashford/gists{/gist_id}","starred_url":"https://api.github.com/users/dbashford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbashford/subscriptions","organizations_url":"https://api.github.com/users/dbashford/orgs","repos_url":"https://api.github.com/users/dbashford/repos","events_url":"https://api.github.com/users/dbashford/events{/privacy}","received_events_url":"https://api.github.com/users/dbashford/received_events","type":"User","site_admin":false},"repo":{"id":9626416,"node_id":"MDEwOlJlcG9zaXRvcnk5NjI2NDE2","name":"textract","full_name":"dbashford/textract","private":false,"owner":{"login":"dbashford","id":581127,"node_id":"MDQ6VXNlcjU4MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/581127?v=4","gravatar_id":"","url":"https://api.github.com/users/dbashford","html_url":"https://github.com/dbashford","followers_url":"https://api.github.com/users/dbashford/followers","following_url":"https://api.github.com/users/dbashford/following{/other_user}","gists_url":"https://api.github.com/users/dbashford/gists{/gist_id}","starred_url":"https://api.github.com/users/dbashford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbashford/subscriptions","organizations_url":"https://api.github.com/users/dbashford/orgs","repos_url":"https://api.github.com/users/dbashford/repos","events_url":"https://api.github.com/users/dbashford/events{/privacy}","received_events_url":"https://api.github.com/users/dbashford/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dbashford/textract","description":"node.js module for extracting text from html, pdf, doc, docx, xls, xlsx, csv, pptx, png, jpg, gif, rtf and more!","fork":false,"url":"https://api.github.com/repos/dbashford/textract","forks_url":"https://api.github.com/repos/dbashford/textract/forks","keys_url":"https://api.github.com/repos/dbashford/textract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbashford/textract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbashford/textract/teams","hooks_url":"https://api.github.com/repos/dbashford/textract/hooks","issue_events_url":"https://api.github.com/repos/dbashford/textract/issues/events{/number}","events_url":"https://api.github.com/repos/dbashford/textract/events","assignees_url":"https://api.github.com/repos/dbashford/textract/assignees{/user}","branches_url":"https://api.github.com/repos/dbashford/textract/branches{/branch}","tags_url":"https://api.github.com/repos/dbashford/textract/tags","blobs_url":"https://api.github.com/repos/dbashford/textract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbashford/textract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbashford/textract/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbashford/textract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbashford/textract/statuses/{sha}","languages_url":"https://api.github.com/repos/dbashford/textract/languages","stargazers_url":"https://api.github.com/repos/dbashford/textract/stargazers","contributors_url":"https://api.github.com/repos/dbashford/textract/contributors","subscribers_url":"https://api.github.com/repos/dbashford/textract/subscribers","subscription_url":"https://api.github.com/repos/dbashford/textract/subscription","commits_url":"https://api.github.com/repos/dbashford/textract/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbashford/textract/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbashford/textract/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbashford/textract/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbashford/textract/contents/{+path}","compare_url":"https://api.github.com/repos/dbashford/textract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbashford/textract/merges","archive_url":"https://api.github.com/repos/dbashford/textract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbashford/textract/downloads","issues_url":"https://api.github.com/repos/dbashford/textract/issues{/number}","pulls_url":"https://api.github.com/repos/dbashford/textract/pulls{/number}","milestones_url":"https://api.github.com/repos/dbashford/textract/milestones{/number}","notifications_url":"https://api.github.com/repos/dbashford/textract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbashford/textract/labels{/name}","releases_url":"https://api.github.com/repos/dbashford/textract/releases{/id}","deployments_url":"https://api.github.com/repos/dbashford/textract/deployments","created_at":"2013-04-23T15:26:43Z","updated_at":"2018-10-17T23:56:13Z","pushed_at":"2018-09-13T12:07:16Z","git_url":"git://github.com/dbashford/textract.git","ssh_url":"git@github.com:dbashford/textract.git","clone_url":"https://github.com/dbashford/textract.git","svn_url":"https://github.com/dbashford/textract","homepage":"","size":5252,"stargazers_count":1037,"watchers_count":1037,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":106,"open_issues":24,"watchers":1037,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dbashford/textract/pulls/175"},"html":{"href":"https://github.com/dbashford/textract/pull/175"},"issue":{"href":"https://api.github.com/repos/dbashford/textract/issues/175"},"comments":{"href":"https://api.github.com/repos/dbashford/textract/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/dbashford/textract/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/dbashford/textract/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dbashford/textract/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/dbashford/textract/statuses/091007357c8cec2325219ee7ee72b4c89483221a"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":20,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"Konijnendijk"}}