{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/pulls/17","id":228141451,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTQxNDUx","html_url":"https://github.com/julianghionoiu/tdl-client-dotnet/pull/17","diff_url":"https://github.com/julianghionoiu/tdl-client-dotnet/pull/17.diff","patch_url":"https://github.com/julianghionoiu/tdl-client-dotnet/pull/17.patch","issue_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/issues/17","number":17,"state":"closed","locked":false,"title":"Update test spec as per tdl client java changes","user":{"login":"neomatrix369","id":1570917,"node_id":"MDQ6VXNlcjE1NzA5MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1570917?v=4","gravatar_id":"","url":"https://api.github.com/users/neomatrix369","html_url":"https://github.com/neomatrix369","followers_url":"https://api.github.com/users/neomatrix369/followers","following_url":"https://api.github.com/users/neomatrix369/following{/other_user}","gists_url":"https://api.github.com/users/neomatrix369/gists{/gist_id}","starred_url":"https://api.github.com/users/neomatrix369/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neomatrix369/subscriptions","organizations_url":"https://api.github.com/users/neomatrix369/orgs","repos_url":"https://api.github.com/users/neomatrix369/repos","events_url":"https://api.github.com/users/neomatrix369/events{/privacy}","received_events_url":"https://api.github.com/users/neomatrix369/received_events","type":"User","site_admin":false},"body":"Question: the package is called tdl.client on `nuget`, the more appropriate name would be tdl.client.dotnet or something of that kind. What do you think?\r\n\r\nIt will lead to change in name and references across the different places but it would be worth doing it for consistency sake","created_at":"2018-11-03T21:09:26Z","updated_at":"2018-11-04T15:53:48Z","closed_at":"2018-11-04T15:53:48Z","merged_at":"2018-11-04T15:53:48Z","merge_commit_sha":"f3cfc229fd14fdbd27f10fd0d76bc63f2e6187a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":684455157,"node_id":"MDU6TGFiZWw2ODQ0NTUxNTc=","url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/pulls/17/commits","review_comments_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/pulls/17/comments","review_comment_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/issues/17/comments","statuses_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/statuses/0c93dfd5dffce2fa5ad76b45826e4b7e1f1b8c28","head":{"label":"julianghionoiu:update-test-spec-as-per-tdl-client-jave-changes","ref":"update-test-spec-as-per-tdl-client-jave-changes","sha":"0c93dfd5dffce2fa5ad76b45826e4b7e1f1b8c28","user":{"login":"julianghionoiu","id":5089833,"node_id":"MDQ6VXNlcjUwODk4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5089833?v=4","gravatar_id":"","url":"https://api.github.com/users/julianghionoiu","html_url":"https://github.com/julianghionoiu","followers_url":"https://api.github.com/users/julianghionoiu/followers","following_url":"https://api.github.com/users/julianghionoiu/following{/other_user}","gists_url":"https://api.github.com/users/julianghionoiu/gists{/gist_id}","starred_url":"https://api.github.com/users/julianghionoiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianghionoiu/subscriptions","organizations_url":"https://api.github.com/users/julianghionoiu/orgs","repos_url":"https://api.github.com/users/julianghionoiu/repos","events_url":"https://api.github.com/users/julianghionoiu/events{/privacy}","received_events_url":"https://api.github.com/users/julianghionoiu/received_events","type":"User","site_admin":false},"repo":{"id":102540843,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NDA4NDM=","name":"tdl-client-dotnet","full_name":"julianghionoiu/tdl-client-dotnet","private":false,"owner":{"login":"julianghionoiu","id":5089833,"node_id":"MDQ6VXNlcjUwODk4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5089833?v=4","gravatar_id":"","url":"https://api.github.com/users/julianghionoiu","html_url":"https://github.com/julianghionoiu","followers_url":"https://api.github.com/users/julianghionoiu/followers","following_url":"https://api.github.com/users/julianghionoiu/following{/other_user}","gists_url":"https://api.github.com/users/julianghionoiu/gists{/gist_id}","starred_url":"https://api.github.com/users/julianghionoiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianghionoiu/subscriptions","organizations_url":"https://api.github.com/users/julianghionoiu/orgs","repos_url":"https://api.github.com/users/julianghionoiu/repos","events_url":"https://api.github.com/users/julianghionoiu/events{/privacy}","received_events_url":"https://api.github.com/users/julianghionoiu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/julianghionoiu/tdl-client-dotnet","description":"tdl-client-dotnet","fork":false,"url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet","forks_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/forks","keys_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/teams","hooks_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/hooks","issue_events_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/events","assignees_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/tags","blobs_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/languages","stargazers_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/stargazers","contributors_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/contributors","subscribers_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/subscribers","subscription_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/subscription","commits_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/merges","archive_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/downloads","issues_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/deployments","created_at":"2017-09-05T23:49:55Z","updated_at":"2018-09-25T06:42:46Z","pushed_at":"2018-11-04T15:53:48Z","git_url":"git://github.com/julianghionoiu/tdl-client-dotnet.git","ssh_url":"git@github.com:julianghionoiu/tdl-client-dotnet.git","clone_url":"https://github.com/julianghionoiu/tdl-client-dotnet.git","svn_url":"https://github.com/julianghionoiu/tdl-client-dotnet","homepage":null,"size":141,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"julianghionoiu:master","ref":"master","sha":"1d604d54dd146301ff3f8d15419f651f0ab20ff4","user":{"login":"julianghionoiu","id":5089833,"node_id":"MDQ6VXNlcjUwODk4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5089833?v=4","gravatar_id":"","url":"https://api.github.com/users/julianghionoiu","html_url":"https://github.com/julianghionoiu","followers_url":"https://api.github.com/users/julianghionoiu/followers","following_url":"https://api.github.com/users/julianghionoiu/following{/other_user}","gists_url":"https://api.github.com/users/julianghionoiu/gists{/gist_id}","starred_url":"https://api.github.com/users/julianghionoiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianghionoiu/subscriptions","organizations_url":"https://api.github.com/users/julianghionoiu/orgs","repos_url":"https://api.github.com/users/julianghionoiu/repos","events_url":"https://api.github.com/users/julianghionoiu/events{/privacy}","received_events_url":"https://api.github.com/users/julianghionoiu/received_events","type":"User","site_admin":false},"repo":{"id":102540843,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NDA4NDM=","name":"tdl-client-dotnet","full_name":"julianghionoiu/tdl-client-dotnet","private":false,"owner":{"login":"julianghionoiu","id":5089833,"node_id":"MDQ6VXNlcjUwODk4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5089833?v=4","gravatar_id":"","url":"https://api.github.com/users/julianghionoiu","html_url":"https://github.com/julianghionoiu","followers_url":"https://api.github.com/users/julianghionoiu/followers","following_url":"https://api.github.com/users/julianghionoiu/following{/other_user}","gists_url":"https://api.github.com/users/julianghionoiu/gists{/gist_id}","starred_url":"https://api.github.com/users/julianghionoiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianghionoiu/subscriptions","organizations_url":"https://api.github.com/users/julianghionoiu/orgs","repos_url":"https://api.github.com/users/julianghionoiu/repos","events_url":"https://api.github.com/users/julianghionoiu/events{/privacy}","received_events_url":"https://api.github.com/users/julianghionoiu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/julianghionoiu/tdl-client-dotnet","description":"tdl-client-dotnet","fork":false,"url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet","forks_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/forks","keys_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/teams","hooks_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/hooks","issue_events_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/events","assignees_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/tags","blobs_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/languages","stargazers_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/stargazers","contributors_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/contributors","subscribers_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/subscribers","subscription_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/subscription","commits_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/merges","archive_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/downloads","issues_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/deployments","created_at":"2017-09-05T23:49:55Z","updated_at":"2018-09-25T06:42:46Z","pushed_at":"2018-11-04T15:53:48Z","git_url":"git://github.com/julianghionoiu/tdl-client-dotnet.git","ssh_url":"git@github.com:julianghionoiu/tdl-client-dotnet.git","clone_url":"https://github.com/julianghionoiu/tdl-client-dotnet.git","svn_url":"https://github.com/julianghionoiu/tdl-client-dotnet","homepage":null,"size":141,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/pulls/17"},"html":{"href":"https://github.com/julianghionoiu/tdl-client-dotnet/pull/17"},"issue":{"href":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/issues/17"},"comments":{"href":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/julianghionoiu/tdl-client-dotnet/statuses/0c93dfd5dffce2fa5ad76b45826e4b7e1f1b8c28"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"julianghionoiu","id":5089833,"node_id":"MDQ6VXNlcjUwODk4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5089833?v=4","gravatar_id":"","url":"https://api.github.com/users/julianghionoiu","html_url":"https://github.com/julianghionoiu","followers_url":"https://api.github.com/users/julianghionoiu/followers","following_url":"https://api.github.com/users/julianghionoiu/following{/other_user}","gists_url":"https://api.github.com/users/julianghionoiu/gists{/gist_id}","starred_url":"https://api.github.com/users/julianghionoiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianghionoiu/subscriptions","organizations_url":"https://api.github.com/users/julianghionoiu/orgs","repos_url":"https://api.github.com/users/julianghionoiu/repos","events_url":"https://api.github.com/users/julianghionoiu/events{/privacy}","received_events_url":"https://api.github.com/users/julianghionoiu/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":6,"additions":184,"deletions":189,"changed_files":24}}
{"actor":{"display_login":"julianghionoiu"}}