{"action":"created","comment":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/comments/227009190","pull_request_review_id":166952901,"id":227009190,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzAwOTE5MA==","diff_hunk":"@@ -14199,7 +14199,7 @@ static int lcommunity_list_unset_vty(struct vty *vty, int argc,\n \t\tvty_out(vty, \"This config option is deprecated, and is scheduled for removal.\\n\");\n \t\tvty_out(vty, \"if you are using this please migrate to the below command.\\n\");\n \t\tvty_out(vty, \"'no bgp large-community-list <(1-99)|(100-500)|standard|expanded> <deny|permit> <LINE|AA:BB:CC>'\\n\");\n-\t\tzlog_warn(\"Deprecated option: 'no ip large-community-list <(1-99)|(100-500)|standard|expanded> <deny|permit> <LINE|AA:BB:CC>' being used\");\t\n+\t\tzlog_warn(\"Deprecated option: 'no ip large-community-list <(1-99)|(100-500)|standard|expanded> <deny|permit> <LINE|AA:BB:CC>' being used\");\n \t}","path":"bgpd/bgp_vty.c","position":27,"original_position":27,"commit_id":"a3d203515e8f70e59ed172aaebe5bbb7afbd7896","original_commit_id":"a3d203515e8f70e59ed172aaebe5bbb7afbd7896","user":{"login":"ton31337","id":3352707,"node_id":"MDQ6VXNlcjMzNTI3MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3352707?v=4","gravatar_id":"","url":"https://api.github.com/users/ton31337","html_url":"https://github.com/ton31337","followers_url":"https://api.github.com/users/ton31337/followers","following_url":"https://api.github.com/users/ton31337/following{/other_user}","gists_url":"https://api.github.com/users/ton31337/gists{/gist_id}","starred_url":"https://api.github.com/users/ton31337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ton31337/subscriptions","organizations_url":"https://api.github.com/users/ton31337/orgs","repos_url":"https://api.github.com/users/ton31337/repos","events_url":"https://api.github.com/users/ton31337/events{/privacy}","received_events_url":"https://api.github.com/users/ton31337/received_events","type":"User","site_admin":false},"body":"vscode just removed them automatically. or should I leave them as they were?","created_at":"2018-10-22T14:45:13Z","updated_at":"2018-10-22T14:45:13Z","html_url":"https://github.com/FRRouting/frr/pull/3204#discussion_r227009190","pull_request_url":"https://api.github.com/repos/FRRouting/frr/pulls/3204","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments/227009190"},"html":{"href":"https://github.com/FRRouting/frr/pull/3204#discussion_r227009190"},"pull_request":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/3204"}},"in_reply_to_id":227007964},"pull_request":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/3204","id":224278799,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Mjc4Nzk5","html_url":"https://github.com/FRRouting/frr/pull/3204","diff_url":"https://github.com/FRRouting/frr/pull/3204.diff","patch_url":"https://github.com/FRRouting/frr/pull/3204.patch","issue_url":"https://api.github.com/repos/FRRouting/frr/issues/3204","number":3204,"state":"open","locked":false,"title":"bgpd: Select default routing table when importing VRF routes into global","user":{"login":"ton31337","id":3352707,"node_id":"MDQ6VXNlcjMzNTI3MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3352707?v=4","gravatar_id":"","url":"https://api.github.com/users/ton31337","html_url":"https://github.com/ton31337","followers_url":"https://api.github.com/users/ton31337/followers","following_url":"https://api.github.com/users/ton31337/following{/other_user}","gists_url":"https://api.github.com/users/ton31337/gists{/gist_id}","starred_url":"https://api.github.com/users/ton31337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ton31337/subscriptions","organizations_url":"https://api.github.com/users/ton31337/orgs","repos_url":"https://api.github.com/users/ton31337/repos","events_url":"https://api.github.com/users/ton31337/events{/privacy}","received_events_url":"https://api.github.com/users/ton31337/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>\r\n\r\n### Summary\r\nI just encountered the problem unless asked in Slack/read the source when importing global routes into arbitrary VRF. It's much easier when you have an option to choose instantly the default instead of eyeballing what's the name of it (default, Default-IP-Routing-Table)\r\n\r\n### Components\r\nbgpd","created_at":"2018-10-19T12:58:51Z","updated_at":"2018-10-22T14:45:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffbdb3adbef822bfb5c75f2cabd42d9b992e94b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FRRouting/frr/pulls/3204/commits","review_comments_url":"https://api.github.com/repos/FRRouting/frr/pulls/3204/comments","review_comment_url":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FRRouting/frr/issues/3204/comments","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/a3d203515e8f70e59ed172aaebe5bbb7afbd7896","head":{"label":"ton31337:fix/make_vrf_import_default_selectable","ref":"fix/make_vrf_import_default_selectable","sha":"a3d203515e8f70e59ed172aaebe5bbb7afbd7896","user":{"login":"ton31337","id":3352707,"node_id":"MDQ6VXNlcjMzNTI3MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3352707?v=4","gravatar_id":"","url":"https://api.github.com/users/ton31337","html_url":"https://github.com/ton31337","followers_url":"https://api.github.com/users/ton31337/followers","following_url":"https://api.github.com/users/ton31337/following{/other_user}","gists_url":"https://api.github.com/users/ton31337/gists{/gist_id}","starred_url":"https://api.github.com/users/ton31337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ton31337/subscriptions","organizations_url":"https://api.github.com/users/ton31337/orgs","repos_url":"https://api.github.com/users/ton31337/repos","events_url":"https://api.github.com/users/ton31337/events{/privacy}","received_events_url":"https://api.github.com/users/ton31337/received_events","type":"User","site_admin":false},"repo":{"id":141319061,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMTkwNjE=","name":"frr","full_name":"ton31337/frr","private":false,"owner":{"login":"ton31337","id":3352707,"node_id":"MDQ6VXNlcjMzNTI3MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3352707?v=4","gravatar_id":"","url":"https://api.github.com/users/ton31337","html_url":"https://github.com/ton31337","followers_url":"https://api.github.com/users/ton31337/followers","following_url":"https://api.github.com/users/ton31337/following{/other_user}","gists_url":"https://api.github.com/users/ton31337/gists{/gist_id}","starred_url":"https://api.github.com/users/ton31337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ton31337/subscriptions","organizations_url":"https://api.github.com/users/ton31337/orgs","repos_url":"https://api.github.com/users/ton31337/repos","events_url":"https://api.github.com/users/ton31337/events{/privacy}","received_events_url":"https://api.github.com/users/ton31337/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ton31337/frr","description":"The FRRouting Protocol Suite","fork":true,"url":"https://api.github.com/repos/ton31337/frr","forks_url":"https://api.github.com/repos/ton31337/frr/forks","keys_url":"https://api.github.com/repos/ton31337/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ton31337/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ton31337/frr/teams","hooks_url":"https://api.github.com/repos/ton31337/frr/hooks","issue_events_url":"https://api.github.com/repos/ton31337/frr/issues/events{/number}","events_url":"https://api.github.com/repos/ton31337/frr/events","assignees_url":"https://api.github.com/repos/ton31337/frr/assignees{/user}","branches_url":"https://api.github.com/repos/ton31337/frr/branches{/branch}","tags_url":"https://api.github.com/repos/ton31337/frr/tags","blobs_url":"https://api.github.com/repos/ton31337/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ton31337/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ton31337/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/ton31337/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ton31337/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/ton31337/frr/languages","stargazers_url":"https://api.github.com/repos/ton31337/frr/stargazers","contributors_url":"https://api.github.com/repos/ton31337/frr/contributors","subscribers_url":"https://api.github.com/repos/ton31337/frr/subscribers","subscription_url":"https://api.github.com/repos/ton31337/frr/subscription","commits_url":"https://api.github.com/repos/ton31337/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/ton31337/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/ton31337/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/ton31337/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/ton31337/frr/contents/{+path}","compare_url":"https://api.github.com/repos/ton31337/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ton31337/frr/merges","archive_url":"https://api.github.com/repos/ton31337/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ton31337/frr/downloads","issues_url":"https://api.github.com/repos/ton31337/frr/issues{/number}","pulls_url":"https://api.github.com/repos/ton31337/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/ton31337/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/ton31337/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ton31337/frr/labels{/name}","releases_url":"https://api.github.com/repos/ton31337/frr/releases{/id}","deployments_url":"https://api.github.com/repos/ton31337/frr/deployments","created_at":"2018-07-17T16:58:56Z","updated_at":"2018-10-14T18:24:45Z","pushed_at":"2018-10-22T10:12:36Z","git_url":"git://github.com/ton31337/frr.git","ssh_url":"git@github.com:ton31337/frr.git","clone_url":"https://github.com/ton31337/frr.git","svn_url":"https://github.com/ton31337/frr","homepage":"https://frrouting.org/","size":47139,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FRRouting:master","ref":"master","sha":"9a2deb2473f7d337f472792308a41c52b7feb6e2","user":{"login":"FRRouting","id":24592672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTkyNjcy","avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"repo":{"id":76599439,"node_id":"MDEwOlJlcG9zaXRvcnk3NjU5OTQzOQ==","name":"frr","full_name":"FRRouting/frr","private":false,"owner":{"login":"FRRouting","id":24592672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTkyNjcy","avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FRRouting/frr","description":"The FRRouting Protocol Suite","fork":false,"url":"https://api.github.com/repos/FRRouting/frr","forks_url":"https://api.github.com/repos/FRRouting/frr/forks","keys_url":"https://api.github.com/repos/FRRouting/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FRRouting/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FRRouting/frr/teams","hooks_url":"https://api.github.com/repos/FRRouting/frr/hooks","issue_events_url":"https://api.github.com/repos/FRRouting/frr/issues/events{/number}","events_url":"https://api.github.com/repos/FRRouting/frr/events","assignees_url":"https://api.github.com/repos/FRRouting/frr/assignees{/user}","branches_url":"https://api.github.com/repos/FRRouting/frr/branches{/branch}","tags_url":"https://api.github.com/repos/FRRouting/frr/tags","blobs_url":"https://api.github.com/repos/FRRouting/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FRRouting/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FRRouting/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/FRRouting/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/FRRouting/frr/languages","stargazers_url":"https://api.github.com/repos/FRRouting/frr/stargazers","contributors_url":"https://api.github.com/repos/FRRouting/frr/contributors","subscribers_url":"https://api.github.com/repos/FRRouting/frr/subscribers","subscription_url":"https://api.github.com/repos/FRRouting/frr/subscription","commits_url":"https://api.github.com/repos/FRRouting/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/FRRouting/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/FRRouting/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/FRRouting/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/FRRouting/frr/contents/{+path}","compare_url":"https://api.github.com/repos/FRRouting/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FRRouting/frr/merges","archive_url":"https://api.github.com/repos/FRRouting/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FRRouting/frr/downloads","issues_url":"https://api.github.com/repos/FRRouting/frr/issues{/number}","pulls_url":"https://api.github.com/repos/FRRouting/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/FRRouting/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/FRRouting/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FRRouting/frr/labels{/name}","releases_url":"https://api.github.com/repos/FRRouting/frr/releases{/id}","deployments_url":"https://api.github.com/repos/FRRouting/frr/deployments","created_at":"2016-12-15T21:56:38Z","updated_at":"2018-10-21T14:31:06Z","pushed_at":"2018-10-22T14:37:36Z","git_url":"git://github.com/FRRouting/frr.git","ssh_url":"git@github.com:FRRouting/frr.git","clone_url":"https://github.com/FRRouting/frr.git","svn_url":"https://github.com/FRRouting/frr","homepage":"https://frrouting.org/","size":47334,"stargazers_count":680,"watchers_count":680,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":283,"mirror_url":null,"archived":false,"open_issues_count":322,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":283,"open_issues":322,"watchers":680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/3204"},"html":{"href":"https://github.com/FRRouting/frr/pull/3204"},"issue":{"href":"https://api.github.com/repos/FRRouting/frr/issues/3204"},"comments":{"href":"https://api.github.com/repos/FRRouting/frr/issues/3204/comments"},"review_comments":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/3204/comments"},"review_comment":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/3204/commits"},"statuses":{"href":"https://api.github.com/repos/FRRouting/frr/statuses/a3d203515e8f70e59ed172aaebe5bbb7afbd7896"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ton31337"}}