{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/comments/234303157","pull_request_review_id":175923711,"id":234303157,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDMwMzE1Nw==","diff_hunk":"@@ -31,6 +31,7 @@\n #import \"MSIDLogger+Internal.h\"\n #import \"MSIDError.h\"\n #import \"MSIDOAuth2Constants.h\"\n+#import \"MSIDCredentialCacheItem+MSIDBaseToken.h\"","path":"IdentityCore/src/IdentityCore_Internal.h","position":4,"original_position":4,"commit_id":"c2461adfca32e5fba4e5c4234e3426b2a1ec3dc1","original_commit_id":"c2461adfca32e5fba4e5c4234e3426b2a1ec3dc1","user":{"login":"oldalton","id":26911890,"node_id":"MDQ6VXNlcjI2OTExODkw","avatar_url":"https://avatars0.githubusercontent.com/u/26911890?v=4","gravatar_id":"","url":"https://api.github.com/users/oldalton","html_url":"https://github.com/oldalton","followers_url":"https://api.github.com/users/oldalton/followers","following_url":"https://api.github.com/users/oldalton/following{/other_user}","gists_url":"https://api.github.com/users/oldalton/gists{/gist_id}","starred_url":"https://api.github.com/users/oldalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oldalton/subscriptions","organizations_url":"https://api.github.com/users/oldalton/orgs","repos_url":"https://api.github.com/users/oldalton/repos","events_url":"https://api.github.com/users/oldalton/events{/privacy}","received_events_url":"https://api.github.com/users/oldalton/received_events","type":"User","site_admin":false},"body":"I don't think this needs to be in the Internal header. It's probably only used in 2-3 classes.","created_at":"2018-11-16T18:22:59Z","updated_at":"2018-11-16T18:23:03Z","html_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/288#discussion_r234303157","pull_request_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/288","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/comments/234303157"},"html":{"href":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/288#discussion_r234303157"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/288"}}},"pull_request":{"url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/288","id":230946213,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTQ2MjEz","html_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/288","diff_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/288.diff","patch_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/288.patch","issue_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/288","number":288,"state":"open","locked":false,"title":"Account/credential refactoring","user":{"login":"d-col","id":41696779,"node_id":"MDQ6VXNlcjQxNjk2Nzc5","avatar_url":"https://avatars3.githubusercontent.com/u/41696779?v=4","gravatar_id":"","url":"https://api.github.com/users/d-col","html_url":"https://github.com/d-col","followers_url":"https://api.github.com/users/d-col/followers","following_url":"https://api.github.com/users/d-col/following{/other_user}","gists_url":"https://api.github.com/users/d-col/gists{/gist_id}","starred_url":"https://api.github.com/users/d-col/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-col/subscriptions","organizations_url":"https://api.github.com/users/d-col/orgs","repos_url":"https://api.github.com/users/d-col/repos","events_url":"https://api.github.com/users/d-col/events{/privacy}","received_events_url":"https://api.github.com/users/d-col/received_events","type":"User","site_admin":false},"body":"This is a very small amount of refactoring of the MSIDCredentialCacheItem & MSIDAccountCacheItem objects so we can use them directly in msalcpp builds _without_ needing the previously-proposed temporary objects (i.e. MSIDCommonCredential). This prevents needing to work on a long-duration branch as was discussed in the previous PR.\r\n\r\n- The main proposed change is allowing moving MSIDCredentialCacheItem's tokenWithType into a Category, since it causes our build some problems. There's no impact on normal builds of MSIDCredentialCacheItem.\r\n- We use a tracing macro, which I #defined to /**/ in the normal non-msalcpp builds. I added calls to it in a couple of places. Hopefully others can just ignore these.\r\n- We compile with warnings-as-errors so I fixed a pair of compiler warnings with \"__unused\".\r\n- (I was able to avoid needing the #ifndef header checks I had added to the logging headers, so I've now removed them.)","created_at":"2018-11-14T19:01:39Z","updated_at":"2018-11-16T18:23:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"989a2beabd08364ba276da5c1b275ba16dce7818","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/288/commits","review_comments_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/288/comments","review_comment_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/288/comments","statuses_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/statuses/c2461adfca32e5fba4e5c4234e3426b2a1ec3dc1","head":{"label":"AzureAD:d-col/msalcpp_common_baseobjs","ref":"d-col/msalcpp_common_baseobjs","sha":"c2461adfca32e5fba4e5c4234e3426b2a1ec3dc1","user":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":109302939,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkzMDI5Mzk=","name":"microsoft-authentication-library-common-for-objc","full_name":"AzureAD/microsoft-authentication-library-common-for-objc","private":false,"owner":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc","description":"Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)","fork":false,"url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc","forks_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/forks","keys_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/teams","hooks_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/events","assignees_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/tags","blobs_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/languages","stargazers_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/subscription","commits_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/merges","archive_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/downloads","issues_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/deployments","created_at":"2017-11-02T18:22:35Z","updated_at":"2018-11-05T19:41:50Z","pushed_at":"2018-11-16T17:03:09Z","git_url":"git://github.com/AzureAD/microsoft-authentication-library-common-for-objc.git","ssh_url":"git@github.com:AzureAD/microsoft-authentication-library-common-for-objc.git","clone_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc.git","svn_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc","homepage":null,"size":4253,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":48,"watchers":2,"default_branch":"master"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"41402f2385c9610f9cc72e5b7fe2f453831d90d4","user":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":109302939,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkzMDI5Mzk=","name":"microsoft-authentication-library-common-for-objc","full_name":"AzureAD/microsoft-authentication-library-common-for-objc","private":false,"owner":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc","description":"Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)","fork":false,"url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc","forks_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/forks","keys_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/teams","hooks_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/events","assignees_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/tags","blobs_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/languages","stargazers_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/subscription","commits_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/merges","archive_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/downloads","issues_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/deployments","created_at":"2017-11-02T18:22:35Z","updated_at":"2018-11-05T19:41:50Z","pushed_at":"2018-11-16T17:03:09Z","git_url":"git://github.com/AzureAD/microsoft-authentication-library-common-for-objc.git","ssh_url":"git@github.com:AzureAD/microsoft-authentication-library-common-for-objc.git","clone_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc.git","svn_url":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc","homepage":null,"size":4253,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":48,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/288"},"html":{"href":"https://github.com/AzureAD/microsoft-authentication-library-common-for-objc/pull/288"},"issue":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/288"},"comments":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/microsoft-authentication-library-common-for-objc/statuses/c2461adfca32e5fba4e5c4234e3426b2a1ec3dc1"}},"author_association":"NONE"}}
{"actor":{"display_login":"oldalton"}}