{"action":"opened","number":578,"pull_request":{"url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/pulls/578","id":202640162,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNjQwMTYy","html_url":"https://github.com/bitcoin-core/bitcoincore.org/pull/578","diff_url":"https://github.com/bitcoin-core/bitcoincore.org/pull/578.diff","patch_url":"https://github.com/bitcoin-core/bitcoincore.org/pull/578.patch","issue_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/issues/578","number":578,"state":"open","locked":false,"title":"HTML: xml escape page titles","user":{"login":"harding","id":61096,"node_id":"MDQ6VXNlcjYxMDk2","avatar_url":"https://avatars2.githubusercontent.com/u/61096?v=4","gravatar_id":"","url":"https://api.github.com/users/harding","html_url":"https://github.com/harding","followers_url":"https://api.github.com/users/harding/followers","following_url":"https://api.github.com/users/harding/following{/other_user}","gists_url":"https://api.github.com/users/harding/gists{/gist_id}","starred_url":"https://api.github.com/users/harding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harding/subscriptions","organizations_url":"https://api.github.com/users/harding/orgs","repos_url":"https://api.github.com/users/harding/repos","events_url":"https://api.github.com/users/harding/events{/privacy}","received_events_url":"https://api.github.com/users/harding/received_events","type":"User","site_admin":false},"body":"When we use HTML directly (not through parsed Markdown), XML entities need to be escaped.  Our tests catch cases where that doesn't happen, so we don't need to be fastidious about it, but in this case I was trying to add a page with an ampersand in the title and these were the places where the tests complained.\r\n\r\nVerified via a diff of the rendered site compared to master that this produces no changes in the rendered site for all current content.","created_at":"2018-07-19T18:05:07Z","updated_at":"2018-07-19T18:05:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/pulls/578/commits","review_comments_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/pulls/578/comments","review_comment_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/issues/578/comments","statuses_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/statuses/b843fd7cf98af138df11130ea8e07d2d5025f7aa","head":{"label":"harding:2018-07-xml-escape-titles","ref":"2018-07-xml-escape-titles","sha":"b843fd7cf98af138df11130ea8e07d2d5025f7aa","user":{"login":"harding","id":61096,"node_id":"MDQ6VXNlcjYxMDk2","avatar_url":"https://avatars2.githubusercontent.com/u/61096?v=4","gravatar_id":"","url":"https://api.github.com/users/harding","html_url":"https://github.com/harding","followers_url":"https://api.github.com/users/harding/followers","following_url":"https://api.github.com/users/harding/following{/other_user}","gists_url":"https://api.github.com/users/harding/gists{/gist_id}","starred_url":"https://api.github.com/users/harding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harding/subscriptions","organizations_url":"https://api.github.com/users/harding/orgs","repos_url":"https://api.github.com/users/harding/repos","events_url":"https://api.github.com/users/harding/events{/privacy}","received_events_url":"https://api.github.com/users/harding/received_events","type":"User","site_admin":false},"repo":{"id":49340299,"node_id":"MDEwOlJlcG9zaXRvcnk0OTM0MDI5OQ==","name":"website","full_name":"harding/website","owner":{"login":"harding","id":61096,"node_id":"MDQ6VXNlcjYxMDk2","avatar_url":"https://avatars2.githubusercontent.com/u/61096?v=4","gravatar_id":"","url":"https://api.github.com/users/harding","html_url":"https://github.com/harding","followers_url":"https://api.github.com/users/harding/followers","following_url":"https://api.github.com/users/harding/following{/other_user}","gists_url":"https://api.github.com/users/harding/gists{/gist_id}","starred_url":"https://api.github.com/users/harding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harding/subscriptions","organizations_url":"https://api.github.com/users/harding/orgs","repos_url":"https://api.github.com/users/harding/repos","events_url":"https://api.github.com/users/harding/events{/privacy}","received_events_url":"https://api.github.com/users/harding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harding/website","description":"Bitcoin Core main website","fork":true,"url":"https://api.github.com/repos/harding/website","forks_url":"https://api.github.com/repos/harding/website/forks","keys_url":"https://api.github.com/repos/harding/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harding/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harding/website/teams","hooks_url":"https://api.github.com/repos/harding/website/hooks","issue_events_url":"https://api.github.com/repos/harding/website/issues/events{/number}","events_url":"https://api.github.com/repos/harding/website/events","assignees_url":"https://api.github.com/repos/harding/website/assignees{/user}","branches_url":"https://api.github.com/repos/harding/website/branches{/branch}","tags_url":"https://api.github.com/repos/harding/website/tags","blobs_url":"https://api.github.com/repos/harding/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harding/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harding/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/harding/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harding/website/statuses/{sha}","languages_url":"https://api.github.com/repos/harding/website/languages","stargazers_url":"https://api.github.com/repos/harding/website/stargazers","contributors_url":"https://api.github.com/repos/harding/website/contributors","subscribers_url":"https://api.github.com/repos/harding/website/subscribers","subscription_url":"https://api.github.com/repos/harding/website/subscription","commits_url":"https://api.github.com/repos/harding/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/harding/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/harding/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/harding/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/harding/website/contents/{+path}","compare_url":"https://api.github.com/repos/harding/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harding/website/merges","archive_url":"https://api.github.com/repos/harding/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harding/website/downloads","issues_url":"https://api.github.com/repos/harding/website/issues{/number}","pulls_url":"https://api.github.com/repos/harding/website/pulls{/number}","milestones_url":"https://api.github.com/repos/harding/website/milestones{/number}","notifications_url":"https://api.github.com/repos/harding/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harding/website/labels{/name}","releases_url":"https://api.github.com/repos/harding/website/releases{/id}","deployments_url":"https://api.github.com/repos/harding/website/deployments","created_at":"2016-01-09T20:33:23Z","updated_at":"2016-01-16T15:00:41Z","pushed_at":"2018-07-19T18:00:57Z","git_url":"git://github.com/harding/website.git","ssh_url":"git@github.com:harding/website.git","clone_url":"https://github.com/harding/website.git","svn_url":"https://github.com/harding/website","homepage":null,"size":6186,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"gh-pages"}},"base":{"label":"bitcoin-core:master","ref":"master","sha":"1aa9649b01f57adb07e47139c58f422b45c09868","user":{"login":"bitcoin-core","id":13464320,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDY0MzIw","avatar_url":"https://avatars2.githubusercontent.com/u/13464320?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin-core","html_url":"https://github.com/bitcoin-core","followers_url":"https://api.github.com/users/bitcoin-core/followers","following_url":"https://api.github.com/users/bitcoin-core/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin-core/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin-core/subscriptions","organizations_url":"https://api.github.com/users/bitcoin-core/orgs","repos_url":"https://api.github.com/users/bitcoin-core/repos","events_url":"https://api.github.com/users/bitcoin-core/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin-core/received_events","type":"Organization","site_admin":false},"repo":{"id":49334327,"node_id":"MDEwOlJlcG9zaXRvcnk0OTMzNDMyNw==","name":"bitcoincore.org","full_name":"bitcoin-core/bitcoincore.org","owner":{"login":"bitcoin-core","id":13464320,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDY0MzIw","avatar_url":"https://avatars2.githubusercontent.com/u/13464320?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin-core","html_url":"https://github.com/bitcoin-core","followers_url":"https://api.github.com/users/bitcoin-core/followers","following_url":"https://api.github.com/users/bitcoin-core/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin-core/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin-core/subscriptions","organizations_url":"https://api.github.com/users/bitcoin-core/orgs","repos_url":"https://api.github.com/users/bitcoin-core/repos","events_url":"https://api.github.com/users/bitcoin-core/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin-core/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin-core/bitcoincore.org","description":"Bitcoin Core project website","fork":false,"url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org","forks_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/forks","keys_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/teams","hooks_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/hooks","issue_events_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/events","assignees_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/tags","blobs_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/languages","stargazers_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/stargazers","contributors_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/contributors","subscribers_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/subscribers","subscription_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/subscription","commits_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/merges","archive_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/downloads","issues_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/deployments","created_at":"2016-01-09T17:37:52Z","updated_at":"2018-07-14T23:11:18Z","pushed_at":"2018-07-15T14:19:15Z","git_url":"git://github.com/bitcoin-core/bitcoincore.org.git","ssh_url":"git@github.com:bitcoin-core/bitcoincore.org.git","clone_url":"https://github.com/bitcoin-core/bitcoincore.org.git","svn_url":"https://github.com/bitcoin-core/bitcoincore.org","homepage":"https://bitcoincore.org/","size":6134,"stargazers_count":238,"watchers_count":238,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":309,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":309,"open_issues":15,"watchers":238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/pulls/578"},"html":{"href":"https://github.com/bitcoin-core/bitcoincore.org/pull/578"},"issue":{"href":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/issues/578"},"comments":{"href":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/issues/578/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/pulls/578/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/pulls/578/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin-core/bitcoincore.org/statuses/b843fd7cf98af138df11130ea8e07d2d5025f7aa"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":17,"deletions":17,"changed_files":5}}
{"actor":{"display_login":"harding"}}