{"action":"created","comment":{"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments/165700683","pull_request_review_id":93686488,"id":165700683,"diff_hunk":"@@ -108,6 +119,36 @@ export class ReportService {\n     }).catch(ResponseUtils.throwError);","path":"webapp/src/main/webapp/src/app/report/report.service.ts","position":45,"original_position":45,"commit_id":"edce29e78bec71fa085c4d6c175f719a934e6154","original_commit_id":"edce29e78bec71fa085c4d6c175f719a934e6154","user":{"login":"wtritch","id":617828,"avatar_url":"https://avatars3.githubusercontent.com/u/617828?v=4","gravatar_id":"","url":"https://api.github.com/users/wtritch","html_url":"https://github.com/wtritch","followers_url":"https://api.github.com/users/wtritch/followers","following_url":"https://api.github.com/users/wtritch/following{/other_user}","gists_url":"https://api.github.com/users/wtritch/gists{/gist_id}","starred_url":"https://api.github.com/users/wtritch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtritch/subscriptions","organizations_url":"https://api.github.com/users/wtritch/orgs","repos_url":"https://api.github.com/users/wtritch/repos","events_url":"https://api.github.com/users/wtritch/events{/privacy}","received_events_url":"https://api.github.com/users/wtritch/received_events","type":"User","site_admin":false},"body":"We should change the accept above this to \"*/*\" or even remove it altogether.  The download response may be text/csv for an exam export, application/pdf for a student/group report, or application/zip for a large pdf report.","created_at":"2018-02-02T17:01:34Z","updated_at":"2018-02-02T17:01:34Z","html_url":"https://github.com/SmarterApp/RDW_Reporting/pull/822#discussion_r165700683","pull_request_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/822","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments/165700683"},"html":{"href":"https://github.com/SmarterApp/RDW_Reporting/pull/822#discussion_r165700683"},"pull_request":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/822"}}},"pull_request":{"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/822","id":166723942,"html_url":"https://github.com/SmarterApp/RDW_Reporting/pull/822","diff_url":"https://github.com/SmarterApp/RDW_Reporting/pull/822.diff","patch_url":"https://github.com/SmarterApp/RDW_Reporting/pull/822.patch","issue_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/822","number":822,"state":"open","locked":false,"title":"Feature/aggregate result loading","user":{"login":"esotrope","id":23462925,"avatar_url":"https://avatars3.githubusercontent.com/u/23462925?v=4","gravatar_id":"","url":"https://api.github.com/users/esotrope","html_url":"https://github.com/esotrope","followers_url":"https://api.github.com/users/esotrope/followers","following_url":"https://api.github.com/users/esotrope/following{/other_user}","gists_url":"https://api.github.com/users/esotrope/gists{/gist_id}","starred_url":"https://api.github.com/users/esotrope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esotrope/subscriptions","organizations_url":"https://api.github.com/users/esotrope/orgs","repos_url":"https://api.github.com/users/esotrope/repos","events_url":"https://api.github.com/users/esotrope/events{/privacy}","received_events_url":"https://api.github.com/users/esotrope/received_events","type":"User","site_admin":false},"body":"Sorry for the PR size - here's the result:\r\n\r\n![image](https://user-images.githubusercontent.com/23462925/35718612-38a80890-079a-11e8-846f-7a9101cc6d2e.png)\r\n\r\n![image](https://user-images.githubusercontent.com/23462925/35718768-dc1d3694-079a-11e8-831c-5abe71d0fcbb.png)\r\n\r\nResult page now accepts a \"id\" url param.\r\nThis param is resolved to a report resource.\r\nIf the resource is too large we display a friendly error for the wannabe-hackers.\r\nIf the resource size is supported we load the report json if completed or poll until completed then load.\r\n","created_at":"2018-02-02T05:58:58Z","updated_at":"2018-02-02T17:01:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f5d27575198b1a73a5206a165ba9657f94b0b28","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jtreuting","id":341584,"avatar_url":"https://avatars0.githubusercontent.com/u/341584?v=4","gravatar_id":"","url":"https://api.github.com/users/jtreuting","html_url":"https://github.com/jtreuting","followers_url":"https://api.github.com/users/jtreuting/followers","following_url":"https://api.github.com/users/jtreuting/following{/other_user}","gists_url":"https://api.github.com/users/jtreuting/gists{/gist_id}","starred_url":"https://api.github.com/users/jtreuting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtreuting/subscriptions","organizations_url":"https://api.github.com/users/jtreuting/orgs","repos_url":"https://api.github.com/users/jtreuting/repos","events_url":"https://api.github.com/users/jtreuting/events{/privacy}","received_events_url":"https://api.github.com/users/jtreuting/received_events","type":"User","site_admin":false},{"login":"agorina","id":16457484,"avatar_url":"https://avatars2.githubusercontent.com/u/16457484?v=4","gravatar_id":"","url":"https://api.github.com/users/agorina","html_url":"https://github.com/agorina","followers_url":"https://api.github.com/users/agorina/followers","following_url":"https://api.github.com/users/agorina/following{/other_user}","gists_url":"https://api.github.com/users/agorina/gists{/gist_id}","starred_url":"https://api.github.com/users/agorina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agorina/subscriptions","organizations_url":"https://api.github.com/users/agorina/orgs","repos_url":"https://api.github.com/users/agorina/repos","events_url":"https://api.github.com/users/agorina/events{/privacy}","received_events_url":"https://api.github.com/users/agorina/received_events","type":"User","site_admin":false},{"login":"dsnyder-fairway","id":33040425,"avatar_url":"https://avatars1.githubusercontent.com/u/33040425?v=4","gravatar_id":"","url":"https://api.github.com/users/dsnyder-fairway","html_url":"https://github.com/dsnyder-fairway","followers_url":"https://api.github.com/users/dsnyder-fairway/followers","following_url":"https://api.github.com/users/dsnyder-fairway/following{/other_user}","gists_url":"https://api.github.com/users/dsnyder-fairway/gists{/gist_id}","starred_url":"https://api.github.com/users/dsnyder-fairway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsnyder-fairway/subscriptions","organizations_url":"https://api.github.com/users/dsnyder-fairway/orgs","repos_url":"https://api.github.com/users/dsnyder-fairway/repos","events_url":"https://api.github.com/users/dsnyder-fairway/events{/privacy}","received_events_url":"https://api.github.com/users/dsnyder-fairway/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/822/commits","review_comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/822/comments","review_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/822/comments","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/edce29e78bec71fa085c4d6c175f719a934e6154","head":{"label":"SmarterApp:feature/aggregate-result-loading","ref":"feature/aggregate-result-loading","sha":"edce29e78bec71fa085c4d6c175f719a934e6154","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":81362154,"name":"RDW_Reporting","full_name":"SmarterApp/RDW_Reporting","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/RDW_Reporting","description":"RDW reporting tier (web app, backend services, etc.)","fork":false,"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting","forks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/forks","keys_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/teams","hooks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/events","assignees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/tags","blobs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscription","commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/merges","archive_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/downloads","issues_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/deployments","created_at":"2017-02-08T18:31:23Z","updated_at":"2017-08-01T00:10:23Z","pushed_at":"2018-02-02T06:30:52Z","git_url":"git://github.com/SmarterApp/RDW_Reporting.git","ssh_url":"git@github.com:SmarterApp/RDW_Reporting.git","clone_url":"https://github.com/SmarterApp/RDW_Reporting.git","svn_url":"https://github.com/SmarterApp/RDW_Reporting","homepage":null,"size":22141,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"SmarterApp:develop","ref":"develop","sha":"67faf71e011d6c4d76e3d20ea137702f6bd55c98","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":81362154,"name":"RDW_Reporting","full_name":"SmarterApp/RDW_Reporting","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/RDW_Reporting","description":"RDW reporting tier (web app, backend services, etc.)","fork":false,"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting","forks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/forks","keys_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/teams","hooks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/events","assignees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/tags","blobs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscription","commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/merges","archive_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/downloads","issues_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/deployments","created_at":"2017-02-08T18:31:23Z","updated_at":"2017-08-01T00:10:23Z","pushed_at":"2018-02-02T06:30:52Z","git_url":"git://github.com/SmarterApp/RDW_Reporting.git","ssh_url":"git@github.com:SmarterApp/RDW_Reporting.git","clone_url":"https://github.com/SmarterApp/RDW_Reporting.git","svn_url":"https://github.com/SmarterApp/RDW_Reporting","homepage":null,"size":22141,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/822"},"html":{"href":"https://github.com/SmarterApp/RDW_Reporting/pull/822"},"issue":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/822"},"comments":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/822/comments"},"review_comments":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/822/comments"},"review_comment":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/822/commits"},"statuses":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/edce29e78bec71fa085c4d6c175f719a934e6154"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wtritch"}}