{"action":"created","issue":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1701","repository_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1701/labels{/name}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1701/comments","events_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1701/events","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1701","id":306457967,"number":1701,"title":"Adding missing implementation of different itests","user":{"login":"odockal","id":19164299,"avatar_url":"https://avatars0.githubusercontent.com/u/19164299?v=4","gravatar_id":"","url":"https://api.github.com/users/odockal","html_url":"https://github.com/odockal","followers_url":"https://api.github.com/users/odockal/followers","following_url":"https://api.github.com/users/odockal/following{/other_user}","gists_url":"https://api.github.com/users/odockal/gists{/gist_id}","starred_url":"https://api.github.com/users/odockal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odockal/subscriptions","organizations_url":"https://api.github.com/users/odockal/orgs","repos_url":"https://api.github.com/users/odockal/repos","events_url":"https://api.github.com/users/odockal/events{/privacy}","received_events_url":"https://api.github.com/users/odockal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-19T13:16:44Z","updated_at":"2018-03-19T13:24:02Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1701","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1701","diff_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1701.diff","patch_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1701.patch"},"body":"   - CDKLabel class encapsulating labels, shells, buttons, etc.\r\n   - Added test for validating OC in workspace\r\n   - Added test for multiple OS 3 connection discovery feature (not impl. yet)\r\n   - Added test for skip registration propagation into launch config\r\n   - CleanDockerexplorerRequirement added\r\n\r\nSigned-off-by: Ondrej Dockal <odockal@redhat.com>\r\n\r\n# Pull Request Checklist\r\n## General\r\n* Is this a blocking issue or new feature? If yes, QE needs to +1 this PR\r\n\r\n## Code\r\n* Are method-/class-/variable-names meaningful?\r\n* Are methods concise, not too long?\r\n* Are catch blocks catching precise Exceptions only (no catch all)?\r\n\r\n## Testing\r\n* Are there unit-tests?\r\n* Are there integration tests (or at least a jira to tackle these)?\r\n* Is the non-happy path working, too?\r\n* Are other parts that use the same component still working fine?\r\n\r\n## Function\r\n* Does it work?\r\n"},"comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/comments/374209856","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1701#issuecomment-374209856","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1701","id":374209856,"user":{"login":"adietish","id":25126,"avatar_url":"https://avatars3.githubusercontent.com/u/25126?v=4","gravatar_id":"","url":"https://api.github.com/users/adietish","html_url":"https://github.com/adietish","followers_url":"https://api.github.com/users/adietish/followers","following_url":"https://api.github.com/users/adietish/following{/other_user}","gists_url":"https://api.github.com/users/adietish/gists{/gist_id}","starred_url":"https://api.github.com/users/adietish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adietish/subscriptions","organizations_url":"https://api.github.com/users/adietish/orgs","repos_url":"https://api.github.com/users/adietish/repos","events_url":"https://api.github.com/users/adietish/events{/privacy}","received_events_url":"https://api.github.com/users/adietish/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T13:24:02Z","updated_at":"2018-03-19T13:24:02Z","author_association":"MEMBER","body":"...in the doing."}}
{"actor":{"display_login":"adietish"}}