{"action":"created","comment":{"url":"https://api.github.com/repos/tamminhdao/httpServer/pulls/comments/165845508","pull_request_review_id":93846351,"id":165845508,"diff_hunk":"@@ -1,3 +1,3 @@\n public protocol HttpAction {\n-    func execute(request: HttpRequest)\n+    func execute(request: HttpRequest) -> HttpResponse\n }","path":"Sources/HttpServer/Actions/ActionProtocol.swift","position":4,"original_position":4,"commit_id":"2c1f2deb4053ceeff667e452c8e5339215b071b1","original_commit_id":"2c1f2deb4053ceeff667e452c8e5339215b071b1","user":{"login":"cmvandrevala","id":159011,"avatar_url":"https://avatars0.githubusercontent.com/u/159011?v=4","gravatar_id":"","url":"https://api.github.com/users/cmvandrevala","html_url":"https://github.com/cmvandrevala","followers_url":"https://api.github.com/users/cmvandrevala/followers","following_url":"https://api.github.com/users/cmvandrevala/following{/other_user}","gists_url":"https://api.github.com/users/cmvandrevala/gists{/gist_id}","starred_url":"https://api.github.com/users/cmvandrevala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmvandrevala/subscriptions","organizations_url":"https://api.github.com/users/cmvandrevala/orgs","repos_url":"https://api.github.com/users/cmvandrevala/repos","events_url":"https://api.github.com/users/cmvandrevala/events{/privacy}","received_events_url":"https://api.github.com/users/cmvandrevala/received_events","type":"User","site_admin":false},"body":"This is a minor detail - try to put a newline at the end of each file.","created_at":"2018-02-04T14:08:57Z","updated_at":"2018-02-04T14:11:10Z","html_url":"https://github.com/tamminhdao/httpServer/pull/14#discussion_r165845508","pull_request_url":"https://api.github.com/repos/tamminhdao/httpServer/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tamminhdao/httpServer/pulls/comments/165845508"},"html":{"href":"https://github.com/tamminhdao/httpServer/pull/14#discussion_r165845508"},"pull_request":{"href":"https://api.github.com/repos/tamminhdao/httpServer/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/tamminhdao/httpServer/pulls/14","id":166986815,"html_url":"https://github.com/tamminhdao/httpServer/pull/14","diff_url":"https://github.com/tamminhdao/httpServer/pull/14.diff","patch_url":"https://github.com/tamminhdao/httpServer/pull/14.patch","issue_url":"https://api.github.com/repos/tamminhdao/httpServer/issues/14","number":14,"state":"open","locked":false,"title":"Refactor (Reminder: Merge this branch to master first)","user":{"login":"tamminhdao","id":11000026,"avatar_url":"https://avatars0.githubusercontent.com/u/11000026?v=4","gravatar_id":"","url":"https://api.github.com/users/tamminhdao","html_url":"https://github.com/tamminhdao","followers_url":"https://api.github.com/users/tamminhdao/followers","following_url":"https://api.github.com/users/tamminhdao/following{/other_user}","gists_url":"https://api.github.com/users/tamminhdao/gists{/gist_id}","starred_url":"https://api.github.com/users/tamminhdao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamminhdao/subscriptions","organizations_url":"https://api.github.com/users/tamminhdao/orgs","repos_url":"https://api.github.com/users/tamminhdao/repos","events_url":"https://api.github.com/users/tamminhdao/events{/privacy}","received_events_url":"https://api.github.com/users/tamminhdao/received_events","type":"User","site_admin":false},"body":"I did some refactoring to address Cyrus's comment on the previous BasicAuth PR.\r\nI now have each Action return a response, so I no longer have that terrible function in the Router with a million nested if statements.\r\n\r\nThis branch doesn't have any Auth code, this is the last point when the simultaneous test was still passing. \r\n","created_at":"2018-02-03T23:59:04Z","updated_at":"2018-02-04T14:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aca44b2fe5c29cb0cf7162cf138235aefcf0a91e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"elizabethengelman","id":4752801,"avatar_url":"https://avatars1.githubusercontent.com/u/4752801?v=4","gravatar_id":"","url":"https://api.github.com/users/elizabethengelman","html_url":"https://github.com/elizabethengelman","followers_url":"https://api.github.com/users/elizabethengelman/followers","following_url":"https://api.github.com/users/elizabethengelman/following{/other_user}","gists_url":"https://api.github.com/users/elizabethengelman/gists{/gist_id}","starred_url":"https://api.github.com/users/elizabethengelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elizabethengelman/subscriptions","organizations_url":"https://api.github.com/users/elizabethengelman/orgs","repos_url":"https://api.github.com/users/elizabethengelman/repos","events_url":"https://api.github.com/users/elizabethengelman/events{/privacy}","received_events_url":"https://api.github.com/users/elizabethengelman/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/tamminhdao/httpServer/pulls/14/commits","review_comments_url":"https://api.github.com/repos/tamminhdao/httpServer/pulls/14/comments","review_comment_url":"https://api.github.com/repos/tamminhdao/httpServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tamminhdao/httpServer/issues/14/comments","statuses_url":"https://api.github.com/repos/tamminhdao/httpServer/statuses/2c1f2deb4053ceeff667e452c8e5339215b071b1","head":{"label":"tamminhdao:refactor","ref":"refactor","sha":"2c1f2deb4053ceeff667e452c8e5339215b071b1","user":{"login":"tamminhdao","id":11000026,"avatar_url":"https://avatars0.githubusercontent.com/u/11000026?v=4","gravatar_id":"","url":"https://api.github.com/users/tamminhdao","html_url":"https://github.com/tamminhdao","followers_url":"https://api.github.com/users/tamminhdao/followers","following_url":"https://api.github.com/users/tamminhdao/following{/other_user}","gists_url":"https://api.github.com/users/tamminhdao/gists{/gist_id}","starred_url":"https://api.github.com/users/tamminhdao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamminhdao/subscriptions","organizations_url":"https://api.github.com/users/tamminhdao/orgs","repos_url":"https://api.github.com/users/tamminhdao/repos","events_url":"https://api.github.com/users/tamminhdao/events{/privacy}","received_events_url":"https://api.github.com/users/tamminhdao/received_events","type":"User","site_admin":false},"repo":{"id":113230710,"name":"httpServer","full_name":"tamminhdao/httpServer","owner":{"login":"tamminhdao","id":11000026,"avatar_url":"https://avatars0.githubusercontent.com/u/11000026?v=4","gravatar_id":"","url":"https://api.github.com/users/tamminhdao","html_url":"https://github.com/tamminhdao","followers_url":"https://api.github.com/users/tamminhdao/followers","following_url":"https://api.github.com/users/tamminhdao/following{/other_user}","gists_url":"https://api.github.com/users/tamminhdao/gists{/gist_id}","starred_url":"https://api.github.com/users/tamminhdao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamminhdao/subscriptions","organizations_url":"https://api.github.com/users/tamminhdao/orgs","repos_url":"https://api.github.com/users/tamminhdao/repos","events_url":"https://api.github.com/users/tamminhdao/events{/privacy}","received_events_url":"https://api.github.com/users/tamminhdao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tamminhdao/httpServer","description":null,"fork":false,"url":"https://api.github.com/repos/tamminhdao/httpServer","forks_url":"https://api.github.com/repos/tamminhdao/httpServer/forks","keys_url":"https://api.github.com/repos/tamminhdao/httpServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tamminhdao/httpServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tamminhdao/httpServer/teams","hooks_url":"https://api.github.com/repos/tamminhdao/httpServer/hooks","issue_events_url":"https://api.github.com/repos/tamminhdao/httpServer/issues/events{/number}","events_url":"https://api.github.com/repos/tamminhdao/httpServer/events","assignees_url":"https://api.github.com/repos/tamminhdao/httpServer/assignees{/user}","branches_url":"https://api.github.com/repos/tamminhdao/httpServer/branches{/branch}","tags_url":"https://api.github.com/repos/tamminhdao/httpServer/tags","blobs_url":"https://api.github.com/repos/tamminhdao/httpServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tamminhdao/httpServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tamminhdao/httpServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/tamminhdao/httpServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tamminhdao/httpServer/statuses/{sha}","languages_url":"https://api.github.com/repos/tamminhdao/httpServer/languages","stargazers_url":"https://api.github.com/repos/tamminhdao/httpServer/stargazers","contributors_url":"https://api.github.com/repos/tamminhdao/httpServer/contributors","subscribers_url":"https://api.github.com/repos/tamminhdao/httpServer/subscribers","subscription_url":"https://api.github.com/repos/tamminhdao/httpServer/subscription","commits_url":"https://api.github.com/repos/tamminhdao/httpServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/tamminhdao/httpServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/tamminhdao/httpServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/tamminhdao/httpServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/tamminhdao/httpServer/contents/{+path}","compare_url":"https://api.github.com/repos/tamminhdao/httpServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tamminhdao/httpServer/merges","archive_url":"https://api.github.com/repos/tamminhdao/httpServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tamminhdao/httpServer/downloads","issues_url":"https://api.github.com/repos/tamminhdao/httpServer/issues{/number}","pulls_url":"https://api.github.com/repos/tamminhdao/httpServer/pulls{/number}","milestones_url":"https://api.github.com/repos/tamminhdao/httpServer/milestones{/number}","notifications_url":"https://api.github.com/repos/tamminhdao/httpServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tamminhdao/httpServer/labels{/name}","releases_url":"https://api.github.com/repos/tamminhdao/httpServer/releases{/id}","deployments_url":"https://api.github.com/repos/tamminhdao/httpServer/deployments","created_at":"2017-12-05T20:39:48Z","updated_at":"2018-01-16T19:10:16Z","pushed_at":"2018-02-03T23:59:04Z","git_url":"git://github.com/tamminhdao/httpServer.git","ssh_url":"git@github.com:tamminhdao/httpServer.git","clone_url":"https://github.com/tamminhdao/httpServer.git","svn_url":"https://github.com/tamminhdao/httpServer","homepage":null,"size":149,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"tamminhdao:master","ref":"master","sha":"86cb1453938767330e56c82dac6f83e39c09473c","user":{"login":"tamminhdao","id":11000026,"avatar_url":"https://avatars0.githubusercontent.com/u/11000026?v=4","gravatar_id":"","url":"https://api.github.com/users/tamminhdao","html_url":"https://github.com/tamminhdao","followers_url":"https://api.github.com/users/tamminhdao/followers","following_url":"https://api.github.com/users/tamminhdao/following{/other_user}","gists_url":"https://api.github.com/users/tamminhdao/gists{/gist_id}","starred_url":"https://api.github.com/users/tamminhdao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamminhdao/subscriptions","organizations_url":"https://api.github.com/users/tamminhdao/orgs","repos_url":"https://api.github.com/users/tamminhdao/repos","events_url":"https://api.github.com/users/tamminhdao/events{/privacy}","received_events_url":"https://api.github.com/users/tamminhdao/received_events","type":"User","site_admin":false},"repo":{"id":113230710,"name":"httpServer","full_name":"tamminhdao/httpServer","owner":{"login":"tamminhdao","id":11000026,"avatar_url":"https://avatars0.githubusercontent.com/u/11000026?v=4","gravatar_id":"","url":"https://api.github.com/users/tamminhdao","html_url":"https://github.com/tamminhdao","followers_url":"https://api.github.com/users/tamminhdao/followers","following_url":"https://api.github.com/users/tamminhdao/following{/other_user}","gists_url":"https://api.github.com/users/tamminhdao/gists{/gist_id}","starred_url":"https://api.github.com/users/tamminhdao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamminhdao/subscriptions","organizations_url":"https://api.github.com/users/tamminhdao/orgs","repos_url":"https://api.github.com/users/tamminhdao/repos","events_url":"https://api.github.com/users/tamminhdao/events{/privacy}","received_events_url":"https://api.github.com/users/tamminhdao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tamminhdao/httpServer","description":null,"fork":false,"url":"https://api.github.com/repos/tamminhdao/httpServer","forks_url":"https://api.github.com/repos/tamminhdao/httpServer/forks","keys_url":"https://api.github.com/repos/tamminhdao/httpServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tamminhdao/httpServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tamminhdao/httpServer/teams","hooks_url":"https://api.github.com/repos/tamminhdao/httpServer/hooks","issue_events_url":"https://api.github.com/repos/tamminhdao/httpServer/issues/events{/number}","events_url":"https://api.github.com/repos/tamminhdao/httpServer/events","assignees_url":"https://api.github.com/repos/tamminhdao/httpServer/assignees{/user}","branches_url":"https://api.github.com/repos/tamminhdao/httpServer/branches{/branch}","tags_url":"https://api.github.com/repos/tamminhdao/httpServer/tags","blobs_url":"https://api.github.com/repos/tamminhdao/httpServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tamminhdao/httpServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tamminhdao/httpServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/tamminhdao/httpServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tamminhdao/httpServer/statuses/{sha}","languages_url":"https://api.github.com/repos/tamminhdao/httpServer/languages","stargazers_url":"https://api.github.com/repos/tamminhdao/httpServer/stargazers","contributors_url":"https://api.github.com/repos/tamminhdao/httpServer/contributors","subscribers_url":"https://api.github.com/repos/tamminhdao/httpServer/subscribers","subscription_url":"https://api.github.com/repos/tamminhdao/httpServer/subscription","commits_url":"https://api.github.com/repos/tamminhdao/httpServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/tamminhdao/httpServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/tamminhdao/httpServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/tamminhdao/httpServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/tamminhdao/httpServer/contents/{+path}","compare_url":"https://api.github.com/repos/tamminhdao/httpServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tamminhdao/httpServer/merges","archive_url":"https://api.github.com/repos/tamminhdao/httpServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tamminhdao/httpServer/downloads","issues_url":"https://api.github.com/repos/tamminhdao/httpServer/issues{/number}","pulls_url":"https://api.github.com/repos/tamminhdao/httpServer/pulls{/number}","milestones_url":"https://api.github.com/repos/tamminhdao/httpServer/milestones{/number}","notifications_url":"https://api.github.com/repos/tamminhdao/httpServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tamminhdao/httpServer/labels{/name}","releases_url":"https://api.github.com/repos/tamminhdao/httpServer/releases{/id}","deployments_url":"https://api.github.com/repos/tamminhdao/httpServer/deployments","created_at":"2017-12-05T20:39:48Z","updated_at":"2018-01-16T19:10:16Z","pushed_at":"2018-02-03T23:59:04Z","git_url":"git://github.com/tamminhdao/httpServer.git","ssh_url":"git@github.com:tamminhdao/httpServer.git","clone_url":"https://github.com/tamminhdao/httpServer.git","svn_url":"https://github.com/tamminhdao/httpServer","homepage":null,"size":149,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tamminhdao/httpServer/pulls/14"},"html":{"href":"https://github.com/tamminhdao/httpServer/pull/14"},"issue":{"href":"https://api.github.com/repos/tamminhdao/httpServer/issues/14"},"comments":{"href":"https://api.github.com/repos/tamminhdao/httpServer/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/tamminhdao/httpServer/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/tamminhdao/httpServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tamminhdao/httpServer/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/tamminhdao/httpServer/statuses/2c1f2deb4053ceeff667e452c8e5339215b071b1"}},"author_association":"OWNER"}}
{"actor":{"display_login":"cmvandrevala"}}