{"action":"created","comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/169800058","pull_request_review_id":98387008,"id":169800058,"diff_hunk":"@@ -26,4 +26,6 @@ python -m kubeflow.testing.run_e2e_workflow \\\n \t--cluster=kubeflow-testing \\\n \t--bucket=kubernetes-jenkins \\\n \t--component=workflows \\\n-\t--app_dir=/src/kubeflow/kubeflow/testing/workflows\n+\t--app_dir=/src/kubeflow/kubeflow/testing/workflows \\","path":"testing/run.sh","position":5,"original_position":5,"commit_id":"4cad818d0f3fd2f026d8c565c3205d167ffc3c52","original_commit_id":"4cad818d0f3fd2f026d8c565c3205d167ffc3c52","user":{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"body":"Just check if prow_config.yaml exists and if it doesn't invoke the current command and if it does invoke the new command.\r\n\r\nThen you can rebuild the image and the image will be backwards compatible. Then you don't depend on any changes  to kubeflow/testing.","created_at":"2018-02-21T22:33:40Z","updated_at":"2018-02-21T22:33:44Z","html_url":"https://github.com/kubeflow/kubeflow/pull/275#discussion_r169800058","pull_request_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/275","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/169800058"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/275#discussion_r169800058"},"pull_request":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/275"}}},"pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/275","id":170584527,"html_url":"https://github.com/kubeflow/kubeflow/pull/275","diff_url":"https://github.com/kubeflow/kubeflow/pull/275.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/275.patch","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/275","number":275,"state":"open","locked":false,"title":"update image to use prow_config if exists","user":{"login":"lluunn","id":32310205,"avatar_url":"https://avatars0.githubusercontent.com/u/32310205?v=4","gravatar_id":"","url":"https://api.github.com/users/lluunn","html_url":"https://github.com/lluunn","followers_url":"https://api.github.com/users/lluunn/followers","following_url":"https://api.github.com/users/lluunn/following{/other_user}","gists_url":"https://api.github.com/users/lluunn/gists{/gist_id}","starred_url":"https://api.github.com/users/lluunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lluunn/subscriptions","organizations_url":"https://api.github.com/users/lluunn/orgs","repos_url":"https://api.github.com/users/lluunn/repos","events_url":"https://api.github.com/users/lluunn/events{/privacy}","received_events_url":"https://api.github.com/users/lluunn/received_events","type":"User","site_admin":false},"body":"depending on https://github.com/kubeflow/testing/pull/39\r\n\r\nAfter this change, we will update the testing image for kubeflow/kubeflow to:\r\n - use prow_config.yaml if exists\r\n - else, use legacy workflow\r\n\r\nThis will be backward compatible, and we can check in the prow_config.yaml later.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/275)\n<!-- Reviewable:end -->\n","created_at":"2018-02-21T20:49:59Z","updated_at":"2018-02-21T22:33:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44c1e880b1cfb63f36feaf33cd5921449b638abd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":796413694,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/XS","name":"size/XS","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/275/commits","review_comments_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/275/comments","review_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/275/comments","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/4cad818d0f3fd2f026d8c565c3205d167ffc3c52","head":{"label":"lluunn:test_image_prow","ref":"test_image_prow","sha":"4cad818d0f3fd2f026d8c565c3205d167ffc3c52","user":{"login":"lluunn","id":32310205,"avatar_url":"https://avatars0.githubusercontent.com/u/32310205?v=4","gravatar_id":"","url":"https://api.github.com/users/lluunn","html_url":"https://github.com/lluunn","followers_url":"https://api.github.com/users/lluunn/followers","following_url":"https://api.github.com/users/lluunn/following{/other_user}","gists_url":"https://api.github.com/users/lluunn/gists{/gist_id}","starred_url":"https://api.github.com/users/lluunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lluunn/subscriptions","organizations_url":"https://api.github.com/users/lluunn/orgs","repos_url":"https://api.github.com/users/lluunn/repos","events_url":"https://api.github.com/users/lluunn/events{/privacy}","received_events_url":"https://api.github.com/users/lluunn/received_events","type":"User","site_admin":false},"repo":{"id":115154099,"name":"kubeflow","full_name":"lluunn/kubeflow","owner":{"login":"lluunn","id":32310205,"avatar_url":"https://avatars0.githubusercontent.com/u/32310205?v=4","gravatar_id":"","url":"https://api.github.com/users/lluunn","html_url":"https://github.com/lluunn","followers_url":"https://api.github.com/users/lluunn/followers","following_url":"https://api.github.com/users/lluunn/following{/other_user}","gists_url":"https://api.github.com/users/lluunn/gists{/gist_id}","starred_url":"https://api.github.com/users/lluunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lluunn/subscriptions","organizations_url":"https://api.github.com/users/lluunn/orgs","repos_url":"https://api.github.com/users/lluunn/repos","events_url":"https://api.github.com/users/lluunn/events{/privacy}","received_events_url":"https://api.github.com/users/lluunn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lluunn/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":true,"url":"https://api.github.com/repos/lluunn/kubeflow","forks_url":"https://api.github.com/repos/lluunn/kubeflow/forks","keys_url":"https://api.github.com/repos/lluunn/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lluunn/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lluunn/kubeflow/teams","hooks_url":"https://api.github.com/repos/lluunn/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/lluunn/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/lluunn/kubeflow/events","assignees_url":"https://api.github.com/repos/lluunn/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/lluunn/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/lluunn/kubeflow/tags","blobs_url":"https://api.github.com/repos/lluunn/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lluunn/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lluunn/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/lluunn/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lluunn/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/lluunn/kubeflow/languages","stargazers_url":"https://api.github.com/repos/lluunn/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/lluunn/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/lluunn/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/lluunn/kubeflow/subscription","commits_url":"https://api.github.com/repos/lluunn/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/lluunn/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/lluunn/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/lluunn/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/lluunn/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/lluunn/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lluunn/kubeflow/merges","archive_url":"https://api.github.com/repos/lluunn/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lluunn/kubeflow/downloads","issues_url":"https://api.github.com/repos/lluunn/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/lluunn/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/lluunn/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/lluunn/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lluunn/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/lluunn/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/lluunn/kubeflow/deployments","created_at":"2017-12-22T22:21:13Z","updated_at":"2017-12-22T22:21:15Z","pushed_at":"2018-02-21T20:44:40Z","git_url":"git://github.com/lluunn/kubeflow.git","ssh_url":"git@github.com:lluunn/kubeflow.git","clone_url":"https://github.com/lluunn/kubeflow.git","svn_url":"https://github.com/lluunn/kubeflow","homepage":"","size":103312,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"d814a0fc1b46189949788dfbaead76331551f08e","user":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":112647343,"name":"kubeflow","full_name":"kubeflow/kubeflow","owner":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeflow/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubeflow/kubeflow","forks_url":"https://api.github.com/repos/kubeflow/kubeflow/forks","keys_url":"https://api.github.com/repos/kubeflow/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/kubeflow/teams","hooks_url":"https://api.github.com/repos/kubeflow/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/kubeflow/events","assignees_url":"https://api.github.com/repos/kubeflow/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/kubeflow/tags","blobs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/kubeflow/languages","stargazers_url":"https://api.github.com/repos/kubeflow/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/kubeflow/subscription","commits_url":"https://api.github.com/repos/kubeflow/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/kubeflow/merges","archive_url":"https://api.github.com/repos/kubeflow/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/kubeflow/downloads","issues_url":"https://api.github.com/repos/kubeflow/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/kubeflow/deployments","created_at":"2017-11-30T18:44:19Z","updated_at":"2018-02-21T13:54:50Z","pushed_at":"2018-02-21T20:50:07Z","git_url":"git://github.com/kubeflow/kubeflow.git","ssh_url":"git@github.com:kubeflow/kubeflow.git","clone_url":"https://github.com/kubeflow/kubeflow.git","svn_url":"https://github.com/kubeflow/kubeflow","homepage":"","size":99863,"stargazers_count":2599,"watchers_count":2599,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":264,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":264,"open_issues":114,"watchers":2599,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/275"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/275"},"issue":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/275"},"comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/kubeflow/statuses/4cad818d0f3fd2f026d8c565c3205d167ffc3c52"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jlewi"}}