{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/212800634","pull_request_review_id":149512485,"id":212800634,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjgwMDYzNA==","diff_hunk":"@@ -0,0 +1,45 @@\n+{ stdenv, lib, fetchFromGitHub, makeWrapper, perl\n+, PodChecker, MIMEtools, HTMLParser\n+, cursesSupport ? true, CursesUI\n+, uriFindSupport ? true, URIFind\n+}:\n+\n+let\n+  perlDeps =\n+    [ MIMEtools HTMLParser ]\n+    ++ lib.optional cursesSupport CursesUI\n+    ++ lib.optional uriFindSupport URIFind;\n+\n+in stdenv.mkDerivation rec {\n+  name = \"extract_url-${version}\";\n+  version = \"1.6.2\";\n+\n+  nativeBuildInputs = [ PodChecker makeWrapper ];\n+  propagatedBuildInputs = [ perl ] ++ perlDeps;\n+\n+  makeFlags = \"prefix=$(out)\";\n+\n+  postPatch = ''\n+    substituteInPlace Makefile --replace /usr/bin/install install","path":"pkgs/applications/misc/extract_url/default.nix","position":23,"original_position":23,"commit_id":"d48ebde8f98ae912346adb01e55af9c67dd0a06a","original_commit_id":"d48ebde8f98ae912346adb01e55af9c67dd0a06a","user":{"login":"jtojnar","id":705123,"node_id":"MDQ6VXNlcjcwNTEyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/705123?v=4","gravatar_id":"","url":"https://api.github.com/users/jtojnar","html_url":"https://github.com/jtojnar","followers_url":"https://api.github.com/users/jtojnar/followers","following_url":"https://api.github.com/users/jtojnar/following{/other_user}","gists_url":"https://api.github.com/users/jtojnar/gists{/gist_id}","starred_url":"https://api.github.com/users/jtojnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtojnar/subscriptions","organizations_url":"https://api.github.com/users/jtojnar/orgs","repos_url":"https://api.github.com/users/jtojnar/repos","events_url":"https://api.github.com/users/jtojnar/events{/privacy}","received_events_url":"https://api.github.com/users/jtojnar/received_events","type":"User","site_admin":false},"body":"Would not adding `INSTALL=install` to `makeFlags` work?","created_at":"2018-08-25T15:01:41Z","updated_at":"2018-08-25T15:01:41Z","html_url":"https://github.com/NixOS/nixpkgs/pull/45624#discussion_r212800634","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45624","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/212800634"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/45624#discussion_r212800634"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45624"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45624","id":210902571,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTAyNTcx","html_url":"https://github.com/NixOS/nixpkgs/pull/45624","diff_url":"https://github.com/NixOS/nixpkgs/pull/45624.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/45624.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45624","number":45624,"state":"open","locked":false,"title":"extract_url: init at 1.6.2","user":{"login":"alyssais","id":2768870,"node_id":"MDQ6VXNlcjI3Njg4NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2768870?v=4","gravatar_id":"","url":"https://api.github.com/users/alyssais","html_url":"https://github.com/alyssais","followers_url":"https://api.github.com/users/alyssais/followers","following_url":"https://api.github.com/users/alyssais/following{/other_user}","gists_url":"https://api.github.com/users/alyssais/gists{/gist_id}","starred_url":"https://api.github.com/users/alyssais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alyssais/subscriptions","organizations_url":"https://api.github.com/users/alyssais/orgs","repos_url":"https://api.github.com/users/alyssais/repos","events_url":"https://api.github.com/users/alyssais/events{/privacy}","received_events_url":"https://api.github.com/users/alyssais/received_events","type":"User","site_admin":false},"body":"<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\n\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\n- Built on platform(s)\n   - [ ] NixOS\n   - [x] macOS\n   - [ ] other Linux distributions\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\n\n---","created_at":"2018-08-25T13:27:49Z","updated_at":"2018-08-25T15:01:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c3d0329078fa00f8f6d2dd3c837a2db6fb6bbad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45624/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45624/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45624/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/d48ebde8f98ae912346adb01e55af9c67dd0a06a","head":{"label":"alyssais:extract_url","ref":"extract_url","sha":"d48ebde8f98ae912346adb01e55af9c67dd0a06a","user":{"login":"alyssais","id":2768870,"node_id":"MDQ6VXNlcjI3Njg4NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2768870?v=4","gravatar_id":"","url":"https://api.github.com/users/alyssais","html_url":"https://github.com/alyssais","followers_url":"https://api.github.com/users/alyssais/followers","following_url":"https://api.github.com/users/alyssais/following{/other_user}","gists_url":"https://api.github.com/users/alyssais/gists{/gist_id}","starred_url":"https://api.github.com/users/alyssais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alyssais/subscriptions","organizations_url":"https://api.github.com/users/alyssais/orgs","repos_url":"https://api.github.com/users/alyssais/repos","events_url":"https://api.github.com/users/alyssais/events{/privacy}","received_events_url":"https://api.github.com/users/alyssais/received_events","type":"User","site_admin":false},"repo":{"id":139425761,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0MjU3NjE=","name":"nixpkgs","full_name":"alyssais/nixpkgs","owner":{"login":"alyssais","id":2768870,"node_id":"MDQ6VXNlcjI3Njg4NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2768870?v=4","gravatar_id":"","url":"https://api.github.com/users/alyssais","html_url":"https://github.com/alyssais","followers_url":"https://api.github.com/users/alyssais/followers","following_url":"https://api.github.com/users/alyssais/following{/other_user}","gists_url":"https://api.github.com/users/alyssais/gists{/gist_id}","starred_url":"https://api.github.com/users/alyssais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alyssais/subscriptions","organizations_url":"https://api.github.com/users/alyssais/orgs","repos_url":"https://api.github.com/users/alyssais/repos","events_url":"https://api.github.com/users/alyssais/events{/privacy}","received_events_url":"https://api.github.com/users/alyssais/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alyssais/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/alyssais/nixpkgs","forks_url":"https://api.github.com/repos/alyssais/nixpkgs/forks","keys_url":"https://api.github.com/repos/alyssais/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alyssais/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alyssais/nixpkgs/teams","hooks_url":"https://api.github.com/repos/alyssais/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/alyssais/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/alyssais/nixpkgs/events","assignees_url":"https://api.github.com/repos/alyssais/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/alyssais/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/alyssais/nixpkgs/tags","blobs_url":"https://api.github.com/repos/alyssais/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alyssais/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alyssais/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/alyssais/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alyssais/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/alyssais/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/alyssais/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/alyssais/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/alyssais/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/alyssais/nixpkgs/subscription","commits_url":"https://api.github.com/repos/alyssais/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/alyssais/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/alyssais/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/alyssais/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/alyssais/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/alyssais/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alyssais/nixpkgs/merges","archive_url":"https://api.github.com/repos/alyssais/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alyssais/nixpkgs/downloads","issues_url":"https://api.github.com/repos/alyssais/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/alyssais/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/alyssais/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/alyssais/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alyssais/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/alyssais/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/alyssais/nixpkgs/deployments","created_at":"2018-07-02T10:06:40Z","updated_at":"2018-08-25T14:57:26Z","pushed_at":"2018-08-25T14:57:23Z","git_url":"git://github.com/alyssais/nixpkgs.git","ssh_url":"git@github.com:alyssais/nixpkgs.git","clone_url":"https://github.com/alyssais/nixpkgs.git","svn_url":"https://github.com/alyssais/nixpkgs","homepage":null,"size":789093,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"nixpkgs-unstable"}},"base":{"label":"NixOS:master","ref":"master","sha":"b74dc6f0f0211860731d31d508027b6d31a342a8","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-08-25T14:02:00Z","pushed_at":"2018-08-25T14:57:20Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":842235,"stargazers_count":2719,"watchers_count":2719,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2969,"mirror_url":null,"archived":false,"open_issues_count":3144,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2969,"open_issues":3144,"watchers":2719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45624"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/45624"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/45624"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/45624/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45624/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45624/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/d48ebde8f98ae912346adb01e55af9c67dd0a06a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jtojnar"}}