{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments/225721515","pull_request_review_id":165384659,"id":225721515,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTcyMTUxNQ==","diff_hunk":"@@ -101,7 +104,26 @@ namespace facter { namespace facts { namespace windows {\n         auto version = result.release.substr(0, lastDot);\n         bool consumerrel = (wmi::get(vals, wmi::producttype) == \"1\");\n         if (version == \"10.0\") {\n-            result.release = consumerrel ? \"10\" : \"2016\";\n+            // Calculate the build number to distinguish between\n+            // Windows Server 2016 and 2019. Note that the kernel\n+            // version is written as <major>.<minor>.<build_number>\n+            auto kernel_version_fact = facts.get<string_value>(fact::kernel_version);\n+            if (! kernel_version_fact) {\n+                LOG_DEBUG(\"Could not resolve the OS release and OS major version facts from the kernel version fact\");\n+                return result;","path":"lib/src/facts/windows/operating_system_resolver.cc","position":29,"original_position":29,"commit_id":"1d0033bc7c9b83b74e6411c36896fc1e9ddf6c41","original_commit_id":"1d0033bc7c9b83b74e6411c36896fc1e9ddf6c41","user":{"login":"ekinanp","id":29735501,"node_id":"MDQ6VXNlcjI5NzM1NTAx","avatar_url":"https://avatars1.githubusercontent.com/u/29735501?v=4","gravatar_id":"","url":"https://api.github.com/users/ekinanp","html_url":"https://github.com/ekinanp","followers_url":"https://api.github.com/users/ekinanp/followers","following_url":"https://api.github.com/users/ekinanp/following{/other_user}","gists_url":"https://api.github.com/users/ekinanp/gists{/gist_id}","starred_url":"https://api.github.com/users/ekinanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekinanp/subscriptions","organizations_url":"https://api.github.com/users/ekinanp/orgs","repos_url":"https://api.github.com/users/ekinanp/repos","events_url":"https://api.github.com/users/ekinanp/events{/privacy}","received_events_url":"https://api.github.com/users/ekinanp/received_events","type":"User","site_admin":false},"body":"No, the acceptance tests are passing for our suite pipelines. However once we add Server 2019 to agent CI, then the acceptance tests will fail without this change.","created_at":"2018-10-16T21:55:32Z","updated_at":"2018-10-16T21:55:32Z","html_url":"https://github.com/puppetlabs/facter/pull/1754#discussion_r225721515","pull_request_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1754","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments/225721515"},"html":{"href":"https://github.com/puppetlabs/facter/pull/1754#discussion_r225721515"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1754"}},"in_reply_to_id":225635028},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/1754","id":223068696,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDY4Njk2","html_url":"https://github.com/puppetlabs/facter/pull/1754","diff_url":"https://github.com/puppetlabs/facter/pull/1754.diff","patch_url":"https://github.com/puppetlabs/facter/pull/1754.patch","issue_url":"https://api.github.com/repos/puppetlabs/facter/issues/1754","number":1754,"state":"open","locked":false,"title":"(FACT-1889) Update os release fact to include Windows Server 2019","user":{"login":"ekinanp","id":29735501,"node_id":"MDQ6VXNlcjI5NzM1NTAx","avatar_url":"https://avatars1.githubusercontent.com/u/29735501?v=4","gravatar_id":"","url":"https://api.github.com/users/ekinanp","html_url":"https://github.com/ekinanp","followers_url":"https://api.github.com/users/ekinanp/followers","following_url":"https://api.github.com/users/ekinanp/following{/other_user}","gists_url":"https://api.github.com/users/ekinanp/gists{/gist_id}","starred_url":"https://api.github.com/users/ekinanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekinanp/subscriptions","organizations_url":"https://api.github.com/users/ekinanp/orgs","repos_url":"https://api.github.com/users/ekinanp/repos","events_url":"https://api.github.com/users/ekinanp/events{/privacy}","received_events_url":"https://api.github.com/users/ekinanp/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-15T23:03:56Z","updated_at":"2018-10-16T21:55:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"515b41149ea0772b076bba8c2c2c665cbd08883d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1754/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1754/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/facter/issues/1754/comments","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/1d0033bc7c9b83b74e6411c36896fc1e9ddf6c41","head":{"label":"ekinanp:FACT-1889","ref":"FACT-1889","sha":"1d0033bc7c9b83b74e6411c36896fc1e9ddf6c41","user":{"login":"ekinanp","id":29735501,"node_id":"MDQ6VXNlcjI5NzM1NTAx","avatar_url":"https://avatars1.githubusercontent.com/u/29735501?v=4","gravatar_id":"","url":"https://api.github.com/users/ekinanp","html_url":"https://github.com/ekinanp","followers_url":"https://api.github.com/users/ekinanp/followers","following_url":"https://api.github.com/users/ekinanp/following{/other_user}","gists_url":"https://api.github.com/users/ekinanp/gists{/gist_id}","starred_url":"https://api.github.com/users/ekinanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekinanp/subscriptions","organizations_url":"https://api.github.com/users/ekinanp/orgs","repos_url":"https://api.github.com/users/ekinanp/repos","events_url":"https://api.github.com/users/ekinanp/events{/privacy}","received_events_url":"https://api.github.com/users/ekinanp/received_events","type":"User","site_admin":false},"repo":{"id":108305866,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgzMDU4NjY=","name":"facter","full_name":"ekinanp/facter","private":false,"owner":{"login":"ekinanp","id":29735501,"node_id":"MDQ6VXNlcjI5NzM1NTAx","avatar_url":"https://avatars1.githubusercontent.com/u/29735501?v=4","gravatar_id":"","url":"https://api.github.com/users/ekinanp","html_url":"https://github.com/ekinanp","followers_url":"https://api.github.com/users/ekinanp/followers","following_url":"https://api.github.com/users/ekinanp/following{/other_user}","gists_url":"https://api.github.com/users/ekinanp/gists{/gist_id}","starred_url":"https://api.github.com/users/ekinanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekinanp/subscriptions","organizations_url":"https://api.github.com/users/ekinanp/orgs","repos_url":"https://api.github.com/users/ekinanp/repos","events_url":"https://api.github.com/users/ekinanp/events{/privacy}","received_events_url":"https://api.github.com/users/ekinanp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ekinanp/facter","description":"Collect and display system facts","fork":true,"url":"https://api.github.com/repos/ekinanp/facter","forks_url":"https://api.github.com/repos/ekinanp/facter/forks","keys_url":"https://api.github.com/repos/ekinanp/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekinanp/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekinanp/facter/teams","hooks_url":"https://api.github.com/repos/ekinanp/facter/hooks","issue_events_url":"https://api.github.com/repos/ekinanp/facter/issues/events{/number}","events_url":"https://api.github.com/repos/ekinanp/facter/events","assignees_url":"https://api.github.com/repos/ekinanp/facter/assignees{/user}","branches_url":"https://api.github.com/repos/ekinanp/facter/branches{/branch}","tags_url":"https://api.github.com/repos/ekinanp/facter/tags","blobs_url":"https://api.github.com/repos/ekinanp/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekinanp/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekinanp/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekinanp/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekinanp/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/ekinanp/facter/languages","stargazers_url":"https://api.github.com/repos/ekinanp/facter/stargazers","contributors_url":"https://api.github.com/repos/ekinanp/facter/contributors","subscribers_url":"https://api.github.com/repos/ekinanp/facter/subscribers","subscription_url":"https://api.github.com/repos/ekinanp/facter/subscription","commits_url":"https://api.github.com/repos/ekinanp/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekinanp/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekinanp/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekinanp/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekinanp/facter/contents/{+path}","compare_url":"https://api.github.com/repos/ekinanp/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekinanp/facter/merges","archive_url":"https://api.github.com/repos/ekinanp/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekinanp/facter/downloads","issues_url":"https://api.github.com/repos/ekinanp/facter/issues{/number}","pulls_url":"https://api.github.com/repos/ekinanp/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/ekinanp/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/ekinanp/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekinanp/facter/labels{/name}","releases_url":"https://api.github.com/repos/ekinanp/facter/releases{/id}","deployments_url":"https://api.github.com/repos/ekinanp/facter/deployments","created_at":"2017-10-25T17:57:44Z","updated_at":"2018-10-15T20:59:18Z","pushed_at":"2018-10-16T19:43:14Z","git_url":"git://github.com/ekinanp/facter.git","ssh_url":"git@github.com:ekinanp/facter.git","clone_url":"https://github.com/ekinanp/facter.git","svn_url":"https://github.com/ekinanp/facter","homepage":"https://tickets.puppet.com/browse/FACT","size":14022,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:3.11.x","ref":"3.11.x","sha":"23244f9f54d44abf46bf184041524d8b2b8d2b58","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910757,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA3NTc=","name":"facter","full_name":"puppetlabs/facter","private":false,"owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/puppetlabs/facter","description":"Collect and display system facts","fork":false,"url":"https://api.github.com/repos/puppetlabs/facter","forks_url":"https://api.github.com/repos/puppetlabs/facter/forks","keys_url":"https://api.github.com/repos/puppetlabs/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/facter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/facter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/facter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/facter/events","assignees_url":"https://api.github.com/repos/puppetlabs/facter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/facter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/facter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/facter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/facter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/facter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/facter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/facter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/facter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/facter/merges","archive_url":"https://api.github.com/repos/puppetlabs/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/facter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/facter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/facter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/facter/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/facter/deployments","created_at":"2010-09-14T19:31:04Z","updated_at":"2018-10-14T10:07:40Z","pushed_at":"2018-10-16T08:13:25Z","git_url":"git://github.com/puppetlabs/facter.git","ssh_url":"git@github.com:puppetlabs/facter.git","clone_url":"https://github.com/puppetlabs/facter.git","svn_url":"https://github.com/puppetlabs/facter","homepage":"https://tickets.puppet.com/browse/FACT","size":14008,"stargazers_count":518,"watchers_count":518,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":435,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":435,"open_issues":13,"watchers":518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1754"},"html":{"href":"https://github.com/puppetlabs/facter/pull/1754"},"issue":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1754"},"comments":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1754/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1754/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1754/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/facter/statuses/1d0033bc7c9b83b74e6411c36896fc1e9ddf6c41"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ekinanp"}}