{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/2441","repository_url":"https://api.github.com/repos/mozilla/fxa-auth-server","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/2441/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/2441/comments","events_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/2441/events","html_url":"https://github.com/mozilla/fxa-auth-server/pull/2441","id":323699633,"number":2441,"title":"Hapi","user":{"login":"deeptibaghel","id":448609,"avatar_url":"https://avatars3.githubusercontent.com/u/448609?v=4","gravatar_id":"","url":"https://api.github.com/users/deeptibaghel","html_url":"https://github.com/deeptibaghel","followers_url":"https://api.github.com/users/deeptibaghel/followers","following_url":"https://api.github.com/users/deeptibaghel/following{/other_user}","gists_url":"https://api.github.com/users/deeptibaghel/gists{/gist_id}","starred_url":"https://api.github.com/users/deeptibaghel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeptibaghel/subscriptions","organizations_url":"https://api.github.com/users/deeptibaghel/orgs","repos_url":"https://api.github.com/users/deeptibaghel/repos","events_url":"https://api.github.com/users/deeptibaghel/events{/privacy}","received_events_url":"https://api.github.com/users/deeptibaghel/received_events","type":"User","site_admin":false},"labels":[{"id":346098910,"url":"https://api.github.com/repos/mozilla/fxa-auth-server/labels/waffle:active","name":"waffle:active","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"deeptibaghel","id":448609,"avatar_url":"https://avatars3.githubusercontent.com/u/448609?v=4","gravatar_id":"","url":"https://api.github.com/users/deeptibaghel","html_url":"https://github.com/deeptibaghel","followers_url":"https://api.github.com/users/deeptibaghel/followers","following_url":"https://api.github.com/users/deeptibaghel/following{/other_user}","gists_url":"https://api.github.com/users/deeptibaghel/gists{/gist_id}","starred_url":"https://api.github.com/users/deeptibaghel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeptibaghel/subscriptions","organizations_url":"https://api.github.com/users/deeptibaghel/orgs","repos_url":"https://api.github.com/users/deeptibaghel/repos","events_url":"https://api.github.com/users/deeptibaghel/events{/privacy}","received_events_url":"https://api.github.com/users/deeptibaghel/received_events","type":"User","site_admin":false},"assignees":[{"login":"deeptibaghel","id":448609,"avatar_url":"https://avatars3.githubusercontent.com/u/448609?v=4","gravatar_id":"","url":"https://api.github.com/users/deeptibaghel","html_url":"https://github.com/deeptibaghel","followers_url":"https://api.github.com/users/deeptibaghel/followers","following_url":"https://api.github.com/users/deeptibaghel/following{/other_user}","gists_url":"https://api.github.com/users/deeptibaghel/gists{/gist_id}","starred_url":"https://api.github.com/users/deeptibaghel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeptibaghel/subscriptions","organizations_url":"https://api.github.com/users/deeptibaghel/orgs","repos_url":"https://api.github.com/users/deeptibaghel/repos","events_url":"https://api.github.com/users/deeptibaghel/events{/privacy}","received_events_url":"https://api.github.com/users/deeptibaghel/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-05-16T16:38:46Z","updated_at":"2018-05-17T00:52:31Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/2441","html_url":"https://github.com/mozilla/fxa-auth-server/pull/2441","diff_url":"https://github.com/mozilla/fxa-auth-server/pull/2441.diff","patch_url":"https://github.com/mozilla/fxa-auth-server/pull/2441.patch"},"body":"@vladikoff, getting : Error: listen EADDRINUSE 127.0.0.1:9001"},"comment":{"url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/comments/389710326","html_url":"https://github.com/mozilla/fxa-auth-server/pull/2441#issuecomment-389710326","issue_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/2441","id":389710326,"user":{"login":"vladikoff","id":128755,"avatar_url":"https://avatars3.githubusercontent.com/u/128755?v=4","gravatar_id":"","url":"https://api.github.com/users/vladikoff","html_url":"https://github.com/vladikoff","followers_url":"https://api.github.com/users/vladikoff/followers","following_url":"https://api.github.com/users/vladikoff/following{/other_user}","gists_url":"https://api.github.com/users/vladikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladikoff/subscriptions","organizations_url":"https://api.github.com/users/vladikoff/orgs","repos_url":"https://api.github.com/users/vladikoff/repos","events_url":"https://api.github.com/users/vladikoff/events{/privacy}","received_events_url":"https://api.github.com/users/vladikoff/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T00:52:31Z","updated_at":"2018-05-17T00:52:31Z","author_association":"MEMBER","body":"@deeptibaghel so same as in the HKPK plugin example, we need to tweak how we get the server instance. You were almost there with `.create`, just need to return `promises.all`. This should unblock you:\r\n\r\n```diff\r\ndiff --git a/lib/server.js b/lib/server.js\r\nindex 230ddfc9..91cf9d56 100644\r\n--- a/lib/server.js\r\n+++ b/lib/server.js\r\n@@ -359,7 +359,7 @@ promises.push(\r\n   })\r\n )\r\n \r\n-  P.all(\r\n+  return P.all(\r\n     promises\r\n   ).then(() => {\r\n     return server\r\ndiff --git a/scripts/test-local.sh b/scripts/test-local.sh\r\nindex 9697cc7f..ec3ffa84 100755\r\n--- a/scripts/test-local.sh\r\n+++ b/scripts/test-local.sh\r\n@@ -12,7 +12,7 @@ if [ -z \"$GLOB\" ]; then\r\n   GLOB=\"test/local test/remote\"\r\n fi\r\n \r\n-DEFAULT_ARGS=\"-R dot --recursive\"\r\n+DEFAULT_ARGS=\" --recursive\"\r\n \r\n # When running under Windows Subsystem for Linux,\r\n # some tests take unusually long to complete.\r\ndiff --git a/test/local/server.js b/test/local/server.js\r\nindex 44107400..c5cc63d6 100644\r\n--- a/test/local/server.js\r\n+++ b/test/local/server.js\r\n@@ -85,7 +85,10 @@ describe('lib/server', () => {\r\n         db = mocks.mockDB({\r\n           devices: [ { id: 'fake device id' } ]\r\n         })\r\n-        instance = server.create(log, error, config, routes, db, translator, Token)\r\n+        instance = server.create(log, error, config, routes, db, translator, Token).then((s) => {\r\n+          console.log('server', s.start)\r\n+        })\r\n+        console.log(instance)\r\n         return instance\r\n       })\r\n ```"}}
{"actor":{"display_login":"vladikoff"}}