{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vstest/pulls/comments/180369044","pull_request_review_id":110774157,"id":180369044,"diff_hunk":"@@ -237,14 +254,24 @@ private void SetAdapterLoggingSettings(IMessageLogger messageLogger, IRunSetting\n                 return null;\n             }\n \n+            IDictionary<AssemblyType, IEnumerable<string>> assemblyTypeToSoucesMap = null;\n             var result = new Dictionary<LazyExtension<ITestDiscoverer, ITestDiscovererCapabilities>, IEnumerable<string>>();\n             var sourcesForWhichNoDiscovererIsAvailable = new List<string>(sources);\n \n             foreach (var discoverer in allDiscoverers)\n             {\n+                var sourcesToCheck = sources;\n+\n+                if (discoverer.Metadata.AssemblyType == AssemblyType.Native ||","path":"src/Microsoft.TestPlatform.CrossPlatEngine/Discovery/DiscovererEnumerator.cs","position":70,"original_position":70,"commit_id":"2056218a0fd14b242b7c9f7214eb2f4c4455891e","original_commit_id":"2056218a0fd14b242b7c9f7214eb2f4c4455891e","user":{"login":"smadala","id":4337332,"avatar_url":"https://avatars1.githubusercontent.com/u/4337332?v=4","gravatar_id":"","url":"https://api.github.com/users/smadala","html_url":"https://github.com/smadala","followers_url":"https://api.github.com/users/smadala/followers","following_url":"https://api.github.com/users/smadala/following{/other_user}","gists_url":"https://api.github.com/users/smadala/gists{/gist_id}","starred_url":"https://api.github.com/users/smadala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smadala/subscriptions","organizations_url":"https://api.github.com/users/smadala/orgs","repos_url":"https://api.github.com/users/smadala/repos","events_url":"https://api.github.com/users/smadala/events{/privacy}","received_events_url":"https://api.github.com/users/smadala/received_events","type":"User","site_admin":false},"body":"Is there a chance discoverer can support both managed and native?","created_at":"2018-04-10T10:25:56Z","updated_at":"2018-04-10T10:51:15Z","html_url":"https://github.com/Microsoft/vstest/pull/1537#discussion_r180369044","pull_request_url":"https://api.github.com/repos/Microsoft/vstest/pulls/1537","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vstest/pulls/comments/180369044"},"html":{"href":"https://github.com/Microsoft/vstest/pull/1537#discussion_r180369044"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vstest/pulls/1537"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vstest/pulls/1537","id":180303437,"html_url":"https://github.com/Microsoft/vstest/pull/1537","diff_url":"https://github.com/Microsoft/vstest/pull/1537.diff","patch_url":"https://github.com/Microsoft/vstest/pull/1537.patch","issue_url":"https://api.github.com/repos/Microsoft/vstest/issues/1537","number":1537,"state":"open","locked":false,"title":"Filtering sources based on assembly type","user":{"login":"abhishkk","id":32157767,"avatar_url":"https://avatars2.githubusercontent.com/u/32157767?v=4","gravatar_id":"","url":"https://api.github.com/users/abhishkk","html_url":"https://github.com/abhishkk","followers_url":"https://api.github.com/users/abhishkk/followers","following_url":"https://api.github.com/users/abhishkk/following{/other_user}","gists_url":"https://api.github.com/users/abhishkk/gists{/gist_id}","starred_url":"https://api.github.com/users/abhishkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhishkk/subscriptions","organizations_url":"https://api.github.com/users/abhishkk/orgs","repos_url":"https://api.github.com/users/abhishkk/repos","events_url":"https://api.github.com/users/abhishkk/events{/privacy}","received_events_url":"https://api.github.com/users/abhishkk/received_events","type":"User","site_admin":false},"body":"Part 3 of [RFC](https://github.com/Microsoft/vstest-docs/pull/124):\r\nContains changes for filtering sources based on assembly type.","created_at":"2018-04-09T13:00:30Z","updated_at":"2018-04-10T10:51:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c9df6c34b0f71a920ce06bbd1769c2b7db4ab88","assignee":{"login":"mayankbansal018","id":24792973,"avatar_url":"https://avatars1.githubusercontent.com/u/24792973?v=4","gravatar_id":"","url":"https://api.github.com/users/mayankbansal018","html_url":"https://github.com/mayankbansal018","followers_url":"https://api.github.com/users/mayankbansal018/followers","following_url":"https://api.github.com/users/mayankbansal018/following{/other_user}","gists_url":"https://api.github.com/users/mayankbansal018/gists{/gist_id}","starred_url":"https://api.github.com/users/mayankbansal018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayankbansal018/subscriptions","organizations_url":"https://api.github.com/users/mayankbansal018/orgs","repos_url":"https://api.github.com/users/mayankbansal018/repos","events_url":"https://api.github.com/users/mayankbansal018/events{/privacy}","received_events_url":"https://api.github.com/users/mayankbansal018/received_events","type":"User","site_admin":false},"assignees":[{"login":"mayankbansal018","id":24792973,"avatar_url":"https://avatars1.githubusercontent.com/u/24792973?v=4","gravatar_id":"","url":"https://api.github.com/users/mayankbansal018","html_url":"https://github.com/mayankbansal018","followers_url":"https://api.github.com/users/mayankbansal018/followers","following_url":"https://api.github.com/users/mayankbansal018/following{/other_user}","gists_url":"https://api.github.com/users/mayankbansal018/gists{/gist_id}","starred_url":"https://api.github.com/users/mayankbansal018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayankbansal018/subscriptions","organizations_url":"https://api.github.com/users/mayankbansal018/orgs","repos_url":"https://api.github.com/users/mayankbansal018/repos","events_url":"https://api.github.com/users/mayankbansal018/events{/privacy}","received_events_url":"https://api.github.com/users/mayankbansal018/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"acesiddhu","id":1168823,"avatar_url":"https://avatars2.githubusercontent.com/u/1168823?v=4","gravatar_id":"","url":"https://api.github.com/users/acesiddhu","html_url":"https://github.com/acesiddhu","followers_url":"https://api.github.com/users/acesiddhu/followers","following_url":"https://api.github.com/users/acesiddhu/following{/other_user}","gists_url":"https://api.github.com/users/acesiddhu/gists{/gist_id}","starred_url":"https://api.github.com/users/acesiddhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acesiddhu/subscriptions","organizations_url":"https://api.github.com/users/acesiddhu/orgs","repos_url":"https://api.github.com/users/acesiddhu/repos","events_url":"https://api.github.com/users/acesiddhu/events{/privacy}","received_events_url":"https://api.github.com/users/acesiddhu/received_events","type":"User","site_admin":false},{"login":"cltshivash","id":18257951,"avatar_url":"https://avatars1.githubusercontent.com/u/18257951?v=4","gravatar_id":"","url":"https://api.github.com/users/cltshivash","html_url":"https://github.com/cltshivash","followers_url":"https://api.github.com/users/cltshivash/followers","following_url":"https://api.github.com/users/cltshivash/following{/other_user}","gists_url":"https://api.github.com/users/cltshivash/gists{/gist_id}","starred_url":"https://api.github.com/users/cltshivash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cltshivash/subscriptions","organizations_url":"https://api.github.com/users/cltshivash/orgs","repos_url":"https://api.github.com/users/cltshivash/repos","events_url":"https://api.github.com/users/cltshivash/events{/privacy}","received_events_url":"https://api.github.com/users/cltshivash/received_events","type":"User","site_admin":false},{"login":"singhsarab","id":18569990,"avatar_url":"https://avatars0.githubusercontent.com/u/18569990?v=4","gravatar_id":"","url":"https://api.github.com/users/singhsarab","html_url":"https://github.com/singhsarab","followers_url":"https://api.github.com/users/singhsarab/followers","following_url":"https://api.github.com/users/singhsarab/following{/other_user}","gists_url":"https://api.github.com/users/singhsarab/gists{/gist_id}","starred_url":"https://api.github.com/users/singhsarab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singhsarab/subscriptions","organizations_url":"https://api.github.com/users/singhsarab/orgs","repos_url":"https://api.github.com/users/singhsarab/repos","events_url":"https://api.github.com/users/singhsarab/events{/privacy}","received_events_url":"https://api.github.com/users/singhsarab/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vstest/pulls/1537/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vstest/pulls/1537/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vstest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vstest/issues/1537/comments","statuses_url":"https://api.github.com/repos/Microsoft/vstest/statuses/2056218a0fd14b242b7c9f7214eb2f4c4455891e","head":{"label":"abhishkk:filterSourcesBasedOnAssemblyType","ref":"filterSourcesBasedOnAssemblyType","sha":"2056218a0fd14b242b7c9f7214eb2f4c4455891e","user":{"login":"abhishkk","id":32157767,"avatar_url":"https://avatars2.githubusercontent.com/u/32157767?v=4","gravatar_id":"","url":"https://api.github.com/users/abhishkk","html_url":"https://github.com/abhishkk","followers_url":"https://api.github.com/users/abhishkk/followers","following_url":"https://api.github.com/users/abhishkk/following{/other_user}","gists_url":"https://api.github.com/users/abhishkk/gists{/gist_id}","starred_url":"https://api.github.com/users/abhishkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhishkk/subscriptions","organizations_url":"https://api.github.com/users/abhishkk/orgs","repos_url":"https://api.github.com/users/abhishkk/repos","events_url":"https://api.github.com/users/abhishkk/events{/privacy}","received_events_url":"https://api.github.com/users/abhishkk/received_events","type":"User","site_admin":false},"repo":{"id":122433470,"name":"vstest","full_name":"abhishkk/vstest","owner":{"login":"abhishkk","id":32157767,"avatar_url":"https://avatars2.githubusercontent.com/u/32157767?v=4","gravatar_id":"","url":"https://api.github.com/users/abhishkk","html_url":"https://github.com/abhishkk","followers_url":"https://api.github.com/users/abhishkk/followers","following_url":"https://api.github.com/users/abhishkk/following{/other_user}","gists_url":"https://api.github.com/users/abhishkk/gists{/gist_id}","starred_url":"https://api.github.com/users/abhishkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhishkk/subscriptions","organizations_url":"https://api.github.com/users/abhishkk/orgs","repos_url":"https://api.github.com/users/abhishkk/repos","events_url":"https://api.github.com/users/abhishkk/events{/privacy}","received_events_url":"https://api.github.com/users/abhishkk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhishkk/vstest","description":"Visual Studio Test Platform is the runner and engine that powers test explorer and vstest.console.","fork":true,"url":"https://api.github.com/repos/abhishkk/vstest","forks_url":"https://api.github.com/repos/abhishkk/vstest/forks","keys_url":"https://api.github.com/repos/abhishkk/vstest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhishkk/vstest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhishkk/vstest/teams","hooks_url":"https://api.github.com/repos/abhishkk/vstest/hooks","issue_events_url":"https://api.github.com/repos/abhishkk/vstest/issues/events{/number}","events_url":"https://api.github.com/repos/abhishkk/vstest/events","assignees_url":"https://api.github.com/repos/abhishkk/vstest/assignees{/user}","branches_url":"https://api.github.com/repos/abhishkk/vstest/branches{/branch}","tags_url":"https://api.github.com/repos/abhishkk/vstest/tags","blobs_url":"https://api.github.com/repos/abhishkk/vstest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhishkk/vstest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhishkk/vstest/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhishkk/vstest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhishkk/vstest/statuses/{sha}","languages_url":"https://api.github.com/repos/abhishkk/vstest/languages","stargazers_url":"https://api.github.com/repos/abhishkk/vstest/stargazers","contributors_url":"https://api.github.com/repos/abhishkk/vstest/contributors","subscribers_url":"https://api.github.com/repos/abhishkk/vstest/subscribers","subscription_url":"https://api.github.com/repos/abhishkk/vstest/subscription","commits_url":"https://api.github.com/repos/abhishkk/vstest/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhishkk/vstest/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhishkk/vstest/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhishkk/vstest/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhishkk/vstest/contents/{+path}","compare_url":"https://api.github.com/repos/abhishkk/vstest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhishkk/vstest/merges","archive_url":"https://api.github.com/repos/abhishkk/vstest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhishkk/vstest/downloads","issues_url":"https://api.github.com/repos/abhishkk/vstest/issues{/number}","pulls_url":"https://api.github.com/repos/abhishkk/vstest/pulls{/number}","milestones_url":"https://api.github.com/repos/abhishkk/vstest/milestones{/number}","notifications_url":"https://api.github.com/repos/abhishkk/vstest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhishkk/vstest/labels{/name}","releases_url":"https://api.github.com/repos/abhishkk/vstest/releases{/id}","deployments_url":"https://api.github.com/repos/abhishkk/vstest/deployments","created_at":"2018-02-22T05:08:48Z","updated_at":"2018-04-09T12:10:22Z","pushed_at":"2018-04-10T07:59:47Z","git_url":"git://github.com/abhishkk/vstest.git","ssh_url":"git@github.com:abhishkk/vstest.git","clone_url":"https://github.com/abhishkk/vstest.git","svn_url":"https://github.com/abhishkk/vstest","homepage":"","size":9357,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"534026fad250aa844ed3bb47e7fd853dfe1b711d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":62774726,"name":"vstest","full_name":"Microsoft/vstest","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vstest","description":"Visual Studio Test Platform is the runner and engine that powers test explorer and vstest.console.","fork":false,"url":"https://api.github.com/repos/Microsoft/vstest","forks_url":"https://api.github.com/repos/Microsoft/vstest/forks","keys_url":"https://api.github.com/repos/Microsoft/vstest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vstest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vstest/teams","hooks_url":"https://api.github.com/repos/Microsoft/vstest/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vstest/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vstest/events","assignees_url":"https://api.github.com/repos/Microsoft/vstest/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vstest/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vstest/tags","blobs_url":"https://api.github.com/repos/Microsoft/vstest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vstest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vstest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vstest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vstest/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vstest/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vstest/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vstest/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vstest/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vstest/subscription","commits_url":"https://api.github.com/repos/Microsoft/vstest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vstest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vstest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vstest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vstest/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vstest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vstest/merges","archive_url":"https://api.github.com/repos/Microsoft/vstest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vstest/downloads","issues_url":"https://api.github.com/repos/Microsoft/vstest/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vstest/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vstest/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vstest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vstest/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vstest/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vstest/deployments","created_at":"2016-07-07T04:18:58Z","updated_at":"2018-04-10T01:38:40Z","pushed_at":"2018-04-10T07:59:48Z","git_url":"git://github.com/Microsoft/vstest.git","ssh_url":"git@github.com:Microsoft/vstest.git","clone_url":"https://github.com/Microsoft/vstest.git","svn_url":"https://github.com/Microsoft/vstest","homepage":"","size":9351,"stargazers_count":368,"watchers_count":368,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":99,"open_issues":93,"watchers":368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vstest/pulls/1537"},"html":{"href":"https://github.com/Microsoft/vstest/pull/1537"},"issue":{"href":"https://api.github.com/repos/Microsoft/vstest/issues/1537"},"comments":{"href":"https://api.github.com/repos/Microsoft/vstest/issues/1537/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vstest/pulls/1537/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vstest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vstest/pulls/1537/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vstest/statuses/2056218a0fd14b242b7c9f7214eb2f4c4455891e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"smadala"}}