{"action":"created","comment":{"url":"https://api.github.com/repos/mediact/dependency-guard/pulls/comments/200851687","pull_request_review_id":135243647,"id":200851687,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDg1MTY4Nw==","diff_hunk":"@@ -48,13 +48,13 @@ public function extract(\n         $symbols = [];\n \n         foreach ($files as $file) {\n-            if (!$file->isFile() || !$file->isReadable()) {\n-                continue;\n-            }\n-\n             try {\n-                $handle     = $file->openFile('r');\n-                $contents   = implode('', iterator_to_array($handle));\n+                $contents = $this->readFile($file);\n+\n+                if ($contents === null) {","path":"src/Php/SymbolExtractor.php","position":null,"original_position":13,"commit_id":"ab43c9c85c7365d7910d71f69c9f784f91c6c4bb","original_commit_id":"e00eeea4da69ca5e70446e041fc217033fdac866","user":{"login":"willemstuursma","id":701299,"node_id":"MDQ6VXNlcjcwMTI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/701299?v=4","gravatar_id":"","url":"https://api.github.com/users/willemstuursma","html_url":"https://github.com/willemstuursma","followers_url":"https://api.github.com/users/willemstuursma/followers","following_url":"https://api.github.com/users/willemstuursma/following{/other_user}","gists_url":"https://api.github.com/users/willemstuursma/gists{/gist_id}","starred_url":"https://api.github.com/users/willemstuursma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willemstuursma/subscriptions","organizations_url":"https://api.github.com/users/willemstuursma/orgs","repos_url":"https://api.github.com/users/willemstuursma/repos","events_url":"https://api.github.com/users/willemstuursma/events{/privacy}","received_events_url":"https://api.github.com/users/willemstuursma/received_events","type":"User","site_admin":false},"body":"Cheers.","created_at":"2018-07-08T19:57:28Z","updated_at":"2018-07-08T19:57:28Z","html_url":"https://github.com/mediact/dependency-guard/pull/8#discussion_r200851687","pull_request_url":"https://api.github.com/repos/mediact/dependency-guard/pulls/8","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mediact/dependency-guard/pulls/comments/200851687"},"html":{"href":"https://github.com/mediact/dependency-guard/pull/8#discussion_r200851687"},"pull_request":{"href":"https://api.github.com/repos/mediact/dependency-guard/pulls/8"}},"in_reply_to_id":200835353},"pull_request":{"url":"https://api.github.com/repos/mediact/dependency-guard/pulls/8","id":199247375,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MjQ3Mzc1","html_url":"https://github.com/mediact/dependency-guard/pull/8","diff_url":"https://github.com/mediact/dependency-guard/pull/8.diff","patch_url":"https://github.com/mediact/dependency-guard/pull/8.patch","issue_url":"https://api.github.com/repos/mediact/dependency-guard/issues/8","number":8,"state":"open","locked":false,"title":"Minor performance improvements","user":{"login":"willemstuursma","id":701299,"node_id":"MDQ6VXNlcjcwMTI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/701299?v=4","gravatar_id":"","url":"https://api.github.com/users/willemstuursma","html_url":"https://github.com/willemstuursma","followers_url":"https://api.github.com/users/willemstuursma/followers","following_url":"https://api.github.com/users/willemstuursma/following{/other_user}","gists_url":"https://api.github.com/users/willemstuursma/gists{/gist_id}","starred_url":"https://api.github.com/users/willemstuursma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willemstuursma/subscriptions","organizations_url":"https://api.github.com/users/willemstuursma/orgs","repos_url":"https://api.github.com/users/willemstuursma/repos","events_url":"https://api.github.com/users/willemstuursma/events{/privacy}","received_events_url":"https://api.github.com/users/willemstuursma/received_events","type":"User","site_admin":false},"body":"Some minor performance improvements.\r\n\r\n* Reduce usage of `array_reduce` so we don't have to loop the entire array\r\n* Use `file_get_contents()` to read the file in one I/O operation. \r\n* Remove checks for isFile() and isReadable(), check error result from `file_get_contents` instead.\r\n\r\nInitial profile against a reasonable sized code base (90% of calls):\r\n\r\n* 4953 different functions called in 165771 milliseconds (1 runs, 37 shown)\r\n\r\nFinal profile:\r\n\r\n* 4950 different functions called in 144280 milliseconds (1 runs, 33 shown)\r\n\r\n±15% speed up.","created_at":"2018-07-04T13:18:57Z","updated_at":"2018-07-08T19:57:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e40a8e2ba1b0b02ffa7215c223f8cdb36721e084","assignee":{"login":"johmanx10","id":642417,"node_id":"MDQ6VXNlcjY0MjQxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/642417?v=4","gravatar_id":"","url":"https://api.github.com/users/johmanx10","html_url":"https://github.com/johmanx10","followers_url":"https://api.github.com/users/johmanx10/followers","following_url":"https://api.github.com/users/johmanx10/following{/other_user}","gists_url":"https://api.github.com/users/johmanx10/gists{/gist_id}","starred_url":"https://api.github.com/users/johmanx10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johmanx10/subscriptions","organizations_url":"https://api.github.com/users/johmanx10/orgs","repos_url":"https://api.github.com/users/johmanx10/repos","events_url":"https://api.github.com/users/johmanx10/events{/privacy}","received_events_url":"https://api.github.com/users/johmanx10/received_events","type":"User","site_admin":false},"assignees":[{"login":"johmanx10","id":642417,"node_id":"MDQ6VXNlcjY0MjQxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/642417?v=4","gravatar_id":"","url":"https://api.github.com/users/johmanx10","html_url":"https://github.com/johmanx10","followers_url":"https://api.github.com/users/johmanx10/followers","following_url":"https://api.github.com/users/johmanx10/following{/other_user}","gists_url":"https://api.github.com/users/johmanx10/gists{/gist_id}","starred_url":"https://api.github.com/users/johmanx10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johmanx10/subscriptions","organizations_url":"https://api.github.com/users/johmanx10/orgs","repos_url":"https://api.github.com/users/johmanx10/repos","events_url":"https://api.github.com/users/johmanx10/events{/privacy}","received_events_url":"https://api.github.com/users/johmanx10/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"sjokki","id":2527109,"node_id":"MDQ6VXNlcjI1MjcxMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2527109?v=4","gravatar_id":"","url":"https://api.github.com/users/sjokki","html_url":"https://github.com/sjokki","followers_url":"https://api.github.com/users/sjokki/followers","following_url":"https://api.github.com/users/sjokki/following{/other_user}","gists_url":"https://api.github.com/users/sjokki/gists{/gist_id}","starred_url":"https://api.github.com/users/sjokki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjokki/subscriptions","organizations_url":"https://api.github.com/users/sjokki/orgs","repos_url":"https://api.github.com/users/sjokki/repos","events_url":"https://api.github.com/users/sjokki/events{/privacy}","received_events_url":"https://api.github.com/users/sjokki/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":981342376,"node_id":"MDU6TGFiZWw5ODEzNDIzNzY=","url":"https://api.github.com/repos/mediact/dependency-guard/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/mediact/dependency-guard/pulls/8/commits","review_comments_url":"https://api.github.com/repos/mediact/dependency-guard/pulls/8/comments","review_comment_url":"https://api.github.com/repos/mediact/dependency-guard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mediact/dependency-guard/issues/8/comments","statuses_url":"https://api.github.com/repos/mediact/dependency-guard/statuses/ab43c9c85c7365d7910d71f69c9f784f91c6c4bb","head":{"label":"willemstuursma:master","ref":"master","sha":"ab43c9c85c7365d7910d71f69c9f784f91c6c4bb","user":{"login":"willemstuursma","id":701299,"node_id":"MDQ6VXNlcjcwMTI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/701299?v=4","gravatar_id":"","url":"https://api.github.com/users/willemstuursma","html_url":"https://github.com/willemstuursma","followers_url":"https://api.github.com/users/willemstuursma/followers","following_url":"https://api.github.com/users/willemstuursma/following{/other_user}","gists_url":"https://api.github.com/users/willemstuursma/gists{/gist_id}","starred_url":"https://api.github.com/users/willemstuursma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willemstuursma/subscriptions","organizations_url":"https://api.github.com/users/willemstuursma/orgs","repos_url":"https://api.github.com/users/willemstuursma/repos","events_url":"https://api.github.com/users/willemstuursma/events{/privacy}","received_events_url":"https://api.github.com/users/willemstuursma/received_events","type":"User","site_admin":false},"repo":{"id":139602210,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2MDIyMTA=","name":"dependency-guard","full_name":"willemstuursma/dependency-guard","owner":{"login":"willemstuursma","id":701299,"node_id":"MDQ6VXNlcjcwMTI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/701299?v=4","gravatar_id":"","url":"https://api.github.com/users/willemstuursma","html_url":"https://github.com/willemstuursma","followers_url":"https://api.github.com/users/willemstuursma/followers","following_url":"https://api.github.com/users/willemstuursma/following{/other_user}","gists_url":"https://api.github.com/users/willemstuursma/gists{/gist_id}","starred_url":"https://api.github.com/users/willemstuursma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willemstuursma/subscriptions","organizations_url":"https://api.github.com/users/willemstuursma/orgs","repos_url":"https://api.github.com/users/willemstuursma/repos","events_url":"https://api.github.com/users/willemstuursma/events{/privacy}","received_events_url":"https://api.github.com/users/willemstuursma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willemstuursma/dependency-guard","description":"Static production dependency analysis.","fork":true,"url":"https://api.github.com/repos/willemstuursma/dependency-guard","forks_url":"https://api.github.com/repos/willemstuursma/dependency-guard/forks","keys_url":"https://api.github.com/repos/willemstuursma/dependency-guard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willemstuursma/dependency-guard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willemstuursma/dependency-guard/teams","hooks_url":"https://api.github.com/repos/willemstuursma/dependency-guard/hooks","issue_events_url":"https://api.github.com/repos/willemstuursma/dependency-guard/issues/events{/number}","events_url":"https://api.github.com/repos/willemstuursma/dependency-guard/events","assignees_url":"https://api.github.com/repos/willemstuursma/dependency-guard/assignees{/user}","branches_url":"https://api.github.com/repos/willemstuursma/dependency-guard/branches{/branch}","tags_url":"https://api.github.com/repos/willemstuursma/dependency-guard/tags","blobs_url":"https://api.github.com/repos/willemstuursma/dependency-guard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willemstuursma/dependency-guard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willemstuursma/dependency-guard/git/refs{/sha}","trees_url":"https://api.github.com/repos/willemstuursma/dependency-guard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willemstuursma/dependency-guard/statuses/{sha}","languages_url":"https://api.github.com/repos/willemstuursma/dependency-guard/languages","stargazers_url":"https://api.github.com/repos/willemstuursma/dependency-guard/stargazers","contributors_url":"https://api.github.com/repos/willemstuursma/dependency-guard/contributors","subscribers_url":"https://api.github.com/repos/willemstuursma/dependency-guard/subscribers","subscription_url":"https://api.github.com/repos/willemstuursma/dependency-guard/subscription","commits_url":"https://api.github.com/repos/willemstuursma/dependency-guard/commits{/sha}","git_commits_url":"https://api.github.com/repos/willemstuursma/dependency-guard/git/commits{/sha}","comments_url":"https://api.github.com/repos/willemstuursma/dependency-guard/comments{/number}","issue_comment_url":"https://api.github.com/repos/willemstuursma/dependency-guard/issues/comments{/number}","contents_url":"https://api.github.com/repos/willemstuursma/dependency-guard/contents/{+path}","compare_url":"https://api.github.com/repos/willemstuursma/dependency-guard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willemstuursma/dependency-guard/merges","archive_url":"https://api.github.com/repos/willemstuursma/dependency-guard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willemstuursma/dependency-guard/downloads","issues_url":"https://api.github.com/repos/willemstuursma/dependency-guard/issues{/number}","pulls_url":"https://api.github.com/repos/willemstuursma/dependency-guard/pulls{/number}","milestones_url":"https://api.github.com/repos/willemstuursma/dependency-guard/milestones{/number}","notifications_url":"https://api.github.com/repos/willemstuursma/dependency-guard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willemstuursma/dependency-guard/labels{/name}","releases_url":"https://api.github.com/repos/willemstuursma/dependency-guard/releases{/id}","deployments_url":"https://api.github.com/repos/willemstuursma/dependency-guard/deployments","created_at":"2018-07-03T15:18:50Z","updated_at":"2018-07-08T19:57:19Z","pushed_at":"2018-07-08T19:57:18Z","git_url":"git://github.com/willemstuursma/dependency-guard.git","ssh_url":"git@github.com:willemstuursma/dependency-guard.git","clone_url":"https://github.com/willemstuursma/dependency-guard.git","svn_url":"https://github.com/willemstuursma/dependency-guard","homepage":null,"size":163,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mediact:master","ref":"master","sha":"8340e9a4e84923576879da208aa93c57054d0800","user":{"login":"mediact","id":13571286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTcxMjg2","avatar_url":"https://avatars1.githubusercontent.com/u/13571286?v=4","gravatar_id":"","url":"https://api.github.com/users/mediact","html_url":"https://github.com/mediact","followers_url":"https://api.github.com/users/mediact/followers","following_url":"https://api.github.com/users/mediact/following{/other_user}","gists_url":"https://api.github.com/users/mediact/gists{/gist_id}","starred_url":"https://api.github.com/users/mediact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mediact/subscriptions","organizations_url":"https://api.github.com/users/mediact/orgs","repos_url":"https://api.github.com/users/mediact/repos","events_url":"https://api.github.com/users/mediact/events{/privacy}","received_events_url":"https://api.github.com/users/mediact/received_events","type":"Organization","site_admin":false},"repo":{"id":139418093,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0MTgwOTM=","name":"dependency-guard","full_name":"mediact/dependency-guard","owner":{"login":"mediact","id":13571286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTcxMjg2","avatar_url":"https://avatars1.githubusercontent.com/u/13571286?v=4","gravatar_id":"","url":"https://api.github.com/users/mediact","html_url":"https://github.com/mediact","followers_url":"https://api.github.com/users/mediact/followers","following_url":"https://api.github.com/users/mediact/following{/other_user}","gists_url":"https://api.github.com/users/mediact/gists{/gist_id}","starred_url":"https://api.github.com/users/mediact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mediact/subscriptions","organizations_url":"https://api.github.com/users/mediact/orgs","repos_url":"https://api.github.com/users/mediact/repos","events_url":"https://api.github.com/users/mediact/events{/privacy}","received_events_url":"https://api.github.com/users/mediact/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mediact/dependency-guard","description":"Static production dependency analysis.","fork":false,"url":"https://api.github.com/repos/mediact/dependency-guard","forks_url":"https://api.github.com/repos/mediact/dependency-guard/forks","keys_url":"https://api.github.com/repos/mediact/dependency-guard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mediact/dependency-guard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mediact/dependency-guard/teams","hooks_url":"https://api.github.com/repos/mediact/dependency-guard/hooks","issue_events_url":"https://api.github.com/repos/mediact/dependency-guard/issues/events{/number}","events_url":"https://api.github.com/repos/mediact/dependency-guard/events","assignees_url":"https://api.github.com/repos/mediact/dependency-guard/assignees{/user}","branches_url":"https://api.github.com/repos/mediact/dependency-guard/branches{/branch}","tags_url":"https://api.github.com/repos/mediact/dependency-guard/tags","blobs_url":"https://api.github.com/repos/mediact/dependency-guard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mediact/dependency-guard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mediact/dependency-guard/git/refs{/sha}","trees_url":"https://api.github.com/repos/mediact/dependency-guard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mediact/dependency-guard/statuses/{sha}","languages_url":"https://api.github.com/repos/mediact/dependency-guard/languages","stargazers_url":"https://api.github.com/repos/mediact/dependency-guard/stargazers","contributors_url":"https://api.github.com/repos/mediact/dependency-guard/contributors","subscribers_url":"https://api.github.com/repos/mediact/dependency-guard/subscribers","subscription_url":"https://api.github.com/repos/mediact/dependency-guard/subscription","commits_url":"https://api.github.com/repos/mediact/dependency-guard/commits{/sha}","git_commits_url":"https://api.github.com/repos/mediact/dependency-guard/git/commits{/sha}","comments_url":"https://api.github.com/repos/mediact/dependency-guard/comments{/number}","issue_comment_url":"https://api.github.com/repos/mediact/dependency-guard/issues/comments{/number}","contents_url":"https://api.github.com/repos/mediact/dependency-guard/contents/{+path}","compare_url":"https://api.github.com/repos/mediact/dependency-guard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mediact/dependency-guard/merges","archive_url":"https://api.github.com/repos/mediact/dependency-guard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mediact/dependency-guard/downloads","issues_url":"https://api.github.com/repos/mediact/dependency-guard/issues{/number}","pulls_url":"https://api.github.com/repos/mediact/dependency-guard/pulls{/number}","milestones_url":"https://api.github.com/repos/mediact/dependency-guard/milestones{/number}","notifications_url":"https://api.github.com/repos/mediact/dependency-guard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mediact/dependency-guard/labels{/name}","releases_url":"https://api.github.com/repos/mediact/dependency-guard/releases{/id}","deployments_url":"https://api.github.com/repos/mediact/dependency-guard/deployments","created_at":"2018-07-02T09:03:57Z","updated_at":"2018-07-07T15:31:23Z","pushed_at":"2018-07-08T19:57:19Z","git_url":"git://github.com/mediact/dependency-guard.git","ssh_url":"git@github.com:mediact/dependency-guard.git","clone_url":"https://github.com/mediact/dependency-guard.git","svn_url":"https://github.com/mediact/dependency-guard","homepage":null,"size":153,"stargazers_count":15,"watchers_count":15,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":2,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mediact/dependency-guard/pulls/8"},"html":{"href":"https://github.com/mediact/dependency-guard/pull/8"},"issue":{"href":"https://api.github.com/repos/mediact/dependency-guard/issues/8"},"comments":{"href":"https://api.github.com/repos/mediact/dependency-guard/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/mediact/dependency-guard/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/mediact/dependency-guard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mediact/dependency-guard/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/mediact/dependency-guard/statuses/ab43c9c85c7365d7910d71f69c9f784f91c6c4bb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"willemstuursma"}}