{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/comments/182231717","pull_request_review_id":112995823,"id":182231717,"diff_hunk":"@@ -0,0 +1,84 @@\n+﻿//----------------------------------------------------------------------\n+//\n+// Copyright (c) Microsoft Corporation.\n+// All rights reserved.\n+//\n+// This code is licensed under the MIT License.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files(the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and / or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions :\n+//\n+// The above copyright notice and this permission notice shall be included in\n+// all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+//\n+//------------------------------------------------------------------------------\n+\n+#if ANDROID\n+using System;\n+using Android.App;\n+#endif","path":"core/src/UI/CoreUIParent.cs","position":31,"original_position":31,"commit_id":"2a46f9eb35dc1ff7ff031d7a7347ab1969467b09","original_commit_id":"2a46f9eb35dc1ff7ff031d7a7347ab1969467b09","user":{"login":"jennyf19","id":19942418,"avatar_url":"https://avatars2.githubusercontent.com/u/19942418?v=4","gravatar_id":"","url":"https://api.github.com/users/jennyf19","html_url":"https://github.com/jennyf19","followers_url":"https://api.github.com/users/jennyf19/followers","following_url":"https://api.github.com/users/jennyf19/following{/other_user}","gists_url":"https://api.github.com/users/jennyf19/gists{/gist_id}","starred_url":"https://api.github.com/users/jennyf19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennyf19/subscriptions","organizations_url":"https://api.github.com/users/jennyf19/orgs","repos_url":"https://api.github.com/users/jennyf19/repos","events_url":"https://api.github.com/users/jennyf19/events{/privacy}","received_events_url":"https://api.github.com/users/jennyf19/received_events","type":"User","site_admin":false},"body":"interesting. I read some documentation on inside vs outside...seems like inside is slightly better, but I think it's important to have consistency at this point. ","created_at":"2018-04-17T20:58:53Z","updated_at":"2018-04-17T20:58:53Z","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1038#discussion_r182231717","pull_request_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1038","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/comments/182231717"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1038#discussion_r182231717"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1038"}},"in_reply_to_id":182142605},"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1038","id":182011105,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1038","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1038.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1038.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1038","number":1038,"state":"open","locked":false,"title":"Jennyf/core web view","user":{"login":"jennyf19","id":19942418,"avatar_url":"https://avatars2.githubusercontent.com/u/19942418?v=4","gravatar_id":"","url":"https://api.github.com/users/jennyf19","html_url":"https://github.com/jennyf19","followers_url":"https://api.github.com/users/jennyf19/followers","following_url":"https://api.github.com/users/jennyf19/following{/other_user}","gists_url":"https://api.github.com/users/jennyf19/gists{/gist_id}","starred_url":"https://api.github.com/users/jennyf19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennyf19/subscriptions","organizations_url":"https://api.github.com/users/jennyf19/orgs","repos_url":"https://api.github.com/users/jennyf19/repos","events_url":"https://api.github.com/users/jennyf19/events{/privacy}","received_events_url":"https://api.github.com/users/jennyf19/received_events","type":"User","site_admin":false},"body":"Initial PR for:\r\n> Refactoring core \r\n> Enabling system webview support in core for msal\r\n> Fix mock and unit tests references due to core refactoring\r\n\r\nI did manual testing w/:\r\n* Xamarin Android in Adal (works as expected w/embedded webview)\r\n* Xamarin Android in MSAL (works as expected w/system browser)","created_at":"2018-04-16T23:04:07Z","updated_at":"2018-04-17T20:58:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"514b59015aceed55abc514aab5b803ad57b81de6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1038/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1038/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1038/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/statuses/2a46f9eb35dc1ff7ff031d7a7347ab1969467b09","head":{"label":"AzureAD:jennyf/coreWebView","ref":"jennyf/coreWebView","sha":"2a46f9eb35dc1ff7ff031d7a7347ab1969467b09","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":19123031,"name":"azure-activedirectory-library-for-dotnet","full_name":"AzureAD/azure-activedirectory-library-for-dotnet","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet","description":null,"fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/deployments","created_at":"2014-04-24T20:29:51Z","updated_at":"2018-04-13T14:26:09Z","pushed_at":"2018-04-17T16:08:28Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-dotnet.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-dotnet.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet","homepage":null,"size":10718,"stargazers_count":171,"watchers_count":171,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":154,"open_issues":37,"watchers":171,"default_branch":"dev"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"130219b656485b4f536be62af1a18c4e123fe09d","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":19123031,"name":"azure-activedirectory-library-for-dotnet","full_name":"AzureAD/azure-activedirectory-library-for-dotnet","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet","description":null,"fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/deployments","created_at":"2014-04-24T20:29:51Z","updated_at":"2018-04-13T14:26:09Z","pushed_at":"2018-04-17T16:08:28Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-dotnet.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-dotnet.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet","homepage":null,"size":10718,"stargazers_count":171,"watchers_count":171,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":154,"open_issues":37,"watchers":171,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1038"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1038"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1038"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1038/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1038/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1038/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/statuses/2a46f9eb35dc1ff7ff031d7a7347ab1969467b09"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jennyf19"}}