{"action":"created","comment":{"url":"https://api.github.com/repos/gsu-library/sirenia/pulls/comments/221991598","pull_request_review_id":160772377,"id":221991598,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTk5MTU5OA==","diff_hunk":"@@ -45,6 +45,8 @@ gem 'hydra-role-management'\n gem 'riiif', '~> 1.1'\n gem 'pdfjs_viewer-rails'\n gem 'pul_uv_rails'\n+gem 'leaflet-rails'\n+gem 'figaro'","path":"Gemfile","position":5,"original_position":5,"commit_id":"68bf98c1de14ece2b72c3cc75bd5ca8ce71bd5dc","original_commit_id":"68bf98c1de14ece2b72c3cc75bd5ca8ce71bd5dc","user":{"login":"boveus","id":20469703,"node_id":"MDQ6VXNlcjIwNDY5NzAz","avatar_url":"https://avatars2.githubusercontent.com/u/20469703?v=4","gravatar_id":"","url":"https://api.github.com/users/boveus","html_url":"https://github.com/boveus","followers_url":"https://api.github.com/users/boveus/followers","following_url":"https://api.github.com/users/boveus/following{/other_user}","gists_url":"https://api.github.com/users/boveus/gists{/gist_id}","starred_url":"https://api.github.com/users/boveus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boveus/subscriptions","organizations_url":"https://api.github.com/users/boveus/orgs","repos_url":"https://api.github.com/users/boveus/repos","events_url":"https://api.github.com/users/boveus/events{/privacy}","received_events_url":"https://api.github.com/users/boveus/received_events","type":"User","site_admin":false},"body":"Are we still using Figaro?  If not, we should probably remove this.","created_at":"2018-10-02T15:09:41Z","updated_at":"2018-10-02T15:37:12Z","html_url":"https://github.com/gsu-library/sirenia/pull/180#discussion_r221991598","pull_request_url":"https://api.github.com/repos/gsu-library/sirenia/pulls/180","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gsu-library/sirenia/pulls/comments/221991598"},"html":{"href":"https://github.com/gsu-library/sirenia/pull/180#discussion_r221991598"},"pull_request":{"href":"https://api.github.com/repos/gsu-library/sirenia/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/gsu-library/sirenia/pulls/180","id":219683579,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NjgzNTc5","html_url":"https://github.com/gsu-library/sirenia/pull/180","diff_url":"https://github.com/gsu-library/sirenia/pull/180.diff","patch_url":"https://github.com/gsu-library/sirenia/pull/180.patch","issue_url":"https://api.github.com/repos/gsu-library/sirenia/issues/180","number":180,"state":"open","locked":false,"title":"Feature/leaflet viewer","user":{"login":"ewilloughby","id":4126936,"node_id":"MDQ6VXNlcjQxMjY5MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4126936?v=4","gravatar_id":"","url":"https://api.github.com/users/ewilloughby","html_url":"https://github.com/ewilloughby","followers_url":"https://api.github.com/users/ewilloughby/followers","following_url":"https://api.github.com/users/ewilloughby/following{/other_user}","gists_url":"https://api.github.com/users/ewilloughby/gists{/gist_id}","starred_url":"https://api.github.com/users/ewilloughby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewilloughby/subscriptions","organizations_url":"https://api.github.com/users/ewilloughby/orgs","repos_url":"https://api.github.com/users/ewilloughby/repos","events_url":"https://api.github.com/users/ewilloughby/events{/privacy}","received_events_url":"https://api.github.com/users/ewilloughby/received_events","type":"User","site_admin":false},"body":"Hey @boveus This PR adds a feature for maps where, if a georeferenced copy of a map in our digital collections exists on our geoserver, an open street maps overlay in leaflet for the georeferenced map is rendered (instead of the uploaded jpeg).   \r\n\r\n In addition to rendering the leaflet viewer for these maps, 4 links are also created that allow for a full screen view, kml & geotiff download, and a WMS URl for use in GIS applications that support remote WMS.  \r\n\r\nThe final feature added in this PR was the addition of URL parameters for the user to save the viewer state of the map and share it with someone else (zoom and latitude/longitude).\r\n\r\nWhile all of the new tests passed locally with both rspec and ci without any issue, I really had to minimize them afterward to get them to pass Travis.  It seems that Travis isn't rendering the map buttons, most likely because the REST api connection and MapViewer entry aren't being made.  I tried adding Travis environment variables with the rest credentials to no avail, I tried travis encrypted environment variables as well.  https://docs.travis-ci.com/user/environment-variables/   \r\n\r\nWe probably need to expand tests for maps in the future, but since this looks like it is going to be harder than I expected, I am submitting this PR and adding the expansion of tests for maps to the backlog.","created_at":"2018-10-02T12:21:57Z","updated_at":"2018-10-02T15:37:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"022c2a756d4147cd1dff4dc5b60a5c4a95726da5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gsu-library/sirenia/pulls/180/commits","review_comments_url":"https://api.github.com/repos/gsu-library/sirenia/pulls/180/comments","review_comment_url":"https://api.github.com/repos/gsu-library/sirenia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gsu-library/sirenia/issues/180/comments","statuses_url":"https://api.github.com/repos/gsu-library/sirenia/statuses/68bf98c1de14ece2b72c3cc75bd5ca8ce71bd5dc","head":{"label":"gsu-library:feature/leaflet-viewer","ref":"feature/leaflet-viewer","sha":"68bf98c1de14ece2b72c3cc75bd5ca8ce71bd5dc","user":{"login":"gsu-library","id":38862339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODYyMzM5","avatar_url":"https://avatars0.githubusercontent.com/u/38862339?v=4","gravatar_id":"","url":"https://api.github.com/users/gsu-library","html_url":"https://github.com/gsu-library","followers_url":"https://api.github.com/users/gsu-library/followers","following_url":"https://api.github.com/users/gsu-library/following{/other_user}","gists_url":"https://api.github.com/users/gsu-library/gists{/gist_id}","starred_url":"https://api.github.com/users/gsu-library/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsu-library/subscriptions","organizations_url":"https://api.github.com/users/gsu-library/orgs","repos_url":"https://api.github.com/users/gsu-library/repos","events_url":"https://api.github.com/users/gsu-library/events{/privacy}","received_events_url":"https://api.github.com/users/gsu-library/received_events","type":"Organization","site_admin":false},"repo":{"id":131891085,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4OTEwODU=","name":"sirenia","full_name":"gsu-library/sirenia","private":false,"owner":{"login":"gsu-library","id":38862339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODYyMzM5","avatar_url":"https://avatars0.githubusercontent.com/u/38862339?v=4","gravatar_id":"","url":"https://api.github.com/users/gsu-library","html_url":"https://github.com/gsu-library","followers_url":"https://api.github.com/users/gsu-library/followers","following_url":"https://api.github.com/users/gsu-library/following{/other_user}","gists_url":"https://api.github.com/users/gsu-library/gists{/gist_id}","starred_url":"https://api.github.com/users/gsu-library/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsu-library/subscriptions","organizations_url":"https://api.github.com/users/gsu-library/orgs","repos_url":"https://api.github.com/users/gsu-library/repos","events_url":"https://api.github.com/users/gsu-library/events{/privacy}","received_events_url":"https://api.github.com/users/gsu-library/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gsu-library/sirenia","description":"A Hyrax-based application to provide a Digital Asset Management system for the Georgia State University Library","fork":false,"url":"https://api.github.com/repos/gsu-library/sirenia","forks_url":"https://api.github.com/repos/gsu-library/sirenia/forks","keys_url":"https://api.github.com/repos/gsu-library/sirenia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsu-library/sirenia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsu-library/sirenia/teams","hooks_url":"https://api.github.com/repos/gsu-library/sirenia/hooks","issue_events_url":"https://api.github.com/repos/gsu-library/sirenia/issues/events{/number}","events_url":"https://api.github.com/repos/gsu-library/sirenia/events","assignees_url":"https://api.github.com/repos/gsu-library/sirenia/assignees{/user}","branches_url":"https://api.github.com/repos/gsu-library/sirenia/branches{/branch}","tags_url":"https://api.github.com/repos/gsu-library/sirenia/tags","blobs_url":"https://api.github.com/repos/gsu-library/sirenia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsu-library/sirenia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsu-library/sirenia/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsu-library/sirenia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsu-library/sirenia/statuses/{sha}","languages_url":"https://api.github.com/repos/gsu-library/sirenia/languages","stargazers_url":"https://api.github.com/repos/gsu-library/sirenia/stargazers","contributors_url":"https://api.github.com/repos/gsu-library/sirenia/contributors","subscribers_url":"https://api.github.com/repos/gsu-library/sirenia/subscribers","subscription_url":"https://api.github.com/repos/gsu-library/sirenia/subscription","commits_url":"https://api.github.com/repos/gsu-library/sirenia/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsu-library/sirenia/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsu-library/sirenia/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsu-library/sirenia/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsu-library/sirenia/contents/{+path}","compare_url":"https://api.github.com/repos/gsu-library/sirenia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsu-library/sirenia/merges","archive_url":"https://api.github.com/repos/gsu-library/sirenia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsu-library/sirenia/downloads","issues_url":"https://api.github.com/repos/gsu-library/sirenia/issues{/number}","pulls_url":"https://api.github.com/repos/gsu-library/sirenia/pulls{/number}","milestones_url":"https://api.github.com/repos/gsu-library/sirenia/milestones{/number}","notifications_url":"https://api.github.com/repos/gsu-library/sirenia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsu-library/sirenia/labels{/name}","releases_url":"https://api.github.com/repos/gsu-library/sirenia/releases{/id}","deployments_url":"https://api.github.com/repos/gsu-library/sirenia/deployments","created_at":"2018-05-02T18:31:00Z","updated_at":"2018-10-02T12:10:02Z","pushed_at":"2018-10-02T13:00:35Z","git_url":"git://github.com/gsu-library/sirenia.git","ssh_url":"git@github.com:gsu-library/sirenia.git","clone_url":"https://github.com/gsu-library/sirenia.git","svn_url":"https://github.com/gsu-library/sirenia","homepage":"","size":278212,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":0,"open_issues":14,"watchers":5,"default_branch":"develop"}},"base":{"label":"gsu-library:develop","ref":"develop","sha":"ceb7344b1bb7081ab8baa3588bfb324d491cabd3","user":{"login":"gsu-library","id":38862339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODYyMzM5","avatar_url":"https://avatars0.githubusercontent.com/u/38862339?v=4","gravatar_id":"","url":"https://api.github.com/users/gsu-library","html_url":"https://github.com/gsu-library","followers_url":"https://api.github.com/users/gsu-library/followers","following_url":"https://api.github.com/users/gsu-library/following{/other_user}","gists_url":"https://api.github.com/users/gsu-library/gists{/gist_id}","starred_url":"https://api.github.com/users/gsu-library/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsu-library/subscriptions","organizations_url":"https://api.github.com/users/gsu-library/orgs","repos_url":"https://api.github.com/users/gsu-library/repos","events_url":"https://api.github.com/users/gsu-library/events{/privacy}","received_events_url":"https://api.github.com/users/gsu-library/received_events","type":"Organization","site_admin":false},"repo":{"id":131891085,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4OTEwODU=","name":"sirenia","full_name":"gsu-library/sirenia","private":false,"owner":{"login":"gsu-library","id":38862339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODYyMzM5","avatar_url":"https://avatars0.githubusercontent.com/u/38862339?v=4","gravatar_id":"","url":"https://api.github.com/users/gsu-library","html_url":"https://github.com/gsu-library","followers_url":"https://api.github.com/users/gsu-library/followers","following_url":"https://api.github.com/users/gsu-library/following{/other_user}","gists_url":"https://api.github.com/users/gsu-library/gists{/gist_id}","starred_url":"https://api.github.com/users/gsu-library/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsu-library/subscriptions","organizations_url":"https://api.github.com/users/gsu-library/orgs","repos_url":"https://api.github.com/users/gsu-library/repos","events_url":"https://api.github.com/users/gsu-library/events{/privacy}","received_events_url":"https://api.github.com/users/gsu-library/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gsu-library/sirenia","description":"A Hyrax-based application to provide a Digital Asset Management system for the Georgia State University Library","fork":false,"url":"https://api.github.com/repos/gsu-library/sirenia","forks_url":"https://api.github.com/repos/gsu-library/sirenia/forks","keys_url":"https://api.github.com/repos/gsu-library/sirenia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsu-library/sirenia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsu-library/sirenia/teams","hooks_url":"https://api.github.com/repos/gsu-library/sirenia/hooks","issue_events_url":"https://api.github.com/repos/gsu-library/sirenia/issues/events{/number}","events_url":"https://api.github.com/repos/gsu-library/sirenia/events","assignees_url":"https://api.github.com/repos/gsu-library/sirenia/assignees{/user}","branches_url":"https://api.github.com/repos/gsu-library/sirenia/branches{/branch}","tags_url":"https://api.github.com/repos/gsu-library/sirenia/tags","blobs_url":"https://api.github.com/repos/gsu-library/sirenia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsu-library/sirenia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsu-library/sirenia/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsu-library/sirenia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsu-library/sirenia/statuses/{sha}","languages_url":"https://api.github.com/repos/gsu-library/sirenia/languages","stargazers_url":"https://api.github.com/repos/gsu-library/sirenia/stargazers","contributors_url":"https://api.github.com/repos/gsu-library/sirenia/contributors","subscribers_url":"https://api.github.com/repos/gsu-library/sirenia/subscribers","subscription_url":"https://api.github.com/repos/gsu-library/sirenia/subscription","commits_url":"https://api.github.com/repos/gsu-library/sirenia/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsu-library/sirenia/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsu-library/sirenia/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsu-library/sirenia/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsu-library/sirenia/contents/{+path}","compare_url":"https://api.github.com/repos/gsu-library/sirenia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsu-library/sirenia/merges","archive_url":"https://api.github.com/repos/gsu-library/sirenia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsu-library/sirenia/downloads","issues_url":"https://api.github.com/repos/gsu-library/sirenia/issues{/number}","pulls_url":"https://api.github.com/repos/gsu-library/sirenia/pulls{/number}","milestones_url":"https://api.github.com/repos/gsu-library/sirenia/milestones{/number}","notifications_url":"https://api.github.com/repos/gsu-library/sirenia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsu-library/sirenia/labels{/name}","releases_url":"https://api.github.com/repos/gsu-library/sirenia/releases{/id}","deployments_url":"https://api.github.com/repos/gsu-library/sirenia/deployments","created_at":"2018-05-02T18:31:00Z","updated_at":"2018-10-02T12:10:02Z","pushed_at":"2018-10-02T13:00:35Z","git_url":"git://github.com/gsu-library/sirenia.git","ssh_url":"git@github.com:gsu-library/sirenia.git","clone_url":"https://github.com/gsu-library/sirenia.git","svn_url":"https://github.com/gsu-library/sirenia","homepage":"","size":278212,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":0,"open_issues":14,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gsu-library/sirenia/pulls/180"},"html":{"href":"https://github.com/gsu-library/sirenia/pull/180"},"issue":{"href":"https://api.github.com/repos/gsu-library/sirenia/issues/180"},"comments":{"href":"https://api.github.com/repos/gsu-library/sirenia/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/gsu-library/sirenia/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/gsu-library/sirenia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gsu-library/sirenia/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/gsu-library/sirenia/statuses/68bf98c1de14ece2b72c3cc75bd5ca8ce71bd5dc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"boveus"}}