{"action":"created","issue":{"url":"https://api.github.com/repos/dani-garcia/bitwarden_rs/issues/221","repository_url":"https://api.github.com/repos/dani-garcia/bitwarden_rs","labels_url":"https://api.github.com/repos/dani-garcia/bitwarden_rs/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/dani-garcia/bitwarden_rs/issues/221/comments","events_url":"https://api.github.com/repos/dani-garcia/bitwarden_rs/issues/221/events","html_url":"https://github.com/dani-garcia/bitwarden_rs/pull/221","id":369951222,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzQ3OTk4","number":221,"title":"Disable WebSockets negotiation by default","user":{"login":"mprasil","id":8255364,"node_id":"MDQ6VXNlcjgyNTUzNjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8255364?v=4","gravatar_id":"","url":"https://api.github.com/users/mprasil","html_url":"https://github.com/mprasil","followers_url":"https://api.github.com/users/mprasil/followers","following_url":"https://api.github.com/users/mprasil/following{/other_user}","gists_url":"https://api.github.com/users/mprasil/gists{/gist_id}","starred_url":"https://api.github.com/users/mprasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprasil/subscriptions","organizations_url":"https://api.github.com/users/mprasil/orgs","repos_url":"https://api.github.com/users/mprasil/repos","events_url":"https://api.github.com/users/mprasil/events{/privacy}","received_events_url":"https://api.github.com/users/mprasil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-14T22:33:14Z","updated_at":"2018-10-15T14:09:02Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/dani-garcia/bitwarden_rs/pulls/221","html_url":"https://github.com/dani-garcia/bitwarden_rs/pull/221","diff_url":"https://github.com/dani-garcia/bitwarden_rs/pull/221.diff","patch_url":"https://github.com/dani-garcia/bitwarden_rs/pull/221.patch"},"body":"This let's users enable WebSockets by setting the `WEBSOCKET_ENABLED` variable to `true`. The reason why I suggest to have this off by default is that for users that won't do that extra proxy configuration this causes issues like the one observed in #203 - essentially breaking the organization functionality in unpredictable way. \r\n\r\nUsers using WebSockets need to do some extra configuration anyways and while this change will break their configuration, it will not break the core functionality, just the WebSockets won't be used until they turn it back on."},"comment":{"url":"https://api.github.com/repos/dani-garcia/bitwarden_rs/issues/comments/429866994","html_url":"https://github.com/dani-garcia/bitwarden_rs/pull/221#issuecomment-429866994","issue_url":"https://api.github.com/repos/dani-garcia/bitwarden_rs/issues/221","id":429866994,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTg2Njk5NA==","user":{"login":"mprasil","id":8255364,"node_id":"MDQ6VXNlcjgyNTUzNjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8255364?v=4","gravatar_id":"","url":"https://api.github.com/users/mprasil","html_url":"https://github.com/mprasil","followers_url":"https://api.github.com/users/mprasil/followers","following_url":"https://api.github.com/users/mprasil/following{/other_user}","gists_url":"https://api.github.com/users/mprasil/gists{/gist_id}","starred_url":"https://api.github.com/users/mprasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprasil/subscriptions","organizations_url":"https://api.github.com/users/mprasil/orgs","repos_url":"https://api.github.com/users/mprasil/repos","events_url":"https://api.github.com/users/mprasil/events{/privacy}","received_events_url":"https://api.github.com/users/mprasil/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T14:09:02Z","updated_at":"2018-10-15T14:09:02Z","author_association":"COLLABORATOR","body":"Good idea! I've added that there."}}
{"actor":{"display_login":"mprasil"}}