{"action":"closed","number":1213,"pull_request":{"url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/pulls/1213","id":165722964,"html_url":"https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1213","diff_url":"https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1213.diff","patch_url":"https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1213.patch","issue_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/issues/1213","number":1213,"state":"closed","locked":false,"title":"Execution dependency extension","user":{"login":"benelot","id":3111851,"avatar_url":"https://avatars1.githubusercontent.com/u/3111851?v=4","gravatar_id":"","url":"https://api.github.com/users/benelot","html_url":"https://github.com/benelot","followers_url":"https://api.github.com/users/benelot/followers","following_url":"https://api.github.com/users/benelot/following{/other_user}","gists_url":"https://api.github.com/users/benelot/gists{/gist_id}","starred_url":"https://api.github.com/users/benelot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benelot/subscriptions","organizations_url":"https://api.github.com/users/benelot/orgs","repos_url":"https://api.github.com/users/benelot/repos","events_url":"https://api.github.com/users/benelot/events{/privacy}","received_events_url":"https://api.github.com/users/benelot/received_events","type":"User","site_admin":false},"body":"I am implementing the extension for custom execution dependencies as discussed in #1193. It seems to work and properly resolves the dependency tree (it even handles circular deps in a simple way). However, in the end it collects all cells in the order found by the topological sort and tries to run them, but then the java script crashes/and the script starts to run anew.\r\n\r\nDISCLAIMER: I have limited experience with JavaScript, so there might be quirky stuff done in code which I comes from my experience as a Java developer. But the problem does not seem to be in that part, but seems to be somewhere else.\r\n\r\nAny idea what is wrong? Second question I have is if there is a neat way I can tell the user that a circular dependency is preventing the dependencies to run. For now it just prints to the console.\r\n\r\nTo test it, simply create two python cells and add a #A tag to the first and a =>A tag to the second. The run the second and look into the developer console. There you can see that it restarts the script after it prints \"Execute cells..\"","created_at":"2018-01-29T14:44:07Z","updated_at":"2018-02-03T17:24:23Z","closed_at":"2018-02-03T17:24:23Z","merged_at":"2018-02-03T17:24:23Z","merge_commit_sha":"a698bbfd675674b8b18654848dd2d7ab01cb0bbf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/pulls/1213/commits","review_comments_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/pulls/1213/comments","review_comment_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/issues/1213/comments","statuses_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/statuses/0adfb29878a7a877da299d3807c94e1bdc902aaa","head":{"label":"benelot:execution_dependencies","ref":"execution_dependencies","sha":"0adfb29878a7a877da299d3807c94e1bdc902aaa","user":{"login":"benelot","id":3111851,"avatar_url":"https://avatars1.githubusercontent.com/u/3111851?v=4","gravatar_id":"","url":"https://api.github.com/users/benelot","html_url":"https://github.com/benelot","followers_url":"https://api.github.com/users/benelot/followers","following_url":"https://api.github.com/users/benelot/following{/other_user}","gists_url":"https://api.github.com/users/benelot/gists{/gist_id}","starred_url":"https://api.github.com/users/benelot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benelot/subscriptions","organizations_url":"https://api.github.com/users/benelot/orgs","repos_url":"https://api.github.com/users/benelot/repos","events_url":"https://api.github.com/users/benelot/events{/privacy}","received_events_url":"https://api.github.com/users/benelot/received_events","type":"User","site_admin":false},"repo":{"id":119261751,"name":"jupyter_contrib_nbextensions","full_name":"benelot/jupyter_contrib_nbextensions","owner":{"login":"benelot","id":3111851,"avatar_url":"https://avatars1.githubusercontent.com/u/3111851?v=4","gravatar_id":"","url":"https://api.github.com/users/benelot","html_url":"https://github.com/benelot","followers_url":"https://api.github.com/users/benelot/followers","following_url":"https://api.github.com/users/benelot/following{/other_user}","gists_url":"https://api.github.com/users/benelot/gists{/gist_id}","starred_url":"https://api.github.com/users/benelot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benelot/subscriptions","organizations_url":"https://api.github.com/users/benelot/orgs","repos_url":"https://api.github.com/users/benelot/repos","events_url":"https://api.github.com/users/benelot/events{/privacy}","received_events_url":"https://api.github.com/users/benelot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benelot/jupyter_contrib_nbextensions","description":"A collection of various notebook extensions for Jupyter","fork":true,"url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions","forks_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/forks","keys_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/teams","hooks_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/hooks","issue_events_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/issues/events{/number}","events_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/events","assignees_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/assignees{/user}","branches_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/branches{/branch}","tags_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/tags","blobs_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/statuses/{sha}","languages_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/languages","stargazers_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/stargazers","contributors_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/contributors","subscribers_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/subscribers","subscription_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/subscription","commits_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/contents/{+path}","compare_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/merges","archive_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/downloads","issues_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/issues{/number}","pulls_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/pulls{/number}","milestones_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/milestones{/number}","notifications_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/labels{/name}","releases_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/releases{/id}","deployments_url":"https://api.github.com/repos/benelot/jupyter_contrib_nbextensions/deployments","created_at":"2018-01-28T13:41:53Z","updated_at":"2018-01-28T13:41:56Z","pushed_at":"2018-02-03T12:36:13Z","git_url":"git://github.com/benelot/jupyter_contrib_nbextensions.git","ssh_url":"git@github.com:benelot/jupyter_contrib_nbextensions.git","clone_url":"https://github.com/benelot/jupyter_contrib_nbextensions.git","svn_url":"https://github.com/benelot/jupyter_contrib_nbextensions","homepage":"http://jupyter-contrib-nbextensions.readthedocs.io/en/latest","size":40459,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ipython-contrib:master","ref":"master","sha":"a4544eca1182db2816523959002b5a31c263e267","user":{"login":"ipython-contrib","id":3129808,"avatar_url":"https://avatars3.githubusercontent.com/u/3129808?v=4","gravatar_id":"","url":"https://api.github.com/users/ipython-contrib","html_url":"https://github.com/ipython-contrib","followers_url":"https://api.github.com/users/ipython-contrib/followers","following_url":"https://api.github.com/users/ipython-contrib/following{/other_user}","gists_url":"https://api.github.com/users/ipython-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/ipython-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipython-contrib/subscriptions","organizations_url":"https://api.github.com/users/ipython-contrib/orgs","repos_url":"https://api.github.com/users/ipython-contrib/repos","events_url":"https://api.github.com/users/ipython-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/ipython-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":11391151,"name":"jupyter_contrib_nbextensions","full_name":"ipython-contrib/jupyter_contrib_nbextensions","owner":{"login":"ipython-contrib","id":3129808,"avatar_url":"https://avatars3.githubusercontent.com/u/3129808?v=4","gravatar_id":"","url":"https://api.github.com/users/ipython-contrib","html_url":"https://github.com/ipython-contrib","followers_url":"https://api.github.com/users/ipython-contrib/followers","following_url":"https://api.github.com/users/ipython-contrib/following{/other_user}","gists_url":"https://api.github.com/users/ipython-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/ipython-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipython-contrib/subscriptions","organizations_url":"https://api.github.com/users/ipython-contrib/orgs","repos_url":"https://api.github.com/users/ipython-contrib/repos","events_url":"https://api.github.com/users/ipython-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/ipython-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipython-contrib/jupyter_contrib_nbextensions","description":"A collection of various notebook extensions for Jupyter","fork":false,"url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions","forks_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/forks","keys_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/teams","hooks_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/hooks","issue_events_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/issues/events{/number}","events_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/events","assignees_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/assignees{/user}","branches_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/branches{/branch}","tags_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/tags","blobs_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/statuses/{sha}","languages_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/languages","stargazers_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/stargazers","contributors_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/contributors","subscribers_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/subscribers","subscription_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/subscription","commits_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/contents/{+path}","compare_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/merges","archive_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/downloads","issues_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/issues{/number}","pulls_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/pulls{/number}","milestones_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/milestones{/number}","notifications_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/labels{/name}","releases_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/releases{/id}","deployments_url":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/deployments","created_at":"2013-07-13T17:05:16Z","updated_at":"2018-02-03T16:49:36Z","pushed_at":"2018-02-03T17:24:23Z","git_url":"git://github.com/ipython-contrib/jupyter_contrib_nbextensions.git","ssh_url":"git@github.com:ipython-contrib/jupyter_contrib_nbextensions.git","clone_url":"https://github.com/ipython-contrib/jupyter_contrib_nbextensions.git","svn_url":"https://github.com/ipython-contrib/jupyter_contrib_nbextensions","homepage":"http://jupyter-contrib-nbextensions.readthedocs.io/en/latest","size":40470,"stargazers_count":1952,"watchers_count":1952,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":383,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":383,"open_issues":111,"watchers":1952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/pulls/1213"},"html":{"href":"https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1213"},"issue":{"href":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/issues/1213"},"comments":{"href":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/issues/1213/comments"},"review_comments":{"href":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/pulls/1213/comments"},"review_comment":{"href":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/pulls/1213/commits"},"statuses":{"href":"https://api.github.com/repos/ipython-contrib/jupyter_contrib_nbextensions/statuses/0adfb29878a7a877da299d3807c94e1bdc902aaa"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jcb91","id":5630710,"avatar_url":"https://avatars0.githubusercontent.com/u/5630710?v=4","gravatar_id":"","url":"https://api.github.com/users/jcb91","html_url":"https://github.com/jcb91","followers_url":"https://api.github.com/users/jcb91/followers","following_url":"https://api.github.com/users/jcb91/following{/other_user}","gists_url":"https://api.github.com/users/jcb91/gists{/gist_id}","starred_url":"https://api.github.com/users/jcb91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcb91/subscriptions","organizations_url":"https://api.github.com/users/jcb91/orgs","repos_url":"https://api.github.com/users/jcb91/repos","events_url":"https://api.github.com/users/jcb91/events{/privacy}","received_events_url":"https://api.github.com/users/jcb91/received_events","type":"User","site_admin":false},"comments":9,"review_comments":23,"maintainer_can_modify":false,"commits":3,"additions":194,"deletions":0,"changed_files":4}}
{"actor":{"display_login":"jcb91"}}